- Devel - libvirt List Archives

[libvirt] [PATCH v4 00/25] Fix and enable owner remembering
by Michal Privoznik 09 Jul '19

09 Jul '19

This is meant for next release to have the most time possible for testing. Some of the patches were ACKed in v3 already but since they don't make sense on their own I haven't pushed them. v4 of: https://www.redhat.com/archives/libvir-list/2019-March/msg01948.html As usual, you can find (not only these) patches on my github: https://github.com/zippy2/libvirt branch xattr_fixes_v4 diff to v3: - Some new patches (qemusecuritytest and qemusecuritymock) - Some other fixes raised by Cole in review of v3 (like double error reporting and others) - Remembering is done only for paths that cannot be shared between domains. This renders refcounting needless because the refcounter can't ever be greater than one. Nevertheless, I'm keeping it in because in the long run I might come up with a solution to the problem of shared resources and having refcounters might help. Michal Prívozník (25): qemusecuritymock: Mock virProcessRunInFork qemusecuritymock: Fix bit arithmetic qemusecuritymock: Actually set error on failure qemusecuritymock: Introduce and use freePaths() qemusecuritytest: Drop unused variable qemusecuritytest: Use AUTOFREE/AUTOUNREF qemusecuritytest: Fix capabilities loading tools: Slightly rework libvirt_recover_xattrs.sh virSecuritySELinuxRestoreAllLabel: Print @migrated in the debug message too virfile: Make virFileGetXAttr report errors virFileSetXAttr: Report error on failure virFileRemoveXAttr: Report error on failure security: Don't skip label restore on file systems lacking XATTRs security: Document @restore member of transaction list security_dac: Allow caller to suppress owner remembering security_selinux: Allow caller to suppress owner remembering qemusecuritymock: Allow some paths to be not restored security: Don't remember owner for shared resources security: Introduce virSecurityManagerMoveImageMetadata security_util: Introduce virSecurityMoveRememberedLabel security_dac: Implement virSecurityManagerMoveImageMetadata security_selinux: Implement virSecurityManagerMoveImageMetadata qemu_security: Implement qemuSecurityMoveImageMetadata qemu: Move image security metadata on snapshot activity Revert "qemu: Temporary disable owner remembering" docs/news.xml | 13 ++ src/libvirt_private.syms | 2 + src/qemu/libvirtd_qemu.aug | 1 + src/qemu/qemu.conf | 5 + src/qemu/qemu_blockjob.c | 6 + src/qemu/qemu_conf.c | 4 + src/qemu/qemu_driver.c | 17 +- src/qemu/qemu_security.c | 19 +++ src/qemu/qemu_security.h | 5 + src/qemu/test_libvirtd_qemu.aug.in | 1 + src/security/security_dac.c | 171 +++++++++++++++---- src/security/security_driver.h | 5 + src/security/security_manager.c | 39 +++++ src/security/security_manager.h | 4 + src/security/security_nop.c | 10 ++ src/security/security_selinux.c | 263 ++++++++++++++++++++--------- src/security/security_stack.c | 20 +++ src/security/security_util.c | 73 +++++++- src/security/security_util.h | 5 + src/util/virfile.c | 78 +++++++-- src/util/virfile.h | 5 + src/util/virprocess.h | 3 +- tests/qemusecuritymock.c | 76 +++++++-- tests/qemusecuritytest.c | 146 ++++++++++------ tests/qemusecuritytest.h | 4 +- tools/libvirt_recover_xattrs.sh | 50 +++--- 26 files changed, 802 insertions(+), 223 deletions(-) -- 2.21.0

4 64

[libvirt] [PATCH Rust v2 1/6] ci workaround when running integration tests
by Sahid Orentino Ferdjaoui 09 Jul '19

09 Jul '19

Due to an issue fixed in libvirt master we should not consider running integration tests in parallel. https://www.redhat.com/archives/libvir-list/2019-July/msg00287.html Signed-off-by: Sahid Orentino Ferdjaoui <sahid.ferdjaoui(a)canonical.com> --- .travis.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index c52f745..54f3c24 100644 --- a/.travis.yml +++ b/.travis.yml @@ -41,4 +41,7 @@ install: script: - cargo test --verbose - - cargo test --verbose -- --ignored + # Due to an issue fixed in master we should not consider running + # integration tests in parallel. + # see: https://www.redhat.com/archives/libvir-list/2019-July/msg00287.html + - cargo test --verbose -- --ignored --test-threads=1 -- 2.17.1

2 11

[libvirt] [PATCH] po: Drop src/xenconfig/xen_sxpr.c from POTFILES
by Peter Krempa 09 Jul '19

09 Jul '19

Commit 2f1c909991291b40 forgot this change. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- Pushed under the build-breaker rule. po/POTFILES | 1 - 1 file changed, 1 deletion(-) diff --git a/po/POTFILES b/po/POTFILES index 23f24ed76f..ab582ffbe9 100644 --- a/po/POTFILES +++ b/po/POTFILES @@ -290,7 +290,6 @@ src/vz/vz_utils.h src/xenapi/xenapi_driver.c src/xenapi/xenapi_utils.c src/xenconfig/xen_common.c -src/xenconfig/xen_sxpr.c src/xenconfig/xen_xl.c src/xenconfig/xen_xm.c tests/virpolkittest.c -- 2.21.0

1 0

[libvirt] [jenkins-ci PATCH 0/5] guests: Add Debian 10
by Andrea Bolognani 09 Jul '19

09 Jul '19

It was released, like, two full days ago! Let's get with the times already! :P Note that the libvirt-check job currently fails on Debian 10, but I have already posted a libvirt patch[1] addressing that issue. [1] https://www.redhat.com/archives/libvir-list/2019-July/msg00318.html Andrea Bolognani (5): guests: Update mappings for perl-Digest guests: Update mappings for sheepdog guests: Add Debian 10 guests: Build on Debian 10 jenkins: Build on Debian 10 guests/host_vars/libvirt-debian-10/docker.yml | 2 + .../host_vars/libvirt-debian-10/install.yml | 2 + guests/host_vars/libvirt-debian-10/main.yml | 24 ++++++ guests/inventory | 1 + guests/playbooks/build/jobs/defaults.yml | 1 + .../playbooks/build/projects/libvirt-dbus.yml | 3 + .../build/projects/libvirt-go-xml.yml | 1 + .../playbooks/build/projects/libvirt-go.yml | 1 + .../build/projects/libvirt-ocaml.yml | 1 + .../build/projects/libvirt-sandbox.yml | 1 + .../playbooks/build/projects/libvirt-tck.yml | 1 + guests/playbooks/build/projects/libvirt.yml | 1 + .../build/projects/osinfo-db-tools.yml | 1 + guests/playbooks/build/projects/osinfo-db.yml | 1 + .../playbooks/build/projects/virt-manager.yml | 2 + guests/vars/mappings.yml | 7 +- guests/vars/vault.yml | 78 ++++++++++--------- jenkins/jobs/defaults.yaml | 1 + jenkins/projects/libvirt-dbus.yaml | 3 + jenkins/projects/libvirt-go-xml.yaml | 1 + jenkins/projects/libvirt-go.yaml | 1 + jenkins/projects/libvirt-ocaml.yaml | 1 + jenkins/projects/libvirt-sandbox.yaml | 1 + jenkins/projects/libvirt-tck.yaml | 1 + jenkins/projects/libvirt.yaml | 1 + jenkins/projects/osinfo-db-tools.yaml | 1 + jenkins/projects/osinfo-db.yaml | 1 + jenkins/projects/virt-manager.yaml | 2 + 28 files changed, 102 insertions(+), 40 deletions(-) create mode 100644 guests/host_vars/libvirt-debian-10/docker.yml create mode 100644 guests/host_vars/libvirt-debian-10/install.yml create mode 100644 guests/host_vars/libvirt-debian-10/main.yml -- 2.21.0

2 12

[libvirt] [PATCH 00/14] xen: Remove sexpr parsing and formatting support
by Peter Krempa 09 Jul '19

09 Jul '19

The formatter support was unused from the time we dropped xend support. Let's drop the formatter too along with all the unused code. Peter Krempa (14): tests: Remove xml2sexprtest xenconfig: Drop sxpr formatter xenconfig: Move guts of xenFormatSxprSound into xenFormatSound xen: Move xenFormatSxprChr to xen_common libxl: Drop support for parsing sxpr format in libxlConnectDomainXMLFromNative tests: Drop sexpr2xmltest xenconfig: Drop unused sexpr parsing infrastructure xenconfig: Remove pointless label in xenParseSxprSound xen: Inline xenParseSxprSound into the only caller xen: Move xenParseSxprVifRate to xen_common xen: Move xenParseSxprChar to xen_common xen: drop xen_sxpr.(c|h) util: Drop virsexpr module news: Mention drop of xen sxpr support docs/drvxen.html.in | 3 +- docs/news.xml | 11 + po/POTFILES | 1 - src/libvirt_private.syms | 18 - src/libvirt_xenconfig.syms | 15 - src/libxl/libxl_driver.c | 14 +- src/util/Makefile.inc.am | 2 - src/util/virsexpr.c | 608 ---- src/util/virsexpr.h | 66 - src/xenconfig/Makefile.inc.am | 2 - src/xenconfig/xen_common.c | 390 ++- src/xenconfig/xen_sxpr.c | 2486 ----------------- src/xenconfig/xen_sxpr.h | 66 - src/xenconfig/xenxs_private.h | 1 - tests/Makefile.am | 16 +- tests/sexpr2xmldata/sexpr2xml-boot-grub.sexpr | 6 - tests/sexpr2xmldata/sexpr2xml-boot-grub.xml | 30 - .../sexpr2xml-bridge-ipaddr.sexpr | 10 - .../sexpr2xmldata/sexpr2xml-bridge-ipaddr.xml | 38 - tests/sexpr2xmldata/sexpr2xml-curmem.sexpr | 50 - tests/sexpr2xmldata/sexpr2xml-curmem.xml | 44 - .../sexpr2xml-disk-block-shareable.sexpr | 6 - .../sexpr2xml-disk-block-shareable.xml | 36 - .../sexpr2xmldata/sexpr2xml-disk-block.sexpr | 8 - tests/sexpr2xmldata/sexpr2xml-disk-block.xml | 31 - .../sexpr2xml-disk-drv-blktap-qcow.sexpr | 8 - .../sexpr2xml-disk-drv-blktap-qcow.xml | 31 - .../sexpr2xml-disk-drv-blktap-raw.sexpr | 8 - .../sexpr2xml-disk-drv-blktap-raw.xml | 31 - .../sexpr2xml-disk-drv-blktap2-raw.sexpr | 8 - .../sexpr2xml-disk-drv-blktap2-raw.xml | 31 - tests/sexpr2xmldata/sexpr2xml-disk-file.sexpr | 8 - tests/sexpr2xmldata/sexpr2xml-disk-file.xml | 31 - .../sexpr2xmldata/sexpr2xml-fv-autoport.sexpr | 86 - tests/sexpr2xmldata/sexpr2xml-fv-autoport.xml | 59 - .../sexpr2xml-fv-empty-kernel.sexpr | 11 - .../sexpr2xml-fv-empty-kernel.xml | 52 - .../sexpr2xml-fv-force-hpet.sexpr | 11 - .../sexpr2xmldata/sexpr2xml-fv-force-hpet.xml | 55 - .../sexpr2xml-fv-force-nohpet.sexpr | 11 - .../sexpr2xml-fv-force-nohpet.xml | 55 - tests/sexpr2xmldata/sexpr2xml-fv-kernel.sexpr | 9 - tests/sexpr2xmldata/sexpr2xml-fv-kernel.xml | 36 - .../sexpr2xml-fv-legacy-vfb.sexpr | 70 - .../sexpr2xmldata/sexpr2xml-fv-legacy-vfb.xml | 37 - .../sexpr2xml-fv-localtime.sexpr | 10 - .../sexpr2xmldata/sexpr2xml-fv-localtime.xml | 52 - .../sexpr2xml-fv-net-netfront.sexpr | 11 - .../sexpr2xml-fv-net-netfront.xml | 53 - .../sexpr2xml-fv-parallel-tcp.sexpr | 10 - .../sexpr2xml-fv-parallel-tcp.xml | 57 - .../sexpr2xml-fv-serial-dev-2-ports.sexpr | 12 - .../sexpr2xml-fv-serial-dev-2-ports.xml | 64 - .../sexpr2xml-fv-serial-dev-2nd-port.sexpr | 11 - .../sexpr2xml-fv-serial-dev-2nd-port.xml | 60 - .../sexpr2xml-fv-serial-file.sexpr | 12 - .../sexpr2xml-fv-serial-file.xml | 60 - .../sexpr2xml-fv-serial-null.sexpr | 10 - .../sexpr2xml-fv-serial-null.xml | 58 - .../sexpr2xml-fv-serial-pipe.sexpr | 12 - .../sexpr2xml-fv-serial-pipe.xml | 60 - .../sexpr2xml-fv-serial-pty.sexpr | 11 - .../sexpr2xmldata/sexpr2xml-fv-serial-pty.xml | 58 - .../sexpr2xml-fv-serial-stdio.sexpr | 10 - .../sexpr2xml-fv-serial-stdio.xml | 58 - .../sexpr2xml-fv-serial-tcp-telnet.sexpr | 11 - .../sexpr2xml-fv-serial-tcp-telnet.xml | 62 - .../sexpr2xml-fv-serial-tcp.sexpr | 11 - .../sexpr2xmldata/sexpr2xml-fv-serial-tcp.xml | 62 - .../sexpr2xml-fv-serial-udp.sexpr | 11 - .../sexpr2xmldata/sexpr2xml-fv-serial-udp.xml | 62 - .../sexpr2xml-fv-serial-unix.sexpr | 11 - .../sexpr2xml-fv-serial-unix.xml | 60 - .../sexpr2xml-fv-sound-all.sexpr | 11 - .../sexpr2xmldata/sexpr2xml-fv-sound-all.xml | 54 - tests/sexpr2xmldata/sexpr2xml-fv-sound.sexpr | 10 - tests/sexpr2xmldata/sexpr2xml-fv-sound.xml | 54 - .../sexpr2xmldata/sexpr2xml-fv-usbmouse.sexpr | 10 - tests/sexpr2xmldata/sexpr2xml-fv-usbmouse.xml | 53 - .../sexpr2xml-fv-usbtablet.sexpr | 10 - .../sexpr2xmldata/sexpr2xml-fv-usbtablet.xml | 53 - tests/sexpr2xmldata/sexpr2xml-fv-utc.sexpr | 11 - tests/sexpr2xmldata/sexpr2xml-fv-utc.xml | 52 - tests/sexpr2xmldata/sexpr2xml-fv-v2.sexpr | 9 - tests/sexpr2xmldata/sexpr2xml-fv-v2.xml | 52 - tests/sexpr2xmldata/sexpr2xml-fv.sexpr | 11 - tests/sexpr2xmldata/sexpr2xml-fv.xml | 52 - .../sexpr2xmldata/sexpr2xml-net-bridged.sexpr | 9 - tests/sexpr2xmldata/sexpr2xml-net-bridged.xml | 37 - tests/sexpr2xmldata/sexpr2xml-net-e1000.sexpr | 10 - tests/sexpr2xmldata/sexpr2xml-net-e1000.xml | 38 - .../sexpr2xmldata/sexpr2xml-net-routed.sexpr | 10 - tests/sexpr2xmldata/sexpr2xml-net-routed.xml | 37 - .../sexpr2xml-no-source-cdrom.sexpr | 66 - .../sexpr2xml-no-source-cdrom.xml | 58 - tests/sexpr2xmldata/sexpr2xml-pci-devs.sexpr | 10 - tests/sexpr2xmldata/sexpr2xml-pci-devs.xml | 43 - .../sexpr2xml-pv-bootloader-cmdline.sexpr | 5 - .../sexpr2xml-pv-bootloader-cmdline.xml | 31 - .../sexpr2xml-pv-bootloader.sexpr | 5 - .../sexpr2xmldata/sexpr2xml-pv-bootloader.xml | 30 - .../sexpr2xml-pv-localtime.sexpr | 8 - .../sexpr2xmldata/sexpr2xml-pv-localtime.xml | 31 - tests/sexpr2xmldata/sexpr2xml-pv-vcpus.sexpr | 8 - tests/sexpr2xmldata/sexpr2xml-pv-vcpus.xml | 31 - .../sexpr2xml-pv-vfb-new-vncdisplay.sexpr | 10 - .../sexpr2xml-pv-vfb-new-vncdisplay.xml | 37 - .../sexpr2xmldata/sexpr2xml-pv-vfb-new.sexpr | 9 - tests/sexpr2xmldata/sexpr2xml-pv-vfb-new.xml | 37 - .../sexpr2xml-pv-vfb-type-crash.sexpr | 83 - .../sexpr2xml-pv-vfb-type-crash.xml | 42 - tests/sexpr2xmldata/sexpr2xml-pv.sexpr | 8 - tests/sexpr2xmldata/sexpr2xml-pv.xml | 31 - tests/sexpr2xmldata/sexpr2xml-vif-rate.sexpr | 11 - tests/sexpr2xmldata/sexpr2xml-vif-rate.xml | 56 - tests/sexpr2xmltest.c | 170 -- tests/virschematest.c | 4 +- tests/xml2sexprdata/xml2sexpr-boot-grub.sexpr | 6 - tests/xml2sexprdata/xml2sexpr-boot-grub.xml | 21 - .../xml2sexpr-bridge-ipaddr.sexpr | 12 - .../xml2sexprdata/xml2sexpr-bridge-ipaddr.xml | 29 - tests/xml2sexprdata/xml2sexpr-curmem.sexpr | 7 - tests/xml2sexprdata/xml2sexpr-curmem.xml | 23 - .../xml2sexpr-disk-block-shareable.sexpr | 9 - .../xml2sexpr-disk-block-shareable.xml | 31 - .../xml2sexprdata/xml2sexpr-disk-block.sexpr | 10 - tests/xml2sexprdata/xml2sexpr-disk-block.xml | 22 - .../xml2sexpr-disk-drv-blkback.sexpr | 10 - .../xml2sexpr-disk-drv-blkback.xml | 23 - .../xml2sexpr-disk-drv-blktap-qcow.sexpr | 10 - .../xml2sexpr-disk-drv-blktap-qcow.xml | 23 - .../xml2sexpr-disk-drv-blktap-raw.sexpr | 10 - .../xml2sexpr-disk-drv-blktap-raw.xml | 23 - .../xml2sexpr-disk-drv-blktap.sexpr | 10 - .../xml2sexpr-disk-drv-blktap.xml | 23 - .../xml2sexpr-disk-drv-blktap2-raw.sexpr | 10 - .../xml2sexpr-disk-drv-blktap2-raw.xml | 23 - .../xml2sexpr-disk-drv-blktap2.sexpr | 10 - .../xml2sexpr-disk-drv-blktap2.xml | 23 - .../xml2sexpr-disk-drv-loop.sexpr | 10 - .../xml2sexprdata/xml2sexpr-disk-drv-loop.xml | 23 - tests/xml2sexprdata/xml2sexpr-disk-file.sexpr | 10 - tests/xml2sexprdata/xml2sexpr-disk-file.xml | 22 - tests/xml2sexprdata/xml2sexpr-escape.sexpr | 11 - tests/xml2sexprdata/xml2sexpr-escape.xml | 24 - .../xml2sexpr-fv-force-hpet.sexpr | 12 - .../xml2sexprdata/xml2sexpr-fv-force-hpet.xml | 39 - .../xml2sexpr-fv-force-nohpet.sexpr | 12 - .../xml2sexpr-fv-force-nohpet.xml | 39 - tests/xml2sexprdata/xml2sexpr-fv-kernel.sexpr | 12 - tests/xml2sexprdata/xml2sexpr-fv-kernel.xml | 24 - .../xml2sexpr-fv-localtime.sexpr | 12 - .../xml2sexprdata/xml2sexpr-fv-localtime.xml | 37 - .../xml2sexpr-fv-net-many-models.sexpr | 1 - .../xml2sexpr-fv-net-many-models.xml | 43 - .../xml2sexpr-fv-net-netfront.sexpr | 10 - .../xml2sexpr-fv-net-netfront.xml | 31 - .../xml2sexprdata/xml2sexpr-fv-net-rate.sexpr | 10 - tests/xml2sexprdata/xml2sexpr-fv-net-rate.xml | 34 - .../xml2sexpr-fv-parallel-tcp.sexpr | 12 - .../xml2sexpr-fv-parallel-tcp.xml | 40 - .../xml2sexpr-fv-serial-dev-2-ports.sexpr | 13 - .../xml2sexpr-fv-serial-dev-2-ports.xml | 44 - .../xml2sexpr-fv-serial-dev-2nd-port.sexpr | 12 - .../xml2sexpr-fv-serial-dev-2nd-port.xml | 40 - .../xml2sexpr-fv-serial-file.sexpr | 13 - .../xml2sexpr-fv-serial-file.xml | 40 - .../xml2sexpr-fv-serial-null.sexpr | 12 - .../xml2sexpr-fv-serial-null.xml | 39 - .../xml2sexpr-fv-serial-pipe.sexpr | 13 - .../xml2sexpr-fv-serial-pipe.xml | 40 - .../xml2sexpr-fv-serial-pty.sexpr | 12 - .../xml2sexprdata/xml2sexpr-fv-serial-pty.xml | 39 - .../xml2sexpr-fv-serial-stdio.sexpr | 12 - .../xml2sexpr-fv-serial-stdio.xml | 39 - .../xml2sexpr-fv-serial-tcp-telnet.sexpr | 13 - .../xml2sexpr-fv-serial-tcp-telnet.xml | 41 - .../xml2sexpr-fv-serial-tcp.sexpr | 13 - .../xml2sexprdata/xml2sexpr-fv-serial-tcp.xml | 40 - .../xml2sexpr-fv-serial-udp.sexpr | 13 - .../xml2sexprdata/xml2sexpr-fv-serial-udp.xml | 41 - .../xml2sexpr-fv-serial-unix.sexpr | 13 - .../xml2sexpr-fv-serial-unix.xml | 40 - tests/xml2sexprdata/xml2sexpr-fv-sound.sexpr | 12 - tests/xml2sexprdata/xml2sexpr-fv-sound.xml | 38 - .../xml2sexprdata/xml2sexpr-fv-usbmouse.sexpr | 12 - tests/xml2sexprdata/xml2sexpr-fv-usbmouse.xml | 37 - .../xml2sexpr-fv-usbtablet.sexpr | 10 - .../xml2sexprdata/xml2sexpr-fv-usbtablet.xml | 36 - tests/xml2sexprdata/xml2sexpr-fv-utc.sexpr | 12 - tests/xml2sexprdata/xml2sexpr-fv-utc.xml | 37 - tests/xml2sexprdata/xml2sexpr-fv-v2.sexpr | 11 - .../xml2sexpr-fv-vncunused.sexpr | 11 - .../xml2sexprdata/xml2sexpr-fv-vncunused.xml | 36 - tests/xml2sexprdata/xml2sexpr-fv.sexpr | 12 - tests/xml2sexprdata/xml2sexpr-fv.xml | 36 - .../xml2sexprdata/xml2sexpr-net-bridged.sexpr | 11 - tests/xml2sexprdata/xml2sexpr-net-bridged.xml | 28 - tests/xml2sexprdata/xml2sexpr-net-e1000.sexpr | 11 - tests/xml2sexprdata/xml2sexpr-net-e1000.xml | 29 - .../xml2sexprdata/xml2sexpr-net-routed.sexpr | 11 - tests/xml2sexprdata/xml2sexpr-net-routed.xml | 28 - .../xml2sexpr-no-source-cdrom.sexpr | 10 - .../xml2sexpr-no-source-cdrom.xml | 37 - tests/xml2sexprdata/xml2sexpr-pci-devs.sexpr | 10 - tests/xml2sexprdata/xml2sexpr-pci-devs.xml | 32 - .../xml2sexpr-pv-bootloader-cmdline.sexpr | 6 - .../xml2sexpr-pv-bootloader-cmdline.xml | 22 - .../xml2sexpr-pv-bootloader.sexpr | 7 - .../xml2sexprdata/xml2sexpr-pv-bootloader.xml | 18 - .../xml2sexpr-pv-localtime.sexpr | 8 - .../xml2sexprdata/xml2sexpr-pv-localtime.xml | 25 - tests/xml2sexprdata/xml2sexpr-pv-vcpus.sexpr | 9 - tests/xml2sexprdata/xml2sexpr-pv-vcpus.xml | 22 - .../xml2sexpr-pv-vfb-new-auto.sexpr | 11 - .../xml2sexpr-pv-vfb-new-auto.xml | 23 - .../xml2sexprdata/xml2sexpr-pv-vfb-new.sexpr | 11 - tests/xml2sexprdata/xml2sexpr-pv-vfb-new.xml | 23 - tests/xml2sexprdata/xml2sexpr-pv.sexpr | 9 - tests/xml2sexprdata/xml2sexpr-pv.xml | 22 - tests/xml2sexprtest.c | 167 -- 221 files changed, 393 insertions(+), 8907 deletions(-) delete mode 100644 src/util/virsexpr.c delete mode 100644 src/util/virsexpr.h delete mode 100644 src/xenconfig/xen_sxpr.c delete mode 100644 src/xenconfig/xen_sxpr.h delete mode 100644 tests/sexpr2xmldata/sexpr2xml-boot-grub.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-boot-grub.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-bridge-ipaddr.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-bridge-ipaddr.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-curmem.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-curmem.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-disk-block-shareable.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-disk-block-shareable.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-disk-block.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-disk-block.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-disk-drv-blktap-qcow.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-disk-drv-blktap-qcow.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-disk-drv-blktap-raw.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-disk-drv-blktap-raw.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-disk-drv-blktap2-raw.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-disk-drv-blktap2-raw.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-disk-file.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-disk-file.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-autoport.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-autoport.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-empty-kernel.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-empty-kernel.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-force-hpet.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-force-hpet.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-force-nohpet.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-force-nohpet.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-kernel.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-kernel.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-legacy-vfb.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-legacy-vfb.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-localtime.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-localtime.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-net-netfront.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-net-netfront.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-parallel-tcp.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-parallel-tcp.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-serial-dev-2-ports.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-serial-dev-2-ports.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-serial-dev-2nd-port.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-serial-dev-2nd-port.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-serial-file.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-serial-file.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-serial-null.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-serial-null.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-serial-pipe.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-serial-pipe.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-serial-pty.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-serial-pty.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-serial-stdio.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-serial-stdio.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp-telnet.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp-telnet.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-serial-udp.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-serial-udp.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-serial-unix.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-serial-unix.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-sound-all.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-sound-all.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-sound.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-sound.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-usbmouse.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-usbmouse.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-usbtablet.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-usbtablet.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-utc.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-utc.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-v2.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv-v2.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-fv.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-net-bridged.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-net-bridged.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-net-e1000.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-net-e1000.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-net-routed.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-net-routed.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-pci-devs.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-pci-devs.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-pv-bootloader-cmdline.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-pv-bootloader-cmdline.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-pv-bootloader.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-pv-bootloader.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-pv-localtime.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-pv-localtime.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-pv-vcpus.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-pv-vcpus.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-pv-vfb-new-vncdisplay.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-pv-vfb-new-vncdisplay.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-pv-vfb-new.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-pv-vfb-new.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-pv-vfb-type-crash.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-pv-vfb-type-crash.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-pv.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-pv.xml delete mode 100644 tests/sexpr2xmldata/sexpr2xml-vif-rate.sexpr delete mode 100644 tests/sexpr2xmldata/sexpr2xml-vif-rate.xml delete mode 100644 tests/sexpr2xmltest.c delete mode 100644 tests/xml2sexprdata/xml2sexpr-boot-grub.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-boot-grub.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-bridge-ipaddr.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-bridge-ipaddr.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-curmem.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-curmem.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-disk-block-shareable.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-disk-block-shareable.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-disk-block.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-disk-block.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-disk-drv-blkback.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-disk-drv-blkback.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-disk-drv-blktap-qcow.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-disk-drv-blktap-qcow.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-disk-drv-blktap-raw.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-disk-drv-blktap-raw.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-disk-drv-blktap.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-disk-drv-blktap.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-disk-drv-blktap2-raw.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-disk-drv-blktap2-raw.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-disk-drv-blktap2.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-disk-drv-blktap2.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-disk-drv-loop.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-disk-drv-loop.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-disk-file.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-disk-file.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-escape.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-escape.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-force-hpet.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-force-hpet.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-force-nohpet.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-force-nohpet.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-kernel.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-kernel.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-localtime.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-localtime.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-net-many-models.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-net-many-models.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-net-netfront.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-net-netfront.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-net-rate.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-net-rate.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-parallel-tcp.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-parallel-tcp.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-serial-dev-2-ports.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-serial-dev-2-ports.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-serial-dev-2nd-port.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-serial-dev-2nd-port.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-serial-file.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-serial-file.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-serial-null.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-serial-null.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-serial-pipe.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-serial-pipe.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-serial-pty.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-serial-pty.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-serial-stdio.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-serial-stdio.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-serial-tcp-telnet.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-serial-tcp-telnet.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-serial-tcp.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-serial-tcp.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-serial-udp.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-serial-udp.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-serial-unix.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-serial-unix.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-sound.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-sound.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-usbmouse.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-usbmouse.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-usbtablet.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-usbtablet.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-utc.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-utc.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-v2.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-vncunused.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv-vncunused.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-fv.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-net-bridged.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-net-bridged.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-net-e1000.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-net-e1000.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-net-routed.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-net-routed.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-no-source-cdrom.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-no-source-cdrom.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-pci-devs.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-pci-devs.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-pv-bootloader-cmdline.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-pv-bootloader-cmdline.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-pv-bootloader.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-pv-bootloader.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-pv-localtime.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-pv-localtime.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-pv-vcpus.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-pv-vcpus.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-pv-vfb-new-auto.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-pv-vfb-new-auto.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-pv-vfb-new.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-pv-vfb-new.xml delete mode 100644 tests/xml2sexprdata/xml2sexpr-pv.sexpr delete mode 100644 tests/xml2sexprdata/xml2sexpr-pv.xml delete mode 100644 tests/xml2sexprtest.c -- 2.21.0

4 31

[libvirt] [PATCH v2] docs: introduce a "knowledge base" for task oriented guides
by Daniel P. Berrangé 08 Jul '19

08 Jul '19

The previously added AMD SEV doc was not linked from anywhere on the website. Address this by introducing a new "Knowledge base" section that can hold task oriented guide to various features. Moving the SEV, disk locking and secure usage guides under this section. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/Makefile.am | 15 +++++++++++- docs/docs.html.in | 9 ++----- docs/kbase.html.in | 25 ++++++++++++++++++++ docs/{ => kbase}/launch_security_sev.html.in | 0 docs/{ => kbase}/locking-lockd.html.in | 0 docs/{ => kbase}/locking-sanlock.html.in | 0 docs/{ => kbase}/locking.html.in | 0 docs/{ => kbase}/secureusage.html.in | 0 8 files changed, 41 insertions(+), 8 deletions(-) create mode 100644 docs/kbase.html.in rename docs/{ => kbase}/launch_security_sev.html.in (100%) rename docs/{ => kbase}/locking-lockd.html.in (100%) rename docs/{ => kbase}/locking-sanlock.html.in (100%) rename docs/{ => kbase}/locking.html.in (100%) rename docs/{ => kbase}/secureusage.html.in (100%) diff --git a/docs/Makefile.am b/docs/Makefile.am index 977be471ad..1cfa38dc80 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -132,6 +132,10 @@ internals_html_in = \ $(patsubst $(srcdir)/%,%,$(wildcard $(srcdir)/internals/*.html.in)) internals_html = $(internals_html_in:%.html.in=%.html) +kbase_html_in = \ + $(patsubst $(srcdir)/%,%,$(wildcard $(srcdir)/kbase/*.html.in)) +kbase_html = $(kbase_html_in:%.html.in=%.html) + # Since we ship pre-built html in the tarball, we must also # ship the sources, even when those sources are themselves # generated. @@ -187,6 +191,7 @@ EXTRA_DIST= \ $(xml) $(qemu_xml) $(lxc_xml) $(admin_xml) $(fig) $(png) $(css) \ $(javascript) $(logofiles) \ $(internals_html_in) $(internals_html) $(fonts) \ + $(kbase_html_in) $(kbase_html) \ aclperms.htmlinc \ hvsupport.pl \ $(schema_DATA) @@ -202,6 +207,7 @@ MAINTAINERCLEANFILES = \ $(addprefix $(srcdir)/,$(apihtml)) \ $(addprefix $(srcdir)/,$(devhelphtml)) \ $(addprefix $(srcdir)/,$(internals_html)) \ + $(addprefix $(srcdir)/,$(kbase_html)) \ $(srcdir)/hvsupport.html.in $(srcdir)/aclperms.htmlinc timestamp="$(shell if test -n "$$SOURCE_DATE_EPOCH"; \ @@ -218,7 +224,8 @@ qemu_api: $(srcdir)/libvirt-qemu-api.xml $(srcdir)/libvirt-qemu-refs.xml lxc_api: $(srcdir)/libvirt-lxc-api.xml $(srcdir)/libvirt-lxc-refs.xml admin_api: $(srcdir)/libvirt-admin-api.xml $(srcdir)/libvirt-admin-refs.xml -web: $(dot_html) $(internals_html) html/index.html devhelp/index.html +web: $(dot_html) $(internals_html) $(kbase_html) \ + html/index.html devhelp/index.html hvsupport.html: $(srcdir)/hvsupport.html.in @@ -381,6 +388,9 @@ install-data-local: $(mkinstalldirs) $(DESTDIR)$(HTML_DIR)/internals for f in $(internals_html); do \ $(INSTALL) -m 0644 $(srcdir)/$$f $(DESTDIR)$(HTML_DIR)/internals; done + $(mkinstalldirs) $(DESTDIR)$(HTML_DIR)/kbase + for f in $(kbase_html); do \ + $(INSTALL) -m 0644 $(srcdir)/$$f $(DESTDIR)$(HTML_DIR)/kbase; done $(mkinstalldirs) $(DESTDIR)$(DEVHELP_DIR) for file in $(devhelphtml) $(devhelppng) $(devhelpcss); do \ $(INSTALL) -m 0644 $(srcdir)/$${file} $(DESTDIR)$(DEVHELP_DIR) ; \ @@ -405,6 +415,9 @@ uninstall-local: for f in $(internals_html); do \ rm -f $(DESTDIR)$(HTML_DIR)/$$f; \ done + for f in $(kbase_html); do \ + rm -f $(DESTDIR)$(HTML_DIR)/$$f; \ + done for f in $(devhelphtml) $(devhelppng) $(devhelpcss); do \ rm -f $(DESTDIR)$(DEVHELP_DIR)/$$(basename $$f); \ done diff --git a/docs/docs.html.in b/docs/docs.html.in index c8674e1457..9e1ef6be41 100644 --- a/docs/docs.html.in +++ b/docs/docs.html.in @@ -86,11 +86,6 @@ <dt><a href="uri.html">URI format</a></dt> <dd>The URI formats used for connecting to libvirt</dd> - <dt><a href="locking.html">Disk locking</a></dt> - <dd>Ensuring exclusive guest access to disks with - <a href="locking-lockd.html">virtlockd</a> or - <a href="locking-sanlock.html">Sanlock</a></dd> - <dt><a href="cgroups.html">CGroups</a></dt> <dd>Control groups integration</dd> @@ -120,8 +115,8 @@ <dt><a href="hvsupport.html">Driver support</a></dt> <dd>matrix of API support per hypervisor per release</dd> - <dt><a href="secureusage.html">Secure usage</a></dt> - <dd>Secure usage of the libvirt APIs</dd> + <dt><a href="kbase.html">Knowledge Base</a></dt> + <dd>Task oriented guides to key features</dd> </dl> </div> diff --git a/docs/kbase.html.in b/docs/kbase.html.in new file mode 100644 index 0000000000..78f2a4e0c5 --- /dev/null +++ b/docs/kbase.html.in @@ -0,0 +1,25 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!DOCTYPE html> +<html xmlns="http://www.w3.org/1999/xhtml"> + <body class="docs"> + <h2>Knowledge base</h2> + + <div class="panel"> + <dl> + <dt><a href="kbase/locking.html">Disk locking</a></dt> + <dd>Ensuring exclusive guest access to disks with + <a href="kbase/locking-lockd.html">virtlockd</a> or + <a href="kbase/locking-sanlock.html">Sanlock</a></dd> + + <dt><a href="kbase/secureusage.html">Secure usage</a></dt> + <dd>Secure usage of the libvirt APIs</dd> + + <dt><a href="kbase/launch_security_sev.html">Launch security</a></dt> + <dd>Securely launching VMs with AMD SEV</dd> + </dl> + </div> + + <br class="clear"/> + + </body> +</html> diff --git a/docs/launch_security_sev.html.in b/docs/kbase/launch_security_sev.html.in similarity index 100% rename from docs/launch_security_sev.html.in rename to docs/kbase/launch_security_sev.html.in diff --git a/docs/locking-lockd.html.in b/docs/kbase/locking-lockd.html.in similarity index 100% rename from docs/locking-lockd.html.in rename to docs/kbase/locking-lockd.html.in diff --git a/docs/locking-sanlock.html.in b/docs/kbase/locking-sanlock.html.in similarity index 100% rename from docs/locking-sanlock.html.in rename to docs/kbase/locking-sanlock.html.in diff --git a/docs/locking.html.in b/docs/kbase/locking.html.in similarity index 100% rename from docs/locking.html.in rename to docs/kbase/locking.html.in diff --git a/docs/secureusage.html.in b/docs/kbase/secureusage.html.in similarity index 100% rename from docs/secureusage.html.in rename to docs/kbase/secureusage.html.in -- 2.21.0

2 2

[libvirt] New Feature: Identify Intel SGX support
by Carvalho, Larkins L 08 Jul '19

08 Jul '19

Hello Team, Greetings! We want to identify if the platform is Intel Software Guard Extensions<https://software.intel.com/en-us/sgx> (SGX) capable. The management platform (ex. Openstack) can use this information to launch VM that can run secure application code and data. Intel(r) SGX offers hardware-based memory encryption that isolates specific application code and data in memory. Regards, Larkins Carvalho Intel Corp.

2 2

[libvirt] [PATCH] rpc: ensure thread safe initialization of SASL library
by Daniel P. Berrangé 08 Jul '19

08 Jul '19

Neither the sasl_client_init or sasl_server_init methods are even remotely threadsafe. They do a bunch of one-time initialization and merely use a simple integer counter to avoid repeated work, not even using atomic increment/reads on the counter. This can easily race in a threaded program. Protect the calls using a virOnce initializer function which is guaranteed threadsafe at least from libvirt's POV. If the application using libvirt also uses another library that makes use of SASL then the race still exists. It is impossible to fix that fully except in SASL code itself. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/rpc/virnetsaslcontext.c | 50 ++++++++++++++++++++++++------------- 1 file changed, 33 insertions(+), 17 deletions(-) diff --git a/src/rpc/virnetsaslcontext.c b/src/rpc/virnetsaslcontext.c index f49340f033..62b103a428 100644 --- a/src/rpc/virnetsaslcontext.c +++ b/src/rpc/virnetsaslcontext.c @@ -77,22 +77,46 @@ VIR_ONCE_GLOBAL_INIT(virNetSASLContext); VIR_WARNINGS_NO_DEPRECATED #endif -virNetSASLContextPtr virNetSASLContextNewClient(void) +static int virNetSASLContextClientOnceInit(void) { - virNetSASLContextPtr ctxt; - int err; + int err = sasl_client_init(NULL); + if (err != SASL_OK) { + virReportError(VIR_ERR_AUTH_FAILED, + _("failed to initialize SASL library: %d (%s)"), + err, sasl_errstring(err, NULL, NULL)); + return -1; + } + + return 0; +} + +VIR_ONCE_GLOBAL_INIT(virNetSASLContextClient); - if (virNetSASLContextInitialize() < 0) - return NULL; - err = sasl_client_init(NULL); +static int virNetSASLContextServerOnceInit(void) +{ + int err = sasl_server_init(NULL, "libvirt"); if (err != SASL_OK) { virReportError(VIR_ERR_AUTH_FAILED, _("failed to initialize SASL library: %d (%s)"), err, sasl_errstring(err, NULL, NULL)); - return NULL; + return -1; } + return 0; +} + +VIR_ONCE_GLOBAL_INIT(virNetSASLContextServer); + + +virNetSASLContextPtr virNetSASLContextNewClient(void) +{ + virNetSASLContextPtr ctxt; + + if (virNetSASLContextInitialize() < 0 || + virNetSASLContextClientInitialize() < 0) + return NULL; + if (!(ctxt = virObjectLockableNew(virNetSASLContextClass))) return NULL; @@ -102,19 +126,11 @@ virNetSASLContextPtr virNetSASLContextNewClient(void) virNetSASLContextPtr virNetSASLContextNewServer(const char *const*usernameWhitelist) { virNetSASLContextPtr ctxt; - int err; - if (virNetSASLContextInitialize() < 0) + if (virNetSASLContextInitialize() < 0 || + virNetSASLContextServerInitialize() < 0) return NULL; - err = sasl_server_init(NULL, "libvirt"); - if (err != SASL_OK) { - virReportError(VIR_ERR_AUTH_FAILED, - _("failed to initialize SASL library: %d (%s)"), - err, sasl_errstring(err, NULL, NULL)); - return NULL; - } - if (!(ctxt = virObjectLockableNew(virNetSASLContextClass))) return NULL; -- 2.21.0

3 3

[libvirt] [PATCH] docs: introduce a "knowledge base" for task oriented guides
by Daniel P. Berrangé 08 Jul '19

08 Jul '19

The previously added AMD SEV doc was not linked from anywhere on the website. Address this by introducing a new "Knowledge base" section that can hold task oriented guide to various features. Moving the SEV, disk locking and secure usage guides under this section. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/Makefile.am | 15 ++++++++++++++- docs/docs.html.in | 9 ++------- docs/{ => kbase}/launch_security_sev.html.in | 0 docs/{ => kbase}/locking-lockd.html.in | 0 docs/{ => kbase}/locking-sanlock.html.in | 0 docs/{ => kbase}/locking.html.in | 0 docs/{ => kbase}/secureusage.html.in | 0 7 files changed, 16 insertions(+), 8 deletions(-) rename docs/{ => kbase}/launch_security_sev.html.in (100%) rename docs/{ => kbase}/locking-lockd.html.in (100%) rename docs/{ => kbase}/locking-sanlock.html.in (100%) rename docs/{ => kbase}/locking.html.in (100%) rename docs/{ => kbase}/secureusage.html.in (100%) diff --git a/docs/Makefile.am b/docs/Makefile.am index 977be471ad..1cfa38dc80 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -132,6 +132,10 @@ internals_html_in = \ $(patsubst $(srcdir)/%,%,$(wildcard $(srcdir)/internals/*.html.in)) internals_html = $(internals_html_in:%.html.in=%.html) +kbase_html_in = \ + $(patsubst $(srcdir)/%,%,$(wildcard $(srcdir)/kbase/*.html.in)) +kbase_html = $(kbase_html_in:%.html.in=%.html) + # Since we ship pre-built html in the tarball, we must also # ship the sources, even when those sources are themselves # generated. @@ -187,6 +191,7 @@ EXTRA_DIST= \ $(xml) $(qemu_xml) $(lxc_xml) $(admin_xml) $(fig) $(png) $(css) \ $(javascript) $(logofiles) \ $(internals_html_in) $(internals_html) $(fonts) \ + $(kbase_html_in) $(kbase_html) \ aclperms.htmlinc \ hvsupport.pl \ $(schema_DATA) @@ -202,6 +207,7 @@ MAINTAINERCLEANFILES = \ $(addprefix $(srcdir)/,$(apihtml)) \ $(addprefix $(srcdir)/,$(devhelphtml)) \ $(addprefix $(srcdir)/,$(internals_html)) \ + $(addprefix $(srcdir)/,$(kbase_html)) \ $(srcdir)/hvsupport.html.in $(srcdir)/aclperms.htmlinc timestamp="$(shell if test -n "$$SOURCE_DATE_EPOCH"; \ @@ -218,7 +224,8 @@ qemu_api: $(srcdir)/libvirt-qemu-api.xml $(srcdir)/libvirt-qemu-refs.xml lxc_api: $(srcdir)/libvirt-lxc-api.xml $(srcdir)/libvirt-lxc-refs.xml admin_api: $(srcdir)/libvirt-admin-api.xml $(srcdir)/libvirt-admin-refs.xml -web: $(dot_html) $(internals_html) html/index.html devhelp/index.html +web: $(dot_html) $(internals_html) $(kbase_html) \ + html/index.html devhelp/index.html hvsupport.html: $(srcdir)/hvsupport.html.in @@ -381,6 +388,9 @@ install-data-local: $(mkinstalldirs) $(DESTDIR)$(HTML_DIR)/internals for f in $(internals_html); do \ $(INSTALL) -m 0644 $(srcdir)/$$f $(DESTDIR)$(HTML_DIR)/internals; done + $(mkinstalldirs) $(DESTDIR)$(HTML_DIR)/kbase + for f in $(kbase_html); do \ + $(INSTALL) -m 0644 $(srcdir)/$$f $(DESTDIR)$(HTML_DIR)/kbase; done $(mkinstalldirs) $(DESTDIR)$(DEVHELP_DIR) for file in $(devhelphtml) $(devhelppng) $(devhelpcss); do \ $(INSTALL) -m 0644 $(srcdir)/$${file} $(DESTDIR)$(DEVHELP_DIR) ; \ @@ -405,6 +415,9 @@ uninstall-local: for f in $(internals_html); do \ rm -f $(DESTDIR)$(HTML_DIR)/$$f; \ done + for f in $(kbase_html); do \ + rm -f $(DESTDIR)$(HTML_DIR)/$$f; \ + done for f in $(devhelphtml) $(devhelppng) $(devhelpcss); do \ rm -f $(DESTDIR)$(DEVHELP_DIR)/$$(basename $$f); \ done diff --git a/docs/docs.html.in b/docs/docs.html.in index c8674e1457..9e1ef6be41 100644 --- a/docs/docs.html.in +++ b/docs/docs.html.in @@ -86,11 +86,6 @@ <dt><a href="uri.html">URI format</a></dt> <dd>The URI formats used for connecting to libvirt</dd> - <dt><a href="locking.html">Disk locking</a></dt> - <dd>Ensuring exclusive guest access to disks with - <a href="locking-lockd.html">virtlockd</a> or - <a href="locking-sanlock.html">Sanlock</a></dd> - <dt><a href="cgroups.html">CGroups</a></dt> <dd>Control groups integration</dd> @@ -120,8 +115,8 @@ <dt><a href="hvsupport.html">Driver support</a></dt> <dd>matrix of API support per hypervisor per release</dd> - <dt><a href="secureusage.html">Secure usage</a></dt> - <dd>Secure usage of the libvirt APIs</dd> + <dt><a href="kbase.html">Knowledge Base</a></dt> + <dd>Task oriented guides to key features</dd> </dl> </div> diff --git a/docs/launch_security_sev.html.in b/docs/kbase/launch_security_sev.html.in similarity index 100% rename from docs/launch_security_sev.html.in rename to docs/kbase/launch_security_sev.html.in diff --git a/docs/locking-lockd.html.in b/docs/kbase/locking-lockd.html.in similarity index 100% rename from docs/locking-lockd.html.in rename to docs/kbase/locking-lockd.html.in diff --git a/docs/locking-sanlock.html.in b/docs/kbase/locking-sanlock.html.in similarity index 100% rename from docs/locking-sanlock.html.in rename to docs/kbase/locking-sanlock.html.in diff --git a/docs/locking.html.in b/docs/kbase/locking.html.in similarity index 100% rename from docs/locking.html.in rename to docs/kbase/locking.html.in diff --git a/docs/secureusage.html.in b/docs/kbase/secureusage.html.in similarity index 100% rename from docs/secureusage.html.in rename to docs/kbase/secureusage.html.in -- 2.21.0

2 2

[libvirt] [PATCH 00/11] qemu: Add formatter for 'blockdev-create' JSON (blockdev-add saga)
by Peter Krempa 08 Jul '19

08 Jul '19

To allow using blockdev-create we need to be able to generate the properties for it, this series adds the necessary bits and also converts to use 'auto-read-only' instead of 'read-only'. Kevin, please look into the test data to see if there's something wrong with the semantic usage. The data is validated against the QMP schema. Format in 2/11 will be used as the 'backing-store' string via the json:// pseudo protocol for recording into new files for network use. 5/11 is the conversion to use auto-read-only. The test data in the patch covers stadard use with -blockdev/blockdev-add 11/11 is the format to be used with 'blockdev-create' Thanks. Peter Krempa (11): qemu: block: Allow skipping non-target related data when formating disk JSON tests: qemublock: Add testing of pure disk source specification JSON generator util: json: Introduce helper to prepend string into a virJSONValueObject qemu: block: Extract formating of 'driver' attribute from child formatters qemu: block: Use 'auto-read-only' instead of 'read-only' for backing chain qemu: block: Add generator for image format creation properties qemu: block: Add generator for creating storage with blockdev-create qemu: domain: Export qemuDomainPrepareStorageSourceBlockdev conf: snapshot: Export virDomainSnapshotDiskDefParseXML conf: snapshot: Provide a function to free virDomainSnapshotDiskDefPtr tests: qemublock: Add testing of 'blockdev-create' generators src/conf/snapshot_conf.c | 13 +- src/conf/snapshot_conf.h | 6 + src/libvirt_private.syms | 1 + src/qemu/qemu_block.c | 584 ++++++++++++++++-- src/qemu/qemu_block.h | 18 +- src/qemu/qemu_command.c | 4 +- src/qemu/qemu_domain.c | 9 +- src/qemu/qemu_domain.h | 5 + src/qemu/qemu_migration.c | 4 +- src/util/virjson.c | 50 +- src/util/virjson.h | 1 + tests/qemublocktest.c | 244 +++++++- .../imagecreate/luks-encopts.json | 19 + .../imagecreate/luks-encopts.xml | 16 + .../imagecreate/luks-noopts.json | 14 + .../imagecreate/luks-noopts.xml | 14 + .../imagecreate/network-gluster-qcow2.json | 28 + .../imagecreate/network-gluster-qcow2.xml | 13 + .../imagecreate/network-rbd-qcow2.json | 26 + .../imagecreate/network-rbd-qcow2.xml | 13 + .../imagecreate/network-sheepdog-qcow2.json | 20 + .../imagecreate/network-sheepdog-qcow2.xml | 12 + .../imagecreate/network-ssh-qcow2.json | 19 + .../imagecreate/network-ssh-qcow2.xml | 12 + .../imagecreate/qcow2-backing-luks.json | 15 + .../imagecreate/qcow2-backing-luks.xml | 1 + .../imagecreate/qcow2-backing-raw-nbd.json | 15 + .../imagecreate/qcow2-backing-raw-nbd.xml | 1 + .../imagecreate/qcow2-backing-raw.json | 15 + .../imagecreate/qcow2-backing-raw.xml | 1 + .../qcow2-luks-encopts-backing.json | 24 + .../qcow2-luks-encopts-backing.xml | 1 + .../imagecreate/qcow2-luks-encopts.json | 22 + .../imagecreate/qcow2-luks-encopts.xml | 16 + .../imagecreate/qcow2-luks-noopts.json | 17 + .../imagecreate/qcow2-luks-noopts.xml | 14 + .../qemublocktestdata/imagecreate/qcow2.json | 13 + tests/qemublocktestdata/imagecreate/qcow2.xml | 11 + .../imagecreate/raw-nbd.json | 4 + .../qemublocktestdata/imagecreate/raw-nbd.xml | 12 + tests/qemublocktestdata/imagecreate/raw.json | 9 + tests/qemublocktestdata/imagecreate/raw.xml | 11 + .../xml2json/block-raw-noopts-srconly.json | 4 + .../xml2json/block-raw-noopts.json | 2 +- .../block-raw-reservations-srconly.json | 4 + .../xml2json/block-raw-reservations.json | 2 +- .../xml2json/dir-fat-cache-srconly.json | 5 + .../xml2json/dir-fat-cache.json | 2 +- .../xml2json/dir-fat-floppy-srconly.json | 5 + .../xml2json/dir-fat-floppy.json | 2 +- .../xml2json/dir-fat-readonly-srconly.json | 5 + .../xml2json/dir-fat-readonly.json | 2 +- ...ile-backing_basic-aio_threads-srconly.json | 24 + .../file-backing_basic-aio_threads.json | 8 +- ...acking_basic-cache-directsync-srconly.json | 24 + .../file-backing_basic-cache-directsync.json | 8 +- ...file-backing_basic-cache-none-srconly.json | 24 + .../file-backing_basic-cache-none.json | 8 +- ...le-backing_basic-cache-unsafe-srconly.json | 24 + .../file-backing_basic-cache-unsafe.json | 8 +- ...backing_basic-cache-writeback-srconly.json | 24 + .../file-backing_basic-cache-writeback.json | 8 +- ...king_basic-cache-writethrough-srconly.json | 24 + ...file-backing_basic-cache-writethrough.json | 8 +- .../file-backing_basic-detect-srconly.json | 24 + .../xml2json/file-backing_basic-detect.json | 8 +- .../file-backing_basic-noopts-srconly.json | 16 + .../xml2json/file-backing_basic-noopts.json | 8 +- ...le-backing_basic-unmap-detect-srconly.json | 24 + .../file-backing_basic-unmap-detect.json | 8 +- ...le-backing_basic-unmap-ignore-srconly.json | 24 + .../file-backing_basic-unmap-ignore.json | 8 +- .../file-backing_basic-unmap-srconly.json | 24 + .../xml2json/file-backing_basic-unmap.json | 8 +- .../xml2json/file-bochs-noopts-srconly.json | 4 + .../xml2json/file-bochs-noopts.json | 2 +- .../xml2json/file-cloop-noopts-srconly.json | 4 + .../xml2json/file-cloop-noopts.json | 2 +- .../xml2json/file-dmg-noopts-srconly.json | 4 + .../xml2json/file-dmg-noopts.json | 2 +- .../xml2json/file-ploop-noopts-srconly.json | 4 + .../xml2json/file-ploop-noopts.json | 2 +- ...cow2-backing-chain-encryption-srconly.json | 8 + .../file-qcow2-backing-chain-encryption.json | 4 +- ...le-qcow2-backing-chain-noopts-srconly.json | 40 ++ .../file-qcow2-backing-chain-noopts.json | 20 +- ...w2-backing-chain-unterminated-srconly.json | 8 + ...file-qcow2-backing-chain-unterminated.json | 4 +- .../xml2json/file-raw-aio_native-srconly.json | 4 + .../xml2json/file-raw-aio_native.json | 2 +- .../xml2json/file-raw-luks-srconly.json | 4 + .../xml2json/file-raw-luks.json | 2 +- .../xml2json/file-raw-noopts-srconly.json | 4 + .../xml2json/file-raw-noopts.json | 2 +- .../xml2json/file-vdi-noopts-srconly.json | 4 + .../xml2json/file-vdi-noopts.json | 2 +- .../xml2json/file-vhd-noopts-srconly.json | 4 + .../xml2json/file-vhd-noopts.json | 2 +- .../xml2json/file-vpc-noopts-srconly.json | 4 + .../xml2json/file-vpc-noopts.json | 2 +- .../xml2json/network-nbd-tls-srconly.json | 8 + .../xml2json/network-nbd-tls.json | 2 +- ...w2-backing-chain-cache-unsafe-srconly.json | 22 + ...work-qcow2-backing-chain-cache-unsafe.json | 4 +- ...backing-chain-encryption_auth-srconly.json | 22 + ...k-qcow2-backing-chain-encryption_auth.json | 4 +- .../qemu-ns.x86_64-4.0.0.args | 2 +- .../qemu-ns.x86_64-latest.args | 2 +- 108 files changed, 1764 insertions(+), 170 deletions(-) create mode 100644 tests/qemublocktestdata/imagecreate/luks-encopts.json create mode 100644 tests/qemublocktestdata/imagecreate/luks-encopts.xml create mode 100644 tests/qemublocktestdata/imagecreate/luks-noopts.json create mode 100644 tests/qemublocktestdata/imagecreate/luks-noopts.xml create mode 100644 tests/qemublocktestdata/imagecreate/network-gluster-qcow2.json create mode 100644 tests/qemublocktestdata/imagecreate/network-gluster-qcow2.xml create mode 100644 tests/qemublocktestdata/imagecreate/network-rbd-qcow2.json create mode 100644 tests/qemublocktestdata/imagecreate/network-rbd-qcow2.xml create mode 100644 tests/qemublocktestdata/imagecreate/network-sheepdog-qcow2.json create mode 100644 tests/qemublocktestdata/imagecreate/network-sheepdog-qcow2.xml create mode 100644 tests/qemublocktestdata/imagecreate/network-ssh-qcow2.json create mode 100644 tests/qemublocktestdata/imagecreate/network-ssh-qcow2.xml create mode 100644 tests/qemublocktestdata/imagecreate/qcow2-backing-luks.json create mode 120000 tests/qemublocktestdata/imagecreate/qcow2-backing-luks.xml create mode 100644 tests/qemublocktestdata/imagecreate/qcow2-backing-raw-nbd.json create mode 120000 tests/qemublocktestdata/imagecreate/qcow2-backing-raw-nbd.xml create mode 100644 tests/qemublocktestdata/imagecreate/qcow2-backing-raw.json create mode 120000 tests/qemublocktestdata/imagecreate/qcow2-backing-raw.xml create mode 100644 tests/qemublocktestdata/imagecreate/qcow2-luks-encopts-backing.json create mode 120000 tests/qemublocktestdata/imagecreate/qcow2-luks-encopts-backing.xml create mode 100644 tests/qemublocktestdata/imagecreate/qcow2-luks-encopts.json create mode 100644 tests/qemublocktestdata/imagecreate/qcow2-luks-encopts.xml create mode 100644 tests/qemublocktestdata/imagecreate/qcow2-luks-noopts.json create mode 100644 tests/qemublocktestdata/imagecreate/qcow2-luks-noopts.xml create mode 100644 tests/qemublocktestdata/imagecreate/qcow2.json create mode 100644 tests/qemublocktestdata/imagecreate/qcow2.xml create mode 100644 tests/qemublocktestdata/imagecreate/raw-nbd.json create mode 100644 tests/qemublocktestdata/imagecreate/raw-nbd.xml create mode 100644 tests/qemublocktestdata/imagecreate/raw.json create mode 100644 tests/qemublocktestdata/imagecreate/raw.xml create mode 100644 tests/qemublocktestdata/xml2json/block-raw-noopts-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/block-raw-reservations-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/dir-fat-cache-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/dir-fat-floppy-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/dir-fat-readonly-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/file-backing_basic-aio_threads-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/file-backing_basic-cache-directsync-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/file-backing_basic-cache-none-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/file-backing_basic-cache-unsafe-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/file-backing_basic-cache-writeback-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/file-backing_basic-cache-writethrough-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/file-backing_basic-detect-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/file-backing_basic-noopts-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/file-backing_basic-unmap-detect-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/file-backing_basic-unmap-ignore-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/file-backing_basic-unmap-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/file-bochs-noopts-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/file-cloop-noopts-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/file-dmg-noopts-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/file-ploop-noopts-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/file-qcow2-backing-chain-encryption-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/file-qcow2-backing-chain-noopts-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/file-qcow2-backing-chain-unterminated-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/file-raw-aio_native-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/file-raw-luks-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/file-raw-noopts-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/file-vdi-noopts-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/file-vhd-noopts-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/file-vpc-noopts-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/network-nbd-tls-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/network-qcow2-backing-chain-cache-unsafe-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/network-qcow2-backing-chain-encryption_auth-srconly.json -- 2.21.0

2 22

[libvirt] [PATCH] m4: Fix check for yajl.pc
by Andrea Bolognani 08 Jul '19

08 Jul '19

Commit 44b8df4cb4b3 introduced a check for yajl.pc that is extremely similar to the one we already had in place for readline.pc - so similar, in fact, that it's still looking for readline.pc instead of yajl.pc :) Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- m4/virt-yajl.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/m4/virt-yajl.m4 b/m4/virt-yajl.m4 index 70cfb983e3..b602abd0a7 100644 --- a/m4/virt-yajl.m4 +++ b/m4/virt-yajl.m4 @@ -24,7 +24,7 @@ AC_DEFUN([LIBVIRT_ARG_YAJL],[ AC_DEFUN([LIBVIRT_CHECK_YAJL],[ dnl YAJL JSON library http://lloyd.github.com/yajl/ - PKG_CHECK_EXISTS([readline], [use_pkgconfig=1], [use_pkgconfig=0]) + PKG_CHECK_EXISTS([yajl], [use_pkgconfig=1], [use_pkgconfig=0]) if test $use_pkgconfig = 1; then dnl 2.0.3 was the version where the pkg-config file was first added -- 2.21.0

2 1

[libvirt] [PATCH 00/23] Use a slirp helper process
by marcandre.lureau＠redhat.com 08 Jul '19

08 Jul '19

From: Marc-André Lureau <marcandre.lureau(a)redhat.com> Hi, SLIRP networking can be running in a separate process. This allows for stricter security policies for QEMU & SLIRP, as SLIRP is notoriously not very safe (discussed on ML, various CVEs, and even the code says so explicitly in the comments), yet people rely on it for various reasons. With this series, for a network interface "user", libvirt will: - check the slirp-helper presence and capabilites (see [1]) - setup a socket pair between qemu and the helper - use -net socket - setup migration thanks to dbus-vmstate There are no changes required to domain configuration to benefit it. "guestfwd" isn't supported at this point, but it is known to be in a broken state with libvirt+qemu anyway. The dbus-vmstate is being proposed to QEMU. The libslirp-rs slirp-helper hasn't yet received a release, but I plan to make one soon, depending on the feedback. fwiw, I have been working on an alternative rust-only implementation of a slirp-helper that will also follow [1]. [1] https://gitlab.freedesktop.org/slirp/libslirp-rs/blob/master/src/bin/README… Marc-André Lureau (23): Add .editorconfig dbus: correctly build reply message qemu: replace logCtxt with qemuDomainLogAppendMessage() qemu: reset VM id after external devices stop qemu: add socket datagram capability qemu: add dbus-vmstate capability qemu-conf: add configurable dbus-daemon location qemu-conf: add dbusStateDir qemu-security: add qemuSecurityCommandRun() qemu: add a DBus daemon helper unit qemu: add dbus-vmstate helper migration support domain-conf: add network def private data qemu: add qemuDomainNetworkPrivate qemu-conf: add configurable slirp-helper location qemu: add slirp helper unit qemu-domain: save and restore slirp state qemu: add a flag to the cookie to prevent slirp-helper setup qemu-migration: prevent migration if slirp cannot be migrated qemu-extdevice: prepare, start and stop slirp-helper qemu-command: use -net socket,fd= with slirp-helper qemu-process: prepare slirp-helper qemu-hotplug: handle hotplugging of slirp-helper tests: add slirp-helper qemuxml2argv test .editorconfig | 21 + m4/virt-driver-qemu.m4 | 10 + src/conf/domain_conf.c | 21 +- src/conf/domain_conf.h | 6 + src/qemu/Makefile.inc.am | 6 + src/qemu/libvirtd_qemu.aug | 2 + src/qemu/qemu.conf | 6 + src/qemu/qemu_alias.c | 7 + src/qemu/qemu_alias.h | 2 + src/qemu/qemu_capabilities.c | 10 + src/qemu/qemu_capabilities.h | 4 + src/qemu/qemu_command.c | 100 ++++- src/qemu/qemu_command.h | 6 +- src/qemu/qemu_conf.c | 20 +- src/qemu/qemu_conf.h | 3 + src/qemu/qemu_dbus.c | 384 ++++++++++++++++ src/qemu/qemu_dbus.h | 44 ++ src/qemu/qemu_domain.c | 206 ++++++++- src/qemu/qemu_domain.h | 27 ++ src/qemu/qemu_driver.c | 11 +- src/qemu/qemu_extdevice.c | 82 ++-- src/qemu/qemu_extdevice.h | 10 +- src/qemu/qemu_hotplug.c | 118 ++++- src/qemu/qemu_hotplug.h | 8 + src/qemu/qemu_interface.c | 27 ++ src/qemu/qemu_interface.h | 4 + src/qemu/qemu_migration.c | 62 +++ src/qemu/qemu_monitor.c | 35 +- src/qemu/qemu_monitor.h | 6 +- src/qemu/qemu_monitor_json.c | 15 + src/qemu/qemu_monitor_json.h | 5 + src/qemu/qemu_process.c | 37 +- src/qemu/qemu_process.h | 1 + src/qemu/qemu_security.c | 22 + src/qemu/qemu_security.h | 6 + src/qemu/qemu_slirp.c | 412 ++++++++++++++++++ src/qemu/qemu_slirp.h | 78 ++++ src/qemu/qemu_tpm.c | 10 +- src/qemu/qemu_tpm.h | 5 +- src/qemu/test_libvirtd_qemu.aug.in | 2 + src/util/virdbus.c | 18 +- src/util/virdbus.h | 6 +- tests/Makefile.am | 1 + .../caps_4.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 1 + .../caps_4.0.0.riscv32.xml | 1 + .../caps_4.0.0.riscv64.xml | 1 + .../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 1 + .../caps_4.0.0.x86_64.xml | 1 + .../caps_4.1.0.x86_64.xml | 1 + .../net-user.x86_64-4.0.0.args | 34 ++ tests/qemuxml2argvtest.c | 16 + tests/testutilsqemu.h | 1 + tests/virfirewalltest.c | 9 +- tests/virpolkittest.c | 3 +- 55 files changed, 1849 insertions(+), 87 deletions(-) create mode 100644 .editorconfig create mode 100644 src/qemu/qemu_dbus.c create mode 100644 src/qemu/qemu_dbus.h create mode 100644 src/qemu/qemu_slirp.c create mode 100644 src/qemu/qemu_slirp.h create mode 100644 tests/qemuxml2argvdata/net-user.x86_64-4.0.0.args -- 2.22.0.214.g8dca754b1e

1 23

[libvirt] [PATCH] libvirt: remove link to outdated mailing list post
by Daniel P. Berrangé 08 Jul '19

08 Jul '19

The virConnectGetType() method has an unfortunate signature, returning a static string that must not be freed by the caller. The remote driver, however, gets this string dynamically over an RPC call, which raised a design discussion on the mailing list. Eventually the problem was resolved by having the remote driver cache the returned string internally and free it when the connection was closed. The link to the mailing list is thus talking about a problem that does not actually exist in the final implementation, and at best serves to confuse the reader into thinking there might be a memory leak. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/libvirt-host.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/libvirt-host.c b/src/libvirt-host.c index 2978825d22..e5c4e5f72a 100644 --- a/src/libvirt-host.c +++ b/src/libvirt-host.c @@ -98,9 +98,6 @@ virConnectSupportsFeature(virConnectPtr conn, int feature) * hypervisor, use virConnectGetCapabilities(). * * Returns NULL in case of error, a static zero terminated string otherwise. - * - * See also: - * http://www.redhat.com/archives/libvir-list/2007-February/msg00096.html */ const char * virConnectGetType(virConnectPtr conn) -- 2.21.0

2 1

[libvirt] [PATCH v8 00/21] Incremental backups
by Eric Blake 07 Jul '19

07 Jul '19

The API is fairly stable, but there are still probably code cleanups worth adding to the qemu driver implementation. I've also seen a desire on the list to support all APIs in the test driver, so I'll try and whip that together for my next round of patches. If we are confident that the API is worth having in 5.3 (especially since the earlier part of this series already has positive reviews), then it's probably worth committing that part of the series now even while I still address review comments on the later patches. I've pushed a tag backup-v8 to both my libvirt.git and libvirt-python.git repos to match: https://repo.or.cz/libvirt/ericb.git/shortlog/refs/tags/backup-v8 https://repo.or.cz/libvirt-python/ericb.git/shortlog/refs/tags/backup-v8 Here's hoping we're happy enough with the API, including the fact that rudimentary operation of pull mode backups work with qemu 4.0-rc1, for this to make it into the 5.2 release. Notable diffs from v7: - address several review comments (although I didn't get to every comment later in the series) - actually support job id of 0 (it was documented but not working in v7) - add support for Unix socket pull mode backups - improve checkpoint XML handling (more tests, separate postparse actions out from initial parse) - rebase to master 001/21:[0044] [FC] 'backup: Document new XML for checkpoints' 002/21:[----] [--] 'backup: Document new XML for backups' 003/21:[0006] [FC] 'backup: Introduce virDomainCheckpoint APIs' 004/21:[0002] [FC] 'backup: Introduce virDomainBackup APIs' 005/21:[----] [--] 'backup: Document nuances between different state capture APIs' 006/21:[0304] [FC] 'backup: Parse and output checkpoint XML' 007/21:[0007] [FC] 'backup: Allow for lists of checkpoint objects' 008/21:[0004] [FC] 'backup: Add new domain:checkpoint access control' 009/21:[0043] [FC] 'backup: Implement backup APIs for remote driver' 010/21:[down] 'conf: Add parameter to virDomainDiskSourceFormat' 011/21:[0019] [FC] 'backup: Parse and output backup XML' 012/21:[0006] [FC] 'backup: Implement virsh support for checkpoints' 013/21:[0002] [FC] 'backup: Implement virsh support for backup' 014/21:[down] 'backup: Prepare for Unix sockets in QMP nbd-server-start' 015/21:[0008] [FC] 'backup: Add new qemu monitor interactions' 016/21:[0022] [FC] 'backup: qemu: Implement metadata tracking for checkpoint APIs' 017/21:[0004] [FC] 'backup: Wire up qemu checkpoint commands over QMP' 018/21:[0019] [FC] 'backup: qemu: Implement framework for backup job APIs' 019/21:[0042] [FC] 'backup: Wire up qemu full pull backup commands over QMP' 020/21:[----] [-C] 'backup: qemu: Wire up qemu full push backup commands over QMP' 021/21:[0003] [FC] 'backup: implement qemu incremental pull backup' Eric Blake (21): backup: Document new XML for checkpoints backup: Document new XML for backups backup: Introduce virDomainCheckpoint APIs backup: Introduce virDomainBackup APIs backup: Document nuances between different state capture APIs backup: Parse and output checkpoint XML backup: Allow for lists of checkpoint objects backup: Add new domain:checkpoint access control backup: Implement backup APIs for remote driver conf: Add parameter to virDomainDiskSourceFormat backup: Parse and output backup XML backup: Implement virsh support for checkpoints backup: Implement virsh support for backup backup: Prepare for Unix sockets in QMP nbd-server-start backup: Add new qemu monitor interactions backup: qemu: Implement metadata tracking for checkpoint APIs backup: Wire up qemu checkpoint commands over QMP backup: qemu: Implement framework for backup job APIs backup: Wire up qemu full pull backup commands over QMP backup: qemu: Wire up qemu full push backup commands over QMP backup: implement qemu incremental pull backup include/libvirt/libvirt-domain-checkpoint.h | 161 ++ include/libvirt/libvirt-domain-snapshot.h | 8 +- include/libvirt/libvirt-domain.h | 47 +- include/libvirt/libvirt.h | 5 +- src/access/viraccessperm.h | 6 + src/conf/backup_conf.h | 97 + src/conf/checkpoint_conf.h | 103 ++ src/conf/domain_conf.h | 3 + src/conf/virconftypes.h | 12 + src/conf/virdomaincheckpointobjlist.h | 74 + src/conf/virdomainmomentobjlist.h | 7 +- src/conf/virdomainobjlist.h | 7 +- src/driver-hypervisor.h | 79 + src/qemu/qemu_block.h | 3 + src/qemu/qemu_blockjob.h | 1 + src/qemu/qemu_capabilities.h | 2 + src/qemu/qemu_conf.h | 2 + src/qemu/qemu_domain.h | 19 + src/qemu/qemu_monitor.h | 27 +- src/qemu/qemu_monitor_json.h | 22 +- tools/virsh-checkpoint.h | 29 + tools/virsh-completer.h | 4 + tools/virsh-util.h | 3 + tools/virsh.h | 1 + docs/Makefile.am | 3 + docs/apibuild.py | 2 + docs/docs.html.in | 10 +- docs/domainstatecapture.html.in | 315 ++++ docs/format.html.in | 2 + docs/formatbackup.html.in | 184 ++ docs/formatcheckpoint.html.in | 204 +++ docs/formatsnapshot.html.in | 2 + docs/index.html.in | 4 +- docs/schemas/domainbackup.rng | 219 +++ docs/schemas/domaincheckpoint.rng | 87 + examples/object-events/event-test.c | 3 + libvirt.spec.in | 3 + mingw-libvirt.spec.in | 6 + po/POTFILES | 3 + src/Makefile.am | 2 + src/access/viraccessperm.c | 3 +- src/conf/Makefile.inc.am | 6 + src/conf/backup_conf.c | 538 ++++++ src/conf/checkpoint_conf.c | 636 +++++++ src/conf/domain_conf.c | 22 +- src/conf/snapshot_conf.c | 3 +- src/conf/virdomaincheckpointobjlist.c | 223 +++ src/conf/virdomainmomentobjlist.c | 40 +- src/conf/virdomainobjlist.c | 11 + src/conf/virdomainsnapshotobjlist.c | 2 +- src/libvirt-domain-checkpoint.c | 750 ++++++++ src/libvirt-domain-snapshot.c | 89 + src/libvirt-domain.c | 237 ++- src/libvirt_private.syms | 32 + src/libvirt_public.syms | 24 + src/qemu/qemu_block.c | 12 + src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_conf.c | 5 + src/qemu/qemu_domain.c | 221 ++- src/qemu/qemu_driver.c | 1577 +++++++++++++++++ src/qemu/qemu_migration.c | 9 +- src/qemu/qemu_monitor.c | 72 +- src/qemu/qemu_monitor_json.c | 222 ++- src/qemu/qemu_process.c | 9 + src/remote/remote_daemon_dispatch.c | 20 + src/remote/remote_driver.c | 32 +- src/remote/remote_protocol.x | 258 ++- src/remote_protocol-structs | 139 ++ src/rpc/gendispatch.pl | 32 +- tests/Makefile.am | 13 +- tests/domainbackupxml2xmlin/backup-pull.xml | 9 + tests/domainbackupxml2xmlin/backup-push.xml | 9 + tests/domainbackupxml2xmlin/empty.xml | 1 + tests/domainbackupxml2xmlout/backup-pull.xml | 9 + tests/domainbackupxml2xmlout/backup-push.xml | 9 + tests/domainbackupxml2xmlout/empty.xml | 7 + tests/domaincheckpointxml2xmlin/empty.xml | 1 + tests/domaincheckpointxml2xmlin/sample.xml | 7 + tests/domaincheckpointxml2xmlin/size.xml | 4 + tests/domaincheckpointxml2xmlout/empty.xml | 7 + .../internal-active-invalid.xml | 53 + .../internal-inactive-invalid.xml | 53 + tests/domaincheckpointxml2xmlout/redefine.xml | 63 + tests/domaincheckpointxml2xmlout/sample.xml | 12 + tests/domaincheckpointxml2xmlout/size.xml | 11 + tests/domaincheckpointxml2xmltest.c | 223 +++ tests/qemublocktest.c | 3 +- .../caps_4.0.0.riscv32.xml | 2 + .../caps_4.0.0.riscv64.xml | 2 + .../caps_4.0.0.x86_64.xml | 2 + tests/qemumonitorjsontest.c | 32 +- tests/virschematest.c | 4 + tests/virstoragetest.c | 2 +- tools/Makefile.am | 1 + tools/virsh-checkpoint.c | 1370 ++++++++++++++ tools/virsh-completer.c | 51 + tools/virsh-domain-monitor.c | 23 + tools/virsh-domain.c | 268 ++- tools/virsh-snapshot.c | 37 +- tools/virsh-util.c | 11 + tools/virsh.c | 2 + tools/virsh.pod | 302 +++- 102 files changed, 9502 insertions(+), 100 deletions(-) create mode 100644 include/libvirt/libvirt-domain-checkpoint.h create mode 100644 src/conf/backup_conf.h create mode 100644 src/conf/checkpoint_conf.h create mode 100644 src/conf/virdomaincheckpointobjlist.h create mode 100644 tools/virsh-checkpoint.h create mode 100644 docs/domainstatecapture.html.in create mode 100644 docs/formatbackup.html.in create mode 100644 docs/formatcheckpoint.html.in create mode 100644 docs/schemas/domainbackup.rng create mode 100644 docs/schemas/domaincheckpoint.rng create mode 100644 src/conf/backup_conf.c create mode 100644 src/conf/checkpoint_conf.c create mode 100644 src/conf/virdomaincheckpointobjlist.c create mode 100644 src/libvirt-domain-checkpoint.c create mode 100644 tests/domainbackupxml2xmlin/backup-pull.xml create mode 100644 tests/domainbackupxml2xmlin/backup-push.xml create mode 100644 tests/domainbackupxml2xmlin/empty.xml create mode 100644 tests/domainbackupxml2xmlout/backup-pull.xml create mode 100644 tests/domainbackupxml2xmlout/backup-push.xml create mode 100644 tests/domainbackupxml2xmlout/empty.xml create mode 100644 tests/domaincheckpointxml2xmlin/empty.xml create mode 100644 tests/domaincheckpointxml2xmlin/sample.xml create mode 100644 tests/domaincheckpointxml2xmlin/size.xml create mode 100644 tests/domaincheckpointxml2xmlout/empty.xml create mode 100644 tests/domaincheckpointxml2xmlout/internal-active-invalid.xml create mode 100644 tests/domaincheckpointxml2xmlout/internal-inactive-invalid.xml create mode 100644 tests/domaincheckpointxml2xmlout/redefine.xml create mode 100644 tests/domaincheckpointxml2xmlout/sample.xml create mode 100644 tests/domaincheckpointxml2xmlout/size.xml create mode 100644 tests/domaincheckpointxml2xmltest.c create mode 100644 tools/virsh-checkpoint.c -- 2.20.1

2 46

[libvirt] [PATCH] docs: minor updates to to new API doc
by Jonathon Jongsma 05 Jul '19

05 Jul '19

Fix a filename and add a couple missing words. Signed-off-by: Jonathon Jongsma <jjongsma(a)redhat.com> --- docs/api_extension.html.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/api_extension.html.in b/docs/api_extension.html.in index d7fbbd6e90..3bbaf4893c 100644 --- a/docs/api_extension.html.in +++ b/docs/api_extension.html.in @@ -229,7 +229,7 @@ <h3><a name='rpcclient'>Implement the RPC client</a></h3> <p> - Implementing the uses the rpcgen generated .h files. The remote + Implementing the RPC client uses the rpcgen generated .h files. The remote method calls go in: </p> @@ -256,7 +256,7 @@ The server side dispatchers are implemented in: </p> - <p><code>src/remote/daemon_dispatch.c</code></p> + <p><code>src/remote/remote_daemon_dispatch.c</code></p> <p>Again, this step uses the .h files generated by make rpcgen.</p> -- 2.20.1

2 1

[libvirt] [PATCH] tests: fix mocking of virFileGetXAttrQuiet on FreeBSD
by Daniel P. Berrangé 05 Jul '19

05 Jul '19

The qemusecuritytest is failing on FreeBSD 11/12, reporting that files are not correctly restored. Debugging code printfs show that the virFileGetXAttrQuiet mock is returning 0, but the virFileGetXAttr function is seeing -1 as the return value. Essentially there appears to be some kind of optimization between the real virFileGetXAttrQuiet and the real virFileGetXAttr, which breaks when we mock virFileGetXAttrQuiet. Rather than trying to figure out how to avoid this, it is simpler to just mock virFileGetXAttr too since it is very short code. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Pushed as a CI build fix tests/qemusecuritymock.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/tests/qemusecuritymock.c b/tests/qemusecuritymock.c index 2a9095e1bf..a15eef29c9 100644 --- a/tests/qemusecuritymock.c +++ b/tests/qemusecuritymock.c @@ -156,6 +156,34 @@ virFileGetXAttrQuiet(const char *path, } +/* + * This may look redundant but is needed to work around an + * compiler quirk. The call from the real virFileGetXAttr + * to the real virFileGetXAttrQuiet has a quirk where the + * return value from virFileGetXAttrQuiet gets scrambled + * if we mock virFileGetXAttrQuiet, returning -1 instead + * of 0 despite succeeding. This happens on FreeBSD 11/12 + * hosts with CLang, and is suspected to be some kind of + * compiler optimization. By mocking this function too we + * can workaround it. + */ +int +virFileGetXAttr(const char *path, + const char *name, + char **value) +{ + int ret; + + if ((ret = virFileGetXAttrQuiet(path, name, value)) < 0) { + virReportSystemError(errno, + "Unable to get XATTR %s on %s", + name, path); + } + + return ret; +} + + int virFileSetXAttr(const char *path, const char *name, const char *value) -- 2.21.0

1 0

Re: [libvirt] [libvirt-users] UDP broadcasts vs. nat Masquerading issue
by Nikolai Zhubr 05 Jul '19

05 Jul '19

Hi Daniel and Laine, [...] >> -A POSTROUTING -o br0 -j MASQUERADE >> -A POSTROUTING -o enp0s25 -j MASQUERADE >> -A POSTROUTING -o virbr2_nic -j MASQUERADE >> -A POSTROUTING -o vnet0 -j MASQUERADE > > *None* of those rules were added by libvirt (unless your build of [...] > You can verify my "counter-claim" by running "virsh net-destroy" for all > of your libvirt networks, and seeing that the offending rules haven't > been removed. > > In short, you need to look elsewhere for the culprit. Yes, found it. You were both right, essentially. The offending rules were added by a firewall in response to new interfaces created by libvirt dynamically, due to some dubious relict settings left in the firewall. (Silly me.) So this it not an issue of libvirt indeed! Tons of thanks for the quick and precise hit! Regards, Nikolai >> >> Here, virbr2_nic and vnet0 are used by libvirt for arranging network >> configurations for VMs, ok. However, br0 is a main interface of this >> host with primary ip address, with enp0s25 being a physical nic of >> this host, and it is used for all sorts of regular (unrelated to >> virtualization) communications. Also, br0 is used for attaching >> bridged (as opposed to NATed) VMs managed by libvirt. >> >> Clearly, libvirt somehow chooses to set up masquerading for literally >> all existing network interfaces here (except lo), > > It's clear that the rules are there. It's not clear that they were added > by libvirt. > >> but I can't see a real reason for the first two rules in the list >> above. Furthermore, they corrupt UDP broadcats coming from outside and >> reaching this host (through enp0s25/br0) such that source address gets >> replaced by this hosts primary address (as per masquerading). I've >> verified this by arranging a hand-crafted UDP listener and printing >> the respective source addresses as seen by normal userspace. >> >> Now I've discovered that I can "eliminate" the problem by either: >> >> 1. Removing "-A POSTROUTING -o br0 -j MASQUERADE" (manually) >> 2. Inserting "-A POSTROUTING -s 192.168.0.0/24 -d 192.168.0.255/32 -j >> ACCEPT" >> (Of course correcting rules by hand is not a solution, just a test) >> >> So question is, how the correct rules should ideally look like? And, >> is this issue known/fixed in most current libvirt? > > Except for putting the libvirt-added rules in their own private chains > (appearing in libvirt 5.1.0, released on Feb 1, 2019), the iptables > rules added by libvirt to support its virtual networks didn't materially > change in > 10 years. Your email is the first time I've ever seen such > rules attributed to libvirt so, as I said above, I think you need to > take a deeper dive into your host system's config. > > > Good luck! >

2 1

[libvirt] [PATCH 0/3] remote: misc cleanups to client driver
by Daniel P. Berrangé 05 Jul '19

05 Jul '19

A few bits of cleanup identified during work on the daemon splitting patches sent now since they are independent. Daniel P. Berrangé (3): remote: stop declaring variables in the middle of a function remote: use autofree for many string variables remote: conditionally declare tty variable for non-Win32 platforms src/remote/remote_driver.c | 61 ++++++++++++++------------------------ 1 file changed, 23 insertions(+), 38 deletions(-) -- 2.21.0

2 4

[libvirt] [PATCH rust 0/5] ci related plus some small updates
by Sahid Orentino Ferdjaoui 05 Jul '19

05 Jul '19

Hello Daniel, When you have a moment, can you please merge this serie. It fixes CI issue, switch to bionic, and updates the tested versions. Results: https://travis-ci.org/sahid/libvirt-rust/builds/554170698 Thanks, s. Sahid Orentino Ferdjaoui (5): fix bug integration test with rust multithreading make lookup_by_id() test more robust update tested versions from 2.5.0 to 5.5.0 switch to the last ubuntu lts bionic fix code formating in README .travis.yml | 10 +++++----- README.md | 6 +++++- tests/domain.rs | 19 +++++++++---------- tests/integration_qemu.rs | 15 +++++++++++---- tests/libvirtd.sasl | 2 ++ 5 files changed, 32 insertions(+), 20 deletions(-) create mode 100644 tests/libvirtd.sasl -- 2.20.1

2 14

[libvirt] [PATCH v2 0/4] test_driver: implement some DomainGetParametersAPIs
by Ilias Stamatis 04 Jul '19

04 Jul '19

Changes since v1: - undefine the macro introduced in 1/4 when done with it's usage - simplified 4/4 by using the virNetDevBandwidthRate struct Ilias Stamatis (4): test_driver: introduce TEST_SET_PARAM macro test_driver: implement virDomainGetMemoryParameters test_driver: implement virDomainGetNumaParameters test_driver: implement testDomainGetInterfaceParameters src/test/test_driver.c | 154 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 154 insertions(+) -- 2.22.0

2 7

[libvirt] [PATCH] test_driver: avoid using nerrors unitialized in testDomainGetDiskErrors
by Ilias Stamatis 04 Jul '19

04 Jul '19

Right now nerrors can be used unitialized in the last for loop causing a bug. Signed-off-by: Ilias Stamatis <stamatis.iliass(a)gmail.com> --- src/test/test_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index ce4ff1a582..2371581f51 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -3275,7 +3275,7 @@ static int testDomainGetDiskErrors(virDomainPtr dom, virDomainObjPtr vm = NULL; int ret = -1; size_t i; - size_t nerrors; + size_t nerrors = 0; virCheckFlags(0, -1); -- 2.22.0

2 1

[libvirt] [PATCH] test: ensure nerrors variable is initialized
by Daniel P. Berrangé 04 Jul '19

04 Jul '19

There is an error path that jumps over the initialization of nerrors, and the jump target reads the variable contents. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Pushed as a build fix src/test/test_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index ce4ff1a582..2371581f51 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -3275,7 +3275,7 @@ static int testDomainGetDiskErrors(virDomainPtr dom, virDomainObjPtr vm = NULL; int ret = -1; size_t i; - size_t nerrors; + size_t nerrors = 0; virCheckFlags(0, -1); -- 2.21.0

1 0

[libvirt] [PATCH] test_driver: sanitize user-provided array in testDomainGetDiskErrors
by Ilias Stamatis 04 Jul '19

04 Jul '19

Zero out the user provided memory in order to avoid passing random pointers to VIR_FREE later. Signed-off-by: Ilias Stamatis <stamatis.iliass(a)gmail.com> --- src/test/test_driver.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 7c58d2c8ce..8ee1f0cad6 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -3275,6 +3275,7 @@ static int testDomainGetDiskErrors(virDomainPtr dom, virDomainObjPtr vm = NULL; int ret = -1; size_t i; + size_t nerrors; virCheckFlags(0, -1); @@ -3284,8 +3285,13 @@ static int testDomainGetDiskErrors(virDomainPtr dom, if (virDomainObjCheckActive(vm) < 0) goto cleanup; + nerrors = MIN(vm->def->ndisks, maxerrors); + if (errors) { - for (i = 0; i < MIN(vm->def->ndisks, maxerrors); i++) { + /* sanitize input */ + memset(errors, 0, sizeof(virDomainDiskError) * nerrors); + + for (i = 0; i < nerrors; i++) { if (VIR_STRDUP(errors[i].disk, vm->def->disks[i]->dst) < 0) goto cleanup; errors[i].error = (i % (VIR_DOMAIN_DISK_ERROR_LAST - 1)) + 1; @@ -3297,7 +3303,7 @@ static int testDomainGetDiskErrors(virDomainPtr dom, cleanup: if (ret < 0) { - for (i = 0; i < MIN(vm->def->ndisks, maxerrors); i++) + for (i = 0; i < nerrors; i++) VIR_FREE(errors[i].disk); } virDomainObjEndAPI(&vm); -- 2.22.0

3 2

[libvirt] [PATCH] test_driver: Implement virDomainSetPerfEvents
by Ilias Stamatis 04 Jul '19

04 Jul '19

Signed-off-by: Ilias Stamatis <stamatis.iliass(a)gmail.com> --- src/test/test_driver.c | 64 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 64 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 7c58d2c8ce..9974eba882 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -3372,6 +3372,69 @@ testDomainGetFSInfo(virDomainPtr dom, } +static int +testDomainSetPerfEvents(virDomainPtr dom, + virTypedParameterPtr params, + int nparams, + unsigned int flags) +{ + virDomainObjPtr vm = NULL; + virDomainDefPtr def = NULL; + size_t i; + int ret = -1; + + virCheckFlags(VIR_DOMAIN_AFFECT_LIVE | + VIR_DOMAIN_AFFECT_CONFIG, -1); + + if (virTypedParamsValidate(params, nparams, + VIR_PERF_PARAM_CMT, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_MBMT, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_MBML, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_CPU_CYCLES, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_INSTRUCTIONS, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_CACHE_REFERENCES, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_CACHE_MISSES, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_BRANCH_INSTRUCTIONS, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_BRANCH_MISSES, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_BUS_CYCLES, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_STALLED_CYCLES_FRONTEND, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_STALLED_CYCLES_BACKEND, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_REF_CPU_CYCLES, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_CPU_CLOCK, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_TASK_CLOCK, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_PAGE_FAULTS, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_CONTEXT_SWITCHES, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_CPU_MIGRATIONS, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_PAGE_FAULTS_MIN, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_PAGE_FAULTS_MAJ, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_ALIGNMENT_FAULTS, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_EMULATION_FAULTS, VIR_TYPED_PARAM_BOOLEAN, + NULL) < 0) + return -1; + + if (!(vm = testDomObjFromDomain(dom))) + return -1; + + if (!(def = virDomainObjGetOneDef(vm, flags))) + goto cleanup; + + for (i = 0; i < nparams; i++) { + virTypedParameterPtr param = &params[i]; + virPerfEventType type = virPerfEventTypeFromString(param->field); + + if (param->value.b) + def->perf.events[type] = VIR_TRISTATE_BOOL_YES; + else + def->perf.events[type] = VIR_TRISTATE_BOOL_NO; + } + + ret = 0; + cleanup: + virDomainObjEndAPI(&vm); + return ret; +} + + static int testDomainGetPerfEvents(virDomainPtr dom, virTypedParameterPtr *params, @@ -7410,6 +7473,7 @@ static virHypervisorDriver testHypervisorDriver = { .domainSetAutostart = testDomainSetAutostart, /* 0.3.2 */ .domainGetDiskErrors = testDomainGetDiskErrors, /* 5.4.0 */ .domainGetFSInfo = testDomainGetFSInfo, /* 5.6.0 */ + .domainSetPerfEvents = testDomainSetPerfEvents, /* 5.6.0 */ .domainGetPerfEvents = testDomainGetPerfEvents, /* 5.6.0 */ .domainGetSchedulerType = testDomainGetSchedulerType, /* 0.3.2 */ .domainGetSchedulerParameters = testDomainGetSchedulerParameters, /* 0.3.2 */ -- 2.22.0

2 1

[libvirt] [PULL 0/4] Python queue, 2019-07-01
by Eduardo Habkost 04 Jul '19

04 Jul '19

The following changes since commit 7d0e02405fc02a181319b1ab8681d2f72246b7c6: Merge remote-tracking branch 'remotes/vivier2/tags/trivial-patches-pull-request' into staging (2019-07-01 17:40:32 +0100) are available in the Git repository at: git://github.com/ehabkost/qemu.git tags/python-next-pull-request for you to fetch changes up to e5abf59eae5990296c243202f95f801495c52e76: Deprecate Python 2 support (2019-07-01 19:02:10 -0300) ---------------------------------------------------------------- Python queue, 2019-07-01 * Deprecate Python 2 support (Eduardo Habkost) * qemu/__init__.py refactor (John Snow) * make qmp-shell work with python3 (Igor Mammedov) ---------------------------------------------------------------- Eduardo Habkost (1): Deprecate Python 2 support Igor Mammedov (1): qmp: make qmp-shell work with python3 John Snow (2): python/qemu: split QEMUMachine out from underneath __init__.py machine.py: minor delinting configure | 8 + scripts/render_block_graph.py | 2 +- python/qemu/__init__.py | 502 +------------------- python/qemu/machine.py | 531 ++++++++++++++++++++++ python/qemu/qtest.py | 2 +- qemu-deprecated.texi | 8 + scripts/device-crash-test | 2 +- scripts/qmp/qmp-shell | 5 +- tests/acceptance/avocado_qemu/__init__.py | 2 +- tests/acceptance/virtio_version.py | 2 +- tests/migration/guestperf/engine.py | 24 +- tests/qemu-iotests/235 | 2 +- tests/vm/basevm.py | 3 +- 13 files changed, 572 insertions(+), 521 deletions(-) create mode 100644 python/qemu/machine.py -- 2.18.0.rc1.1.g3f1ff2140

2 5