- Devel - libvirt List Archives

[libvirt] [PATCH] tests: virpcimock: remove unused variable 'devid'
by Ján Tomko 19 Aug '19

19 Aug '19

virpcimock.c:685:26: error: unused variable 'devid' [-Werror,-Wunused-variable] VIR_AUTOFREE(char *) devid = NULL; ^ Fixes: 76b42294380d40282ed29560e4ae4a7491b9df05 Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Pushed as a trivial build fix. tests/virpcimock.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/virpcimock.c b/tests/virpcimock.c index 09a6c648af..ca6cc060fd 100644 --- a/tests/virpcimock.c +++ b/tests/virpcimock.c @@ -682,7 +682,6 @@ pci_driver_find_by_path(const char *path) static struct pciDriver * pci_driver_find_by_driver_override(struct pciDevice *dev) { - VIR_AUTOFREE(char *) devid = NULL; VIR_AUTOFREE(char *) path = NULL; char tmp[32]; size_t i; -- 2.20.1

1 0

[libvirt] [PATCH] test_driver: implement virDomainSetBlockThreshold
by Ilias Stamatis 17 Aug '19

17 Aug '19

Store disk name - threshold pairs in vm-private data so they can be retrieved by virConnectGetAllDomainStats later. Signed-off-by: Ilias Stamatis <stamatis.iliass(a)gmail.com> --- src/test/test_driver.c | 91 +++++++++++++++++++++++++++++++++++++++++- src/test/test_driver.h | 9 +++++ 2 files changed, 98 insertions(+), 2 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 9bf3728654..0b4646b0bb 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -396,6 +396,10 @@ struct _testDomainObjPrivate { /* used by get/set time APIs */ long long seconds; unsigned int nseconds; + + /* used by domainSetBlockThreshold */ + size_t num_thresholds; + testBlockThresholdPtr *thresholds; }; @@ -413,6 +417,9 @@ testDomainObjPrivateAlloc(void *opaque) priv->seconds = 627319920; priv->nseconds = 0; + priv->num_thresholds = 0; + priv->thresholds = NULL; + return priv; } @@ -3974,6 +3981,71 @@ testDomainGetBlockIoTune(virDomainPtr dom, #undef TEST_SET_PARAM +static int +testDomainSetBlockThreshold(virDomainPtr dom, + const char *dev, + unsigned long long threshold, + unsigned int flags) +{ + virDomainObjPtr vm = NULL; + virDomainDiskDefPtr disk; + testDomainObjPrivatePtr priv; + testBlockThresholdPtr blockthreshold = NULL; + size_t i; + int ret = -1; + + virCheckFlags(0, -1); + + if (!(vm = testDomObjFromDomain(dom))) + return -1; + + if (virDomainObjCheckActive(vm) < 0) + goto cleanup; + + if (!(disk = virDomainDiskByName(vm->def, dev, true))) { + virReportError(VIR_ERR_INVALID_ARG, + _("failed to find disk '%s'"), + dev); + goto cleanup; + } + + priv = vm->privateData; + + for (i = 0; i < priv->num_thresholds; i++) { + if (STREQ(dev, priv->thresholds[i]->name)) { + blockthreshold = priv->thresholds[i]; + break; + } + } + + if (blockthreshold != NULL) { + blockthreshold->threshold = threshold; + } else { + /* disk not found. add it to the list */ + if (VIR_ALLOC(blockthreshold) < 0) + goto cleanup; + if (VIR_STRDUP(blockthreshold->name, dev) < 0) + goto cleanup; + + blockthreshold->threshold = threshold; + + if (VIR_APPEND_ELEMENT(priv->thresholds, priv->num_thresholds, + blockthreshold) < 0) + goto cleanup; + } + + ret = 0; + + cleanup: + if (ret < 0 && blockthreshold != NULL) { + VIR_FREE(blockthreshold->name); + VIR_FREE(blockthreshold); + } + virDomainObjEndAPI(&vm); + return ret; +} + + static int testConnectNumOfDefinedDomains(virConnectPtr conn) { testDriverPtr privconn = conn->privateData; @@ -5070,10 +5142,12 @@ testDomainDeviceOperation(testDriverPtr driver, virTestDeviceOperation operation, const char *xml, const char *alias, + virDomainObjPtr vm, virDomainDefPtr def) { virDomainDeviceDefPtr dev = NULL; unsigned int parse_flags = VIR_DOMAIN_DEF_PARSE_INACTIVE; + size_t i; int ret = -1; if (operation == TEST_DEVICE_DETACH) @@ -5097,6 +5171,17 @@ testDomainDeviceOperation(testDriverPtr driver, case TEST_DEVICE_DETACH: if (testDomainDetachDeviceLiveAndConfig(def, dev) < 0) goto cleanup; + + if (dev->type == VIR_DOMAIN_DEVICE_DISK) { + testDomainObjPrivatePtr priv = vm->privateData; + + for (i = 0; i < priv->num_thresholds; i++) { + if (STREQ(dev->data.disk->dst, priv->thresholds[i]->name)) { + VIR_DELETE_ELEMENT(priv->thresholds[i], i, priv->num_thresholds); + break; + } + } + } break; case TEST_DEVICE_UPDATE: if (testDomainUpdateDeviceLiveAndConfig(def, dev) < 0) @@ -5137,12 +5222,13 @@ testDomainAttachDetachUpdateDevice(virDomainPtr dom, goto cleanup; if (persistentDef) { - if (testDomainDeviceOperation(driver, operation, xml, alias, persistentDef) < 0) + if (testDomainDeviceOperation(driver, operation, xml, alias, vm, + persistentDef) < 0) goto cleanup; } if (def) { - if (testDomainDeviceOperation(driver, operation, xml, alias, def) < 0) + if (testDomainDeviceOperation(driver, operation, xml, alias, vm, def) < 0) goto cleanup; } @@ -10001,6 +10087,7 @@ static virHypervisorDriver testHypervisorDriver = { .domainGetInterfaceParameters = testDomainGetInterfaceParameters, /* 5.6.0 */ .domainSetBlockIoTune = testDomainSetBlockIoTune, /* 5.7.0 */ .domainGetBlockIoTune = testDomainGetBlockIoTune, /* 5.7.0 */ + .domainSetBlockThreshold = testDomainSetBlockThreshold, /* 5.7.0 */ .connectListDefinedDomains = testConnectListDefinedDomains, /* 0.1.11 */ .connectNumOfDefinedDomains = testConnectNumOfDefinedDomains, /* 0.1.11 */ .domainCreate = testDomainCreate, /* 0.1.11 */ diff --git a/src/test/test_driver.h b/src/test/test_driver.h index 8c8a462db7..bcb5ffd7a4 100644 --- a/src/test/test_driver.h +++ b/src/test/test_driver.h @@ -23,4 +23,13 @@ #include "internal.h" + +typedef struct _testBlockThreshold testBlockThreshold; +typedef testBlockThreshold *testBlockThresholdPtr; + +struct _testBlockThreshold { + char *name; + unsigned long long threshold; +}; + int testRegister(void); -- 2.22.0

1 0

[libvirt] [PATCH 00/18] Enhance virpcimock and test VFIO instead of KVM
by Michal Privoznik 17 Aug '19

17 Aug '19

Kernel structure looks slightly different than what virpcimock creates. This did not use to be a problem, because we are testing KVM device assignment even though majority of systems we run on (if not all of them) use VFIO assignment. In order to switch our test suite (mainly virhostdevtest and virpcitest) to test VFIO assignment, the virpcimock must be fixed. Firstly, it needs to create symlinks under /sys/kernel/iommu_groups/... directories (patch 13/18) so that virhostdev module can iterate over them. Secondly, it needs to create 'driver_override' file (which exists since kernel-3.16.0) so that the virtual environment the mock creates matches real up to date systems (patch 03/18). Funny thing is, that enhancing the mock uncovered a bug we had (fix is in 15/18) and also one latent bug (14/18). As usual, these patches can be found on my github too: https://github.com/zippy2/libvirt/tree/virpcimock and just for the fun of it, here's the latest travis build of that branch: https://travis-ci.org/zippy2/libvirt/builds/571752953 Michal Prívozník (18): virpcimock: Move actions checking one level up Revert "virpcitest: Test virPCIDeviceDetach failure" virpcimock: Create driver_override file in device dirs virpcimock: Drop needless typecast virpcimock: Use VIR_AUTOFREE() virpcimock: Eliminate use of @fakesysfspcidir virpcimock: Rename @fakesysfspcidir virpcimock: Create devices/ and drivers/ under /sys/bus/pci upfront virpcimock: Introduce and use pci_device_get_path() virpcimock: Introduce and use pci_driver_get_path() virpcimock: Store PCI address as ints not string virpcimock: Create PCI devices under /sys/devices/pci* virpcimock: Create symlink in /sys/kernel/iommu_groups/N/devices dir virhostdev: Check driver name too in virHostdevIsPCINodeDeviceUsed() virhostdev: Unify virHostdevPreparePCIDevices behaviour for KVM and VFIO cases qemuxml2argvtest: Switch to modern vfio backend virhostdevtest: Use modern VFIO virpcitest: Use modern VFIO src/util/virhostdev.c | 26 +- .../hostdev-pci-address-device.args | 2 +- .../qemuxml2argvdata/hostdev-pci-address.args | 2 +- .../net-hostdev-bootorder.args | 3 +- .../net-hostdev-multidomain.args | 2 +- tests/qemuxml2argvdata/net-hostdev.args | 2 +- tests/qemuxml2argvdata/pci-rom.args | 4 +- tests/qemuxml2argvtest.c | 14 +- tests/virhostdevtest.c | 4 +- tests/virpcimock.c | 394 ++++++++++++------ tests/virpcitest.c | 48 +-- 11 files changed, 304 insertions(+), 197 deletions(-) -- 2.21.0

3 44

[libvirt] [PATCH v2 0/6] test_driver: implement device attach/detach APIs
by Ilias Stamatis 16 Aug '19

16 Aug '19

This series needed a respin since there were conflicts when trying to apply on the current master. Ilias Stamatis (6): test_driver: implement virDomainAttachDeviceFlags test_driver: implement virDomainAttachDevice test_driver: implement virDomainDetachDeviceFlags test_driver: implement virDomainDetachDevice test_driver: implement virDomainDetachDeviceAlias test_driver: implement virDomainUpdateDeviceFlags src/test/test_driver.c | 569 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 569 insertions(+) -- 2.22.0

2 14

[libvirt] [PATCH v2 0/7] PCI Multifunction hotplug/unplug, part 1
by Daniel Henrique Barboza 16 Aug '19

16 Aug '19

v2: - rebased without 3 patches from Michal that are under review in his NVMe patch series This is the first part of the feature discussed at [1]. These patches are mostly cleanup and fixes, thus it is beneficial to have them upstream right away. The whole feature can be checked out at [2]. All patches survives unit testing. The feature was stress tested with hundreds of consecutive hotplug/unplugs of a Broadcom BCM5719 multifunction network card in a guest running in a Power 8 server. Hopefully I'll find a suitable x86 env to stress test the feature there too. [1] https://www.redhat.com/archives/libvir-list/2019-June/msg00703.html [2] https://github.com/danielhb/libvirt/tree/multifunction_latest Daniel Henrique Barboza (1): util/virhostdev: enhance VFIO device is in use detection Shivaprasad G Bhat (6): tests: Fix the iommu group path in mock pci tests: pci: Mock the iommu groups and vfio virpcitest: Change the stub driver to vfio from pci-stub virpcimock: Mock the SRIOV Virtual functions tests: qemu: Add test case for pci-hostdev hotplug tests: Add a baseline test for multifunction pci device use case src/util/virhostdev.c | 74 +++++-- src/util/virprocess.h | 2 +- tests/Makefile.am | 7 + tests/qemuhotplugtest.c | 42 +++- .../qemuhotplug-hostdev-pci.xml | 6 + .../qemuhotplug-base-live+hostdev-pci.xml | 58 +++++ ...uhotplug-pseries-base-live+hostdev-pci.xml | 51 +++++ .../qemuhotplug-pseries-base-live.xml | 43 ++++ .../hostdev-pci-multifunction.args | 35 +++ .../hostdev-pci-multifunction.xml | 59 +++++ .../hostdev-vfio-multidomain.args | 2 +- .../hostdev-vfio-multidomain.xml | 2 +- tests/qemuxml2argvdata/hostdev-vfio.args | 2 +- tests/qemuxml2argvdata/hostdev-vfio.xml | 2 +- tests/qemuxml2argvdata/net-hostdev-fail.xml | 2 +- tests/qemuxml2argvdata/net-hostdev-vfio.args | 2 +- tests/qemuxml2argvdata/net-hostdev-vfio.xml | 2 +- tests/qemuxml2argvtest.c | 3 + .../hostdev-pci-multifunction.xml | 79 +++++++ tests/qemuxml2xmloutdata/hostdev-vfio.xml | 2 +- tests/qemuxml2xmloutdata/net-hostdev-vfio.xml | 2 +- tests/qemuxml2xmltest.c | 1 + tests/virhostdevtest.c | 4 +- tests/virpcimock.c | 201 ++++++++++++++++-- tests/virpcitest.c | 12 +- tests/virpcitestdata/0000-06-12.0.config | Bin 0 -> 256 bytes tests/virpcitestdata/0000-06-12.1.config | Bin 0 -> 256 bytes tests/virpcitestdata/0000-06-12.2.config | Bin 0 -> 256 bytes tests/virprocessmock.c | 28 +++ 29 files changed, 668 insertions(+), 55 deletions(-) create mode 100644 tests/qemuhotplugtestdevices/qemuhotplug-hostdev-pci.xml create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-base-live+hostdev-pci.xml create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-pseries-base-live+hostdev-pci.xml create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-pseries-base-live.xml create mode 100644 tests/qemuxml2argvdata/hostdev-pci-multifunction.args create mode 100644 tests/qemuxml2argvdata/hostdev-pci-multifunction.xml create mode 100644 tests/qemuxml2xmloutdata/hostdev-pci-multifunction.xml create mode 100644 tests/virpcitestdata/0000-06-12.0.config create mode 100644 tests/virpcitestdata/0000-06-12.1.config create mode 100644 tests/virpcitestdata/0000-06-12.2.config create mode 100644 tests/virprocessmock.c -- 2.21.0

2 14

[libvirt] [jenkins-ci PATCH 0/2] quayadmin: Add create-build command
by Andrea Bolognani 16 Aug '19

16 Aug '19

Once [1] has been merged, we'll be able to conveniently cause container images to be rebuilt without having to define custom triggers. [1] https://www.redhat.com/archives/libvir-list/2019-August/msg00399.html Andrea Bolognani (2): quayadmin: Fix endpoints quayadmin: Add create-build command guests/quayadmin | 46 ++++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 42 insertions(+), 4 deletions(-) -- 2.21.0

2 3

[libvirt] [dockerfiles PATCH 0/3] refresh: Generate archived Dockerfiles
by Andrea Bolognani 16 Aug '19

16 Aug '19

See commit 1/3 for more information. Andrea Bolognani (3): refresh: Generate archived Dockerfiles Remove plain Dockerfiles Add archived Dockerfiles .gitignore | 1 + buildenv-libosinfo-centos-7.Dockerfile | 43 ------- buildenv-libosinfo-centos-7.zip | Bin 0 -> 458 bytes ...bosinfo-debian-10-cross-aarch64.Dockerfile | 64 ---------- ...denv-libosinfo-debian-10-cross-aarch64.zip | Bin 0 -> 683 bytes ...ibosinfo-debian-10-cross-armv6l.Dockerfile | 64 ---------- buildenv-libosinfo-debian-10-cross-armv6l.zip | Bin 0 -> 682 bytes ...ibosinfo-debian-10-cross-armv7l.Dockerfile | 64 ---------- buildenv-libosinfo-debian-10-cross-armv7l.zip | Bin 0 -> 686 bytes ...-libosinfo-debian-10-cross-i686.Dockerfile | 64 ---------- buildenv-libosinfo-debian-10-cross-i686.zip | Bin 0 -> 682 bytes ...-libosinfo-debian-10-cross-mips.Dockerfile | 64 ---------- buildenv-libosinfo-debian-10-cross-mips.zip | Bin 0 -> 678 bytes ...osinfo-debian-10-cross-mips64el.Dockerfile | 64 ---------- ...env-libosinfo-debian-10-cross-mips64el.zip | Bin 0 -> 689 bytes ...ibosinfo-debian-10-cross-mipsel.Dockerfile | 64 ---------- buildenv-libosinfo-debian-10-cross-mipsel.zip | Bin 0 -> 681 bytes ...bosinfo-debian-10-cross-ppc64le.Dockerfile | 64 ---------- ...denv-libosinfo-debian-10-cross-ppc64le.zip | Bin 0 -> 687 bytes ...libosinfo-debian-10-cross-s390x.Dockerfile | 64 ---------- buildenv-libosinfo-debian-10-cross-s390x.zip | Bin 0 -> 680 bytes buildenv-libosinfo-debian-10.Dockerfile | 50 -------- buildenv-libosinfo-debian-10.zip | Bin 0 -> 555 bytes ...ibosinfo-debian-9-cross-aarch64.Dockerfile | 64 ---------- buildenv-libosinfo-debian-9-cross-aarch64.zip | Bin 0 -> 682 bytes ...libosinfo-debian-9-cross-armv6l.Dockerfile | 64 ---------- buildenv-libosinfo-debian-9-cross-armv6l.zip | Bin 0 -> 681 bytes ...libosinfo-debian-9-cross-armv7l.Dockerfile | 64 ---------- buildenv-libosinfo-debian-9-cross-armv7l.zip | Bin 0 -> 685 bytes ...v-libosinfo-debian-9-cross-mips.Dockerfile | 64 ---------- buildenv-libosinfo-debian-9-cross-mips.zip | Bin 0 -> 678 bytes ...bosinfo-debian-9-cross-mips64el.Dockerfile | 64 ---------- ...denv-libosinfo-debian-9-cross-mips64el.zip | Bin 0 -> 689 bytes ...libosinfo-debian-9-cross-mipsel.Dockerfile | 64 ---------- buildenv-libosinfo-debian-9-cross-mipsel.zip | Bin 0 -> 680 bytes ...ibosinfo-debian-9-cross-ppc64le.Dockerfile | 64 ---------- buildenv-libosinfo-debian-9-cross-ppc64le.zip | Bin 0 -> 687 bytes ...-libosinfo-debian-9-cross-s390x.Dockerfile | 64 ---------- buildenv-libosinfo-debian-9-cross-s390x.zip | Bin 0 -> 680 bytes buildenv-libosinfo-debian-9.Dockerfile | 50 -------- buildenv-libosinfo-debian-9.zip | Bin 0 -> 554 bytes ...osinfo-debian-sid-cross-aarch64.Dockerfile | 64 ---------- ...env-libosinfo-debian-sid-cross-aarch64.zip | Bin 0 -> 683 bytes ...bosinfo-debian-sid-cross-armv6l.Dockerfile | 64 ---------- ...denv-libosinfo-debian-sid-cross-armv6l.zip | Bin 0 -> 682 bytes ...bosinfo-debian-sid-cross-armv7l.Dockerfile | 64 ---------- ...denv-libosinfo-debian-sid-cross-armv7l.zip | Bin 0 -> 686 bytes ...libosinfo-debian-sid-cross-i686.Dockerfile | 64 ---------- buildenv-libosinfo-debian-sid-cross-i686.zip | Bin 0 -> 683 bytes ...libosinfo-debian-sid-cross-mips.Dockerfile | 64 ---------- buildenv-libosinfo-debian-sid-cross-mips.zip | Bin 0 -> 678 bytes ...sinfo-debian-sid-cross-mips64el.Dockerfile | 64 ---------- ...nv-libosinfo-debian-sid-cross-mips64el.zip | Bin 0 -> 689 bytes ...bosinfo-debian-sid-cross-mipsel.Dockerfile | 64 ---------- ...denv-libosinfo-debian-sid-cross-mipsel.zip | Bin 0 -> 681 bytes ...osinfo-debian-sid-cross-ppc64le.Dockerfile | 64 ---------- ...env-libosinfo-debian-sid-cross-ppc64le.zip | Bin 0 -> 687 bytes ...ibosinfo-debian-sid-cross-s390x.Dockerfile | 64 ---------- buildenv-libosinfo-debian-sid-cross-s390x.zip | Bin 0 -> 680 bytes buildenv-libosinfo-debian-sid.Dockerfile | 50 -------- buildenv-libosinfo-debian-sid.zip | Bin 0 -> 555 bytes buildenv-libosinfo-fedora-29.Dockerfile | 49 -------- buildenv-libosinfo-fedora-29.zip | Bin 0 -> 488 bytes buildenv-libosinfo-fedora-30.Dockerfile | 49 -------- buildenv-libosinfo-fedora-30.zip | Bin 0 -> 489 bytes buildenv-libosinfo-fedora-rawhide.Dockerfile | 63 ---------- buildenv-libosinfo-fedora-rawhide.zip | Bin 0 -> 572 bytes buildenv-libosinfo-ubuntu-16.Dockerfile | 50 -------- buildenv-libosinfo-ubuntu-16.zip | Bin 0 -> 558 bytes buildenv-libosinfo-ubuntu-18.Dockerfile | 50 -------- buildenv-libosinfo-ubuntu-18.zip | Bin 0 -> 558 bytes buildenv-libvirt-centos-7.Dockerfile | 81 ------------- buildenv-libvirt-centos-7.zip | Bin 0 -> 662 bytes ...libvirt-debian-10-cross-aarch64.Dockerfile | 100 --------------- buildenv-libvirt-debian-10-cross-aarch64.zip | Bin 0 -> 887 bytes ...-libvirt-debian-10-cross-armv6l.Dockerfile | 98 --------------- buildenv-libvirt-debian-10-cross-armv6l.zip | Bin 0 -> 880 bytes ...-libvirt-debian-10-cross-armv7l.Dockerfile | 99 --------------- buildenv-libvirt-debian-10-cross-armv7l.zip | Bin 0 -> 884 bytes ...nv-libvirt-debian-10-cross-i686.Dockerfile | 99 --------------- buildenv-libvirt-debian-10-cross-i686.zip | Bin 0 -> 883 bytes ...nv-libvirt-debian-10-cross-mips.Dockerfile | 99 --------------- buildenv-libvirt-debian-10-cross-mips.zip | Bin 0 -> 878 bytes ...ibvirt-debian-10-cross-mips64el.Dockerfile | 99 --------------- buildenv-libvirt-debian-10-cross-mips64el.zip | Bin 0 -> 892 bytes ...-libvirt-debian-10-cross-mipsel.Dockerfile | 99 --------------- buildenv-libvirt-debian-10-cross-mipsel.zip | Bin 0 -> 882 bytes ...libvirt-debian-10-cross-ppc64le.Dockerfile | 99 --------------- buildenv-libvirt-debian-10-cross-ppc64le.zip | Bin 0 -> 890 bytes ...v-libvirt-debian-10-cross-s390x.Dockerfile | 99 --------------- buildenv-libvirt-debian-10-cross-s390x.zip | Bin 0 -> 883 bytes buildenv-libvirt-debian-10.Dockerfile | 89 -------------- buildenv-libvirt-debian-10.zip | Bin 0 -> 773 bytes ...-libvirt-debian-9-cross-aarch64.Dockerfile | 101 ---------------- buildenv-libvirt-debian-9-cross-aarch64.zip | Bin 0 -> 896 bytes ...v-libvirt-debian-9-cross-armv6l.Dockerfile | 99 --------------- buildenv-libvirt-debian-9-cross-armv6l.zip | Bin 0 -> 887 bytes ...v-libvirt-debian-9-cross-armv7l.Dockerfile | 100 --------------- buildenv-libvirt-debian-9-cross-armv7l.zip | Bin 0 -> 893 bytes ...env-libvirt-debian-9-cross-mips.Dockerfile | 100 --------------- buildenv-libvirt-debian-9-cross-mips.zip | Bin 0 -> 886 bytes ...libvirt-debian-9-cross-mips64el.Dockerfile | 100 --------------- buildenv-libvirt-debian-9-cross-mips64el.zip | Bin 0 -> 898 bytes ...v-libvirt-debian-9-cross-mipsel.Dockerfile | 100 --------------- buildenv-libvirt-debian-9-cross-mipsel.zip | Bin 0 -> 889 bytes ...-libvirt-debian-9-cross-ppc64le.Dockerfile | 100 --------------- buildenv-libvirt-debian-9-cross-ppc64le.zip | Bin 0 -> 898 bytes ...nv-libvirt-debian-9-cross-s390x.Dockerfile | 100 --------------- buildenv-libvirt-debian-9-cross-s390x.zip | Bin 0 -> 890 bytes buildenv-libvirt-debian-9.Dockerfile | 90 -------------- buildenv-libvirt-debian-9.zip | Bin 0 -> 777 bytes ...ibvirt-debian-sid-cross-aarch64.Dockerfile | 100 --------------- buildenv-libvirt-debian-sid-cross-aarch64.zip | Bin 0 -> 886 bytes ...libvirt-debian-sid-cross-armv6l.Dockerfile | 98 --------------- buildenv-libvirt-debian-sid-cross-armv6l.zip | Bin 0 -> 879 bytes ...libvirt-debian-sid-cross-armv7l.Dockerfile | 99 --------------- buildenv-libvirt-debian-sid-cross-armv7l.zip | Bin 0 -> 884 bytes ...v-libvirt-debian-sid-cross-i686.Dockerfile | 99 --------------- buildenv-libvirt-debian-sid-cross-i686.zip | Bin 0 -> 883 bytes ...v-libvirt-debian-sid-cross-mips.Dockerfile | 99 --------------- buildenv-libvirt-debian-sid-cross-mips.zip | Bin 0 -> 877 bytes ...bvirt-debian-sid-cross-mips64el.Dockerfile | 99 --------------- ...denv-libvirt-debian-sid-cross-mips64el.zip | Bin 0 -> 892 bytes ...libvirt-debian-sid-cross-mipsel.Dockerfile | 99 --------------- buildenv-libvirt-debian-sid-cross-mipsel.zip | Bin 0 -> 882 bytes ...ibvirt-debian-sid-cross-ppc64le.Dockerfile | 99 --------------- buildenv-libvirt-debian-sid-cross-ppc64le.zip | Bin 0 -> 890 bytes ...-libvirt-debian-sid-cross-s390x.Dockerfile | 99 --------------- buildenv-libvirt-debian-sid-cross-s390x.zip | Bin 0 -> 883 bytes buildenv-libvirt-debian-sid.Dockerfile | 89 -------------- buildenv-libvirt-debian-sid.zip | Bin 0 -> 773 bytes buildenv-libvirt-fedora-29.Dockerfile | 89 -------------- buildenv-libvirt-fedora-29.zip | Bin 0 -> 694 bytes buildenv-libvirt-fedora-30.Dockerfile | 89 -------------- buildenv-libvirt-fedora-30.zip | Bin 0 -> 695 bytes buildenv-libvirt-fedora-rawhide.Dockerfile | 114 ------------------ buildenv-libvirt-fedora-rawhide.zip | Bin 0 -> 828 bytes buildenv-libvirt-ubuntu-16.Dockerfile | 91 -------------- buildenv-libvirt-ubuntu-16.zip | Bin 0 -> 784 bytes buildenv-libvirt-ubuntu-18.Dockerfile | 91 -------------- buildenv-libvirt-ubuntu-18.zip | Bin 0 -> 783 bytes refresh | 21 +++- 142 files changed, 20 insertions(+), 5525 deletions(-) create mode 100644 .gitignore delete mode 100644 buildenv-libosinfo-centos-7.Dockerfile create mode 100644 buildenv-libosinfo-centos-7.zip delete mode 100644 buildenv-libosinfo-debian-10-cross-aarch64.Dockerfile create mode 100644 buildenv-libosinfo-debian-10-cross-aarch64.zip delete mode 100644 buildenv-libosinfo-debian-10-cross-armv6l.Dockerfile create mode 100644 buildenv-libosinfo-debian-10-cross-armv6l.zip delete mode 100644 buildenv-libosinfo-debian-10-cross-armv7l.Dockerfile create mode 100644 buildenv-libosinfo-debian-10-cross-armv7l.zip delete mode 100644 buildenv-libosinfo-debian-10-cross-i686.Dockerfile create mode 100644 buildenv-libosinfo-debian-10-cross-i686.zip delete mode 100644 buildenv-libosinfo-debian-10-cross-mips.Dockerfile create mode 100644 buildenv-libosinfo-debian-10-cross-mips.zip delete mode 100644 buildenv-libosinfo-debian-10-cross-mips64el.Dockerfile create mode 100644 buildenv-libosinfo-debian-10-cross-mips64el.zip delete mode 100644 buildenv-libosinfo-debian-10-cross-mipsel.Dockerfile create mode 100644 buildenv-libosinfo-debian-10-cross-mipsel.zip delete mode 100644 buildenv-libosinfo-debian-10-cross-ppc64le.Dockerfile create mode 100644 buildenv-libosinfo-debian-10-cross-ppc64le.zip delete mode 100644 buildenv-libosinfo-debian-10-cross-s390x.Dockerfile create mode 100644 buildenv-libosinfo-debian-10-cross-s390x.zip delete mode 100644 buildenv-libosinfo-debian-10.Dockerfile create mode 100644 buildenv-libosinfo-debian-10.zip delete mode 100644 buildenv-libosinfo-debian-9-cross-aarch64.Dockerfile create mode 100644 buildenv-libosinfo-debian-9-cross-aarch64.zip delete mode 100644 buildenv-libosinfo-debian-9-cross-armv6l.Dockerfile create mode 100644 buildenv-libosinfo-debian-9-cross-armv6l.zip delete mode 100644 buildenv-libosinfo-debian-9-cross-armv7l.Dockerfile create mode 100644 buildenv-libosinfo-debian-9-cross-armv7l.zip delete mode 100644 buildenv-libosinfo-debian-9-cross-mips.Dockerfile create mode 100644 buildenv-libosinfo-debian-9-cross-mips.zip delete mode 100644 buildenv-libosinfo-debian-9-cross-mips64el.Dockerfile create mode 100644 buildenv-libosinfo-debian-9-cross-mips64el.zip delete mode 100644 buildenv-libosinfo-debian-9-cross-mipsel.Dockerfile create mode 100644 buildenv-libosinfo-debian-9-cross-mipsel.zip delete mode 100644 buildenv-libosinfo-debian-9-cross-ppc64le.Dockerfile create mode 100644 buildenv-libosinfo-debian-9-cross-ppc64le.zip delete mode 100644 buildenv-libosinfo-debian-9-cross-s390x.Dockerfile create mode 100644 buildenv-libosinfo-debian-9-cross-s390x.zip delete mode 100644 buildenv-libosinfo-debian-9.Dockerfile create mode 100644 buildenv-libosinfo-debian-9.zip delete mode 100644 buildenv-libosinfo-debian-sid-cross-aarch64.Dockerfile create mode 100644 buildenv-libosinfo-debian-sid-cross-aarch64.zip delete mode 100644 buildenv-libosinfo-debian-sid-cross-armv6l.Dockerfile create mode 100644 buildenv-libosinfo-debian-sid-cross-armv6l.zip delete mode 100644 buildenv-libosinfo-debian-sid-cross-armv7l.Dockerfile create mode 100644 buildenv-libosinfo-debian-sid-cross-armv7l.zip delete mode 100644 buildenv-libosinfo-debian-sid-cross-i686.Dockerfile create mode 100644 buildenv-libosinfo-debian-sid-cross-i686.zip delete mode 100644 buildenv-libosinfo-debian-sid-cross-mips.Dockerfile create mode 100644 buildenv-libosinfo-debian-sid-cross-mips.zip delete mode 100644 buildenv-libosinfo-debian-sid-cross-mips64el.Dockerfile create mode 100644 buildenv-libosinfo-debian-sid-cross-mips64el.zip delete mode 100644 buildenv-libosinfo-debian-sid-cross-mipsel.Dockerfile create mode 100644 buildenv-libosinfo-debian-sid-cross-mipsel.zip delete mode 100644 buildenv-libosinfo-debian-sid-cross-ppc64le.Dockerfile create mode 100644 buildenv-libosinfo-debian-sid-cross-ppc64le.zip delete mode 100644 buildenv-libosinfo-debian-sid-cross-s390x.Dockerfile create mode 100644 buildenv-libosinfo-debian-sid-cross-s390x.zip delete mode 100644 buildenv-libosinfo-debian-sid.Dockerfile create mode 100644 buildenv-libosinfo-debian-sid.zip delete mode 100644 buildenv-libosinfo-fedora-29.Dockerfile create mode 100644 buildenv-libosinfo-fedora-29.zip delete mode 100644 buildenv-libosinfo-fedora-30.Dockerfile create mode 100644 buildenv-libosinfo-fedora-30.zip delete mode 100644 buildenv-libosinfo-fedora-rawhide.Dockerfile create mode 100644 buildenv-libosinfo-fedora-rawhide.zip delete mode 100644 buildenv-libosinfo-ubuntu-16.Dockerfile create mode 100644 buildenv-libosinfo-ubuntu-16.zip delete mode 100644 buildenv-libosinfo-ubuntu-18.Dockerfile create mode 100644 buildenv-libosinfo-ubuntu-18.zip delete mode 100644 buildenv-libvirt-centos-7.Dockerfile create mode 100644 buildenv-libvirt-centos-7.zip delete mode 100644 buildenv-libvirt-debian-10-cross-aarch64.Dockerfile create mode 100644 buildenv-libvirt-debian-10-cross-aarch64.zip delete mode 100644 buildenv-libvirt-debian-10-cross-armv6l.Dockerfile create mode 100644 buildenv-libvirt-debian-10-cross-armv6l.zip delete mode 100644 buildenv-libvirt-debian-10-cross-armv7l.Dockerfile create mode 100644 buildenv-libvirt-debian-10-cross-armv7l.zip delete mode 100644 buildenv-libvirt-debian-10-cross-i686.Dockerfile create mode 100644 buildenv-libvirt-debian-10-cross-i686.zip delete mode 100644 buildenv-libvirt-debian-10-cross-mips.Dockerfile create mode 100644 buildenv-libvirt-debian-10-cross-mips.zip delete mode 100644 buildenv-libvirt-debian-10-cross-mips64el.Dockerfile create mode 100644 buildenv-libvirt-debian-10-cross-mips64el.zip delete mode 100644 buildenv-libvirt-debian-10-cross-mipsel.Dockerfile create mode 100644 buildenv-libvirt-debian-10-cross-mipsel.zip delete mode 100644 buildenv-libvirt-debian-10-cross-ppc64le.Dockerfile create mode 100644 buildenv-libvirt-debian-10-cross-ppc64le.zip delete mode 100644 buildenv-libvirt-debian-10-cross-s390x.Dockerfile create mode 100644 buildenv-libvirt-debian-10-cross-s390x.zip delete mode 100644 buildenv-libvirt-debian-10.Dockerfile create mode 100644 buildenv-libvirt-debian-10.zip delete mode 100644 buildenv-libvirt-debian-9-cross-aarch64.Dockerfile create mode 100644 buildenv-libvirt-debian-9-cross-aarch64.zip delete mode 100644 buildenv-libvirt-debian-9-cross-armv6l.Dockerfile create mode 100644 buildenv-libvirt-debian-9-cross-armv6l.zip delete mode 100644 buildenv-libvirt-debian-9-cross-armv7l.Dockerfile create mode 100644 buildenv-libvirt-debian-9-cross-armv7l.zip delete mode 100644 buildenv-libvirt-debian-9-cross-mips.Dockerfile create mode 100644 buildenv-libvirt-debian-9-cross-mips.zip delete mode 100644 buildenv-libvirt-debian-9-cross-mips64el.Dockerfile create mode 100644 buildenv-libvirt-debian-9-cross-mips64el.zip delete mode 100644 buildenv-libvirt-debian-9-cross-mipsel.Dockerfile create mode 100644 buildenv-libvirt-debian-9-cross-mipsel.zip delete mode 100644 buildenv-libvirt-debian-9-cross-ppc64le.Dockerfile create mode 100644 buildenv-libvirt-debian-9-cross-ppc64le.zip delete mode 100644 buildenv-libvirt-debian-9-cross-s390x.Dockerfile create mode 100644 buildenv-libvirt-debian-9-cross-s390x.zip delete mode 100644 buildenv-libvirt-debian-9.Dockerfile create mode 100644 buildenv-libvirt-debian-9.zip delete mode 100644 buildenv-libvirt-debian-sid-cross-aarch64.Dockerfile create mode 100644 buildenv-libvirt-debian-sid-cross-aarch64.zip delete mode 100644 buildenv-libvirt-debian-sid-cross-armv6l.Dockerfile create mode 100644 buildenv-libvirt-debian-sid-cross-armv6l.zip delete mode 100644 buildenv-libvirt-debian-sid-cross-armv7l.Dockerfile create mode 100644 buildenv-libvirt-debian-sid-cross-armv7l.zip delete mode 100644 buildenv-libvirt-debian-sid-cross-i686.Dockerfile create mode 100644 buildenv-libvirt-debian-sid-cross-i686.zip delete mode 100644 buildenv-libvirt-debian-sid-cross-mips.Dockerfile create mode 100644 buildenv-libvirt-debian-sid-cross-mips.zip delete mode 100644 buildenv-libvirt-debian-sid-cross-mips64el.Dockerfile create mode 100644 buildenv-libvirt-debian-sid-cross-mips64el.zip delete mode 100644 buildenv-libvirt-debian-sid-cross-mipsel.Dockerfile create mode 100644 buildenv-libvirt-debian-sid-cross-mipsel.zip delete mode 100644 buildenv-libvirt-debian-sid-cross-ppc64le.Dockerfile create mode 100644 buildenv-libvirt-debian-sid-cross-ppc64le.zip delete mode 100644 buildenv-libvirt-debian-sid-cross-s390x.Dockerfile create mode 100644 buildenv-libvirt-debian-sid-cross-s390x.zip delete mode 100644 buildenv-libvirt-debian-sid.Dockerfile create mode 100644 buildenv-libvirt-debian-sid.zip delete mode 100644 buildenv-libvirt-fedora-29.Dockerfile create mode 100644 buildenv-libvirt-fedora-29.zip delete mode 100644 buildenv-libvirt-fedora-30.Dockerfile create mode 100644 buildenv-libvirt-fedora-30.zip delete mode 100644 buildenv-libvirt-fedora-rawhide.Dockerfile create mode 100644 buildenv-libvirt-fedora-rawhide.zip delete mode 100644 buildenv-libvirt-ubuntu-16.Dockerfile create mode 100644 buildenv-libvirt-ubuntu-16.zip delete mode 100644 buildenv-libvirt-ubuntu-18.Dockerfile create mode 100644 buildenv-libvirt-ubuntu-18.zip -- 2.21.0

2 4

[libvirt] [PATCH 0/2] network: fix crash during cleanup from failure to allocate port
by Laine Stump 16 Aug '19

16 Aug '19

The first patch fixes the bug. The 2nd patch just updates some code that I noticed while fixing the bug (because I figured someone would whine that I was just moving around calls to outdated APIs). Laine Stump (2): network: fix crash during cleanup from failure to allocate port network: replace virSaveLastError() with virErrorPreserveLast() src/network/bridge_driver.c | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) -- 2.21.0

2 3

[libvirt] [PATCH] access: fix incorrect addition to virAccessPermNetwork
by Laine Stump 16 Aug '19

16 Aug '19

Commit e69444e17 (first appeared in libvirt-5.5.0) added the new value "VIR_ACCESS_PERM_NETWORK_SEARCH_PORTS" to the virAccessPerNetwork enum, and also the string "search_ports" to the VIR_ENUM_IMPL() macro for that enum. Unfortunately, the enum value was added in the middle of the list, while the string was added to the end of the VIR_ENUM_IMPL(). This patch corrects that error by moving the new value to the end of the enum definition, so that the order matches that of the string list. Resolves: https://bugzilla.redhat.com/1741428 Signed-off-by: Laine Stump <laine(a)redhat.com> --- src/access/viraccessperm.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/access/viraccessperm.h b/src/access/viraccessperm.h index a42512d5e0..7480ee8c2f 100644 --- a/src/access/viraccessperm.h +++ b/src/access/viraccessperm.h @@ -410,18 +410,18 @@ typedef enum { */ VIR_ACCESS_PERM_NETWORK_START, - /** - * @desc: List network ports - * @message: Listing network ports requires authorization - */ - VIR_ACCESS_PERM_NETWORK_SEARCH_PORTS, - /** * @desc: Stop network * @message: Stopping network requires authorization */ VIR_ACCESS_PERM_NETWORK_STOP, + /** + * @desc: List network ports + * @message: Listing network ports requires authorization + */ + VIR_ACCESS_PERM_NETWORK_SEARCH_PORTS, + VIR_ACCESS_PERM_NETWORK_LAST } virAccessPermNetwork; -- 2.21.0

2 1

[libvirt] [PATCH] tests: virpcimock: Always declare __open_2
by Peter Krempa 16 Aug '19

16 Aug '19

In some cases e.g. with clang on fedora 30 __open2 isn't even declared which results in the following build error: /home/pipo/libvirt/tests/virpcimock.c:939:1: error: no previous prototype for function '__open_2' [-Werror,-Wmissing-prototypes] __open_2(const char *path, int flags) Add a separate declaration to appease the compiler. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- tests/virpcimock.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/virpcimock.c b/tests/virpcimock.c index 829d61cd3f..cfe91ba3ff 100644 --- a/tests/virpcimock.c +++ b/tests/virpcimock.c @@ -935,6 +935,11 @@ open(const char *path, int flags, ...) } +/* in some cases this function may not be present in headers, so we need + * a declaration to silence the complier */ +int +__open_2(const char *path, int flags); + int __open_2(const char *path, int flags) { -- 2.21.0

2 2

[libvirt] [PATCH] test_driver: Fix permissions for test_driver.c
by Ján Tomko 15 Aug '19

15 Aug '19

From: Andrea Bolognani <abologna(a)redhat.com> Introduced in commit 4a6ee53581b3. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> (cherry picked from commit df1b5cf02efd4fee6f01ebe69fd0f1fd24b3947d) Reintroduced-by: fb275b76734ba1c0b18ad1088e3c82fb01961903 Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/test/test_driver.c | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100755 => 100644 src/test/test_driver.c diff --git a/src/test/test_driver.c b/src/test/test_driver.c old mode 100755 new mode 100644 -- 2.20.1

1 0

[libvirt] [PATCH] remote_daemon_dispatch.c: typecast ARRAY_CARDINALITY() in remoteDispatchProbeURI()
by Michal Privoznik 15 Aug '19

15 Aug '19

Since users can enable/disable drivers at compile time, it may happen that @drivers array is in fact empty (in both its occurrences within the function). This means that ARRAY_CARDINALITY() returns 0UL which makes gcc unhappy because of loop condition: i < ARRAY_CARDINALITY(drivers) GCC complains that @i is unsigned and comparing an unsigned value against 0 is always false. However, changing the type of @i to ssize_t is not enough, because compiler still sees the unsigned zero. The solution is to typecast the ARRAY_CARDINALITY(). Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/remote/remote_daemon_dispatch.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon_dispatch.c index c8e353ebd3..1bd281dd6d 100644 --- a/src/remote/remote_daemon_dispatch.c +++ b/src/remote/remote_daemon_dispatch.c @@ -2141,9 +2141,9 @@ remoteDispatchProbeURI(bool readonly, "vbox", # endif }; - size_t i; + ssize_t i; - for (i = 0; i < ARRAY_CARDINALITY(drivers) && !*probeduri; i++) { + for (i = 0; i < (ssize_t) ARRAY_CARDINALITY(drivers) && !*probeduri; i++) { VIR_AUTOFREE(char *) daemonname = NULL; VIR_AUTOFREE(char *) daemonpath = NULL; @@ -2187,9 +2187,9 @@ remoteDispatchProbeURI(bool readonly, "vz", # endif }; - size_t i; + ssize_t i; - for (i = 0; i < ARRAY_CARDINALITY(drivers) && !*probeduri; i++) { + for (i = 0; i < (ssize_t) ARRAY_CARDINALITY(drivers) && !*probeduri; i++) { VIR_AUTOFREE(char *) sockname = NULL; if (virAsprintf(&sockname, "%s/run/libvirt/virt%sd-%s", -- 2.21.0

2 1

[libvirt] [PATCH 0/6] qemu: Allow suppressing some errors in qemu bulk stats code
by Peter Krempa 15 Aug '19

15 Aug '19

There is an bugreport [1] that some Openstack deployments get periodic errors in the log. This is most probably from the bulk stats code which in some cases calls into the storage backends to update some aspects of storage volumes. Since none of the errors are fatal add code to allow skipping them. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1724808 Peter Krempa (6): util: Export virStorageFileSupportsBackingChainTraversal qemu: Allow skipping some errors in qemuDomainStorageOpenStat util: storagefile: Don't report errors from virStorageSourceUpdatePhysicalSize qemu: driver: Improve error suppression in qemuDomainStorageUpdatePhysical qemu: Allow suppressing errors from qemuStorageLimitsRefresh qemu: Don't report some ignored errors in qemuDomainGetStatsOneBlockFallback src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 60 ++++++++++++++++++++++++++++----------- src/util/virstoragefile.c | 16 +++-------- src/util/virstoragefile.h | 1 + 4 files changed, 50 insertions(+), 28 deletions(-) -- 2.21.0

2 12

[libvirt] [PATCH 0/2] Fix the latest virpcitest failure
by Michal Privoznik 15 Aug '19

15 Aug '19

See 2/2 for explanation. Michal Prívozník (2): ci: Allow gdb in containers virpcimock: Mock __open_2() Makefile.ci | 1 + tests/virpcimock.c | 29 +++++++++++++++++++++++++++++ 2 files changed, 30 insertions(+) -- 2.21.0

3 5

[libvirt] [PATCH] test_driver: implement virConnectCompareCPU
by Ilias Stamatis 15 Aug '19

15 Aug '19

Signed-off-by: Ilias Stamatis <stamatis.iliass(a)gmail.com> --- Probably we need to extend the host CPU's capabilities as well along with this patch. Currently virCPUx86Compare reports "unknown host CPU". src/test/test_driver.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index c39eef2d4b..b1037f4eab 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -1529,6 +1529,26 @@ static int testConnectGetMaxVcpus(virConnectPtr conn ATTRIBUTE_UNUSED, return 32; } + +static int +testConnectCompareCPU(virConnectPtr conn, + const char *xmlDesc, + unsigned int flags) +{ + testDriverPtr privconn = conn->privateData; + bool failIncompatible = !!(flags & VIR_CONNECT_COMPARE_CPU_FAIL_INCOMPATIBLE); + int ret = VIR_CPU_COMPARE_ERROR; + + virCheckFlags(VIR_CONNECT_COMPARE_CPU_FAIL_INCOMPATIBLE, + VIR_CPU_COMPARE_ERROR); + + ret = virCPUCompareXML(privconn->caps->host.arch, privconn->caps->host.cpu, + xmlDesc, failIncompatible); + + return ret; +} + + static char * testConnectBaselineCPU(virConnectPtr conn ATTRIBUTE_UNUSED, const char **xmlCPUs, @@ -9510,6 +9530,7 @@ static virHypervisorDriver testHypervisorDriver = { .domainRevertToSnapshot = testDomainRevertToSnapshot, /* 1.1.4 */ .domainSnapshotDelete = testDomainSnapshotDelete, /* 1.1.4 */ + .connectCompareCPU = testConnectCompareCPU, /* 5.7.0 */ .connectBaselineCPU = testConnectBaselineCPU, /* 1.2.0 */ .domainCheckpointCreateXML = testDomainCheckpointCreateXML, /* 5.6.0 */ .domainCheckpointGetXMLDesc = testDomainCheckpointGetXMLDesc, /* 5.6.0 */ -- 2.22.0

1 0

[libvirt] [PATCH] docs: Make anchors in API html files clickable/linkable
by Peter Krempa 15 Aug '19

15 Aug '19

Use 'id' instead of 'name' for anchors which adds the hidden clickable headerlink helper so it's way simpler to link to a specific part of the docs. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- docs/newapi.xsl | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/newapi.xsl b/docs/newapi.xsl index c808fe5ff8..f9cbcb6323 100644 --- a/docs/newapi.xsl +++ b/docs/newapi.xsl @@ -308,7 +308,7 @@ <xsl:template match="typedef[@type = 'enum']"> <xsl:variable name="name" select="string(@name)"/> - <h3><a name="{$name}"><code><xsl:value-of select="$name"/></code></a></h3> + <h3><a id="{$name}"><code><xsl:value-of select="$name"/></code></a></h3> <div class="api"> <pre> <span class="keyword">enum</span><xsl:text> </xsl:text> @@ -357,7 +357,7 @@ </xsl:template> <xsl:template match="struct"> - <h3><a name="{@name}"><code><xsl:value-of select="@name"/></code></a></h3> + <h3><a id="{@name}"><code><xsl:value-of select="@name"/></code></a></h3> <div class="api"> <pre> <span class="keyword">struct </span> @@ -447,7 +447,7 @@ <xsl:template match="macro"> <xsl:variable name="name" select="string(@name)"/> - <h3><a name="{$name}"><code><xsl:value-of select="$name"/></code></a></h3> + <h3><a id="{$name}"><code><xsl:value-of select="$name"/></code></a></h3> <pre class="api"><span class="directive">#define</span><xsl:text> </xsl:text><xsl:value-of select="$name"/></pre> <div class="description"> <xsl:call-template name="formattext"> @@ -558,7 +558,7 @@ <xsl:variable name="nlen" select="string-length($name)"/> <xsl:variable name="tlen" select="string-length(return/@type)"/> <xsl:variable name="blen" select="(($nlen + 8) - (($nlen + 8) mod 8)) + (($tlen + 8) - (($tlen + 8) mod 8))"/> - <h3><a name="{$name}"><code><xsl:value-of select="$name"/></code></a></h3> + <h3><a id="{$name}"><code><xsl:value-of select="$name"/></code></a></h3> <pre class="api"> <span class="keyword">typedef</span><xsl:text> </xsl:text> <span class="type"> @@ -636,7 +636,7 @@ <xsl:variable name="nlen" select="string-length($name)"/> <xsl:variable name="tlen" select="string-length(return/@type)"/> <xsl:variable name="blen" select="(($nlen + 8) - (($nlen + 8) mod 8)) + (($tlen + 8) - (($tlen + 8) mod 8))"/> - <h3><a name="{$name}"><code><xsl:value-of select="$name"/></code></a></h3> + <h3><a id="{$name}"><code><xsl:value-of select="$name"/></code></a></h3> <pre class="api"> <span class="type"> <xsl:call-template name="dumptext"> -- 2.21.0

2 1

[libvirt] [PATCH 00/12] qemu: Add blockdev support for block copy (blockdev-add saga)
by Peter Krempa 15 Aug '19

15 Aug '19

Add support for running a block-copy with -blockdev. This requires us to format our own images, so this series also adds support for blockdev-create which allows to do such a thing with qemu directly. blockdev-create will also be used with snapshots. Peter Krempa (12): qemu: domain: Allow formatting top source only in qemuDomainObjPrivateXMLFormatBlockjobFormatChain qemu: Fix logic in qemuDomainBlockCopyCommonValidateUserMirrorBackingStore qemu: fix broken handling of shallow flag in qemuDomainBlockCopyCommon util: storage: Refactor logic for using virStorageFileGetBackendForSupportCheck util: storage: Allow checking whether virStorageFileCreate is supported qemu: blockjob: Remove qemuBlockJobDiskRegisterMirror qemu: domain: Add 'break' after formatting commit job status XML conf: domain: Parse backingStore with VIR_DOMAIN_DEF_PARSE_DISK_SOURCE qemu: blockjob: Copy non-detected chain fully in qemuBlockJobRewriteConfigDiskSource qemu: Introduce code for blockdev-create qemu: Add blockdev support for the block copy job qemu: driver: allow remote destinations for block copy src/conf/domain_conf.c | 6 +- src/libvirt_private.syms | 1 + src/qemu/qemu_block.c | 250 ++++++++++++++++++ src/qemu/qemu_block.h | 14 + src/qemu/qemu_blockjob.c | 202 ++++++++++++-- src/qemu/qemu_blockjob.h | 37 ++- src/qemu/qemu_domain.c | 83 ++++-- src/qemu/qemu_driver.c | 184 +++++++++---- src/util/virstoragefile.c | 59 +++-- src/util/virstoragefile.h | 1 + .../blockjob-blockdev-in.xml | 59 +++++ 11 files changed, 786 insertions(+), 110 deletions(-) -- 2.21.0

2 24

[libvirt] [PATCH] util: storage: Fix parsing of 'exportname' from legacy NBD strings
by Peter Krempa 15 Aug '19

15 Aug '19

If the nbd export name contains a colon, our parser would not parse it properly as we split the string by colons. Modify the code to look up the exportname and copy any trailing characters as the export name is supposed to be at the end of the string. https://bugzilla.redhat.com/show_bug.cgi?id=1733044 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/util/virstoragefile.c | 6 ++++-- tests/virstoragetest.c | 8 ++++++++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index a6de6a1e45..ffafeef9d8 100644 --- a/src/util/virstoragefile.c +++ b/src/util/virstoragefile.c @@ -2928,6 +2928,7 @@ virStorageSourceParseNBDColonString(const char *nbdstr, virStorageSourcePtr src) { VIR_AUTOSTRINGLIST backing = NULL; + const char *exportname; if (!(backing = virStringSplit(nbdstr, ":", 0))) return -1; @@ -2975,8 +2976,9 @@ virStorageSourceParseNBDColonString(const char *nbdstr, return -1; } - if (backing[3] && STRPREFIX(backing[3], "exportname=")) { - if (VIR_STRDUP(src->path, backing[3] + strlen("exportname=")) < 0) + if ((exportname = strstr(nbdstr, "exportname="))) { + exportname += strlen("exportname="); + if (VIR_STRDUP(src->path, exportname) < 0) return -1; } diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c index ef16b3c6e0..f558eea622 100644 --- a/tests/virstoragetest.c +++ b/tests/virstoragetest.c @@ -1262,6 +1262,14 @@ mymain(void) "<source protocol='nbd' name='blah'>\n" " <host name='example.org' port='6000'/>\n" "</source>\n"); + TEST_BACKING_PARSE("nbd:example.org:6000:exportname=:", + "<source protocol='nbd' name=':'>\n" + " <host name='example.org' port='6000'/>\n" + "</source>\n"); + TEST_BACKING_PARSE("nbd:example.org:6000:exportname=:test", + "<source protocol='nbd' name=':test'>\n" + " <host name='example.org' port='6000'/>\n" + "</source>\n"); TEST_BACKING_PARSE("nbd://example.org:1234", "<source protocol='nbd'>\n" " <host name='example.org' port='1234'/>\n" -- 2.21.0

2 2

[libvirt] [PATCH 0/5] util: open pci config read-only for querying
by Ján Tomko 15 Aug '19

15 Aug '19

A bunch of functions opened the PCI device config as read-write even though they only read from it. Ján Tomko (5): util: introduce virPCIDeviceConfigOpenInternal util: Introduce virPCIDeviceConfigOpenWrite util: introduce readonly attribute to virPCIDeviceConfigOpenInternal util: introduce virPCIDeviceConfigOpenTry util: default to read-only in virPCIDeviceConfigOpen src/util/virpci.c | 40 +++++++++++++++++++++++++++++----------- 1 file changed, 29 insertions(+), 11 deletions(-) -- 2.20.1

4 8

[libvirt] [PATCH v2 0/2] test_driver: implement virDomainSetLifecycleAction
by Ilias Stamatis 14 Aug '19

14 Aug '19

Ilias Stamatis (2): test_driver: handle different lifecycle actions in testDomainShutdownFlags test_driver: implement virDomainSetLifecycleAction src/test/test_driver.c | 135 +++++++++++++++++++++++++++++++---------- 1 file changed, 103 insertions(+), 32 deletions(-) -- 2.22.0

2 6

[libvirt] [PATCH 0/3] virNetDaemonCallInhibit: check for logind availability
by Ján Tomko 14 Aug '19

14 Aug '19

* get rid of a pointless error logged when system D-Bus is not available * do not send messages on systems without logind * remove four extra dbus calls on libvirtd startup when checking for logind availability Ján Tomko (3): util: introduce virSystemdHasLogind util: cache the result of whether logind is available rpc: make virNetDaemonCallInhibit a no-op with no logind src/libvirt_private.syms | 2 ++ src/rpc/virnetdaemon.c | 3 +++ src/util/virsystemd.c | 37 ++++++++++++++++++++++++++++++++----- src/util/virsystemd.h | 2 ++ src/util/virsystemdpriv.h | 1 + tests/virsystemdtest.c | 3 +++ 6 files changed, 43 insertions(+), 5 deletions(-) -- 2.19.2

2 4

[libvirt] [PATCH 0/3] quietly ignore missing pm-is-supported
by Ján Tomko 14 Aug '19

14 Aug '19

On systems with no logind or pm-is-supported binary, stop spamming the logs about a missing executable. Ján Tomko (3): util: use VIR_AUTOPTR virNodeSuspendSupportsTargetPMUtils util: do not repeat the pm-is-supported string util: be quiet when pm-is-supported is unavailable src/util/virnodesuspend.c | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) -- 2.19.2

2 7

[libvirt] [PATCH 0/3] qemu: Allow migration with disk cache on
by Jiri Denemark 14 Aug '19

14 Aug '19

QEMU 4.0.0 and newer automatically drops caches at the end of migration, which means we can safely allow migration even if disk/driver/@cache is not none nor directsync. Jiri Denemark (3): qemu: Clarify error message in qemuMigrationSrcIsSafe qemu: Check for drop-cache capability qemu: Allow migration with disk cache on src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_migration.c | 14 +++++++++++--- tests/qemucapabilitiesdata/caps_4.0.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_4.0.0.riscv32.xml | 1 + tests/qemucapabilitiesdata/caps_4.0.0.riscv64.xml | 1 + tests/qemucapabilitiesdata/caps_4.0.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_4.0.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_4.1.0.x86_64.xml | 1 + 10 files changed, 21 insertions(+), 3 deletions(-) -- 2.22.1

3 5

[libvirt] [PATCH] qemu: Fix crash on incoming migration
by Jiri Denemark 13 Aug '19

13 Aug '19

In the first stage of incoming migration (qemuMigrationDstPrepareAny) we call qemuMigrationEatCookie when there's no vm object created yet and thus we don't have any private data to pass. Broken by me in commit v5.6.0-109-gbf15b145ec. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_migration_cookie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_migration_cookie.c b/src/qemu/qemu_migration_cookie.c index da5bc8d05f..25d3fecd74 100644 --- a/src/qemu/qemu_migration_cookie.c +++ b/src/qemu/qemu_migration_cookie.c @@ -1507,7 +1507,7 @@ qemuMigrationEatCookie(virQEMUDriverPtr driver, if (cookiein && cookieinlen && qemuMigrationCookieXMLParseStr(mig, driver, - priv->qemuCaps, + priv ? priv->qemuCaps : NULL, cookiein, flags) < 0) goto error; -- 2.22.1

2 1

[libvirt] [PATCH v2 0/2] Revert "configure: Remove --enable-test-coverage"
by Jiri Denemark 13 Aug '19

13 Aug '19

Gnulib's make coverage (or init-coverage, build-coverage, gen-coverage) is not a 1-1 replacement for the original configure option. Our old --enable-test-coverage seems to be close to gnulib's make build-coverage except gnulib runs lcov in that phase and the build actually fails for me even before lcov is run. And since we want to be able to just build libvirt without running lcov, I suggest reverting to our own implementation. I admit the best solution would be to somehow make gnulib support what we need (and fix the actual build), but I don't feel brave enough to do that. Eric? :-) Also if we ever switch to glib and drop gnulib completely, we would need to reintroduce our own implementation anyway. I had to do some changes to resolve conflicts. The changes were not too big, but I figured I'd rather resend this patch especially when I originally forgot to Cc the original author of the reverted patch. Jiri Denemark (2): Revert "configure: Remove --enable-test-coverage" Revert "docs: hacking: Add 'Code coverage reports' section" Makefile.am | 20 +++++++++++++++++--- configure.ac | 18 ++++++++++++++++++ docs/hacking.html.in | 29 ----------------------------- src/Makefile.am | 2 ++ src/remote/Makefile.inc.am | 2 ++ tests/Makefile.am | 2 ++ tools/Makefile.am | 6 ++++++ 7 files changed, 47 insertions(+), 32 deletions(-) -- 2.22.1

2 3