- Devel - libvirt List Archives

[libvirt] [PATCH 0/4] qemu: Error out if backing image format is not recorded in image metadata
by Peter Krempa 17 Dec '19

17 Dec '19

See patch 3/4 for explanation. Peter Krempa (4): tests: storage: Use strict version of virStorageFileGetMetadata tests: storage: Remove unused test modes util: storage: Don't treat files with missing backing store format as 'raw' kbase: Add document outlining backing chain XML config and troubleshooting docs/kbase.html.in | 4 + docs/kbase/backing_chains.rst | 185 ++++++++++++++++++++++++++++++++++ src/util/virstoragefile.c | 21 +++- tests/virstoragetest.c | 42 +++----- 4 files changed, 221 insertions(+), 31 deletions(-) create mode 100644 docs/kbase/backing_chains.rst -- 2.23.0

3 7

[libvirt] [PATCH v2 00/12] esx: various improvements
by Pino Toscano 17 Dec '19

17 Dec '19

- implement connectListAllStoragePools, so virConnectListAllStoragePools() works - implement connectListAllNetworks, so virConnectListAllNetworks() works - implement storagePoolListAllVolumes, so virStoragePoolListAllVolumes() works - set the proper filesystem type for vmfs-based datastores Pino Toscano (12): esx: split datastoreToStoragePoolPtr helper esx: split datastorePoolType helper esx: split targetToStoragePool helper esx: implement connectListAllStoragePools esx: split virtualswitchToNetwork helper esx: implement connectListAllNetworks storage: add vmfs filesystem type esx: set vmfs fs type for vmfs-based datastores esx: split datastorePathToStorageVol helper esx: split scsilunToStorageVol helper esx: implement storagePoolListAllVolumes docs: document implemented APIs in esx docs/news.xml | 11 + docs/schemas/storagepool.rng | 1 + docs/schemas/storagevol.rng | 1 + docs/storage.html.in | 3 + src/conf/storage_conf.c | 1 + src/conf/storage_conf.h | 1 + src/esx/esx_network_driver.c | 100 +++++- src/esx/esx_storage_backend_iscsi.c | 234 +++++++++++--- src/esx/esx_storage_backend_vmfs.c | 306 +++++++++++++++--- src/esx/esx_storage_driver.c | 87 +++++ .../storagepoolcapsschemadata/poolcaps-fs.xml | 1 + .../poolcaps-full.xml | 1 + 12 files changed, 655 insertions(+), 92 deletions(-) -- 2.21.0

3 23

[libvirt] [PATCH v4 0/5] PCI hostdev partial assignment support
by Daniel Henrique Barboza 17 Dec '19

17 Dec '19

changes from version 3 [1]: - removed last 2 patches that made function 0 of PCI multifunction devices mandatory - new patch: news.xml update - changed 'since' version to 6.0.0 in patch 4 - unassigned hostdevs are now getting qemu aliases [1] https://www.redhat.com/archives/libvir-list/2019-November/msg01263.html Daniel Henrique Barboza (5): Introducing new address type='unassigned' for PCI hostdevs qemu: handle unassigned PCI hostdevs in command line virhostdev.c: check all IOMMU devs in virHostdevPreparePCIDevices formatdomain.html.in: document <address type='unassigned'/> news.xml: add address type='unassigned' entry docs/formatdomain.html.in | 14 ++++ docs/news.xml | 19 ++++++ docs/schemas/domaincommon.rng | 5 ++ src/conf/device_conf.c | 2 + src/conf/device_conf.h | 1 + src/conf/domain_conf.c | 7 +- src/qemu/qemu_command.c | 5 ++ src/qemu/qemu_domain.c | 1 + src/qemu/qemu_domain_address.c | 5 ++ src/util/virhostdev.c | 64 +++++++++++++++++-- .../hostdev-pci-address-unassigned.args | 31 +++++++++ .../hostdev-pci-address-unassigned.xml | 42 ++++++++++++ tests/qemuxml2argvtest.c | 4 ++ .../hostdev-pci-address-unassigned.xml | 58 +++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 15 files changed, 251 insertions(+), 8 deletions(-) create mode 100644 tests/qemuxml2argvdata/hostdev-pci-address-unassigned.args create mode 100644 tests/qemuxml2argvdata/hostdev-pci-address-unassigned.xml create mode 100644 tests/qemuxml2xmloutdata/hostdev-pci-address-unassigned.xml -- 2.23.0

4 19

[libvirt] [PATCH 0/4] Rewrite virGetUser*Directory() functions using g_get_*_dir()
by Fabiano Fidêncio 17 Dec '19

17 Dec '19

By rewriting virGetUser*Directory() functions using g_get_*_dir() functions allows us to drop all the different implementations we keep, as GLib already takes care of those for us. Fabiano Fidêncio (4): util: Rewrite virGetUserDirectory() using g_get_home_dir() util: Rewrite virGetUserConfigDirectory() using g_get_user_config_dir() util: Rewrite virGetUserCacheDirectory() using g_get_user_cache_dir() util: Rewrite virGetUserRuntimeDirectory() using g_get_user_runtime_dir() src/util/virutil.c | 146 +++++++++++++-------------------------------- 1 file changed, 40 insertions(+), 106 deletions(-) -- 2.23.0

1 4

[libvirt] [PATCH] tests: securityselinuxlabel: Add QEMU_CAPS_VNC to fake qemuCaps
by Peter Krempa 17 Dec '19

17 Dec '19

In commit 45270337f057f26ce484f6e forgot to make sure that tests pass. Add the missing capability to fix the test. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- Pushed. tests/securityselinuxlabeltest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/securityselinuxlabeltest.c b/tests/securityselinuxlabeltest.c index 192f2dc84f..3040a36693 100644 --- a/tests/securityselinuxlabeltest.c +++ b/tests/securityselinuxlabeltest.c @@ -351,6 +351,7 @@ mymain(void) return EXIT_FAILURE; virQEMUCapsSet(qemuCaps, QEMU_CAPS_DEVICE_CIRRUS_VGA); + virQEMUCapsSet(qemuCaps, QEMU_CAPS_VNC); if (qemuTestCapsCacheInsert(driver.qemuCapsCache, qemuCaps) < 0) return EXIT_FAILURE; -- 2.23.0

2 1

[libvirt] [PATCH 0/9] Cleanup virConnectPtr usage
by Michal Privoznik 17 Dec '19

17 Dec '19

I've noticed this problem when reviewing a patch on the list [1]. Long story short, dom->conn is not guaranteed to have all driver pointers set (consider split daemons). I haven't identified any other violation than what I'm fixing here. But something might have slipped through my git grep. 1: https://www.redhat.com/archives/libvir-list/2019-December/msg00120.html Michal Prívozník (9): qemu_driver: Push qemuDomainInterfaceAddresses() a few lines down qemu: Don't use dom->conn to lookup virNetwork qemuGetDHCPInterfaces: Move some variables inside the loop qemuGetDHCPInterfaces: Switch to GLib libxl: Don't use dom->conn to lookup virNetwork libxlGetDHCPInterfaces: Move some variables inside the loop libxlGetDHCPInterfaces: Switch to GLib lxc: Cleanup virConnectPtr usage get_nonnull_domain: Drop useless comment src/libxl/libxl_driver.c | 71 ++++------ src/lxc/lxc_driver.c | 12 +- src/lxc/lxc_process.c | 40 +++--- src/lxc/lxc_process.h | 2 +- src/qemu/qemu_driver.c | 193 ++++++++++++---------------- src/remote/remote_daemon_dispatch.c | 3 - 6 files changed, 139 insertions(+), 182 deletions(-) -- 2.23.0

2 10

[libvirt] [PATCH] cpu_map/x86: Add support for BFLOAT16 data type
by Jiri Denemark 17 Dec '19

17 Dec '19

Introduced in QEMU by commit v4.1.0-266-g80db491da4. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/cpu_map/x86_features.xml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index b42b490160..eefb55067e 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -339,6 +339,10 @@ <cpuid eax_in='0x07' ecx_in='0x00' edx='0x80000000'/> </feature> + <feature name='avx512-bf16'> + <cpuid eax_in='0x07' ecx_in='0x01' eax='0x00000020'/> + </feature> +  <feature name='xsaveopt'> <cpuid eax_in='0x0d' ecx_in='0x01' eax='0x00000001'/> -- 2.24.1

2 1

[libvirt] [PATCH] virsh migrate: Require --tls for --tls-destination
by Jiri Denemark 17 Dec '19

17 Dec '19

--tls-destination would be just ignored unless --tls is not specified, which is correct, but let's provide a bit of a guidance is a user forgets to add --tls. https://bugzilla.redhat.com/show_bug.cgi?id=1784345 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- tools/virsh-domain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 56137bdd74..e7e92ee60d 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -10966,6 +10966,7 @@ cmdMigrate(vshControl *ctl, const vshCmd *cmd) VSH_REQUIRE_OPTION("postcopy-after-precopy", "postcopy"); VSH_REQUIRE_OPTION("timeout-postcopy", "postcopy"); VSH_REQUIRE_OPTION("persistent-xml", "persistent"); + VSH_REQUIRE_OPTION("tls-destination", "tls"); if (!(dom = virshCommandOptDomain(ctl, cmd, NULL))) return false; -- 2.24.1

2 3

[libvirt] [glib PATCH 0/2] po: change over to use Weblate instead of Zanata
by Daniel P. Berrangé 17 Dec '19

17 Dec '19

Zanata is dead upstream, and Fedora is replacing it with Weblate https://fedoraproject.org/wiki/L10N_Move_to_Weblate Libvirt has outsourced its translations to the Fedora translation team, so we must follow this move. Daniel P. Berrangé (2): po: delete empty translation files po: change update rules to use weblate instead of zanata po/Makefile.am | 32 +++++++++++++++++++------------- po/af.mini.po | 20 -------------------- po/am.mini.po | 20 -------------------- po/anp.mini.po | 19 ------------------- po/ar.mini.po | 21 --------------------- po/as.mini.po | 20 -------------------- po/ast.mini.po | 20 -------------------- po/bal.mini.po | 20 -------------------- po/be.mini.po | 21 --------------------- po/bg.mini.po | 20 -------------------- po/bn.mini.po | 20 -------------------- po/bn_IN.mini.po | 20 -------------------- po/bo.mini.po | 20 -------------------- po/br.mini.po | 20 -------------------- po/brx.mini.po | 20 -------------------- po/bs.mini.po | 21 --------------------- po/cy.mini.po | 21 --------------------- po/da.mini.po | 20 -------------------- po/de.mini.po | 20 -------------------- po/de_CH.mini.po | 20 -------------------- po/el.mini.po | 20 -------------------- po/eo.mini.po | 20 -------------------- po/et.mini.po | 20 -------------------- po/eu.mini.po | 20 -------------------- po/fa.mini.po | 20 -------------------- po/gl.mini.po | 20 -------------------- po/gu.mini.po | 20 -------------------- po/he.mini.po | 20 -------------------- po/hr.mini.po | 21 --------------------- po/hu.mini.po | 20 -------------------- po/ia.mini.po | 20 -------------------- po/id.mini.po | 20 -------------------- po/ilo.mini.po | 20 -------------------- po/is.mini.po | 20 -------------------- po/it.mini.po | 20 -------------------- po/ka.mini.po | 20 -------------------- po/kk.mini.po | 20 -------------------- po/km.mini.po | 20 -------------------- po/kn.mini.po | 20 -------------------- po/ko.mini.po | 20 -------------------- po/kw.mini.po | 20 -------------------- po/kw(a)kkcor.mini.po | 20 -------------------- po/kw(a)uccor.mini.po | 20 -------------------- po/kw_GB.mini.po | 20 -------------------- po/ky.mini.po | 20 -------------------- po/lt.mini.po | 21 --------------------- po/lv.mini.po | 21 --------------------- po/mai.mini.po | 20 -------------------- po/mk.mini.po | 20 -------------------- po/ml.mini.po | 20 -------------------- po/mn.mini.po | 20 -------------------- po/mr.mini.po | 20 -------------------- po/ms.mini.po | 20 -------------------- po/nb.mini.po | 20 -------------------- po/nds.mini.po | 20 -------------------- po/ne.mini.po | 20 -------------------- po/nl.mini.po | 20 -------------------- po/nn.mini.po | 20 -------------------- po/nso.mini.po | 20 -------------------- po/or.mini.po | 20 -------------------- po/pa.mini.po | 20 -------------------- po/pt.mini.po | 20 -------------------- po/ro.mini.po | 21 --------------------- po/si.mini.po | 20 -------------------- po/sk.mini.po | 20 -------------------- po/sl.mini.po | 21 --------------------- po/sq.mini.po | 20 -------------------- po/sr.mini.po | 21 --------------------- po/sr(a)latin.mini.po | 21 --------------------- po/sv.mini.po | 20 -------------------- po/ta.mini.po | 20 -------------------- po/te.mini.po | 20 -------------------- po/tg.mini.po | 20 -------------------- po/th.mini.po | 20 -------------------- po/tr.mini.po | 20 -------------------- po/tw.mini.po | 19 ------------------- po/ur.mini.po | 20 -------------------- po/vi.mini.po | 20 -------------------- po/wba.mini.po | 19 ------------------- po/yo.mini.po | 19 ------------------- po/zanata.xml | 7 ------- po/zh_CN.mini.po | 20 -------------------- po/zh_HK.mini.po | 20 -------------------- po/zh_TW.mini.po | 20 -------------------- po/zu.mini.po | 20 -------------------- 85 files changed, 19 insertions(+), 1687 deletions(-) delete mode 100644 po/af.mini.po delete mode 100644 po/am.mini.po delete mode 100644 po/anp.mini.po delete mode 100644 po/ar.mini.po delete mode 100644 po/as.mini.po delete mode 100644 po/ast.mini.po delete mode 100644 po/bal.mini.po delete mode 100644 po/be.mini.po delete mode 100644 po/bg.mini.po delete mode 100644 po/bn.mini.po delete mode 100644 po/bn_IN.mini.po delete mode 100644 po/bo.mini.po delete mode 100644 po/br.mini.po delete mode 100644 po/brx.mini.po delete mode 100644 po/bs.mini.po delete mode 100644 po/cy.mini.po delete mode 100644 po/da.mini.po delete mode 100644 po/de.mini.po delete mode 100644 po/de_CH.mini.po delete mode 100644 po/el.mini.po delete mode 100644 po/eo.mini.po delete mode 100644 po/et.mini.po delete mode 100644 po/eu.mini.po delete mode 100644 po/fa.mini.po delete mode 100644 po/gl.mini.po delete mode 100644 po/gu.mini.po delete mode 100644 po/he.mini.po delete mode 100644 po/hr.mini.po delete mode 100644 po/hu.mini.po delete mode 100644 po/ia.mini.po delete mode 100644 po/id.mini.po delete mode 100644 po/ilo.mini.po delete mode 100644 po/is.mini.po delete mode 100644 po/it.mini.po delete mode 100644 po/ka.mini.po delete mode 100644 po/kk.mini.po delete mode 100644 po/km.mini.po delete mode 100644 po/kn.mini.po delete mode 100644 po/ko.mini.po delete mode 100644 po/kw.mini.po delete mode 100644 po/kw(a)kkcor.mini.po delete mode 100644 po/kw(a)uccor.mini.po delete mode 100644 po/kw_GB.mini.po delete mode 100644 po/ky.mini.po delete mode 100644 po/lt.mini.po delete mode 100644 po/lv.mini.po delete mode 100644 po/mai.mini.po delete mode 100644 po/mk.mini.po delete mode 100644 po/ml.mini.po delete mode 100644 po/mn.mini.po delete mode 100644 po/mr.mini.po delete mode 100644 po/ms.mini.po delete mode 100644 po/nb.mini.po delete mode 100644 po/nds.mini.po delete mode 100644 po/ne.mini.po delete mode 100644 po/nl.mini.po delete mode 100644 po/nn.mini.po delete mode 100644 po/nso.mini.po delete mode 100644 po/or.mini.po delete mode 100644 po/pa.mini.po delete mode 100644 po/pt.mini.po delete mode 100644 po/ro.mini.po delete mode 100644 po/si.mini.po delete mode 100644 po/sk.mini.po delete mode 100644 po/sl.mini.po delete mode 100644 po/sq.mini.po delete mode 100644 po/sr.mini.po delete mode 100644 po/sr(a)latin.mini.po delete mode 100644 po/sv.mini.po delete mode 100644 po/ta.mini.po delete mode 100644 po/te.mini.po delete mode 100644 po/tg.mini.po delete mode 100644 po/th.mini.po delete mode 100644 po/tr.mini.po delete mode 100644 po/tw.mini.po delete mode 100644 po/ur.mini.po delete mode 100644 po/vi.mini.po delete mode 100644 po/wba.mini.po delete mode 100644 po/yo.mini.po delete mode 100644 po/zanata.xml delete mode 100644 po/zh_CN.mini.po delete mode 100644 po/zh_HK.mini.po delete mode 100644 po/zh_TW.mini.po delete mode 100644 po/zu.mini.po -- 2.23.0

2 4

[libvirt] [PATCH v3 00/30] Introduce NVMe support
by Michal Privoznik 17 Dec '19

17 Dec '19

v3 of: https://www.redhat.com/archives/libvir-list/2019-September/msg01209.html Builds just fine ;-) https://travis-ci.org/zippy2/libvirt/builds/619622349 diff to v2: - Fixed bug reported by Cole - unability to plug regular <hostdev/>-s caused by v2. Michal Prívozník (30): qemu: Explicitly add/remove /dev/vfio/vfio to/from NS/CGroups qemuDomainGetHostdevPath: Use more g_autoptr()/g_autofree qemuDomainGetHostdevPath: Don't include /dev/vfio/vfio in returned paths qemu: Drop some 'cleanup' labels virpci: Introduce and use virPCIDeviceAddressGetIOMMUGroupDev virHostdevPreparePCIDevices: Separate out function body virHostdevReAttachPCIDevices: Separate out function body virpci: Introduce virPCIDeviceAddressCopy qemuMigrationSrcIsSafe: Rework slightly schemas: Introduce disk type NVMe conf: Format and parse NVMe type disk virstoragefile: Introduce virStorageSourceChainHasNVMe domain_conf: Introduce virDomainDefHasNVMeDisk util: Introduce virNVMeDevice module virhostdev: Include virNVMeDevice module virpcimock: Introduce NVMe driver and devices virhostdevtest: Test virNVMeDevice assignment qemu: prepare NVMe devices too qemu: Take NVMe disks into account when calculating memlock limit qemu: Create NVMe disk in domain namespace qemu: Mark NVMe disks as 'need VFIO' qemu: Allow NVMe disk in CGroups virSecuritySELinuxRestoreImageLabelInt: Don't skip non-local storage qemu_capabilities: Introduce QEMU_CAPS_DRIVE_NVME qemu: Generate command line of NVMe disks qemu_monitor_text: Catch IOMMU/VFIO related errors in qemuMonitorTextAddDrive qemu: Don't leak storage perms on failure in qemuDomainAttachDiskGeneric qemu: Allow forcing VFIO when computing memlock limit qemu_hotplug: Prepare NVMe disks on hotplug virsh: Introduce nvme disk to domblklist docs/formatdomain.html.in | 57 ++- docs/schemas/domaincommon.rng | 32 ++ po/POTFILES.in | 1 + src/conf/domain_conf.c | 109 +++++ src/conf/domain_conf.h | 3 + src/libvirt_private.syms | 28 ++ src/libxl/xen_xl.c | 1 + src/qemu/qemu_block.c | 25 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_cgroup.c | 203 +++++--- src/qemu/qemu_command.c | 6 +- src/qemu/qemu_domain.c | 375 +++++++++------ src/qemu/qemu_domain.h | 15 +- src/qemu/qemu_driver.c | 4 + src/qemu/qemu_hostdev.c | 71 ++- src/qemu/qemu_hostdev.h | 16 + src/qemu/qemu_hotplug.c | 31 +- src/qemu/qemu_migration.c | 30 +- src/qemu/qemu_monitor_text.c | 7 + src/qemu/qemu_process.c | 7 + src/security/security_apparmor.c | 25 +- src/security/security_dac.c | 30 ++ src/security/security_selinux.c | 51 +- src/util/Makefile.inc.am | 2 + src/util/virhostdev.c | 431 +++++++++++++++-- src/util/virhostdev.h | 37 ++ src/util/virnvme.c | 447 ++++++++++++++++++ src/util/virnvme.h | 97 ++++ src/util/virpci.c | 29 ++ src/util/virpci.h | 5 + src/util/virstoragefile.c | 71 +++ src/util/virstoragefile.h | 19 + .../caps_2.12.0.aarch64.xml | 1 + .../caps_2.12.0.ppc64.xml | 1 + .../caps_2.12.0.s390x.xml | 1 + .../caps_2.12.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 1 + .../caps_3.0.0.riscv32.xml | 1 + .../caps_3.0.0.riscv64.xml | 1 + .../qemucapabilitiesdata/caps_3.0.0.s390x.xml | 1 + .../caps_3.0.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 1 + .../caps_3.1.0.x86_64.xml | 1 + .../caps_4.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 1 + .../caps_4.0.0.riscv32.xml | 1 + .../caps_4.0.0.riscv64.xml | 1 + .../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 1 + .../caps_4.0.0.x86_64.xml | 1 + .../caps_4.1.0.x86_64.xml | 1 + .../caps_4.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 + .../caps_4.2.0.x86_64.xml | 1 + tests/qemumemlocktest.c | 2 +- .../disk-nvme.x86_64-latest.args | 63 +++ tests/qemuxml2argvdata/disk-nvme.xml | 63 +++ tests/qemuxml2argvtest.c | 1 + tests/qemuxml2xmloutdata/disk-nvme.xml | 1 + tests/qemuxml2xmltest.c | 1 + tests/virhostdevtest.c | 97 ++++ tests/virpcimock.c | 3 + tests/virpcitestdata/0000-01-00.0.config | Bin 0 -> 4096 bytes tests/virpcitestdata/0000-02-00.0.config | Bin 0 -> 4096 bytes tools/virsh-domain-monitor.c | 31 +- 66 files changed, 2240 insertions(+), 312 deletions(-) create mode 100644 src/util/virnvme.c create mode 100644 src/util/virnvme.h create mode 100644 tests/qemuxml2argvdata/disk-nvme.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/disk-nvme.xml create mode 120000 tests/qemuxml2xmloutdata/disk-nvme.xml create mode 100644 tests/virpcitestdata/0000-01-00.0.config create mode 100644 tests/virpcitestdata/0000-02-00.0.config -- 2.23.0

3 67

[libvirt] [PATCH 0/2] build: -Wframe-larger-than shenanigans
by Ján Tomko 17 Dec '19

17 Dec '19

The recent cputest addition broke the build with clang for me, since clang calculates the stack size differently than gcc. Put the strict limit into all warning by default (this starts enforcing it for examples, for example) and raise the limit by a few orders, which might appear Sisyphean but I believe it's needed for putting two conflicting limits on the compiler command line. Ján Tomko (2): build: warn on a large frame by default build: relax the relaxed stack frame limit further m4/virt-compile-warnings.m4 | 4 ++-- src/Makefile.am | 2 -- tools/Makefile.am | 2 -- 3 files changed, 2 insertions(+), 6 deletions(-) -- 2.19.2

2 4

[libvirt] [PATCH] virtio-blk: deprecate SCSI passthrough
by Stefan Hajnoczi 17 Dec '19

17 Dec '19

The Linux virtio_blk.ko guest driver is removing legacy SCSI passthrough support. Deprecate this feature in QEMU too. Signed-off-by: Stefan Hajnoczi <stefanha(a)redhat.com> --- qemu-deprecated.texi | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index 4b4b7425ac..ef94d497da 100644 --- a/qemu-deprecated.texi +++ b/qemu-deprecated.texi @@ -285,6 +285,17 @@ spec you can use the ``-cpu rv64gcsu,priv_spec=v1.9.1`` command line argument. @section Device options +@subsection Emulated device options + +@subsubsection -device virtio-blk,scsi=on|off (since 5.0.0) + +The virtio-blk SCSI passthrough feature is a legacy VIRTIO feature. VIRTIO 1.0 +and later do not support it because the virtio-scsi device was introduced for +full SCSI support. Use virtio-scsi instead when SCSI passthrough is required. + +Note this also applies to ``-device virtio-blk-pci,scsi=on|off'', which is an +alias. + @subsection Block device options @subsubsection "backing": "" (since 2.12.0) -- 2.23.0

6 7

[libvirt] [PATCH 0/5] Introduce the support of Intel RDT-MBM
by Wang Huaqiang 17 Dec '19

17 Dec '19

RDT is the short for Intel Resource Director Technology, consists of four sub-technologies until now: -. CAT for cache allocation -. CMT for cache usage monitoring -. MBA for memory bandwidth allocation -. MBM for memory bandwidth usage monitoring The Linux kernel interface is 'resctrl' file system, and we have already implemented the support of CAT, CMT and MBA, to accomplish the tasks such as allocating a part of shared CPU last level cache to particular domain vcpu or a list of vcpus and monitoring the usage of cache, or the task of allocating a mount of memory bandwidth to specify domain vcpu(s). This series is to introduce the support of MBM. Basically the interfaces are: ** Identify host capability ** Similar to identify the host capability of CMT, it could be gotten through the result of 'virsh capabilities', if following elements are found, then MBM is supported: <memory_bandwidth> <monitor maxMonitors='176'> <feature name='mbm_total_bytes'/> <feature name='mbm_local_bytes'/> </monitor> </memory_bandwidth> 'mbm_total_bytes' means supporting to report the memory bandwidth used by the vcpu(s) of specific monitor on all CPU sockets. 'mbm_local_bytes' means supporting to report the memory bandwidth used by vcpu(s) that is passing through local CPU socket. ** Create monitor group** The monitor group for specific domain vcpus, for example vcpu 0-4, is defined in domain configuration file, in such kind of way: <cputune> <memorytune vcpus='0-4'> <monitor vcpus='0-4'/> </memorytune> </cputune> ** Report memory usage ** Introduced an option '--memory' against 'virsh domstats' command to show the memory bandwidth usage in such way: (also very similar to the format of CMT result.) # virsh domstats --memory Domain: 'libvirt-vm' memory.bandwidth.monitor.count=4 memory.bandwidth.monitor.0.name=vcpus_0-4 memory.bandwidth.monitor.0.vcpus=0-4 memory.bandwidth.monitor.0.node.count=2 memory.bandwidth.monitor.0.node.0.id=0 memory.bandwidth.monitor.0.node.0.bytes.total=14201651200 memory.bandwidth.monitor.0.node.0.bytes.local=7369809920 memory.bandwidth.monitor.0.node.1.id=1 memory.bandwidth.monitor.0.node.1.bytes.total=188897640448 memory.bandwidth.monitor.0.node.1.bytes.local=170044047360 Huaqiang (5): util, resctrl: using 64bit interface instead of 32bit for counters conf: showing cache/memoryBW monitor features in capabilities cachetune schema: a looser check for the order of <cache> and <monitor> element conf: Parse dommon configure file for memorytune monitors virsh: show memoryBW info in 'virsh domstats' command docs/schemas/domaincommon.rng | 91 +++++++++--------- include/libvirt/libvirt-domain.h | 1 + src/conf/capabilities.c | 4 +- src/conf/domain_conf.c | 44 +++++++-- src/libvirt-domain.c | 21 +++++ src/qemu/qemu_driver.c | 103 ++++++++++++++++++++- src/util/virfile.c | 40 ++++++++ src/util/virfile.h | 2 + src/util/virresctrl.c | 6 +- src/util/virresctrl.h | 2 +- tests/genericxml2xmlindata/cachetune.xml | 1 + tests/genericxml2xmlindata/memorytune.xml | 5 + tests/genericxml2xmloutdata/cachetune.xml | 34 +++++++ tests/genericxml2xmloutdata/memorytune.xml | 42 +++++++++ tests/genericxml2xmltest.c | 4 +- tools/virsh-domain-monitor.c | 7 ++ tools/virsh.pod | 23 ++++- 17 files changed, 367 insertions(+), 63 deletions(-) create mode 100644 tests/genericxml2xmloutdata/cachetune.xml create mode 100644 tests/genericxml2xmloutdata/memorytune.xml -- 2.23.0

4 17

[libvirt] [PATCH v1 00/26] move qemucaps validations from qemu_command to qemu_domain
by Daniel Henrique Barboza 16 Dec '19

16 Dec '19

(series based on master commit 97cafa610ecf5) This work was proposed by Cole in [1]. This is Cole's reasoning for it, copy/pasted from [1]: ------- The benefits of moving to validate time is that XML is rejected by 'virsh define' rather than at 'virsh start' time. It also makes it easier to follow the cli building code, and makes it easier to verify qemu_command.c test suite code coverage for the important stuff like covering every CLI option. It's also a good intermediate step for sharing validation with domain capabilities building, like is done presently for rng models. ------- Cole also mentioned that the machine features validation was a good place to start. I took it a step further and did it across the board on all qemu_command.c. This series didn't create any new validation, just moved them to domain define time. Any other outcome is unintended. Not all cases where covered in this work. For a first version I decided to do only the most trivial cases. These are the other cases I left out for another day: - all verifications contained in functions that are also called by qemu_hotplug.c. This means that the hotplug process will also use the validation code, and we can't just move it to qemu_domain.c. Besides, not all validation done in domain define time applies to hotplug, so it's not simply a matter of calling the same function from qemu_domain in qemu_hotplug. I have patches that moved the verification of all virtio options to qemu_domain.c, while also considering qemu_hotplug validation. In the end I decided to leave it away from this work for now because (1) it took 8 patches just for virtio case alone and (2) there are a lot of these cases in qemu_command.c and it would be too much to do it all at in this same series. - moving CPU Model validation is trickier than the rest because there are code in DefPostParse() that makes CPU Model changes that are then validated in qemu_command.c. Moving the validation to define time doesn't cut in this case - the validation is considering PostParse changes in the CPU Model and some of the will fail if done by qemuDomainDefValidate time. I didn't think too much about how to handle this case, but given that the approach would be different from the other cases handled here, I left it out too. - SHMem: part of SHMem validation is being used by hotplug code. I could've moved the non-hotplug validation to define time, instead I decided it's better to to leave it to do it all at once in the future. - DBus-VMState: validation of this fella must be done by first querying if the hash vm->priv->dbusVMState has elements. qemuDomainDefValidate does not have 'vm->priv' in it's API, meaning that I would need to either change the API to include it (which means changing domainValidateCallback), or do the validation by another branch where I can get access to vm->priv. - vmcoreinfo: there are no challenges in moving vmcoreinfo validation to qemuDomainDefValidate. The problem were the unit tests. Moving this validation to domain define time breaks 925 tests on qemuxml2xmltest.c, including tests labelled as 'minimal' which should pass under any circurstances, as far as I understand. It is possible to just shoehorn QEMU_CAPS_DEVICE_VMCOREINFO in the qemuCaps of all tests, but this would tamper the idea of having to deal with NONE or LATEST or a specific set of capabilities for certain tests. Another case I would rather discuss separately. [1] https://www.redhat.com/archives/libvir-list/2019-October/msg00568.html Daniel Henrique Barboza (26): qemu_command.c: move PSeries features validation to qemu_domain.c qemu_command.c: move mem.nosharepages validation to qemu_domain.c qemu_command.c: move validation of vmport to qemu_domain.c qemu_command.c: move nvdimm validation to qemu_domain.c qemu_command.c: move I/O APIC validation to qemu_domain.c numa_conf: add virDomainNumaNodesDistancesAreBeingSet() helper qemu_command.c move NUMA validation to qemu_domain.c qemu_command.c: move NVRAM validation to qemu_domain.c qemu_command: move qemuBuildSoundDevStr caps validation to qemu_domain qemu_command.c: move sound codec validation to qemu_domain.c qemu_command: move qemuBuildHubDevStr caps validation to qemu_domain qemu_command: move qemuBuildChrChardevStr caps validation to qemu_domain qemu: move qemuBuildHostdevCommandLine caps validation to qemu_domain qemu_command.c: move vmGenID validation to qemu_domain.c qemu: move qemuBuildSgaCommandLine validation to qemu_domain.c qemu: move virDomainClockDef validation to qemu_domain.c qemu: move qemuBuildPMCommandLine validation to qemu_domain.c qemu: move qemuBuildBootCommandLine validation to qemu_domain.c qemu_command.c: move pcihole64 validation to qemu_domain.c qemu: move qemuBuildGraphicsSDLCommandLine validation to qemu_domain.c qemu: move qemuBuildGraphicsVNCCommandLine validation to qemu_domain.c qemu: move qemuBuildGraphicsSPICECommandLine validation to qemu_domain.c qemu: move qemuBuildGraphicsEGLHeadlessCommandLine validation to qemu_domain.c qemu: move qemuBuildSmartcardCommandLine validation to qemu_domain.c qemu: move qemuBuildConsoleCommandLine validation to qemu_domain.c qemu: move qemuBuildTPMDevStr TPM validation to qemu_domain.c src/conf/numa_conf.c | 19 + src/conf/numa_conf.h | 2 + src/libvirt_private.syms | 1 + src/qemu/qemu_command.c | 575 +--------- src/qemu/qemu_command.h | 1 + src/qemu/qemu_domain.c | 983 ++++++++++++++++-- tests/qemuhotplugtest.c | 10 + tests/qemumemlocktest.c | 16 +- .../default-video-type-aarch64.xml | 2 +- .../default-video-type-ppc64.xml | 2 +- .../default-video-type-s390x.xml | 2 +- .../graphics-egl-headless.args | 2 +- .../graphics-spice-egl-headless.args | 2 +- .../graphics-vnc-egl-headless.args | 2 +- tests/qemuxml2argvtest.c | 80 +- ...ault-video-type-aarch64.aarch64-latest.xml | 4 +- .../default-video-type-ppc64.ppc64-latest.xml | 4 +- .../default-video-type-s390x.s390x-latest.xml | 4 +- tests/qemuxml2xmltest.c | 244 +++-- 19 files changed, 1246 insertions(+), 709 deletions(-) -- 2.23.0

4 42

[libvirt] [PATCH v6 0/4] scripts: convert most perl scripts to python
by Daniel P. Berrangé 16 Dec '19

16 Dec '19

This series is an effort to reduce the number of different languages we use by eliminating most use of perl in favour of python. This aligns with fact that the likely future build system we'll use (meson) is written in python, and that python is much more commonly used/understood by developers these days than perl. With this applied we use perl in a handful of places only: - src/rpc/gendispatch.pl - this is a horrendously large script and very hard to understand/follow. A straight syntax conversion to Python would still leave a hgue and hard to understand/follow script. It really needs a clean room rewrite from scratch, with better structure. - src/rpc/genprotocol.pl - fairly easy to convert, but might be obsolete depending on approach for rewriting gendispatch.pl, so ignored for now - tests/oomtrace.pl - will be purge by the patches that drop OOM handling anyway - tools/wireshark/util/genxdrstub.pl - a very large script, which I haven't got the courage to tackle yet. - cfg.mk/maint.mk - many syntax rules involve regexes which are fed to perl. Decision on what to do with syntax-check rules punted to another time. - build-aux/gitlog-to-changelog - build-aux/useless-if-before-free - Both pulled in from gnulib. Could be rewritten quite easily if desired, but given that we aren't maintainers of them right now, they're ignored as they don't really impact our developers. Note that the check-spacing.py script is significantly slower in Python than in Perl. After researching this it appears there is nothing that can be done. The Perl regex engine is simply much better optimized than the Python one. As previously discussed we need to loook at uncrustify or clang-format or some other tool to validate whitespace formatting. This is ongoing. We can either accept the slow down in the short term or keep the Perl version in the short term. In v6: - Fix various bugs in check-file-access.py so it now reports same output as original perl script. - Merged the already-ACKd scripts In v5: - Rebased to cope with changes to require VPATH build - Merged the already-ACKd scripts In v4: - Moved all scripts into the scripts/ directory instead of having them scattered around source tree - Use re.search instead of re.match - Don't bother re-compiling regexes In v3: - All scripts comply with all flake8 style rules with exception of E129 visually indented line with same indent as next logical line In v2: - Pulled in patch to hacking file - Converted many more scripts - Forced UTF-8 character set to avoid ascii codec on py3 < 3.7 Daniel P. Berrangé (4): tests: rewrite qemu capability grouper in Python tests: rewrite file access checker in Python docs: rewrite hvsupport.html page generator in python docs: rewrite polkit docs generator in Python Makefile.am | 4 + build-aux/syntax-check.mk | 3 +- docs/Makefile.am | 12 +- docs/genaclperms.pl | 125 -------- docs/hvsupport.pl | 459 ----------------------------- scripts/check-file-access.py | 125 ++++++++ scripts/genaclperms.py | 121 ++++++++ scripts/group-qemu-caps.py | 121 ++++++++ scripts/hvsupport.py | 502 ++++++++++++++++++++++++++++++++ tests/Makefile.am | 3 +- tests/check-file-access.pl | 130 --------- tests/file_access_whitelist.txt | 2 +- tests/group-qemu-caps.pl | 124 -------- 13 files changed, 882 insertions(+), 849 deletions(-) delete mode 100755 docs/genaclperms.pl delete mode 100755 docs/hvsupport.pl create mode 100755 scripts/check-file-access.py create mode 100755 scripts/genaclperms.py create mode 100755 scripts/group-qemu-caps.py create mode 100755 scripts/hvsupport.py delete mode 100755 tests/check-file-access.pl delete mode 100755 tests/group-qemu-caps.pl -- 2.21.0

2 5

[libvirt] [tck PATCH] Update x86_64 image & virt-builder image to F31
by Daniel P. Berrangé 16 Dec '19

16 Dec '19

i386 was dropped even as a secondary arch in F31 so must remain on F30 Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- conf/default.cfg | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/conf/default.cfg b/conf/default.cfg index 39d9b04..3493ad7 100644 --- a/conf/default.cfg +++ b/conf/default.cfg @@ -49,7 +49,7 @@ images = ( hvm xen ) - osname = fedora-30 + osname = fedora-31 } ) @@ -76,6 +76,7 @@ images = ( # kernels = ( # Fedora 30 i686 PAE has pv_ops, so one kernel can do both Xen and KVM guests here + # No i386 releases since F30 { arch = i686 ostype = ( @@ -85,15 +86,15 @@ kernels = ( kernel = http://dl.fedoraproject.org/pub/fedora-secondary/releases/30/Everything/i38… initrd = http://dl.fedoraproject.org/pub/fedora-secondary/releases/30/Everything/i38… } - # Fedora 30 x86_64 has pv_ops, so one kernel can do both Xen and KVM guests here + # Fedora 31 x86_64 has pv_ops, so one kernel can do both Xen and KVM guests here { arch = x86_64 ostype = ( hvm xen ) - kernel = http://dl.fedoraproject.org/pub/fedora/linux/releases/30/Everything/x86_64/… - initrd = http://dl.fedoraproject.org/pub/fedora/linux/releases/30/Everything/x86_64/… + kernel = http://dl.fedoraproject.org/pub/fedora/linux/releases/31/Everything/x86_64/… + initrd = http://dl.fedoraproject.org/pub/fedora/linux/releases/31/Everything/x86_64/… } # LXC containers need a virtual container filesystem somewhere # { -- 2.23.0

2 1

[libvirt] ongoing code transitions section on the wiki
by Cole Robinson 16 Dec '19

16 Dec '19

Hi all, I added a 'Ongoing code transitions' section to the BiteSizedTasks page on the wiki: https://wiki.libvirt.org/page/BiteSizedTasks#Ongoing_code_transitions BiteSizedTasks might not be the best location for it, but I wanted to start a list and that page already exists. I added 3 sections: * g_autofree/g_autoptr, with some example conversion commits * GLib in general, listing APIs that can replace custom libvirt code. Currently the list is only g_key_file for virkeyfile, g_user_*_dir for virGetUser*Dir, some virFile APIs for g_path_* APIs. * gnulib removal. I filled in a few examples of possible gnulib module replacements, and listed all the others as 'Unsorted/replacments unclear'. If you know any GLib replacements for existing code or gnulib modules, please fill them in there. Or any other incomplete code conversions internally Thanks, Cole

1 0

[libvirt] [rust PATCH] Domain: Implement scheduler information related APIs
by Vineeth Remanan Pillai 16 Dec '19

16 Dec '19

Implement the following: - virDomainGetSchedulerType - virDomainSetSchedulerParameters - virDomainSetSchedulerParametersFlags - virDomainGetSchedulerParameters - virDomainGetSchedulerParametersFlags Signed-off-by: Vineeth Remanan Pillai <vpilllai(a)digitalocean.com> --- examples/hello.rs | 38 +++++++ src/domain.rs | 260 +++++++++++++++++++++++++++++++++++++++++++--- 2 files changed, 283 insertions(+), 15 deletions(-) diff --git a/examples/hello.rs b/examples/hello.rs index e5ec6e4..1f336a9 100644 --- a/examples/hello.rs +++ b/examples/hello.rs @@ -89,6 +89,44 @@ fn show_domains(conn: &Connect) -> Result<(), Error> { numa.node_set.unwrap_or(String::from(""))); println!(" Mode: {}", numa.mode.unwrap_or(0)); } + + if let Ok((sched_type, nparams)) = dom.get_scheduler_type() { + println!("SchedType: {}, nparams: {}", + sched_type, nparams); + } + + if let Ok(sched_info) = dom.get_scheduler_parameters() { + println!("Schedule Information:"); + println!("\tScheduler\t: {}", sched_info.scheduler_type); + if let Some(shares) = sched_info.cpu_shares { + println!("\tcpu_shares\t: {}", shares); + } + if let Some(period) = sched_info.vcpu_bw.period { + println!("\tvcpu_period\t: {}", period); + } + if let Some(quota) = sched_info.vcpu_bw.quota { + println!("\tvcpu_quota\t: {}", quota); + } + if let Some(period) = sched_info.emulator_bw.period { + println!("\temulator_period\t: {}", period); + } + if let Some(quota) = sched_info.emulator_bw.quota { + println!("\temulator_quota\t: {}", quota); + } + if let Some(period) = sched_info.global_bw.period { + println!("\tglobal_period\t: {}", period); + } + if let Some(quota) = sched_info.global_bw.quota { + println!("\tglobal_quota\t: {}", quota); + } + if let Some(period) = sched_info.global_bw.period { + println!("\tiothread_period\t: {}", period); + } + if let Some(quota) = sched_info.global_bw.quota { + println!("\tiothread_quota\t: {}", quota); + } + } + } } return Ok(()); diff --git a/src/domain.rs b/src/domain.rs index acb9e6e..40a18d8 100644 --- a/src/domain.rs +++ b/src/domain.rs @@ -363,6 +363,29 @@ extern "C" { snaps: *mut *mut virDomainSnapshotPtr, flags: libc::c_uint) -> libc::c_int; + + fn virDomainGetSchedulerType(ptr: sys::virDomainPtr, + nparams: *mut libc::c_int) + -> *mut libc::c_char; + fn virDomainGetSchedulerParameters(ptr: sys::virDomainPtr, + params: virTypedParameterPtr, + nparams: *mut libc::c_int) + -> libc::c_int; + fn virDomainSetSchedulerParameters(ptr: sys::virDomainPtr, + params: virTypedParameterPtr, + nparams: libc::c_int) + -> libc::c_int; + fn virDomainGetSchedulerParametersFlags(ptr: sys::virDomainPtr, + params: virTypedParameterPtr, + nparams: *mut libc::c_int, + flags: libc::c_uint) + -> libc::c_int; + fn virDomainSetSchedulerParametersFlags(ptr: sys::virDomainPtr, + params: virTypedParameterPtr, + nparams: libc::c_int, + flags: libc::c_uint) + -> libc::c_int; + } pub type DomainXMLFlags = self::libc::c_uint; @@ -607,6 +630,124 @@ impl MemoryStats { } } +/// Structure representing the CFS scheduler cpu bandwidth parameters +/// see https://www.kernel.org/doc/html/latest/scheduler/sched-bwc.html +#[derive(Clone, Debug, Default)] +pub struct SchedBandwidth { + pub period: Option<u64>, + pub quota: Option<i64>, +} + +#[derive(Clone, Debug, Default)] +pub struct SchedulerInfo { + pub scheduler_type: String, + // cpu shares for the domain. + pub cpu_shares: Option<u64>, + // Bandwidth allocated for the vcpu threads. + pub vcpu_bw: SchedBandwidth, + // Bandwidth allocated for the emulator threads. + pub emulator_bw: SchedBandwidth, + // Bandwidth allocated for the Domain. + pub global_bw: SchedBandwidth, + // Bandwidth allocated for the io threads.. + pub iothread_bw: SchedBandwidth, +} + +impl SchedulerInfo { + pub fn from_vec(vec: Vec<virTypedParameter>, scheduler_type: String) -> SchedulerInfo { + unsafe { + let mut ret = SchedulerInfo::default(); + ret.scheduler_type = scheduler_type; + for param in vec { + match str::from_utf8(CStr::from_ptr(param.field.as_ptr()).to_bytes()).unwrap() { + "cpu_shares" => ret.cpu_shares = Some(param.value as u64), + "vcpu_period" => ret.vcpu_bw.period = Some(param.value as u64), + "vcpu_quota" => ret.vcpu_bw.quota = Some(param.value as i64), + "emulator_period" => ret.emulator_bw.period = Some(param.value as u64), + "emulator_quota" => ret.emulator_bw.quota = Some(param.value as i64), + "global_period" => ret.global_bw.period = Some(param.value as u64), + "global_quota" => ret.global_bw.quota = Some(param.value as i64), + "iothread_period" => ret.iothread_bw.period = Some(param.value as u64), + "iothread_quota" => ret.iothread_bw.quota = Some(param.value as i64), + unknow => panic!("Field not implemented for SchedulerInfo, {:?}", unknow), + } + } + ret + } + } + + pub fn to_vec(&self) -> Vec<virTypedParameter> { + let mut cparams: Vec<virTypedParameter> = Vec::new(); + + if let Some(shares) = self.cpu_shares { + cparams.push(virTypedParameter { + field: to_arr("cpu_shares\0"), + typed: ::typedparam::VIR_TYPED_PARAM_ULLONG, + value: shares + }); + } + + if let Some(period) = self.vcpu_bw.period { + cparams.push(virTypedParameter { + field: to_arr("vcpu_period\0"), + typed: ::typedparam::VIR_TYPED_PARAM_ULLONG, + value: period, + }); + } + if let Some(quota) = self.vcpu_bw.quota { + cparams.push(virTypedParameter { + field: to_arr("vcpu_quota\0"), + typed: ::typedparam::VIR_TYPED_PARAM_LLONG, + value: quota as u64, + }); + } + if let Some(period) = self.emulator_bw.period { + cparams.push(virTypedParameter { + field: to_arr("emulator_period\0"), + typed: ::typedparam::VIR_TYPED_PARAM_ULLONG, + value: period, + }); + } + if let Some(quota) = self.emulator_bw.quota { + cparams.push(virTypedParameter { + field: to_arr("emulator_quota\0"), + typed: ::typedparam::VIR_TYPED_PARAM_LLONG, + value: quota as u64, + }); + } + if let Some(period) = self.global_bw.period { + cparams.push(virTypedParameter { + field: to_arr("global_period\0"), + typed: ::typedparam::VIR_TYPED_PARAM_ULLONG, + value: period, + }); + } + if let Some(quota) = self.global_bw.quota { + cparams.push(virTypedParameter { + field: to_arr("global_quota\0"), + typed: ::typedparam::VIR_TYPED_PARAM_LLONG, + value: quota as u64, + }); + } + if let Some(period) = self.iothread_bw.period { + cparams.push(virTypedParameter { + field: to_arr("iothread_period\0"), + typed: ::typedparam::VIR_TYPED_PARAM_ULLONG, + value: period, + }); + } + if let Some(quota) = self.iothread_bw.quota { + cparams.push(virTypedParameter { + field: to_arr("iothread_quota\0"), + typed: ::typedparam::VIR_TYPED_PARAM_LLONG, + value: quota as u64, + }); + } + + cparams + } +} + /// Provides APIs for the management of domains. /// /// See http://libvirt.org/html/libvirt-libvirt-domain.html @@ -627,6 +768,14 @@ impl Drop for Domain { } } +fn to_arr(name: &str) -> [libc::c_char; 80] { + let mut field: [libc::c_char; 80] = [0; 80]; + for (a, c) in field.iter_mut().zip(name.as_bytes()) { + *a = *c as i8 + } + field +} + impl Domain { pub fn new(ptr: sys::virDomainPtr) -> Domain { return Domain { ptr: Some(ptr) }; @@ -1656,14 +1805,6 @@ impl Domain { flags: u32) -> Result<u32, Error> { unsafe { - fn to_arr(name: &str) -> [libc::c_char; 80] { - let mut field: [libc::c_char; 80] = [0; 80]; - for (a, c) in field.iter_mut().zip(name.as_bytes()) { - *a = *c as i8 - } - field - } - let mut cparams: Vec<virTypedParameter> = Vec::new(); if params.hard_limit.is_some() { cparams.push(virTypedParameter { @@ -1809,13 +1950,6 @@ impl Domain { pub fn set_numa_parameters(&self, params: NUMAParameters, flags: u32) -> Result<u32, Error> { unsafe { - fn to_arr(name: &str) -> [libc::c_char; 80] { - let mut field: [libc::c_char; 80] = [0; 80]; - for (a, c) in field.iter_mut().zip(name.as_bytes()) { - *a = *c as i8 - } - field - } let mut cparams: Vec<virTypedParameter> = Vec::new(); if params.node_set.is_some() { @@ -1863,4 +1997,100 @@ impl Domain { return Ok(array); } } + + /// Get the cpu scheduler type for the domain + pub fn get_scheduler_type(&self) -> Result<(String, i32), Error> + { + unsafe { + let mut nparams: libc::c_int = -1; + let sched_type = virDomainGetSchedulerType(self.as_ptr(), + &mut nparams); + if sched_type.is_null() { + return Err(Error::new()); + } + + return Ok((c_chars_to_string!(sched_type), nparams)); + } + } + + /// Get the scheduler parameters for the domain. + pub fn get_scheduler_parameters(&self) -> Result<SchedulerInfo, Error> { + + let (sched_type, mut nparams) = self.get_scheduler_type()?; + unsafe { + let mut params: Vec<virTypedParameter> = vec![ + virTypedParameter::default(); 9]; + let ret = virDomainGetSchedulerParameters(self.as_ptr(), + &mut params[0], + &mut nparams); + if ret == -1 { + return Err(Error::new()); + } + Ok(SchedulerInfo::from_vec(params, sched_type)) + } + + } + + /// Get the scheduler parameters for the domain for the configuration + /// as specified by the flags. + /// # Arguments + /// + /// * `flags` - Specifies the Domain Impact: CONFIG, LIVE or CURRENT. + pub fn get_scheduler_parameters_flags(&self, + flags: DomainModImpactFlags) + -> Result<SchedulerInfo, Error> { + + let (sched_type, mut nparams) = self.get_scheduler_type()?; + unsafe { + let mut params: Vec<virTypedParameter> = vec![ + virTypedParameter::default(); 9]; + let ret = virDomainGetSchedulerParametersFlags(self.as_ptr(), + &mut params[0], + &mut nparams, + flags as libc::c_uint); + if ret == -1 { + return Err(Error::new()); + } + Ok(SchedulerInfo::from_vec(params, sched_type)) + } + + } + + /// Set the scheduler parameters for the domain. + pub fn set_scheduler_parameters(&self, + sched_info: &SchedulerInfo) + -> Result<i32, Error> { + unsafe { + let mut params = sched_info.to_vec(); + let ret = virDomainSetSchedulerParameters(self.as_ptr(), + &mut params[0], + params.len() as libc::c_int); + if ret == -1 { + return Err(Error::new()); + } + Ok(ret) + } + } + + /// Set the scheduler parameters for the domain for the configuration + /// as specified by the flags. + /// # Arguments + /// + /// * `flags` - Specifies the Domain Impact: CONFIG, LIVE or CURRENT. + pub fn set_scheduler_parameters_flags(&self, + sched_info: &SchedulerInfo, + flags: DomainModImpactFlags) + -> Result<i32, Error> { + unsafe { + let mut params = sched_info.to_vec(); + let ret = virDomainSetSchedulerParametersFlags(self.as_ptr(), + &mut params[0], + params.len() as libc::c_int, + flags as libc::c_uint); + if ret == -1 { + return Err(Error::new()); + } + Ok(ret) + } + } } -- 2.17.1

2 2

[libvirt] [PATCH] src: warn against virNodeGetInfo() API call due to inaccurate info
by Daniel P. Berrangé 16 Dec '19

16 Dec '19

Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- include/libvirt/libvirt-host.h | 4 ++++ src/libvirt-host.c | 16 ++++++++++++++++ 2 files changed, 20 insertions(+) diff --git a/include/libvirt/libvirt-host.h b/include/libvirt/libvirt-host.h index be65b4686b..b87d634813 100644 --- a/include/libvirt/libvirt-host.h +++ b/include/libvirt/libvirt-host.h @@ -147,6 +147,10 @@ typedef virSecurityModel *virSecurityModelPtr; * * a virNodeInfo is a structure filled by virNodeGetInfo() and providing * the information for the Node. + * + * Note that the information in this struct is not guaranteed to be an + * accurate relection of the system hardware. See the virNodeGetInfo() + * API documentation for further guidance. */ typedef struct _virNodeInfo virNodeInfo; diff --git a/src/libvirt-host.c b/src/libvirt-host.c index 94ba5a8e80..bc3d1d2803 100644 --- a/src/libvirt-host.c +++ b/src/libvirt-host.c @@ -399,6 +399,22 @@ virConnectGetMaxVcpus(virConnectPtr conn, * * Extract hardware information about the node. * + * Use of this API is strongly discouraged as the information provided + * is not guaranteed to be accurate on all hardware platforms. + * + * The mHZ value merely reflects the speed that the first CPU in the + * machine is currently running at. This speed may vary across CPUs + * and changes continually as the host OS throttles. + * + * The nodes/sockets/cores/threads data is potentially inaccurate as + * it assumes a symmetric installation. If one NUMA node has more + * sockets populated that another NUMA node this information will be + * wrong. It is also not able to report about CPU dies. + * + * Applications are recommended to use the virConnectGetCapabilities() + * call instead, which provides all the information except CPU mHZ, + * in a more accurate representation. + * * Returns 0 in case of success and -1 in case of failure. */ int -- 2.23.0

2 1

[libvirt] [PATCH] tools: skip libvirt-guests fast if libvirtd is not active
by Christian Ehrhardt 16 Dec '19

16 Dec '19

The most common operation of libvirt-guests is to manage the local libvirtd. But users might have disabled that and while we are After=libvirtd for ordering we are not Requiring it.. OTOH adding that or any harder dependency might affect our ordering. But if people have disabled libvirt they will do a full retry loop until timeout. Lets check if the local service is active at all and skip fast if it is not. Fixes: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1854653 Reported-by: Doug Smythies <dsmythies(a)telus.net> Signed-off-by: Christian Ehrhardt <christian.ehrhardt(a)canonical.com> --- tools/libvirt-guests.sh.in | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tools/libvirt-guests.sh.in b/tools/libvirt-guests.sh.in index 4bc6e866f0..5a9930ee2f 100644 --- a/tools/libvirt-guests.sh.in +++ b/tools/libvirt-guests.sh.in @@ -90,6 +90,14 @@ test_connect() { uri=$1 + if [ "x$uri" = xdefault ]; then + # Default config is most common and for the local libvirtd + # Check if it is active before wasting time in connect loop + if ! systemctl -q is-active libvirtd; then + return 1 + fi + fi + i=${CONNECT_RETRIES} while [ $i -gt 0 ]; do run_virsh "$uri" connect 2>/dev/null -- 2.24.0

4 8

[libvirt] [PATCH] virsh.pod: Mention iscsi-direct is supported in find-storage-pool-sources
by Han Han 13 Dec '19

13 Dec '19

Signed-off-by: Han Han <hhan(a)redhat.com> --- tools/virsh.pod | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index a8331154e1..14f4121787 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -3994,7 +3994,8 @@ any other provided XML elements in I<srcSpec>. For a "logical" pool, the contents of the I<srcSpec> file are ignored, although if provided the file must at least exist. -For an "iscsi" pool, the minimal expect XML required is the <host> element +For an "iscsi" or "iscsi-direct" pool, +the minimal expect XML required is the <host> element with a "name" attribute describing the IP address or hostname to be used to find the pool (the iSCSI server address). Optionally, the "port" attribute may be provided, although it will default to 3260. Optionally, an <initiator> -- 2.24.0.rc1

2 1

[libvirt] [PATCH v3 0/6] PCI hostdev partial assignment support
by Daniel Henrique Barboza 13 Dec '19

13 Dec '19

changes from previous version [1]: - do not overload address type='none'. A new address type called 'unassigned' is introduced; - there is no unassigned' flag being created in virDomainHostdevDef. The logic added by new address type is enough; - do not allow function zero of multifunction devices to be unassigned. Nothing too special to discuss in this cover letter. More details can be found at the discussions of the previous version [1]. Commit messages of the patches have more background info as well. [1] https://www.redhat.com/archives/libvir-list/2019-November/msg01099.html Daniel Henrique Barboza (6): Introducing new address type='unassigned' for PCI hostdevs qemu: handle unassigned PCI hostdevs in command line and alias virhostdev.c: check all IOMMU devs in virHostdevPreparePCIDevices formatdomain.html.in: document <address type='unassigned'/> utils: PCI multifunction detection helpers domain_conf.c: don't allow function zero to be unassigned docs/formatdomain.html.in | 14 +++ docs/schemas/domaincommon.rng | 5 ++ src/conf/device_conf.c | 2 + src/conf/device_conf.h | 1 + src/conf/domain_conf.c | 20 ++++- src/libvirt_private.syms | 2 + src/qemu/qemu_alias.c | 6 ++ src/qemu/qemu_command.c | 5 ++ src/qemu/qemu_domain.c | 1 + src/qemu/qemu_domain_address.c | 5 ++ src/util/virhostdev.c | 88 +++++++++++++++++-- src/util/virhostdev.h | 3 + src/util/virpci.c | 17 ++++ src/util/virpci.h | 2 + .../hostdev-pci-address-unassigned.args | 31 +++++++ .../hostdev-pci-address-unassigned.xml | 42 +++++++++ ...pci-multifunction-zero-unassigned-fail.xml | 42 +++++++++ tests/qemuxml2argvtest.c | 8 ++ .../hostdev-pci-address-unassigned.xml | 58 ++++++++++++ tests/qemuxml2xmltest.c | 1 + tests/virpcimock.c | 9 +- 21 files changed, 351 insertions(+), 11 deletions(-) create mode 100644 tests/qemuxml2argvdata/hostdev-pci-address-unassigned.args create mode 100644 tests/qemuxml2argvdata/hostdev-pci-address-unassigned.xml create mode 100644 tests/qemuxml2argvdata/hostdev-pci-multifunction-zero-unassigned-fail.xml create mode 100644 tests/qemuxml2xmloutdata/hostdev-pci-address-unassigned.xml -- 2.23.0

2 9

[libvirt] [libvirt-tck PATCH] Add cases for nvram
by Dan Zheng 13 Dec '19

13 Dec '19

This is to add the tests for below flags: - Sys::Virt::Domain::UNDEFINE_KEEP_NVRAM - Sys::Virt::Domain::UNDEFINE_NVRAM Signed-off-by: Dan Zheng <dzheng(a)redhat.com> --- scripts/domain/401-ovmf-nvram.t | 143 ++++++++++++++++++++++++++++++++ 1 file changed, 143 insertions(+) create mode 100644 scripts/domain/401-ovmf-nvram.t diff --git a/scripts/domain/401-ovmf-nvram.t b/scripts/domain/401-ovmf-nvram.t new file mode 100644 index 0000000..5310dd0 --- /dev/null +++ b/scripts/domain/401-ovmf-nvram.t @@ -0,0 +1,143 @@ +# -*- perl -*- +# +# Copyright (C) 2009 Red Hat, Inc. +# Copyright (C) 2018 Dan Zheng (dzheng(a)redhat.com) +# +# This program is free software; You can redistribute it and/or modify +# it under the GNU General Public License as published by the Free +# Software Foundation; either version 2, or (at your option) any +# later version +# +# The file "LICENSE" distributed along with this file provides full +# details of the terms and conditions +# + +=pod + +=head1 NAME + +domain/401-ovmf-nvram.t - Test OVMF related functions and flags + +=head1 DESCRIPTION + +The test cases validates OVMF related APIs and flags + +Sys::Virt::Domain::UNDEFINE_KEEP_NVRAM +Sys::Virt::Domain::UNDEFINE_NVRAM + +=cut + +use strict; +use warnings; + +use Test::More tests => 8; + +use Sys::Virt::TCK; +use File::stat; +use File::Copy; + + +my $tck = Sys::Virt::TCK->new(); +my $conn = eval { $tck->setup(); }; +BAIL_OUT "failed to setup test harness: $@" if $@; +END { $tck->cleanup if $tck; } + + +sub setup_nvram { + +my $loader_path = shift; +my $nvram_template = shift; +my $nvram_path = shift; + +# Install OVMF and check the two files should exist +# - /usr/share/OVMF/OVMF_CODE.secboot.fd +# - /usr/share/OVMF/OVMF_VARS.fd + +my $ret = `yum install -y OVMF`; +diag "yum install OVMF: $ret"; +my $st = stat($loader_path); +ok($st, "path $loader_path exists after OVMF is installed"); +$st = stat($nvram_template); +ok($st, "path $nvram_template exists after OVMF is installed"); + +# Ensure the sample nvram file exists +copy($nvram_template, $nvram_path) or die "Copy failed: $!"; + +# Use 'q35' as machine type and add below lines to guest xml +# <loader readonly='yes' secure='yes' type='pflash'>/usr/share/OVMF/OVMF_CODE.secboot.fd</loader> +# <nvram template='/usr/share/OVMF/OVMF_VARS.fd'>/var/lib/libvirt/qemu/nvram/test_VARS.fd</nvram> + +my $xml = $tck->generic_domain(name => "tck")->as_xml; +my $xp = XML::XPath->new($xml); +diag $xp->getNodeText("/domain/os/type/\@machine"); + +diag "Changing guest machine type to q35"; +$xp->setNodeText("/domain/os/type/\@machine", "q35"); + +my $loader_node = XML::XPath::Node::Element->new('loader'); +my $loader_text = XML::XPath::Node::Text->new($loader_path); +my $attr_ro = XML::XPath::Node::Attribute->new('readonly'); +my $attr_secure = XML::XPath::Node::Attribute->new('secure'); +my $attr_type = XML::XPath::Node::Attribute->new('type'); + +$attr_ro -> setNodeValue('yes'); +$attr_secure -> setNodeValue('yes'); +$attr_type -> setNodeValue('pflash'); + +$loader_node->appendChild($loader_text); +$loader_node->appendAttribute($attr_ro); +$loader_node->appendAttribute($attr_secure); +$loader_node->appendAttribute($attr_type); + +my $nvram_node = XML::XPath::Node::Element->new('nvram'); +my $nvram_text = XML::XPath::Node::Text->new($nvram_path); +my $attr_template = XML::XPath::Node::Attribute->new('template'); + +$attr_template -> setNodeValue($nvram_template); + +$nvram_node->appendChild($nvram_text); +$nvram_node->appendAttribute($attr_template); + +my $smm_node = XML::XPath::Node::Element->new('smm'); +my $attr_state = XML::XPath::Node::Attribute->new('state'); +$attr_state -> setNodeValue("on"); +$smm_node -> appendAttribute($attr_state); + +my ($root) = $xp->findnodes('/domain/os'); +$root->appendChild($loader_node); +$root->appendChild($nvram_node); +($root) = $xp->findnodes('/domain/features'); +$root->appendChild($smm_node); + +$xml = $xp->findnodes_as_string('/'); +diag $xml; +return $xml; +} + +diag "Defining an inactive domain config with nvram"; +my $loader_file_path = '/usr/share/OVMF/OVMF_CODE.secboot.fd'; +my $nvram_file_template = '/usr/share/OVMF/OVMF_VARS.fd'; +my $nvram_file_path = '/var/lib/libvirt/qemu/nvram/test_VARS.fd'; + +my $xml = setup_nvram($loader_file_path, $nvram_file_template, $nvram_file_path); +my $dom; + +diag "Test Sys::Virt::Domain::UNDEFINE_KEEP_NVRAM"; +ok_domain(sub { $dom = $conn->define_domain($xml) }, "defined domain with nvram configure"); +diag "Checking nvram file already exists"; +my $st = stat($nvram_file_path); +ok($st, "File '$nvram_file_path' exists as expected"); +$dom->undefine(Sys::Virt::Domain::UNDEFINE_KEEP_NVRAM); +diag "Checking nvram file still exists"; +$st = stat($nvram_file_path); +ok($st, "File '$nvram_file_path' still exists as expected"); + +diag "Test Sys::Virt::Domain::UNDEFINE_NVRAM"; +ok_domain(sub { $dom = $conn->define_domain($xml) }, "defined domain with nvram configure"); +$dom->undefine(Sys::Virt::Domain::UNDEFINE_NVRAM); +diag "Checking nvram file removed"; +$st = stat($nvram_file_path); +ok(!$st, "File '$nvram_file_path' is removed"); + +ok_error(sub { $conn->get_domain_by_name("tck") }, "NO_DOMAIN error raised from missing domain", + Sys::Virt::Error::ERR_NO_DOMAIN); -- 2.18.1

2 1

[libvirt] [PATCH 0/2] configure: Provide OpenRC scripts for sub-daemons
by Michal Privoznik 13 Dec '19

13 Dec '19

Tested on my Gentoo and it works (TM). I've copied dependencies from systemd unit files. I was also thinking about providing a dummy init script that would do nothing but depend on the rest of sub-daemon init files for convenience: /etc/init.d/libvirt-dummy start (the name is still WIP) But I'm not sure if we want that - after we drop libvirtd we can use libvirtd script just for that. But if somebody wants it, I can write and post it as a follow up patch. Michal Prívozník (2): configure: Provide OpenRC scripts for sub-daemons news: Document init scripts docs/news.xml | 11 ++++++ m4/virt-init-script.m4 | 8 +++- src/Makefile.am | 56 +++++++++++++++++++++++++++- src/interface/Makefile.inc.am | 11 ++++++ src/interface/virtinterfaced.init.in | 26 +++++++++++++ src/libxl/Makefile.inc.am | 10 +++++ src/libxl/virtxend.init.in | 26 +++++++++++++ src/lxc/Makefile.inc.am | 10 +++++ src/lxc/virtlxcd.init.in | 26 +++++++++++++ src/network/Makefile.inc.am | 10 +++++ src/network/virtnetworkd.init.in | 26 +++++++++++++ src/node_device/Makefile.inc.am | 11 ++++++ src/node_device/virtnodedevd.init.in | 26 +++++++++++++ src/nwfilter/Makefile.inc.am | 11 ++++++ src/nwfilter/virtnwfilterd.init.in | 26 +++++++++++++ src/qemu/Makefile.inc.am | 10 +++++ src/qemu/virtqemud.init.in | 26 +++++++++++++ src/remote/Makefile.inc.am | 30 +++++++++++++++ src/remote/libvirtd.confd | 18 +++++++++ src/remote/libvirtd.init.in | 29 ++++++++++++++ src/remote/virtproxyd.confd | 10 +++++ src/remote/virtproxyd.init.in | 28 ++++++++++++++ src/secret/Makefile.inc.am | 10 +++++ src/secret/virtsecretd.init.in | 26 +++++++++++++ src/storage/Makefile.inc.am | 10 +++++ src/storage/virtstoraged.init.in | 26 +++++++++++++ src/vbox/Makefile.inc.am | 10 +++++ src/vbox/virtvboxd.init.in | 26 +++++++++++++ src/vz/Makefile.inc.am | 10 +++++ src/vz/virtvzd.init.in | 26 +++++++++++++ 30 files changed, 587 insertions(+), 2 deletions(-) create mode 100644 src/interface/virtinterfaced.init.in create mode 100644 src/libxl/virtxend.init.in create mode 100644 src/lxc/virtlxcd.init.in create mode 100644 src/network/virtnetworkd.init.in create mode 100644 src/node_device/virtnodedevd.init.in create mode 100644 src/nwfilter/virtnwfilterd.init.in create mode 100644 src/qemu/virtqemud.init.in create mode 100644 src/remote/libvirtd.confd create mode 100644 src/remote/libvirtd.init.in create mode 100644 src/remote/virtproxyd.confd create mode 100644 src/remote/virtproxyd.init.in create mode 100644 src/secret/virtsecretd.init.in create mode 100644 src/storage/virtstoraged.init.in create mode 100644 src/vbox/virtvboxd.init.in create mode 100644 src/vz/virtvzd.init.in -- 2.23.0

2 4

[libvirt] [PATCH RESEND 0/4] Add support for Hygon Dhyana CPU
by Yingle Hou 13 Dec '19

13 Dec '19

As a Joint Venture between AMD and Haiguang Information Technology Co., Ltd., Hygon aims to provide x86 server processor in China market. The first generation processor Dhyana (family 18h) shares similar architecture with AMD family 17h. As Dhyana support in QEMU already have been merged in qemu-4.1.0 [1], to add Dhyana support in libvirt, we have added a new Dhyana CPU model file x86_Dhyana.xml in cpu_map directory, and also we have added a series of Dhyana test files. We have tested the patches on Hygon Dhyana machine with the result that it has successfully worked as expected. Reference: [1] https://patchwork.kernel.org/patch/10902889/ Yingle Hou (4): cpu: Remove the verification conditions of the model in the x86 signatures cpu: Add new Dhyana CPU model cputest: Add CPUID data for Hygon Dhyana 7185 32-core Processor domaincapstest: Add CPU model Dhyana to QEMU src/cpu/cpu_x86.c | 2 +- src/cpu_map/Makefile.inc.am | 1 + src/cpu_map/index.xml | 3 + src/cpu_map/x86_Dhyana.xml | 70 + src/cpu_map/x86_vendors.xml | 1 + tests/cputest.c | 1 + ...86_64-cpuid-Hygon-C86-7185-32-core-disabled.xml | 7 + ...x86_64-cpuid-Hygon-C86-7185-32-core-enabled.xml | 9 + .../x86_64-cpuid-Hygon-C86-7185-32-core-guest.xml | 16 + .../x86_64-cpuid-Hygon-C86-7185-32-core-host.xml | 17 + .../x86_64-cpuid-Hygon-C86-7185-32-core-json.xml | 12 + .../x86_64-cpuid-Hygon-C86-7185-32-core.json | 1631 ++++++++++++++++++++ .../x86_64-cpuid-Hygon-C86-7185-32-core.sig | 4 + .../x86_64-cpuid-Hygon-C86-7185-32-core.xml | 54 + tests/domaincapsdata/qemu_4.1.0-q35.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.1.0.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.2.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.x86_64.xml | 1 + 20 files changed, 1833 insertions(+), 1 deletion(-) create mode 100644 src/cpu_map/x86_Dhyana.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core-guest.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core-host.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core-json.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core.json create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core.sig create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core.xml -- 1.8.3.1

2 9