- Devel - libvirt List Archives

[libvirt PATCH] docs: fix a typo
by Ján Tomko 31 Jan '20

31 Jan '20

s/axnd/and/ Signed-off-by: Ján Tomko <jtomko(a)redhat.com> Fixes: f0f34056ab26eaa9f903a51cd1fa155088fd640f --- Pushed as trivial docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 20bf6a9b84..60a103d7c6 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -5877,7 +5877,7 @@ <p> <span class="since">Since 6.1.0 (QEMU and KVM only, requires - QEMU 4.2.0 or newer axnd a guest virtio-net driver supporting + QEMU 4.2.0 or newer and a guest virtio-net driver supporting the "failover" feature, such as the one included in Linux kernel 4.18 and newer) </span> -- 2.19.2

1 0

[libvirt] [PATCH v1 0/8] domain_addr and qemu_domain cleanups
by Daniel Henrique Barboza 31 Jan '20

31 Jan '20

Hi, These are a few cleanups in some files that I'll end up messing with in a future series (which isn't Glibfied ATM). Figured it's best to clean them up now instead of adding more non-Glibfied code on top. Patches 7 and 8 are stuff that I noted some time ago and figured it might be worth sending as well. Daniel Henrique Barboza (8): conf/domain_addr.c: use g_autofree in strings conf/domain_addr.c: remove unneeded 'cleanup' labels qemu_domain.c: remove redundant virObjectUnref() qemu_domain.c: use g_autofree when possible qemu_domain.c: use g_autoptr when possible qemu_domain.c: removing unneeded cleanup labels qemu_domain.c: turn qemuDomainChrDefDropDefaultPath to void qemu_domain_address.c: turn qemuDomainFillDeviceIsolationGroup to void src/conf/domain_addr.c | 124 +++----- src/qemu/qemu_domain.c | 511 +++++++++++---------------------- src/qemu/qemu_domain_address.c | 20 +- src/qemu/qemu_domain_address.h | 2 +- src/qemu/qemu_hotplug.c | 6 +- 5 files changed, 227 insertions(+), 436 deletions(-) -- 2.24.1

2 11

[hooks PATCH] Don't allow @localhost email addresses in commit message
by Daniel P. Berrangé 31 Jan '20

31 Jan '20

Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- update | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/update b/update index 247b008..966fe22 100755 --- a/update +++ b/update @@ -264,6 +264,19 @@ if [ $check_diff = yes ]; then fi done fi + + allow_localhost_email=$(git config --bool hooks.allowlocalhostemail) + if [ "$allow_localhost_email" != "true" ]; then + for rev in `git log --format=%h $oldrev..$newrev` + do + git show $rev | grep '@localhost' >/dev/null 2>&1 + if test $? != 0 + then + echo "*** Update hook: @localhost email address is forbidden $rev" >&2 + exit 1 + fi + done + fi fi # --- Finished -- 2.24.1

3 2

[libvirt PATCH] docs: Update godoc URLs for Go packages
by Andrea Bolognani 31 Jan '20

31 Jan '20

Since commit 201156ec6e65e08cdb04d6fdefe013652fb7fa87 Author: Daniel P. Berrangé <berrange(a)redhat.com> Date: Mon Dec 16 10:06:50 2019 +0000 docs: add pages to support Go module package resolution it's possible to use import "libvirt.org/libvirt-go" import "libvirt.org/libvirt-go-xml" in Go programs, which will result in the Go packages being fetched directly from libvirt.org instead of GitHub. The godoc website offers the API documentation for the updated imports, and that's where we should send users. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- docs/downloads.html.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/downloads.html.in b/docs/downloads.html.in index e84455ca04..d4b4701ee0 100644 --- a/docs/downloads.html.in +++ b/docs/downloads.html.in @@ -71,7 +71,7 @@ <a href="https://github.com/libvirt/libvirt-go">github</a> </td> <td> - <a href="https://godoc.org/github.com/libvirt/libvirt-go">api ref</a> + <a href="https://godoc.org/libvirt.org/libvirt-go">api ref</a> </td> </tr> <tr> @@ -206,7 +206,7 @@ <a href="https://github.com/libvirt/libvirt-go-xml">github</a> </td> <td> - <a href="https://godoc.org/github.com/libvirt/libvirt-go-xml">api ref</a> + <a href="https://godoc.org/libvirt.org/libvirt-go-xml">api ref</a> </td> </tr> <tr> -- 2.24.1

2 1

[libvirt PATCH] docs: Update download location for Go packages
by Andrea Bolognani 31 Jan '20

31 Jan '20

We haven't ever made releases of the Go components, which makes sense because that's just not how that specific ecosystem works. For people who are looking to use libvirt from Go, the brief introductory pages located at the same URLs used to import the packages are a much better entry point than an empty directory listing, so let's send them there instead. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- docs/downloads.html.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/downloads.html.in b/docs/downloads.html.in index e84455ca04..7cbf3cadc0 100644 --- a/docs/downloads.html.in +++ b/docs/downloads.html.in @@ -61,7 +61,7 @@ <tr> <td>Go</td> <td> - <a href="https://libvirt.org/sources/go/">libvirt</a> + <a href="https://libvirt.org/libvirt-go">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-go.git;a=summary">libvirt</a> @@ -196,7 +196,7 @@ <tr> <td>Go XML</td> <td> - <a href="https://libvirt.org/sources/go/">libvirt</a> + <a href="https://libvirt.org/libvirt-go-xml">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-go-xml.git;a=summary">libvirt</a> -- 2.24.1

2 1

[PATCH] apparmor: fix qemu_bridge_helper for named profile
by Christian Ehrhardt 31 Jan '20

31 Jan '20

Since a3ab6d42 "apparmor: convert libvirtd profile to a named profile" the detection of the subelement for qemu_bridge_helper is wrong. In combination with the older 123cc3e1 "apparmor: allow /usr/lib/qemu/qemu-bridge-helper" it now detects qemu-bridge-helper no more with its path, but instead as a proper subelement of the named profile like: label=libvirtd//qemu_bridge_helper In the same fashion the reverse rule in the qemu_bridge_helper sub-profile still uses the path and not the named profile label. Triggering denies like: apparmor="DENIED" operation="file_inherit" profile="libvirtd//qemu_bridge_helper" pid=5629 comm="qemu-bridge-hel" family="unix" sock_type="stream" protocol=0 requested_mask="send receive" denied_mask="send receive" addr=none peer_addr=none peer="libvirtd" This patch fixes the unix socket rules for the communication between libvirtd and qemu-bridge-helper to match that. Fixes: a3ab6d42d825499af44b8f19f9299e150d9687bc Fixes: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1655111 Signed-off-by: Christian Ehrhardt <christian.ehrhardt(a)canonical.com> --- src/security/apparmor/usr.sbin.libvirtd | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/security/apparmor/usr.sbin.libvirtd b/src/security/apparmor/usr.sbin.libvirtd index 29f9936ad9..172972e525 100644 --- a/src/security/apparmor/usr.sbin.libvirtd +++ b/src/security/apparmor/usr.sbin.libvirtd @@ -62,8 +62,8 @@ profile libvirtd /usr/sbin/libvirtd flags=(attach_disconnected) { signal (send) set=("kill", "term") peer=unconfined, # For communication/control to qemu-bridge-helper - unix (send, receive) type=stream addr=none peer=(label=/usr/sbin/libvirtd//qemu_bridge_helper), - signal (send) set=("term") peer=/usr/sbin/libvirtd//qemu_bridge_helper, + unix (send, receive) type=stream addr=none peer=(label=libvirtd//qemu_bridge_helper), + signal (send) set=("term") peer=libvirtd//qemu_bridge_helper, # allow connect with openGraphicsFD, direction reversed in newer versions unix (send, receive) type=stream addr=none peer=(label=libvirt-[0-9a-f]*-[0-9a-f]*-[0-9a-f]*-[0-9a-f]*-[0-9a-f]*), @@ -121,7 +121,7 @@ profile libvirtd /usr/sbin/libvirtd flags=(attach_disconnected) { network inet stream, # For communication/control from libvirtd - unix (send, receive) type=stream addr=none peer=(label=/usr/sbin/libvirtd), + unix (send, receive) type=stream addr=none peer=(label=libvirtd), signal (receive) set=("term") peer=/usr/sbin/libvirtd, signal (receive) set=("term") peer=libvirtd, -- 2.25.0

2 2

[PATCH 00/10] qemu: Fix pre-creation of non-shared storage on migration
by Peter Krempa 30 Jan '20

30 Jan '20

The last patch fixes a bug where we'd fail to detect capacity of disks on migration source due to changes in disk topology related to blockdev. The rest of the series makes the function at least somewhat sane. Peter Krempa (10): util: hash: Use g_new0 for allocating hash internals conf: domain: Remove checking of return value of virHashCreateFull Remove checking of return value of virHashNew qemuMigrationCookieAddNBD: Exit early if there are no disks qemuMigrationCookieNBD: Extract embedded struct qemuMigrationCookieAddNBD: Use glib memory allocators qemuMigrationCookieAddNBD: Move monitor call out of the loop qemuMigrationCookieAddNBD: Use virHashNew and automatic freeing of virHashTablePtr qemuMigrationCookieAddNBD: Remove 'ret' variable and 'cleanup' label qemuMigrationCookieAddNBD: Fix filling of 'capacity' when blockdev is used src/conf/backup_conf.c | 6 +--- src/conf/domain_addr.c | 32 +++++++----------- src/qemu/qemu_migration_cookie.c | 58 +++++++++++++++----------------- src/qemu/qemu_migration_cookie.h | 10 +++--- src/qemu/qemu_monitor_json.c | 3 +- src/util/virhash.c | 14 +++----- 6 files changed, 54 insertions(+), 69 deletions(-) -- 2.24.1

2 14

[PATCH v2 00/21] PCI Multifunction hotplug/hotunplug support
by Daniel Henrique Barboza 30 Jan '20

30 Jan '20

This series adds PCI multifunction hotplug/unplug capabilities for Libvirt. Some of these patches were sent last year in a shorter prep series in [1]. The patches then got a bit of rework to keep up with Libvirt changes in master. This work follows the considerations made for the unplug design in [2]. A first version of this series were sent back in 2018 [3], so this is the official version 2 of that work. The design guideline for the patches can be summed up as: - attach/detach functions were changed to handle a list of devices instead of a single device definition. The regular device attach/detach is represented with a list with size = 1; - common code between single device and multifunction device mechanics were moved to 'internal' versions of the functions; - for the 'Live' operations, both attach and detach were handled in specialized functions for the multifunction case. The regular case is still being handled by the same functions. This allowed us to add the multifunction support without changing existing regular attach/detach device support. Attaching/detaching a multifunction device works by supplying the <devices> XML to the same attach/detach commands we already use. It is expected to supply the same XML when detaching the device, as discussed in [2]. Despite the changes and additions I've made, this is still adherent to the original 2018 series from Shivaprasad G Bhat. [1] https://www.redhat.com/archives/libvir-list/2019-August/msg01382.html [2] https://www.redhat.com/archives/libvir-list/2020-January/msg00865.html [3] https://www.redhat.com/archives/libvir-list/2018-March/msg00729.html Daniel Henrique Barboza (4): utils: PCI multifunction detection helpers qemu_hotplug.c: tune unplugTimeout for multifunction detach qemu_hotplug: do not hotplug/hotunplug 'unassigned' hostdevs qemu_hotplug.c: use enhanced multifunction unplug if available Shivaprasad G Bhat (17): qemu: address: Separate the slots into multiple aggregates virhostdev: Introduce virHostdevPCIDevicesBelongToSameSlot qemu: address: Enable auto addressing multifunction cards conf: qemu: validate multifunction hostdevice domain configs conf: Add helper to get active functions of a slot of domain qemu: hostdev: Move the hostdev preparation to a separate function qemu: hotplug: Move the detach of PCI device to the beginning of live hotplug qemu: hotplug: move assignment outside qemuDomainAttachHostPCIDevice Introduce virDomainDeviceDefParseXMLMany Introduce qemuDomainDeviceParseXMLMany qemu: refactor qemuDomain[Attach|Detach]DeviceConfig qemu: refactor qemuDomain[Attach|Detach]DeviceLive qemu: hotplug: Queue and wait for multiple devices domain: addr: Introduce virDomainPCIAddressEnsureMultifunctionAddress qemu: hotplug: Implement multifunction device hotplug qemu: hotplug: Prevent updates to multifunction device qemu: hotplug: Implement multifunction device unplug src/conf/device_conf.h | 7 + src/conf/domain_addr.c | 129 ++++- src/conf/domain_addr.h | 43 +- src/conf/domain_conf.c | 198 +++++++- src/conf/domain_conf.h | 35 ++ src/libvirt_private.syms | 10 + src/qemu/qemu_domain.c | 73 +++ src/qemu/qemu_domain.h | 21 +- src/qemu/qemu_domain_address.c | 366 ++++++++++++++- src/qemu/qemu_domain_address.h | 16 + src/qemu/qemu_driver.c | 242 +++++++--- src/qemu/qemu_hotplug.c | 440 +++++++++++++++--- src/qemu/qemu_hotplug.h | 14 + src/util/virhostdev.c | 54 +++ src/util/virhostdev.h | 5 + src/util/virpci.c | 17 + src/util/virpci.h | 4 + tests/qemuhotplugtest.c | 68 ++- ...emuhotplug-multifunction-hostdev-pci-2.xml | 14 + ...plug-multifunction-hostdev-pci-partial.xml | 27 ++ .../qemuhotplug-multifunction-hostdev-pci.xml | 26 ++ ...live+multifunction-hostdev-pci-partial.xml | 82 ++++ ...ug-base-live+multifunction-hostdev-pci.xml | 82 ++++ ...-base-live+multifunction-hostdev-pci-2.xml | 59 +++ ...es-base-live+multifunction-hostdev-pci.xml | 69 +++ .../hostdev-pci-address-unassigned.args | 9 +- .../hostdev-pci-multifunction.args | 18 +- .../hostdev-pci-multifunction.xml | 8 +- .../hostdev-pci-no-primary-function.xml | 23 + .../hostdev-pci-validate.args | 30 ++ .../qemuxml2argvdata/hostdev-pci-validate.xml | 29 ++ .../qemuxml2argvdata/pseries-hostdevs-1.args | 5 +- .../qemuxml2argvdata/pseries-hostdevs-3.args | 5 +- tests/qemuxml2argvtest.c | 14 +- .../hostdev-pci-address-unassigned.xml | 8 +- .../hostdev-pci-multifunction.xml | 24 +- .../qemuxml2xmloutdata/pseries-hostdevs-1.xml | 4 +- .../qemuxml2xmloutdata/pseries-hostdevs-3.xml | 4 +- tests/virpcitestdata/0005-90-01.1.config | Bin 256 -> 256 bytes tests/virpcitestdata/0005-90-01.2.config | Bin 256 -> 256 bytes tests/virpcitestdata/0005-90-01.3.config | Bin 0 -> 256 bytes 41 files changed, 2023 insertions(+), 259 deletions(-) create mode 100644 tests/qemuhotplugtestdevices/qemuhotplug-multifunction-hostdev-pci-2.xml create mode 100644 tests/qemuhotplugtestdevices/qemuhotplug-multifunction-hostdev-pci-partial.xml create mode 100644 tests/qemuhotplugtestdevices/qemuhotplug-multifunction-hostdev-pci.xml create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-base-live+multifunction-hostdev-pci-partial.xml create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-base-live+multifunction-hostdev-pci.xml create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-pseries-base-live+multifunction-hostdev-pci-2.xml create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-pseries-base-live+multifunction-hostdev-pci.xml create mode 100644 tests/qemuxml2argvdata/hostdev-pci-no-primary-function.xml create mode 100644 tests/qemuxml2argvdata/hostdev-pci-validate.args create mode 100644 tests/qemuxml2argvdata/hostdev-pci-validate.xml create mode 100644 tests/virpcitestdata/0005-90-01.3.config -- 2.24.1

1 22

[PATCH] docs: update Rust releases and resources links
by Sahid Orentino Ferdjaoui 30 Jan '20

30 Jan '20

This is updating the releases and resources links so they point now to crates.io for the releases and docs.rs for the api ref. Signed-off-by: Sahid Orentino Ferdjaoui <sahid.ferdjaoui(a)canonical.com> --- docs/downloads.html.in | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/downloads.html.in b/docs/downloads.html.in index e84455ca04..50e0c54046 100644 --- a/docs/downloads.html.in +++ b/docs/downloads.html.in @@ -165,7 +165,7 @@ <tr> <td>Rust</td> <td> - <a href="https://libvirt.org/sources/rust/">libvirt</a> + <a href="https://crates.io/crates/virt">crates.io</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-rust.git;a=summary">libvirt</a> @@ -174,7 +174,9 @@ <a href="https://gitlab.com/libvirt/libvirt-rust">gitlab</a> <a href="https://github.com/libvirt/libvirt-rust">github</a> </td> - <td></td> + <td> + <a href="https://docs.rs/virt">api ref</a> + </td> </tr> <tr> <th colspan="7">Integration modules</th> -- 2.20.1

2 1

[PATCH 0/6] Couple of apparmor fixes
by Michal Privoznik 30 Jan '20

30 Jan '20

These are inspired by Gentoo patch [1]. However, they still match what we do upstream, so I figured we should merge them. 1: https://github.com/gentoo/gentoo/blob/master/app-emulation/libvirt/files/li… Michal Prívozník (6): apparmor: Fix parthelper, iohelper and virt-aa-helper paths in profiles apparmor: Allow libvirt to spawn virt-aa-helper and libvirt_lxc docs: Fix virt-aa-helper location apparmor: Rename virt-aa-helper profile apparmor: Sort paths in blocks in libvirt-qemu profile apparmor: Allow some more BIOS/UEFI paths docs/drvqemu.html.in | 2 +- src/security/Makefile.inc.am | 10 +-- src/security/apparmor/libvirt-qemu | 78 ++++++++++--------- ...t-aa-helper => usr.libexec.virt-aa-helper} | 6 +- src/security/apparmor/usr.sbin.libvirtd | 6 +- 5 files changed, 53 insertions(+), 49 deletions(-) rename src/security/apparmor/{usr.lib.libvirt.virt-aa-helper => usr.libexec.virt-aa-helper} (90%) -- 2.24.1

4 18

[libvirt PATCH 0/2] Use immediate paket delivery mode instead of buffering in the DHCP snoop thread
by Erik Skultety 30 Jan '20

30 Jan '20

See patch 2 for the reasoning. Erik Skultety (2): libpcap: Bump the minimum required version to >= 1.5.0 nwfilter: Use immediate paket delivery mode rather than buffering libvirt.spec.in | 2 +- m4/virt-libpcap.m4 | 2 +- src/nwfilter/nwfilter_dhcpsnoop.c | 24 +----------------------- 3 files changed, 3 insertions(+), 25 deletions(-) -- 2.24.1

3 5

[libvirt-rust PATCH v3 0/4] Map more functions in stream module
by Zixing Liu 30 Jan '20

30 Jan '20

This set of patches will add more functions to the Rust bindings. Newly mapped functions from C library: virStreamNew virStreamEventUpdateCallback virStreamEventRemoveCallback virStreamEventAddCallback. virStreamEventAddCallback can accept normal fn functions or closures (can capture variables outside) The changes are not very thoroughly tested since event module is not implemented at all so the virStreamEventAddCallback will always return "unsupported by the connection driver". Version 2: Addressed comments Version 3: Undo format changes and rebased against latest branch Zixing Liu (4): libvirt-rust: stream: add more functions in stream libvirt-rust: stream: add more functions in stream libvirt-rust: use reference instead of moving libvirt-rust: stream: addressed comments src/domain.rs | 2 +- src/stream.rs | 94 ++++++++++++++++++++++++++++++++++++++++++++++--- tests/stream.rs | 40 +++++++++++++++++++++ 3 files changed, 130 insertions(+), 6 deletions(-) create mode 100644 tests/stream.rs -- 2.25.0

2 5

[libvirt-go PATCH] Import from libvirt.org instead of github.com
by Andrea Bolognani 30 Jan '20

30 Jan '20

Since commit 201156ec6e65e08cdb04d6fdefe013652fb7fa87 Author: Daniel P. Berrangé <berrange(a)redhat.com> Date: Mon Dec 16 10:06:50 2019 +0000 docs: add pages to support Go module package resolution it's possible to use import "libvirt.org/libvirt-go" in Go programs, which will result in the Go bindings being fetched directly from libvirt.org thus removing our reliance on GitHub. Update the documentation accordingly. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- README.md | 4 ++-- doc.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 326d6a0..c11e9ab 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,4 @@ -# libvirt-go [![Build Status](https://travis-ci.org/libvirt/libvirt-go.svg?branch=master)](https:… [![GoDoc](https://godoc.org/github.com/libvirt/libvirt-go?status.svg)](https://godoc.org/github.com/libvirt/libvirt-go) +# libvirt-go [![Build Status](https://travis-ci.org/libvirt/libvirt-go.svg?branch=master)](https:… [![GoDoc](https://godoc.org/libvirt.org/libvirt-go?status.svg)](https://godoc.org/libvirt.org/libvirt-go) Go bindings for libvirt. @@ -32,7 +32,7 @@ changes may apply to future versions: ## Documentation -* [api documentation for the bindings](https://godoc.org/github.com/libvirt/libvirt-go) +* [api documentation for the bindings](https://godoc.org/libvirt.org/t libvirt-go) * [api documentation for libvirt](http://libvirt.org/html/libvirt-libvirt.html) ## Contributing diff --git a/doc.go b/doc.go index 55d75b0..35c9962 100644 --- a/doc.go +++ b/doc.go @@ -116,7 +116,7 @@ // To connect to libvirt // // import ( -// libvirt "github.com/libvirt/libvirt-go" +// libvirt "libvirt.org/libvirt-go" // ) // conn, err := libvirt.NewConnect("qemu:///system") // if err != nil { -- 2.24.1

3 3

[libvirt-go-xml PATCH] Import from libvirt.org instead of github.com
by Andrea Bolognani 30 Jan '20

30 Jan '20

Since commit 201156ec6e65e08cdb04d6fdefe013652fb7fa87 Author: Daniel P. Berrangé <berrange(a)redhat.com> Date: Mon Dec 16 10:06:50 2019 +0000 docs: add pages to support Go module package resolution it's possible to use import "libvirt.org/libvirt-go-xml" in Go programs, which will result in the Go bindings being fetched directly from libvirt.org thus removing our reliance on GitHub. Update the documentation accordingly. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- README.md | 4 ++-- doc.go | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 79f42f4..fcc1ffb 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,4 @@ -# libvirt-go-xml [![Build Status](https://travis-ci.org/libvirt/libvirt-go-xml.svg?branch=master)](ht… [![GoDoc](https://godoc.org/github.com/libvirt/libvirt-go-xml?status.svg)](https://godoc.org/github.com/libvirt/libvirt-go-xml) +# libvirt-go-xml [![Build Status](https://travis-ci.org/libvirt/libvirt-go-xml.svg?branch=master)](ht… [![GoDoc](https://godoc.org/libvirt.org/libvirt-go-xml?status.svg)](https://godoc.org/libvirt.org/libvirt-go-xml) Go API for manipulating libvirt XML documents @@ -9,7 +9,7 @@ the way in which the application talks to libvirt. ## Documentation -* [API documentation for the bindings](https://godoc.org/github.com/libvirt/libvirt-go-xml) +* [API documentation for the bindings](https://godoc.org/libvirt.org/libvirt-go-xml) * [Libvirt XML schema documentation](https://libvirt.org/format.html): * [capabilities](https://libvirt.org/formatcaps.html) * [domain](https://libvirt.org/formatdomain.html) diff --git a/doc.go b/doc.go index 25bc1d5..f93fac0 100644 --- a/doc.go +++ b/doc.go @@ -36,7 +36,7 @@ // package main // // import ( -// "github.com/libvirt/libvirt-go-xml" +// "libvirt.org/libvirt-go-xml" // ) // // func main() { @@ -51,8 +51,8 @@ // package main // // import ( -// "github.com/libvirt/libvirt-go" -// "github.com/libvirt/libvirt-go-xml" +// "libvirt.org/libvirt-go" +// "libvirt.org/libvirt-go-xml" // "fmt" // ) // -- 2.24.1

2 1

[PATCH v3 0/4] lxc: Add suport to network indexes for LXC 3.X
by Julio Faracco 30 Jan '20

30 Jan '20

This series implement support for network syntax settings for LXC 3.X. Now, indexes are part of the settings to define network interfaces. Each interface has its own index. The old style uses 'type' tag to differentiate each interface and with this, it could use one single structure. Now, network interfaces are a single array with interface pointers. Old: lxc.network.type = veth lxc.network.flags = up lxc.network.link = virbr0 New: lxc.net.0.type = veth lxc.net.0.flags = up lxc.net.0.link = virbr0 v1-v2: Moving sscanf to virStrToLong_ull according Daniel's suggestion. v2-v3: Adding missing g_autofree from `suffix` variable. Julio Faracco (4): lxc: refactor lxcNetworkParseData pointers to use new structures lxc: add LXC version 3 network parser lxc: remove domain definition from lxc network struct tests: update LXC config dataset to support V3 indexes src/lxc/lxc_native.c | 189 ++++++++++++------ .../lxcconf2xml-ethernet-v3.config | 16 +- .../lxcconf2xml-fstab-v3.config | 10 +- .../lxcconf2xml-macvlannetwork-v3.config | 10 +- .../lxcconf2xml-simple-v3.config | 18 +- 5 files changed, 151 insertions(+), 92 deletions(-) -- 2.20.1

2 7

[PATCH] libxl: support getting and setting parameters for the Credit2
by Dario Faggioli 30 Jan '20

30 Jan '20

With Credit2 being Xen default scheduler, it's definitely the case to allow Credit2's scheduling parameters to be get and set via libvirt. This is easy, as Credit and Credit2 have (at least as of now) the very same parameters ('weight' and 'cap'). So we can just let credit2 pass the scheduler-type check and the same code will work for both. Signed-off-by: Dario Faggioli <dfaggioli(a)suse.com> --- Cc: Jim Fehlig <jfehlig(a)suse.com> --- src/libxl/libxl_driver.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index e0a8ec5c24..78ca77d0f6 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -75,6 +75,7 @@ VIR_LOG_INIT("libxl.libxl_driver"); /* Number of Xen scheduler parameters */ #define XEN_SCHED_CREDIT_NPARAM 2 +#define XEN_SCHED_CREDIT2_NPARAM 2 #define LIBXL_CHECK_DOM0_GOTO(name, label) \ do { \ @@ -4586,6 +4587,8 @@ libxlDomainGetSchedulerType(virDomainPtr dom, int *nparams) break; case LIBXL_SCHEDULER_CREDIT2: name = "credit2"; + if (nparams) + *nparams = XEN_SCHED_CREDIT2_NPARAM; break; case LIBXL_SCHEDULER_ARINC653: name = "arinc653"; @@ -4632,11 +4635,11 @@ libxlDomainGetSchedulerParametersFlags(virDomainPtr dom, if (virDomainObjCheckActive(vm) < 0) goto cleanup; + /* Only credit and credit2 are supported for now. */ sched_id = libxl_get_scheduler(cfg->ctx); - - if (sched_id != LIBXL_SCHEDULER_CREDIT) { + if (sched_id != LIBXL_SCHEDULER_CREDIT && sched_id != LIBXL_SCHEDULER_CREDIT2) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Only 'credit' scheduler is supported")); + _("Only 'credit' and 'credit2' schedulers are supported")); goto cleanup; } @@ -4657,6 +4660,9 @@ libxlDomainGetSchedulerParametersFlags(virDomainPtr dom, goto cleanup; } + /* Credit and Credit2 have the same number (two) of parameters, + * so this is ok for both, at least as long as that stays true. */ + G_STATIC_ASSERT(XEN_SCHED_CREDIT_NPARAM == XEN_SCHED2_CREDIT_NPARAM); if (*nparams > XEN_SCHED_CREDIT_NPARAM) *nparams = XEN_SCHED_CREDIT_NPARAM; ret = 0; @@ -4711,9 +4717,11 @@ libxlDomainSetSchedulerParametersFlags(virDomainPtr dom, sched_id = libxl_get_scheduler(cfg->ctx); - if (sched_id != LIBXL_SCHEDULER_CREDIT) { + /* Only credit and credit2 are supported for now. */ + sched_id = libxl_get_scheduler(cfg->ctx); + if (sched_id != LIBXL_SCHEDULER_CREDIT && sched_id != LIBXL_SCHEDULER_CREDIT2) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Only 'credit' scheduler is supported")); + _("Only 'credit' and 'credit2' schedulers are supported")); goto endjob; } -- 2.24.1 -- Dario Faggioli, Ph.D http://about.me/dario.faggioli Virtualization Software Engineer SUSE Labs, SUSE https://www.suse.com/ ------------------------------------------------------------------- <<This happens because _I_ choose it to happen!>> (Raistlin Majere)

2 1

RHEL 7.7/libvirt 5.10 Question
by bart.m.bailey＠verizon.com 29 Jan '20

29 Jan '20

Hello, RHEL 7.7 installation attempts of libvirt-5.10.0-1.fc30.src.rpm are encountering the following - make[4]: Entering directory `/root/rpm/BUILD/libvirt-5.10.0/x86_64-redhat-linux-gnu/gnulib/tests' CC test-accept.o CC test-alloca-opt.o CC test-arpa_inet.o CC test-binary-io.o ============================================================================ Testsuite summary for libvirt 5.10.0 ============================================================================ # TOTAL: 197 # PASS: 187 # SKIP: 10 # XFAIL: 0 # FAIL: 0 # XPASS: 0 # ERROR: 0 ============================================================================ With subsequent testsuite execcuiton registering the following failure - ============================================================================ Testsuite summary for libvirt 5.10.0 ============================================================================ # TOTAL: 131 # PASS: 130 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 ============================================================================ See tests/test-suite.log Please report to libvir-list(a)redhat.com<mailto:libvir-list@redhat.com> ============================================================================ make[3]: *** [test-suite.log] Error 1 make[3]: Leaving directory `/root/rpm/BUILD/libvirt-5.10.0/x86_64-redhat-linux-gnu/tests' make[2]: *** [check-TESTS] Error 2 make[2]: Leaving directory `/root/rpm/BUILD/libvirt-5.10.0/x86_64-redhat-linux-gnu/tests' make[1]: *** [check-am] Error 2 make[1]: Leaving directory `/root/rpm/BUILD/libvirt-5.10.0/x86_64-redhat-linux-gnu/tests' make: *** [check-recursive] Error 1 + cat test-suite.log cat: test-suite.log: No such file or directory + true + exit 1 error: Bad exit status from /var/tmp/rpm-tmp.eMOkrN (%check) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.eMOkrN (%check) The gnulib-test-suite.log file attachment registers the following event ... 35) Checking luks-disk-invalid.xml against domain.rng ... libvirt: XML Util error : XML document failed to validate against schema: Unable to validate doc against /root/rpm/BUILD/libvirt-5.10.0/x86_64-redhat-linux-gnu/../docs/schemas/domain.rng Extra element devices in interleave Element domain failed to validate content OK 36) Checking disk-serial.xml against domain.rng ... OK 37) Checking pseries-no-parallel.xml against domain.rng ... OK ...with subsequent xml errors following similar to below. 2115) Checking dir-missing-target-path-invalid.xml against storagepool.rng ... libvirt: XML Util error : XML document failed to validate against schema: Unable to validate doc against /root/rpm/BUILD/libvirt-5.10.0/x86_64-redhat-linux-gnu/../docs/schemas/storagepool.rng Expecting an element path, got nothing Invalid sequence in interleave Element target failed to validate content Invalid sequence in interleave Element pool failed to validate content OK File attachments x86_64-redhat-linux-gnu/gnulib/tests/test-suite.log, x86_64-redhat-linux-gnu/tests/test-suite.log are provided and not sure if this helps but libvirt 5.10 candidate release libvirt-5.10.0-0rc2.fc30.src.rpm<https://libvirt.org/sources/libvirt-5.10.0-0rc2.fc30.src.rpm> completed RPM builds successfully. Libvirt 5.10 release libvirt-5.10.0-1.fc30.src.rpm is required for this application. Thanks and let us know if anything else is needed from this end. [cid:image002.png@01D5D5B6.9ADA0040] Bart Bailey (216) 462-2173 Verizon ME Lab Richardson 400 International Parkway Richardson, TX 75081

2 2

[PATCH v1 0/2] DAC,SELinux: do not remember/recall labels for
by Daniel Henrique Barboza 29 Jan '20

29 Jan '20

Libvirt is trying to do multiple open() calls in /dev/vfio files, which results in errors inside the security drivers and QEMU returning error 125 when attempting to hotplug a hostdev which belongs to the same IOMMU group as an existing domain hostdev. See patch 2 commit msg for more details. I found this problem when testing a PCI multifunction hotplug implementation. Since this is a problem that can happen in other currently supported scenarios, I decided it was worth sending the fix right away. Michal, I'm CCing you because I mentioned commit 4e95cdcbb3 ("security: Don't remember labels for TPM") in patch 2, which seems to fix a very similar problem. Figured you might want to take a look. Daniel Henrique Barboza (2): security: Allow 'remember' to be set for HostdevLabelHelper security: do not remember/recall labels for VFIO src/security/security_dac.c | 20 ++++++++++++-------- src/security/security_selinux.c | 20 ++++++++++++-------- 2 files changed, 24 insertions(+), 16 deletions(-) -- 2.24.1

2 3

[libvirt PATCH] docs: add warning about virt-qemu-run being experimental
by Daniel P. Berrangé 29 Jan '20

29 Jan '20

We currently note that the QEMU embedded driver in experimental in the drvqemu.html file, but we should do the same in the virt-qemu-run man page. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/manpages/virt-qemu-run.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/docs/manpages/virt-qemu-run.rst b/docs/manpages/virt-qemu-run.rst index 5074a928b7..b06c311b1d 100644 --- a/docs/manpages/virt-qemu-run.rst +++ b/docs/manpages/virt-qemu-run.rst @@ -33,6 +33,11 @@ If the virt-qemu-run program is interrupted (eg Ctrl-C) it will immediately terminate the virtual machine without giving the guest OS any opportunity to gracefully shutdown. +**NOTE: this tool is currently considered experimental.** Its +usage and behaviour is still subject to change in future libvirt +releases. For further information on its usage consult the +`QEMU driver documentation <https://libvirt.org/drvqemu.html#uriembedded>`_. + OPTIONS ======= -- 2.24.1

2 1

[libvirt PATCH 0/2] docs: make rst docs generation more robust
by Daniel P. Berrangé 29 Jan '20

29 Jan '20

This will avoid the various issues with generated docs containing build warnings. Daniel P. Berrangé (2): docs: fix various duplicate link targets in virsh.rst docs: use --strict arg when processing rst docs docs/Makefile.am | 10 +++++----- docs/manpages/virsh.rst | 36 ++++++++++++++++++------------------ 2 files changed, 23 insertions(+), 23 deletions(-) -- 2.24.1

2 3

[libvirt-rust] change in coding style to follow rustfmt
by Sahid Orentino Ferdjaoui 29 Jan '20

29 Jan '20

I'm proposing to merge a change [0] so the CI would check whether the source code is well-formatted using rustfmt [1]. The aim is to add an easy convention to follow regarding the coding style. For contributors the natural thing to do before to submit any patches is to verify the format using: `cargo fmt -v -- --check` The support of rustfmt via cargo can be added using: `rustup component add rustfmt` I did not want to pollute the mailing list with such big change which doesn't bring anything. Please let me know if you have any objections. commit 851296786626d61ebec985a9caeb515514955dd8 Author: Sahid Orentino Ferdjaoui <sahid.ferdjaoui(a)canonical.com> Date: Tue Jan 28 15:05:44 2020 +0100 ensure that the code is well formatted using rustfmt. In this commit we add CI rule so travis would check whether the code is well formatted using rustfmt. Signed-off-by: Sahid Orentino Ferdjaoui <sahid.ferdjaoui(a)canonical.com> .travis.yml | 4 + README.md | 6 + examples/auth.rs | 19 +- examples/hello.rs | 76 +-- examples/migrate.rs | 35 +- examples/suspend.rs | 31 +- src/connect.rs | 534 ++++++++++-------- src/domain.rs | 1323 +++++++++++++++++++++++++-------------------- src/domain_snapshot.rs | 88 +-- src/error.rs | 13 +- src/interface.rs | 38 +- src/lib.rs | 30 +- src/network.rs | 75 +-- src/nodedev.rs | 122 +++-- src/nwfilter.rs | 14 +- src/secret.rs | 79 +-- src/storage_pool.rs | 99 ++-- src/storage_vol.rs | 218 ++++---- src/stream.rs | 27 +- tests/common/mod.rs | 115 ++-- tests/connect.rs | 74 +-- tests/domain.rs | 14 +- tests/integration_qemu.rs | 39 +- tests/interface.rs | 2 - tests/network.rs | 1 - tests/storage_pool.rs | 18 +- 26 files changed, 1717 insertions(+), 1377 deletions(-) Thanks. s. [0] https://github.com/sahid/libvirt-rust/commit/851296786626d61ebec985a9caeb51… [1] https://travis-ci.org/sahid/libvirt-rust/builds/642931039

3 2

[PATCH v2 0/7] qemu: block iotune group fixes/improvements
by Michal Privoznik 29 Jan '20

29 Jan '20

This series was originally posted by Nikolay here: https://www.redhat.com/archives/libvir-list/2020-January/msg00283.html I've delayed review too much. Sorry for that. To make it up to you, I've fixed some patches and resending the series. Basically, I want to know whether you agree with my adjustments. I will add Dan's Reviewed-by when merging. Nikolay Shirokovskiy (7): qemu: Move qemuDiskConfigBlkdeviotuneHas* to conf conf: expand iotune params if only group name is given qemu: propagate iotune settings to all disks in the group qemu: check iotune params same for all disk in group qemu: fix using defaults when setting persistent iotune params qemu: get defaults from iotune group we move disk into qemu: when leaving iotune group update xml properly src/conf/domain_conf.c | 108 +++++++++++++++++++++++++++++++++++++++ src/conf/domain_conf.h | 22 ++++++++ src/libvirt_private.syms | 6 +++ src/qemu/qemu_command.c | 91 ++++++++++++++------------------- src/qemu/qemu_command.h | 3 ++ src/qemu/qemu_driver.c | 94 ++++++++++++++++++++++++++++++++-- src/qemu/qemu_hotplug.c | 2 +- tests/qemublocktest.c | 8 ++- 8 files changed, 275 insertions(+), 59 deletions(-) -- 2.24.1

2 9

[libvirt] [PATCH 0/7] qemu: block iotune group fixes/improvements
by Nikolay Shirokovskiy 29 Jan '20

29 Jan '20

Currently iotune group impl has several bugs/oddities this patchset aims to fix. Also patches (2) and (3) add/change functionality so that group iotune became easier/saner to use. TODO: add docs to API/virsh in respect to using iotune group Nikolay Shirokovskiy (7): conf: refactor virDomainBlockIoTuneInfoHas* conf: expand iotune params if only group name is given (2) qemu: check iotune params same for all disk in group qemu: fix using defaults when setting persistent iotune params qemu: propagate iotune settings to all disks in the group qemu: get defaults from iotune group we move disk into (3) qemu: when leaving iotune group update xml properly src/conf/domain_conf.c | 104 +++++++++++++++++++++++++++++++++++++++ src/conf/domain_conf.h | 16 ++++++ src/libvirt_private.syms | 5 ++ src/qemu/qemu_command.c | 90 ++++++++++++++------------------- src/qemu/qemu_command.h | 3 ++ src/qemu/qemu_driver.c | 98 ++++++++++++++++++++++++++++++++++-- src/qemu/qemu_hotplug.c | 2 +- tests/qemublocktest.c | 2 +- 8 files changed, 262 insertions(+), 58 deletions(-) -- 2.23.0

3 17

[libvirt PATCH 00/10] Various cleanups (virtio-fs epopee)
by Ján Tomko 29 Jan '20

29 Jan '20

2 22

[PATCH v2 0/4] lxc: Add suport to network indexes for LXC 3.X
by Julio Faracco 28 Jan '20

28 Jan '20

This series implement support for network syntax settings for LXC 3.X. Now, indexes are part of the settings to define network interfaces. Each interface has its own index. The old style uses 'type' tag to differentiate each interface and with this, it could use one single structure. Now, network interfaces are a single array with interface pointers. Old: lxc.network.type = veth lxc.network.flags = up lxc.network.link = virbr0 New: lxc.net.0.type = veth lxc.net.0.flags = up lxc.net.0.link = virbr0 v1-v2: Moving sscanf to virStrToLong_ull according Daniel's suggestion. Julio Faracco (4): lxc: refactor lxcNetworkParseData pointers to use new structures lxc: add LXC version 3 network parser lxc: remove domain definition from lxc network struct tests: update LXC config dataset to support V3 indexes src/lxc/lxc_native.c | 189 ++++++++++++------ .../lxcconf2xml-ethernet-v3.config | 16 +- .../lxcconf2xml-fstab-v3.config | 10 +- .../lxcconf2xml-macvlannetwork-v3.config | 10 +- .../lxcconf2xml-simple-v3.config | 18 +- 5 files changed, 151 insertions(+), 92 deletions(-) -- 2.20.1

1 4