- Devel - libvirt List Archives

[PATCH] util: virhostcpu: Fail when fetching CPU Stats for invalid cpu
by Mauro S. M. Rodrigues 24 Mar '20

24 Mar '20

virHostCPUGetStatsLinux walks through every cpu in /proc/stat until it finds cpu%cpuNum that matches with the requested cpu. If none is found it logs the error but it should return -1, instead of 0. Otherwise virsh nodecpustats --cpu <invalid cpu number> and API bindings don't fail properly, printing a blank line instead of an error message. This patch also includes an additional test for virhostcputest to avoid this regression to happen again in the future. Reported-by: Satheesh Rajendran <satheera(a)in.ibm.com> Signed-off-by: Mauro S. M. Rodrigues <maurosr(a)linux.vnet.ibm.com> --- src/util/virhostcpu.c | 2 +- tests/virhostcputest.c | 9 ++++++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/util/virhostcpu.c b/src/util/virhostcpu.c index 81293eea8c..20c8d0ce6c 100644 --- a/src/util/virhostcpu.c +++ b/src/util/virhostcpu.c @@ -847,7 +847,7 @@ virHostCPUGetStatsLinux(FILE *procstat, _("Invalid cpuNum in %s"), __FUNCTION__); - return 0; + return -1; } diff --git a/tests/virhostcputest.c b/tests/virhostcputest.c index 7865b61578..2f569d8bd4 100644 --- a/tests/virhostcputest.c +++ b/tests/virhostcputest.c @@ -258,14 +258,17 @@ mymain(void) if (virTestRun(nodeData[i].testName, linuxTestHostCPU, &nodeData[i]) != 0) ret = -1; -# define DO_TEST_CPU_STATS(name, ncpus) \ +# define DO_TEST_CPU_STATS(name, ncpus, shouldFail) \ do { \ static struct nodeCPUStatsData data = { name, ncpus }; \ - if (virTestRun("CPU stats " name, linuxTestNodeCPUStats, &data) < 0) \ + if ((virTestRun("CPU stats " name, \ + linuxTestNodeCPUStats, \ + &data) < 0) != shouldFail) \ ret = -1; \ } while (0) - DO_TEST_CPU_STATS("24cpu", 24); + DO_TEST_CPU_STATS("24cpu", 24, false); + DO_TEST_CPU_STATS("24cpu", 25, true); return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -- 2.24.1

3 2

Hot unplug disabling on pci-pci bridge
by Ani Sinha 24 Mar '20

24 Mar '20

Hi All : I have been playing with Qemu trying to disable hot-unplug capability for conventional PCI. I have discussed this briefly on IRC and the plan is to have an option on the pci-pci bridge that would disable SHPC and ACPI hotplug capability for all the slots on that bus. I am _not_ trying to implement a per slot capability for conventional PCI as was previously posted for PCIE slots in this patch : https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg01833.html (we do not need this atm). I am following the conversations which happened few weeks back here: https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg00985.html To that end, I have been experimenting with Qemu using the patch I mention below. I have attached the virtio balloon driver with bus 1 which is attached to the pci bridge. <controller type='pci' index='0' model='pci-root'> <alias name='pci.0'/> </controller> <controller type='pci' index='1' model='pci-bridge'> <model name='pci-bridge'/> <target chassisNr='1'/> <alias name='pci.1'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/> </controller> <memballoon model='virtio'> <stats period='30'/> <alias name='balloon0'/> <address type='pci' domain='0x0000' bus='0x02' slot='0x01' function='0x0'/> </memballoon> I am using a windows guest and from the guest I can see that the balloon driver is indeed attached to the pci bridge (see attached screenshot). I still find Windows giving me an option to hot eject the pci balloon driver. So what am I doing wrong here? [cid:87E6C01C-8B8C-4E24-AC4B-C0D746C2F605] The patch I am experimenting with (which is currently a hack) is attached below. It is based off libvirt 4.5 and not the latest mainline. --- hw/pci-bridge/pci_bridge_dev.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/pci-bridge/pci_bridge_dev.c b/hw/pci-bridge/pci_bridge_dev.c index b2d861d..e706d49 100644 --- a/hw/pci-bridge/pci_bridge_dev.c +++ b/hw/pci-bridge/pci_bridge_dev.c @@ -58,7 +58,7 @@ static void pci_bridge_dev_realize(PCIDevice *dev, Error **errp) pci_bridge_initfn(dev, TYPE_PCI_BUS); - if (bridge_dev->flags & (1 << PCI_BRIDGE_DEV_F_SHPC_REQ)) { + if (0) {//bridge_dev->flags & (1 << PCI_BRIDGE_DEV_F_SHPC_REQ)) { dev->config[PCI_INTERRUPT_PIN] = 0x1; memory_region_init(&bridge_dev->bar, OBJECT(dev), "shpc-bar", shpc_bar_size(dev)); @@ -161,7 +161,7 @@ static Property pci_bridge_dev_properties[] = { DEFINE_PROP_ON_OFF_AUTO(PCI_BRIDGE_DEV_PROP_MSI, PCIBridgeDev, msi, ON_OFF_AUTO_AUTO), DEFINE_PROP_BIT(PCI_BRIDGE_DEV_PROP_SHPC, PCIBridgeDev, flags, - PCI_BRIDGE_DEV_F_SHPC_REQ, true), + PCI_BRIDGE_DEV_F_SHPC_REQ, false), DEFINE_PROP_END_OF_LIST(), }; @@ -181,7 +181,7 @@ static const VMStateDescription pci_bridge_dev_vmstate = { VMSTATE_END_OF_LIST() } }; - +#if 0 static void pci_bridge_dev_hotplug_cb(HotplugHandler *hotplug_dev, DeviceState *dev, Error **errp) { @@ -208,12 +208,12 @@ static void pci_bridge_dev_hot_unplug_request_cb(HotplugHandler *hotplug_dev, } shpc_device_hot_unplug_request_cb(hotplug_dev, dev, errp); } - +#endif static void pci_bridge_dev_class_init(ObjectClass *klass, void *data) { DeviceClass *dc = DEVICE_CLASS(klass); PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); - HotplugHandlerClass *hc = HOTPLUG_HANDLER_CLASS(klass); + //HotplugHandlerClass *hc = HOTPLUG_HANDLER_CLASS(klass); k->realize = pci_bridge_dev_realize; k->exit = pci_bridge_dev_exitfn; @@ -227,8 +227,8 @@ static void pci_bridge_dev_class_init(ObjectClass *klass, void *data) dc->props = pci_bridge_dev_properties; dc->vmsd = &pci_bridge_dev_vmstate; set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); - hc->plug = pci_bridge_dev_hotplug_cb; - hc->unplug_request = pci_bridge_dev_hot_unplug_request_cb; + //hc->plug = pci_bridge_dev_hotplug_cb; + //hc->unplug_request = pci_bridge_dev_hot_unplug_request_cb; } static const TypeInfo pci_bridge_dev_info = { @@ -238,7 +238,7 @@ static const TypeInfo pci_bridge_dev_info = { .class_init = pci_bridge_dev_class_init, .instance_finalize = pci_bridge_dev_instance_finalize, .interfaces = (InterfaceInfo[]) { - { TYPE_HOTPLUG_HANDLER }, + //{ TYPE_HOTPLUG_HANDLER }, { INTERFACE_CONVENTIONAL_PCI_DEVICE }, { } } -- 1.9.4

2 2

[libvirt-tck] scripts: fix disk media change test
by Jim Fehlig 24 Mar '20

24 Mar '20

Since the introduction of the 'index' attribute of a disk's <source> element, test 207-disk-media-change.t is failing. The test is a bit flawed in that it compares initial and final domXML after changing the media of a cdrom disk device. The test only needs to check the final domXML to ensure the correct <source> path exists at the end of the test. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- scripts/domain/207-disk-media-change.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/domain/207-disk-media-change.t b/scripts/domain/207-disk-media-change.t index dfef7c9..7a43afc 100644 --- a/scripts/domain/207-disk-media-change.t +++ b/scripts/domain/207-disk-media-change.t @@ -98,5 +98,5 @@ EOF my $finalxml = $dom->get_xml_description; - is($initialxml, $finalxml, "final XML matches initial XML"); + ok($finalxml =~ m|$path1|, "final XML has properly updated media"); } -- 2.25.0

3 2

[PATCH v4 0/6] NVDIMM suport for pSeries guests
by Daniel Henrique Barboza 24 Mar '20

24 Mar '20

changes in v4: - moved label size requirement from virDomainMemoryDefParseXML() to virDomainMemoryDefValidate() Previous version: https://www.redhat.com/archives/libvir-list/2020-March/msg00769.html Daniel Henrique Barboza (6): qemu: capabilities: update qemu-5.0.0 capabilities for ppc64 conf: Introduce optional 'uuid' element for NVDIMM memory formatdomain.html.in: document the new 'uuid' NVDIMM element conf, qemu: enable NVDIMM support for ppc64 formatdomain.html.in: document NVDIMM 'label' requirement for pSeries news.xml: document the new NVDIMM support for Pseries guests docs/formatdomain.html.in | 24 +- docs/news.xml | 11 + docs/schemas/domaincommon.rng | 5 + src/conf/domain_conf.c | 49 +- src/conf/domain_conf.h | 3 + src/qemu/qemu_command.c | 7 + src/qemu/qemu_domain.c | 63 +- src/qemu/qemu_domain.h | 4 +- src/qemu/qemu_hotplug.c | 6 +- tests/domaincapsdata/qemu_5.0.0.ppc64.xml | 2 +- .../caps_5.0.0.ppc64.replies | 10949 +++++++++------- .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1216 +- ...default-video-type-ppc64.ppc64-latest.args | 2 - .../memory-hotplug-nvdimm-ppc64.args | 32 + ...ory-hotplug-nvdimm-ppc64.ppc64-latest.args | 36 + .../memory-hotplug-nvdimm-ppc64.xml | 50 + ...ault-cpu-kvm-pseries-2.7.ppc64-latest.args | 10 +- ...ault-cpu-kvm-pseries-3.1.ppc64-latest.args | 10 +- ...ault-cpu-kvm-pseries-4.2.ppc64-latest.args | 10 +- ...ault-cpu-tcg-pseries-2.7.ppc64-latest.args | 10 +- ...ault-cpu-tcg-pseries-3.1.ppc64-latest.args | 10 +- ...ault-cpu-tcg-pseries-4.2.ppc64-latest.args | 10 +- .../ppc64-pseries-graphics.ppc64-latest.args | 10 +- .../ppc64-pseries-headless.ppc64-latest.args | 10 +- .../tpm-emulator-spapr.ppc64-latest.args | 9 +- tests/qemuxml2argvtest.c | 1 + .../memory-hotplug-nvdimm-ppc64.xml | 50 + tests/qemuxml2xmltest.c | 2 + 28 files changed, 7028 insertions(+), 5573 deletions(-) create mode 100644 tests/qemuxml2argvdata/memory-hotplug-nvdimm-ppc64.args create mode 100644 tests/qemuxml2argvdata/memory-hotplug-nvdimm-ppc64.ppc64-latest.args create mode 100644 tests/qemuxml2argvdata/memory-hotplug-nvdimm-ppc64.xml create mode 100644 tests/qemuxml2xmloutdata/memory-hotplug-nvdimm-ppc64.xml -- 2.25.1

2 7

Propose to extend the capability of arm cpu driver
by Zhenyu Zheng 24 Mar '20

24 Mar '20

Hello Libvirt, With more and more ARM servers on the market and increasing amount of users, we got reported alot that Libvirt cannot provide as much function on ARM platform as on other platforms(mainly x86), some basic founctions are missing, such as showing cpu model details and features using ``virsh capabilities``, comparing cpus etc. So I would like to propose to extend the capability of ARM cpu driver. Since I'm quite new here, I searched through the mailing list and did not find much information on this, so I would like to know that will this be something that I could work on? BR, Zhenyu Zheng

2 6

TCK regression from blockdev change
by Jim Fehlig 23 Mar '20

23 Mar '20

Hi all, I noticed libvirt-tck test 207-disk-media-change.t is failing with 6.1.0, although I _think_ the failure has actually been around since the change to using blockdev in the qemu driver. The test essentially creates a minimal domain with a cdrom disk device, then calls attach_device a few times, changing the <source> of the disk. The last attach_device uses the same <source> as when the domain was created and expects the initial and final XML to be the same. For reference, here's a link to the test https://libvirt.org/git/?p=libvirt-tck.git;a=blob;f=scripts/domain/207-disk… However the test fails since the 'index' attribute of the <source> element is not the same between initial XML (index='1') and final XML (index='5'). Indeed with each attach operation the index is incremented. Should libvirt be fixed to always provide an index of 1 for this disk config? Or should we adjust the test case? I'm not so familiar with this functionality but I lean towards the former since attaching a disk with a missing source (no media) results in odd looking disk config <disk type='file' device='cdrom'> <driver name='qemu' type='raw' cache='none'/> <source index='4'/> <target dev='hdc' bus='ide'/> <readonly/> <alias name='ide0-1-0'/> <address type='drive' controller='0' bus='1' target='0' unit='0'/> </disk> Regards, Jim

2 2

[PATCH v2 0/5] NVDIMM suport for pSeries guests
by Daniel Henrique Barboza 23 Mar '20

23 Mar '20

changes in v2, all of them affecting just pSeries guests: - added 'label' requirement - added code to align down the NVDIMM device previous version: https://www.redhat.com/archives/libvir-list/2020-March/msg00165.html This patch series adds NVDIMM suport for ppc64 guests, which consists on adding an extra 'uuid' element in the nvdimm command line and the target label size must always be provided in the memory definition. No changes were made in the existing NVDIMM support for x86 and other archs. Daniel Henrique Barboza (5): conf: Introduce optional 'uuid' element for NVDIMM memory formatdomain.html.in: document the new 'uuid' NVDIMM element conf, qemu: enable NVDIMM support for ppc64 formatdomain.html.in: document NVDIMM 'label' requirement for pSeries news.xml: document the new NVDIMM support for Pseries guests docs/formatdomain.html.in | 24 +++++++-- docs/news.xml | 11 ++++ docs/schemas/domaincommon.rng | 5 ++ src/conf/domain_conf.c | 44 ++++++++++++++-- src/conf/domain_conf.h | 3 ++ src/qemu/qemu_command.c | 7 +++ src/qemu/qemu_domain.c | 47 +++++++++++++++-- .../memory-hotplug-nvdimm-ppc64.args | 32 ++++++++++++ .../memory-hotplug-nvdimm-ppc64.xml | 50 +++++++++++++++++++ tests/qemuxml2argvtest.c | 4 ++ .../memory-hotplug-nvdimm-ppc64.xml | 50 +++++++++++++++++++ tests/qemuxml2xmltest.c | 2 + 12 files changed, 268 insertions(+), 11 deletions(-) create mode 100644 tests/qemuxml2argvdata/memory-hotplug-nvdimm-ppc64.args create mode 100644 tests/qemuxml2argvdata/memory-hotplug-nvdimm-ppc64.xml create mode 100644 tests/qemuxml2xmloutdata/memory-hotplug-nvdimm-ppc64.xml -- 2.24.1

3 10

[libvirt PATCH 0/4] qemu: virtiofs fixes
by Ján Tomko 23 Mar '20

23 Mar '20

Shorten some paths and kill the whole process group instead of just the parent. Ján Tomko (4): qemu: virtiofs: kill the whole process group when stopping qemu: virtiofs: shorten pid filename qemu: virtiofs: shorten socket filename qemu: virtiofs: use a .log.fs suffix for logs src/qemu/qemu_virtiofs.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) -- 2.25.1

3 12

[PATCH] news: Document removal of support for .ini style of comments
by Michal Privoznik 23 Mar '20

23 Mar '20

In previous patches virKeyFile was replaced with its GLib counterpart which created an incompatible change: comments can now begin only with a number sign (#). While this won't probably affect anyone, mention it in the release notes. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- docs/news.xml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index ae4ee444d0..3de0a4945f 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -45,6 +45,19 @@ <release version="v6.2.0" date="unreleased"> <section title="New features"> </section> + <section title="Removed features"> + <change> + <summary> + Removed support for INI style of comments + </summary> + <description> + With switching of our internal code to GLib, parsing of config files + is handed over to GLib which does not support <code>INI</code> style + of comments starting with a semicolon (<code>;</code>). Use number + sign (<code>#</code>) instead. + </description> + </change> + </section> <section title="Improvements"> </section> <section title="Bug fixes"> -- 2.24.1

2 1

Virtualbox Support for 6.x ?
by CDT CDT 23 Mar '20

23 Mar '20

Hello all, TL;DR: Is there any libvirt update regarding VBox 6.x planned until July 2020? I tried using libvirt 4.x / virsh with Virtualbox 6.1.4, which seem to not work. The output of virsh -V tells me that hypervisor should be able for that: Compiled with support for: Hypervisors: … VirtualBox … If I try to connect to a vbox session I get following error: error: failed to connect to the hypervisor error: internal error: unable to initialize VirtualBox driver API I already saw from different threads messages like this: libvirt version: 5.10.0 Libvirt doesn't support VirtualBox API version 6001000 regarding the libvirt changelog, only Virtualbox 5.2 is officially supported. Unfortunately, the support/maintenance for Virtualbox 5.2. ends in July 2020. Is there any libvirt update regarding VBox 6.x planned until July 2020? And is following combination in general possible: Libvirt + VBox + Windows Guest/VM ? Best regards Emanuel

3 2

[libvirt PATCH 0/4] cpu_map: Add more -noTSX x86 CPU models
by Jiri Denemark 23 Mar '20

23 Mar '20

Christian Ehrhardt (1): cpu_map: Add more -noTSX x86 CPU models Jiri Denemark (3): cpu_map: Add <decode> element to x86 CPU model definitions cpu_x86: Honor CPU models' <decode> element cpu_map: Don't use new noTSX models for host-model CPUs src/cpu/cpu_x86.c | 65 ++++++++++++- src/cpu_map/Makefile.inc.am | 5 + src/cpu_map/index.xml | 5 + src/cpu_map/x86_486.xml | 1 + src/cpu_map/x86_Broadwell-IBRS.xml | 1 + src/cpu_map/x86_Broadwell-noTSX-IBRS.xml | 1 + src/cpu_map/x86_Broadwell-noTSX.xml | 1 + src/cpu_map/x86_Broadwell.xml | 1 + src/cpu_map/x86_Cascadelake-Server-noTSX.xml | 79 ++++++++++++++++ src/cpu_map/x86_Cascadelake-Server.xml | 1 + src/cpu_map/x86_Conroe.xml | 1 + src/cpu_map/x86_Dhyana.xml | 1 + src/cpu_map/x86_EPYC-IBPB.xml | 1 + src/cpu_map/x86_EPYC.xml | 1 + src/cpu_map/x86_Haswell-IBRS.xml | 1 + src/cpu_map/x86_Haswell-noTSX-IBRS.xml | 1 + src/cpu_map/x86_Haswell-noTSX.xml | 1 + src/cpu_map/x86_Haswell.xml | 1 + src/cpu_map/x86_Icelake-Client-noTSX.xml | 82 +++++++++++++++++ src/cpu_map/x86_Icelake-Client.xml | 1 + src/cpu_map/x86_Icelake-Server-noTSX.xml | 91 +++++++++++++++++++ src/cpu_map/x86_Icelake-Server.xml | 1 + src/cpu_map/x86_IvyBridge-IBRS.xml | 1 + src/cpu_map/x86_IvyBridge.xml | 1 + src/cpu_map/x86_Nehalem-IBRS.xml | 1 + src/cpu_map/x86_Nehalem.xml | 1 + src/cpu_map/x86_Opteron_G1.xml | 1 + src/cpu_map/x86_Opteron_G2.xml | 1 + src/cpu_map/x86_Opteron_G3.xml | 1 + src/cpu_map/x86_Opteron_G4.xml | 1 + src/cpu_map/x86_Opteron_G5.xml | 1 + src/cpu_map/x86_Penryn.xml | 1 + src/cpu_map/x86_SandyBridge-IBRS.xml | 1 + src/cpu_map/x86_SandyBridge.xml | 1 + src/cpu_map/x86_Skylake-Client-IBRS.xml | 1 + src/cpu_map/x86_Skylake-Client-noTSX-IBRS.xml | 74 +++++++++++++++ src/cpu_map/x86_Skylake-Client.xml | 1 + src/cpu_map/x86_Skylake-Server-IBRS.xml | 1 + src/cpu_map/x86_Skylake-Server-noTSX-IBRS.xml | 76 ++++++++++++++++ src/cpu_map/x86_Skylake-Server.xml | 1 + src/cpu_map/x86_Westmere-IBRS.xml | 1 + src/cpu_map/x86_Westmere.xml | 1 + src/cpu_map/x86_athlon.xml | 1 + src/cpu_map/x86_core2duo.xml | 1 + src/cpu_map/x86_coreduo.xml | 1 + src/cpu_map/x86_cpu64-rhel5.xml | 1 + src/cpu_map/x86_cpu64-rhel6.xml | 1 + src/cpu_map/x86_kvm32.xml | 1 + src/cpu_map/x86_kvm64.xml | 1 + src/cpu_map/x86_n270.xml | 1 + src/cpu_map/x86_pentium.xml | 1 + src/cpu_map/x86_pentium2.xml | 1 + src/cpu_map/x86_pentium3.xml | 1 + src/cpu_map/x86_pentiumpro.xml | 1 + src/cpu_map/x86_phenom.xml | 1 + src/cpu_map/x86_qemu32.xml | 1 + src/cpu_map/x86_qemu64.xml | 1 + .../x86_64-cpuid-Core-i7-8550U-host.xml | 11 +-- .../domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 5 + .../domaincapsdata/qemu_4.2.0-tcg.x86_64.xml | 5 + tests/domaincapsdata/qemu_4.2.0.x86_64.xml | 5 + .../domaincapsdata/qemu_5.0.0-q35.x86_64.xml | 5 + .../domaincapsdata/qemu_5.0.0-tcg.x86_64.xml | 5 + tests/domaincapsdata/qemu_5.0.0.x86_64.xml | 5 + 64 files changed, 552 insertions(+), 15 deletions(-) create mode 100644 src/cpu_map/x86_Cascadelake-Server-noTSX.xml create mode 100644 src/cpu_map/x86_Icelake-Client-noTSX.xml create mode 100644 src/cpu_map/x86_Icelake-Server-noTSX.xml create mode 100644 src/cpu_map/x86_Skylake-Client-noTSX-IBRS.xml create mode 100644 src/cpu_map/x86_Skylake-Server-noTSX-IBRS.xml -- 2.25.1

2 5

[PATCH v2 1/2] util: authconfig: use g_key_file_*
by Rafael Fonseca 23 Mar '20

23 Mar '20

Replace libvirt's virKeyFile by glib's GKeyFile. Signed-off-by: Rafael Fonseca <r4f4rfs(a)gmail.com> --- src/util/virauthconfig.c | 25 +++++++++++-------------- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/src/util/virauthconfig.c b/src/util/virauthconfig.c index fd846ddd4b..473b4c76d6 100644 --- a/src/util/virauthconfig.c +++ b/src/util/virauthconfig.c @@ -29,7 +29,7 @@ #include "viralloc.h" struct _virAuthConfig { - virKeyFilePtr keyfile; + GKeyFile *keyfile; char *path; }; @@ -46,10 +46,10 @@ virAuthConfigPtr virAuthConfigNew(const char *path) auth->path = g_strdup(path); - if (!(auth->keyfile = virKeyFileNew())) + if (!(auth->keyfile = g_key_file_new())) goto error; - if (virKeyFileLoadFile(auth->keyfile, path) < 0) + if (!g_key_file_load_from_file(auth->keyfile, path, 0, NULL)) goto error; return auth; @@ -71,10 +71,10 @@ virAuthConfigPtr virAuthConfigNewData(const char *path, auth->path = g_strdup(path); - if (!(auth->keyfile = virKeyFileNew())) + if (!(auth->keyfile = g_key_file_new())) goto error; - if (virKeyFileLoadData(auth->keyfile, path, data, len) < 0) + if (!g_key_file_load_from_data(auth->keyfile, data, len, 0, NULL)) goto error; return auth; @@ -90,7 +90,7 @@ void virAuthConfigFree(virAuthConfigPtr auth) if (!auth) return; - virKeyFileFree(auth->keyfile); + g_key_file_free(auth->keyfile); VIR_FREE(auth->path); VIR_FREE(auth); } @@ -115,15 +115,15 @@ int virAuthConfigLookup(virAuthConfigPtr auth, authgroup = g_strdup_printf("auth-%s-%s", service, hostname); - if (!virKeyFileHasGroup(auth->keyfile, authgroup)) { + if (!g_key_file_has_group(auth->keyfile, authgroup)) { VIR_FREE(authgroup); authgroup = g_strdup_printf("auth-%s-%s", service, "default"); } - if (!virKeyFileHasGroup(auth->keyfile, authgroup)) + if (!g_key_file_has_group(auth->keyfile, authgroup)) return 0; - if (!(authcred = virKeyFileGetValueString(auth->keyfile, authgroup, "credentials"))) { + if (!(authcred = g_key_file_get_string(auth->keyfile, authgroup, "credentials", NULL))) { virReportError(VIR_ERR_CONF_SYNTAX, _("Missing item 'credentials' in group '%s' in '%s'"), authgroup, auth->path); @@ -132,17 +132,14 @@ int virAuthConfigLookup(virAuthConfigPtr auth, credgroup = g_strdup_printf("credentials-%s", authcred); - if (!virKeyFileHasGroup(auth->keyfile, credgroup)) { + if (!g_key_file_has_group(auth->keyfile, credgroup)) { virReportError(VIR_ERR_CONF_SYNTAX, _("Missing group 'credentials-%s' referenced from group '%s' in '%s'"), authcred, authgroup, auth->path); return -1; } - if (!virKeyFileHasValue(auth->keyfile, credgroup, credname)) - return 0; - - *value = virKeyFileGetValueString(auth->keyfile, credgroup, credname); + *value = g_key_file_get_string(auth->keyfile, credgroup, credname, NULL); return 0; } -- 2.25.1

2 2

[libvirt PATCH] api: disallow virDomainAgentSetResponseTimeout() on read-only connections
by Jonathon Jongsma 23 Mar '20

23 Mar '20

This function changes the amount of time that libvirt waits for a response from the guest agent for all guest agent commands. Since this is a configuration change, it should not be allowed on read-only connections. Signed-off-by: Jonathon Jongsma <jjongsma(a)redhat.com> --- src/libvirt-domain.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 65813b68cc..a12809c2d5 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -12576,6 +12576,8 @@ virDomainAgentSetResponseTimeout(virDomainPtr domain, virCheckDomainReturn(domain, -1); conn = domain->conn; + virCheckReadOnlyGoto(conn->flags, error); + if (conn->driver->domainAgentSetResponseTimeout) { if (conn->driver->domainAgentSetResponseTimeout(domain, timeout, flags) < 0) goto error; -- 2.21.1

3 2

[libvirt PATCH] qemu: fix response timeout for agent guest-sync
by Jonathon Jongsma 23 Mar '20

23 Mar '20

The agent 'guest-sync' command historically had a 5s response timeout which was different from other agent commands, which waited forever. When we added the ability to customize the response timeout for guest agent commands, we intended to continue to use 5s for 'guest-sync' when the user specified a response timeout greater than 5s, and use the user-specified timeout if it was below 5s. Unfortunately, when attempting to determine whether the user-specified timeout was less than 5s, we were comparing against an enum value of VIR_DOMAIN_QEMU_AGENT_COMMAND_DEFAULT (which is -1) rather than against the actual time value that it represented (5). This change makes it so that 'guest-sync' now uses the user-specified tiemout if it is less than 5s. Signed-off-by: Jonathon Jongsma <jjongsma(a)redhat.com> --- src/qemu/qemu_agent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index 6ff5b11374..a10ef0728a 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -904,7 +904,7 @@ qemuAgentGuestSync(qemuAgentPtr agent) /* if user specified a custom agent timeout that is lower than the * default timeout, use the shorter timeout instead */ - if ((agent->timeout >= 0) && (agent->timeout < timeout)) + if ((agent->timeout >= 0) && (agent->timeout < QEMU_AGENT_WAIT_TIME)) timeout = agent->timeout; memset(&sync_msg, 0, sizeof(sync_msg)); -- 2.21.1

3 2

[PATCH v1] qemu: Use g_autofree and g_autoptr in qemuAgentSetUserPassword
by Seeteena Thoufeek 23 Mar '20

23 Mar '20

Signed-off-by: Seeteena Thoufeek <s1seetee(a)linux.vnet.ibm.com> --- src/qemu/qemu_agent.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index 9ea2c59563..1583a4eee2 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -2274,10 +2274,9 @@ qemuAgentSetUserPassword(qemuAgentPtr agent, const char *password, bool crypted) { - int ret = -1; - virJSONValuePtr cmd = NULL; - virJSONValuePtr reply = NULL; - char *password64 = NULL; + g_autoptr(virJSONValue) cmd = NULL; + g_autoptr(virJSONValue) reply = NULL; + g_autofree char *password64 = NULL; password64 = g_base64_encode((unsigned char *)password, strlen(password)); @@ -2287,18 +2286,12 @@ qemuAgentSetUserPassword(qemuAgentPtr agent, "s:username", user, "s:password", password64, NULL))) - goto cleanup; + return -1; if (qemuAgentCommand(agent, cmd, &reply, agent->timeout) < 0) - goto cleanup; - - ret = 0; + return -1; - cleanup: - virJSONValueFree(cmd); - virJSONValueFree(reply); - VIR_FREE(password64); - return ret; + return 0; } /* Returns: 0 on success -- 2.18.2

3 2

[PATCH] conf: use virStringParseYesNo
by Rafael Fonseca 23 Mar '20

23 Mar '20

Use existing function built for this exact purpose. Signed-off-by: Rafael Fonseca <r4f4rfs(a)gmail.com> --- src/conf/domain_conf.c | 25 ++++++++++--------------- src/conf/interface_conf.c | 13 ++++++------- 2 files changed, 16 insertions(+), 22 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index e0432fc47d..2fed8dff14 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -9203,7 +9203,7 @@ virSecurityDeviceLabelDefParseXML(virSecurityDeviceLabelDefPtr **seclabels_rtn, labelskip = virXMLPropString(list[i], "labelskip"); seclabels[i]->labelskip = false; if (labelskip && !(flags & VIR_DOMAIN_DEF_PARSE_INACTIVE)) - seclabels[i]->labelskip = STREQ(labelskip, "yes"); + ignore_value(virStringParseYesNo(labelskip, &seclabels[i]->labelskip)); VIR_FREE(labelskip); ctxt->node = list[i]; @@ -12354,16 +12354,14 @@ virDomainNetDefParseXML(virDomainXMLOptionPtr xmlopt, goto error; if (managed_tap) { - if (STREQ(managed_tap, "no")) { - def->managed_tap = VIR_TRISTATE_BOOL_NO; - } else if (STREQ(managed_tap, "yes")) { - def->managed_tap = VIR_TRISTATE_BOOL_YES; - } else { + bool state = false; + if (virStringParseYesNo(managed_tap, &state) < 0) { virReportError(VIR_ERR_XML_ERROR, _("invalid 'managed' value '%s'"), managed_tap); goto error; } + def->managed_tap = virTristateBoolFromBool(state); } if (def->managed_tap != VIR_TRISTATE_BOOL_NO && ifname && @@ -13887,15 +13885,13 @@ virDomainTimerDefParseXML(xmlNodePtr node, def->present = -1; /* unspecified */ if ((present = virXMLPropString(node, "present")) != NULL) { - if (STREQ(present, "yes")) { - def->present = 1; - } else if (STREQ(present, "no")) { - def->present = 0; - } else { + bool state = false; + if (virStringParseYesNo(present, &state) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, _("unknown timer present value '%s'"), present); goto error; } + def->present = state ? 1 : 0; } def->tickpolicy = -1; @@ -18611,10 +18607,9 @@ virDomainDefParseBootXML(xmlXPathContextPtr ctxt, if ((node = virXPathNode("./os/bios[1]", ctxt))) { tmp = virXMLPropString(node, "useserial"); if (tmp) { - if (STREQ(tmp, "yes")) - def->os.bios.useserial = VIR_TRISTATE_BOOL_YES; - else - def->os.bios.useserial = VIR_TRISTATE_BOOL_NO; + bool state = false; + ignore_value(virStringParseYesNo(tmp, &state)); + def->os.bios.useserial = virTristateBoolFromBool(state); VIR_FREE(tmp); } diff --git a/src/conf/interface_conf.c b/src/conf/interface_conf.c index 7a41b19ed0..d1732621b5 100644 --- a/src/conf/interface_conf.c +++ b/src/conf/interface_conf.c @@ -28,6 +28,7 @@ #include "virxml.h" #include "viruuid.h" #include "virbuffer.h" +#include "virstring.h" #define VIR_FROM_THIS VIR_FROM_INTERFACE @@ -268,21 +269,19 @@ virInterfaceDefParseDhcp(virInterfaceProtocolDefPtr def, def->dhcp = 1; save = ctxt->node; ctxt->node = dhcp; + def->peerdns = -1; /* Not much to do in the current version */ tmp = virXPathString("string(./@peerdns)", ctxt); if (tmp) { - if (STREQ(tmp, "yes")) { - def->peerdns = 1; - } else if (STREQ(tmp, "no")) { - def->peerdns = 0; - } else { + bool state = false; + if (virStringParseYesNo(tmp, &state) < 0) { virReportError(VIR_ERR_XML_ERROR, _("unknown dhcp peerdns value %s"), tmp); ret = -1; + } else { + def->peerdns = state ? 1 : 0; } VIR_FREE(tmp); - } else { - def->peerdns = -1; } ctxt->node = save; -- 2.25.1

2 1

[PATCH] util: authconfig: use g_key_file_*
by Rafael Fonseca 23 Mar '20

23 Mar '20

Replace libvirt's virKeyFile by glib's GKeyFile. Signed-off-by: Rafael Fonseca <r4f4rfs(a)gmail.com> --- src/util/virauthconfig.c | 25 +++++++++++-------------- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/src/util/virauthconfig.c b/src/util/virauthconfig.c index fd846ddd4b..473b4c76d6 100644 --- a/src/util/virauthconfig.c +++ b/src/util/virauthconfig.c @@ -29,7 +29,7 @@ #include "viralloc.h" struct _virAuthConfig { - virKeyFilePtr keyfile; + GKeyFile *keyfile; char *path; }; @@ -46,10 +46,10 @@ virAuthConfigPtr virAuthConfigNew(const char *path) auth->path = g_strdup(path); - if (!(auth->keyfile = virKeyFileNew())) + if (!(auth->keyfile = g_key_file_new())) goto error; - if (virKeyFileLoadFile(auth->keyfile, path) < 0) + if (!g_key_file_load_from_file(auth->keyfile, path, 0, NULL)) goto error; return auth; @@ -71,10 +71,10 @@ virAuthConfigPtr virAuthConfigNewData(const char *path, auth->path = g_strdup(path); - if (!(auth->keyfile = virKeyFileNew())) + if (!(auth->keyfile = g_key_file_new())) goto error; - if (virKeyFileLoadData(auth->keyfile, path, data, len) < 0) + if (!g_key_file_load_from_data(auth->keyfile, data, len, 0, NULL)) goto error; return auth; @@ -90,7 +90,7 @@ void virAuthConfigFree(virAuthConfigPtr auth) if (!auth) return; - virKeyFileFree(auth->keyfile); + g_key_file_free(auth->keyfile); VIR_FREE(auth->path); VIR_FREE(auth); } @@ -115,15 +115,15 @@ int virAuthConfigLookup(virAuthConfigPtr auth, authgroup = g_strdup_printf("auth-%s-%s", service, hostname); - if (!virKeyFileHasGroup(auth->keyfile, authgroup)) { + if (!g_key_file_has_group(auth->keyfile, authgroup)) { VIR_FREE(authgroup); authgroup = g_strdup_printf("auth-%s-%s", service, "default"); } - if (!virKeyFileHasGroup(auth->keyfile, authgroup)) + if (!g_key_file_has_group(auth->keyfile, authgroup)) return 0; - if (!(authcred = virKeyFileGetValueString(auth->keyfile, authgroup, "credentials"))) { + if (!(authcred = g_key_file_get_string(auth->keyfile, authgroup, "credentials", NULL))) { virReportError(VIR_ERR_CONF_SYNTAX, _("Missing item 'credentials' in group '%s' in '%s'"), authgroup, auth->path); @@ -132,17 +132,14 @@ int virAuthConfigLookup(virAuthConfigPtr auth, credgroup = g_strdup_printf("credentials-%s", authcred); - if (!virKeyFileHasGroup(auth->keyfile, credgroup)) { + if (!g_key_file_has_group(auth->keyfile, credgroup)) { virReportError(VIR_ERR_CONF_SYNTAX, _("Missing group 'credentials-%s' referenced from group '%s' in '%s'"), authcred, authgroup, auth->path); return -1; } - if (!virKeyFileHasValue(auth->keyfile, credgroup, credname)) - return 0; - - *value = virKeyFileGetValueString(auth->keyfile, credgroup, credname); + *value = g_key_file_get_string(auth->keyfile, credgroup, credname, NULL); return 0; } -- 2.25.1

3 3

[libvirt PATCH] qemu: ensure domain event thread is always stopped
by Daniel P. Berrangé 23 Mar '20

23 Mar '20

In previous commit: commit e6afacb0feabd9bf58331aa0e5259a35378be74e Author: Daniel P. Berrangé <berrange(a)redhat.com> Date: Wed Feb 12 12:26:11 2020 +0000 qemu: start/stop an event loop thread for domains A bogus comment was added claiming we didn't need to shutdown the event thread in the qemuProcessStop method, because this would be done in the monitor EOF callback. This was wrong because the EOF callback only runs in the case of a QEMU crash or a guest initiated clean shutdown & poweroff. In the case where the libvirt admin calls virDomainDestroy, the EOF callback never fires because we have already unregistered the event callbacks. We must thus always attempt to stop the event thread in qemuProcessStop. Reported-by: Peter Krempa <pkrempa(a)redhat.com> Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/qemu/qemu_process.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index e8401030a2..fcdde76aaa 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -7398,17 +7398,7 @@ void qemuProcessStop(virQEMUDriverPtr driver, priv->monConfig = NULL; } - /* - * We cannot stop the event thread at this time. When - * we are in this code, we may not yet have processed the - * STOP event or EOF from the monitor. So the event loop - * may have pending input that we need to process still. - * The qemuProcessHandleMonitorEOF method will kill - * the event thread because at that point we don't - * expect any more I/O from the QEMU monitor. We are - * assuming we don't need to get any more events from the - * QEMU agent at that time. - */ + qemuDomainObjStopWorker(vm); /* Remove the master key */ qemuDomainMasterKeyRemove(priv); -- 2.24.1

2 1

[PATCH v3 0/6] NVDIMM suport for pSeries guests
by Daniel Henrique Barboza 22 Mar '20

22 Mar '20

changes in v3, all proposed by Shivaprasad Bhat: - error out when the NVDIMM is too small instead of rounding it up to alignment - added a new patch (#1) to update ppc64 capabilities. This new patch can be pushed separately, but the unit tests of patch 3/6 depends on it - previous version: https://www.redhat.com/archives/libvir-list/2020-March/msg00406.html Daniel Henrique Barboza (6): qemu: capabilities: update qemu-5.0.0 capabilities for ppc64 conf: Introduce optional 'uuid' element for NVDIMM memory formatdomain.html.in: document the new 'uuid' NVDIMM element conf, qemu: enable NVDIMM support for ppc64 formatdomain.html.in: document NVDIMM 'label' requirement for pSeries news.xml: document the new NVDIMM support for Pseries guests docs/formatdomain.html.in | 24 +- docs/news.xml | 11 + docs/schemas/domaincommon.rng | 5 + src/conf/domain_conf.c | 44 +- src/conf/domain_conf.h | 3 + src/qemu/qemu_command.c | 7 + src/qemu/qemu_domain.c | 63 +- src/qemu/qemu_domain.h | 4 +- src/qemu/qemu_hotplug.c | 6 +- tests/domaincapsdata/qemu_5.0.0.ppc64.xml | 2 +- .../caps_5.0.0.ppc64.replies | 10949 +++++++++------- .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1216 +- ...default-video-type-ppc64.ppc64-latest.args | 2 - .../memory-hotplug-nvdimm-ppc64.args | 32 + ...ory-hotplug-nvdimm-ppc64.ppc64-latest.args | 36 + .../memory-hotplug-nvdimm-ppc64.xml | 50 + ...ault-cpu-kvm-pseries-2.7.ppc64-latest.args | 10 +- ...ault-cpu-kvm-pseries-3.1.ppc64-latest.args | 10 +- ...ault-cpu-kvm-pseries-4.2.ppc64-latest.args | 10 +- ...ault-cpu-tcg-pseries-2.7.ppc64-latest.args | 10 +- ...ault-cpu-tcg-pseries-3.1.ppc64-latest.args | 10 +- ...ault-cpu-tcg-pseries-4.2.ppc64-latest.args | 10 +- .../ppc64-pseries-graphics.ppc64-latest.args | 10 +- .../ppc64-pseries-headless.ppc64-latest.args | 10 +- .../tpm-emulator-spapr.ppc64-latest.args | 9 +- tests/qemuxml2argvtest.c | 1 + .../memory-hotplug-nvdimm-ppc64.xml | 50 + tests/qemuxml2xmltest.c | 2 + 28 files changed, 7025 insertions(+), 5571 deletions(-) create mode 100644 tests/qemuxml2argvdata/memory-hotplug-nvdimm-ppc64.args create mode 100644 tests/qemuxml2argvdata/memory-hotplug-nvdimm-ppc64.ppc64-latest.args create mode 100644 tests/qemuxml2argvdata/memory-hotplug-nvdimm-ppc64.xml create mode 100644 tests/qemuxml2xmloutdata/memory-hotplug-nvdimm-ppc64.xml -- 2.25.1

1 6

GSOC'20: Add support for Jailhouse hypervisor to libvirt.
by PRAKHAR BANSAL 21 Mar '20

21 Mar '20

Hello All, My name is Prakhar Bansal and I am a graduate student in Computer Engineering at Iowa State University, US. I have experience with Analysing Performance of Applications running inside multiple virtual machines hosted by the libvirt QEMU-KVM through virt-manager. I am interested in working on the project to develop a Libvirt driver for the Jailhouse hypervisor. I looked into the initial attempt on the Jailhouse driver which seems to be based on the Jailhouse command-line interface. I am currently looking into learning and understanding the kernel APIs for jailhouse hypervisor. I followed the below articles from Mr. Valentine Sinitsyn to begin learning about the Jailhouse hypervisor. https://lwn.net/Articles/578295/ https://lwn.net/Articles/578852/ Regards, Prakhar Bansal

1 0

Fwd: KVM hook
by Aditya Sahu 21 Mar '20

21 Mar '20

Hi Team , I am reaching out to you seeking your help for one of my KVM hook script. I am using /etc/libvirt/hooks/network file to trigger an event when a network is created or deleted ( https://www.libvirt.org/hooks.html ). Basically I using a rest call to create the same network in my Infoblox appliance for the network monitoring. However every time I create a network only $2== start or $2==started gets invoked, i have tried pretty much every combination and permutation but did not get any success. I checked the libvirtd.log and found that only $2== start or $2==started gets invoked. In my case i would like to get network created in infoblox appliance as and when it gets created in the KVM and should get deleted as and when it gets deleted from the KVM. Here is snippet of my script #!/bin/bash network_name=`xml_grep --text_only hookData/network/name /etc/libvirt/hooks/net_details` network=`xmllint --xpath hookData/network/ip/@address /etc/libvirt/hooks/net_details|cut -d "=" -f2|tr -d '"'` network_mask=`ipcalc $network |awk '/Network/{print$2}'` if [[ $2=="begin" ]] || [[ $2=="start" ]] || [[ $2=="started" ]]; then curl -k -u admin:infoblox -H "content-type: application/json" -X POST " https://10.196.200.63/wapi/v2.10/network?_return_fields%2B=network&_return_…" -d '{"network": "'$network_mask'"}' network_ref=`curl -k -s -u admin:infoblox -H 'content-type: application/json' -X GET ' https://10.196.200.63/wapi/v2.10/network?_return_fields%2B=network&_return_… '| grep $network_mask| awk -v RS=" " '/_ref/{getline;print$1}' |cut -d "/" -f2-3` else curl -k -u admin:infoblox -H 'content-type: application/json' -X DELETE "https://10.196.200.63/wapi/v2.10/network/$network_ref/default" fi ----------------------------------------------------------------------------------------------------------------------- This script works perfectly fine and creates the network however when i delete the network it does not get deleted from the infoblox appliance. As i mentioned when tailed the libvirtd.log I found that the API to create network gets executed when the network is stopped. Attaching libvirted.log snippet [image: image.png] In this screen shot, stopped hook is triggered but still network creation API is fired which has errored out. Any guidance or help is highly appreciated. -Aditya

1 0

[libvirt PATCH 0/4] src: add configurable support for cgroups usage
by Daniel P. Berrangé 21 Mar '20

21 Mar '20

This simple series allows apps to choose how cgroups are managed by libvirt, between cgroupfs and machined, or disabled entirely. Daniel P. Berrangé (4): conf: allow different resource registration modes util: allow choice between machined or direct cgroups filesystem qemu: wire up support for controlling use of cgroups backend lxc: wire up support for controlling use of cgroups backend docs/formatdomain.html.in | 24 +++++++- docs/schemas/domaincommon.rng | 17 +++++- src/conf/domain_conf.c | 46 ++++++++++++---- src/conf/domain_conf.h | 13 +++++ src/libvirt_private.syms | 2 + src/lxc/lxc_cgroup.c | 32 +++++++++++ src/lxc/lxc_cgroup.h | 3 + src/lxc/lxc_process.c | 7 ++- src/qemu/qemu_cgroup.c | 67 +++++++++++++++++++++-- src/qemu/qemu_command.c | 9 +-- src/util/vircgroup.c | 57 ++++++++++++------- src/util/vircgroup.h | 7 +++ tests/lxcxml2xmldata/lxc-capabilities.xml | 2 +- tests/lxcxml2xmldata/lxc-idmap.xml | 2 +- 14 files changed, 239 insertions(+), 49 deletions(-) -- 2.24.1

3 13

[libvirt PATCH] docs: virtiofs: add missing aposthrophe
by Ján Tomko 20 Mar '20

20 Mar '20

Signed-off-by: Ján Tomko <jtomko(a)redhat.com> Reported-by: Dr. David Alan Gilbert <dgilbert(a)redhat.com> --- I pushed this on Monday, but forgot to send the e-mail. docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index b6ddfa8e0c..594146009d 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -3981,7 +3981,7 @@ <readonly/> </filesystem> <filesystem type='mount' accessmode='passthrough'> - <driver type='virtiofs queue='1024'/> + <driver type='virtiofs' queue='1024'/> <binary path='/usr/libexec/virtiofsd' xattr='on'> <cache mode='always'/> <lock posix='on' flock='on'/> -- 2.24.1

1 0

listen type socket support for rdp graphics
by Vasiliy Tolstov 20 Mar '20

20 Mar '20

Hi! How hard implement listen type socket support for rdp graphics? VNC and SPICE already have such options? And does this support for rdp available for qemu driver? (I need to access qemu vm via rdp) Thanks! -- Vasiliy Tolstov, e-mail: v.tolstov(a)selfip.ru

2 2

[PATCH] qemu: reset await_event in all error paths in qemuAgentCommand
by Nikolay Shirokovskiy 20 Mar '20

20 Mar '20

A fixup to patch [1]. We need to reset await_event in all error paths. [1] 52532073d : qemu: remove redundant needReply argument of qemuAgentCommand Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com> --- src/qemu/qemu_agent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index 9ea2c59..6ff5b11 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -1113,7 +1113,7 @@ qemuAgentCommand(qemuAgentPtr agent, } if (qemuAgentGuestSync(agent) < 0) - return -1; + goto cleanup; if (!(cmdstr = virJSONValueToString(cmd, false))) goto cleanup; -- 1.8.3.1

2 1