- Devel - libvirt List Archives

[PATCH v2 0/4] libxl: add e820_host option to the libvirt config
by Marek Marczykowski-Górecki 14 Apr '20

14 Apr '20

Context: - old thread on xen-devel: http://xen.markmail.org/thread/awcswnywzei4s65e - new thread here: https://www.redhat.com/archives/libvir-list/2020-April/msg00447.html Marek Marczykowski-Górecki (4): conf: add xen specific feature: e820_host libxl: make use of e820_host feature xenconfig: parse e820_host option tests: check e820_host option handling docs/formatdomain.html.in | 20 ++++- docs/schemas/domaincommon.rng | 16 +++- src/conf/domain_conf.c | 102 ++++++++++++++++++- src/conf/domain_conf.h | 9 ++- src/libxl/libxl_conf.c | 14 ++- src/libxl/xen_common.c | 13 ++- src/qemu/qemu_validate.c | 1 +- tests/xlconfigdata/test-paravirt-e820_host.cfg | 13 ++- tests/xlconfigdata/test-paravirt-e820_host.xml | 37 +++++++- tests/xlconfigtest.c | 1 +- 10 files changed, 226 insertions(+) create mode 100644 tests/xlconfigdata/test-paravirt-e820_host.cfg create mode 100644 tests/xlconfigdata/test-paravirt-e820_host.xml base-commit: 7118bdee1550b6022e7362402ca8204add4cf80b -- git-series 0.9.1

2 5

[PATCH 0/2] backup: Fix docs and add schema for LUKS encrypted backups
by Peter Krempa 14 Apr '20

14 Apr '20

Peter Krempa (2): docs: backup: Remove references to push backup to network disk backup: Allow 'encryption' of backups and scratch images docs/formatbackup.html.in | 19 ++++-- docs/schemas/domainbackup.rng | 65 +++++++++++++++---- .../backup-pull-encrypted.xml | 30 +++++++++ .../backup-push-encrypted.xml | 29 +++++++++ .../backup-pull-encrypted.xml | 30 +++++++++ .../backup-push-encrypted.xml | 29 +++++++++ tests/genericxml2xmltest.c | 3 + 7 files changed, 187 insertions(+), 18 deletions(-) create mode 100644 tests/domainbackupxml2xmlin/backup-pull-encrypted.xml create mode 100644 tests/domainbackupxml2xmlin/backup-push-encrypted.xml create mode 100644 tests/domainbackupxml2xmlout/backup-pull-encrypted.xml create mode 100644 tests/domainbackupxml2xmlout/backup-push-encrypted.xml -- 2.26.0

4 7

[libvirt PATCH] README: rewrite in rst
by Ján Tomko 14 Apr '20

14 Apr '20

Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- README | 2 +- README.md => README.rst | 53 +++++++++++++++++++++-------------------- 2 files changed, 28 insertions(+), 27 deletions(-) rename README.md => README.rst (65%) diff --git a/README b/README index 42061c01a1..92cacd2853 120000 --- a/README +++ b/README @@ -1 +1 @@ -README.md \ No newline at end of file +README.rst \ No newline at end of file diff --git a/README.md b/README.rst similarity index 65% rename from README.md rename to README.rst index 44b0dd87c5..222ba55e78 100644 --- a/README.md +++ b/README.rst @@ -1,6 +1,11 @@ -[![Build Status](https://travis-ci.org/libvirt/libvirt.svg)](https://travis-ci.org/l… - [![CII Best Practices](https://bestpractices.coreinfrastructure.org/projects/355/badge)… +.. image:: https://travis-ci.org/libvirt/libvirt.svg + :alt: Build Status + :target: https://travis-ci.org/libvirt/libvirt +.. image:: https://bestpractices.coreinfrastructure.org/projects/355/badge + :alt: CII Best Practices + :target: https://bestpractices.coreinfrastructure.org/projects/355 +============================== Libvirt API for virtualization ============================== @@ -21,60 +26,56 @@ mappings into object systems such as GObject, CIM and SNMP. Further information about the libvirt project can be found on the website: -[https://libvirt.org](https://libvirt.org) +https://libvirt.org License -------- +======= The libvirt C API is distributed under the terms of GNU Lesser General Public License, version 2.1 (or later). Some parts of the code that are not part of the C library may have the more restrictive GNU General -Public License, version 2.0 (or later). See the files `COPYING.LESSER` -and `COPYING` for full license terms & conditions. +Public License, version 2.0 (or later). See the files ``COPYING.LESSER`` +and ``COPYING`` for full license terms & conditions. Installation ------------- +============ Libvirt uses the GNU Autotools build system, so in general can be built and installed with the usual commands, however, we mandate to have the build directory different than the source directory. For example, to build -in a manner that is suitable for installing as root, use: +in a manner that is suitable for installing as root, use:: -``` -$ mkdir build && cd build -$ ../configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var -$ make -$ sudo make install -``` + $ mkdir build && cd build + $ ../configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var + $ make + $ sudo make install -While to build & install as an unprivileged user +While to build & install as an unprivileged user:: -``` -$ mkdir build && cd build -$ ../configure --prefix=$HOME/usr -$ make -$ make install -``` + $ mkdir build && cd build + $ ../configure --prefix=$HOME/usr + $ make + $ make install The libvirt code relies on a large number of 3rd party libraries. These will -be detected during execution of the `configure` script and a summary printed +be detected during execution of the ``configure`` script and a summary printed which lists any missing (optional) dependencies. Contributing ------------- +============ The libvirt project welcomes contributions in many ways. For most components the best way to contribute is to send patches to the primary development mailing list. Further guidance on this can be found on the website: -[https://libvirt.org/contribute.html](https://libvirt.org/contribute.html) +https://libvirt.org/contribute.html Contact -------- +======= The libvirt project has two primary mailing lists: @@ -83,4 +84,4 @@ The libvirt project has two primary mailing lists: Further details on contacting the project are available on the website: -[https://libvirt.org/contact.html](https://libvirt.org/contact.html) +https://libvirt.org/contact.html -- 2.25.1

2 1

[libvirt PATCH] Convert all remaining Markdown files to reStructuredText
by Andrea Bolognani 14 Apr '20

14 Apr '20

We've adopted reStructuredText as the primary markup language for our documentation and, given that both GitLab and GitHub can render documents in this format just fine, it makes sense to get rid of the few last remaining bits of Markdown and standardize on reStructuredText across the board. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Note that I've taken a few liberties during the conversion when it comes to formatting, with the goal of staying close to the style used for existing reStructuredText documents, but I have not altered the contents beyond that. ABOUT-NLS | 2 +- Makefile.am | 2 +- README | 2 +- README.md => README.rst | 55 ++++++++++++----------- docs/Makefile.am | 2 +- docs/fonts/{LICENSE.md => LICENSE.rst} | 30 +++++++++---- libvirt.spec.in | 2 +- po/{README.md => README.rst} | 32 ++++++++----- tools/wireshark/{README.md => README.rst} | 28 ++++++++---- 9 files changed, 97 insertions(+), 58 deletions(-) rename README.md => README.rst (65%) rename docs/fonts/{LICENSE.md => LICENSE.rst} (94%) rename po/{README.md => README.rst} (86%) rename tools/wireshark/{README.md => README.rst} (52%) diff --git a/ABOUT-NLS b/ABOUT-NLS index b583e276a7..91a3266ed6 120000 --- a/ABOUT-NLS +++ b/ABOUT-NLS @@ -1 +1 @@ -po/README.md \ No newline at end of file +po/README.rst \ No newline at end of file diff --git a/Makefile.am b/Makefile.am index 5590c88e4d..06475344c1 100644 --- a/Makefile.am +++ b/Makefile.am @@ -43,7 +43,7 @@ EXTRA_DIST = \ autogen.sh \ GNUmakefile \ run.in \ - README.md \ + README.rst \ AUTHORS.in \ scripts/apibuild.py \ scripts/augeas-gentest.py \ diff --git a/README b/README index 42061c01a1..92cacd2853 120000 --- a/README +++ b/README @@ -1 +1 @@ -README.md \ No newline at end of file +README.rst \ No newline at end of file diff --git a/README.md b/README.rst similarity index 65% rename from README.md rename to README.rst index 44b0dd87c5..663fba4510 100644 --- a/README.md +++ b/README.rst @@ -1,6 +1,9 @@ -[![Build Status](https://travis-ci.org/libvirt/libvirt.svg)](https://travis-ci.org/l… - [![CII Best Practices](https://bestpractices.coreinfrastructure.org/projects/355/badge)… +.. image:: https://travis-ci.org/libvirt/libvirt.svg + :alt: Travis CI Build Status +.. image:: https://bestpractices.coreinfrastructure.org/projects/355/badge + :alt: CII Best Practices +============================== Libvirt API for virtualization ============================== @@ -21,66 +24,66 @@ mappings into object systems such as GObject, CIM and SNMP. Further information about the libvirt project can be found on the website: -[https://libvirt.org](https://libvirt.org) +https://libvirt.org License -------- +======= The libvirt C API is distributed under the terms of GNU Lesser General Public License, version 2.1 (or later). Some parts of the code that are not part of the C library may have the more restrictive GNU General -Public License, version 2.0 (or later). See the files `COPYING.LESSER` -and `COPYING` for full license terms & conditions. +Public License, version 2.0 (or later). See the files ``COPYING.LESSER`` +and ``COPYING`` for full license terms & conditions. Installation ------------- +============ Libvirt uses the GNU Autotools build system, so in general can be built and installed with the usual commands, however, we mandate to have the build directory different than the source directory. For example, to build in a manner that is suitable for installing as root, use: -``` -$ mkdir build && cd build -$ ../configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var -$ make -$ sudo make install -``` +:: + + $ mkdir build && cd build + $ ../configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var + $ make + $ sudo make install While to build & install as an unprivileged user -``` -$ mkdir build && cd build -$ ../configure --prefix=$HOME/usr -$ make -$ make install -``` +:: + + $ mkdir build && cd build + $ ../configure --prefix=$HOME/usr + $ make + $ make install The libvirt code relies on a large number of 3rd party libraries. These will -be detected during execution of the `configure` script and a summary printed +be detected during execution of the ``configure`` script and a summary printed which lists any missing (optional) dependencies. Contributing ------------- +============ The libvirt project welcomes contributions in many ways. For most components the best way to contribute is to send patches to the primary development mailing list. Further guidance on this can be found on the website: -[https://libvirt.org/contribute.html](https://libvirt.org/contribute.html) +https://libvirt.org/contribute.html Contact -------- +======= The libvirt project has two primary mailing lists: - * libvirt-users(a)redhat.com (**for user discussions**) - * libvir-list(a)redhat.com (**for development only**) +* libvirt-users(a)redhat.com (**for user discussions**) +* libvir-list(a)redhat.com (**for development only**) Further details on contacting the project are available on the website: -[https://libvirt.org/contact.html](https://libvirt.org/contact.html) +https://libvirt.org/contact.html diff --git a/docs/Makefile.am b/docs/Makefile.am index 404121a2a2..6860efc888 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -118,7 +118,7 @@ javascriptdir = $(HTML_DIR)/js javascript_DATA = $(javascript) fonts = \ - fonts/LICENSE.md \ + fonts/LICENSE.rst \ fonts/stylesheet.css \ fonts/overpass-bold-italic.woff \ fonts/overpass-bold.woff \ diff --git a/docs/fonts/LICENSE.md b/docs/fonts/LICENSE.rst similarity index 94% rename from docs/fonts/LICENSE.md rename to docs/fonts/LICENSE.rst index 9520f30f73..4e32b1a1d3 100644 --- a/docs/fonts/LICENSE.md +++ b/docs/fonts/LICENSE.rst @@ -1,18 +1,24 @@ -## License +======= +License +======= Copyright (C) 2015 Red Hat, Inc., This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is copied below, and is also available with a FAQ at: + http://scripts.sil.org/OFL -#### SIL OPEN FONT LICENSE +===================== +SIL OPEN FONT LICENSE +===================== + Version 1.1 - 26 February 2007 ---- +PREAMBLE +======== -#### PREAMBLE The goals of the Open Font License (OFL) are to stimulate worldwide development of collaborative font projects, to support the font creation efforts of academic and linguistic communities, and to provide a free and open framework @@ -27,7 +33,9 @@ any other type of license. The requirement for fonts to remain under this license does not apply to any document created using the fonts or their derivatives. -#### DEFINITIONS +DEFINITIONS +=========== + “Font Software” refers to the set of files released by the Copyright Holder(s) under this license and clearly marked as such. This may include source files, build scripts and documentation. @@ -45,7 +53,9 @@ by changing formats or by porting the Font Software to a new environment. “Author” refers to any designer, engineer, programmer, technical writer or other person who contributed to the Font Software. -#### PERMISSION & CONDITIONS +PERMISSION & CONDITIONS +======================= + Permission is hereby granted, free of charge, to any person obtaining a copy of the Font Software, to use, study, copy, merge, embed, modify, redistribute, and sell modified and unmodified copies of the Font Software, subject to the @@ -76,10 +86,14 @@ distributed entirely under this license, and must not be distributed under any other license. The requirement for fonts to remain under this license does not apply to any document created using the Font Software. -#### TERMINATION +TERMINATION +=========== + This license becomes null and void if any of the above conditions are not met. -#### DISCLAIMER +DISCLAIMER +========== + THE FONT SOFTWARE IS PROVIDED “AS IS”, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO ANY WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF COPYRIGHT, PATENT, diff --git a/libvirt.spec.in b/libvirt.spec.in index 6061a26497..6abf97df85 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1505,7 +1505,7 @@ exit 0 %files %files docs -%doc AUTHORS ChangeLog NEWS README README.md +%doc AUTHORS ChangeLog NEWS README README.rst %doc %{_vpath_builddir}/libvirt-docs/* %files daemon diff --git a/po/README.md b/po/README.rst similarity index 86% rename from po/README.md rename to po/README.rst index 2f77c5d48c..2e234547ca 100644 --- a/po/README.md +++ b/po/README.rst @@ -1,3 +1,4 @@ +=========================== Libvirt Message Translation =========================== @@ -7,6 +8,7 @@ file formats, in combination with the Zanata web service. python-zanata-client is required in order to use make to pull/push translations from/to Zanata server. + Source repository ================= @@ -14,21 +16,25 @@ The libvirt GIT repository does NOT store the master "libvirt.pot" file, nor does it store full "po" files for translations. The master "libvirt.pot" file can be generated at any time using - make libvirt.pot +:: + + $ make libvirt.pot The translations are kept in minimized files that are the same file format as normal po files but with all redundant information stripped and messages re-ordered. The key differences between the ".mini.po" files in GIT and the full ".po" files are - - msgids with no current translation are omitted - - msgids are sorted in alphabetical order not source file order - - msgids with a msgstr marked "fuzzy" are discarded - - source file locations are omitted +* msgids with no current translation are omitted +* msgids are sorted in alphabetical order not source file order +* msgids with a msgstr marked "fuzzy" are discarded +* source file locations are omitted The full po files can be created at any time using - make update-po +:: + + $ make update-po This merges the "libvirt.pot" with the "$LANG.mini.po" for each language, to create the "$LANG.po" files. These are included in the release archives created @@ -37,7 +43,9 @@ by "make dist". When a full po file is updated, changes can be propagated back into the minimized po files using - make update-mini-po +:: + + $ make update-mini-po Note, however, that this is generally not something that should be run by developers normally, as it is triggered by 'make pull-po' when refreshing @@ -50,7 +58,7 @@ Zanata web service The translation of libvirt messages has been outsourced to the Fedora translation team using the Zanata web service: - https://fedora.zanata.org/project/view/libvirt +https://fedora.zanata.org/project/view/libvirt As such, changes to translations will generally NOT be accepted as patches directly to libvirt GIT. Any changes made to "$LANG.mini.po" files in libvirt @@ -59,12 +67,16 @@ GIT will be overwritten and lost the next time content is imported from Zanata. The master "libvirt.pot" file is periodically pushed to Zanata to provide the translation team with content changes, using - make push-pot +:: + + $ make push-pot New translated text is then periodically pulled down from Zanata to update the minimized po files, using - make pull-po +:: + + $ make pull-po Sometimes the translators make mistakes, most commonly with handling printf format specifiers. The "pull-po" command re-generates the .gmo files to try to diff --git a/tools/wireshark/README.md b/tools/wireshark/README.rst similarity index 52% rename from tools/wireshark/README.md rename to tools/wireshark/README.rst index b7f40d0954..919b89d32a 100644 --- a/tools/wireshark/README.md +++ b/tools/wireshark/README.rst @@ -1,5 +1,7 @@ +===== About ===== + This is the project of Google Summer of Code 2013 accepted by QEMU.org and libvirt community. The goal of this project is, provide Wireshark dissector for Libvirt RPC protocol. It will provide Libvirt packet overview/detail analysing @@ -8,24 +10,32 @@ definition placed in Libvirt source tree to support latest protocol specification. See also: -- http://www.google-melange.com/gsoc/project/google/gsoc2013/kawamuray/7001 -- https://wiki.qemu.org/Features/LibvirtWiresharkDissector + +* http://www.google-melange.com/gsoc/project/google/gsoc2013/kawamuray/7001 +* https://wiki.qemu.org/Features/LibvirtWiresharkDissector + Installation ============= -Run ./configure with --with-wireshark-dissector option enabled. + +Run ``./configure`` with ``--with-wireshark-dissector`` option enabled. Then dissector will compiled with libvirt itself. Add/Remove protocol from dissector's support -------------------------------------------- -Modify variable WS\_DISSECTOR\_PROTO\_FILES in tools/wireshark/src/Makefile.am. + +Modify variable ``WS_DISSECTOR_PROTO_FILES`` +in ``tools/wireshark/src/Makefile.am``. Changing installation directory ------------------------------- -You can change installation directory of pluggable shared object(libvirt.so) by -specifying --with-ws-plugindir=<path>. -You can install libvirt.so into your local wireshark plugin directory: +You can change installation directory of pluggable shared +object(``libvirt.so``) by specifying ``--with-ws-plugindir=<path>``. + +You can install ``libvirt.so`` into your local wireshark plugin directory: + +:: - ./configure --with-wireshark-dissector \ - --with-ws-plugindir=$HOME/.wireshark/plugins + $ ./configure --with-wireshark-dissector \ + --with-ws-plugindir=$HOME/.wireshark/plugins -- 2.25.2

2 4

[PATCH 0/2] Fix formatting of http cookies into XML
by Peter Krempa 14 Apr '20

14 Apr '20

See 2/2. Peter Krempa (2): virstoragetest: testBackingParse: Use VIR_DOMAIN_DEF_FORMAT_SECURE when formatting xml conf: Don't format http cookies unless VIR_DOMAIN_DEF_FORMAT_SECURE is used src/conf/domain_conf.c | 8 ++++++-- tests/virstoragetest.c | 3 ++- 2 files changed, 8 insertions(+), 3 deletions(-) -- 2.26.0

2 4

libvirt python console
by PunkGeek 14 Apr '20

14 Apr '20

Hello, I see this example about VM console serial, Which I could connect to the guest VM successfully. however, I could not understand how to send commands to the guest VM? https://github.com/libvirt/libvirt-python/blob/master/examples/consolecallb… Best regards

2 1

[PATCH] libvirt-stream.c: Use g_autofree
by Seeteena Thoufeek 14 Apr '20

14 Apr '20

Signed-off-by: Seeteena Thoufeek <s1seetee(a)linux.vnet.ibm.com> --- src/libvirt-stream.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/src/libvirt-stream.c b/src/libvirt-stream.c index 6f6bb5d..41b9cc1 100644 --- a/src/libvirt-stream.c +++ b/src/libvirt-stream.c @@ -573,7 +573,7 @@ virStreamSendAll(virStreamPtr stream, virStreamSourceFunc handler, void *opaque) { - char *bytes = NULL; + g_autofree char *bytes = NULL; size_t want = VIR_NET_MESSAGE_LEGACY_PAYLOAD_MAX; int ret = -1; VIR_DEBUG("stream=%p, handler=%p, opaque=%p", stream, handler, opaque); @@ -616,8 +616,6 @@ virStreamSendAll(virStreamPtr stream, ret = 0; cleanup: - VIR_FREE(bytes); - if (ret != 0) { virErrorPtr orig_err; @@ -706,7 +704,7 @@ int virStreamSparseSendAll(virStreamPtr stream, virStreamSourceSkipFunc skipHandler, void *opaque) { - char *bytes = NULL; + g_autofree char *bytes = NULL; size_t bufLen = VIR_NET_MESSAGE_LEGACY_PAYLOAD_MAX; int ret = -1; unsigned long long dataLen = 0; @@ -787,8 +785,6 @@ int virStreamSparseSendAll(virStreamPtr stream, ret = 0; cleanup: - VIR_FREE(bytes); - if (ret != 0) { virErrorPtr orig_err; @@ -847,7 +843,7 @@ virStreamRecvAll(virStreamPtr stream, virStreamSinkFunc handler, void *opaque) { - char *bytes = NULL; + g_autofree char *bytes = NULL; size_t want = VIR_NET_MESSAGE_LEGACY_PAYLOAD_MAX; int ret = -1; VIR_DEBUG("stream=%p, handler=%p, opaque=%p", stream, handler, opaque); @@ -892,8 +888,6 @@ virStreamRecvAll(virStreamPtr stream, ret = 0; cleanup: - VIR_FREE(bytes); - if (ret != 0) { virErrorPtr orig_err; @@ -964,7 +958,7 @@ virStreamSparseRecvAll(virStreamPtr stream, virStreamSinkHoleFunc holeHandler, void *opaque) { - char *bytes = NULL; + g_autofree char *bytes = NULL; size_t want = VIR_NET_MESSAGE_LEGACY_PAYLOAD_MAX; const unsigned int flags = VIR_STREAM_RECV_STOP_AT_HOLE; int ret = -1; @@ -1025,8 +1019,6 @@ virStreamSparseRecvAll(virStreamPtr stream, ret = 0; cleanup: - VIR_FREE(bytes); - if (ret != 0) { virErrorPtr orig_err; -- 1.8.3.1

2 1

[libvirt PATCH 0/2] Improve entry point for new contributors
by Andrea Bolognani 14 Apr '20

14 Apr '20

Use the path most people will look for, reduce building instructions to the bare minimum necessary to locally bootstrap the learning process, and ensure duplication doesn't creep in over time by pointing to the full documentation. Andrea Bolognani (2): CONTRIBUTING: Add entry point for new contributors README-hacking: Drop from the git repository CONTRIBUTING.md | 18 ++++++++++++++++ README-hacking | 56 ------------------------------------------------- 2 files changed, 18 insertions(+), 56 deletions(-) create mode 100644 CONTRIBUTING.md delete mode 100644 README-hacking -- 2.25.1

2 6

[libvirt-jenkins-ci PATCH v3 0/5] Introduce the new 'gitlab' flavor
by Erik Skultety 14 Apr '20

14 Apr '20

since v1: - .bash_logout is removed from the user home environment (causes builds to fail on Debian) - gitlab-runner is now downloaded to and executed from user's bin/ directory instead of using /usr/local/bin - both RC and systemd service files now define the user explicitly that the init system changes to when spawning the gitlab-runner service - the gitlab flavour tasks file now relies on shell's 'creates' module argument so that the agent registration is idempotent rather than touching the dirs/files explicitly - both gitlab URL and runner token are now files editable under ~/.config/lcitool since v2: - download location changed to /usr/local/bin - config location changed to /etc/gitlab-runner (readable to the gitlab user) - machine tagging changed to 'os_version-distro_major_number' - fixed the regression caused by the gitlab code which was checking the gitlab config files unconditionally for all flavours - cosmetic syntactic changes to the Python code as requested by the reviewer Both the config.toml improvement in terms of replacing the ~/.config/lcitool files as discussed during the v1 review process as well as cloudinit usage is planned for a separate respective series, so for now, we'll have to live with 2 new config files and cloud images will need to be built manually. Erik Skultety (5): guests: users: Discard the .bash_logout skeleton file guests: templates: Introduce a gitlab-runner systemd service template guests: templates: Introduce a gitlab-runner RC init service template guests: Introduce the new 'gitlab' flavor guests: lcitool: Enable the new 'gitlab' flavor in the lcitool script guests/lcitool | 46 ++++++++++++++- guests/playbooks/update/main.yml | 5 ++ guests/playbooks/update/tasks/gitlab.yml | 58 +++++++++++++++++++ guests/playbooks/update/tasks/users.yml | 3 +- .../update/templates/gitlab-runner.j2 | 31 ++++++++++ .../update/templates/gitlab-runner.service.j2 | 14 +++++ 6 files changed, 154 insertions(+), 3 deletions(-) create mode 100644 guests/playbooks/update/tasks/gitlab.yml create mode 100644 guests/playbooks/update/templates/gitlab-runner.j2 create mode 100644 guests/playbooks/update/templates/gitlab-runner.service.j2 -- 2.25.1

2 12

[PATCH ocaml 0/1] RFC: add/switch to dune build system
by Pino Toscano 14 Apr '20

14 Apr '20

ocaml-libvirt is currently built using manually written makefiles, and an autoconf script to detect libvirt (using pkg-config). While this seems OK, it has a lot of downsides: - all the OCaml rules are manually written - there is some form of duplication in the OCaml rules - the bytecode vs native build is fragile Initially named jhbuild, dune is a native OCaml build system which plans to eventually replace the others (omake, oasis, ocamlbuild), with a growing user base in the OCaml community. This is a very simple patch adding support for dune. The idea is to replace the current autoconf+makefile build system, which can be removed more or less easily. I'd prefer to not maintain two build systems at once, so this patch is also a way to start a discussion about the proposed approach. Things not yet done (pending the discussion): - rewrite/simplify the release bits, currently interwonen in the makefiles - update the documentation - update libvirt-ci - remove the autoconf+makefile build system Pino Toscano (1): Add dune build system .gitignore | 3 +++ dune | 18 +++++++++++++ dune-project | 1 + dune.inc | 22 ++++++++++++++++ examples/dune | 50 ++++++++++++++++++++++++++++++++++++ libvirt/discover.ml | 40 +++++++++++++++++++++++++++++ libvirt/dune | 57 ++++++++++++++++++++++++++++++++++++++++++ libvirt/dune-project | 2 ++ libvirt/mllibvirt.opam | 33 ++++++++++++++++++++++++ 9 files changed, 226 insertions(+) create mode 100644 dune create mode 100644 dune-project create mode 100644 dune.inc create mode 100644 examples/dune create mode 100644 libvirt/discover.ml create mode 100644 libvirt/dune create mode 100644 libvirt/dune-project create mode 100644 libvirt/mllibvirt.opam -- 2.25.2

2 2

[PATCH] driver.c: Use g_autofree
by Seeteena Thoufeek 14 Apr '20

14 Apr '20

This is the only instance of g_autofree change applicable for driver.c Signed-off-by: Seeteena Thoufeek <s1seetee(a)linux.vnet.ibm.com> --- src/driver.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/driver.c b/src/driver.c index a2047be..e745210 100644 --- a/src/driver.c +++ b/src/driver.c @@ -48,7 +48,7 @@ virDriverLoadModule(const char *name, const char *regfunc, bool required) { - char *modfile = NULL; + g_autofree char *modfile = NULL; int ret; VIR_DEBUG("Module load %s", name); @@ -62,9 +62,6 @@ virDriverLoadModule(const char *name, return -1; ret = virModuleLoad(modfile, regfunc, required); - - VIR_FREE(modfile); - return ret; } -- 1.8.3.1

2 1

FYI: Report about libvirt failing to compile on MSYS2 with an XDR error
by Richard W.M. Jones 14 Apr '20

14 Apr '20

.. is here: https://github.com/msys2/MINGW-packages/issues/6384 Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v

1 0

[PATCH 0/4] libxl: add e820_host option to the libvirt config
by Marek Marczykowski-Górecki 13 Apr '20

13 Apr '20

Context: - old thread on xen-devel: http://xen.markmail.org/thread/awcswnywzei4s65e - new thread here: https://www.redhat.com/archives/libvir-list/2020-April/msg00447.html Marek Marczykowski-Górecki (4): conf: add xen specific feature: e820_host libxl: make use of e820_host feature xenconfig: parse e820_host option tests: check e820_host option handling docs/schemas/domaincommon.rng | 16 +++- src/conf/domain_conf.c | 106 ++++++++++++++++++- src/conf/domain_conf.h | 9 ++- src/libxl/libxl_conf.c | 14 ++- src/libxl/xen_common.c | 14 ++- src/qemu/qemu_validate.c | 1 +- tests/xlconfigdata/test-paravirt-e820_host.cfg | 13 ++- tests/xlconfigdata/test-paravirt-e820_host.xml | 37 ++++++- tests/xlconfigtest.c | 1 +- 9 files changed, 211 insertions(+) create mode 100644 tests/xlconfigdata/test-paravirt-e820_host.cfg create mode 100644 tests/xlconfigdata/test-paravirt-e820_host.xml base-commit: 7118bdee1550b6022e7362402ca8204add4cf80b -- git-series 0.9.1

2 8

[PATCH] util: fix iteration in virSocketAddrResolveService
by Nikolay Shirokovskiy 13 Apr '20

13 Apr '20

getaddrinfo returns linked list. Fix iteration accordingly. Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com> --- src/util/virsocketaddr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c index 4cad329..4c9f124 100644 --- a/src/util/virsocketaddr.c +++ b/src/util/virsocketaddr.c @@ -271,7 +271,7 @@ int virSocketAddrResolveService(const char *service) port = ntohs(in.sin6_port); goto cleanup; } - tmp++; + tmp = tmp->ai_next; } virReportError(VIR_ERR_SYSTEM_ERROR, -- 1.8.3.1

2 1

[PATCH] formatdomain.html.in: document emulator/vcpu pin delay
by Daniel Henrique Barboza 10 Apr '20

10 Apr '20

In a guest with only one vcpu, when pinning the emulator in say CPU184 and the vcpu0 in CPU0 of the host, the user might expect that only CPU0 and CPU184 of the host will be used by the guest. The reality is that Libvirt takes some time to honor the emulator and vcpu pinning, taking care of NUMA constraints first. This will result in other CPUs of the host being potentially used by the QEMU thread until the emulator/vcpu pinning is done. The user then might be confused by the output of 'virsh cpu-stats' in this scenario, showing around 200 microseconds of cycles being spent in other CPUs. Let's document this behavior, which is explained in detail in Libvirt commit v5.0.0-199-gf136b83139, in the cputune section of formatdomain.html.in. Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com> --- docs/formatdomain.html.in | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 47e10a836c..932bf8841f 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -808,6 +808,13 @@ <dd> The optional <code>cputune</code> element provides details regarding the CPU tunable parameters for the domain. + + Note: for the qemu driver, the optional <code>vcpupin</code> + and <code>emulatorpin</code> pinning settings are honored after + the emulator is launched and NUMA constraints considered. This + means that it is expected that other physical CPUs of the host + will be used during this time by the domain, which will be + reflected by the output of <code>virsh cpu-stats</code>. <span class="since">Since 0.9.0</span> </dd> <dt><code>vcpupin</code></dt> -- 2.25.1

2 1

[libvirt-ci PATCH v2] dco: build and publish a container image for DCO check
by Daniel P. Berrangé 09 Apr '20

09 Apr '20

This builds a container image containing the DCO checking script. It is then published at: registry.gitlab.com/libvirt/libvirt-jenkins-ci/check-dco:master from where it can be used in all other project repositories. This avoids having to copy the check-dco.py script into every repo when we want to make changes to it. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- In v2: - Drop -f arg to docker - Drop .py suffix .gitlab-ci.yml | 39 +++++++++++++++++ check-dco/Dockerfile | 6 +++ check-dco/check-dco.py | 99 ++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 144 insertions(+) create mode 100644 .gitlab-ci.yml create mode 100644 check-dco/Dockerfile create mode 100755 check-dco/check-dco.py diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml new file mode 100644 index 0000000..7735bb3 --- /dev/null +++ b/.gitlab-ci.yml @@ -0,0 +1,39 @@ + +stages: + - containers + - postbuild + +.build_container_template: &build_container_definition + image: docker:stable + stage: containers + services: + - docker:dind + before_script: + - docker info + - docker login registry.gitlab.com -u ${CI_REGISTRY_USER} -p ${CI_REGISTRY_PASSWORD} + script: + - docker build --tag ${CI_REGISTRY_IMAGE}/${NAME}:${CI_COMMIT_REF_SLUG} ${NAME} + - docker push ${CI_REGISTRY_IMAGE}/${NAME}:${CI_COMMIT_REF_SLUG} + after_script: + - docker logout + +build-dco: + <<: *build_container_definition + variables: + NAME: check-dco + +# Check that all commits are signed-off for the DCO. Skip +# on master branch and -maint branches, since we only need +# to test developer's personal branches. +check-dco: + # In most projects we'd put this in a "prebuild", but this + # repo is a special case as we need to actually build the + # container first! + stage: postbuild + image: ${CI_REGISTRY_IMAGE}/check-dco:${CI_COMMIT_REF_SLUG} + script: + - /check-dco + only: + - branches + except: + - master diff --git a/check-dco/Dockerfile b/check-dco/Dockerfile new file mode 100644 index 0000000..366f72b --- /dev/null +++ b/check-dco/Dockerfile @@ -0,0 +1,6 @@ +FROM centos:8 + +RUN dnf -y install python3 git && \ + dnf -y clean all + +COPY check-dco.py /check-dco diff --git a/check-dco/check-dco.py b/check-dco/check-dco.py new file mode 100755 index 0000000..f8204ca --- /dev/null +++ b/check-dco/check-dco.py @@ -0,0 +1,99 @@ +#!/usr/bin/env python3 +# +# ci-job.py: validate all commits are signed off +# +# Copyright (C) 2020 Red Hat, Inc. +# +# This library is free software; you can redistribute it and/or +# modify it under the terms of the GNU Lesser General Public +# License as published by the Free Software Foundation; either +# version 2.1 of the License, or (at your option) any later version. +# +# This library is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +# Lesser General Public License for more details. +# +# You should have received a copy of the GNU Lesser General Public +# License along with this library. If not, see +# <http://www.gnu.org/licenses/>. + +import os +import os.path +import sys +import subprocess + +cwd = os.getcwd() +reponame = os.path.basename(cwd) +repourl = "https://gitlab.com/libvirt/%s.git" % reponame + +subprocess.check_call(["git", "remote", "add", "dcocheck", repourl]) +subprocess.check_call(["git", "fetch", "dcocheck", "master"], + stdout=subprocess.DEVNULL, + stderr=subprocess.DEVNULL) + +ancestor = subprocess.check_output(["git", "merge-base", "dcocheck/master", "HEAD"], + universal_newlines=True) + +ancestor = ancestor.strip() + +subprocess.check_call(["git", "remote", "rm", "dcocheck"]) + +errors = False + +print("\nChecking for 'Signed-off-by: NAME <EMAIL>' on all commits since %s...\n" % ancestor) + +log = subprocess.check_output(["git", "log", "--format=%H %s", ancestor + "..."], + universal_newlines=True) + +if log == "": + commits = [] +else: + commits = [[c[0:40], c[41:]] for c in log.strip().split("\n")] + +for sha, subject in commits: + + msg = subprocess.check_output(["git", "show", "-s", sha], + universal_newlines=True) + lines = msg.strip().split("\n") + + print("🔍 %s %s" % (sha, subject)) + sob = False + for line in lines: + if "Signed-off-by:" in line: + sob = True + if "localhost" in line: + print(" ❌ FAIL: bad email in %s" % line) + errors = True + + if not sob: + print(" ❌ FAIL missing Signed-off-by tag") + errors = True + +if errors: + print(""" + +❌ ERROR: One or more commits are missing a valid Signed-off-By tag. + + +This project requires all contributors to assert that their contributions +are provided in compliance with the terms of the Developer's Certificate +of Origin 1.1 (DCO): + + https://developercertificate.org/ + +To indicate acceptance of the DCO every commit must have a tag + + Signed-off-by: REAL NAME <EMAIL> + +This can be achieved by passing the "-s" flag to the "git commit" command. + +To bulk update all commits on current branch "git rebase" can be used: + + git rebase -i master -x 'git commit --amend --no-edit -s' + +""") + + sys.exit(1) + +sys.exit(0) -- 2.24.1

2 1

[libvirt-jenkins-ci PATCH] dco: build and publish a container image for DCO check
by Daniel P. Berrangé 09 Apr '20

09 Apr '20

This builds a container image containing the DCO checking script. It is then published at: registry.gitlab.com/libvirt/libvirt-jenkins-ci/check-dco:master from where it can be used in all other project repositories. This avoids having to copy the check-dco.py script into every repo when we want to make changes to it. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- .gitlab-ci.yml | 39 +++++++++++++++++ check-dco/Dockerfile | 6 +++ check-dco/check-dco.py | 99 ++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 144 insertions(+) create mode 100644 .gitlab-ci.yml create mode 100644 check-dco/Dockerfile create mode 100755 check-dco/check-dco.py diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml new file mode 100644 index 0000000..83b0d64 --- /dev/null +++ b/.gitlab-ci.yml @@ -0,0 +1,39 @@ + +stages: + - containers + - postbuild + +.build_container_template: &build_container_definition + image: docker:stable + stage: containers + services: + - docker:dind + before_script: + - docker info + - docker login registry.gitlab.com -u ${CI_REGISTRY_USER} -p ${CI_REGISTRY_PASSWORD} + script: + - docker build --tag ${CI_REGISTRY_IMAGE}/${NAME}:${CI_COMMIT_REF_SLUG} -f ${NAME}/Dockerfile ${NAME} + - docker push ${CI_REGISTRY_IMAGE}/${NAME}:${CI_COMMIT_REF_SLUG} + after_script: + - docker logout + +build-dco: + <<: *build_container_definition + variables: + NAME: check-dco + +# Check that all commits are signed-off for the DCO. Skip +# on master branch and -maint branches, since we only need +# to test developer's personal branches. +check-dco: + # In most projects we'd put this in a "prebuild", but this + # repo is a special case as we need to actually build the + # container first! + stage: postbuild + image: ${CI_REGISTRY_IMAGE}/check-dco:${CI_COMMIT_REF_SLUG} + script: + - /check-dco.py + only: + - branches + except: + - master diff --git a/check-dco/Dockerfile b/check-dco/Dockerfile new file mode 100644 index 0000000..86cada7 --- /dev/null +++ b/check-dco/Dockerfile @@ -0,0 +1,6 @@ +FROM centos:8 + +RUN dnf -y install python3 git && \ + dnf -y clean all + +COPY check-dco.py check-dco.py diff --git a/check-dco/check-dco.py b/check-dco/check-dco.py new file mode 100755 index 0000000..f8204ca --- /dev/null +++ b/check-dco/check-dco.py @@ -0,0 +1,99 @@ +#!/usr/bin/env python3 +# +# ci-job.py: validate all commits are signed off +# +# Copyright (C) 2020 Red Hat, Inc. +# +# This library is free software; you can redistribute it and/or +# modify it under the terms of the GNU Lesser General Public +# License as published by the Free Software Foundation; either +# version 2.1 of the License, or (at your option) any later version. +# +# This library is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +# Lesser General Public License for more details. +# +# You should have received a copy of the GNU Lesser General Public +# License along with this library. If not, see +# <http://www.gnu.org/licenses/>. + +import os +import os.path +import sys +import subprocess + +cwd = os.getcwd() +reponame = os.path.basename(cwd) +repourl = "https://gitlab.com/libvirt/%s.git" % reponame + +subprocess.check_call(["git", "remote", "add", "dcocheck", repourl]) +subprocess.check_call(["git", "fetch", "dcocheck", "master"], + stdout=subprocess.DEVNULL, + stderr=subprocess.DEVNULL) + +ancestor = subprocess.check_output(["git", "merge-base", "dcocheck/master", "HEAD"], + universal_newlines=True) + +ancestor = ancestor.strip() + +subprocess.check_call(["git", "remote", "rm", "dcocheck"]) + +errors = False + +print("\nChecking for 'Signed-off-by: NAME <EMAIL>' on all commits since %s...\n" % ancestor) + +log = subprocess.check_output(["git", "log", "--format=%H %s", ancestor + "..."], + universal_newlines=True) + +if log == "": + commits = [] +else: + commits = [[c[0:40], c[41:]] for c in log.strip().split("\n")] + +for sha, subject in commits: + + msg = subprocess.check_output(["git", "show", "-s", sha], + universal_newlines=True) + lines = msg.strip().split("\n") + + print("🔍 %s %s" % (sha, subject)) + sob = False + for line in lines: + if "Signed-off-by:" in line: + sob = True + if "localhost" in line: + print(" ❌ FAIL: bad email in %s" % line) + errors = True + + if not sob: + print(" ❌ FAIL missing Signed-off-by tag") + errors = True + +if errors: + print(""" + +❌ ERROR: One or more commits are missing a valid Signed-off-By tag. + + +This project requires all contributors to assert that their contributions +are provided in compliance with the terms of the Developer's Certificate +of Origin 1.1 (DCO): + + https://developercertificate.org/ + +To indicate acceptance of the DCO every commit must have a tag + + Signed-off-by: REAL NAME <EMAIL> + +This can be achieved by passing the "-s" flag to the "git commit" command. + +To bulk update all commits on current branch "git rebase" can be used: + + git rebase -i master -x 'git commit --amend --no-edit -s' + +""") + + sys.exit(1) + +sys.exit(0) -- 2.24.1

2 7

[libvirt PATCH] gitdm: Add missing entries
by Andrea Bolognani 09 Apr '20

09 Apr '20

One new company has contributed to libvirt since the last time the gitdm configuration was updated. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- docs/gitdm/companies/others | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/gitdm/companies/others b/docs/gitdm/companies/others index f459163dd2..37d590a6b9 100644 --- a/docs/gitdm/companies/others +++ b/docs/gitdm/companies/others @@ -16,6 +16,7 @@ citrix.com Citrix cloudwatt.com Cloudwatt cmss.chinamobile.com China Mobile codethink.co.uk Codethink +crudebyte.com Crudebyte cumulusnetworks.com Cumulus Networks dataductus.se Data Ductus datagravity.com DataGravity -- 2.25.1

2 2

[libvirt PATCH 0/6] docs: misc updates for gitlab changes
by Daniel P. Berrangé 09 Apr '20

09 Apr '20

Daniel P. Berrangé (6): docs: point users to gitlab for issue tracking docs: point to gitlab as primary git repo host docs: style git mirror links less prominently docs: update for rename of libvirt-jenkins.ci repository docs: add link to bug tracker against each download docs: replace site name with link type in download table docs/best-practices.rst | 5 +- docs/bugs.html.in | 27 +++--- docs/downloads.html.in | 187 ++++++++++++++++++++++++++++------------ docs/libvirt.css | 9 ++ 4 files changed, 159 insertions(+), 69 deletions(-) -- 2.24.1

2 14

[libvirt PATCH v2] docs: list settings required in creating a new git repo
by Daniel P. Berrangé 09 Apr '20

09 Apr '20

The libvirt project has alot of git repositories, and they must all be configured in the same way, more or less. This page documents the settings changes that I have made in GitLab and GitHub when configuring projects, both as a reminder for myself, and to help anyone else doing the same in future. Also included is info about the repo mirroring on the libvirt.org server. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- In v2: - Apply all Andrea's suggestions docs/docs.html.in | 3 + docs/newreposetup.rst | 137 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 140 insertions(+) create mode 100644 docs/newreposetup.rst diff --git a/docs/docs.html.in b/docs/docs.html.in index 142c79bfa9..6bdf0c32b8 100644 --- a/docs/docs.html.in +++ b/docs/docs.html.in @@ -172,6 +172,9 @@ <dt><a href="testsuites.html">Functional testing</a></dt> <dd>Testing libvirt with <a href="testtck.html">TCK test suite</a> and <a href="testapi.html">Libvirt-test-API</a></dd> + + <dt><a href="newreposetup.html">New repo setup</a></dt> + <dd>Procedure for configuring new git repositories for libvirt</dd> </dl> </div> diff --git a/docs/newreposetup.rst b/docs/newreposetup.rst new file mode 100644 index 0000000000..7da13830c0 --- /dev/null +++ b/docs/newreposetup.rst @@ -0,0 +1,137 @@ +=============================== +Repository infrastructure setup +=============================== + +GitLab Configuration +==================== + +The `GitLab organization <https://gitlab.com/libvirt>`_ hosts the master copy +of all the libvirt Git repositories. + +When creating a new repository the following changes to the defaults are +required under the **Settings** page: + +* **General** + + * **Naming, topics, avatar** + + * *Project avatar*: upload ``docs/logos/logo-square-256.png`` + + * **Visibility, project features, permissions** + + * *Packages*: disabled + + * *Wiki*: disabled + + * *Snippets*: disabled + + * **Merge Requests** + + * *Merge method*: Fast-forward merge + + * *Merge options*: Enable 'delete source branch' option by default + + * *Merge checks*: Pipelines must succeed + + * **Merge request approvals** + + * *Any eligible user*: Num approvals required == 1 + +* **Integrations** + + * **Pipelines emails** + + * *Recipients*: ``libvirt-ci(a)redhat.com`` + +* **Repository** + + * **Push rules** + + * *Do not allow users to remove git tags with git push*: enabled + + * *Commit message*: ``Signed-off-by:`` + + * *Branch name*: ``^(master|v.*-maint)$`` + + * **Mirroring repositories** + + * *Git repository URL*: ``https://libvirtmirror@github.com/libvirt/$repo.git`` + + * *Mirror direction*: push + + * *Password*: see ``/root/libvirt-mirror-github-api-token.txt`` on ``libvirt.org`` + + * **Protected branches** + + * *Branch*: ``master`` + + * *Allowed to merge*: Developers + Maintainers + + * *Allowed to push*: None (or Developers + Maintainers if MRs not used) + + * *Require approval from code owners*: disabled + +GitHub configuration +==================== + +The `GitHub organization <https://github.com/libvirt>`_ hosts read-only +mirrors of all the libvirt Git repositories. + +When creating a new repository the following changes to the defaults are +required under the **Settings** page: + +* **Options** + + * **Features** + + * *Wikis*: disabled + + * *Sponsorships*: disabled + + * *Projects*: disabled + + * **Manage access** + + * Add the ``@committers`` team with the role "Write", which + grants ``libvirtmirror`` access to sync from gitlab. + + * **Integrations** + + * Check for *Repo Lockdown* (should be set automatically for all projects) + +In the master git repository create a file `.github/lockdown.yml` to restrict +use of issue tracker and pull requests. + + +libvirt.org +=========== + +The `libvirt project server <https://libvirt.org>`_ hosts read-only mirrors of +all the libvirt Git repositories in the directory ``/data/git``. + +When creating a new repository the following steps are required: + +* Create repo with + :: + + $ sudo su - + # cd /data/git + # mkdir $repo.git + # cd $repo.git + # git init --bare + # touch export + # touch git-daemon-export-ok + # cd .. + # chown -R gitmirror.gitmirror $repo.git + # chmod -R g+w $repo.git + # find -type d $repo.git | xargs chmod g+s + +* Set the ``description`` and ``config`` files following other repos' example + +* Setup mirroring + :: + + $ sudo su - gitmirror + # ./newrepo.sh /data/git/$repo.git + # cd mirrors + # $HOME/sync-one.sh $repo.git -- 2.24.1

2 1

[PATCH] virsh: cmdUndefine: Properly extract delete-storage-volume-snapshots flag
by Peter Krempa 09 Apr '20

09 Apr '20

Commit 86608f787ee added the above flag as an alias for ambiguous 'delete-snapshots' flag, but forgot to actually change the code that extracts it, thus the new version actually doesn't work. https://bugzilla.redhat.com/show_bug.cgi?id=1821988 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- tools/virsh-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 2dc7c38b55..a203b34996 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -3658,7 +3658,7 @@ cmdUndefine(vshControl *ctl, const vshCmd *cmd) bool checkpoints_metadata = vshCommandOptBool(cmd, "checkpoints-metadata"); bool wipe_storage = vshCommandOptBool(cmd, "wipe-storage"); bool remove_all_storage = vshCommandOptBool(cmd, "remove-all-storage"); - bool delete_snapshots = vshCommandOptBool(cmd, "delete-snapshots"); + bool delete_snapshots = vshCommandOptBool(cmd, "delete-storage-volume-snapshots"); bool nvram = vshCommandOptBool(cmd, "nvram"); bool keep_nvram = vshCommandOptBool(cmd, "keep-nvram"); /* Positive if these items exist. */ -- 2.26.0

2 1

[libvirt-dockerfiles PATCH 0/5] Update after libvirt-ci repo rename
by Andrea Bolognani 09 Apr '20

09 Apr '20

All pushed as trivial. Andrea Bolognani (5): README: Update git URLs to point to GitLab README: Update after libvirt-ci repo rename refresh: Update after libvirt-ci repo rename trigger: Update after libvirt-ci repo rename monitor: Update after libvirt-ci repo rename README.md | 5 ++--- monitor | 2 +- refresh | 4 ++-- trigger | 2 +- 4 files changed, 6 insertions(+), 7 deletions(-) -- 2.25.2

1 5

[PATCH 0/3] libxl: Add support for max_event_channels
by Jim Fehlig 09 Apr '20

09 Apr '20

This series implements support Xen's max_event_channels setting as proposed in this thread https://www.redhat.com/archives/libvir-list/2020-April/msg00376.html See the individual patches for details. Jim Fehlig (3): conf: Add a new xenbus controller option for event channels libxl: Add support for max_event_channels xenconfig: Add support for max_event_channels docs/formatdomain.html.in | 8 +- docs/schemas/domaincommon.rng | 5 ++ src/conf/domain_conf.c | 15 ++++ src/conf/domain_conf.h | 1 + src/libxl/libxl_conf.c | 14 +-- src/libxl/xen_xl.c | 57 ++++++------ .../max-eventchannels-hvm.json | 90 +++++++++++++++++++ .../max-eventchannels-hvm.xml | 37 ++++++++ tests/libxlxml2domconfigtest.c | 2 + tests/xlconfigdata/test-max-eventchannels.cfg | 13 +++ tests/xlconfigdata/test-max-eventchannels.xml | 32 +++++++ tests/xlconfigdata/test-usbctrl.xml | 2 +- tests/xlconfigtest.c | 2 + 13 files changed, 245 insertions(+), 33 deletions(-) create mode 100644 tests/libxlxml2domconfigdata/max-eventchannels-hvm.json create mode 100644 tests/libxlxml2domconfigdata/max-eventchannels-hvm.xml create mode 100644 tests/xlconfigdata/test-max-eventchannels.cfg create mode 100644 tests/xlconfigdata/test-max-eventchannels.xml -- 2.26.0

2 6

[jenkins-ci PATCH 0/3] Update various files after repo rename
by Andrea Bolognani 09 Apr '20

09 Apr '20

All pushed as trivial. Andrea Bolognani (3): guests: Update README after repo rename git-publish: Update config after repo rename github: Update repo-lockdown config after repo rename .github/lockdown.yml | 6 +++--- .gitpublish | 2 +- guests/README.markdown | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) -- 2.25.2

1 3

[PATCH V2 3/5] cpu: Introduce ARM related structs
by Zhenyu Zheng 09 Apr '20

09 Apr '20

Introduce vendor and model struct and related cleanup functions for ARM cpu. Signed-off-by: Zhenyu Zheng <zhengzhenyulixi(a)gmail.com> --- src/cpu/cpu_arm.c | 75 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 75 insertions(+) diff --git a/src/cpu/cpu_arm.c b/src/cpu/cpu_arm.c index ee5802198f..d8f571cae3 100644 --- a/src/cpu/cpu_arm.c +++ b/src/cpu/cpu_arm.c @@ -1,6 +1,7 @@ /* * cpu_arm.c: CPU driver for arm CPUs * + * Copyright (C) 2020 Huawei Technologies Co., Ltd. * Copyright (C) 2013 Red Hat, Inc. * Copyright (C) Canonical Ltd. 2012 * @@ -23,12 +24,16 @@ #include "viralloc.h" #include "cpu.h" +#include "cpu_arm.h" #include "cpu_map.h" +#include "virlog.h" #include "virstring.h" #include "virxml.h" #define VIR_FROM_THIS VIR_FROM_CPU +VIR_LOG_INIT("cpu.cpu_arm"); + static const virArch archs[] = { VIR_ARCH_ARMV6L, VIR_ARCH_ARMV7B, @@ -36,6 +41,21 @@ static const virArch archs[] = { VIR_ARCH_AARCH64, }; +typedef struct _virCPUarmVendor virCPUarmVendor; +typedef virCPUarmVendor *virCPUarmVendorPtr; +struct _virCPUarmVendor { + char *name; + unsigned long value; +}; + +typedef struct _virCPUarmModel virCPUarmModel; +typedef virCPUarmModel *virCPUarmModelPtr; +struct _virCPUarmModel { + char *name; + virCPUarmVendorPtr vendor; + virCPUarmData data; +}; + typedef struct _virCPUarmFeature virCPUarmFeature; typedef virCPUarmFeature *virCPUarmFeaturePtr; struct _virCPUarmFeature { @@ -64,6 +84,10 @@ G_DEFINE_AUTOPTR_CLEANUP_FUNC(virCPUarmFeature, virCPUarmFeatureFree); typedef struct _virCPUarmMap virCPUarmMap; typedef virCPUarmMap *virCPUarmMapPtr; struct _virCPUarmMap { + size_t nvendors; + virCPUarmVendorPtr *vendors; + size_t nmodels; + virCPUarmModelPtr *models; GPtrArray *features; }; @@ -81,12 +105,62 @@ virCPUarmMapNew(void) return map; } +static void +virCPUarmDataClear(virCPUarmData *data) +{ + if (!data) + return; + + VIR_FREE(data->features); +} + +static void +virCPUarmDataFree(virCPUDataPtr cpuData) +{ + if (!cpuData) + return; + + virCPUarmDataClear(&cpuData->data.arm); + VIR_FREE(cpuData); +} + +static void +virCPUarmModelFree(virCPUarmModelPtr model) +{ + if (!model) + return; + + virCPUarmDataClear(&model->data); + g_free(model->name); + g_free(model); +} + +static void +virCPUarmVendorFree(virCPUarmVendorPtr vendor) +{ + if (!vendor) + return; + + g_free(vendor->name); + g_free(vendor); +} + static void virCPUarmMapFree(virCPUarmMapPtr map) { if (!map) return; + size_t i; + + for (i = 0; i < map->nmodels; i++) + virCPUarmModelFree(map->models[i]); + g_free(map->models); + + for (i = 0; i < map->nvendors; i++) + virCPUarmVendorFree(map->vendors[i]); + g_free(map->vendors); + g_ptr_array_free(map->features, TRUE); g_free(map); @@ -259,6 +333,7 @@ struct cpuArchDriver cpuDriverArm = { .compare = virCPUarmCompare, .decode = NULL, .encode = NULL, + .dataFree = virCPUarmDataFree, .baseline = virCPUarmBaseline, .update = virCPUarmUpdate, .validateFeatures = virCPUarmValidateFeatures, -- 2.26.0.windows.1

1 0