- Devel - libvirt List Archives

[libvirt PATCH 0/2] Fix some nodedev documentation
by Jonathon Jongsma 22 May '20

22 May '20

In response to a comment by Daniel Berrange about documentation on my previous patch series, I noticed that the node device xml format documentation appears to be split between two different pages. It seems better to document the schema fully on the formatdomain page and refer to it from the other page. Another small patch fixes a documentation error. Jonathon Jongsma (2): docs: Fix names for PF and VF PCI device capabilities docs: Document full node device xml in formatnode.html.in docs/drvnodedev.html.in | 127 ++++------------------------------------ docs/formatnode.html.in | 74 +++++++++++++++++++++-- 2 files changed, 83 insertions(+), 118 deletions(-) -- 2.21.3

2 5

[libvirt PATCH] docs: drvnodedev: Fix a few closing XML elements in the examples
by Erik Skultety 22 May '20

22 May '20

Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- Pushed as trivial. docs/drvnodedev.html.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/drvnodedev.html.in b/docs/drvnodedev.html.in index 71a8a57b0c..a9c86f9fc7 100644 --- a/docs/drvnodedev.html.in +++ b/docs/drvnodedev.html.in @@ -184,7 +184,7 @@ <address domain='0x0000' bus='0x04' slot='0x00' function='0x0'/> </capability> ... -<device></pre> +</device></pre> <h3><a id="MDEVCap">MDEV capability</a></h3> <p> @@ -300,8 +300,8 @@ <capability type='mdev'> <type id='nvidia-11'/> <iommuGroup number='12'/> - <capability/> -<device/></pre> + </capability> +</device></pre> <p> The support of mediated device's framework in libvirt's node device driver -- 2.25.4

1 0

[libvirt PATCH 0/4] scripts: improve API docs handing of enums
by Daniel P. Berrangé 22 May '20

22 May '20

In attempting to refactor the Go API bindings to be partially auto-generated, I'm encountering missing information in the enum descriptions. The effects of this series are shown in this diff: --- libvirt-api.xml 2020-05-19 12:47:22.003489289 +0100 +++ docs/libvirt-api.xml 2020-05-19 12:47:27.156476186 +0100 @@ -1,4 +1,4 @@ -<?xml version=3D"1.0" encoding=3D"ISO-8859-1"?> +<?xml version=3D"1.0" encoding=3D"UTF-8"?> <api name=3D'libvirt'> <files> <file name=3D'libvirt-domain-checkpoint'> @@ -2089,13 +2089,13 @@ </file> </files> <symbols> - <macro name=3D'LIBVIR_CHECK_VERSION' file=3D'libvirt-common'> + <macro name=3D'LIBVIR_CHECK_VERSION' file=3D'libvirt-common' params=3D'm= ajor,minor,micro' raw=3D'((major) * 1000000 + (minor) * 1000 + (micro) <=3D L= IBVIR_VERSION_NUMBER)'> <info><![CDATA[Macro for developers to easily check what version of th= e library their code is compiling against. e.g. #if LIBVIR_CHECK_VERSION(1,1,= 3) // some code that only works in 1.1.3 and newer #endif]]></info> <arg name=3D'major' info=3D'major component of the version number'/> <arg name=3D'minor' info=3D'minor component of the version number'/> <arg name=3D'micro' info=3D'micro component of the version number'/> </macro> - <macro name=3D'LIBVIR_VERSION_NUMBER' file=3D'libvirt-common'> + <macro name=3D'LIBVIR_VERSION_NUMBER' file=3D'libvirt-common' raw=3D'600= 4000'> <info><![CDATA[Macro providing the version of the library as version *= 1,000,000 + minor * 1000 + micro]]></info> </macro> <macro name=3D'VIR_CONNECT_IDENTITY_GROUP_NAME' file=3D'libvirt-host' st= ring=3D'group-name'> @@ -2125,25 +2125,25 @@ <macro name=3D'VIR_CONNECT_IDENTITY_X509_DISTINGUISHED_NAME' file=3D'lib= virt-host' string=3D'x509-distinguished-name'> <info><![CDATA[The TLS x509 certificate distinguished named as VIR_TYP= ED_PARAM_STRING]]></info> </macro> - <macro name=3D'VIR_COPY_CPUMAP' file=3D'libvirt-domain'> + <macro name=3D'VIR_COPY_CPUMAP' file=3D'libvirt-domain' params=3D'cpumap= s,maplen,vcpu,cpumap' raw=3D'memcpy(cpumap, VIR_GET_CPUMAP(cpumaps, maplen, v= cpu), maplen)'> <info><![CDATA[This macro is to be used in conjunction with virDomainG= etVcpus() and virDomainPinVcpu() APIs. VIR_COPY_CPUMAP macro extracts the cpu= map of the specified vcpu from cpumaps array and copies it into cpumap to be = used later by virDomainPinVcpu() API.]]></info> <arg name=3D'cpumaps' info=3D'pointer to an array of cpumap (in 8-bit = bytes) (IN)'/> <arg name=3D'maplen' info=3D'the length (in bytes) of one cpumap'/> <arg name=3D'vcpu' info=3D'the virtual CPU number'/> <arg name=3D'cpumap' info=3D'pointer to a cpumap (in 8-bit bytes) (OUT= ) This cpumap must be previously allocated by the caller (ie: malloc(maplen))= '/> </macro> - <macro name=3D'VIR_CPU_MAPLEN' file=3D'libvirt-domain'> + <macro name=3D'VIR_CPU_MAPLEN' file=3D'libvirt-domain' params=3D'cpu' ra= w=3D''> <info><![CDATA[This macro is to be used in conjunction with virDomainP= inVcpu() API. It returns the length (in bytes) required to store the complete= CPU map between a single virtual & all physical CPUs of a domain.]]></info> <arg name=3D'cpu' info=3D'number of physical CPUs'/> </macro> - <macro name=3D'VIR_CPU_USABLE' file=3D'libvirt-domain'> + <macro name=3D'VIR_CPU_USABLE' file=3D'libvirt-domain' params=3D'cpumaps= ,maplen,vcpu,cpu' raw=3D'VIR_CPU_USED(VIR_GET_CPUMAP(cpumaps, maplen, vcpu), = cpu)'> <info><![CDATA[This macro is to be used in conjunction with virDomainG= etVcpus() API. VIR_CPU_USABLE macro returns a non-zero value (true) if the cp= u is usable by the vcpu, and 0 otherwise.]]></info> <arg name=3D'cpumaps' info=3D'pointer to an array of cpumap (in 8-bit = bytes) (IN)'/> <arg name=3D'maplen' info=3D'the length (in bytes) of one cpumap'/> <arg name=3D'vcpu' info=3D'the virtual CPU number'/> <arg name=3D'cpu' info=3D'the physical CPU number'/> </macro> - <macro name=3D'VIR_CPU_USED' file=3D'libvirt-domain'> + <macro name=3D'VIR_CPU_USED' file=3D'libvirt-domain' params=3D'cpumap,cp= u' raw=3D'((cpumap)[(cpu) / 8] & (1 << ((cpu) % 8)))'> <info><![CDATA[This macro can be used in conjunction with virNodeGetCP= UMap() API. It returns non-zero if the bit of the related CPU is set.]]></inf= o> <arg name=3D'cpumap' info=3D'pointer to a bit map of real CPUs (in 8-b= it bytes) (IN)'/> <arg name=3D'cpu' info=3D'the physical CPU number'/> @@ -2184,7 +2184,7 @@ <macro name=3D'VIR_DOMAIN_BLKIO_DEVICE_WRITE_IOPS' file=3D'libvirt-domai= n' string=3D'device_write_iops_sec'> <info><![CDATA[Macro for the blkio tunable throttle.write_iops_device:= it represents the number of writing the block device per second, as a string= . The string is parsed as a series of /path/to/device, write_iops elements, s= eparated by ','.]]></info> </macro> - <macro name=3D'VIR_DOMAIN_BLKIO_FIELD_LENGTH' file=3D'libvirt-domain'> + <macro name=3D'VIR_DOMAIN_BLKIO_FIELD_LENGTH' file=3D'libvirt-domain' ra= w=3D'VIR_TYPED_PARAM_FIELD_LENGTH'> <info><![CDATA[Macro providing the field length of virBlkioParameter. = Provided for backwards compatibility; VIR_TYPED_PARAM_FIELD_LENGTH is the pr= eferred value since 0.9.2.]]></info> </macro> <macro name=3D'VIR_DOMAIN_BLKIO_WEIGHT' file=3D'libvirt-domain' string= =3D'weight'> @@ -2262,7 +2262,7 @@ <macro name=3D'VIR_DOMAIN_BLOCK_STATS_ERRS' file=3D'libvirt-domain' stri= ng=3D'errs'> <info><![CDATA[In Xen this returns the mysterious 'oo_req', as an llon= g.]]></info> </macro> - <macro name=3D'VIR_DOMAIN_BLOCK_STATS_FIELD_LENGTH' file=3D'libvirt-doma= in'> + <macro name=3D'VIR_DOMAIN_BLOCK_STATS_FIELD_LENGTH' file=3D'libvirt-doma= in' raw=3D'VIR_TYPED_PARAM_FIELD_LENGTH'> <info><![CDATA[Macro providing the field length of parameter names whe= n using virDomainBlockStatsFlags().]]></info> </macro> <macro name=3D'VIR_DOMAIN_BLOCK_STATS_FLUSH_REQ' file=3D'libvirt-domain'= string=3D'flush_operations'> @@ -2301,7 +2301,7 @@ <macro name=3D'VIR_DOMAIN_CPU_STATS_VCPUTIME' file=3D'libvirt-domain' st= ring=3D'vcpu_time'> <info><![CDATA[vcpu usage in nanoseconds (cpu_time excluding hyperviso= r time), as a ullong]]></info> </macro> - <macro name=3D'VIR_DOMAIN_EVENT_CALLBACK' file=3D'libvirt-domain'> + <macro name=3D'VIR_DOMAIN_EVENT_CALLBACK' file=3D'libvirt-domain' params= =3D'cb' raw=3D''> <info><![CDATA[Used to cast the event specific callback into the gener= ic one for use for virConnectDomainEventRegisterAny()]]></info> </macro> <macro name=3D'VIR_DOMAIN_IOTHREAD_POLL_GROW' file=3D'libvirt-domain' st= ring=3D'poll_grow'> @@ -2421,7 +2421,7 @@ <macro name=3D'VIR_DOMAIN_LAUNCH_SECURITY_SEV_MEASUREMENT' file=3D'libvi= rt-domain' string=3D'sev-measurement'> <info><![CDATA[Macro represents the launch measurement of the SEV gues= t, as VIR_TYPED_PARAM_STRING.]]></info> </macro> - <macro name=3D'VIR_DOMAIN_MEMORY_FIELD_LENGTH' file=3D'libvirt-domain'> + <macro name=3D'VIR_DOMAIN_MEMORY_FIELD_LENGTH' file=3D'libvirt-domain' r= aw=3D'VIR_TYPED_PARAM_FIELD_LENGTH'> <info><![CDATA[Macro providing the field length of virMemoryParameter.= Provided for backwards compatibility; VIR_TYPED_PARAM_FIELD_LENGTH is the p= referred value since 0.9.2.]]></info> </macro> <macro name=3D'VIR_DOMAIN_MEMORY_HARD_LIMIT' file=3D'libvirt-domain' str= ing=3D'hard_limit'> @@ -2430,7 +2430,7 @@ <macro name=3D'VIR_DOMAIN_MEMORY_MIN_GUARANTEE' file=3D'libvirt-domain' = string=3D'min_guarantee'> <info><![CDATA[Macro for the memory tunable min_guarantee: it represen= ts the minimum memory guaranteed to be reserved for the guest, as a ullong.]]= ></info> </macro> - <macro name=3D'VIR_DOMAIN_MEMORY_PARAM_UNLIMITED' file=3D'libvirt-domain= '> + <macro name=3D'VIR_DOMAIN_MEMORY_PARAM_UNLIMITED' file=3D'libvirt-domain= ' raw=3D'9007199254740991LL /* =3D INT64_MAX >> 10 */'> <info><![CDATA[Macro providing the virMemoryParameter value that indic= ates "unlimited"]]></info> </macro> <macro name=3D'VIR_DOMAIN_MEMORY_SOFT_LIMIT' file=3D'libvirt-domain' str= ing=3D'soft_limit'> @@ -2487,10 +2487,10 @@ <macro name=3D'VIR_DOMAIN_SCHEDULER_WEIGHT' file=3D'libvirt-domain' stri= ng=3D'weight'> <info><![CDATA[Macro represents the relative weight, when using the c= redit scheduler, as a uint.]]></info> </macro> - <macro name=3D'VIR_DOMAIN_SCHED_FIELD_LENGTH' file=3D'libvirt-domain'> + <macro name=3D'VIR_DOMAIN_SCHED_FIELD_LENGTH' file=3D'libvirt-domain' ra= w=3D'VIR_TYPED_PARAM_FIELD_LENGTH'> <info><![CDATA[Macro providing the field length of virSchedParameter. = Provided for backwards compatibility; VIR_TYPED_PARAM_FIELD_LENGTH is the pr= eferred value since 0.9.2.]]></info> </macro> - <macro name=3D'VIR_DOMAIN_SEND_KEY_MAX_KEYS' file=3D'libvirt-domain'> + <macro name=3D'VIR_DOMAIN_SEND_KEY_MAX_KEYS' file=3D'libvirt-domain' raw= =3D'16'> <info><![CDATA[Maximum number of keycodes that can be sent in one virD= omainSendKey() call.]]></info> </macro> <macro name=3D'VIR_DOMAIN_TUNABLE_BLKDEV_DISK' file=3D'libvirt-domain' s= tring=3D'blkdeviotune.disk'> @@ -2592,13 +2592,13 @@ <macro name=3D'VIR_DOMAIN_TUNABLE_CPU_VCPU_QUOTA' file=3D'libvirt-domain= ' string=3D'cputune.vcpu_quota'> <info><![CDATA[Macro represents the maximum bandwidth to be used withi= n a period for vcpus only, when using the posix scheduler, as VIR_TYPED_PARAM= _LLONG.]]></info> </macro> - <macro name=3D'VIR_GET_CPUMAP' file=3D'libvirt-domain'> + <macro name=3D'VIR_GET_CPUMAP' file=3D'libvirt-domain' params=3D'cpumaps= ,maplen,vcpu' raw=3D'(&((cpumaps)[(vcpu) * (maplen)]))'> <info><![CDATA[This macro is to be used in conjunction with virDomainG= etVcpus() and virDomainPinVcpu() APIs. VIR_GET_CPUMAP macro returns a pointer= to the cpumap of the specified vcpu from cpumaps array.]]></info> <arg name=3D'cpumaps' info=3D'pointer to an array of cpumap (in 8-bit = bytes) (IN)'/> <arg name=3D'maplen' info=3D'the length (in bytes) of one cpumap'/> <arg name=3D'vcpu' info=3D'the virtual CPU number'/> </macro> - <macro name=3D'VIR_KEYCODE_SET_RFB' file=3D'libvirt-domain'> + <macro name=3D'VIR_KEYCODE_SET_RFB' file=3D'libvirt-domain' raw=3D'VIR_K= EYCODE_SET_QNUM'> <info><![CDATA[Compatibility alias for VIR_KEYCODE_SET_QNUM, which rep= laced it since 4.2.0.]]></info> </macro> <macro name=3D'VIR_MIGRATE_PARAM_AUTO_CONVERGE_INCREMENT' file=3D'libvir= t-domain' string=3D'auto_converge.increment'> @@ -2658,7 +2658,7 @@ <macro name=3D'VIR_MIGRATE_PARAM_URI' file=3D'libvirt-domain' string=3D'= migrate_uri'> <info><![CDATA[virDomainMigrate* params field: URI to use for initiati= ng domain migration as VIR_TYPED_PARAM_STRING. It takes a hypervisor specific= format. The uri_transports element of the hypervisor capabilities XML includ= es details of the supported URI schemes. When omitted libvirt will auto-gener= ate suitable default URI. It is typically only necessary to specify this URI = if the destination host has multiple interfaces and a specific interface is r= equired to transmit migration data. This field may not be used when VIR_MIGR= ATE_TUNNELLED flag is set.]]></info> </macro> - <macro name=3D'VIR_NETWORK_EVENT_CALLBACK' file=3D'libvirt-network'> + <macro name=3D'VIR_NETWORK_EVENT_CALLBACK' file=3D'libvirt-network' para= ms=3D'cb' raw=3D''> <info><![CDATA[Used to cast the event specific callback into the gener= ic one for use for virConnectNetworkEventRegisterAny()]]></info> </macro> <macro name=3D'VIR_NETWORK_PORT_BANDWIDTH_IN_AVERAGE' file=3D'libvirt-ne= twork' string=3D'inbound.average'> @@ -2682,11 +2682,11 @@ <macro name=3D'VIR_NETWORK_PORT_BANDWIDTH_OUT_PEAK' file=3D'libvirt-netw= ork' string=3D'outbound.peak'> <info><![CDATA[Macro represents the outbound peak of NIC bandwidth, as= a uint.]]></info> </macro> - <macro name=3D'VIR_NODEINFO_MAXCPUS' file=3D'libvirt-host'> + <macro name=3D'VIR_NODEINFO_MAXCPUS' file=3D'libvirt-host' params=3D'nod= einfo' raw=3D''> <info><![CDATA[This macro is to calculate the total number of CPUs sup= ported but not necessary active in the host.]]></info> <arg name=3D'nodeinfo' info=3D'virNodeInfo instance'/> </macro> - <macro name=3D'VIR_NODE_CPU_STATS_FIELD_LENGTH' file=3D'libvirt-host'> + <macro name=3D'VIR_NODE_CPU_STATS_FIELD_LENGTH' file=3D'libvirt-host' ra= w=3D'80'> <info><![CDATA[Macro providing the field length of virNodeCPUStats]]><= /info> </macro> <macro name=3D'VIR_NODE_CPU_STATS_IDLE' file=3D'libvirt-host' string=3D'= idle'> @@ -2707,7 +2707,7 @@ <macro name=3D'VIR_NODE_CPU_STATS_UTILIZATION' file=3D'libvirt-host' str= ing=3D'utilization'> <info><![CDATA[The CPU utilization of a node. The usage value is in pe= rcent and 100% represents all CPUs of the node.]]></info> </macro> - <macro name=3D'VIR_NODE_DEVICE_EVENT_CALLBACK' file=3D'libvirt-nodedev'> + <macro name=3D'VIR_NODE_DEVICE_EVENT_CALLBACK' file=3D'libvirt-nodedev' = params=3D'cb' raw=3D'((virConnectNodeDeviceEventGenericCallback)(cb))'> <info><![CDATA[Used to cast the event specific callback into the gener= ic one for use for virConnectNodeDeviceEventRegisterAny()]]></info> </macro> <macro name=3D'VIR_NODE_MEMORY_SHARED_FULL_SCANS' file=3D'libvirt-host' = string=3D'shm_full_scans'> @@ -2740,7 +2740,7 @@ <macro name=3D'VIR_NODE_MEMORY_STATS_CACHED' file=3D'libvirt-host' strin= g=3D'cached'> <info><![CDATA[Macro for the cached memory: On Linux, it is only retur= ned in case of VIR_NODE_MEMORY_STATS_ALL_CELLS.]]></info> </macro> - <macro name=3D'VIR_NODE_MEMORY_STATS_FIELD_LENGTH' file=3D'libvirt-host'> + <macro name=3D'VIR_NODE_MEMORY_STATS_FIELD_LENGTH' file=3D'libvirt-host'= raw=3D'80'> <info><![CDATA[Macro providing the field length of virNodeMemoryStats]= ]></info> </macro> <macro name=3D'VIR_NODE_MEMORY_STATS_FREE' file=3D'libvirt-host' string= =3D'free'> @@ -2827,45 +2827,45 @@ <macro name=3D'VIR_PERF_PARAM_TASK_CLOCK' file=3D'libvirt-domain' string= =3D'task_clock'> <info><![CDATA[Macro for typed parameter name that represents task_clo= ck perf event which can be used to measure the count of task clock time by ap= plications running on the platform. It corresponds to the "perf.task_clock" f= ield in the *Stats APIs.]]></info> </macro> - <macro name=3D'VIR_SECRET_EVENT_CALLBACK' file=3D'libvirt-secret'> + <macro name=3D'VIR_SECRET_EVENT_CALLBACK' file=3D'libvirt-secret' params= =3D'cb' raw=3D'((virConnectSecretEventGenericCallback)(cb))'> <info><![CDATA[Used to cast the event specific callback into the gener= ic one for use for virConnectSecretEventRegisterAny()]]></info> </macro> - <macro name=3D'VIR_SECURITY_DOI_BUFLEN' file=3D'libvirt-host'> + <macro name=3D'VIR_SECURITY_DOI_BUFLEN' file=3D'libvirt-host' raw=3D'(25= 6 + 1)'> <info><![CDATA[Macro providing the maximum length of the virSecurityMo= del doi string.]]></info> </macro> - <macro name=3D'VIR_SECURITY_LABEL_BUFLEN' file=3D'libvirt-host'> + <macro name=3D'VIR_SECURITY_LABEL_BUFLEN' file=3D'libvirt-host' raw=3D'(= 4096 + 1)'> <info><![CDATA[Macro providing the maximum length of the virSecurityLa= bel label string. Note that this value is based on that used by Labeled NFS.]= ]></info> </macro> - <macro name=3D'VIR_SECURITY_MODEL_BUFLEN' file=3D'libvirt-host'> + <macro name=3D'VIR_SECURITY_MODEL_BUFLEN' file=3D'libvirt-host' raw=3D'(= 256 + 1)'> <info><![CDATA[Macro providing the maximum length of the virSecurityMo= del model string.]]></info> </macro> - <macro name=3D'VIR_STORAGE_POOL_EVENT_CALLBACK' file=3D'libvirt-storage'> + <macro name=3D'VIR_STORAGE_POOL_EVENT_CALLBACK' file=3D'libvirt-storage'= params=3D'cb' raw=3D'((virConnectStoragePoolEventGenericCallback)(cb))'> <info><![CDATA[Used to cast the event specific callback into the gener= ic one for use for virConnectStoragePoolEventRegisterAny()]]></info> </macro> - <macro name=3D'VIR_TYPED_PARAM_FIELD_LENGTH' file=3D'libvirt-common'> + <macro name=3D'VIR_TYPED_PARAM_FIELD_LENGTH' file=3D'libvirt-common' raw= =3D'80'> <info><![CDATA[Macro providing the field length of virTypedParameter n= ame]]></info> </macro> - <macro name=3D'VIR_UNUSE_CPU' file=3D'libvirt-domain'> + <macro name=3D'VIR_UNUSE_CPU' file=3D'libvirt-domain' params=3D'cpumap,c= pu' raw=3D'((cpumap)[(cpu) / 8] &=3D ~(1 << ((cpu) % 8)))'> <info><![CDATA[This macro is to be used in conjunction with virDomainP= inVcpu() API. It resets the bit (CPU not usable) of the related cpu in cpumap= .]]></info> <arg name=3D'cpumap' info=3D'pointer to a bit map of real CPUs (in 8-b= it bytes) (IN/OUT)'/> <arg name=3D'cpu' info=3D'the physical CPU number'/> </macro> - <macro name=3D'VIR_USE_CPU' file=3D'libvirt-domain'> + <macro name=3D'VIR_USE_CPU' file=3D'libvirt-domain' params=3D'cpumap,cpu= ' raw=3D'((cpumap)[(cpu) / 8] |=3D (1 << ((cpu) % 8)))'> <info><![CDATA[This macro is to be used in conjunction with virDomainP= inVcpu() API. It sets the bit (CPU usable) of the related cpu in cpumap.]]></= info> <arg name=3D'cpumap' info=3D'pointer to a bit map of real CPUs (in 8-b= it bytes) (IN/OUT)'/> <arg name=3D'cpu' info=3D'the physical CPU number'/> </macro> - <macro name=3D'VIR_UUID_BUFLEN' file=3D'libvirt-host'> + <macro name=3D'VIR_UUID_BUFLEN' file=3D'libvirt-host' raw=3D'(16)'> <info><![CDATA[This macro provides the length of the buffer required f= or virDomainGetUUID()]]></info> </macro> - <macro name=3D'VIR_UUID_STRING_BUFLEN' file=3D'libvirt-host'> + <macro name=3D'VIR_UUID_STRING_BUFLEN' file=3D'libvirt-host' raw=3D'(36+= 1)'> <info><![CDATA[This macro provides the length of the buffer required f= or virDomainGetUUIDString()]]></info> </macro> - <macro name=3D'_virBlkioParameter' file=3D'libvirt-domain'> + <macro name=3D'_virBlkioParameter' file=3D'libvirt-domain' raw=3D'_virTy= pedParameter'> </macro> - <macro name=3D'_virMemoryParameter' file=3D'libvirt-domain'> + <macro name=3D'_virMemoryParameter' file=3D'libvirt-domain' raw=3D'_virT= ypedParameter'> </macro> - <macro name=3D'_virSchedParameter' file=3D'libvirt-domain'> + <macro name=3D'_virSchedParameter' file=3D'libvirt-domain' raw=3D'_virTy= pedParameter'> </macro> <enum name=3D'VIR_CONNECT_BASELINE_CPU_EXPAND_FEATURES' file=3D'libvirt-= host' value=3D'1' value_hex=3D'0x1' value_bitshift=3D'0' type=3D'virConnectBa= selineCPUFlags' info=3D'show all features'/> <enum name=3D'VIR_CONNECT_BASELINE_CPU_MIGRATABLE' file=3D'libvirt-host'= value=3D'2' value_hex=3D'0x2' value_bitshift=3D'1' type=3D'virConnectBaselin= eCPUFlags' info=3D'filter out non-migratable features'/> Daniel P. Berrang=C3=A9 (4): scripts: use UTF-8 for API XML files scripts: fix tokenizing of enum parameters in API builder scripts: emit enum parameters in API build description scripts: emit raw enum value in API build description scripts/apibuild.py | 47 ++++++++++++++++++++++++++++++++++++++------- 1 file changed, 40 insertions(+), 7 deletions(-) --=20 2.26.2

2 9

[PATCH] testCompareXMLToArgvValidateSchema: Construct @vm from scratch
by Michal Privoznik 22 May '20

22 May '20

Currently, the @vm is passed in as an argument and testCompareXMLToArgvCreateArgs() is called over it which means under the hood qemuProcessPrepareDomain() is called. But at the point where ValidateSchema() is called, the domain object is already 'prepared', i.e. all device aliases are assigned and so on. But our code is not prepared to 'prepare' a domain twice - it simply overwrites all the pointers leading to a memory leak. Fortunately, this is only the problem of this test. Resolve this by constructing the domain object from scratch. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tests/qemuxml2argvtest.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 4f613e8f1a..3103cac884 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -482,16 +482,17 @@ testCompareXMLToArgvCreateArgs(virQEMUDriverPtr drv, static int testCompareXMLToArgvValidateSchema(virQEMUDriverPtr drv, - virDomainObjPtr vm, const char *migrateURI, struct testQemuInfo *info, unsigned int flags) { VIR_AUTOSTRINGLIST args = NULL; + g_autoptr(virDomainObj) vm = NULL; size_t nargs = 0; size_t i; g_autoptr(virHashTable) schema = NULL; g_autoptr(virCommand) cmd = NULL; + unsigned int parseFlags = info->parseFlags; if (info->schemafile) schema = testQEMUSchemaLoad(info->schemafile); @@ -504,6 +505,15 @@ testCompareXMLToArgvValidateSchema(virQEMUDriverPtr drv, if (!schema) return 0; + if (!(vm = virDomainObjNew(driver.xmlopt))) + return -1; + + parseFlags |= VIR_DOMAIN_DEF_PARSE_INACTIVE; + if (!(vm->def = virDomainDefParseFile(info->infile, + driver.xmlopt, + NULL, parseFlags))) + return -1; + if (!(cmd = testCompareXMLToArgvCreateArgs(drv, vm, migrateURI, info, flags, true))) return -1; @@ -651,7 +661,7 @@ testCompareXMLToArgv(const void *data) goto cleanup; } - if (testCompareXMLToArgvValidateSchema(&driver, vm, migrateURI, info, flags) < 0) + if (testCompareXMLToArgvValidateSchema(&driver, migrateURI, info, flags) < 0) goto cleanup; if (!(actualargv = virCommandToString(cmd, false))) -- 2.26.2

2 1

[libvirt PATCH 0/6] src: make virObject inherit from GObject
by Daniel P. Berrangé 22 May '20

22 May '20

This series attempts to make the conversion from virObject to GObject less dangerous, by making the former inherit from the latter. The way we setup inheritance with virObject means we have to make some moderately gross games with registering virClass instances as GObjectClass instances. Empirically it seems to work and pass the basic TCK test suite. Ultimately virObject should be deleted entirely, so the gross bits shouldn't live too long. Daniel P. Berrangé (6): qemu: stop checking virObjectUnref return value src: make virObjectUnref return void test: allocate numa cells separately from driver src: don't include ref count in debug messages / probes src: don't use VIR_FREE on an object allocation src: make virObject inherit from GObject src/admin/libvirt-admin.c | 7 +- src/datatypes.c | 26 ++++ src/datatypes.h | 6 + src/interface/interface_backend_netcf.c | 7 +- src/libvirt-domain-checkpoint.c | 3 +- src/libvirt-domain-snapshot.c | 3 +- src/libvirt-domain.c | 2 +- src/libvirt-host.c | 2 +- src/libvirt-interface.c | 2 +- src/libvirt-network.c | 6 +- src/libvirt-nodedev.c | 2 +- src/libvirt-nwfilter.c | 6 +- src/libvirt-secret.c | 3 +- src/libvirt-storage.c | 4 +- src/libvirt-stream.c | 3 +- src/libvirt.c | 4 +- src/libvirt_qemu_probes.d | 8 +- src/qemu/qemu_domain.c | 4 +- src/qemu/qemu_monitor.c | 21 +++- src/qemu/qemu_monitor.h | 3 + src/qemu/qemu_process.c | 30 ++--- src/rpc/virnettlscontext.c | 5 +- src/test/test_driver.c | 15 ++- src/util/virfdstream.c | 6 +- src/util/virobject.c | 150 ++++++++++++++---------- src/util/virobject.h | 27 ++--- src/vbox/vbox_common.c | 10 +- 27 files changed, 210 insertions(+), 155 deletions(-) -- 2.24.1

3 9

[PATCH v2 00/13] audio: deprecate -soundhw
by Gerd Hoffmann 21 May '20

21 May '20

v2: - use g_assert_not_reached() for stubs. - add deprecation notice. Gerd Hoffmann (13): stubs: add isa_create_simple stubs: add pci_create_simple audio: add deprecated_register_soundhw audio: deprecate -soundhw ac97 audio: deprecate -soundhw es1370 audio: deprecate -soundhw adlib audio: deprecate -soundhw cs4231a audio: deprecate -soundhw gus audio: deprecate -soundhw sb16 audio: deprecate -soundhw hda audio: deprecate -soundhw pcspk audio: add soundhw deprecation notice [RFC] audio: try use onboard audiodev for pcspk include/hw/audio/soundhw.h | 2 ++ hw/audio/ac97.c | 9 ++------- hw/audio/adlib.c | 8 +------- hw/audio/cs4231a.c | 8 +------- hw/audio/es1370.c | 9 ++------- hw/audio/gus.c | 8 +------- hw/audio/intel-hda.c | 3 +++ hw/audio/pcspk.c | 27 ++++++++++++++++++++++++--- hw/audio/sb16.c | 9 ++------- hw/audio/soundhw.c | 24 +++++++++++++++++++++++- qdev-monitor.c | 2 ++ stubs/isa-bus.c | 7 +++++++ stubs/pci-bus.c | 7 +++++++ docs/system/deprecated.rst | 9 +++++++++ stubs/Makefile.objs | 2 ++ 15 files changed, 88 insertions(+), 46 deletions(-) create mode 100644 stubs/isa-bus.c create mode 100644 stubs/pci-bus.c -- 2.18.4

5 23

[PATCH v4 00/10] Introducing TPM Proxy device support for PPC64
by Daniel Henrique Barboza 21 May '20

21 May '20

changes in v4: - patch 1: added missing <code> tags - comma-escaped the path string in qemu_command.c (patch 8) - moved validations not-XML-parsing related from domain_conf.c to qemu_validate.c - new patches 3 and 4: cleanups - patch 5 (former 3): changed the approach to use a def->tpms array instead of def->tpmproxy pointer - new patch 6: qemu_validate changes to not clog patch 5 with changes - added Jano's and Stefan's r-b when applicable v3 link: https://www.redhat.com/archives/libvir-list/2020-May/msg00642.html v2 link: https://www.redhat.com/archives/libvir-list/2020-May/msg00604.html v1 link: https://www.redhat.com/archives/libvir-list/2020-May/msg00604.html Daniel Henrique Barboza (10): docs: documentation and schema for the new TPM Proxy model qemu: Extend QEMU capabilities with 'spapr-tpm-proxy' qemu_extdevice.c: remove unneeded 'ret' variable qemu_tpm, security, tests: change 'switch' clauses for 'if' conf, qemu, security, tests: introducing 'def->tpms' array qemu_validate.c: add validation for TPM Proxy model tests: add XML schema tests for the TPM Proxy device qemu: build command line for the TPM Proxy device tests/qemuxml2argvtest.c: add TPM Proxy command line tests docs/news.xml: update for the new TPM Proxy device docs/formatdomain.html.in | 19 ++++- docs/news.xml | 17 +++++ docs/schemas/domaincommon.rng | 1 + src/conf/domain_audit.c | 4 +- src/conf/domain_conf.c | 72 +++++++++++++----- src/conf/domain_conf.h | 6 +- src/qemu/qemu_alias.c | 9 ++- src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_cgroup.c | 10 ++- src/qemu/qemu_command.c | 59 +++++++++++--- src/qemu/qemu_domain.c | 31 +++++--- src/qemu/qemu_domain_address.c | 11 ++- src/qemu/qemu_extdevice.c | 24 +++--- src/qemu/qemu_tpm.c | 76 +++++++++---------- src/qemu/qemu_validate.c | 19 +++++ src/security/security_dac.c | 8 +- src/security/security_selinux.c | 44 +++++------ src/security/virt-aa-helper.c | 14 ++-- .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 + .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 + tests/qemuxml2argvdata/ppc64-tpm-double.xml | 34 +++++++++ .../ppc64-tpmproxy-double.xml | 38 ++++++++++ .../ppc64-tpmproxy-single.ppc64-latest.args | 34 +++++++++ .../ppc64-tpmproxy-single.xml | 33 ++++++++ .../ppc64-tpmproxy-with-tpm.ppc64-latest.args | 37 +++++++++ .../ppc64-tpmproxy-with-tpm.xml | 36 +++++++++ tests/qemuxml2argvtest.c | 33 +++++--- .../ppc64-tpmproxy-single.ppc64-latest.xml | 42 ++++++++++ .../ppc64-tpmproxy-with-tpm.ppc64-latest.xml | 46 +++++++++++ tests/qemuxml2xmltest.c | 2 + 31 files changed, 616 insertions(+), 152 deletions(-) create mode 100644 tests/qemuxml2argvdata/ppc64-tpm-double.xml create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-double.xml create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-single.ppc64-latest.args create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-single.xml create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-with-tpm.ppc64-latest.args create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-with-tpm.xml create mode 100644 tests/qemuxml2xmloutdata/ppc64-tpmproxy-single.ppc64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/ppc64-tpmproxy-with-tpm.ppc64-latest.xml -- 2.26.2

2 12

[PATCH v2 0/2] introduces qemu_job_wait_time option
by MIKI Nobuhiro 21 May '20

21 May '20

This series introduces qemu_job_wait_time option to configuration file. MIKI Nobuhiro (2): conf: Add qemu_job_wait_time option news: add support for qemu_job_wait_time configuration docs/news.xml | 9 +++++++++ src/qemu/libvirtd_qemu.aug | 1 + src/qemu/qemu.conf | 3 +++ src/qemu/qemu_conf.c | 3 +++ src/qemu/qemu_conf.h | 2 ++ src/qemu/qemu_domain.c | 7 ++----- src/qemu/test_libvirtd_qemu.aug.in | 1 + 7 files changed, 21 insertions(+), 5 deletions(-) -- 1.8.3.1

2 4

[PATCH v3 00/21] PCI Multifunction hotplug/unplug support
by Daniel Henrique Barboza 21 May '20

21 May '20

This is the v3 of the same support sent to the mailing list a few months ago. No major changes were made. Refer to the v2 cover letter for a general view of the design used across the patches. Changes in v3: - rebase to master at d265171b5784 - minor typo fixes link to v2: https://www.redhat.com/archives/libvir-list/2020-January/msg01377.html link to v1: https://www.redhat.com/archives/libvir-list/2020-January/msg01377.html Daniel Henrique Barboza (4): utils: PCI multifunction detection helpers qemu_hotplug.c: tune unplugTimeout for multifunction detach qemu_hotplug: do not hotplug/hotunplug 'unassigned' hostdevs qemu_hotplug.c: use enhanced multifunction unplug if available Shivaprasad G Bhat (17): qemu: address: Separate the slots into multiple aggregates virhostdev: Introduce virHostdevPCIDevicesBelongToSameSlot qemu: address: Enable auto addressing multifunction cards conf: qemu: validate multifunction hostdevice domain configs conf: Add helper to get active functions of a slot of domain qemu: hostdev: Move the hostdev preparation to a separate function qemu: hotplug: Move the detach of PCI device to the beginning of live hotplug qemu: hotplug: move assignment outside qemuDomainAttachHostPCIDevice Introduce virDomainDeviceDefParseXMLMany Introduce qemuDomainDeviceParseXMLMany qemu: refactor qemuDomain[Attach|Detach]DeviceConfig qemu: refactor qemuDomain[Attach|Detach]DeviceLive qemu: hotplug: Queue and wait for multiple devices domain: addr: Introduce virDomainPCIAddressEnsureMultifunctionAddress qemu: hotplug: Implement multifunction device hotplug qemu: hotplug: Prevent updates to multifunction device qemu: hotplug: Implement multifunction device unplug src/conf/device_conf.h | 7 + src/conf/domain_addr.c | 130 +++++- src/conf/domain_addr.h | 43 +- src/conf/domain_conf.c | 224 ++++++++- src/conf/domain_conf.h | 38 ++ src/hypervisor/virhostdev.c | 29 ++ src/hypervisor/virhostdev.h | 2 + src/libvirt_private.syms | 10 + src/qemu/qemu_domain.c | 75 +++ src/qemu/qemu_domain.h | 21 +- src/qemu/qemu_domain_address.c | 311 ++++++++++++- src/qemu/qemu_domain_address.h | 17 + src/qemu/qemu_driver.c | 243 +++++++--- src/qemu/qemu_hotplug.c | 431 +++++++++++++++--- src/qemu/qemu_hotplug.h | 14 + src/qemu/qemu_validate.c | 56 +++ src/qemu/qemu_validate.h | 1 + src/util/virpci.c | 17 + src/util/virpci.h | 4 + tests/qemuhotplugtest.c | 66 ++- ...emuhotplug-multifunction-hostdev-pci-2.xml | 14 + ...plug-multifunction-hostdev-pci-partial.xml | 27 ++ .../qemuhotplug-multifunction-hostdev-pci.xml | 26 ++ ...live+multifunction-hostdev-pci-partial.xml | 82 ++++ ...ug-base-live+multifunction-hostdev-pci.xml | 82 ++++ ...-base-live+multifunction-hostdev-pci-2.xml | 59 +++ ...es-base-live+multifunction-hostdev-pci.xml | 69 +++ .../hostdev-pci-address-unassigned.args | 9 +- .../hostdev-pci-multifunction.args | 18 +- .../hostdev-pci-multifunction.xml | 8 +- .../hostdev-pci-no-primary-function.xml | 23 + .../hostdev-pci-validate.args | 30 ++ .../qemuxml2argvdata/hostdev-pci-validate.xml | 29 ++ .../qemuxml2argvdata/pseries-hostdevs-1.args | 5 +- .../qemuxml2argvdata/pseries-hostdevs-3.args | 5 +- tests/qemuxml2argvtest.c | 14 +- .../hostdev-pci-address-unassigned.xml | 8 +- .../hostdev-pci-multifunction.xml | 24 +- .../qemuxml2xmloutdata/pseries-hostdevs-1.xml | 4 +- .../qemuxml2xmloutdata/pseries-hostdevs-3.xml | 4 +- tests/virpcitestdata/0005-90-01.1.config | Bin 256 -> 256 bytes tests/virpcitestdata/0005-90-01.2.config | Bin 256 -> 256 bytes tests/virpcitestdata/0005-90-01.3.config | Bin 0 -> 256 bytes 43 files changed, 2022 insertions(+), 257 deletions(-) create mode 100644 tests/qemuhotplugtestdevices/qemuhotplug-multifunction-hostdev-pci-2.xml create mode 100644 tests/qemuhotplugtestdevices/qemuhotplug-multifunction-hostdev-pci-partial.xml create mode 100644 tests/qemuhotplugtestdevices/qemuhotplug-multifunction-hostdev-pci.xml create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-base-live+multifunction-hostdev-pci-partial.xml create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-base-live+multifunction-hostdev-pci.xml create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-pseries-base-live+multifunction-hostdev-pci-2.xml create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-pseries-base-live+multifunction-hostdev-pci.xml create mode 100644 tests/qemuxml2argvdata/hostdev-pci-no-primary-function.xml create mode 100644 tests/qemuxml2argvdata/hostdev-pci-validate.args create mode 100644 tests/qemuxml2argvdata/hostdev-pci-validate.xml create mode 100644 tests/virpcitestdata/0005-90-01.3.config -- 2.26.2

1 21

Exposing -fw_cfg?
by Michal Privoznik 20 May '20

20 May '20

List, QEMU has capability to inject various blobs into firmware that configure how firmware configures itself. However, it can be also used to passthrough a specific file into the guest. For instance: -fw_cfg value=name=opt/com.example,file=/tmp/ign will make the /tmp/ign file accessible in the guest under: /sys/firmware/qemu_fw_cfg/by_name/opt/com.example/raw the @name is important here as it defines what knob is touched. For instance, /opt/ovmf tweaks OVMF, /bootorder changes the boot order, and so on. But, if the @name is in /opt/reverse.fully.qualified.domain form than this is a blob that is exposed into the guest and does not affect ACPI, SMBIOS, ... And IMO this is what makes the interface horrible. While I definitely would not expose the FW configuration knobs (we already provide a way to configure things like bootroder), the file passthrough is actually used. So far I have found out that RHCOS uses it to give the guest so called ignition file (for the sake of argument we can assume it's like a kickstart that the OS reads on the first boot and configures itself up), but there are some other potential users (for users it looks intriguing, it's a simple API that makes a file show up at well defined location inside the guest). Therefore I vouch for exposing the file passthorugh (and definitely do not mention firmware in the element or docs in any way, to not encourage users to use FW tweaking mode). However, before I design something, I'd like to hear your opinion. Michal

3 4

[libvirt PATCH 0/6] Add ability to create mediated devices in libvirt
by Jonathon Jongsma 20 May '20

20 May '20

This is the first portion of an effort to support persistent mediated devices with libvirt. This first series simply enables creating and destroying non-persistent mediated devices via the virNodeDeviceCreateXML() and virNodeDeviceDestroy() functions. The 'mdevctl' utility[1] provides the backend implementation. [1] https://github.com/mdevctl/mdevctl Jonathon Jongsma (6): nodedev: factor out nodeDeviceHasCapability() nodedev: add support for mdev attributes nodedev: refactor nodeDeviceFindNewDevice() nodedev: store mdev UUID in mdev caps nodedev: add mdev support to virNodeDeviceCreateXML() nodedev: add mdev support to virNodeDeviceDestroy() docs/schemas/nodedev.rng | 6 + libvirt.spec.in | 3 + m4/virt-external-programs.m4 | 3 + src/conf/node_device_conf.c | 59 ++++- src/conf/node_device_conf.h | 3 + src/conf/virnodedeviceobj.c | 34 +++ src/conf/virnodedeviceobj.h | 3 + src/libvirt_private.syms | 3 + src/node_device/node_device_driver.c | 326 ++++++++++++++++++++++++--- src/node_device/node_device_udev.c | 5 +- src/util/virmdev.c | 12 + src/util/virmdev.h | 11 + 12 files changed, 425 insertions(+), 43 deletions(-) -- 2.21.1

4 19

[PATCH trivial v2 1/1] logging.html.in: fix number of output formats available
by Daniel Henrique Barboza 20 May '20

20 May '20

There are 4 formats available (x:stderr, x:syslog:name, x:file:file_path, x:journald), not 3. Use "the following" instead of the actual number to avoid the need to update the number every time a new form is added/removed. Suggested-by: Pino Toscano <ptoscano(a)redhat.com> Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com> --- docs/logging.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/logging.html.in b/docs/logging.html.in index 65c13e8a19..3ff0dd3eb6 100644 --- a/docs/logging.html.in +++ b/docs/logging.html.in @@ -124,7 +124,7 @@ x:name</pre> priority level, messages that match that filter will still be logged, while others will not. In order to see those messages, you must also have an output defined that includes the priority level of your filter.</p> - <p>The format for an output can be one of those 3 forms:</p> + <p>The format for an output can be one of the following forms:</p> <ul> <li><code>x:stderr</code> output goes to stderr</li> <li><code>x:syslog:name</code> use syslog for the output and use the -- 2.26.2

2 1

[PATCH 0/3] qemu: Emit an event on lease attach/detach
by Michal Privoznik 20 May '20

20 May '20

*** BLURB HERE *** Michal Prívozník (3): qemuDomainAttachDeviceLive: Rework event emitting Introduce VIR_DOMAIN_EVENT_ID_LEASE_CHANGE qemu: Emit an event on lease attach/detach examples/c/misc/event-test.c | 37 ++++++++++ include/libvirt/libvirt-domain.h | 37 ++++++++++ src/conf/domain_event.c | 100 ++++++++++++++++++++++++++++ src/conf/domain_event.h | 16 +++++ src/libvirt_private.syms | 2 + src/qemu/qemu_driver.c | 45 +++++++------ src/qemu/qemu_hotplug.c | 9 +++ src/remote/remote_daemon_dispatch.c | 37 ++++++++++ src/remote/remote_driver.c | 34 ++++++++++ src/remote/remote_protocol.x | 18 ++++- src/remote_protocol-structs | 8 +++ tools/virsh-domain.c | 34 ++++++++++ 12 files changed, 355 insertions(+), 22 deletions(-) -- 2.26.2

1 3

[PATCH trivial 1/1] logging.html.in: fix number of output formats available
by Daniel Henrique Barboza 20 May '20

20 May '20

There are 4 formats available (x:stderr, x:syslog:name, x:file:file_path, x:journald), not 3. Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com> --- docs/logging.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/logging.html.in b/docs/logging.html.in index 65c13e8a19..9f320b439e 100644 --- a/docs/logging.html.in +++ b/docs/logging.html.in @@ -124,7 +124,7 @@ x:name</pre> priority level, messages that match that filter will still be logged, while others will not. In order to see those messages, you must also have an output defined that includes the priority level of your filter.</p> - <p>The format for an output can be one of those 3 forms:</p> + <p>The format for an output can be one of those 4 forms:</p> <ul> <li><code>x:stderr</code> output goes to stderr</li> <li><code>x:syslog:name</code> use syslog for the output and use the -- 2.26.2

2 2

Re: Question: How do I discard any changes for the device which is set by blockdev option?
by Eric Blake 20 May '20

20 May '20

On 5/19/20 12:56 PM, Masayoshi Mizuma wrote: > Hello, > > I would like to discard any changes while the qemu guest OS is done. > I can do that with snapshot and drive option. > However, snapshot option doesn't work for the device which set by > blockdev option like as: > > $QEMU --enable-kvm \ > -m 1024 \ > -nographic \ > -serial mon:stdio \ > -blockdev driver=file,node-name=mydisk,filename=/mnt/fedora.qcow2 \ > -blockdev driver=qcow2,node-name=vda,file=mydisk \ > -device virtio-blk-pci,drive=vda,bootindex=1 \ > -snapshot > > I would like to use blockdev option to set the device because > libvirt uses blockdev option for disk element. > > If there's no way to do so, does that make sense to get available > snapshot option to blockdev as well? If that makes sense, I'll try to > implement that. > > As for qcow2, I think we can do such things to use qemu-img snapshot > command, for example save the original image and restore the image > after the qemu guest OS is shutdowned. However, it may be complecated > for user. I would like the simple way like as snapshot/drive option... > > If I'm missing something, let me know. > Sounds like a repeat of this thread: https://lists.gnu.org/archive/html/qemu-devel/2020-01/msg06144.html where the consensus is yes, -blockdev and -snapshot are incompatible, libvirt has plans to use the <transient/> tag to behave the same as what -snapshot does (but no one has implemented it yet), and in the meantime, it is possible to force libvirt to avoid -blockdev if you still need to supply -snapshot behind libvirt's back. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

2 1

[PATCH 00/15] tests: qemu: Detect deprecation in the QMP schema (deprecation part 1)
by Peter Krempa 19 May '20

19 May '20

Recent qemu versions started adding the 'deprecated' feature to commands and fields. Use this data to validate that our code doesn't rely on deprecated commands. It turns out that we still use some old migration commands (See 14/15) and add validator to catch anything deprecated early. Peter Krempa (15): testQemuHotplugCpuPrepare: Allow unused monitor commands only on failure testutilsqemuschema: Introduce testQEMUSchemaValidateCommand qemuMonitorTestProcessCommandDefaultValidate: Use testQEMUSchemaValidateCommand qemuMonitorTestProcessCommandDefaultValidate: Clean up return value use qemumonitortestutils: Introduce qemuMonitorTestSkipDeprecatedValidation testutilsqemuschema: Use automatic variable clearing where possible testutilsqemuschema: Pass in 'schema' and 'debug' variables to workers in a struct testQEMUSchemaValidate(Command): Allow skipping validation of deprecated fields testQemuHotplugCpuPrepare: Allow deprecated commands for non-modern cpu hotplug test qemumonitorjsontest: Add infrastructure for generated tests of deprecated commands testQemuMonitorJSONqemuMonitorJSONQueryCPUs: Split off test for query-cpus-fast qemumonitorjsontest: Allow use of deprecated 'query-cpus' qemumonitorjsontest: Allow use of deprecated 'cpu-add' and 'change' command qemumonitorjsontest: Mark recently deprecated migration command in our tests testQEMUSchemaValidate*: Reject usage of fields with 'deprecated' set tests/qemublocktest.c | 14 +- tests/qemuhotplugtest.c | 11 +- tests/qemumonitorjsontest.c | 67 +++++-- tests/qemumonitortestutils.c | 66 ++++--- tests/qemumonitortestutils.h | 2 + tests/testutilsqemuschema.c | 334 ++++++++++++++++++++++------------- tests/testutilsqemuschema.h | 9 + 7 files changed, 325 insertions(+), 178 deletions(-) -- 2.26.2

2 30

[PATCH] qemu: do not allow /dev/rtc or /dev/hpet access via the devices cgroup
by Paolo Bonzini 19 May '20

19 May '20

The RTC and HPET modes for the QEMU emulation tick have been dropped almost 9 years ago, in commit 25f3151ece1d5881826232bebccc21b588d4e03e. Do not allow them in the devices cgroup policy. Signed-off-by: Paolo Bonzini <pbonzini(a)redhat.com> --- docs/drvqemu.html.in | 1 - src/qemu/qemu.conf | 1 - src/qemu/qemu_cgroup.c | 1 - src/qemu/test_libvirtd_qemu.aug.in | 2 -- 4 files changed, 5 deletions(-) diff --git a/docs/drvqemu.html.in b/docs/drvqemu.html.in index afc4ddf56d..b6d731bb59 100644 --- a/docs/drvqemu.html.in +++ b/docs/drvqemu.html.in @@ -484,7 +484,6 @@ chmod o+x /path/to/directory /dev/null, /dev/full, /dev/zero, /dev/random, /dev/urandom, /dev/ptmx, /dev/kvm, -/dev/rtc, /dev/hpet </pre> <p> diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf index abdbf07fec..d7a3f40e78 100644 --- a/src/qemu/qemu.conf +++ b/src/qemu/qemu.conf @@ -495,7 +495,6 @@ # "/dev/null", "/dev/full", "/dev/zero", # "/dev/random", "/dev/urandom", # "/dev/ptmx", "/dev/kvm", -# "/dev/rtc","/dev/hpet" #] # # RDMA migration requires the following extra files to be added to the list: diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index 2e019b64af..d92202f847 100644 --- a/src/qemu/qemu_cgroup.c +++ b/src/qemu/qemu_cgroup.c @@ -47,7 +47,6 @@ const char *const defaultDeviceACL[] = { "/dev/null", "/dev/full", "/dev/zero", "/dev/random", "/dev/urandom", "/dev/ptmx", "/dev/kvm", - "/dev/rtc", "/dev/hpet", NULL, }; #define DEVICE_PTY_MAJOR 136 diff --git a/src/qemu/test_libvirtd_qemu.aug.in b/src/qemu/test_libvirtd_qemu.aug.in index 19da591aae..e533b9f551 100644 --- a/src/qemu/test_libvirtd_qemu.aug.in +++ b/src/qemu/test_libvirtd_qemu.aug.in @@ -61,8 +61,6 @@ module Test_libvirtd_qemu = { "5" = "/dev/urandom" } { "6" = "/dev/ptmx" } { "7" = "/dev/kvm" } - { "8" = "/dev/rtc" } - { "9" = "/dev/hpet" } } { "save_image_format" = "raw" } { "dump_image_format" = "raw" } -- 2.25.4

3 4

[PATCH v2] README.rst: Replace the installation instructions with link to compiling.html.
by Yi Wang 19 May '20

19 May '20

From: Liao Pingfang <liao.pingfang(a)zte.com.cn> Remove the installation instructions from README.rst, and add the link to compiling.html. Signed-off-by: Liao Pingfang <liao.pingfang(a)zte.com.cn> --- Changes in v2: use compiling.html replace the installation instructions README.rst | 26 ++------------------------ 1 file changed, 2 insertions(+), 24 deletions(-) diff --git a/README.rst b/README.rst index cdcc97b..5d6ca55 100644 --- a/README.rst +++ b/README.rst @@ -45,31 +45,9 @@ and ``COPYING`` for full license terms & conditions. Installation ============ -Libvirt uses the GNU Autotools build system, so in general can be built -and installed with the usual commands, however, we mandate to have the -build directory different than the source directory. For example, to build -in a manner that is suitable for installing as root, use: - -:: - - $ mkdir build && cd build - $ ../configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var - $ make - $ sudo make install - -While to build & install as an unprivileged user - -:: - - $ mkdir build && cd build - $ ../configure --prefix=$HOME/usr - $ make - $ make install - -The libvirt code relies on a large number of 3rd party libraries. These will -be detected during execution of the ``configure`` script and a summary printed -which lists any missing (optional) dependencies. +Instructions on building and installing libvirt can be found on the website: +https://libvirt.org/compiling.html Contributing ============ -- 2.9.5

2 1

[libvirt PATCH] qemu: conf: fix stray comma
by Ján Tomko 19 May '20

19 May '20

The qemu.conf change broke our augeas test: qemu/test_libvirtd_qemu.aug:96.3-203.1:exception thrown in test qemu/test_libvirtd_qemu.aug:96.8-.34:exception: Iterated lens matched less than it should Lens: ../../src/qemu/libvirtd_qemu.aug:170.13-.43: Last match: ../../src/qemu/libvirtd_qemu.aug:18.52-.113: Not matching: ../../src/qemu/libvirtd_qemu.aug:12.19-.31: Error encountered at 48:27 (1615 characters into string) <\n "/dev/ptmx", "/dev/kvm"|=|,\n]\nsave_image_format = "raw> Fixes: ab5ba57012e9e6ab4f55afdeecd1813dd3ca916b Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Pushed as a trivial build fix src/qemu/qemu.conf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf index d7a3f40e78..404961c53e 100644 --- a/src/qemu/qemu.conf +++ b/src/qemu/qemu.conf @@ -494,7 +494,7 @@ #cgroup_device_acl = [ # "/dev/null", "/dev/full", "/dev/zero", # "/dev/random", "/dev/urandom", -# "/dev/ptmx", "/dev/kvm", +# "/dev/ptmx", "/dev/kvm" #] # # RDMA migration requires the following extra files to be added to the list: -- 2.25.4

1 0

[PATCH 0/2] Introduce GitLab CI and merge requests
by Daniel P. Berrangé 19 May '20

19 May '20

In v2: - Use ubuntu for publishing pages build Daniel P. Berrangé (2): gitlab: introduce CI jobs for building content gitlab: add CONTRIBUTING.rst file to indicate use of merge requests .gitlab-ci.yml | 126 +++++++++++++++++++++++++++ .gitpublish | 4 - CONTRIBUTING.rst | 28 ++++++ Makefile | 7 +- ci/libvirt-centos-7.Dockerfile | 83 ++++++++++++++++++ ci/libvirt-debian-10.Dockerfile | 53 +++++++++++ ci/libvirt-debian-9.Dockerfile | 56 ++++++++++++ ci/libvirt-debian-sid.Dockerfile | 53 +++++++++++ ci/libvirt-fedora-31.Dockerfile | 50 +++++++++++ ci/libvirt-fedora-32.Dockerfile | 50 +++++++++++ ci/libvirt-fedora-rawhide.Dockerfile | 51 +++++++++++ ci/libvirt-ubuntu-1804.Dockerfile | 56 ++++++++++++ ci/libvirt-ubuntu-2004.Dockerfile | 53 +++++++++++ ci/refresh | 22 +++++ 14 files changed, 685 insertions(+), 7 deletions(-) delete mode 100644 .gitpublish create mode 100644 CONTRIBUTING.rst create mode 100644 ci/libvirt-centos-7.Dockerfile create mode 100644 ci/libvirt-debian-10.Dockerfile create mode 100644 ci/libvirt-debian-9.Dockerfile create mode 100644 ci/libvirt-debian-sid.Dockerfile create mode 100644 ci/libvirt-fedora-31.Dockerfile create mode 100644 ci/libvirt-fedora-32.Dockerfile create mode 100644 ci/libvirt-fedora-rawhide.Dockerfile create mode 100644 ci/libvirt-ubuntu-1804.Dockerfile create mode 100644 ci/libvirt-ubuntu-2004.Dockerfile create mode 100755 ci/refresh -- 2.26.2

2 5

[PATCH 00/21] Fix compatibility with netdev-add in qemu-5.0
by Peter Krempa 18 May '20

18 May '20

This is based on top of tests: qemu: Detect deprecation in the QMP schema (deprecation part 1) https://www.redhat.com/archives/libvir-list/2020-April/msg01444.html Both can be fetched at: git fetch https://gitlab.com/pipo.sk/libvirt.git netdev_add-validate QEMU-5.0 released a fully QAPIfied 'netdev_add' command. Since we didn't format the arguments in a way qemu now thinks we should do them network device hotplug broke. Fix it by modifying our internals slightly and add some testing. This series also adds schema testing of -blockdev arguments and prepares for a simple addition of schema testing for arguments of -device and -object if qemu ever finishes the qapification of those. Theoretically we can even do it pre-emtptively but it's almost guaranteed to fail at least for -device. I just hope that qemu let's us know in advance as -device will be harder. Note that if the loading of the schema in the tests I've added will be deemed to be slow I'll add caching. Peter Krempa (21): qemu: domain: Forbid unsupported 'tftp' protocol and handle tests qemuMonitorJSONParseKeywords: remove constant argument qemuBuildChannelsCommandLine: Use typecasted switch for channel type qemuBuildChannelsCommandLine: Extract common formatting of 'chardev' qemuBuildChannelChrDeviceStr: Remove formatting of properties for -netdev qemuBuildHostNetStr: Stop using 'ipv6-net' convenience argument virQEMUBuildCommandLineJSON: Allow skipping certain keys virQEMUBuildCommandLineJSON: Add possibility for using 'on/off' instead of 'yes/no' virCommand: Introduce virCommandGetArgList util: json: Introduce virJSONValueObjectAppendStringPrintf testCompareXMLToArgv: Split out preparation and command formatting qemuMonitorJSON(Add|Remove)Netdev: Refactor cleanup util: virqemu: Introduce virQEMUBuildNetdevCommandlineFromJSON qemu: command: Generate -netdev command line via JSON->cmdline conversion virQEMUBuildNetdevCommandlineFromJSON: Prepare for quirky 'guestfwd' qemuBuildChannelGuestfwdNetdevProps: Convert to generating JSON props qemuMonitorAddNetdev: Convert to the native JSON props object qemu: Prepare for testing of 'netdev_add' props via qemuxml2argvtest testQEMUSchemaLoad: Rename to testQEMUSchemaLoadLatest testutilsqemuschema: Allow loading non-latest schema qemuxml2argvtest: Add QAPI/QMP schema validation for -blockdev and -netdev src/libvirt_private.syms | 3 + src/qemu/qemu_command.c | 289 +++++++++++------- src/qemu/qemu_command.h | 22 +- src/qemu/qemu_domain.c | 10 + src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_hotplug.c | 31 +- src/qemu/qemu_monitor.c | 8 +- src/qemu/qemu_monitor.h | 2 +- src/qemu/qemu_monitor_json.c | 76 ++--- src/qemu/qemu_monitor_json.h | 2 +- src/qemu/qemu_process.c | 11 +- src/qemu/qemu_process.h | 1 + src/util/vircommand.c | 23 ++ src/util/vircommand.h | 1 + src/util/virjson.c | 17 ++ src/util/virjson.h | 2 + src/util/virqemu.c | 119 +++++++- src/util/virqemu.h | 18 +- tests/Makefile.am | 2 +- tests/qemublocktest.c | 2 +- tests/qemucommandutiltest.c | 2 +- tests/qemuhotplugtest.c | 2 +- tests/qemumonitorjsontest.c | 6 +- .../qemuxml2argvdata/disk-cdrom-network.args | 3 - .../disk-cdrom-network.x86_64-2.12.0.args | 3 - .../disk-cdrom-network.x86_64-latest.args | 17 +- tests/qemuxml2argvdata/disk-cdrom-network.xml | 9 - tests/qemuxml2argvdata/net-user-addr.args | 3 +- tests/qemuxml2argvtest.c | 236 +++++++++----- tests/testutilsqemu.c | 5 + tests/testutilsqemu.h | 1 + tests/testutilsqemuschema.c | 66 ++-- tests/testutilsqemuschema.h | 5 +- 33 files changed, 667 insertions(+), 332 deletions(-) -- 2.26.2

2 43

[libvirt PATCH 0/2] fix a leak in virQEMUDriverConfigLoadMemoryEntry
by Ján Tomko 18 May '20

18 May '20

Thanks to valgrind Ján Tomko (2): qemu: do not leak the directory in virQEMUDriverConfigLoadMemoryEntry qemu: only return two values in virQEMUDriverConfigLoadMemoryEntry src/qemu/qemu_conf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.25.4

2 3

[PATCH v2] qemuProcessStop: Reattach NVMe disks a domain is mirroring into
by Michal Privoznik 18 May '20

18 May '20

In v5.10.0-rc1~42 (which was later fixed in v6.0.0-rc1~487) I am removing XATTRs for a file that QEMU is mirroring a disk into but it is killed meanwhile. Well, we can call qemuSecurityRestoreImageLabel() which will not only remove XATTRs but also use them to restore the original owner of the file. Moreover, if the mirror destination is not a file but a NVMe disk, then call qemuHostdevReAttachOneNVMeDisk() to reattach the NVMe back to the host. All of this would be done by blockjob code when the job finishes, but in this case the job won't finish - QEMU is killed meanwhile. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1825785 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- v2 of: https://www.redhat.com/archives/libvir-list/2020-May/msg00210.html diff to v1: - per Peter's review, instead of calling qemuDomainStorageSourceAccessRevoke() call only some functions it would call. src/qemu/qemu_process.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 8ea470f75f..65d51e58c9 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -7604,8 +7604,13 @@ void qemuProcessStop(virQEMUDriverPtr driver, for (i = 0; i < def->ndisks; i++) { virDomainDiskDefPtr disk = def->disks[i]; - if (disk->mirror) - qemuBlockRemoveImageMetadata(driver, vm, disk->dst, disk->mirror); + if (disk->mirror) { + if (qemuSecurityRestoreImageLabel(driver, vm, disk->mirror, false) < 0) + VIR_WARN("Unable to restore security label on %s", disk->dst); + + if (virStorageSourceChainHasNVMe(disk->mirror)) + qemuHostdevReAttachOneNVMeDisk(driver, vm->def->name, disk->mirror); + } qemuBlockRemoveImageMetadata(driver, vm, disk->dst, disk->src); } -- 2.26.2

2 1

[libvirt PATCH v2 00/10] qemu: block: basic implementation of deletion of external snapshots
by Pavel Mores 18 May '20

18 May '20

Deleting external snapshots has been unimplemented so far. This series aims to enable limited functionality in that direction, handling just the common cases for now. The intention is to subsequently build upon this to eventually cover the more complex/exotic cases as well. It works by blockcommitting the snapshot to be deleted into its parent. Handles both deleting children as well and deleting children only (by committing the children into the snapshot referred to by snapshot-delete argument). If the necessary block commit operations turns out to be active (the snapshot referred to by snapshot-delete argument is current, or deleting children is requested) pivot is performed as well. This implemetation is limited to the straightforward case which assumes no branching snapshot chains below the snapshot to be deleted, and the current snapshot has to be the leaf of the (linear) chain starting at the snapshot to be deleted. These requirements are checked and enforced at the top of qemuDomainSnapshotDeleteExternal(). They might even be too restrictive for the case where deletion of children is not requested as in that case, requiring that the parent of the snapshot to be deleted not be a branching point in snapshot tree should be enough. The above limitations do not appear too severe under the current state of matters where a major source of branching snapshot structures, snapshot-revert, is not even implemented for external snapshots yet. The only other known cause of branching in external snapshots thus seems to be if a user creates branching by manually creating snapshot images and metadata and applies them using snapshot-create --redefine. Also, the snapshot images involved basically have to be files. This does not seem overly limiting either, at least for the time being, because it's a limitation shared with the underlying blockcommit code. Just as the existing code, the new code ultimately relies on virStorageFileChainLookup() as its image comparison and look-up engine and is affected by its limitaions. At any rate, this work should be understood as just a first step to a full support of deleting external snapshots. The first 5 commits of this series are just refactors used by the last 5 commits which actually implement snapshot deletion. However, the qemuDomainBlockCommit() refactor (the initial 2 commits of this series) was affected by a rather hairy merge on rebasing to the current master and although I tried to do my best to get the merge right I still feel a careful review is in order for these two commits. Pavel Mores (10): qemu: block: factor implementation out of qemuDomainBlockCommit() qemu: block: refactor blockcommit so that it's callable with storage sources qemu: block: factor implementation out of qemuDomainBlockJobAbort() conf: rename virDomainMomentFindLeaf() to virDomainMomentObjListFindLeaf() conf: add virDomainMomentFindLeaf() which operates on virDomainMomentObjPtr qemu: block: add function to collect blockcommit params and verify them qemu: block: add function to launch all prepared blockcommits qemu: block: add function to wait for blockcommits and collect results qemu: block: add external snapshot-delete top-level algorithm qemu: block: add actual invocation of external snapshot-delete src/conf/virdomaincheckpointobjlist.c | 2 +- src/conf/virdomainmomentobjlist.c | 27 +- src/conf/virdomainmomentobjlist.h | 3 +- src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 552 ++++++++++++++++++++++---- 5 files changed, 485 insertions(+), 100 deletions(-) -- 2.24.1

2 15

[PATCH] RFC: Support network interface downscript
by Chen Hanxiao 18 May '20

18 May '20

https://gitlab.com/libvirt/libvirt/-/issues/13 Add support for downscript: <interface type='ethernet'> <mac address='00:11:22:33:44:55'/> <script path='/etc/qemu-ifup'/> <downscript path='/path/to/my/downscript'/> </interface> But -net ...,script=/etc/qemu-ifup has some limitation: https://github.com/qemu/qemu/blob/035b448b84f3557206abc44d786c5d3db2638f7d/… Maybe virNetDevRunEthernetScript is another choice. Signed-off-by: Chen Hanxiao <chen_han_xiao(a)126.com> --- src/conf/domain_conf.c | 7 +++++++ src/conf/domain_conf.h | 1 + src/qemu/qemu_extdevice.c | 2 ++ 3 files changed, 10 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index c201fc9..5cb39a3 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -2520,6 +2520,7 @@ virDomainNetDefClear(virDomainNetDefPtr def) VIR_FREE(def->teaming.persistent); VIR_FREE(def->virtPortProfile); VIR_FREE(def->script); + VIR_FREE(def->downscript); VIR_FREE(def->domain_name); VIR_FREE(def->ifname); VIR_FREE(def->ifname_guest); @@ -11977,6 +11978,7 @@ virDomainNetDefParseXML(virDomainXMLOptionPtr xmlopt, g_autofree char *ifname_guest = NULL; g_autofree char *ifname_guest_actual = NULL; g_autofree char *script = NULL; + g_autofree char *downscript = NULL; g_autofree char *address = NULL; g_autofree char *port = NULL; g_autofree char *localaddr = NULL; @@ -12149,6 +12151,9 @@ virDomainNetDefParseXML(virDomainXMLOptionPtr xmlopt, } else if (!script && virXMLNodeNameEqual(cur, "script")) { script = virXMLPropString(cur, "path"); + } else if (!downscript && + virXMLNodeNameEqual(cur, "downscript")) { + downscript = virXMLPropString(cur, "path"); } else if (!domain_name && virXMLNodeNameEqual(cur, "backenddomain")) { domain_name = virXMLPropString(cur, "name"); @@ -12482,6 +12487,8 @@ virDomainNetDefParseXML(virDomainXMLOptionPtr xmlopt, if (script != NULL) def->script = g_steal_pointer(&script); + if (downscript != NULL) + def->downscript = g_steal_pointer(&downscript); if (domain_name != NULL) def->domain_name = g_steal_pointer(&domain_name); if (ifname != NULL) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index ddc75d8..e152c59 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -1055,6 +1055,7 @@ struct _virDomainNetDef { unsigned long sndbuf; } tune; char *script; + char *downscript; char *domain_name; /* backend domain name */ char *ifname; /* interface name on the host (<target dev='x'/>) */ int managed_tap; /* enum virTristateBool - ABSENT == YES */ diff --git a/src/qemu/qemu_extdevice.c b/src/qemu/qemu_extdevice.c index 2096272..f8e440a 100644 --- a/src/qemu/qemu_extdevice.c +++ b/src/qemu/qemu_extdevice.c @@ -234,6 +234,8 @@ qemuExtDevicesStop(virQEMUDriverPtr driver, if (slirp) qemuSlirpStop(slirp, vm, driver, net); + if (net->downscript) + virNetDevRunEthernetScript(net->ifname, net->downscript); } for (i = 0; i < def->nfss; i++) { -- 1.8.3.1

2 1