- Devel - libvirt List Archives

[libvirt PATCH] docs: Fixed incorrect XML attribute name in virtio kbase
by Ján Tomko 01 Jun '20

01 Jun '20

From: Jaak Ristioja <jaak(a)ristioja.ee> Signed-off-by: Jaak Ristioja <jaak(a)ristioja.ee> --- Pushed by danpb under the trivial rule from https://gitlab.com/libvirt/libvirt/-/merge_requests/2 docs/kbase/virtiofs.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/kbase/virtiofs.rst b/docs/kbase/virtiofs.rst index 68fbafcf37..18d568af1b 100644 --- a/docs/kbase/virtiofs.rst +++ b/docs/kbase/virtiofs.rst @@ -143,5 +143,5 @@ More optional elements can be specified <driver type='virtiofs' queue='1024'/> <binary path='/usr/libexec/virtiofsd' xattr='on'> <cache mode='always'/> - <lock posix_lock='on' flock='on'/> + <lock posix='on' flock='on'/> </binary> -- 2.25.4

1 0

[PATCH 0/6] Add Security Guest doc and check for capabilities cache validation
by Boris Fiuczynski 28 May '20

28 May '20

This series introduces the concept of a 'Secure Guest' feature which covers on s390 IBM Secure Execution and on x86 AMD Secure Encrypted Virtualization. Besides adding documentation for IBM Secure Execution it also adds checks during validation of the qemu capabilities cache. These checks per architecture can be performed for IBM Secure Execution on s390 and AMD Secure Encrypted Virtualization on AMD x86 CPUs (both checks implemented in this series). For s390 the verification consists of: - checking if /sys/firmware/uv is available: meaning the HW facility is available and the host OS supports it; - checking if the kernel cmdline contains 'prot_virt=1': meaning the host OS wants to use the feature. For AMD Secure Encrypted Virtualization the verification consists of: - checking if /sys/module/kvm_amd/parameters/sev contains the value '1': meaning SEV is enabled in the host kernel; - checking if the kernel cmdline contains 'mem_encrypt=on': meaning SME memory encryption feature on the host is enabled Whenever the availability of the feature does not match the secure guest flag in the cache then libvirt will re-build it in order to pick up the new set of capabilities available. Additionally, this series adds the same aforementioned checks to the virt-host-validate tool to facilitate the manual verification process for users. Boris Fiuczynski (2): tools: secure guest check on s390 in virt-host-validate tools: secure guest check for AMD in virt-host-validate Paulo de Rezende Pinatti (3): util: introduce a parser for kernel cmdline arguments qemu: check if s390 secure guest support is enabled qemu: check if AMD secure guest support is enabled Viktor Mihajlovski (1): docs: Describe protected virtualization guest setup docs/kbase.html.in | 3 + docs/kbase/launch_security_sev.rst | 9 +- docs/kbase/s390_protected_virt.rst | 189 +++++++++++++++++++++++++++++ src/libvirt_private.syms | 2 + src/qemu/qemu_capabilities.c | 83 +++++++++++++ src/util/virutil.c | 173 ++++++++++++++++++++++++++ src/util/virutil.h | 18 +++ tests/utiltest.c | 130 ++++++++++++++++++++ tools/virt-host-validate-common.c | 90 +++++++++++++- tools/virt-host-validate-common.h | 5 + tools/virt-host-validate-qemu.c | 4 + 11 files changed, 701 insertions(+), 5 deletions(-) create mode 100644 docs/kbase/s390_protected_virt.rst -- 2.25.1

4 28

[PATCH v2] qemu: Skip pre-creation of NVMe disks
by Michal Privoznik 28 May '20

28 May '20

Upon migration with disks, libvirt determines if each disk exists on the destination and tries to pre-create missing ones. Well, NVMe disks can't be pre-created, but they can be checked for presence. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1823639 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Technically, this is a v2 of: https://www.redhat.com/archives/libvir-list/2020-May/msg00253.html but I've taken what I'm suggesting in a BZ comment and posting it as a patch. src/qemu/qemu_migration.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 02e8271e42..7ee5b5eda8 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -315,6 +315,7 @@ qemuMigrationDstPrecreateStorage(virDomainObjPtr vm, for (i = 0; i < nbd->ndisks; i++) { virDomainDiskDefPtr disk; const char *diskSrcPath; + g_autofree char *nvmePath = NULL; VIR_DEBUG("Looking up disk target '%s' (capacity=%llu)", nbd->disks[i].target, nbd->disks[i].capacity); @@ -326,7 +327,12 @@ qemuMigrationDstPrecreateStorage(virDomainObjPtr vm, goto cleanup; } - diskSrcPath = virDomainDiskGetSource(disk); + if (disk->src->type == VIR_STORAGE_TYPE_NVME) { + virPCIDeviceAddressGetSysfsFile(&disk->src->nvme->pciAddr, &nvmePath); + diskSrcPath = nvmePath; + } else { + diskSrcPath = virDomainDiskGetSource(disk); + } /* Skip disks we don't want to migrate and already existing disks. */ if (!qemuMigrationAnyCopyDisk(disk, nmigrate_disks, migrate_disks) || -- 2.26.2

2 1

[PATCH] news: Document 'netdev_add' regression and disk type='lun' changes
by Peter Krempa 28 May '20

28 May '20

Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- docs/news.xml | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 67fb85377d..104babbae7 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -46,8 +46,31 @@ <section title="New features"> </section> <section title="Improvements"> + <change> + <summary> + qemu: stricter validation for disk type='lun' + </summary> + <description> + The 'lun' type is meant for SCSI command passthrough, which can't be + achieved if qemu's block layer features are used. Disk type='lun' is now + allowed only when the format is 'raw' and no other block layer features + are requested. + </description> + </change> </section> <section title="Bug fixes"> + <change> + <summary> + qemu: fixed regression in network device hotplug with new qemu versions + </summary> + <description> + Starting from QEMU-5.0 it's required to conform to strict schema when + hotplugging network devices. Libvirt didn't conform to the schema so + in versions prior to 6.4.0 network device hotplug fails in certain + cases. This version fixes it and adds stricter testing to prevent + further issues. + </description> + </change> </section> </release> <release version="v6.3.0" date="2020-05-05"> -- 2.26.2

2 1

[GSoC'20]: Student Introduction
by PRAKHAR BANSAL 28 May '20

28 May '20

Hello Everyone, I am Prakhar Bansal, Google Summer of Code Student from Iowa State University, USA. In the next few months, I will be working on the Project " Libvirt Support For Jailhouse Hypervisor" under the guidance of my mentors Michal Privoznik and Jan Kiszka. This project aims to add support for Jailhouse( partitioning hypervisor based on Linux) in the Libvirt API to make it easier to use this hypervisor using the well known Libvirt API or through various applications using Libvirt. I am available on IRC with a nickname as prakhar. Thanks, Prakhar

1 1

Entering freeze for libvirt-6.4.0
by Daniel Veillard 28 May '20

28 May '20

We are getting at the end of the month and Monday is closed here, so I though it was better to roll RC1 even if I had not yet announced the release plan, I assume it's better than skipping by a few days. So it is there, I tagged it in git head and pushed signed tarball and source rpm to the usual place: https://libvirt.org/sources/ I seems to work in my limited testing and there is only a few red spots on the CI https://ci.centos.org/view/libvirt/ but TBH that doesn't look critical. Please give it a try, I will try to roll RC2 on Friday, then assuming everything looks fine 6.4.0 could go out on Tuesday, thanks in advance, Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[PATCH v5 00/10] Introducing TPM Proxy device support for PPC64
by Daniel Henrique Barboza 28 May '20

28 May '20

changes in v5: - rebased and fixed commits to master at d265171b5784 - moved two TPMs validation from domain_conf.c (patch 05) to qemu_domain.c (patch 06) Gitlab tree: https://gitlab.com/danielhb/libvirt/tree/spapr_tpm_proxy_v5 v4 link: https://www.redhat.com/archives/libvir-list/2020-May/msg00814.html v3 link: https://www.redhat.com/archives/libvir-list/2020-May/msg00642.html v2 link: https://www.redhat.com/archives/libvir-list/2020-May/msg00604.html v1 link: https://www.redhat.com/archives/libvir-list/2020-May/msg00604.html Daniel Henrique Barboza (10): docs: documentation and schema for the new TPM Proxy model qemu: Extend QEMU capabilities with 'spapr-tpm-proxy' qemu_extdevice.c: remove unneeded 'ret' variable qemu_tpm, security, tests: change 'switch' clauses for 'if' conf, qemu, security, tests: introducing 'def->tpms' array qemu: add validations after TPM Proxy model introduction tests: add XML schema tests for the TPM Proxy device qemu: build command line for the TPM Proxy device tests/qemuxml2argvtest.c: add TPM Proxy command line tests docs/news.xml: update for the new TPM Proxy device docs/formatdomain.html.in | 19 ++++- docs/news.xml | 17 +++++ docs/schemas/domaincommon.rng | 1 + src/conf/domain_audit.c | 4 +- src/conf/domain_conf.c | 50 +++++++----- src/conf/domain_conf.h | 6 +- src/qemu/qemu_alias.c | 9 ++- src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_cgroup.c | 10 ++- src/qemu/qemu_command.c | 59 +++++++++++--- src/qemu/qemu_domain.c | 68 ++++++++++++++--- src/qemu/qemu_domain_address.c | 11 ++- src/qemu/qemu_extdevice.c | 24 +++--- src/qemu/qemu_tpm.c | 76 +++++++++---------- src/qemu/qemu_validate.c | 19 +++++ src/security/security_dac.c | 8 +- src/security/security_selinux.c | 44 +++++------ src/security/virt-aa-helper.c | 14 ++-- .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 + .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 + tests/qemuxml2argvdata/ppc64-tpm-double.xml | 34 +++++++++ .../ppc64-tpmproxy-double.xml | 38 ++++++++++ .../ppc64-tpmproxy-single.ppc64-latest.args | 34 +++++++++ .../ppc64-tpmproxy-single.xml | 33 ++++++++ .../ppc64-tpmproxy-with-tpm.ppc64-latest.args | 37 +++++++++ .../ppc64-tpmproxy-with-tpm.xml | 36 +++++++++ tests/qemuxml2argvtest.c | 33 +++++--- .../ppc64-tpmproxy-single.ppc64-latest.xml | 42 ++++++++++ .../ppc64-tpmproxy-with-tpm.ppc64-latest.xml | 46 +++++++++++ tests/qemuxml2xmltest.c | 2 + 31 files changed, 631 insertions(+), 152 deletions(-) create mode 100644 tests/qemuxml2argvdata/ppc64-tpm-double.xml create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-double.xml create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-single.ppc64-latest.args create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-single.xml create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-with-tpm.ppc64-latest.args create mode 100644 tests/qemuxml2argvdata/ppc64-tpmproxy-with-tpm.xml create mode 100644 tests/qemuxml2xmloutdata/ppc64-tpmproxy-single.ppc64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/ppc64-tpmproxy-with-tpm.ppc64-latest.xml -- 2.26.2

3 16

[PULL 00/14] mips-hw-next patches for 2020-05-26
by Philippe Mathieu-Daudé 27 May '20

27 May '20

The following changes since commit 8f72c75cfc9b3c84a9b5e7a58ee5e471cb2f19c8: Merge remote-tracking branch 'remotes/kraxel/tags/audio-20200526-pull-reque= st' into staging (2020-05-26 10:59:01 +0100) are available in the Git repository at: https://gitlab.com/philmd/qemu.git tags/mips-hw-next-20200526 for you to fetch changes up to 97d8974620053db5754af808583de70380f73a10: MAINTAINERS: Change Aleksandar Rikalo's email address (2020-05-26 13:21:12 = +0200) ---------------------------------------------------------------- MIPS hardware updates - MAINTAINERS updated to welcome Huacai Chen and Jiaxun Yang, and update Aleksandar Rikalo's email address, - Trivial improvements in the Bonito64 North Bridge and the Fuloong 2e machine, - MIPS Machines names unified without 'mips_' prefix. CI: https://travis-ci.org/github/philmd/qemu/builds/691247975 ---------------------------------------------------------------- Aleksandar Markovic (3): hw/mips: Rename malta/mipssim/r4k/jazz files hw/mips/malta: Add some logging for bad register offset cases MAINTAINERS: Change Aleksandar Rikalo's email address Huacai Chen (1): MAINTAINERS: Add Huacai Chen as fuloong2e co-maintainer Philippe Mathieu-Daud=C3=A9 (10): hw/pci-host: Use CONFIG_PCI_BONITO to select the Bonito North Bridge hw/pci-host/bonito: Fix DPRINTF() format strings hw/pci-host/bonito: Map peripheral using physical address hw/pci-host/bonito: Map all the Bonito64 I/O range hw/pci-host/bonito: Map the different PCI ranges more detailed hw/pci-host/bonito: Better describe the I/O CS regions hw/pci-host/bonito: Set the Config register reset value with FIELD_DP32 hw/mips/fuloong2e: Move code and update a comment hw/mips/fuloong2e: Fix typo in Fuloong machine name hw/mips/mips_int: De-duplicate KVM interrupt delivery docs/system/deprecated.rst | 5 ++ docs/system/target-mips.rst | 2 +- default-configs/mips64el-softmmu.mak | 2 +- hw/isa/vt82c686.c | 2 +- hw/mips/{mips_fulong2e.c =3D> fuloong2e.c} | 48 ++++++------- hw/mips/{mips_jazz.c =3D> jazz.c} | 0 hw/mips/{mips_malta.c =3D> malta.c} | 14 ++-- hw/mips/mips_int.c | 11 +-- hw/mips/{mips_mipssim.c =3D> mipssim.c} | 0 hw/mips/{mips_r4k.c =3D> r4k.c} | 0 hw/pci-host/bonito.c | 87 +++++++++++++++++++----- tests/qtest/endianness-test.c | 2 +- .mailmap | 3 +- MAINTAINERS | 26 +++---- hw/mips/Kconfig | 3 +- hw/mips/Makefile.objs | 10 +-- hw/pci-host/Kconfig | 5 ++ hw/pci-host/Makefile.objs | 2 +- 18 files changed, 142 insertions(+), 80 deletions(-) rename hw/mips/{mips_fulong2e.c =3D> fuloong2e.c} (91%) rename hw/mips/{mips_jazz.c =3D> jazz.c} (100%) rename hw/mips/{mips_malta.c =3D> malta.c} (99%) rename hw/mips/{mips_mipssim.c =3D> mipssim.c} (100%) rename hw/mips/{mips_r4k.c =3D> r4k.c} (100%) --=20 2.21.3

2 15

[PATCH v2] security: don't fail if built without attr support
by Christian Ehrhardt 27 May '20

27 May '20

If built without attr support removing any image will trigger qemuBlockRemoveImageMetadata (the one that emits the warning) -> qemuSecurityMoveImageMetadata -> virSecurityManagerMoveImageMetadata -> virSecurityDACMoveImageMetadata -> virSecurityDACMoveImageMetadataHelper -> virProcessRunInFork (spawns subprocess) -> virSecurityMoveRememberedLabel In there due to !HAVE_LIBATTR virFileGetXAttrQuiet will return ENOSYS and from there the chain will error out. That is wrong and looks like: libvirtd[6320]: internal error: child reported (status=125): libvirtd[6320]: Unable to remove disk metadata on vm testguest from /var/lib/uvtool/libvirt/images/testguest.qcow (disk target vda) This change makes virSecurityDACMoveImageMetadataHelper and virSecuritySELinuxMoveImageMetadataHelper accept that error code gracefully and in that sense it is an extension of: 5214b2f1a3f "security: Don't skip label restore on file systems lacking XATTRs" which does the same for other call chains into the virFile*XAttr functions. Signed-off-by: Christian Ehrhardt <christian.ehrhardt(a)canonical.com> Reviewed-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/security/security_dac.c | 6 ++++++ src/security/security_selinux.c | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/src/security/security_dac.c b/src/security/security_dac.c index bdc2d7edf3..7b95a6f86d 100644 --- a/src/security/security_dac.c +++ b/src/security/security_dac.c @@ -1117,6 +1117,12 @@ virSecurityDACMoveImageMetadataHelper(pid_t pid G_GNUC_UNUSED, ret = virSecurityMoveRememberedLabel(SECURITY_DAC_NAME, data->src, data->dst); virSecurityManagerMetadataUnlock(data->mgr, &state); + + if (ret == -2) { + /* Libvirt built without XATTRS */ + ret = 0; + } + return ret; } diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index 9a929debe1..7bb7c2b7b1 100644 --- a/src/security/security_selinux.c +++ b/src/security/security_selinux.c @@ -1975,6 +1975,12 @@ virSecuritySELinuxMoveImageMetadataHelper(pid_t pid G_GNUC_UNUSED, ret = virSecurityMoveRememberedLabel(SECURITY_SELINUX_NAME, data->src, data->dst); virSecurityManagerMetadataUnlock(data->mgr, &state); + + if (ret == -2) { + /* Libvirt built without XATTRS */ + ret = 0; + } + return ret; } -- 2.26.0

1 1

[PATCH 00/14] hw/mips: patch queue for 2020-05-26
by Philippe Mathieu-Daudé 27 May '20

27 May '20

Hi, This is the current state of my hw/mips/next tree. - MAINTAINERS updated to welcome Huacai Chen and Jiaxun Yang, and update Aleksandar Rikalo's email address, - Trivial improvements in the Bonito64 North Bridge and the Fuloong 2e machine, - MIPS Machines names unified without 'mips_' prefix. The following patches need review: - #6 "hw/pci-host/bonito: Map the different PCI ranges more detailled" - #10 "hw/mips/fuloong2e: Fix typo in Fuloong machine name" Aleksandar Markovic (3): hw/mips: Rename malta/mipssim/r4k/jazz files hw/mips/malta: Add some logging for bad register offset cases MAINTAINERS: Change Aleksandar Rikalo's email address Huacai Chen (1): MAINTAINERS: Add Huacai Chen as fuloong2e co-maintainer Philippe Mathieu-Daudé (10): hw/pci-host: Use CONFIG_PCI_BONITO to select the Bonito North Bridge hw/pci-host/bonito: Fix DPRINTF() format strings hw/pci-host/bonito: Map peripheral using physical address hw/pci-host/bonito: Map all the Bonito64 I/O range hw/pci-host/bonito: Map the different PCI ranges more detailled hw/pci-host/bonito: Better describe the I/O CS regions hw/pci-host/bonito: Set the Config register reset value with FIELD_DP32 hw/mips/fuloong2e: Move code and update a comment hw/mips/fuloong2e: Fix typo in Fuloong machine name hw/mips/mips_int: De-duplicate KVM interrupt delivery docs/system/deprecated.rst | 5 ++ docs/system/target-mips.rst | 2 +- default-configs/mips64el-softmmu.mak | 2 +- hw/isa/vt82c686.c | 2 +- hw/mips/{mips_fulong2e.c => fuloong2e.c} | 48 ++++++------- hw/mips/{mips_jazz.c => jazz.c} | 0 hw/mips/{mips_malta.c => malta.c} | 14 ++-- hw/mips/mips_int.c | 11 +-- hw/mips/{mips_mipssim.c => mipssim.c} | 0 hw/mips/{mips_r4k.c => r4k.c} | 0 hw/pci-host/bonito.c | 87 +++++++++++++++++++----- tests/qtest/endianness-test.c | 2 +- .mailmap | 3 +- MAINTAINERS | 26 +++---- hw/mips/Kconfig | 3 +- hw/mips/Makefile.objs | 10 +-- hw/pci-host/Kconfig | 5 ++ hw/pci-host/Makefile.objs | 2 +- 18 files changed, 142 insertions(+), 80 deletions(-) rename hw/mips/{mips_fulong2e.c => fuloong2e.c} (91%) rename hw/mips/{mips_jazz.c => jazz.c} (100%) rename hw/mips/{mips_malta.c => malta.c} (99%) rename hw/mips/{mips_mipssim.c => mipssim.c} (100%) rename hw/mips/{mips_r4k.c => r4k.c} (100%) -- 2.21.3

3 29

[PATCH v2.1 0/3] Support network interface downscript
by Chen Hanxiao 26 May '20

26 May '20

QEMU has the ability to run a script when a NIC is brought up and down. Libvirt only enables use of the up script at this time. This series add support for postscript when NIC is down/detached. Chen Hanxiao (3): interface: introduce downscript downscript: add support for booting and hotplug interface news: add description about downscript docs/formatdomain.html.in | 6 ++- docs/news.xml | 10 +++++ docs/schemas/domaincommon.rng | 8 ++++ src/conf/domain_conf.c | 9 ++++ src/conf/domain_conf.h | 1 + src/qemu/qemu_extdevice.c | 4 ++ src/qemu/qemu_hotplug.c | 3 ++ tests/qemuxml2argvdata/downscript.xml | 60 +++++++++++++++++++++++++ tests/qemuxml2xmloutdata/downscript.xml | 60 +++++++++++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 10 files changed, 161 insertions(+), 1 deletion(-) create mode 100644 tests/qemuxml2argvdata/downscript.xml create mode 100644 tests/qemuxml2xmloutdata/downscript.xml -- 2.23.0

2 6

[PATCH 0/8] qemu: Use memory-backend-* for regular guest memory
by Michal Privoznik 26 May '20

26 May '20

DISCLAIMER: These patches depend on a yet not merged QEMU patch: https://lists.nongnu.org/archive/html/qemu-devel/2020-05/msg07255.html This is another round of patches that are adapting Libvirt to new QEMU command line so that they can deprecate the old one. See 8/8 for explanation. Michal Prívozník (8): qemuBuildMemoryBackendProps: Move @prealloc setting to backend agnostic part qemuBuildMemoryBackendProps: Respect //memoryBacking/allocation/@mode=immediate qemuBuildMemoryBackendProps: Prealloc mem for memfd backend qemuBuildMemoryBackendProps: Fix const correctness qemu: Introduce QEMU_CAPS_MACHINE_MEMORY_BACKEND qemu: Track default-ram-id machine attribute qemucapabilitiestest: Update 5.1.0 data qemu: Use memory-backend-* for regular guest memory src/qemu/qemu_capabilities.c | 42 ++- src/qemu/qemu_capabilities.h | 6 + src/qemu/qemu_capspriv.h | 3 +- src/qemu/qemu_command.c | 98 ++++-- src/qemu/qemu_command.h | 4 +- src/qemu/qemu_monitor.c | 1 + src/qemu/qemu_monitor.h | 1 + src/qemu/qemu_monitor_json.c | 11 + .../caps_5.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 + .../caps_5.0.0.riscv64.xml | 1 + .../caps_5.0.0.x86_64.xml | 1 + .../caps_5.1.0.x86_64.replies | 280 ++++++++++++------ .../caps_5.1.0.x86_64.xml | 181 +++++------ .../blkdeviotune-group-num.x86_64-latest.args | 3 +- ...blkdeviotune-max-length.x86_64-latest.args | 3 +- .../blkdeviotune-max.x86_64-latest.args | 3 +- .../channel-unix-guestfwd.x86_64-latest.args | 3 +- .../console-virtio-unix.x86_64-latest.args | 3 +- .../controller-virtio-scsi.x86_64-latest.args | 3 +- ...-Icelake-Server-pconfig.x86_64-latest.args | 3 +- .../cpu-translation.x86_64-latest.args | 3 +- .../disk-aio-io_uring.x86_64-latest.args | 3 +- .../disk-aio.x86_64-latest.args | 3 +- ...-backing-chains-noindex.x86_64-latest.args | 3 +- .../disk-cache.x86_64-latest.args | 4 +- .../disk-cdrom-bus-other.x86_64-latest.args | 3 +- ...m-empty-network-invalid.x86_64-latest.args | 3 +- .../disk-cdrom-network.x86_64-latest.args | 3 +- .../disk-cdrom-tray.x86_64-latest.args | 3 +- .../disk-cdrom.x86_64-latest.args | 3 +- .../disk-copy_on_read.x86_64-latest.args | 3 +- .../disk-detect-zeroes.x86_64-latest.args | 3 +- .../disk-discard.x86_64-latest.args | 3 +- .../disk-error-policy.x86_64-latest.args | 3 +- .../disk-floppy-q35-2_11.x86_64-latest.args | 4 +- .../disk-floppy-q35-2_9.x86_64-latest.args | 4 +- .../disk-floppy.x86_64-latest.args | 3 +- .../disk-network-gluster.x86_64-latest.args | 3 +- .../disk-network-http.x86_64-latest.args | 3 +- .../disk-network-iscsi.x86_64-latest.args | 3 +- .../disk-network-nbd.x86_64-latest.args | 3 +- .../disk-network-rbd.x86_64-latest.args | 3 +- .../disk-network-sheepdog.x86_64-latest.args | 3 +- ...isk-network-source-auth.x86_64-latest.args | 3 +- .../disk-network-tlsx509.x86_64-latest.args | 3 +- .../disk-nvme.x86_64-latest.args | 3 +- .../disk-readonly-disk.x86_64-latest.args | 3 +- .../disk-scsi-device-auto.x86_64-latest.args | 3 +- .../disk-scsi.x86_64-latest.args | 3 +- .../disk-shared.x86_64-latest.args | 3 +- .../disk-slices.x86_64-latest.args | 3 +- ...irtio-scsi-reservations.x86_64-latest.args | 3 +- .../eoi-disabled.x86_64-latest.args | 3 +- .../eoi-enabled.x86_64-latest.args | 3 +- .../floppy-drive-fat.x86_64-latest.args | 3 +- .../qemuxml2argvdata/fs9p.x86_64-latest.args | 3 +- .../genid-auto.x86_64-latest.args | 3 +- .../qemuxml2argvdata/genid.x86_64-latest.args | 3 +- ...egl-headless-rendernode.x86_64-latest.args | 3 +- .../graphics-egl-headless.x86_64-latest.args | 3 +- ...pice-gl-auto-rendernode.x86_64-latest.args | 3 +- ...graphics-vnc-tls-secret.x86_64-latest.args | 3 +- .../graphics-vnc-tls.x86_64-latest.args | 3 +- ...tdev-mdev-display-ramfb.x86_64-latest.args | 3 +- ...play-spice-egl-headless.x86_64-latest.args | 3 +- ...ev-display-spice-opengl.x86_64-latest.args | 3 +- ...isplay-vnc-egl-headless.x86_64-latest.args | 3 +- ...ostdev-mdev-display-vnc.x86_64-latest.args | 3 +- .../qemuxml2argvdata/hugepages-memaccess.args | 30 +- .../hugepages-memaccess2.args | 12 +- .../hugepages-numa-nodeset-part.args | 5 +- .../hugepages-numa-nodeset.args | 20 +- .../hugepages-nvdimm.x86_64-latest.args | 15 +- tests/qemuxml2argvdata/hugepages-shared.args | 24 +- .../hyperv-off.x86_64-latest.args | 3 +- .../hyperv-panic.x86_64-latest.args | 3 +- .../hyperv-stimer-direct.x86_64-latest.args | 3 +- .../hyperv.x86_64-latest.args | 3 +- ...ntel-iommu-caching-mode.x86_64-latest.args | 4 +- ...ntel-iommu-device-iotlb.x86_64-latest.args | 4 +- .../intel-iommu-eim.x86_64-latest.args | 4 +- .../intel-iommu.x86_64-latest.args | 3 +- ...threads-virtio-scsi-pci.x86_64-latest.args | 3 +- .../kvmclock+eoi-disabled.x86_64-latest.args | 3 +- ...luks-disks-source-qcow2.x86_64-latest.args | 4 +- ...memory-default-hugepage.x86_64-latest.args | 8 +- .../memfd-memory-numa.x86_64-latest.args | 8 +- .../memory-hotplug-dimm-addr.args | 6 +- .../qemuxml2argvdata/memory-hotplug-dimm.args | 6 +- ...y-hotplug-nvdimm-access.x86_64-latest.args | 8 +- ...ry-hotplug-nvdimm-align.x86_64-latest.args | 8 +- ...ry-hotplug-nvdimm-label.x86_64-latest.args | 8 +- ...ory-hotplug-nvdimm-pmem.x86_64-latest.args | 8 +- ...ory-hotplug-nvdimm-ppc64.ppc64-latest.args | 2 +- ...hotplug-nvdimm-readonly.x86_64-latest.args | 8 +- .../memory-hotplug-nvdimm.x86_64-latest.args | 6 +- .../mlock-off.x86_64-latest.args | 3 +- .../mlock-on.x86_64-latest.args | 3 +- .../net-vhostuser.x86_64-latest.args | 3 +- .../os-firmware-bios.x86_64-latest.args | 4 +- ...os-firmware-efi-secboot.x86_64-latest.args | 4 +- .../os-firmware-efi.x86_64-latest.args | 4 +- .../qemuxml2argvdata/pages-dimm-discard.args | 4 +- .../parallel-unix-chardev.x86_64-latest.args | 3 +- ...cie-root-port-nohotplug.x86_64-latest.args | 3 +- .../pv-spinlock-disabled.x86_64-latest.args | 3 +- .../pv-spinlock-enabled.x86_64-latest.args | 3 +- .../qemu-ns.x86_64-latest.args | 3 +- .../serial-unix-chardev.x86_64-latest.args | 3 +- ...rtcard-passthrough-unix.x86_64-latest.args | 3 +- .../tpm-emulator-tpm2-enc.x86_64-latest.args | 4 +- .../tpm-emulator-tpm2.x86_64-latest.args | 4 +- .../tpm-emulator.x86_64-latest.args | 4 +- .../tpm-passthrough-crb.x86_64-latest.args | 4 +- .../tpm-passthrough.x86_64-latest.args | 4 +- .../tseg-explicit-size.x86_64-latest.args | 4 +- .../usb-redir-unix.x86_64-latest.args | 3 +- tests/qemuxml2argvdata/user-aliases.args | 16 +- ...vhost-user-fs-fd-memory.x86_64-latest.args | 4 +- ...vhost-user-fs-hugepages.x86_64-latest.args | 10 +- ...host-user-gpu-secondary.x86_64-latest.args | 3 +- .../vhost-user-vga.x86_64-latest.args | 3 +- .../vhost-vsock-auto.x86_64-latest.args | 4 +- .../vhost-vsock.x86_64-latest.args | 3 +- ...eo-bochs-display-device.x86_64-latest.args | 3 +- ...video-qxl-device-vram64.x86_64-latest.args | 3 +- ...o-qxl-sec-device-vram64.x86_64-latest.args | 3 +- ...eo-ramfb-display-device.x86_64-latest.args | 3 +- .../virtio-9p-multidevs.x86_64-latest.args | 3 +- ...virtio-non-transitional.x86_64-latest.args | 3 +- ...-options-controller-ats.x86_64-latest.args | 3 +- ...ptions-controller-iommu.x86_64-latest.args | 3 +- ...tions-controller-packed.x86_64-latest.args | 3 +- ...virtio-options-disk-ats.x86_64-latest.args | 3 +- ...rtio-options-disk-iommu.x86_64-latest.args | 3 +- ...tio-options-disk-packed.x86_64-latest.args | 3 +- .../virtio-options-fs-ats.x86_64-latest.args | 3 +- ...virtio-options-fs-iommu.x86_64-latest.args | 3 +- ...irtio-options-fs-packed.x86_64-latest.args | 3 +- ...irtio-options-input-ats.x86_64-latest.args | 3 +- ...tio-options-input-iommu.x86_64-latest.args | 3 +- ...io-options-input-packed.x86_64-latest.args | 3 +- ...-options-memballoon-ats.x86_64-latest.args | 3 +- ...ptions-memballoon-iommu.x86_64-latest.args | 3 +- ...tions-memballoon-packed.x86_64-latest.args | 3 +- .../virtio-options-net-ats.x86_64-latest.args | 3 +- ...irtio-options-net-iommu.x86_64-latest.args | 3 +- ...rtio-options-net-packed.x86_64-latest.args | 3 +- .../virtio-options-rng-ats.x86_64-latest.args | 3 +- ...irtio-options-rng-iommu.x86_64-latest.args | 3 +- ...rtio-options-rng-packed.x86_64-latest.args | 3 +- ...irtio-options-video-ats.x86_64-latest.args | 3 +- ...tio-options-video-iommu.x86_64-latest.args | 3 +- ...io-options-video-packed.x86_64-latest.args | 3 +- .../virtio-options.x86_64-latest.args | 3 +- .../virtio-rng-builtin.x86_64-latest.args | 3 +- .../virtio-rng-egd-unix.x86_64-latest.args | 3 +- .../virtio-transitional.x86_64-latest.args | 3 +- ...-default-cpu-kvm-pc-4.2.x86_64-latest.args | 4 +- ...default-cpu-kvm-q35-4.2.x86_64-latest.args | 4 +- ...-default-cpu-tcg-pc-4.2.x86_64-latest.args | 4 +- ...default-cpu-tcg-q35-4.2.x86_64-latest.args | 4 +- .../x86_64-pc-graphics.x86_64-latest.args | 3 +- .../x86_64-pc-headless.x86_64-latest.args | 3 +- .../x86_64-q35-graphics.x86_64-latest.args | 3 +- .../x86_64-q35-headless.x86_64-latest.args | 3 +- tests/testutilsqemu.c | 15 +- 168 files changed, 843 insertions(+), 436 deletions(-) -- 2.26.2

1 8

[libvirt PATCH] cpu_map: Distribute x86_Cooperlake.xml
by Jiri Denemark 26 May '20

26 May '20

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- I will push this as a build breaker once https://gitlab.com/jirkade/libvirt/pipelines/149651008 pipeline succeeds. src/cpu_map/Makefile.inc.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/cpu_map/Makefile.inc.am b/src/cpu_map/Makefile.inc.am index 5d9190e27d..62403d2ed0 100644 --- a/src/cpu_map/Makefile.inc.am +++ b/src/cpu_map/Makefile.inc.am @@ -29,6 +29,7 @@ cpumap_DATA = \ cpu_map/x86_Cascadelake-Server.xml \ cpu_map/x86_Cascadelake-Server-noTSX.xml \ cpu_map/x86_Conroe.xml \ + cpu_map/x86_Cooperlake.xml \ cpu_map/x86_core2duo.xml \ cpu_map/x86_coreduo.xml \ cpu_map/x86_cpu64-rhel5.xml \ -- 2.26.2

2 1

[PATCH] Don't require secdrivers to implement .domainMoveImageMetadata
by Michal Privoznik 26 May '20

26 May '20

The AppArmor secdriver does not use labels to grant access to resources. Therefore, it doesn't use XATTRs and hence it lacks implementation of .domainMoveImageMetadata callback. This leads to a harmless but needless error message appearing in the logs: virSecurityManagerMoveImageMetadata:476 : this function is not supported by the connection driver: virSecurityManagerMoveImageMetadata Closes: https://gitlab.com/libvirt/libvirt/-/issues/25 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/security/security_manager.c | 3 +-- src/security/security_nop.c | 10 ---------- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/src/security/security_manager.c b/src/security/security_manager.c index 2dea294784..b1237d63b6 100644 --- a/src/security/security_manager.c +++ b/src/security/security_manager.c @@ -473,8 +473,7 @@ virSecurityManagerMoveImageMetadata(virSecurityManagerPtr mgr, return ret; } - virReportUnsupportedError(); - return -1; + return 0; } diff --git a/src/security/security_nop.c b/src/security/security_nop.c index c1856eb421..d5f715b916 100644 --- a/src/security/security_nop.c +++ b/src/security/security_nop.c @@ -225,15 +225,6 @@ virSecurityDomainSetImageLabelNop(virSecurityManagerPtr mgr G_GNUC_UNUSED, return 0; } -static int -virSecurityDomainMoveImageMetadataNop(virSecurityManagerPtr mgr G_GNUC_UNUSED, - pid_t pid G_GNUC_UNUSED, - virStorageSourcePtr src G_GNUC_UNUSED, - virStorageSourcePtr dst G_GNUC_UNUSED) -{ - return 0; -} - static int virSecurityDomainSetMemoryLabelNop(virSecurityManagerPtr mgr G_GNUC_UNUSED, virDomainDefPtr def G_GNUC_UNUSED, @@ -290,7 +281,6 @@ virSecurityDriver virSecurityDriverNop = { .domainSetSecurityImageLabel = virSecurityDomainSetImageLabelNop, .domainRestoreSecurityImageLabel = virSecurityDomainRestoreImageLabelNop, - .domainMoveImageMetadata = virSecurityDomainMoveImageMetadataNop, .domainSetSecurityMemoryLabel = virSecurityDomainSetMemoryLabelNop, .domainRestoreSecurityMemoryLabel = virSecurityDomainRestoreMemoryLabelNop, -- 2.26.2

3 8

[PATCH] security: don't fail if built without attr support
by Christian Ehrhardt 26 May '20

26 May '20

If built without attr support removing any image will trigger qemuBlockRemoveImageMetadata (the one that emits the warning) -> qemuSecurityMoveImageMetadata -> virSecurityManagerMoveImageMetadata -> virSecurityDACMoveImageMetadata -> virSecurityDACMoveImageMetadataHelper -> virProcessRunInFork (spawns subprocess) -> virSecurityMoveRememberedLabel In there due to !HAVE_LIBATTR virFileGetXAttrQuiet will return ENOSYS and from there the chain will error out. That is wrong and looks like: libvirtd[6320]: internal error: child reported (status=125): libvirtd[6320]: Unable to remove disk metadata on vm testguest from /var/lib/uvtool/libvirt/images/testguest.qcow (disk target vda) This change makes virSecurityDACMoveImageMetadataHelper accept that error code gracefully and in that sense it is an extension of: 5214b2f1a3f "security: Don't skip label restore on file systems lacking XATTRs" which does the same for other call chains into the virFile*XAttr functions. Signed-off-by: Christian Ehrhardt <christian.ehrhardt(a)canonical.com> --- src/security/security_dac.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/security/security_dac.c b/src/security/security_dac.c index bdc2d7edf3..7b95a6f86d 100644 --- a/src/security/security_dac.c +++ b/src/security/security_dac.c @@ -1117,6 +1117,12 @@ virSecurityDACMoveImageMetadataHelper(pid_t pid G_GNUC_UNUSED, ret = virSecurityMoveRememberedLabel(SECURITY_DAC_NAME, data->src, data->dst); virSecurityManagerMetadataUnlock(data->mgr, &state); + + if (ret == -2) { + /* Libvirt built without XATTRS */ + ret = 0; + } + return ret; } -- 2.26.0

2 1

[libvirt PATCH] scripts: Fix E741 that pycodesyle is pointing out during syntax-check
by Erik Skultety 26 May '20

26 May '20

With newer pycodestyle 2.6.0 (which is part of flake8-3.8.2) reports the following pep violation during syntax-check: ../scripts/check-remote-protocol.py:95:9: E741 ambiguous variable name 'l' for l in err.strip().split("\n") On all the distros we test on, this hasn't occurred yet, but with the future update of flake8 it likely would. The fix is easy, just name the variable appropriately. Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- The weird thing is that E741 checking has been in pycodestyle since 2.1.0 [1], we now have 2.5.0 and yet only 2.6.0 is complaining about it [1] https://pycodestyle.pycqa.org/en/latest/developer.html#id8 scripts/check-remote-protocol.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/check-remote-protocol.py b/scripts/check-remote-protocol.py index 25caa19563..cf9e3f84a1 100644 --- a/scripts/check-remote-protocol.py +++ b/scripts/check-remote-protocol.py @@ -92,8 +92,8 @@ if out == "" or pdwtagsproc.returncode != 0: else: print("WARNING: exit code %d, pdwtags appears broken:" % pdwtagsproc.returncode, file=sys.stderr) - for l in err.strip().split("\n"): - print("WARNING: %s" % l, file=sys.stderr) + for line in err.strip().split("\n"): + print("WARNING: %s" % line, file=sys.stderr) print("WARNING: skipping the remote protocol test", file=sys.stderr) sys.exit(0) -- 2.25.4

3 4

"http://libvirt.org/schemas/domain/qemu/1.0" returns 404 error
by Yan Fu 26 May '20

26 May '20

Hello everyone, The XML namespace request website can not be accessed with 404 error: http://libvirt.org/schemas/domain/qemu/1.0 Could anyone help to fix it please? Thanks, Yan Fu

2 1

[PATCH v2 0/3] Support network interface downscript
by Chen Hanxiao 26 May '20

26 May '20

QEMU has the ability to run a script when a NIC is brought up and down. Libvirt only enables use of the up script at this time. This series add support for postscript when NIC is down/detached. Chen Hanxiao (3): interface: introduce downscript downscript: add support for booting and hotplug interface downscript: docs: add docs and news docs/formatdomain.html.in | 6 ++- docs/news.xml | 10 +++++ docs/schemas/domaincommon.rng | 8 ++++ src/conf/domain_conf.c | 9 ++++ src/conf/domain_conf.h | 1 + src/qemu/qemu_extdevice.c | 4 ++ src/qemu/qemu_hotplug.c | 3 ++ tests/qemuxml2argvdata/downscript.xml | 60 +++++++++++++++++++++++++ tests/qemuxml2xmloutdata/downscript.xml | 60 +++++++++++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 10 files changed, 161 insertions(+), 1 deletion(-) create mode 100644 tests/qemuxml2argvdata/downscript.xml create mode 100644 tests/qemuxml2xmloutdata/downscript.xml -- 2.23.0

2 4

[PATCH v2 0/1] qemuProcessRefreshCPU: skip 'host-model' code
by Daniel Henrique Barboza 25 May '20

25 May '20

changes in v2: - resending only patch 5/5 - changed the 'if' placement to qemuProcessRefreshCPU as suggested by Jiri Denemark - changed the commit msg to reflect the new intention of the patch link to v1: https://www.redhat.com/archives/libvir-list/2020-May/msg01049.html Daniel Henrique Barboza (1): qemuProcessRefreshCPU: skip 'host-model' logic for pSeries guests src/qemu/qemu_process.c | 9 +++++++++ 1 file changed, 9 insertions(+) -- 2.26.2

2 2

[libvirt PATCH 0/6] qemu: Invalidate capabilities when host CPU changes
by Jiri Denemark 25 May '20

25 May '20

The host CPU related info stored in the capabilities cache is no longer valid after the host CPU changes. This is not a frequent situation in real world, but it can easily happen in nested scenarios when a disk image is started with various CPUs. https://bugzilla.redhat.com/show_bug.cgi?id=1778819 Jiri Denemark (6): util: Define g_autoptr callback for FILE hostcpu: Introduce virHostCPUGetSignature hostcpu: Implement virHostCPUGetSignature for x86 hostcpu: Implement virHostCPUGetSignature for ppc64 hostcpu: Implement virHostCPUGetSignature for s390 qemu: Invalidate capabilities when host CPU changes src/libvirt_private.syms | 2 + src/qemu/qemu_capabilities.c | 24 ++++ src/qemu/qemu_capspriv.h | 1 + src/util/virfile.h | 1 + src/util/virhostcpu.c | 111 ++++++++++++++++++ src/util/virhostcpu.h | 2 + src/util/virhostcpupriv.h | 4 + tests/qemucapsprobe.c | 2 +- .../linux-ppc64-deconf-cpus.signature | 1 + .../linux-ppc64-subcores1.signature | 1 + .../linux-ppc64-subcores2.signature | 1 + .../linux-ppc64-subcores3.signature | 1 + .../linux-s390x-with-frequency.signature | 1 + .../linux-x86_64-test1.signature | 1 + .../linux-x86_64-test2.signature | 1 + .../linux-x86_64-test3.signature | 1 + .../linux-x86_64-test4.signature | 1 + .../linux-x86_64-test5.signature | 1 + .../linux-x86_64-test6.signature | 1 + .../linux-x86_64-test7.signature | 1 + .../linux-x86_64-test8.signature | 1 + .../linux-x86_64-with-die.signature | 1 + tests/virhostcputest.c | 42 ++++++- 23 files changed, 201 insertions(+), 2 deletions(-) create mode 100644 tests/virhostcpudata/linux-ppc64-deconf-cpus.signature create mode 100644 tests/virhostcpudata/linux-ppc64-subcores1.signature create mode 100644 tests/virhostcpudata/linux-ppc64-subcores2.signature create mode 100644 tests/virhostcpudata/linux-ppc64-subcores3.signature create mode 100644 tests/virhostcpudata/linux-s390x-with-frequency.signature create mode 100644 tests/virhostcpudata/linux-x86_64-test1.signature create mode 100644 tests/virhostcpudata/linux-x86_64-test2.signature create mode 100644 tests/virhostcpudata/linux-x86_64-test3.signature create mode 100644 tests/virhostcpudata/linux-x86_64-test4.signature create mode 100644 tests/virhostcpudata/linux-x86_64-test5.signature create mode 100644 tests/virhostcpudata/linux-x86_64-test6.signature create mode 100644 tests/virhostcpudata/linux-x86_64-test7.signature create mode 100644 tests/virhostcpudata/linux-x86_64-test8.signature create mode 100644 tests/virhostcpudata/linux-x86_64-with-die.signature -- 2.26.2

4 12

[PATCH 0/5] qemuProcessUpdateCPU: do not change 'fallback' for pSeries guests
by Daniel Henrique Barboza 25 May '20

25 May '20

Hi, Patch 5/5 contains a fix for [1]. The first 4 patches are g_auto() cleanups I made along the way while investigating the bug. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1660711 Daniel Henrique Barboza (5): cpu_conf.c: modernize virCPUDefCopyWithoutModel and virCPUDefCopy cpu_arm.c: modernize virCPUarmUpdate cpu_s390.c: modernize virCPUs390Update qemu_process.c: modernize qemuProcessUpdateCPU code path qemuProcessUpdateCPU: do not change 'fallback' to ALLOW for pSeries guests src/conf/cpu_conf.c | 22 +++++----------- src/cpu/cpu_arm.c | 14 ++++------ src/cpu/cpu_s390.c | 18 +++++-------- src/qemu/qemu_process.c | 58 +++++++++++++++++------------------------ 4 files changed, 43 insertions(+), 69 deletions(-) -- 2.26.2

2 11

[libvirt PATCH 0/3] cpu_map: Add Cooperlake x86 CPU model
by Jiri Denemark 25 May '20

25 May '20

Jiri Denemark (3): cputest: Add data for Cooperlake CPU cpu_map: Add pschange-mc-no bit in IA32_ARCH_CAPABILITIES MSR cpu_map: Add Cooperlake x86 CPU model src/cpu_map/index.xml | 1 + src/cpu_map/x86_Cooperlake.xml | 90 + src/cpu_map/x86_features.xml | 3 + tests/cputest.c | 1 + .../x86_64-cpuid-Cooperlake-disabled.xml | 7 + .../x86_64-cpuid-Cooperlake-enabled.xml | 11 + .../x86_64-cpuid-Cooperlake-guest.xml | 32 + .../x86_64-cpuid-Cooperlake-host.xml | 33 + .../x86_64-cpuid-Cooperlake-json.xml | 15 + .../cputestdata/x86_64-cpuid-Cooperlake.json | 1574 +++++++++++++++++ tests/cputestdata/x86_64-cpuid-Cooperlake.sig | 4 + tests/cputestdata/x86_64-cpuid-Cooperlake.xml | 68 + .../x86_64-cpuid-Core-i7-8550U-enabled.xml | 2 +- .../x86_64-cpuid-Core-i7-8550U-guest.xml | 1 + .../x86_64-cpuid-Core-i7-8550U-host.xml | 1 + .../x86_64-cpuid-Core-i7-8550U-json.xml | 1 + ...64-cpuid-Ryzen-9-3900X-12-Core-enabled.xml | 2 +- ...6_64-cpuid-Ryzen-9-3900X-12-Core-guest.xml | 1 + ...86_64-cpuid-Ryzen-9-3900X-12-Core-host.xml | 1 + ...86_64-cpuid-Ryzen-9-3900X-12-Core-json.xml | 1 + ...86_64-cpuid-Xeon-Platinum-9242-enabled.xml | 2 +- .../x86_64-cpuid-Xeon-Platinum-9242-json.xml | 1 + .../domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.0.0-q35.x86_64.xml | 2 + .../domaincapsdata/qemu_5.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.x86_64.xml | 2 + .../domaincapsdata/qemu_5.1.0-q35.x86_64.xml | 2 + .../domaincapsdata/qemu_5.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_5.1.0.x86_64.xml | 2 + 30 files changed, 1861 insertions(+), 3 deletions(-) create mode 100644 src/cpu_map/x86_Cooperlake.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Cooperlake-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Cooperlake-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Cooperlake-guest.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Cooperlake-host.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Cooperlake-json.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Cooperlake.json create mode 100644 tests/cputestdata/x86_64-cpuid-Cooperlake.sig create mode 100644 tests/cputestdata/x86_64-cpuid-Cooperlake.xml -- 2.26.2

2 4

[PATCH 0/3] Support network interface downscript
by Chen Hanxiao 25 May '20

25 May '20

QEMU has the ability to run a script when a NIC is brought up and down. Libvirt only enables use of the up script at this time. This series add support for postscript when NIC is down/detached. Chen Hanxiao (3): downscript: Support network interface downscript downscript: add test case doc: downscript: updating the documentation docs/formatdomain.html.in | 6 ++- docs/schemas/domaincommon.rng | 8 ++++ src/conf/domain_conf.c | 9 ++++ src/conf/domain_conf.h | 1 + src/qemu/qemu_extdevice.c | 4 ++ src/qemu/qemu_hotplug.c | 6 +++ tests/qemuxml2argvdata/downscript.xml | 60 +++++++++++++++++++++++++ tests/qemuxml2xmloutdata/downscript.xml | 60 +++++++++++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 9 files changed, 154 insertions(+), 1 deletion(-) create mode 100644 tests/qemuxml2argvdata/downscript.xml create mode 100644 tests/qemuxml2xmloutdata/downscript.xml -- 2.23.0

2 7

[PATCH v2 1/3] libxl: Add 'permissive' option for PCI devices
by Marek Marczykowski-Górecki 23 May '20

23 May '20

From: Simon Gaiser <simon(a)invisiblethingslab.com> By setting the permissive flag the Xen guest access to the PCI config space is not filtered. This might be a security risk, but it's required for some devices and the IOMMU and interrupt remapping should (mostly?) contain it. Because of it (and that the attribute is Xen only), in an example include "permissive='no'" - to not expose users copying from documentation to extra risk. Example usage: <devices> ... <hostdev mode='subsystem' type='pci' managed='yes' permissive='yes'> <source> <address domain='0x0000' bus='0x06' slot='0x02' function='0x0'/> </source> </hostdev> </devices> Signed-off-by: Simon Gaiser <simon(a)invisiblethingslab.com> Signed-off-by: Marek Marczykowski-Górecki <marmarek(a)invisiblethingslab.com> --- Changes in v2: - improve documentation (version info, example) - update schema - use virTristateBool - add a test - improve commit message - news entry --- docs/formatdomain.html.in | 7 +++++-- docs/news.xml | 11 +++++++++++- docs/schemas/domaincommon.rng | 10 ++++++++++- src/conf/domain_conf.c | 19 +++++++++++++++++++- src/conf/domain_conf.h | 1 +- src/libxl/libxl_conf.c | 1 +- tests/libxlxml2domconfigdata/moredevs-hvm.json | 6 ++++++- tests/libxlxml2domconfigdata/moredevs-hvm.xml | 5 +++++- 8 files changed, 58 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index c530573..0d1146e 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -4987,7 +4987,7 @@ <pre> ... <devices> - <hostdev mode='subsystem' type='pci' managed='yes'> + <hostdev mode='subsystem' type='pci' managed='yes' permissive='no'> <source> <address domain='0x0000' bus='0x06' slot='0x02' function='0x0'/> </source> @@ -5082,7 +5082,10 @@ (or <code>virsh nodedev-detach</code> before starting the guest or hot-plugging the device and <code>virNodeDeviceReAttach</code> (or <code>virsh nodedev-reattach</code>) after hot-unplug or - stopping the guest. + stopping the guest. When <code>permissive</code> + (<span class="since">since 6.3.0, Xen only</span>) is "yes" + the pci config space access will not be filtered. This might be + a security issue. The default is "no". </dd> <dt><code>scsi</code></dt> <dd>For SCSI devices, user is responsible to make sure the device diff --git a/docs/news.xml b/docs/news.xml index 5835013..a8e992a 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -109,6 +109,17 @@ and/or fine tuned per individual host. </description> </change> + <change> + <summary> + xen: Add support for 'permissive' PCI device option + </summary> + <description> + <code>permissive</code> is a Xen-specific PCI device option that + disables config space write filtering. It is needed for proper + functioning of some devices using non-standard config space + registers. + </description> + </change> </section> <section title="Improvements"> </section> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 7f18e5b..5a71222 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -3065,6 +3065,11 @@ <ref name="virYesNo"/> </attribute> </optional> + <optional> + <attribute name="permissive"> + <ref name="virYesNo"/> + </attribute> + </optional> <interleave> <element name="source"> <optional> @@ -4899,6 +4904,11 @@ <ref name="virYesNo"/> </attribute> </optional> + <optional> + <attribute name="permissive"> + <ref name="virYesNo"/> + </attribute> + </optional> <choice> <ref name="hostdevsubsyspci"/> <ref name="hostdevsubsysusb"/> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 89cd8c5..fe1a864 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8434,6 +8434,7 @@ virDomainHostdevDefParseXMLSubsys(xmlNodePtr node, virDomainHostdevSubsysSCSIVHostPtr scsihostsrc = &def->source.subsys.u.scsi_host; virDomainHostdevSubsysMediatedDevPtr mdevsrc = &def->source.subsys.u.mdev; g_autofree char *managed = NULL; + g_autofree char *permissive = NULL; g_autofree char *sgio = NULL; g_autofree char *rawio = NULL; g_autofree char *backendStr = NULL; @@ -8449,6 +8450,15 @@ virDomainHostdevDefParseXMLSubsys(xmlNodePtr node, if ((managed = virXMLPropString(node, "managed")) != NULL) ignore_value(virStringParseYesNo(managed, &def->managed)); + if ((permissive = virXMLPropString(node, "permissive")) != NULL) { + if ((def->permissive = virTristateBoolTypeFromString(permissive)) < 0) { + virReportError(VIR_ERR_XML_ERROR, + _("unknown hostdev permissive setting '%s'"), + permissive); + return -1; + } + } + sgio = virXMLPropString(node, "sgio"); rawio = virXMLPropString(node, "rawio"); model = virXMLPropString(node, "model"); @@ -26091,6 +26101,9 @@ virDomainActualNetDefFormat(virBufferPtr buf, virDomainHostdevDefPtr hostdef = virDomainNetGetActualHostdev(def); if (hostdef && hostdef->managed) virBufferAddLit(buf, " managed='yes'"); + if (hostdef && hostdef->permissive) + virBufferAsprintf(buf, " permissive='%s'", + virTristateBoolTypeToString(hostdef->permissive)); } if (def->trustGuestRxFilters) virBufferAsprintf(buf, " trustGuestRxFilters='%s'", @@ -26279,6 +26292,9 @@ virDomainNetDefFormat(virBufferPtr buf, virBufferAsprintf(buf, "<interface type='%s'", typeStr); if (hostdef && hostdef->managed) virBufferAddLit(buf, " managed='yes'"); + if (hostdef && hostdef->permissive) + virBufferAsprintf(buf, " permissive='%s'", + virTristateBoolTypeToString(hostdef->permissive)); if (def->trustGuestRxFilters) virBufferAsprintf(buf, " trustGuestRxFilters='%s'", virTristateBoolTypeToString(def->trustGuestRxFilters)); @@ -28063,6 +28079,9 @@ virDomainHostdevDefFormat(virBufferPtr buf, if (def->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS) { virBufferAsprintf(buf, " managed='%s'", def->managed ? "yes" : "no"); + if (def->permissive) + virBufferAsprintf(buf, " permissive='%s'", + virTristateBoolTypeToString(def->permissive)); if (def->source.subsys.type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI && scsisrc->sgio) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index ecb80ef..24ec03c 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -345,6 +345,7 @@ struct _virDomainHostdevDef { bool missing; bool readonly; bool shareable; + virTristateBool permissive; union { virDomainHostdevSubsys subsys; virDomainHostdevCaps caps; diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 458dfc2..23dd0e4 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -2284,6 +2284,7 @@ libxlMakePCI(virDomainHostdevDefPtr hostdev, libxl_device_pci *pcidev) pcidev->bus = pcisrc->addr.bus; pcidev->dev = pcisrc->addr.slot; pcidev->func = pcisrc->addr.function; + pcidev->permissive = hostdev->permissive == VIR_TRISTATE_BOOL_YES; return 0; } diff --git a/tests/libxlxml2domconfigdata/moredevs-hvm.json b/tests/libxlxml2domconfigdata/moredevs-hvm.json index 7bfd68b..474aa2c 100644 --- a/tests/libxlxml2domconfigdata/moredevs-hvm.json +++ b/tests/libxlxml2domconfigdata/moredevs-hvm.json @@ -88,6 +88,12 @@ "dev": 16, "bus": 10, "rdm_policy": "invalid" + }, + { + "dev": 8, + "bus": 10, + "permissive": true, + "rdm_policy": "invalid" } ], "vfbs": [ diff --git a/tests/libxlxml2domconfigdata/moredevs-hvm.xml b/tests/libxlxml2domconfigdata/moredevs-hvm.xml index f7eb09f..1b6b738 100644 --- a/tests/libxlxml2domconfigdata/moredevs-hvm.xml +++ b/tests/libxlxml2domconfigdata/moredevs-hvm.xml @@ -48,6 +48,11 @@ <address type='pci' domain='0x0000' bus='0x0a' slot='0x10' function='0x0'/> </source> </interface> + <hostdev mode='subsystem' type='pci' managed='yes' permissive='yes'> + <source> + <address domain='0x0000' bus='0x0a' slot='0x08' function='0x0'/> + </source> + </hostdev> <graphics type='vnc'/> <video> <model type='cirrus' vram='8192' heads='1' primary='yes'/> base-commit: c3ace7e234ccd43d5a008d93e122e6d47cd58e17 -- git-series 0.9.1

3 7

[PATCH] docs: Fix a typo in formatdomain.html
by Han Han 22 May '20

22 May '20

Signed-off-by: Han Han <hhan(a)redhat.com> --- docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 23eb0292..05a1ed45 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -7039,7 +7039,7 @@ qemu-kvm -net nic,model=? /dev/null <input type='keyboard' bus='virtio'/> <input type='tablet' bus='virtio'/> <input type='passthrough' bus='virtio'> - <source evdev='/dev/input/event1/> + <source evdev='/dev/input/event1'/> </input> </devices> ...</pre> -- 2.25.0

2 1