- Devel - libvirt List Archives

[PATCH] RFC: fix error message in virMigrate3 if connection is broken
by Nikolay Shirokovskiy 24 Sep '20

24 Sep '20

Currently virDomainMigrate3 reports "this function is not supported by the connection driver: virDomainMigrate3" if connection to destination for example is broken. This is a bit misleading. This is a result of we treat errors as unsupported feature in VIR_DRV_SUPPORTS_FEATURE macro. So let's handle errors instead. In order to keep logic clean as before there are new helper functions virDrvSupportsFeature/virDrvNSupportsFeature. They allow to keep if/else if structure of feature tests. I guess all the other occurences of VIR_DRV_SUPPORTS_FEATURE need to be replaced with one these new helper functions so that we detect error early and not have issues similar to virDomainMigrate3. I'm going to fix the other places if this RFC is approved. --- src/datatypes.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++ src/datatypes.h | 7 +++++ src/libvirt-domain.c | 76 +++++++++++++++++++++++++++++++--------------------- 3 files changed, 123 insertions(+), 30 deletions(-) diff --git a/src/datatypes.c b/src/datatypes.c index 1db38c5..3fb71f4 100644 --- a/src/datatypes.c +++ b/src/datatypes.c @@ -1257,3 +1257,73 @@ virAdmClientDispose(void *obj) virObjectUnref(clt->srv); } + + +/* + * Tests if feature is supported by connection. If testing failed + * due to error then function returns true as well and set @err flag + * to true. Thus positive result should be checked for an error. + * If @err is already set to true then no checking is done and + * the function returns true immediately so that previous error + * is not overwritten. + * + * Returns: + * true feature is supported or testing hit error + * false feature is not supported + */ +bool +virDrvSupportsFeature(virConnectPtr conn, + virDrvFeature feature, + bool *err) +{ + int rc; + + if (*err) + return true; + + if (!conn->driver->connectSupportsFeature) + return false; + + if ((rc = conn->driver->connectSupportsFeature(conn, feature)) < 0) { + *err = true; + return true; + } + + return rc > 0 ? true : false; +} + + +/* + * Tests if feature is NOT supported by connection. If testing failed + * due to error then function returns true as well and set @err flag + * to true. Thus positive result should be checked for an error. + * If @err is already set to true then no checking is done and + * the function returns true immediately so that previous error + * is not overwritten. + * + * Note that this function is not merge negation of virDrvSupportsFeature. + * + * Returns: + * true feature is not supported or testing hit error + * false feature is supported + */ +bool +virDrvNSupportsFeature(virConnectPtr conn, + virDrvFeature feature, + bool *err) +{ + int rc; + + if (*err) + return true; + + if (!conn->driver->connectSupportsFeature) + return true; + + if ((rc = conn->driver->connectSupportsFeature(conn, feature)) < 0) { + *err = true; + return true; + } + + return rc > 0 ? false : true; +} diff --git a/src/datatypes.h b/src/datatypes.h index ade3779..e468d92 100644 --- a/src/datatypes.h +++ b/src/datatypes.h @@ -871,3 +871,10 @@ int virAdmConnectCloseCallbackDataRegister(virAdmConnectCloseCallbackDataPtr cbd virFreeCallback freecb); int virAdmConnectCloseCallbackDataUnregister(virAdmConnectCloseCallbackDataPtr cbdata, virAdmConnectCloseFunc cb); + +bool virDrvSupportsFeature(virConnectPtr conn, + virDrvFeature feature, + bool *err); +bool virDrvNSupportsFeature(virConnectPtr conn, + virDrvFeature feature, + bool *err); diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index cde86c7..f4f626a 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -3846,6 +3846,7 @@ virDomainMigrate3(virDomainPtr domain, const char *dname = NULL; const char *dxml = NULL; unsigned long long bandwidth = 0; + bool err = false; VIR_DOMAIN_DEBUG(domain, "dconn=%p, params=%p, nparms=%u flags=0x%x", dconn, params, nparams, flags); @@ -3878,18 +3879,20 @@ virDomainMigrate3(virDomainPtr domain, } if (flags & VIR_MIGRATE_OFFLINE) { - if (!VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, - VIR_DRV_FEATURE_MIGRATION_OFFLINE)) { - virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", - _("offline migration is not supported by " - "the source host")); + if (virDrvNSupportsFeature(domain->conn, + VIR_DRV_FEATURE_MIGRATION_OFFLINE, &err)) { + if (!err) + virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", + _("offline migration is not supported by " + "the source host")); goto error; } - if (!VIR_DRV_SUPPORTS_FEATURE(dconn->driver, dconn, - VIR_DRV_FEATURE_MIGRATION_OFFLINE)) { - virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", - _("offline migration is not supported by " - "the destination host")); + if (virDrvNSupportsFeature(dconn, + VIR_DRV_FEATURE_MIGRATION_OFFLINE, &err)) { + if (!err) + virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", + _("offline migration is not supported by " + "the destination host")); goto error; } } @@ -3900,20 +3903,25 @@ virDomainMigrate3(virDomainPtr domain, * migration from newer source to an older destination that * rejects the flag. */ if (flags & VIR_MIGRATE_CHANGE_PROTECTION && - !VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, - VIR_DRV_FEATURE_MIGRATE_CHANGE_PROTECTION)) { - virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", - _("cannot enforce change protection")); + virDrvNSupportsFeature(domain->conn, + VIR_DRV_FEATURE_MIGRATE_CHANGE_PROTECTION, + &err)) { + if (!err) + virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", + _("cannot enforce change protection")); goto error; } flags &= ~VIR_MIGRATE_CHANGE_PROTECTION; /* Prefer extensible API but fall back to older migration APIs if params * only contains parameters which were supported by the older API. */ - if (VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, - VIR_DRV_FEATURE_MIGRATION_PARAMS) && - VIR_DRV_SUPPORTS_FEATURE(dconn->driver, dconn, - VIR_DRV_FEATURE_MIGRATION_PARAMS)) { + if (virDrvSupportsFeature(domain->conn, + VIR_DRV_FEATURE_MIGRATION_PARAMS, &err) && + virDrvSupportsFeature(dconn, + VIR_DRV_FEATURE_MIGRATION_PARAMS, &err)) { + if (err) + goto error; + VIR_DEBUG("Using migration protocol 3 with extensible parameters"); ddomain = virDomainMigrateVersion3Params(domain, dconn, params, nparams, flags); @@ -3939,17 +3947,22 @@ virDomainMigrate3(virDomainPtr domain, goto error; } - if (VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, - VIR_DRV_FEATURE_MIGRATION_V3) && - VIR_DRV_SUPPORTS_FEATURE(dconn->driver, dconn, - VIR_DRV_FEATURE_MIGRATION_V3)) { + if (virDrvSupportsFeature(domain->conn, + VIR_DRV_FEATURE_MIGRATION_V3, &err) && + virDrvSupportsFeature(dconn, VIR_DRV_FEATURE_MIGRATION_V3, &err)) { + if (err) + goto error; + VIR_DEBUG("Using migration protocol 3"); ddomain = virDomainMigrateVersion3(domain, dconn, dxml, flags, dname, uri, bandwidth); - } else if (VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, - VIR_DRV_FEATURE_MIGRATION_V2) && - VIR_DRV_SUPPORTS_FEATURE(dconn->driver, dconn, - VIR_DRV_FEATURE_MIGRATION_V2)) { + } else if (virDrvSupportsFeature(domain->conn, + VIR_DRV_FEATURE_MIGRATION_V2, &err) && + virDrvSupportsFeature(dconn, + VIR_DRV_FEATURE_MIGRATION_V2, &err)) { + if (err) + goto error; + VIR_DEBUG("Using migration protocol 2"); if (dxml) { virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", @@ -3959,10 +3972,13 @@ virDomainMigrate3(virDomainPtr domain, } ddomain = virDomainMigrateVersion2(domain, dconn, flags, dname, uri, bandwidth); - } else if (VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, - VIR_DRV_FEATURE_MIGRATION_V1) && - VIR_DRV_SUPPORTS_FEATURE(dconn->driver, dconn, - VIR_DRV_FEATURE_MIGRATION_V1)) { + } else if (virDrvSupportsFeature(domain->conn, + VIR_DRV_FEATURE_MIGRATION_V1, &err) && + virDrvSupportsFeature(dconn, + VIR_DRV_FEATURE_MIGRATION_V1, &err)) { + if (err) + goto error; + VIR_DEBUG("Using migration protocol 1"); if (dxml) { virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", -- 1.8.3.1

2 2

[PATCH] libxl: use b_info->{acpi,acpi} when available
by Marek Marczykowski-Górecki 24 Sep '20

24 Sep '20

b_info->u.hvm.{acpi,apic} are deprecated. But also, on recent libxl version (4.14) the old one seems to be broken. While libxl part should be fixed too, update the usage here and at some point drop support for the old version. b_info->acpi was added in Xen 4.8 b_info->apic was added in Xen 4.10 Xen 4.10 is the oldest version that still has security support (until December 2020). Signed-off-by: Marek Marczykowski-Górecki <marmarek(a)invisiblethingslab.com> --- src/libxl/libxl_conf.c | 13 +++++++++++++ tests/libxlxml2domconfigdata/basic-hvm.json | 4 ++-- tests/libxlxml2domconfigdata/cpu-shares-hvm.json | 4 ++-- .../libxlxml2domconfigdata/fullvirt-acpi-slic.json | 4 ++-- .../fullvirt-cpuid-legacy-nest.json | 4 ++-- tests/libxlxml2domconfigdata/fullvirt-cpuid.json | 4 ++-- .../max-eventchannels-hvm.json | 4 ++-- tests/libxlxml2domconfigdata/max-gntframes-hvm.json | 4 ++-- tests/libxlxml2domconfigdata/moredevs-hvm.json | 4 ++-- .../libxlxml2domconfigdata/variable-clock-hvm.json | 4 ++-- .../vnuma-hvm-legacy-nest.json | 4 ++-- tests/libxlxml2domconfigdata/vnuma-hvm.json | 4 ++-- 12 files changed, 35 insertions(+), 22 deletions(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index befd5eb965..5b729a019a 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -508,12 +508,25 @@ libxlMakeDomBuildInfo(virDomainDefPtr def, libxl_defbool_set(&b_info->u.hvm.pae, def->features[VIR_DOMAIN_FEATURE_PAE] == VIR_TRISTATE_SWITCH_ON); +#ifdef LIBXL_HAVE_BUILDINFO_APIC + libxl_defbool_set(&b_info->apic, + def->features[VIR_DOMAIN_FEATURE_APIC] == + VIR_TRISTATE_SWITCH_ON); + /* + * Strictly speaking b_info->acpi was introduced earlier (Xen 4.8), but + * there is no separate #define in libxl.h. + */ + libxl_defbool_set(&b_info->acpi, + def->features[VIR_DOMAIN_FEATURE_ACPI] == + VIR_TRISTATE_SWITCH_ON); +#else libxl_defbool_set(&b_info->u.hvm.apic, def->features[VIR_DOMAIN_FEATURE_APIC] == VIR_TRISTATE_SWITCH_ON); libxl_defbool_set(&b_info->u.hvm.acpi, def->features[VIR_DOMAIN_FEATURE_ACPI] == VIR_TRISTATE_SWITCH_ON); +#endif /* copy SLIC table path to acpi_firmware */ if (def->os.slic_table) diff --git a/tests/libxlxml2domconfigdata/basic-hvm.json b/tests/libxlxml2domconfigdata/basic-hvm.json index ccd5853854..87f8cb7d8a 100644 --- a/tests/libxlxml2domconfigdata/basic-hvm.json +++ b/tests/libxlxml2domconfigdata/basic-hvm.json @@ -21,10 +21,10 @@ "sched_params": { }, + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "vga": { "kind": "cirrus" }, diff --git a/tests/libxlxml2domconfigdata/cpu-shares-hvm.json b/tests/libxlxml2domconfigdata/cpu-shares-hvm.json index 2e647eada2..2aa97e88c5 100644 --- a/tests/libxlxml2domconfigdata/cpu-shares-hvm.json +++ b/tests/libxlxml2domconfigdata/cpu-shares-hvm.json @@ -21,10 +21,10 @@ "sched_params": { "weight": 1500 }, + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "vga": { "kind": "cirrus" }, diff --git a/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json b/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json index f16b4a971a..a2d46797aa 100644 --- a/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json +++ b/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json @@ -14,10 +14,10 @@ "shadow_memkb": 5656, "sched_params": { }, + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "acpi_firmware": "/path/to/slic.dat", "nographic": "True", "vga": { diff --git a/tests/libxlxml2domconfigdata/fullvirt-cpuid-legacy-nest.json b/tests/libxlxml2domconfigdata/fullvirt-cpuid-legacy-nest.json index 0944476151..6290655c20 100644 --- a/tests/libxlxml2domconfigdata/fullvirt-cpuid-legacy-nest.json +++ b/tests/libxlxml2domconfigdata/fullvirt-cpuid-legacy-nest.json @@ -21,10 +21,10 @@ ], "sched_params": { }, + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "nested_hvm": "False", "nographic": "True", "vga": { diff --git a/tests/libxlxml2domconfigdata/fullvirt-cpuid.json b/tests/libxlxml2domconfigdata/fullvirt-cpuid.json index ddc423bca7..811a4f0ac7 100644 --- a/tests/libxlxml2domconfigdata/fullvirt-cpuid.json +++ b/tests/libxlxml2domconfigdata/fullvirt-cpuid.json @@ -22,10 +22,10 @@ "sched_params": { }, "nested_hvm": "False", + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "nographic": "True", "vga": { "kind": "none" diff --git a/tests/libxlxml2domconfigdata/max-eventchannels-hvm.json b/tests/libxlxml2domconfigdata/max-eventchannels-hvm.json index d5b351beb5..4a5b0ca65f 100644 --- a/tests/libxlxml2domconfigdata/max-eventchannels-hvm.json +++ b/tests/libxlxml2domconfigdata/max-eventchannels-hvm.json @@ -22,10 +22,10 @@ "sched_params": { }, + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "vga": { "kind": "cirrus" }, diff --git a/tests/libxlxml2domconfigdata/max-gntframes-hvm.json b/tests/libxlxml2domconfigdata/max-gntframes-hvm.json index ef602f09fc..2883d057ff 100644 --- a/tests/libxlxml2domconfigdata/max-gntframes-hvm.json +++ b/tests/libxlxml2domconfigdata/max-gntframes-hvm.json @@ -22,10 +22,10 @@ "sched_params": { }, + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "vga": { "kind": "cirrus" }, diff --git a/tests/libxlxml2domconfigdata/moredevs-hvm.json b/tests/libxlxml2domconfigdata/moredevs-hvm.json index 474aa2cef6..58cf32a8d4 100644 --- a/tests/libxlxml2domconfigdata/moredevs-hvm.json +++ b/tests/libxlxml2domconfigdata/moredevs-hvm.json @@ -23,10 +23,10 @@ "sched_params": { }, + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "hpet": "True", "vga": { "kind": "cirrus" diff --git a/tests/libxlxml2domconfigdata/variable-clock-hvm.json b/tests/libxlxml2domconfigdata/variable-clock-hvm.json index 69be9c64cb..9a25d51da2 100644 --- a/tests/libxlxml2domconfigdata/variable-clock-hvm.json +++ b/tests/libxlxml2domconfigdata/variable-clock-hvm.json @@ -23,10 +23,10 @@ "sched_params": { }, + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "vga": { "kind": "cirrus" }, diff --git a/tests/libxlxml2domconfigdata/vnuma-hvm-legacy-nest.json b/tests/libxlxml2domconfigdata/vnuma-hvm-legacy-nest.json index 3b2fc5f40f..6cda8d0252 100644 --- a/tests/libxlxml2domconfigdata/vnuma-hvm-legacy-nest.json +++ b/tests/libxlxml2domconfigdata/vnuma-hvm-legacy-nest.json @@ -109,10 +109,10 @@ "sched_params": { }, + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "nested_hvm": "True", "vga": { "kind": "cirrus" diff --git a/tests/libxlxml2domconfigdata/vnuma-hvm.json b/tests/libxlxml2domconfigdata/vnuma-hvm.json index 02c10a9deb..f578ccd3d3 100644 --- a/tests/libxlxml2domconfigdata/vnuma-hvm.json +++ b/tests/libxlxml2domconfigdata/vnuma-hvm.json @@ -110,10 +110,10 @@ }, "nested_hvm": "True", + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "vga": { "kind": "cirrus" }, -- 2.25.4

5 10

Help on meson build
by Wei Wang 24 Sep '20

24 Sep '20

Hi folks, I'm trying to build libvirt using meson with the latest upstream libvirt, but the compilation fails: (followed on https://libvirt.org/compiling.html, not sure if any dependencies are missed) FAILED: src/util/libvirt_util.a.p/glibcompat.c.o .... In file included from ../src/util/glibcompat.c:19: ./config.h:1026:10: fatal error: config-post.h: No such file or directory FAILED: src/util/libvirt_util.a.p/virfirmware.c.o In file included from ../src/util/virarch.c:22: ./config.h:1026:10: fatal error: config-post.h: No such file or directory FAILED: src/util/libvirt_util.a.p/viraudit.c.o In file included from ../src/util/viraudit.c:22: ./config.h:1026:10: fatal error: config-post.h: No such file or directory Any help is appreciated. Thanks, Wei

1 0

[PATCH v2 0/6] qemu: Use memory-backend-* for regular guest memory
by Michal Privoznik 24 Sep '20

24 Sep '20

v2 of: https://www.redhat.com/archives/libvir-list/2020-September/msg00023.html diff to v1: - I've dropped the capability (patch 5/7 in the original set) and am relying on qemu providing default-ram-id. I've tested migration from a daemon with these patches to a daemon without and also vice versa and it worked. Michal Prívozník (6): qemuBuildMemoryBackendProps: Move @prealloc setting to backend agnostic part qemuBuildMemoryBackendProps: Respect //memoryBacking/allocation/@mode=immediate qemuBuildMemoryBackendProps: Prealloc mem for memfd backend qemuBuildMemoryBackendProps: Fix const correctness qemu: Track default-ram-id machine attribute qemu: Use memory-backend-* for regular guest memory src/qemu/qemu_capabilities.c | 35 +++- src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_capspriv.h | 3 +- src/qemu/qemu_command.c | 96 +++++++-- src/qemu/qemu_command.h | 4 +- src/qemu/qemu_monitor.c | 1 + src/qemu/qemu_monitor.h | 1 + src/qemu/qemu_monitor_json.c | 11 + .../caps_5.2.0.x86_64.xml | 196 +++++++++--------- .../blkdeviotune-group-num.x86_64-latest.args | 3 +- ...blkdeviotune-max-length.x86_64-latest.args | 3 +- .../blkdeviotune-max.x86_64-latest.args | 3 +- .../channel-unix-guestfwd.x86_64-latest.args | 3 +- .../console-virtio-unix.x86_64-latest.args | 3 +- .../controller-virtio-scsi.x86_64-latest.args | 3 +- ...-Icelake-Server-pconfig.x86_64-latest.args | 3 +- .../cpu-translation.x86_64-latest.args | 3 +- .../cputune-cpuset-big-id.x86_64-latest.args | 3 +- .../disk-aio-io_uring.x86_64-latest.args | 3 +- .../disk-aio.x86_64-latest.args | 3 +- ...-backing-chains-noindex.x86_64-latest.args | 3 +- .../disk-cache.x86_64-latest.args | 4 +- .../disk-cdrom-bus-other.x86_64-latest.args | 3 +- ...m-empty-network-invalid.x86_64-latest.args | 3 +- .../disk-cdrom-network.x86_64-latest.args | 3 +- .../disk-cdrom-tray.x86_64-latest.args | 3 +- .../disk-cdrom.x86_64-latest.args | 3 +- .../disk-copy_on_read.x86_64-latest.args | 3 +- .../disk-detect-zeroes.x86_64-latest.args | 3 +- .../disk-discard.x86_64-latest.args | 3 +- .../disk-error-policy.x86_64-latest.args | 3 +- .../disk-floppy-q35-2_11.x86_64-latest.args | 4 +- .../disk-floppy-q35-2_9.x86_64-latest.args | 4 +- .../disk-floppy.x86_64-latest.args | 3 +- .../disk-network-gluster.x86_64-latest.args | 3 +- .../disk-network-http.x86_64-latest.args | 3 +- .../disk-network-iscsi.x86_64-latest.args | 3 +- .../disk-network-nbd.x86_64-latest.args | 3 +- .../disk-network-rbd.x86_64-latest.args | 3 +- .../disk-network-sheepdog.x86_64-latest.args | 3 +- ...isk-network-source-auth.x86_64-latest.args | 3 +- ...isk-network-tlsx509-nbd.x86_64-latest.args | 3 +- .../disk-nvme.x86_64-latest.args | 3 +- .../disk-readonly-disk.x86_64-latest.args | 3 +- .../disk-scsi-device-auto.x86_64-latest.args | 3 +- .../disk-scsi.x86_64-latest.args | 3 +- .../disk-shared.x86_64-latest.args | 3 +- .../disk-slices.x86_64-latest.args | 3 +- ...irtio-scsi-reservations.x86_64-latest.args | 3 +- .../eoi-disabled.x86_64-latest.args | 3 +- .../eoi-enabled.x86_64-latest.args | 3 +- .../floppy-drive-fat.x86_64-latest.args | 3 +- .../qemuxml2argvdata/fs9p.x86_64-latest.args | 3 +- .../genid-auto.x86_64-latest.args | 3 +- .../qemuxml2argvdata/genid.x86_64-latest.args | 3 +- ...egl-headless-rendernode.x86_64-latest.args | 3 +- .../graphics-egl-headless.x86_64-latest.args | 3 +- ...pice-gl-auto-rendernode.x86_64-latest.args | 3 +- ...graphics-vnc-tls-secret.x86_64-latest.args | 3 +- .../graphics-vnc-tls.x86_64-latest.args | 3 +- ...tdev-mdev-display-ramfb.x86_64-latest.args | 3 +- ...play-spice-egl-headless.x86_64-latest.args | 3 +- ...ev-display-spice-opengl.x86_64-latest.args | 3 +- ...isplay-vnc-egl-headless.x86_64-latest.args | 3 +- ...ostdev-mdev-display-vnc.x86_64-latest.args | 3 +- .../hostdev-scsi-lsi.x86_64-latest.args | 3 +- ...ostdev-scsi-virtio-scsi.x86_64-latest.args | 3 +- .../qemuxml2argvdata/hugepages-memaccess.args | 30 +-- .../hugepages-memaccess2.args | 12 +- .../hugepages-numa-nodeset-part.args | 5 +- .../hugepages-numa-nodeset.args | 20 +- .../hugepages-nvdimm.x86_64-latest.args | 15 +- tests/qemuxml2argvdata/hugepages-shared.args | 24 +-- .../hyperv-off.x86_64-latest.args | 3 +- .../hyperv-panic.x86_64-latest.args | 3 +- .../hyperv-stimer-direct.x86_64-latest.args | 3 +- .../hyperv.x86_64-latest.args | 3 +- .../intel-iommu-aw-bits.x86_64-latest.args | 4 +- ...ntel-iommu-caching-mode.x86_64-latest.args | 4 +- ...ntel-iommu-device-iotlb.x86_64-latest.args | 4 +- .../intel-iommu-eim.x86_64-latest.args | 4 +- .../intel-iommu.x86_64-latest.args | 3 +- ...threads-virtio-scsi-pci.x86_64-latest.args | 3 +- .../kvmclock+eoi-disabled.x86_64-latest.args | 3 +- ...luks-disks-source-qcow2.x86_64-latest.args | 4 +- ...memory-default-hugepage.x86_64-latest.args | 8 +- .../memfd-memory-numa.x86_64-latest.args | 8 +- .../memory-hotplug-dimm-addr.args | 6 +- .../qemuxml2argvdata/memory-hotplug-dimm.args | 6 +- ...y-hotplug-nvdimm-access.x86_64-latest.args | 8 +- ...ry-hotplug-nvdimm-align.x86_64-latest.args | 8 +- ...ry-hotplug-nvdimm-label.x86_64-latest.args | 8 +- ...ory-hotplug-nvdimm-pmem.x86_64-latest.args | 8 +- ...ory-hotplug-nvdimm-ppc64.ppc64-latest.args | 2 +- ...hotplug-nvdimm-readonly.x86_64-latest.args | 8 +- .../memory-hotplug-nvdimm.x86_64-latest.args | 6 +- .../mlock-off.x86_64-latest.args | 3 +- .../mlock-on.x86_64-latest.args | 3 +- .../net-vhostuser.x86_64-latest.args | 3 +- .../numatune-hmat.x86_64-latest.args | 4 +- .../os-firmware-bios.x86_64-latest.args | 4 +- ...os-firmware-efi-secboot.x86_64-latest.args | 4 +- .../os-firmware-efi.x86_64-latest.args | 4 +- .../qemuxml2argvdata/pages-dimm-discard.args | 4 +- .../parallel-unix-chardev.x86_64-latest.args | 3 +- ...cie-root-port-nohotplug.x86_64-latest.args | 3 +- .../pv-spinlock-disabled.x86_64-latest.args | 3 +- .../pv-spinlock-enabled.x86_64-latest.args | 3 +- .../qemu-ns.x86_64-latest.args | 3 +- .../serial-unix-chardev.x86_64-latest.args | 3 +- ...rtcard-passthrough-unix.x86_64-latest.args | 3 +- .../tpm-emulator-tpm2-enc.x86_64-latest.args | 4 +- .../tpm-emulator-tpm2.x86_64-latest.args | 4 +- .../tpm-emulator.x86_64-latest.args | 4 +- .../tpm-passthrough-crb.x86_64-latest.args | 4 +- .../tpm-passthrough.x86_64-latest.args | 4 +- .../tseg-explicit-size.x86_64-latest.args | 4 +- .../usb-redir-unix.x86_64-latest.args | 3 +- tests/qemuxml2argvdata/user-aliases.args | 16 +- ...vhost-user-fs-fd-memory.x86_64-latest.args | 4 +- ...vhost-user-fs-hugepages.x86_64-latest.args | 10 +- ...host-user-gpu-secondary.x86_64-latest.args | 3 +- .../vhost-user-vga.x86_64-latest.args | 3 +- .../vhost-vsock-auto.x86_64-latest.args | 4 +- .../vhost-vsock.x86_64-latest.args | 3 +- ...eo-bochs-display-device.x86_64-latest.args | 3 +- ...video-qxl-device-vram64.x86_64-latest.args | 3 +- ...o-qxl-sec-device-vram64.x86_64-latest.args | 3 +- ...eo-ramfb-display-device.x86_64-latest.args | 3 +- .../virtio-9p-multidevs.x86_64-latest.args | 3 +- ...virtio-non-transitional.x86_64-latest.args | 3 +- ...-options-controller-ats.x86_64-latest.args | 3 +- ...ptions-controller-iommu.x86_64-latest.args | 3 +- ...tions-controller-packed.x86_64-latest.args | 3 +- ...virtio-options-disk-ats.x86_64-latest.args | 3 +- ...rtio-options-disk-iommu.x86_64-latest.args | 3 +- ...tio-options-disk-packed.x86_64-latest.args | 3 +- .../virtio-options-fs-ats.x86_64-latest.args | 3 +- ...virtio-options-fs-iommu.x86_64-latest.args | 3 +- ...irtio-options-fs-packed.x86_64-latest.args | 3 +- ...irtio-options-input-ats.x86_64-latest.args | 3 +- ...tio-options-input-iommu.x86_64-latest.args | 3 +- ...io-options-input-packed.x86_64-latest.args | 3 +- ...-options-memballoon-ats.x86_64-latest.args | 3 +- ...ptions-memballoon-iommu.x86_64-latest.args | 3 +- ...tions-memballoon-packed.x86_64-latest.args | 3 +- .../virtio-options-net-ats.x86_64-latest.args | 3 +- ...irtio-options-net-iommu.x86_64-latest.args | 3 +- ...rtio-options-net-packed.x86_64-latest.args | 3 +- .../virtio-options-rng-ats.x86_64-latest.args | 3 +- ...irtio-options-rng-iommu.x86_64-latest.args | 3 +- ...rtio-options-rng-packed.x86_64-latest.args | 3 +- ...irtio-options-video-ats.x86_64-latest.args | 3 +- ...tio-options-video-iommu.x86_64-latest.args | 3 +- ...io-options-video-packed.x86_64-latest.args | 3 +- .../virtio-options.x86_64-latest.args | 3 +- .../virtio-rng-builtin.x86_64-latest.args | 3 +- .../virtio-rng-egd-unix.x86_64-latest.args | 3 +- .../virtio-transitional.x86_64-latest.args | 3 +- ...-default-cpu-kvm-pc-4.2.x86_64-latest.args | 4 +- ...default-cpu-kvm-q35-4.2.x86_64-latest.args | 4 +- ...-default-cpu-tcg-pc-4.2.x86_64-latest.args | 4 +- ...default-cpu-tcg-q35-4.2.x86_64-latest.args | 4 +- .../x86_64-pc-graphics.x86_64-latest.args | 3 +- .../x86_64-pc-headless.x86_64-latest.args | 3 +- .../x86_64-q35-graphics.x86_64-latest.args | 3 +- .../x86_64-q35-headless.x86_64-latest.args | 3 +- tests/testutilsqemu.c | 24 ++- 168 files changed, 667 insertions(+), 357 deletions(-) -- 2.26.2

2 7

[PATCH v1] qemu: monitor: substitute missing model name for host-passthrough
by Collin Walling 24 Sep '20

24 Sep '20

When executing the hypervisor-cpu-compare/baseline commands and the XML file contains a CPU definition using host-passthrough and no model name, the commands will fail and return an error message from the QMP response. Let's fix this by checking for host-passthrough and a missing model name when converting a CPU definition to a JSON object. If these conditions are matched, then the JSON object will be constructed using "host" as the model name. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1850680 Signed-off-by: Collin Walling <walling(a)linux.ibm.com> --- src/qemu/qemu_monitor_json.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 3070c1e6b3..448a3a9356 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -5804,9 +5804,20 @@ qemuMonitorJSONMakeCPUModel(virCPUDefPtr cpu, { virJSONValuePtr model = virJSONValueNewObject(); virJSONValuePtr props = NULL; + const char *model_name = cpu->model; size_t i; - if (virJSONValueObjectAppendString(model, "name", cpu->model) < 0) + if (!model_name) { + if (cpu->mode == VIR_CPU_MODE_HOST_PASSTHROUGH) { + model_name = "host"; + } else { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("cpu parameter is missing a model name")); + goto error; + } + } + + if (virJSONValueObjectAppendString(model, "name", model_name) < 0) goto error; if (cpu->nfeatures || !migratable) { -- 2.26.2

4 8

[PATCH] xen: Don't add dom0 twice on driver reload
by Jim Fehlig 24 Sep '20

24 Sep '20

When the xen driver loads, it probes libxl for some info about dom0 and adds it to the virDomainObjList. The driver then looks for any domains in stateDir and if they are still alive adds them to the list as well. This logic is a bit flawed wrt handling driver reload and causes the following error internal error: unexpected domain Domain-0 already exists A simple fix is to load all domains from stateDir first and then only add dom0 if needed. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- src/libxl/libxl_driver.c | 46 +++++++++++++++++++++++----------------- 1 file changed, 26 insertions(+), 20 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 161a6882f3..083738871d 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -604,27 +604,33 @@ libxlAddDom0(libxlDriverPrivatePtr driver) goto cleanup; } - if (!(def = virDomainDefNew())) - goto cleanup; + /* + * On a driver reload dom0 will already exist. On host restart it must + * created. + */ + if ((vm = virDomainObjListFindByID(driver->domains, 0)) == NULL) { + if (!(def = virDomainDefNew())) + goto cleanup; - def->id = 0; - def->virtType = VIR_DOMAIN_VIRT_XEN; - def->name = g_strdup("Domain-0"); + def->id = 0; + def->virtType = VIR_DOMAIN_VIRT_XEN; + def->name = g_strdup("Domain-0"); - def->os.type = VIR_DOMAIN_OSTYPE_XEN; + def->os.type = VIR_DOMAIN_OSTYPE_XEN; - if (virUUIDParse("00000000-0000-0000-0000-000000000000", def->uuid) < 0) - goto cleanup; + if (virUUIDParse("00000000-0000-0000-0000-000000000000", def->uuid) < 0) + goto cleanup; - if (!(vm = virDomainObjListAdd(driver->domains, def, - driver->xmlopt, - 0, - NULL))) - goto cleanup; - def = NULL; + if (!(vm = virDomainObjListAdd(driver->domains, def, + driver->xmlopt, + 0, + NULL))) + goto cleanup; + + vm->persistent = 1; + virDomainObjSetState(vm, VIR_DOMAIN_RUNNING, VIR_DOMAIN_RUNNING_BOOTED); + } - vm->persistent = 1; - virDomainObjSetState(vm, VIR_DOMAIN_RUNNING, VIR_DOMAIN_RUNNING_BOOTED); if (virDomainDefSetVcpusMax(vm->def, d_info.vcpu_max_id + 1, driver->xmlopt)) goto cleanup; @@ -783,10 +789,6 @@ libxlStateInitialize(bool privileged, if (!(libxl_driver->xmlopt = libxlCreateXMLConf(libxl_driver))) goto error; - /* Add Domain-0 */ - if (libxlAddDom0(libxl_driver) < 0) - goto error; - /* Load running domains first. */ if (virDomainObjListLoadAllConfigs(libxl_driver->domains, cfg->stateDir, @@ -796,6 +798,10 @@ libxlStateInitialize(bool privileged, NULL, NULL) < 0) goto error; + /* Add Domain-0 */ + if (libxlAddDom0(libxl_driver) < 0) + goto error; + libxlReconnectDomains(libxl_driver); /* Then inactive persistent configs */ -- 2.28.0

2 1

[PATCH 00/13] virStorageSourceNew failure handling and virDomainSnapshotAlignDisks refactors
by Peter Krempa 23 Sep '20

23 Sep '20

A set of patches that prevent failures from virStorageSourceNew and refactor virDomainSnapshotAlignDisks for better readability. Peter Krempa (13): virStorageSourceNew: Abort on failure virStorageVolDefParseXML: Use g_steal_pointer qemuDomainBlockRebase: Replace ternary operator with if/else qemuSnapshotCreateInactiveExternal: Don't access 'idx' of snapshot virDomainSnapshotAlignDisks: Refactor cleanup virDomainSnapshotAlignDisks: Rename 'def' -> 'snapdef' virDomainSnapshotAlignDisks: Rename 'disk' -> 'snapdisk' virDomainSnapshotAlignDisks: Add 'domdef' local variable virDomainSnapshotAlignDisks: Extract domain disk definition to a local variable virDomainSnapshotAlignDisks: remove unnecessary 'tmp' variable virDomainSnapshotAlignDisks: clarify handing of snapshot location virDomainSnapshotAlignDisks: refactor extension to all disks virDomainSnapshotDiskDef: Remove 'idx' field src/conf/backup_conf.c | 7 +- src/conf/domain_conf.c | 21 ++-- src/conf/snapshot_conf.c | 160 +++++++++++--------------- src/conf/snapshot_conf.h | 1 - src/conf/storage_conf.c | 8 +- src/qemu/qemu_domain.c | 21 ++-- src/qemu/qemu_driver.c | 18 ++- src/qemu/qemu_migration.c | 7 +- src/qemu/qemu_snapshot.c | 7 +- src/storage/storage_backend_gluster.c | 5 +- src/storage/storage_backend_logical.c | 4 +- src/storage/storage_util.c | 10 +- src/util/virstoragefile.c | 32 ++---- tests/qemublocktest.c | 16 +-- tests/virstoragetest.c | 5 +- 15 files changed, 121 insertions(+), 201 deletions(-) -- 2.26.2

3 28

[libvirt PATCHv3] tests: build SELinux tests (glib chronicles?)
by Ján Tomko 23 Sep '20

23 Sep '20

We set WITH_LIBATTR in meson.build, not WITH_ATTR. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> Fixes: 3ace72965c3b11fc763f781ae7ce3ca29dd36507 --- tests/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/meson.build b/tests/meson.build index 31e8d66c7a..cb720f3afe 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -477,7 +477,7 @@ if conf.has('WITH_REMOTE') endif if conf.has('WITH_SECDRIVER_SELINUX') - if conf.has('WITH_ATTR') + if conf.has('WITH_LIBATTR') tests += [ { 'name': 'securityselinuxtest' }, { 'name': 'viridentitytest' }, @@ -485,7 +485,7 @@ if conf.has('WITH_SECDRIVER_SELINUX') if conf.has('WITH_QEMU') tests += [ - { 'name': 'securityselinuxlabeltest', 'link_whole': [ test_utils_qemu_lib ] }, + { 'name': 'securityselinuxlabeltest', 'link_with': [ test_qemu_driver_lib ], 'link_whole': [ test_utils_qemu_lib ] }, ] endif endif -- 2.26.2

2 1

[libvirt PATCH] util: do not unref event thread after joining it
by Ján Tomko 23 Sep '20

23 Sep '20

==295055== Invalid read of size 4 ==295055== at 0x4DA4AE4: g_thread_unref (in /usr/lib64/libglib-2.0.so.0.6400.5) ==295055== by 0x491D5FA: vir_event_thread_finalize (vireventthread.c:47) ==295055== by 0x4E6BCFF: g_object_unref (in /usr/lib64/libgobject-2.0.so.0.6400.5) ==295055== by 0x22F35CF4: qemuProcessQMPFree (qemu_process.c:8525) ==295055== by 0x22E71B58: glib_autoptr_clear_qemuProcessQMP (qemu_process.h:237) ... ==295055== by 0x22E98A29: qemuDomainPostParseDataAlloc (qemu_domain.c:5476) ==295055== by 0x49ABF83: virDomainDefPostParse (domain_conf.c:6023) ==295055== Address 0x2acb1c68 is 24 bytes inside a block of size 88 free'd ==295055== at 0x483B9F5: free (vg_replace_malloc.c:538) ==295055== by 0x4D80A4C: g_free (in /usr/lib64/libglib-2.0.so.0.6400.5) ... ==295055== by 0x491D5F1: vir_event_thread_finalize (vireventthread.c:46) ==295055== by 0x4E6BCFF: g_object_unref (in /usr/lib64/libgobject-2.0.so.0.6400.5) ==295055== by 0x22F35CF4: qemuProcessQMPFree (qemu_process.c:8525) ==295055== by 0x22E71B58: glib_autoptr_clear_qemuProcessQMP (qemu_process.h:237) ... ==295055== Block was alloc'd at ==295055== at 0x483A809: malloc (vg_replace_malloc.c:307) ==295055== by 0x4D80958: g_malloc (in /usr/lib64/libglib-2.0.so.0.6400.5) ... ==295055== by 0x4DA4C32: g_thread_try_new (in /usr/lib64/libglib-2.0.so.0.6400.5) ==295055== by 0x491D3BC: virEventThreadStart (vireventthread.c:159) ==295055== by 0x491D3BC: virEventThreadNew (vireventthread.c:185) ... Signed-off-by: Ján Tomko <jtomko(a)redhat.com> Fixes: f4fc3db9204407874181117085756c9ced78adad --- src/util/vireventthread.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/util/vireventthread.c b/src/util/vireventthread.c index 1bca2aa57a..8342f420f6 100644 --- a/src/util/vireventthread.c +++ b/src/util/vireventthread.c @@ -44,7 +44,6 @@ vir_event_thread_finalize(GObject *object) if (evt->thread) { g_main_loop_quit(evt->loop); g_thread_join(evt->thread); - g_thread_unref(evt->thread); } g_main_loop_unref(evt->loop); -- 2.26.2

2 1

[libvirt PATCH] virnetdaemon: fix memory leak in virNetDaemonCallInhibit
by Pavel Hrdina 23 Sep '20

23 Sep '20

g_variant_new() returns a weak reference which can be consumed by passing to other g_variant* functions or to g_dbus_connection_call* functions. This make it possible to call g_variant_new() directly as argument to the functions above. Because this might be confusing I explicitly call g_variant_ref_sink() to make it normal reference in both virGDBusCallMethod() and virGDBusCallMethodWithFD() so the caller is always responsible for the data. Reported-by: Peter Krempa <pkrempa(a)redhat.com> Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/rpc/virnetdaemon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rpc/virnetdaemon.c b/src/rpc/virnetdaemon.c index f3a5e9f75c..2e01244f74 100644 --- a/src/rpc/virnetdaemon.c +++ b/src/rpc/virnetdaemon.c @@ -469,7 +469,7 @@ virNetDaemonCallInhibit(virNetDaemonPtr dmn, { g_autoptr(GVariant) reply = NULL; g_autoptr(GUnixFDList) replyFD = NULL; - GVariant *message = NULL; + g_autoptr(GVariant) message = NULL; GDBusConnection *systemBus; int fd; int rc; -- 2.26.2

3 2

[libvirt PATCH] util/virgdbus: fix memory leak in virGDBusIsServiceInList
by Pavel Hrdina 23 Sep '20

23 Sep '20

g_variant_iter_loop() handles freeing all arguments unless we break out of the loop, in that case we have to free them manually. Reported-by: Peter Krempa <pkrempa(a)redhat.com> Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/util/virgdbus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/util/virgdbus.c b/src/util/virgdbus.c index cd9ca8d5d6..4360a6acff 100644 --- a/src/util/virgdbus.c +++ b/src/util/virgdbus.c @@ -359,8 +359,10 @@ virGDBusIsServiceInList(const char *listMethod, g_variant_get(reply, "(as)", &iter); while (g_variant_iter_loop(iter, "s", &str)) { - if (STREQ(str, name)) + if (STREQ(str, name)) { + g_free(str); return 0; + } } return -2; -- 2.26.2

2 1

[libvirt PATCHv2 0/2] tests: switch to g_new0 (glib chronicles)
by Ján Tomko 23 Sep '20

23 Sep '20

2 4

[PATCH v2 0/2] block: deprecate the sheepdog driver
by Daniel P. Berrangé 23 Sep '20

23 Sep '20

2 years back I proposed dropping the sheepdog mailing list from the MAINTAINERS file, but somehow the patch never got picked up: https://lists.gnu.org/archive/html/qemu-block/2018-03/msg01048.html So here I am with the same patch again. This time I go further and deprecate the sheepdog driver entirely. See the rationale in the second patch commit message. Daniel P. Berrangé (2): block: drop moderated sheepdog mailing list from MAINTAINERS file block: deprecate the sheepdog block driver MAINTAINERS | 1 - block/sheepdog.c | 15 +++++++++++++++ configure | 5 +++-- docs/system/deprecated.rst | 9 +++++++++ 4 files changed, 27 insertions(+), 3 deletions(-) -- 2.26.2

8 14

[PATCH] docs: manpages: Strip table of contents from manpages
by Peter Krempa 23 Sep '20

23 Sep '20

After meson conversion the man pages started to contain the table of contents. In autoconf we prevented this by a 'grep -v ::contents' in the command building the manpages. A more cultured solution is to strip out the 'contents' docutils element directly. Reported-by: Daniel P. Berrangé <berrange(a)redhat.com> Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- docs/manpages/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/manpages/meson.build b/docs/manpages/meson.build index 3888bb8efe..7ed1d304a4 100644 --- a/docs/manpages/meson.build +++ b/docs/manpages/meson.build @@ -89,7 +89,8 @@ foreach data : docs_man_files man_file, input: rst_file, output: man_file, - command: [ rst2man_prog, '--strict', '@INPUT@', '@OUTPUT@' ], + # 'contents' element is the table of contents which is undesired in manpage + command: [ rst2man_prog, '--strip-elements-with-class', 'contents', '--strict', '@INPUT@', '@OUTPUT@' ], install: true, install_dir: mandir / 'man@0@'.format(data['section']), ) -- 2.26.2

4 3

[libvirt PATCH 0/4] tests: switch to g_new0 (glib chronicles)
by Ján Tomko 23 Sep '20

23 Sep '20

With the exception of viralloctest. Ján Tomko (4): tests: virNumaGetPages: use g_new0 instead of VIR_ALLOC_N tests: cpuTestLoadMultiXML: use g_new0 instead of VIR_ALLOC_N tests: use g_new0 instead of VIR_ALLOC_N tests: use g_new0 instead of VIR_ALLOC tests/commandtest.c | 7 +++---- tests/cputest.c | 4 +++- tests/domaincapstest.c | 10 ++++------ tests/fdstreamtest.c | 10 ++++------ tests/nodedevmdevctltest.c | 16 +++++----------- tests/nwfilterxml2firewalltest.c | 3 +-- tests/qemublocktest.c | 9 +++------ tests/qemuhotplugtest.c | 3 +-- tests/qemumonitorjsontest.c | 12 ++++-------- tests/qemumonitortestutils.c | 22 ++++++---------------- tests/qemusecuritymock.c | 3 +-- tests/qemuxml2argvtest.c | 3 +-- tests/securityselinuxhelper.c | 3 +-- tests/securityselinuxlabeltest.c | 3 +-- tests/securityselinuxtest.c | 6 ++---- tests/testutils.c | 8 ++------ tests/testutilsqemu.c | 6 ++---- tests/vircgrouptest.c | 3 +-- tests/vircryptotest.c | 5 ++--- tests/virhostcputest.c | 3 +-- tests/virhostdevtest.c | 3 +-- tests/virnetdaemontest.c | 3 +-- tests/virnetmessagetest.c | 15 ++++++--------- tests/virnetserverclienttest.c | 3 +-- tests/virnetsockettest.c | 6 +----- tests/virnettlshelpers.c | 3 +-- tests/virnumamock.c | 16 +++------------- tests/virstringtest.c | 8 +++----- tests/xlconfigtest.c | 3 +-- tests/xmconfigtest.c | 3 +-- 30 files changed, 67 insertions(+), 135 deletions(-) -- 2.26.2

2 9

[PATCH v2] docs/system: clarify deprecation schedule
by Stefan Hajnoczi 23 Sep '20

23 Sep '20

The sentence explaining the deprecation schedule is ambiguous. Make it clear that a feature deprecated in the Nth release is guaranteed to remain available in the N+1th release. Removal can occur in the N+2nd release or later. As an example of this in action, see commit 25956af3fe5dd0385ad8017bc768a6afe41e2a74 ("block: Finish deprecation of 'qemu-img convert -n -o'"). The feature was deprecated in QEMU 4.2.0. It was present in the 5.0.0 release and removed in the 5.1.0 release. Suggested-by: Daniel P. Berrangé <berrange(a)redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha(a)redhat.com> --- v2: * Use Dan's suggested wording [Daniel Berrange] --- docs/system/deprecated.rst | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst index 0cb8b01424..f2d5bd8ce1 100644 --- a/docs/system/deprecated.rst +++ b/docs/system/deprecated.rst @@ -3,10 +3,11 @@ Deprecated features In general features are intended to be supported indefinitely once introduced into QEMU. In the event that a feature needs to be removed, -it will be listed in this section. The feature will remain functional -for 2 releases prior to actual removal. Deprecated features may also -generate warnings on the console when QEMU starts up, or if activated -via a monitor command, however, this is not a mandatory requirement. +it will be listed in this section. The feature will remain functional for the +release in which it was deprecated and one further release. After these two +releases, the feature is liable to be removed. Deprecated features may also +generate warnings on the console when QEMU starts up, or if activated via a +monitor command, however, this is not a mandatory requirement. Prior to the 2.10.0 release there was no official policy on how long features would be deprecated prior to their removal, nor -- 2.26.2

3 3

[libvirt PATCH] gdbus: fix virGDBusCallMethodWithFD stub for non-UNIX
by Ján Tomko 23 Sep '20

23 Sep '20

Signed-off-by: Ján Tomko <jtomko(a)redhat.com> Fixes: a961d93768f18c28979ca2841832cd7278bf95b8 --- Pushed as a build fix. src/util/virgdbus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/virgdbus.c b/src/util/virgdbus.c index 837c8faf1f..cd9ca8d5d6 100644 --- a/src/util/virgdbus.c +++ b/src/util/virgdbus.c @@ -310,6 +310,7 @@ virGDBusCallMethodWithFD(GDBusConnection *conn, int virGDBusCallMethodWithFD(GDBusConnection *conn G_GNUC_UNUSED, GVariant **reply G_GNUC_UNUSED, + const GVariantType *replyType G_GNUC_UNUSED, GUnixFDList **replyFD G_GNUC_UNUSED, virErrorPtr error G_GNUC_UNUSED, const char *busName G_GNUC_UNUSED, -- 2.26.2

1 0

[libvirt PATCHv2 0/2] esx: fix race when building tests
by Ján Tomko 23 Sep '20

23 Sep '20

v1: https://www.redhat.com/archives/libvir-list/2020-September/msg01196.html Ján Tomko (2): esx: separate header and source file generation tests: esxutilstest: depend on esx_gen_headers scripts/esx_vi_generator.py | 161 ++++++++++++++++++++---------------- src/esx/meson.build | 34 ++++++-- tests/meson.build | 2 +- 3 files changed, 120 insertions(+), 77 deletions(-) -- 2.26.2

2 3

[libvirt PATCH] virgdbus: add DBus reply format check
by Pavel Hrdina 23 Sep '20

23 Sep '20

We used to check the format of reply data with libdbus so we should do the same with GLib DBus as well. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- At first I thought that this is not necessary as it is unlikely to happen but after Jano found the bug with firewalld getZones function and asked about checking return values I figured out that it will be better to check it because if the returned message would have different format it would be silently ignored. src/rpc/virnetdaemon.c | 1 + src/util/virfirewalld.c | 5 +++++ src/util/virgdbus.c | 8 ++++++-- src/util/virgdbus.h | 2 ++ src/util/virpolkit.c | 1 + src/util/virsystemd.c | 7 +++++++ 6 files changed, 22 insertions(+), 2 deletions(-) diff --git a/src/rpc/virnetdaemon.c b/src/rpc/virnetdaemon.c index 12d4d9bf87..f3a5e9f75c 100644 --- a/src/rpc/virnetdaemon.c +++ b/src/rpc/virnetdaemon.c @@ -487,6 +487,7 @@ virNetDaemonCallInhibit(virNetDaemonPtr dmn, rc = virGDBusCallMethodWithFD(systemBus, &reply, + G_VARIANT_TYPE("(h)"), &replyFD, NULL, "org.freedesktop.login1", diff --git a/src/util/virfirewalld.c b/src/util/virfirewalld.c index 12448f0681..a94ac7c183 100644 --- a/src/util/virfirewalld.c +++ b/src/util/virfirewalld.c @@ -95,6 +95,7 @@ virFirewallDGetVersion(unsigned long *version) if (virGDBusCallMethod(sysbus, &reply, + G_VARIANT_TYPE("(v)"), NULL, VIR_FIREWALL_FIREWALLD_SERVICE, "/org/fedoraproject/FirewallD1", @@ -147,6 +148,7 @@ virFirewallDGetBackend(void) if (virGDBusCallMethod(sysbus, &reply, + G_VARIANT_TYPE("(v)"), error, VIR_FIREWALL_FIREWALLD_SERVICE, "/org/fedoraproject/FirewallD1/config", @@ -207,6 +209,7 @@ virFirewallDGetZones(char ***zones, size_t *nzones) if (virGDBusCallMethod(sysbus, &reply, + G_VARIANT_TYPE("(as)"), NULL, VIR_FIREWALL_FIREWALLD_SERVICE, "/org/fedoraproject/FirewallD1", @@ -295,6 +298,7 @@ virFirewallDApplyRule(virFirewallLayer layer, if (virGDBusCallMethod(sysbus, &reply, + G_VARIANT_TYPE("(s)"), error, VIR_FIREWALL_FIREWALLD_SERVICE, "/org/fedoraproject/FirewallD1", @@ -357,6 +361,7 @@ virFirewallDInterfaceSetZone(const char *iface, message = g_variant_new("(ss)", zone, iface); return virGDBusCallMethod(sysbus, + NULL, NULL, NULL, VIR_FIREWALL_FIREWALLD_SERVICE, diff --git a/src/util/virgdbus.c b/src/util/virgdbus.c index 535b19f0a4..837c8faf1f 100644 --- a/src/util/virgdbus.c +++ b/src/util/virgdbus.c @@ -181,6 +181,7 @@ virGDBusCloseSystemBus(void) * virGDBusCallMethod: * @conn: a DBus connection * @reply: pointer to receive reply message, or NULL + * @replyType: pointer to GVariantType to validate reply data, or NULL * @error: libvirt error pointer or NULL * @busName: bus identifier of the target service * @objectPath: object path of the target service @@ -198,6 +199,7 @@ virGDBusCloseSystemBus(void) int virGDBusCallMethod(GDBusConnection *conn, GVariant **reply, + const GVariantType *replyType, virErrorPtr error, const char *busName, const char *objectPath, @@ -220,7 +222,7 @@ virGDBusCallMethod(GDBusConnection *conn, ifaceName, method, data, - NULL, + replyType, G_DBUS_CALL_FLAGS_NONE, VIR_DBUS_METHOD_CALL_TIMEOUT_MILIS, NULL, @@ -250,6 +252,7 @@ virGDBusCallMethod(GDBusConnection *conn, int virGDBusCallMethodWithFD(GDBusConnection *conn, GVariant **reply, + const GVariantType *replyType, GUnixFDList **replyFD, virErrorPtr error, const char *busName, @@ -274,7 +277,7 @@ virGDBusCallMethodWithFD(GDBusConnection *conn, ifaceName, method, data, - NULL, + replyType, G_DBUS_CALL_FLAGS_NONE, VIR_DBUS_METHOD_CALL_TIMEOUT_MILIS, dataFD, @@ -342,6 +345,7 @@ virGDBusIsServiceInList(const char *listMethod, rc = virGDBusCallMethod(conn, &reply, + G_VARIANT_TYPE("(as)"), NULL, "org.freedesktop.DBus", "/org/freedesktop/DBus", diff --git a/src/util/virgdbus.h b/src/util/virgdbus.h index 6ea717eea2..ca7073e27c 100644 --- a/src/util/virgdbus.h +++ b/src/util/virgdbus.h @@ -45,6 +45,7 @@ virGDBusCloseSystemBus(void); int virGDBusCallMethod(GDBusConnection *conn, GVariant **reply, + const GVariantType *replyType, virErrorPtr error, const char *busName, const char *objectPath, @@ -55,6 +56,7 @@ virGDBusCallMethod(GDBusConnection *conn, int virGDBusCallMethodWithFD(GDBusConnection *conn, GVariant **reply, + const GVariantType *replyType, GUnixFDList **replyFD, virErrorPtr error, const char *busName, diff --git a/src/util/virpolkit.c b/src/util/virpolkit.c index 2ad00fd206..aad924a065 100644 --- a/src/util/virpolkit.c +++ b/src/util/virpolkit.c @@ -104,6 +104,7 @@ int virPolkitCheckAuth(const char *actionid, if (virGDBusCallMethod(sysbus, &reply, + G_VARIANT_TYPE("((bba{ss}))"), NULL, "org.freedesktop.PolicyKit1", "/org/freedesktop/PolicyKit1/Authority", diff --git a/src/util/virsystemd.c b/src/util/virsystemd.c index 32c830c002..8456085476 100644 --- a/src/util/virsystemd.c +++ b/src/util/virsystemd.c @@ -214,6 +214,7 @@ virSystemdGetMachineNameByPID(pid_t pid) if (virGDBusCallMethod(conn, &reply, + G_VARIANT_TYPE("(o)"), NULL, "org.freedesktop.machine1", "/org/freedesktop/machine1", @@ -236,6 +237,7 @@ virSystemdGetMachineNameByPID(pid_t pid) if (virGDBusCallMethod(conn, &reply, + G_VARIANT_TYPE("(v)"), NULL, "org.freedesktop.machine1", object, @@ -384,6 +386,7 @@ int virSystemdCreateMachine(const char *name, gprops); rc = virGDBusCallMethod(conn, + NULL, NULL, error, "org.freedesktop.machine1", @@ -430,6 +433,7 @@ int virSystemdCreateMachine(const char *name, gprops); rc = virGDBusCallMethod(conn, + NULL, NULL, NULL, "org.freedesktop.machine1", @@ -457,6 +461,7 @@ int virSystemdCreateMachine(const char *name, gprops); rc = virGDBusCallMethod(conn, + NULL, NULL, NULL, "org.freedesktop.systemd1", @@ -507,6 +512,7 @@ int virSystemdTerminateMachine(const char *name) VIR_DEBUG("Attempting to terminate machine via systemd"); if (virGDBusCallMethod(conn, + NULL, NULL, error, "org.freedesktop.machine1", @@ -592,6 +598,7 @@ virSystemdPMSupportTarget(const char *methodName, bool *result) if (virGDBusCallMethod(conn, &reply, + G_VARIANT_TYPE("(s)"), NULL, "org.freedesktop.login1", "/org/freedesktop/login1", -- 2.26.2

2 2

[PATCH v2] util: support PCI passthrough net device stats collection
by zhenwei pi 23 Sep '20

23 Sep '20

Collect PCI passthrough net device stats from kernel by netlink API. Currently, libvirt can not get PCI passthrough net device stats, run command: #virsh domifstat instance --interface=52:54:00:2d:b2:35 error: Failed to get interface stats instance 52:54:00:2d:b2:35 error: internal error: Interface name not provided The PCI device(usually SR-IOV virtual function device) is detached while it's used in PCI passthrough mode. And we can not parse this device from /proc/net/dev any more. In this patch, libvirt check net device is VF of not firstly, then query virNetDevVFInterfaceStats(new API). virNetDevVFInterfaceStats parses VFs info of all PFs, compares MAC address until the two MAC addresses match. '#ip -s link show' can get the same result. Instead of parsing the output result, implement this feature by libnl API. Notice that this feature deponds on driver of PF. Test on Mellanox ConnectX-4 Lx, it works well. Also test on Intel Corporation 82599ES, it works, but only get 0. (ip-link command get the same result). Signed-off-by: zhenwei pi <pizhenwei(a)bytedance.com> --- src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 3 ++ src/util/virnetdev.c | 137 +++++++++++++++++++++++++++++++++++++++++++++++ src/util/virnetdev.h | 5 ++ 4 files changed, 146 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index bdbe3431b8..bcc40b8d69 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -2585,6 +2585,7 @@ virNetDevSetRcvMulti; virNetDevSetupControl; virNetDevSysfsFile; virNetDevValidateConfig; +virNetDevVFInterfaceStats; # util/virnetdevbandwidth.h diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index ae715c01d7..f554010c40 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -10196,6 +10196,9 @@ qemuDomainInterfaceStats(virDomainPtr dom, if (virDomainNetGetActualType(net) == VIR_DOMAIN_NET_TYPE_VHOSTUSER) { if (virNetDevOpenvswitchInterfaceStats(net->ifname, stats) < 0) goto cleanup; + } else if (virDomainNetGetActualType(net) == VIR_DOMAIN_NET_TYPE_HOSTDEV) { + if (virNetDevVFInterfaceStats(&net->mac, stats) < 0) + goto cleanup; } else { if (virNetDevTapInterfaceStats(net->ifname, stats, !virDomainNetTypeSharesHostView(net)) < 0) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index e1a4cc2bef..377f25aae7 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -1489,6 +1489,7 @@ static struct nla_policy ifla_vf_policy[IFLA_VF_MAX+1] = { .maxlen = sizeof(struct ifla_vf_mac) }, [IFLA_VF_VLAN] = { .type = NLA_UNSPEC, .maxlen = sizeof(struct ifla_vf_vlan) }, + [IFLA_VF_STATS] = { .type = NLA_NESTED }, }; @@ -2265,6 +2266,132 @@ virNetDevSetNetConfig(const char *linkdev, int vf, return 0; } +static struct nla_policy ifla_vfstats_policy[IFLA_VF_STATS_MAX+1] = { + [IFLA_VF_STATS_RX_PACKETS] = { .type = NLA_U64 }, + [IFLA_VF_STATS_TX_PACKETS] = { .type = NLA_U64 }, + [IFLA_VF_STATS_RX_BYTES] = { .type = NLA_U64 }, + [IFLA_VF_STATS_TX_BYTES] = { .type = NLA_U64 }, + [IFLA_VF_STATS_BROADCAST] = { .type = NLA_U64 }, + [IFLA_VF_STATS_MULTICAST] = { .type = NLA_U64 }, +}; + +static int +virNetDevParseVfStats(struct nlattr **tb, virMacAddrPtr mac, + virDomainInterfaceStatsPtr stats) +{ + int ret = -1, len; + struct ifla_vf_mac *vf_lladdr; + struct nlattr *nla, *t[IFLA_VF_MAX+1]; + struct nlattr *stb[IFLA_VF_STATS_MAX+1]; + + if (tb == NULL || mac == NULL || stats == NULL) { + return -1; + } + + if (!tb[IFLA_VFINFO_LIST]) + return -1; + + len = nla_len(tb[IFLA_VFINFO_LIST]); + + for (nla = nla_data(tb[IFLA_VFINFO_LIST]); nla_ok(nla, len); + nla = nla_next(nla, &len)) { + ret = nla_parse(t, IFLA_VF_MAX, nla_data(nla), nla_len(nla), + ifla_vf_policy); + if (ret < 0) + return -1; + + if (t[IFLA_VF_MAC] == NULL) { + continue; + } + + vf_lladdr = nla_data(t[IFLA_VF_MAC]); + if (virMacAddrCmpRaw(mac, vf_lladdr->mac)) { + continue; + } + + if (t[IFLA_VF_STATS]) { + ret = nla_parse_nested(stb, IFLA_VF_STATS_MAX, + t[IFLA_VF_STATS], + ifla_vfstats_policy); + if (ret < 0) + return -1; + + stats->rx_bytes = nla_get_u64(stb[IFLA_VF_STATS_RX_BYTES]); + stats->tx_bytes = nla_get_u64(stb[IFLA_VF_STATS_TX_BYTES]); + stats->rx_packets = nla_get_u64(stb[IFLA_VF_STATS_RX_PACKETS]); + stats->tx_packets = nla_get_u64(stb[IFLA_VF_STATS_TX_PACKETS]); + } + return 0; + } + + return ret; +} + +/** + * virNetDevVFInterfaceStats: + * @mac: MAC address of the VF interface + * @stats: returns stats of the VF interface + * + * Get the VF interface from kernel by netlink. + * Returns 0 on success, -1 on failure. + */ +int +virNetDevVFInterfaceStats(virMacAddrPtr mac, + virDomainInterfaceStatsPtr stats) +{ + FILE *fp; + char line[256], *colon, *ifname; + int rc = -1; + void *nlData = NULL; + struct nlattr *tb[IFLA_MAX + 1] = {NULL, }; + char *sysfsDevicePath = NULL; + + fp = fopen("/proc/net/dev", "r"); + if (!fp) { + virReportSystemError(errno, "%s", + _("Could not open /proc/net/dev")); + return -1; + } + + /* get all PCI net devices, and parse VFs list from netlink API. + * compare MAC address, collect device stats if matching. + */ + while (fgets(line, sizeof(line), fp)) { + /* The line looks like: + * " eth0:..." + * Split it at the colon. and strip blank from head. + */ + colon = strchr(line, ':'); + if (!colon) + continue; + *colon = '\0'; + ifname = line; + while ((*ifname == ' ') && (ifname < colon)) + ifname++; + + if (virNetDevSysfsFile(&sysfsDevicePath, ifname, "device") < 0) + break; + + if (virNetDevIsPCIDevice(sysfsDevicePath)) { + rc = virNetlinkDumpLink(ifname, -1, &nlData, tb, 0, 0); + if (rc < 0) { + rc = -1; + goto cleanup; + } + + rc = virNetDevParseVfStats(tb, mac, stats); + VIR_FREE(nlData); + if (rc == 0) + goto cleanup; + } + VIR_FREE(sysfsDevicePath); + } + + cleanup: + VIR_FREE(sysfsDevicePath); + VIR_FORCE_FCLOSE(fp); + return rc; +} #else /* defined(__linux__) && defined(WITH_LIBNL) && defined(IFLA_VF_MAX) */ @@ -2309,6 +2436,16 @@ virNetDevSetNetConfig(const char *linkdev G_GNUC_UNUSED, } +int +virNetDevVFInterfaceStats(virMacAddrPtr mac G_GNUC_UNUSED, + virDomainInterfaceStatsPtr stats G_GNUC_UNUSED) +{ + virReportSystemError(ENOSYS, "%s", + _("Unable to get VF net device stats on this platform")); + return -1; +} + + #endif /* defined(__linux__) && defined(WITH_LIBNL) && defined(IFLA_VF_MAX) */ VIR_ENUM_IMPL(virNetDevIfState, diff --git a/src/util/virnetdev.h b/src/util/virnetdev.h index 5f581323ed..ff59d9d341 100644 --- a/src/util/virnetdev.h +++ b/src/util/virnetdev.h @@ -312,4 +312,9 @@ int virNetDevSysfsFile(char **pf_sysfs_device_link, int virNetDevRunEthernetScript(const char *ifname, const char *script) G_GNUC_NO_INLINE; +int virNetDevVFInterfaceStats(virMacAddrPtr mac, + virDomainInterfaceStatsPtr stats) +ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); + + G_DEFINE_AUTOPTR_CLEANUP_FUNC(virNetDevRxFilter, virNetDevRxFilterFree); -- 2.11.0

2 1

[PATCH] Remove redundant check when storage pool is mounted
by Yi Li 23 Sep '20

23 Sep '20

virFileComparePaths just return 0 or 1 after commit 7b48bb8 so break while after virFileComparePaths return 1 Signed-off-by: Yi Li <yili(a)winhong.com> --- src/storage/storage_backend_fs.c | 8 ++------ src/util/virfile.c | 1 - 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c index 536e5cf952..30c2367df4 100644 --- a/src/storage/storage_backend_fs.c +++ b/src/storage/storage_backend_fs.c @@ -245,7 +245,6 @@ virStorageBackendFileSystemIsMounted(virStoragePoolObjPtr pool) FILE *mtab; struct mntent ent; char buf[1024]; - int rc1, rc2; g_autofree char *src = NULL; if ((mtab = fopen(_PATH_MOUNTED, "r")) == NULL) { @@ -262,11 +261,8 @@ virStorageBackendFileSystemIsMounted(virStoragePoolObjPtr pool) /* compare both mount destinations and sources to be sure the mounted * FS pool is really the one we're looking for */ - if ((rc1 = virFileComparePaths(ent.mnt_dir, def->target.path)) < 0 || - (rc2 = virFileComparePaths(ent.mnt_fsname, src)) < 0) - goto cleanup; - - if (rc1 && rc2) { + if (virFileComparePaths(ent.mnt_dir, def->target.path) && + virFileComparePaths(ent.mnt_fsname, src)) { ret = 1; goto cleanup; } diff --git a/src/util/virfile.c b/src/util/virfile.c index 61d2c16072..e120d277d0 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c @@ -3884,7 +3884,6 @@ virFileCopyACLs(const char *src, * Returns: * 1 : Equal * 0 : Non-Equal - * -1 : Error */ int virFileComparePaths(const char *p1, const char *p2) -- 2.25.3

2 1

[libvirt PATCH 0/3] esx: fix race when building tests
by Ján Tomko 23 Sep '20

23 Sep '20

This should get rid of some of the random CI fails: https://gitlab.com/libvirt/libvirt/-/jobs/726039284 Ján Tomko (3): esx: separate header and source file generation tests: esxutilstest: depend on esx_gen_headers sleep scripts/esx_vi_generator.py | 162 ++++++++++++++++++++---------------- src/esx/meson.build | 31 +++++-- tests/meson.build | 3 +- 3 files changed, 119 insertions(+), 77 deletions(-) -- 2.26.2

2 5

[PATCH v2 0/3] improve pSeries NVDIMM support
by Daniel Henrique Barboza 23 Sep '20

23 Sep '20

Hi, This is a follow up of [1] after Andrea pushed the revert patch as standalone. Changes from v1: - patch 2 (former 3): moved the auto-align code from virDomainMemoryDefParseXML() to virDomainMemoryDefPostParse() - patch 3 (former 4): updated NEWS.rst based on Andrea's changes already upstream [1] https://www.redhat.com/archives/libvir-list/2020-September/msg00864.html Daniel Henrique Barboza (3): conf, qemu: move qemuDomainNVDimmAlignSizePseries to domain_conf.c domain_conf.c: auto-align pSeries NVDIMM in virDomainMemoryDefPostParse() NEWS.rst: update NVDIMM changes entry NEWS.rst | 3 +- src/conf/domain_conf.c | 59 ++++++++++++++++++- src/conf/domain_conf.h | 3 + src/libvirt_private.syms | 1 + src/qemu/qemu_domain.c | 42 +------------ .../memory-hotplug-nvdimm-ppc64.xml | 2 +- 6 files changed, 67 insertions(+), 43 deletions(-) -- 2.26.2

2 6

[libvirt PATCH] virfirewalld: fix g_variant_get call
by Pavel Hrdina 23 Sep '20

23 Sep '20

We need to pass pointer to `array`. Reported-by: Ján Tomko <jtomko(a)redhat.com> Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/util/virfirewalld.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virfirewalld.c b/src/util/virfirewalld.c index 69c8b73da0..12448f0681 100644 --- a/src/util/virfirewalld.c +++ b/src/util/virfirewalld.c @@ -215,7 +215,7 @@ virFirewallDGetZones(char ***zones, size_t *nzones) NULL) < 0) return -1; - g_variant_get(reply, "(@as)", array); + g_variant_get(reply, "(@as)", &array); *zones = g_variant_dup_strv(array, nzones); return 0; -- 2.26.2

2 2

[libvirt PATCH 0/9] [GSoC]: Libvirt driver for Jailhouse
by Daniel P. Berrangé 23 Sep '20

23 Sep '20

I'm sending this series on behalf of Prakhar Bansal who has been unable to sucessfully send the whole series. GMail is blocking sending of certain patches for unknown reasons. https://www.redhat.com/archives/libvir-list/2020-September/msg00309.html It is also available at https://github.com/pbansal2/libvirt/tree/jailhouse_driver Prakhar Bansal (9): Jailhouse driver: first commit with skeleton code Jailhouse driver: Implementation of ConnectOpen Jailhouse driver: Implementation of ConnectGetType Jailhouse driver: Implementation of DomainCreate* callbacks Jailhouse driver: Implementation of DomainInfo/State/List Jailhouse driver: Implementation of DomainLookup* callbacks Jailhouse driver: Implementation of DomainShutdown/Destroy callbacks Jailhouse driver: Fixes for creation of cells, fetching cell info, disabling jailhouse hypervisor Jailhouse driver: Add events to events queue in DomainCreate/Shutdown/Destroy include/libvirt/virterror.h | 1 + libvirt.spec.in | 7 + m4/virt-driver-jailhouse.m4 | 42 ++ meson.build | 4 + meson_options.txt | 1 + po/POTFILES.in | 2 + src/conf/domain_conf.c | 1 + src/conf/domain_conf.h | 1 + src/jailhouse/Makefile.inc.am | 47 ++ src/jailhouse/jailhouse.conf | 10 + src/jailhouse/jailhouse_api.c | 458 +++++++++++++++ src/jailhouse/jailhouse_api.h | 103 ++++ src/jailhouse/jailhouse_driver.c | 837 +++++++++++++++++++++++++++ src/jailhouse/jailhouse_driver.h | 82 +++ src/jailhouse/libvirtd_jailhouse.aug | 43 ++ src/jailhouse/meson.build | 49 ++ src/meson.build | 1 + src/qemu/qemu_command.c | 1 + src/remote/remote_daemon.c | 4 + src/remote/remote_daemon_dispatch.c | 3 +- src/util/virerror.c | 1 + 21 files changed, 1697 insertions(+), 1 deletion(-) create mode 100644 m4/virt-driver-jailhouse.m4 create mode 100644 src/jailhouse/Makefile.inc.am create mode 100644 src/jailhouse/jailhouse.conf create mode 100644 src/jailhouse/jailhouse_api.c create mode 100644 src/jailhouse/jailhouse_api.h create mode 100644 src/jailhouse/jailhouse_driver.c create mode 100644 src/jailhouse/jailhouse_driver.h create mode 100644 src/jailhouse/libvirtd_jailhouse.aug create mode 100644 src/jailhouse/meson.build -- 2.26.2

3 17