- Devel - libvirt List Archives

[libvirt PATCH 0/4] vbox: use g_new0 (glib chronicles)
by Ján Tomko 05 Oct '20

05 Oct '20

Ján Tomko (4): vbox: use g_new0 in vboxDumpAudio vbox: invert condition in vboxSnapshotGetReadOnlyDisks vbox: refactor vboxNetworkGetXMLDesc a bit vbox: use g_new0 instead of VIR_ALLOC src/vbox/vbox_common.c | 119 ++++++++++++---------------------- src/vbox/vbox_network.c | 107 ++++++++++++++---------------- src/vbox/vbox_snapshot_conf.c | 48 ++++++-------- 3 files changed, 110 insertions(+), 164 deletions(-) -- 2.26.2

2 9

[libvirt PATCH 0/4] vz: use g_new0 (glib chronicles)
by Ján Tomko 05 Oct '20

05 Oct '20

Ján Tomko (4): vz: separate if conditions in vzEatCookie vz: vzEatCookie: use distinct 'tmp' variables vz: vzEatCookie: separate allocation vz: use g_new0 instead of VIR_ALLOC src/vz/vz_driver.c | 49 ++++++++++++++++++++++------------------------ src/vz/vz_sdk.c | 46 +++++++++++++------------------------------ src/vz/vz_utils.c | 3 +-- 3 files changed, 38 insertions(+), 60 deletions(-) -- 2.26.2

2 5

[libvirt PATCH] vmware: use g_new0 instead of VIR_ALLOC (glib chronicles)
by Ján Tomko 05 Oct '20

05 Oct '20

Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/vmware/vmware_driver.c | 6 ++--- src/vmx/vmx.c | 46 ++++++++++---------------------------- 2 files changed, 14 insertions(+), 38 deletions(-) diff --git a/src/vmware/vmware_driver.c b/src/vmware/vmware_driver.c index e82edf2a11..087664a341 100644 --- a/src/vmware/vmware_driver.c +++ b/src/vmware/vmware_driver.c @@ -97,8 +97,7 @@ vmwareDataAllocFunc(void *opaque G_GNUC_UNUSED) { vmwareDomainPtr dom; - if (VIR_ALLOC(dom) < 0) - return NULL; + dom = g_new0(vmwareDomain, 1); dom->vmxPath = NULL; dom->gui = true; @@ -184,8 +183,7 @@ vmwareConnectOpen(virConnectPtr conn, /* We now know the URI is definitely for this driver, so beyond * here, don't return DECLINED, always use ERROR */ - if (VIR_ALLOC(driver) < 0) - return VIR_DRV_OPEN_ERROR; + driver = g_new0(struct vmware_driver, 1); /* Find vmrun, which is what this driver uses to communicate to * the VMware hypervisor. We look this up first since we use it diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index 9894d5c0ce..0e8a690d0d 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -637,8 +637,7 @@ virVMXEscapeHex(const char *string, char escape, const char *special) ++length; } - if (VIR_ALLOC_N(escaped, length) < 0) - return NULL; + escaped = g_new0(char, length); tmp1 = string; /* reading from this one */ tmp2 = escaped; /* writing to this one */ @@ -1150,8 +1149,7 @@ virVMXGatherSCSIControllers(virVMXContext *ctx, virDomainDefPtr def, int count = 0; int *autodetectedModels; - if (VIR_ALLOC_N(autodetectedModels, def->ndisks) < 0) - return -1; + autodetectedModels = g_new0(int, def->ndisks); for (i = 0; i < def->ncontrollers; ++i) { controller = def->controllers[i]; @@ -1611,9 +1609,7 @@ virVMXParseConfig(virVMXContext *ctx, /* FIXME */ /* def:graphics */ - if (VIR_ALLOC_N(def->graphics, 1) < 0) - goto cleanup; - + def->graphics = g_new0(virDomainGraphicsDefPtr, 1); def->ngraphics = 0; if (virVMXParseVNC(conf, &def->graphics[def->ngraphics]) < 0) @@ -1623,9 +1619,7 @@ virVMXParseConfig(virVMXContext *ctx, ++def->ngraphics; /* def:disks: 4 * 15 scsi + 2 * 2 ide + 2 floppy = 66 */ - if (VIR_ALLOC_N(def->disks, 66) < 0) - goto cleanup; - + def->disks = g_new0(virDomainDiskDefPtr, 66); def->ndisks = 0; /* def:disks (scsi) */ @@ -1733,9 +1727,7 @@ virVMXParseConfig(virVMXContext *ctx, if (sharedFolder_maxNum > 0) { int number; - if (VIR_ALLOC_N(def->fss, sharedFolder_maxNum) < 0) - goto cleanup; - + def->fss = g_new0(virDomainFSDefPtr, sharedFolder_maxNum); def->nfss = 0; for (number = 0; number < sharedFolder_maxNum; ++number) { @@ -1767,9 +1759,7 @@ virVMXParseConfig(virVMXContext *ctx, /* FIXME */ /* def:videos */ - if (VIR_ALLOC_N(def->videos, 1) < 0) - goto cleanup; - + def->videos = g_new0(virDomainVideoDefPtr, 1); def->nvideos = 0; if (virVMXParseSVGA(conf, &def->videos[def->nvideos]) < 0) @@ -1784,9 +1774,7 @@ virVMXParseConfig(virVMXContext *ctx, /* FIXME */ /* def:serials */ - if (VIR_ALLOC_N(def->serials, 4) < 0) - goto cleanup; - + def->serials = g_new0(virDomainChrDefPtr, 4); def->nserials = 0; for (port = 0; port < 4; ++port) { @@ -1800,9 +1788,7 @@ virVMXParseConfig(virVMXContext *ctx, } /* def:parallels */ - if (VIR_ALLOC_N(def->parallels, 3) < 0) - goto cleanup; - + def->parallels = g_new0(virDomainChrDefPtr, 3); def->nparallels = 0; for (port = 0; port < 3; ++port) { @@ -1819,10 +1805,7 @@ virVMXParseConfig(virVMXContext *ctx, if (ctx->datacenterPath || ctx->moref) { struct virVMXDomainDefNamespaceData *nsdata = NULL; - if (VIR_ALLOC(nsdata) < 0) { - virVMXDomainDefNamespaceFree(nsdata); - goto cleanup; - } + nsdata = g_new0(struct virVMXDomainDefNamespaceData, 1); nsdata->datacenterPath = g_strdup(ctx->datacenterPath); @@ -1891,9 +1874,7 @@ virVMXParseVNC(virConfPtr conf, virDomainGraphicsDefPtr *def) if (! enabled) return 0; - if (VIR_ALLOC(*def) < 0) - goto failure; - + *def = g_new0(virDomainGraphicsDef, 1); (*def)->type = VIR_DOMAIN_GRAPHICS_TYPE_VNC; if (virVMXGetConfigLong(conf, "RemoteDisplay.vnc.port", &port, -1, @@ -2588,8 +2569,7 @@ virVMXParseEthernet(virConfPtr conf, int controller, virDomainNetDefPtr *def) if (! present/* && ! startConnected*/) return 0; - if (VIR_ALLOC(*def) < 0) - return -1; + *def = g_new0(virDomainNetDef, 1); /* vmx:connectionType -> def:type */ if (virVMXGetConfigString(conf, connectionType_name, &connectionType, @@ -3040,9 +3020,7 @@ virVMXParseSVGA(virConfPtr conf, virDomainVideoDefPtr *def) return -1; } - if (VIR_ALLOC(*def) < 0) - return -1; - + *def = g_new0(virDomainVideoDef, 1); (*def)->type = VIR_DOMAIN_VIDEO_TYPE_VMVGA; /* vmx:vramSize */ -- 2.26.2

2 1

[libvirt PATCH] API: discourage usage of non-ListAll APIs
by Ján Tomko 05 Oct '20

05 Oct '20

They require the caller to provide the maximum number of array elements upfront, leading to either incomplete results or violations of the zero-one-infinity rule. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/libvirt-domain-snapshot.c | 6 ++++-- src/libvirt-domain.c | 8 ++++---- src/libvirt-interface.c | 6 ++++-- src/libvirt-network.c | 6 ++++-- src/libvirt-nodedev.c | 3 ++- src/libvirt-nwfilter.c | 3 +++ src/libvirt-secret.c | 3 +++ src/libvirt-storage.c | 9 ++++++--- 8 files changed, 30 insertions(+), 14 deletions(-) diff --git a/src/libvirt-domain-snapshot.c b/src/libvirt-domain-snapshot.c index f856e5b9b8..74d5e16281 100644 --- a/src/libvirt-domain-snapshot.c +++ b/src/libvirt-domain-snapshot.c @@ -378,8 +378,10 @@ virDomainSnapshotNum(virDomainPtr domain, unsigned int flags) * snapshots were listed if the return is less than @nameslen. Likewise, * you should be prepared for virDomainSnapshotLookupByName() to fail when * converting a name from this call into a snapshot object, if another - * connection deletes the snapshot in the meantime. For more control over - * the results, see virDomainListAllSnapshots(). + * connection deletes the snapshot in the meantime. + * + * The use of this function in new code is discouraged. Instead, use + * virDomainListAllSnapshots(). * * Returns the number of domain snapshots found or -1 in case of error. * The caller is responsible to call free() for each member of the array. diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 415482a526..03eca1196a 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -41,8 +41,8 @@ VIR_LOG_INIT("libvirt.domain"); * * Collect the list of active domains, and store their IDs in array @ids * - * For inactive domains, see virConnectListDefinedDomains(). For more - * control over the results, see virConnectListAllDomains(). + * The use of this function in new code is discouraged. Instead, use + * virConnectListAllDomains(). * * Returns the number of domains found or -1 in case of error. Note that * this command is inherently racy; a domain can be started between a @@ -6366,8 +6366,8 @@ virConnectNumOfDefinedDomains(virConnectPtr conn) * list the defined but inactive domains, stores the pointers to the names * in @names * - * For active domains, see virConnectListDomains(). For more control over - * the results, see virConnectListAllDomains(). + * The use of this function in new code is discouraged. Instead, use + * virConnectListAllDomains(). * * Returns the number of names provided in the array or -1 in case of error. * Note that this command is inherently racy; a domain can be defined between diff --git a/src/libvirt-interface.c b/src/libvirt-interface.c index 5eb5980483..271f21b7b5 100644 --- a/src/libvirt-interface.c +++ b/src/libvirt-interface.c @@ -150,7 +150,8 @@ virConnectNumOfInterfaces(virConnectPtr conn) * Collect the list of active physical host interfaces, * and store their names in @names * - * For more control over the results, see virConnectListAllInterfaces(). + * The use of this function in new code is discouraged. Instead, use + * virConnectListAllInterfaces(). * * Returns the number of interfaces found or -1 in case of error. Note that * this command is inherently racy; a interface can be started between a call @@ -227,7 +228,8 @@ virConnectNumOfDefinedInterfaces(virConnectPtr conn) * Collect the list of defined (inactive) physical host interfaces, * and store their names in @names. * - * For more control over the results, see virConnectListAllInterfaces(). + * The use of this function in new code is discouraged. Instead, use + * virConnectListAllInterfaces(). * * Returns the number of names provided in the array or -1 in case of error. * Note that this command is inherently racy; a interface can be defined between diff --git a/src/libvirt-network.c b/src/libvirt-network.c index f691b672c7..e6ea66a234 100644 --- a/src/libvirt-network.c +++ b/src/libvirt-network.c @@ -159,7 +159,8 @@ virConnectNumOfNetworks(virConnectPtr conn) * * Collect the list of active networks, and store their names in @names * - * For more control over the results, see virConnectListAllNetworks(). + * The use of this function in new code is discouraged. Instead, use + * virConnectListAllNetworks(). * * Returns the number of networks found or -1 in case of error. Note that * this command is inherently racy; a network can be started between a call @@ -235,7 +236,8 @@ virConnectNumOfDefinedNetworks(virConnectPtr conn) * * list the inactive networks, stores the pointers to the names in @names * - * For more control over the results, see virConnectListAllNetworks(). + * The use of this function in new code is discouraged. Instead, use + * virConnectListAllNetworks(). * * Returns the number of names provided in the array or -1 in case of error. * Note that this command is inherently racy; a network can be defined between diff --git a/src/libvirt-nodedev.c b/src/libvirt-nodedev.c index 28765b9c30..6b1e03c531 100644 --- a/src/libvirt-nodedev.c +++ b/src/libvirt-nodedev.c @@ -151,7 +151,8 @@ virConnectListAllNodeDevices(virConnectPtr conn, * * Collect the list of node devices, and store their names in @names * - * For more control over the results, see virConnectListAllNodeDevices(). + * The use of this function in new code is discouraged. Instead, use + * virConnectListAllNodeDevices(). * * If the optional 'cap' argument is non-NULL, then the count * will be restricted to devices with the specified capability diff --git a/src/libvirt-nwfilter.c b/src/libvirt-nwfilter.c index e299385895..11397f2f4c 100644 --- a/src/libvirt-nwfilter.c +++ b/src/libvirt-nwfilter.c @@ -117,6 +117,9 @@ virConnectListAllNWFilters(virConnectPtr conn, * * Collect the list of network filters, and store their names in @names * + * The use of this function in new code is discouraged. Instead, use + * virConnectListALLNWFilters(). + * * Returns the number of network filters found or -1 in case of error */ int diff --git a/src/libvirt-secret.c b/src/libvirt-secret.c index 75d40f53dc..c836a09ce7 100644 --- a/src/libvirt-secret.c +++ b/src/libvirt-secret.c @@ -156,6 +156,9 @@ virConnectListAllSecrets(virConnectPtr conn, * * List UUIDs of defined secrets, store pointers to names in uuids. * + * The use of this function in new code is discouraged. Instead, use + * virConnectListAllSecrets(). + * * Returns the number of UUIDs provided in the array, or -1 on failure. */ int diff --git a/src/libvirt-storage.c b/src/libvirt-storage.c index 2a7cdca234..6b2f612cac 100644 --- a/src/libvirt-storage.c +++ b/src/libvirt-storage.c @@ -179,7 +179,8 @@ virConnectNumOfStoragePools(virConnectPtr conn) * If there are more than maxnames, the remaining names will be silently * ignored. * - * For more control over the results, see virConnectListAllStoragePools(). + * The use of this function in new code is discouraged. Instead, use + * virConnectListAllStoragePools(). * * Returns the number of pools found or -1 in case of error. Note that * this command is inherently racy; a pool can be started between a call to @@ -259,7 +260,8 @@ virConnectNumOfDefinedStoragePools(virConnectPtr conn) * If there are more than maxnames, the remaining names will be silently * ignored. * - * For more control over the results, see virConnectListAllStoragePools(). + * The use of this function in new code is discouraged. Instead, use + * virConnectListAllStoragePools(). * * Returns the number of names provided in the array or -1 in case of error. * Note that this command is inherently racy; a pool can be defined between @@ -1254,7 +1256,8 @@ virStoragePoolNumOfVolumes(virStoragePoolPtr pool) * Fetch list of storage volume names, limiting to * at most maxnames. * - * To list the volume objects directly, see virStoragePoolListAllVolumes(). + * The use of this function in new code is discouraged. Instead, use + * virStoragePoolListAllVolumes(). * * Returns the number of names fetched, or -1 on error */ -- 2.26.2

2 1

[PATCH 00/15] virbitmap: Refactor bitmap allocation
by Peter Krempa 05 Oct '20

05 Oct '20

Peter Krempa (15): virQEMUCapsFlagsString: Remove unused function virBitmapToString: Remove unused 'prefix' and 'trim' arguments virBitmapToString|virBitmapNewString: Clarify semantics of the 'string' virBitmapToString: Properly handle empty bitmaps virbitmaptest: test13: Refactor memory cleanup virbitmaptest: Use g_auto(free) for cleanup virbitmaptest: Remove unnecessary error/cleanup labels util: virbitmap: Don't forbid 0 size bitmap virbitmaptest: Add few more cases for virBitmapToString virBitmapNewQuiet: Don't fail on unlikely overflow scenario util: bitmap: Remove virBitmapNewQuiet virBitmapNew: Don't force return value check util: bitmp: Remove virBitmapNewEmpty qemuSlirpNew: Use g_new0 to allocate the slirp object virBitmapNew: Don't check return value src/conf/capabilities.c | 7 +- src/conf/checkpoint_conf.c | 3 +- src/conf/domain_addr.c | 6 +- src/conf/domain_conf.c | 12 +- src/conf/node_device_conf.c | 6 +- src/conf/numa_conf.c | 2 +- src/conf/storage_conf.c | 3 +- src/conf/virnetworkobj.c | 3 +- src/libvirt_private.syms | 2 - src/libxl/libxl_capabilities.c | 4 - src/libxl/libxl_driver.c | 6 +- src/lxc/lxc_controller.c | 3 - src/qemu/qemu_capabilities.c | 9 +- src/qemu/qemu_capabilities.h | 2 - src/qemu/qemu_conf.c | 3 +- src/qemu/qemu_domain_address.c | 5 +- src/qemu/qemu_driver.c | 11 +- src/qemu/qemu_hotplug.c | 3 +- src/qemu/qemu_migration_cookie.c | 5 +- src/qemu/qemu_migration_params.c | 12 +- src/qemu/qemu_monitor.c | 3 +- src/qemu/qemu_namespace.c | 5 +- src/qemu/qemu_process.c | 5 +- src/qemu/qemu_slirp.c | 7 +- src/qemu/qemu_snapshot.c | 3 +- src/test/test_driver.c | 12 +- src/util/virbitmap.c | 102 +++----- src/util/virbitmap.h | 6 +- src/util/vircommand.c | 3 +- src/util/virdnsmasq.c | 7 +- src/util/virhostcpu.c | 14 +- src/util/virjson.c | 3 +- src/util/virnetdev.c | 3 +- src/util/virnuma.c | 8 +- src/util/virportallocator.c | 6 +- src/util/virprocess.c | 6 +- src/util/virresctrl.c | 12 +- src/util/virstoragefile.c | 3 +- src/util/virtpm.c | 2 +- src/vmx/vmx.c | 2 - src/vz/vz_sdk.c | 3 +- tests/qemumonitorjsontest.c | 3 - tests/testutils.c | 11 +- tests/virbitmaptest.c | 410 +++++++++++++----------------- tools/virsh-domain.c | 9 +- tools/virt-host-validate-common.c | 4 +- 46 files changed, 271 insertions(+), 488 deletions(-) -- 2.26.2

2 39

[PATCH] rpm: Simplify qemu+kvm conditionals and eliminate duplication
by Neal Gompa 05 Oct '20

05 Oct '20

The conditionals for enabling qemu+kvm were unnecessarily complex. In practice, there were far fewer cases where the functionality would be disabled than what the conditional logic expressed, and this change simplifies it to the realistic set of options. Signed-off-by: Neal Gompa <ngompa13(a)gmail.com> --- libvirt.spec.in | 49 +++++++++++++++++++++++-------------------------- 1 file changed, 23 insertions(+), 26 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index c4a7c30737..6940066de9 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -20,31 +20,12 @@ %define with_qemu_tcg %{with_qemu} -%define qemu_kvm_arches %{ix86} x86_64 - -%if 0%{?fedora} - %define qemu_kvm_arches %{ix86} x86_64 %{power64} s390x %{arm} aarch64 -%endif - -%if 0%{?rhel} - %define with_qemu_tcg 0 - %define qemu_kvm_arches x86_64 %{power64} aarch64 s390x -%endif - # On RHEL 7 and older macro _vpath_builddir is not defined. %if 0%{?rhel} && 0%{?rhel} <= 7 %define _vpath_builddir %{_target_platform} %endif -%ifarch %{qemu_kvm_arches} - %define with_qemu_kvm %{with_qemu} -%else - %define with_qemu_kvm 0 -%endif - -%if ! %{with_qemu_tcg} && ! %{with_qemu_kvm} - %define with_qemu 0 -%endif +%define with_qemu_kvm %{with_qemu} # Then the hypervisor drivers that run outside libvirtd, in libvirt.so %define with_openvz 0%{!?_without_openvz:1} @@ -61,12 +42,6 @@ %endif %define with_storage_gluster 0%{!?_without_storage_gluster:1} -%ifnarch %{qemu_kvm_arches} - # gluster is only built where qemu driver is enabled on RHEL 8 - %if 0%{?rhel} >= 8 - %define with_storage_gluster 0 - %endif -%endif %define with_numactl 0%{!?_without_numactl:1} @@ -97,6 +72,11 @@ # Finally set the OS / architecture specific special cases +# KVM is available on most architectures +%ifnarch %{ix86} x86_64 %{power64} s390x %{arm} aarch64 + %define with_qemu_kvm 0 +%endif + # Xen is available only on i386 x86_64 ia64 %ifnarch %{ix86} x86_64 ia64 %define with_libxl 0 @@ -122,6 +102,23 @@ %define with_storage_rbd 0 %endif +# RHEL does not ship qemu-tcg +%if 0%{?rhel} + %define with_qemu_tcg 0 +%endif + +# In the event that qemu-tcg and qemu-kvm are unavailable, don't ship qemu +%if ! %{with_qemu_tcg} && ! %{with_qemu_kvm} + %define with_qemu 0 +%endif + +%if ! %{with_qemu_kvm} + # gluster is only built where qemu driver is enabled on RHEL 8 + %if 0%{?rhel} >= 8 + %define with_storage_gluster 0 + %endif +%endif + # RHEL doesn't ship OpenVZ, VBox, PowerHypervisor, # VMware, libxenlight (Xen 4.1 and newer), # or HyperV. -- 2.26.2

2 2

[PATCH] qemu: Taint cpu host-passthrough only after migration
by Cole Robinson 05 Oct '20

05 Oct '20

>From a discussion last year[1], Dan recommended libvirt drop the tain flag for cpu host-passthrough, unless the VM has been migrated. This repurposes the existing host-cpu taint flag to do just that. [1]: https://www.redhat.com/archives/virt-tools-list/2019-February/msg00041.html https://bugzilla.redhat.com/show_bug.cgi?id=1673098 Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- src/conf/domain_conf.h | 2 +- src/qemu/qemu_domain.c | 7 +++++-- src/qemu/qemu_domain.h | 3 ++- src/qemu/qemu_process.c | 2 +- 4 files changed, 9 insertions(+), 5 deletions(-) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 9a44315519..450686dfb5 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2736,7 +2736,7 @@ typedef enum { VIR_DOMAIN_TAINT_SHELL_SCRIPTS, /* Network configuration using opaque shell scripts */ VIR_DOMAIN_TAINT_DISK_PROBING, /* Relying on potentially unsafe disk format probing */ VIR_DOMAIN_TAINT_EXTERNAL_LAUNCH, /* Externally launched guest domain */ - VIR_DOMAIN_TAINT_HOST_CPU, /* Host CPU passthrough in use */ + VIR_DOMAIN_TAINT_HOST_CPU, /* Host CPU passthrough in use after migration */ VIR_DOMAIN_TAINT_HOOK, /* Domain (possibly) changed via hook script */ VIR_DOMAIN_TAINT_CDROM_PASSTHROUGH,/* CDROM passthrough */ VIR_DOMAIN_TAINT_CUSTOM_DTB, /* Custom device tree blob was specified */ diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 0331fd55e0..ed4bdbd7fb 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -6115,7 +6115,8 @@ void qemuDomainObjTaint(virQEMUDriverPtr driver, void qemuDomainObjCheckTaint(virQEMUDriverPtr driver, virDomainObjPtr obj, - qemuDomainLogContextPtr logCtxt) + qemuDomainLogContextPtr logCtxt, + bool incomingMigration) { size_t i; g_autoptr(virQEMUDriverConfig) cfg = virQEMUDriverGetConfig(driver); @@ -6144,7 +6145,9 @@ void qemuDomainObjCheckTaint(virQEMUDriverPtr driver, VIR_DOMAIN_TAINT_CUSTOM_HYPERVISOR_FEATURE, logCtxt); } - if (obj->def->cpu && obj->def->cpu->mode == VIR_CPU_MODE_HOST_PASSTHROUGH) + if (obj->def->cpu && + obj->def->cpu->mode == VIR_CPU_MODE_HOST_PASSTHROUGH && + incomingMigration) qemuDomainObjTaint(driver, obj, VIR_DOMAIN_TAINT_HOST_CPU, logCtxt); for (i = 0; i < obj->def->ndisks; i++) diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index ec776ced72..9bf32e16c9 100644 --- a/src/qemu/qemu_domain.h +++ b/src/qemu/qemu_domain.h @@ -567,7 +567,8 @@ void qemuDomainObjTaint(virQEMUDriverPtr driver, void qemuDomainObjCheckTaint(virQEMUDriverPtr driver, virDomainObjPtr obj, - qemuDomainLogContextPtr logCtxt); + qemuDomainLogContextPtr logCtxt, + bool incomingMigration); void qemuDomainObjCheckDiskTaint(virQEMUDriverPtr driver, virDomainObjPtr obj, virDomainDiskDefPtr disk, diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 9122069cc9..57d764014a 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -6856,7 +6856,7 @@ qemuProcessLaunch(virConnectPtr conn, qemuLogOperation(vm, "starting up", cmd, logCtxt); - qemuDomainObjCheckTaint(driver, vm, logCtxt); + qemuDomainObjCheckTaint(driver, vm, logCtxt, incoming != NULL); qemuDomainLogContextMarkPosition(logCtxt); -- 2.28.0

2 1

[libvirt PATCH] news: move section about downscript to v6.4.0
by Ján Tomko 05 Oct '20

05 Oct '20

The feature was merged in v6.3.0-175-g61ba6f09b1 Signed-off-by: Ján Tomko <jtomko(a)redhat.com> Fixes: 4eda71a8d05d968e73ab9b0fdc8a90123c57d39e --- NEWS.rst | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/NEWS.rst b/NEWS.rst index f6074d9fe8..5da6174e42 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -404,6 +404,12 @@ v6.4.0 (2020-06-02) ``virsh capabilities`` will now include information about the host CPU when run on ARM machines. + * qemu: support network interface downscript + + QEMU has the ability to run a script when a NIC is brought up and down. + Libvirt only enables use of the up script. Now add support for postscript + when NIC is down/detached. + * **Improvements** * qemu: stricter validation for disk type='lun' @@ -454,12 +460,6 @@ v6.3.0 (2020-05-05) * **New features** - * qemu: support network interface downscript - - QEMU has the ability to run a script when a NIC is brought up and down. - Libvirt only enables use of the up script. Now add support for postscript - when NIC is down/detached. - * qemu: support disabling hotplug/unplug of PCIe devices libvirt can now set the "hotplug" option for pcie-root-ports and -- 2.26.2

2 1

[libvirt PATCH] API: virDomainLookupByID: s/UUId/UUID/
by Ján Tomko 05 Oct '20

05 Oct '20

Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/libvirt-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 415482a526..a7266ccd88 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -284,7 +284,7 @@ virDomainCreateLinux(virConnectPtr conn, const char *xmlDesc, * * Try to find a domain based on the hypervisor ID number * Note that this won't work for inactive domains which have an ID of -1, - * in that case a lookup based on the Name or UUId need to be done instead. + * in that case a lookup based on the Name or UUID need to be done instead. * * virDomainFree should be used to free the resources after the * domain object is no longer needed. -- 2.26.2

2 1

[PATCH 0/8] hyperv: implement new APIs & more
by mcoleman＠datto.com 05 Oct '20

05 Oct '20

From: Matt Coleman <matt(a)datto.com> These patches fix a couple bugs, consolidate duplicate code, and implement several APIs. Currently, some interactions with Hyper-V systems fail when the system is not configured for the "en-US" locale. Additionally, some CPU names also contain the clock frequency, making it too long for _virNodeInfo.model. The first two patches fix these bugs. The second two patches clean up the code a little: one moves repeated operations into new helper functions; the other replaces the generic "get WMI class list" functions with a macro. The last four patches implement the following APIs in the Hyper-V driver: * virConnectGetCapabilities() * virConnectGetMaxVcpus() * virConnectGetVersion() * virDomainGetAutostart() Matt Coleman (8): hyperv: make Msvm_ComputerSystem WQL queries locale agnostic hyperv: fix nodeGetInfo failures caused by long CPU names hyperv: break out common lookups into separate functions hyperv: replace generic WMI class list helpers with a macro hyperv: implement connectGetCapabilities hyperv: implement connectGetMaxVcpus hyperv: implement connectGetVersion hyperv: implement domainGetAutostart NEWS.rst | 10 + src/hyperv/hyperv_driver.c | 691 ++++++++++++++++++-------- src/hyperv/hyperv_private.h | 2 + src/hyperv/hyperv_wmi.c | 87 +--- src/hyperv/hyperv_wmi.h | 34 +- src/hyperv/hyperv_wmi_classes.h | 4 +- src/hyperv/hyperv_wmi_generator.input | 2 +- 7 files changed, 524 insertions(+), 306 deletions(-) -- 2.27.0

4 20

[PATCH 0/4] docs: formatdomain: misc fixes
by Cole Robinson 05 Oct '20

05 Oct '20

A collection of formatdomain fixes that I've noticed over the past few months Cole Robinson (4): docs: formatdomain: remove doubled filesystem <driver> docs: formatdomain: fix incorrect 'Vsock' heading indent docs: formatdomain: fix net downscript 'since' docs: formatdomain: add spicevmc <redirdev> example docs/formatdomain.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.28.0

2 8

[libvirt PATCH] tests: fix incorrect free of GVariant in our GLib mock functions
by Pavel Hrdina 05 Oct '20

05 Oct '20

GLib implementation of g_dbus_connection_call_sync() calls g_variant_ref_sink() on the passed @parameters to make sure they have proper reference. If the original reference is floating the g_dbus_connection_call_sync() consumes it, but if it's normal reference it will just add another one. Our mock functions were only freeing the @parameters which is incorrect and doesn't reflect how the real implementation works. Reported-by: Cole Robinson <crobinso(a)redhat.com> Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- tests/networkxml2firewalltest.c | 4 +++- tests/virfirewalltest.c | 3 +++ tests/virpolkittest.c | 3 +++ tests/virsystemdtest.c | 4 +++- 4 files changed, 12 insertions(+), 2 deletions(-) diff --git a/tests/networkxml2firewalltest.c b/tests/networkxml2firewalltest.c index e0244f508e..3496445f0d 100644 --- a/tests/networkxml2firewalltest.c +++ b/tests/networkxml2firewalltest.c @@ -60,8 +60,10 @@ VIR_MOCK_WRAP_RET_ARGS(g_dbus_connection_call_sync, GCancellable *, cancellable, GError **, error) { - if (parameters) + if (parameters) { + g_variant_ref_sink(parameters); g_variant_unref(parameters); + } VIR_MOCK_REAL_INIT(g_dbus_connection_call_sync); diff --git a/tests/virfirewalltest.c b/tests/virfirewalltest.c index 607638e9d0..646b999d96 100644 --- a/tests/virfirewalltest.c +++ b/tests/virfirewalltest.c @@ -79,6 +79,9 @@ VIR_MOCK_WRAP_RET_ARGS(g_dbus_connection_call_sync, GVariant *reply = NULL; g_autoptr(GVariant) params = parameters; + if (params) + g_variant_ref_sink(params); + VIR_MOCK_REAL_INIT(g_dbus_connection_call_sync); if (STREQ(bus_name, "org.freedesktop.DBus") && diff --git a/tests/virpolkittest.c b/tests/virpolkittest.c index 011d83a506..b7cbe28466 100644 --- a/tests/virpolkittest.c +++ b/tests/virpolkittest.c @@ -52,6 +52,9 @@ VIR_MOCK_WRAP_RET_ARGS(g_dbus_connection_call_sync, GVariant *reply = NULL; g_autoptr(GVariant) params = parameters; + if (params) + g_variant_ref_sink(params); + VIR_MOCK_REAL_INIT(g_dbus_connection_call_sync); if (STREQ(bus_name, "org.freedesktop.PolicyKit1") && diff --git a/tests/virsystemdtest.c b/tests/virsystemdtest.c index c1411d7c05..bd0ca51140 100644 --- a/tests/virsystemdtest.c +++ b/tests/virsystemdtest.c @@ -54,8 +54,10 @@ VIR_MOCK_WRAP_RET_ARGS(g_dbus_connection_call_sync, { GVariant *reply = NULL; - if (parameters) + if (parameters) { + g_variant_ref_sink(parameters); g_variant_unref(parameters); + } VIR_MOCK_REAL_INIT(g_dbus_connection_call_sync); -- 2.26.2

3 2

[PATCH 1/1] vircommand.c: write child pidfile before process tuning in virExec()
by Daniel Henrique Barboza 03 Oct '20

03 Oct '20

When VIR_EXEC_DAEMON is true and cmd->pidfile exists, the parent will expect the pidfile to be written before exiting, sitting tight in a saferead() call waiting. The child then does process tuning (via virProcessSet* functions) before writing the pidfile. Problem is that these tunings can fail, and trigger a 'fork_error' jump, before cmd->pidfile is written. The result is that the process was aborted in the child, but the parent is still hang in the saferead() call. This behavior can be reproduced by trying to create and execute a QEMU guest in user mode (e.g. using qemu:///session as non-root). virProcessSetMaxMemLock() will fail if the spawned libvirtd user process does not have CAP_SYS_RESOURCE capability. setrlimit() will fail, and a 'fork_error' jump is triggered before cmd->pidfile is written. The parent will hung in saferead() indefinitely. From the user perspective, 'virsh start <guest>' will hang up indefinitely. CTRL+C can be used to retrieve the terminal, but any subsequent 'virsh' call will also hang because the previous libvirtd user process is still there. We can fix this by moving all virProcessSet*() tuning functions to be executed after cmd->pidfile is taken care of. In the case mentioned above, this would be the result of 'virsh start' after this patch: error: Failed to start domain vm1 error: internal error: Process exited prior to exec: libvirt: error : cannot limit locked memory to 79691776: Operation not permitted Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1882093 Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com> --- src/util/vircommand.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/src/util/vircommand.c b/src/util/vircommand.c index 76f7eb9a3d..0475e22db6 100644 --- a/src/util/vircommand.c +++ b/src/util/vircommand.c @@ -787,15 +787,6 @@ virExec(virCommandPtr cmd) } } - if (virProcessSetMaxMemLock(0, cmd->maxMemLock) < 0) - goto fork_error; - if (virProcessSetMaxProcesses(0, cmd->maxProcesses) < 0) - goto fork_error; - if (virProcessSetMaxFiles(0, cmd->maxFiles) < 0) - goto fork_error; - if (cmd->setMaxCore && - virProcessSetMaxCoreSize(0, cmd->maxCore) < 0) - goto fork_error; if (cmd->pidfile) { int pidfilefd = -1; char c; @@ -820,6 +811,16 @@ virExec(virCommandPtr cmd) /* pidfilefd is intentionally leaked. */ } + if (virProcessSetMaxMemLock(0, cmd->maxMemLock) < 0) + goto fork_error; + if (virProcessSetMaxProcesses(0, cmd->maxProcesses) < 0) + goto fork_error; + if (virProcessSetMaxFiles(0, cmd->maxFiles) < 0) + goto fork_error; + if (cmd->setMaxCore && + virProcessSetMaxCoreSize(0, cmd->maxCore) < 0) + goto fork_error; + if (cmd->hook) { VIR_DEBUG("Run hook %p %p", cmd->hook, cmd->opaque); ret = cmd->hook(cmd->opaque); -- 2.26.2

3 5

[libvirt PATCH 0/5] misc spelling errors reported by codespell
by Daniel P. Berrangé 02 Oct '20

02 Oct '20

2 8

[PATCH] NEWS: mention CVE-2020-25637 in v6.8.0 release notes
by Mauro Matteo Cascella 02 Oct '20

02 Oct '20

--- NEWS.rst | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index de46cac8c5..f6074d9fe8 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -27,6 +27,14 @@ v6.9.0 (unreleased) v6.8.0 (2020-10-01) =================== +* **Security** + + * qemu: double free in qemuAgentGetInterfaces() in qemu_agent.c + + Clients connecting to the read-write socket with limited ACL permissions + may be able to crash the libvirt daemon, resulting in a denial of service, + or potentially escalate their privileges on the system. CVE-2020-25637. + * **New features** * xen: Add ``writeFiltering`` attribute for PCI devices -- 2.26.2

2 2

[PATCH 0/6] virBitmapCopy: Refactor to prevent failures
by Peter Krempa 02 Oct '20

02 Oct '20

Note that this applies on top of my previous series dealing with bitmaps. Peter Krempa (6): virBitmapNewCopy: Reimplement bitmap copying to prevent failure Don't check return value of virBitmapNewCopy Use 'virBitmapNewCopy' instead of 'virBitmapCopy' util: virbitmap: Remove virBitmapCopy virDomainResctrlNew: Refactor allocation to remove 'cleanup' label qemuDomainFilterHotplugVcpuEntities: Refactor memory freeing to remove 'cleanup' label src/conf/capabilities.c | 6 ++---- src/conf/domain_conf.c | 19 ++++-------------- src/conf/numa_conf.c | 4 ++-- src/libvirt_private.syms | 1 - src/qemu/qemu_capabilities.c | 3 ++- src/qemu/qemu_driver.c | 13 +++---------- src/qemu/qemu_hotplug.c | 20 ++++++------------- src/qemu/qemu_migration_cookie.c | 3 --- src/qemu/qemu_process.c | 3 +-- src/test/test_driver.c | 5 +---- src/util/virbitmap.c | 33 ++------------------------------ src/util/virbitmap.h | 6 ------ src/util/virresctrl.c | 4 ++-- src/util/virstoragefile.c | 5 ++--- 14 files changed, 27 insertions(+), 98 deletions(-) -- 2.26.2

2 12

[PATCH 00/20] qemu: migration_cookie: Refactor and modernize
by Peter Krempa 02 Oct '20

02 Oct '20

Note that this applies on top of the recent bitmap refactors Peter Krempa (20): qemu: migration_cookie: Extract parsing/validation of mandatory features qemuMigrationCookieXMLParse: Switch to single-purpose temporary variables qemuMigrationCookieXMLParse: Check domain element count more defensively qemuMigrationCookieXMLParse: Decrease scope of 'nodes' and use automatic freeing qemuMigrationCookieXMLParse: Remove comment mentioning that error was already set qemuMigrationCookieXMLParse: Remove 'error' label qemuMigrationCookieGraphicsXMLFormat: Use 'virXMLFormatElement' qemuMigrationCookieNetworkXMLFormat: Refactor XML formatting qemuMigrationCookieXMLFormat: Extract formatting of NBD qemuDomainExtractTLSSubject: Refactor memory handling qemu: migration_cookie: Register 'autoptr' functions for internal types qemuMigrationCookieGraphicsSpiceAlloc: Refactor memory handling qemuMigrationCookieNetworkAlloc: Refactor memory handling qemuMigrationCookieXMLFormat: Refactor memory handling qemuMigrationCookieNetworkXMLParse: Refactor memory handling qemuMigrationCookieNBDXMLParse: Refactor memory handling qemuMigrationCookieCapsXMLParse: Refactor memory handling qemuMigrationCookieAddCaps: Use 'g_new0' instead of VIR_ALLOC qemuMigrationCookieXMLParse: Avoid VIR_FREE when parsing lockstate qemu: migration_cookie: s/VIR_FREE/g_free/ src/qemu/qemu_migration_cookie.c | 493 ++++++++++++++----------------- 1 file changed, 214 insertions(+), 279 deletions(-) -- 2.26.2

2 21

virsystemdtest segfault on ppc64
by Cole Robinson 02 Oct '20

02 Oct '20

I'm seeing failures building libvirt 6.8.0 rpm on fedora 32, 33, and rawhide. virsystemdtest is segfaulting on ppc64. https://kojipkgs.fedoraproject.org//work/tasks/5494/52595494/build.log The output from the failed tests: 74/160 libvirt / virsystemdtest FAIL 0.44s (killed by signal 11 SIGSEGV) --- command --- 17:14:09 abs_srcdir='/builddir/build/BUILD/libvirt-6.8.0/tests' abs_top_srcdir='/builddir/build/BUILD/libvirt-6.8.0' VIR_TEST_EXPENSIVE='1' LIBVIRT_AUTOSTART='0' abs_top_builddir='/builddir/build/BUILD/libvirt-6.8.0/ppc64le-redhat-linux-gnu' LC_ALL='C' abs_builddir='/builddir/build/BUILD/libvirt-6.8.0/ppc64le-redhat-linux-gnu/tests' /builddir/build/BUILD/libvirt-6.8.0/ppc64le-redhat-linux-gnu/tests/virsystemdtest --- stderr --- TEST: virsystemdtest (process:3397099): GLib-CRITICAL **: 17:14:09.137: g_atomic_ref_count_dec: assertion 'g_atomic_int_get (arc) > 0' failed . (process:3397099): GLib-CRITICAL **: 17:14:09.137: g_atomic_ref_count_dec: assertion 'g_atomic_int_get (arc) > 0' failed . (process:3397099): GLib-CRITICAL **: 17:14:09.137: g_atomic_ref_count_dec: assertion 'g_atomic_int_get (arc) > 0' failed . (process:3397099): GLib-CRITICAL **: 17:14:09.137: g_atomic_ref_count_dec: assertion 'g_atomic_int_get (arc) > 0' failed . (process:3397099): GLib-CRITICAL **: 17:14:09.137: g_atomic_ref_count_dec: assertion 'g_atomic_int_get (arc) > 0' failed . (process:3397099): GLib-CRITICAL **: 17:14:09.137: g_atomic_ref_count_dec: assertion 'g_atomic_int_get (arc) > 0' failed . (process:3397099): GLib-CRITICAL **: 17:14:09.137: g_atomic_ref_count_dec: assertion 'g_atomic_int_get (arc) > 0' failed . (process:3397099): GLib-CRITICAL **: 17:14:09.137: g_atomic_ref_count_dec: assertion 'g_atomic_int_get (arc) > 0' failed ..... (process:3397099): GLib-CRITICAL **: 17:14:09.138: g_atomic_ref_count_dec: assertion 'g_atomic_int_get (arc) > 0' failed . (process:3397099): GLib-CRITICAL **: 17:14:09.138: g_atomic_ref_count_dec: assertion 'g_atomic_int_get (arc) > 0' failed . (process:3397099): GLib-CRITICAL **: 17:14:09.138: g_atomic_ref_count_dec: assertion 'g_atomic_int_get (arc) > 0' failed . (process:3397099): GLib-CRITICAL **: 17:14:09.138: g_atomic_ref_count_dec: assertion 'g_atomic_int_get (arc) > 0' failed . ------- Full log written to /builddir/build/BUILD/libvirt-6.8.0/ppc64le-redhat-linux-gnu/meson-logs/testlog.txt RPM build errors: error: Bad exit status from /var/tmp/rpm-tmp.Yh8pF5 (%check) Bad exit status from /var/tmp/rpm-tmp.Yh8pF5 (%check) Child return code was: 1 Thanks, Cole

4 4

[PATCH 0/5] GDBus and memleak fixes
by Michal Privoznik 02 Oct '20

02 Oct '20

The first patch fixes issue raised by Cole here: https://www.redhat.com/archives/libvir-list/2020-October/msg00037.html The second one sets the environment variable which will cause our tests fail should we run into similar problem. To see it in action just switch order with patch 1/5 and observe test suite failing. The last two patches fix memleaks I've found during debugging the original problem. https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/197284472 Michal Prívozník (5): lib: Don't unref message passed to virGDBusCallMethod{WithFD}() tests: Set G_DEBUG environment variable virfirewalltest: Don't duplicate string when adding it onto stringlist vmx; Free @checkMACAddress in virVMXParseEthernet() NEWS: Document recent GLib DBus fix NEWS.rst | 6 ++++++ src/rpc/virnetdaemon.c | 4 ++-- src/util/virfirewalld.c | 16 ++++++++-------- src/util/virgdbus.c | 29 ++++++++++++++++++++--------- src/util/virgdbus.h | 4 ++-- src/util/virpolkit.c | 4 ++-- src/util/virsystemd.c | 23 ++++++++--------------- src/vmx/vmx.c | 1 + tests/meson.build | 1 + tests/virfirewalltest.c | 2 +- 10 files changed, 51 insertions(+), 39 deletions(-) -- 2.26.2

3 11

[libvirt PATCH] build: remove old macvtap and virtualport leftovers
by Pino Toscano 02 Oct '20

02 Oct '20

Followup of commit a79e7639daffac04b088378e6c79854fcac292f3 and commit 7556ab139fd2e503ac26ee232ab273f1ec027c21. Signed-off-by: Pino Toscano <ptoscano(a)redhat.com> --- meson.build | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/meson.build b/meson.build index 257e4452a1..a5ce8e17a8 100644 --- a/meson.build +++ b/meson.build @@ -1503,10 +1503,6 @@ elif get_option('firewalld_zone').enabled() error('You must have firewalld support enabled to enable firewalld_zone') endif -if conf.has('WITH_MACVTAP') and not conf.has('WITH_LIBNL') - error('libnl3-devel is required for macvtap support') -endif - if (pkcheck_prog.found() or get_option('polkit').enabled()) conf.set('WITH_POLKIT', 1) endif @@ -1515,10 +1511,6 @@ if udev_dep.found() and not pciaccess_dep.found() error('You must install the pciaccess module to build with udev') endif -if conf.has('WITH_VIRTUALPORT') and not conf.has('WITH_MACVTAP') - error('macvtap is required for virtualport support') -endif - # build driver options @@ -2388,7 +2380,6 @@ libs_summary = { 'libssh': libssh_dep.found(), 'libssh2': libssh2_dep.found(), 'libxml': libxml_dep.found(), - 'macvtap': conf.has('WITH_MACVTAP'), 'netcf': netcf_dep.found(), 'NLS': have_gnu_gettext_tools, 'nss': conf.has('WITH_NSS'), @@ -2403,7 +2394,6 @@ libs_summary = { 'sasl': sasl_dep.found(), 'selinux': selinux_dep.found(), 'udev': udev_dep.found(), - 'virtualport': conf.has('WITH_VIRTUALPORT'), 'xdr': xdr_dep.found(), 'yajl': yajl_dep.found(), } -- 2.26.2

2 1

[PATCH 0/1] Add support for QEMU's 'fmode' and 'dmode'
by Brian Turek 02 Oct '20

02 Oct '20

This patch exposes QEMU's 9pfs's 'fmode' and 'dmode flags options. I followed Ján Tomko's advice from his reply to my email to the mailing list yesterday and heavily based this on the patches that added 'multidev' support. The only part I am unsure of is whether modifying all of the 'caps' files was necessary or if only a certain few needed changing. Brian Turek (1): qemu: add support for 'fmode' and 'dmode' docs/formatdomain.rst | 12 ++++ docs/schemas/domaincommon.rng | 16 +++++ src/conf/domain_conf.c | 43 +++++++++++++ src/conf/domain_conf.h | 2 + src/qemu/qemu_capabilities.c | 4 ++ src/qemu/qemu_capabilities.h | 2 + src/qemu/qemu_command.c | 6 ++ src/qemu/qemu_validate.c | 26 ++++++++ .../caps_2.10.0.aarch64.xml | 2 + .../caps_2.10.0.ppc64.xml | 2 + .../caps_2.10.0.s390x.xml | 2 + .../caps_2.10.0.x86_64.xml | 2 + .../caps_2.11.0.s390x.xml | 2 + .../caps_2.11.0.x86_64.xml | 2 + .../caps_2.12.0.aarch64.xml | 2 + .../caps_2.12.0.ppc64.xml | 2 + .../caps_2.12.0.s390x.xml | 2 + .../caps_2.12.0.x86_64.xml | 2 + .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 2 + .../caps_3.0.0.riscv32.xml | 2 + .../caps_3.0.0.riscv64.xml | 2 + .../qemucapabilitiesdata/caps_3.0.0.s390x.xml | 2 + .../caps_3.0.0.x86_64.xml | 2 + .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 2 + .../caps_3.1.0.x86_64.xml | 2 + .../caps_4.0.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 2 + .../caps_4.0.0.riscv32.xml | 2 + .../caps_4.0.0.riscv64.xml | 2 + .../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 2 + .../caps_4.0.0.x86_64.xml | 2 + .../caps_4.1.0.x86_64.xml | 2 + .../caps_4.2.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 2 + .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 2 + .../caps_4.2.0.x86_64.xml | 2 + .../caps_5.0.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 2 + .../caps_5.0.0.riscv64.xml | 2 + .../caps_5.0.0.x86_64.xml | 2 + .../caps_5.1.0.x86_64.xml | 2 + .../caps_5.2.0.x86_64.xml | 2 + .../virtio-9p-fmodedmode.x86_64-latest.args | 48 +++++++++++++++ .../qemuxml2argvdata/virtio-9p-fmodedmode.xml | 58 ++++++++++++++++++ .../virtio-9p-fmodedmode.x86_64-latest.xml | 61 +++++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 46 files changed, 347 insertions(+) create mode 100644 tests/qemuxml2argvdata/virtio-9p-fmodedmode.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/virtio-9p-fmodedmode.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-9p-fmodedmode.x86_64-latest.xml -- 2.25.1

2 2

[libvirt PATCH v4 0/6] Add support for vDPA network devices
by Jonathon Jongsma 02 Oct '20

02 Oct '20

vDPA network devices allow high-performance networking in a virtual machine by providing a wire-speed data path. These devices require a vendor-specific host driver but the data path follows the virtio specification. The support for vDPA devices was recently added to qemu. This allows libvirt to support these devices. This patchset requires that the device is configured on the host with the appropriate vendor-specific driver. This will create a chardev on the host at e.g. /dev/vhost-vdpa-0. That chardev path can then be used to define a new interface with type=3D'vdpa'. Changes in v4: - rebased to latest master - added hotplug support - report vdpa devices in node device list Jonathon Jongsma (6): conf: Add support for vDPA network devices qemu: add vhost-vdpa capability qemu: add vdpa support qemu: add monitor functions for handling file descriptors qemu: support hotplug of vdpa devices Include vdpa devices in node device list docs/formatdomain.rst | 24 +++ docs/schemas/domaincommon.rng | 15 ++ include/libvirt/libvirt-nodedev.h | 1 + src/conf/domain_conf.c | 31 ++++ src/conf/domain_conf.h | 4 + src/conf/netdev_bandwidth_conf.c | 1 + src/conf/node_device_conf.c | 5 + src/conf/node_device_conf.h | 4 +- src/conf/virnodedeviceobj.c | 4 +- src/libxl/libxl_conf.c | 1 + src/libxl/xen_common.c | 1 + src/lxc/lxc_controller.c | 1 + src/lxc/lxc_driver.c | 3 + src/lxc/lxc_process.c | 1 + src/node_device/node_device_udev.c | 16 ++ src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_command.c | 36 +++- src/qemu/qemu_command.h | 3 +- src/qemu/qemu_domain.c | 6 +- src/qemu/qemu_hotplug.c | 73 +++++++- src/qemu/qemu_interface.c | 25 +++ src/qemu/qemu_interface.h | 2 + src/qemu/qemu_migration.c | 10 +- src/qemu/qemu_monitor.c | 93 ++++++++++ src/qemu/qemu_monitor.h | 41 +++++ src/qemu/qemu_monitor_json.c | 173 ++++++++++++++++++ src/qemu/qemu_monitor_json.h | 12 ++ src/qemu/qemu_process.c | 2 + src/qemu/qemu_validate.c | 15 ++ src/vmx/vmx.c | 1 + .../caps_5.1.0.x86_64.xml | 1 + .../caps_5.2.0.x86_64.xml | 1 + tests/qemuhotplugmock.c | 9 + tests/qemuhotplugtest.c | 16 ++ .../qemuhotplug-interface-vdpa.xml | 4 + .../qemuhotplug-base-live+interface-vdpa.xml | 57 ++++++ .../net-vdpa.x86_64-latest.args | 37 ++++ tests/qemuxml2argvdata/net-vdpa.xml | 28 +++ tests/qemuxml2argvmock.c | 11 +- tests/qemuxml2argvtest.c | 1 + tests/qemuxml2xmloutdata/net-vdpa.xml | 34 ++++ tests/qemuxml2xmltest.c | 1 + tools/virsh-domain.c | 1 + tools/virsh-nodedev.c | 3 + 45 files changed, 799 insertions(+), 16 deletions(-) create mode 100644 tests/qemuhotplugtestdevices/qemuhotplug-interface-vdpa.x= ml create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-base-live+interf= ace-vdpa.xml create mode 100644 tests/qemuxml2argvdata/net-vdpa.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/net-vdpa.xml create mode 100644 tests/qemuxml2xmloutdata/net-vdpa.xml --=20 2.26.2

3 15

[PATCH 0/9] various build flag related fixes
by Laine Stump 02 Oct '20

02 Oct '20

These patches eliminate a few build flags that were necessary back 10 years ago when their associated features had been newly added to the kernel, but are now pointless (because all supported Linuxes have the feature) (1-6), makes it possible to to a successful (and usable, albeit limited in some ways) build on a system that doesn't have libnl3-devel installed (7-8) (macvtap and interface type='hostdev' don't work, but standard tap devices do), and removes a duplicated identifier check that I noticed in meson.build (9). Laine Stump (9): util: remove useless check for IFLA_VF_MAX util: remove extraneous defined(__linux__) when checking for WITH_LIBNL build: eliminate useless WITH_VIRTUALPORT check build: remove check for MACVLAN_MODE_PASSTHRU build: simplify check for WITH_MACVTAP build: eliminate WITH_MACVTAP flag util: fix Linux build when libnl-devel isn't available util: provide non-netlink/libnl alternative for virNetDevGetMaster() build: remove duplicate check for GET_VLAN_VID_CMD libvirt.spec.in | 1 - meson.build | 30 ------------------------ src/util/virnetdev.c | 40 ++++++++++++++++++++++++++------ src/util/virnetdevbridge.c | 6 ++--- src/util/virnetdevip.c | 6 ++--- src/util/virnetdevmacvlan.c | 11 +++------ src/util/virnetdevvportprofile.c | 8 +++---- src/util/virnetlink.c | 4 ++-- src/util/virnetlink.h | 4 ++-- tools/virsh.c | 3 --- 10 files changed, 50 insertions(+), 63 deletions(-) -- 2.26.2

4 18

[libvirt PATCH] Revert "Also look for dmi information in /sys/class"
by Ján Tomko 01 Oct '20

01 Oct '20

Assume nobody runs current libvirt on kernels such as 2.6.26. Kernel commit 9f9c9cbb60576a1518d0bf93fb8e499cffccf377 (released in 3.8) mentions the new path and I believe it was added by: commit 948af1f0bbc8526448e8cbe3f8d3bf211bdf5181 firmware: Basic dmi-sysfs support (released in 2.6.39), but I cannot figure out how all that kernel automagic works. This reverts commit 4c81b0fdc57b23d80b1b4752cd6143d15c02e9c8 Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/node_device/node_device_udev.c | 13 +++++-------- src/node_device/node_device_udev.h | 1 - 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c index 2d0ca27fc6..29a7eaa07c 100644 --- a/src/node_device/node_device_udev.c +++ b/src/node_device/node_device_udev.c @@ -1731,14 +1731,11 @@ udevGetDMIData(virNodeDevCapSystemPtr syscap) device = udev_device_new_from_syspath(udev, DMI_DEVPATH); if (device == NULL) { - device = udev_device_new_from_syspath(udev, DMI_DEVPATH_FALLBACK); - if (device == NULL) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Failed to get udev device for syspath '%s' or '%s'"), - DMI_DEVPATH, DMI_DEVPATH_FALLBACK); - virObjectUnlock(priv); - return; - } + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Failed to get udev device for syspath '%s'"), + DMI_DEVPATH); + virObjectUnlock(priv); + return; } virObjectUnlock(priv); diff --git a/src/node_device/node_device_udev.h b/src/node_device/node_device_udev.h index 996677dfe0..eab22a9182 100644 --- a/src/node_device/node_device_udev.h +++ b/src/node_device/node_device_udev.h @@ -24,4 +24,3 @@ #define SYSFS_DATA_SIZE 4096 #define DMI_DEVPATH "/sys/devices/virtual/dmi/id" -#define DMI_DEVPATH_FALLBACK "/sys/class/dmi/id" -- 2.26.2

2 1

[PATCH 0/3] logging: fix a couple of issues
by Nikolay Shirokovskiy 01 Oct '20

01 Oct '20

The code fixed in the first actual patch is quite venerable so I made up a synthetic test to show issue/test it is fixed. Test covers both issues. Initially I got /tmp/virtlogd-test size of only 2048 and after the first fix I saw actual endless loop. Nikolay Shirokovskiy (3): DO NOT APPLY: code to show logging issues logging: read all bytes on EOF in event handler logging: fix endless loop on EOF src/logging/log_handler.c | 10 ++++++---- src/qemu/qemu_process.c | 35 +++++++++++++++++++++++++++++++++++ 2 files changed, 41 insertions(+), 4 deletions(-) -- 1.8.3.1

2 5