- Devel - libvirt List Archives

[PATCH] NEWS: support phytium processor
by yangshaojun19＠163.com 19 Nov '20

19 Nov '20

From: Shaojun Yang <yangshaojun(a)phytium.com.cn> FT-2000+ and Tengyun-S2500 are two chips by produced by Phytium Technology Co., Ltd., which based on ARMv8 architecture. Shaojun Yang (1): add phytium FT-2000+ and Tengyun-S2500 support on arm architecture. src/cpu_map/arm_FT-2000plus.xml | 6 ++++++ src/cpu_map/arm_Tengyun-S2500.xml | 6 ++++++ src/cpu_map/arm_vendors.xml | 1 + src/cpu_map/index.xml | 4 ++++ src/cpu_map/meson.build | 2 ++ 5 files changed, 19 insertions(+) create mode 100644 src/cpu_map/arm_FT-2000plus.xml create mode 100644 src/cpu_map/arm_Tengyun-S2500.xml -- 2.7.4

2 2

[libvirt PATCH] cgroup: add stub for virCgroupNew
by Ján Tomko 19 Nov '20

19 Nov '20

The previous commit exported the function but forgot to add a non-Linux stub. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> Fixes: 126cb34a206a44f04e364700b46426dff9f387d5 --- Pushed. src/util/vircgroup.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index e0fe1dbf3e..13df10e507 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -2820,6 +2820,17 @@ virCgroupNewPartition(const char *path G_GNUC_UNUSED, } +int +virCgroupNew(const char *path G_GNUC_UNUSED, + int controllers G_GNUC_UNUSED, + virCgroupPtr *group G_GNUC_UNUSED) +{ + virReportSystemError(ENXIO, "%s", + _("Control groups not supported on this platform")); + return -1; +} + + int virCgroupNewSelf(virCgroupPtr *group G_GNUC_UNUSED) { -- 2.26.2

1 0

[libvirt PATCH] virt-host-validate: fix detection with cgroups v2
by Pavel Hrdina 19 Nov '20

19 Nov '20

Using virtCgroupNewSelf() is not correct with cgroups v2 because the the virt-host-validate process is executed from from the same cgroup context as the terminal and usually not all controllers are enabled by default. To do a proper check we need to use the root cgroup to see what controllers are actually available. Libvirt or systemd ensures that all controllers are available for VMs as well. This still doesn't solve the devices controller with cgroups v2 where there is no controller as it was replaced by eBPF. Currently libvirt tries to query eBPF programs which usually works only for root as regular users will get permission denied for that operation. Fixes: https://gitlab.com/libvirt/libvirt/-/issues/94 Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/libvirt_private.syms | 1 + src/util/vircgroup.h | 4 ++++ src/util/vircgrouppriv.h | 4 ---- tools/virt-host-validate-common.c | 2 +- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 1d98f01334..79a23f34cb 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1796,6 +1796,7 @@ virCgroupHasController; virCgroupHasEmptyTasks; virCgroupKillPainfully; virCgroupKillRecursive; +virCgroupNew; virCgroupNewDetect; virCgroupNewDetectMachine; virCgroupNewDomainPartition; diff --git a/src/util/vircgroup.h b/src/util/vircgroup.h index 78770f5d3b..f7eed983cc 100644 --- a/src/util/vircgroup.h +++ b/src/util/vircgroup.h @@ -60,6 +60,10 @@ typedef enum { bool virCgroupAvailable(void); +int virCgroupNew(const char *path, + int controllers, + virCgroupPtr *group); + int virCgroupNewSelf(virCgroupPtr *group) ATTRIBUTE_NONNULL(1); diff --git a/src/util/vircgrouppriv.h b/src/util/vircgrouppriv.h index baa84550f4..85ba5393e0 100644 --- a/src/util/vircgrouppriv.h +++ b/src/util/vircgrouppriv.h @@ -110,10 +110,6 @@ int virCgroupGetValueForBlkDev(const char *str, const char *devPath, char **value); -int virCgroupNew(const char *path, - int controllers, - virCgroupPtr *group); - int virCgroupNewPartition(const char *path, bool create, int controllers, diff --git a/tools/virt-host-validate-common.c b/tools/virt-host-validate-common.c index a10ac03293..fc43b2ddc8 100644 --- a/tools/virt-host-validate-common.c +++ b/tools/virt-host-validate-common.c @@ -293,7 +293,7 @@ int virHostValidateCGroupControllers(const char *hvname, int ret = 0; size_t i; - if (virCgroupNewSelf(&group) < 0) + if (virCgroupNew("/", -1, &group) < 0) return -1; for (i = 0; i < VIR_CGROUP_CONTROLLER_LAST; i++) { -- 2.26.2

3 2

[PATCH] virsh: Added attach-disk support for network disk
by Ryan Gahagan 19 Nov '20

19 Nov '20

Related issue: https://gitlab.com/libvirt/libvirt/-/issues/16 Added in support for the following parameters in attach-disk: --source-protocol --source-host-name --source-host-socket --source-host-transport Added documentation to virsh.rst specifying usage. Signed-off-by: Ryan Gahagan <rgahagan(a)cs.utexas.edu> --- docs/manpages/virsh.rst | 31 ++++++--- tools/virsh-domain.c | 135 +++++++++++++++++++++++++++++++++++----- 2 files changed, 145 insertions(+), 21 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index 1ae6d1a0d4..36c868a3e6 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -4538,14 +4538,18 @@ attach-disk [--current]] | [--persistent]] [--targetbus bus] [--driver driver] [--subdriver subdriver] [--iothread iothread] [--cache cache] [--io io] [--type type] [--alias alias] - [--mode mode] [--sourcetype sourcetype] [--serial serial] - [--wwn wwn] [--rawio] [--address address] [--multifunction] - [--print-xml] + [--mode mode] [--sourcetype sourcetype] + [--source-protocol protocol] [--source-host-name hostname:port] + [--source-host-transport transport] [--source-host-socket socket] + [--serial serial] [--wwn wwn] [--rawio] [--address address] + [--multifunction] [--print-xml] Attach a new disk device to the domain. -*source* is path for the files and devices. *target* controls the bus or -device under which the disk is exposed to the guest OS. It indicates the -"logical" device name; the optional *targetbus* attribute specifies the type +*source* is path for the files and devices unless *--source-protocol* +is specified, in which case *source* is the name of a network disk. +*target* controls the bus or device under which the disk is exposed +to the guest OS. It indicates the "logical" device name; +the optional *targetbus* attribute specifies the type of disk device to emulate; possible values are driver specific, with typical values being *ide*, *scsi*, *virtio*, *xen*, *usb*, *sata*, or *sd*, if omitted, the bus type is inferred from the style of the device name (e.g. a @@ -4563,7 +4567,7 @@ within the existing virtual cdrom or floppy device; consider using ``update-device`` for this usage instead. *alias* can set user supplied alias. *mode* can specify the two specific mode *readonly* or *shareable*. -*sourcetype* can indicate the type of source (block|file) +*sourcetype* can indicate the type of source (block|file|network) *cache* can be one of "default", "none", "writethrough", "writeback", "directsync" or "unsafe". *io* controls specific policies on I/O; QEMU guests support "threads", @@ -4579,6 +4583,19 @@ ccw:cssid.ssid.devno. Virtio-ccw devices must have their cssid set to 0xfe. *multifunction* indicates specified pci address is a multifunction pci device address. +There is also support for using a network disk. As specified, the user can +provide a *--source-protocol* in which case the *source* parameter will +be interpreted as the source name. *--source-protocol* must be provided +if the user intends to provide a network disk or host information. +Host information can be provided using the tags +*--source-host-name*, *--source-host-transport*, and *--source-host-socket*, +which respectively denote the name of the host, the host's transport method, +and the socket that the host uses. *--source-host-socket* and +*--source-host-name* cannot both be provided, and the user must provide a +*--source-host-transport* if they want to provide a *--source-host-socket*. +The *--source-host-name* parameter supports host:port syntax +if the user wants to provide a port as well. + If *--print-xml* is specified, then the XML of the disk that would be attached is printed instead. diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index c999458d72..1303676c33 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -222,7 +222,7 @@ static const vshCmdOptDef opts_attach_disk[] = { {.name = "source", .type = VSH_OT_DATA, .flags = VSH_OFLAG_REQ | VSH_OFLAG_EMPTY_OK, - .help = N_("source of disk device") + .help = N_("source of disk device or name of network disk") }, {.name = "target", .type = VSH_OT_DATA, @@ -268,7 +268,7 @@ static const vshCmdOptDef opts_attach_disk[] = { }, {.name = "sourcetype", .type = VSH_OT_STRING, - .help = N_("type of source (block|file)") + .help = N_("type of source (block|file|network)") }, {.name = "serial", .type = VSH_OT_STRING, @@ -298,6 +298,22 @@ static const vshCmdOptDef opts_attach_disk[] = { .type = VSH_OT_BOOL, .help = N_("print XML document rather than attach the disk") }, + {.name = "source-protocol", + .type = VSH_OT_STRING, + .help = N_("protocol used by disk device source") + }, + {.name = "source-host-name", + .type = VSH_OT_STRING, + .help = N_("host name for source of disk device") + }, + {.name = "source-host-transport", + .type = VSH_OT_STRING, + .help = N_("host transport for source of disk device") + }, + {.name = "source-host-socket", + .type = VSH_OT_STRING, + .help = N_("host socket for source of disk device") + }, VIRSH_COMMON_OPT_DOMAIN_PERSISTENT, VIRSH_COMMON_OPT_DOMAIN_CONFIG, VIRSH_COMMON_OPT_DOMAIN_LIVE, @@ -558,6 +574,13 @@ static int str2DiskAddress(const char *str, struct DiskAddress *diskAddr) return -1; } +typedef enum { + VIRSH_SOURCE_TYPE_FILE, + VIRSH_SOURCE_TYPE_BLOCK, + VIRSH_SOURCE_TYPE_NETWORK, + VIRSH_SOURCE_TYPE_UNKNOWN, +} virshAttachDiskSourceType; + static bool cmdAttachDisk(vshControl *ctl, const vshCmd *cmd) { @@ -567,8 +590,14 @@ cmdAttachDisk(vshControl *ctl, const vshCmd *cmd) *iothread = NULL, *cache = NULL, *io = NULL, *serial = NULL, *straddr = NULL, *wwn = NULL, *targetbus = NULL, *alias = NULL; + const char *source_protocol = NULL; + const char *host_name = NULL; + const char *host_transport = NULL; + const char *host_socket = NULL; + char *host_port = NULL; struct DiskAddress diskAddr; - bool isFile = false, functionReturn = false; + virshAttachDiskSourceType disk_type = VIRSH_SOURCE_TYPE_UNKNOWN; + bool functionReturn = false; int ret; unsigned int flags = VIR_DOMAIN_AFFECT_CURRENT; const char *stype = NULL; @@ -585,6 +614,13 @@ cmdAttachDisk(vshControl *ctl, const vshCmd *cmd) VSH_EXCLUSIVE_OPTIONS_VAR(current, live); VSH_EXCLUSIVE_OPTIONS_VAR(current, config); + VSH_REQUIRE_OPTION("source-host-name", "source-protocol"); + VSH_REQUIRE_OPTION("source-host-transport", "source-protocol"); + VSH_REQUIRE_OPTION("source-host-socket", "source-protocol"); + VSH_REQUIRE_OPTION("source-host-socket", "source-host-transport"); + + VSH_EXCLUSIVE_OPTIONS("source-host-name", "source-host-socket"); + if (config || persistent) flags |= VIR_DOMAIN_AFFECT_CONFIG; if (live) @@ -604,23 +640,45 @@ cmdAttachDisk(vshControl *ctl, const vshCmd *cmd) vshCommandOptStringReq(ctl, cmd, "address", &straddr) < 0 || vshCommandOptStringReq(ctl, cmd, "targetbus", &targetbus) < 0 || vshCommandOptStringReq(ctl, cmd, "alias", &alias) < 0 || - vshCommandOptStringReq(ctl, cmd, "sourcetype", &stype) < 0) + vshCommandOptStringReq(ctl, cmd, "sourcetype", &stype) < 0 || + vshCommandOptStringReq(ctl, cmd, "source-protocol", &source_protocol) < 0 || + vshCommandOptStringReq(ctl, cmd, "source-host-name", &host_name) < 0 || + vshCommandOptStringReq(ctl, cmd, "source-host-transport", &host_transport) < 0 || + vshCommandOptStringReq(ctl, cmd, "source-host-socket", &host_socket) < 0) goto cleanup; if (!stype) { if (driver && (STREQ(driver, "file") || STREQ(driver, "tap"))) { - isFile = true; + disk_type = VIRSH_SOURCE_TYPE_FILE; } else { - if (source && !stat(source, &st)) - isFile = S_ISREG(st.st_mode) ? true : false; + if (source && !stat(source, &st)) { + if (S_ISREG(st.st_mode)) + disk_type = VIRSH_SOURCE_TYPE_FILE; + else + disk_type = VIRSH_SOURCE_TYPE_BLOCK; + } } } else if (STREQ(stype, "file")) { - isFile = true; - } else if (STRNEQ(stype, "block")) { + disk_type = VIRSH_SOURCE_TYPE_FILE; + } else if (STREQ(stype, "block")) { + disk_type = VIRSH_SOURCE_TYPE_BLOCK; + } else if (STREQ(stype, "network")) { + /* The user must provide a protocol for a network disk */ + if (!source_protocol) { + vshError(ctl, _("A source-protocol must be provided for a network disk")); + goto cleanup; + } + } else { vshError(ctl, _("Unknown source type: '%s'"), stype); goto cleanup; } + /* If a protocol is provided, the disk is assumed to be a network disk. + * This overwrites other disk types, such as an explicit + * 'sourcetype=file' or comparable parameter. */ + if (source_protocol) + disk_type = VIRSH_SOURCE_TYPE_NETWORK; + if (mode) { if (STRNEQ(mode, "readonly") && STRNEQ(mode, "shareable")) { vshError(ctl, _("No support for %s in command 'attach-disk'"), @@ -633,8 +691,13 @@ cmdAttachDisk(vshControl *ctl, const vshCmd *cmd) goto cleanup; /* Make XML of disk */ - virBufferAsprintf(&buf, "<disk type='%s'", - isFile ? "file" : "block"); + if (disk_type == VIRSH_SOURCE_TYPE_FILE) + virBufferAddLit(&buf, "<disk type='file'"); + else if (disk_type == VIRSH_SOURCE_TYPE_BLOCK) + virBufferAddLit(&buf, "<disk type='block'"); + else if (disk_type == VIRSH_SOURCE_TYPE_NETWORK) + virBufferAddLit(&buf, "<disk type='network'"); + if (type) virBufferAsprintf(&buf, " device='%s'", type); if (vshCommandOptBool(cmd, "rawio")) @@ -659,9 +722,53 @@ cmdAttachDisk(vshControl *ctl, const vshCmd *cmd) virBufferAddLit(&buf, "/>\n"); } - if (source) - virBufferAsprintf(&buf, "<source %s='%s'/>\n", - isFile ? "file" : "dev", source); + if (source || source_protocol) { + virBufferAddLit(&buf, "<source"); + if (source_protocol) { + /* Using a network disk; source is --source-name */ + virBufferAsprintf(&buf, " protocol='%s'", source_protocol); + if (source) + virBufferAsprintf(&buf, " name='%s'", source); + + if (host_name || host_socket || host_transport) { + /* Host information provided, add a <host> tag */ + virBufferAddLit(&buf, ">\n"); + virBufferAdjustIndent(&buf, 2); + virBufferAddLit(&buf, "<host"); + + if (host_name) { + /* Logic for host:port syntax */ + g_autofree char *host_name_copy = g_strdup(host_name); + host_port = strchr(host_name_copy, ':'); + + if (host_port) { + *host_port = '\0'; + virBufferAsprintf(&buf, + " name='%s' port='%s'", + host_name_copy, host_port + 1); + } else { + virBufferAsprintf(&buf, " name='%s'", host_name); + } + } + + if (host_transport) + virBufferAsprintf(&buf, " transport='%s'", host_transport); + if (host_socket) + virBufferAsprintf(&buf, " socket='%s'", host_socket); + virBufferAddLit(&buf, "/>\n"); + virBufferAdjustIndent(&buf, -2); + virBufferAddLit(&buf, "</source>\n"); + } + } else { + /* Using a local disk; source is file or dev */ + if (disk_type == VIRSH_SOURCE_TYPE_FILE) + virBufferAsprintf(&buf, " file='%s'", source); + else + virBufferAsprintf(&buf, " dev='%s'", source); + virBufferAddLit(&buf, "/>\n"); + } + } + virBufferAsprintf(&buf, "<target dev='%s'", target); if (targetbus) virBufferAsprintf(&buf, " bus='%s'", targetbus); -- 2.29.0

2 1

[PATCH 00/23] hyperv: storage volume XML changes
by Matt Coleman 19 Nov '20

19 Nov '20

Here's a GitLab MR if you'd prefer to review it there: https://gitlab.com/iammattcoleman/libvirt/-/merge_requests/12/commits Matt Coleman (23): hyperv: XML parsing of storage volumes schema: add support for Windows file paths and device names hyperv: ambiguous VM names will throw an error hyperv: implement domainUndefine and domainUndefineFlags hyperv: implement domainCreateXML and domainDefineXML hyperv: add hypervMsvmVSMSAddResourceSettings hyperv: create SCSI controllers when defining domains hyperv: attach virtual disks when defining domains hyperv: attach physical disks when defining domains hyperv: attach virtual optical disks when defining domains hyperv: attach floppy disks when defining domains hyperv: implement domainAttachDevice and domainAttachDeviceFlags hyperv: store the Hyper-V version when connecting hyperv: add inheritance to the WMI generator XML parsing of serial ports hyperv: add support for creating serial devices hyperv: XML parsing of Ethernet adapters hyperv: add support for creating network adapters hyperv: implement connectListAllNetworks and connectNumOfNetworks hyperv: implement networkLookupByName and networkLookupByUUID hyperv: implement connectNumOfDefinedNetworks and connectListDefinedNetworks hyperv: implement networkGetAutostart, networkIsActive, and networkIsPersistent hyperv: implement networkGetXMLDesc docs/schemas/basictypes.rng | 2 +- docs/schemas/domaincommon.rng | 5 +- include/libvirt/virterror.h | 1 + po/POTFILES.in | 1 + scripts/hyperv_wmi_generator.py | 12 +- src/hyperv/hyperv_driver.c | 1812 ++++++++++++++++- src/hyperv/hyperv_driver.h | 3 + src/hyperv/hyperv_network_driver.c | 250 +++ src/hyperv/hyperv_network_driver.h | 26 + src/hyperv/hyperv_private.h | 3 + src/hyperv/hyperv_wmi.c | 156 ++ src/hyperv/hyperv_wmi.h | 25 + src/hyperv/hyperv_wmi_classes.h | 35 + src/hyperv/hyperv_wmi_generator.input | 280 +++ src/hyperv/meson.build | 1 + src/util/virerror.c | 6 +- .../disk-hyperv-physical.xml | 17 + .../disk-hyperv-virtual.xml | 17 + .../disk-hyperv-physical.xml | 23 + .../disk-hyperv-virtual.xml | 23 + tests/genericxml2xmltest.c | 2 + 21 files changed, 2655 insertions(+), 45 deletions(-) create mode 100644 src/hyperv/hyperv_network_driver.c create mode 100644 src/hyperv/hyperv_network_driver.h create mode 100644 tests/genericxml2xmlindata/disk-hyperv-physical.xml create mode 100644 tests/genericxml2xmlindata/disk-hyperv-virtual.xml create mode 100644 tests/genericxml2xmloutdata/disk-hyperv-physical.xml create mode 100644 tests/genericxml2xmloutdata/disk-hyperv-virtual.xml -- 2.27.0

1 2

[libvirt PATCH] NEWS: restore backtick balance
by Ján Tomko 18 Nov '20

18 Nov '20

Signed-off-by: Ján Tomko <jtomko(a)redhat.com> Reported-by: Michal Prívozník <mprivozn(a)redhat.com> Fixes: db98d17709eeb13603730352a70f3817becd7372 --- Pushed. NEWS.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS.rst b/NEWS.rst index 8cccc07f52..aa8a217eb6 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -33,7 +33,7 @@ v6.10.0 (unreleased) * hyperv: implement new APIs - The `virDomainGetMaxMemory()``, ``virDomainSetMaxMemory()``, + The ``virDomainGetMaxMemory()``, ``virDomainSetMaxMemory()``, ``virDomainGetSchedulerType()``, ``virDomainGetSchedulerParameters()``, ``virDomainGetSchedulerParametersFlags()``, ``virDomainGetVcpus()``, ``virDomainGetVcpusFlags()``, ``virDomainGetMaxVcpus()``, -- 2.26.2

1 0

[libvirt PATCH v2 0/9] Add missing feature detection to sync tool in cpu_map
by Tim Wiederhake 18 Nov '20

18 Nov '20

sync_qemu_i386.py in src/cpu_map is a tool to sync CPU models from qemu with libvirt. It currently has no provisions for detecting new features that are not implemented in libvirt yet. This series changes that. Currently missing x86 CPU models: * "Denverton" * "KnightsMill" * "Snowridge" Currently missing x86 CPU features: * "core-capability" * "fsrm" * "split-lock-detect" "fsrm" is added in this series. For the "Snowridge" CPU model and the "core-capability" and "split-lock-detect" features, see https://www.redhat.com/archives/libvir-list/2020-November/msg00924.html. V1: https://www.redhat.com/archives/libvir-list/2020-November/msg01002.html Tim Wiederhake (9): cpu_map: sync_qemu_cpu_i386: Translate features in model versions cpu_map: sync_qemu_cpu_i386: Factor out translation of vendors cpu_map: sync_qemu_cpu_i386: Factor out translation of features cpu_map: sync_qemu_cpu_i386: Do not ignore CPUID_EXT_MONITOR cpu_map: sync_qemu_cpu_i386: Simplify ignore features cpu_map: sync_qemu_cpu_i386: Translate qemu feature pretty names cpu_map: sync_qemu_cpu_i386: Add missing features cpu_map: sync_qemu_cpu_i386: Detect features missing in libvirt cpu_map: Add missing feature fsrm src/cpu_map/sync_qemu_i386.py | 340 ++++++++++-------- src/cpu_map/x86_features.xml | 3 + .../x86_64-cpuid-Ice-Lake-Server-guest.xml | 1 + .../x86_64-cpuid-Ice-Lake-Server-host.xml | 1 + 4 files changed, 198 insertions(+), 147 deletions(-) -- 2.26.2

1 9

[libvirt PATCH] qemu_conf: fix a typo in comment
by Ján Tomko 18 Nov '20

18 Nov '20

Ceci n'est pas un objet. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> Fixes: 7db61843b05a6e4295b1d2e27a3d86f162ef04a0 --- Pushed under the surreal rule. src/qemu/qemu_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 80ff18204e..83de26ab56 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -1391,7 +1391,7 @@ virCapsPtr virQEMUDriverCreateCapabilities(virQEMUDriverPtr driver) * driver. If @refresh is true, the capabilities will be * rebuilt first * - * The caller must release the reference with virObjetUnref + * The caller must release the reference with virObjectUnref * * Returns: a reference to a virCapsPtr instance or NULL */ -- 2.26.2

1 0

[PATCH] news: Mention Cooperlake cpu model in v6.4.0
by Han Han 18 Nov '20

18 Nov '20

Signed-off-by: Han Han <hhan(a)redhat.com> --- NEWS.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 2fef3f706c..5dac805390 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -463,6 +463,8 @@ v6.4.0 (2020-06-02) already does in these cases. Users are encouraged to provide complete NUMA topologies to avoid unexpected changes in the domain XML. + * Cooperlake x86 CPU model is added + * **Bug fixes** * qemu: fixed regression in network device hotplug with new qemu versions -- 2.28.0

3 3

[PATCH v1 00/10] move memory module align to PostParse time
by Daniel Henrique Barboza 18 Nov '20

18 Nov '20

Hi, This is a work that I intended to do after pSeries NVDIMM changes I made in commit v6.7.0-302-gd3f3c2c97f. The reasoning is that if ppc64 NVDIMM alignment can be done in PostParse time, regular ppc64 DIMMs alignment can also be done the same way. After that I realized that the same logic can be applied to x86 as well, and then I started to see where we could eliminate explicit align calls. The end result is that a bug that affects pSeries the most was found and fixed in patch 02, and now we're able to reflect the exact memory being used by the guest in the live XML since the alignment is now done in parse time. The series can be fetched from: https://gitlab.com/danielhb/libvirt/-/tree/memory_modules_postparse_v1 NOTE: I worked with the x86 logic based on what I could assert from the code itself, i.e. the aligment mechanics (2MiB align for mem modules, 1MiB align for total memory) are related to QEMU internals, not being hypervisor-agnostic. If someone with authority can guarantee that the alignment restrictions for x86 are applicable to all hypervisors (like in the pSeries case), let me know and I'll respin the series putting the x86 code in virDomainMemoryDefPostParse(). Daniel Henrique Barboza (10): domain_conf.c: handle all ppc64 dimms in virDomainNVDimmAlignSizePseries qemu_domain.c: align memory modules before calculating 'initialmem' domain_conf.c: align pSeries mem modules in virDomainMemoryDefPostParse() qemu_domain.c: simplify qemuDomainGetMemoryModuleSizeAlignment() qemu_domain.c: align x86 memory module in post parse time qemu_domain.c: move size check for mem modules after alignment qemu_hotplug.c: avoid aligning the mem obj in qemuDomainDetachPrepMemory() qemu_hotplug.c: avoid aligning the mem obj in qemuDomainAttachMemory() qemu_domain.c: remove qemuDomainMemoryDeviceAlignSize() NEWS.rs: document memory alignment improvements NEWS.rst | 14 +++ src/conf/domain_conf.c | 25 ++++- src/conf/domain_conf.h | 2 +- src/libvirt_private.syms | 2 +- src/qemu/qemu_domain.c | 106 +++++++----------- src/qemu/qemu_domain.h | 2 - src/qemu/qemu_hotplug.c | 9 +- tests/qemuxml2argvdata/hugepages-nvdimm.xml | 2 +- .../memory-hotplug-nvdimm-access.xml | 2 +- .../memory-hotplug-nvdimm-align.xml | 2 +- .../memory-hotplug-nvdimm-label.xml | 2 +- .../memory-hotplug-nvdimm-pmem.xml | 2 +- .../memory-hotplug-nvdimm-readonly.xml | 2 +- .../memory-hotplug-nvdimm.xml | 2 +- .../memory-hotplug-ppc64-nonuma.args | 2 +- tests/qemuxml2argvdata/pages-dimm-discard.xml | 2 +- .../memory-hotplug-dimm.xml | 4 +- 17 files changed, 92 insertions(+), 90 deletions(-) -- 2.26.2

5 24

[libvirt PATCH 00/16] docs: add manpages for all the modular daemons
by Daniel P. Berrangé 18 Nov '20

18 Nov '20

Most of the modular daemon stuff has been done from a single template, but for the man pages that is more trouble than it is worth, so we create a separate man page source for each daemon, which makes it easy to extend with driver specific information. Daniel P. Berrangé (16): docs: consistently mark libvirtd as preformatted text docs: don't hardcode an ancient version in manpage examples docs: tweak heading for daemon manual pages docs: add manpage for virtproxyd docs: add manpage for virtbhyved docs: add manpage for virtinterfaced docs: add manpage for virtlxcd docs: add manpage for virtnetworkd docs: add manpage for virtnodedevd docs: add manpage for virtnwfilterd docs: add manpage for virtqemud docs: add manpage for virtsecretd docs: add manpage for virtstoraged docs: add manpage for virtvboxd docs: add manpage for virtvzd docs: add manpage for virtxend docs/manpages/index.rst | 25 ++- docs/manpages/libvirtd.rst | 50 +++--- docs/manpages/meson.build | 14 ++ docs/manpages/virtbhyved.rst | 215 ++++++++++++++++++++++++++ docs/manpages/virtinterfaced.rst | 215 ++++++++++++++++++++++++++ docs/manpages/virtlockd.rst | 2 +- docs/manpages/virtlogd.rst | 2 +- docs/manpages/virtlxcd.rst | 215 ++++++++++++++++++++++++++ docs/manpages/virtnetworkd.rst | 215 ++++++++++++++++++++++++++ docs/manpages/virtnodedevd.rst | 214 ++++++++++++++++++++++++++ docs/manpages/virtnwfilterd.rst | 215 ++++++++++++++++++++++++++ docs/manpages/virtproxyd.rst | 256 +++++++++++++++++++++++++++++++ docs/manpages/virtqemud.rst | 215 ++++++++++++++++++++++++++ docs/manpages/virtsecretd.rst | 214 ++++++++++++++++++++++++++ docs/manpages/virtstoraged.rst | 215 ++++++++++++++++++++++++++ docs/manpages/virtvboxd.rst | 213 +++++++++++++++++++++++++ docs/manpages/virtvzd.rst | 215 ++++++++++++++++++++++++++ docs/manpages/virtxend.rst | 215 ++++++++++++++++++++++++++ 18 files changed, 2896 insertions(+), 29 deletions(-) create mode 100644 docs/manpages/virtbhyved.rst create mode 100644 docs/manpages/virtinterfaced.rst create mode 100644 docs/manpages/virtlxcd.rst create mode 100644 docs/manpages/virtnetworkd.rst create mode 100644 docs/manpages/virtnodedevd.rst create mode 100644 docs/manpages/virtnwfilterd.rst create mode 100644 docs/manpages/virtproxyd.rst create mode 100644 docs/manpages/virtqemud.rst create mode 100644 docs/manpages/virtsecretd.rst create mode 100644 docs/manpages/virtstoraged.rst create mode 100644 docs/manpages/virtvboxd.rst create mode 100644 docs/manpages/virtvzd.rst create mode 100644 docs/manpages/virtxend.rst -- 2.28.0

3 19

[PATCH] cpu_map: Support phytium processor
by yangshaojun19＠163.com 18 Nov '20

18 Nov '20

From: Shaojun Yang <yangshaojun(a)phytium.com.cn> FT-2000+ and Tengyun-S2500 are two chips by produced Phytium Technology Co., Ltd., which based on ARMv8 architecure. Shaojun Yang (1): add phytium FT-2000+ and Tengyun-S2500 support on arm architecture. src/cpu_map/arm_Phytium.xml | 10 ++++++++++ src/cpu_map/arm_vendors.xml | 1 + src/cpu_map/index.xml | 3 +++ 3 files changed, 14 insertions(+) create mode 100644 src/cpu_map/arm_Phytium.xml -- 2.7.4

3 3

[PATCH 0/5] Deduplicate some of validation code
by Michal Privoznik 18 Nov '20

18 Nov '20

These stemmed from Cole's comment on my patches: https://www.redhat.com/archives/libvir-list/2020-November/msg00888.html The approach might not be that obvious at first because domCaps do qemuCaps to device model translation and during validation we want the exact opposite - we have parsed device model and want to check whether qemuCaps has corresponding capability. But what we can do, is let domCaps code fill a bitmap of supported device models and then check if the bit that corresponds to parsed device model is set. In this series I'm fixing RNG and video models, which were checked this way until very recently (until I touched the code). And also I'm introducing graphics check (which is new) because that one looked the most sane from virQEMUCapsFillDomainCaps(). The rest there not that much. Michal Prívozník (5): domain_capabilities: Introduce VIR_DOMAIN_CAPS_ENUM_IS_SET qemu_validate: Deduplicate code for video model check qemu_validate: Deduplicate code for RNG model check domcaps: Report egl-headless graphics type qemu_validate: Deduplicate code for graphics type check src/conf/domain_capabilities.c | 2 +- src/conf/domain_capabilities.h | 2 + src/qemu/qemu_capabilities.c | 8 +- src/qemu/qemu_capabilities.h | 9 ++ src/qemu/qemu_validate.c | 107 ++++-------------- .../domaincapsdata/qemu_2.10.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.10.0-tcg.x86_64.xml | 1 + .../qemu_2.10.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.10.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.10.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_2.10.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.10.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.11.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.11.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.11.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.11.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.12.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.12.0-tcg.x86_64.xml | 1 + .../qemu_2.12.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.12.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.12.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_2.12.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.12.0.x86_64.xml | 1 + .../domaincapsdata/qemu_3.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_3.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_3.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_3.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_3.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_3.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_3.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_3.1.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_3.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_4.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_4.0.0-tcg.x86_64.xml | 1 + .../qemu_4.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_4.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_4.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_4.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_4.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_4.2.0-tcg.x86_64.xml | 1 + .../qemu_4.2.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.s390x.xml | 1 + tests/domaincapsdata/qemu_4.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_5.0.0-tcg.x86_64.xml | 1 + .../qemu_5.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_5.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_5.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.2.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_5.2.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_5.2.0.x86_64.xml | 1 + 61 files changed, 97 insertions(+), 87 deletions(-) -- 2.26.2

3 11

[PATCH] virsh: Added attach-disk support for network disk
by Ryan Gahagan 18 Nov '20

18 Nov '20

Related issue: https://gitlab.com/libvirt/libvirt/-/issues/16 Added in support for the following parameters in attach-disk: --source-protocol --source-host-name --source-host-socket --source-host-transport Added documentation to virsh.rst specifying usage. Signed-off-by: Ryan Gahagan <rgahagan(a)cs.utexas.edu> --- docs/manpages/virsh.rst | 26 ++++++++++--- tools/virsh-domain.c | 85 ++++++++++++++++++++++++++++++++++++++--- 2 files changed, 100 insertions(+), 11 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index bfd26e3120..a4d70e9211 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -4500,14 +4500,18 @@ attach-disk [--current]] | [--persistent]] [--targetbus bus] [--driver driver] [--subdriver subdriver] [--iothread iothread] [--cache cache] [--io io] [--type type] [--alias alias] - [--mode mode] [--sourcetype sourcetype] [--serial serial] - [--wwn wwn] [--rawio] [--address address] [--multifunction] - [--print-xml] + [--mode mode] [--sourcetype sourcetype] + [--source-protocol protocol] [--source-host-name hostname:port] + [--source-host-transport transport] [--source-host-socket socket] + [--serial serial] [--wwn wwn] [--rawio] [--address address] + [--multifunction] [--print-xml] Attach a new disk device to the domain. -*source* is path for the files and devices. *target* controls the bus or -device under which the disk is exposed to the guest OS. It indicates the -"logical" device name; the optional *targetbus* attribute specifies the type +*source* is path for the files and devices unless *--source-protocol* +is specified, in which case *source* is the name of a network disk. +*target* controls the bus or device under which the disk is exposed +to the guest OS. It indicates the "logical" device name; +the optional *targetbus* attribute specifies the type of disk device to emulate; possible values are driver specific, with typical values being *ide*, *scsi*, *virtio*, *xen*, *usb*, *sata*, or *sd*, if omitted, the bus type is inferred from the style of the device name (e.g. a @@ -4541,6 +4545,16 @@ ccw:cssid.ssid.devno. Virtio-ccw devices must have their cssid set to 0xfe. *multifunction* indicates specified pci address is a multifunction pci device address. +There is also support for using a network disk. As specified, the user can +provide a *--source-protocol* in which case the *source* parameter will +be interpreted as the source name. *--source-protocol* must be provided +if the user also wishes to provide host information. +Host information can be provided using any of the tags +*--source-host-name*, *--source-host-transport*, and *--source-host-socket*, +which respectively denote the name of the host, the host's transport method, +and the socket that the host uses. The *--source-host-name* parameter +supports host:port syntax if the user wants to provide a port as well. + If *--print-xml* is specified, then the XML of the disk that would be attached is printed instead. diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 12b35c037d..4c43da7a2c 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -222,7 +222,7 @@ static const vshCmdOptDef opts_attach_disk[] = { {.name = "source", .type = VSH_OT_DATA, .flags = VSH_OFLAG_REQ | VSH_OFLAG_EMPTY_OK, - .help = N_("source of disk device") + .help = N_("source of disk device or name of network disk") }, {.name = "target", .type = VSH_OT_DATA, @@ -298,6 +298,22 @@ static const vshCmdOptDef opts_attach_disk[] = { .type = VSH_OT_BOOL, .help = N_("print XML document rather than attach the disk") }, + {.name = "source-protocol", + .type = VSH_OT_STRING, + .help = N_("protocol used by disk device source") + }, + {.name = "source-host-name", + .type = VSH_OT_STRING, + .help = N_("host name for source of disk device") + }, + {.name = "source-host-transport", + .type = VSH_OT_STRING, + .help = N_("host transport for source of disk device") + }, + {.name = "source-host-socket", + .type = VSH_OT_STRING, + .help = N_("host socket for source of disk device") + }, VIRSH_COMMON_OPT_DOMAIN_PERSISTENT, VIRSH_COMMON_OPT_DOMAIN_CONFIG, VIRSH_COMMON_OPT_DOMAIN_LIVE, @@ -567,6 +583,12 @@ cmdAttachDisk(vshControl *ctl, const vshCmd *cmd) *iothread = NULL, *cache = NULL, *io = NULL, *serial = NULL, *straddr = NULL, *wwn = NULL, *targetbus = NULL, *alias = NULL; + const char *source_protocol = NULL; + const char *host_name = NULL; + const char *host_transport = NULL; + const char *host_socket = NULL; + char *host_name_copy = NULL; + char *host_port = NULL; struct DiskAddress diskAddr; bool isFile = false, functionReturn = false; int ret; @@ -604,7 +626,11 @@ cmdAttachDisk(vshControl *ctl, const vshCmd *cmd) vshCommandOptStringReq(ctl, cmd, "address", &straddr) < 0 || vshCommandOptStringReq(ctl, cmd, "targetbus", &targetbus) < 0 || vshCommandOptStringReq(ctl, cmd, "alias", &alias) < 0 || - vshCommandOptStringReq(ctl, cmd, "sourcetype", &stype) < 0) + vshCommandOptStringReq(ctl, cmd, "sourcetype", &stype) < 0 || + vshCommandOptStringReq(ctl, cmd, "source-protocol", &source_protocol) < 0 || + vshCommandOptStringReq(ctl, cmd, "source-host-name", &host_name) < 0 || + vshCommandOptStringReq(ctl, cmd, "source-host-transport", &host_transport) < 0 || + vshCommandOptStringReq(ctl, cmd, "source-host-socket", &host_socket) < 0) goto cleanup; if (!stype) { @@ -632,6 +658,13 @@ cmdAttachDisk(vshControl *ctl, const vshCmd *cmd) if (wwn && !virValidateWWN(wwn)) goto cleanup; + if (!source_protocol && (host_name || host_socket || host_transport)) { + /* Error: cannot use network host without a source protocol */ + vshError(ctl, "%s", + _("Cannot use --source-host-* parameters without a --source-protocol")); + goto cleanup; + } + /* Make XML of disk */ virBufferAsprintf(&buf, "<disk type='%s'", isFile ? "file" : "block"); @@ -659,9 +692,51 @@ cmdAttachDisk(vshControl *ctl, const vshCmd *cmd) virBufferAddLit(&buf, "/>\n"); } - if (source) - virBufferAsprintf(&buf, "<source %s='%s'/>\n", - isFile ? "file" : "dev", source); + if (source || source_protocol) { + virBufferAddLit(&buf, "<source"); + if (source_protocol) { + /* Using a network disk; source is --source-name */ + virBufferAsprintf(&buf, " protocol='%s'", source_protocol); + if (source) + virBufferAsprintf(&buf, " name='%s'", source); + + if (host_name || host_socket || host_transport) { + /* Host information provided, add a <host> tag */ + virBufferAddLit(&buf, ">\n"); + virBufferAdjustIndent(&buf, 2); + virBufferAddLit(&buf, "<host"); + + if (host_name) { + /* Logic for host:port syntax */ + host_name_copy = g_strdup(host_name); + host_port = strchr(host_name_copy, ':'); + + if (host_port) { + host_name_copy[(int)(host_port - host_name_copy)] = '\0'; + virBufferAsprintf(&buf, + " name='%s' port='%s'", + host_name_copy, host_port); + } else { + virBufferAsprintf(&buf, " name='%s'", host_name); + } + } + + if (host_transport) + virBufferAsprintf(&buf, " transport='%s'", host_transport); + if (host_socket) + virBufferAsprintf(&buf, " socket='%s'", host_socket); + virBufferAddLit(&buf, "/>\n"); + virBufferAdjustIndent(&buf, -2); + virBufferAddLit(&buf, "</source>\n"); + } + } else { + /* Using a local disk; source is file or dev */ + virBufferAsprintf(&buf, " %s='%s'", + isFile ? "file" : "dev", source); + virBufferAddLit(&buf, "/>\n"); + } + } + virBufferAsprintf(&buf, "<target dev='%s'", target); if (targetbus) virBufferAsprintf(&buf, " bus='%s'", targetbus); -- 2.29.0

3 3

[PATCH for-5.2] docs: Fix some typos (found by codespell)
by Stefan Weil 18 Nov '20

18 Nov '20

Fix also a similar typo in a code comment. Signed-off-by: Stefan Weil <sw(a)weilnetz.de> --- docs/can.txt | 8 ++++---- docs/interop/vhost-user.rst | 2 +- docs/replay.txt | 2 +- docs/specs/ppc-spapr-numa.rst | 2 +- docs/system/deprecated.rst | 4 ++-- docs/tools/virtiofsd.rst | 2 +- hw/vfio/igd.c | 2 +- 7 files changed, 11 insertions(+), 11 deletions(-) diff --git a/docs/can.txt b/docs/can.txt index 5838f6620c..0d310237df 100644 --- a/docs/can.txt +++ b/docs/can.txt @@ -19,7 +19,7 @@ interface to implement because such device can be easily connected to systems with different CPU architectures (x86, PowerPC, Arm, etc.). In 2020, CTU CAN FD controller model has been added as part -of the bachelor theses of Jan Charvat. This controller is complete +of the bachelor thesis of Jan Charvat. This controller is complete open-source/design/hardware solution. The core designer of the project is Ondrej Ille, the financial support has been provided by CTU, and more companies including Volkswagen subsidiaries. @@ -31,7 +31,7 @@ testing lead to goal change to provide environment which provides complete emulated environment for testing and RTEMS GSoC slot has been donated to work on CAN hardware emulation on QEMU. -Examples how to use CAN emulation for SJA1000 based borads +Examples how to use CAN emulation for SJA1000 based boards ========================================================== When QEMU with CAN PCI support is compiled then one of the next @@ -106,8 +106,8 @@ This open-source core provides CAN FD support. CAN FD drames are delivered even to the host systems when SocketCAN interface is found CAN FD capable. -The PCIe borad emulation is provided for now (the device identifier is -ctucan_pci). The defauld build defines two CTU CAN FD cores +The PCIe board emulation is provided for now (the device identifier is +ctucan_pci). The default build defines two CTU CAN FD cores on the board. Example how to connect the canbus0-bus (virtual wire) to the host diff --git a/docs/interop/vhost-user.rst b/docs/interop/vhost-user.rst index 988f154144..72b2e8c7ba 100644 --- a/docs/interop/vhost-user.rst +++ b/docs/interop/vhost-user.rst @@ -513,7 +513,7 @@ descriptor table (split virtqueue) or descriptor ring (packed virtqueue). However, it can't work when we process descriptors out-of-order because some entries which store the information of inflight descriptors in available ring (split virtqueue) or descriptor -ring (packed virtqueue) might be overrided by new entries. To solve +ring (packed virtqueue) might be overridden by new entries. To solve this problem, slave need to allocate an extra buffer to store this information of inflight descriptors and share it with master for persistent. ``VHOST_USER_GET_INFLIGHT_FD`` and diff --git a/docs/replay.txt b/docs/replay.txt index 87a64ae068..5b008ca491 100644 --- a/docs/replay.txt +++ b/docs/replay.txt @@ -328,7 +328,7 @@ between the snapshots. Each of the passes include the following steps: 1. loading the snapshot 2. replaying to examine the breakpoints 3. if breakpoint or watchpoint was met - - loading the snaphot again + - loading the snapshot again - replaying to the required breakpoint 4. else - proceeding to the p.1 with the earlier snapshot diff --git a/docs/specs/ppc-spapr-numa.rst b/docs/specs/ppc-spapr-numa.rst index 5fca2bdd8e..ffa687dc89 100644 --- a/docs/specs/ppc-spapr-numa.rst +++ b/docs/specs/ppc-spapr-numa.rst @@ -198,7 +198,7 @@ This is how it is being done: * user distance 121 and beyond will be interpreted as 160 * user distance 10 stays 10 -The reasoning behind this aproximation is to avoid any round up to the local +The reasoning behind this approximation is to avoid any round up to the local distance (10), keeping it exclusive to the 4th NUMA level (which is still exclusive to the node_id). All other ranges were chosen under the developer discretion of what would be (somewhat) sensible considering the user input. diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst index 32a0e620db..63e9db1463 100644 --- a/docs/system/deprecated.rst +++ b/docs/system/deprecated.rst @@ -465,7 +465,7 @@ default configuration. The CPU model runnability guarantee won't apply anymore to existing CPU models. Management software that needs runnability -guarantees must resolve the CPU model aliases using te +guarantees must resolve the CPU model aliases using the ``alias-of`` field returned by the ``query-cpu-definitions`` QMP command. @@ -637,7 +637,7 @@ Splitting RAM by default between NUMA nodes had the same issues as ``mem`` parameter with the difference that the role of the user plays QEMU using implicit generic or board specific splitting rule. Use ``memdev`` with *memory-backend-ram* backend or ``mem`` (if -it's supported by used machine type) to define mapping explictly instead. +it's supported by used machine type) to define mapping explicitly instead. Users of existing VMs, wishing to preserve the same RAM distribution, should configure it explicitly using ``-numa node,memdev`` options. Current RAM distribution can be retrieved using HMP command ``info numa`` and if separate diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst index 34a9e40146..866b7db3ee 100644 --- a/docs/tools/virtiofsd.rst +++ b/docs/tools/virtiofsd.rst @@ -174,7 +174,7 @@ Using ':' as the separator a rule is of the form: - 'bad' - If a client tries to use a name matching 'key' it's denied using EPERM; when the server passes an attribute name matching 'prepend' it's hidden. In many ways it's use is very like - 'ok' as either an explict terminator or for special handling of certain + 'ok' as either an explicit terminator or for special handling of certain patterns. **key** is a string tested as a prefix on an attribute name originating diff --git a/hw/vfio/igd.c b/hw/vfio/igd.c index 64e332746b..470205f487 100644 --- a/hw/vfio/igd.c +++ b/hw/vfio/igd.c @@ -535,7 +535,7 @@ void vfio_probe_igd_bar4_quirk(VFIOPCIDevice *vdev, int nr) } /* - * Assume we have no GMS memory, but allow it to be overrided by device + * Assume we have no GMS memory, but allow it to be overridden by device * option (experimental). The spec doesn't actually allow zero GMS when * when IVD (IGD VGA Disable) is clear, but the claim is that it's unused, * so let's not waste VM memory for it. -- 2.29.2

3 2

[libvirt PATCH 00/11] fix various issues
by Pavel Hrdina 18 Nov '20

18 Nov '20

Issues reported by coverity. Pavel Hrdina (11): domain_conf: remove unused rc variable domain_conf: fix NULL dereference on error in virDomainObjCopyPersistentDef hyperv_wmi: remove unreachable cleanup code interface_backend_udev: refactor udevListInterfacesByStatus qemu_command: fix FD usage in qemuBuildInterfaceCommandLine qemu_monitor_json: explicitly ignore return values qemu_process: no need to check for NULL remote_driver: remove unreachable cleanup code virdevmapper: fix stat comparison in virDMSanitizepath vbox_common: unlock vbox_driver_lock before return testutils: call va_end before return src/conf/domain_conf.c | 10 +++++---- src/hyperv/hyperv_wmi.c | 12 ++--------- src/interface/interface_backend_udev.c | 13 ++--------- src/qemu/qemu_command.c | 2 +- src/qemu/qemu_monitor_json.c | 4 ++-- src/qemu/qemu_process.c | 30 +++++++++++--------------- src/remote/remote_driver.c | 18 ++++------------ src/util/virdevmapper.c | 2 +- src/vbox/vbox_common.c | 3 +++ tests/testutils.c | 1 + 10 files changed, 35 insertions(+), 60 deletions(-) -- 2.26.2

2 27

[PATCH v2 0/6] Introduce OpenSSH authorized key file mgmt APIs
by Michal Privoznik 18 Nov '20

18 Nov '20

v2 of: https://www.redhat.com/archives/libvir-list/2020-November/msg00444.html diff to v1: - Fixed issues raised by Peter (RO connection check, switched virsh from ARGV to --file, etc.) Marc-André Lureau (1): qemu_agent: add qemuAgentSSH{Add,Remove,Get}AuthorizedKeys Michal Prívozník (5): Introduce OpenSSH authorized key file mgmt APIs remote: Implement OpenSSH authorized key file mgmt APIs virsh: Expose OpenSSH authorized key file mgmt APIs qemu: Implement OpenSSH authorized key file mgmt APIs news: Document recent OpenSSH authorized key file mgmt APIs NEWS.rst | 6 + docs/manpages/virsh.rst | 37 ++++++ include/libvirt/libvirt-domain.h | 17 +++ src/driver-hypervisor.h | 15 +++ src/libvirt-domain.c | 133 ++++++++++++++++++++++ src/libvirt_public.syms | 6 + src/qemu/qemu_agent.c | 142 +++++++++++++++++++++++ src/qemu/qemu_agent.h | 15 +++ src/qemu/qemu_driver.c | 81 ++++++++++++++ src/remote/remote_daemon_dispatch.c | 82 ++++++++++++++ src/remote/remote_driver.c | 87 +++++++++++++++ src/remote/remote_protocol.x | 34 +++++- src/remote_protocol-structs | 22 ++++ tests/qemuagenttest.c | 79 +++++++++++++ tools/virsh-domain.c | 167 ++++++++++++++++++++++++++++ 15 files changed, 922 insertions(+), 1 deletion(-) -- 2.26.2

2 15

[libvirt] improve security by adjusting the privileges of libvirtd processes
by yebiaoxiang 18 Nov '20

18 Nov '20

Hi Team The daemon libvirtd runs as root user, which against the least privilege security model. root 567642 1.2 0.0 2856020 47576 ? Ssl 15:49 0:02 /usr/sbin/libvirtd --listen In addition, the "--listen" parameter exposes TCP or TLS ports on the network, it increasing the attack surface. tcp 0 0 0.0.0.0:16509 0.0.0.0:* LISTEN 647824/libvirtd tcp 0 0 0.0.0.0:16514 0.0.0.0:* LISTEN 647824/libvirtd I have the following puzzles: 1. Whether root is the least privilege required for libvirtd to manage virtualization platforms, it's possible to run libvirtd as a non-root user? 2. Is there any plan to resolve this security weaknesses? (like move the function of "--listen" to an independent non-root process, or other better schemes) Regards, BiaoXiang

2 1

[libvirt PATCH 0/2] network: Drop UUID handling for default network
by Andrea Bolognani 18 Nov '20

18 Nov '20

<blurb>cc30b49f-6084-48da-879e-55645459f2a0</blurb> Andrea Bolognani (2): network: Drop UUID handling for default network spec: Drop UUID handling for default network libvirt.spec.in | 4 ---- src/network/meson.build | 32 +++++++------------------------- 2 files changed, 7 insertions(+), 29 deletions(-) -- 2.26.2

4 13

[libvirt PATCH 0/4] nodedev: cleanup some historical baggage
by Daniel P. Berrangé 18 Nov '20

18 Nov '20

Daniel P. Berrangé (4): nodedev: improve debugging logs from udev device/event processing nodedev: dont rely on ignoring errors on missing properties nodedev: drop DKD_MEDIA_AVAILABLE property check nodedev: report errors about missing integer properties src/node_device/node_device_udev.c | 70 +++++++++++++----------------- 1 file changed, 30 insertions(+), 40 deletions(-) -- 2.28.0

3 7

[PATCH] add phytium FT-2000+ and Tengyun-S2500 support on arm architecture.
by yangshaojun19＠163.com 18 Nov '20

18 Nov '20

From: yangshaojun <yangshaojun(a)phytium.com.cn> Signed-off-by: yangshaojun <yangshaojun(a)phytium.com.cn> --- src/cpu_map/arm_Phytium.xml | 10 ++++++++++ src/cpu_map/arm_vendors.xml | 1 + src/cpu_map/index.xml | 3 +++ 3 files changed, 14 insertions(+) create mode 100644 src/cpu_map/arm_Phytium.xml diff --git a/src/cpu_map/arm_Phytium.xml b/src/cpu_map/arm_Phytium.xml new file mode 100644 index 0000000..f8b4852 --- /dev/null +++ b/src/cpu_map/arm_Phytium.xml @@ -0,0 +1,10 @@ +<cpus> + <model name='FT-2000+'> + <vendor name='Phytium'/> + <pvr value='0x662'/> + </model> + <model name='Tengyun-S2500'> + <vendor name='Phytium'/> + <pvr value='0x663'/> + </model> +</cpus> diff --git a/src/cpu_map/arm_vendors.xml b/src/cpu_map/arm_vendors.xml index ff799ef..4465463 100644 --- a/src/cpu_map/arm_vendors.xml +++ b/src/cpu_map/arm_vendors.xml @@ -11,4 +11,5 @@ <vendor name='Qualcomm' value='0x51'/> <vendor name='Marvell' value='0x56'/> <vendor name='Intel' value='0x69'/> + <vendor name='Phytium' value='0x70'/> </cpus> diff --git a/src/cpu_map/index.xml b/src/cpu_map/index.xml index 08f052e..e2c454b 100644 --- a/src/cpu_map/index.xml +++ b/src/cpu_map/index.xml @@ -103,5 +103,8 @@  <include filename='arm_Kunpeng-920.xml'/> + +  + <include filename='arm_Phytium.xml'/> </arch> </cpus> -- 2.7.4

2 1

[PATCH 0/5] qemu: Don't cache domCaps
by Michal Privoznik 17 Nov '20

17 Nov '20

See 4/5 for explanation. Michal Prívozník (5): qemu: Validate RNG model qemu: Validate video model conf: Drop virDomainCapsDeviceDefValidate() qemu: Don't cache domCaps in virQEMUDriverGetDomainCapabilities() qemu: Remove virQEMUDomainCapsCache code src/conf/domain_capabilities.c | 88 ------------ src/conf/domain_capabilities.h | 4 - src/libvirt_private.syms | 1 - src/qemu/qemu_capabilities.c | 129 ------------------ src/qemu/qemu_capabilities.h | 10 -- src/qemu/qemu_conf.c | 27 ++-- src/qemu/qemu_validate.c | 77 +++++++++-- .../default-video-type-x86_64-caps-test-0.err | 2 +- .../video-invalid-multiple-devices.err | 2 +- 9 files changed, 83 insertions(+), 257 deletions(-) -- 2.26.2

3 9

[libvirt PATCH 0/2] qemu: support kvm-poll-control performance hint
by Tim Wiederhake 17 Nov '20

17 Nov '20

See the commit message of the first patch and https://bugzilla.redhat.com/show_bug.cgi?id=1895204 Tim Wiederhake (2): qemu: support kvm-poll-control performance hint tests: Add tests for kvm-poll-control feature docs/formatdomain.rst | 14 ++++++++------ docs/schemas/domaincommon.rng | 5 +++++ src/conf/domain_conf.c | 4 ++++ src/conf/domain_conf.h | 1 + src/qemu/qemu_command.c | 5 +++++ tests/qemuxml2argvdata/kvm-features-off.xml | 1 + tests/qemuxml2argvdata/kvm-features.args | 2 +- tests/qemuxml2argvdata/kvm-features.xml | 1 + tests/qemuxml2xmloutdata/kvm-features-off.xml | 1 + tests/qemuxml2xmloutdata/kvm-features.xml | 1 + 10 files changed, 28 insertions(+), 7 deletions(-) -- 2.26.2

2 7

[PATCH] node_device: Use "udev" monitor source
by Michal Privoznik 17 Nov '20

17 Nov '20

In v6.3.0-rc1~67 I've made a switch: instead of listening on udev events the nodedev driver started listening for kernel events. This was because when a device changes its name (e.g. NICs) we will get "move" event with DEVPATH_OLD property set, which we can then use to remove the old device and thus keep our internal list up to date. The switch to "kernel" source was made because if the old NICs naming (eth0, eth1, ...) is enabled (e.g. via net.ifnames=0 on the kernel cmd line) then udev overwrites the property with the new name making our internal list go out of sync. Interestingly, when the od NICs naming is not enabled then the DEVPATH_OLD contains the correct value. But as it turns out, "kernel" source might be missing some other important properties, e.g. USB vendor/product IDs. Therefore, switch back to "udev" source and wish the best of luck to users using the old NICs naming. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1897625 Fixes: 9a13704818e4a018723e0ec5b9e97b176f1c8584 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/node_device/node_device_udev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c index 65f312d8f4..dec19a3166 100644 --- a/src/node_device/node_device_udev.c +++ b/src/node_device/node_device_udev.c @@ -1983,7 +1983,7 @@ nodeStateInitialize(bool privileged, virObjectLock(priv); - priv->udev_monitor = udev_monitor_new_from_netlink(udev, "kernel"); + priv->udev_monitor = udev_monitor_new_from_netlink(udev, "udev"); if (!priv->udev_monitor) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("udev_monitor_new_from_netlink returned NULL")); -- 2.26.2

2 3

[Question] sg_persist failed when using qemu-pr-helper
by Zihao Chang 17 Nov '20

17 Nov '20

Hi all, When using qemu-pr-helper，"sg_persist" in guest return Aborted Command after iscsiadm logout & login. My confusion: Is this problem caused by bugs of libvirt/qemu-pr-helper? Or iscsiadm logout & login should be forbidden when using qemu-pr-helper? Or There is something wrong with my config. Steps to Reproduce: 1. setup multipath env 1) set /etc/iscsi/initiatorname.iscsi 2) iscsiadm discovery & login 3) start multipathd 2. add the following xml to guest <disk type='block' device='lun'> <driver name='qemu' type='raw' cache='none' io='native'/> <source dev='/dev/mapper/XXXXXXXXXXXXXXXXX'> **<reservations managed='yes'/>** </source> <target dev='sdc' bus='scsi'/> </disk> 3. start the guest 1) "sg_persist -v -i -n -k -d /dev/sdc" works well in the guest 2) here /dev/sdc(guest) -> /dev/sdht(host) 4. iscsiadm logout & login on host 1) iscsiadm -m node -u (host) 2) iscsiadm -m node -l (host) 3) here /dev/sdc(guest) -(change)-> /dev/sdfo(host) 5. exec "sg_persist -v -i -n -k -d /dev/sdc" in the guest 1) command return: Persistent Reservation In cmd: 5e 00 00 00 00 00 00 20 00 00 persistent reservation in: Fixed format, current; Sense key: Aborted Command Additional sense: Logical unit communication failure PR in (Read keys): Aborted command sense key, other than protection related (asc=0x10) 2) strace qemu-pr-helper show: openat(AT_FDCWD, "/dev/sdht", O_RDONLY) = -1 ENOENT (No such file or directory) Additional info: 1. strace qemu-pr-helper show: openat(AT_FDCWD, "/dev/sdht", O_RDONLY) = -1 ENOENT (No such file or directory) 2. This problem may be related to mnt(namespace). I try to set mnt of qemu-pr-helper as pid 1, sg_persist works well after logout & login.

2 3