- Devel - libvirt List Archives

[PATCH 0/3] qemu: Fix issue of combining virDomainFSFreeze and VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE
by Peter Krempa 16 Feb '21

16 Feb '21

Peter Krempa (3): api: Discourage use of VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE qemuSnapshotCreateActiveExternal: Don't thaw filesystems when freeze fails qemuSnapshotFSFreeze: Don't return -2 src/libvirt-domain-snapshot.c | 3 +++ src/qemu/qemu_snapshot.c | 33 +++++++++++++-------------------- 2 files changed, 16 insertions(+), 20 deletions(-) -- 2.29.2

2 8

[PATCH] docs: tlscerts: fix link to remote URI parameters
by Ville Skyttä 16 Feb '21

16 Feb '21

Signed-off-by: Ville Skyttä <ville.skytta(a)iki.fi> --- docs/tlscerts.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/tlscerts.html.in b/docs/tlscerts.html.in index 8a74311682..22fc054801 100644 --- a/docs/tlscerts.html.in +++ b/docs/tlscerts.html.in @@ -125,7 +125,7 @@ of the server and clients. There are two distinct checks involved: server. Checking done by client by matching the certificate that the server sends to the server's hostname. May be disabled by adding <code>?no_verify=1</code> to the -<a href="#Remote_URI_parameters">remote URI</a>. +<a href="uri.html#Remote_URI_parameters">remote URI</a>. </li> <li> The server should know that only permitted clients are connecting. This can be done based on client's IP address, or on -- 2.17.1

2 1

[libvirt PATCH] vircgroup: correctly free nested virCgroupPtr
by Pavel Hrdina 16 Feb '21

16 Feb '21

Fixes: 184245f53b94fc84f727eb6e8a2aa52df02d69c0 Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/util/vircgroup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index 57e18d6f38..abc06b8cb0 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -3770,7 +3770,8 @@ virCgroupFree(virCgroupPtr group) g_free(group->unified.mountPoint); g_free(group->unified.placement); g_free(group->unitName); - g_free(group->nested); + + virCgroupFree(group->nested); g_free(group); } -- 2.29.2

2 1

[PATCH] qemu_hotplug: Don't dereference NULL pointer @newb in qemuDomainChangeNet()
by Michal Privoznik 16 Feb '21

16 Feb '21

In one of my previous commits I've made an attempt to restore the noqueue qdisc on a TAP corresponding to domain's <interface/> if QoS is cleared out. The commit consisted of two almost identical hunks. In both the pointer is dereferenced. But in one of them, the pointer to new bandwidth can't be NULL while in the other it can leading to a crash. Fixes: d53b09235398c1320ed2f1b45b640823171467ed Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1919619 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_hotplug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index e7863328db..a66354426d 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -3900,10 +3900,10 @@ qemuDomainChangeNet(virQEMUDriverPtr driver, /* If the old bandwidth was cleared out, restore qdisc. */ if (virDomainNetTypeSharesHostView(newdev)) { - if (!newb->out || newb->out->average == 0) + if (!newb || !newb->out || newb->out->average == 0) qemuDomainInterfaceSetDefaultQDisc(driver, newdev); } else { - if (!newb->in || newb->in->average == 0) + if (!newb || !newb->in || newb->in->average == 0) qemuDomainInterfaceSetDefaultQDisc(driver, newdev); } needReplaceDevDef = true; -- 2.26.2

2 1

[PATCH] qemu: add delay time cpu stats
by Aleksei Zakharov 15 Feb '21

15 Feb '21

This commit adds delay time (steal time inside guest) to libvirt domain CPU stats. It's more convenient to work with this statistic in a context of libvirt domain. Any monitoring software may use this information. As an example: the next step is to add support to libvirt-go and expose metrics with libvirt-exporter. Signed-off-by: Aleksei Zakharov <zaharov(a)selectel.ru> --- include/libvirt/libvirt-domain.h | 6 ++++ src/qemu/qemu_driver.c | 56 ++++++++++++++++++++++++++++++++ tools/virsh-domain.c | 3 +- 3 files changed, 64 insertions(+), 1 deletion(-) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index de2456812c..b3f9f375a5 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -1350,6 +1350,12 @@ int virDomainGetState (virDomainPtr domain, */ # define VIR_DOMAIN_CPU_STATS_SYSTEMTIME "system_time" +/** + * VIR_DOMAIN_CPU_STATS_DELAYTIME: + * cpu time waiting on runqueue in nanoseconds, as a ullong + */ +# define VIR_DOMAIN_CPU_STATS_DELAYTIME "delay_time" + /** * VIR_DOMAIN_CPU_STATS_VCPUTIME: * vcpu usage in nanoseconds (cpu_time excluding hypervisor time), diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 6193376544..41839a0239 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -16674,6 +16674,36 @@ qemuDomainGetMetadata(virDomainPtr dom, return ret; } +static int +virSchedstatGetDelay(virDomainObjPtr dom, unsigned long long *delay) +{ + char *proc = NULL; + FILE* schedstat; + unsigned long long curr_delay, oncpu = 0; + pid_t pid = dom->pid; + for (size_t i = 0; i < virDomainDefGetVcpusMax(dom->def); i++) { + pid_t vcpupid = qemuDomainGetVcpuPid(dom, i); + if (vcpupid) { + if (asprintf(&proc, "/proc/%d/task/%d/schedstat", + pid, vcpupid) < 0) + return -1; + } else { + if (asprintf(&proc, "/proc/%d/schedstat", pid) < 0) + return -1; + } + schedstat = fopen(proc, "r"); + VIR_FREE(proc); + if (!schedstat || + fscanf(schedstat, "%llu %llu", + &oncpu, &curr_delay) < 2) { + return -1; + } + + *delay += curr_delay; + } + return 0; +} + static int qemuDomainGetCPUStats(virDomainPtr domain, @@ -16687,6 +16717,7 @@ qemuDomainGetCPUStats(virDomainPtr domain, int ret = -1; qemuDomainObjPrivatePtr priv; virBitmapPtr guestvcpus = NULL; + unsigned long long delay = 0; virCheckFlags(VIR_TYPED_PARAM_STRING_OKAY, -1); @@ -16712,8 +16743,19 @@ qemuDomainGetCPUStats(virDomainPtr domain, goto cleanup; if (start_cpu == -1) + { ret = virCgroupGetDomainTotalCpuStats(priv->cgroup, params, nparams); + if (nparams > 3) { + if (virSchedstatGetDelay(vm,&delay) < 0) + return -1; + if (virTypedParameterAssign(&params[3], + VIR_DOMAIN_CPU_STATS_DELAYTIME, + VIR_TYPED_PARAM_ULLONG, delay) < 0) + return -1; + } + ret++; + } else ret = virCgroupGetPercpuStats(priv->cgroup, params, nparams, start_cpu, ncpus, guestvcpus); @@ -17845,6 +17887,17 @@ qemuDomainGetStatsMemoryBandwidth(virQEMUDriverPtr driver, return ret; } +static int +qemuDomainGetStatsCpuDelay(virDomainObjPtr dom, + virTypedParamListPtr params) +{ + unsigned long long delay_time = 0; + int err = 0; + err = virSchedstatGetDelay(dom, &delay_time); + if (!err && virTypedParamListAddULLong(params, delay_time, "cpu.delay") < 0) + return -1; + return 0; +} static int qemuDomainGetStatsCpuCache(virQEMUDriverPtr driver, @@ -17950,6 +18003,9 @@ qemuDomainGetStatsCpu(virQEMUDriverPtr driver, if (qemuDomainGetStatsCpuCache(driver, dom, params) < 0) return -1; + if (qemuDomainGetStatsCpuDelay(dom, params) < 0) + return -1; + return 0; } diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 2bb136333f..a1780da1a5 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -8085,7 +8085,8 @@ vshCPUStatsPrintField(vshControl *ctl, if ((STREQ(param->field, VIR_DOMAIN_CPU_STATS_CPUTIME) || STREQ(param->field, VIR_DOMAIN_CPU_STATS_VCPUTIME) || STREQ(param->field, VIR_DOMAIN_CPU_STATS_USERTIME) || - STREQ(param->field, VIR_DOMAIN_CPU_STATS_SYSTEMTIME)) && + STREQ(param->field, VIR_DOMAIN_CPU_STATS_SYSTEMTIME) || + STREQ(param->field, VIR_DOMAIN_CPU_STATS_DELAYTIME)) && param->type == VIR_TYPED_PARAM_ULLONG) { vshPrint(ctl, "%9lld.%09lld seconds\n", param->value.ul / 1000000000, -- 2.17.1

2 7

[libvirt PATCH v2 0/3] ci: Paint the pipeline green
by Andrea Bolognani 15 Feb '21

15 Feb '21

Various workarounds that are necessary due to breakages in external services and distribution archives, plus fixes for a couple of issues that were discovered in the process. Changes from [v1]: * the first three patches have been dropped from the series as they've been pushed already; * Dockerfiles have been refreshed using a more recent version of lcitool. [v1] https://listman.redhat.com/archives/libvir-list/2021-February/msg00664.html Andrea Bolognani (3): ci: Refresh Dockerfiles ci: Add temporary workaround for Fedora Rawhide ci: Build on FreeBSD 12.2 .gitlab-ci.yml | 2 +- ci/containers/ci-centos-7.Dockerfile | 3 ++- ci/containers/ci-centos-8.Dockerfile | 3 ++- ci/containers/ci-centos-stream.Dockerfile | 3 ++- ci/containers/ci-debian-10-cross-aarch64.Dockerfile | 3 ++- ci/containers/ci-debian-10-cross-armv6l.Dockerfile | 3 ++- ci/containers/ci-debian-10-cross-armv7l.Dockerfile | 3 ++- ci/containers/ci-debian-10-cross-i686.Dockerfile | 3 ++- ci/containers/ci-debian-10-cross-mips.Dockerfile | 3 ++- ci/containers/ci-debian-10-cross-mips64el.Dockerfile | 3 ++- ci/containers/ci-debian-10-cross-mipsel.Dockerfile | 3 ++- ci/containers/ci-debian-10-cross-ppc64le.Dockerfile | 3 ++- ci/containers/ci-debian-10-cross-s390x.Dockerfile | 3 ++- ci/containers/ci-debian-10.Dockerfile | 3 ++- ci/containers/ci-debian-sid-cross-aarch64.Dockerfile | 3 ++- ci/containers/ci-debian-sid-cross-armv6l.Dockerfile | 3 ++- ci/containers/ci-debian-sid-cross-armv7l.Dockerfile | 3 ++- ci/containers/ci-debian-sid-cross-i686.Dockerfile | 3 ++- ci/containers/ci-debian-sid-cross-mips64el.Dockerfile | 3 ++- ci/containers/ci-debian-sid-cross-mipsel.Dockerfile | 3 ++- ci/containers/ci-debian-sid-cross-ppc64le.Dockerfile | 3 ++- ci/containers/ci-debian-sid-cross-s390x.Dockerfile | 3 ++- ci/containers/ci-debian-sid.Dockerfile | 3 ++- ci/containers/ci-fedora-32.Dockerfile | 3 ++- ci/containers/ci-fedora-33.Dockerfile | 3 ++- ci/containers/ci-fedora-rawhide-cross-mingw32.Dockerfile | 8 +++++--- ci/containers/ci-fedora-rawhide-cross-mingw64.Dockerfile | 8 +++++--- ci/containers/ci-fedora-rawhide.Dockerfile | 8 +++++--- ci/containers/ci-opensuse-152.Dockerfile | 3 ++- ci/containers/ci-ubuntu-1804.Dockerfile | 3 ++- ci/containers/ci-ubuntu-2004.Dockerfile | 3 ++- 31 files changed, 70 insertions(+), 37 deletions(-) -- 2.26.2

2 5

[libvirt PATCH] news: Mention Apple Silicon support
by Andrea Bolognani 15 Feb '21

15 Feb '21

After the recent fixes, it's now confirmed to work. https://gitlab.com/libvirt/libvirt/-/issues/121 Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- NEWS.rst | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index a9a1a61119..440dbf2601 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -11,6 +11,12 @@ For a more fine-grained view, use the `git log`_. v7.1.0 (unreleased) =================== +* **Portability** + + * Implement Apple Silicon support + + libvirt now runs on the ARM-based Apple Silicon Macs. + * **New features** * Introduce virtio-pmem ``<memory/>`` model -- 2.26.2

4 7

[libvirt PATCH v2 0/6] APIs for reporting tainting and deprecation messages
by Daniel P. Berrangé 13 Feb '21

13 Feb '21

This is a follow up to https://listman.redhat.com/archives/libvir-list/2021-January/msg00988.html I pushed the first non-API parts of that series already. This posting takes a different approach to the APIs. Instead of separte APIs for tainting and deprecations, there is now one API for reporting general informational messages. This is explicitly only targetted at humans. v2: - Change formatting for better translation - Fix leak of strings Daniel P. Berrangé (6): conf: record deprecation messages against the domain qemu: record deprecation messages against the domain src: define virDomainGetMessages API remote: add RPC support for the virDomainGetMessages API qemu: implement virDomainGetMessages API tools: report messages for 'dominfo' command include/libvirt/libvirt-domain.h | 9 +++++ src/conf/domain_conf.c | 45 ++++++++++++++++++++-- src/conf/domain_conf.h | 5 +++ src/driver-hypervisor.h | 6 +++ src/libvirt-domain.c | 54 +++++++++++++++++++++++++++ src/libvirt_private.syms | 3 ++ src/libvirt_public.syms | 5 +++ src/qemu/qemu_domain.c | 5 +++ src/qemu/qemu_domain.h | 3 ++ src/qemu/qemu_driver.c | 58 +++++++++++++++++++++++++++++ src/qemu/qemu_process.c | 5 +++ src/remote/remote_daemon_dispatch.c | 45 ++++++++++++++++++++++ src/remote/remote_driver.c | 44 ++++++++++++++++++++++ src/remote/remote_protocol.x | 21 ++++++++++- src/remote_protocol-structs | 11 ++++++ tools/virsh-domain-monitor.c | 10 +++++ 16 files changed, 325 insertions(+), 4 deletions(-) -- 2.29.2

3 8

[libvirt RFC PATCH 0/5] eliminating VIR_FREE in the *Clear() functions
by Laine Stump 13 Feb '21

13 Feb '21

I've looked at a few of these, and one thing I've found is that very often we have a function called somethingSomethingClear(), and: 1) The only places it is ever called will immediately free the memory of the object as soon as they clear it. and very possibly 2) It doesn't actually *clear* everything. Some items are cleared via VIR_FREE(), but then some of the other pointers call bobLoblawFree(def->bobloblaw) and then don't actually set def->bobloblaw to NULL - so the functions aren't actually "Clearing", they're "Freeing and then clearing a few things, but not everything". So I'm wondering if it is worthwhile to A) audit all the *Clear() functions and rename the functions that don't actually need to clear the contents to be, e.g. bobLobLawFreeContents(), while also replacing VIR_FREE with g_free(). (this is what I've done in these 5 patches) or if we should B) just do the wholesale approach and (as danpb suggested last week) change all VIR_FREE in *Clear() functions to g_free(), and put a "memset(obj, 0, sizeof(*obj))" at the end of each function, ignoring whether or not we actually need that. (B) would obviously be much faster to get done, and simpler for everyone to keep track of what's happening, but of course it is less efficient. Very likely this efficiency is completely meaningless in the large scheme (even in the medium or small scheme). (I actually like the idea of 0'ing out *everything*[*] when we're done with it, extra cycles be damned! I think of the two choices above, after going through this exercise, I'd say (B) is a more reasonable choice, but since I tried this, I thought I'd send it and see if anyone else has an opinion (or different idea) [*](including all those places I've replaced VIR_FREE with g_free in the name of "progress?") Laine Stump (5): conf: rename and narrow scope of virDomainHostdevDefClear() conf: rename virDomainHostdevSubsysSCSIClear conf: replace pointless VIR_FREEs with g_free in virDomainVideoDefClear() conf: don't call virDomainDeviceInfoClear from virDomainDeviceInfoParseXML conf: replace virDomainDeviceInfoClear with virDomainDeviceInfoFreeContents src/conf/device_conf.c | 15 +++----- src/conf/device_conf.h | 2 +- src/conf/domain_conf.c | 81 ++++++++++++++++++++-------------------- src/conf/domain_conf.h | 1 - src/libvirt_private.syms | 1 - 5 files changed, 47 insertions(+), 53 deletions(-) -- 2.29.2

5 12

[PATCH] qemu_shim: URI escape root directory
by Michal Privoznik 13 Feb '21

13 Feb '21

The root directory can be provided by user (or a temporary one is generated) and is always formatted into connection URI for both secret driver and QEMU driver, like this: qemu:///embed?root=$root But if it so happens that there is an URI unfriendly character in root directory or path to it (say a space) then invalid URI is formatted which results in unexpected results. We can trust g_dir_make_tmp() to generate valid URI but we can't trust user. Escape user provided root directory. Always. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1920400 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_shim.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_shim.c b/src/qemu/qemu_shim.c index 18bdc99256..c10598df4b 100644 --- a/src/qemu/qemu_shim.c +++ b/src/qemu/qemu_shim.c @@ -140,7 +140,8 @@ int main(int argc, char **argv) g_autofree char *xml = NULL; g_autofree char *uri = NULL; g_autofree char *suri = NULL; - char *root = NULL; + const char *root = NULL; + g_autofree char *escaped = NULL; bool tmproot = false; int ret = 1; g_autoptr(GError) error = NULL; @@ -216,6 +217,8 @@ int main(int argc, char **argv) } } + escaped = g_uri_escape_string(root, NULL, true); + virFileActivateDirOverrideForProg(argv[0]); if (verbose) @@ -242,7 +245,7 @@ int main(int argc, char **argv) eventLoopThread = g_thread_new("event-loop", qemuShimEventLoop, NULL); if (secrets && *secrets) { - suri = g_strdup_printf("secret:///embed?root=%s", root); + suri = g_strdup_printf("secret:///embed?root=%s", escaped); if (verbose) g_printerr("%s: %lld: opening %s\n", @@ -303,7 +306,7 @@ int main(int argc, char **argv) } } - uri = g_strdup_printf("qemu:///embed?root=%s", root); + uri = g_strdup_printf("qemu:///embed?root=%s", escaped); if (verbose) g_printerr("%s: %lld: opening %s\n", -- 2.26.2

2 1

[libvirt PATCH 00/10] [RFC] clang-tidy CI integration
by Tim Wiederhake 12 Feb '21

12 Feb '21

"clang-tidy" is a static code analysis tool for c and c++ code. See https://listman.redhat.com/archives/libvir-list/2021-January/msg01152.html for some issues found by clang-tidy and more background information. Meson has support for clang-tidy and generates target named "clang-tidy" if it finds a ".clang-tidy" configuration file in the project's root directory. There are some problems with this approach though, with regards to inclusion in GitLab's CI: * Single-threaded runtime of a complete scan takes between 95 and 110 minutes, depending on the enabled checks, which is significantly longer than GitLab's maximum run time of 60 minutes, after which jobs are aborted. * Even without this limit on runtime, this new check would double to triple the run time of the libVirt pipeline in GitLab. * clang-tidy finds a lot of false positives (see link above for explanation) and has checks that contradict the libVirt code style (e.g. braces around blocks). This makes a quite complex configuration in ".clang-tidy" neccessary. * I was unable to make clang-tidy recognize the settings from the configuration file for generated files, leading clang-tidy to always add some checks. These checks were among those that produced false positives. * The list of enabled / disabled checks in the yaml configuration file is a quite long string, making it hard to weave in some comments / documentation on which checks are enabled / disabled for what reason. This series introduces a new script, "run-clang-tidy.py". This is a replacement for the script of the same name from clang-tools-extra. It offers parallel execution, caching of results and a configurable soft-timeout. Please see the individual commits for more details. Comments welcome. https://gitlab.com/twiederh/libvirt/-/pipelines/255321968 → "clang-tidy". Tim Tim Wiederhake (10): clang-tidy: Add a simple runner clang-tidy: Run in parallel clang-tidy: Filter output clang-tidy: Add cache clang-tidy: Add timeout clang-tidy: Allow timeouts clang-tidy: Add shuffle clang-tidy: Make list of checks explicit clang-tidy: Disable irrelevant and failing checks clang-tidy: Add CI integration .gitlab-ci.yml | 88 ++++++ scripts/run-clang-tidy.py | 557 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 645 insertions(+) create mode 100755 scripts/run-clang-tidy.py -- 2.26.2

3 14

[libvirt PATCH v2 0/4] ci: Adjustments to remove our dependency on sudo
by Erik Skultety 12 Feb '21

12 Feb '21

Our Debian containers don't have sudo pre-installed and the only reason we actually needed it was to run a custom prepare script which as it turns out does nothing really. Since v1: - applied quoting to the variables as asked during the review process - simplified setting of CI_PODMAN_ARGS - moved 4/4 to 3/4 Erik Skultety (4): ci: Specify the shebang sequence for build.sh ci: Run podman command directly without wrapping it with prepare.sh ci: Drop the prepare.sh script ci: Makefile: Expose the CI_USER_LOGIN variable for users to use ci/Makefile | 62 +++++++++++++++++++++++++-------------------------- ci/build.sh | 2 ++ ci/prepare.sh | 13 ----------- 3 files changed, 33 insertions(+), 44 deletions(-) delete mode 100644 ci/prepare.sh -- 2.29.2

2 6

[libvirt PATCH 0/4] ci: Adjustments to remove our dependency on sudo
by Erik Skultety 12 Feb '21

12 Feb '21

Our Debian containers don't have sudo pre-installed and the only reason we actually needed it was to run a custom prepare script which as it turns out d= oes nothing really. Erik Skultety (4): ci: Specify the shebang sequence for build.sh ci: Run podman command directly without wrapping it with prepare.sh ci: Expose CI_USER_LOGIN as a Makefile variable for users to use ci: Drop the prepare.sh script ci/Makefile | 43 ++++++++++++++++++++++++------------------- ci/build.sh | 2 ++ ci/prepare.sh | 13 ------------- 3 files changed, 26 insertions(+), 32 deletions(-) delete mode 100644 ci/prepare.sh --=20 2.29.2

2 10

[libvirt PATCH 0/8] More VIR_FREE removals
by Laine Stump 12 Feb '21

12 Feb '21

Only 90 this time. These are all functions that behave similar to the *Free() functions, but their names don't end in "Free" so I missed them last time. Laine Stump (8): esx: replace VIR_FREE with g_free in any ESX_VI__TEMPLATE__FREE conf: convert VIR_FREE to g_free in other functions that free their arg locking: convert VIR_FREE to g_free in other functions that free their arg openvz: convert VIR_FREE to g_free in other functions that free their arg remote: convert VIR_FREE to g_free in other functions that free their arg qemu: convert VIR_FREE to g_free in other functions that free their arg util: convert VIR_FREE to g_free in other functions that free their arg vmware: convert VIR_FREE to g_free in other functions that free their arg src/conf/capabilities.c | 38 +++++++++++++++---------------- src/esx/esx_vi.c | 18 +++++++-------- src/esx/esx_vi_types.c | 24 +++++++++---------- src/locking/lock_manager.c | 4 ++-- src/openvz/openvz_conf.c | 2 +- src/qemu/qemu_domain.c | 2 +- src/qemu/qemu_driver.c | 8 +++---- src/remote/remote_daemon_stream.c | 2 +- src/util/virconf.c | 4 ++-- src/util/virerror.c | 4 ++-- src/util/virobject.c | 2 +- src/util/virstring.c | 4 ++-- src/vmware/vmware_conf.c | 4 ++-- src/vmware/vmware_driver.c | 4 ++-- 14 files changed, 60 insertions(+), 60 deletions(-) -- 2.29.2

2 9

[PATCH 0/2] qemu: swtpm improvements
by Jim Fehlig 12 Feb '21

12 Feb '21

These patches are fallout from a discussion about TPM devices and aarch64 https://listman.redhat.com/archives/libvir-list/2021-February/msg00526.html Jim Fehlig (2): qemu: Fix swtpm device with aarch64 qemu: Validate TPM TIS device src/qemu/qemu_command.c | 3 ++ src/qemu/qemu_validate.c | 7 ++++ .../aarch64-tpm.aarch64-latest.args | 37 +++++++++++++++++++ tests/qemuxml2argvdata/aarch64-tpm.xml | 15 ++++++++ tests/qemuxml2argvtest.c | 1 + 5 files changed, 63 insertions(+) create mode 100644 tests/qemuxml2argvdata/aarch64-tpm.aarch64-latest.args create mode 100644 tests/qemuxml2argvdata/aarch64-tpm.xml -- 2.29.2

2 6

[libvirt PATCH 0/6] ci: Paint the pipeline green
by Andrea Bolognani 11 Feb '21

11 Feb '21

Various workarounds that are necessary due to breakages in external services and distribution archives, plus fixes for a couple of issues that were discovered in the process. Andrea Bolognani (6): ci: Shuffle cross-building jobs around ci: Mark container build jobs as required/optional correctly ci: Move ppc64le build from Debian sid to Debian 10 ci: Refresh Dockerfiles ci: Add temporary workaround for Fedora Rawhide ci: Build on FreeBSD 12.2 .gitlab-ci.yml | 66 +++++++++---------- ci/containers/ci-centos-7.Dockerfile | 3 +- ci/containers/ci-centos-8.Dockerfile | 3 +- ci/containers/ci-centos-stream.Dockerfile | 3 +- .../ci-debian-10-cross-aarch64.Dockerfile | 3 +- .../ci-debian-10-cross-armv6l.Dockerfile | 3 +- .../ci-debian-10-cross-armv7l.Dockerfile | 3 +- .../ci-debian-10-cross-i686.Dockerfile | 3 +- .../ci-debian-10-cross-mips.Dockerfile | 3 +- .../ci-debian-10-cross-mips64el.Dockerfile | 3 +- .../ci-debian-10-cross-mipsel.Dockerfile | 3 +- .../ci-debian-10-cross-ppc64le.Dockerfile | 3 +- .../ci-debian-10-cross-s390x.Dockerfile | 3 +- ci/containers/ci-debian-10.Dockerfile | 3 +- .../ci-debian-sid-cross-aarch64.Dockerfile | 3 +- .../ci-debian-sid-cross-armv6l.Dockerfile | 3 +- .../ci-debian-sid-cross-armv7l.Dockerfile | 3 +- .../ci-debian-sid-cross-i686.Dockerfile | 3 +- .../ci-debian-sid-cross-mips64el.Dockerfile | 3 +- .../ci-debian-sid-cross-mipsel.Dockerfile | 3 +- .../ci-debian-sid-cross-ppc64le.Dockerfile | 3 +- .../ci-debian-sid-cross-s390x.Dockerfile | 3 +- ci/containers/ci-debian-sid.Dockerfile | 3 +- ci/containers/ci-fedora-32.Dockerfile | 3 +- ci/containers/ci-fedora-33.Dockerfile | 3 +- ...ci-fedora-rawhide-cross-mingw32.Dockerfile | 6 +- ...ci-fedora-rawhide-cross-mingw64.Dockerfile | 6 +- ci/containers/ci-fedora-rawhide.Dockerfile | 6 +- ci/containers/ci-opensuse-152.Dockerfile | 3 +- ci/containers/ci-ubuntu-1804.Dockerfile | 3 +- ci/containers/ci-ubuntu-2004.Dockerfile | 3 +- 31 files changed, 99 insertions(+), 66 deletions(-) -- 2.26.2

2 12

[PATCH 0/7] support <teaming> (aka "QEMU virtio failover") with plain <hostdev>
by Laine Stump 11 Feb '21

11 Feb '21

This is explained in excruciating detail in Patch 5, but in short, allowing the <teaming> element to be in a plain <hostdev> will permit someone who is running libvirt unprivileged, or in a container with no access to a PF device, to use the <teaming> feature, which encapsulates a lot of functionality related to assigning an SRIOV network device to a guest as a part of a failover bond device (the other device in the pair is an emulated virtio NIC), which in turn permits the guest to be migrated by transparently unplugging the SRIOV NIC prior to migration, and plugging a new one in after migration is completed. (Previously we required <interface type='hostdev'> for this feature, but that type of device needs to send netlink messages to the PF of the SRIOV VF that's being assigned, and that simply isn't possible sometimes.) Laine Stump (7): conf: make teaming info an official type conf: use virDomainNetTeamingInfoPtr instead of virDomainNetTeamingInfo conf: separate Parse/Format functions for virDomainNetTeamingInfo schema: separate teaming element definition from interface element conf: parse/format <teaming> element in plain <hostdev> qemu: plug <teaming> config from <hostdev> into qemu commandline news: document support for <teaming> in <hostdev> NEWS.rst | 6 ++ docs/formatdomain.rst | 51 +++++++++++ docs/schemas/domaincommon.rng | 42 +++++---- src/conf/domain_conf.c | 87 +++++++++++++------ src/conf/domain_conf.h | 13 ++- src/conf/domain_validate.c | 45 +++++++--- src/conf/virconftypes.h | 3 + src/libvirt_private.syms | 1 + src/qemu/qemu_command.c | 17 ++-- src/qemu/qemu_domain.c | 2 +- src/qemu/qemu_migration.c | 4 +- src/qemu/qemu_validate.c | 42 ++++----- .../net-virtio-teaming-hostdev.args | 40 +++++++++ .../net-virtio-teaming-hostdev.xml | 48 ++++++++++ tests/qemuxml2argvtest.c | 3 + .../net-virtio-teaming-hostdev.xml | 64 ++++++++++++++ tests/qemuxml2xmltest.c | 3 + 17 files changed, 384 insertions(+), 87 deletions(-) create mode 100644 tests/qemuxml2argvdata/net-virtio-teaming-hostdev.args create mode 100644 tests/qemuxml2argvdata/net-virtio-teaming-hostdev.xml create mode 100644 tests/qemuxml2xmloutdata/net-virtio-teaming-hostdev.xml -- 2.29.2

2 9

[PATCH 0/3 V3] Linstor storage backend
by Rene Peinthor 11 Feb '21

11 Feb '21

I didn't get any feedback on V2, nor any updates if you still reviewing, but I found myself a few issues. First in V2 the <source/host> element wasn't optional (which it should be) and I improved a few error messages, because sometimes it wasn't clear from where the error originated. Best regards, Rene Rene Peinthor (3): storage: Linstor configuration storage: Linstor support storage: Add tests for the Linstor storage backend docs/schemas/storagepool.rng | 27 + docs/storage.html.in | 39 + include/libvirt/libvirt-storage.h | 1 + meson.build | 6 + meson_options.txt | 1 + po/POTFILES.in | 1 + src/conf/domain_conf.c | 1 + src/conf/storage_conf.c | 13 +- src/conf/storage_conf.h | 1 + src/conf/virstorageobj.c | 4 +- src/storage/meson.build | 25 + src/storage/storage_backend.c | 6 + src/storage/storage_backend_linstor.c | 783 ++++++++++++++++++ src/storage/storage_backend_linstor.h | 24 + src/storage/storage_backend_linstor_priv.h | 53 ++ src/storage/storage_driver.c | 1 + src/test/test_driver.c | 1 + tests/linstorjsondata/broken.json | 1 + tests/linstorjsondata/resource-group.json | 1 + .../linstorjsondata/resource-list-test2.json | 332 ++++++++ .../storage-pools-ssdpool.json | 72 ++ tests/linstorjsondata/storage-pools.json | 192 +++++ tests/linstorjsondata/volume-def-list.json | 158 ++++ .../volume-definition-test2.json | 1 + tests/meson.build | 6 + tests/storagebackendlinstortest.c | 372 +++++++++ .../storagepoolcapsschemadata/poolcaps-fs.xml | 7 + .../poolcaps-full.xml | 7 + tests/storagepoolxml2argvtest.c | 1 + tests/storagepoolxml2xmlin/pool-linstor.xml | 8 + tests/storagevolxml2xmlin/vol-linstor.xml | 10 + tools/virsh-pool.c | 3 + 32 files changed, 2156 insertions(+), 2 deletions(-) create mode 100644 src/storage/storage_backend_linstor.c create mode 100644 src/storage/storage_backend_linstor.h create mode 100644 src/storage/storage_backend_linstor_priv.h create mode 100644 tests/linstorjsondata/broken.json create mode 100644 tests/linstorjsondata/resource-group.json create mode 100644 tests/linstorjsondata/resource-list-test2.json create mode 100644 tests/linstorjsondata/storage-pools-ssdpool.json create mode 100644 tests/linstorjsondata/storage-pools.json create mode 100644 tests/linstorjsondata/volume-def-list.json create mode 100644 tests/linstorjsondata/volume-definition-test2.json create mode 100644 tests/storagebackendlinstortest.c create mode 100644 tests/storagepoolxml2xmlin/pool-linstor.xml create mode 100644 tests/storagevolxml2xmlin/vol-linstor.xml -- 2.30.0

1 4

[PATCH] qemu: match alias when looking for proper <interface> to detach.
by Laine Stump 11 Feb '21

11 Feb '21

Previously we only checked MAC address and PCI address (or CCW address). This is not enough information in cases where PCI address isn't provided and multiple interfaces have the same MAC address (for example, a virtio + hostdev "teaming" pair - their MAC addresses are always the same). Resolves: https://bugzilla.redhat.com/1926190 Signed-off-by: Laine Stump <laine(a)redhat.com> --- Arguably, it would be nice to overhaul the device matching used for virDomainDeviceDetach for *all* the device types, as they could all be matched by looking at alias (and PCI address, for that matter). On the other hand, for all other device types there are already enough fields being matched to assure a unique match even without looking at alias/PCI address, and this patch is intended to fix a current problem being experienced in the wild, meaning it's likely that it will need to be backported to stable branches, and I'd rather not force backporting a sweeping change to stable branches just to bring in a fix for one corner case) src/conf/domain_conf.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 07e6f39256..8f2207bdf6 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -16431,6 +16431,11 @@ virDomainNetFindIdx(virDomainDefPtr def, virDomainNetDefPtr net) &net->info.addr.ccw)) continue; + if (net->info.alias && + STRNEQ_NULLABLE(def->nets[i]->info.alias, net->info.alias)) { + continue; + } + if (matchidx >= 0) { /* there were multiple matches on mac address, and no * qualifying guest-side PCI/CCW address was given, so we must -- 2.29.2

2 1

[PATCH v3 0/2] qemu: Do not use canonical path for system memory
by Michal Privoznik 11 Feb '21

11 Feb '21

v3 of: https://listman.redhat.com/archives/libvir-list/2021-January/msg00684.html diff to v2: - Rebased as new capabilities and capabilities files were added since v2 - Replaced imaginary QEMU commit $HASH with actual commit hash (QEMU part was merged meanwhile) - Worked in Peter's review of v2 Michal Prívozník (2): qemu_capabilities: Introduce QEMU_CAPS_X_USE_CANONICAL_PATH_FOR_RAMBLOCK_ID qemu: Do not Use canonical path for system memory src/qemu/qemu_capabilities.c | 6 ++++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 35 ++++++++++++++++--- src/qemu/qemu_command.h | 3 +- src/qemu/qemu_hotplug.c | 2 +- .../caps_4.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 1 + .../caps_4.0.0.riscv32.xml | 1 + .../caps_4.0.0.riscv64.xml | 1 + .../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 1 + .../caps_4.0.0.x86_64.xml | 1 + .../caps_4.1.0.x86_64.xml | 1 + .../caps_4.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 + .../caps_4.2.0.x86_64.xml | 1 + .../caps_5.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 + .../caps_5.0.0.riscv64.xml | 1 + .../caps_5.0.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_5.1.0.sparc.xml | 1 + .../caps_5.1.0.x86_64.xml | 1 + .../caps_5.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 1 + .../caps_5.2.0.riscv64.xml | 1 + .../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 1 + .../caps_5.2.0.x86_64.xml | 1 + .../caps_6.0.0.x86_64.xml | 1 + .../disk-vhostuser.x86_64-latest.args | 3 +- .../hugepages-memaccess3.x86_64-latest.args | 4 +-- 30 files changed, 68 insertions(+), 9 deletions(-) -- 2.26.2

2 6

[PATCH v2 0/2] rpc: avoid crash when system time jump back
by BiaoxiangYe 10 Feb '21

10 Feb '21

From: BiaoXiang Ye <yebiaoxiang(a)huawei.com> Using monotonic timer instead of detecting a jump backwards as suggested by Jano and Daniel, thanks for suggestions. BiaoXiang Ye (2): rpc: avoid crash when system time jump back rpc: introduce macro MILLISECONDS_PER_SECOND src/rpc/virkeepalive.c | 35 +++++++++++++++++++---------------- 1 file changed, 19 insertions(+), 16 deletions(-) -- 2.23.0

3 4

[libvirt PATCH] schemas: Add support for maximum CPU mode
by Jiri Denemark 10 Feb '21

10 Feb '21

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- docs/schemas/cputypes.rng | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/schemas/cputypes.rng b/docs/schemas/cputypes.rng index f66bc62ba7..77c8fa783b 100644 --- a/docs/schemas/cputypes.rng +++ b/docs/schemas/cputypes.rng @@ -9,6 +9,7 @@ <value>custom</value> <value>host-model</value> <value>host-passthrough</value> + <value>maximum</value> </choice> </attribute> </define> -- 2.30.0

3 2

[PATCH] build: Remove unused 'conflicts' key from virt_daemon_unit
by Jim Fehlig 10 Feb '21

10 Feb '21

The 'conflict' key in a virt_daemon_unit dictionary is not used when generating systemd service and socket files. The comment associated with the key claims the default is 'true', and a few build files needlessly set it to 'true' when defining their virt_daemon_unit. Remove the 'conflict' key and its use in the affect build files. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- src/interface/meson.build | 1 - src/libxl/meson.build | 1 - src/lxc/meson.build | 1 - src/meson.build | 1 - src/network/meson.build | 1 - src/node_device/meson.build | 1 - src/nwfilter/meson.build | 1 - src/qemu/meson.build | 1 - src/secret/meson.build | 1 - src/storage/meson.build | 1 - src/vbox/meson.build | 1 - src/vz/meson.build | 1 - 12 files changed, 12 deletions(-) diff --git a/src/interface/meson.build b/src/interface/meson.build index 1092c5a267..2d4e30362c 100644 --- a/src/interface/meson.build +++ b/src/interface/meson.build @@ -48,7 +48,6 @@ if conf.has('WITH_INTERFACE') 'name': 'Libvirt interface', 'sockprefix': 'virtinterfaced', 'sockets': [ 'main', 'ro', 'admin' ], - 'conflicts': true, } openrc_init_files += { diff --git a/src/libxl/meson.build b/src/libxl/meson.build index 783af6c667..9793899106 100644 --- a/src/libxl/meson.build +++ b/src/libxl/meson.build @@ -71,7 +71,6 @@ if conf.has('WITH_LIBXL') 'sockprefix': 'virtxend', 'sockets': [ 'main', 'ro', 'admin' ], 'deps': 'ConditionPathExists=/proc/xen/capabilities', - 'conflicts': true, } openrc_init_files += { diff --git a/src/lxc/meson.build b/src/lxc/meson.build index f8e2a8852a..ad5c659dba 100644 --- a/src/lxc/meson.build +++ b/src/lxc/meson.build @@ -168,7 +168,6 @@ if conf.has('WITH_LXC') 'name': 'Libvirt lxc', 'sockprefix': 'virtlxcd', 'sockets': [ 'main', 'ro', 'admin' ], - 'conflicts': true, } openrc_init_files += { diff --git a/src/meson.build b/src/meson.build index 74d932a32c..f13b85b74e 100644 --- a/src/meson.build +++ b/src/meson.build @@ -201,7 +201,6 @@ guest_unit_files = [] # * sockets - array of additional sockets (optional, default [ 'main', 'ro', 'admin' ]) # * socket_$name_in - additional socket source files (optional, default remote/libvirtd.socket.in ) # * deps - socket dependencies (optional, default '') -# * conflicts - if the service conflicts with libvirtd (optional, true) virt_daemon_units = [] # openrc_init_files diff --git a/src/network/meson.build b/src/network/meson.build index 3ec598c3f9..d6fb624bb7 100644 --- a/src/network/meson.build +++ b/src/network/meson.build @@ -65,7 +65,6 @@ if conf.has('WITH_NETWORK') 'name': 'Libvirt network', 'sockprefix': 'virtnetworkd', 'sockets': [ 'main', 'ro', 'admin' ], - 'conflicts': true, } openrc_init_files += { diff --git a/src/node_device/meson.build b/src/node_device/meson.build index c4e4c3906b..15f9c3ad29 100644 --- a/src/node_device/meson.build +++ b/src/node_device/meson.build @@ -56,7 +56,6 @@ if conf.has('WITH_NODE_DEVICES') 'name': 'Libvirt nodedev', 'sockprefix': 'virtnodedevd', 'sockets': [ 'main', 'ro', 'admin' ], - 'conflicts': true, } openrc_init_files += { diff --git a/src/nwfilter/meson.build b/src/nwfilter/meson.build index 715282ee77..a21e575925 100644 --- a/src/nwfilter/meson.build +++ b/src/nwfilter/meson.build @@ -54,7 +54,6 @@ if conf.has('WITH_NWFILTER') 'name': 'Libvirt nwfilter', 'sockprefix': 'virtnwfilterd', 'sockets': [ 'main', 'ro', 'admin' ], - 'conflicts': true, } openrc_init_files += { diff --git a/src/qemu/meson.build b/src/qemu/meson.build index 08c1d20087..3898d23877 100644 --- a/src/qemu/meson.build +++ b/src/qemu/meson.build @@ -158,7 +158,6 @@ if conf.has('WITH_QEMU') 'name': 'Libvirt qemu', 'sockprefix': 'virtqemud', 'sockets': [ 'main', 'ro', 'admin' ], - 'conflicts': true, } openrc_init_files += { diff --git a/src/secret/meson.build b/src/secret/meson.build index d576d3218e..a487055cde 100644 --- a/src/secret/meson.build +++ b/src/secret/meson.build @@ -37,7 +37,6 @@ if conf.has('WITH_SECRETS') 'name': 'Libvirt secret', 'sockprefix': 'virtsecretd', 'sockets': [ 'main', 'ro', 'admin' ], - 'conflicts': true, } openrc_init_files += { diff --git a/src/storage/meson.build b/src/storage/meson.build index 153ff6f846..915ae46f61 100644 --- a/src/storage/meson.build +++ b/src/storage/meson.build @@ -119,7 +119,6 @@ if conf.has('WITH_STORAGE') 'name': 'Libvirt storage', 'sockprefix': 'virtstoraged', 'sockets': [ 'main', 'ro', 'admin' ], - 'conflicts': true, } openrc_init_files += { diff --git a/src/vbox/meson.build b/src/vbox/meson.build index 3e608fa101..df0cfb40e8 100644 --- a/src/vbox/meson.build +++ b/src/vbox/meson.build @@ -62,7 +62,6 @@ if conf.has('WITH_VBOX') 'name': 'Libvirt vbox', 'sockprefix': 'virtvboxd', 'sockets': [ 'main', 'ro', 'admin' ], - 'conflicts': true, } openrc_init_files += { diff --git a/src/vz/meson.build b/src/vz/meson.build index 2859dc7979..14f7280f66 100644 --- a/src/vz/meson.build +++ b/src/vz/meson.build @@ -52,7 +52,6 @@ if conf.has('WITH_VZ') 'name': 'Libvirt vz', 'sockprefix': 'virtvzd', 'sockets': [ 'main', 'ro', 'admin' ], - 'conflicts': true, } openrc_init_files += { -- 2.29.2

2 1

[libvirt PATCH 0/5] qemu: support "max" CPU model
by Daniel P. Berrangé 10 Feb '21

10 Feb '21

QEMU has supported a "max" CPU model for many releases now, but somehow we never got it wired up into libvirt. "max" is useful for applications which don't care about live migration and just want the best CPU model possible. Normally "host" would be used but this only works for KVM. "max" is identical to "host" for KVM, while for TCG it exposes every feature TCG implements. This "max" model will be a natural choice for something like libguestfs and probably other apps too. In libvirt we enable it with <cpu mode="maximum"/> Daniel P. Berrangé (5): conf: define a new "maximum" CPU mode conf: add reporting of "maximum" CPU mode in domain caps cpu: wire up support for maximum CPU mode qemu: probe for "-cpu max" support qemu: wire up support for maximum CPU model docs/formatdomain.rst | 24 +++++++++++++++++ docs/formatdomaincaps.html.in | 6 +++++ docs/schemas/domaincaps.rng | 13 +++++++++ src/conf/cpu_conf.c | 13 ++++++--- src/conf/cpu_conf.h | 1 + src/conf/domain_capabilities.c | 15 +++++++++++ src/conf/domain_capabilities.h | 2 ++ src/cpu/cpu.c | 4 ++- src/cpu/cpu_ppc64.c | 10 +++++-- src/cpu/cpu_x86.c | 3 ++- src/qemu/qemu_capabilities.c | 27 +++++++++++++++++++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 9 +++++-- src/qemu/qemu_domain.c | 10 ++++--- src/qemu/qemu_driver.c | 2 ++ src/qemu/qemu_process.c | 8 +++--- src/qemu/qemu_validate.c | 14 ++++++++-- tests/domaincapsdata/bhyve_basic.x86_64.xml | 1 + tests/domaincapsdata/bhyve_fbuf.x86_64.xml | 1 + tests/domaincapsdata/bhyve_uefi.x86_64.xml | 1 + tests/domaincapsdata/empty.xml | 1 + tests/domaincapsdata/libxl-xenfv.xml | 1 + tests/domaincapsdata/libxl-xenpv.xml | 1 + .../domaincapsdata/qemu_1.5.3-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_1.5.3-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_1.5.3.x86_64.xml | 1 + .../domaincapsdata/qemu_1.6.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_1.6.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_1.6.0.x86_64.xml | 1 + .../domaincapsdata/qemu_1.7.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_1.7.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_1.7.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.1.1-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.1.1-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.1.1.x86_64.xml | 1 + .../domaincapsdata/qemu_2.10.0-q35.x86_64.xml | 6 +++++ .../domaincapsdata/qemu_2.10.0-tcg.x86_64.xml | 6 +++++ .../qemu_2.10.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.10.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.10.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_2.10.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.10.0.x86_64.xml | 6 +++++ .../domaincapsdata/qemu_2.11.0-q35.x86_64.xml | 6 +++++ .../domaincapsdata/qemu_2.11.0-tcg.x86_64.xml | 6 +++++ tests/domaincapsdata/qemu_2.11.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.11.0.x86_64.xml | 6 +++++ .../domaincapsdata/qemu_2.12.0-q35.x86_64.xml | 6 +++++ .../domaincapsdata/qemu_2.12.0-tcg.x86_64.xml | 6 +++++ .../qemu_2.12.0-virt.aarch64.xml | 6 +++++ tests/domaincapsdata/qemu_2.12.0.aarch64.xml | 6 +++++ tests/domaincapsdata/qemu_2.12.0.ppc64.xml | 6 +++++ tests/domaincapsdata/qemu_2.12.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.12.0.x86_64.xml | 6 +++++ .../domaincapsdata/qemu_2.4.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.4.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.4.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.5.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.5.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.5.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.6.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.6.0-tcg.x86_64.xml | 1 + .../qemu_2.6.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.6.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.6.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_2.6.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.7.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.7.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.7.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.7.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.8.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.8.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.8.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.8.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.9.0-q35.x86_64.xml | 6 +++++ .../domaincapsdata/qemu_2.9.0-tcg.x86_64.xml | 6 +++++ tests/domaincapsdata/qemu_2.9.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_2.9.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.9.0.x86_64.xml | 6 +++++ .../domaincapsdata/qemu_3.0.0-q35.x86_64.xml | 6 +++++ .../domaincapsdata/qemu_3.0.0-tcg.x86_64.xml | 6 +++++ tests/domaincapsdata/qemu_3.0.0.ppc64.xml | 6 +++++ tests/domaincapsdata/qemu_3.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_3.0.0.x86_64.xml | 6 +++++ .../domaincapsdata/qemu_3.1.0-q35.x86_64.xml | 6 +++++ .../domaincapsdata/qemu_3.1.0-tcg.x86_64.xml | 6 +++++ tests/domaincapsdata/qemu_3.1.0.ppc64.xml | 6 +++++ tests/domaincapsdata/qemu_3.1.0.x86_64.xml | 6 +++++ .../domaincapsdata/qemu_4.0.0-q35.x86_64.xml | 6 +++++ .../domaincapsdata/qemu_4.0.0-tcg.x86_64.xml | 6 +++++ .../qemu_4.0.0-virt.aarch64.xml | 6 +++++ tests/domaincapsdata/qemu_4.0.0.aarch64.xml | 6 +++++ tests/domaincapsdata/qemu_4.0.0.ppc64.xml | 6 +++++ tests/domaincapsdata/qemu_4.0.0.s390x.xml | 6 +++++ tests/domaincapsdata/qemu_4.0.0.x86_64.xml | 6 +++++ .../domaincapsdata/qemu_4.1.0-q35.x86_64.xml | 6 +++++ .../domaincapsdata/qemu_4.1.0-tcg.x86_64.xml | 6 +++++ tests/domaincapsdata/qemu_4.1.0.x86_64.xml | 6 +++++ .../domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 6 +++++ .../domaincapsdata/qemu_4.2.0-tcg.x86_64.xml | 6 +++++ .../qemu_4.2.0-virt.aarch64.xml | 6 +++++ tests/domaincapsdata/qemu_4.2.0.aarch64.xml | 6 +++++ tests/domaincapsdata/qemu_4.2.0.ppc64.xml | 6 +++++ tests/domaincapsdata/qemu_4.2.0.s390x.xml | 6 +++++ tests/domaincapsdata/qemu_4.2.0.x86_64.xml | 6 +++++ .../domaincapsdata/qemu_5.0.0-q35.x86_64.xml | 6 +++++ .../domaincapsdata/qemu_5.0.0-tcg.x86_64.xml | 6 +++++ .../qemu_5.0.0-virt.aarch64.xml | 6 +++++ tests/domaincapsdata/qemu_5.0.0.aarch64.xml | 6 +++++ tests/domaincapsdata/qemu_5.0.0.ppc64.xml | 6 +++++ tests/domaincapsdata/qemu_5.0.0.x86_64.xml | 6 +++++ .../domaincapsdata/qemu_5.1.0-q35.x86_64.xml | 6 +++++ .../domaincapsdata/qemu_5.1.0-tcg.x86_64.xml | 6 +++++ tests/domaincapsdata/qemu_5.1.0.sparc.xml | 1 + tests/domaincapsdata/qemu_5.1.0.x86_64.xml | 6 +++++ .../domaincapsdata/qemu_5.2.0-q35.x86_64.xml | 6 +++++ .../domaincapsdata/qemu_5.2.0-tcg.x86_64.xml | 6 +++++ .../qemu_5.2.0-virt.aarch64.xml | 6 +++++ tests/domaincapsdata/qemu_5.2.0.aarch64.xml | 6 +++++ tests/domaincapsdata/qemu_5.2.0.ppc64.xml | 6 +++++ tests/domaincapsdata/qemu_5.2.0.s390x.xml | 6 +++++ tests/domaincapsdata/qemu_5.2.0.x86_64.xml | 6 +++++ .../domaincapsdata/qemu_6.0.0-q35.x86_64.xml | 6 +++++ .../domaincapsdata/qemu_6.0.0-tcg.x86_64.xml | 6 +++++ tests/domaincapsdata/qemu_6.0.0.x86_64.xml | 6 +++++ .../caps_2.10.0.x86_64.xml | 1 + .../caps_2.11.0.x86_64.xml | 1 + .../caps_2.12.0.aarch64.xml | 1 + .../caps_2.12.0.ppc64.xml | 1 + .../caps_2.12.0.x86_64.xml | 1 + .../caps_2.9.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 1 + .../caps_3.0.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 1 + .../caps_3.1.0.x86_64.xml | 1 + .../caps_4.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 1 + .../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 1 + .../caps_4.0.0.x86_64.xml | 1 + .../caps_4.1.0.x86_64.xml | 1 + .../caps_4.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 + .../caps_4.2.0.x86_64.xml | 1 + .../caps_5.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 + .../caps_5.0.0.x86_64.xml | 1 + .../caps_5.1.0.x86_64.xml | 1 + .../caps_5.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 1 + .../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 1 + .../caps_5.2.0.x86_64.xml | 1 + .../caps_6.0.0.x86_64.xml | 1 + .../cpu-cache-passthrough3.err | 2 +- 153 files changed, 575 insertions(+), 19 deletions(-) -- 2.29.2

3 21

[PATCH 00/12] vsh: Improve completer code
by Michal Privoznik 10 Feb '21

10 Feb '21

There is no functional change to completion. No user visible change, nor to a developer who writes a completer callback. Some code deduplication and code cleanup and adapting code to 2021. Michal Prívozník (12): lib: Substitute some STREQLEN with STRPREFIX vsh: Don't put VSH_OT_ALIAS onto list of completions vsh: Use g_auto(GStrv) to free string list returned by completer callback vsh: Accept NULL @list in vshCompleterFilter() vsh: Prefer g_strdup_printf() over g_snprintf() in vshReadlineOptionsGenerator() vsh: Use g_auto() for string lists returned in readline command/options generators vsh: Rewrite opt->type check in vshReadlineParse() vsh: Deduplicate filtering in vshReadlineOptionsGenerator() vsh: Deduplicate filtering in vshReadlineCommandGenerator() vsh: Simplify condition for calling completer callback vsh: Rework vshReadlineCommandGenerator() vsh: Drop unused @text arg from readline generators src/libxl/xen_xl.c | 2 +- src/util/vircgroupv2.c | 10 +-- tools/vsh.c | 152 ++++++++++++++++------------------------- 3 files changed, 63 insertions(+), 101 deletions(-) -- 2.26.2

2 17