- Devel - libvirt List Archives

[PATCH] docs/compiling: Add note on how to check minimum meson version
by Peter Krempa 16 Mar '21

16 Mar '21

Give guidance on how to check minimum meson version for a given package. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/140 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- docs/compiling.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/docs/compiling.rst b/docs/compiling.rst index 62519b6bdb..7746f20bed 100644 --- a/docs/compiling.rst +++ b/docs/compiling.rst @@ -18,6 +18,11 @@ the build directory is different from the source directory: The *meson* script can be given options to change its default behaviour. +**Note:** Please ensure that you have the appropriate minimal ``meson`` version +installed in your build environment. The minimal version for a specific package +can be checked in the top level ``meson.build`` file in the ``meson_version`` +field. + To get the complete list of the options run the following command: :: -- 2.29.2

3 2

[PATCH 0/2] Fix calling of virNetworkUpdate() driver callback
by Michal Privoznik 16 Mar '21

16 Mar '21

See 2/2 for explanation. BUT, I am not fully convinced about changing XDR though. In my testing it did not really show to be that backward compatible. I did the following tests: 1) run libvirtd unpatched, 2) run libvirtd with just arguments if the callback fixed (i.e. just the first hunk of 2/2), 3) run libvirtd with patch 2/2 as is And also, I repeated the same for split daemon using qemu:///system and network:///system URIs. I've tested the following command: virsh net-update default add dns-txt '<txt name="example" value="example value"/>' and if I got the following error message: Operation not supported: can't update 'ip' section of network 'default' I knew that arguments are swapped (because 'add' command has value 3, 'dns-txt' section has value 11 and 'ip' section has value 3). >From the results I've constructed the following tables: | libvirtd (case 1) | libvirtd + swap (case 2) | libvirtd + RPC (case 3) --------------+-------------------+--------------------------+------------------------ client | 1 | 0 | 0 client + swap | 0 | 1 | 1 client + RPC | 0 | 1 | 1 Both client and libvirtd were tested for all three cases as described above; 1 means success (API returned without an error), 0 means the error message from above was observed. For libvirtd I've tested just qemu:///system, because network:///system has to yield the same results. For split daemon (SD) case: qemu:///system | SD (case 1) | SD + swap (case 2) | SD + RPC (case 3) --------------+-------------+--------------------+------------------ client | 0 | 0 | 0 client + swap | 1 | 1 | 1 client + RPC | 1 | 1 | 1 network:///system | SD (case 1) | SD + swap (case 2) | SD + RPC (case 3) --------------+-------------+--------------------+------------------ client | 1 | 0 | 0 client + swap | 0 | 1 | 1 client + RPC | 0 | 1 | 1 Therefore, what I am trying to say is, there is no case where plain swap (= case 2) would not help and including RPC change (= case 3) would help. Maybe I'm missing something? Michal Prívozník (2): lib: Debug print all arguments of virNetworkUpdate() lib: Fix calling of virNetworkUpdate() driver callback src/libvirt-network.c | 6 +++--- src/remote/remote_protocol.x | 7 ++++++- src/remote_protocol-structs | 2 +- 3 files changed, 10 insertions(+), 5 deletions(-) -- 2.26.2

2 6

[PATCH] qemu_process: Use accessor for def->mem.total_memory
by Michal Privoznik 16 Mar '21

16 Mar '21

When connecting to the monitor, a timeout is calculated that is bigger the more memory guest has (because QEMU has to allocate and possibly zero out the memory and what not, empirically deducted). However, when computing the timeout the @total_memory mmember is accessed directly even though virDomainDefGetMemoryTotal() should have been used. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 800b7b197d..f6da5afb48 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -2077,7 +2077,7 @@ qemuConnectMonitor(virQEMUDriverPtr driver, virDomainObjPtr vm, int asyncJob, * handing them over to qemu. This can be very time * consuming. Therefore, add a second to timeout for each * 1GiB of guest RAM. */ - timeout = vm->def->mem.total_memory / (1024 * 1024); + timeout = virDomainDefGetMemoryTotal(vm->def) / (1024 * 1024); ignore_value(virTimeMillisNow(&priv->monStart)); -- 2.26.2

2 1

[PATCH] coding-style: Don't encourage virXXXPtr typedefs
by Michal Privoznik 16 Mar '21

16 Mar '21

We don't like virXXXPtr typedefs really and they are going away shortly, possibly. Do not encourage new code to put in the typedefs. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- docs/coding-style.rst | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/docs/coding-style.rst b/docs/coding-style.rst index 22de86a657..470c61860f 100644 --- a/docs/coding-style.rst +++ b/docs/coding-style.rst @@ -53,13 +53,10 @@ Struct type names All structs should have a 'vir' prefix in their typedef name, and each following word should have its first letter in uppercase. The struct name should be the same as the typedef - name with a leading underscore. A second typedef should be - given for a pointer to the struct with a 'Ptr' suffix. - + name with a leading underscore. :: typedef struct _virHashTable virHashTable; - typedef virHashTable *virHashTablePtr; struct _virHashTable { ... }; @@ -426,11 +423,11 @@ Conditional expressions For readability reasons new code should avoid shortening comparisons to 0 for numeric types. Boolean and pointer -comparisions may be shortened. All long forms are okay: +comparisons may be shortened. All long forms are okay: :: - virFooPtr foos = NULL; + virFoo *foos = NULL; size nfoos = 0; bool hasFoos = false; -- 2.26.2

2 1

[PATCH] meson: Don't check for addr2line
by Michal Privoznik 16 Mar '21

16 Mar '21

In the past, we used to have this oomtrace.pl script that attempted to print the stack trace of where an OOM error occurred and it used addr2line for that. But since v5.8.0-rc1~189 we don't really care about OOM anymore and the script is long gone so there's no need to check for addr2line program either. Fixes: 2c52ecd96086b4643b99b4570b5823d40ce2787b Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/meson.build b/meson.build index c81c6ab205..69a7b4c88e 100644 --- a/meson.build +++ b/meson.build @@ -925,7 +925,6 @@ endforeach # optional programs optional_programs = [ - 'addr2line', 'augparse', 'dmidecode', 'dnsmasq', -- 2.26.2

2 1

[PATCH v2 00/13] deprecations: remove many old deprecations
by Daniel P. Berrangé 16 Mar '21

16 Mar '21

This is an update to https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg07558.html The following features have been deprecated for well over the 2 release cycle we promise ``-drive file=3Djson:{...{'driver':'file'}}`` (since 3.0) ``-vnc acl`` (since 4.0.0) ``-mon ...,control=3Dreadline,pretty=3Don|off`` (since 4.1) ``migrate_set_downtime`` and ``migrate_set_speed`` (since 2.8.0) ``query-named-block-nodes`` result ``encryption_key_missing`` (since 2.10.0) ``query-block`` result ``inserted.encryption_key_missing`` (since 2.10.0) ``migrate-set-cache-size`` and ``query-migrate-cache-size`` (since 2.11.0) ``query-named-block-nodes`` and ``query-block`` result dirty-bitmaps[i].sta= tus (since 4.0) ``query-cpus`` (since 2.12.0) ``query-cpus-fast`` ``arch`` output member (since 3.0.0) ``query-events`` (since 4.0) chardev client socket with ``wait`` option (since 4.0) ``acl_show``, ``acl_reset``, ``acl_policy``, ``acl_add``, ``acl_remove`` (s= ince 4.0.0) ``ide-drive`` (since 4.2) ``scsi-disk`` (since 4.2) AFAICT, libvirt has ceased to use all of these too. These patches all have reviews now, and I'll send a pull request tomorrow for soft freeze unless I hear from subsystem maintainers with any negative feedback. In v2: - Dropped -usbdevice removal, as that's spun off into separate debate - Fixed misplaced hunk in scsi-disk patch - Fixed non-default iotest jobs in dirty-bitmap code Daniel P. Berrang=C3=A9 (13): ui, monitor: remove deprecated VNC ACL option and HMP commands monitor: raise error when 'pretty' option is used with HMP monitor: remove 'query-events' QMP command migrate: remove QMP/HMP commands for speed, downtime and cache size machine: remove 'query-cpus' QMP command machine: remove 'arch' field from 'query-cpus-fast' QMP command chardev: reject use of 'wait' flag for socket client chardevs hw/ide: remove 'ide-drive' device hw/scsi: remove 'scsi-disk' device block: remove 'encryption_key_missing' flag from QAPI block: remove dirty bitmaps 'status' field block: remove 'dirty-bitmaps' field from 'BlockInfo' struct block: remove support for using "file" driver with block/char devices block/dirty-bitmap.c | 38 -- block/file-posix.c | 17 +- block/qapi.c | 6 - chardev/char-socket.c | 12 +- docs/devel/migration.rst | 2 +- docs/qdev-device-use.txt | 2 +- docs/rdma.txt | 2 +- docs/system/deprecated.rst | 108 ----- docs/system/removed-features.rst | 109 +++++ docs/xbzrle.txt | 5 - hmp-commands-info.hx | 13 - hmp-commands.hx | 121 ------ hw/core/machine-hmp-cmds.c | 8 +- hw/core/machine-qmp-cmds.c | 120 ------ hw/i386/pc.c | 2 - hw/ide/qdev.c | 38 -- hw/ppc/mac_newworld.c | 13 - hw/ppc/mac_oldworld.c | 13 - hw/scsi/scsi-disk.c | 62 --- hw/sparc64/sun4u.c | 15 - include/block/dirty-bitmap.h | 1 - include/monitor/hmp.h | 4 - migration/migration.c | 45 --- migration/ram.c | 2 +- monitor/hmp-cmds.c | 34 -- monitor/misc.c | 187 --------- monitor/monitor.c | 4 +- monitor/qmp-cmds-control.c | 24 -- qapi/block-core.json | 64 +-- qapi/control.json | 45 --- qapi/machine.json | 181 +-------- qapi/migration.json | 98 ----- qemu-options.hx | 5 +- scripts/device-crash-test | 2 - softmmu/vl.c | 1 - tests/acceptance/pc_cpu_hotplug_props.py | 2 +- tests/acceptance/x86_cpu_model_versions.py | 2 +- tests/migration/guestperf/engine.py | 18 +- tests/qemu-iotests/051 | 4 - tests/qemu-iotests/051.pc.out | 20 - tests/qemu-iotests/124 | 4 - tests/qemu-iotests/181 | 2 +- tests/qemu-iotests/184.out | 6 +- tests/qemu-iotests/191.out | 48 +-- tests/qemu-iotests/194 | 4 +- tests/qemu-iotests/194.out | 4 +- tests/qemu-iotests/226.out | 10 +- tests/qemu-iotests/236 | 2 +- tests/qemu-iotests/236.out | 42 +- tests/qemu-iotests/246 | 3 +- tests/qemu-iotests/246.out | 66 +-- tests/qemu-iotests/254 | 2 +- tests/qemu-iotests/254.out | 9 +- tests/qemu-iotests/257.out | 378 ++++++------------ tests/qemu-iotests/260 | 5 +- tests/qemu-iotests/273.out | 15 +- .../tests/migrate-bitmaps-postcopy-test | 6 +- tests/qtest/migration-test.c | 48 --- tests/qtest/numa-test.c | 6 +- tests/qtest/qmp-test.c | 6 +- tests/qtest/test-hmp.c | 6 +- tests/qtest/test-x86-cpuid-compat.c | 4 +- tests/qtest/vhost-user-test.c | 8 +- ui/vnc.c | 38 -- 64 files changed, 370 insertions(+), 1801 deletions(-) --=20 2.30.2

2 15

[libvirt PATCH v3 00/10] ci: Add helper script
by Andrea Bolognani 16 Mar '21

16 Mar '21

Changes from [v2]: * address review feedback; * wrap more Makefile functionality; * split into smaller, easier to review patches. Changes from [v1]: * implement (partial) support for running builds and spawning shells inside the container; * make the code more maintainable by using a couple of classes. [v2] https://listman.redhat.com/archives/libvir-list/2021-February/msg00922.html [v1] https://listman.redhat.com/archives/libvir-list/2021-February/msg00900.html Andrea Bolognani (10): syntax-check: Allow exceptions for sc_prohibit_nonreentrant ci: Fix name for ci-test target in help output ci: Add helper script ci: Implement 'refresh' helper action ci: Implement 'list-images' helper action ci: Implement 'shell' helper action ci: Implement 'build' helper action ci: Implement 'test' helper action ci: Delete refresh scripts ci: Discourage users from using the Makefile directly build-aux/syntax-check.mk | 1 + ci/Makefile | 13 +- ci/cirrus/refresh | 22 ---- ci/containers/refresh | 41 ------ ci/helper | 260 ++++++++++++++++++++++++++++++++++++++ 5 files changed, 273 insertions(+), 64 deletions(-) delete mode 100755 ci/cirrus/refresh delete mode 100755 ci/containers/refresh create mode 100755 ci/helper -- 2.26.2

2 16

[libvirt PATCH 0/2] Coverity diaries
by Ján Tomko 16 Mar '21

16 Mar '21

two minor bug fixes Ján Tomko (2): cmdList: mark title as autofree nss: findLease: do not leak path tools/nss/libvirt_nss.c | 4 +++- tools/virsh-domain-monitor.c | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) -- 2.29.2

2 3

[libvirt PATCH 0/9] docs: Convert html.in to rst (volume 1)
by Erik Skultety 16 Mar '21

16 Mar '21

'#itsfriday' Erik Skultety (9): docs: html.in: Convert aclpolkit to rst docs: html.in: Convert api_extension to rst docs: html.in: Convert api to rst docs: html.in: Convert apps to rst docs: html.in: Convert architecture to rst docs: html.in: Convert auditlog to rst docs: html.in: Convert auth to rst docs: html.in: Convert bindings to rst docs: html.in: Convert 'compiling' to rst docs/aclpolkit.html.in | 523 ------------------------------------- docs/aclpolkit.rst | 310 ++++++++++++++++++++++ docs/api.html.in | 380 --------------------------- docs/api.rst | 265 +++++++++++++++++++ docs/api_extension.html.in | 376 -------------------------- docs/api_extension.rst | 291 +++++++++++++++++++++ docs/apps.html.in | 488 ---------------------------------- docs/apps.rst | 348 ++++++++++++++++++++++++ docs/architecture.html.in | 82 ------ docs/architecture.rst | 83 ++++++ docs/auditlog.html.in | 375 -------------------------- docs/auditlog.rst | 321 +++++++++++++++++++++++ docs/auth.html.in | 368 -------------------------- docs/auth.rst | 343 ++++++++++++++++++++++++ docs/bindings.html.in | 101 ------- docs/bindings.rst | 62 +++++ docs/compiling.html.in | 115 -------- docs/compiling.rst | 95 +++++++ docs/meson.build | 18 +- 19 files changed, 2127 insertions(+), 2817 deletions(-) delete mode 100644 docs/aclpolkit.html.in create mode 100644 docs/aclpolkit.rst delete mode 100644 docs/api.html.in create mode 100644 docs/api.rst delete mode 100644 docs/api_extension.html.in create mode 100644 docs/api_extension.rst delete mode 100644 docs/apps.html.in create mode 100644 docs/apps.rst delete mode 100644 docs/architecture.html.in create mode 100644 docs/architecture.rst delete mode 100644 docs/auditlog.html.in create mode 100644 docs/auditlog.rst delete mode 100644 docs/auth.html.in create mode 100644 docs/auth.rst delete mode 100644 docs/bindings.html.in create mode 100644 docs/bindings.rst delete mode 100644 docs/compiling.html.in create mode 100644 docs/compiling.rst -- 2.29.2

2 21

[libvirt PATCH v2 0/4] qemu: Only raise memlock limit if necessary
by Andrea Bolognani 16 Mar '21

16 Mar '21

This feature has been requested by KubeVirt developers and will make it possible for them to make some VFIO-related features, such as migration and hotplug, work correctly. https://bugzilla.redhat.com/show_bug.cgi?id=1916346 Changes from [v1]: * prep patches have been pushed; * parsing /proc file is now explicitly restricted to Linux only and only uses safe libvirt helpers; * the qemu.conf knob has been dropped in favor of adopting a behavior that should work correctly in all scenarios. [v1] https://listman.redhat.com/archives/libvir-list/2021-March/msg00293.html Andrea Bolognani (4): util: Try to get limits from /proc qemu: Don't ignore virProcessGetMaxMemLock() errors qemu: Refactor qemuDomainAdjustMaxMemLock() qemu: Only raise memlock limit if necessary src/qemu/qemu_domain.c | 36 +++++++++------ src/util/virprocess.c | 102 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 125 insertions(+), 13 deletions(-) -- 2.26.2

2 10

[PATCH v3 00/30] qapi/qom: QAPIfy --object and object-add
by Kevin Wolf 15 Mar '21

15 Mar '21

This series adds a QAPI type for the properties of all user creatable QOM types and finally makes the --object command line option (in all binaries) and the object-add monitor commands (in QMP and HMP) use the new ObjectOptions union. This change improves things in more than just one way: 1. Documentation for QOM object types has always been lacking. Adding the schema, we get documentation for every property. 2. It prevents bugs by performing parts of the input validation (e.g. checking presence of mandatory properties) already in QAPI instead of relying on separate manual implementations in each class. 3. It provides QAPI introspection for user creatable objects. 4. Non-scalar properties are now supported everywhere because the command line parsers (including HMP) use the keyval parser now. If you are in the CC list and didn't expect this series, it's probably because you're the maintainer of one of the objects for which I'm adding a QAPI schema description. Please just have a look at the specific patch for your object and check whether the schema and its documentation make sense to you. You can ignore all other patches. In a next step after this series, we can add make use of the QAPI structs in the implementation of the object and separate their configuration from the runtime state. Specifically, the plan is to add a .configure() callback to ObjectClass that allows configuring the object in one place at creation time and keeping QOM property setters only for properties that can actually be changed at runtime. Paolo made an example of what the state could look like after this: https://wiki.qemu.org/Features/QOM-QAPI_integration Finally, the intention is to extend the QAPI schema to have separate 'object' entities and generate some of the code that was written manually in the intermediate state before. This series is available as a git tag at: https://repo.or.cz/qemu/kevin.git qapi-object-v3 v3: - Removed now useless QAuthZListRuleListHack - Made some more ObjectOptions branches conditional - Improved documentation for some properties - Fixed 'qemu-img compare' exit code for option parsing failure v2: - Convert not only object-add, but all external interfaces so that the schema will always be enforced and mismatch between implementation and schema can't go unnoticed. - Rebased, covering properties and object types added since v1 (yes, things do become outdated rather quickly when you touch all user creatable objects) - Changed the "Since:" version number in the schema documentation to refer to the version when the object was introduced rather than 6.0 where the schema will (hopefully) be added - Probably some other minor changes Kevin Wolf (30): qapi/qom: Drop deprecated 'props' from object-add qapi/qom: Add ObjectOptions for iothread qapi/qom: Add ObjectOptions for authz-* qapi/qom: Add ObjectOptions for cryptodev-* qapi/qom: Add ObjectOptions for dbus-vmstate qapi/qom: Add ObjectOptions for memory-backend-* qapi/qom: Add ObjectOptions for rng-*, deprecate 'opened' qapi/qom: Add ObjectOptions for throttle-group qapi/qom: Add ObjectOptions for secret*, deprecate 'loaded' qapi/qom: Add ObjectOptions for tls-*, deprecate 'loaded' qapi/qom: Add ObjectOptions for can-* qapi/qom: Add ObjectOptions for colo-compare qapi/qom: Add ObjectOptions for filter-* qapi/qom: Add ObjectOptions for pr-manager-helper qapi/qom: Add ObjectOptions for confidential-guest-support qapi/qom: Add ObjectOptions for input-* qapi/qom: Add ObjectOptions for x-remote-object qapi/qom: QAPIfy object-add qom: Make "object" QemuOptsList optional qemu-storage-daemon: Implement --object with qmp_object_add() qom: Remove user_creatable_add_dict() qom: Factor out user_creatable_process_cmdline() qemu-io: Use user_creatable_process_cmdline() for --object qemu-nbd: Use user_creatable_process_cmdline() for --object qom: Add user_creatable_add_from_str() qemu-img: Use user_creatable_process_cmdline() for --object hmp: QAPIfy object_add qom: Add user_creatable_parse_str() vl: QAPIfy -object qom: Drop QemuOpts based interfaces qapi/authz.json | 61 ++- qapi/block-core.json | 27 ++ qapi/common.json | 52 +++ qapi/crypto.json | 159 +++++++ qapi/machine.json | 22 +- qapi/net.json | 20 - qapi/qom.json | 644 ++++++++++++++++++++++++++- qapi/ui.json | 13 +- docs/system/deprecated.rst | 25 +- docs/system/removed-features.rst | 5 + include/qom/object_interfaces.h | 106 ++--- hw/block/xen-block.c | 16 +- monitor/hmp-cmds.c | 17 +- monitor/misc.c | 2 - qemu-img.c | 251 ++--------- qemu-io.c | 33 +- qemu-nbd.c | 34 +- qom/object_interfaces.c | 168 +++---- qom/qom-qmp-cmds.c | 28 +- softmmu/vl.c | 109 +++-- storage-daemon/qemu-storage-daemon.c | 27 +- tests/check-qom-proplist.c | 42 +- hmp-commands.hx | 2 +- storage-daemon/qapi/qapi-schema.json | 1 + 24 files changed, 1231 insertions(+), 633 deletions(-) -- 2.29.2

7 77

[libvirt PATCH] qemu_driver: fix setting vcpu_quota if not all vCPUs are online
by Pavel Hrdina 15 Mar '21

15 Mar '21

When switching to g_autoptr this was incorrectly changed from 'continue;' into 'return -1;' resulting into an error when user tries to set vcpu_quota of running VM: error: An error occurred, but the cause is unknown Fixes: e4a8bbfaf2b4cdd741bb441873bb730f9134b714 Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index b7c89a826a..16c5ccae45 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -9204,7 +9204,7 @@ qemuSetVcpusBWLive(virDomainObjPtr vm, virCgroupPtr cgroup, virDomainVcpuDefPtr vcpu = virDomainDefGetVcpu(vm->def, i); if (!vcpu->online) - return -1; + continue; if (virCgroupNewThread(cgroup, VIR_CGROUP_THREAD_VCPU, i, false, &cgroup_vcpu) < 0) -- 2.30.2

2 1

[libvirt PATCH v2 0/1] ci: Add helper script
by Andrea Bolognani 15 Mar '21

15 Mar '21

Changes from [v1]: * implement (partial) support for running builds and spawning shells inside the container; * make the code more maintainable by using a couple of classes. [v1] https://listman.redhat.com/archives/libvir-list/2021-February/msg00900.h= tml Andrea Bolognani (1): ci: Add helper script ci/cirrus/refresh | 22 ----- ci/containers/refresh | 41 --------- ci/helper | 187 ++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 187 insertions(+), 63 deletions(-) delete mode 100755 ci/cirrus/refresh delete mode 100755 ci/containers/refresh create mode 100755 ci/helper --=20 2.26.2

2 4

[PATCH 00/14] deprecations: remove many old deprecations
by Daniel P. Berrangé 15 Mar '21

15 Mar '21

The following features have been deprecated for well over the 2 release cycle we promise ``-usbdevice`` (since 2.10.0) ``-drive file=3Djson:{...{'driver':'file'}}`` (since 3.0) ``-vnc acl`` (since 4.0.0) ``-mon ...,control=3Dreadline,pretty=3Don|off`` (since 4.1) ``migrate_set_downtime`` and ``migrate_set_speed`` (since 2.8.0) ``query-named-block-nodes`` result ``encryption_key_missing`` (since 2.10.0) ``query-block`` result ``inserted.encryption_key_missing`` (since 2.10.0) ``migrate-set-cache-size`` and ``query-migrate-cache-size`` (since 2.11.0) ``query-named-block-nodes`` and ``query-block`` result dirty-bitmaps[i].sta= tus (ince 4.0) ``query-cpus`` (since 2.12.0) ``query-cpus-fast`` ``arch`` output member (since 3.0.0) ``query-events`` (since 4.0) chardev client socket with ``wait`` option (since 4.0) ``acl_show``, ``acl_reset``, ``acl_policy``, ``acl_add``, ``acl_remove`` (s= ince 4.0.0) ``ide-drive`` (since 4.2) ``scsi-disk`` (since 4.2) AFAICT, libvirt has ceased to use all of these too. There are many more similarly old deprecations not (yet) tackled. Daniel P. Berrang=C3=A9 (14): ui, monitor: remove deprecated VNC ACL option and HMP commands monitor: raise error when 'pretty' option is used with HMP monitor: remove 'query-events' QMP command softmmu: remove '-usbdevice' command line option migrate: remove QMP/HMP commands for speed, downtime and cache size machine: remove 'query-cpus' QMP command machine: remove 'arch' field from 'query-cpus-fast' QMP command chardev: reject use of 'wait' flag for socket client chardevs hw/ide: remove 'ide-drive' device hw/scsi: remove 'scsi-disk' device block: remove 'encryption_key_missing' flag from QAPI block: remove dirty bitmaps 'status' field block: remove 'dirty-bitmaps' field from 'BlockInfo' struct block: remove support for using "file" driver with block/char devices block/dirty-bitmap.c | 38 --- block/file-posix.c | 17 +- block/qapi.c | 6 - chardev/char-socket.c | 12 +- docs/devel/migration.rst | 2 +- docs/qdev-device-use.txt | 2 +- docs/rdma.txt | 2 +- docs/system/deprecated.rst | 117 ------- docs/system/removed-features.rst | 123 +++++++ docs/xbzrle.txt | 5 - hmp-commands-info.hx | 13 - hmp-commands.hx | 121 ------- hw/core/machine-hmp-cmds.c | 8 +- hw/core/machine-qmp-cmds.c | 120 ------- hw/i386/pc.c | 2 - hw/ide/qdev.c | 38 --- hw/ppc/mac_newworld.c | 13 - hw/ppc/mac_oldworld.c | 13 - hw/scsi/scsi-disk.c | 62 ---- hw/sparc64/sun4u.c | 15 - include/block/dirty-bitmap.h | 1 - include/monitor/hmp.h | 4 - migration/migration.c | 45 --- migration/ram.c | 2 +- monitor/hmp-cmds.c | 34 -- monitor/misc.c | 187 ---------- monitor/monitor.c | 4 +- monitor/qmp-cmds-control.c | 24 -- qapi/block-core.json | 64 +--- qapi/control.json | 45 --- qapi/machine.json | 181 +--------- qapi/migration.json | 98 ------ qemu-options.hx | 5 +- scripts/device-crash-test | 2 - softmmu/vl.c | 43 --- tests/acceptance/pc_cpu_hotplug_props.py | 2 +- tests/acceptance/x86_cpu_model_versions.py | 2 +- tests/migration/guestperf/engine.py | 18 +- tests/qemu-iotests/051 | 4 - tests/qemu-iotests/051.pc.out | 20 -- tests/qemu-iotests/124 | 4 - tests/qemu-iotests/181 | 2 +- tests/qemu-iotests/184.out | 6 +- tests/qemu-iotests/191.out | 48 +-- tests/qemu-iotests/194 | 4 +- tests/qemu-iotests/194.out | 4 +- tests/qemu-iotests/226.out | 10 +- tests/qemu-iotests/236 | 2 +- tests/qemu-iotests/236.out | 42 +-- tests/qemu-iotests/246 | 3 +- tests/qemu-iotests/246.out | 66 ++-- tests/qemu-iotests/254 | 2 +- tests/qemu-iotests/254.out | 9 +- tests/qemu-iotests/257.out | 378 +++++++-------------- tests/qemu-iotests/260 | 5 +- tests/qemu-iotests/273.out | 15 +- tests/qtest/migration-test.c | 48 --- tests/qtest/numa-test.c | 6 +- tests/qtest/qmp-test.c | 6 +- tests/qtest/test-hmp.c | 6 +- tests/qtest/test-x86-cpuid-compat.c | 4 +- tests/qtest/vhost-user-test.c | 8 +- ui/vnc.c | 38 --- 63 files changed, 380 insertions(+), 1850 deletions(-) --=20 2.29.2

13 47

[PATCH] bhyve: add <os firmware='efi'> support
by Roman Bogorodskiy 15 Mar '21

15 Mar '21

Implement "<os firmware='efi'>" support for bhyve driver. As there are not really lot of options, try to find "BHYVE_UEFI.fd" firmware which is installed by the sysutils/uefi-edk2-bhyve FreeBSD port. If not found, just use the first found firmware in the firmwares directory (which is configurable via config file). Signed-off-by: Roman Bogorodskiy <bogorodskiy(a)gmail.com> --- Not extremely happy about the LIBVIRT_BHYVE_FIRMWARE_DIR_OVERRIDE knob, but not sure how to test this otherwise. po/POTFILES.in | 1 + src/bhyve/bhyve_domain.c | 5 + src/bhyve/bhyve_firmware.c | 91 +++++++++++++++++++ src/bhyve/bhyve_firmware.h | 30 ++++++ src/bhyve/bhyve_process.c | 15 +++ src/bhyve/bhyve_process.h | 5 + src/bhyve/meson.build | 1 + .../bhyvexml2argv-firmware-efi.args | 11 +++ .../bhyvexml2argv-firmware-efi.ldargs | 1 + .../bhyvexml2argv-firmware-efi.xml | 22 +++++ tests/bhyvexml2argvtest.c | 83 ++++++++++++++--- 11 files changed, 254 insertions(+), 11 deletions(-) create mode 100644 src/bhyve/bhyve_firmware.c create mode 100644 src/bhyve/bhyve_firmware.h create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-firmware-efi.args create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-firmware-efi.ldargs create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-firmware-efi.xml diff --git a/po/POTFILES.in b/po/POTFILES.in index 80c5f145be..413783ee35 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -14,6 +14,7 @@ @SRCDIR@src/bhyve/bhyve_command.c @SRCDIR@src/bhyve/bhyve_domain.c @SRCDIR@src/bhyve/bhyve_driver.c +@SRCDIR@src/bhyve/bhyve_firmware.c @SRCDIR@src/bhyve/bhyve_monitor.c @SRCDIR@src/bhyve/bhyve_parse_command.c @SRCDIR@src/bhyve/bhyve_process.c diff --git a/src/bhyve/bhyve_domain.c b/src/bhyve/bhyve_domain.c index 8fbc554a0a..209e4d3905 100644 --- a/src/bhyve/bhyve_domain.c +++ b/src/bhyve/bhyve_domain.c @@ -64,6 +64,9 @@ bhyveDomainDefNeedsISAController(virDomainDefPtr def) if (def->os.bootloader == NULL && def->os.loader) return true; + if (def->os.firmware == VIR_DOMAIN_OS_DEF_FIRMWARE_EFI) + return true; + if (def->nserials || def->nconsoles) return true; @@ -230,6 +233,8 @@ virDomainDefParserConfig virBhyveDriverDomainDefParserConfig = { .domainPostParseCallback = bhyveDomainDefPostParse, .assignAddressesCallback = bhyveDomainDefAssignAddresses, .deviceValidateCallback = bhyveDomainDeviceDefValidate, + + .features = VIR_DOMAIN_DEF_FEATURE_FW_AUTOSELECT, }; static void diff --git a/src/bhyve/bhyve_firmware.c b/src/bhyve/bhyve_firmware.c new file mode 100644 index 0000000000..ccc3a5ffc8 --- /dev/null +++ b/src/bhyve/bhyve_firmware.c @@ -0,0 +1,91 @@ +/* + * bhyve_firmware.c: bhyve firmware management + * + * Copyright (C) 2021 Roman Bogorodskiy + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + */ + +#include <config.h> +#include <dirent.h> + +#include "viralloc.h" +#include "virlog.h" +#include "virfile.h" +#include "bhyve_conf.h" +#include "bhyve_firmware.h" + +#define VIR_FROM_THIS VIR_FROM_BHYVE + +VIR_LOG_INIT("bhyve.bhyve_firmware"); + + +#define BHYVE_DEFAULT_FIRMWARE "BHYVE_UEFI.fd" + +int +bhyveFirmwareFillDomain(bhyveConnPtr driver, + virDomainDefPtr def, + unsigned int flags) +{ + g_autoptr(DIR) dir = NULL; + virBhyveDriverConfigPtr cfg = virBhyveDriverGetConfig(driver); + const char *firmware_dir_cfg = cfg->firmwareDir; + const char *firmware_dir_env = NULL, *firmware_dir = NULL; + struct dirent *entry; + char *matching_firmware = NULL; + char *first_found = NULL; + + virCheckFlags(0, -1); + + if (def->os.firmware == VIR_DOMAIN_OS_DEF_FIRMWARE_NONE) + return 0; + + if (virDirOpenIfExists(&dir, firmware_dir_cfg) > 0) { + while ((virDirRead(dir, &entry, firmware_dir)) > 0) { + if (STREQ(entry->d_name, BHYVE_DEFAULT_FIRMWARE)) { + matching_firmware = g_strdup(entry->d_name); + break; + } + if (!first_found) + first_found = g_strdup(entry->d_name); + } + } + + if (!matching_firmware) { + if (!first_found) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("no firmwares found in %s"), + firmware_dir_cfg); + return -1; + } else { + matching_firmware = first_found; + } + } + + if (!def->os.loader) + def->os.loader = g_new0(virDomainLoaderDef, 1); + + def->os.loader->type = VIR_DOMAIN_LOADER_TYPE_PFLASH; + def->os.loader->readonly = VIR_TRISTATE_BOOL_YES; + + VIR_FREE(def->os.loader->path); + + firmware_dir_env = g_getenv("LIBVIRT_BHYVE_FIRMWARE_DIR_OVERRIDE"); + firmware_dir = firmware_dir_env ? firmware_dir_env : firmware_dir_cfg; + def->os.loader->path = g_build_filename(firmware_dir, matching_firmware, NULL); + + return 0; +} diff --git a/src/bhyve/bhyve_firmware.h b/src/bhyve/bhyve_firmware.h new file mode 100644 index 0000000000..ae4bc98676 --- /dev/null +++ b/src/bhyve/bhyve_firmware.h @@ -0,0 +1,30 @@ +/* + * bhyve_firmware.h: bhyve firmware management + * + * Copyright (C) 2021 Roman Bogorodskiy + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + */ + +#pragma once + +#include "domain_conf.h" +#include "bhyve_utils.h" + +int +bhyveFirmwareFillDomain(bhyveConnPtr driver, + virDomainDefPtr def, + unsigned int flags); diff --git a/src/bhyve/bhyve_process.c b/src/bhyve/bhyve_process.c index 060018bc70..0cfe69688c 100644 --- a/src/bhyve/bhyve_process.c +++ b/src/bhyve/bhyve_process.c @@ -33,6 +33,7 @@ #include "bhyve_device.h" #include "bhyve_driver.h" #include "bhyve_command.h" +#include "bhyve_firmware.h" #include "bhyve_monitor.h" #include "bhyve_process.h" #include "datatypes.h" @@ -251,6 +252,17 @@ virBhyveProcessStartImpl(bhyveConnPtr driver, return ret; } +int +bhyveProcessPrepareDomain(bhyveConnPtr driver, + virDomainObjPtr vm, + unsigned int flags) +{ + if (bhyveFirmwareFillDomain(driver, vm->def, flags) < 0) + return -1; + + return 0; +} + int virBhyveProcessStart(virConnectPtr conn, virDomainObjPtr vm, @@ -268,6 +280,9 @@ virBhyveProcessStart(virConnectPtr conn, conn, bhyveProcessAutoDestroy) < 0) return -1; + if (bhyveProcessPrepareDomain(driver, vm, flags) < 0) + return -1; + return virBhyveProcessStartImpl(driver, vm, reason); } diff --git a/src/bhyve/bhyve_process.h b/src/bhyve/bhyve_process.h index d7b4e0bd4e..133863c1e0 100644 --- a/src/bhyve/bhyve_process.h +++ b/src/bhyve/bhyve_process.h @@ -23,6 +23,11 @@ #include "bhyve_utils.h" +int +bhyveProcessPrepareDomain(bhyveConnPtr driver, + virDomainObjPtr vm, + unsigned int flags); + int virBhyveProcessStart(virConnectPtr conn, virDomainObjPtr vm, virDomainRunningReason reason, diff --git a/src/bhyve/meson.build b/src/bhyve/meson.build index 2b65eecf5e..b3551477b7 100644 --- a/src/bhyve/meson.build +++ b/src/bhyve/meson.build @@ -2,6 +2,7 @@ bhyve_sources = files( 'bhyve_capabilities.c', 'bhyve_command.c', 'bhyve_conf.c', + 'bhyve_firmware.c', 'bhyve_parse_command.c', 'bhyve_device.c', 'bhyve_domain.c', diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-firmware-efi.args b/tests/bhyvexml2argvdata/bhyvexml2argv-firmware-efi.args new file mode 100644 index 0000000000..40bc84ef27 --- /dev/null +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-firmware-efi.args @@ -0,0 +1,11 @@ +/usr/sbin/bhyve \ +-c 1 \ +-m 214 \ +-u \ +-H \ +-P \ +-s 0:0,hostbridge \ +-l bootrom,test_firmware_dir/BHYVE_UEFI.fd \ +-s 1:0,lpc \ +-s 2:0,ahci,hd:/tmp/freebsd.img \ +-s 3:0,virtio-net,faketapdev,mac=52:54:00:00:00:00 bhyve diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-firmware-efi.ldargs b/tests/bhyvexml2argvdata/bhyvexml2argv-firmware-efi.ldargs new file mode 100644 index 0000000000..421376db9e --- /dev/null +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-firmware-efi.ldargs @@ -0,0 +1 @@ +dummy diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-firmware-efi.xml b/tests/bhyvexml2argvdata/bhyvexml2argv-firmware-efi.xml new file mode 100644 index 0000000000..302326cb26 --- /dev/null +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-firmware-efi.xml @@ -0,0 +1,22 @@ +<domain type='bhyve'> + <name>bhyve</name> + <uuid>df3be7e7-a104-11e3-aeb0-50e5492bd3dc</uuid> + <memory>219136</memory> + <vcpu>1</vcpu> + <os firmware='efi'> + <type>hvm</type> + </os> + <devices> + <disk type='file'> + <driver name='file' type='raw'/> + <source file='/tmp/freebsd.img'/> + <target dev='hda' bus='sata'/> + <address type='drive' controller='0' bus='0' target='2' unit='0'/> + </disk> + <interface type='bridge'> + <model type='virtio'/> + <source bridge="virbr0"/> + <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> + </interface> + </devices> +</domain> diff --git a/tests/bhyvexml2argvtest.c b/tests/bhyvexml2argvtest.c index 197334f9c4..13b8e34c2b 100644 --- a/tests/bhyvexml2argvtest.c +++ b/tests/bhyvexml2argvtest.c @@ -7,17 +7,20 @@ # include "datatypes.h" # include "bhyve/bhyve_capabilities.h" +# include "bhyve/bhyve_conf.h" # include "bhyve/bhyve_domain.h" # include "bhyve/bhyve_utils.h" # include "bhyve/bhyve_command.h" +# include "bhyve/bhyve_process.h" # define VIR_FROM_THIS VIR_FROM_BHYVE static bhyveConn driver; typedef enum { - FLAG_EXPECT_FAILURE = 1 << 0, - FLAG_EXPECT_PARSE_ERROR = 1 << 1, + FLAG_EXPECT_FAILURE = 1 << 0, + FLAG_EXPECT_PARSE_ERROR = 1 << 1, + FLAG_EXPECT_PREPARE_ERROR = 1 << 2, } virBhyveXMLToArgvTestFlags; static int testCompareXMLToArgvFiles(const char *xml, @@ -29,7 +32,7 @@ static int testCompareXMLToArgvFiles(const char *xml, g_autofree char *actualargv = NULL; g_autofree char *actualld = NULL; g_autofree char *actualdm = NULL; - g_autoptr(virDomainDef) vmdef = NULL; + g_autoptr(virDomainObj) vm = NULL; g_autoptr(virCommand) cmd = NULL; g_autoptr(virCommand) ldcmd = NULL; g_autoptr(virConnect) conn = NULL; @@ -38,7 +41,10 @@ static int testCompareXMLToArgvFiles(const char *xml, if (!(conn = virGetConnect())) goto out; - if (!(vmdef = virDomainDefParseFile(xml, driver.xmlopt, + if (!(vm = virDomainObjNew(driver.xmlopt))) + return -1; + + if (!(vm->def = virDomainDefParseFile(xml, driver.xmlopt, NULL, VIR_DOMAIN_DEF_PARSE_INACTIVE))) { if (flags & FLAG_EXPECT_PARSE_ERROR) { ret = 0; @@ -54,11 +60,20 @@ static int testCompareXMLToArgvFiles(const char *xml, conn->privateData = &driver; - cmd = virBhyveProcessBuildBhyveCmd(&driver, vmdef, false); - if (vmdef->os.loader) + if (bhyveProcessPrepareDomain(&driver, vm, 0) < 0) { + if (flags & FLAG_EXPECT_PREPARE_ERROR) { + ret = 0; + VIR_TEST_DEBUG("Got expected error: %s", + virGetLastErrorMessage()); + } + goto out; + } + + cmd = virBhyveProcessBuildBhyveCmd(&driver, vm->def, false); + if (vm->def->os.loader) ldcmd = virCommandNew("dummy"); else - ldcmd = virBhyveProcessBuildLoadCmd(&driver, vmdef, "<device.map>", + ldcmd = virBhyveProcessBuildLoadCmd(&driver, vm->def, "<device.map>", &actualdm); if ((cmd == NULL) || (ldcmd == NULL)) { @@ -94,10 +109,10 @@ static int testCompareXMLToArgvFiles(const char *xml, ret = 0; out: - if (vmdef && - vmdef->ngraphics == 1 && - vmdef->graphics[0]->type == VIR_DOMAIN_GRAPHICS_TYPE_VNC) - virPortAllocatorRelease(vmdef->graphics[0]->data.vnc.port); + if (vm && vm->def && + vm->def->ngraphics == 1 && + vm->def->graphics[0]->type == VIR_DOMAIN_GRAPHICS_TYPE_VNC) + virPortAllocatorRelease(vm->def->graphics[0]->data.vnc.port); return ret; } @@ -128,10 +143,16 @@ testCompareXMLToArgvHelper(const void *data) return testCompareXMLToArgvFiles(xml, args, ldargs, dmargs, info->flags); } +# define FAKEFIRMWAREDIRTEMPLATE abs_builddir "/bhyvefakefirmwaredir-XXXXXX" + static int mymain(void) { int ret = 0; + g_autofree char *fakefirmwaredir = NULL; + g_autofree char *emptyfirmwaredir = NULL; + const char *firmwares[] = {"BHYVE_UEFI.fd", "BHYVE_UEFI_CSM.fd", "refind_x64.efi", NULL}; + size_t i; if ((driver.caps = virBhyveCapsBuild()) == NULL) return EXIT_FAILURE; @@ -142,6 +163,35 @@ mymain(void) if (!(driver.remotePorts = virPortAllocatorRangeNew("display", 5900, 65535))) return EXIT_FAILURE; + if (!(driver.config = virBhyveDriverConfigNew())) + return EXIT_FAILURE; + + fakefirmwaredir = g_strdup(FAKEFIRMWAREDIRTEMPLATE); + + if (!g_mkdtemp(fakefirmwaredir)) { + fprintf(stderr, "Cannot create fakefirmwaredir"); + abort(); + } + driver.config->firmwareDir = fakefirmwaredir; + + emptyfirmwaredir = g_strdup(FAKEFIRMWAREDIRTEMPLATE); + + if (!g_mkdtemp(emptyfirmwaredir)) { + fprintf(stderr, "Cannot create emptyfirmwaredir"); + abort(); + } + + i = 0; + while (firmwares[i]) { + g_autofree char *firmware_path = g_strdup_printf("%s/%s", fakefirmwaredir, firmwares[i++]); + + if (virFileTouch(firmware_path, 0600) < 0) { + fprintf(stderr, "Cannot create firmware file"); + abort(); + } + } + + g_setenv("LIBVIRT_BHYVE_FIRMWARE_DIR_OVERRIDE", "test_firmware_dir", TRUE); # define DO_TEST_FULL(name, flags) \ do { \ @@ -162,6 +212,9 @@ mymain(void) # define DO_TEST_PARSE_ERROR(name) \ DO_TEST_FULL(name, FLAG_EXPECT_PARSE_ERROR) +# define DO_TEST_PREPARE_ERROR(name) \ + DO_TEST_FULL(name, FLAG_EXPECT_PREPARE_ERROR) + driver.grubcaps = BHYVE_GRUB_CAP_CONSDEV; driver.bhyvecaps = BHYVE_CAP_RTC_UTC | BHYVE_CAP_AHCI32SLOT | \ BHYVE_CAP_NET_E1000 | BHYVE_CAP_LPC_BOOTROM | \ @@ -209,6 +262,10 @@ mymain(void) DO_TEST("sound"); DO_TEST("isa-controller"); DO_TEST_FAILURE("isa-multiple-controllers"); + DO_TEST("firmware-efi"); + g_unsetenv("LIBVIRT_BHYVE_FIRMWARE_DIR_OVERRIDE"); + driver.config->firmwareDir = emptyfirmwaredir; + DO_TEST_PREPARE_ERROR("firmware-efi"); DO_TEST("fs-9p"); DO_TEST("fs-9p-readonly"); DO_TEST_FAILURE("fs-9p-unsupported-type"); @@ -264,9 +321,13 @@ mymain(void) driver.bhyvecaps &= ~BHYVE_CAP_VNC_PASSWORD; DO_TEST_FAILURE("vnc-password"); + virFileDeleteTree(fakefirmwaredir); + virFileDeleteTree(emptyfirmwaredir); + virObjectUnref(driver.caps); virObjectUnref(driver.xmlopt); virPortAllocatorRangeFree(driver.remotePorts); + virObjectUnref(driver.config); return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -- 2.30.0

3 2

[PATCH v3 00/13] Prepare for -object QAPIfication
by Peter Krempa 13 Mar '21

13 Mar '21

v3 now uses JSON to configure objects which is possible with the following qemu patch: https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg04436.html The use of JSON completely avoids problems with conversion of the JSON definition which we create regardless (especially bitmaps/arrays for the host-nodes property) to command line arguments which was lossy with the traditional arguments. Peter Krempa (13): qemuxml2argvdata: Remove unused output file 'disk-network-tlsx509.x86_64-latest.args' virQEMUQAPISchemaTraverse: Fix quoting in comment qemu: capabilities: Introduce QEMU_CAPS_OBJECT_QAPIFIED qemu: monitor: Make wrapping of 'props' of 'object-add' optional qemuMonitorCreateObjectPropsWrap: Open-code in qemuBuildMemoryBackendProps qemu: monitor: Don't add 'props' wrapper if qemu has QEMU_CAPS_OBJECT_QAPIFIED qemu: command: Use JSON for QAPIfied -object directly tests: qemuxml2argv: Validate generation of JSON props for object-add qemumonitorjsontest: Remove tripwire guarding object-add QAPIfication tests: qemucapabilities: Update qemu caps for object-add qapification qemuxml2argvtest: Add DO_CAPS_LATEST variant of 'numatune-memnode' qemuxml2argvtest: Pin examples of -object usage to qemu-5.2 caps qemu: capabilities: Enable detection of QEMU_CAPS_OBJECT_QAPIFIED src/libvirt_private.syms | 1 - src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 98 +- src/qemu/qemu_monitor.c | 78 +- src/qemu/qemu_monitor.h | 4 - src/qemu/qemu_qapi.c | 2 +- src/util/virqemu.c | 38 - src/util/virqemu.h | 3 - .../domaincapsdata/qemu_6.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_6.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_6.0.0.x86_64.xml | 1 + .../caps_6.0.0.x86_64.replies | 3262 ++++++++++++----- .../caps_6.0.0.x86_64.xml | 89 +- tests/qemumonitorjsontest.c | 14 - .../audio-alsa-best.x86_64-latest.args | 6 +- .../audio-alsa-full.x86_64-latest.args | 6 +- .../audio-alsa-minimal.x86_64-latest.args | 6 +- .../audio-coreaudio-best.x86_64-latest.args | 6 +- .../audio-coreaudio-full.x86_64-latest.args | 6 +- ...audio-coreaudio-minimal.x86_64-latest.args | 6 +- ...udio-default-nographics.x86_64-latest.args | 6 +- .../audio-default-sdl.x86_64-latest.args | 6 +- .../audio-default-spice.x86_64-latest.args | 6 +- .../audio-default-vnc.x86_64-latest.args | 6 +- .../audio-file-best.x86_64-latest.args | 6 +- .../audio-file-full.x86_64-latest.args | 6 +- .../audio-file-minimal.x86_64-latest.args | 6 +- .../audio-jack-full.x86_64-latest.args | 6 +- .../audio-jack-minimal.x86_64-latest.args | 6 +- .../audio-many-backends.x86_64-latest.args | 6 +- .../audio-none-best.x86_64-latest.args | 6 +- .../audio-none-full.x86_64-latest.args | 6 +- .../audio-none-minimal.x86_64-latest.args | 6 +- .../audio-oss-best.x86_64-latest.args | 6 +- .../audio-oss-full.x86_64-latest.args | 6 +- .../audio-oss-minimal.x86_64-latest.args | 6 +- .../audio-pulseaudio-best.x86_64-latest.args | 6 +- .../audio-pulseaudio-full.x86_64-latest.args | 6 +- ...udio-pulseaudio-minimal.x86_64-latest.args | 6 +- .../audio-sdl-best.x86_64-latest.args | 6 +- .../audio-sdl-full.x86_64-latest.args | 6 +- .../audio-sdl-minimal.x86_64-latest.args | 6 +- .../audio-spice-best.x86_64-latest.args | 6 +- .../audio-spice-full.x86_64-latest.args | 6 +- .../audio-spice-minimal.x86_64-latest.args | 6 +- .../blkdeviotune-group-num.x86_64-latest.args | 6 +- ...blkdeviotune-max-length.x86_64-latest.args | 6 +- .../blkdeviotune-max.x86_64-latest.args | 6 +- .../channel-unix-guestfwd.x86_64-latest.args | 6 +- .../console-virtio-unix.x86_64-latest.args | 6 +- .../controller-virtio-scsi.x86_64-latest.args | 6 +- ...-Icelake-Server-pconfig.x86_64-latest.args | 6 +- .../cpu-translation.x86_64-latest.args | 6 +- .../cpu-tsc-high-frequency.x86_64-latest.args | 6 +- .../cputune-cpuset-big-id.x86_64-latest.args | 6 +- .../disk-aio-io_uring.x86_64-latest.args | 6 +- .../disk-aio.x86_64-latest.args | 6 +- ...-backing-chains-noindex.x86_64-latest.args | 12 +- .../disk-cache.x86_64-latest.args | 6 +- .../disk-cdrom-bus-other.x86_64-latest.args | 6 +- ...m-empty-network-invalid.x86_64-latest.args | 6 +- .../disk-cdrom-network.x86_64-latest.args | 6 +- .../disk-cdrom-tray.x86_64-latest.args | 6 +- .../disk-cdrom.x86_64-latest.args | 6 +- .../disk-copy_on_read.x86_64-latest.args | 6 +- .../disk-detect-zeroes.x86_64-latest.args | 6 +- .../disk-discard.x86_64-latest.args | 6 +- .../disk-error-policy.x86_64-latest.args | 6 +- .../disk-floppy-q35-2_11.x86_64-latest.args | 6 +- .../disk-floppy-q35-2_9.x86_64-latest.args | 6 +- .../disk-floppy.x86_64-latest.args | 6 +- .../disk-metadata-cache.x86_64-latest.args | 6 +- .../disk-network-gluster.x86_64-latest.args | 6 +- .../disk-network-http.x86_64-latest.args | 18 +- .../disk-network-iscsi.x86_64-latest.args | 18 +- .../disk-network-nbd.x86_64-latest.args | 6 +- .../disk-network-nfs.x86_64-latest.args | 6 +- .../disk-network-rbd.x86_64-latest.args | 12 +- .../disk-network-sheepdog.x86_64-latest.args | 6 +- ...isk-network-source-auth.x86_64-latest.args | 24 +- ...disk-network-tlsx509-nbd.x86_64-5.2.0.args | 50 + ...isk-network-tlsx509-nbd.x86_64-latest.args | 18 +- .../disk-network-tlsx509.x86_64-latest.args | 90 - .../disk-nvme.x86_64-latest.args | 12 +- .../disk-readonly-disk.x86_64-latest.args | 6 +- .../disk-scsi-device-auto.x86_64-latest.args | 6 +- .../disk-scsi.x86_64-latest.args | 6 +- .../disk-shared.x86_64-latest.args | 6 +- .../disk-slices.x86_64-latest.args | 18 +- .../disk-transient.x86_64-latest.args | 6 +- .../disk-vhostuser.x86_64-latest.args | 8 +- ...virtio-scsi-reservations.x86_64-5.2.0.args | 55 + ...irtio-scsi-reservations.x86_64-latest.args | 14 +- .../eoi-disabled.x86_64-latest.args | 6 +- .../eoi-enabled.x86_64-latest.args | 6 +- .../fips-enabled.x86_64-latest.args | 6 +- .../floppy-drive-fat.x86_64-latest.args | 6 +- .../qemuxml2argvdata/fs9p.x86_64-latest.args | 6 +- .../genid-auto.x86_64-latest.args | 6 +- .../qemuxml2argvdata/genid.x86_64-latest.args | 6 +- ...egl-headless-rendernode.x86_64-latest.args | 6 +- .../graphics-egl-headless.x86_64-latest.args | 6 +- ...pice-gl-auto-rendernode.x86_64-latest.args | 6 +- .../graphics-vnc-power.x86_64-latest.args | 6 +- .../graphics-vnc-tls-secret.x86_64-5.2.0.args | 42 + ...graphics-vnc-tls-secret.x86_64-latest.args | 17 +- .../graphics-vnc-tls.x86_64-latest.args | 10 +- ...tdev-mdev-display-ramfb.x86_64-latest.args | 6 +- ...play-spice-egl-headless.x86_64-latest.args | 6 +- ...ev-display-spice-opengl.x86_64-latest.args | 6 +- ...isplay-vnc-egl-headless.x86_64-latest.args | 6 +- ...ostdev-mdev-display-vnc.x86_64-latest.args | 6 +- .../hostdev-scsi-lsi.x86_64-latest.args | 18 +- ...ostdev-scsi-virtio-scsi.x86_64-latest.args | 18 +- .../hugepages-memaccess3.x86_64-latest.args | 11 +- .../hugepages-nvdimm.x86_64-latest.args | 14 +- .../hyperv-off.x86_64-latest.args | 6 +- .../hyperv-panic.x86_64-latest.args | 6 +- .../hyperv-stimer-direct.x86_64-latest.args | 6 +- .../hyperv.x86_64-latest.args | 6 +- .../intel-iommu-aw-bits.x86_64-latest.args | 6 +- ...ntel-iommu-caching-mode.x86_64-latest.args | 6 +- ...ntel-iommu-device-iotlb.x86_64-latest.args | 6 +- .../intel-iommu-eim.x86_64-latest.args | 6 +- .../intel-iommu.x86_64-latest.args | 6 +- ...othreads-virtio-scsi-pci.x86_64-5.2.0.args | 57 + ...threads-virtio-scsi-pci.x86_64-latest.args | 10 +- .../kvmclock+eoi-disabled.x86_64-latest.args | 6 +- .../luks-disks-source-qcow2.x86_64-5.2.0.args | 112 + ...luks-disks-source-qcow2.x86_64-latest.args | 54 +- ...memory-default-hugepage.x86_64-latest.args | 9 +- .../memfd-memory-numa.x86_64-latest.args | 9 +- ...y-hotplug-nvdimm-access.x86_64-latest.args | 10 +- ...ory-hotplug-nvdimm-align.x86_64-5.2.0.args | 44 + ...ry-hotplug-nvdimm-align.x86_64-latest.args | 11 +- ...ory-hotplug-nvdimm-label.x86_64-5.2.0.args | 44 + ...ry-hotplug-nvdimm-label.x86_64-latest.args | 10 +- ...mory-hotplug-nvdimm-pmem.x86_64-5.2.0.args | 44 + ...ory-hotplug-nvdimm-pmem.x86_64-latest.args | 10 +- ...-hotplug-nvdimm-readonly.x86_64-5.2.0.args | 44 + ...hotplug-nvdimm-readonly.x86_64-latest.args | 10 +- .../memory-hotplug-nvdimm.x86_64-latest.args | 10 +- ...mory-hotplug-virtio-pmem.x86_64-5.2.0.args | 45 + ...ory-hotplug-virtio-pmem.x86_64-latest.args | 10 +- .../mlock-off.x86_64-latest.args | 6 +- .../mlock-on.x86_64-latest.args | 6 +- .../net-vdpa.x86_64-latest.args | 6 +- .../net-vhostuser.x86_64-latest.args | 6 +- .../numatune-hmat.x86_64-latest.args | 16 +- .../numatune-memnode.x86_64-5.2.0.args | 43 + .../numatune-memnode.x86_64-latest.args | 43 + .../os-firmware-bios.x86_64-latest.args | 6 +- ...os-firmware-efi-secboot.x86_64-latest.args | 6 +- .../os-firmware-efi.x86_64-latest.args | 6 +- .../parallel-unix-chardev.x86_64-latest.args | 6 +- ...cie-root-port-nohotplug.x86_64-latest.args | 6 +- .../pv-spinlock-disabled.x86_64-latest.args | 6 +- .../pv-spinlock-enabled.x86_64-latest.args | 6 +- .../qemu-ns.x86_64-latest.args | 6 +- .../serial-unix-chardev.x86_64-latest.args | 6 +- ...rtcard-passthrough-unix.x86_64-latest.args | 6 +- .../tpm-emulator-tpm2-enc.x86_64-latest.args | 6 +- ...pm-emulator-tpm2-pstate.x86_64-latest.args | 6 +- .../tpm-emulator-tpm2.x86_64-latest.args | 6 +- .../tpm-emulator.x86_64-latest.args | 6 +- .../tpm-passthrough-crb.x86_64-latest.args | 6 +- .../tpm-passthrough.x86_64-latest.args | 6 +- .../tseg-explicit-size.x86_64-latest.args | 6 +- .../usb-redir-unix.x86_64-latest.args | 6 +- ...vhost-user-fs-fd-memory.x86_64-latest.args | 10 +- ...vhost-user-fs-hugepages.x86_64-latest.args | 10 +- ...host-user-gpu-secondary.x86_64-latest.args | 7 +- .../vhost-user-vga.x86_64-latest.args | 7 +- .../vhost-vsock-auto.x86_64-latest.args | 6 +- .../vhost-vsock.x86_64-latest.args | 6 +- ...eo-bochs-display-device.x86_64-latest.args | 6 +- ...video-qxl-device-vram64.x86_64-latest.args | 6 +- ...o-qxl-sec-device-vram64.x86_64-latest.args | 6 +- ...eo-ramfb-display-device.x86_64-latest.args | 6 +- .../virtio-9p-createmode.x86_64-latest.args | 6 +- .../virtio-9p-multidevs.x86_64-latest.args | 6 +- ...virtio-non-transitional.x86_64-latest.args | 8 +- ...-options-controller-ats.x86_64-latest.args | 6 +- ...ptions-controller-iommu.x86_64-latest.args | 6 +- ...tions-controller-packed.x86_64-latest.args | 6 +- ...virtio-options-disk-ats.x86_64-latest.args | 6 +- ...rtio-options-disk-iommu.x86_64-latest.args | 6 +- ...tio-options-disk-packed.x86_64-latest.args | 6 +- .../virtio-options-fs-ats.x86_64-latest.args | 6 +- ...virtio-options-fs-iommu.x86_64-latest.args | 6 +- ...irtio-options-fs-packed.x86_64-latest.args | 6 +- ...irtio-options-input-ats.x86_64-latest.args | 6 +- ...tio-options-input-iommu.x86_64-latest.args | 6 +- ...io-options-input-packed.x86_64-latest.args | 6 +- ...-options-memballoon-ats.x86_64-latest.args | 6 +- ...loon-freepage-reporting.x86_64-latest.args | 6 +- ...ptions-memballoon-iommu.x86_64-latest.args | 6 +- ...tions-memballoon-packed.x86_64-latest.args | 6 +- .../virtio-options-net-ats.x86_64-latest.args | 6 +- ...irtio-options-net-iommu.x86_64-latest.args | 6 +- ...rtio-options-net-packed.x86_64-latest.args | 6 +- .../virtio-options-rng-ats.x86_64-latest.args | 10 +- ...irtio-options-rng-iommu.x86_64-latest.args | 10 +- ...rtio-options-rng-packed.x86_64-latest.args | 10 +- ...irtio-options-video-ats.x86_64-latest.args | 6 +- ...tio-options-video-iommu.x86_64-latest.args | 6 +- ...io-options-video-packed.x86_64-latest.args | 6 +- .../virtio-options.x86_64-latest.args | 8 +- .../virtio-rng-builtin.x86_64-5.2.0.args | 38 + .../virtio-rng-builtin.x86_64-latest.args | 8 +- .../virtio-rng-egd-unix.x86_64-5.2.0.args | 39 + .../virtio-rng-egd-unix.x86_64-latest.args | 8 +- .../virtio-transitional.x86_64-latest.args | 8 +- ...-default-cpu-kvm-pc-4.2.x86_64-latest.args | 6 +- ...default-cpu-kvm-q35-4.2.x86_64-latest.args | 6 +- ...-default-cpu-tcg-pc-4.2.x86_64-latest.args | 6 +- ...default-cpu-tcg-q35-4.2.x86_64-latest.args | 6 +- .../x86_64-pc-graphics.x86_64-latest.args | 8 +- .../x86_64-pc-headless.x86_64-latest.args | 8 +- .../x86_64-q35-graphics.x86_64-latest.args | 8 +- .../x86_64-q35-headless.x86_64-latest.args | 8 +- tests/qemuxml2argvtest.c | 32 + 223 files changed, 4071 insertions(+), 1781 deletions(-) create mode 100644 tests/qemuxml2argvdata/disk-network-tlsx509-nbd.x86_64-5.2.0.args delete mode 100644 tests/qemuxml2argvdata/disk-network-tlsx509.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/disk-virtio-scsi-reservations.x86_64-5.2.0.args create mode 100644 tests/qemuxml2argvdata/graphics-vnc-tls-secret.x86_64-5.2.0.args create mode 100644 tests/qemuxml2argvdata/iothreads-virtio-scsi-pci.x86_64-5.2.0.args create mode 100644 tests/qemuxml2argvdata/luks-disks-source-qcow2.x86_64-5.2.0.args create mode 100644 tests/qemuxml2argvdata/memory-hotplug-nvdimm-align.x86_64-5.2.0.args create mode 100644 tests/qemuxml2argvdata/memory-hotplug-nvdimm-label.x86_64-5.2.0.args create mode 100644 tests/qemuxml2argvdata/memory-hotplug-nvdimm-pmem.x86_64-5.2.0.args create mode 100644 tests/qemuxml2argvdata/memory-hotplug-nvdimm-readonly.x86_64-5.2.0.args create mode 100644 tests/qemuxml2argvdata/memory-hotplug-virtio-pmem.x86_64-5.2.0.args create mode 100644 tests/qemuxml2argvdata/numatune-memnode.x86_64-5.2.0.args create mode 100644 tests/qemuxml2argvdata/numatune-memnode.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/virtio-rng-builtin.x86_64-5.2.0.args create mode 100644 tests/qemuxml2argvdata/virtio-rng-egd-unix.x86_64-5.2.0.args -- 2.29.2

1 13

[PATCH 0/4] Couple of qemu:///embed related fixes
by Michal Privoznik 12 Mar '21

12 Mar '21

*** BLURB HERE *** Michal Prívozník (4): qemu_shim: Don't hang if failed to start domain docs: Lift restriction on running API from the event loop thread virConnectOpen: Require root dir to be absolute path qemu_shim: Always pre-create root dir docs/drvqemu.html.in | 8 ++++++-- src/libvirt.c | 6 ++++++ src/qemu/qemu_shim.c | 20 ++++++++++++++------ 3 files changed, 26 insertions(+), 8 deletions(-) -- 2.26.2

3 13

[PATCH 0/2] Fix exec-restart of virtlogd and virtlockd
by Peter Krempa 12 Mar '21

12 Mar '21

Peter Krempa (2): virnetdaemon: Introduce virNetDaemonQuitExecRestart virtlo(g|ck)d: Fix exec-restart src/libvirt_remote.syms | 1 + src/locking/lock_daemon.c | 2 +- src/logging/log_daemon.c | 2 +- src/rpc/virnetdaemon.c | 19 +++++++++++++++++++ src/rpc/virnetdaemon.h | 1 + 5 files changed, 23 insertions(+), 2 deletions(-) -- 2.29.2

3 9

[PATCH v2] qemu_shim: Don't hang if failed to start domain
by Michal Privoznik 12 Mar '21

12 Mar '21

The qemu shim spawns a separate thread in which the event loop is ran. The virEventRunDefaultImpl() call is wrapped in a while() loop, just like it should. There are few lines of code around which try to ensure that domain is destroyed (when quitting) and that the last round of event loop is ran after the virDomainDestroy() call. Only after that the loop is quit from and the thread quits. However, if domain creation fails, there is no @dom to call destroy over, the @quit flag is never set and while() never exits. Set the flag regardless of @dom pointer. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1920337 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- v2 of: https://listman.redhat.com/archives/libvir-list/2021-March/msg00011.html Thanks to Andrea who made me realize that this can be written better. diff to v1: - Instead of exiting from while() early, let the event loop run another iteration (it should be no-op anyway). src/qemu/qemu_shim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_shim.c b/src/qemu/qemu_shim.c index d85497bd3a..8b3afd0324 100644 --- a/src/qemu/qemu_shim.c +++ b/src/qemu/qemu_shim.c @@ -45,9 +45,9 @@ qemuShimEventLoop(void *opaque G_GNUC_UNUSED) while (!quit) { g_mutex_lock(&eventLock); if (eventQuitFlag && !eventPreventQuitFlag) { + quit = true; if (dom) { virDomainDestroy(dom); - quit = true; } } g_mutex_unlock(&eventLock); -- 2.26.2

1 0

[PATCH] virConfLoadConfig: Refactor cleanup
by Yi Li 12 Mar '21

12 Mar '21

Switch to using the 'g_auto*' helpers. Signed-off-by: Yi Li <yili(a)winhong.com> --- src/util/virconf.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/src/util/virconf.c b/src/util/virconf.c index 16107bce96..11046a1d45 100644 --- a/src/util/virconf.c +++ b/src/util/virconf.c @@ -1505,26 +1505,19 @@ virConfLoadConfigPath(const char *name) int virConfLoadConfig(virConfPtr *conf, const char *name) { - char *path = NULL; - int ret = -1; + g_autofree char *path = NULL; *conf = NULL; if (!(path = virConfLoadConfigPath(name))) - goto cleanup; + return -1; - if (!virFileExists(path)) { - ret = 0; - goto cleanup; - } + if (!virFileExists(path)) + return 0; VIR_DEBUG("Loading config file '%s'", path); if (!(*conf = virConfReadFile(path, 0))) - goto cleanup; - - ret = 0; + return -1; - cleanup: - VIR_FREE(path); - return ret; + return 0; } -- 2.25.3

2 3

[PATCH 0/2] virlockspace: Fix two more crashes of virtlockd on the exec-restart code path
by Peter Krempa 12 Mar '21

12 Mar '21

Peter Krempa (2): virLockSpacePreExecRestart: Avoid use-after-free virLockSpaceNewPostExecRestart: Fix out-of-bounds array access src/util/virlockspace.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) -- 2.29.2

2 3

[PATCH v2] xenParseVif: Refactor parser
by Peter Krempa 12 Mar '21

12 Mar '21

Use g_strsplit to split the string and avoid use of stack'd strings. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/libxl/xen_common.c | 130 +++++++++++++---------------------------- 1 file changed, 39 insertions(+), 91 deletions(-) v2: - helper variables are made const and strings are borrowed from the array returned by g_strsplit instead of copying/freeing - second argument of xenParseVifBridge turned const to silence compiler diff --git a/src/libxl/xen_common.c b/src/libxl/xen_common.c index c56815d7fc..0d3a3f994a 100644 --- a/src/libxl/xen_common.c +++ b/src/libxl/xen_common.c @@ -1027,7 +1027,7 @@ xenParseCharDev(virConfPtr conf, virDomainDefPtr def, const char *nativeFormat) static int -xenParseVifBridge(virDomainNetDefPtr net, char *bridge) +xenParseVifBridge(virDomainNetDefPtr net, const char *bridge) { char *vlanstr; unsigned int tag; @@ -1141,104 +1141,53 @@ xenParseVif(char *entry, const char *vif_typename) { virDomainNetDefPtr net = NULL; virDomainNetDefPtr ret = NULL; - char *script = NULL; - char model[10]; - char type[10]; - char ip[128]; - char mac[18]; - char bridge[50]; - char vifname[50]; - char rate[50]; - char *key; - - bridge[0] = '\0'; - mac[0] = '\0'; - ip[0] = '\0'; - model[0] = '\0'; - type[0] = '\0'; - vifname[0] = '\0'; - rate[0] = '\0'; - - key = entry; - while (key) { - char *data; - char *nextkey = strchr(key, ','); - - if (!(data = strchr(key, '='))) + g_auto(GStrv) keyvals = NULL; + GStrv keyval; + const char *script = NULL; + const char *model = NULL; + const char *type = NULL; + const char *ip = NULL; + const char *mac = NULL; + const char *bridge = NULL; + const char *vifname = NULL; + const char *rate = NULL; + + keyvals = g_strsplit(entry, ",", 0); + + for (keyval = keyvals; keyval && *keyval; keyval++) { + const char *key = *keyval; + char *val = strchr(key, '='); + + virSkipSpaces(&key); + + if (!val) return NULL; - data++; + + val++; if (STRPREFIX(key, "mac=")) { - int len = nextkey ? (nextkey - data) : strlen(data); - if (virStrncpy(mac, data, len, sizeof(mac)) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("MAC address %s too big for destination"), - data); - return NULL; - } + mac = val; } else if (STRPREFIX(key, "bridge=")) { - int len = nextkey ? (nextkey - data) : strlen(data); - if (virStrncpy(bridge, data, len, sizeof(bridge)) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Bridge %s too big for destination"), - data); - return NULL; - } + bridge = val; } else if (STRPREFIX(key, "script=")) { - int len = nextkey ? (nextkey - data) : strlen(data); - VIR_FREE(script); - script = g_strndup(data, len); + script = val; } else if (STRPREFIX(key, "model=")) { - int len = nextkey ? (nextkey - data) : strlen(data); - if (virStrncpy(model, data, len, sizeof(model)) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Model %s too big for destination"), - data); - return NULL; - } + model = val; } else if (STRPREFIX(key, "type=")) { - int len = nextkey ? (nextkey - data) : strlen(data); - if (virStrncpy(type, data, len, sizeof(type)) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Type %s too big for destination"), - data); - return NULL; - } + type = val; } else if (STRPREFIX(key, "vifname=")) { - int len = nextkey ? (nextkey - data) : strlen(data); - if (virStrncpy(vifname, data, len, sizeof(vifname)) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Vifname %s too big for destination"), - data); - return NULL; - } + vifname = val; } else if (STRPREFIX(key, "ip=")) { - int len = nextkey ? (nextkey - data) : strlen(data); - if (virStrncpy(ip, data, len, sizeof(ip)) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("IP %s too big for destination"), data); - return NULL; - } + ip = val; } else if (STRPREFIX(key, "rate=")) { - int len = nextkey ? (nextkey - data) : strlen(data); - if (virStrncpy(rate, data, len, sizeof(rate)) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("rate %s too big for destination"), data); - return NULL; - } + rate = val; } - - while (nextkey && (nextkey[0] == ',' || - nextkey[0] == ' ' || - nextkey[0] == '\t')) - nextkey++; - key = nextkey; } if (!(net = virDomainNetDefNew(NULL))) goto cleanup; - if (mac[0]) { + if (mac) { if (virMacAddrParse(mac, &net->mac) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, _("malformed mac address '%s'"), mac); @@ -1246,18 +1195,18 @@ xenParseVif(char *entry, const char *vif_typename) } } - if (bridge[0] || STREQ_NULLABLE(script, "vif-bridge") || + if (bridge || STREQ_NULLABLE(script, "vif-bridge") || STREQ_NULLABLE(script, "vif-vnic")) { net->type = VIR_DOMAIN_NET_TYPE_BRIDGE; } else { net->type = VIR_DOMAIN_NET_TYPE_ETHERNET; } - if (net->type == VIR_DOMAIN_NET_TYPE_BRIDGE && bridge[0]) { + if (net->type == VIR_DOMAIN_NET_TYPE_BRIDGE && bridge) { if (xenParseVifBridge(net, bridge) < 0) goto cleanup; } - if (ip[0]) { + if (ip) { char **ip_list = g_strsplit(ip, " ", 0); size_t i; @@ -1276,18 +1225,18 @@ xenParseVif(char *entry, const char *vif_typename) if (script && script[0]) net->script = g_strdup(script); - if (model[0]) { + if (model) { if (virDomainNetSetModelString(net, model) < 0) goto cleanup; } else { - if (type[0] && STREQ(type, vif_typename)) + if (type && STREQ(type, vif_typename)) net->model = VIR_DOMAIN_NET_MODEL_NETFRONT; } - if (vifname[0]) + if (vifname && vifname[0]) net->ifname = g_strdup(vifname); - if (rate[0]) { + if (rate) { virNetDevBandwidthPtr bandwidth; unsigned long long kbytes_per_sec; @@ -1304,7 +1253,6 @@ xenParseVif(char *entry, const char *vif_typename) cleanup: virDomainNetDefFree(net); - VIR_FREE(script); return ret; } -- 2.29.2

2 1

Re: [PATCH 1/6] accel: Introduce 'query-accels' QMP command
by Thomas Huth 12 Mar '21

12 Mar '21

On 12/03/2021 08.42, Marc-André Lureau wrote: > > > On Fri, Mar 12, 2021 at 3:14 AM Philippe Mathieu-Daudé <philmd(a)redhat.com > <mailto:philmd@redhat.com>> wrote: > [...] > +## > +# @AcceleratorInfo: > +# > +# Accelerator information. > +# > +# @name: The accelerator name. > +# > +# Since: 6.0 > +## > +{ 'union': 'AcceleratorInfo', > + 'base': {'name': 'Accelerator'}, > + 'discriminator': 'name', > + 'data': { } } > > + > > > Making room for future details, why not. I think we definitely need the additional data section here: For KVM on POWER, it would be good to know whether it's KVM-HV or KVM-PR, for KVM on MIPS it would be good to know whether it's KVM_VM_MIPS_VZ or KVM_VM_MIPS_TE, for KVM on x86 whether it's the AMD flavor or Intel, ... > +## > +# @query-accels: > +# > +# Get a list of AcceleratorInfo for all built-in accelerators. > +# > +# Returns: a list of @AcceleratorInfo describing each accelerator. > +# > +# Since: 6.0 > +# > +# Example: > +# > +# -> { "execute": "query-accels" } > +# <- { "return": [ > +# { > +# "type": "qtest" > +# }, > +# { > +# "type": "kvm" > +# } > +# ] } > +# > +## > +{ 'command': 'query-accels', > + 'returns': ['AcceleratorInfo'] } > > > That's nice, but how do you know which accels are actually enabled? I guess we need two commands in the end, one for querying which accelerators are available, and one for querying the data from the currently active accelerator...? Thomas

4 6

[PATCH 0/5] Document lxc.conf and libxl.conf locations
by Michal Privoznik 12 Mar '21

12 Mar '21

This is a continuation of effort started here, where I documented qemu.conf location: https://listman.redhat.com/archives/libvir-list/2021-March/msg00276.html Michal Prívozník (5): docs: Capitalize QEMU driver reference manpages: Remove reference to a session daemon for LXC docs: Document lxc.conf location manpages: Remove reference to a session daemon for libxl docs: Document libxl.conf location docs/drvlxc.html.in | 10 ++++++++++ docs/drvxen.html.in | 11 +++++++++++ docs/manpages/libvirtd.rst | 17 ++++++++++------- docs/manpages/virtlxcd.rst | 38 +++++++++++-------------------------- docs/manpages/virtqemud.rst | 2 +- docs/manpages/virtxend.rst | 38 +++++++++++-------------------------- 6 files changed, 54 insertions(+), 62 deletions(-) -- 2.26.2

2 6

[libvirt PATCH 00/18] qemu: add support for audio backend configuration
by Daniel P. Berrangé 12 Mar '21

12 Mar '21

Historically we've done almost nothing with audio backend configuration. In QEMU we merely set QEMU_AUDIO_DRV to one of sdl, spice, none depending on <graphics>. We also have the somewhat crazy ability to let QEMU inherit the QEMU_AUDIO_DRV env variable from libvirtd. Fairly recently BHyve wanted audio backend config for OSS so introduced the <audio> element. We designed that to allow QEMU to later extend it, and that's what this series does. We add <audio> types for all the QEMU backends, except the Windows only DSound which isn't relevant for libvirt. The QEMU driver is updated to use this element to configure things. QEMU has many many many more env variables for configuring audio settings, which we can now support. These are all deprecated since 4.0.0 though, so we also add support for the new -audiodev argument. Unfortunately -audiodev isn't introspectable due to limits in QEMU fixed by: https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg00653.html The lack of introspection isn't critical though. We can detect existance of -audiodev by querying for '-vnc audiodev=3DNNN' argument support. We simply lack ability to determine what QEMU audio backends are compiled in. This means we have to delegate error reporting to QEMU itself, which is OK. We'll make use of the query-audiodev command at a later date to track future improvements to QEMU audiodev backends. Daniel P. Berrang=C3=A9 (18): config: cleanup some typos / baggage wrt compiler checks conf: stronger error reporting when parsing audio related params conf: don't force existance of audio child elements conf: add helper to test for sound device codec support conf: add missing iteration over audio backends conf: refactor OSS audio backend specific options conf: add coverage for all QEMU audio backend types conf: add support for audio backend for the VNC server conf: add validation of audio backend IDs conf: rename and improve virDomainDefFindAudioForSound qemu: support use of <audio> elements qemu: populate <audio> element with default config qemu: probe for -vnc audiodev property qemu: add support for generating -audiodev arguments conf: introduce support for common audio settings qemu: wire up support for common audio backend settings conf: add support for audio backend specific settings qemu: wire up support for backend specific audio settings config.h | 10 +- docs/formatdomain.rst | 322 +++++++- docs/schemas/domaincommon.rng | 384 +++++++++- src/bhyve/bhyve_command.c | 30 +- src/conf/domain_conf.c | 693 +++++++++++++++++- src/conf/domain_conf.h | 125 +++- src/conf/domain_validate.c | 67 +- src/libvirt_private.syms | 8 +- src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_command.c | 484 +++++++++++- src/qemu/qemu_domain.c | 110 ++- src/qemu/qemu_validate.c | 136 +++- .../caps_4.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 + .../caps_4.2.0.x86_64.xml | 1 + .../caps_5.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 + .../caps_5.0.0.riscv64.xml | 1 + .../caps_5.0.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_5.1.0.sparc.xml | 1 + .../caps_5.1.0.x86_64.xml | 1 + .../caps_5.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 1 + .../caps_5.2.0.riscv64.xml | 1 + .../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 1 + .../caps_5.2.0.x86_64.xml | 1 + .../caps_6.0.0.x86_64.xml | 1 + .../redefine.xml | 1 + .../disk_snapshot_redefine.xml | 1 + .../external_vm_redefine.xml | 1 + .../full_domain.xml | 1 + .../qemudomainsnapshotxml2xmlout/metadata.xml | 1 + .../ppc64-modern-bulk-result-conf.xml | 1 + .../ppc64-modern-bulk-result-live.xml | 1 + .../ppc64-modern-individual-result-conf.xml | 1 + .../ppc64-modern-individual-result-live.xml | 1 + .../x86-modern-bulk-result-conf.xml | 1 + .../x86-modern-bulk-result-live.xml | 1 + .../x86-modern-individual-add-result-conf.xml | 1 + .../x86-modern-individual-add-result-live.xml | 1 + .../x86-old-bulk-result-conf.xml | 1 + .../x86-old-bulk-result-live.xml | 1 + .../qemuhotplug-base-ccw-live+ccw-virtio.xml | 1 + ...with-2-ccw-virtio+ccw-virtio-1-reverse.xml | 1 + ...otplug-base-ccw-live-with-2-ccw-virtio.xml | 1 + ...-with-ccw-virtio+ccw-virtio-2-explicit.xml | 1 + ...-ccw-live-with-ccw-virtio+ccw-virtio-2.xml | 1 + ...uhotplug-base-ccw-live-with-ccw-virtio.xml | 1 + .../qemuhotplug-base-ccw-live.xml | 1 + ...uhotplug-base-live+disk-scsi-multipath.xml | 1 + ...+disk-scsi-wwn+disk-scsi-duplicate-wwn.xml | 1 + .../qemuhotplug-base-live+disk-scsi.xml | 1 + .../qemuhotplug-base-live+disk-usb.xml | 1 + .../qemuhotplug-base-live+disk-virtio.xml | 1 + .../qemuhotplug-base-live+guestfwd.xml | 1 + .../qemuhotplug-base-live+hostdev-pci.xml | 1 + .../qemuhotplug-base-live+interface-vdpa.xml | 1 + ...qemuhotplug-base-live+ivshmem-doorbell.xml | 1 + .../qemuhotplug-base-live+ivshmem-plain.xml | 1 + .../qemuhotplug-base-live+qemu-agent.xml | 1 + ...uhotplug-base-live+watchdog-user-alias.xml | 1 + .../qemuhotplug-base-live+watchdog.xml | 1 + .../qemuhotplug-base-live.xml | 1 + ...hotplug-base-with-scsi-controller-live.xml | 1 + ...thout-scsi-controller-live+disk-scsi-2.xml | 1 + ...g-console-compat-2-live+console-virtio.xml | 1 + .../qemuhotplug-console-compat-2-live.xml | 1 + ...uhotplug-pseries-base-live+hostdev-pci.xml | 1 + .../qemuhotplug-pseries-base-live.xml | 1 + .../full-xml2xml-out.xml | 1 + .../qemustatusxml2xmldata/backup-pull-in.xml | 1 + .../blockjob-blockdev-in.xml | 1 + .../blockjob-mirror-in.xml | 1 + .../migration-in-params-in.xml | 1 + .../migration-out-nbd-bitmaps-in.xml | 1 + .../migration-out-nbd-out.xml | 1 + .../migration-out-nbd-tls-out.xml | 1 + .../migration-out-params-in.xml | 1 + tests/qemustatusxml2xmldata/modern-in.xml | 1 + tests/qemustatusxml2xmldata/upgrade-out.xml | 1 + .../qemustatusxml2xmldata/vcpus-multi-in.xml | 1 + ...fault-cpu-kvm-virt-4.2.aarch64-latest.args | 2 +- ...fault-cpu-tcg-virt-4.2.aarch64-latest.args | 2 +- .../aarch64-features-sve.aarch64-latest.args | 2 +- tests/qemuxml2argvdata/aarch64-gic-host.xml | 1 + tests/qemuxml2argvdata/aarch64-gic-v2.xml | 1 + tests/qemuxml2argvdata/aarch64-gic-v3.xml | 1 + ...arch64-os-firmware-efi.aarch64-latest.args | 2 +- .../aarch64-tpm.aarch64-latest.args | 2 +- .../aarch64-virt-graphics.aarch64-latest.args | 4 +- .../aarch64-virt-headless.aarch64-latest.args | 2 +- tests/qemuxml2argvdata/audio-alsa-best.args | 41 ++ .../audio-alsa-best.x86_64-latest.args | 42 ++ tests/qemuxml2argvdata/audio-alsa-best.xml | 43 ++ tests/qemuxml2argvdata/audio-alsa-full.args | 29 + tests/qemuxml2argvdata/audio-alsa-full.err | 1 + .../audio-alsa-full.x86_64-latest.args | 43 ++ tests/qemuxml2argvdata/audio-alsa-full.xml | 43 ++ .../qemuxml2argvdata/audio-alsa-minimal.args | 29 + .../audio-alsa-minimal.x86_64-latest.args | 39 + tests/qemuxml2argvdata/audio-alsa-minimal.xml | 36 + .../audio-coreaudio-best.args | 41 ++ .../audio-coreaudio-best.x86_64-latest.args | 42 ++ .../qemuxml2argvdata/audio-coreaudio-best.xml | 43 ++ .../audio-coreaudio-full.args | 29 + .../qemuxml2argvdata/audio-coreaudio-full.err | 1 + .../audio-coreaudio-full.x86_64-latest.args | 43 ++ .../qemuxml2argvdata/audio-coreaudio-full.xml | 43 ++ .../audio-coreaudio-minimal.args | 29 + ...audio-coreaudio-minimal.x86_64-latest.args | 39 + .../audio-coreaudio-minimal.xml | 36 + .../audio-default-nographics.args | 29 + ...udio-default-nographics.x86_64-latest.args | 39 + .../audio-default-nographics.xml | 31 + tests/qemuxml2argvdata/audio-default-sdl.args | 31 + .../audio-default-sdl.x86_64-latest.args | 41 ++ tests/qemuxml2argvdata/audio-default-sdl.xml | 35 + .../qemuxml2argvdata/audio-default-spice.args | 30 + .../audio-default-spice.x86_64-latest.args | 40 + .../qemuxml2argvdata/audio-default-spice.xml | 35 + tests/qemuxml2argvdata/audio-default-vnc.args | 30 + .../audio-default-vnc.x86_64-latest.args | 40 + tests/qemuxml2argvdata/audio-default-vnc.xml | 35 + tests/qemuxml2argvdata/audio-file-best.args | 40 + .../audio-file-best.x86_64-latest.args | 42 ++ tests/qemuxml2argvdata/audio-file-best.xml | 43 ++ tests/qemuxml2argvdata/audio-file-full.args | 29 + tests/qemuxml2argvdata/audio-file-full.err | 1 + .../audio-file-full.x86_64-latest.args | 43 ++ tests/qemuxml2argvdata/audio-file-full.xml | 43 ++ .../qemuxml2argvdata/audio-file-minimal.args | 29 + .../audio-file-minimal.x86_64-latest.args | 39 + tests/qemuxml2argvdata/audio-file-minimal.xml | 36 + tests/qemuxml2argvdata/audio-jack-full.err | 1 + .../audio-jack-full.x86_64-latest.args | 44 ++ tests/qemuxml2argvdata/audio-jack-full.xml | 43 ++ tests/qemuxml2argvdata/audio-jack-minimal.err | 1 + .../audio-jack-minimal.x86_64-latest.args | 39 + tests/qemuxml2argvdata/audio-jack-minimal.xml | 36 + .../qemuxml2argvdata/audio-many-backends.err | 1 + .../audio-many-backends.x86_64-latest.args | 46 ++ .../qemuxml2argvdata/audio-many-backends.xml | 60 ++ tests/qemuxml2argvdata/audio-none-best.args | 39 + .../audio-none-best.x86_64-latest.args | 42 ++ tests/qemuxml2argvdata/audio-none-best.xml | 43 ++ tests/qemuxml2argvdata/audio-none-full.args | 29 + tests/qemuxml2argvdata/audio-none-full.err | 1 + .../audio-none-full.x86_64-latest.args | 42 ++ tests/qemuxml2argvdata/audio-none-full.xml | 43 ++ .../qemuxml2argvdata/audio-none-minimal.args | 29 + .../audio-none-minimal.x86_64-latest.args | 39 + tests/qemuxml2argvdata/audio-none-minimal.xml | 36 + tests/qemuxml2argvdata/audio-oss-best.args | 44 ++ .../audio-oss-best.x86_64-latest.args | 43 ++ tests/qemuxml2argvdata/audio-oss-best.xml | 43 ++ tests/qemuxml2argvdata/audio-oss-full.args | 31 + tests/qemuxml2argvdata/audio-oss-full.err | 1 + .../audio-oss-full.x86_64-latest.args | 44 ++ tests/qemuxml2argvdata/audio-oss-full.xml | 43 ++ tests/qemuxml2argvdata/audio-oss-minimal.args | 29 + .../audio-oss-minimal.x86_64-latest.args | 39 + tests/qemuxml2argvdata/audio-oss-minimal.xml | 36 + .../audio-pulseaudio-best.args | 43 ++ .../audio-pulseaudio-best.x86_64-latest.args | 43 ++ .../audio-pulseaudio-best.xml | 43 ++ .../audio-pulseaudio-full.args | 29 + .../audio-pulseaudio-full.err | 1 + .../audio-pulseaudio-full.x86_64-latest.args | 44 ++ .../audio-pulseaudio-full.xml | 43 ++ .../audio-pulseaudio-minimal.args | 29 + ...udio-pulseaudio-minimal.x86_64-latest.args | 39 + .../audio-pulseaudio-minimal.xml | 36 + tests/qemuxml2argvdata/audio-sdl-best.args | 41 ++ .../audio-sdl-best.x86_64-latest.args | 43 ++ tests/qemuxml2argvdata/audio-sdl-best.xml | 43 ++ tests/qemuxml2argvdata/audio-sdl-full.args | 30 + tests/qemuxml2argvdata/audio-sdl-full.err | 1 + .../audio-sdl-full.x86_64-latest.args | 44 ++ tests/qemuxml2argvdata/audio-sdl-full.xml | 43 ++ tests/qemuxml2argvdata/audio-sdl-minimal.args | 29 + .../audio-sdl-minimal.x86_64-latest.args | 39 + tests/qemuxml2argvdata/audio-sdl-minimal.xml | 36 + tests/qemuxml2argvdata/audio-spice-best.args | 39 + .../audio-spice-best.x86_64-latest.args | 42 ++ tests/qemuxml2argvdata/audio-spice-best.xml | 43 ++ tests/qemuxml2argvdata/audio-spice-full.args | 29 + tests/qemuxml2argvdata/audio-spice-full.err | 1 + .../audio-spice-full.x86_64-latest.args | 42 ++ tests/qemuxml2argvdata/audio-spice-full.xml | 43 ++ .../qemuxml2argvdata/audio-spice-minimal.args | 29 + .../audio-spice-minimal.x86_64-latest.args | 39 + .../qemuxml2argvdata/audio-spice-minimal.xml | 36 + .../blkdeviotune-group-num.x86_64-latest.args | 2 +- .../blkdeviotune-group-num.xml | 1 + ...blkdeviotune-max-length.x86_64-latest.args | 2 +- .../blkdeviotune-max-length.xml | 1 + .../blkdeviotune-max.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/blkdeviotune-max.xml | 1 + tests/qemuxml2argvdata/boot-floppy-q35.xml | 1 + .../channel-unix-guestfwd.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/clock-france.args | 2 +- tests/qemuxml2argvdata/clock-realtime.xml | 1 + .../clock-timer-armvtimer.aarch64-latest.args | 2 +- .../clock-timer-armvtimer.xml | 1 + .../console-virtio-unix.x86_64-latest.args | 2 +- .../controller-virtio-scsi.x86_64-latest.args | 2 +- ...-Icelake-Server-pconfig.x86_64-latest.args | 2 +- .../cpu-translation.x86_64-latest.args | 2 +- .../cpu-tsc-high-frequency.x86_64-latest.args | 2 +- .../cputune-cpuset-big-id.x86_64-latest.args | 2 +- ...ult-video-type-aarch64.aarch64-latest.args | 4 +- ...default-video-type-ppc64.ppc64-latest.args | 4 +- ...ult-video-type-riscv64.riscv64-latest.args | 2 +- ...default-video-type-s390x.s390x-latest.args | 4 +- .../disk-aio-io_uring.x86_64-latest.args | 2 +- .../disk-aio.x86_64-latest.args | 2 +- .../disk-arm-virtio-sd.aarch64-latest.args | 2 +- ...-backing-chains-noindex.x86_64-latest.args | 2 +- .../disk-cache.x86_64-latest.args | 2 +- .../disk-cdrom-bus-other.x86_64-latest.args | 2 +- ...m-empty-network-invalid.x86_64-latest.args | 2 +- .../disk-cdrom-network.x86_64-latest.args | 2 +- .../disk-cdrom-tray.x86_64-latest.args | 2 +- .../disk-cdrom.x86_64-latest.args | 2 +- .../disk-copy_on_read.x86_64-latest.args | 2 +- .../disk-detect-zeroes.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-detect-zeroes.xml | 1 + .../disk-discard.x86_64-latest.args | 2 +- .../disk-error-policy-s390x.s390x-latest.args | 2 +- .../disk-error-policy.x86_64-latest.args | 2 +- .../disk-floppy-q35-2_11.x86_64-latest.args | 2 +- .../disk-floppy-q35-2_9.x86_64-latest.args | 2 +- .../disk-floppy.x86_64-latest.args | 2 +- .../disk-metadata-cache.x86_64-latest.args | 2 +- .../disk-network-gluster.x86_64-latest.args | 2 +- .../disk-network-http.x86_64-latest.args | 2 +- .../disk-network-iscsi.x86_64-latest.args | 2 +- .../disk-network-nbd.x86_64-latest.args | 2 +- .../disk-network-nfs.x86_64-latest.args | 2 +- .../disk-network-rbd.x86_64-latest.args | 2 +- .../disk-network-sheepdog.x86_64-latest.args | 2 +- ...isk-network-source-auth.x86_64-latest.args | 2 +- ...isk-network-tlsx509-nbd.x86_64-latest.args | 2 +- ...isk-network-tlsx509-vxhs.x86_64-5.0.0.args | 2 +- .../disk-nvme.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-nvme.xml | 1 + .../disk-readonly-disk.x86_64-latest.args | 2 +- .../disk-scsi-device-auto.x86_64-latest.args | 2 +- .../disk-scsi.x86_64-latest.args | 2 +- .../disk-shared.x86_64-latest.args | 2 +- .../disk-slices.x86_64-latest.args | 2 +- .../disk-transient.x86_64-latest.args | 2 +- .../disk-vhostuser.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-virtio-queues.xml | 1 + ...irtio-scsi-reservations.x86_64-latest.args | 2 +- .../disk-virtio-scsi-reservations.xml | 1 + tests/qemuxml2argvdata/downscript.xml | 1 + .../qemuxml2argvdata/encrypted-disk-usage.xml | 1 + .../eoi-disabled.x86_64-latest.args | 2 +- .../eoi-enabled.x86_64-latest.args | 2 +- .../fd-memory-no-numa-topology.xml | 1 + .../fd-memory-numa-topology.xml | 1 + .../fd-memory-numa-topology2.xml | 1 + .../fd-memory-numa-topology3.xml | 1 + .../fips-enabled.x86_64-5.1.0.args | 2 +- .../fips-enabled.x86_64-latest.args | 2 +- .../floppy-drive-fat.x86_64-latest.args | 2 +- .../fs9p-ccw.s390x-latest.args | 2 +- .../qemuxml2argvdata/fs9p.x86_64-latest.args | 2 +- .../genid-auto.x86_64-latest.args | 2 +- .../qemuxml2argvdata/genid.x86_64-latest.args | 2 +- ...pice-gl-auto-rendernode.x86_64-latest.args | 2 +- .../qemuxml2argvdata/graphics-spice-sasl.args | 2 +- tests/qemuxml2argvdata/graphics-vnc-sasl.args | 2 +- ...graphics-vnc-tls-secret.x86_64-latest.args | 4 +- tests/qemuxml2argvdata/graphics-vnc-tls.args | 2 +- .../graphics-vnc-tls.x86_64-2.4.0.args | 2 +- .../graphics-vnc-tls.x86_64-latest.args | 4 +- ...tdev-mdev-display-ramfb.x86_64-latest.args | 4 +- ...play-spice-egl-headless.x86_64-latest.args | 2 +- ...ev-display-spice-opengl.x86_64-latest.args | 2 +- ...isplay-vnc-egl-headless.x86_64-latest.args | 4 +- ...ostdev-mdev-display-vnc.x86_64-latest.args | 4 +- .../hostdev-scsi-lsi.x86_64-latest.args | 2 +- ...ostdev-scsi-virtio-scsi.x86_64-latest.args | 2 +- ...tdev-subsys-mdev-vfio-ap.s390x-latest.args | 2 +- ...ubsys-mdev-vfio-ccw-boot.s390x-latest.args | 2 +- .../qemuxml2argvdata/hugepages-default-2M.xml | 1 + .../hugepages-default-system-size.xml | 1 + .../qemuxml2argvdata/hugepages-memaccess.xml | 1 + .../qemuxml2argvdata/hugepages-memaccess2.xml | 1 + .../hugepages-memaccess3.x86_64-latest.args | 2 +- .../hugepages-numa-default-dimm.xml | 1 + .../hugepages-nvdimm.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/hugepages-nvdimm.xml | 1 + .../hyperv-off.x86_64-latest.args | 2 +- .../hyperv-panic.x86_64-latest.args | 2 +- .../hyperv-stimer-direct.x86_64-latest.args | 2 +- .../hyperv.x86_64-latest.args | 2 +- .../intel-iommu-aw-bits.x86_64-latest.args | 2 +- .../qemuxml2argvdata/intel-iommu-aw-bits.xml | 1 + ...ntel-iommu-caching-mode.x86_64-latest.args | 2 +- .../intel-iommu-caching-mode.xml | 1 + ...ntel-iommu-device-iotlb.x86_64-latest.args | 2 +- .../intel-iommu-device-iotlb.xml | 1 + .../intel-iommu-eim.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/intel-iommu-eim.xml | 1 + .../intel-iommu.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/intel-iommu.xml | 1 + .../iommu-smmuv3.aarch64-latest.args | 2 +- ...othreads-virtio-scsi-ccw.s390x-latest.args | 2 +- ...threads-virtio-scsi-pci.x86_64-latest.args | 2 +- .../kvmclock+eoi-disabled.x86_64-latest.args | 2 +- ...luks-disks-source-qcow2.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/luks-disks.xml | 1 + ...memory-default-hugepage.x86_64-latest.args | 2 +- .../memfd-memory-default-hugepage.xml | 1 + .../memfd-memory-numa.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/memfd-memory-numa.xml | 1 + ...y-hotplug-nvdimm-access.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-access.xml | 1 + ...ry-hotplug-nvdimm-align.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-align.xml | 1 + ...ry-hotplug-nvdimm-label.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-label.xml | 1 + ...ory-hotplug-nvdimm-pmem.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-pmem.xml | 1 + ...hotplug-nvdimm-readonly.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-readonly.xml | 1 + .../memory-hotplug-nvdimm.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm.xml | 1 + .../memory-hotplug-ppc64-nonuma.xml | 1 + ...ory-hotplug-virtio-pmem.x86_64-latest.args | 2 +- .../memory-hotplug-virtio-pmem.xml | 1 + .../mlock-off.x86_64-latest.args | 2 +- .../mlock-on.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/net-user-addr.xml | 1 + .../net-vdpa.x86_64-latest.args | 2 +- .../net-vhostuser.x86_64-latest.args | 2 +- .../net-virtio-teaming-hostdev.xml | 1 + .../numatune-hmat.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/numatune-hmat.xml | 1 + tests/qemuxml2argvdata/numatune-no-vcpu.xml | 1 + .../os-firmware-bios.x86_64-latest.args | 2 +- ...os-firmware-efi-secboot.x86_64-latest.args | 2 +- .../os-firmware-efi.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/pages-dimm-discard.xml | 1 + .../pages-discard-hugepages.xml | 1 + tests/qemuxml2argvdata/pages-discard.xml | 1 + .../parallel-unix-chardev.x86_64-latest.args | 2 +- ...cie-root-port-nohotplug.x86_64-latest.args | 2 +- ...ault-cpu-kvm-pseries-2.7.ppc64-latest.args | 2 +- ...ault-cpu-kvm-pseries-3.1.ppc64-latest.args | 2 +- ...ault-cpu-kvm-pseries-4.2.ppc64-latest.args | 2 +- ...ault-cpu-tcg-pseries-2.7.ppc64-latest.args | 2 +- ...ault-cpu-tcg-pseries-3.1.ppc64-latest.args | 2 +- ...ault-cpu-tcg-pseries-4.2.ppc64-latest.args | 2 +- .../ppc64-pseries-graphics.ppc64-latest.args | 4 +- .../ppc64-pseries-headless.ppc64-latest.args | 2 +- .../ppc64-tpmproxy-single.ppc64-latest.args | 2 +- .../ppc64-tpmproxy-with-tpm.ppc64-latest.args | 2 +- .../pv-spinlock-disabled.x86_64-latest.args | 2 +- .../pv-spinlock-enabled.x86_64-latest.args | 2 +- .../qemu-ns.x86_64-latest.args | 2 +- .../riscv64-virt-graphics.riscv64-latest.args | 4 +- .../riscv64-virt-headless.riscv64-latest.args | 2 +- ...t-cpu-kvm-ccw-virtio-2.7.s390x-latest.args | 2 +- ...t-cpu-kvm-ccw-virtio-4.2.s390x-latest.args | 2 +- ...t-cpu-tcg-ccw-virtio-2.7.s390x-latest.args | 2 +- ...t-cpu-tcg-ccw-virtio-4.2.s390x-latest.args | 2 +- .../s390x-ccw-graphics.s390x-latest.args | 4 +- .../s390x-ccw-headless.s390x-latest.args | 2 +- .../serial-tcp-tlsx509-chardev-notls.xml | 1 + .../serial-unix-chardev.x86_64-latest.args | 2 +- ...rtcard-passthrough-unix.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/smbios-type-fwcfg.xml | 1 + .../tpm-emulator-spapr.ppc64-latest.args | 2 +- .../tpm-emulator-tpm2-enc.x86_64-latest.args | 2 +- ...pm-emulator-tpm2-pstate.x86_64-latest.args | 2 +- .../tpm-emulator-tpm2.x86_64-latest.args | 2 +- .../tpm-emulator.x86_64-latest.args | 2 +- .../tpm-passthrough-crb.x86_64-latest.args | 2 +- .../tpm-passthrough.x86_64-latest.args | 2 +- .../tseg-explicit-size.x86_64-latest.args | 2 +- .../usb-redir-unix.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/user-aliases.xml | 1 + .../vcpu-placement-static.xml | 1 + ...vhost-user-fs-fd-memory.x86_64-latest.args | 2 +- .../vhost-user-fs-fd-memory.xml | 1 + ...vhost-user-fs-hugepages.x86_64-latest.args | 2 +- .../vhost-user-fs-hugepages.xml | 1 + ...host-user-gpu-secondary.x86_64-latest.args | 2 +- .../vhost-user-vga.x86_64-latest.args | 2 +- .../vhost-vsock-auto.x86_64-latest.args | 2 +- .../vhost-vsock-ccw-auto.s390x-latest.args | 2 +- .../vhost-vsock-ccw-iommu.s390x-latest.args | 2 +- .../vhost-vsock-ccw-iommu.xml | 1 + .../vhost-vsock-ccw.s390x-latest.args | 2 +- tests/qemuxml2argvdata/vhost-vsock-ccw.xml | 1 + .../vhost-vsock.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/vhost-vsock.xml | 1 + ...eo-bochs-display-device.x86_64-latest.args | 2 +- ...video-qxl-device-vram64.x86_64-latest.args | 2 +- .../qemuxml2argvdata/video-qxl-resolution.xml | 1 + ...o-qxl-sec-device-vram64.x86_64-latest.args | 2 +- ...eo-ramfb-display-device.x86_64-latest.args | 2 +- .../virtio-9p-createmode.x86_64-latest.args | 2 +- .../virtio-9p-multidevs.x86_64-latest.args | 2 +- ...virtio-non-transitional.x86_64-latest.args | 2 +- ...-options-controller-ats.x86_64-latest.args | 2 +- ...ptions-controller-iommu.x86_64-latest.args | 2 +- ...tions-controller-packed.x86_64-latest.args | 2 +- ...virtio-options-disk-ats.x86_64-latest.args | 2 +- ...rtio-options-disk-iommu.x86_64-latest.args | 2 +- ...tio-options-disk-packed.x86_64-latest.args | 2 +- .../virtio-options-fs-ats.x86_64-latest.args | 2 +- ...virtio-options-fs-iommu.x86_64-latest.args | 2 +- ...irtio-options-fs-packed.x86_64-latest.args | 2 +- ...irtio-options-input-ats.x86_64-latest.args | 2 +- ...tio-options-input-iommu.x86_64-latest.args | 2 +- ...io-options-input-packed.x86_64-latest.args | 2 +- ...-options-memballoon-ats.x86_64-latest.args | 2 +- ...loon-freepage-reporting.x86_64-latest.args | 2 +- ...ptions-memballoon-iommu.x86_64-latest.args | 2 +- ...tions-memballoon-packed.x86_64-latest.args | 2 +- .../virtio-options-net-ats.x86_64-latest.args | 2 +- ...irtio-options-net-iommu.x86_64-latest.args | 2 +- ...rtio-options-net-packed.x86_64-latest.args | 2 +- .../virtio-options-rng-ats.x86_64-latest.args | 2 +- ...irtio-options-rng-iommu.x86_64-latest.args | 2 +- ...rtio-options-rng-packed.x86_64-latest.args | 2 +- ...irtio-options-video-ats.x86_64-latest.args | 2 +- ...tio-options-video-iommu.x86_64-latest.args | 2 +- ...io-options-video-packed.x86_64-latest.args | 2 +- .../virtio-options.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/virtio-options.xml | 1 + .../virtio-rng-builtin.x86_64-latest.args | 2 +- .../virtio-rng-egd-unix.x86_64-latest.args | 2 +- .../virtio-transitional.x86_64-latest.args | 2 +- ...-default-cpu-kvm-pc-4.2.x86_64-latest.args | 2 +- ...default-cpu-kvm-q35-4.2.x86_64-latest.args | 2 +- ...-default-cpu-tcg-pc-4.2.x86_64-latest.args | 2 +- ...default-cpu-tcg-q35-4.2.x86_64-latest.args | 2 +- .../x86_64-pc-graphics.x86_64-latest.args | 4 +- .../x86_64-pc-headless.x86_64-latest.args | 2 +- .../x86_64-q35-graphics.x86_64-latest.args | 4 +- .../x86_64-q35-headless.x86_64-latest.args | 2 +- tests/qemuxml2argvtest.c | 90 +++ .../aarch64-aavmf-virtio-mmio.xml | 1 + ...efault-cpu-kvm-virt-4.2.aarch64-latest.xml | 1 + ...efault-cpu-tcg-virt-4.2.aarch64-latest.xml | 1 + .../aarch64-features-sve.aarch64-latest.xml | 1 + .../aarch64-gic-none-tcg.xml | 1 + ...aarch64-os-firmware-efi.aarch64-latest.xml | 1 + .../qemuxml2xmloutdata/aarch64-pci-serial.xml | 1 + .../aarch64-traditional-pci.xml | 1 + .../aarch64-video-default.xml | 1 + .../aarch64-video-virtio-gpu-pci.xml | 1 + .../aarch64-virt-graphics.aarch64-latest.xml | 1 + .../aarch64-virt-headless.aarch64-latest.xml | 1 + .../aarch64-virtio-pci-default.xml | 1 + .../aarch64-virtio-pci-manual-addresses.xml | 1 + tests/qemuxml2xmloutdata/acpi-table.xml | 1 + tests/qemuxml2xmloutdata/audio-alsa-best.xml | 1 + tests/qemuxml2xmloutdata/audio-alsa-full.xml | 1 + .../qemuxml2xmloutdata/audio-alsa-minimal.xml | 1 + .../audio-coreaudio-best.xml | 1 + .../audio-coreaudio-full.xml | 1 + .../audio-coreaudio-minimal.xml | 1 + ...audio-default-nographics.x86_64-latest.xml | 39 + .../audio-default-nographics.xml | 1 + .../audio-default-sdl.x86_64-latest.xml | 44 ++ .../qemuxml2xmloutdata/audio-default-sdl.xml | 1 + .../audio-default-spice.x86_64-latest.xml | 46 ++ .../audio-default-spice.xml | 1 + .../audio-default-vnc.x86_64-latest.xml | 46 ++ .../qemuxml2xmloutdata/audio-default-vnc.xml | 1 + tests/qemuxml2xmloutdata/audio-file-best.xml | 1 + tests/qemuxml2xmloutdata/audio-file-full.xml | 1 + .../qemuxml2xmloutdata/audio-file-minimal.xml | 1 + tests/qemuxml2xmloutdata/audio-jack-full.xml | 1 + .../audio-many-backends.x86_64-latest.xml | 1 + tests/qemuxml2xmloutdata/audio-none-best.xml | 1 + tests/qemuxml2xmloutdata/audio-none-full.xml | 1 + .../qemuxml2xmloutdata/audio-none-minimal.xml | 1 + tests/qemuxml2xmloutdata/audio-oss-best.xml | 1 + tests/qemuxml2xmloutdata/audio-oss-full.xml | 1 + .../qemuxml2xmloutdata/audio-oss-minimal.xml | 1 + .../audio-pulseaudio-best.xml | 1 + .../audio-pulseaudio-full.xml | 1 + .../audio-pulseaudio-minimal.xml | 1 + tests/qemuxml2xmloutdata/audio-sdl-best.xml | 1 + tests/qemuxml2xmloutdata/audio-sdl-full.xml | 1 + .../qemuxml2xmloutdata/audio-sdl-minimal.xml | 1 + tests/qemuxml2xmloutdata/audio-spice-best.xml | 1 + tests/qemuxml2xmloutdata/audio-spice-full.xml | 1 + .../audio-spice-minimal.xml | 1 + tests/qemuxml2xmloutdata/autoindex.xml | 1 + .../balloon-device-auto.xml | 1 + .../balloon-device-period.xml | 1 + .../bios-nvram-os-interleave.xml | 1 + tests/qemuxml2xmloutdata/bios-nvram.xml | 1 + .../blkdeviotune.x86_64-latest.xml | 1 + tests/qemuxml2xmloutdata/blkiotune-device.xml | 1 + tests/qemuxml2xmloutdata/blkiotune.xml | 1 + tests/qemuxml2xmloutdata/boot-cdrom.xml | 1 + tests/qemuxml2xmloutdata/boot-floppy.xml | 1 + .../boot-menu-disable-with-timeout.xml | 1 + .../qemuxml2xmloutdata/boot-menu-disable.xml | 1 + .../boot-menu-enable-with-timeout.xml | 1 + tests/qemuxml2xmloutdata/boot-multi.xml | 1 + tests/qemuxml2xmloutdata/boot-network.xml | 1 + tests/qemuxml2xmloutdata/boot-order.xml | 1 + tests/qemuxml2xmloutdata/channel-guestfwd.xml | 1 + .../channel-unix-source-path-active.xml | 1 + .../channel-unix-source-path-inactive.xml | 1 + .../channel-virtio-auto.xml | 1 + .../channel-virtio-state-active.xml | 1 + .../channel-virtio-state-inactive.xml | 1 + tests/qemuxml2xmloutdata/channel-virtio.xml | 1 + tests/qemuxml2xmloutdata/chardev-label.xml | 1 + tests/qemuxml2xmloutdata/clock-catchup.xml | 1 + tests/qemuxml2xmloutdata/clock-localtime.xml | 1 + .../clock-timer-hyperv-rtc.xml | 1 + tests/qemuxml2xmloutdata/clock-utc.xml | 1 + .../console-compat-auto.xml | 1 + tests/qemuxml2xmloutdata/console-compat.xml | 1 + tests/qemuxml2xmloutdata/console-compat2.xml | 1 + .../console-virtio-many.xml | 1 + tests/qemuxml2xmloutdata/console-virtio.xml | 1 + .../controller-usb-order.xml | 1 + .../controller-virtio-scsi.xml | 1 + ...pu-Icelake-Server-pconfig.x86_64-3.1.0.xml | 1 + ...u-Icelake-Server-pconfig.x86_64-latest.xml | 1 + .../cpu-check-default-none.xml | 1 + .../cpu-check-default-none2.xml | 1 + .../cpu-check-default-partial.xml | 1 + .../cpu-check-default-partial2.xml | 1 + tests/qemuxml2xmloutdata/cpu-check-full.xml | 1 + tests/qemuxml2xmloutdata/cpu-check-none.xml | 1 + .../qemuxml2xmloutdata/cpu-check-partial.xml | 1 + tests/qemuxml2xmloutdata/cpu-empty.xml | 1 + tests/qemuxml2xmloutdata/cpu-eoi-disabled.xml | 1 + tests/qemuxml2xmloutdata/cpu-eoi-enabled.xml | 1 + .../qemuxml2xmloutdata/cpu-host-kvmclock.xml | 1 + .../cpu-host-model-features.xml | 1 + .../cpu-host-model-vendor.xml | 1 + .../cpu-host-passthrough-features.xml | 1 + tests/qemuxml2xmloutdata/cpu-kvmclock.xml | 1 + .../qemuxml2xmloutdata/cpu-numa-disjoint.xml | 1 + .../cpu-numa-disordered.xml | 1 + .../qemuxml2xmloutdata/cpu-numa-memshared.xml | 1 + .../cpu-numa-no-memory-element.xml | 1 + tests/qemuxml2xmloutdata/cpu-numa1.xml | 1 + tests/qemuxml2xmloutdata/cpu-numa2.xml | 1 + .../cputune-cpuset-big-id.x86_64-latest.xml | 1 + .../qemuxml2xmloutdata/cputune-iothreads.xml | 1 + .../cputune-iothreadsched-zeropriority.xml | 1 + .../cputune-iothreadsched.xml | 1 + tests/qemuxml2xmloutdata/cputune-numatune.xml | 1 + .../cputune-zero-shares.xml | 1 + tests/qemuxml2xmloutdata/cputune.xml | 1 + .../default-kvm-host-arch.xml | 1 + .../default-qemu-host-arch.xml | 1 + ...ault-video-type-aarch64.aarch64-latest.xml | 1 + .../default-video-type-ppc64.ppc64-latest.xml | 1 + ...ault-video-type-riscv64.riscv64-latest.xml | 1 + .../default-video-type-s390x.s390x-latest.xml | 1 + .../default-video-type-x86_64-caps-test-0.xml | 1 + .../default-video-type-x86_64-caps-test-1.xml | 1 + .../disk-active-commit-active.xml | 1 + .../disk-active-commit-inactive.xml | 1 + .../disk-aio-io_uring.x86_64-latest.xml | 1 + tests/qemuxml2xmloutdata/disk-aio.xml | 1 + .../disk-arm-virtio-sd.aarch64-latest.xml | 1 + .../disk-backing-chains-active.xml | 1 + .../disk-backing-chains-inactive.xml | 1 + .../disk-backing-chains-index-active.xml | 1 + .../disk-backing-chains-index-inactive.xml | 1 + .../disk-backing-chains-noindex.xml | 1 + tests/qemuxml2xmloutdata/disk-boot-cdrom.xml | 1 + tests/qemuxml2xmloutdata/disk-boot-disk.xml | 1 + .../disk-cache.x86_64-1.5.3.xml | 1 + .../disk-cache.x86_64-2.12.0.xml | 1 + .../disk-cache.x86_64-2.6.0.xml | 1 + .../disk-cache.x86_64-2.7.0.xml | 1 + .../disk-cache.x86_64-latest.xml | 1 + .../disk-cdrom-bus-other.xml | 1 + ...om-empty-network-invalid.x86_64-latest.xml | 1 + tests/qemuxml2xmloutdata/disk-cdrom.xml | 1 + .../qemuxml2xmloutdata/disk-copy_on_read.xml | 1 + .../disk-discard.x86_64-latest.xml | 1 + .../qemuxml2xmloutdata/disk-error-policy.xml | 1 + tests/qemuxml2xmloutdata/disk-floppy.xml | 1 + tests/qemuxml2xmloutdata/disk-fmt-qcow.xml | 1 + .../disk-metadata-cache.x86_64-latest.xml | 1 + .../qemuxml2xmloutdata/disk-mirror-active.xml | 1 + .../disk-mirror-inactive.xml | 1 + .../disk-mirror-old-active.xml | 1 + .../disk-mirror-old-inactive.xml | 1 + .../disk-network-gluster.xml | 1 + .../disk-network-http.x86_64-latest.xml | 1 + .../qemuxml2xmloutdata/disk-network-iscsi.xml | 1 + tests/qemuxml2xmloutdata/disk-network-nbd.xml | 1 + ...isk-network-nfs-inactive.x86_64-latest.xml | 1 + .../disk-network-nfs.x86_64-latest.xml | 1 + tests/qemuxml2xmloutdata/disk-network-rbd.xml | 1 + .../disk-network-sheepdog.xml | 1 + .../disk-network-source-auth.xml | 1 + .../disk-network-tlsx509-nbd.xml | 1 + .../disk-network-tlsx509-vxhs.xml | 1 + .../qemuxml2xmloutdata/disk-network-vxhs.xml | 1 + .../disk-scsi-device-auto.xml | 1 + .../qemuxml2xmloutdata/disk-scsi-disk-vpd.xml | 1 + .../disk-scsi-lun-passthrough-sgio.xml | 1 + .../disk-scsi.x86_64-latest.xml | 1 + tests/qemuxml2xmloutdata/disk-serial.xml | 1 + .../disk-slices.x86_64-latest.xml | 1 + .../disk-source-pool-mode.xml | 1 + tests/qemuxml2xmloutdata/disk-source-pool.xml | 1 + tests/qemuxml2xmloutdata/disk-usb-device.xml | 1 + .../disk-vhostuser.x86_64-latest.xml | 1 + .../disk-virtio-s390-zpci.xml | 1 + tests/qemuxml2xmloutdata/disk-virtio.xml | 1 + tests/qemuxml2xmloutdata/encrypted-disk.xml | 1 + tests/qemuxml2xmloutdata/eoi-disabled.xml | 1 + tests/qemuxml2xmloutdata/eoi-enabled.xml | 1 + tests/qemuxml2xmloutdata/event_idx.xml | 1 + tests/qemuxml2xmloutdata/floppy-drive-fat.xml | 1 + .../genid-active.x86_64-latest.xml | 1 + .../genid-auto-active.x86_64-latest.xml | 1 + .../genid-auto-inactive.x86_64-latest.xml | 1 + .../genid-inactive.x86_64-latest.xml | 1 + .../graphics-listen-network.xml | 1 + .../graphics-listen-network2.xml | 1 + .../graphics-spice-auto-socket-cfg.xml | 1 + .../graphics-spice-auto-socket.xml | 1 + .../graphics-spice-compression.xml | 1 + .../graphics-spice-egl-headless.xml | 1 + .../graphics-spice-qxl-vga.xml | 1 + .../graphics-spice-socket.xml | 1 + .../graphics-spice-timeout.xml | 1 + tests/qemuxml2xmloutdata/graphics-spice.xml | 1 + .../graphics-vnc-auto-socket-cfg.xml | 1 + .../graphics-vnc-auto-socket.xml | 1 + .../graphics-vnc-egl-headless.xml | 1 + .../graphics-vnc-no-listen-attr.xml | 1 + ...ics-vnc-remove-generated-socket-active.xml | 1 + ...s-vnc-remove-generated-socket-inactive.xml | 1 + .../qemuxml2xmloutdata/graphics-vnc-sasl.xml | 1 + .../graphics-vnc-socket.xml | 1 + tests/qemuxml2xmloutdata/graphics-vnc-tls.xml | 1 + .../graphics-vnc-websocket.xml | 1 + tests/qemuxml2xmloutdata/graphics-vnc.xml | 1 + ...stdev-mdev-display-ramfb.x86_64-latest.xml | 1 + .../hostdev-mdev-display.xml | 1 + .../hostdev-mdev-precreated.xml | 1 + .../hostdev-pci-address-unassigned.xml | 1 + .../hostdev-pci-address.xml | 1 + .../hostdev-pci-multifunction.xml | 1 + .../hostdev-scsi-autogen-address.xml | 1 + .../hostdev-scsi-large-unit.xml | 1 + tests/qemuxml2xmloutdata/hostdev-scsi-lsi.xml | 1 + .../qemuxml2xmloutdata/hostdev-scsi-rawio.xml | 1 + .../qemuxml2xmloutdata/hostdev-scsi-sgio.xml | 1 + .../hostdev-scsi-shareable.xml | 1 + .../hostdev-scsi-vhost-scsi-ccw.xml | 1 + .../hostdev-scsi-vhost-scsi-pci.xml | 1 + .../hostdev-scsi-vhost-scsi-pcie.xml | 1 + .../hostdev-scsi-virtio-scsi.xml | 1 + .../hostdev-subsys-mdev-vfio-ap.xml | 1 + ...subsys-mdev-vfio-ccw-boot.s390x-latest.xml | 1 + .../hostdev-subsys-mdev-vfio-ccw.xml | 1 + .../hostdev-usb-address.xml | 1 + .../hostdev-vfio-zpci-autogenerate-fids.xml | 1 + .../hostdev-vfio-zpci-autogenerate-uids.xml | 1 + .../hostdev-vfio-zpci-autogenerate.xml | 1 + .../hostdev-vfio-zpci-boundaries.xml | 1 + .../hostdev-vfio-zpci-ccw-memballoon.xml | 1 + .../hostdev-vfio-zpci-multidomain-many.xml | 1 + .../qemuxml2xmloutdata/hostdev-vfio-zpci.xml | 1 + tests/qemuxml2xmloutdata/hostdev-vfio.xml | 1 + .../qemuxml2xmloutdata/hugepages-default.xml | 1 + .../qemuxml2xmloutdata/hugepages-nodeset.xml | 1 + .../hugepages-numa-default-2M.xml | 1 + .../hugepages-numa-nodeset-part.xml | 1 + .../hugepages-numa-nodeset.xml | 1 + tests/qemuxml2xmloutdata/hugepages-shared.xml | 1 + tests/qemuxml2xmloutdata/hyperv-off.xml | 1 + tests/qemuxml2xmloutdata/hyperv-panic.xml | 1 + .../hyperv-stimer-direct.xml | 1 + tests/qemuxml2xmloutdata/hyperv.xml | 1 + tests/qemuxml2xmloutdata/input-usbmouse.xml | 1 + tests/qemuxml2xmloutdata/input-usbtablet.xml | 1 + tests/qemuxml2xmloutdata/input-virtio-ccw.xml | 1 + .../intel-iommu.x86_64-2.6.0.xml | 1 + tests/qemuxml2xmloutdata/interface-driver.xml | 1 + tests/qemuxml2xmloutdata/interface-server.xml | 1 + .../iommu-smmuv3.aarch64-latest.xml | 1 + .../iothreads-disk-virtio-ccw.xml | 1 + tests/qemuxml2xmloutdata/iothreads-disk.xml | 1 + .../iothreads-ids-partial.xml | 1 + tests/qemuxml2xmloutdata/iothreads-ids.xml | 1 + .../iothreads-virtio-scsi-ccw.xml | 1 + .../iothreads-virtio-scsi-pci.xml | 1 + tests/qemuxml2xmloutdata/iothreads.xml | 1 + tests/qemuxml2xmloutdata/kvm-features-off.xml | 1 + tests/qemuxml2xmloutdata/kvm-features.xml | 1 + tests/qemuxml2xmloutdata/kvmclock.xml | 1 + tests/qemuxml2xmloutdata/lease.xml | 1 + .../luks-disks-source-qcow2.x86_64-latest.xml | 1 + .../qemuxml2xmloutdata/luks-disks-source.xml | 1 + .../mach-virt-console-virtio.xml | 1 + .../mach-virt-serial-compat.xml | 1 + .../mach-virt-serial-pci.xml | 1 + .../mach-virt-serial-usb.xml | 1 + tests/qemuxml2xmloutdata/machine-core-off.xml | 1 + tests/qemuxml2xmloutdata/machine-core-on.xml | 1 + ...hine-loadparm-multiple-disks-nets-s390.xml | 1 + .../memory-hotplug-dimm.xml | 1 + ...memory-hotplug-nvdimm-ppc64-abi-update.xml | 1 + .../memory-hotplug-nvdimm-ppc64.xml | 1 + ...memory-hotplug-ppc64-nonuma-abi-update.xml | 1 + tests/qemuxml2xmloutdata/memory-hotplug.xml | 1 + .../qemuxml2xmloutdata/memorybacking-set.xml | 1 + .../memorybacking-unset.xml | 1 + .../qemuxml2xmloutdata/memtune-unlimited.xml | 1 + tests/qemuxml2xmloutdata/memtune.xml | 1 + .../qemuxml2xmloutdata/metadata-duplicate.xml | 1 + tests/qemuxml2xmloutdata/metadata.xml | 1 + tests/qemuxml2xmloutdata/migrate.xml | 1 + tests/qemuxml2xmloutdata/minimal.xml | 1 + tests/qemuxml2xmloutdata/misc-acpi.xml | 1 + tests/qemuxml2xmloutdata/misc-disable-s3.xml | 1 + .../misc-disable-suspends.xml | 1 + tests/qemuxml2xmloutdata/misc-enable-s4.xml | 1 + tests/qemuxml2xmloutdata/misc-no-reboot.xml | 1 + tests/qemuxml2xmloutdata/misc-uuid.xml | 1 + tests/qemuxml2xmloutdata/net-bandwidth.xml | 1 + tests/qemuxml2xmloutdata/net-bandwidth2.xml | 1 + tests/qemuxml2xmloutdata/net-coalesce.xml | 1 + tests/qemuxml2xmloutdata/net-eth-hostip.xml | 1 + tests/qemuxml2xmloutdata/net-eth-ifname.xml | 1 + .../net-eth-unmanaged-tap.xml | 1 + tests/qemuxml2xmloutdata/net-eth.xml | 1 + .../net-hostdev-bootorder.xml | 1 + tests/qemuxml2xmloutdata/net-hostdev-vfio.xml | 1 + tests/qemuxml2xmloutdata/net-hostdev.xml | 1 + .../net-isolated-port.x86_64-latest.xml | 1 + tests/qemuxml2xmloutdata/net-many-models.xml | 1 + tests/qemuxml2xmloutdata/net-midonet.xml | 1 + tests/qemuxml2xmloutdata/net-mtu.xml | 1 + tests/qemuxml2xmloutdata/net-openvswitch.xml | 1 + tests/qemuxml2xmloutdata/net-udp.xml | 1 + tests/qemuxml2xmloutdata/net-user.xml | 1 + tests/qemuxml2xmloutdata/net-vdpa.xml | 1 + tests/qemuxml2xmloutdata/net-vhostuser.xml | 1 + .../qemuxml2xmloutdata/net-virtio-device.xml | 1 + .../net-virtio-disable-offloads.xml | 1 + .../net-virtio-network-portgroup.xml | 1 + .../net-virtio-rxtxqueuesize.xml | 1 + .../net-virtio-teaming-network.xml | 1 + .../qemuxml2xmloutdata/net-virtio-teaming.xml | 1 + tests/qemuxml2xmloutdata/net-virtio.xml | 1 + tests/qemuxml2xmloutdata/nosharepages.xml | 1 + .../numad-auto-memory-vcpu-cpuset.xml | 1 + ...to-memory-vcpu-no-cpuset-and-placement.xml | 1 + .../numad-auto-vcpu-no-numatune.xml | 1 + .../numad-static-vcpu-no-numatune.xml | 1 + .../numatune-auto-prefer.xml | 1 + .../qemuxml2xmloutdata/numatune-distances.xml | 1 + .../numatune-memnode-no-memory.xml | 1 + tests/qemuxml2xmloutdata/numatune-memnode.xml | 1 + ...avcpus-topology-mismatch.x86_64-latest.xml | 1 + .../os-firmware-bios.x86_64-latest.xml | 1 + .../os-firmware-efi-secboot.x86_64-latest.xml | 1 + .../os-firmware-efi.x86_64-latest.xml | 1 + tests/qemuxml2xmloutdata/panic-double.xml | 1 + tests/qemuxml2xmloutdata/panic-isa.xml | 1 + tests/qemuxml2xmloutdata/panic-no-address.xml | 1 + tests/qemuxml2xmloutdata/panic-pseries.xml | 1 + tests/qemuxml2xmloutdata/panic.xml | 1 + tests/qemuxml2xmloutdata/pci-autoadd-addr.xml | 1 + tests/qemuxml2xmloutdata/pci-autoadd-idx.xml | 1 + .../qemuxml2xmloutdata/pci-autofill-addr.xml | 1 + .../pci-bridge-many-disks.xml | 1 + tests/qemuxml2xmloutdata/pci-bridge.xml | 1 + tests/qemuxml2xmloutdata/pci-expander-bus.xml | 1 + tests/qemuxml2xmloutdata/pci-many.xml | 1 + .../pci-rom-disabled-invalid.xml | 1 + tests/qemuxml2xmloutdata/pci-rom-disabled.xml | 1 + tests/qemuxml2xmloutdata/pci-rom.xml | 1 + .../pci-serial-dev-chardev.xml | 1 + .../qemuxml2xmloutdata/pcie-expander-bus.xml | 1 + .../pcie-root-port-model-generic.xml | 1 + .../pcie-root-port-model-ioh3420.xml | 1 + ...pcie-root-port-nohotplug.x86_64-latest.xml | 1 + tests/qemuxml2xmloutdata/pcie-root-port.xml | 1 + tests/qemuxml2xmloutdata/pcie-root.xml | 1 + .../pcie-switch-downstream-port.xml | 1 + .../pcie-switch-upstream-port.xml | 1 + tests/qemuxml2xmloutdata/pcihole64-gib.xml | 1 + tests/qemuxml2xmloutdata/pcihole64-none.xml | 1 + tests/qemuxml2xmloutdata/pcihole64-q35.xml | 1 + tests/qemuxml2xmloutdata/pcihole64.xml | 1 + tests/qemuxml2xmloutdata/pmu-feature-off.xml | 1 + tests/qemuxml2xmloutdata/pmu-feature.xml | 1 + ...fault-cpu-kvm-pseries-2.7.ppc64-latest.xml | 1 + ...fault-cpu-kvm-pseries-3.1.ppc64-latest.xml | 1 + ...fault-cpu-kvm-pseries-4.2.ppc64-latest.xml | 1 + ...fault-cpu-tcg-pseries-2.7.ppc64-latest.xml | 1 + ...fault-cpu-tcg-pseries-3.1.ppc64-latest.xml | 1 + ...fault-cpu-tcg-pseries-4.2.ppc64-latest.xml | 1 + .../ppc64-pseries-graphics.ppc64-latest.xml | 1 + .../ppc64-pseries-headless.ppc64-latest.xml | 1 + .../ppc64-tpmproxy-single.ppc64-latest.xml | 1 + .../ppc64-tpmproxy-with-tpm.ppc64-latest.xml | 1 + .../ppc64-usb-controller-legacy.xml | 1 + .../ppc64-usb-controller.xml | 1 + .../pseries-console-virtio.xml | 1 + .../pseries-cpu-compat-power9.xml | 1 + .../qemuxml2xmloutdata/pseries-cpu-compat.xml | 1 + .../qemuxml2xmloutdata/pseries-cpu-exact.xml | 1 + tests/qemuxml2xmloutdata/pseries-features.xml | 1 + .../qemuxml2xmloutdata/pseries-hostdevs-1.xml | 1 + .../qemuxml2xmloutdata/pseries-hostdevs-2.xml | 1 + .../qemuxml2xmloutdata/pseries-hostdevs-3.xml | 1 + .../pseries-many-buses-1.xml | 1 + .../pseries-many-buses-2.xml | 1 + .../pseries-many-devices.xml | 1 + tests/qemuxml2xmloutdata/pseries-nvram.xml | 1 + .../pseries-panic-missing.xml | 1 + .../pseries-panic-no-address.xml | 1 + .../pseries-phb-default-missing.xml | 1 + .../pseries-phb-numa-node.xml | 1 + .../qemuxml2xmloutdata/pseries-phb-simple.xml | 1 + .../pseries-serial-native.xml | 1 + .../qemuxml2xmloutdata/pseries-serial-pci.xml | 1 + .../qemuxml2xmloutdata/pseries-serial-usb.xml | 1 + .../pv-spinlock-disabled.xml | 1 + .../pv-spinlock-enabled.xml | 1 + .../q35-default-devices-only.xml | 1 + .../qemuxml2xmloutdata/q35-multifunction.xml | 1 + .../q35-pci-force-address.xml | 1 + tests/qemuxml2xmloutdata/q35-pcie-autoadd.xml | 1 + tests/qemuxml2xmloutdata/q35-pcie.xml | 1 + tests/qemuxml2xmloutdata/q35-usb2-multi.xml | 1 + tests/qemuxml2xmloutdata/q35-usb2-reorder.xml | 1 + tests/qemuxml2xmloutdata/q35-usb2.xml | 1 + .../q35-virt-manager-basic.xml | 1 + tests/qemuxml2xmloutdata/q35-virtio-pci.xml | 1 + tests/qemuxml2xmloutdata/q35.xml | 1 + tests/qemuxml2xmloutdata/qemu-ns-no-env.xml | 1 + .../reboot-timeout-disabled.xml | 1 + .../reboot-timeout-enabled.xml | 1 + tests/qemuxml2xmloutdata/restore-v2.xml | 1 + .../riscv64-virt-graphics.riscv64-latest.xml | 1 + .../riscv64-virt-headless.riscv64-latest.xml | 1 + tests/qemuxml2xmloutdata/riscv64-virt-pci.xml | 1 + tests/qemuxml2xmloutdata/riscv64-virt.xml | 1 + ...lt-cpu-kvm-ccw-virtio-2.7.s390x-latest.xml | 1 + ...lt-cpu-kvm-ccw-virtio-4.2.s390x-latest.xml | 1 + ...lt-cpu-tcg-ccw-virtio-2.7.s390x-latest.xml | 1 + ...lt-cpu-tcg-ccw-virtio-4.2.s390x-latest.xml | 1 + .../s390-defaultconsole.xml | 1 + .../qemuxml2xmloutdata/s390-panic-missing.xml | 1 + .../s390-panic-no-address.xml | 1 + tests/qemuxml2xmloutdata/s390-panic.xml | 1 + tests/qemuxml2xmloutdata/s390-serial-2.xml | 1 + .../s390-serial-console.xml | 1 + tests/qemuxml2xmloutdata/s390-serial.xml | 1 + .../s390x-ccw-graphics.s390x-latest.xml | 1 + .../s390x-ccw-headless.s390x-latest.xml | 1 + .../qemuxml2xmloutdata/seclabel-dac-none.xml | 1 + .../seclabel-device-multiple.xml | 1 + .../seclabel-dynamic-baselabel-inactive.xml | 1 + .../seclabel-dynamic-labelskip-inactive.xml | 1 + ...seclabel-dynamic-none-relabel-inactive.xml | 1 + .../seclabel-dynamic-none.xml | 1 + .../seclabel-dynamic-override-inactive.xml | 1 + .../seclabel-dynamic-relabel-inactive.xml | 1 + tests/qemuxml2xmloutdata/seclabel-none.xml | 1 + .../seclabel-static-labelskip-active.xml | 1 + .../seclabel-static-labelskip-inactive.xml | 1 + tests/qemuxml2xmloutdata/seclabel-static.xml | 1 + .../serial-spiceport-nospice.xml | 1 + tests/qemuxml2xmloutdata/serial-spiceport.xml | 1 + .../serial-target-port-auto.xml | 1 + .../serial-tcp-tlsx509-chardev.xml | 1 + .../shmem-plain-doorbell.xml | 1 + tests/qemuxml2xmloutdata/shmem.xml | 1 + .../smartcard-controller.xml | 1 + .../smartcard-host-certificates-database.xml | 1 + .../smartcard-host-certificates.xml | 1 + tests/qemuxml2xmloutdata/smartcard-host.xml | 1 + .../smartcard-passthrough-spicevmc.xml | 1 + .../smartcard-passthrough-tcp.xml | 1 + .../smbios-multiple-type2.xml | 1 + tests/qemuxml2xmloutdata/smbios.xml | 1 + tests/qemuxml2xmloutdata/smp.xml | 1 + tests/qemuxml2xmloutdata/sound-device.xml | 1 + tests/qemuxml2xmloutdata/sound.xml | 1 + .../tap-vhost-incorrect.xml | 1 + tests/qemuxml2xmloutdata/tap-vhost.xml | 1 + .../tpm-emulator-tpm2-enc.x86_64-latest.xml | 1 + ...tpm-emulator-tpm2-pstate.x86_64-latest.xml | 1 + .../tpm-emulator-tpm2.x86_64-latest.xml | 1 + .../tpm-emulator.x86_64-latest.xml | 1 + .../tpm-passthrough-crb.x86_64-latest.xml | 1 + .../tpm-passthrough.x86_64-latest.xml | 1 + .../qemuxml2xmloutdata/tseg-explicit-size.xml | 1 + .../usb-controller-default-q35.xml | 1 + .../usb-controller-explicit-q35.xml | 1 + tests/qemuxml2xmloutdata/usb-controller.xml | 1 + .../qemuxml2xmloutdata/usb-ich9-ehci-addr.xml | 1 + tests/qemuxml2xmloutdata/usb-none.xml | 1 + .../usb-piix3-controller.xml | 1 + tests/qemuxml2xmloutdata/usb-port-missing.xml | 1 + .../usb-redir-filter-version.xml | 1 + tests/qemuxml2xmloutdata/usb-redir-filter.xml | 1 + tests/qemuxml2xmloutdata/usb-redir.xml | 1 + tests/qemuxml2xmloutdata/vhost-vsock-auto.xml | 1 + .../vhost-vsock-ccw-auto.xml | 1 + tests/qemuxml2xmloutdata/vhost_queues.xml | 1 + .../video-device-pciaddr-default.xml | 1 + .../qemuxml2xmloutdata/video-none-device.xml | 1 + tests/qemuxml2xmloutdata/video-qxl-heads.xml | 1 + .../qemuxml2xmloutdata/video-qxl-noheads.xml | 1 + .../video-virtio-gpu-ccw-auto.xml | 1 + .../video-virtio-gpu-ccw.xml | 1 + .../video-virtio-gpu-device.xml | 1 + .../video-virtio-gpu-secondary.xml | 1 + .../video-virtio-gpu-spice-gl.xml | 1 + .../video-virtio-gpu-virgl.xml | 1 + .../virtio-9p-createmode.x86_64-latest.xml | 1 + .../virtio-9p-multidevs.x86_64-latest.xml | 1 + .../virtio-input-passthrough.xml | 1 + tests/qemuxml2xmloutdata/virtio-input.xml | 1 + tests/qemuxml2xmloutdata/virtio-lun.xml | 1 + .../virtio-non-transitional.x86_64-latest.xml | 1 + .../virtio-rng-builtin.x86_64-latest.xml | 1 + tests/qemuxml2xmloutdata/virtio-rng-egd.xml | 1 + .../qemuxml2xmloutdata/virtio-rng-random.xml | 1 + .../virtio-transitional.x86_64-latest.xml | 1 + tests/qemuxml2xmloutdata/vmcoreinfo.xml | 1 + tests/qemuxml2xmloutdata/watchdog.xml | 1 + ...4-default-cpu-kvm-pc-4.2.x86_64-latest.xml | 1 + ...-default-cpu-kvm-q35-4.2.x86_64-latest.xml | 1 + ...4-default-cpu-tcg-pc-4.2.x86_64-latest.xml | 1 + ...-default-cpu-tcg-q35-4.2.x86_64-latest.xml | 1 + .../x86_64-pc-graphics.x86_64-latest.xml | 1 + .../x86_64-pc-headless.x86_64-latest.xml | 1 + .../x86_64-q35-graphics.x86_64-latest.xml | 1 + .../x86_64-q35-headless.x86_64-latest.xml | 1 + tests/qemuxml2xmltest.c | 54 ++ 957 files changed, 6887 insertions(+), 341 deletions(-) create mode 100644 tests/qemuxml2argvdata/audio-alsa-best.args create mode 100644 tests/qemuxml2argvdata/audio-alsa-best.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-alsa-best.xml create mode 100644 tests/qemuxml2argvdata/audio-alsa-full.args create mode 100644 tests/qemuxml2argvdata/audio-alsa-full.err create mode 100644 tests/qemuxml2argvdata/audio-alsa-full.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-alsa-full.xml create mode 100644 tests/qemuxml2argvdata/audio-alsa-minimal.args create mode 100644 tests/qemuxml2argvdata/audio-alsa-minimal.x86_64-latest.a= rgs create mode 100644 tests/qemuxml2argvdata/audio-alsa-minimal.xml create mode 100644 tests/qemuxml2argvdata/audio-coreaudio-best.args create mode 100644 tests/qemuxml2argvdata/audio-coreaudio-best.x86_64-latest= .args create mode 100644 tests/qemuxml2argvdata/audio-coreaudio-best.xml create mode 100644 tests/qemuxml2argvdata/audio-coreaudio-full.args create mode 100644 tests/qemuxml2argvdata/audio-coreaudio-full.err create mode 100644 tests/qemuxml2argvdata/audio-coreaudio-full.x86_64-latest= .args create mode 100644 tests/qemuxml2argvdata/audio-coreaudio-full.xml create mode 100644 tests/qemuxml2argvdata/audio-coreaudio-minimal.args create mode 100644 tests/qemuxml2argvdata/audio-coreaudio-minimal.x86_64-lat= est.args create mode 100644 tests/qemuxml2argvdata/audio-coreaudio-minimal.xml create mode 100644 tests/qemuxml2argvdata/audio-default-nographics.args create mode 100644 tests/qemuxml2argvdata/audio-default-nographics.x86_64-la= test.args create mode 100644 tests/qemuxml2argvdata/audio-default-nographics.xml create mode 100644 tests/qemuxml2argvdata/audio-default-sdl.args create mode 100644 tests/qemuxml2argvdata/audio-default-sdl.x86_64-latest.ar= gs create mode 100644 tests/qemuxml2argvdata/audio-default-sdl.xml create mode 100644 tests/qemuxml2argvdata/audio-default-spice.args create mode 100644 tests/qemuxml2argvdata/audio-default-spice.x86_64-latest.= args create mode 100644 tests/qemuxml2argvdata/audio-default-spice.xml create mode 100644 tests/qemuxml2argvdata/audio-default-vnc.args create mode 100644 tests/qemuxml2argvdata/audio-default-vnc.x86_64-latest.ar= gs create mode 100644 tests/qemuxml2argvdata/audio-default-vnc.xml create mode 100644 tests/qemuxml2argvdata/audio-file-best.args create mode 100644 tests/qemuxml2argvdata/audio-file-best.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-file-best.xml create mode 100644 tests/qemuxml2argvdata/audio-file-full.args create mode 100644 tests/qemuxml2argvdata/audio-file-full.err create mode 100644 tests/qemuxml2argvdata/audio-file-full.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-file-full.xml create mode 100644 tests/qemuxml2argvdata/audio-file-minimal.args create mode 100644 tests/qemuxml2argvdata/audio-file-minimal.x86_64-latest.a= rgs create mode 100644 tests/qemuxml2argvdata/audio-file-minimal.xml create mode 100644 tests/qemuxml2argvdata/audio-jack-full.err create mode 100644 tests/qemuxml2argvdata/audio-jack-full.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-jack-full.xml create mode 100644 tests/qemuxml2argvdata/audio-jack-minimal.err create mode 100644 tests/qemuxml2argvdata/audio-jack-minimal.x86_64-latest.a= rgs create mode 100644 tests/qemuxml2argvdata/audio-jack-minimal.xml create mode 100644 tests/qemuxml2argvdata/audio-many-backends.err create mode 100644 tests/qemuxml2argvdata/audio-many-backends.x86_64-latest.= args create mode 100644 tests/qemuxml2argvdata/audio-many-backends.xml create mode 100644 tests/qemuxml2argvdata/audio-none-best.args create mode 100644 tests/qemuxml2argvdata/audio-none-best.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-none-best.xml create mode 100644 tests/qemuxml2argvdata/audio-none-full.args create mode 100644 tests/qemuxml2argvdata/audio-none-full.err create mode 100644 tests/qemuxml2argvdata/audio-none-full.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-none-full.xml create mode 100644 tests/qemuxml2argvdata/audio-none-minimal.args create mode 100644 tests/qemuxml2argvdata/audio-none-minimal.x86_64-latest.a= rgs create mode 100644 tests/qemuxml2argvdata/audio-none-minimal.xml create mode 100644 tests/qemuxml2argvdata/audio-oss-best.args create mode 100644 tests/qemuxml2argvdata/audio-oss-best.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-oss-best.xml create mode 100644 tests/qemuxml2argvdata/audio-oss-full.args create mode 100644 tests/qemuxml2argvdata/audio-oss-full.err create mode 100644 tests/qemuxml2argvdata/audio-oss-full.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-oss-full.xml create mode 100644 tests/qemuxml2argvdata/audio-oss-minimal.args create mode 100644 tests/qemuxml2argvdata/audio-oss-minimal.x86_64-latest.ar= gs create mode 100644 tests/qemuxml2argvdata/audio-oss-minimal.xml create mode 100644 tests/qemuxml2argvdata/audio-pulseaudio-best.args create mode 100644 tests/qemuxml2argvdata/audio-pulseaudio-best.x86_64-lates= t.args create mode 100644 tests/qemuxml2argvdata/audio-pulseaudio-best.xml create mode 100644 tests/qemuxml2argvdata/audio-pulseaudio-full.args create mode 100644 tests/qemuxml2argvdata/audio-pulseaudio-full.err create mode 100644 tests/qemuxml2argvdata/audio-pulseaudio-full.x86_64-lates= t.args create mode 100644 tests/qemuxml2argvdata/audio-pulseaudio-full.xml create mode 100644 tests/qemuxml2argvdata/audio-pulseaudio-minimal.args create mode 100644 tests/qemuxml2argvdata/audio-pulseaudio-minimal.x86_64-la= test.args create mode 100644 tests/qemuxml2argvdata/audio-pulseaudio-minimal.xml create mode 100644 tests/qemuxml2argvdata/audio-sdl-best.args create mode 100644 tests/qemuxml2argvdata/audio-sdl-best.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-sdl-best.xml create mode 100644 tests/qemuxml2argvdata/audio-sdl-full.args create mode 100644 tests/qemuxml2argvdata/audio-sdl-full.err create mode 100644 tests/qemuxml2argvdata/audio-sdl-full.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-sdl-full.xml create mode 100644 tests/qemuxml2argvdata/audio-sdl-minimal.args create mode 100644 tests/qemuxml2argvdata/audio-sdl-minimal.x86_64-latest.ar= gs create mode 100644 tests/qemuxml2argvdata/audio-sdl-minimal.xml create mode 100644 tests/qemuxml2argvdata/audio-spice-best.args create mode 100644 tests/qemuxml2argvdata/audio-spice-best.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-spice-best.xml create mode 100644 tests/qemuxml2argvdata/audio-spice-full.args create mode 100644 tests/qemuxml2argvdata/audio-spice-full.err create mode 100644 tests/qemuxml2argvdata/audio-spice-full.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-spice-full.xml create mode 100644 tests/qemuxml2argvdata/audio-spice-minimal.args create mode 100644 tests/qemuxml2argvdata/audio-spice-minimal.x86_64-latest.= args create mode 100644 tests/qemuxml2argvdata/audio-spice-minimal.xml create mode 120000 tests/qemuxml2xmloutdata/audio-alsa-best.xml create mode 120000 tests/qemuxml2xmloutdata/audio-alsa-full.xml create mode 120000 tests/qemuxml2xmloutdata/audio-alsa-minimal.xml create mode 120000 tests/qemuxml2xmloutdata/audio-coreaudio-best.xml create mode 120000 tests/qemuxml2xmloutdata/audio-coreaudio-full.xml create mode 120000 tests/qemuxml2xmloutdata/audio-coreaudio-minimal.xml create mode 100644 tests/qemuxml2xmloutdata/audio-default-nographics.x86_64-= latest.xml create mode 120000 tests/qemuxml2xmloutdata/audio-default-nographics.xml create mode 100644 tests/qemuxml2xmloutdata/audio-default-sdl.x86_64-latest.= xml create mode 120000 tests/qemuxml2xmloutdata/audio-default-sdl.xml create mode 100644 tests/qemuxml2xmloutdata/audio-default-spice.x86_64-lates= t.xml create mode 120000 tests/qemuxml2xmloutdata/audio-default-spice.xml create mode 100644 tests/qemuxml2xmloutdata/audio-default-vnc.x86_64-latest.= xml create mode 120000 tests/qemuxml2xmloutdata/audio-default-vnc.xml create mode 120000 tests/qemuxml2xmloutdata/audio-file-best.xml create mode 120000 tests/qemuxml2xmloutdata/audio-file-full.xml create mode 120000 tests/qemuxml2xmloutdata/audio-file-minimal.xml create mode 120000 tests/qemuxml2xmloutdata/audio-jack-full.xml create mode 120000 tests/qemuxml2xmloutdata/audio-many-backends.x86_64-lates= t.xml create mode 120000 tests/qemuxml2xmloutdata/audio-none-best.xml create mode 120000 tests/qemuxml2xmloutdata/audio-none-full.xml create mode 120000 tests/qemuxml2xmloutdata/audio-none-minimal.xml create mode 120000 tests/qemuxml2xmloutdata/audio-oss-best.xml create mode 120000 tests/qemuxml2xmloutdata/audio-oss-full.xml create mode 120000 tests/qemuxml2xmloutdata/audio-oss-minimal.xml create mode 120000 tests/qemuxml2xmloutdata/audio-pulseaudio-best.xml create mode 120000 tests/qemuxml2xmloutdata/audio-pulseaudio-full.xml create mode 120000 tests/qemuxml2xmloutdata/audio-pulseaudio-minimal.xml create mode 120000 tests/qemuxml2xmloutdata/audio-sdl-best.xml create mode 120000 tests/qemuxml2xmloutdata/audio-sdl-full.xml create mode 120000 tests/qemuxml2xmloutdata/audio-sdl-minimal.xml create mode 120000 tests/qemuxml2xmloutdata/audio-spice-best.xml create mode 120000 tests/qemuxml2xmloutdata/audio-spice-full.xml create mode 120000 tests/qemuxml2xmloutdata/audio-spice-minimal.xml --=20 2.29.2

3 25