- Devel - libvirt List Archives

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part II
by Tim Wiederhake 21 Apr '21

21 Apr '21

For background, see https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html Tim Wiederhake (10): virDomainVirtioOptionsParseXML: Use virXMLProp* virDomainDeviceBootParseXML: Use virXMLProp* virDomainDeviceISAAddressParseXML: Use virXMLProp* virDomainDiskSourceNVMeParse: Use virXMLProp* virDomainChrSourceDefParseFile: Use virXMLProp* virDomainChrSourceDefParseLog: Use virXMLProp* virDomainAudioJackParse: Use virXMLProp* virDomainVideoResolutionDefParseXML: Use virXMLProp* virDomainVsockDefParseXML: Use virXMLProp* virDomainLoaderDefParseXML: Use virXMLProp* src/conf/domain_conf.c | 246 +++++++++-------------------------------- 1 file changed, 52 insertions(+), 194 deletions(-) -- 2.26.3

2 12

[PATCH 00/21] Refactoring conf to use XPath
by Kristina Hanicova 21 Apr '21

21 Apr '21

This series reworks the outdated way of parsing XML to parsing by XPath, which is more obvious and saves a few lines of code. Kristina Hanicova (21): conf: Propagate xmlXPathContextPtr into virDomainHostdevSubsysUSBDefParseXML() Refactoring virDomainHostdevSubsysUSBDefParseXML() to use XPath conf: Propagate xmlXPathContextPtr into virDomainBlkioDeviceParseXML() Refactoring virDomainBlkioDeviceParseXML() to use XPath conf: Propagate xmlXPathContextPtr into virDomainHostdevSubsysPCIDefParseXML() Refactoring virDomainHostdevSubsysPCIDefParseXML() to use XPath conf: Propagate xmlXPathContextPtr into virDomainLeaseDefParseXML() Refactoring virDomainLeaseDefParseXML() to use XPath Refactoring virDomainDiskDefParseXML() to use XPath Refactoring virDomainControllerDefParseXML() to use XPath Refactoring virDomainFSDefParseXML() to use XPath Refactoring virDomainNetDefParseXML() to use XPath conf: Propagate xmlXPathContextPtr into virDomainChrDefParseTargetXML() Refactoring virDomainChrDefParseTargetXML() to use XPath Refactoring virDomainChrSourceDefParseXML() to use XPath Refactoring virDomainChrDefParseXML() to use XPath Refactoring virDomainSmartcardDefParseXML() to use XPath Refactoring virDomainGraphicsDefParseXMLSpice() to use XPath conf: Propagate xmlXPathContextPtr into virDomainVideoDriverDefParseXML() Refactoring virDomainVideoDriverDefParseXML() to use XPath Refactoring virDomainVideoDefParseXML() to use XPath src/conf/domain_conf.c | 1786 +++++++++++++++++----------------------- 1 file changed, 777 insertions(+), 1009 deletions(-) -- 2.30.2

4 24

[RFC PATCH 0/7] Fix issue when storage migration is requested but there are no disks to migrate
by Peter Krempa 21 Apr '21

21 Apr '21

In certain weird cases and due to very crusty code we'd instruct qemu to migrate storage using the old style storage migration when there wasn't anything to migrate. This was caused by a recent refactor. Note that the series is RFC as I didn't really test it yet, but feel free to provide feedback. Peter Krempa (7): util: xml: Introduce virXMLFormatElementEmpty qemuMigrationCookieNBDXMLFormat: Format empty <nbd/> element qemuMigrationSrcNBDStorageCopy: Return error code on error qemuMigrationSrcNBDStorageCopy: Don't pass migrate_flags qemuMigrationSrcRun: Sanitize setting of cookieFlags and migrate_flags on storage migration qemuMigrationSrcRun: Don't attempt any storage migration if no disks will be migrated qemuMigrationSrcBeginPhase: Don't offer 'nbd' in cookie if there are no disks to migrate src/libvirt_private.syms | 1 + src/qemu/qemu_migration.c | 102 ++++++++++++++++++------------- src/qemu/qemu_migration_cookie.c | 2 +- src/util/virxml.c | 42 ++++++++----- src/util/virxml.h | 7 +++ 5 files changed, 95 insertions(+), 59 deletions(-) -- 2.30.2

3 13

[PATCH] docs: formatdomain: Fix quoting of ':since:' argument for <teaming>
by Peter Krempa 21 Apr '21

21 Apr '21

The end quote of the argument of :since: must not have a space in front of it as it's then not considered as end of the argument. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- docs/formatdomain.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Pushed as trivial. diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 4388ad545f..4528e172ec 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -4856,7 +4856,7 @@ Teaming a virtio/hostdev NIC pair :since:`Since 6.1.0 (QEMU and KVM only, requires QEMU 4.2.0 or newer and a guest virtio-net driver supporting the "failover" feature, such as the one included in -Linux kernel 4.18 and newer) ` The ``<teaming>`` element of two interfaces can +Linux kernel 4.18 and newer)` The ``<teaming>`` element of two interfaces can be used to connect them as a team/bond device in the guest (assuming proper support in the hypervisor and the guest network driver). -- 2.30.2

1 0

[libvirt PATCH v2 00/10] Refactor more XML parsing boilerplate code
by Tim Wiederhake 21 Apr '21

21 Apr '21

For background, see https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html Changes since V1: * Rebased * s/VIR_XML_PROP_OPTIONAL/VIR_XML_PROP_NONE/ * Declare variables 1 / line * Commented on strictening of parser in patch #10 Tim Wiederhake (10): virDomainBackupDiskDefParseXML: Use virXMLProp* virDomainBackupDefParse: Use virXMLProp* virZPCIDeviceAddressParseXML: Use virXMLProp* virPCIDeviceAddressParseXML: Use virXMLProp* virDomainDeviceCCWAddressParseXML: Use virXMLProp* virDomainDeviceDriveAddressParseXML: Use virXMLProp* virDomainDeviceVirtioSerialAddressParseXML: Use virXMLProp* virDomainDeviceCcidAddressParseXML: Use virXMLProp* virDomainDeviceUSBAddressParseXML: Use virXMLProp* virInterfaceLinkParseXML: Use virXMLProp* src/conf/backup_conf.c | 57 +++------- src/conf/device_conf.c | 237 ++++++++++++----------------------------- 2 files changed, 80 insertions(+), 214 deletions(-) -- 2.26.3

2 11

[libvirt PATCH] spec: Do not build qemu driver for Power on RHEL-9
by Jiri Denemark 21 Apr '21

21 Apr '21

https://bugzilla.redhat.com/show_bug.cgi?id=1946529 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- libvirt.spec.in | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index f9af330186..be74964b7b 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -19,7 +19,11 @@ %define arches_qemu_kvm %{ix86} x86_64 %{power64} %{arm} aarch64 s390x %if 0%{?rhel} - %define arches_qemu_kvm x86_64 %{power64} aarch64 s390x + %if 0%{?rhel} <= 8 + %define arches_qemu_kvm x86_64 %{power64} aarch64 s390x + %else + %define arches_qemu_kvm x86_64 aarch64 s390x + %endif %endif %define arches_64bit x86_64 %{power64} aarch64 s390x riscv64 -- 2.31.1

2 1

[libvirt PATCH v2 00/21] cleanup meson checks for runtime binaries
by Pavel Hrdina 21 Apr '21

21 Apr '21

Recent attempt to add a lot of meson options to specify different runtime paths motivated me enough to cleanup this from meson. Changes in v2: - split and rework patch 16/17 to address review comments - added a new patch to cleanup libvirt.spec.in file Pavel Hrdina (21): bridge_driver: fix comment about dnsmasqCaps virdnsmasq: drop unused dnsmasqCapsNewFromFile function virdnsmasq: drop unused dnsmasqCapsRefresh function virdnsmasq: remove binaryPath argument from dnsmasqCapsNewFromBuffer virdnsmasq: remove binaryPath argument from dnsmasqCapsNewFromBinary virfirewall: use virFindFileInPath instead of virFileIsExecutable tests: introduce virfirewallmock tests: use virfirewallmock instead of hasNetfilterTools virnetdev: move virNetDevSetRootQDisc to virnetdevbandwidth tests: testutilsqemu: move virFindFileInPath into domaincapsmock meson: don't check collie as program for sheepdog bhyvexml2argvtest: use virCommandToStringFull to strip command path storage: use virFindFileInPath to validate presence of mkfs virfile: introduce virFindFileInPathFull() qemu_conf: use virFindFileInPathFull for runtime binaries meson: drop check for runtime binary dependencies meson: move iscsiadm check into storage_iscsi condition meson: stop setting runtime binaries defines during compilation meson: use runtime binaries to only resolve features with "auto" value meson: optional_programs should be used only for building libvirt libvirt.spec: drop no longer required build dependencies libvirt.spec.in | 31 --- meson.build | 214 ++++++------------ src/bhyve/bhyve_command.c | 4 + src/libvirt_private.syms | 6 +- src/locking/lock_driver_lockd.c | 12 +- src/network/bridge_driver.c | 8 +- src/node_device/node_device_driver.c | 2 + src/qemu/qemu_conf.c | 23 +- src/qemu/qemu_domain.c | 3 +- src/storage/storage_backend_fs.c | 24 +- src/storage/storage_backend_logical.c | 13 ++ src/storage/storage_backend_sheepdog.c | 2 + src/storage/storage_backend_zfs.c | 3 + src/storage/storage_util.c | 2 + src/storage/storage_util.h | 6 + src/util/virdnsmasq.c | 56 +---- src/util/virdnsmasq.h | 8 +- src/util/virfile.c | 16 +- src/util/virfile.h | 6 +- src/util/virfirewall.c | 4 +- src/util/virfirewall.h | 4 + src/util/viriscsi.h | 2 + src/util/virkmod.h | 3 + src/util/virnetdev.c | 46 ---- src/util/virnetdev.h | 4 - src/util/virnetdevbandwidth.c | 50 ++++ src/util/virnetdevbandwidth.h | 6 + src/util/virnetdevip.c | 2 + src/util/virnetdevmidonet.c | 2 + src/util/virnetdevopenvswitch.c | 2 + src/util/virnuma.c | 1 + src/util/virsysinfo.c | 1 + src/util/virutil.c | 2 + .../bhyvexml2argv-acpiapic.args | 2 +- .../bhyvexml2argv-acpiapic.ldargs | 2 +- ...ml2argv-addr-isa-controller-on-slot-1.args | 2 +- ...2argv-addr-isa-controller-on-slot-1.ldargs | 2 +- ...l2argv-addr-isa-controller-on-slot-31.args | 2 +- ...argv-addr-isa-controller-on-slot-31.ldargs | 2 +- ...xml2argv-addr-more-than-32-sata-disks.args | 2 +- ...l2argv-addr-more-than-32-sata-disks.ldargs | 2 +- ...hyvexml2argv-addr-multiple-sata-disks.args | 2 +- ...vexml2argv-addr-multiple-sata-disks.ldargs | 2 +- ...vexml2argv-addr-multiple-virtio-disks.args | 2 +- ...xml2argv-addr-multiple-virtio-disks.ldargs | 2 +- ...rgv-addr-no32devs-multiple-sata-disks.args | 2 +- ...v-addr-no32devs-multiple-sata-disks.ldargs | 2 +- ...l2argv-addr-no32devs-single-sata-disk.args | 2 +- ...argv-addr-no32devs-single-sata-disk.ldargs | 2 +- ...rgv-addr-non-isa-controller-on-slot-1.args | 2 +- .../bhyvexml2argv-addr-single-sata-disk.args | 2 +- ...bhyvexml2argv-addr-single-sata-disk.ldargs | 2 +- ...bhyvexml2argv-addr-single-virtio-disk.args | 2 +- ...yvexml2argv-addr-single-virtio-disk.ldargs | 2 +- .../bhyvexml2argvdata/bhyvexml2argv-base.args | 2 +- .../bhyvexml2argv-base.ldargs | 2 +- .../bhyvexml2argv-bhyveload-bootorder.args | 2 +- .../bhyvexml2argv-bhyveload-bootorder.ldargs | 2 +- .../bhyvexml2argv-bhyveload-bootorder1.args | 2 +- .../bhyvexml2argv-bhyveload-bootorder1.ldargs | 2 +- .../bhyvexml2argv-bhyveload-bootorder3.args | 2 +- .../bhyvexml2argv-bhyveload-bootorder3.ldargs | 2 +- .../bhyvexml2argv-bhyveload-explicitargs.args | 2 +- ...hyvexml2argv-bhyveload-explicitargs.ldargs | 2 +- .../bhyvexml2argv-commandline.args | 2 +- .../bhyvexml2argv-commandline.ldargs | 2 +- ...gv-console-master-slave-not-specified.args | 2 +- ...-console-master-slave-not-specified.ldargs | 2 +- .../bhyvexml2argv-console.args | 2 +- .../bhyvexml2argv-console.ldargs | 2 +- .../bhyvexml2argv-cputopology.args | 2 +- .../bhyvexml2argv-cputopology.ldargs | 2 +- .../bhyvexml2argv-custom-loader.args | 2 +- .../bhyvexml2argv-custom-loader.ldargs | 2 +- .../bhyvexml2argv-disk-cdrom-grub.args | 2 +- .../bhyvexml2argv-disk-cdrom-grub.ldargs | 2 +- .../bhyvexml2argv-disk-cdrom.args | 2 +- .../bhyvexml2argv-disk-cdrom.ldargs | 2 +- .../bhyvexml2argv-disk-virtio.args | 2 +- .../bhyvexml2argv-disk-virtio.ldargs | 2 +- .../bhyvexml2argv-firmware-efi.args | 2 +- .../bhyvexml2argv-fs-9p-readonly.args | 2 +- .../bhyvexml2argv-fs-9p-readonly.ldargs | 2 +- .../bhyvexml2argv-fs-9p.args | 2 +- .../bhyvexml2argv-fs-9p.ldargs | 2 +- .../bhyvexml2argv-grub-bootorder.args | 2 +- .../bhyvexml2argv-grub-bootorder.ldargs | 2 +- .../bhyvexml2argv-grub-bootorder2.args | 2 +- .../bhyvexml2argv-grub-bootorder2.ldargs | 2 +- .../bhyvexml2argv-grub-defaults.args | 2 +- .../bhyvexml2argv-grub-defaults.ldargs | 2 +- .../bhyvexml2argv-input-xhci-tablet.args | 2 +- .../bhyvexml2argv-input-xhci-tablet.ldargs | 2 +- .../bhyvexml2argv-isa-controller.args | 2 +- .../bhyvexml2argv-isa-controller.ldargs | 2 +- .../bhyvexml2argv-localtime.args | 2 +- .../bhyvexml2argv-localtime.ldargs | 2 +- .../bhyvexml2argv-macaddr.args | 2 +- .../bhyvexml2argv-macaddr.ldargs | 2 +- .../bhyvexml2argvdata/bhyvexml2argv-msrs.args | 2 +- .../bhyvexml2argv-msrs.ldargs | 2 +- .../bhyvexml2argv-net-e1000.args | 2 +- .../bhyvexml2argv-net-e1000.ldargs | 2 +- .../bhyvexml2argv-serial-grub-nocons.args | 2 +- .../bhyvexml2argv-serial-grub-nocons.ldargs | 2 +- .../bhyvexml2argv-serial-grub.args | 2 +- .../bhyvexml2argv-serial-grub.ldargs | 2 +- .../bhyvexml2argv-serial.args | 2 +- .../bhyvexml2argv-serial.ldargs | 2 +- .../bhyvexml2argv-sound.args | 2 +- .../bhyvexml2argv-sound.ldargs | 2 +- .../bhyvexml2argvdata/bhyvexml2argv-uefi.args | 2 +- .../bhyvexml2argv-vnc-autoport.args | 2 +- .../bhyvexml2argv-vnc-password.args | 2 +- .../bhyvexml2argv-vnc-resolution.args | 2 +- .../bhyvexml2argv-vnc-vgaconf-io.args | 2 +- .../bhyvexml2argv-vnc-vgaconf-off.args | 2 +- .../bhyvexml2argv-vnc-vgaconf-on.args | 2 +- .../bhyvexml2argvdata/bhyvexml2argv-vnc.args | 2 +- .../bhyvexml2argv-wired.args | 2 +- .../bhyvexml2argv-wired.ldargs | 2 +- tests/bhyvexml2argvtest.c | 4 +- tests/domaincapsmock.c | 17 ++ tests/meson.build | 1 + tests/networkxml2conftest.c | 6 +- tests/networkxml2firewalltest.c | 16 +- tests/nwfilterebiptablestest.c | 15 +- tests/nwfilterxml2firewalltest.c | 14 +- tests/qemuxml2argvmock.c | 5 +- tests/testutilsqemu.c | 15 -- tests/virfirewallmock.c | 35 +++ tests/virfirewalltest.c | 15 +- 132 files changed, 403 insertions(+), 484 deletions(-) create mode 100644 tests/virfirewallmock.c -- 2.30.2

4 44

[PATCH] qemu.conf: add max-ram-below-4g option
by yezhiyong 21 Apr '21

21 Apr '21

Limit the amount of ram below 4G. This helps in scenarios like GPU passthrough when the GPA used by DMA device is conflict with the decode window of a host bridge and the address translation request to iommu isn't launched, which causes address overlapping. Note that currently this can be triggered by some abnormal behavior of hardware. In the general case, this option needs to be configured when virtual machines share the same host, which is why using qemu.conf to support per-host configuration. Signed-off-by: yezhiyong <yezhiyong(a)bytedance.com> Signed-off-by: zhenwei pi <pizhenwei(a)bytedance.com> Signed-off-by: zhangruien <zhangruien(a)bytedance.com> --- src/qemu/qemu.conf | 8 ++++++++ src/qemu/qemu_command.c | 4 ++++ src/qemu/qemu_conf.c | 5 +++++ src/qemu/qemu_conf.h | 1 + 4 files changed, 18 insertions(+) diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf index 8722dc169c..f09c89486e 100644 --- a/src/qemu/qemu.conf +++ b/src/qemu/qemu.conf @@ -898,6 +898,14 @@ # NOTE: big files will be stored here #memory_backing_dir = "/var/lib/libvirt/qemu/ram" +# Limit the amount of ram below 4G. This helps in scenarios like +# GPU passthrough when the GPA used by DMA device is comflict with +# the decode window of a host bridge and the address translation +# request to iommu isn't launched, which causes address overlapping. +# Note that currently this can be triggered by some abnormal behavior +# of hardware. +#max_ram_below_4g = "2G" + # Path to the SCSI persistent reservations helper. This helper is # used whenever <reservations/> are enabled for SCSI LUN devices. #pr_helper = "/usr/bin/qemu-pr-helper" diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 2f69a79bc0..fd5e14c500 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -6960,6 +6960,10 @@ qemuBuildMachineCommandLine(virCommand *cmd, cfg->dumpGuestCore ? "on" : "off"); } + if (cfg->maxRamBelow4G) + virBufferAsprintf(&buf, ",max-ram-below-4g=%s", + cfg->maxRamBelow4G); + if (def->mem.nosharepages) virBufferAddLit(&buf, ",mem-merge=off"); diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 916a3d36ee..b718995870 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -384,6 +384,8 @@ static void virQEMUDriverConfigDispose(void *obj) g_strfreev(cfg->capabilityfilters); g_free(cfg->deprecationBehavior); + + g_free(cfg->maxRamBelow4G); } @@ -1001,6 +1003,9 @@ virQEMUDriverConfigLoadMemoryEntry(virQEMUDriverConfig *cfg, g_autofree char *dir = NULL; int rc; + if (virConfGetValueString(conf, "max_ram_below_4g", &cfg->maxRamBelow4G) < 0) + return -1; + if ((rc = virConfGetValueString(conf, "memory_backing_dir", &dir)) < 0) { return -1; } else if (rc > 0) { diff --git a/src/qemu/qemu_conf.h b/src/qemu/qemu_conf.h index 2f64e39a18..ff558e2fdb 100644 --- a/src/qemu/qemu_conf.h +++ b/src/qemu/qemu_conf.h @@ -216,6 +216,7 @@ struct _virQEMUDriverConfig { bool virtiofsdDebug; char *memoryBackingDir; + char *maxRamBelow4G; uid_t swtpm_user; gid_t swtpm_group; -- 2.24.3 (Apple Git-128)

4 5

[PATCH] qemu: blockjob: Transition into 'ready' state only from expected states
by Peter Krempa 21 Apr '21

21 Apr '21

In certain rare occasions qemu can transition a block job which was already 'ready' into 'standby' and then back. If this happens in the following order libvirt will get confused about the actual job state: 1) the block copy job is 'ready' (job->state == QEMU_BLOCKJOB_STATE_READY) 2) user calls qemuDomainBlockJobAbort with VIR_DOMAIN_BLOCK_JOB_ABORT_PIVOT flag but without VIR_DOMAIN_BLOCK_JOB_ABORT_ASYNC 3) the block job is switched to synchronous event handling 4) the block job blips to 'standby' and back to 'ready', the event is not processed since the blockjob is in sync mode for now 5) qemuDomainBlockJobPivot is called: 5.1) 'job-complete' QMP command is issued 5.2) job->state is set to QEMU_BLOCKJOB_STATE_PIVOTING 6) code for synchronous-wait for the job completion in qemuDomainBlockJobAbort is invoked 7) the waiting loop calls qemuBlockJobUpdate: 7.1) job->newstate is QEMU_BLOCKJOB_STATE_READY due to 4) 7.2) qemuBlockJobEventProcess is called 7.3) the handler for QEMU_BLOCKJOB_STATE_READY overwrites job->state from QEMU_BLOCKJOB_STATE_PIVOTING to QEMU_BLOCKJOB_STATE_READY 8) qemuDomainBlockJobAbort is looking for a finished job, so waits again 9) qemu finishes the blockjob and transitions it into 'concluded' state 10) qemuBlockJobUpdate is triggered again, this time finalizing the job. 10.1) job->newstate is = QEMU_BLOCKJOB_STATE_CONCLUDED job->state is = QEMU_BLOCKJOB_STATE_READY 10.2) qemuBlockJobEventProcessConcluded is called, the function checks whether there was an error with the blockjob. Since there was no error job->newstate becomes QEMU_BLOCKJOB_STATE_COMPLETED. 10.3) qemuBlockJobEventProcessConcludedTransition selects the action for the appropriate block job type where we have: case QEMU_BLOCKJOB_TYPE_COPY: if (job->state == QEMU_BLOCKJOB_STATE_PIVOTING && success) qemuBlockJobProcessEventConcludedCopyPivot(driver, vm, job, asyncJob); else qemuBlockJobProcessEventConcludedCopyAbort(driver, vm, job, asyncJob); break; Since job->state is QEMU_BLOCKJOB_STATE_READY, qemuBlockJobProcessEventConcludedCopyAbort is called. This patch forbids transitions to QEMU_BLOCKJOB_STATE_READY if the previous job state isn't QEMU_BLOCKJOB_STATE_RUNNING or QEMU_BLOCKJOB_STATE_NEW. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1951507 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_blockjob.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_blockjob.c index 21fcc29ddb..9ae4500f4d 100644 --- a/src/qemu/qemu_blockjob.c +++ b/src/qemu/qemu_blockjob.c @@ -1697,14 +1697,21 @@ qemuBlockJobEventProcess(virQEMUDriver *driver, break; case QEMU_BLOCKJOB_STATE_READY: - /* mirror may be NULL for copy job corresponding to migration */ - if (job->disk) { - job->disk->mirrorState = VIR_DOMAIN_DISK_MIRROR_STATE_READY; - qemuBlockJobEmitEvents(driver, vm, job->disk, job->type, job->newstate); + /* in certain cases qemu can blip out and back into 'ready' state for + * a blockjob. In cases when we already are past RUNNING the job such + * as when pivoting/aborting this could reset the internally set job + * state, thus we ignore it if the job isn't in expected state */ + if (job->state == QEMU_BLOCKJOB_STATE_NEW || + job->state == QEMU_BLOCKJOB_STATE_RUNNING) { + /* mirror may be NULL for copy job corresponding to migration */ + if (job->disk) { + job->disk->mirrorState = VIR_DOMAIN_DISK_MIRROR_STATE_READY; + qemuBlockJobEmitEvents(driver, vm, job->disk, job->type, job->newstate); + } + job->state = job->newstate; + qemuDomainSaveStatus(vm); } - job->state = job->newstate; job->newstate = -1; - qemuDomainSaveStatus(vm); break; case QEMU_BLOCKJOB_STATE_NEW: -- 2.30.2

3 3

[libvirt PATCH 0/4] Some memory leaks related fixes
by Tim Wiederhake 21 Apr '21

21 Apr '21

Patch #1 is a resend of https://listman.redhat.com/archives/libvir-list/2021-April/msg00600.html Patch #2 is a fix for a mistake in https://listman.redhat.com/archives/libvir-list/2021-April/msg00782.html Patches #3 and #4 are the replacement for https://listman.redhat.com/archives/libvir-list/2021-April/msg00643.html Cheers, Tim Tim Wiederhake (4): virxml: Fix schema validation of individual nodes xenParseHypervisorFeatures: Remove superfluous VIR_FREE qemu: Introduce virQEMUCapsUpdateHostCPUModel testUpdateQEMUCaps: Fix memory leak src/conf/cpu_conf.c | 3 +-- src/libxl/xen_common.c | 1 - src/qemu/qemu_capabilities.c | 9 +++++++++ src/qemu/qemu_capspriv.h | 4 ++++ src/util/virxml.c | 13 ++++++------- src/util/virxml.h | 1 - tests/qemuxml2argvtest.c | 8 ++++---- 7 files changed, 24 insertions(+), 15 deletions(-) -- 2.26.3

2 6

[libvirt PATCH v4 0/7] spec: Reorganize some packages
by Andrea Bolognani 21 Apr '21

21 Apr '21

Changes from [v3]: * generate per-command bash completion scripts using Meson instead of tweaking the contents after the fact for RPM build; * update documentation as files are moved around and packages are dropped. Changes from [v2]: * move virt-admin to -daemon rather than -client; * move other host-only tools from -client to -daemon; * move systemtap probes from -client to -libs. Changes from [v1]: * add Obsoletes/Provides for a smooth transition. [v3] https://listman.redhat.com/archives/libvir-list/2021-April/msg00900.html [v2] https://listman.redhat.com/archives/libvir-list/2021-April/msg00613.html [v1] https://listman.redhat.com/archives/libvir-list/2021-April/msg00604.html Andrea Bolognani (7): docs: Use consistent vertical spacing docs: Expand upon the contents of the -daemon package spec: Merge -admin package into -daemon spec: Move some files from -client to -daemon spec: Move systemtap probes from -client to -libs tools: Generate per-command bash completion script spec: Drop -bash-completion package docs/kbase/rpm-deployment.rst | 55 ++++--------------- libvirt.spec.in | 76 ++++++++++----------------- tools/bash-completion/meson.build | 24 +++++---- tools/bash-completion/{vsh => vsh.in} | 7 ++- 4 files changed, 54 insertions(+), 108 deletions(-) rename tools/bash-completion/{vsh => vsh.in} (91%) -- 2.26.3

3 9

[libvirt PATCH 1/2] nodedev: fix potential leak of command
by Jonathon Jongsma 21 Apr '21

21 Apr '21

When returning early due to errors, cmd will be leaked. Use an autoptr to handle these early returns without leaking memory. Signed-off-by: Jonathon Jongsma <jjongsma(a)redhat.com> --- src/node_device/node_device_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_device_driver.c index b0cc63ed42..e565cc29ec 100644 --- a/src/node_device/node_device_driver.c +++ b/src/node_device/node_device_driver.c @@ -724,7 +724,7 @@ nodeDeviceGetMdevctlCommand(virNodeDeviceDef *def, char **errbuf) { g_autofree char *parent_addr = NULL; - virCommand *cmd = NULL; + g_autoptr(virCommand) cmd = NULL; const char *subcommand = virMdevctlCommandTypeToString(cmd_type); g_autofree char *inbuf = NULL; @@ -787,7 +787,7 @@ nodeDeviceGetMdevctlCommand(virNodeDeviceDef *def, virCommandSetErrorBuffer(cmd, errbuf); - return cmd; + return g_steal_pointer(&cmd); } -- 2.26.3

2 3

[PATCH 0/2] util: xml: Fix two problems with the new virXMLProp* helpers
by Peter Krempa 21 Apr '21

21 Apr '21

See individual patches for explanation. Peter Krempa (2): util: xml: Remove VIR_XML_PROP_WRAPNEGATIVE util: xml: Fix confusing semantics of VIR_XML_PROP_OPTIONAL flag src/conf/cpu_conf.c | 2 +- src/conf/domain_conf.c | 24 ++++++++++++------------ src/conf/network_conf.c | 2 +- src/util/virxml.c | 6 +----- src/util/virxml.h | 3 +-- 5 files changed, 16 insertions(+), 21 deletions(-) -- 2.30.2

2 3

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code
by Tim Wiederhake 21 Apr '21

21 Apr '21

For background, see https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html Tim Wiederhake (10): virDomainBackupDiskDefParseXML: Use virXMLProp* virDomainBackupDefParse: Use virXMLProp* virZPCIDeviceAddressParseXML: Use virXMLProp* virPCIDeviceAddressParseXML: Use virXMLProp* virDomainDeviceCCWAddressParseXML: Use virXMLProp* virDomainDeviceDriveAddressParseXML: Use virXMLProp* virDomainDeviceVirtioSerialAddressParseXML: Use virXMLProp* virDomainDeviceCcidAddressParseXML: Use virXMLProp* virDomainDeviceUSBAddressParseXML: Use virXMLProp* virInterfaceLinkParseXML: Use virXMLProp* src/conf/backup_conf.c | 57 +++------- src/conf/device_conf.c | 241 ++++++++++++----------------------------- 2 files changed, 84 insertions(+), 214 deletions(-) -- 2.26.2

2 14

[libvirt PATCH v3 0/4] spec: Reorganize some packages
by Andrea Bolognani 20 Apr '21

20 Apr '21

Upgrading to packages built with these patches applied results in $ sudo dnf update ./*.rpm Dependencies resolved. =========================================================================== Package Version =========================================================================== Upgrading: libvirt 7.3.0-1.fc32 libvirt-client 7.3.0-1.fc32 replacing libvirt-bash-completion.x86_64 7.2.0-1.fc32 libvirt-daemon 7.3.0-1.fc32 replacing libvirt-admin.x86_64 7.2.0-1.fc32 replacing libvirt-bash-completion.x86_64 7.2.0-1.fc32 libvirt-daemon-config-network 7.3.0-1.fc32 libvirt-daemon-config-nwfilter 7.3.0-1.fc32 libvirt-daemon-driver-interface 7.3.0-1.fc32 libvirt-daemon-driver-libxl 7.3.0-1.fc32 libvirt-daemon-driver-lxc 7.3.0-1.fc32 libvirt-daemon-driver-network 7.3.0-1.fc32 libvirt-daemon-driver-nodedev 7.3.0-1.fc32 libvirt-daemon-driver-nwfilter 7.3.0-1.fc32 libvirt-daemon-driver-qemu 7.3.0-1.fc32 libvirt-daemon-driver-secret 7.3.0-1.fc32 libvirt-daemon-driver-storage 7.3.0-1.fc32 libvirt-daemon-driver-storage-core 7.3.0-1.fc32 libvirt-daemon-driver-storage-disk 7.3.0-1.fc32 libvirt-daemon-driver-storage-gluster 7.3.0-1.fc32 libvirt-daemon-driver-storage-iscsi 7.3.0-1.fc32 libvirt-daemon-driver-storage-iscsi-direct 7.3.0-1.fc32 libvirt-daemon-driver-storage-logical 7.3.0-1.fc32 libvirt-daemon-driver-storage-mpath 7.3.0-1.fc32 libvirt-daemon-driver-storage-rbd 7.3.0-1.fc32 libvirt-daemon-driver-storage-scsi 7.3.0-1.fc32 libvirt-daemon-driver-storage-sheepdog 7.3.0-1.fc32 libvirt-daemon-driver-storage-zfs 7.3.0-1.fc32 libvirt-daemon-driver-vbox 7.3.0-1.fc32 libvirt-daemon-kvm 7.3.0-1.fc32 libvirt-devel 7.3.0-1.fc32 libvirt-libs 7.3.0-1.fc32 libvirt-nss 7.3.0-1.fc32 Transaction Summary =========================================================================== Upgrade 30 Packages Total size: 8.2 M Is this ok [y/N] which is exactly what we were aiming for. Changes from [v2]: * move virt-admin to -daemon rather than -client; * move other host-only tools from -client to -daemon; * move systemtap probes from -client to -libs. Changes from [v1]: * add Obsoletes/Provides for a smooth transition. [v2] https://listman.redhat.com/archives/libvir-list/2021-April/msg00613.html [v1] https://listman.redhat.com/archives/libvir-list/2021-April/msg00604.html Andrea Bolognani (4): spec: Merge -admin package into -daemon spec: Move some files from -client to -daemon spec: Move systemtap probes from -client to -libs spec: Drop -bash-completion package libvirt.spec.in | 74 ++++++++++++++++++++++++------------------------- 1 file changed, 36 insertions(+), 38 deletions(-) -- 2.26.3

3 12

[libvirt PATCH v2 00/12] Some additional cleanups to mdev support
by Jonathon Jongsma 20 Apr '21

20 Apr '21

Erik recommended several changes to the mdev series that was just merged and suggested to address them in a follow-up patch series. They're mostly related to simplifying the testing, and shouldn't actually change any behavior (aside from switching to using the long commandline options when executing mdevctl). Changes in v2: - rebase to lastest git master Erik Skultety (4): nodedev: driver: Swap virMdevctlStart and virMdevctlCreate nodedev: driver: Introduce internal mdevctl commands enum nodedev: driver: Create a generic mdevctl command translator tests: nodedev: Make the mdevctl test function and helper generic Jonathon Jongsma (8): nodedev: don't log error in nodeDeviceFindAddressByName() nodedev: avoid use of VIR_ERR_NO_* errors internally tests: nodedev: switch all test macros to accept a filename nodedev: Switch to using long options for mdevctl nodedev: Remove GetMdevctl*Command() wrappers tests: nodedev: simplify test macros tests: nodedev: remove unused variable tests: nodedev: remove unnecessary cleanup label src/node_device/node_device_driver.c | 181 +++++++-------- src/node_device/node_device_driver.h | 43 ++-- ...19_36ea_4111_8f0a_8c9a70e21366-create.argv | 5 + ...9_36ea_4111_8f0a_8c9a70e21366-create.json} | 0 ...19_36ea_4111_8f0a_8c9a70e21366-define.argv | 4 +- ...019_36ea_4111_8f0a_8c9a70e21366-start.argv | 2 - ...d019_36ea_4111_8f0a_8c9a70e21366-stop.argv | 3 + ..._36ea_4111_8f0a_8c9a70e21366-undefine.argv | 3 + ...39_495e_4243_ad9f_beb3f14c23d9-create.argv | 4 + ...9_495e_4243_ad9f_beb3f14c23d9-create.json} | 0 ...39_495e_4243_ad9f_beb3f14c23d9-define.argv | 4 +- ...d39_495e_4243_ad9f_beb3f14c23d9-start.argv | 4 - ...16_1ca8_49ac_b176_871d16c13076-create.argv | 4 + ...6_1ca8_49ac_b176_871d16c13076-create.json} | 0 ...16_1ca8_49ac_b176_871d16c13076-define.argv | 4 +- ...916_1ca8_49ac_b176_871d16c13076-start.argv | 4 - tests/nodedevmdevctldata/mdevctl-create.argv | 3 - tests/nodedevmdevctldata/mdevctl-stop.argv | 3 - .../nodedevmdevctldata/mdevctl-undefine.argv | 3 - tests/nodedevmdevctltest.c | 211 ++++++------------ 20 files changed, 197 insertions(+), 288 deletions(-) create mode 100644 tests/nodedevmdevctldata/mdev_d069d019_36ea_4111_8f0a_8c9= a70e21366-create.argv rename tests/nodedevmdevctldata/{mdev_d069d019_36ea_4111_8f0a_8c9a70e21366-s= tart.json =3D> mdev_d069d019_36ea_4111_8f0a_8c9a70e21366-create.json} (100%) create mode 100644 tests/nodedevmdevctldata/mdev_d069d019_36ea_4111_8f0a_8c9= a70e21366-stop.argv create mode 100644 tests/nodedevmdevctldata/mdev_d069d019_36ea_4111_8f0a_8c9= a70e21366-undefine.argv create mode 100644 tests/nodedevmdevctldata/mdev_d2441d39_495e_4243_ad9f_beb= 3f14c23d9-create.argv rename tests/nodedevmdevctldata/{mdev_d2441d39_495e_4243_ad9f_beb3f14c23d9-s= tart.json =3D> mdev_d2441d39_495e_4243_ad9f_beb3f14c23d9-create.json} (100%) delete mode 100644 tests/nodedevmdevctldata/mdev_d2441d39_495e_4243_ad9f_beb= 3f14c23d9-start.argv create mode 100644 tests/nodedevmdevctldata/mdev_fedc4916_1ca8_49ac_b176_871= d16c13076-create.argv rename tests/nodedevmdevctldata/{mdev_fedc4916_1ca8_49ac_b176_871d16c13076-s= tart.json =3D> mdev_fedc4916_1ca8_49ac_b176_871d16c13076-create.json} (100%) delete mode 100644 tests/nodedevmdevctldata/mdev_fedc4916_1ca8_49ac_b176_871= d16c13076-start.argv delete mode 100644 tests/nodedevmdevctldata/mdevctl-create.argv delete mode 100644 tests/nodedevmdevctldata/mdevctl-stop.argv delete mode 100644 tests/nodedevmdevctldata/mdevctl-undefine.argv --=20 2.26.3

4 31

[libvirt PATCH 00/17] drop meson checks for runtime binaries
by Pavel Hrdina 20 Apr '21

20 Apr '21

Recent attempt to add a lot of meson options to specify different runtime paths motivated me enough to cleanup this from meson. Pavel Hrdina (17): bridge_driver: fix comment about dnsmasqCaps virdnsmasq: drop unused dnsmasqCapsNewFromFile function virdnsmasq: drop unused dnsmasqCapsRefresh function virdnsmasq: remove binaryPath argument from dnsmasqCapsNewFromBuffer virdnsmasq: remove binaryPath argument from dnsmasqCapsNewFromBinary virfirewall: use virFindFileInPath instead of virFileIsExecutable tests: introduce virfirewallmock tests: use virfirewallmock instead of hasNetfilterTools virnetdev: move virNetDevSetRootQDisc to virnetdevbandwidth tests: testutilsqemu: move virFindFileInPath into domaincapsmock meson: don't check collie as program for sheepdog bhyvexml2argvtest: use virCommandToStringFull to strip command path storage: use virFindFileInPath to validate presence of mkfs virfile: introduce virFindFileInPathFull() qemu_conf: use virFindFileInPathFull for runtime binaries meson: drop check for runtime binary dependencies meson: optional_programs should be used only for building libvirt meson.build | 180 +----------------- src/bhyve/bhyve_command.c | 4 + src/libvirt_private.syms | 6 +- src/locking/lock_driver_lockd.c | 12 +- src/network/bridge_driver.c | 8 +- src/node_device/node_device_driver.c | 2 + src/qemu/qemu_conf.c | 23 ++- src/qemu/qemu_domain.c | 3 +- src/storage/storage_backend_fs.c | 24 +-- src/storage/storage_backend_logical.c | 13 ++ src/storage/storage_backend_sheepdog.c | 2 + src/storage/storage_backend_zfs.c | 3 + src/storage/storage_util.c | 2 + src/storage/storage_util.h | 6 + src/util/virdnsmasq.c | 56 +----- src/util/virdnsmasq.h | 8 +- src/util/virfile.c | 16 +- src/util/virfile.h | 6 +- src/util/virfirewall.c | 4 +- src/util/virfirewall.h | 4 + src/util/viriscsi.h | 2 + src/util/virkmod.h | 3 + src/util/virnetdev.c | 46 ----- src/util/virnetdev.h | 4 - src/util/virnetdevbandwidth.c | 50 +++++ src/util/virnetdevbandwidth.h | 6 + src/util/virnetdevip.c | 2 + src/util/virnetdevmidonet.c | 2 + src/util/virnetdevopenvswitch.c | 2 + src/util/virnuma.c | 1 + src/util/virsysinfo.c | 1 + src/util/virutil.c | 2 + .../bhyvexml2argv-acpiapic.args | 2 +- .../bhyvexml2argv-acpiapic.ldargs | 2 +- ...ml2argv-addr-isa-controller-on-slot-1.args | 2 +- ...2argv-addr-isa-controller-on-slot-1.ldargs | 2 +- ...l2argv-addr-isa-controller-on-slot-31.args | 2 +- ...argv-addr-isa-controller-on-slot-31.ldargs | 2 +- ...xml2argv-addr-more-than-32-sata-disks.args | 2 +- ...l2argv-addr-more-than-32-sata-disks.ldargs | 2 +- ...hyvexml2argv-addr-multiple-sata-disks.args | 2 +- ...vexml2argv-addr-multiple-sata-disks.ldargs | 2 +- ...vexml2argv-addr-multiple-virtio-disks.args | 2 +- ...xml2argv-addr-multiple-virtio-disks.ldargs | 2 +- ...rgv-addr-no32devs-multiple-sata-disks.args | 2 +- ...v-addr-no32devs-multiple-sata-disks.ldargs | 2 +- ...l2argv-addr-no32devs-single-sata-disk.args | 2 +- ...argv-addr-no32devs-single-sata-disk.ldargs | 2 +- ...rgv-addr-non-isa-controller-on-slot-1.args | 2 +- .../bhyvexml2argv-addr-single-sata-disk.args | 2 +- ...bhyvexml2argv-addr-single-sata-disk.ldargs | 2 +- ...bhyvexml2argv-addr-single-virtio-disk.args | 2 +- ...yvexml2argv-addr-single-virtio-disk.ldargs | 2 +- .../bhyvexml2argvdata/bhyvexml2argv-base.args | 2 +- .../bhyvexml2argv-base.ldargs | 2 +- .../bhyvexml2argv-bhyveload-bootorder.args | 2 +- .../bhyvexml2argv-bhyveload-bootorder.ldargs | 2 +- .../bhyvexml2argv-bhyveload-bootorder1.args | 2 +- .../bhyvexml2argv-bhyveload-bootorder1.ldargs | 2 +- .../bhyvexml2argv-bhyveload-bootorder3.args | 2 +- .../bhyvexml2argv-bhyveload-bootorder3.ldargs | 2 +- .../bhyvexml2argv-bhyveload-explicitargs.args | 2 +- ...hyvexml2argv-bhyveload-explicitargs.ldargs | 2 +- .../bhyvexml2argv-commandline.args | 2 +- .../bhyvexml2argv-commandline.ldargs | 2 +- ...gv-console-master-slave-not-specified.args | 2 +- ...-console-master-slave-not-specified.ldargs | 2 +- .../bhyvexml2argv-console.args | 2 +- .../bhyvexml2argv-console.ldargs | 2 +- .../bhyvexml2argv-cputopology.args | 2 +- .../bhyvexml2argv-cputopology.ldargs | 2 +- .../bhyvexml2argv-custom-loader.args | 2 +- .../bhyvexml2argv-custom-loader.ldargs | 2 +- .../bhyvexml2argv-disk-cdrom-grub.args | 2 +- .../bhyvexml2argv-disk-cdrom-grub.ldargs | 2 +- .../bhyvexml2argv-disk-cdrom.args | 2 +- .../bhyvexml2argv-disk-cdrom.ldargs | 2 +- .../bhyvexml2argv-disk-virtio.args | 2 +- .../bhyvexml2argv-disk-virtio.ldargs | 2 +- .../bhyvexml2argv-firmware-efi.args | 2 +- .../bhyvexml2argv-fs-9p-readonly.args | 2 +- .../bhyvexml2argv-fs-9p-readonly.ldargs | 2 +- .../bhyvexml2argv-fs-9p.args | 2 +- .../bhyvexml2argv-fs-9p.ldargs | 2 +- .../bhyvexml2argv-grub-bootorder.args | 2 +- .../bhyvexml2argv-grub-bootorder.ldargs | 2 +- .../bhyvexml2argv-grub-bootorder2.args | 2 +- .../bhyvexml2argv-grub-bootorder2.ldargs | 2 +- .../bhyvexml2argv-grub-defaults.args | 2 +- .../bhyvexml2argv-grub-defaults.ldargs | 2 +- .../bhyvexml2argv-input-xhci-tablet.args | 2 +- .../bhyvexml2argv-input-xhci-tablet.ldargs | 2 +- .../bhyvexml2argv-isa-controller.args | 2 +- .../bhyvexml2argv-isa-controller.ldargs | 2 +- .../bhyvexml2argv-localtime.args | 2 +- .../bhyvexml2argv-localtime.ldargs | 2 +- .../bhyvexml2argv-macaddr.args | 2 +- .../bhyvexml2argv-macaddr.ldargs | 2 +- .../bhyvexml2argvdata/bhyvexml2argv-msrs.args | 2 +- .../bhyvexml2argv-msrs.ldargs | 2 +- .../bhyvexml2argv-net-e1000.args | 2 +- .../bhyvexml2argv-net-e1000.ldargs | 2 +- .../bhyvexml2argv-serial-grub-nocons.args | 2 +- .../bhyvexml2argv-serial-grub-nocons.ldargs | 2 +- .../bhyvexml2argv-serial-grub.args | 2 +- .../bhyvexml2argv-serial-grub.ldargs | 2 +- .../bhyvexml2argv-serial.args | 2 +- .../bhyvexml2argv-serial.ldargs | 2 +- .../bhyvexml2argv-sound.args | 2 +- .../bhyvexml2argv-sound.ldargs | 2 +- .../bhyvexml2argvdata/bhyvexml2argv-uefi.args | 2 +- .../bhyvexml2argv-vnc-autoport.args | 2 +- .../bhyvexml2argv-vnc-password.args | 2 +- .../bhyvexml2argv-vnc-resolution.args | 2 +- .../bhyvexml2argv-vnc-vgaconf-io.args | 2 +- .../bhyvexml2argv-vnc-vgaconf-off.args | 2 +- .../bhyvexml2argv-vnc-vgaconf-on.args | 2 +- .../bhyvexml2argvdata/bhyvexml2argv-vnc.args | 2 +- .../bhyvexml2argv-wired.args | 2 +- .../bhyvexml2argv-wired.ldargs | 2 +- tests/bhyvexml2argvtest.c | 4 +- tests/domaincapsmock.c | 17 ++ tests/meson.build | 1 + tests/networkxml2conftest.c | 6 +- tests/networkxml2firewalltest.c | 16 +- tests/nwfilterebiptablestest.c | 15 +- tests/nwfilterxml2firewalltest.c | 14 +- tests/qemuxml2argvmock.c | 5 +- tests/testutilsqemu.c | 15 -- tests/virfirewallmock.c | 35 ++++ tests/virfirewalltest.c | 15 +- 131 files changed, 340 insertions(+), 482 deletions(-) create mode 100644 tests/virfirewallmock.c -- 2.30.2

5 28

[libvirt PATCH v2 0/5] Fix some memory leaks
by Tim Wiederhake 20 Apr '21

20 Apr '21

Issues were found by llvm's asan and ubsan sanitizers. V1: https://listman.redhat.com/archives/libvir-list/2021-April/msg00640.html Changes since V1: * Edited patch #1 to use two g_autofree variables instead of VIR_FREE'ing a reused variable * Removed "virQEMUCapsSetHostModel: Fix memory leak", I will address this issue seperately * Added fixes for two more memory leaks and one issue found by ubsan (passing NULL to qsort) Tim Wiederhake (5): xenParseHypervisorFeatures: Fix memory leak virDomainFeaturesDefParse: Fix memory leak cmdCheckpointList: Fix memory leak cmdSnapshotList: Fix memory leak virshCheckpointListCollect: Do not pass NULL to qsort src/conf/domain_conf.c | 2 +- src/libxl/xen_common.c | 28 +++++++++++++++------------- tools/virsh-checkpoint.c | 5 +++-- tools/virsh-snapshot.c | 2 +- 4 files changed, 20 insertions(+), 17 deletions(-) -- 2.26.3

2 10

[PATCH for-7.4.0 00/38] qemu: Remove support for qemu-1.5 - qemu-2.10 and clean up capabilities
by Peter Krempa 20 Apr '21

20 Apr '21

May 7, 2021 is the 2nd anniversary of release of rhel-8, which means we no longer have to support qemu-1.5. Remove the capabilities and test data for the versions we no longer care about and clean up some capabilities related stuff: - remove code for QEMU_CAPS_DEVICE_VIDEO_PRIMARY - remove checking for QEMU_CAPS_QUERY_QMP_SCHEMA since all versions now support it This is also a good opportunity to clean up few things regarding the capabilties test data, namely call 'query-qmp-schema' before 'query-commands' to prepare to retire query-commands. This series is heavily truncated since there were massive (27MiB) patches resulting from some of the mechanical (and generated) changes and also depends on my previous command line wrapping cleanup. Fetch the full version at: git fetch https://gitlab.com/pipo.sk/libvirt.git qemu-deprec-3 The massive move of 'query-qmp-schema' query and reply before the 'query-commands' invocation in patch 30 was done using a tool based on pieces of our code which I've uploaded to: https://gitlab.com/pipo.sk/libvirt/-/commits/qemu-capabilities-tool rfc->v1: - pushed ACKed cleanup patches which weren't bound to this series - reworded the news addition as requested - squashed removal of test files to patches dropping the tests - cleaned up the rest of always-asserted capabilities (patches 31-38) Patch 2/38 needs to be adjusted once libvirt-7.3 is out. Peter Krempa (38): qemu: Formally deprecate support for qemu < 2.11 NEWS: Mention that minimum supported qemu version was bumped to 2.11 qemuxml2argvtest: Remove versioned tests for qemu < 2.11 qemuxml2xmltest: Remove versioned tests for qemu < 2.11 qemucapabilitiesdata: Drop capability test data for qemu < 2.11 virQEMUCapsHasPCIMultiBus: Remove logic for PPC multibus support check qemuAssignDeviceControllerAlias: Remove unused 'qemuCaps' argument qemuBuildDeviceAddressStr: Remove unused 'qemuCaps' virQEMUCapsInitProcessCaps: Remove obsolete version checks virQEMUCapsInitQMPVersionCaps: Remove unneeded version checks qemu: capabilities: Move setting of QEMU_CAPS_CPU_AARCH64_OFF to virQEMUCapsInitQMPBasicArch qemuxml2argvtest: Remove negative test case 'pseries-features-htp-resize' qemu: capabilities: Move setting of PPC specific flags to virQEMUCapsInitQMPBasicArch qemuxml2argvtest: Remove negative test for gic v3/host qemu: capabilities: Move setting of QEMU_CAPS_MACH_VIRT_GIC_VERSION to virQEMUCapsInitQMPBasicArch qemuxml2argvtest: Remove negative test case for 'net-vhostuser-multiq' qemuxml2argvtest: Remove tests for absence of QEMU_CAPS_DEVICE_VIDEO_PRIMARY qemu: capabilities: Move setting QEMU_CAPS_DEVICE_VIDEO_PRIMARY to virQEMUCapsInitQMPBasicArch qemuxml2(argv|xml)test: Retire QEMU_CAPS_DEVICE_VIDEO_PRIMARY from tests qemu: capabilities: Move rest of always present caps to virQEMUCapsInitQMPArch qemuhotplugtest: Add also always-present capabilities qemu: command: Remove legacy '-vga' commandline formatter qemu_domain_address: Drop compatibility with pre-device vga specification for i440fx qemu_domain_address: Drop compatibility with pre-device vga specification for q35 qemuDomainValidateDevicePCISlotsChipsets: Remove unused @qemuCaps qemu: capabilities: Retire QEMU_CAPS_DEVICE_VIDEO_PRIMARY qemu: capabilities: Always assume QEMU_CAPS_QUERY_QMP_SCHEMA qemu: monitor: Remove qemuMonitorGetEvents qemu: monitor: Remove qemuMonitorSupportsActiveCommit qemu: capabilities: Probe QMP schema before probing commands qemu: capabilities: Retire QEMU_CAPS_MACHINE_IOMMU qemu: capabilities: Fix detection of 'vmport' qemu: capabilities: Retire QEMU_CAPS_VHOSTUSER_MULTIQUEUE qemu: capabilities: Retire QEMU_CAPS_MACHINE_SMM_OPT qemu: capabilities: Retire QEMU_CAPS_SDL_GL qemu: capabilities: Retire QEMU_CAPS_MACHINE_KERNEL_IRQCHIP_SPLIT qemu: capabilities: Retire QEMU_CAPS_EGL_HEADLESS qemu: capabilities: Retire QEMU_CAPS_NUMA_DIST NEWS.rst | 7 + docs/drvqemu.rst | 2 +- src/qemu/qemu_alias.c | 5 +- src/qemu/qemu_alias.h | 1 - src/qemu/qemu_capabilities.c | 177 +- src/qemu/qemu_capabilities.h | 21 +- src/qemu/qemu_command.c | 209 +- src/qemu/qemu_domain.c | 11 +- src/qemu/qemu_domain_address.c | 82 +- src/qemu/qemu_hotplug.c | 2 +- src/qemu/qemu_monitor.c | 23 - src/qemu/qemu_monitor.h | 3 - src/qemu/qemu_monitor_json.c | 90 - src/qemu/qemu_monitor_json.h | 6 - src/qemu/qemu_validate.c | 49 +- .../caps_1.5.3.x86_64.replies | 3327 -- .../caps_1.5.3.x86_64.xml | 176 - .../caps_1.6.0.x86_64.replies | 3298 -- .../caps_1.6.0.x86_64.xml | 185 - .../caps_1.7.0.x86_64.replies | 3521 -- .../caps_1.7.0.x86_64.xml | 191 - .../caps_2.1.1.x86_64.replies | 4041 -- .../caps_2.1.1.x86_64.xml | 217 - .../caps_2.10.0.aarch64.replies | 16975 ------ .../caps_2.10.0.aarch64.xml | 325 - .../caps_2.10.0.ppc64.replies | 20756 ------- .../caps_2.10.0.ppc64.xml | 1067 - .../caps_2.10.0.s390x.replies | 16608 ------ .../caps_2.10.0.s390x.xml | 1277 - .../caps_2.10.0.x86_64.replies | 19329 ------- .../caps_2.10.0.x86_64.xml | 997 - .../caps_2.11.0.s390x.replies | 24402 ++++---- .../caps_2.11.0.s390x.xml | 10 - .../caps_2.11.0.x86_64.replies | 25714 ++++----- .../caps_2.11.0.x86_64.xml | 9 - .../caps_2.12.0.aarch64.replies | 29184 +++++----- .../caps_2.12.0.aarch64.xml | 9 - .../caps_2.12.0.ppc64.replies | 31498 +++++------ .../caps_2.12.0.ppc64.xml | 10 - .../caps_2.12.0.s390x.replies | 27150 ++++----- .../caps_2.12.0.s390x.xml | 10 - .../caps_2.12.0.x86_64.replies | 30348 +++++----- .../caps_2.12.0.x86_64.xml | 9 - .../caps_2.4.0.x86_64.replies | 4868 -- .../caps_2.4.0.x86_64.xml | 263 - .../caps_2.5.0.x86_64.replies | 12506 ----- .../caps_2.5.0.x86_64.xml | 273 - .../caps_2.6.0.aarch64.replies | 13317 ----- .../caps_2.6.0.aarch64.xml | 283 - .../caps_2.6.0.ppc64.replies | 15692 ------ .../qemucapabilitiesdata/caps_2.6.0.ppc64.xml | 1026 - .../caps_2.6.0.x86_64.replies | 13061 ----- .../caps_2.6.0.x86_64.xml | 273 - .../caps_2.7.0.s390x.replies | 12137 ---- .../qemucapabilitiesdata/caps_2.7.0.s390x.xml | 113 - .../caps_2.7.0.x86_64.replies | 13680 ----- .../caps_2.7.0.x86_64.xml | 284 - .../caps_2.8.0.s390x.replies | 13553 ----- .../qemucapabilitiesdata/caps_2.8.0.s390x.xml | 265 - .../caps_2.8.0.x86_64.replies | 14594 ----- .../caps_2.8.0.x86_64.xml | 419 - .../caps_2.9.0.ppc64.replies | 19514 ------- .../qemucapabilitiesdata/caps_2.9.0.ppc64.xml | 1056 - .../caps_2.9.0.s390x.replies | 14607 ----- .../qemucapabilitiesdata/caps_2.9.0.s390x.xml | 273 - .../caps_2.9.0.x86_64.replies | 18290 ------ .../caps_2.9.0.x86_64.xml | 910 - .../caps_3.0.0.ppc64.replies | 32840 +++++------ .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 10 - .../caps_3.0.0.riscv32.replies | 21708 ++++---- .../caps_3.0.0.riscv32.xml | 10 - .../caps_3.0.0.riscv64.replies | 21708 ++++---- .../caps_3.0.0.riscv64.xml | 10 - .../caps_3.0.0.s390x.replies | 28078 +++++----- .../qemucapabilitiesdata/caps_3.0.0.s390x.xml | 10 - .../caps_3.0.0.x86_64.replies | 31462 +++++------ .../caps_3.0.0.x86_64.xml | 9 - .../caps_3.1.0.ppc64.replies | 32540 +++++------ .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 10 - .../caps_3.1.0.x86_64.replies | 32302 +++++------ .../caps_3.1.0.x86_64.xml | 9 - .../caps_4.0.0.aarch64.replies | 31300 +++++------ .../caps_4.0.0.aarch64.xml | 9 - .../caps_4.0.0.ppc64.replies | 33522 +++++------ .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 10 - .../caps_4.0.0.riscv32.replies | 29066 +++++----- .../caps_4.0.0.riscv32.xml | 10 - .../caps_4.0.0.riscv64.replies | 29066 +++++----- .../caps_4.0.0.riscv64.xml | 10 - .../caps_4.0.0.s390x.replies | 29544 +++++----- .../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 10 - .../caps_4.0.0.x86_64.replies | 32926 +++++------ .../caps_4.0.0.x86_64.xml | 9 - .../caps_4.1.0.x86_64.replies | 34448 ++++++------ .../caps_4.1.0.x86_64.xml | 9 - .../caps_4.2.0.aarch64.replies | 33728 ++++++------ .../caps_4.2.0.aarch64.xml | 9 - .../caps_4.2.0.ppc64.replies | 34230 ++++++------ .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 10 - .../caps_4.2.0.s390x.replies | 31044 +++++------ .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 10 - .../caps_4.2.0.x86_64.replies | 37040 ++++++------- .../caps_4.2.0.x86_64.xml | 9 - .../caps_5.0.0.aarch64.replies | 36328 ++++++------ .../caps_5.0.0.aarch64.xml | 9 - .../caps_5.0.0.ppc64.replies | 37728 ++++++------- .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 10 - .../caps_5.0.0.riscv64.replies | 32792 +++++------ .../caps_5.0.0.riscv64.xml | 10 - .../caps_5.0.0.x86_64.replies | 39754 +++++++------- .../caps_5.0.0.x86_64.xml | 9 - .../caps_5.1.0.sparc.replies | 25244 ++++----- .../qemucapabilitiesdata/caps_5.1.0.sparc.xml | 10 - .../caps_5.1.0.x86_64.replies | 41046 +++++++------- .../caps_5.1.0.x86_64.xml | 9 - .../caps_5.2.0.aarch64.replies | 38490 ++++++------- .../caps_5.2.0.aarch64.xml | 9 - .../caps_5.2.0.ppc64.replies | 40514 +++++++------- .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 10 - .../caps_5.2.0.riscv64.replies | 34452 ++++++------ .../caps_5.2.0.riscv64.xml | 10 - .../caps_5.2.0.s390x.replies | 35480 ++++++------ .../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 10 - .../caps_5.2.0.x86_64.replies | 42432 +++++++------- .../caps_5.2.0.x86_64.xml | 9 - .../caps_6.0.0.x86_64.replies | 45838 ++++++++-------- .../caps_6.0.0.x86_64.xml | 9 - tests/qemuhotplugtest.c | 5 + .../ppc64-modern-bulk-result-conf.xml | 2 +- .../ppc64-modern-bulk-result-live.xml | 2 +- .../ppc64-modern-individual-result-conf.xml | 2 +- .../ppc64-modern-individual-result-live.xml | 2 +- .../x86-modern-bulk-result-conf.xml | 2 +- .../x86-modern-bulk-result-live.xml | 2 +- .../x86-modern-individual-add-result-conf.xml | 2 +- .../x86-modern-individual-add-result-live.xml | 2 +- .../x86-old-bulk-result-conf.xml | 2 +- .../x86-old-bulk-result-live.xml | 2 +- .../qemuhotplug-ivshmem-doorbell-detach.xml | 2 +- .../qemuhotplug-ivshmem-plain-detach.xml | 2 +- .../qemuhotplug-watchdog-full.xml | 2 +- .../qemuhotplug-watchdog-user-alias-full.xml | 2 +- .../qemuhotplug-base-live+disk-virtio.xml | 2 +- .../qemuhotplug-base-live+hostdev-pci.xml | 2 +- .../qemuhotplug-base-live+interface-vdpa.xml | 2 +- ...qemuhotplug-base-live+ivshmem-doorbell.xml | 4 +- .../qemuhotplug-base-live+ivshmem-plain.xml | 2 +- ...uhotplug-base-live+watchdog-user-alias.xml | 2 +- .../qemuhotplug-base-live+watchdog.xml | 2 +- ...hotplug-base-with-scsi-controller-live.xml | 8 +- ...thout-scsi-controller-live+disk-scsi-2.xml | 8 +- tests/qemumonitorjsontest.c | 44 - .../aarch64-aavmf-virtio-mmio.args | 2 +- tests/qemuxml2argvdata/aarch64-acpi-uefi.args | 2 +- .../aarch64-cpu-passthrough.args | 2 +- tests/qemuxml2argvdata/aarch64-gic-host.err | 1 - tests/qemuxml2argvdata/aarch64-gic-v3.err | 1 - .../aarch64-noacpi-nouefi.args | 2 +- .../qemuxml2argvdata/aarch64-noacpi-uefi.args | 2 +- .../qemuxml2argvdata/aarch64-pci-serial.args | 2 +- .../aarch64-traditional-pci.args | 2 +- .../aarch64-usb-controller-nec-xhci.args | 2 +- .../aarch64-usb-controller-qemu-xhci.args | 2 +- .../aarch64-video-default.args | 2 +- .../aarch64-video-virtio-gpu-pci.args | 2 +- .../aarch64-virt-2.6-virtio-pci-default.args | 2 +- .../aarch64-virt-default-nic.args | 2 +- .../qemuxml2argvdata/aarch64-virt-virtio.args | 2 +- .../aarch64-virtio-pci-default.args | 2 +- .../aarch64-virtio-pci-manual-addresses.args | 2 +- tests/qemuxml2argvdata/audio-default-sdl.args | 2 +- .../qemuxml2argvdata/audio-default-spice.args | 2 +- tests/qemuxml2argvdata/audio-default-vnc.args | 2 +- tests/qemuxml2argvdata/autoindex.args | 2 +- .../qemuxml2argvdata/balloon-device-auto.args | 2 +- .../balloon-mmio-deflate.args | 2 +- tests/qemuxml2argvdata/bios-nvram-secure.args | 2 +- tests/qemuxml2argvdata/bios-nvram.args | 2 +- tests/qemuxml2argvdata/bios.args | 2 +- tests/qemuxml2argvdata/blkiotune-device.args | 2 +- tests/qemuxml2argvdata/blkiotune.args | 2 +- tests/qemuxml2argvdata/boot-complex.args | 8 +- .../boot-menu-disable-drive.args | 2 +- tests/qemuxml2argvdata/boot-menu-disable.args | 2 +- .../boot-menu-enable-with-timeout.args | 2 +- tests/qemuxml2argvdata/boot-menu-enable.args | 2 +- tests/qemuxml2argvdata/boot-multi.args | 2 +- tests/qemuxml2argvdata/boot-order.args | 6 +- tests/qemuxml2argvdata/boot-strict.args | 8 +- tests/qemuxml2argvdata/channel-guestfwd.args | 2 +- tests/qemuxml2argvdata/channel-spicevmc.args | 2 +- .../channel-unix-guestfwd.x86_64-2.5.0.args | 33 - .../qemuxml2argvdata/channel-virtio-auto.args | 6 +- .../channel-virtio-autoadd.args | 6 +- .../channel-virtio-autoassign.args | 4 +- .../channel-virtio-default.args | 4 +- .../channel-virtio-state.args | 2 +- .../qemuxml2argvdata/channel-virtio-unix.args | 2 +- tests/qemuxml2argvdata/channel-virtio.args | 2 +- tests/qemuxml2argvdata/chardev-reconnect.args | 4 +- tests/qemuxml2argvdata/clock-catchup.args | 2 +- tests/qemuxml2argvdata/clock-france.args | 2 +- tests/qemuxml2argvdata/clock-hpet-off.args | 2 +- .../clock-localtime-basis-localtime.args | 2 +- .../clock-timer-hyperv-rtc.args | 2 +- tests/qemuxml2argvdata/clock-variable.args | 2 +- .../qemuxml2argvdata/console-compat-auto.args | 2 +- .../console-compat-chardev.args | 2 +- .../qemuxml2argvdata/console-virtio-many.args | 4 +- .../console-virtio-unix.x86_64-2.5.0.args | 34 - tests/qemuxml2argvdata/console-virtio.args | 4 +- tests/qemuxml2argvdata/controller-order.args | 2 +- tests/qemuxml2argvdata/cpu-Haswell-noTSX.args | 2 +- tests/qemuxml2argvdata/cpu-Haswell.args | 2 +- tests/qemuxml2argvdata/cpu-Haswell2.args | 2 +- tests/qemuxml2argvdata/cpu-Haswell3.args | 2 +- tests/qemuxml2argvdata/cpu-cache-disable.args | 2 +- .../qemuxml2argvdata/cpu-cache-disable2.args | 2 +- .../qemuxml2argvdata/cpu-cache-disable3.args | 2 +- .../cpu-cache-emulate-l3.args | 2 +- .../cpu-cache-passthrough.args | 2 +- .../cpu-cache-passthrough2.args | 2 +- .../cpu-check-default-none.args | 2 +- .../cpu-check-default-none2.args | 2 +- .../cpu-check-default-partial.args | 2 +- .../cpu-check-default-partial2.args | 2 +- tests/qemuxml2argvdata/cpu-check-none.args | 2 +- tests/qemuxml2argvdata/cpu-eoi-disabled.args | 2 +- tests/qemuxml2argvdata/cpu-eoi-enabled.args | 2 +- tests/qemuxml2argvdata/cpu-exact1.args | 2 +- .../cpu-exact2-nofallback.args | 2 +- tests/qemuxml2argvdata/cpu-exact2.args | 2 +- tests/qemuxml2argvdata/cpu-fallback.args | 2 +- tests/qemuxml2argvdata/cpu-host-kvmclock.args | 2 +- .../qemuxml2argvdata/cpu-host-model-cmt.args | 2 +- .../cpu-host-model-fallback.args | 2 +- .../cpu-host-model-vendor.args | 2 +- tests/qemuxml2argvdata/cpu-host-model.args | 2 +- .../cpu-host-passthrough-features.args | 2 +- .../cpu-host-passthrough.args | 2 +- .../qemuxml2argvdata/cpu-hotplug-startup.args | 2 +- tests/qemuxml2argvdata/cpu-kvmclock.args | 2 +- tests/qemuxml2argvdata/cpu-minimum1.args | 2 +- tests/qemuxml2argvdata/cpu-minimum2.args | 2 +- .../cpu-no-removed-features.args | 2 +- tests/qemuxml2argvdata/cpu-numa-disjoint.args | 2 +- .../qemuxml2argvdata/cpu-numa-memshared.args | 2 +- .../cpu-numa-no-memory-element.args | 2 +- tests/qemuxml2argvdata/cpu-numa1.args | 2 +- tests/qemuxml2argvdata/cpu-numa2.args | 2 +- tests/qemuxml2argvdata/cpu-strict1.args | 2 +- tests/qemuxml2argvdata/cpu-topology1.args | 2 +- tests/qemuxml2argvdata/cpu-topology2.args | 2 +- tests/qemuxml2argvdata/cpu-topology3.args | 2 +- tests/qemuxml2argvdata/cpu-tsc-frequency.args | 2 +- .../qemuxml2argvdata/cputune-zero-shares.args | 2 +- tests/qemuxml2argvdata/cputune.args | 2 +- tests/qemuxml2argvdata/debug-threads.args | 2 +- .../default-kvm-host-arch.args | 2 +- .../default-qemu-host-arch.args | 2 +- tests/qemuxml2argvdata/disk-aio.args | 2 +- tests/qemuxml2argvdata/disk-blockio.args | 2 +- .../disk-cache.x86_64-1.5.3.args | 38 - .../disk-cache.x86_64-2.6.0.args | 40 - .../disk-cache.x86_64-2.7.0.args | 40 - .../qemuxml2argvdata/disk-cdrom-network.args | 2 +- tests/qemuxml2argvdata/disk-cdrom-tray.args | 2 +- tests/qemuxml2argvdata/disk-copy_on_read.args | 4 +- tests/qemuxml2argvdata/disk-floppy-tray.args | 2 +- tests/qemuxml2argvdata/disk-geometry.args | 2 +- tests/qemuxml2argvdata/disk-ide-split.args | 2 +- tests/qemuxml2argvdata/disk-ide-wwn.args | 2 +- tests/qemuxml2argvdata/disk-ioeventfd.args | 4 +- .../disk-network-gluster.args | 6 +- .../disk-network-iscsi-modern.args | 10 +- .../qemuxml2argvdata/disk-network-iscsi.args | 10 +- tests/qemuxml2argvdata/disk-network-nbd.args | 10 +- .../disk-network-rbd.x86_64-2.5.0.args | 40 - .../disk-network-sheepdog.args | 2 +- .../disk-network-source-auth.args | 6 +- tests/qemuxml2argvdata/disk-order.args | 6 +- .../qemuxml2argvdata/disk-readonly-disk.args | 2 +- tests/qemuxml2argvdata/disk-sata-device.args | 4 +- .../disk-scsi-device-auto.x86_64-1.5.3.args | 33 - .../disk-scsi-disk-split.args | 10 +- .../qemuxml2argvdata/disk-scsi-disk-vpd.args | 6 +- .../qemuxml2argvdata/disk-scsi-disk-wwn.args | 6 +- .../disk-scsi-lun-passthrough.args | 6 +- tests/qemuxml2argvdata/disk-serial.args | 2 +- tests/qemuxml2argvdata/disk-snapshot.args | 2 +- .../disk-source-pool-mode.args | 2 +- tests/qemuxml2argvdata/disk-source-pool.args | 4 +- .../disk-usb-device-removable.args | 2 +- tests/qemuxml2argvdata/disk-usb-device.args | 2 +- tests/qemuxml2argvdata/disk-virtio.args | 4 +- tests/qemuxml2argvdata/encrypted-disk.args | 2 +- .../eoi-disabled.x86_64-2.7.0.args | 30 - .../eoi-enabled.x86_64-2.7.0.args | 30 - tests/qemuxml2argvdata/event_idx.args | 4 +- tests/qemuxml2argvdata/floppy-drive-fat.args | 2 +- tests/qemuxml2argvdata/fs9p.args | 6 +- .../graphics-egl-headless.args | 2 +- .../graphics-sdl-fullscreen.args | 2 +- tests/qemuxml2argvdata/graphics-sdl.args | 2 +- .../graphics-spice-agent-file-xfer.args | 4 +- .../graphics-spice-agentmouse.args | 2 +- .../graphics-spice-auto-socket-cfg.args | 2 +- .../graphics-spice-auto-socket.args | 2 +- .../graphics-spice-compression.args | 4 +- .../graphics-spice-egl-headless.args | 4 +- .../graphics-spice-no-args.args | 2 +- .../graphics-spice-qxl-vga.args | 4 +- .../qemuxml2argvdata/graphics-spice-sasl.args | 4 +- .../graphics-spice-socket.args | 2 +- .../graphics-spice-timeout.args | 2 +- .../graphics-spice-usb-redir.args | 2 +- tests/qemuxml2argvdata/graphics-spice.args | 4 +- .../graphics-vnc-auto-socket-cfg.args | 2 +- .../graphics-vnc-auto-socket.args | 2 +- .../graphics-vnc-egl-headless.args | 2 +- .../graphics-vnc-no-listen-attr.args | 2 +- tests/qemuxml2argvdata/graphics-vnc-none.args | 2 +- .../qemuxml2argvdata/graphics-vnc-policy.args | 2 +- .../graphics-vnc-remove-generated-socket.args | 2 +- tests/qemuxml2argvdata/graphics-vnc-sasl.args | 2 +- .../graphics-vnc-socket-new-cmdline.args | 2 +- .../qemuxml2argvdata/graphics-vnc-socket.args | 2 +- tests/qemuxml2argvdata/graphics-vnc-tls.args | 2 +- .../graphics-vnc-tls.x86_64-2.4.0.args | 30 - .../graphics-vnc-websocket.args | 2 +- tests/qemuxml2argvdata/graphics-vnc.args | 2 +- .../hostdev-mdev-precreated.args | 2 +- .../hostdev-pci-address-device.args | 4 +- .../hostdev-pci-address-unassigned.args | 8 +- .../qemuxml2argvdata/hostdev-pci-address.args | 2 +- .../hostdev-pci-multifunction.args | 16 +- .../hostdev-scsi-lsi.x86_64-2.8.0.args | 45 - .../hostdev-scsi-vhost-scsi-pci.args | 2 +- .../hostdev-scsi-vhost-scsi-pcie.args | 4 +- ...hostdev-scsi-virtio-scsi.x86_64-2.8.0.args | 47 - .../hostdev-usb-address-device-boot.args | 2 +- .../hostdev-usb-address-device.args | 2 +- .../hostdev-vfio-multidomain.args | 4 +- tests/qemuxml2argvdata/hostdev-vfio.args | 4 +- tests/qemuxml2argvdata/hugepages-default.args | 2 +- tests/qemuxml2argvdata/hugepages-shared.args | 2 +- .../qemuxml2argvdata/input-usbmouse-addr.args | 2 +- .../intel-iommu.x86_64-2.6.0.args | 29 - tests/qemuxml2argvdata/iothreads-disk.args | 2 +- tests/qemuxml2argvdata/kvm-features-off.args | 2 +- tests/qemuxml2argvdata/kvm-pit-delay.args | 2 +- tests/qemuxml2argvdata/kvm-pit-discard.args | 2 +- .../kvmclock+eoi-disabled.x86_64-2.7.0.args | 30 - .../luks-disks-source-qcow2.args | 8 +- tests/qemuxml2argvdata/luks-disks-source.args | 6 +- .../mach-virt-console-virtio.args | 2 +- .../mach-virt-serial-native.args | 2 +- .../mach-virt-serial-pci.args | 2 +- .../mach-virt-serial-usb.args | 2 +- tests/qemuxml2argvdata/machine-aliases1.args | 2 +- tests/qemuxml2argvdata/machine-aliases2.args | 2 +- tests/qemuxml2argvdata/machine-smm-opt.args | 2 +- .../qemuxml2argvdata/machine-vmport-opt.args | 2 +- .../memory-hotplug-dimm-addr.args | 2 +- .../qemuxml2argvdata/memory-hotplug-dimm.args | 2 +- tests/qemuxml2argvdata/memory-hotplug.args | 2 +- tests/qemuxml2argvdata/memtune-unlimited.args | 2 +- tests/qemuxml2argvdata/memtune.args | 2 +- .../migrate-numa-unaligned.args | 2 +- .../minimal-msg-timestamp.args | 2 +- tests/qemuxml2argvdata/minimal-sandbox.args | 2 +- tests/qemuxml2argvdata/minimal.args | 2 +- tests/qemuxml2argvdata/monitor-json.args | 2 +- .../multifunction-pci-device.args | 2 +- tests/qemuxml2argvdata/net-client.args | 4 +- tests/qemuxml2argvdata/net-eth-hostip.args | 2 +- tests/qemuxml2argvdata/net-eth-ifname.args | 2 +- tests/qemuxml2argvdata/net-eth-names.args | 6 +- .../net-eth-unmanaged-tap.args | 2 +- tests/qemuxml2argvdata/net-eth.args | 2 +- .../net-hostdev-bootorder.args | 2 +- .../net-hostdev-multidomain.args | 4 +- .../net-hostdev-vfio-multidomain.args | 4 +- tests/qemuxml2argvdata/net-hostdev-vfio.args | 4 +- tests/qemuxml2argvdata/net-hostdev.args | 4 +- tests/qemuxml2argvdata/net-many-models.args | 12 +- tests/qemuxml2argvdata/net-mcast.args | 4 +- tests/qemuxml2argvdata/net-server.args | 4 +- tests/qemuxml2argvdata/net-udp.args | 4 +- tests/qemuxml2argvdata/net-user.args | 2 +- .../net-vhostuser-multiq.args | 10 +- .../qemuxml2argvdata/net-vhostuser-multiq.err | 1 - tests/qemuxml2argvdata/net-vhostuser.args | 6 +- .../net-vhostuser.x86_64-2.5.0.args | 36 - tests/qemuxml2argvdata/net-virtio-device.args | 4 +- .../net-virtio-disable-offloads.args | 4 +- tests/qemuxml2argvdata/net-virtio-netdev.args | 4 +- .../net-virtio-rxtxqueuesize.args | 4 +- .../qemuxml2argvdata/net-virtio-teaming.args | 10 +- tests/qemuxml2argvdata/net-virtio.args | 2 +- .../numad-auto-memory-vcpu-cpuset.args | 2 +- ...o-memory-vcpu-no-cpuset-and-placement.args | 2 +- .../numad-auto-vcpu-static-numatune.args | 2 +- .../numad-static-memory-auto-vcpu.args | 2 +- tests/qemuxml2argvdata/numad.args | 2 +- .../numatune-auto-nodeset-invalid.args | 2 +- .../numatune-auto-prefer.args | 2 +- .../qemuxml2argvdata/numatune-distances.args | 2 +- .../numatune-memnode-no-memory.args | 2 +- tests/qemuxml2argvdata/numatune-memnode.args | 2 +- tests/qemuxml2argvdata/numatune-memory.args | 2 +- tests/qemuxml2argvdata/panic-no-address.args | 2 +- tests/qemuxml2argvdata/panic.args | 2 +- .../parallel-parport-chardev.args | 2 +- .../parallel-tcp-chardev.args | 2 +- .../parallel-unix-chardev.x86_64-2.5.0.args | 33 - tests/qemuxml2argvdata/pci-autoadd-addr.args | 2 +- tests/qemuxml2argvdata/pci-autoadd-idx.args | 2 +- tests/qemuxml2argvdata/pci-autofill-addr.args | 2 +- .../pci-bridge-many-disks.args | 216 +- tests/qemuxml2argvdata/pci-bridge.args | 2 +- tests/qemuxml2argvdata/pci-expander-bus.args | 68 +- tests/qemuxml2argvdata/pci-many.args | 2 +- tests/qemuxml2argvdata/pci-rom-disabled.args | 2 +- tests/qemuxml2argvdata/pci-rom.args | 10 +- .../pci-serial-dev-chardev.args | 2 +- .../pcie-root-port-model-generic.args | 6 +- .../pcie-root-port-model-ioh3420.args | 4 +- tests/qemuxml2argvdata/pcihole64.args | 2 +- .../pseries-cpu-compat-power9.args | 4 +- .../qemuxml2argvdata/pseries-cpu-compat.args | 4 +- .../pseries-features-htp-resize.err | 1 - .../pseries-features-htp-resize.xml | 1 - .../pv-spinlock-disabled.x86_64-2.7.0.args | 30 - .../pv-spinlock-enabled.x86_64-2.7.0.args | 30 - .../q35-pci-force-address.args | 2 +- .../q35-pm-disable-fallback.args | 2 +- tests/qemuxml2argvdata/q35-pm-disable.args | 2 +- tests/qemuxml2argvdata/qemu-ns-alt.args | 2 +- .../qemu-ns-commandline-ns0.args | 2 +- .../qemu-ns-commandline-ns1.args | 2 +- .../qemuxml2argvdata/qemu-ns-commandline.args | 2 +- .../qemu-ns-domain-commandline-ns0.args | 2 +- .../qemu-ns-domain-commandline.args | 2 +- .../qemuxml2argvdata/qemu-ns-domain-ns0.args | 2 +- tests/qemuxml2argvdata/restore-v2-fd.args | 2 +- tests/qemuxml2argvdata/seclabel-dac-none.args | 2 +- .../seclabel-dynamic-baselabel.args | 2 +- .../seclabel-dynamic-labelskip.args | 2 +- .../seclabel-dynamic-override.args | 2 +- .../seclabel-dynamic-relabel.args | 2 +- tests/qemuxml2argvdata/seclabel-dynamic.args | 2 +- tests/qemuxml2argvdata/seclabel-none.args | 2 +- .../seclabel-static-labelskip.args | 2 +- .../seclabel-static-relabel.args | 2 +- tests/qemuxml2argvdata/seclabel-static.args | 2 +- .../serial-dev-chardev-iobase.args | 2 +- .../qemuxml2argvdata/serial-dev-chardev.args | 2 +- .../qemuxml2argvdata/serial-file-chardev.args | 2 +- .../qemuxml2argvdata/serial-many-chardev.args | 2 +- .../qemuxml2argvdata/serial-pty-chardev.args | 2 +- .../serial-spiceport-nospice.args | 2 +- .../qemuxml2argvdata/serial-tcp-chardev.args | 2 +- .../serial-tcp-telnet-chardev.args | 2 +- .../serial-tcp-tlsx509-chardev-verify.args | 2 +- .../serial-tcp-tlsx509-chardev.args | 2 +- .../qemuxml2argvdata/serial-udp-chardev.args | 2 +- .../qemuxml2argvdata/serial-unix-chardev.args | 2 +- tests/qemuxml2argvdata/serial-vc-chardev.args | 2 +- .../shmem-plain-doorbell.args | 14 +- tests/qemuxml2argvdata/shmem.args | 14 +- .../smartcard-controller.args | 2 +- .../smartcard-host-certificates-database.args | 2 +- .../smartcard-host-certificates.args | 2 +- tests/qemuxml2argvdata/smartcard-host.args | 2 +- .../smartcard-passthrough-spicevmc.args | 2 +- .../smartcard-passthrough-tcp.args | 2 +- ...artcard-passthrough-unix.x86_64-2.5.0.args | 32 - tests/qemuxml2argvdata/smbios.args | 2 +- tests/qemuxml2argvdata/sound-device.args | 14 +- tests/qemuxml2argvdata/sound.args | 4 +- .../usb-controller-qemu-xhci.args | 2 +- .../qemuxml2argvdata/usb-controller-xhci.args | 2 +- tests/qemuxml2argvdata/usb-controller.args | 2 +- .../usb-hub-autoadd-deluxe.args | 2 +- tests/qemuxml2argvdata/usb-hub-autoadd.args | 2 +- tests/qemuxml2argvdata/usb-hub.args | 2 +- .../qemuxml2argvdata/usb-ich9-autoassign.args | 2 +- .../qemuxml2argvdata/usb-ich9-companion.args | 2 +- .../qemuxml2argvdata/usb-ich9-ehci-addr.args | 26 +- .../qemuxml2argvdata/usb-long-port-path.args | 2 +- tests/qemuxml2argvdata/usb-none.args | 2 +- .../usb-piix3-controller.args | 2 +- .../qemuxml2argvdata/usb-port-autoassign.args | 2 +- tests/qemuxml2argvdata/usb-port-missing.args | 2 +- tests/qemuxml2argvdata/usb-ports.args | 2 +- tests/qemuxml2argvdata/usb-redir-boot.args | 2 +- .../usb-redir-filter-version.args | 2 +- tests/qemuxml2argvdata/usb-redir-filter.args | 2 +- .../usb-redir-unix.x86_64-2.5.0.args | 36 - tests/qemuxml2argvdata/usb-redir.args | 2 +- .../qemuxml2argvdata/usb-xhci-autoassign.args | 2 +- tests/qemuxml2argvdata/usb1-usb2.args | 2 +- tests/qemuxml2argvdata/user-aliases-usb.args | 2 +- tests/qemuxml2argvdata/user-aliases.args | 2 +- .../qemuxml2argvdata/video-qxl-nodevice.args | 32 - tests/qemuxml2argvdata/video-qxl-nodevice.xml | 29 - .../qemuxml2argvdata/video-vga-nodevice.args | 30 - tests/qemuxml2argvdata/video-vga-nodevice.xml | 29 - .../qemuxml2argvdata/video-vga-qxl-heads.args | 5 +- .../virtio-input-passthrough.args | 4 +- tests/qemuxml2argvdata/virtio-input.args | 6 +- tests/qemuxml2argvdata/virtio-lun.args | 4 +- .../qemuxml2argvdata/virtio-rng-default.args | 2 +- .../virtio-rng-egd-unix.x86_64-2.5.0.args | 32 - tests/qemuxml2argvdata/virtio-rng-egd.args | 4 +- .../qemuxml2argvdata/virtio-rng-multiple.args | 4 +- tests/qemuxml2argvdata/virtio-rng-random.args | 4 +- tests/qemuxml2argvdata/vmcoreinfo.args | 2 +- tests/qemuxml2argvdata/watchdog-device.args | 2 +- tests/qemuxml2argvdata/watchdog-dump.args | 2 +- .../qemuxml2argvdata/watchdog-injectnmi.args | 2 +- tests/qemuxml2argvtest.c | 124 +- tests/qemuxml2xmloutdata/autoindex.xml | 4 +- .../balloon-device-auto.xml | 2 +- .../bios-nvram-os-interleave.xml | 2 +- tests/qemuxml2xmloutdata/bios-nvram.xml | 2 +- tests/qemuxml2xmloutdata/blkiotune-device.xml | 2 +- tests/qemuxml2xmloutdata/blkiotune.xml | 2 +- .../boot-menu-disable-with-timeout.xml | 2 +- .../qemuxml2xmloutdata/boot-menu-disable.xml | 2 +- .../boot-menu-enable-with-timeout.xml | 2 +- tests/qemuxml2xmloutdata/boot-multi.xml | 2 +- tests/qemuxml2xmloutdata/boot-order.xml | 6 +- tests/qemuxml2xmloutdata/channel-guestfwd.xml | 2 +- .../channel-unix-source-path-active.xml | 2 +- .../channel-unix-source-path-inactive.xml | 2 +- .../channel-virtio-auto.xml | 6 +- .../channel-virtio-state-active.xml | 2 +- .../channel-virtio-state-inactive.xml | 2 +- tests/qemuxml2xmloutdata/channel-virtio.xml | 2 +- tests/qemuxml2xmloutdata/chardev-label.xml | 4 +- tests/qemuxml2xmloutdata/clock-catchup.xml | 2 +- .../clock-timer-hyperv-rtc.xml | 2 +- .../console-compat-auto.xml | 2 +- tests/qemuxml2xmloutdata/console-compat2.xml | 2 +- .../console-virtio-many.xml | 4 +- tests/qemuxml2xmloutdata/console-virtio.xml | 4 +- .../controller-usb-order.xml | 2 +- .../controller-virtio-scsi.xml | 12 +- .../cpu-check-default-none.xml | 2 +- .../cpu-check-default-none2.xml | 2 +- .../cpu-check-default-partial.xml | 2 +- .../cpu-check-default-partial2.xml | 2 +- tests/qemuxml2xmloutdata/cpu-check-full.xml | 2 +- tests/qemuxml2xmloutdata/cpu-check-none.xml | 2 +- .../qemuxml2xmloutdata/cpu-check-partial.xml | 2 +- tests/qemuxml2xmloutdata/cpu-empty.xml | 2 +- tests/qemuxml2xmloutdata/cpu-eoi-disabled.xml | 2 +- tests/qemuxml2xmloutdata/cpu-eoi-enabled.xml | 2 +- .../qemuxml2xmloutdata/cpu-host-kvmclock.xml | 2 +- .../cpu-host-model-features.xml | 2 +- .../cpu-host-model-vendor.xml | 2 +- .../cpu-host-passthrough-features.xml | 2 +- tests/qemuxml2xmloutdata/cpu-kvmclock.xml | 2 +- .../qemuxml2xmloutdata/cpu-numa-disjoint.xml | 2 +- .../cpu-numa-disordered.xml | 2 +- .../qemuxml2xmloutdata/cpu-numa-memshared.xml | 2 +- .../cpu-numa-no-memory-element.xml | 2 +- tests/qemuxml2xmloutdata/cpu-numa1.xml | 2 +- tests/qemuxml2xmloutdata/cpu-numa2.xml | 2 +- .../qemuxml2xmloutdata/cputune-iothreads.xml | 2 +- .../cputune-iothreadsched-zeropriority.xml | 2 +- .../cputune-iothreadsched.xml | 2 +- .../cputune-zero-shares.xml | 2 +- tests/qemuxml2xmloutdata/cputune.xml | 2 +- .../default-kvm-host-arch.xml | 2 +- .../default-qemu-host-arch.xml | 2 +- .../disk-active-commit-active.xml | 2 +- .../disk-active-commit-inactive.xml | 2 +- tests/qemuxml2xmloutdata/disk-aio.xml | 2 +- .../disk-backing-chains-active.xml | 12 +- .../disk-backing-chains-inactive.xml | 12 +- .../disk-backing-chains-index-active.xml | 14 +- .../disk-backing-chains-index-inactive.xml | 14 +- .../disk-backing-chains-noindex.xml | 14 +- .../disk-cache.x86_64-1.5.3.xml | 61 - .../disk-cache.x86_64-2.6.0.xml | 61 - .../disk-cache.x86_64-2.7.0.xml | 61 - .../qemuxml2xmloutdata/disk-copy_on_read.xml | 4 +- .../qemuxml2xmloutdata/disk-mirror-active.xml | 8 +- .../disk-mirror-inactive.xml | 8 +- .../disk-mirror-old-active.xml | 6 +- .../disk-mirror-old-inactive.xml | 6 +- .../disk-network-gluster.xml | 6 +- .../qemuxml2xmloutdata/disk-network-iscsi.xml | 10 +- tests/qemuxml2xmloutdata/disk-network-nbd.xml | 10 +- tests/qemuxml2xmloutdata/disk-network-rbd.xml | 12 +- .../disk-network-sheepdog.xml | 2 +- .../disk-network-source-auth.xml | 6 +- .../disk-scsi-device-auto.xml | 4 +- .../qemuxml2xmloutdata/disk-scsi-disk-vpd.xml | 6 +- .../disk-scsi-lun-passthrough-sgio.xml | 6 +- tests/qemuxml2xmloutdata/disk-serial.xml | 2 +- .../disk-source-pool-mode.xml | 2 +- tests/qemuxml2xmloutdata/disk-source-pool.xml | 4 +- tests/qemuxml2xmloutdata/disk-usb-device.xml | 2 +- tests/qemuxml2xmloutdata/disk-virtio.xml | 4 +- tests/qemuxml2xmloutdata/encrypted-disk.xml | 2 +- tests/qemuxml2xmloutdata/eoi-disabled.xml | 2 +- tests/qemuxml2xmloutdata/eoi-enabled.xml | 2 +- tests/qemuxml2xmloutdata/event_idx.xml | 4 +- tests/qemuxml2xmloutdata/floppy-drive-fat.xml | 2 +- .../hostdev-mdev-precreated.xml | 2 +- .../hostdev-pci-address-unassigned.xml | 8 +- .../hostdev-pci-address.xml | 2 +- .../hostdev-pci-multifunction.xml | 16 +- .../hostdev-scsi-autogen-address.xml | 6 +- .../hostdev-scsi-large-unit.xml | 4 +- tests/qemuxml2xmloutdata/hostdev-scsi-lsi.xml | 4 +- .../qemuxml2xmloutdata/hostdev-scsi-rawio.xml | 4 +- .../qemuxml2xmloutdata/hostdev-scsi-sgio.xml | 4 +- .../hostdev-scsi-shareable.xml | 4 +- .../hostdev-scsi-vhost-scsi-pci.xml | 2 +- .../hostdev-scsi-vhost-scsi-pcie.xml | 8 +- .../hostdev-scsi-virtio-scsi.xml | 4 +- tests/qemuxml2xmloutdata/hostdev-vfio.xml | 4 +- .../qemuxml2xmloutdata/hugepages-default.xml | 2 +- tests/qemuxml2xmloutdata/hugepages-shared.xml | 2 +- tests/qemuxml2xmloutdata/hyperv-off.xml | 2 +- .../intel-iommu.x86_64-2.6.0.xml | 31 - tests/qemuxml2xmloutdata/interface-driver.xml | 4 +- tests/qemuxml2xmloutdata/iothreads-disk.xml | 2 +- tests/qemuxml2xmloutdata/kvm-features-off.xml | 2 +- tests/qemuxml2xmloutdata/lease.xml | 2 +- .../qemuxml2xmloutdata/luks-disks-source.xml | 6 +- .../memory-hotplug-dimm.xml | 2 +- tests/qemuxml2xmloutdata/memory-hotplug.xml | 2 +- .../qemuxml2xmloutdata/memorybacking-set.xml | 2 +- .../memorybacking-unset.xml | 2 +- .../qemuxml2xmloutdata/memtune-unlimited.xml | 2 +- tests/qemuxml2xmloutdata/memtune.xml | 2 +- .../qemuxml2xmloutdata/metadata-duplicate.xml | 2 +- tests/qemuxml2xmloutdata/metadata.xml | 2 +- tests/qemuxml2xmloutdata/minimal.xml | 2 +- tests/qemuxml2xmloutdata/net-coalesce.xml | 8 +- tests/qemuxml2xmloutdata/net-eth-hostip.xml | 2 +- tests/qemuxml2xmloutdata/net-eth-ifname.xml | 2 +- .../net-eth-unmanaged-tap.xml | 2 +- tests/qemuxml2xmloutdata/net-eth.xml | 2 +- .../net-hostdev-bootorder.xml | 2 +- tests/qemuxml2xmloutdata/net-hostdev-vfio.xml | 4 +- tests/qemuxml2xmloutdata/net-hostdev.xml | 4 +- tests/qemuxml2xmloutdata/net-many-models.xml | 12 +- tests/qemuxml2xmloutdata/net-midonet.xml | 4 +- tests/qemuxml2xmloutdata/net-mtu.xml | 6 +- tests/qemuxml2xmloutdata/net-openvswitch.xml | 4 +- tests/qemuxml2xmloutdata/net-udp.xml | 4 +- tests/qemuxml2xmloutdata/net-user.xml | 2 +- tests/qemuxml2xmloutdata/net-vdpa.xml | 2 +- tests/qemuxml2xmloutdata/net-vhostuser.xml | 6 +- .../qemuxml2xmloutdata/net-virtio-device.xml | 4 +- .../net-virtio-disable-offloads.xml | 4 +- .../net-virtio-network-portgroup.xml | 8 +- .../net-virtio-rxtxqueuesize.xml | 4 +- .../net-virtio-teaming-network.xml | 6 +- .../qemuxml2xmloutdata/net-virtio-teaming.xml | 10 +- tests/qemuxml2xmloutdata/net-virtio.xml | 2 +- .../numad-auto-memory-vcpu-cpuset.xml | 2 +- ...to-memory-vcpu-no-cpuset-and-placement.xml | 2 +- .../numad-auto-vcpu-no-numatune.xml | 2 +- .../numad-static-vcpu-no-numatune.xml | 2 +- .../numatune-auto-prefer.xml | 2 +- .../qemuxml2xmloutdata/numatune-distances.xml | 2 +- .../numatune-memnode-no-memory.xml | 2 +- tests/qemuxml2xmloutdata/numatune-memnode.xml | 2 +- tests/qemuxml2xmloutdata/panic-isa.xml | 2 +- tests/qemuxml2xmloutdata/panic-no-address.xml | 2 +- tests/qemuxml2xmloutdata/panic.xml | 2 +- .../pci-bridge-many-disks.xml | 216 +- tests/qemuxml2xmloutdata/pci-expander-bus.xml | 68 +- .../pci-rom-disabled-invalid.xml | 2 +- tests/qemuxml2xmloutdata/pci-rom-disabled.xml | 2 +- tests/qemuxml2xmloutdata/pci-rom.xml | 10 +- .../pci-serial-dev-chardev.xml | 2 +- .../pcie-root-port-model-generic.xml | 12 +- .../pcie-root-port-model-ioh3420.xml | 8 +- tests/qemuxml2xmloutdata/pcihole64-gib.xml | 2 +- tests/qemuxml2xmloutdata/pcihole64-none.xml | 2 +- tests/qemuxml2xmloutdata/pcihole64.xml | 2 +- .../pv-spinlock-disabled.xml | 2 +- .../pv-spinlock-enabled.xml | 2 +- .../q35-pci-force-address.xml | 4 +- .../qemuxml2xmloutdata/seclabel-dac-none.xml | 2 +- .../seclabel-device-multiple.xml | 2 +- .../seclabel-dynamic-baselabel-inactive.xml | 2 +- .../seclabel-dynamic-labelskip-inactive.xml | 2 +- .../seclabel-dynamic-none.xml | 2 +- .../seclabel-dynamic-override-inactive.xml | 2 +- .../seclabel-dynamic-relabel-inactive.xml | 2 +- tests/qemuxml2xmloutdata/seclabel-none.xml | 2 +- .../seclabel-static-labelskip-active.xml | 2 +- .../seclabel-static-labelskip-inactive.xml | 2 +- tests/qemuxml2xmloutdata/seclabel-static.xml | 2 +- .../serial-spiceport-nospice.xml | 2 +- .../serial-target-port-auto.xml | 2 +- .../serial-tcp-tlsx509-chardev.xml | 2 +- .../shmem-plain-doorbell.xml | 14 +- tests/qemuxml2xmloutdata/shmem.xml | 14 +- .../smartcard-controller.xml | 2 +- .../smartcard-host-certificates-database.xml | 2 +- .../smartcard-host-certificates.xml | 2 +- tests/qemuxml2xmloutdata/smartcard-host.xml | 2 +- .../smartcard-passthrough-spicevmc.xml | 2 +- .../smartcard-passthrough-tcp.xml | 2 +- .../smbios-multiple-type2.xml | 2 +- tests/qemuxml2xmloutdata/smbios.xml | 2 +- tests/qemuxml2xmloutdata/sound-device.xml | 14 +- tests/qemuxml2xmloutdata/sound.xml | 4 +- .../tap-vhost-incorrect.xml | 6 +- tests/qemuxml2xmloutdata/tap-vhost.xml | 4 +- .../qemuxml2xmloutdata/tseg-explicit-size.xml | 4 +- tests/qemuxml2xmloutdata/usb-controller.xml | 2 +- .../qemuxml2xmloutdata/usb-ich9-ehci-addr.xml | 26 +- tests/qemuxml2xmloutdata/usb-none.xml | 2 +- .../usb-piix3-controller.xml | 2 +- tests/qemuxml2xmloutdata/usb-port-missing.xml | 2 +- .../usb-redir-filter-version.xml | 2 +- tests/qemuxml2xmloutdata/usb-redir-filter.xml | 2 +- tests/qemuxml2xmloutdata/usb-redir.xml | 2 +- tests/qemuxml2xmloutdata/vhost-vsock-auto.xml | 2 +- tests/qemuxml2xmloutdata/vhost_queues.xml | 4 +- .../virtio-input-passthrough.xml | 4 +- tests/qemuxml2xmloutdata/virtio-input.xml | 6 +- tests/qemuxml2xmloutdata/virtio-lun.xml | 4 +- tests/qemuxml2xmloutdata/virtio-rng-egd.xml | 4 +- .../qemuxml2xmloutdata/virtio-rng-random.xml | 4 +- tests/qemuxml2xmloutdata/vmcoreinfo.xml | 2 +- tests/qemuxml2xmltest.c | 43 +- tests/testutilsqemu.c | 2 +- 740 files changed, 588797 insertions(+), 854418 deletions(-) delete mode 100644 tests/qemucapabilitiesdata/caps_1.5.3.x86_64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_1.6.0.x86_64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_1.7.0.x86_64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_2.1.1.x86_64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_2.10.0.aarch64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_2.10.0.ppc64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_2.10.0.s390x.replies delete mode 100644 tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml delete mode 100644 tests/qemucapabilitiesdata/caps_2.10.0.x86_64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_2.4.0.x86_64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_2.5.0.x86_64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_2.6.0.aarch64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_2.6.0.ppc64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_2.6.0.x86_64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_2.7.0.s390x.replies delete mode 100644 tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml delete mode 100644 tests/qemucapabilitiesdata/caps_2.7.0.x86_64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_2.8.0.s390x.replies delete mode 100644 tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml delete mode 100644 tests/qemucapabilitiesdata/caps_2.8.0.x86_64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_2.9.0.ppc64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_2.9.0.s390x.replies delete mode 100644 tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml delete mode 100644 tests/qemucapabilitiesdata/caps_2.9.0.x86_64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml delete mode 100644 tests/qemuxml2argvdata/aarch64-gic-host.err delete mode 100644 tests/qemuxml2argvdata/aarch64-gic-v3.err delete mode 100644 tests/qemuxml2argvdata/channel-unix-guestfwd.x86_64-2.5.0.args delete mode 100644 tests/qemuxml2argvdata/console-virtio-unix.x86_64-2.5.0.args delete mode 100644 tests/qemuxml2argvdata/disk-cache.x86_64-1.5.3.args delete mode 100644 tests/qemuxml2argvdata/disk-cache.x86_64-2.6.0.args delete mode 100644 tests/qemuxml2argvdata/disk-cache.x86_64-2.7.0.args delete mode 100644 tests/qemuxml2argvdata/disk-network-rbd.x86_64-2.5.0.args delete mode 100644 tests/qemuxml2argvdata/disk-scsi-device-auto.x86_64-1.5.3.args delete mode 100644 tests/qemuxml2argvdata/eoi-disabled.x86_64-2.7.0.args delete mode 100644 tests/qemuxml2argvdata/eoi-enabled.x86_64-2.7.0.args delete mode 100644 tests/qemuxml2argvdata/graphics-vnc-tls.x86_64-2.4.0.args delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-lsi.x86_64-2.8.0.args delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-virtio-scsi.x86_64-2.8.0.args delete mode 100644 tests/qemuxml2argvdata/intel-iommu.x86_64-2.6.0.args delete mode 100644 tests/qemuxml2argvdata/kvmclock+eoi-disabled.x86_64-2.7.0.args delete mode 100644 tests/qemuxml2argvdata/net-vhostuser-multiq.err delete mode 100644 tests/qemuxml2argvdata/net-vhostuser.x86_64-2.5.0.args delete mode 100644 tests/qemuxml2argvdata/parallel-unix-chardev.x86_64-2.5.0.args delete mode 100644 tests/qemuxml2argvdata/pseries-features-htp-resize.err delete mode 120000 tests/qemuxml2argvdata/pseries-features-htp-resize.xml delete mode 100644 tests/qemuxml2argvdata/pv-spinlock-disabled.x86_64-2.7.0.args delete mode 100644 tests/qemuxml2argvdata/pv-spinlock-enabled.x86_64-2.7.0.args delete mode 100644 tests/qemuxml2argvdata/smartcard-passthrough-unix.x86_64-2.5.0.args delete mode 100644 tests/qemuxml2argvdata/usb-redir-unix.x86_64-2.5.0.args delete mode 100644 tests/qemuxml2argvdata/video-qxl-nodevice.args delete mode 100644 tests/qemuxml2argvdata/video-qxl-nodevice.xml delete mode 100644 tests/qemuxml2argvdata/video-vga-nodevice.args delete mode 100644 tests/qemuxml2argvdata/video-vga-nodevice.xml delete mode 100644 tests/qemuxml2argvdata/virtio-rng-egd-unix.x86_64-2.5.0.args delete mode 100644 tests/qemuxml2xmloutdata/disk-cache.x86_64-1.5.3.xml delete mode 100644 tests/qemuxml2xmloutdata/disk-cache.x86_64-2.6.0.xml delete mode 100644 tests/qemuxml2xmloutdata/disk-cache.x86_64-2.7.0.xml delete mode 100644 tests/qemuxml2xmloutdata/intel-iommu.x86_64-2.6.0.xml -- 2.30.2

2 39

[libvirt PATCH v2] spec: Merge -bash-completion and -admin into -client
by Andrea Bolognani 20 Apr '21

20 Apr '21

The former is ridiculously tiny and doesn't have any use on its own, so it hardly warrants the overhead of an additional package; the latter is also very small and, just like virsh, is something that you likely want to have available on any virtualization host to help with management and debugging tasks. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Changes from [v1]: * add Obsoletes/Provides for a smooth transition. [v1] https://listman.redhat.com/archives/libvir-list/2021-April/msg00604.html libvirt.spec.in | 34 ++++++++++------------------------ 1 file changed, 10 insertions(+), 24 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index f9af330186..a90f6abe38 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -901,7 +901,12 @@ Requires: %{name}-libs = %{version}-%{release} Requires: gettext # Needed by virt-pki-validate script. Requires: gnutls-utils -Requires: %{name}-bash-completion = %{version}-%{release} +# The -admin and -bash-completion packages have been merged into +# the -client package: ensure this change is handled smoothly +Obsoletes: libvirt-admin < 7.3.0 +Obsoletes: libvirt-bash-completion < 7.3.0 +Provides: libvirt-admin +Provides: libvirt-bash-completion %description client The client binaries needed to access the virtualization @@ -918,20 +923,6 @@ Requires: cyrus-sasl-gssapi %description libs Shared libraries for accessing the libvirt daemon. -%package admin -Summary: Set of tools to control libvirt daemon -Requires: %{name}-libs = %{version}-%{release} -Requires: %{name}-bash-completion = %{version}-%{release} - -%description admin -The client side utilities to control the libvirt daemon. - -%package bash-completion -Summary: Bash completion script - -%description bash-completion -Bash completion script stub. - %if %{with_wireshark} %package wireshark Summary: Wireshark dissector plugin for libvirt RPC transactions @@ -1872,10 +1863,12 @@ exit 0 %files client %{_mandir}/man1/virsh.1* +%{_mandir}/man1/virt-admin.1* %{_mandir}/man1/virt-xml-validate.1* %{_mandir}/man1/virt-pki-validate.1* %{_mandir}/man1/virt-host-validate.1* %{_bindir}/virsh +%{_bindir}/virt-admin %{_bindir}/virt-xml-validate %{_bindir}/virt-pki-validate %{_bindir}/virt-host-validate @@ -1886,8 +1879,9 @@ exit 0 %{_datadir}/systemtap/tapset/libvirt_qemu_probes*.stp %endif +%{_datadir}/bash-completion/completions/vsh %{_datadir}/bash-completion/completions/virsh - +%{_datadir}/bash-completion/completions/virt-admin %{_unitdir}/libvirt-guests.service %config(noreplace) %{_sysconfdir}/sysconfig/libvirt-guests @@ -1911,14 +1905,6 @@ exit 0 %{_datadir}/libvirt/test-screenshot.png -%files admin -%{_mandir}/man1/virt-admin.1* -%{_bindir}/virt-admin -%{_datadir}/bash-completion/completions/virt-admin - -%files bash-completion -%{_datadir}/bash-completion/completions/vsh - %if %{with_wireshark} %files wireshark %{wireshark_plugindir}/libvirt.so -- 2.26.3

3 5

[libvirt PATCH 0/2] remove sheepdog support
by Pavel Hrdina 19 Apr '21

19 Apr '21

This patch series depends on [1] otherwise you will have conflicts when applying the second patch. [1] <https://listman.redhat.com/archives/libvir-list/2021-April/msg00735.html> Pavel Hrdina (2): tests: use RBD instead of sheepdog remove sheepdog support from libvirt docs/formatdomain.rst | 13 +- docs/formatstorage.html.in | 5 +- docs/kbase/rpm-deployment.rst | 6 - docs/manpages/virsh.rst | 7 +- docs/schemas/domaincommon.rng | 1 - docs/schemas/storagepool.rng | 22 - docs/storage.html.in | 59 --- libvirt.spec.in | 36 -- meson.build | 6 - meson_options.txt | 1 - mingw-libvirt.spec.in | 1 - po/POTFILES.in | 1 - src/conf/domain_conf.c | 1 - src/conf/storage_conf.c | 12 +- src/conf/storage_conf.h | 2 - src/conf/storage_source_conf.c | 4 - src/conf/storage_source_conf.h | 1 - src/conf/virstorageobj.c | 9 - src/libvirt-storage.c | 1 - src/libxl/libxl_conf.c | 1 - src/libxl/xen_xl.c | 1 - src/qemu/qemu_block.c | 41 -- src/qemu/qemu_command.c | 20 - src/qemu/qemu_domain.c | 1 - src/qemu/qemu_snapshot.c | 3 - src/storage/meson.build | 25 -- src/storage/storage_backend.c | 6 - src/storage/storage_backend_sheepdog.c | 378 ------------------ src/storage/storage_backend_sheepdog.h | 25 -- src/storage/storage_backend_sheepdog_priv.h | 30 -- src/storage/storage_driver.c | 1 - .../storage_source_backingstore.c | 44 -- src/test/test_driver.c | 1 - tests/meson.build | 6 - tests/qemublocktest.c | 4 - .../imagecreate/network-sheepdog-qcow2.json | 20 - .../imagecreate/network-sheepdog-qcow2.xml | 12 - tests/qemusecuritytest.c | 1 - tests/qemuxml2argvdata/boot-dev+order.xml | 2 +- tests/qemuxml2argvdata/boot-order.args | 2 +- tests/qemuxml2argvdata/boot-order.xml | 2 +- .../disk-network-sheepdog.args | 30 -- .../disk-network-sheepdog.x86_64-2.12.0.args | 34 -- .../disk-network-sheepdog.x86_64-latest.args | 38 -- .../disk-network-sheepdog.xml | 37 -- tests/qemuxml2argvtest.c | 3 - tests/qemuxml2xmloutdata/boot-order.xml | 2 +- .../disk-network-sheepdog.xml | 43 -- tests/qemuxml2xmltest.c | 1 - tests/storagebackendsheepdogtest.c | 206 ---------- .../storagepoolcapsschemadata/poolcaps-fs.xml | 2 - .../poolcaps-full.xml | 2 - tests/storagepoolxml2argvtest.c | 2 - tests/storagepoolxml2xmlin/pool-sheepdog.xml | 8 - tests/storagepoolxml2xmlout/pool-sheepdog.xml | 11 - tests/storagepoolxml2xmltest.c | 1 - tests/storagevolxml2xmlin/vol-sheepdog.xml | 10 - tests/storagevolxml2xmlout/vol-sheepdog.xml | 8 - tests/storagevolxml2xmltest.c | 1 - .../deflatten-qemu-sheepdog-in.json | 11 - .../deflatten-qemu-sheepdog-out.json | 13 - tests/virjsontest.c | 1 - tests/virstoragetest.c | 21 - tools/virsh-pool.c | 3 - tools/virsh.c | 3 - 65 files changed, 12 insertions(+), 1293 deletions(-) delete mode 100644 src/storage/storage_backend_sheepdog.c delete mode 100644 src/storage/storage_backend_sheepdog.h delete mode 100644 src/storage/storage_backend_sheepdog_priv.h delete mode 100644 tests/qemublocktestdata/imagecreate/network-sheepdog-qcow2.json delete mode 100644 tests/qemublocktestdata/imagecreate/network-sheepdog-qcow2.xml delete mode 100644 tests/qemuxml2argvdata/disk-network-sheepdog.args delete mode 100644 tests/qemuxml2argvdata/disk-network-sheepdog.x86_64-2.12.0.args delete mode 100644 tests/qemuxml2argvdata/disk-network-sheepdog.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/disk-network-sheepdog.xml delete mode 100644 tests/qemuxml2xmloutdata/disk-network-sheepdog.xml delete mode 100644 tests/storagebackendsheepdogtest.c delete mode 100644 tests/storagepoolxml2xmlin/pool-sheepdog.xml delete mode 100644 tests/storagepoolxml2xmlout/pool-sheepdog.xml delete mode 100644 tests/storagevolxml2xmlin/vol-sheepdog.xml delete mode 100644 tests/storagevolxml2xmlout/vol-sheepdog.xml delete mode 100644 tests/virjsondata/deflatten-qemu-sheepdog-in.json delete mode 100644 tests/virjsondata/deflatten-qemu-sheepdog-out.json -- 2.30.2

3 10

Feature proposal: Add page-per-vq flag to the 'driver' element of virtio devices
by Gavi Teitz 19 Apr '21

19 Apr '21

Hi, The page-per-vq flag is important for vdpa with vhost-user performance [1]. Currently there is no way in libvirt to set it in the xml page-per-vq except with qemu args, like so: <devices> <interface type='vhostuser'> <mac address='fa:16:3e:92:6d:79'/> <source type='unix' path='/var/lib/vhost_sockets/sock7f9a971a-cf3' mode='server'/> <model type='virtio'/> <driver queues='4' rx_queue_size='512' tx_queue_size='512'/> <alias name='net0'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> </interface> </devices> <qemu:commandline> <qemu:arg value='-set'/> <qemu:arg value='device.net0.page-per-vq=on'/> </qemu:commandline> However, this is not an approach which can be used for hotplug devices, as qemu:commandline arguments cannot be used for them, and is therefore not suitable for production. We propose to add the flag to the ' driver' element of virtio devices, as this is an attribute related to the virtio transport [2]. This will enable configuring virtio devices with the page-per-vq flag without relying on qemu:commandline arguments. Are there any issues that would prevent this feature from being accepted? Thanks, Gavi [1] - http://doc.dpdk.org/guides/sample_app_ug/vdpa.html - look for page-per-vq [2] - https://libvirt.org/formatdomain.html#virtio-related-options

3 3

[PATCH] add the ability to disable transport authentication (like esxi et al)
by simonmartin76 19 Apr '21

19 Apr '21

Signed-off-by: Simon Martin <simonmartin76(a)protonmail.com> --- src/hyperv/hyperv_driver.c | 5 +++++ src/hyperv/hyperv_util.c | 11 +++++++++++ src/hyperv/hyperv_util.h | 1 + 3 files changed, 17 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 17f5be1f0d..67e6e09f2d 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c @@ -1728,6 +1728,11 @@ hypervInitConnection(virConnectPtr conn, hypervPrivate *priv, /* FIXME: Currently only basic authentication is supported */ wsman_transport_set_auth_method(priv->client, "basic"); + if (priv->parsedUri->noVerify) { + wsman_transport_set_verify_peer(priv->client, 0); + wsman_transport_set_verify_host(priv->client, 0); + } + return 0; } diff --git a/src/hyperv/hyperv_util.c b/src/hyperv/hyperv_util.c index d8a6e6cf5c..40e1540dfe 100644 --- a/src/hyperv/hyperv_util.c +++ b/src/hyperv/hyperv_util.c @@ -38,6 +38,7 @@ int hypervParseUri(hypervParsedUri **parsedUri, virURIPtr uri) { int result = -1; + int noVerify; size_t i; if (parsedUri == NULL || *parsedUri != NULL) { @@ -63,6 +64,16 @@ hypervParseUri(hypervParsedUri **parsedUri, virURIPtr uri) (*parsedUri)->transport); goto cleanup; } + } else if (STRCASEEQ(queryParam->name, "no_verify")) { + if (virStrToLong_i(queryParam->value, NULL, 10, &noVerify) < 0 || + (noVerify != 0 && noVerify != 1)) { + virReportError(VIR_ERR_INVALID_ARG, + _("Query parameter 'no_verify' has unexpected value " + "'%s' (should be 0 or 1)"), queryParam->value); + goto cleanup; + } + + (*parsedUri)->noVerify = noVerify != 0; } else { VIR_WARN("Ignoring unexpected query parameter '%s'", queryParam->name); diff --git a/src/hyperv/hyperv_util.h b/src/hyperv/hyperv_util.h index 67d698450d..a0604d6830 100644 --- a/src/hyperv/hyperv_util.h +++ b/src/hyperv/hyperv_util.h @@ -28,6 +28,7 @@ typedef struct _hypervParsedUri hypervParsedUri; struct _hypervParsedUri { char *transport; + bool noVerify; }; int hypervParseUri(hypervParsedUri **parsedUri, virURIPtr uri); -- 2.17.1 Sent with ProtonMail Secure Email.

2 1

[libvirt PATCH] qemu_block: fix copy&paste typo in SSH protocol
by Pavel Hrdina 19 Apr '21

19 Apr '21

Fixes: caf71b64fe6989116316b966fda119cd3e47f485 Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/qemu/qemu_block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index 6845e25176..a972e1e368 100644 --- a/src/qemu/qemu_block.c +++ b/src/qemu/qemu_block.c @@ -965,7 +965,7 @@ qemuBlockStorageSourceGetSshProps(virStorageSource *src) if (src->nhosts != 1) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("sheepdog protocol accepts only one host")); + _("ssh protocol accepts only one host")); return NULL; } -- 2.30.2

2 1

[libvirt PATCH 0/2] introduce 'restrictive' mode in numatune
by Martin Kletzander 19 Apr '21

19 Apr '21

Resent patches with some fixes v5: https://listman.redhat.com/archives/libvir-list/2021-April/msg00450.html Luyao Zhong (2): conf, docs, schema: Add support for 'restrictive' mode in numatune qemu: Add support for 'restrictive' mode in numatune docs/formatdomain.rst | 7 +++- docs/schemas/domaincommon.rng | 2 + include/libvirt/libvirt-domain.h | 1 + src/conf/numa_conf.c | 9 ++++ src/qemu/qemu_command.c | 6 ++- src/qemu/qemu_process.c | 32 +++++++++++++++ src/util/virnuma.c | 3 ++ .../numatune-memnode-invalid-mode.err | 1 + .../numatune-memnode-invalid-mode.xml | 33 +++++++++++++++ ...emnode-restrictive-mode.x86_64-latest.args | 38 +++++++++++++++++ .../numatune-memnode-restrictive-mode.xml | 41 +++++++++++++++++++ tests/qemuxml2argvtest.c | 2 + ...memnode-restrictive-mode.x86_64-latest.xml | 1 + tests/qemuxml2xmltest.c | 1 + 14 files changed, 174 insertions(+), 3 deletions(-) create mode 100644 tests/qemuxml2argvdata/numatune-memnode-invalid-mode.err create mode 100644 tests/qemuxml2argvdata/numatune-memnode-invalid-mode.xml create mode 100644 tests/qemuxml2argvdata/numatune-memnode-restrictive-mode.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/numatune-memnode-restrictive-mode.xml create mode 120000 tests/qemuxml2xmloutdata/numatune-memnode-restrictive-mode.x86_64-latest.xml -- 2.31.1

3 5