- Devel - libvirt List Archives

[PATCH 0/1] Fix the bug about virsh attach-interface from a
by jx8zjs 02 Nov '21

02 Nov '21

virsh: inherit qos from network definition when attaching an interface Resolved: https://bugzilla.redhat.com/show_bug.cgi?id=1826168 jx8zjs (1): virsh: inherit qos from network definition when attaching an interface tools/virsh-domain.c | 34 +++++++++++++++++++++++++++++++--- 1 file changed, 31 insertions(+), 3 deletions(-) -- 2.30.2.windows.1

3 3

[PATCH 1/2] tests: qemu: use domain type 'kvm' for kvm-features-off
by zhenwei pi 02 Nov '21

02 Nov '21

KVM features off test cases should be tested for a KVM domain, so keep align kvm-features-off test with kvm-features except KVM features on/off. Signed-off-by: zhenwei pi <pizhenwei(a)bytedance.com> --- tests/qemuxml2argvdata/kvm-features-off.args | 4 ++-- tests/qemuxml2argvdata/kvm-features-off.xml | 5 +++-- tests/qemuxml2xmloutdata/kvm-features-off.xml | 7 +++---- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/qemuxml2argvdata/kvm-features-off.args b/tests/qemuxml2argvdata/kvm-features-off.args index f6f13495e6..f7133bc0c3 100644 --- a/tests/qemuxml2argvdata/kvm-features-off.args +++ b/tests/qemuxml2argvdata/kvm-features-off.args @@ -11,7 +11,8 @@ QEMU_AUDIO_DRV=none \ -name guest=QEMUGuest1,debug-threads=on \ -S \ -object secret,id=masterKey0,format=raw,file=/tmp/lib/domain--1-QEMUGuest1/master-key.aes \ --machine pc,accel=tcg,usb=off,dump-guest-core=off \ +-machine pc,accel=kvm,usb=off,dump-guest-core=off \ +-cpu host \ -m 214 \ -realtime mlock=off \ -smp 6,sockets=6,cores=1,threads=1 \ @@ -25,5 +26,4 @@ QEMU_AUDIO_DRV=none \ -no-shutdown \ -boot strict=on \ -usb \ --device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x2 \ -msg timestamp=on diff --git a/tests/qemuxml2argvdata/kvm-features-off.xml b/tests/qemuxml2argvdata/kvm-features-off.xml index d63a573239..7871698f06 100644 --- a/tests/qemuxml2argvdata/kvm-features-off.xml +++ b/tests/qemuxml2argvdata/kvm-features-off.xml @@ -1,4 +1,4 @@ -<domain type='qemu'> +<domain type='kvm'> <name>QEMUGuest1</name> <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> <memory unit='KiB'>219100</memory> @@ -16,6 +16,7 @@ <poll-control state='off'/> </kvm> </features> + <cpu mode='host-passthrough' check='none'/> <clock offset='utc'/> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> @@ -26,6 +27,6 @@ <controller type='pci' index='0' model='pci-root'/> <input type='mouse' bus='ps2'/> <input type='keyboard' bus='ps2'/> - <memballoon model='virtio'/> + <memballoon model='none'/> </devices> </domain> diff --git a/tests/qemuxml2xmloutdata/kvm-features-off.xml b/tests/qemuxml2xmloutdata/kvm-features-off.xml index f2e9407ac9..9c176190a5 100644 --- a/tests/qemuxml2xmloutdata/kvm-features-off.xml +++ b/tests/qemuxml2xmloutdata/kvm-features-off.xml @@ -1,4 +1,4 @@ -<domain type='qemu'> +<domain type='kvm'> <name>QEMUGuest1</name> <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> <memory unit='KiB'>219100</memory> @@ -16,6 +16,7 @@ <poll-control state='off'/> </kvm> </features> + <cpu mode='host-passthrough' check='none' migratable='off'/> <clock offset='utc'/> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> @@ -29,8 +30,6 @@ <input type='mouse' bus='ps2'/> <input type='keyboard' bus='ps2'/> <audio id='1' type='none'/> - <memballoon model='virtio'> - <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/> - </memballoon> + <memballoon model='none'/> </devices> </domain> -- 2.25.1

2 3

[PATCH v2 0/8] qemu: QAPI-schema: Add support for enum value 'features'
by Peter Krempa 01 Nov '21

01 Nov '21

Patches 2-8 were already reviewed by Michal. 1/8 is new as the qemu functionality was just merged upstream. Peter Krempa (8): qemucapabilitiestest: Update capability probe for qemu-6.2 on x86_64 virQEMUQAPISchemaTraverseEnum: Move helper variables into loop virQEMUQAPISchemaTraverseEnum: Use the modern 'members' array virQEMUQAPISchemaTraverseEnum: Allow query of enume type features testQEMUSchemaValidateEnum: Refactor logic to simplify switching to new QMP schema format testQEMUSchemaValidateEnum: Use new 'members' for 'enum' meta type testQEMUSchemaValidateDeprecated: Move to the top testQEMUSchemaValidateEnum: Validate deprecated members src/qemu/qemu_qapi.c | 46 +- .../caps_6.2.0.x86_64.replies | 3513 +++++++++++++++-- .../caps_6.2.0.x86_64.xml | 2 +- tests/testutilsqemuschema.c | 130 +- 4 files changed, 3214 insertions(+), 477 deletions(-) -- 2.31.1

2 9

[PATCH v2] qemu_block: Refactor qemuBlockExportAddNBD()
by Kristina Hanicova 01 Nov '21

01 Nov '21

This is v2 of: https://listman.redhat.com/archives/libvir-list/2021-October/msg01035.html Diff to v1: * negation of 'if' with switched body (proposed by Peter) Signed-off-by: Kristina Hanicova <khanicov(a)redhat.com> --- src/qemu/qemu_block.c | 33 +++++++++++++-------------------- 1 file changed, 13 insertions(+), 20 deletions(-) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index 34fdec2c4b..b8e70f6a83 100644 --- a/src/qemu/qemu_block.c +++ b/src/qemu/qemu_block.c @@ -3592,28 +3592,21 @@ qemuBlockExportAddNBD(virDomainObj *vm, const char *bitmap) { qemuDomainObjPrivate *priv = vm->privateData; + g_autoptr(virJSONValue) nbdprops = NULL; + const char *bitmaps[2] = { bitmap, NULL }; - if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKDEV)) { - if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCK_EXPORT_ADD)) { - g_autoptr(virJSONValue) nbdprops = NULL; - const char *bitmaps[2] = { bitmap, NULL }; + /* older qemu versions didn't support configuring the exportname and + * took the 'drivealias' as the export name */ + if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKDEV)) + return qemuMonitorNBDServerAdd(priv->mon, drivealias, NULL, writable, NULL); - if (!(nbdprops = qemuBlockExportGetNBDProps(src->nodeformat, - exportname, - writable, - bitmaps))) - return -1; + if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCK_EXPORT_ADD)) + return qemuMonitorNBDServerAdd(priv->mon, src->nodeformat, + exportname, writable, bitmap); - return qemuMonitorBlockExportAdd(priv->mon, &nbdprops); - } else { - return qemuMonitorNBDServerAdd(priv->mon, src->nodeformat, - exportname, writable, bitmap); - } - } else { - /* older qemu versions didn't support configuring the exportname and - * took the 'drivealias' as the export name */ - return qemuMonitorNBDServerAdd(priv->mon, drivealias, NULL, writable, NULL); - } + if (!(nbdprops = qemuBlockExportGetNBDProps(src->nodeformat, exportname, + writable, bitmaps))) + return -1; - return 0; + return qemuMonitorBlockExportAdd(priv->mon, &nbdprops); } -- 2.31.1

2 1

[PATCH] virsh: Fix ambiguous output in metadata-change event
by Han Han 01 Nov '21

01 Nov '21

When you set metadata with type element like the following: dom.setMetadata(libvirt.VIR_DOMAIN_METADATA_ELEMENT, "<test/>", 'abc', "HAHAH", 0) Then for `virsh event --all`, then it will output this message: event 'metadata-change' for domain 'rhel9': element HAHAH The message is ambiguous since it looks like the params for metadata-change event is the element HAHAH. Actually that means the type is element while the url is HAHAH. Let's make it more clear. Signed-off-by: Han Han <hhan(a)redhat.com> --- tools/virsh-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 7f3356a536..d454075dfc 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -13317,7 +13317,7 @@ virshEventMetadataChangePrint(virConnectPtr conn G_GNUC_UNUSED, { g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER; - virBufferAsprintf(&buf, _("event 'metadata-change' for domain '%s': %s %s\n"), + virBufferAsprintf(&buf, _("event 'metadata-change' for domain '%s': type %s, uri %s\n"), virDomainGetName(dom), UNKNOWNSTR(virshEventMetadataChangeTypeTypeToString(type)), NULLSTR(nsuri)); -- 2.33.1

2 1

[PATCH 0/2] Unify calculation of ovs and tc.
by jx8zjs 01 Nov '21

01 Nov '21

For other interface type, values in tc rules are calculated by multiply by 8*1000 instead of 8*1024. Related link: https://listman.redhat.com/archives/libvir-list/2021-October/msg01121.html zhangjl02 (2): virnetdevopenvswitch: unify calculation of ovs and tc. For other interface type, values in tc rules are calculated by multiply by 8*1000 instead of 8*1024. virnetdevopenvswitchtest: fix inbound value calculation src/util/virnetdevopenvswitch.c | 2 +- tests/virnetdevopenvswitchtest.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) -- 2.30.2.windows.1

2 3

[PATCH] ch_driver: Drop needless fwd declaration
by Michal Privoznik 01 Nov '21

01 Nov '21

In ch_driver.c there are two forward declarations that are not needed. Drop them. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/ch/ch_driver.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/ch/ch_driver.c b/src/ch/ch_driver.c index 1824d2fd16..9eaf3ee499 100644 --- a/src/ch/ch_driver.c +++ b/src/ch/ch_driver.c @@ -47,11 +47,6 @@ VIR_LOG_INIT("ch.ch_driver"); -static int chStateInitialize(bool privileged, - const char *root, - virStateInhibitCallback callback, - void *opaque); -static int chStateCleanup(void); virCHDriver *ch_driver = NULL; static virDomainObj * -- 2.32.0

2 1

[PATCH 0/2] lib: Drop retval check for virCapabilitiesAddGuest{, Domain)()
by Michal Privoznik 01 Nov '21

01 Nov '21

*** BLURB HERE *** Michal Prívozník (2): lib: Don't check for virCapabilitiesAddGuest() retval lib: Don't check for virCapabilitiesAddGuestDomain() retval src/bhyve/bhyve_capabilities.c | 13 ++++----- src/ch/ch_conf.c | 20 +++----------- src/esx/esx_driver.c | 14 +++------- src/hyperv/hyperv_driver.c | 12 +++------ src/libxl/libxl_capabilities.c | 34 +++++++++--------------- src/lxc/lxc_conf.c | 38 ++++++--------------------- src/openvz/openvz_conf.c | 19 +++----------- src/qemu/qemu_capabilities.c | 31 +++++----------------- src/security/virt-aa-helper.c | 23 +++------------- src/test/test_driver.c | 19 +++----------- src/vbox/vbox_common.c | 18 +++---------- src/vmware/vmware_conf.c | 26 ++++++------------ src/vz/vz_driver.c | 8 +++--- tests/testutils.c | 41 ++++++++++++----------------- tests/testutilslxc.c | 26 +++++++----------- tests/testutilsqemu.c | 30 ++++++--------------- tests/testutilsxen.c | 48 +++++++++++++++------------------- tests/vmx2xmltest.c | 38 +++++++-------------------- tests/xml2vmxtest.c | 39 +++++++-------------------- 19 files changed, 147 insertions(+), 350 deletions(-) -- 2.32.0

2 4

[PATCH] qemu: tpm: Enable creation of certs for TPM 1.2 in non-privileged mode
by Stefan Berger 01 Nov '21

01 Nov '21

When 'swtpm_setup --print-capabilities' shows the 'tpm12-not-need-root' flag, then it is possible to create certificates for the TPM 1.2 also in non-privileged mode since swtpm_setup doesn't need tcsd anymore. Check for this flag and create the certificates if this flag is found. Signed-off-by: Stefan Berger <stefanb(a)linux.ibm.com> --- src/qemu/qemu_tpm.c | 5 ++++- src/util/virtpm.c | 1 + src/util/virtpm.h | 1 + 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_tpm.c b/src/qemu/qemu_tpm.c index e1b08a66c5..91e21ae646 100644 --- a/src/qemu/qemu_tpm.c +++ b/src/qemu/qemu_tpm.c @@ -463,11 +463,14 @@ qemuTPMEmulatorRunSetup(const char *storagepath, if (!swtpm_setup) return -1; - if (!privileged && tpmversion == VIR_DOMAIN_TPM_VERSION_1_2) + if (!privileged && tpmversion == VIR_DOMAIN_TPM_VERSION_1_2 && + !virTPMSwtpmSetupCapsGet( + VIR_TPM_SWTPM_SETUP_FEATURE_TPM12_NOT_NEED_ROOT)) { return virFileWriteStr(logfile, _("Did not create EK and certificates since " "this requires privileged mode for a " "TPM 1.2\n"), 0600); + } if (!privileged && qemuTPMCreateConfigFiles(swtpm_setup) < 0) return -1; diff --git a/src/util/virtpm.c b/src/util/virtpm.c index 0f50de866c..40d9272e66 100644 --- a/src/util/virtpm.c +++ b/src/util/virtpm.c @@ -46,6 +46,7 @@ VIR_ENUM_IMPL(virTPMSwtpmSetupFeature, VIR_TPM_SWTPM_SETUP_FEATURE_LAST, "cmdarg-pwdfile-fd", "cmdarg-create-config-files", + "tpm12-not-need-root", ); /** diff --git a/src/util/virtpm.h b/src/util/virtpm.h index 3bb03b3b33..b75eb84f31 100644 --- a/src/util/virtpm.h +++ b/src/util/virtpm.h @@ -39,6 +39,7 @@ typedef enum { typedef enum { VIR_TPM_SWTPM_SETUP_FEATURE_CMDARG_PWDFILE_FD, VIR_TPM_SWTPM_SETUP_FEATURE_CMDARG_CREATE_CONFIG_FILES, + VIR_TPM_SWTPM_SETUP_FEATURE_TPM12_NOT_NEED_ROOT, VIR_TPM_SWTPM_SETUP_FEATURE_LAST } virTPMSwtpmSetupFeature; -- 2.31.1

2 1

[PATCH] qemu: support kvm-pv-ipi off
by zhenwei pi 01 Nov '21

01 Nov '21

QEMU version 3.1 introduced PV_SEND_IPI CPUID feature bit under commit 7f710c32bb8 (target-i386: adds PV_SEND_IPI CPUID feature bit). This patch adds a new KVM feature 'pv-ipi' to disable this feature (enabled by default). Newer CPU platform (Ex, AMD Zen2) supports hardware accelation for IPI in guest, to use this feature to get better performance in some scenarios. Detailed about the discussion: https://lkml.org/lkml/2021/10/20/423 To disable kvm-pv-ipi and have libvirt add "-cpu host,kvm-pv-ipi=off" to the QEMU command line, the following XML code needs to be added to the guest's domain description: <features> <kvm> <pv-ipi state='off'/> </kvm> </features> Signed-off-by: zhenwei pi <pizhenwei(a)bytedance.com> --- docs/formatdomain.rst | 2 ++ docs/schemas/domaincommon.rng | 5 +++++ src/conf/domain_conf.c | 3 +++ src/conf/domain_conf.h | 1 + src/qemu/qemu_command.c | 5 +++++ 5 files changed, 16 insertions(+) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 58768f7e5e..8ff833bbd2 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -1842,6 +1842,7 @@ Hypervisors may allow certain CPU / machine features to be toggled on/off. <hidden state='on'/> <hint-dedicated state='on'/> <poll-control state='on'/> + <pv-ipi state='off'/> </kvm> <xen> <e820_host state='on'/> @@ -1930,6 +1931,7 @@ are: hidden Hide the KVM hypervisor from standard MSR based discovery on, off :since:`1.2.8 (QEMU 2.1.0)` hint-dedicated Allows a guest to enable optimizations when running on dedicated vCPUs on, off :since:`5.7.0 (QEMU 2.12.0)` poll-control Decrease IO completion latency by introducing a grace period of busy waiting on, off :since:`6.10.0 (QEMU 4.2)` + pv-ipi Paravirtualized send IPIs on, off :since:`7.10.0 (QEMU 3.1)` ============== ============================================================================ ======= ============================ ``xen`` diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index f71e375a33..67df13d90d 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -7177,6 +7177,11 @@ <ref name="featurestate"/> </element> </optional> + <optional> + <element name="pv-ipi"> + <ref name="featurestate"/> + </element> + </optional> </interleave> </element> </define> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 48c6ee9865..c8868de577 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -204,6 +204,7 @@ VIR_ENUM_IMPL(virDomainKVM, "hidden", "hint-dedicated", "poll-control", + "pv-ipi", ); VIR_ENUM_IMPL(virDomainXen, @@ -21789,6 +21790,7 @@ virDomainDefFeaturesCheckABIStability(virDomainDef *src, case VIR_DOMAIN_KVM_HIDDEN: case VIR_DOMAIN_KVM_DEDICATED: case VIR_DOMAIN_KVM_POLLCONTROL: + case VIR_DOMAIN_KVM_PVIPI: if (src->kvm_features[i] != dst->kvm_features[i]) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("State of KVM feature '%s' differs: " @@ -27821,6 +27823,7 @@ virDomainDefFormatFeatures(virBuffer *buf, case VIR_DOMAIN_KVM_HIDDEN: case VIR_DOMAIN_KVM_DEDICATED: case VIR_DOMAIN_KVM_POLLCONTROL: + case VIR_DOMAIN_KVM_PVIPI: if (def->kvm_features[j]) virBufferAsprintf(&childBuf, "<%s state='%s'/>\n", virDomainKVMTypeToString(j), diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index f4be5c84f0..cb6d8975b8 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2073,6 +2073,7 @@ typedef enum { VIR_DOMAIN_KVM_HIDDEN = 0, VIR_DOMAIN_KVM_DEDICATED, VIR_DOMAIN_KVM_POLLCONTROL, + VIR_DOMAIN_KVM_PVIPI, VIR_DOMAIN_KVM_LAST } virDomainKVM; diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 7374b2beca..f7c19246d8 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -6848,6 +6848,11 @@ qemuBuildCpuCommandLine(virCommand *cmd, virBufferAddLit(&buf, ",kvm-poll-control=on"); break; + case VIR_DOMAIN_KVM_PVIPI: + if (def->kvm_features[i] == VIR_TRISTATE_SWITCH_OFF) + virBufferAddLit(&buf, ",kvm-pv-ipi=off"); + break; + case VIR_DOMAIN_KVM_LAST: break; } -- 2.25.1

2 2

[PATCH v2] qemu_agent: remove unused code
by Kristina Hanicova 01 Nov '21

01 Nov '21

This is v2 of: https://listman.redhat.com/archives/libvir-list/2021-October/msg01064.html Diff to v1: * I forgot to delete another part of the unused code which belonged together (noticed by Jano) This section of code was left unused ever since it was introduced ten years ago. I think we can safely remove it. Signed-off-by: Kristina Hanicova <khanicov(a)redhat.com> --- src/qemu/qemu_agent.c | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index 5f421be6f6..f319b881fc 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -60,17 +60,6 @@ VIR_LOG_INIT("qemu.qemu_agent"); */ #define QEMU_AGENT_MAX_RESPONSE (10 * 1024 * 1024) -/* When you are the first to uncomment this, - * don't forget to uncomment the corresponding - * part in qemuAgentIOProcessEvent as well. - * -static struct { - const char *type; - void (*handler)(qemuAgent *agent, virJSONValue *data); -} eventHandlers[] = { -}; -*/ - typedef struct _qemuAgentMessage qemuAgentMessage; struct _qemuAgentMessage { char *txBuffer; @@ -237,17 +226,6 @@ qemuAgentIOProcessEvent(qemuAgent *agent, return -1; } -/* - for (i = 0; i < G_N_ELEMENTS(eventHandlers); i++) { - if (STREQ(eventHandlers[i].type, type)) { - virJSONValue *data = virJSONValueObjectGet(obj, "data"); - VIR_DEBUG("handle %s handler=%p data=%p", type, - eventHandlers[i].handler, data); - (eventHandlers[i].handler)(agent, data); - break; - } - } -*/ return 0; } -- 2.31.1

2 1

Release of libvirt-7.9.0
by Jiri Denemark 01 Nov '21

01 Nov '21

The 7.9.0 release of both libvirt and libvirt-python is tagged and signed tarballs and source RPMs are available at https://libvirt.org/sources/ https://libvirt.org/sources/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is greatly appreciated. * New features * Introduce virtio-mem ``<memory/>`` model New virtio-mem model is introduced for ``<memory/>`` device which is a paravirtualized mechanism of adding/removing memory to/from a VM. Use ``virDomainUpdateDeviceFlags()`` API to adjust amount of memory or ``virsh update-memory-device`` for convenience. * qemu: support disabling hotplug of devices on the pci-root controller the <target hotplug='on|off'/> option is now supported for the pci-root controller on i440fx-based (x86 "pc") machinetypes. This can be used to disable hotplug/unplug of devices from this controller. The default behavior is unchanged (hotplug is allowed). * Support hotplug and hotunplug for virtiofs Filesystems backed by virtiofsd can now be hotplugged and hotunplugged. * virpcivpd: Add a PCI VPD parser A parser for the standard PCI/PCIe VPD ("I.3. VPD Definitions" in PCI 2.2+ and an equivalent definition in "6.28.1 VPD Format" PCIe 4.0) was added along with relevant types to represent PCI VPD in memory. This functionality got added for Linux only at this point (kernels above v2.6.26 have support for exposing VPD via sysfs). * virpci: Add PCI VPD-related helper functions to virpci In order to utilize the PCI VPD parser, a couple of helper functions got introduced to check for the presence of a VPD file in the sysfs tree and to invoke the PCI VPD parser to get a list of resources representing PCI VPD contents in memory. * nodedev: Add PCI VPD capability support Support for serializing and deserializing PCI VPD data structures is added following the addition of the PCI VPD parser. A new PCI device capability called "vpd" is introduced holding string resources and keyword resources found in PCI VPD. * qemu: Support page_per_vq for driver element This optional virtio attribute ``page_per_vq`` controls the layout of the notification capabilities exposed to the guest. It is recommended for the vDPA devices. * qemu: Support librbd encryption Add an encryption engine ``librbd``. It will provides the image-level encryption of librbd. It requires QEMU >= 6.1.0 and librbd >= 16.1.0. * Improvements * Use of JSON syntax with ``-device`` with upcoming QEMU-6.2 Libvirt started using JSON directly with the ``-device`` commandline parameter as it's considered the preferred stable syntax for further QEMU releases. If any problems with the conversion are encountered please report them as soon as possible. * Bug fixes * qemu: Fix problems on ``virsh domstats`` with qemu <5.2.0 Libvirt v7.2.0 and later called query-dirty-rate, which was introduced in qemu-5.2.0, regardless of qemu version and failed in qemu-5.1.0. This release fixes the bug. * Don't enter endless loop when unable to accept new clients If libvirtd (or any other daemon) hit the ulimit for maximum number of open files but there are still client connections pending then libvirtd (or corresponding split daemon) would enter an endless loop from which it would never recover. This behaviour is now fixed. * qemu: Run secondary driver hooks in split daemon mode Because of a bug in implementation it may happen that hooks from secondary drivers were not called in all cases, for instance a network hook wasn't called upon removal of interface after domain shut off itself. With this release the bug is fixed. Enjoy. Jirka

2 1

[PATCH v2 0/4] MAINTAINERS: Sanitize 'MIPS TCG CPUs' section
by Philippe Mathieu-Daudé 01 Nov '21

01 Nov '21

Move various files unrelated to MIPS TCG frontend into new sections. Since v1: - Do not add Paul without his consent - un-deprecate nanoMIPS Philippe Mathieu-Daudé (4): MAINTAINERS: Add MIPS general architecture support entry MAINTAINERS: Add entries to cover MIPS CPS / GIC hardware MAINTAINERS: Split MIPS TCG frontend vs MIPS machines/hardware MAINTAINERS: Agree to maintain nanoMIPS TCG frontend docs/about/deprecated.rst | 23 --------------------- MAINTAINERS | 43 +++++++++++++++++++++++++-------------- 2 files changed, 28 insertions(+), 38 deletions(-) -- 2.31.1

2 9

for rbd, how to use qmp directly to add dick
by longguang.yue 01 Nov '21

01 Nov '21

Hi, all: in my case, i need to add device via qmp. but for rbd drive needs a secret object. how to produce secret object. 'base64 -d' outputs unreadable code . -object secret,id=virtio-disk0-secret0,data=2YVH6svMZa42RfVx8MbIIVjtU6iGO8QzFADuDnLk7BU=,keyid=masterKey0,iv=/m3QyHQ33NeMEfDDMuDEeg==,format=base64 thanks

2 1

[libvirt PATCH v2 0/3] PCI VPD: Handle More Edge Cases
by Dmitrii Shcherbakov 01 Nov '21

01 Nov '21

This patch set improves edge case testing: * The parser is now more strict about checking boundary conditions when parsing fields: an invalid field length is a possibility which is now being accounted for; * The parser will now make sure that RV and RW fields are the last in their section by making sure that no more data is left to read after those; * The RW field in the read-write section is not considered a VPD format violation even though it is a violation of the spec since it does not prevent Libvirt from parsing valid data for presenting it to a user. This is a policy decision made by Libvirt in favor of usability with hardware that does not strictly follow the PCI/PCIe VPD spec. Invalid field values are now skipped instead of halting further parsing completely. Some vendors use 0xFF as placeholders in VPD-W since those values do not correspond to printable ASCII characters, they will be discarded, however, parsing will continue beyond that point. Also, it turns out that some vendors use printable ASCII characters not present in the alphanumeric range. Following a mailing list discussion Libvirt will accept printable ASCII characters to avoid cases where useful data is discarded. https://listman.redhat.com/archives/libvir-list/2021-October/msg01043.html Higher-level software needs to account for this character set and act accordingly. For example, the outcome of this is that one may get "N/A" as a value for a serial number that is supposed to be unique, however, there is no way for Libvirt to validate serial number uniqueness anyway even if it was a different character sequence. https://gitlab.com/dmitriis/libvirt/-/pipelines/398517951 (x86_64 only, have not set up arch-specific runners yet and over the limit of what gitlab provides) Dmitrii Shcherbakov (3): PCI VPD: handle additional edge cases PCI VPD: Skip fields with invalid values PCI VPD: Fix a wrong return code in a test case src/util/virpcivpd.c | 63 +++++++--- tests/virpcivpdtest.c | 263 ++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 296 insertions(+), 30 deletions(-) -- 2.32.0

2 4

[PATCH] qemu: Extend qemu.conf with PCR banks to activate during 'TPM manufacturing'
by Stefan Berger 29 Oct '21

29 Oct '21

Extend qemu.conf with a configration option swtpm_active_pcr_banks that allows a user to set a comma-separated list of PCR banks to activate during 'TPM manufacturing'. Valid PCR banks are sha1,sha256,sha384 and sha512. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2016599 Signed-off-by: Stefan Berger <stefanb(a)linux.ibm.com> --- src/qemu/qemu.conf | 8 ++++++++ src/qemu/qemu_conf.c | 6 ++++++ src/qemu/qemu_conf.h | 1 + src/qemu/qemu_tpm.c | 8 ++++++++ 4 files changed, 23 insertions(+) diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf index 71fd125699..7aa151ed55 100644 --- a/src/qemu/qemu.conf +++ b/src/qemu/qemu.conf @@ -915,6 +915,14 @@ #swtpm_user = "tss" #swtpm_group = "tss" +# The PCR banks to activate during 'TPM manufacturing' before a swtpm instance +# is started the first time. +# +# A comma-separated list without spaces containing sha1,sha256,sha384, or +# sha512. The default is 'sha256'. +# +# swtpm_active_pcr_banks = "sha256,sha384" + # For debugging and testing purposes it's sometimes useful to be able to disable # libvirt behaviour based on the capabilities of the qemu process. This option # allows to do so. DO _NOT_ use in production and beaware that the behaviour diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 0451bc70ac..a62525385e 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -384,6 +384,8 @@ static void virQEMUDriverConfigDispose(void *obj) g_strfreev(cfg->capabilityfilters); g_free(cfg->deprecationBehavior); + + g_free(cfg->swtpmActivePcrBanks); } @@ -1030,6 +1032,10 @@ virQEMUDriverConfigLoadSWTPMEntry(virQEMUDriverConfig *cfg, if (swtpm_group && virGetGroupID(swtpm_group, &cfg->swtpm_group) < 0) return -1; + if (virConfGetValueString(conf, "swtpm_active_pcr_banks", + &cfg->swtpmActivePcrBanks) < 0) + return -1; + return 0; } diff --git a/src/qemu/qemu_conf.h b/src/qemu/qemu_conf.h index 2f64e39a18..37461d9e31 100644 --- a/src/qemu/qemu_conf.h +++ b/src/qemu/qemu_conf.h @@ -219,6 +219,7 @@ struct _virQEMUDriverConfig { uid_t swtpm_user; gid_t swtpm_group; + char *swtpmActivePcrBanks; char **capabilityfilters; diff --git a/src/qemu/qemu_tpm.c b/src/qemu/qemu_tpm.c index e1b08a66c5..69fd1e67e3 100644 --- a/src/qemu/qemu_tpm.c +++ b/src/qemu/qemu_tpm.c @@ -448,6 +448,7 @@ qemuTPMEmulatorRunSetup(const char *storagepath, bool privileged, uid_t swtpm_user, gid_t swtpm_group, + const char *swtpmActivePcrBanks, const char *logfile, const virDomainTPMVersion tpmversion, const unsigned char *secretuuid, @@ -512,6 +513,9 @@ qemuTPMEmulatorRunSetup(const char *storagepath, } if (!incomingMigration) { + if (!swtpmActivePcrBanks) + swtpmActivePcrBanks = "sha256"; + virCommandAddArgList(cmd, "--tpm-state", storagepath, "--vmid", vmid, @@ -521,6 +525,7 @@ qemuTPMEmulatorRunSetup(const char *storagepath, "--create-platform-cert", "--lock-nvram", "--not-overwrite", + "--pcr-banks", swtpmActivePcrBanks, NULL); } else { virCommandAddArgList(cmd, @@ -568,6 +573,7 @@ qemuTPMEmulatorBuildCommand(virDomainTPMDef *tpm, bool privileged, uid_t swtpm_user, gid_t swtpm_group, + const char *swtpmActivePcrBanks, const char *swtpmStateDir, const char *shortName, bool incomingMigration) @@ -593,6 +599,7 @@ qemuTPMEmulatorBuildCommand(virDomainTPMDef *tpm, if (created && qemuTPMEmulatorRunSetup(tpm->data.emulator.storagepath, vmname, vmuuid, privileged, swtpm_user, swtpm_group, + swtpmActivePcrBanks, tpm->data.emulator.logfile, tpm->version, secretuuid, incomingMigration) < 0) goto error; @@ -812,6 +819,7 @@ qemuExtTPMStartEmulator(virQEMUDriver *driver, driver->privileged, cfg->swtpm_user, cfg->swtpm_group, + cfg->swtpmActivePcrBanks, cfg->swtpmStateDir, shortName, incomingMigration))) return -1; -- 2.31.1

3 6

[PATCH v2 0/9] Configurable policy for handling unstable interfaces
by Markus Armbruster 29 Oct '21

29 Oct '21

Option -compat lets you configure what to do when deprecated interfaces get used. This series extends this to unstable interfaces. Works the same way. Intended for testing users of the management interfaces. It is experimental. To make it possible, I replace the "x-" naming convention by special feature flag "unstable". See PATCH 1 for rationale. v2: * Rebased * PATCH 1: Commit message revamped [Kevin], R-bys kept * PATCH 6: gen_special_features() rewritten [John] * PATCH 7: disastrous typos fixed [Philippe] Markus Armbruster (9): qapi: New special feature flag "unstable" qapi: Mark unstable QMP parts with feature 'unstable' qapi: Eliminate QCO_NO_OPTIONS for a slight simplification qapi: Tools for sets of special feature flags in generated code qapi: Generalize struct member policy checking qapi: Generalize command policy checking qapi: Generalize enum member policy checking qapi: Factor out compat_policy_input_ok() qapi: Extend -compat to set policy for unstable interfaces docs/devel/qapi-code-gen.rst | 9 +- qapi/block-core.json | 123 +++++++++++++++++------- qapi/compat.json | 6 +- qapi/migration.json | 35 +++++-- qapi/misc.json | 6 +- qapi/qom.json | 11 ++- include/qapi/compat-policy.h | 7 ++ include/qapi/qmp/dispatch.h | 6 +- include/qapi/util.h | 8 +- include/qapi/visitor-impl.h | 6 +- include/qapi/visitor.h | 17 +++- monitor/misc.c | 7 +- qapi/qapi-forward-visitor.c | 16 +-- qapi/qapi-visit-core.c | 41 ++++---- qapi/qmp-dispatch.c | 57 ++++++++--- qapi/qmp-registry.c | 4 +- qapi/qobject-input-visitor.c | 22 ++--- qapi/qobject-output-visitor.c | 13 ++- storage-daemon/qemu-storage-daemon.c | 3 +- qapi/trace-events | 4 +- qemu-options.hx | 20 +++- scripts/qapi/commands.py | 12 +-- scripts/qapi/events.py | 10 +- scripts/qapi/gen.py | 8 ++ scripts/qapi/schema.py | 11 ++- scripts/qapi/types.py | 22 +++-- scripts/qapi/visit.py | 14 +-- tests/qapi-schema/qapi-schema-test.json | 7 +- tests/qapi-schema/qapi-schema-test.out | 5 + 29 files changed, 348 insertions(+), 162 deletions(-) -- 2.31.1

4 27

[PATCH 0/7] qemu: Various monitor cleanups and removal of legacy cpu hotplug
by Peter Krempa 29 Oct '21

29 Oct '21

Peter Krempa (7): qemuMonitorJSONQueryBlock: Reformat function header qemuMonitorJSONBlockInfoAdd: Refactor hash table addition qemuhotplugtest: Remove tests for legacy cpu hotplug on x86 qemuDomainHotplugAddVcpu: Remove legacy hotplug branch qemu: monitor: Remove unused qemuMonitorSetCPU qemuMonitorEjectMedia: Remove stale comment qemuMonitorJSONSave[Physical|Virtual]Memory: Reformat function headers src/qemu/qemu_hotplug.c | 22 +- src/qemu/qemu_monitor.c | 14 -- src/qemu/qemu_monitor.h | 6 - src/qemu/qemu_monitor_json.c | 77 +++---- src/qemu/qemu_monitor_json.h | 1 - tests/qemuhotplugtest.c | 1 - .../x86-old-bulk-domain.xml | 21 -- .../x86-old-bulk-monitor.json | 193 ------------------ .../x86-old-bulk-result-conf.xml | 31 --- .../x86-old-bulk-result-live.xml | 39 ---- tests/qemumonitorjsontest.c | 2 - 11 files changed, 35 insertions(+), 372 deletions(-) delete mode 100644 tests/qemuhotplugtestcpus/x86-old-bulk-domain.xml delete mode 100644 tests/qemuhotplugtestcpus/x86-old-bulk-monitor.json delete mode 100644 tests/qemuhotplugtestcpus/x86-old-bulk-result-conf.xml delete mode 100644 tests/qemuhotplugtestcpus/x86-old-bulk-result-live.xml -- 2.31.1

2 9

[PATCH for 7.9.0] NEWS: Document my bugfixes for v7.9.0
by Michal Privoznik 29 Oct '21

29 Oct '21

There are two bugs I fixed worth mentioning in the 7.9.0 release notes. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- NEWS.rst | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 1d2d31430f..1bb6897abd 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -86,6 +86,21 @@ v7.9.0 (unreleased) qemu-5.2.0, regardless of qemu version and failed in qemu-5.1.0. This release fixes the bug. + * Don't enter endless loop when unable to accept new clients + + If libvirtd (or any other daemon) hit the ulimit for maximum number of open + files but there are still client connections pending then libvirtd (or + corresponding split daemon) would enter an endless loop from which it would + never recover. This behaviour is now fixed. + + * qemu: Run secondary driver hooks in split daemon mode + + Because of a bug in implementation it may happen that hooks from secondary + drivers were not called in all cases, for instance a network hook wasn't + called upon removal of interface after domain shut off itself. With this + release the bug is fixed. + + v7.8.0 (2021-10-01) =================== -- 2.32.0

2 1

[libvirt PATCH] spec: Depend on qemu-kvm-block-driver-curl in RHEL-9
by Jiri Denemark 29 Oct '21

29 Oct '21

The curl block driver is no longer a requirement for qemu-kvm package in RHEL-9, which breaks support for https network disks. Let's depend on it explicitly (in libvirt-daemon-kvm meta package) until we possibly reimplement the https disk support using nbdkit (tracked in bug 2016527). https://bugzilla.redhat.com/show_bug.cgi?id=2014229 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- libvirt.spec.in | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index 4ecb28114c..b71888653d 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -791,6 +791,10 @@ Requires: libvirt-daemon-driver-nwfilter = %{version}-%{release} Requires: libvirt-daemon-driver-secret = %{version}-%{release} Requires: libvirt-daemon-driver-storage = %{version}-%{release} Requires: qemu-kvm +# qemu-kvm no longer depends on curl block driver in RHEL-9 +%if 0%{?rhel} > 8 +Requires: qemu-kvm-block-driver-curl +%endif %description daemon-kvm Server side daemon and driver required to manage the virtualization -- 2.33.1

3 4

[PATCH 0/4] Some news and docs update for v7.9.0
by Han Han 29 Oct '21

29 Oct '21

Han Han (4): docs: Fix a typo of page_per_vq news: News for the new virtio attribute page_per_vq docs: Make the version requirement more clear for rbd encryption news: Add support for librbd encryption NEWS.rst | 11 +++++++++++ docs/formatdomain.rst | 2 +- docs/formatstorageencryption.html.in | 5 +++-- 3 files changed, 15 insertions(+), 3 deletions(-) -- 2.33.1

2 5

Entering freeze for libvirt-7.9.0
by Jiri Denemark 29 Oct '21

29 Oct '21

I have just tagged v7.9.0-rc1 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue is more visible. If you have not done so yet, please update NEWS.rst to document any significant change you made since the last release. Thanks, Jirka

1 1

[PATCH v3 0/4] Add qemu support setting qos via ovs on ovs interface
by zhangjl02 29 Oct '21

29 Oct '21

--- diff to v2: - Remove passing "actualType" argument, get it inside funtion - Format code. diff to v1: - Move qemuDomainDefIsOvsport from src/qemu/qemu_domain.c to src/conf/domain_conf.c - Call virCommandFree(cmd)free cmd before reusing it. - Ddd g_autofree to variables. - Reduce usage of virReportError(), and coupled it with return -1. - Fix remove port qos error. - Optimise code structure. Thanks to Michal Privoznik for helping reviewing these patches and solving problems. Really sorry to bring extra work to review them. I will continue to learn and become familiar with submission process. Now libvirt use tc rules to manage interface's qos. But when an interface is created by ovs, there is no qos setting result in ovs database. Therefore, qos of ovs port should be set via ovs management command. We add a function to tell whether a port definition is an ovs managed virtual port. Change default qdisc rules, which return 0 directly if the port is ovs managed(When the ovs port is set noqueue, qos config on this port will not work). Add ovs management function of setting and cleaning qos. Then check if the port is an ovs managed port during its life cycle, and call the ovs management function to set or clean qos settings. zhangjl02 (4): virDomain: interface: add virDomainNetDefIsOvsport virDomain: interface: add virNetDevOpenvswitchInterfaceSetQos and virNetDevOpenvswitchInterfaceClearQos qemu: interface: remove setting noqueue for ovs port qemu: interface: check and use ovs command to set qos of ovs managed port src/conf/domain_conf.c | 11 ++ src/conf/domain_conf.h | 2 + src/libvirt_private.syms | 3 + src/qemu/qemu_command.c | 10 +- src/qemu/qemu_domain.c | 3 +- src/qemu/qemu_driver.c | 23 ++- src/qemu/qemu_hotplug.c | 35 ++-- src/qemu/qemu_process.c | 7 +- src/util/virnetdevopenvswitch.c | 274 ++++++++++++++++++++++++++++++++ src/util/virnetdevopenvswitch.h | 11 ++ 10 files changed, 364 insertions(+), 15 deletions(-) -- 2.30.2.windows.1

4 14

[PATCH 0/3] Docs and news update for v7.8.0
by Han Han 29 Oct '21

29 Oct '21

Han Han (3): docs: Mention QEMU version requirement for queue-size news: Add queue_size option to virtio disk news: Add validation flags for creating of net, nwfilter-binding, net port NEWS.rst | 16 ++++++++++++++++ docs/formatdomain.rst | 2 +- 2 files changed, 17 insertions(+), 1 deletion(-) -- 2.33.1

2 4

[PATCH] news: Support vhostuser in virsh attach-interface since v7.7.0
by Han Han 29 Oct '21

29 Oct '21

Signed-off-by: Han Han <hhan(a)redhat.com> --- NEWS.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 5f1cf19940..694c506cad 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -162,6 +162,8 @@ v7.7.0 (2021-09-01) forbidden for older qemus which don't support the update API as the guest could still reboot and execute some instructions until it was terminated. + * virsh: Support vhostuser in attach-interface + * **Bug fixes** * qemu: Open chardev logfile on behalf of QEMU -- 2.33.1

1 0