- Devel - libvirt List Archives

[PATCH 0/8] kbase: debuglogs: Include guidance how to setup logging with modular daemons
by Peter Krempa 20 Jan '22

20 Jan '22

Modular daemons are the default in many cases yet, one of our most frequented documents neglects to describe the intricacies of the setup. Browsable result is available at: https://pipo.sk.gitlab.io/-/libvirt/-/jobs/1983126893/artifacts/website/dae… https://pipo.sk.gitlab.io/-/libvirt/-/jobs/1983126893/artifacts/website/kba… Sorry for TLS warnings. Gitlab didn't really think through allowing users to pick username with a dot and I refuse to change it. Peter Krempa (8): docs: daemons: Add section on figuring out whether modular or monolithic daemon is in use kbase: debuglogs: Use common heading hierarchy kbase: debuglogs: Un-nest section on enabling debug logs kbase: debuglogs: Section off the settings for legacy libvirt kbase: debuglogs: Add a section describing log outputs and filters kbase: debuglogs: Extract client library logging setup kbase: debuglogs: Emphasise 'virt-admin' kbase: debuglogs: Fix for modular daemons docs/daemons.rst | 47 ++++++++ docs/kbase/debuglogs.rst | 239 ++++++++++++++++++++++++++++++--------- 2 files changed, 235 insertions(+), 51 deletions(-) -- 2.34.1

2 19

[PATCH 0/5] storage: Implement 'checkPool' for 'disk' pools and various fixes
by Peter Krempa 20 Jan '22

20 Jan '22

Peter Krempa (5): storage: Add debug logs for storage pool config loading virStoragePoolObjLoadAllConfigs: Use automatic memory clearing storageDriverAutostartCallback: Refactor control flow virStoragePoolObjSourceFindDuplicateCb: Fix handling of VIR_STORAGE_POOL_ISCSI_DIRECT storage: Implement 'checkPool' method for 'disk' type pools src/conf/virstorageobj.c | 23 ++++---------- src/storage/storage_backend_disk.c | 27 ++++++++++++++++ src/storage/storage_driver.c | 51 ++++++++++++++++-------------- 3 files changed, 61 insertions(+), 40 deletions(-) -- 2.34.1

2 6

[libvirt][PATCH v9 0/5] Support query and use SGX
by Haibin Huang 20 Jan '22

20 Jan '22

This patch series provides support for enabling Intel's Software Guard Extensions (SGX) feature in guest VM. Giving the SGX support in QEMU be accepted and will be merged in two days Intel SGX is a set of instructions that increases the security of application code and data, giving them more protection from disclosure or modification. Developers can partition sensitive information into enclaves, which are areas of execution in memory with more security protection. The typical flow looks below at very high level: 1. Calls virConnectGetDomainCapabilities API to domain capabilities that includes the following SGX information. <feature> ... <sgx supported='yes'> <epc_size unit='KiB'>N</epc_size> </sgx> </feature> 2. User requests to start a guest calling virCreateXML() with SGX requirement. It should contain <devices> ... <memory model='sgx-epc'> <target> <size unit='KiB'>N</size> </target> </memory> ... </devices> Haibin Huang (2): Get SGX Capabilities from QEMU Transfer Qemu SGX Capabilities to XML Lin Yang (3): conf: Introduce SGX EPC element into device memory xml qemu: Add command-line to generate SGX EPC memory backend Add unit tests for guest VM creation command with SGX EPC docs/schemas/domaincaps.rng | 22 ++- docs/schemas/domaincommon.rng | 1 + src/conf/domain_capabilities.c | 29 ++++ src/conf/domain_capabilities.h | 13 ++ src/conf/domain_conf.c | 6 + src/conf/domain_conf.h | 1 + src/conf/domain_validate.c | 1 + src/libvirt_private.syms | 1 + src/qemu/qemu_alias.c | 6 +- src/qemu/qemu_capabilities.c | 143 +++++++++++++++++- src/qemu/qemu_capabilities.h | 4 + src/qemu/qemu_command.c | 41 ++++- src/qemu/qemu_domain.c | 12 +- src/qemu/qemu_domain_address.c | 6 + src/qemu/qemu_driver.c | 1 + src/qemu/qemu_monitor.c | 10 ++ src/qemu/qemu_monitor.h | 3 + src/qemu/qemu_monitor_json.c | 83 ++++++++++ src/qemu/qemu_monitor_json.h | 3 + src/qemu/qemu_process.c | 2 + src/qemu/qemu_validate.c | 8 + src/security/security_apparmor.c | 1 + src/security/security_dac.c | 2 + src/security/security_selinux.c | 2 + tests/domaincapsdata/bhyve_basic.x86_64.xml | 1 + tests/domaincapsdata/bhyve_fbuf.x86_64.xml | 1 + tests/domaincapsdata/bhyve_uefi.x86_64.xml | 1 + tests/domaincapsdata/empty.xml | 1 + tests/domaincapsdata/libxl-xenfv.xml | 1 + tests/domaincapsdata/libxl-xenpv.xml | 1 + .../domaincapsdata/qemu_2.11.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.11.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.11.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.11.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.12.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.12.0-tcg.x86_64.xml | 1 + .../qemu_2.12.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.12.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.12.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_2.12.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.12.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.4.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.4.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.4.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.5.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.5.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.5.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.6.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.6.0-tcg.x86_64.xml | 1 + .../qemu_2.6.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.6.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.6.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_2.6.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.7.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.7.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.7.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.7.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.8.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.8.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.8.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.8.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.9.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.9.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.9.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_2.9.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.9.0.x86_64.xml | 1 + .../domaincapsdata/qemu_3.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_3.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_3.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_3.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_3.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_3.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_3.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_3.1.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_3.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_4.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_4.0.0-tcg.x86_64.xml | 1 + .../qemu_4.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_4.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_4.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_4.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_4.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_4.2.0-tcg.x86_64.xml | 1 + .../qemu_4.2.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.s390x.xml | 1 + tests/domaincapsdata/qemu_4.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_5.0.0-tcg.x86_64.xml | 1 + .../qemu_5.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_5.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_5.1.0.sparc.xml | 1 + tests/domaincapsdata/qemu_5.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.2.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_5.2.0-tcg.x86_64.xml | 1 + .../qemu_5.2.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.2.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.2.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_5.2.0.s390x.xml | 1 + tests/domaincapsdata/qemu_5.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_6.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_6.0.0-tcg.x86_64.xml | 1 + .../qemu_6.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_6.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_6.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_6.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_6.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_6.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_6.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_6.2.0-q35.x86_64.xml | 4 + .../domaincapsdata/qemu_6.2.0-tcg.x86_64.xml | 4 + tests/domaincapsdata/qemu_6.2.0.x86_64.xml | 4 + .../caps_6.2.0.x86_64.replies | 22 ++- .../caps_6.2.0.x86_64.xml | 5 + .../sgx-epc.x86_64-6.2.0.args | 37 +++++ tests/qemuxml2argvdata/sgx-epc.xml | 36 +++++ tests/qemuxml2argvtest.c | 2 + 126 files changed, 597 insertions(+), 12 deletions(-) create mode 100644 tests/qemuxml2argvdata/sgx-epc.x86_64-6.2.0.args create mode 100644 tests/qemuxml2argvdata/sgx-epc.xml -- 2.17.1

3 18

[PATCH] docs: man: virsh: Document more carefully that 'guestinfo' can return nothing
by Peter Krempa 20 Jan '22

20 Jan '22

When invoking 'virsh guestinfo $VM' without explicitly specifying a group of information to return, virsh always reports success even when the guest agent doesn't report any information in the current state. This is desired in situations when you are okay with stats being missing and avoids spurious errors being reported. Clarify that this is really desired in the man page. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2041665 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- docs/manpages/virsh.rst | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index dd534c10cb..19fb8cd0e4 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -2768,11 +2768,14 @@ Note that this command requires a guest agent to be configured and running in the domain's guest OS. When run without any arguments, this command prints all information types that -are supported by the guest agent. You can limit the types of information that -are returned by specifying one or more flags. If a requested information -type is not supported, the processes will provide an exit code of 1. -Available information types flags are *--user*, *--os*, +are supported by the guest agent at that point, omitting unavailable ones. +Success is always reported in this mode. + +You can limit the types of information that are returned by specifying one or +more flags. Available information types flags are *--user*, *--os*, *--timezone*, *--hostname*, *--filesystem*, *--disk* and *--interface*. +If an explicitly requested information type is not supported by the guest agent +at that point, the processes will provide an exit code of 1. Note that depending on the hypervisor type and the version of the guest agent running within the domain, not all of the following information may be -- 2.34.1

2 1

[libvirt PATCH v2 0/1] docs: Drop node.gif
by Andrea Bolognani 20 Jan '22

20 Jan '22

Changes from [v1] * drop the file instead of converting it. [v1] https://listman.redhat.com/archives/libvir-list/2022-January/msg00317.html Andrea Bolognani (1): docs: Drop node.gif docs/goals.html.in | 3 --- docs/images/meson.build | 1 - docs/images/node.gif | Bin 1397 -> 0 bytes docs/images/node.svg | 36 ------------------------------------ 4 files changed, 40 deletions(-) delete mode 100644 docs/images/node.gif delete mode 100644 docs/images/node.svg -- 2.34.1

2 2

[libvirt PATCH] manpages: libvirt-guests: Fix typos
by Tim Wiederhake 20 Jan '22

20 Jan '22

Signed-off-by: Tim Wiederhake <twiederh(a)redhat.com> --- docs/manpages/libvirt-guests.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/manpages/libvirt-guests.rst b/docs/manpages/libvirt-guests.rst index 76045ed11a..bea08e3bff 100644 --- a/docs/manpages/libvirt-guests.rst +++ b/docs/manpages/libvirt-guests.rst @@ -21,7 +21,7 @@ DESCRIPTION =========== ``libvirt-guests`` is a service that can be used to coordinate guest and host -lifecyle actions. By default, ``libvirt-guests`` will suspend running guests +lifecycle actions. By default, ``libvirt-guests`` will suspend running guests when the host shuts down, and restore them to their pre-shutdown state when the host reboots. @@ -40,7 +40,7 @@ FILES ===== ``libvirt-guests`` defines several variables to control service behavior. -The default vaule of these variables can be overridden in: +The default value of these variables can be overridden in: * ``@SYSCONFDIR@/sysconfig/libvirt-guests`` -- 2.31.1

3 4

[PATCH] spec: Run pre/post-install stuff on 'daemon-driver-storage-core'
by Peter Krempa 19 Jan '22

19 Jan '22

'daemon-driver-storage' is just a meta-package, the actual daemon is in the 'daemon-driver-storage-core' package, so without installing the meta package the storage daemon is not being enabled. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2025644 Fixes: 50eae3f8859, b8ef6255444 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- libvirt.spec.in | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index b9f1e30906..f0ff4c0ece 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1483,19 +1483,19 @@ fi %libvirt_daemon_perform_restart virtsecretd -%pre daemon-driver-storage +%pre daemon-driver-storage-core %libvirt_sysconfig_pre virtstoraged -%post daemon-driver-storage +%post daemon-driver-storage-core %if %{with_modular_daemons} %libvirt_daemon_systemd_post virtstoraged %endif %libvirt_daemon_schedule_restart virtstoraged -%preun daemon-driver-storage +%preun daemon-driver-storage-core %libvirt_daemon_systemd_preun virtstoraged -%posttrans daemon-driver-storage +%posttrans daemon-driver-storage-core %libvirt_sysconfig_posttrans virtstoraged %libvirt_daemon_perform_restart virtstoraged -- 2.34.1

3 2

[PATCH] docs: man: Unify wording for the description of '--timeout' of daemons
by Peter Krempa 19 Jan '22

19 Jan '22

Use a common wording for all various daemons to prevent having to adjust the documentation any further by just outlining that neither clients nor anything else needing the attention of the daemon must be present in order to shut down. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2035985 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- docs/manpages/virtbhyved.rst | 3 ++- docs/manpages/virtinterfaced.rst | 3 ++- docs/manpages/virtlockd.rst | 5 +++-- docs/manpages/virtlogd.rst | 5 +++-- docs/manpages/virtlxcd.rst | 3 ++- docs/manpages/virtnetworkd.rst | 3 ++- docs/manpages/virtnodedevd.rst | 3 ++- docs/manpages/virtnwfilterd.rst | 3 ++- docs/manpages/virtproxyd.rst | 3 ++- docs/manpages/virtqemud.rst | 3 ++- docs/manpages/virtsecretd.rst | 3 ++- docs/manpages/virtstoraged.rst | 3 ++- docs/manpages/virtvboxd.rst | 3 ++- docs/manpages/virtvzd.rst | 3 ++- docs/manpages/virtxend.rst | 3 ++- 15 files changed, 32 insertions(+), 17 deletions(-) diff --git a/docs/manpages/virtbhyved.rst b/docs/manpages/virtbhyved.rst index 9fdaca6da2..2e56514914 100644 --- a/docs/manpages/virtbhyved.rst +++ b/docs/manpages/virtbhyved.rst @@ -61,7 +61,8 @@ Use this name for the PID file, overriding the default value. ``-t``, ``--timeout *SECONDS*`` Exit after timeout period (in seconds), provided there are neither any client -connections nor any running domains. +connections nor any other resources (e.g. running domains, locks, etc.) needing +attention of the daemon. ``-v``, ``--verbose`` diff --git a/docs/manpages/virtinterfaced.rst b/docs/manpages/virtinterfaced.rst index 5777dba638..9b836b0b12 100644 --- a/docs/manpages/virtinterfaced.rst +++ b/docs/manpages/virtinterfaced.rst @@ -83,7 +83,8 @@ Use this name for the PID file, overriding the default value. ``-t``, ``--timeout *SECONDS*`` Exit after timeout period (in seconds), provided there are neither any client -connections nor any running domains. +connections nor any other resources (e.g. running domains, locks, etc.) needing +attention of the daemon. ``-v``, ``--verbose`` diff --git a/docs/manpages/virtlockd.rst b/docs/manpages/virtlockd.rst index 0bbee5a5f7..7ea720d1b7 100644 --- a/docs/manpages/virtlockd.rst +++ b/docs/manpages/virtlockd.rst @@ -50,8 +50,9 @@ Use this configuration file, overriding the default value. ``-t``, ``--timeout`` *SECONDS* -Automatically shutdown after *SECONDS* have elapsed with -no active client or lock. +Exit after timeout period (in seconds), provided there are neither any client +connections nor any other resources (e.g. running domains, locks, etc.) needing +attention of the daemon. ``-p``, ``--pid-file`` *FILE* diff --git a/docs/manpages/virtlogd.rst b/docs/manpages/virtlogd.rst index 1e39ff1b49..0b00595a85 100644 --- a/docs/manpages/virtlogd.rst +++ b/docs/manpages/virtlogd.rst @@ -50,8 +50,9 @@ Use this configuration file, overriding the default value. ``-t``, ``--timeout`` *SECONDS* -Automatically shutdown after *SECONDS* have elapsed with -no active console log. +Exit after timeout period (in seconds), provided there are neither any client +connections nor any other resources (e.g. running domains, locks, etc.) needing +attention of the daemon. ``-p``, ``--pid-file`` *FILE* diff --git a/docs/manpages/virtlxcd.rst b/docs/manpages/virtlxcd.rst index 2e9d8fd14b..4c9a441d0d 100644 --- a/docs/manpages/virtlxcd.rst +++ b/docs/manpages/virtlxcd.rst @@ -83,7 +83,8 @@ Use this name for the PID file, overriding the default value. ``-t``, ``--timeout *SECONDS*`` Exit after timeout period (in seconds), provided there are neither any client -connections nor any running domains. +connections nor any other resources (e.g. running domains, locks, etc.) needing +attention of the daemon. ``-v``, ``--verbose`` diff --git a/docs/manpages/virtnetworkd.rst b/docs/manpages/virtnetworkd.rst index 6d9c5e5fa3..b9409723fb 100644 --- a/docs/manpages/virtnetworkd.rst +++ b/docs/manpages/virtnetworkd.rst @@ -83,7 +83,8 @@ Use this name for the PID file, overriding the default value. ``-t``, ``--timeout *SECONDS*`` Exit after timeout period (in seconds), provided there are neither any client -connections nor any running domains. +connections nor any other resources (e.g. running domains, locks, etc.) needing +attention of the daemon. ``-v``, ``--verbose`` diff --git a/docs/manpages/virtnodedevd.rst b/docs/manpages/virtnodedevd.rst index ef968e486e..1c79529bd8 100644 --- a/docs/manpages/virtnodedevd.rst +++ b/docs/manpages/virtnodedevd.rst @@ -82,7 +82,8 @@ Use this name for the PID file, overriding the default value. ``-t``, ``--timeout *SECONDS*`` Exit after timeout period (in seconds), provided there are neither any client -connections nor any running domains. +connections nor any other resources (e.g. running domains, locks, etc.) needing +attention of the daemon. ``-v``, ``--verbose`` diff --git a/docs/manpages/virtnwfilterd.rst b/docs/manpages/virtnwfilterd.rst index 4faa6b225d..0690c795d9 100644 --- a/docs/manpages/virtnwfilterd.rst +++ b/docs/manpages/virtnwfilterd.rst @@ -83,7 +83,8 @@ Use this name for the PID file, overriding the default value. ``-t``, ``--timeout *SECONDS*`` Exit after timeout period (in seconds), provided there are neither any client -connections nor any running domains. +connections nor any other resources (e.g. running domains, locks, etc.) needing +attention of the daemon. ``-v``, ``--verbose`` diff --git a/docs/manpages/virtproxyd.rst b/docs/manpages/virtproxyd.rst index 0366935b9a..918aae6c2b 100644 --- a/docs/manpages/virtproxyd.rst +++ b/docs/manpages/virtproxyd.rst @@ -105,7 +105,8 @@ Use this name for the PID file, overriding the default value. ``-t``, ``--timeout *SECONDS*`` Exit after timeout period (in seconds), provided there are neither any client -connections nor any running domains. +connections nor any other resources (e.g. running domains, locks, etc.) needing +attention of the daemon. ``-v``, ``--verbose`` diff --git a/docs/manpages/virtqemud.rst b/docs/manpages/virtqemud.rst index ea8d6e3105..f1f1710393 100644 --- a/docs/manpages/virtqemud.rst +++ b/docs/manpages/virtqemud.rst @@ -83,7 +83,8 @@ Use this name for the PID file, overriding the default value. ``-t``, ``--timeout *SECONDS*`` Exit after timeout period (in seconds), provided there are neither any client -connections nor any running domains. +connections nor any other resources (e.g. running domains, locks, etc.) needing +attention of the daemon. ``-v``, ``--verbose`` diff --git a/docs/manpages/virtsecretd.rst b/docs/manpages/virtsecretd.rst index fffb3a24f6..f35bfb6b5a 100644 --- a/docs/manpages/virtsecretd.rst +++ b/docs/manpages/virtsecretd.rst @@ -82,7 +82,8 @@ Use this name for the PID file, overriding the default value. ``-t``, ``--timeout *SECONDS*`` Exit after timeout period (in seconds), provided there are neither any client -connections nor any running domains. +connections nor any other resources (e.g. running domains, locks, etc.) needing +attention of the daemon. ``-v``, ``--verbose`` diff --git a/docs/manpages/virtstoraged.rst b/docs/manpages/virtstoraged.rst index 4ceae57e40..ae25a90040 100644 --- a/docs/manpages/virtstoraged.rst +++ b/docs/manpages/virtstoraged.rst @@ -83,7 +83,8 @@ Use this name for the PID file, overriding the default value. ``-t``, ``--timeout *SECONDS*`` Exit after timeout period (in seconds), provided there are neither any client -connections nor any running domains. +connections nor any other resources (e.g. running domains, locks, etc.) needing +attention of the daemon. ``-v``, ``--verbose`` diff --git a/docs/manpages/virtvboxd.rst b/docs/manpages/virtvboxd.rst index d7339d99f2..0be68d87b8 100644 --- a/docs/manpages/virtvboxd.rst +++ b/docs/manpages/virtvboxd.rst @@ -81,7 +81,8 @@ Use this name for the PID file, overriding the default value. ``-t``, ``--timeout *SECONDS*`` Exit after timeout period (in seconds), provided there are neither any client -connections nor any running domains. +connections nor any other resources (e.g. running domains, locks, etc.) needing +attention of the daemon. ``-v``, ``--verbose`` diff --git a/docs/manpages/virtvzd.rst b/docs/manpages/virtvzd.rst index 42dfa263e4..d2d6fecce6 100644 --- a/docs/manpages/virtvzd.rst +++ b/docs/manpages/virtvzd.rst @@ -83,7 +83,8 @@ Use this name for the PID file, overriding the default value. ``-t``, ``--timeout *SECONDS*`` Exit after timeout period (in seconds), provided there are neither any client -connections nor any running domains. +connections nor any other resources (e.g. running domains, locks, etc.) needing +attention of the daemon. ``-v``, ``--verbose`` diff --git a/docs/manpages/virtxend.rst b/docs/manpages/virtxend.rst index b08346b489..d12196956c 100644 --- a/docs/manpages/virtxend.rst +++ b/docs/manpages/virtxend.rst @@ -83,7 +83,8 @@ Use this name for the PID file, overriding the default value. ``-t``, ``--timeout *SECONDS*`` Exit after timeout period (in seconds), provided there are neither any client -connections nor any running domains. +connections nor any other resources (e.g. running domains, locks, etc.) needing +attention of the daemon. ``-v``, ``--verbose`` -- 2.34.1

2 3

[PATCH 0/2] virsh: Introduce completer for two net-update arguments
by Michal Privoznik 19 Jan '22

19 Jan '22

*** BLURB HERE *** Michal Prívozník (2): virsh: Introduce net-update --command completer virsh: Introduce net-update --section completer tools/virsh-completer-network.c | 43 +++++++++++++++++++++++++++++++++ tools/virsh-completer-network.h | 10 ++++++++ tools/virsh-network.c | 4 +-- tools/virsh-network.h | 3 +++ 4 files changed, 58 insertions(+), 2 deletions(-) -- 2.34.1

2 4

[PATCH v1 0/5] qemu: Allow prealloc for virtio-mem-pci
by Michal Privoznik 19 Jan '22

19 Jan '22

See 5/5 for explanation, but long story short when prealloc is needed we can't set it on memory-backend-* but on virtio-mem-pci. Patches 1-3 are cleanup and independent of the feature. Michal Prívozník (5): qemuBuildMemoryDeviceProps: Fix const correctness qemu: Separate out hugepages handling from qemuBuildMemoryBackendProps() qemu: Move @prealloc into qemuBuildMemoryGetPagesize() qemu_capabilities: Introduce QEMU_CAPS_DEVICE_VIRTIO_MEM_PCI_PREALLOC qemu: Allow prealloc for virtio-mem-pci src/qemu/qemu_capabilities.c | 8 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 220 +++++++------ src/qemu/qemu_command.h | 6 +- src/qemu/qemu_hotplug.c | 2 +- .../caps_5.1.0.x86_64.replies | 255 +++++++++++++-- .../caps_5.2.0.x86_64.replies | 260 ++++++++++++++-- .../caps_6.0.0.x86_64.replies | 282 +++++++++++++++-- .../caps_6.1.0.x86_64.replies | 282 +++++++++++++++-- .../caps_6.2.0.x86_64.replies | 282 +++++++++++++++-- .../caps_7.0.0.x86_64.replies | 293 ++++++++++++++++-- .../caps_7.0.0.x86_64.xml | 1 + ...mory-hotplug-virtio-mem.x86_64-latest.args | 2 +- 13 files changed, 1646 insertions(+), 248 deletions(-) -- 2.34.1

2 7

[libvirt PATCH v3 0/2] Code style documentation
by Tim Wiederhake 19 Jan '22

19 Jan '22

Some additions and clarifications to libvirt's code style documentation, based on points of feedback that are given regularly on the mailing list. V1: https://listman.redhat.com/archives/libvir-list/2022-January/msg00631.html V2: https://listman.redhat.com/archives/libvir-list/2022-January/msg00681.html Changes since V2: * Changed the example type name in patch 1 Tim Wiederhake (2): docs: coding-style: Clarify on virXXXPtr types docs: coding-style: One variable declaration per line docs/coding-style.rst | 28 +++++++++++++++++++++++----- 1 file changed, 23 insertions(+), 5 deletions(-) -- 2.31.1

7 8

[libvirt PATCH 0/7] remove support for unpriv_sgio
by Ján Tomko 19 Jan '22

19 Jan '22

This feature was never merged in upstream kernel and only made it to upstream libvirt by mistakes. Remove it as well as the 'sharedDevices' hash table that was only used for this purpose. The 'sgio' attribute is preserved for compatibility reasons and its 'filtered' value is left intact. An error is added to the XML validator for the 'unfiltered' value, which means 'unpriv_sgio' Ján Tomko (7): util: remove virGetUnprivSGIOSysfsPath conf: reject unfiltered sgio on validation qemu: remove all use of SGIO qemu: remove sharedDevices hash table util: remove virGetDeviceID util: remove {Get,Set}UnprivSGIO qemu: simplify qemuProcessSetupRawIO src/conf/domain_validate.c | 11 + src/libvirt_private.syms | 4 - src/qemu/qemu_conf.c | 448 ------------------ src/qemu/qemu_conf.h | 37 -- src/qemu/qemu_driver.c | 3 - src/qemu/qemu_hostdev.c | 31 -- src/qemu/qemu_hotplug.c | 23 - src/qemu/qemu_process.c | 36 +- src/util/virutil.c | 122 ----- src/util/virutil.h | 12 - tests/qemuhotplugmock.c | 17 - .../disk-scsi-lun-passthrough-sgio.xml | 35 -- tests/qemuxml2argvdata/hostdev-scsi-rawio.xml | 37 -- tests/qemuxml2argvdata/hostdev-scsi-sgio.xml | 37 -- .../disk-scsi-lun-passthrough-sgio.xml | 46 -- .../qemuxml2xmloutdata/hostdev-scsi-rawio.xml | 47 -- .../qemuxml2xmloutdata/hostdev-scsi-sgio.xml | 47 -- tests/qemuxml2xmltest.c | 11 - 18 files changed, 14 insertions(+), 990 deletions(-) delete mode 100644 tests/qemuxml2argvdata/disk-scsi-lun-passthrough-sgio.xml delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-rawio.xml delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-sgio.xml delete mode 100644 tests/qemuxml2xmloutdata/disk-scsi-lun-passthrough-sgio.xml delete mode 100644 tests/qemuxml2xmloutdata/hostdev-scsi-rawio.xml delete mode 100644 tests/qemuxml2xmloutdata/hostdev-scsi-sgio.xml -- 2.31.1

2 10

[PATCH 0/5] qemu: Clean up and fix corner case in 'max_outputs'/heads handling
by Peter Krempa 19 Jan '22

19 Jan '22

Peter Krempa (5): qemuBuildDeviceVideoCmd: Always assume support for 'max_outputs' property qemu: capabilities: Retire QEMU_CAPS_QXL_MAX_OUTPUTS and QEMU_CAPS_VIRTIO_GPU_MAX_OUTPUTS qemuBuildDeviceVideoCmd: Simplify formatting of 'max_outputs' property qemuValidateDomainDeviceDefVideo: Refactor condition checking for qxl and virtio-vga qemuValidateDomainDeviceDefVideo: Reject non-default video head count for devices not supporting it src/qemu/qemu_capabilities.c | 6 ++--- src/qemu/qemu_capabilities.h | 4 ++-- src/qemu/qemu_command.c | 24 +++++-------------- src/qemu/qemu_validate.c | 21 ++++++++++------ .../caps_2.11.0.s390x.xml | 1 - .../caps_2.11.0.x86_64.xml | 2 -- .../caps_2.12.0.aarch64.xml | 1 - .../caps_2.12.0.ppc64.xml | 1 - .../caps_2.12.0.s390x.xml | 1 - .../caps_2.12.0.x86_64.xml | 2 -- .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 1 - .../caps_3.0.0.riscv32.xml | 1 - .../caps_3.0.0.riscv64.xml | 1 - .../qemucapabilitiesdata/caps_3.0.0.s390x.xml | 1 - .../caps_3.0.0.x86_64.xml | 2 -- .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 1 - .../caps_3.1.0.x86_64.xml | 2 -- .../caps_4.0.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 1 - .../caps_4.0.0.riscv32.xml | 1 - .../caps_4.0.0.riscv64.xml | 1 - .../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 1 - .../caps_4.0.0.x86_64.xml | 2 -- .../caps_4.1.0.x86_64.xml | 2 -- .../caps_4.2.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 - .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 - .../caps_4.2.0.x86_64.xml | 2 -- .../caps_5.0.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 - .../caps_5.0.0.riscv64.xml | 1 - .../caps_5.0.0.x86_64.xml | 2 -- .../caps_5.1.0.x86_64.xml | 2 -- .../caps_5.2.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 1 - .../caps_5.2.0.riscv64.xml | 1 - .../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 1 - .../caps_5.2.0.x86_64.xml | 2 -- .../caps_6.0.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_6.0.0.s390x.xml | 1 - .../caps_6.0.0.x86_64.xml | 2 -- .../caps_6.1.0.x86_64.xml | 2 -- .../caps_6.2.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 1 - .../caps_6.2.0.x86_64.xml | 2 -- .../caps_7.0.0.x86_64.xml | 2 -- .../aarch64-video-default.args | 2 +- .../aarch64-video-virtio-gpu-pci.args | 2 +- ...s-spice-agent-file-xfer.x86_64-latest.args | 4 ++-- ...phics-spice-compression.x86_64-latest.args | 4 ++-- ...hics-spice-egl-headless.x86_64-latest.args | 2 +- .../graphics-spice-qxl-vga.x86_64-latest.args | 4 ++-- .../graphics-spice-sasl.x86_64-latest.args | 2 +- .../graphics-spice.x86_64-latest.args | 4 ++-- ...tdev-mdev-display-ramfb.x86_64-latest.args | 2 +- ...play-spice-egl-headless.x86_64-latest.args | 2 +- ...ev-display-spice-opengl.x86_64-latest.args | 2 +- ...isplay-vnc-egl-headless.x86_64-latest.args | 2 +- ...ostdev-mdev-display-vnc.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/pcie-root-port.args | 2 +- .../pcie-switch-downstream-port.args | 2 +- .../pcie-switch-upstream-port.args | 2 +- tests/qemuxml2argvdata/pcihole64-q35.args | 2 +- tests/qemuxml2argvdata/q35-pcie-autoadd.args | 2 +- tests/qemuxml2argvdata/q35-pcie.args | 2 +- tests/qemuxml2argvdata/q35-usb2-multi.args | 2 +- tests/qemuxml2argvdata/q35-usb2-reorder.args | 2 +- tests/qemuxml2argvdata/q35-usb2.args | 2 +- .../q35-virt-manager-basic.args | 2 +- tests/qemuxml2argvdata/q35-virtio-pci.args | 2 +- tests/qemuxml2argvdata/q35.args | 2 +- tests/qemuxml2argvdata/serial-spiceport.args | 2 +- .../serial-spiceport.x86_64-latest.args | 2 +- .../video-device-pciaddr-default.args | 6 ++--- .../video-qxl-device-vgamem.args | 2 +- ...video-qxl-device-vram64.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/video-qxl-device.args | 2 +- tests/qemuxml2argvdata/video-qxl-heads.args | 6 ++--- tests/qemuxml2argvdata/video-qxl-noheads.args | 2 +- .../video-qxl-resolution.args | 2 +- .../video-qxl-sec-device-vgamem.args | 4 ++-- ...o-qxl-sec-device-vram64.x86_64-latest.args | 4 ++-- .../video-qxl-sec-device.args | 4 ++-- .../qemuxml2argvdata/video-vga-qxl-heads.args | 6 ++--- .../video-virtio-gpu-device.args | 2 +- .../video-virtio-gpu-sdl-gl.args | 2 +- .../video-virtio-gpu-secondary.args | 4 ++-- .../video-virtio-gpu-spice-gl.args | 2 +- .../video-virtio-gpu-virgl.args | 2 +- .../x86_64-pc-graphics.x86_64-latest.args | 2 +- .../x86_64-q35-graphics.x86_64-latest.args | 2 +- tests/qemuxml2argvtest.c | 16 ++++--------- tests/qemuxml2xmltest.c | 2 -- 93 files changed, 87 insertions(+), 160 deletions(-) -- 2.34.1

2 6

[libvirt PATCH 0/2] util: misc syslog fixes
by Daniel P. Berrangé 19 Jan '22

19 Jan '22

Daniel P. Berrangé (2): util: fix syslog facility value util: set facility when opening syslog channel src/util/virlog.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) -- 2.33.1

2 3

[libvirt PATCHv2 0/3] remove transitional virtio-input-host support
by Ján Tomko 19 Jan '22

19 Jan '22

*** BLURB HERE *** Ján Tomko (3): qemu: capabilities: do not check for transitional input host qemu: remove support for transitional virtio-input-host qemu: remove support for transitional virtio-input-host src/qemu/qemu_capabilities.c | 2 -- src/qemu/qemu_command.c | 2 -- src/qemu/qemu_validate.c | 26 +++++-------------- .../virtio-non-transitional.x86_64-3.1.0.args | 4 +-- ...virtio-non-transitional.x86_64-latest.args | 4 +-- .../virtio-non-transitional.xml | 3 --- .../virtio-transitional.x86_64-3.1.0.args | 3 +-- .../virtio-transitional.x86_64-latest.args | 3 +-- .../qemuxml2argvdata/virtio-transitional.xml | 3 --- .../virtio-non-transitional.x86_64-latest.xml | 11 +------- .../virtio-transitional.x86_64-latest.xml | 6 +---- 11 files changed, 12 insertions(+), 55 deletions(-) -- 2.31.1

2 4

[libvirt PATCH 0/2] remove transitional virtio-input-host support
by Ján Tomko 19 Jan '22

19 Jan '22

Ján Tomko (2): qemu: capabilities: do not check for transitional input host qemu: remove support for transitional virtio-input-host src/qemu/qemu_capabilities.c | 2 -- src/qemu/qemu_command.c | 2 -- .../qemuxml2argvdata/virtio-non-transitional.x86_64-3.1.0.args | 2 +- .../qemuxml2argvdata/virtio-non-transitional.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/virtio-transitional.x86_64-3.1.0.args | 2 +- tests/qemuxml2argvdata/virtio-transitional.x86_64-latest.args | 2 +- 6 files changed, 4 insertions(+), 8 deletions(-) -- 2.31.1

2 4

[PATCH] remote: systemd: Remove unix sockets from filesystem when disabling a '.socket' unit
by Peter Krempa 18 Jan '22

18 Jan '22

The existence of the unix socket path is used by the remote driver to determine whether modular daemons are in use, so if the socket file stays behind and the user decided to switch from modular to monolithic daemon which was socket activated, the remote driver will insist on picking '/var/run/libvirt/virtqemud-sock', even when it's no longer in use: # systemctl start libvirtd.service # virsh list Id Name State -------------------- # systemctl stop libvirtd.service Warning: Stopping libvirtd.service, but it can still be activated by: libvirtd.socket libvirtd-ro.socket libvirtd-admin.socket # systemctl start virtqemud.socket # virsh list Id Name State -------------------- # systemctl stop virtqemud.socket # systemctl start libvirtd.service # virsh list error: failed to connect to the hypervisor error: Failed to connect socket to '/var/run/libvirt/virtqemud-sock': Connection refused # virsh -c 'qemu:///system?socket=/var/run/libvirt/libvirt-sock' list Id Name State -------------------- Fix this by instructing systemd to delete the socket file when deactivating the unit file for the socket. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/remote/libvirtd.socket.in | 1 + 1 file changed, 1 insertion(+) diff --git a/src/remote/libvirtd.socket.in b/src/remote/libvirtd.socket.in index 85b4aa800a..0f349656f5 100644 --- a/src/remote/libvirtd.socket.in +++ b/src/remote/libvirtd.socket.in @@ -9,6 +9,7 @@ Before=@service@.service ListenStream=@runstatedir@/libvirt/@sockprefix@-sock Service=@service@.service SocketMode=@mode@ +RemoveOnStop=yes [Install] WantedBy=sockets.target -- 2.34.1

5 7

[PATCH v5 00/13] virdnsmasq: Lookup DNSMASQ in PATH
by Michal Privoznik 18 Jan '22

18 Jan '22

v5 of: https://listman.redhat.com/archives/libvir-list/2022-January/msg00715.html diff to v4: - Switched to virCommandSetDryRun() in commit 10/13, because using a separate script was conflicting with ASAN. Tried to debug, failed miserably. - Extended error message from patch 11/13 to include virGetLastErrorMessage() (because if a test fails one simply doesn't access libvirt log in the CI). Michal Prívozník (13): virdnsmasq: Drop @binaryPath argument from dnsmasqCapsNewEmpty() lib: Prefer g_autoptr(dnsmasqCaps) instead of explicit unref virdnsmasq: Drop @force argument of dnsmasqCapsRefreshInternal() virdnsmasq: Drop mtime member from struct _dnsmasqCaps virdnsmasq: Drop noRefresh member from from struct _dnsmasqCaps virdnsmasq: Drop !caps check from dnsmasqCapsRefreshInternal() virdnsmasq: Don't run 'dnsmasq --help' virdnsmasq: Lookup DNSMASQ in PATH virdnsmasq: Require non NULL @caps in dnsmasqCapsGetBinaryPath() networkxml2conftest: Use dnsmasqCapsNewFromBinary() to construct caps networkxml2conftest: Check if capabilities were created successfully virdnsmasq: Drop dnsmasqCapsNewFromBuffer() virdnsmasq: Join dnsmasqCapsNewEmpty() and dnsmasqCapsNewFromBinary() meson.build | 1 - src/libvirt_private.syms | 1 - src/util/virdnsmasq.c | 84 ++++++------------------------------- src/util/virdnsmasq.h | 1 - tests/meson.build | 1 + tests/networkxml2conftest.c | 47 ++++++++++++++++++--- tests/virdnsmasqmock.c | 19 +++++++++ 7 files changed, 75 insertions(+), 79 deletions(-) create mode 100644 tests/virdnsmasqmock.c -- 2.34.1

2 14

[PATCH] virDomainDeviceInfoParseXML: Reject '0' value for ACPI index
by Peter Krempa 18 Jan '22

18 Jan '22

Value of '0' is treated equivalently to when it's not provided by the user. Reject an explicit '0' provided by the user as it would get ignored. In this rare case we can make the XML parser more strict, as libvirt would never format the '<acpi/>' element if the index is '0' thus there are no libvirt-generated XMLs we'd not load back, as of such this is identical to rejecting it in the validation phase. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2037146 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index a805f7f6a3..393f9d9478 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -6786,7 +6786,7 @@ virDomainDeviceInfoParseXML(virDomainXMLOption *xmlopt, } if ((acpi = virXPathNode("./acpi", ctxt))) { - if (virXMLPropUInt(acpi, "index", 10, VIR_XML_PROP_NONE, + if (virXMLPropUInt(acpi, "index", 10, VIR_XML_PROP_NONZERO, &info->acpiIndex) < 0) goto cleanup; } -- 2.34.1

2 1

[PATCH v4 00/13] virdnsmasq: Lookup DNSMASQ in PATH
by Michal Privoznik 18 Jan '22

18 Jan '22

v4 of: https://listman.redhat.com/archives/libvir-list/2022-January/msg00498.html diff to v3: - Removed even more code - Switched from virCommandDryRun to a python script, per Andrea's request - Reordered patches so that the mock doesn't need to redirect stat() - Renamed mock - Removed exec() of 'dnsmasq --help' Michal Prívozník (13): virdnsmasq: Drop @binaryPath argument from dnsmasqCapsNewEmpty() lib: Prefer g_autoptr(dnsmasqCaps) instead of explicit unref virdnsmasq: Drop @force argument of dnsmasqCapsRefreshInternal() virdnsmasq: Drop mtime member from struct _dnsmasqCaps virdnsmasq: Drop noRefresh member from from struct _dnsmasqCaps virdnsmasq: Drop !caps check from dnsmasqCapsRefreshInternal() virdnsmasq: Don't run 'dnsmasq --help' virdnsmasq: Lookup DNSMASQ in PATH virdnsmasq: Require non NULL @caps in dnsmasqCapsGetBinaryPath() networkxml2conftest: Use dnsmasqCapsNewFromBinary() to construct caps networkxml2conftest: Check if capabilities were created successfully virdnsmasq: Drop dnsmasqCapsNewFromBuffer() virdnsmasq: Join dnsmasqCapsNewEmpty() and dnsmasqCapsNewFromBinary() meson.build | 1 - src/libvirt_private.syms | 1 - src/util/virdnsmasq.c | 84 ++++++------------------------------- src/util/virdnsmasq.h | 1 - tests/dnsmasqmock.py | 13 ++++++ tests/meson.build | 1 + tests/networkxml2conftest.c | 13 +++--- tests/virdnsmasqmock.c | 19 +++++++++ 8 files changed, 54 insertions(+), 79 deletions(-) create mode 100755 tests/dnsmasqmock.py create mode 100644 tests/virdnsmasqmock.c -- 2.34.1

3 21

[libvirt PATCH] qemu: Log which API is trying to acquire a job
by Jiri Denemark 18 Jan '22

18 Jan '22

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_domainjob.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_domainjob.c b/src/qemu/qemu_domainjob.c index c8fe8ad555..1ecde5af86 100644 --- a/src/qemu/qemu_domainjob.c +++ b/src/qemu/qemu_domainjob.c @@ -827,9 +827,11 @@ qemuDomainObjBeginJobInternal(virQEMUDriver *driver, unsigned long long duration = 0; unsigned long long agentDuration = 0; unsigned long long asyncDuration = 0; + const char *currentAPI = virThreadJobGet(); - VIR_DEBUG("Starting job: job=%s agentJob=%s asyncJob=%s " + VIR_DEBUG("Starting job: API=%s job=%s agentJob=%s asyncJob=%s " "(vm=%p name=%s, current job=%s agentJob=%s async=%s)", + NULLSTR(currentAPI), qemuDomainJobTypeToString(job), qemuDomainAgentJobTypeToString(agentJob), qemuDomainAsyncJobTypeToString(asyncJob), @@ -931,13 +933,14 @@ qemuDomainObjBeginJobInternal(virQEMUDriver *driver, if (priv->job.asyncJob && priv->job.asyncStarted) asyncDuration = now - priv->job.asyncStarted; - VIR_WARN("Cannot start job (%s, %s, %s) for domain %s; " + VIR_WARN("Cannot start job (%s, %s, %s) in API %s for domain %s; " "current job is (%s, %s, %s) " "owned by (%llu %s, %llu %s, %llu %s (flags=0x%lx)) " "for (%llus, %llus, %llus)", qemuDomainJobTypeToString(job), qemuDomainAgentJobTypeToString(agentJob), qemuDomainAsyncJobTypeToString(asyncJob), + NULLSTR(currentAPI), obj->def->name, qemuDomainJobTypeToString(priv->job.active), qemuDomainAgentJobTypeToString(priv->job.agentActive), -- 2.34.1

2 1

[PATCH 0/2] qemuDomainPinIOThread: Update live definition after process pinning
by Peter Krempa 18 Jan '22

18 Jan '22

see 2/2 Peter Krempa (2): qemuDomainPinIOThread: Copy the cpu bitmap instead of re-parsing it qemuDomainPinIOThread: Update live definition after process pinning src/qemu/qemu_driver.c | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) -- 2.34.1

3 4

[libvirt PATCH 0/6] util: virnetdev: use g_auto for virCommand
by Ján Tomko 18 Jan '22

18 Jan '22

Refactor some functions to remove more manual virCommand freeing. virNetDevBandwidthSet is left untouched. Ján Tomko (6): util: midonet: use g_auto for virCommand util: virNetDevBandwidthUpdateRate: refactor util: virNetDevBandwidthManipulateFilter: use g_auto util: virNetDevBandwidthClear: use g_auto util: refactor virNetDevBandwidthPlug util: refactor virNetDevBandwidthUnplug src/util/virnetdevbandwidth.c | 128 +++++++++++++--------------------- src/util/virnetdevmidonet.c | 20 ++---- 2 files changed, 53 insertions(+), 95 deletions(-) -- 2.31.1

2 7

[libvirt PATCH 0/6] util: openvswitch: cleanup
by Ján Tomko 18 Jan '22

18 Jan '22

Rearrange some code and remove 'cmd' variable reuse to get rid of manual 'virCommandFree' in functions using g_auto. Ján Tomko (6): util: openvswitch: move InterfaceClear{Rx,Tx}Qos util: openvswitch: unexport InterfaceClear{Rx,Tx}Qos util: openvswitch: split out virNetDevOpenvswitchInterfaceSetTxQos util: openvswitch: split out virNetDevOpenvswitchInterfaceSetRxQos util: openvswitch: do not reuse cmd in InterfaceSetTxQos util: openvswitch: do not reuse cmd in InterfaceClearTxQos src/libvirt_private.syms | 2 - src/util/virnetdevopenvswitch.c | 406 +++++++++++++++++--------------- src/util/virnetdevopenvswitch.h | 7 - 3 files changed, 213 insertions(+), 202 deletions(-) -- 2.31.1

2 7

[libvirt PATCH 0/2] dnsmasq: Some small tweaks
by Andrea Bolognani 18 Jan '22

18 Jan '22

Applies on top of Michal's patches. https://listman.redhat.com/archives/libvir-list/2022-January/msg00715.html Andrea Bolognani (2): spec: Drop BuildRequires on dnsmasq util: Stop storing dnsmasq version libvirt.spec.in | 1 - src/util/virdnsmasq.c | 14 +++++++------- 2 files changed, 7 insertions(+), 8 deletions(-) -- 2.34.1

2 3