- Devel - libvirt List Archives

[PATCH 0/4] docs cleanups
by Peter Krempa 09 Mar '22

09 Mar '22

Cleanups based on review of series converting a bunch of docs to rST format. Peter Krempa (4): docs: securityprocess: Don't claim that we have maint branches docs: formatsnapshot: Move paragraphs describing 'disk' element together docs: formatsnapshot: Remove explicit listing of supported snapshot formats docs: formatsnapshot: Remove empty 'seclabel' definition docs/formatsnapshot.rst | 24 +++++++++++------------- docs/securityprocess.rst | 6 ++---- 2 files changed, 13 insertions(+), 17 deletions(-) -- 2.35.1

3 12

[libvirt PATCH v2 0/1] meson: Fixes and improvements to handling of qemu_user and qemu_group
by Andrea Bolognani 09 Mar '22

09 Mar '22

Changes from [v1]: * most patches have been pushed; * added comments. [v1] https://listman.redhat.com/archives/libvir-list/2022-January/msg01189.html Andrea Bolognani (1): meson: Check for os-release's ID_LIKE in addition to ID meson.build | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) -- 2.34.1

2 4

[libvirt PATCH 0/2] nwfilter cleanups for legacy platforms
by Daniel P. Berrangé 09 Mar '22

09 Mar '22

We have a couple of compatibility hacks to cope with changes in iptables userspace and kernel. These were very long ago so not relevant to our current build platforms. Removing them makes the code clearer. The tests have churn because we were never properly testing this aspect in the past Daniel P. Berrangé (2): nwfilter: drop support for legacy iptables match syntax nwfilter: drop support for legacy iptables conntrack direction src/nwfilter/nwfilter_ebiptables_driver.c | 128 +- .../ah-ipv6-linux.args | 54 +- tests/nwfilterxml2firewalldata/ah-linux.args | 54 +- .../all-ipv6-linux.args | 54 +- tests/nwfilterxml2firewalldata/all-linux.args | 54 +- .../comment-linux.args | 90 +- .../conntrack-linux.args | 18 +- .../esp-ipv6-linux.args | 54 +- tests/nwfilterxml2firewalldata/esp-linux.args | 54 +- .../example-1-linux.args | 54 +- .../example-2-linux.args | 28 +- .../hex-data-linux.args | 36 +- .../icmp-direction-linux.args | 12 +- .../icmp-direction2-linux.args | 12 +- .../icmp-direction3-linux.args | 18 +- .../nwfilterxml2firewalldata/icmp-linux.args | 12 +- .../icmpv6-linux.args | 16 +- .../nwfilterxml2firewalldata/igmp-linux.args | 54 +- .../nwfilterxml2firewalldata/ipset-linux.args | 72 +- .../nwfilterxml2firewalldata/iter1-linux.args | 54 +- .../nwfilterxml2firewalldata/iter2-linux.args | 1026 +++++++++++------ .../nwfilterxml2firewalldata/iter3-linux.args | 90 +- .../sctp-ipv6-linux.args | 54 +- .../nwfilterxml2firewalldata/sctp-linux.args | 54 +- .../target-linux.args | 36 +- .../target2-linux.args | 18 +- .../tcp-ipv6-linux.args | 54 +- tests/nwfilterxml2firewalldata/tcp-linux.args | 18 +- .../udp-ipv6-linux.args | 54 +- tests/nwfilterxml2firewalldata/udp-linux.args | 54 +- .../udplite-ipv6-linux.args | 54 +- .../udplite-linux.args | 54 +- 32 files changed, 1570 insertions(+), 924 deletions(-) -- 2.35.1

2 3

[libvirt PATCH v2 0/6] Add support for 'blob' to virtio video device
by Jonathon Jongsma 08 Mar '22

08 Mar '22

Add support to libvirt for the 'blob' option for virtio video devices in qemu. Also do a little preparatory refactoring of the video device xml parsing code. Changes in v2: - Added some basic documentation - add a qemu capability - Make sure that the /dev/udmabuf device is accessible to qemu (cgroups, etc) Jonathon Jongsma (6): conf: Refactor video model parsing conf: switch to virXMLProp* functions conf: use enum variable for video type conf: add support for 'blob' in virtio video device qemu: Add capability for virtio-gpu.blob qemu: Implement 'blob' support for virtio gpu docs/formatdomain.rst | 6 + docs/schemas/domaincommon.rng | 5 + src/conf/domain_conf.c | 133 +++++++++--------- src/conf/domain_conf.h | 3 +- src/conf/domain_validate.c | 13 +- src/libxl/libxl_conf.c | 10 ++ src/libxl/libxl_domain.c | 11 ++ src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_cgroup.c | 28 ++-- src/qemu/qemu_command.c | 3 + src/qemu/qemu_domain.h | 1 + src/qemu/qemu_monitor_json.c | 16 ++- src/qemu/qemu_namespace.c | 22 +++ src/qemu/qemu_process.c | 7 + src/qemu/qemu_validate.c | 9 ++ .../caps_6.1.0.x86_64.xml | 1 + .../caps_6.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 1 + .../caps_6.2.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_7.0.0.ppc64.xml | 1 + .../caps_7.0.0.x86_64.xml | 1 + .../video-virtio-blob-absent.args | 34 +++++ .../video-virtio-blob-absent.xml | 33 +++++ .../video-virtio-blob-off.args | 34 +++++ .../video-virtio-blob-off.xml | 33 +++++ .../video-virtio-blob-on.args | 34 +++++ .../qemuxml2argvdata/video-virtio-blob-on.xml | 33 +++++ .../video-virtio-vga-blob-on.args | 34 +++++ .../video-virtio-vga-blob-on.xml | 33 +++++ tests/qemuxml2argvtest.c | 12 ++ .../video-virtio-blob-absent.xml | 41 ++++++ .../video-virtio-blob-off.xml | 41 ++++++ .../video-virtio-blob-on.xml | 41 ++++++ .../video-virtio-vga-blob-on.xml | 41 ++++++ tests/qemuxml2xmltest.c | 12 ++ 36 files changed, 652 insertions(+), 84 deletions(-) create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-absent.args create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-absent.xml create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-off.args create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-off.xml create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-on.args create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-on.xml create mode 100644 tests/qemuxml2argvdata/video-virtio-vga-blob-on.args create mode 100644 tests/qemuxml2argvdata/video-virtio-vga-blob-on.xml create mode 100644 tests/qemuxml2xmloutdata/video-virtio-blob-absent.xml create mode 100644 tests/qemuxml2xmloutdata/video-virtio-blob-off.xml create mode 100644 tests/qemuxml2xmloutdata/video-virtio-blob-on.xml create mode 100644 tests/qemuxml2xmloutdata/video-virtio-vga-blob-on.xml -- 2.35.1

1 7

[PATCH 00/17] docs: Convert some pages to rST and clean up (part 1)
by Peter Krempa 08 Mar '22

08 Mar '22

Peter Krempa (17): docs: Remove 'virshcmdref' page docs: Drop 'devguide' page docs: formatsnapshot: Convert to 'rst' docs: Convert 'goals' to rST docs: Convert 'strategy' to rST docs: Convert 'contribute' page to rST docs: Convert 'bugs' page to rST docs: Convert 'errors' page to rST docs: Convert 'support' page to rST docs: Convert 'securityprocess' page to rST docs: securityprocess: Don't claim that we have maint branches docs: Convert 'governance' page to rST docs: page.xsl: Update anchor to the 'Code of conduct' paragraph docs: Convert 'drivers' page to rST docs: Convert 'formatsecret' page to rST docs: formatsecret: Drop few unneeded empty lines docs: meson: Restore alphabetical order docs/bugs.html.in | 161 ----------- docs/bugs.rst | 125 ++++++++ docs/contribute.html.in | 143 --------- docs/contribute.rst | 105 +++++++ docs/devguide.html.in | 42 --- docs/drivers.html.in | 44 --- docs/drivers.rst | 31 ++ docs/errors.html.in | 84 ------ docs/errors.rst | 109 +++++++ docs/formatsecret.html.in | 414 --------------------------- docs/formatsecret.rst | 332 +++++++++++++++++++++ docs/formatsnapshot.html.in | 352 ----------------------- docs/formatsnapshot.rst | 297 +++++++++++++++++++ docs/formatstorageencryption.html.in | 2 +- docs/goals.html.in | 64 ----- docs/goals.rst | 56 ++++ docs/governance.html.in | 298 ------------------- docs/governance.rst | 232 +++++++++++++++ docs/meson.build | 32 +-- docs/page.xsl | 2 +- docs/securityprocess.html.in | 119 -------- docs/securityprocess.rst | 91 ++++++ docs/strategy.html.in | 133 --------- docs/strategy.rst | 105 +++++++ docs/support.html.in | 258 ----------------- docs/support.rst | 207 ++++++++++++++ docs/virshcmdref.html.in | 75 ----- 27 files changed, 1707 insertions(+), 2206 deletions(-) delete mode 100644 docs/bugs.html.in create mode 100644 docs/bugs.rst delete mode 100644 docs/contribute.html.in create mode 100644 docs/contribute.rst delete mode 100644 docs/devguide.html.in delete mode 100644 docs/drivers.html.in create mode 100644 docs/drivers.rst delete mode 100644 docs/errors.html.in create mode 100644 docs/errors.rst delete mode 100644 docs/formatsecret.html.in create mode 100644 docs/formatsecret.rst delete mode 100644 docs/formatsnapshot.html.in create mode 100644 docs/formatsnapshot.rst delete mode 100644 docs/goals.html.in create mode 100644 docs/goals.rst delete mode 100644 docs/governance.html.in create mode 100644 docs/governance.rst delete mode 100644 docs/securityprocess.html.in create mode 100644 docs/securityprocess.rst delete mode 100644 docs/strategy.html.in create mode 100644 docs/strategy.rst delete mode 100644 docs/support.html.in create mode 100644 docs/support.rst delete mode 100644 docs/virshcmdref.html.in -- 2.35.1

2 35

[PATCH 0/2] libvirt-qemu: Two simple fixes
by Michal Privoznik 08 Mar '22

08 Mar '22

*** BLURB HERE *** Michal Prívozník (2): libvirt-qemu: Don't allow NULL cmd in virDomainQemuMonitorCommandWithFiles() libvirt-qemu: Fix capitalization of QEMU src/libvirt-qemu.c | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) -- 2.34.1

2 3

[libvirt PATCH] spec: Move virkey* manual pages from -daemon to -client
by Andrea Bolognani 08 Mar '22

08 Mar '22

The documentation included in these manual pages is mostly useful to users of the 'send-key' virsh command, and the virsh manual page refers to them, so it makes more sense to install them along with virsh instead of libvirtd. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 0e6cd13bb2..6855b3a760 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1733,7 +1733,6 @@ exit 0 %{_mandir}/man8/virtlogd.8* %{_mandir}/man8/virtlockd.8* %{_mandir}/man8/virtproxyd.8* -%{_mandir}/man7/virkey*.7* %{_bindir}/virt-host-validate %{_bindir}/virt-admin @@ -2010,6 +2009,7 @@ exit 0 %{_mandir}/man1/virt-xml-validate.1* %{_mandir}/man1/virt-pki-query-dn.1* %{_mandir}/man1/virt-pki-validate.1* +%{_mandir}/man7/virkey*.7* %{_bindir}/virsh %{_bindir}/virt-xml-validate %{_bindir}/virt-pki-query-dn -- 2.34.1

2 2

[PATCH] qemu: domainjob: Allow free if cb is not set in qemuDomainObjClearJob
by Kristina Hanicova 08 Mar '22

08 Mar '22

We should allow resetting and freeing qemuDomainJobObj even if 'cb' attribute is not set. This is theoretical for now, but the attribute must not be always set in the future, so early return would create memory leaks. It is sufficient to check if 'cb' exists before dereferencing it in qemuDomainObjClearJob() and also qemuDomainObjResetAsyncJob() as the latter is called from the former. This commit partially reverts af16e754cd4efc3ca1. Signed-off-by: Kristina Hanicova <khanicov(a)redhat.com> --- src/qemu/qemu_domainjob.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_domainjob.c b/src/qemu/qemu_domainjob.c index 3e73eba4ed..587c166d94 100644 --- a/src/qemu/qemu_domainjob.c +++ b/src/qemu/qemu_domainjob.c @@ -239,8 +239,10 @@ qemuDomainObjResetAsyncJob(qemuDomainJobObj *job) job->abortJob = false; VIR_FREE(job->error); g_clear_pointer(&job->current, virDomainJobDataFree); - job->cb->resetJobPrivate(job->privateData); job->apiFlags = 0; + + if (job->cb) + job->cb->resetJobPrivate(job->privateData); } int @@ -270,16 +272,15 @@ qemuDomainObjRestoreJob(virDomainObj *obj, void qemuDomainObjClearJob(qemuDomainJobObj *job) { - if (!job->cb) - return; - qemuDomainObjResetJob(job); qemuDomainObjResetAsyncJob(job); - g_clear_pointer(&job->privateData, job->cb->freeJobPrivate); g_clear_pointer(&job->current, virDomainJobDataFree); g_clear_pointer(&job->completed, virDomainJobDataFree); virCondDestroy(&job->cond); virCondDestroy(&job->asyncCond); + + if (job->cb) + g_clear_pointer(&job->privateData, job->cb->freeJobPrivate); } bool -- 2.35.1

2 1

[PULL v4 21/47] hw/i386/pc_piix: Mark the machine types from version 1.4 to 1.7 as deprecated
by Michael S. Tsirkin 07 Mar '22

07 Mar '22

From: Thomas Huth <thuth(a)redhat.com> The list of machine types grows larger and larger each release ... and it is unlikely that many people still use the very old ones for live migration. QEMU v1.7 has been released more than 8 years ago, so most people should have updated their machines to a newer version in those 8 years at least once. Thus let's mark the very old 1.x machine types as deprecated now. Signed-off-by: Thomas Huth <thuth(a)redhat.com> Message-Id: <20220117191639.278497-1-thuth(a)redhat.com> Reviewed-by: Michael S. Tsirkin <mst(a)redhat.com> Signed-off-by: Michael S. Tsirkin <mst(a)redhat.com> --- hw/i386/pc_piix.c | 1 + docs/about/deprecated.rst | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 8d33cf689d..b72c03d0a6 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -757,6 +757,7 @@ static void pc_i440fx_1_7_machine_options(MachineClass *m) m->hw_version = "1.7.0"; m->default_machine_opts = NULL; m->option_rom_has_mr = true; + m->deprecation_reason = "old and unattended - use a newer version instead"; compat_props_add(m->compat_props, pc_compat_1_7, pc_compat_1_7_len); pcmc->smbios_defaults = false; pcmc->gigabyte_align = false; diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 85773db631..cf02ef6821 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -324,6 +324,14 @@ machine is hardly emulated at all (e.g. neither the LCD nor the USB part had been implemented), so there is not much value added by this board. Use the ``ref405ep`` machine instead. +``pc-i440fx-1.4`` up to ``pc-i440fx-1.7`` (since 7.0) +''''''''''''''''''''''''''''''''''''''''''''''''''''' + +These old machine types are quite neglected nowadays and thus might have +various pitfalls with regards to live migration. Use a newer machine type +instead. + + Backend options --------------- -- MST

1 0

[libvirt PATCH] Drop YouCompleteMe and color_coded integration
by Andrea Bolognani 07 Mar '22

07 Mar '22

I introduced support for these vim plugins several years ago but have since moved away from them. These days developers are likely better served by lsp-based tooling, which doesn't require additional per-project configuration. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- .color_coded.in | 38 --------------------------------- .ycm_extra_conf.py.in | 43 -------------------------------------- build-aux/syntax-check.mk | 1 - docs/developer-tooling.rst | 13 ------------ docs/hacking.rst | 1 - docs/meson.build | 1 - meson.build | 19 ----------------- 7 files changed, 116 deletions(-) delete mode 100644 .color_coded.in delete mode 100644 .ycm_extra_conf.py.in delete mode 100644 docs/developer-tooling.rst diff --git a/.color_coded.in b/.color_coded.in deleted file mode 100644 index f39c6860ab..0000000000 --- a/.color_coded.in +++ /dev/null @@ -1,38 +0,0 @@ --I@abs_top_builddir@ --I@abs_top_srcdir@ --I@abs_top_builddir@/include --I@abs_top_srcdir@/include --I@abs_top_builddir@/src --I@abs_top_srcdir@/src --I@abs_top_builddir@/src/access --I@abs_top_srcdir@/src/access --I@abs_top_builddir@/src/admin --I@abs_top_srcdir@/src/admin --I@abs_top_builddir@/src/bhyve --I@abs_top_srcdir@/src/bhyve --I@abs_top_builddir@/src/conf --I@abs_top_srcdir@/src/conf --I@abs_top_builddir@/src/libxl --I@abs_top_srcdir@/src/libxl --I@abs_top_builddir@/src/locking --I@abs_top_srcdir@/src/locking --I@abs_top_builddir@/src/logging --I@abs_top_srcdir@/src/logging --I@abs_top_builddir@/src/lxc --I@abs_top_srcdir@/src/lxc --I@abs_top_builddir@/src/qemu --I@abs_top_srcdir@/src/qemu --I@abs_top_builddir@/src/remote --I@abs_top_srcdir@/src/remote --I@abs_top_builddir@/src/rpc --I@abs_top_srcdir@/src/rpc --I@abs_top_builddir@/src/secret --I@abs_top_srcdir@/src/secret --I@abs_top_builddir@/src/security --I@abs_top_srcdir@/src/security --I@abs_top_builddir@/src/util --I@abs_top_srcdir@/src/util --I@abs_top_builddir@/src/vmx --I@abs_top_srcdir@/src/vmx --I@abs_top_builddir@/src/xenconfig --I@abs_top_srcdir@/src/xenconfig diff --git a/.ycm_extra_conf.py.in b/.ycm_extra_conf.py.in deleted file mode 100644 index 2e24334079..0000000000 --- a/.ycm_extra_conf.py.in +++ /dev/null @@ -1,43 +0,0 @@ -flags = [ - '-I@abs_top_builddir@', - '-I@abs_top_srcdir@', - '-I@abs_top_builddir@/include', - '-I@abs_top_srcdir@/include', - '-I@abs_top_builddir@/src', - '-I@abs_top_srcdir@/src', - '-I@abs_top_builddir@/src/access', - '-I@abs_top_srcdir@/src/access', - '-I@abs_top_builddir@/src/admin', - '-I@abs_top_srcdir@/src/admin', - '-I@abs_top_builddir@/src/bhyve', - '-I@abs_top_srcdir@/src/bhyve', - '-I@abs_top_builddir@/src/conf', - '-I@abs_top_srcdir@/src/conf', - '-I@abs_top_builddir@/src/libxl', - '-I@abs_top_srcdir@/src/libxl', - '-I@abs_top_builddir@/src/locking', - '-I@abs_top_srcdir@/src/locking', - '-I@abs_top_builddir@/src/logging', - '-I@abs_top_srcdir@/src/logging', - '-I@abs_top_builddir@/src/lxc', - '-I@abs_top_srcdir@/src/lxc', - '-I@abs_top_builddir@/src/qemu', - '-I@abs_top_srcdir@/src/qemu', - '-I@abs_top_builddir@/src/remote', - '-I@abs_top_srcdir@/src/remote', - '-I@abs_top_builddir@/src/rpc', - '-I@abs_top_srcdir@/src/rpc', - '-I@abs_top_builddir@/src/secret', - '-I@abs_top_srcdir@/src/secret', - '-I@abs_top_builddir@/src/security', - '-I@abs_top_srcdir@/src/security', - '-I@abs_top_builddir@/src/util', - '-I@abs_top_srcdir@/src/util', - '-I@abs_top_builddir@/src/vmx', - '-I@abs_top_srcdir@/src/vmx', - '-I@abs_top_builddir@/src/xenconfig', - '-I@abs_top_srcdir@/src/xenconfig', -] - -def FlagsForFile(filename, **kwargs): - return { 'flags': flags, 'do_cache': True } diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index a8c9153b20..fac1338589 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -921,7 +921,6 @@ http_sites += www.javvin.com # 404 links http_sites += publib.boulder.ibm.com http_sites += kerneltrap.org -http_sites += valloric.github.io http_sites += www.microsoft.com http_sites += xenbits.xen.org http_sites += lovezutto.googlepages.com diff --git a/docs/developer-tooling.rst b/docs/developer-tooling.rst deleted file mode 100644 index c8980e3e4f..0000000000 --- a/docs/developer-tooling.rst +++ /dev/null @@ -1,13 +0,0 @@ -================= -Developer tooling -================= - -libvirt includes support for some useful development tools right -in its source repository, meaning users will be able to take -advantage of them without little or no configuration. Examples -include: - -- `color_coded <https://github.com/jeaye/color_coded>`__, a vim - plugin for libclang-powered semantic syntax highlighting; -- `YouCompleteMe <http://valloric.github.io/YouCompleteMe/>`__, a - vim plugin for libclang-powered semantic code completion. diff --git a/docs/hacking.rst b/docs/hacking.rst index cd009c4c73..1be9daab80 100644 --- a/docs/hacking.rst +++ b/docs/hacking.rst @@ -72,7 +72,6 @@ This page only covers the very basics, so it's recommended that you also take a look at the following documents: - `Programming languages <programming-languages.html>`__ -- `Developer tooling <developer-tooling.html>`__ - `Advanced test suite usage <advanced-tests.html>`__ - `Adoption of GLib APIs <glib-adoption.html>`__ - `Committer guidelines <committer-guidelines.html>`__ diff --git a/docs/meson.build b/docs/meson.build index 7e070d68ad..690715a12e 100644 --- a/docs/meson.build +++ b/docs/meson.build @@ -95,7 +95,6 @@ docs_rst_files = [ 'committer-guidelines', 'compiling', 'daemons', - 'developer-tooling', 'drvqemu', 'drvch', 'formatbackup', diff --git a/meson.build b/meson.build index 519a928c9a..987d8a393f 100644 --- a/meson.build +++ b/meson.build @@ -2215,25 +2215,6 @@ configure_file( run_command('chmod', 'a+x', meson.current_build_dir() / 'run', check: true) -# generate developer tooling files -tooling_files = [ - '.color_coded.in', - '.ycm_extra_conf.py.in', -] - -tooling_conf = configuration_data() -tooling_conf.set('abs_top_builddir', meson.build_root()) -tooling_conf.set('abs_top_srcdir', meson.source_root()) - -foreach file : tooling_files - configure_file( - input: file, - output: '@BASENAME@', - configuration: tooling_conf, - ) -endforeach - - # print configuration summary driver_summary = { -- 2.35.1

2 1

[libvirt PATCH 0/5] Miscelaneous libc-related fixes
by Martin Kletzander 07 Mar '22

07 Mar '22

Compiling libvirt on alpine showed a bunch of things that are potentially wrong, we just haven't noticed elsewhere. Martin Kletzander (5): syntax-check: Rework mock-noinline to get all files at once Include poll.h instead of sys/poll.h Include sys/wait.h instead of wait.h nwfilter: Avoid memory alignment issues tests: Allow expansion of mocked stat symbols build-aux/syntax-check.mk | 2 +- scripts/mock-noinline.py | 2 +- src/lxc/lxc_driver.c | 4 ++-- src/network/bridge_driver.c | 2 +- src/nwfilter/nwfilter_learnipaddr.c | 15 ++++++++------- src/openvz/openvz_driver.c | 2 +- src/qemu/qemu_driver.c | 2 +- src/security/security_apparmor.c | 2 +- src/vz/vz_driver.c | 2 +- tests/virmock.h | 4 +++- 10 files changed, 20 insertions(+), 17 deletions(-) -- 2.35.1

4 11

[libvirt PATCH] wireshark: Fix dissector for quad types
by Martin Kletzander 07 Mar '22

07 Mar '22

This uses the right type that is expected to make it work even on platforms where gint64 != quad_t. Due to indentation changes it is best to view this patch with -w. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- tools/wireshark/src/packet-libvirt.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/tools/wireshark/src/packet-libvirt.c b/tools/wireshark/src/packet-libvirt.c index eeacbcdf0e14..ee20e3734d74 100644 --- a/tools/wireshark/src/packet-libvirt.c +++ b/tools/wireshark/src/packet-libvirt.c @@ -74,17 +74,17 @@ static gint ett_libvirt_stream_hole = -1; VIR_WARNINGS_NO_UNUSED_FUNCTION -XDR_PRIMITIVE_DISSECTOR(int, gint32, int) -XDR_PRIMITIVE_DISSECTOR(u_int, guint32, uint) -XDR_PRIMITIVE_DISSECTOR(short, gint16, int) -XDR_PRIMITIVE_DISSECTOR(u_short, guint16, uint) -XDR_PRIMITIVE_DISSECTOR(char, gchar, int) -XDR_PRIMITIVE_DISSECTOR(u_char, guchar, uint) -XDR_PRIMITIVE_DISSECTOR(hyper, gint64, int64) -XDR_PRIMITIVE_DISSECTOR(u_hyper, guint64, uint64) -XDR_PRIMITIVE_DISSECTOR(float, gfloat, float) -XDR_PRIMITIVE_DISSECTOR(double, gdouble, double) -XDR_PRIMITIVE_DISSECTOR(bool, bool_t, boolean) +XDR_PRIMITIVE_DISSECTOR(int, gint32, int) +XDR_PRIMITIVE_DISSECTOR(u_int, guint32, uint) +XDR_PRIMITIVE_DISSECTOR(short, gint16, int) +XDR_PRIMITIVE_DISSECTOR(u_short, guint16, uint) +XDR_PRIMITIVE_DISSECTOR(char, gchar, int) +XDR_PRIMITIVE_DISSECTOR(u_char, guchar, uint) +XDR_PRIMITIVE_DISSECTOR(hyper, quad_t, int64) +XDR_PRIMITIVE_DISSECTOR(u_hyper, u_quad_t, uint64) +XDR_PRIMITIVE_DISSECTOR(float, gfloat, float) +XDR_PRIMITIVE_DISSECTOR(double, gdouble, double) +XDR_PRIMITIVE_DISSECTOR(bool, bool_t, boolean) VIR_WARNINGS_RESET -- 2.35.1

2 1

[PATCH 00/17] lxc_fuse: Implement support for FUSE3
by Michal Privoznik 07 Mar '22

07 Mar '22

Unfortunately, we can't just replace FUSE with FUSE3 because Ubuntu1804 doesn't have fuse3 package, but in a few weeks time, when the support for old Ubuntu is dropped, we can drop old FUSE support too. Michal Prívozník (17): lxc_fuse: Hide struct virLXCFuse lxc_fuse: Move virLXCMeminfo struct into lxc_cgroup.h lxc_fuse.h: Don't include lxc_conf.h lxc_fuse: Move #include <fuse.h> lxc_fuse: Drop some G_GNUC_UNUSED attributes lxc_fuse.c: Modernize function declarations lxc_fuse: Prefer O_ACCMODE instead of & 3 lxcSetupFuse: Cleanup error paths lxcProcReadMeminfo: Rename @fd to @fp lxc_fuse: Use automatic file closing lxcProcReadMeminfo: Drop needless label lxcProcReadMeminfo: Drop @new_meminfo variable lxcProcReadMeminfo: Fix case when @offset != 0 lxc_fuse: Prefer fuse_file_info::direct_io over mount option lxc_fuse: Tell FUSE that /proc/meminfo is nonseekable lxc_fuse: Implement support for FUSE3 meson: Detect newer fuse meson.build | 12 +- src/lxc/lxc_cgroup.h | 13 +++ src/lxc/lxc_fuse.c | 258 ++++++++++++++++++++++++++++++------------- src/lxc/lxc_fuse.h | 28 +---- 4 files changed, 207 insertions(+), 104 deletions(-) -- 2.34.1

2 18

[libvirt PATCH] Add .gitattributes file
by Andrea Bolognani 07 Mar '22

07 Mar '22

The files marked as export-ignore here are not going to be included in the tarball produced by 'meson dist' when using meson >= 0.60. Older versions of meson excluded a small subset of these files automatically, but since we have more control now we can be more aggressive and leave out anything that doesn't make sense in a release tarball. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- .gitattributes | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 .gitattributes diff --git a/.gitattributes b/.gitattributes new file mode 100644 index 0000000000..6f0a34d2a0 --- /dev/null +++ b/.gitattributes @@ -0,0 +1,22 @@ +# Generic git stuff +**/.gitattributes export-ignore +**/.gitignore export-ignore +/.gitmodules export-ignore +/.mailmap export-ignore + +# Project-specific git stuff +/.gitpublish export-ignore +/docs/gitdm export-ignore +/docs/gitdm/** export-ignore +/gitdm.config export-ignore + +# Code hosting stuff +/.github export-ignore +/.github/** export-ignore +/.gitlab export-ignore +/.gitlab/** export-ignore + +# CI stuff +/.gitlab-ci.yml export-ignore +/ci export-ignore +/ci/** export-ignore -- 2.35.1

4 4

[libvirt PATCH] docs: remove extra closing tag
by Ján Tomko 07 Mar '22

07 Mar '22

Reported-by: Юлій В. Чирков <juliyvchirkov(a)gmail.com> Closes: https://gitlab.com/libvirt/libvirt/-/merge_requests/143 Fixes: d3ac12e3a1c01d1205b4db3f6cd640f3da98579b Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Pushed as trivial. docs/formatnetwork.html.in | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/formatnetwork.html.in b/docs/formatnetwork.html.in index fad43f77ea..56ff32fbf4 100644 --- a/docs/formatnetwork.html.in +++ b/docs/formatnetwork.html.in @@ -1250,7 +1250,6 @@ </dhcp> </ip> <ip family="ipv6" address="fdXX:XXXX:XXXX:NNNN:: prefix="64"/> - </ip> </network></pre> <p>IPv6 NAT addressing has some caveats over the more straight -- 2.35.1

1 0

[PULL v2 21/47] hw/i386/pc_piix: Mark the machine types from version 1.4 to 1.7 as deprecated
by Michael S. Tsirkin 07 Mar '22

07 Mar '22

From: Thomas Huth <thuth(a)redhat.com> The list of machine types grows larger and larger each release ... and it is unlikely that many people still use the very old ones for live migration. QEMU v1.7 has been released more than 8 years ago, so most people should have updated their machines to a newer version in those 8 years at least once. Thus let's mark the very old 1.x machine types as deprecated now. Signed-off-by: Thomas Huth <thuth(a)redhat.com> Message-Id: <20220117191639.278497-1-thuth(a)redhat.com> Reviewed-by: Michael S. Tsirkin <mst(a)redhat.com> Signed-off-by: Michael S. Tsirkin <mst(a)redhat.com> --- hw/i386/pc_piix.c | 1 + docs/about/deprecated.rst | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 8d33cf689d..b72c03d0a6 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -757,6 +757,7 @@ static void pc_i440fx_1_7_machine_options(MachineClass *m) m->hw_version = "1.7.0"; m->default_machine_opts = NULL; m->option_rom_has_mr = true; + m->deprecation_reason = "old and unattended - use a newer version instead"; compat_props_add(m->compat_props, pc_compat_1_7, pc_compat_1_7_len); pcmc->smbios_defaults = false; pcmc->gigabyte_align = false; diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 85773db631..cf02ef6821 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -324,6 +324,14 @@ machine is hardly emulated at all (e.g. neither the LCD nor the USB part had been implemented), so there is not much value added by this board. Use the ``ref405ep`` machine instead. +``pc-i440fx-1.4`` up to ``pc-i440fx-1.7`` (since 7.0) +''''''''''''''''''''''''''''''''''''''''''''''''''''' + +These old machine types are quite neglected nowadays and thus might have +various pitfalls with regards to live migration. Use a newer machine type +instead. + + Backend options --------------- -- MST

1 0

Release of libvirt-8.1.0
by Jiri Denemark 07 Mar '22

07 Mar '22

The 8.1.0 release of both libvirt and libvirt-python is tagged and signed tarballs and source RPMs are available at https://libvirt.org/sources/ https://libvirt.org/sources/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is greatly appreciated. * New features * qemu: Add hvf domain type for Hypervisor.framework It works on Intel machines as well as recent machines powered by Apple Silicon. QEMU 6.2.0 is needed for Apple Silicon support. * qemu: Support mode option for dirtyrate calculation Introduce ``virDomainDirtyRateCalcFlags`` as parameter of ``virDomainStartDirtyRateCalc``, which is used to specify the mode of dirty page rate calculation. Add ``--mode`` option to ``virsh domdirtyrate-calc``, which can be either of the following 3 options: ``page-sampling, dirty-bitmap, dirty-ring``. Add ``calc_mode`` field for dirtyrate statistics returned by ``virsh domstats --dirtyrate``, also add ``vCPU dirtyrate`` if ``dirty-ring`` mode was used in last measurement. * Improvements * packaging: sysconfig files no longer installed libvirt used to provide defaults in various /etc/sysconfig/ files, such as /etc/sysconfig/libvirtd. Since these files are owned by the admin, this made it difficult to change built-in defaults in case such file was modified by the admin. The built-in defaults are now part of the provided systemd unit files, such as libvirtd.service. These unit files continue to parse sysconfig files, in case they are created by the admin and filled with the desired key=value pairs. * virnetdev: Ignore EPERM on implicit clearing of VF VLAN ID Libvirt will now ignore EPERM errors on attempts to implicitly clear a VLAN ID (when a VLAN is not explicitly provided via an interface XML using a 0 or a non-zero value) as SmartNIC DPUs do not expose VLAN programming capabilities to the hypervisor host. This allows Libvirt clients to avoid specifying a VLAN and expect VF configuration to work since Libvirt tries to clear a VLAN in the same operation as setting a MAC address for VIR_DOMAIN_NET_TYPE_HOSTDEV devices which is now split into two distinct operations. EPERM errors received while trying to program a non-zero VLAN ID or explicitly program a VLAN ID 0 will still cause errors as before so there is no change in behavior in those cases. * Bug fixes * Remove unix sockets from filesystem when disabling a '.socket' systemd unit The presence of the socket files is used by our remote driver to determine which service to access. Since neiter systemd nor the daemons clean up the socket file clients were running into problems when a modular deployment was switched to monolithic ``libvirtd``. * qemu: Fixes of fd passing during hotplug and hotunplug of chardevs FDs used as chardev backing are now properly removed when hot-unplugging a chardev from qemu and hotplugged chardevs now properly use ``virtlogd`` to handle the input and output from qemu. * RPM: Run pre/post-install steps on ``daemon-driver-storage-core`` Previously the pre/post-install code was part of the meta-package which installed all storage driver sub-packages thus a minimalistic install of the storage driver didn't behave correctly. Enjoy. Jirka

2 2

[PATCH v2 0/8] softmmu: move and refactor -runas, -chroot and -daemonize
by Daniel P. Berrangé 04 Mar '22

04 Mar '22

This small series was motivated by my thoughts on the proposals in https://lists.gnu.org/archive/html/qemu-devel/2022-03/msg01135.html It demonstrates the approach I mention there, and has the further benefit of untangling and isolating the implementation of UID changing, chrooting and daemonizing, from the parsing of the corresponding command line options. Changed in v2: - Fix mistake that left stderr open when daemonizing - Remove use of is_daemonized from chardev - Remove use of is_daemonized from logging - Eliminate is_daemonized function Daniel P. Berrangé (8): softmmu: remove deprecated --enable-fips option os-posix: refactor code handling the -runas argument os-posix: refactor code handling the -chroot argument util: remove use of is_daemonized flag from logging code softmmu: refactor use of is_daemonized() method chardev: add API to block use of the stdio implementation softmmu: move parsing of -runas, -chroot and -daemonize code softmmu: remove is_daemonized() method chardev/char-stdio.c | 12 +- docs/about/deprecated.rst | 12 -- docs/about/removed-features.rst | 11 ++ include/chardev/char-stdio.h | 29 ++++ include/qemu/log.h | 1 + include/qemu/osdep.h | 3 - include/sysemu/os-posix.h | 6 +- include/sysemu/os-win32.h | 6 - os-posix.c | 227 ++++++++++---------------------- os-win32.c | 9 -- qemu-options.hx | 10 -- softmmu/vl.c | 92 +++++++++++-- stubs/is-daemonized.c | 9 -- stubs/meson.build | 1 - ui/vnc.c | 7 - util/log.c | 12 +- util/osdep.c | 28 ---- 17 files changed, 213 insertions(+), 262 deletions(-) create mode 100644 include/chardev/char-stdio.h delete mode 100644 stubs/is-daemonized.c -- 2.34.1

2 13

[PATCH 0/4] softmmu: move and refactor -runas, -chroot and -daemonize
by Daniel P. Berrangé 04 Mar '22

04 Mar '22

This small series was motivated by my thoughts on the proposals in https://lists.gnu.org/archive/html/qemu-devel/2022-03/msg01135.html It demostrates the approach I mention there, and has the further benefit of untangling and isolating the implementation of UID changing, chrooting and daemonized, from the parsing of the corresponding command line options. Daniel P. Berrangé (4): softmmu: remove deprecated --enable-fips option os-posix: refactor code handling the -runas argument os-posix: refactor code handling the -chroot argument softmmu: move parsing of -runas, -chroot and -daemonize code docs/about/deprecated.rst | 12 -- docs/about/removed-features.rst | 11 ++ include/qemu/osdep.h | 3 - include/sysemu/os-posix.h | 4 +- include/sysemu/os-win32.h | 1 - os-posix.c | 222 ++++++++++---------------------- os-win32.c | 9 -- qemu-options.hx | 10 -- softmmu/vl.c | 76 ++++++++++- ui/vnc.c | 7 - util/osdep.c | 28 ---- 11 files changed, 154 insertions(+), 229 deletions(-) -- 2.34.1

3 10

[libvirt PATCH v2] qemu: support multiqueue for vdpa net device
by Jonathon Jongsma 04 Mar '22

04 Mar '22

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2024406 Signed-off-by: Jonathon Jongsma <jjongsma(a)redhat.com> --- Changes in v2: - remove error message in virDomainNetDefParseXML(). The model is already checked in the post parse validation step. src/conf/domain_conf.c | 2 ++ src/qemu/qemu_domain.c | 3 +- .../net-vdpa-multiqueue.x86_64-latest.args | 36 +++++++++++++++++++ .../qemuxml2argvdata/net-vdpa-multiqueue.xml | 29 +++++++++++++++ tests/qemuxml2argvtest.c | 1 + .../net-vdpa-multiqueue.xml | 36 +++++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 7 files changed, 107 insertions(+), 1 deletion(-) create mode 100644 tests/qemuxml2argvdata/net-vdpa-multiqueue.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/net-vdpa-multiqueue.xml create mode 100644 tests/qemuxml2xmloutdata/net-vdpa-multiqueue.xml diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 34fec887a3..9634c9256e 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -10552,6 +10552,8 @@ virDomainNetDefParseXML(virDomainXMLOption *xmlopt, goto error; } def->data.vdpa.devicepath = g_steal_pointer(&dev); + if (!def->model) + def->model = VIR_DOMAIN_NET_MODEL_VIRTIO; break; case VIR_DOMAIN_NET_TYPE_BRIDGE: diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index acc76c1cd6..6b61fefb8f 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -4523,7 +4523,8 @@ qemuDomainValidateActualNetDef(const virDomainNetDef *net, actualType == VIR_DOMAIN_NET_TYPE_BRIDGE || actualType == VIR_DOMAIN_NET_TYPE_DIRECT || actualType == VIR_DOMAIN_NET_TYPE_ETHERNET || - actualType == VIR_DOMAIN_NET_TYPE_VHOSTUSER)) { + actualType == VIR_DOMAIN_NET_TYPE_VHOSTUSER || + actualType == VIR_DOMAIN_NET_TYPE_VDPA)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("interface %s - multiqueue is not supported for network interfaces of type %s"), macstr, virDomainNetTypeToString(actualType)); diff --git a/tests/qemuxml2argvdata/net-vdpa-multiqueue.x86_64-latest.args b/tests/qemuxml2argvdata/net-vdpa-multiqueue.x86_64-latest.args new file mode 100644 index 0000000000..26ef666036 --- /dev/null +++ b/tests/qemuxml2argvdata/net-vdpa-multiqueue.x86_64-latest.args @@ -0,0 +1,36 @@ +LC_ALL=C \ +PATH=/bin \ +HOME=/tmp/lib/domain--1-QEMUGuest1 \ +USER=test \ +LOGNAME=test \ +XDG_DATA_HOME=/tmp/lib/domain--1-QEMUGuest1/.local/share \ +XDG_CACHE_HOME=/tmp/lib/domain--1-QEMUGuest1/.cache \ +XDG_CONFIG_HOME=/tmp/lib/domain--1-QEMUGuest1/.config \ +/usr/bin/qemu-system-x86_64 \ +-name guest=QEMUGuest1,debug-threads=on \ +-S \ +-object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/tmp/lib/domain--1-QEMUGuest1/master-key.aes"}' \ +-machine pc,usb=off,dump-guest-core=off,memory-backend=pc.ram \ +-accel tcg \ +-cpu qemu64 \ +-m 214 \ +-object '{"qom-type":"memory-backend-ram","id":"pc.ram","size":224395264}' \ +-overcommit mem-lock=off \ +-smp 1,sockets=1,cores=1,threads=1 \ +-uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \ +-display none \ +-no-user-config \ +-nodefaults \ +-chardev socket,id=charmonitor,fd=1729,server=on,wait=off \ +-mon chardev=charmonitor,id=monitor,mode=control \ +-rtc base=utc \ +-no-shutdown \ +-no-acpi \ +-boot strict=on \ +-device '{"driver":"piix3-usb-uhci","id":"usb","bus":"pci.0","addr":"0x1.0x2"}' \ +-add-fd set=0,fd=1732,opaque=net0-vdpa \ +-netdev vhost-vdpa,vhostdev=/dev/fdset/0,id=hostnet0 \ +-device '{"driver":"virtio-net-pci","mq":true,"vectors":6,"netdev":"hostnet0","id":"net0","mac":"52:54:00:95:db:c0","bus":"pci.0","addr":"0x2"}' \ +-audiodev '{"id":"audio1","driver":"none"}' \ +-sandbox on,obsolete=deny,elevateprivileges=deny,spawn=deny,resourcecontrol=deny \ +-msg timestamp=on diff --git a/tests/qemuxml2argvdata/net-vdpa-multiqueue.xml b/tests/qemuxml2argvdata/net-vdpa-multiqueue.xml new file mode 100644 index 0000000000..2e38c6f976 --- /dev/null +++ b/tests/qemuxml2argvdata/net-vdpa-multiqueue.xml @@ -0,0 +1,29 @@ +<domain type='qemu'> + <name>QEMUGuest1</name> + <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> + <memory unit='KiB'>219136</memory> + <currentMemory unit='KiB'>219136</currentMemory> + <vcpu placement='static'>1</vcpu> + <os> + <type arch='x86_64' machine='pc'>hvm</type> + <boot dev='hd'/> + </os> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <emulator>/usr/bin/qemu-system-x86_64</emulator> + <controller type='usb' index='0'/> + <controller type='ide' index='0'/> + <controller type='pci' index='0' model='pci-root'/> + <interface type='vdpa'> + <mac address='52:54:00:95:db:c0'/> + <source dev='/dev/vhost-vdpa-0'/> + <driver queues='2'/> + </interface> + <input type='mouse' bus='ps2'/> + <input type='keyboard' bus='ps2'/> + <memballoon model='none'/> + </devices> +</domain> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index ce475df466..7e1167e60e 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1609,6 +1609,7 @@ mymain(void) DO_TEST_FAILURE("net-hostdev-fail", QEMU_CAPS_DEVICE_VFIO_PCI); DO_TEST_CAPS_LATEST("net-vdpa"); + DO_TEST_CAPS_LATEST("net-vdpa-multiqueue"); DO_TEST("hostdev-pci-multifunction", QEMU_CAPS_KVM, diff --git a/tests/qemuxml2xmloutdata/net-vdpa-multiqueue.xml b/tests/qemuxml2xmloutdata/net-vdpa-multiqueue.xml new file mode 100644 index 0000000000..0876d5df62 --- /dev/null +++ b/tests/qemuxml2xmloutdata/net-vdpa-multiqueue.xml @@ -0,0 +1,36 @@ +<domain type='qemu'> + <name>QEMUGuest1</name> + <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> + <memory unit='KiB'>219136</memory> + <currentMemory unit='KiB'>219136</currentMemory> + <vcpu placement='static'>1</vcpu> + <os> + <type arch='x86_64' machine='pc'>hvm</type> + <boot dev='hd'/> + </os> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <emulator>/usr/bin/qemu-system-x86_64</emulator> + <controller type='usb' index='0'> + <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x2'/> + </controller> + <controller type='ide' index='0'> + <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x1'/> + </controller> + <controller type='pci' index='0' model='pci-root'/> + <interface type='vdpa'> + <mac address='52:54:00:95:db:c0'/> + <source dev='/dev/vhost-vdpa-0'/> + <model type='virtio'/> + <driver queues='2'/> + <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/> + </interface> + <input type='mouse' bus='ps2'/> + <input type='keyboard' bus='ps2'/> + <audio id='1' type='none'/> + <memballoon model='none'/> + </devices> +</domain> diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index 052950b86f..2174965784 100644 --- a/tests/qemuxml2xmltest.c +++ b/tests/qemuxml2xmltest.c @@ -485,6 +485,7 @@ mymain(void) DO_TEST_NOCAPS("net-coalesce"); DO_TEST_NOCAPS("net-many-models"); DO_TEST("net-vdpa", QEMU_CAPS_NETDEV_VHOST_VDPA); + DO_TEST("net-vdpa-multiqueue", QEMU_CAPS_NETDEV_VHOST_VDPA); DO_TEST_NOCAPS("serial-tcp-tlsx509-chardev"); DO_TEST_NOCAPS("serial-tcp-tlsx509-chardev-notls"); -- 2.35.1

2 1

[PULL 25/45] hw/i386/pc_piix: Mark the machine types from version 1.4 to 1.7 as deprecated
by Michael S. Tsirkin 04 Mar '22

04 Mar '22

From: Thomas Huth <thuth(a)redhat.com> The list of machine types grows larger and larger each release ... and it is unlikely that many people still use the very old ones for live migration. QEMU v1.7 has been released more than 8 years ago, so most people should have updated their machines to a newer version in those 8 years at least once. Thus let's mark the very old 1.x machine types as deprecated now. Signed-off-by: Thomas Huth <thuth(a)redhat.com> Message-Id: <20220117191639.278497-1-thuth(a)redhat.com> Reviewed-by: Michael S. Tsirkin <mst(a)redhat.com> Signed-off-by: Michael S. Tsirkin <mst(a)redhat.com> --- hw/i386/pc_piix.c | 1 + docs/about/deprecated.rst | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 8d33cf689d..b72c03d0a6 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -757,6 +757,7 @@ static void pc_i440fx_1_7_machine_options(MachineClass *m) m->hw_version = "1.7.0"; m->default_machine_opts = NULL; m->option_rom_has_mr = true; + m->deprecation_reason = "old and unattended - use a newer version instead"; compat_props_add(m->compat_props, pc_compat_1_7, pc_compat_1_7_len); pcmc->smbios_defaults = false; pcmc->gigabyte_align = false; diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 85773db631..cf02ef6821 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -324,6 +324,14 @@ machine is hardly emulated at all (e.g. neither the LCD nor the USB part had been implemented), so there is not much value added by this board. Use the ``ref405ep`` machine instead. +``pc-i440fx-1.4`` up to ``pc-i440fx-1.7`` (since 7.0) +''''''''''''''''''''''''''''''''''''''''''''''''''''' + +These old machine types are quite neglected nowadays and thus might have +various pitfalls with regards to live migration. Use a newer machine type +instead. + + Backend options --------------- -- MST

1 0

[PATCH] rpc: Fix memory leak of fds
by Peng Liang 04 Mar '22

04 Mar '22

In virSystemdActivationClaimFDs, the memory of ent->fds has been stolen and stored in fds, but fds is never freed, which causes a memory leak. Fix it by declaring fds as g_autofree. Reported-by: Jie Tang <tangjie18(a)huawei.com> Signed-off-by: Peng Liang <liangpeng10(a)huawei.com> --- src/rpc/virnetserver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rpc/virnetserver.c b/src/rpc/virnetserver.c index ad581a36ddf3..d9430a2cfa76 100644 --- a/src/rpc/virnetserver.c +++ b/src/rpc/virnetserver.c @@ -655,7 +655,7 @@ virNetServerAddServiceActivation(virNetServer *srv, size_t max_queued_clients, size_t nrequests_client_max) { - int *fds; + g_autofree int *fds = NULL; size_t nfds; if (act == NULL) -- 2.35.1

2 1

[PATCH 0/4] tests: Miscellaneous fixes and improvements
by Michal Privoznik 04 Mar '22

04 Mar '22

I've been trying to compile libvirt with musl lately and seen couple of tests failing. Some of them were related strictly to how musl works, but the rest are genuine bugs we have and it's by pure chance that we haven't met them with glibc (1/4 for instance). Green pipeline can be seen here: https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/483864407 Michal Prívozník (4): vircgroupmock: Be wiser about detecting fakerootdir change vircgroupmock: Make global variables static sockettest: Check for IPv4-in-IPv6 parsing and formatting tests: Update IPv4-in-IPv6 addresses tests/nwfilterxml2firewalldata/ah-ipv6-linux.args | 6 +++--- tests/nwfilterxml2firewalldata/ah-ipv6.xml | 2 +- .../nwfilterxml2firewalldata/all-ipv6-linux.args | 6 +++--- tests/nwfilterxml2firewalldata/all-ipv6.xml | 2 +- tests/nwfilterxml2firewalldata/comment-linux.args | 4 ++-- tests/nwfilterxml2firewalldata/comment.xml | 4 ++-- .../nwfilterxml2firewalldata/esp-ipv6-linux.args | 6 +++--- tests/nwfilterxml2firewalldata/esp-ipv6.xml | 2 +- .../nwfilterxml2firewalldata/hex-data-linux.args | 4 ++-- tests/nwfilterxml2firewalldata/hex-data.xml | 4 ++-- tests/nwfilterxml2firewalldata/icmpv6-linux.args | 2 +- tests/nwfilterxml2firewalldata/icmpv6.xml | 2 +- tests/nwfilterxml2firewalldata/ipv6-linux.args | 4 ++-- tests/nwfilterxml2firewalldata/ipv6.xml | 4 ++-- .../nwfilterxml2firewalldata/sctp-ipv6-linux.args | 6 +++--- tests/nwfilterxml2firewalldata/sctp-ipv6.xml | 2 +- .../nwfilterxml2firewalldata/tcp-ipv6-linux.args | 6 +++--- tests/nwfilterxml2firewalldata/tcp-ipv6.xml | 2 +- .../nwfilterxml2firewalldata/udp-ipv6-linux.args | 6 +++--- tests/nwfilterxml2firewalldata/udp-ipv6.xml | 2 +- .../udplite-ipv6-linux.args | 6 +++--- tests/nwfilterxml2firewalldata/udplite-ipv6.xml | 2 +- tests/nwfilterxml2xmlin/ah-ipv6-test-invalid.xml | 2 +- tests/nwfilterxml2xmlin/all-ipv6-test-invalid.xml | 2 +- tests/nwfilterxml2xmlin/comment-test-invalid.xml | 4 ++-- tests/nwfilterxml2xmlin/esp-ipv6-test-invalid.xml | 2 +- tests/nwfilterxml2xmlin/hex-data-test-invalid.xml | 4 ++-- tests/nwfilterxml2xmlin/icmpv6-test-invalid.xml | 2 +- tests/nwfilterxml2xmlin/ipv6-test-invalid.xml | 4 ++-- .../nwfilterxml2xmlin/sctp-ipv6-test-invalid.xml | 2 +- tests/nwfilterxml2xmlin/tcp-ipv6-test-invalid.xml | 2 +- tests/nwfilterxml2xmlin/udp-ipv6-test-invalid.xml | 2 +- .../udplite-ipv6-test-invalid.xml | 2 +- tests/nwfilterxml2xmlout/ah-ipv6-test.xml | 2 +- tests/nwfilterxml2xmlout/all-ipv6-test.xml | 2 +- tests/nwfilterxml2xmlout/comment-test.xml | 2 +- tests/nwfilterxml2xmlout/esp-ipv6-test.xml | 2 +- tests/nwfilterxml2xmlout/hex-data-test.xml | 2 +- tests/nwfilterxml2xmlout/icmpv6-test.xml | 2 +- tests/nwfilterxml2xmlout/ipv6-test.xml | 2 +- tests/nwfilterxml2xmlout/sctp-ipv6-test.xml | 2 +- tests/nwfilterxml2xmlout/tcp-ipv6-test.xml | 2 +- tests/nwfilterxml2xmlout/udp-ipv6-test.xml | 2 +- tests/nwfilterxml2xmlout/udplite-ipv6-test.xml | 2 +- tests/sockettest.c | 2 ++ tests/vircgroupmock.c | 15 ++++++--------- 46 files changed, 75 insertions(+), 76 deletions(-) -- 2.34.1

2 6

[PATCH] deprecation: x86 default machine types
by Dr. David Alan Gilbert (git) 03 Mar '22

03 Mar '22

From: "Dr. David Alan Gilbert" <dgilbert(a)redhat.com> Declare the intent to require a machine type to be specified on x86 system emulation. Signed-off-by: Dr. David Alan Gilbert <dgilbert(a)redhat.com> --- docs/about/deprecated.rst | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 85773db631..143c60d105 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -324,6 +324,14 @@ machine is hardly emulated at all (e.g. neither the LCD nor the USB part had been implemented), so there is not much value added by this board. Use the ``ref405ep`` machine instead. +x86 default machine type +'''''''''''''''''''''''' + +x86 currently defaults to the ```pc``` machine type which is based on the very +old ```i440fx``` chipset. This default will be removed and the user will be +required to specify a machine type explicitly using -M; users are encouraged to +switch to the not quite as old ```q35``` machine types. + Backend options --------------- -- 2.35.1

4 5

[libvirt PATCH 0/4] [RFC] Functional CI - GitLab enablement
by Erik Skultety 03 Mar '22

03 Mar '22

I'd like to propose a PoC of a GitLab-driven functional CI based on GitLab's custom executor runner feature. ** TL;DR ** - there's some RH owned HW that can be utilized for upstream functional CI running workloads on Red Hat-sponsored distros (see the pipeline) - the PoC utilizes GitLab's custom executor feature [1] which allows literally any infrastructure to be plugged into the CI machinery - the PoC solution (as proposed) is relying on nested virt capability and backed by plain libvirt + QEMU/KVM - the test environment comprises of the libvirt-TCK suite [2] and Avocado test framework [3] as the harness engine (as a wrapper and future replacement of the existing Perl implementation) - example pipeline (simplified to only a couple of distros) can be found here [4] - libvirt debug logs are exposed as artifacts and can be downloaded on job failure ** LONG VERSION ** This RFC is driven by GitLab's custom executor feature which can be integrated with any VMM and hence libvirt+QEMU/KVM as well. Example pipeline can be found here [4]. Architecture ============ Platform ~~~~~~~~ It doesn't matter what platform is used with this PoC, but FWIW the one tested with this PoC is a baremetal KVM virtualization host provided and owned by Red Hat, utilizing libvirt, QEMU, a bit of lcitool [5], and libguestfs. Custom executor ~~~~~~~~~~~~~~ If you're wondering why this PoC revolves around the custom executor GitLab runner type [6], some time ago GitLab decided that instead of adding and supporting different types of virtualization runners, they'd create some kind of gateway suitable basically for any solution out there and named it 'custom executor' - it's nothing more than a bunch of shell scripts categorized to various stages of a pipeline job (which will run either on the host or the guest depending how you set it up). Provisioner ~~~~~~~~~~~ Wait, why is this section needed, just take the example scripts from [1]... If you look at the example Bash scripts in GitLab's docs on custom executor [1] you'll see that the example scripts are very straight forward and concise but there are few things that are suboptimal - creating a new disk image for every single VM instance of the same distro out of the virt-builder template - injecting a bunch of commands directly with virt-builder instead of using something more robust like Ansible when there is more than a single VM to be created - static hostname for every single VM instance - waiting for the either the VM getting an IP or for the SSH connection to be available for a quite limited fixed period of time Because I wanted to address all of the ^above pitfalls, I created a Python based provisioner relying on libvirt-NSS, transient machines, backing chain overlay images, cloud-init, etc. instead. You can find the code base for the provisioner here [7]. Child pipelines & Multiproject CI pipelines ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ child pipeline = a "downstream" (or subpipeline) of the main pipeline useful when there are multiple stages which should be part of a single stage of the main pipeline multiproject pipeline = a pipeline that is kicked off by the main pipeline of your project and runs in context of a different project which your main pipeline can then depend on Technically speaking none of the above 2 GitLab features is needed to really integrate this PoC to upstream libvirt CI, but it was a nice experiment from 3 perspectives: 1) seeing that GitLab's own public SaaS deployment has features from all tiers available 2) it made some job descriptions shorter because e.g. we didn't have to rebuild libvirt in the VM when it was done in the previous step in a container; we don't need to build the Perl bindings (which we need for libvirt-TCK) in the VM either, since we already have a project and hence a pipeline for that already, we just need to harness the results which combined makes the actual VM's purpose more obvious 3) installing libvirt and libvirt-perl using the RPM artifacts built in previous pipeline stages is closer to a real life deployment/environment than re-building everything in the VM followed by doing 'sudo make install' Artifacts ~~~~~~~~~ Apart from the RPMs being published as artifacts from an earlier stage of the pipeline as mentioned in the previous section, in order for this to be any useful to the developers (I know, NOTHING beats a local setup, just be patient with us/me for another while...), when there's a genuine test failure (no infrastructure is failproof), the job description as proposed in patch 4/5 exposes libvirt debug logs as artifacts which can be downloaded and inspected. Test framework ============== For the SW testing part a combination of libvirt-TCK [2] and Avocado [3] were used. The reasoning for this combined test environment was discussed in this thread [8], but essentially we'd like to port most of the Perl-native TCK tests to Python, as more people are familiar with the language, making maintenance of them easier as well as making it easier to contribute new tests to the somewhat ancient test suite. Avocado can definitely help here as it does provide a good foundation and building stones to achieve both. Work in progress ================ One of the things that we already know is problematic with the current hybrid TCK+Avocado setup is that if a test fails, the summary that Avocado produces doesn't quickly tell us which tests have failed and one has to either scroll through the GitLab job output or wade through Avocado job logs. -> this issue is tracked in upstream Avocado and should be addressed soon: https://github.com/avocado-framework/avocado/issues/5200 Another annoying thing in terms of test failure analysis is that TCK in its current shape cannot save libvirt debug logs on a per-test basis and so a massive dump is produced for the whole test run. This is very suboptimal, but this can only be solved with libvirt admin API which can enable/modify/redirect logs at runtime, however, the perl bindings are currently missings -> I'm already working on adding the bindings to libvirt-perl and then we need to teach TCK to use that feature Known issues ============ There are already a couple of known test failures which can be seen in the example pipeline: 1) modular daemons occasionally hang in some test scenarios (doesn't happen with monolithic) https://bugzilla.redhat.com/show_bug.cgi?id=2044379 2) QEMU tray status detection when a CD media is changed -> this one is also intermittent, but no good reproducer data to attach to an official QEMU BZ has been harnessed so far [1] https://docs.gitlab.com/runner/executors/custom.html [2] https://gitlab.com/libvirt/libvirt-tck/ [3] https://avocado-framework.readthedocs.io/ [4] https://gitlab.com/eskultety/libvirt/-/pipelines/457836923 [5] https://gitlab.com/libvirt/libvirt-ci/ [6] https://docs.gitlab.com/runner/executors/ [7] https://gitlab.com/eskultety/libvirt-gitlab-executor [8] https://listman.redhat.com/archives/libvir-list/2021-June/msg00836.html Erik Skultety (4): ci: manifest: Allow RPM builds on CentOS Stream 8 ci: containers: Add CentOS Stream 9 target ci: manifest: Publish RPMs as artifacts on CentOS Stream and Fedoras gitlab-ci: Introduce a new test 'integration' pipeline stage .gitlab-ci-integration.yml | 116 +++++++++++++++++++++++ .gitlab-ci.yml | 17 +++- ci/containers/centos-stream-9.Dockerfile | 87 +++++++++++++++++ ci/gitlab.yml | 33 ++++++- ci/manifest.yml | 26 ++++- 5 files changed, 274 insertions(+), 5 deletions(-) create mode 100644 .gitlab-ci-integration.yml create mode 100644 ci/containers/centos-stream-9.Dockerfile -- 2.34.1

5 37