- Devel - libvirt List Archives

[libvirt PATCH 0/2] ci: Refresh, add Ubuntu 22.04
by Andrea Bolognani 06 May '22

06 May '22

Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/532731034 Andrea Bolognani (2): ci: Refresh configuration ci: Add Ubuntu 22.04 ci/containers/ubuntu-2204.Dockerfile | 101 +++++++++++++++++++++++++++ ci/gitlab.yml | 18 ++++- ci/manifest.yml | 2 + 3 files changed, 120 insertions(+), 1 deletion(-) create mode 100644 ci/containers/ubuntu-2204.Dockerfile -- 2.35.1

3 7

[libvirt PATCH 0/3] meson: Fix handling of version scripts
by Andrea Bolognani 06 May '22

06 May '22

Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/532183411 Andrea Bolognani (3): meson: Refactor handling of link_args and link_depends meson: Don't attempt to use version scripts on macOS meson: Drop support for -Wl,-M meson.build | 5 +- src/admin/meson.build | 22 +++++++-- src/meson.build | 110 +++++++++++++++++++++++------------------- tools/nss/meson.build | 48 +++++++++++------- 4 files changed, 111 insertions(+), 74 deletions(-) -- 2.35.1

2 4

[PATCH] Support cpu0-id of Qemu QMP query-sev-capabilities
by Niteesh Dubey 05 May '22

05 May '22

It allows libvirt to provide the value of cpu0-id retuned by the Qemu QMP command query-sev-capabilities as implemented by the Qemu Patch [1] which is merged to Qemu master branch and should be available with Qemu 7.1. This is used to get the signed Chip Endorsement Key (CEK) of the CPU of AMD system from AMD's Key Distribution Service (KDS). Similar to cbitpos, reducedPhysBits, maxGuests & maxESGuests; the value of cpu0-id is also provided using 'virsh domcapability'. [1] https://lore.kernel.org/all/20220228093014.882288-1-dovmurik@linux.ibm.com/ Signed-off-by: Niteesh Dubey <niteesh(a)linux.ibm.com> --- include/libvirt/libvirt-host.h | 11 +++++++++++ src/conf/domain_capabilities.c | 4 ++++ src/conf/domain_capabilities.h | 1 + src/qemu/qemu_capabilities.c | 12 ++++++++++++ src/qemu/qemu_driver.c | 5 +++++ src/qemu/qemu_monitor_json.c | 6 ++++++ 6 files changed, 39 insertions(+) diff --git a/include/libvirt/libvirt-host.h b/include/libvirt/libvirt-host.h index b5cf8a4a4a..d35abbd9aa 100644 --- a/include/libvirt/libvirt-host.h +++ b/include/libvirt/libvirt-host.h @@ -537,6 +537,17 @@ typedef virNodeMemoryStats *virNodeMemoryStatsPtr; */ # define VIR_NODE_SEV_CERT_CHAIN "cert-chain" +/** + * VIR_NODE_SEV_CPU0_ID: + * + * Macro represents the unique ID of CPU0 (socket 0) needed to retrieve + * the signed CEK of the CPU from AMD's Key Distribution Service (KDS), + * as VIR_TYPED_PARAMS_STRING. + * + * Since: v8.3.1 + */ +# define VIR_NODE_SEV_CPU0_ID "cpu0-id" + /** * VIR_NODE_SEV_CBITPOS: * diff --git a/src/conf/domain_capabilities.c b/src/conf/domain_capabilities.c index c394a7a390..2a888da1a9 100644 --- a/src/conf/domain_capabilities.c +++ b/src/conf/domain_capabilities.c @@ -601,6 +601,10 @@ virDomainCapsFeatureSEVFormat(virBuffer *buf, sev->max_guests); virBufferAsprintf(buf, "<maxESGuests>%d</maxESGuests>\n", sev->max_es_guests); + if (sev->cpu0_id != NULL) { + virBufferAsprintf(buf, "<cpu0Id>%s</cpu0Id>\n", + sev->cpu0_id); + } virBufferAdjustIndent(buf, -2); virBufferAddLit(buf, "</sev>\n"); } diff --git a/src/conf/domain_capabilities.h b/src/conf/domain_capabilities.h index 1d2f4ac7a5..f2eed80b15 100644 --- a/src/conf/domain_capabilities.h +++ b/src/conf/domain_capabilities.h @@ -185,6 +185,7 @@ typedef struct _virSEVCapability virSEVCapability; struct _virSEVCapability { char *pdh; char *cert_chain; + char *cpu0_id; unsigned int cbitpos; unsigned int reduced_phys_bits; unsigned int max_guests; diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index b91db851bb..2d3165e74a 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -1957,6 +1957,9 @@ virQEMUCapsSEVInfoCopy(virSEVCapability **dst, tmp->pdh = g_strdup(src->pdh); tmp->cert_chain = g_strdup(src->cert_chain); + if (src->cpu0_id != NULL) { + tmp->cpu0_id = g_strdup(src->cpu0_id); + } tmp->cbitpos = src->cbitpos; tmp->reduced_phys_bits = src->reduced_phys_bits; @@ -4693,6 +4696,11 @@ virQEMUCapsFormatSEVInfo(virQEMUCaps *qemuCaps, virBuffer *buf) virBufferEscapeString(buf, "<pdh>%s</pdh>\n", sev->pdh); virBufferEscapeString(buf, "<certChain>%s</certChain>\n", sev->cert_chain); + if (sev->cpu0_id != NULL) { + virBufferEscapeString(buf, "<cpu0Id>%s</cpu0Id>\n", + sev->cpu0_id); + } + virBufferAdjustIndent(buf, -2); virBufferAddLit(buf, "</sev>\n"); } @@ -6478,6 +6486,10 @@ virQEMUCapsFillDomainFeatureSEVCaps(virQEMUCaps *qemuCaps, domCaps->sev->pdh = g_strdup(cap->pdh); domCaps->sev->cert_chain = g_strdup(cap->cert_chain); + if (cap->cpu0_id != NULL) { + domCaps->sev->cpu0_id = g_strdup(cap->cpu0_id); + } + domCaps->sev->cbitpos = cap->cbitpos; domCaps->sev->reduced_phys_bits = cap->reduced_phys_bits; domCaps->sev->max_guests = cap->max_guests; diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index ee0963c30d..464c080409 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -19861,6 +19861,11 @@ qemuGetSEVInfoToParams(virQEMUCaps *qemuCaps, VIR_NODE_SEV_CERT_CHAIN, sev->cert_chain) < 0) goto cleanup; + if ((sev->cpu0_id != NULL) && + (virTypedParamsAddString(&sevParams, &n, &maxpar, + VIR_NODE_SEV_CPU0_ID, sev->cpu0_id) < 0)) + goto cleanup; + if (virTypedParamsAddUInt(&sevParams, &n, &maxpar, VIR_NODE_SEV_CBITPOS, sev->cbitpos) < 0) goto cleanup; diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 776f4ab2ea..9e611e93e8 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -6400,6 +6400,7 @@ qemuMonitorJSONGetSEVCapabilities(qemuMonitor *mon, virJSONValue *caps; const char *pdh = NULL; const char *cert_chain = NULL; + const char *cpu0_id = NULL; unsigned int cbitpos; unsigned int reduced_phys_bits; g_autoptr(virSEVCapability) capability = NULL; @@ -6457,6 +6458,11 @@ qemuMonitorJSONGetSEVCapabilities(qemuMonitor *mon, capability->cert_chain = g_strdup(cert_chain); + cpu0_id = virJSONValueObjectGetString(caps, "cpu0-id"); + if (cpu0_id != NULL) { + capability->cpu0_id = g_strdup(cpu0_id); + } + capability->cbitpos = cbitpos; capability->reduced_phys_bits = reduced_phys_bits; *capabilities = g_steal_pointer(&capability); -- 2.25.1

3 4

[libvirt PATCH 0/2] API documentation fixes
by Andrea Bolognani 05 May '22

05 May '22

Andrea Bolognani (2): lib: Drop "type hint" comments include: Explicitly reserve values for overlapping flag types include/libvirt/libvirt-common.h.in | 19 +++++++++++++++++-- include/libvirt/libvirt-domain.h | 8 ++++---- src/libvirt-network.c | 4 ++-- 3 files changed, 23 insertions(+), 8 deletions(-) -- 2.35.1

3 10

[PATCH 0/2] virnetdev: Fix regression in setting VLAN tag
by Michal Privoznik 05 May '22

05 May '22

*** BLURB HERE *** Michal Prívozník (2): virNetDevSetVfMac: Fix error message on invalid args virnetdev: Fix regression in setting VLAN tag src/util/virnetdev.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) -- 2.35.1

3 4

[libvirt PATCH 0/8] Improve heuristics for computing baseline CPU models
by Jiri Denemark 05 May '22

05 May '22

See 7/8 and 8/8 for details. https://bugzilla.redhat.com/show_bug.cgi?id=1851227 Jiri Denemark (8): cpu_map: Disable cpu64-rhel* for host-model and baseline cputest: Drop some old artificial baseline tests cputest: Give better names to baseline tests cputest: Add some real world baseline tests cpu_x86: Consolidate signature match in x86DecodeUseCandidate cpu_x86: Refactor feature list comparison in x86DecodeUseCandidate cpu_x86: Penalize disabled features when computing CPU model cpu_x86: Ignore enabled features for input models in x86DecodeUseCandidate src/cpu/cpu_x86.c | 156 ++++++++++++------ src/cpu_map/x86_cpu64-rhel5.xml | 2 +- src/cpu_map/x86_cpu64-rhel6.xml | 2 +- tests/cputest.c | 136 ++++++++++++--- .../cputestdata/x86_64-baseline-1-result.xml | 5 - tests/cputestdata/x86_64-baseline-1.xml | 20 --- .../cputestdata/x86_64-baseline-2-result.xml | 4 - tests/cputestdata/x86_64-baseline-2.xml | 22 --- .../x86_64-baseline-5-expanded.xml | 47 ------ tests/cputestdata/x86_64-baseline-5.xml | 35 ---- .../x86_64-baseline-6-migratable.xml | 10 -- .../cputestdata/x86_64-baseline-7-result.xml | 4 - tests/cputestdata/x86_64-baseline-7.xml | 24 --- .../cputestdata/x86_64-baseline-8-result.xml | 4 - tests/cputestdata/x86_64-baseline-8.xml | 28 ---- ...-baseline-Westmere+Nehalem-migratable.xml} | 8 +- ...6_64-baseline-Westmere+Nehalem-result.xml} | 8 +- ...l => x86_64-baseline-Westmere+Nehalem.xml} | 0 ... => x86_64-baseline-features-expanded.xml} | 0 ...ml => x86_64-baseline-features-result.xml} | 0 ...ine-4.xml => x86_64-baseline-features.xml} | 0 .../x86_64-baseline-no-vendor-result.xml | 3 +- ...ml => x86_64-baseline-simple-expanded.xml} | 0 ....xml => x86_64-baseline-simple-result.xml} | 0 ...eline-3.xml => x86_64-baseline-simple.xml} | 0 .../x86_64-cpuid-Atom-D510-guest.xml | 5 +- .../x86_64-cpuid-Atom-N450-guest.xml | 5 +- .../x86_64-cpuid-Phenom-B95-json.xml | 21 ++- ...id-baseline-Broadwell-IBRS+Cascadelake.xml | 14 ++ ..._64-cpuid-baseline-Cascadelake+Icelake.xml | 15 ++ ...puid-baseline-Cascadelake+Skylake-IBRS.xml | 13 ++ ..._64-cpuid-baseline-Cascadelake+Skylake.xml | 8 + ...-cpuid-baseline-Cooperlake+Cascadelake.xml | 22 +++ ...6_64-cpuid-baseline-Cooperlake+Icelake.xml | 15 ++ .../x86_64-cpuid-baseline-EPYC+Rome.xml | 13 ++ .../x86_64-cpuid-baseline-Haswell+Skylake.xml | 14 ++ ...-baseline-Haswell-noTSX-IBRS+Broadwell.xml | 14 ++ ...seline-Haswell-noTSX-IBRS+Skylake-IBRS.xml | 14 ++ ...id-baseline-Haswell-noTSX-IBRS+Skylake.xml | 14 ++ .../x86_64-cpuid-baseline-Ryzen+Rome.xml | 13 ++ ...4-cpuid-baseline-Skylake-Client+Server.xml | 9 + .../x86_64-host+guest,models-result.xml | 10 +- .../domaincapsdata/qemu_3.1.0-tcg.x86_64.xml | 35 ++-- .../domaincapsdata/qemu_4.0.0-tcg.x86_64.xml | 36 ++-- .../domaincapsdata/qemu_4.1.0-tcg.x86_64.xml | 37 +++-- .../domaincapsdata/qemu_4.2.0-tcg.x86_64.xml | 37 +++-- .../domaincapsdata/qemu_5.0.0-tcg.x86_64.xml | 36 ++-- .../domaincapsdata/qemu_5.1.0-tcg.x86_64.xml | 36 ++-- .../domaincapsdata/qemu_5.2.0-tcg.x86_64.xml | 36 ++-- .../domaincapsdata/qemu_6.0.0-tcg.x86_64.xml | 36 ++-- .../domaincapsdata/qemu_6.1.0-tcg.x86_64.xml | 36 ++-- .../domaincapsdata/qemu_6.2.0-tcg.x86_64.xml | 36 ++-- .../domaincapsdata/qemu_7.0.0-tcg.x86_64.xml | 36 ++-- tests/qemuxml2argvdata/cpu-fallback.args | 2 +- .../cpu-host-model-cmt.x86_64-4.0.0.args | 2 +- .../cpu-host-model-fallback.args | 2 +- 56 files changed, 681 insertions(+), 459 deletions(-) delete mode 100644 tests/cputestdata/x86_64-baseline-1-result.xml delete mode 100644 tests/cputestdata/x86_64-baseline-1.xml delete mode 100644 tests/cputestdata/x86_64-baseline-2-result.xml delete mode 100644 tests/cputestdata/x86_64-baseline-2.xml delete mode 100644 tests/cputestdata/x86_64-baseline-5-expanded.xml delete mode 100644 tests/cputestdata/x86_64-baseline-5.xml delete mode 100644 tests/cputestdata/x86_64-baseline-6-migratable.xml delete mode 100644 tests/cputestdata/x86_64-baseline-7-result.xml delete mode 100644 tests/cputestdata/x86_64-baseline-7.xml delete mode 100644 tests/cputestdata/x86_64-baseline-8-result.xml delete mode 100644 tests/cputestdata/x86_64-baseline-8.xml rename tests/cputestdata/{x86_64-baseline-5-result.xml => x86_64-baseline-Westmere+Nehalem-migratable.xml} (51%) rename tests/cputestdata/{x86_64-baseline-6-result.xml => x86_64-baseline-Westmere+Nehalem-result.xml} (54%) rename tests/cputestdata/{x86_64-baseline-6.xml => x86_64-baseline-Westmere+Nehalem.xml} (100%) rename tests/cputestdata/{x86_64-baseline-4-expanded.xml => x86_64-baseline-features-expanded.xml} (100%) rename tests/cputestdata/{x86_64-baseline-4-result.xml => x86_64-baseline-features-result.xml} (100%) rename tests/cputestdata/{x86_64-baseline-4.xml => x86_64-baseline-features.xml} (100%) rename tests/cputestdata/{x86_64-baseline-3-expanded.xml => x86_64-baseline-simple-expanded.xml} (100%) rename tests/cputestdata/{x86_64-baseline-3-result.xml => x86_64-baseline-simple-result.xml} (100%) rename tests/cputestdata/{x86_64-baseline-3.xml => x86_64-baseline-simple.xml} (100%) create mode 100644 tests/cputestdata/x86_64-cpuid-baseline-Broadwell-IBRS+Cascadelake.xml create mode 100644 tests/cputestdata/x86_64-cpuid-baseline-Cascadelake+Icelake.xml create mode 100644 tests/cputestdata/x86_64-cpuid-baseline-Cascadelake+Skylake-IBRS.xml create mode 100644 tests/cputestdata/x86_64-cpuid-baseline-Cascadelake+Skylake.xml create mode 100644 tests/cputestdata/x86_64-cpuid-baseline-Cooperlake+Cascadelake.xml create mode 100644 tests/cputestdata/x86_64-cpuid-baseline-Cooperlake+Icelake.xml create mode 100644 tests/cputestdata/x86_64-cpuid-baseline-EPYC+Rome.xml create mode 100644 tests/cputestdata/x86_64-cpuid-baseline-Haswell+Skylake.xml create mode 100644 tests/cputestdata/x86_64-cpuid-baseline-Haswell-noTSX-IBRS+Broadwell.xml create mode 100644 tests/cputestdata/x86_64-cpuid-baseline-Haswell-noTSX-IBRS+Skylake-IBRS.xml create mode 100644 tests/cputestdata/x86_64-cpuid-baseline-Haswell-noTSX-IBRS+Skylake.xml create mode 100644 tests/cputestdata/x86_64-cpuid-baseline-Ryzen+Rome.xml create mode 100644 tests/cputestdata/x86_64-cpuid-baseline-Skylake-Client+Server.xml -- 2.35.1

2 10

[PATCH] include: Fix unmatched parentheses in comment
by Andrea Bolognani 04 May '22

04 May '22

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. include/libvirt/libvirt-network.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/libvirt/libvirt-network.h b/include/libvirt/libvirt-network.h index d3e3fdeecf..90cde0cf24 100644 --- a/include/libvirt/libvirt-network.h +++ b/include/libvirt/libvirt-network.h @@ -176,7 +176,7 @@ int virNetworkUndefine (virNetworkPtr network); * Since: 0.10.2 */ typedef enum { - VIR_NETWORK_UPDATE_COMMAND_NONE = 0, /* (invalid (Since: 0.10.2) */ + VIR_NETWORK_UPDATE_COMMAND_NONE = 0, /* invalid (Since: 0.10.2) */ VIR_NETWORK_UPDATE_COMMAND_MODIFY = 1, /* modify an existing element (Since: 0.10.2) */ VIR_NETWORK_UPDATE_COMMAND_DELETE = 2, /* delete an existing element (Since: 0.10.2) */ VIR_NETWORK_UPDATE_COMMAND_ADD_LAST = 3, /* add an element at end of list (Since: 0.10.2) */ @@ -195,7 +195,7 @@ typedef enum { * Since: 0.10.2 */ typedef enum { - VIR_NETWORK_SECTION_NONE = 0, /* (invalid (Since: 0.10.2) */ + VIR_NETWORK_SECTION_NONE = 0, /* invalid (Since: 0.10.2) */ VIR_NETWORK_SECTION_BRIDGE = 1, /* <bridge> (Since: 0.10.2) */ VIR_NETWORK_SECTION_DOMAIN = 2, /* <domain> (Since: 0.10.2) */ VIR_NETWORK_SECTION_IP = 3, /* <ip> (Since: 0.10.2) */ -- 2.35.1

1 0

[PATCH v4 00/19] Add 'version' to other exported types
by Victor Toso 04 May '22

04 May '22

Hi, The 4th is coming! v3: https://listman.redhat.com/archives/libvir-list/2022-April/230200.html v2: https://listman.redhat.com/archives/libvir-list/2022-April/230097.html v1: https://listman.redhat.com/archives/libvir-list/2022-April/229881.html I tried to be more careful this time in regards to the patch flow. - The first 4 patches are related to wrong versions introduced in https://gitlab.com/libvirt/libvirt/-/commit/034432e47b Each commit log points out the error I did in v3 and fixes it. If you rather squash them, feel free. - 05/19 "remove comments between enum values" are following Andrea and Peter's suggestion that this should be fixed before adding the version tags: https://listman.redhat.com/archives/libvir-list/2022-April/230304.html - 06/19 "avoid sc_prohibit_nonreentrant in a comment" is the workaround proposed by Peter to avoid syntax-check failure https://listman.redhat.com/archives/libvir-list/2022-April/230238.html - I have set the virAdm exported types to be minimum = v2.0.0. This is for all related types of libvirt-admin: * 08/19 for enums; * 09/19 for macros; * 10/19 for typedefs; * 12/19 for functions; - For exported version of functions, the syms file are the source of truth apart from 4 functions (Peter) https://listman.redhat.com/archives/libvir-list/2022-April/230236.html - Variable's comments are now properly sanitized (Andrea) https://listman.redhat.com/archives/libvir-list/2022-April/230352.html - Removed an extra line in the block of comments (Andrea) https://listman.redhat.com/archives/libvir-list/2022-April/230291.html The CI run for this series: https://gitlab.com/victortoso/libvirt/-/pipelines/522757286 Have a great weekend, Victor Victor Toso (19): docstring: typedef: fix version of virConnectListAllStoragePoolsFlags docstring: typedef: fix version of virDomainDeviceModifyFlags docstring: typedef: fix version of virDomainMemoryModFlags docstring: typedef: fix version of virDomainVcpuFlags docstring: remove comments between enum values docstring: avoid sc_prohibit_nonreentrant in a comment docstring: enums: libvirt: Add 'Since version' metadata docstring: enums: admin: Add 'Since version' metadata docstring: macros: admin: Add 'Since version' metadata docstring: typedef: admin:: Add 'Since version' metadata docstring: function: libvirt: Add 'Since version' metadata docstring: function: admin: Add 'Since version' metadata scripts: apibuild: parse 'Since' version for enums scripts: apibuild: fix parsing block comments from typedef enum scripts: apibuild: parse 'Since' for typedefs scripts: apibuild: parse 'Since' for macros scripts: apibuild: parse 'Since' for functions scripts: apibuild: factor out comment cleaning scripts: apibuild: add parsing variable's comments include/libvirt/libvirt-admin.h | 67 +- include/libvirt/libvirt-domain-checkpoint.h | 28 +- include/libvirt/libvirt-domain-snapshot.h | 60 +- include/libvirt/libvirt-domain.h | 1260 +++++++++++-------- include/libvirt/libvirt-event.h | 24 +- include/libvirt/libvirt-host.h | 62 +- include/libvirt/libvirt-interface.h | 8 +- include/libvirt/libvirt-network.h | 92 +- include/libvirt/libvirt-nodedev.h | 70 +- include/libvirt/libvirt-nwfilter.h | 4 +- include/libvirt/libvirt-secret.h | 40 +- include/libvirt/libvirt-storage.h | 173 +-- include/libvirt/libvirt-stream.h | 24 +- include/libvirt/virterror.h | 408 +++--- scripts/apibuild.py | 163 ++- src/admin/libvirt-admin.c | 62 + src/libvirt-domain-checkpoint.c | 24 + src/libvirt-domain-snapshot.c | 42 + src/libvirt-domain.c | 371 +++++- src/libvirt-host.c | 68 + src/libvirt-interface.c | 42 + src/libvirt-network.c | 89 ++ src/libvirt-nodedev.c | 54 + src/libvirt-nwfilter.c | 48 + src/libvirt-secret.c | 40 + src/libvirt-storage.c | 114 ++ src/libvirt-stream.c | 34 + src/libvirt.c | 12 + src/util/virerror.c | 30 + src/util/virevent.c | 18 + 30 files changed, 2497 insertions(+), 1034 deletions(-) -- 2.35.1

2 34

[libvirt PATCH] tests: Add test for missing network attribute in graphics' listen element
by Martin Kletzander 04 May '22

04 May '22

This tests a change done in commit 871a071abb9c. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- .../graphics-listen-network-invalid.xml | 29 +++++++++++++++++++ tests/genericxml2xmltest.c | 1 + 2 files changed, 30 insertions(+) create mode 100644 tests/genericxml2xmlindata/graphics-listen-network-invalid.xml diff --git a/tests/genericxml2xmlindata/graphics-listen-network-invalid.xml b/tests/genericxml2xmlindata/graphics-listen-network-invalid.xml new file mode 100644 index 000000000000..87b5a32abe87 --- /dev/null +++ b/tests/genericxml2xmlindata/graphics-listen-network-invalid.xml @@ -0,0 +1,29 @@ +<domain type='qemu'> + <name>QEMUGuest1</name> + <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> + <memory unit='KiB'>219100</memory> + <currentMemory unit='KiB'>219100</currentMemory> + <vcpu placement='static'>1</vcpu> + <os> + <type arch='i686' machine='pc'>hvm</type> + <boot dev='hd'/> + </os> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <controller type='usb' index='0'/> + <controller type='ide' index='0'/> + <controller type='pci' index='0' model='pci-root'/> + <input type='mouse' bus='ps2'/> + <input type='keyboard' bus='ps2'/> + <graphics type='vnc'> + <listen type='network'/> + </graphics> + <video> + <model type='cirrus' vram='16384' heads='1' primary='yes'/> + </video> + <memballoon model='none'/> + </devices> +</domain> diff --git a/tests/genericxml2xmltest.c b/tests/genericxml2xmltest.c index 34ccaff61503..87014e3e531f 100644 --- a/tests/genericxml2xmltest.c +++ b/tests/genericxml2xmltest.c @@ -174,6 +174,7 @@ mymain(void) DO_TEST_DIFFERENT("graphics-vnc-socket-attr-listen-socket"); DO_TEST_FAIL_ACTIVE("graphics-vnc-socket-attr-listen-socket-mismatch"); DO_TEST("graphics-vnc-autoport-no"); + DO_TEST_FAIL_INACTIVE("graphics-listen-network-invalid"); DO_TEST_FAIL_ACTIVE("name-slash-fail"); -- 2.35.1

2 1

[PATCH v2] conf: virDomainGraphicsDefValidate: validate attribute 'network' for listen type 'network'
by Amneesh Singh 04 May '22

04 May '22

Related: https://gitlab.com/libvirt/libvirt/-/issues/93 Signed-off-by: Amneesh Singh <natto(a)weirdnatto.in> --- v1 PATCH: https://listman.redhat.com/archives/libvir-list/2022-April/230021.html src/conf/domain_validate.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index 68190fc..e58b84e 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -2347,10 +2347,35 @@ virDomainAudioDefValidate(const virDomainDef *def, return 0; } +static int +virDomainGraphicsDefListensValidate(const virDomainGraphicsDef *def) +{ + size_t i; + + for (i = 0; i < def->nListens; i++) { + if (def->listens[i].type == VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK && + !def->listens[i].network) { + virReportError(VIR_ERR_XML_ERROR, "%s", + _("'network' attribute is required for " + "listen type 'network'")); + return -1; + } + } + + return 0; +} + static int virDomainGraphicsDefValidate(const virDomainDef *def, const virDomainGraphicsDef *graphics) { + if (graphics->type == VIR_DOMAIN_GRAPHICS_TYPE_VNC || + graphics->type == VIR_DOMAIN_GRAPHICS_TYPE_SPICE || + graphics->type == VIR_DOMAIN_GRAPHICS_TYPE_RDP) { + if (virDomainGraphicsDefListensValidate(graphics) < 0) + return -1; + } + if (graphics->type == VIR_DOMAIN_GRAPHICS_TYPE_VNC) return virDomainEnsureAudioID(def, graphics->data.vnc.audioId); -- 2.35.1

2 1

[RFC PATCH 0/2] Introduce 'absolute' clock offset
by Peter Krempa 04 May '22

04 May '22

Based on https://listman.redhat.com/archives/libvirt-users/2022-April/013537.html Looked as a very simple addition. Peter Krempa (2): conf: Introduce 'absolute' clock offset qemu: Implement 'absolute' clock offset mode docs/formatdomain.rst | 4 ++ src/conf/domain_conf.c | 13 +++++++ src/conf/domain_conf.h | 4 ++ src/conf/schemas/domaincommon.rng | 8 ++++ src/libxl/libxl_conf.c | 1 + src/qemu/qemu_command.c | 10 ++++- .../clock-absolute.x86_64-latest.args | 36 ++++++++++++++++++ tests/qemuxml2argvdata/clock-absolute.xml | 30 +++++++++++++++ tests/qemuxml2argvtest.c | 1 + .../clock-absolute.x86_64-latest.xml | 38 +++++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 11 files changed, 145 insertions(+), 1 deletion(-) create mode 100644 tests/qemuxml2argvdata/clock-absolute.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/clock-absolute.xml create mode 100644 tests/qemuxml2xmloutdata/clock-absolute.x86_64-latest.xml -- 2.35.1

3 4

[PATCH] qemu: do not use domain virt type to get default version
by Liang Yan 04 May '22

04 May '22

We do not need VIR_DOMAIN_VIRT_QEMU to get qemu default version. With the 'os_type' and 'arch'in capabilities, we could identify 'emulator' which is enough to get the version. Actually VIR_DOMAIN_VIRT_QEMU is not the only domain virt type for qemu driver, there are VIR_DOMAIN_VIRT_KVM and VIR_DOMAIN_VIRT_HVF. If TCG is disabled in qemu, it will cause the error that could not find suitable emulater when access version. Signed-off-by: Liang Yan <lyan(a)digtalocean.com> --- src/qemu/qemu_capabilities.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index b91db851bb..9a0b7ebeb4 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -1857,7 +1857,7 @@ int virQEMUCapsGetDefaultVersion(virCaps *caps, hostarch = virArchFromHost(); if (!(capsdata = virCapabilitiesDomainDataLookup(caps, - VIR_DOMAIN_OSTYPE_HVM, hostarch, VIR_DOMAIN_VIRT_QEMU, + VIR_DOMAIN_OSTYPE_HVM, hostarch, VIR_DOMAIN_VIRT_NONE, NULL, NULL))) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Cannot find suitable emulator for %s"), -- 2.34.1

2 3

[libvirt PATCH v3 00/16] Add QEMU "-display dbus" support
by marcandre.lureau＠redhat.com 04 May '22

04 May '22

From: Marc-André Lureau <marcandre.lureau(a)redhat.com> Hi, This series implements supports for the uQEMU "-display dbus" support, that landed earlier this week for 7.0. By default, libvirt will start a private VM bus (sharing and reusing the existing "vmstate" VM bus & code). The feature set should cover the needs to replace Spice as local client of choice, including 3daccel/dmabuf, audio, clipboard sharing, usb redirection, and arbitrary chardev/channels (for serial etc). The test Gtk4 client is also in progress, currently in development at https://gitlab.com/marcandre.lureau/qemu-display/. A few dependencies, such as zbus, require an upcoming release. virt-viewer & boxes will need a port to Gtk4 to make use of the shared widget. Comments welcome, as we can still adjust the QEMU side etc. thanks v3: after QEMU 7.0 dev cycle opening and merge - rebased - add 7.0 x86-64 capabilities (instead of tweaking 6.2) - fix version annotations Marc-André Lureau (16): qemu: add chardev-vdagent capability check qemu: add -display dbus capability check qemucapabilitiestest: Add x64 test data for the qemu-7.0 development cycle conf: add <graphics type='dbus'> qemu: start the D-Bus daemon for the display qemu: add -display dbus support virsh: refactor/split cmdDomDisplay() virsh: report the D-Bus bus URI for domdisplay conf: add <audio type='dbus'> support qemu: add audio type 'dbus' conf: add dbus <clipboard> qemu: add dbus clipboard sharing conf: add <serial type='dbus'> qemu: add -chardev dbus support qemu: add usbredir type 'dbus' docs: document <graphics> type dbus NEWS.rst | 7 +- docs/formatdomain.rst | 43 +- docs/schemas/basictypes.rng | 7 + docs/schemas/domaincommon.rng | 71 + src/bhyve/bhyve_command.c | 1 + src/conf/domain_conf.c | 141 +- src/conf/domain_conf.h | 15 + src/conf/domain_validate.c | 41 +- src/libxl/libxl_conf.c | 1 + src/qemu/qemu_capabilities.c | 8 + src/qemu/qemu_capabilities.h | 4 + src/qemu/qemu_command.c | 77 +- src/qemu/qemu_domain.c | 1 + src/qemu/qemu_driver.c | 10 +- src/qemu/qemu_extdevice.c | 13 + src/qemu/qemu_hotplug.c | 1 + src/qemu/qemu_monitor_json.c | 10 + src/qemu/qemu_process.c | 41 +- src/qemu/qemu_validate.c | 33 + src/security/security_dac.c | 2 + src/vmx/vmx.c | 1 + .../domaincapsdata/qemu_7.0.0-q35.x86_64.xml | 231 + .../domaincapsdata/qemu_7.0.0-tcg.x86_64.xml | 237 + tests/domaincapsdata/qemu_7.0.0.x86_64.xml | 231 + .../caps_6.1.0.x86_64.xml | 1 + .../caps_6.2.0.aarch64.xml | 1 + .../caps_6.2.0.x86_64.xml | 1 + .../caps_7.0.0.x86_64.replies | 37335 ++++++++++++++++ .../caps_7.0.0.x86_64.xml | 3720 ++ .../graphics-dbus-address.args | 30 + .../graphics-dbus-address.xml | 35 + .../qemuxml2argvdata/graphics-dbus-audio.args | 33 + .../qemuxml2argvdata/graphics-dbus-audio.xml | 45 + .../graphics-dbus-chardev.args | 32 + .../graphics-dbus-chardev.xml | 43 + .../graphics-dbus-clipboard.args | 31 + .../graphics-dbus-clipboard.xml | 35 + tests/qemuxml2argvdata/graphics-dbus-p2p.args | 30 + tests/qemuxml2argvdata/graphics-dbus-p2p.xml | 33 + .../graphics-dbus-usbredir.args | 34 + .../graphics-dbus-usbredir.xml | 30 + tests/qemuxml2argvdata/graphics-dbus.args | 30 + tests/qemuxml2argvdata/graphics-dbus.xml | 33 + tests/qemuxml2argvtest.c | 22 + .../graphics-dbus-address.xml | 1 + .../graphics-dbus-audio.xml | 1 + .../graphics-dbus-chardev.xml | 1 + .../graphics-dbus-clipboard.xml | 1 + .../qemuxml2xmloutdata/graphics-dbus-p2p.xml | 1 + tests/qemuxml2xmloutdata/graphics-dbus.xml | 1 + tests/qemuxml2xmltest.c | 20 + tools/virsh-domain.c | 366 +- 52 files changed, 42981 insertions(+), 192 deletions(-) create mode 100644 tests/domaincapsdata/qemu_7.0.0-q35.x86_64.xml create mode 100644 tests/domaincapsdata/qemu_7.0.0-tcg.x86_64.xml create mode 100644 tests/domaincapsdata/qemu_7.0.0.x86_64.xml create mode 100644 tests/qemucapabilitiesdata/caps_7.0.0.x86_64.replies create mode 100644 tests/qemucapabilitiesdata/caps_7.0.0.x86_64.xml create mode 100644 tests/qemuxml2argvdata/graphics-dbus-address.args create mode 100644 tests/qemuxml2argvdata/graphics-dbus-address.xml create mode 100644 tests/qemuxml2argvdata/graphics-dbus-audio.args create mode 100644 tests/qemuxml2argvdata/graphics-dbus-audio.xml create mode 100644 tests/qemuxml2argvdata/graphics-dbus-chardev.args create mode 100644 tests/qemuxml2argvdata/graphics-dbus-chardev.xml create mode 100644 tests/qemuxml2argvdata/graphics-dbus-clipboard.args create mode 100644 tests/qemuxml2argvdata/graphics-dbus-clipboard.xml create mode 100644 tests/qemuxml2argvdata/graphics-dbus-p2p.args create mode 100644 tests/qemuxml2argvdata/graphics-dbus-p2p.xml create mode 100644 tests/qemuxml2argvdata/graphics-dbus-usbredir.args create mode 100644 tests/qemuxml2argvdata/graphics-dbus-usbredir.xml create mode 100644 tests/qemuxml2argvdata/graphics-dbus.args create mode 100644 tests/qemuxml2argvdata/graphics-dbus.xml create mode 120000 tests/qemuxml2xmloutdata/graphics-dbus-address.xml create mode 120000 tests/qemuxml2xmloutdata/graphics-dbus-audio.xml create mode 120000 tests/qemuxml2xmloutdata/graphics-dbus-chardev.xml create mode 120000 tests/qemuxml2xmloutdata/graphics-dbus-clipboard.xml create mode 120000 tests/qemuxml2xmloutdata/graphics-dbus-p2p.xml create mode 120000 tests/qemuxml2xmloutdata/graphics-dbus.xml -- 2.34.1.8.g35151cf07204

5 23

[libvirt PATCH 0/2] Fix tests on macOS
by Daniel P. Berrangé 03 May '22

03 May '22

NB, even with this done there is still a latent bug affecting all platforms. When we call g_source_destroy the removal is async but we usually close the FD synchronously. This leads to poll'ing on a bad FD. We've actually had this race in libvirt since day 1 - our previous poll() event loop impl before glib would also implement the virEventRemoveHandle call async by just writing to a pipe to interrupt the other thread in poll, just as glib does. We've always relied on parallelism to make this async call almost instantaneous but under the right load conditions we trigger the POLLNVAL / EBADF issue. The only viable solution to this that I see is to only ever call g_source_destroy + g_source_unref from an idle callback, to guarantee that poll() isn't currently running. We know this has a bit of a perf hit on code that is sensitive to main loop iterations, so we tried to avoid it where possible right now: https://listman.redhat.com/archives/libvir-list/2020-November/212411.html I think we'll need to revisit this though, as known BADF problems are not good. Daniel P. Berrangé (2): ci: print stack traces on macOS if any tests fail tests: don't set G_DEBUG=fatal-warnings on macOS ci/cirrus/build.yml | 2 +- tests/meson.build | 17 ++++++++++++++++- 2 files changed, 17 insertions(+), 2 deletions(-) -- 2.35.1

4 10

[libvirt PATCH] conf: ensure only one vgpu has ramfb enabled
by Jonathon Jongsma 02 May '22

02 May '22

Validate the domain configuration to ensure that if there are more than one vgpu assigned to a domain, only one of them has 'ramfb' enabled. This was never a supported configuration. QEMU failed confusingly when attempting to start a domain with this configuration. This change attempts to provide better information about the error. https://bugzilla.redhat.com/show_bug.cgi?id=2079760 Signed-off-by: Jonathon Jongsma <jjongsma(a)redhat.com> --- src/conf/domain_validate.c | 19 ++++++++-- ...v-display-ramfb-multiple.x86_64-latest.err | 1 + .../hostdev-mdev-display-ramfb-multiple.xml | 38 +++++++++++++++++++ tests/qemuxml2argvtest.c | 1 + 4 files changed, 56 insertions(+), 3 deletions(-) create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-ramfb-multiple.x86_64-latest.err create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-ramfb-multiple.xml diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index 68190fc3e2..f4d6e6e0c5 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -1194,20 +1194,33 @@ virDomainDefDuplicateDiskInfoValidate(const virDomainDef *def) } static int -virDomainDefDuplicateHostdevInfoValidate(const virDomainDef *def) +virDomainDefHostdevValidate(const virDomainDef *def) { size_t i; size_t j; + bool ramfbEnabled = false; for (i = 0; i < def->nhostdevs; i++) { + virDomainHostdevDef *dev = def->hostdevs[i]; + for (j = i + 1; j < def->nhostdevs; j++) { - if (virDomainHostdevMatch(def->hostdevs[i], + if (virDomainHostdevMatch(dev, def->hostdevs[j])) { virReportError(VIR_ERR_XML_ERROR, "%s", _("Hostdev already exists in the domain configuration")); return -1; } } + + if (dev->source.subsys.type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_MDEV && + dev->source.subsys.u.mdev.ramfb == VIR_TRISTATE_SWITCH_ON) { + if (ramfbEnabled) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Only one vgpu device can have 'ramfb' enabled")); + return -1; + } + ramfbEnabled = true; + } } return 0; @@ -1664,7 +1677,7 @@ virDomainDefValidateInternal(const virDomainDef *def, if (virDomainDefDuplicateDiskInfoValidate(def) < 0) return -1; - if (virDomainDefDuplicateHostdevInfoValidate(def) < 0) + if (virDomainDefHostdevValidate(def) < 0) return -1; if (virDomainDefDuplicateDriveAddressesValidate(def) < 0) diff --git a/tests/qemuxml2argvdata/hostdev-mdev-display-ramfb-multiple.x86_64-latest.err b/tests/qemuxml2argvdata/hostdev-mdev-display-ramfb-multiple.x86_64-latest.err new file mode 100644 index 0000000000..07ce47abf7 --- /dev/null +++ b/tests/qemuxml2argvdata/hostdev-mdev-display-ramfb-multiple.x86_64-latest.err @@ -0,0 +1 @@ +unsupported configuration: Only one vgpu device can have 'ramfb' enabled diff --git a/tests/qemuxml2argvdata/hostdev-mdev-display-ramfb-multiple.xml b/tests/qemuxml2argvdata/hostdev-mdev-display-ramfb-multiple.xml new file mode 100644 index 0000000000..1fe53726b5 --- /dev/null +++ b/tests/qemuxml2argvdata/hostdev-mdev-display-ramfb-multiple.xml @@ -0,0 +1,38 @@ +<domain type='qemu'> + <name>QEMUGuest2</name> + <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> + <memory unit='KiB'>219136</memory> + <currentMemory unit='KiB'>219136</currentMemory> + <vcpu placement='static'>1</vcpu> + <os> + <type arch='x86_64' machine='pc'>hvm</type> + <boot dev='hd'/> + </os> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <emulator>/usr/bin/qemu-system-x86_64</emulator> + <controller type='usb' index='0'> + </controller> + <controller type='pci' index='0' model='pci-root'/> + <controller type='ide' index='0'> + </controller> + <graphics type='vnc'/> + <hostdev mode='subsystem' type='mdev' model='vfio-pci' display='on' ramfb='on'> + <source> + <address uuid='53764d0e-85a0-42b4-af5c-2046b460b1dc'/> + </source> + </hostdev> + <hostdev mode='subsystem' type='mdev' model='vfio-pci' display='on' ramfb='on'> + <source> + <address uuid='53764d0e-85a0-42b4-af5c-2046b460b1dd'/> + </source> + </hostdev> + <video> + <model type='qxl' heads='1'/> + </video> + <memballoon model='none'/> + </devices> +</domain> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 41fd032f19..e334c59eb7 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1896,6 +1896,7 @@ mymain(void) QEMU_CAPS_DEVICE_VFIO_PCI, QEMU_CAPS_VFIO_PCI_DISPLAY); DO_TEST_CAPS_LATEST("hostdev-mdev-display-ramfb"); + DO_TEST_CAPS_LATEST_PARSE_ERROR("hostdev-mdev-display-ramfb-multiple"); DO_TEST_PARSE_ERROR("hostdev-vfio-zpci-wrong-arch", QEMU_CAPS_DEVICE_VFIO_PCI); DO_TEST("hostdev-vfio-zpci", -- 2.35.1

2 1

Release of libvirt-8.3.0
by Jiri Denemark 02 May '22

02 May '22

The 8.3.0 release of both libvirt and libvirt-python is tagged and signed tarballs and source RPMs are available at https://libvirt.org/sources/ https://libvirt.org/sources/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is greatly appreciated. * Removed features * qemu: Remove support for QEMU < 3.1 In accordance with our platform support policy, the oldest supported QEMU version is now bumped from 2.11 to 3.1. * New features * qemu: Introduce support for virtio-iommu This IOMMU device can be used with both Q35 and ARM virt guests. Enjoy. Jirka

1 0

[libvirt RFCv5 00/27] multifd save restore prototype
by Claudio Fontana 30 Apr '22

30 Apr '22

This is the multifd save prototype in semi-functional state, with both save and restore minimally functional. There are still quite a few rough edges. KNOWN ISSUES: 1) this applies only to virsh save and virsh restore for now (no managed save etc). 2) error handling is not good yet, especially during resume, errors may leave behind a qemu process and such. May need some help find all of these cases 3) the compression part is demonstrative only, there needs to be more attention to compression options, and detecting the compression used to store the multifd saves. ... changes from v4: * runIO renamed to virFileDiskCopy and rethought arguments * renamed new APIs from ...ParametersFlags to ...Params * introduce the new virDomainSaveParams and virDomainRestoreParams without any additional parameters, so they can be upstreamed first. * solved the issue in the gendispatch.pl script generating code that was missing the conn parameter. --- changes from v3: * reordered series to have all helper-related change at the start * solved all reported issues from ninja test, including documentation * fixed most broken migration capabilities code (still imperfect likely) * added G_GNUC_UNUSED as needed * after multifd restore, added what I think were the missing operations: qemuProcessRefreshState(), qemuProcessStartCPUs() - most importantly, virDomainObjSave() The domain now starts running after restore without further encouragement * removed the sleep(10) from the multifd-helper changes from v2: * added ability to restore the VM from disk using multifd * fixed the multifd-helper to work in both directions, assuming the need to listen for save, and connect for restore. * fixed a large number of bugs, and probably introduced some :-) Thanks for your thoughts, Claudio Claudio Fontana (27): iohelper: introduce new struct to carry copy operation parameters iohelper: refactor copy operation as a separate function iohelper: move runIO function to virfile.c virfile: rename runIO to virFileDiskCopy virfile: change virFileDiskCopy arguments to extend beyond stdin, stdout virfile: add comment about the use of SEEK_END in virFileDiskCopy multifd-helper: new helper for parallel save/restore libvirt: introduce virDomainSaveParams public API libvirt: introduce virDomainRestoreParams public API remote: Add RPC support for the virDomainSaveParams API gendispatch: add DomainRestoreParams as requiring conn argument remote: Add RPC support for the virDomainRestoreParams API qemu: add implementation for virDomainSaveParams API qemu: add implementation for virDomainRestoreParams API libvirt: add new VIR_DOMAIN_SAVE_PARALLEL flag and parameter qemu: add stub support for VIR_DOMAIN_SAVE_PARALLEL in save qemu: add stub support for VIR_DOMAIN_SAVE_PARALLEL in restore qemu: saveimage: introduce virQEMUSaveFd qemu: wire up saveimage code with the multifd helper qemu: capabilities: add multifd to the probed migration capabilities qemu: implement qemuMigrationSrcToFilesMultiFd qemu: add parameter to qemuMigrationDstRun to skip waiting qemu: implement qemuSaveImageLoadMultiFd tools: add parallel parameter to virsh save command tools: add parallel parameter to virsh restore command docs: update refs to virDomainSaveParams and virDomainRestoreParams qemu: add migration parameter multifd-compression docs/formatsnapshot.rst | 5 +- docs/manpages/virsh.rst | 34 +- include/libvirt/libvirt-domain.h | 49 ++ po/POTFILES.in | 1 + src/driver-hypervisor.h | 14 + src/libvirt-domain.c | 99 +++- src/libvirt_private.syms | 1 + src/libvirt_public.syms | 6 + src/qemu/qemu_capabilities.c | 6 + src/qemu/qemu_capabilities.h | 4 + src/qemu/qemu_driver.c | 239 +++++++-- src/qemu/qemu_migration.c | 155 ++++-- src/qemu/qemu_migration.h | 16 +- src/qemu/qemu_migration_params.c | 71 ++- src/qemu/qemu_migration_params.h | 15 + src/qemu/qemu_process.c | 3 +- src/qemu/qemu_process.h | 5 +- src/qemu/qemu_saveimage.c | 496 ++++++++++++++---- src/qemu/qemu_saveimage.h | 49 +- src/qemu/qemu_snapshot.c | 6 +- src/remote/remote_driver.c | 2 + src/remote/remote_protocol.x | 29 +- src/remote_protocol-structs | 17 + src/rpc/gendispatch.pl | 5 +- src/util/iohelper.c | 162 +----- src/util/meson.build | 19 + src/util/multifd-helper.c | 249 +++++++++ src/util/virfile.c | 218 ++++++++ src/util/virfile.h | 2 + src/util/virthread.c | 5 + src/util/virthread.h | 1 + .../caps_4.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 1 + .../caps_4.0.0.riscv32.xml | 1 + .../caps_4.0.0.riscv64.xml | 1 + .../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 1 + .../caps_4.0.0.x86_64.xml | 1 + .../caps_4.1.0.x86_64.xml | 1 + .../caps_4.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 + .../caps_4.2.0.x86_64.xml | 1 + .../caps_5.0.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 2 + .../caps_5.0.0.riscv64.xml | 2 + .../caps_5.0.0.x86_64.xml | 2 + .../qemucapabilitiesdata/caps_5.1.0.sparc.xml | 2 + .../caps_5.1.0.x86_64.xml | 2 + .../caps_5.2.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 2 + .../caps_5.2.0.riscv64.xml | 2 + .../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 2 + .../caps_5.2.0.x86_64.xml | 2 + .../caps_6.0.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_6.0.0.s390x.xml | 2 + .../caps_6.0.0.x86_64.xml | 2 + .../caps_6.1.0.x86_64.xml | 2 + .../caps_6.2.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 2 + .../caps_6.2.0.x86_64.xml | 2 + .../caps_7.0.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_7.0.0.ppc64.xml | 2 + .../caps_7.0.0.x86_64.xml | 2 + tools/virsh-domain.c | 96 +++- 64 files changed, 1686 insertions(+), 446 deletions(-) create mode 100644 src/util/multifd-helper.c -- 2.34.1

1 27

[libvirt RFCv4 00/20] multifd save restore prototype
by Claudio Fontana 30 Apr '22

30 Apr '22

This is the multifd save prototype in semi-functional state, with both save and restore minimally functional. There are still quite a few rough edges. KNOWN ISSUES: 1) this applies only to virsh save and virsh restore for now (no managed save etc). 2) the .pl scripts to generate the headers for the new APIs do not reliably work for me, for the Restore case. I get: src/remote/remote_daemon_dispatch_stubs.h:10080:9: error: too few arguments to function ‘virDomainRestoreParametersFlags’ if (virDomainRestoreParametersFlags(params, nparams, args->flags) < 0) To work around this I had to fixup the header manually to add the conn parameter like this: ...(conn, params, nparams, args->flags) < 0) 3) error handling is not good yet, especially during resume, errors may leave behind a qemu process and such. May need some help find all of these cases... ... changes from v3: * reordered series to have all helper-related change at the start * solved all reported issues from ninja test, including documentation * fixed most broken migration capabilities code (still imperfect likely) * added G_GNUC_UNUSED as needed * after multifd restore, added what I think were the missing operations: qemuProcessRefreshState(), qemuProcessStartCPUs() - most importantly, virDomainObjSave() The domain now starts running after restore without further encouragement * removed the sleep(10) from the multifd-helper changes from v2: * added ability to restore the VM from disk using multifd * fixed the multifd-helper to work in both directions, assuming the need to listen for save, and connect for restore. * fixed a large number of bugs, and probably introduced some :-) Thanks for your thoughts, Claudio *** BLURB HERE *** Claudio Fontana (20): iohelper: introduce new struct to carry copy operation parameters iohelper: refactor copy operation as a separate function iohelper: move runIO function to a separate module runio: add arguments to extend use beyond just stdin and stdout multifd-helper: new helper for parallel save/restore libvirt: introduce virDomainSaveParametersFlags public API libvirt: introduce virDomainRestoreParametersFlags public API remote: Add RPC support for the virDomainSaveParametersFlags API remote: Add RPC support for the virDomainRestoreParametersFlags API qemu: add a stub for virDomainSaveParametersFlags API qemu: add a stub for virDomainRestoreParametersFlags API qemu: saveimage: introduce virQEMUSaveFd qemu: wire up saveimage code with the multifd helper qemu: capabilities: add multifd to the probed migration capabilities qemu: implement qemuMigrationSrcToFilesMultiFd qemu: add parameter to qemuMigrationDstRun to skip waiting qemu: implement qemuSaveImageLoadMultiFd tools: add parallel parameter to virsh save command tools: add parallel parameter to virsh restore command qemu: add migration parameter multifd-compression docs/manpages/virsh.rst | 34 +- include/libvirt/libvirt-domain.h | 49 ++ po/POTFILES.in | 2 + src/driver-hypervisor.h | 14 + src/libvirt-domain.c | 99 ++++ src/libvirt_private.syms | 1 + src/libvirt_public.syms | 6 + src/qemu/qemu_capabilities.c | 6 + src/qemu/qemu_capabilities.h | 4 + src/qemu/qemu_driver.c | 239 +++++++-- src/qemu/qemu_migration.c | 155 ++++-- src/qemu/qemu_migration.h | 16 +- src/qemu/qemu_migration_params.c | 71 ++- src/qemu/qemu_migration_params.h | 15 + src/qemu/qemu_process.c | 3 +- src/qemu/qemu_process.h | 5 +- src/qemu/qemu_saveimage.c | 496 ++++++++++++++---- src/qemu/qemu_saveimage.h | 49 +- src/qemu/qemu_snapshot.c | 6 +- src/remote/remote_driver.c | 2 + src/remote/remote_protocol.x | 29 +- src/remote_protocol-structs | 17 + src/util/iohelper.c | 150 +----- src/util/meson.build | 15 + src/util/multifd-helper.c | 250 +++++++++ src/util/runio.c | 214 ++++++++ src/util/runio.h | 38 ++ src/util/virthread.c | 5 + src/util/virthread.h | 1 + .../caps_4.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 1 + .../caps_4.0.0.riscv32.xml | 1 + .../caps_4.0.0.riscv64.xml | 1 + .../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 1 + .../caps_4.0.0.x86_64.xml | 1 + .../caps_4.1.0.x86_64.xml | 1 + .../caps_4.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 + .../caps_4.2.0.x86_64.xml | 1 + .../caps_5.0.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 2 + .../caps_5.0.0.riscv64.xml | 2 + .../caps_5.0.0.x86_64.xml | 2 + .../qemucapabilitiesdata/caps_5.1.0.sparc.xml | 2 + .../caps_5.1.0.x86_64.xml | 2 + .../caps_5.2.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 2 + .../caps_5.2.0.riscv64.xml | 2 + .../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 2 + .../caps_5.2.0.x86_64.xml | 2 + .../caps_6.0.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_6.0.0.s390x.xml | 2 + .../caps_6.0.0.x86_64.xml | 2 + .../caps_6.1.0.x86_64.xml | 2 + .../caps_6.2.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 2 + .../caps_6.2.0.x86_64.xml | 2 + .../caps_7.0.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_7.0.0.ppc64.xml | 2 + .../caps_7.0.0.x86_64.xml | 2 + tools/virsh-domain.c | 96 +++- 62 files changed, 1713 insertions(+), 427 deletions(-) create mode 100644 src/util/multifd-helper.c create mode 100644 src/util/runio.c create mode 100644 src/util/runio.h -- 2.34.1

2 40

[PATCH v2 2/5] hw/nvme: do not auto-generate eui64
by Klaus Jensen 29 Apr '22

29 Apr '22

From: Klaus Jensen <k.jensen(a)samsung.com> We cannot provide auto-generated unique or persistent namespace identifiers (EUI64, NGUID, UUID) easily. Since 6.1, namespaces have been assigned a generated EUI64 of the form "52:54:00:<namespace counter>". This is will be unique within a QEMU instance, but not globally. Revert that this is assigned automatically and immediately deprecate the compatibility parameter. Users can opt-in to this with the `eui64-default=on` device parameter or set it explicitly with `eui64=UINT64`. Cc: libvir-list(a)redhat.com Signed-off-by: Klaus Jensen <k.jensen(a)samsung.com> --- docs/about/deprecated.rst | 7 +++++++ hw/core/machine.c | 4 +++- hw/nvme/ns.c | 2 +- 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 896e5a97abbd..c65faa5ab4ad 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -356,6 +356,13 @@ contains native support for this feature and thus use of the option ROM approach is obsolete. The native SeaBIOS support can be activated by using ``-machine graphics=off``. +``-device nvme-ns,eui64-default=on|off`` (since 7.1) +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ + +In QEMU versions 6.1, 6.2 and 7.0, the ``nvme-ns`` generates an EUI-64 +identifer that is not globally unique. If an EUI-64 identifer is required, the +user must set it explicitly using the ``nvme-ns`` device parameter ``eui64``. + Block device options '''''''''''''''''''' diff --git a/hw/core/machine.c b/hw/core/machine.c index cb9bbc844d24..1e2108d95f11 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -37,7 +37,9 @@ #include "hw/virtio/virtio.h" #include "hw/virtio/virtio-pci.h" -GlobalProperty hw_compat_7_0[] = {}; +GlobalProperty hw_compat_7_0[] = { + { "nvme-ns", "eui64-default", "on"}, +}; const size_t hw_compat_7_0_len = G_N_ELEMENTS(hw_compat_7_0); GlobalProperty hw_compat_6_2[] = { diff --git a/hw/nvme/ns.c b/hw/nvme/ns.c index af6504fad2d8..06a04131f192 100644 --- a/hw/nvme/ns.c +++ b/hw/nvme/ns.c @@ -641,7 +641,7 @@ static Property nvme_ns_props[] = { DEFINE_PROP_SIZE("zoned.zrwas", NvmeNamespace, params.zrwas, 0), DEFINE_PROP_SIZE("zoned.zrwafg", NvmeNamespace, params.zrwafg, -1), DEFINE_PROP_BOOL("eui64-default", NvmeNamespace, params.eui64_default, - true), + false), DEFINE_PROP_END_OF_LIST(), }; -- 2.35.1

2 1

Entering freeze for libvirt-8.3.0
by Jiri Denemark 29 Apr '22

29 Apr '22

I have just tagged v8.3.0-rc1 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue is more visible. If you have not done so yet, please update NEWS.rst to document any significant change you made since the last release. Thanks, Jirka

1 1

Re: [RFC 00/18] vfio: Adopt iommufd
by Alex Williamson 29 Apr '22

29 Apr '22

[Cc +libvirt folks] On Thu, 14 Apr 2022 03:46:52 -0700 Yi Liu <yi.l.liu(a)intel.com> wrote: > With the introduction of iommufd[1], the linux kernel provides a generic > interface for userspace drivers to propagate their DMA mappings to kernel > for assigned devices. This series does the porting of the VFIO devices > onto the /dev/iommu uapi and let it coexist with the legacy implementation. > Other devices like vpda, vfio mdev and etc. are not considered yet. > > For vfio devices, the new interface is tied with device fd and iommufd > as the iommufd solution is device-centric. This is different from legacy > vfio which is group-centric. To support both interfaces in QEMU, this > series introduces the iommu backend concept in the form of different > container classes. The existing vfio container is named legacy container > (equivalent with legacy iommu backend in this series), while the new > iommufd based container is named as iommufd container (may also be mentioned > as iommufd backend in this series). The two backend types have their own > way to setup secure context and dma management interface. Below diagram > shows how it looks like with both BEs. > > VFIO AddressSpace/Memory > +-------+ +----------+ +-----+ +-----+ > | pci | | platform | | ap | | ccw | > +---+---+ +----+-----+ +--+--+ +--+--+ +----------------------+ > | | | | | AddressSpace | > | | | | +------------+---------+ > +---V-----------V-----------V--------V----+ / > | VFIOAddressSpace | <------------+ > | | | MemoryListener > | VFIOContainer list | > +-------+----------------------------+----+ > | | > | | > +-------V------+ +--------V----------+ > | iommufd | | vfio legacy | > | container | | container | > +-------+------+ +--------+----------+ > | | > | /dev/iommu | /dev/vfio/vfio > | /dev/vfio/devices/vfioX | /dev/vfio/$group_id > Userspace | | > ===========+============================+================================ > Kernel | device fd | > +---------------+ | group/container fd > | (BIND_IOMMUFD | | (SET_CONTAINER/SET_IOMMU) > | ATTACH_IOAS) | | device fd > | | | > | +-------V------------V-----------------+ > iommufd | | vfio | > (map/unmap | +---------+--------------------+-------+ > ioas_copy) | | | map/unmap > | | | > +------V------+ +-----V------+ +------V--------+ > | iommfd core | | device | | vfio iommu | > +-------------+ +------------+ +---------------+ > > [Secure Context setup] > - iommufd BE: uses device fd and iommufd to setup secure context > (bind_iommufd, attach_ioas) > - vfio legacy BE: uses group fd and container fd to setup secure context > (set_container, set_iommu) > [Device access] > - iommufd BE: device fd is opened through /dev/vfio/devices/vfioX > - vfio legacy BE: device fd is retrieved from group fd ioctl > [DMA Mapping flow] > - VFIOAddressSpace receives MemoryRegion add/del via MemoryListener > - VFIO populates DMA map/unmap via the container BEs > *) iommufd BE: uses iommufd > *) vfio legacy BE: uses container fd > > This series qomifies the VFIOContainer object which acts as a base class > for a container. This base class is derived into the legacy VFIO container > and the new iommufd based container. The base class implements generic code > such as code related to memory_listener and address space management whereas > the derived class implements callbacks that depend on the kernel user space > being used. > > The selection of the backend is made on a device basis using the new > iommufd option (on/off/auto). By default the iommufd backend is selected > if supported by the host and by QEMU (iommufd KConfig). This option is > currently available only for the vfio-pci device. For other types of > devices, it does not yet exist and the legacy BE is chosen by default. I've discussed this a bit with Eric, but let me propose a different command line interface. Libvirt generally likes to pass file descriptors to QEMU rather than grant it access to those files directly. This was problematic with vfio-pci because libvirt can't easily know when QEMU will want to grab another /dev/vfio/vfio container. Therefore we abandoned this approach and instead libvirt grants file permissions. However, with iommufd there's no reason that QEMU ever needs more than a single instance of /dev/iommufd and we're using per device vfio file descriptors, so it seems like a good time to revisit this. The interface I was considering would be to add an iommufd object to QEMU, so we might have a: -device iommufd[,fd=#][,id=foo] For non-libivrt usage this would have the ability to open /dev/iommufd itself if an fd is not provided. This object could be shared with other iommufd users in the VM and maybe we'd allow multiple instances for more esoteric use cases. [NB, maybe this should be a -object rather than -device since the iommufd is not a guest visible device?] The vfio-pci device might then become: -device vfio-pci[,host=DDDD:BB:DD.f][,sysfsdev=/sys/path/to/device][,fd=#][,iommufd=foo] So essentially we can specify the device via host, sysfsdev, or passing an fd to the vfio device file. When an iommufd object is specified, "foo" in the example above, each of those options would use the vfio-device access mechanism, essentially the same as iommufd=on in your example. With the fd passing option, an iommufd object would be required and necessarily use device level access. In your example, the iommufd=auto seems especially troublesome for libvirt because QEMU is going to have different locked memory requirements based on whether we're using type1 or iommufd, where the latter resolves the duplicate accounting issues. libvirt needs to know deterministically which backed is being used, which this proposal seems to provide, while at the same time bringing us more in line with fd passing. Thoughts? Thanks, Alex

5 15

[libvirt RFC v3 00/19] multifd save restore prototype
by Claudio Fontana 28 Apr '22

28 Apr '22

This is the multifd save prototype in its first semi-functional state, now with both save and restore minimally functional. Still as mentioned before, likely there are quite a few rough edges, let me know what you think about this possible option. changes from v2 are many, mainly: * added ability to restore the VM from disk using multifd * fixed the multifd-helper to work in both directions, assuming the need to listen for save, and connect for restore. * fixed a large number of bugs, and probably introduced some :-) KNOWN ISSUES: 1) this applies only to virsh save and virsh restore for now (no managed save etc). 2) the .pl scripts to generate the headers for the new APIs do not reliably work for me, for the Restore case. I get: src/remote/remote_daemon_dispatch_stubs.h:10080:9: error: too few arguments to function ‘virDomainRestoreParametersFlags’ if (virDomainRestoreParametersFlags(params, nparams, args->flags) < 0) To work around this I had to fixup the header manually to look like: ...(conn, params, nparams, args->flags) < 0) Thanks for your thoughts, Claudio Claudio Fontana (19): iohelper: introduce new struct to carry copy operation parameters iohelper: refactor copy operation as a separate function libvirt: introduce virDomainSaveParametersFlags public API libvirt: introduce virDomainRestoreParametersFlags public API remote: Add RPC support for the virDomainSaveParametersFlags API remote: Add RPC support for the virDomainRestoreParametersFlags API qemu: add a stub for virDomainSaveParametersFlags API qemu: add a stub for virDomainRestoreParametersFlags API qemu: saveimage: introduce virQEMUSaveFd iohelper: move runIO function to a separate module runio: add arguments to extend use beyond just stdin and stdout multifd-helper: new helper for parallel save/restore qemu: wire up saveimage code with the multifd helper qemu: implement qemuMigrationSrcToFilesMultiFd qemu: add parameter to qemuMigrationDstRun to skip waiting qemu: implement qemuSaveImageLoadMultiFd tools: add parallel parameter to virsh save command tools: add parallel parameter to virsh restore command qemu: add migration parameter multifd-compression docs/manpages/virsh.rst | 34 ++- include/libvirt/libvirt-domain.h | 13 + src/driver-hypervisor.h | 14 + src/libvirt-domain.c | 99 +++++++ src/libvirt_private.syms | 1 + src/libvirt_public.syms | 6 + src/qemu/qemu_capabilities.c | 5 + src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_driver.c | 233 +++++++++++---- src/qemu/qemu_migration.c | 155 ++++++---- src/qemu/qemu_migration.h | 16 +- src/qemu/qemu_migration_params.c | 71 +++-- src/qemu/qemu_migration_params.h | 15 + src/qemu/qemu_process.c | 3 +- src/qemu/qemu_process.h | 5 +- src/qemu/qemu_saveimage.c | 480 ++++++++++++++++++++++++------- src/qemu/qemu_saveimage.h | 49 +++- src/qemu/qemu_snapshot.c | 6 +- src/remote/remote_driver.c | 2 + src/remote/remote_protocol.x | 29 +- src/remote_protocol-structs | 17 ++ src/util/iohelper.c | 150 +--------- src/util/meson.build | 15 + src/util/multifd-helper.c | 250 ++++++++++++++++ src/util/runio.c | 214 ++++++++++++++ src/util/runio.h | 38 +++ src/util/virthread.c | 5 + src/util/virthread.h | 1 + tools/virsh-domain.c | 96 +++++-- 29 files changed, 1599 insertions(+), 426 deletions(-) create mode 100644 src/util/multifd-helper.c create mode 100644 src/util/runio.c create mode 100644 src/util/runio.h -- 2.34.1

3 34

[PATCH] build-aux: remove duplicated syntax check filter for 'select'
by Daniel P. Berrangé 28 Apr '22

28 Apr '22

Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- build-aux/syntax-check.mk | 3 --- 1 file changed, 3 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 66ebc3e066..6664763faf 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -1621,9 +1621,6 @@ exclude_file_name_regexp--sc_prohibit_newline_at_end_of_diagnostic = \ exclude_file_name_regexp--sc_prohibit_nonreentrant = \ ^((po|tests|examples)/|docs/.*(py|js|html\.in|.rst)|run.in$$|tools/wireshark/util/genxdrstub\.pl|tools/virt-login-shell\.c$$) -exclude_file_name_regexp--sc_prohibit_select = \ - ^build-aux/syntax-check\.mk$$ - exclude_file_name_regexp--sc_prohibit_canonicalize_file_name = \ ^(build-aux/syntax-check\.mk|tests/virfilemock\.c)$$ -- 2.35.1

2 1

[libvirt RFC] add API for parallel Saves (not for committing)
by Claudio Fontana 28 Apr '22

28 Apr '22

RFC, starting point for discussion. Sketch API changes to allow parallel Saves, and open up and implementation for QEMU to leverage multifd migration to files, with optional multifd compression. This allows to improve save times for huge VMs. The idea is to issue commands like: virsh save domain /path/savevm --parallel --parallel-connections 2 and have libvirt start a multifd migration to: /path/savevm : main migration connection /path/savevm.1 : multifd channel 1 /path/savevm.2 : multifd channel 2 Signed-off-by: Claudio Fontana <cfontana(a)suse.de> --- include/libvirt/libvirt-domain.h | 5 +++++ src/driver-hypervisor.h | 7 +++++++ src/libvirt_public.syms | 5 +++++ src/qemu/qemu_driver.c | 1 + tools/virsh-domain.c | 8 ++++++++ 5 files changed, 26 insertions(+) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index 2d5718301e..a7b9c4132d 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -1270,6 +1270,7 @@ typedef enum { VIR_DOMAIN_SAVE_RUNNING = 1 << 1, /* Favor running over paused */ VIR_DOMAIN_SAVE_PAUSED = 1 << 2, /* Favor paused over running */ VIR_DOMAIN_SAVE_RESET_NVRAM = 1 << 3, /* Re-initialize NVRAM from template */ + VIR_DOMAIN_SAVE_PARALLEL = 1 << 4, /* Parallel Save/Restore to multiple files */ } virDomainSaveRestoreFlags; int virDomainSave (virDomainPtr domain, @@ -1278,6 +1279,10 @@ int virDomainSaveFlags (virDomainPtr domain, const char *to, const char *dxml, unsigned int flags); +int virDomainSaveParametersFlags (virDomainPtr domain, + virTypedParameterPtr params, + int nparams, + unsigned int flags); int virDomainRestore (virConnectPtr conn, const char *from); int virDomainRestoreFlags (virConnectPtr conn, diff --git a/src/driver-hypervisor.h b/src/driver-hypervisor.h index 4423eb0885..a4e1d21e76 100644 --- a/src/driver-hypervisor.h +++ b/src/driver-hypervisor.h @@ -240,6 +240,12 @@ typedef int const char *dxml, unsigned int flags); +typedef int +(*virDrvDomainSaveParametersFlags)(virDomainPtr domain, + virTypedParameterPtr params, + int nparams, + unsigned int flags); + typedef int (*virDrvDomainRestore)(virConnectPtr conn, const char *from); @@ -1489,6 +1495,7 @@ struct _virHypervisorDriver { virDrvDomainGetControlInfo domainGetControlInfo; virDrvDomainSave domainSave; virDrvDomainSaveFlags domainSaveFlags; + virDrvDomainSaveParametersFlags domainSaveParametersFlags; virDrvDomainRestore domainRestore; virDrvDomainRestoreFlags domainRestoreFlags; virDrvDomainSaveImageGetXMLDesc domainSaveImageGetXMLDesc; diff --git a/src/libvirt_public.syms b/src/libvirt_public.syms index f93692c427..eb3a7afb75 100644 --- a/src/libvirt_public.syms +++ b/src/libvirt_public.syms @@ -916,4 +916,9 @@ LIBVIRT_8.0.0 { virDomainSetLaunchSecurityState; } LIBVIRT_7.8.0; +LIBVIRT_8.3.0 { + global: + virDomainSaveParametersFlags; +} LIBVIRT_8.0.0; + # .... define new API here using predicted next version number .... diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 77012eb527..249105356c 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -20826,6 +20826,7 @@ static virHypervisorDriver qemuHypervisorDriver = { .domainGetControlInfo = qemuDomainGetControlInfo, /* 0.9.3 */ .domainSave = qemuDomainSave, /* 0.2.0 */ .domainSaveFlags = qemuDomainSaveFlags, /* 0.9.4 */ + .domainSaveParametersFlags = qemuDomainSaveParametersFlags, /* 8.3.0 */ .domainRestore = qemuDomainRestore, /* 0.2.0 */ .domainRestoreFlags = qemuDomainRestoreFlags, /* 0.9.4 */ .domainSaveImageGetXMLDesc = qemuDomainSaveImageGetXMLDesc, /* 0.9.4 */ diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index d5fd8be7c3..ccded6d265 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -4164,6 +4164,14 @@ static const vshCmdOptDef opts_save[] = { .type = VSH_OT_BOOL, .help = N_("avoid file system cache when saving") }, + {.name = "parallel", + .type = VSH_OT_BOOL, + .help = N_("enable parallel save to files") + }, + {.name = "parallel-connections", + .type = VSH_OT_INT, + .help = N_("number of connections/files for parallel save") + }, {.name = "xml", .type = VSH_OT_STRING, .completer = virshCompletePathLocalExisting, -- 2.34.1

4 12

[PATCH] NEWS: Mention bump of minimum qemu version to qemu-3.1
by Peter Krempa 27 Apr '22

27 Apr '22

Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- NEWS.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 7ad8b9ec0b..c9b0ad42ed 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -15,6 +15,11 @@ v8.3.0 (unreleased) * **Removed features** + * qemu: Remove support for QEMU < 3.1 + + In accordance with our platform support policy, the oldest supported QEMU + version is now bumped from 2.11 to 3.1. + * **New features** * qemu: Introduce support for virtio-iommu -- 2.35.1

2 1