- Devel - libvirt List Archives

[libvirt] When are volumes 'detected' / refreshed
by Stefan de Konink 04 Aug '08

04 Aug '08

At what time are volumes currently detected on NetFS? I see there is some sort of storage now going on, since deleting files from NFS doesn't delete them from vol-list directly. (If this is fixed in a recent version... I'm sorry to bother) Stefan

3 2

[libvirt] fully virtualized xen guest question
by Christoph Höger 01 Aug '08

01 Aug '08

Hi, I am running XEN on an debian etch. For clustering purposes I wanted to boot fedora as virtual machine. That works (except for nfs mounts) fine using the paravortualization features. But fully virtulalized guests do not even boot, I do not get any sensefull error message, my config file looks like: <domain type='xen'> <name>werewolf</name> <os> <type>hvm</type> <loader>/usr/lib/xen-3.0.3-1/boot/hvmloader</loader> <kernel>/data/virtual/kernel/kvm1/vmlinuz-2.6.18-6-amd64</kernel> <initrd>/data/virtual/kernel/kvm1/initrd.img-2.6.18-6-amd64</initrd> <cmdline>root=/dev/hda1</cmdline> </os> <memory>524M</memory> <vcpu>1</vcpu> <devices> <emulator>/usr/bin/kvm</emulator> <disk type='file'> <source file='/tmp/werewolf.img.plb13810'/> <target dev='hda1' bus='xen'/> </disk> <interface type='bridge'> <source bridge='virbr1'/> </interface> </devices> <features> <acpi/> </features> </domain> <domain type='xen'> <name>werewolf</name> <os> <type>hvm</type> <loader>/usr/lib/xen-3.0.3-1/boot/hvmloader</loader> <kernel>/data/virtual/kernel/kvm1/vmlinuz-2.6.18-6-amd64</kernel> <initrd>/data/virtual/kernel/kvm1/initrd.img-2.6.18-6-amd64</initrd> <cmdline>root=/dev/hda1</cmdline> </os> <memory>524M</memory> <vcpu>1</vcpu> <devices> <emulator>/usr/bin/kvm</emulator> <disk type='file'> <source file='/tmp/werewolf.img.plb13810'/> <target dev='hda1' bus='xen'/> </disk> <interface type='bridge'> <source bridge='virbr1'/> </interface> </devices> <features> <acpi/> </features> </domain> all I get when tryin virsh create is: xend_post: error from xen daemon: (xend.err "Error creating domain: (0, 'Error')") Whats wrong?

2 2

[libvirt] sexpr.c: reviving an old const-correct change
by Jim Meyering 01 Aug '08

01 Aug '08

I wrote this months ago and forgot about it: diff --git a/src/xend_internal.c b/src/xend_internal.c index 880a279..1e6e875 100644 --- a/src/xend_internal.c +++ b/src/xend_internal.c @@ -2171,7 +2171,7 @@ error: */ static virDomainDefPtr xenDaemonParseSxpr(virConnectPtr conn, - struct sexpr *root, + const struct sexpr *root, int xendConfigVersion, const char *cpus) { When you pull the thread (i.e., eliminate all resulting warnings that arise from the above change), you end up with the following additional const-adding changes: (I'll squash the two into a single change set before committing) >From 1d0fd10b999ab65c555d8cb5bcfc03bc5cad9e6e Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Fri, 1 Aug 2008 15:36:31 +0200 Subject: [PATCH] xend_internal.c, sexpr.c: const-correctness --- src/sexpr.c | 2 +- src/sexpr.h | 2 +- src/xend_internal.c | 19 ++++++++++--------- 3 files changed, 12 insertions(+), 11 deletions(-) diff --git a/src/sexpr.c b/src/sexpr.c index 90c549c..b607e41 100644 --- a/src/sexpr.c +++ b/src/sexpr.c @@ -519,7 +519,7 @@ sexpr_lookup(const struct sexpr *sexpr, const char *node) * Returns true if the key was found, false otherwise */ int -sexpr_has(struct sexpr *sexpr, const char *node) +sexpr_has(const struct sexpr *sexpr, const char *node) { struct sexpr *s = sexpr_lookup_key(sexpr, node); diff --git a/src/sexpr.h b/src/sexpr.h index 0559a27..c3d038e 100644 --- a/src/sexpr.h +++ b/src/sexpr.h @@ -51,5 +51,5 @@ int sexpr_node_copy(const struct sexpr *sexpr, const char *node, char **dst); const char *sexpr_fmt_node(const struct sexpr *sexpr, const char *fmt, ...) ATTRIBUTE_FORMAT(printf,2,3); struct sexpr *sexpr_lookup(const struct sexpr *sexpr, const char *node); -int sexpr_has(struct sexpr *sexpr, const char *node); +int sexpr_has(const struct sexpr *sexpr, const char *node); #endif diff --git a/src/xend_internal.c b/src/xend_internal.c index 1e6e875..e29702a 100644 --- a/src/xend_internal.c +++ b/src/xend_internal.c @@ -1180,7 +1180,8 @@ xend_detect_config_version(virConnectPtr conn) { * Returns 0 in case of success and -1 in case of error */ static int -xenDaemonParseSxprOS(virConnectPtr xend, struct sexpr *node, +xenDaemonParseSxprOS(virConnectPtr xend, + const struct sexpr *node, virDomainDefPtr def, int hvm) { @@ -1640,11 +1641,11 @@ error: static int xenDaemonParseSxprDisks(virConnectPtr conn, virDomainDefPtr def, - struct sexpr *root, + const struct sexpr *root, int hvm, int xendConfigVersion) { - struct sexpr *cur, *node; + const struct sexpr *cur, *node; virDomainDiskDefPtr disk = NULL, prev = def->disks; for (cur = root; cur->kind == SEXPR_CONS; cur = cur->u.s.cdr) { @@ -1803,10 +1804,10 @@ error: static int xenDaemonParseSxprNets(virConnectPtr conn, virDomainDefPtr def, - struct sexpr *root) + const struct sexpr *root) { virDomainNetDefPtr net = NULL, prev = def->nets; - struct sexpr *cur, *node; + const struct sexpr *cur, *node; const char *tmp; int vif_index = 0; @@ -1964,7 +1965,7 @@ error: static int xenDaemonParseSxprUSB(virConnectPtr conn, virDomainDefPtr def, - struct sexpr *root) + const struct sexpr *root) { virDomainInputDefPtr prev = def->inputs; struct sexpr *cur, *node; @@ -2007,7 +2008,7 @@ no_memory: static int xenDaemonParseSxprGraphicsOld(virConnectPtr conn, virDomainDefPtr def, - struct sexpr *root, + const struct sexpr *root, int hvm, int xendConfigVersion) { @@ -2085,10 +2086,10 @@ no_memory: static int xenDaemonParseSxprGraphicsNew(virConnectPtr conn, virDomainDefPtr def, - struct sexpr *root) + const struct sexpr *root) { virDomainGraphicsDefPtr graphics = NULL; - struct sexpr *cur, *node; + const struct sexpr *cur, *node; const char *tmp; /* append network devices and framebuffer */ -- 1.6.0.rc1.29.gf08e3

2 2

[libvirt] [PATCH] virsh edit, virsh net-edit, virsh pool-edit
by Richard W.M. Jones 01 Aug '08

01 Aug '08

This implements 'virsh edit', 'virsh net-edit' and 'virsh pool-edit' commands. Previous discussion of this patch was in this thread: https://www.redhat.com/archives/libvir-list/2008-July/thread.html#00434 Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://et.redhat.com/~rjones/virt-df/

2 6

[libvirt] virsh.c: more const-correctness
by Jim Meyering 01 Aug '08

01 Aug '08

One good turn deserves another ;-) This also normalizes spacing around the "*" in declarations of vshControl and vshCmd pointers. Of course, this compiles with no warnings and passes "make syntax-check". >From e0db0c0eb4a62eafe1f5790de6d7f9a9d5cb84a0 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Fri, 1 Aug 2008 14:00:20 +0200 Subject: [PATCH] virsh.c: more const-correctness --- src/virsh.c | 266 +++++++++++++++++++++++++++++----------------------------- 1 files changed, 133 insertions(+), 133 deletions(-) diff --git a/src/virsh.c b/src/virsh.c index 620f103..d636301 100644 --- a/src/virsh.c +++ b/src/virsh.c @@ -182,7 +182,7 @@ typedef struct vshCmdOpt { */ typedef struct { const char *name; - int (*handler) (vshControl *, vshCmd *); /* command handler */ + int (*handler) (vshControl *, const vshCmd *); /* command handler */ vshCmdOptDef *opts; /* definition of command options */ vshCmdInfo *info; /* details about command */ } vshCmdDef; @@ -218,35 +218,35 @@ typedef struct __vshControl { static vshCmdDef commands[]; -static void vshError(vshControl * ctl, int doexit, const char *format, ...) +static void vshError(vshControl *ctl, int doexit, const char *format, ...) ATTRIBUTE_FORMAT(printf, 3, 4); -static int vshInit(vshControl * ctl); -static int vshDeinit(vshControl * ctl); -static void vshUsage(vshControl * ctl, const char *cmdname); +static int vshInit(vshControl *ctl); +static int vshDeinit(vshControl *ctl); +static void vshUsage(vshControl *ctl, const char *cmdname); static void vshOpenLogFile(vshControl *ctl); static void vshOutputLogFile(vshControl *ctl, int log_level, const char *format, va_list ap); static void vshCloseLogFile(vshControl *ctl); -static int vshParseArgv(vshControl * ctl, int argc, char **argv); +static int vshParseArgv(vshControl *ctl, int argc, char **argv); static const char *vshCmddefGetInfo(vshCmdDef * cmd, const char *info); static vshCmdDef *vshCmddefSearch(const char *cmdname); -static int vshCmddefHelp(vshControl * ctl, const char *name, int withprog); +static int vshCmddefHelp(vshControl *ctl, const char *name, int withprog); -static vshCmdOpt *vshCommandOpt(vshCmd * cmd, const char *name); -static int vshCommandOptInt(vshCmd * cmd, const char *name, int *found); -static char *vshCommandOptString(vshCmd * cmd, const char *name, +static vshCmdOpt *vshCommandOpt(const vshCmd *cmd, const char *name); +static int vshCommandOptInt(const vshCmd *cmd, const char *name, int *found); +static char *vshCommandOptString(const vshCmd *cmd, const char *name, int *found); #if 0 -static int vshCommandOptStringList(vshCmd * cmd, const char *name, char ***data); +static int vshCommandOptStringList(const vshCmd *cmd, const char *name, char ***data); #endif -static int vshCommandOptBool(vshCmd * cmd, const char *name); +static int vshCommandOptBool(const vshCmd *cmd, const char *name); #define VSH_BYID (1 << 1) #define VSH_BYUUID (1 << 2) #define VSH_BYNAME (1 << 3) -static virDomainPtr vshCommandOptDomainBy(vshControl * ctl, vshCmd * cmd, +static virDomainPtr vshCommandOptDomainBy(vshControl *ctl, const vshCmd *cmd, const char *optname, char **name, int flag); /* default is lookup by Id, Name and UUID */ @@ -254,7 +254,7 @@ static virDomainPtr vshCommandOptDomainBy(vshControl * ctl, vshCmd * cmd, vshCommandOptDomainBy(_ctl, _cmd, _optname, _name, \ VSH_BYID|VSH_BYUUID|VSH_BYNAME) -static virNetworkPtr vshCommandOptNetworkBy(vshControl * ctl, vshCmd * cmd, +static virNetworkPtr vshCommandOptNetworkBy(vshControl *ctl, const vshCmd *cmd, const char *optname, char **name, int flag); /* default is lookup by Name and UUID */ @@ -262,7 +262,7 @@ static virNetworkPtr vshCommandOptNetworkBy(vshControl * ctl, vshCmd * cmd, vshCommandOptNetworkBy(_ctl, _cmd, _optname, _name, \ VSH_BYUUID|VSH_BYNAME) -static virStoragePoolPtr vshCommandOptPoolBy(vshControl * ctl, vshCmd * cmd, +static virStoragePoolPtr vshCommandOptPoolBy(vshControl *ctl, const vshCmd *cmd, const char *optname, char **name, int flag); /* default is lookup by Name and UUID */ @@ -270,7 +270,7 @@ static virStoragePoolPtr vshCommandOptPoolBy(vshControl * ctl, vshCmd * cmd, vshCommandOptPoolBy(_ctl, _cmd, _optname, _name, \ VSH_BYUUID|VSH_BYNAME) -static virStorageVolPtr vshCommandOptVolBy(vshControl * ctl, vshCmd * cmd, +static virStorageVolPtr vshCommandOptVolBy(vshControl *ctl, const vshCmd *cmd, const char *optname, const char *pooloptname, char **name, int flag); @@ -280,9 +280,9 @@ static virStorageVolPtr vshCommandOptVolBy(vshControl * ctl, vshCmd * cmd, vshCommandOptVolBy(_ctl, _cmd, _optname, _pooloptname, _name, \ VSH_BYUUID|VSH_BYNAME) -static void vshPrintExtra(vshControl * ctl, const char *format, ...) +static void vshPrintExtra(vshControl *ctl, const char *format, ...) ATTRIBUTE_FORMAT(printf, 2, 3); -static void vshDebug(vshControl * ctl, int level, const char *format, ...) +static void vshDebug(vshControl *ctl, int level, const char *format, ...) ATTRIBUTE_FORMAT(printf, 3, 4); /* XXX: add batch support */ @@ -290,19 +290,19 @@ static void vshDebug(vshControl * ctl, int level, const char *format, ...) static const char *vshDomainStateToString(int state); static const char *vshDomainVcpuStateToString(int state); -static int vshConnectionUsability(vshControl * ctl, virConnectPtr conn, +static int vshConnectionUsability(vshControl *ctl, virConnectPtr conn, int showerror); -static void *_vshMalloc(vshControl * ctl, size_t sz, const char *filename, int line); +static void *_vshMalloc(vshControl *ctl, size_t sz, const char *filename, int line); #define vshMalloc(_ctl, _sz) _vshMalloc(_ctl, _sz, __FILE__, __LINE__) -static void *_vshCalloc(vshControl * ctl, size_t nmemb, size_t sz, const char *filename, int line); +static void *_vshCalloc(vshControl *ctl, size_t nmemb, size_t sz, const char *filename, int line); #define vshCalloc(_ctl, _nmemb, _sz) _vshCalloc(_ctl, _nmemb, _sz, __FILE__, __LINE__) -static void *_vshRealloc(vshControl * ctl, void *ptr, size_t sz, const char *filename, int line); +static void *_vshRealloc(vshControl *ctl, void *ptr, size_t sz, const char *filename, int line); #define vshRealloc(_ctl, _ptr, _sz) _vshRealloc(_ctl, _ptr, _sz, __FILE__, __LINE__) -static char *_vshStrdup(vshControl * ctl, const char *s, const char *filename, int line); +static char *_vshStrdup(vshControl *ctl, const char *s, const char *filename, int line); #define vshStrdup(_ctl, _s) _vshStrdup(_ctl, _s, __FILE__, __LINE__) @@ -346,7 +346,7 @@ static vshCmdOptDef opts_help[] = { }; static int -cmdHelp(vshControl * ctl, vshCmd * cmd) +cmdHelp(vshControl *ctl, const vshCmd *cmd) { const char *cmdname = vshCommandOptString(cmd, "command", NULL); @@ -380,7 +380,7 @@ static vshCmdOptDef opts_autostart[] = { }; static int -cmdAutostart(vshControl * ctl, vshCmd * cmd) +cmdAutostart(vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom; char *name; @@ -432,7 +432,7 @@ static vshCmdOptDef opts_connect[] = { }; static int -cmdConnect(vshControl * ctl, vshCmd * cmd) +cmdConnect(vshControl *ctl, const vshCmd *cmd) { int ro = vshCommandOptBool(cmd, "readonly"); @@ -481,7 +481,7 @@ static vshCmdOptDef opts_console[] = { #ifndef __MINGW32__ static int -cmdConsole(vshControl * ctl, vshCmd * cmd) +cmdConsole(vshControl *ctl, const vshCmd *cmd) { xmlDocPtr xml = NULL; xmlXPathObjectPtr obj = NULL; @@ -531,7 +531,7 @@ cmdConsole(vshControl * ctl, vshCmd * cmd) #else /* __MINGW32__ */ static int -cmdConsole(vshControl * ctl, vshCmd * cmd ATTRIBUTE_UNUSED) +cmdConsole(vshControl *ctl, const vshCmd *cmd ATTRIBUTE_UNUSED) { vshError (ctl, FALSE, "%s", _("console not implemented on this platform")); return FALSE; @@ -557,7 +557,7 @@ static vshCmdOptDef opts_list[] = { static int -cmdList(vshControl * ctl, vshCmd * cmd ATTRIBUTE_UNUSED) +cmdList(vshControl *ctl, const vshCmd *cmd ATTRIBUTE_UNUSED) { int inactive = vshCommandOptBool(cmd, "inactive"); int all = vshCommandOptBool(cmd, "all"); @@ -673,7 +673,7 @@ static vshCmdOptDef opts_domstate[] = { }; static int -cmdDomstate(vshControl * ctl, vshCmd * cmd) +cmdDomstate(vshControl *ctl, const vshCmd *cmd) { virDomainInfo info; virDomainPtr dom; @@ -711,7 +711,7 @@ static vshCmdOptDef opts_domblkstat[] = { }; static int -cmdDomblkstat (vshControl *ctl, vshCmd *cmd) +cmdDomblkstat (vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom; char *name, *device; @@ -768,7 +768,7 @@ static vshCmdOptDef opts_domifstat[] = { }; static int -cmdDomIfstat (vshControl *ctl, vshCmd *cmd) +cmdDomIfstat (vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom; char *name, *device; @@ -834,7 +834,7 @@ static vshCmdOptDef opts_suspend[] = { }; static int -cmdSuspend(vshControl * ctl, vshCmd * cmd) +cmdSuspend(vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom; char *name; @@ -873,7 +873,7 @@ static vshCmdOptDef opts_create[] = { }; static int -cmdCreate(vshControl * ctl, vshCmd * cmd) +cmdCreate(vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom; char *from; @@ -921,7 +921,7 @@ static vshCmdOptDef opts_define[] = { }; static int -cmdDefine(vshControl * ctl, vshCmd * cmd) +cmdDefine(vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom; char *from; @@ -969,7 +969,7 @@ static vshCmdOptDef opts_undefine[] = { }; static int -cmdUndefine(vshControl * ctl, vshCmd * cmd) +cmdUndefine(vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom; int ret = TRUE; @@ -1024,7 +1024,7 @@ static vshCmdOptDef opts_start[] = { }; static int -cmdStart(vshControl * ctl, vshCmd * cmd) +cmdStart(vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom; int ret = TRUE; @@ -1070,7 +1070,7 @@ static vshCmdOptDef opts_save[] = { }; static int -cmdSave(vshControl * ctl, vshCmd * cmd) +cmdSave(vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom; char *name; @@ -1115,7 +1115,7 @@ static vshCmdOptDef opts_schedinfo[] = { }; static int -cmdSchedinfo(vshControl * ctl, vshCmd * cmd) +cmdSchedinfo(vshControl *ctl, const vshCmd *cmd) { char *schedulertype; virDomainPtr dom; @@ -1264,7 +1264,7 @@ static vshCmdOptDef opts_restore[] = { }; static int -cmdRestore(vshControl * ctl, vshCmd * cmd) +cmdRestore(vshControl *ctl, const vshCmd *cmd) { char *from; int found; @@ -1303,7 +1303,7 @@ static vshCmdOptDef opts_dump[] = { }; static int -cmdDump(vshControl * ctl, vshCmd * cmd) +cmdDump(vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom; char *name; @@ -1347,7 +1347,7 @@ static vshCmdOptDef opts_resume[] = { }; static int -cmdResume(vshControl * ctl, vshCmd * cmd) +cmdResume(vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom; int ret = TRUE; @@ -1386,7 +1386,7 @@ static vshCmdOptDef opts_shutdown[] = { }; static int -cmdShutdown(vshControl * ctl, vshCmd * cmd) +cmdShutdown(vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom; int ret = TRUE; @@ -1425,7 +1425,7 @@ static vshCmdOptDef opts_reboot[] = { }; static int -cmdReboot(vshControl * ctl, vshCmd * cmd) +cmdReboot(vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom; int ret = TRUE; @@ -1464,7 +1464,7 @@ static vshCmdOptDef opts_destroy[] = { }; static int -cmdDestroy(vshControl * ctl, vshCmd * cmd) +cmdDestroy(vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom; int ret = TRUE; @@ -1503,7 +1503,7 @@ static vshCmdOptDef opts_dominfo[] = { }; static int -cmdDominfo(vshControl * ctl, vshCmd * cmd) +cmdDominfo(vshControl *ctl, const vshCmd *cmd) { virDomainInfo info; virDomainPtr dom; @@ -1585,7 +1585,7 @@ static vshCmdOptDef opts_freecell[] = { }; static int -cmdFreecell(vshControl * ctl, vshCmd * cmd) +cmdFreecell(vshControl *ctl, const vshCmd *cmd) { int ret; int cell, cell_given; @@ -1627,7 +1627,7 @@ static vshCmdOptDef opts_vcpuinfo[] = { }; static int -cmdVcpuinfo(vshControl * ctl, vshCmd * cmd) +cmdVcpuinfo(vshControl *ctl, const vshCmd *cmd) { virDomainInfo info; virDomainPtr dom; @@ -1716,7 +1716,7 @@ static vshCmdOptDef opts_vcpupin[] = { }; static int -cmdVcpupin(vshControl * ctl, vshCmd * cmd) +cmdVcpupin(vshControl *ctl, const vshCmd *cmd) { virDomainInfo info; virDomainPtr dom; @@ -1849,7 +1849,7 @@ static vshCmdOptDef opts_setvcpus[] = { }; static int -cmdSetvcpus(vshControl * ctl, vshCmd * cmd) +cmdSetvcpus(vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom; int count; @@ -1906,7 +1906,7 @@ static vshCmdOptDef opts_setmem[] = { }; static int -cmdSetmem(vshControl * ctl, vshCmd * cmd) +cmdSetmem(vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom; virDomainInfo info; @@ -1963,7 +1963,7 @@ static vshCmdOptDef opts_setmaxmem[] = { }; static int -cmdSetmaxmem(vshControl * ctl, vshCmd * cmd) +cmdSetmaxmem(vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom; virDomainInfo info; @@ -2017,7 +2017,7 @@ static vshCmdInfo info_nodeinfo[] = { }; static int -cmdNodeinfo(vshControl * ctl, vshCmd * cmd ATTRIBUTE_UNUSED) +cmdNodeinfo(vshControl *ctl, const vshCmd *cmd ATTRIBUTE_UNUSED) { virNodeInfo info; @@ -2051,7 +2051,7 @@ static vshCmdInfo info_capabilities[] = { }; static int -cmdCapabilities (vshControl * ctl, vshCmd * cmd ATTRIBUTE_UNUSED) +cmdCapabilities (vshControl *ctl, const vshCmd *cmd ATTRIBUTE_UNUSED) { char *caps; @@ -2084,7 +2084,7 @@ static vshCmdOptDef opts_dumpxml[] = { }; static int -cmdDumpXML(vshControl * ctl, vshCmd * cmd) +cmdDumpXML(vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom; int ret = TRUE; @@ -2123,7 +2123,7 @@ static vshCmdOptDef opts_domname[] = { }; static int -cmdDomname(vshControl * ctl, vshCmd * cmd) +cmdDomname(vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom; @@ -2153,7 +2153,7 @@ static vshCmdOptDef opts_domid[] = { }; static int -cmdDomid(vshControl * ctl, vshCmd * cmd) +cmdDomid(vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom; unsigned int id; @@ -2188,7 +2188,7 @@ static vshCmdOptDef opts_domuuid[] = { }; static int -cmdDomuuid(vshControl * ctl, vshCmd * cmd) +cmdDomuuid(vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom; char uuid[VIR_UUID_STRING_BUFLEN]; @@ -2227,7 +2227,7 @@ static vshCmdOptDef opts_migrate[] = { }; static int -cmdMigrate (vshControl *ctl, vshCmd *cmd) +cmdMigrate (vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom = NULL; const char *desturi; @@ -2289,7 +2289,7 @@ static vshCmdOptDef opts_network_autostart[] = { }; static int -cmdNetworkAutostart(vshControl * ctl, vshCmd * cmd) +cmdNetworkAutostart(vshControl *ctl, const vshCmd *cmd) { virNetworkPtr network; char *name; @@ -2338,7 +2338,7 @@ static vshCmdOptDef opts_network_create[] = { }; static int -cmdNetworkCreate(vshControl * ctl, vshCmd * cmd) +cmdNetworkCreate(vshControl *ctl, const vshCmd *cmd) { virNetworkPtr network; char *from; @@ -2386,7 +2386,7 @@ static vshCmdOptDef opts_network_define[] = { }; static int -cmdNetworkDefine(vshControl * ctl, vshCmd * cmd) +cmdNetworkDefine(vshControl *ctl, const vshCmd *cmd) { virNetworkPtr network; char *from; @@ -2434,7 +2434,7 @@ static vshCmdOptDef opts_network_destroy[] = { }; static int -cmdNetworkDestroy(vshControl * ctl, vshCmd * cmd) +cmdNetworkDestroy(vshControl *ctl, const vshCmd *cmd) { virNetworkPtr network; int ret = TRUE; @@ -2474,7 +2474,7 @@ static vshCmdOptDef opts_network_dumpxml[] = { }; static int -cmdNetworkDumpXML(vshControl * ctl, vshCmd * cmd) +cmdNetworkDumpXML(vshControl *ctl, const vshCmd *cmd) { virNetworkPtr network; int ret = TRUE; @@ -2516,7 +2516,7 @@ static vshCmdOptDef opts_network_list[] = { }; static int -cmdNetworkList(vshControl * ctl, vshCmd * cmd ATTRIBUTE_UNUSED) +cmdNetworkList(vshControl *ctl, const vshCmd *cmd ATTRIBUTE_UNUSED) { int inactive = vshCommandOptBool(cmd, "inactive"); int all = vshCommandOptBool(cmd, "all"); @@ -2638,7 +2638,7 @@ static vshCmdOptDef opts_network_name[] = { }; static int -cmdNetworkName(vshControl * ctl, vshCmd * cmd) +cmdNetworkName(vshControl *ctl, const vshCmd *cmd) { virNetworkPtr network; @@ -2670,7 +2670,7 @@ static vshCmdOptDef opts_network_start[] = { }; static int -cmdNetworkStart(vshControl * ctl, vshCmd * cmd) +cmdNetworkStart(vshControl *ctl, const vshCmd *cmd) { virNetworkPtr network; int ret = TRUE; @@ -2709,7 +2709,7 @@ static vshCmdOptDef opts_network_undefine[] = { }; static int -cmdNetworkUndefine(vshControl * ctl, vshCmd * cmd) +cmdNetworkUndefine(vshControl *ctl, const vshCmd *cmd) { virNetworkPtr network; int ret = TRUE; @@ -2747,7 +2747,7 @@ static vshCmdOptDef opts_network_uuid[] = { }; static int -cmdNetworkUuid(vshControl * ctl, vshCmd * cmd) +cmdNetworkUuid(vshControl *ctl, const vshCmd *cmd) { virNetworkPtr network; char uuid[VIR_UUID_STRING_BUFLEN]; @@ -2797,7 +2797,7 @@ static vshCmdOptDef opts_pool_autostart[] = { }; static int -cmdPoolAutostart(vshControl * ctl, vshCmd * cmd) +cmdPoolAutostart(vshControl *ctl, const vshCmd *cmd) { virStoragePoolPtr pool; char *name; @@ -2846,7 +2846,7 @@ static vshCmdOptDef opts_pool_create[] = { }; static int -cmdPoolCreate(vshControl * ctl, vshCmd * cmd) +cmdPoolCreate(vshControl *ctl, const vshCmd *cmd) { virStoragePoolPtr pool; char *from; @@ -2899,7 +2899,7 @@ static vshCmdOptDef opts_pool_create_as[] = { static int -cmdPoolCreateAs(vshControl * ctl, vshCmd * cmd) +cmdPoolCreateAs(vshControl *ctl, const vshCmd *cmd) { virStoragePoolPtr pool; int found; @@ -2984,7 +2984,7 @@ static vshCmdOptDef opts_pool_define[] = { }; static int -cmdPoolDefine(vshControl * ctl, vshCmd * cmd) +cmdPoolDefine(vshControl *ctl, const vshCmd *cmd) { virStoragePoolPtr pool; char *from; @@ -3038,7 +3038,7 @@ static vshCmdOptDef opts_pool_define_as[] = { static int -cmdPoolDefineAs(vshControl * ctl, vshCmd * cmd) +cmdPoolDefineAs(vshControl *ctl, const vshCmd *cmd) { virStoragePoolPtr pool; int found; @@ -3122,7 +3122,7 @@ static vshCmdOptDef opts_pool_build[] = { }; static int -cmdPoolBuild(vshControl * ctl, vshCmd * cmd) +cmdPoolBuild(vshControl *ctl, const vshCmd *cmd) { virStoragePoolPtr pool; int ret = TRUE; @@ -3162,7 +3162,7 @@ static vshCmdOptDef opts_pool_destroy[] = { }; static int -cmdPoolDestroy(vshControl * ctl, vshCmd * cmd) +cmdPoolDestroy(vshControl *ctl, const vshCmd *cmd) { virStoragePoolPtr pool; int ret = TRUE; @@ -3202,7 +3202,7 @@ static vshCmdOptDef opts_pool_delete[] = { }; static int -cmdPoolDelete(vshControl * ctl, vshCmd * cmd) +cmdPoolDelete(vshControl *ctl, const vshCmd *cmd) { virStoragePoolPtr pool; int ret = TRUE; @@ -3242,7 +3242,7 @@ static vshCmdOptDef opts_pool_refresh[] = { }; static int -cmdPoolRefresh(vshControl * ctl, vshCmd * cmd) +cmdPoolRefresh(vshControl *ctl, const vshCmd *cmd) { virStoragePoolPtr pool; int ret = TRUE; @@ -3282,7 +3282,7 @@ static vshCmdOptDef opts_pool_dumpxml[] = { }; static int -cmdPoolDumpXML(vshControl * ctl, vshCmd * cmd) +cmdPoolDumpXML(vshControl *ctl, const vshCmd *cmd) { virStoragePoolPtr pool; int ret = TRUE; @@ -3324,7 +3324,7 @@ static vshCmdOptDef opts_pool_list[] = { }; static int -cmdPoolList(vshControl * ctl, vshCmd * cmd ATTRIBUTE_UNUSED) +cmdPoolList(vshControl *ctl, const vshCmd *cmd ATTRIBUTE_UNUSED) { int inactive = vshCommandOptBool(cmd, "inactive"); int all = vshCommandOptBool(cmd, "all"); @@ -3467,7 +3467,7 @@ static vshCmdOptDef opts_pool_info[] = { }; static int -cmdPoolInfo(vshControl * ctl, vshCmd * cmd) +cmdPoolInfo(vshControl *ctl, const vshCmd *cmd) { virStoragePoolInfo info; virStoragePoolPtr pool; @@ -3542,7 +3542,7 @@ static vshCmdOptDef opts_pool_name[] = { }; static int -cmdPoolName(vshControl * ctl, vshCmd * cmd) +cmdPoolName(vshControl *ctl, const vshCmd *cmd) { virStoragePoolPtr pool; @@ -3574,7 +3574,7 @@ static vshCmdOptDef opts_pool_start[] = { }; static int -cmdPoolStart(vshControl * ctl, vshCmd * cmd) +cmdPoolStart(vshControl *ctl, const vshCmd *cmd) { virStoragePoolPtr pool; int ret = TRUE; @@ -3645,7 +3645,7 @@ static int cmdVolSize(const char *data, unsigned long long *val) } static int -cmdVolCreateAs(vshControl * ctl, vshCmd * cmd) +cmdVolCreateAs(vshControl *ctl, const vshCmd *cmd) { virStoragePoolPtr pool; virStorageVolPtr vol; @@ -3735,7 +3735,7 @@ static vshCmdOptDef opts_pool_undefine[] = { }; static int -cmdPoolUndefine(vshControl * ctl, vshCmd * cmd) +cmdPoolUndefine(vshControl *ctl, const vshCmd *cmd) { virStoragePoolPtr pool; int ret = TRUE; @@ -3773,7 +3773,7 @@ static vshCmdOptDef opts_pool_uuid[] = { }; static int -cmdPoolUuid(vshControl * ctl, vshCmd * cmd) +cmdPoolUuid(vshControl *ctl, const vshCmd *cmd) { virStoragePoolPtr pool; char uuid[VIR_UUID_STRING_BUFLEN]; @@ -3813,7 +3813,7 @@ static vshCmdOptDef opts_vol_create[] = { }; static int -cmdVolCreate(vshControl * ctl, vshCmd * cmd) +cmdVolCreate(vshControl *ctl, const vshCmd *cmd) { virStoragePoolPtr pool; virStorageVolPtr vol; @@ -3872,7 +3872,7 @@ static vshCmdOptDef opts_vol_delete[] = { }; static int -cmdVolDelete(vshControl * ctl, vshCmd * cmd) +cmdVolDelete(vshControl *ctl, const vshCmd *cmd) { virStorageVolPtr vol; int ret = TRUE; @@ -3914,7 +3914,7 @@ static vshCmdOptDef opts_vol_info[] = { }; static int -cmdVolInfo(vshControl * ctl, vshCmd * cmd) +cmdVolInfo(vshControl *ctl, const vshCmd *cmd) { virStorageVolInfo info; virStorageVolPtr vol; @@ -3966,7 +3966,7 @@ static vshCmdOptDef opts_vol_dumpxml[] = { }; static int -cmdVolDumpXML(vshControl * ctl, vshCmd * cmd) +cmdVolDumpXML(vshControl *ctl, const vshCmd *cmd) { virStorageVolPtr vol; int ret = TRUE; @@ -4007,7 +4007,7 @@ static vshCmdOptDef opts_vol_list[] = { }; static int -cmdVolList(vshControl * ctl, vshCmd * cmd ATTRIBUTE_UNUSED) +cmdVolList(vshControl *ctl, const vshCmd *cmd ATTRIBUTE_UNUSED) { virStoragePoolPtr pool; int maxactive = 0, i; @@ -4085,7 +4085,7 @@ static vshCmdOptDef opts_vol_name[] = { }; static int -cmdVolName(vshControl * ctl, vshCmd * cmd) +cmdVolName(vshControl *ctl, const vshCmd *cmd) { virStorageVolPtr vol; @@ -4118,7 +4118,7 @@ static vshCmdOptDef opts_vol_key[] = { }; static int -cmdVolKey(vshControl * ctl, vshCmd * cmd) +cmdVolKey(vshControl *ctl, const vshCmd *cmd) { virStorageVolPtr vol; @@ -4152,7 +4152,7 @@ static vshCmdOptDef opts_vol_path[] = { }; static int -cmdVolPath(vshControl * ctl, vshCmd * cmd) +cmdVolPath(vshControl *ctl, const vshCmd *cmd) { virStorageVolPtr vol; @@ -4185,7 +4185,7 @@ static vshCmdInfo info_version[] = { static int -cmdVersion(vshControl * ctl, vshCmd * cmd ATTRIBUTE_UNUSED) +cmdVersion(vshControl *ctl, const vshCmd *cmd ATTRIBUTE_UNUSED) { unsigned long hvVersion; const char *hvType; @@ -4263,7 +4263,7 @@ static vshCmdInfo info_hostname[] = { }; static int -cmdHostname (vshControl *ctl, vshCmd *cmd ATTRIBUTE_UNUSED) +cmdHostname (vshControl *ctl, const vshCmd *cmd ATTRIBUTE_UNUSED) { char *hostname; @@ -4292,7 +4292,7 @@ static vshCmdInfo info_uri[] = { }; static int -cmdURI (vshControl *ctl, vshCmd *cmd ATTRIBUTE_UNUSED) +cmdURI (vshControl *ctl, const vshCmd *cmd ATTRIBUTE_UNUSED) { char *uri; @@ -4327,7 +4327,7 @@ static vshCmdOptDef opts_vncdisplay[] = { }; static int -cmdVNCDisplay(vshControl * ctl, vshCmd * cmd) +cmdVNCDisplay(vshControl *ctl, const vshCmd *cmd) { xmlDocPtr xml = NULL; xmlXPathObjectPtr obj = NULL; @@ -4403,7 +4403,7 @@ static vshCmdOptDef opts_ttyconsole[] = { }; static int -cmdTTYConsole(vshControl * ctl, vshCmd * cmd) +cmdTTYConsole(vshControl *ctl, const vshCmd *cmd) { xmlDocPtr xml = NULL; xmlXPathObjectPtr obj = NULL; @@ -4465,7 +4465,7 @@ static vshCmdOptDef opts_attach_device[] = { }; static int -cmdAttachDevice(vshControl * ctl, vshCmd * cmd) +cmdAttachDevice(vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom; char *from; @@ -4522,7 +4522,7 @@ static vshCmdOptDef opts_detach_device[] = { }; static int -cmdDetachDevice(vshControl * ctl, vshCmd * cmd) +cmdDetachDevice(vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom; char *from; @@ -4583,7 +4583,7 @@ static vshCmdOptDef opts_attach_interface[] = { }; static int -cmdAttachInterface(vshControl * ctl, vshCmd * cmd) +cmdAttachInterface(vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom = NULL; char *mac, *target, *script, *type, *source; @@ -4694,7 +4694,7 @@ static vshCmdOptDef opts_detach_interface[] = { }; static int -cmdDetachInterface(vshControl * ctl, vshCmd * cmd) +cmdDetachInterface(vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom = NULL; xmlDocPtr xml = NULL; @@ -4817,7 +4817,7 @@ static vshCmdOptDef opts_attach_disk[] = { }; static int -cmdAttachDisk(vshControl * ctl, vshCmd * cmd) +cmdAttachDisk(vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom = NULL; char *source, *target, *driver, *subdriver, *type, *mode; @@ -4975,7 +4975,7 @@ static vshCmdOptDef opts_detach_disk[] = { }; static int -cmdDetachDisk(vshControl * ctl, vshCmd * cmd) +cmdDetachDisk(vshControl *ctl, const vshCmd *cmd) { xmlDocPtr xml = NULL; xmlXPathObjectPtr obj=NULL; @@ -5079,7 +5079,7 @@ static vshCmdInfo info_quit[] = { }; static int -cmdQuit(vshControl * ctl, vshCmd * cmd ATTRIBUTE_UNUSED) +cmdQuit(vshControl *ctl, const vshCmd *cmd ATTRIBUTE_UNUSED) { ctl->imode = FALSE; return TRUE; @@ -5226,7 +5226,7 @@ vshCmddefGetData(vshCmdDef * cmd, int data_ct) * Checks for required options */ static int -vshCommandCheckOpts(vshControl * ctl, vshCmd * cmd) +vshCommandCheckOpts(vshControl *ctl, vshCmd *cmd) { vshCmdDef *def = cmd->def; vshCmdOptDef *d; @@ -5268,7 +5268,7 @@ vshCmddefSearch(const char *cmdname) } static int -vshCmddefHelp(vshControl * ctl, const char *cmdname, int withprog) +vshCmddefHelp(vshControl *ctl, const char *cmdname, int withprog) { vshCmdDef *def = vshCmddefSearch(cmdname); @@ -5337,7 +5337,7 @@ vshCommandOptFree(vshCmdOpt * arg) } static void -vshCommandFree(vshCmd * cmd) +vshCommandFree(vshCmd *cmd) { vshCmd *c = cmd; @@ -5356,7 +5356,7 @@ vshCommandFree(vshCmd * cmd) * Returns option by name */ static vshCmdOpt * -vshCommandOpt(vshCmd * cmd, const char *name) +vshCommandOpt(const vshCmd *cmd, const char *name) { vshCmdOpt *opt = cmd->opts; @@ -5372,7 +5372,7 @@ vshCommandOpt(vshCmd * cmd, const char *name) * Returns option as INT */ static int -vshCommandOptInt(vshCmd * cmd, const char *name, int *found) +vshCommandOptInt(const vshCmd *cmd, const char *name, int *found) { vshCmdOpt *arg = vshCommandOpt(cmd, name); int res = 0, num_found = FALSE; @@ -5394,7 +5394,7 @@ vshCommandOptInt(vshCmd * cmd, const char *name, int *found) * Returns option as STRING */ static char * -vshCommandOptString(vshCmd * cmd, const char *name, int *found) +vshCommandOptString(const vshCmd *cmd, const char *name, int *found) { vshCmdOpt *arg = vshCommandOpt(cmd, name); @@ -5406,7 +5406,7 @@ vshCommandOptString(vshCmd * cmd, const char *name, int *found) #if 0 static int -vshCommandOptStringList(vshCmd * cmd, const char *name, char ***data) +vshCommandOptStringList(const vshCmd *cmd, const char *name, char ***data) { vshCmdOpt *arg = cmd->opts; char **val = NULL; @@ -5434,14 +5434,14 @@ vshCommandOptStringList(vshCmd * cmd, const char *name, char ***data) * Returns TRUE/FALSE if the option exists */ static int -vshCommandOptBool(vshCmd * cmd, const char *name) +vshCommandOptBool(const vshCmd *cmd, const char *name) { return vshCommandOpt(cmd, name) ? TRUE : FALSE; } static virDomainPtr -vshCommandOptDomainBy(vshControl * ctl, vshCmd * cmd, const char *optname, +vshCommandOptDomainBy(vshControl *ctl, const vshCmd *cmd, const char *optname, char **name, int flag) { virDomainPtr dom = NULL; @@ -5487,7 +5487,7 @@ vshCommandOptDomainBy(vshControl * ctl, vshCmd * cmd, const char *optname, } static virNetworkPtr -vshCommandOptNetworkBy(vshControl * ctl, vshCmd * cmd, const char *optname, +vshCommandOptNetworkBy(vshControl *ctl, const vshCmd *cmd, const char *optname, char **name, int flag) { virNetworkPtr network = NULL; @@ -5524,7 +5524,7 @@ vshCommandOptNetworkBy(vshControl * ctl, vshCmd * cmd, const char *optname, } static virStoragePoolPtr -vshCommandOptPoolBy(vshControl * ctl, vshCmd * cmd, const char *optname, +vshCommandOptPoolBy(vshControl *ctl, const vshCmd *cmd, const char *optname, char **name, int flag) { virStoragePoolPtr pool = NULL; @@ -5561,7 +5561,7 @@ vshCommandOptPoolBy(vshControl * ctl, vshCmd * cmd, const char *optname, } static virStorageVolPtr -vshCommandOptVolBy(vshControl * ctl, vshCmd * cmd, +vshCommandOptVolBy(vshControl *ctl, const vshCmd *cmd, const char *optname, const char *pooloptname, char **name, int flag) @@ -5620,7 +5620,7 @@ vshCommandOptVolBy(vshControl * ctl, vshCmd * cmd, * Executes command(s) and returns return code from last command */ static int -vshCommandRun(vshControl * ctl, vshCmd * cmd) +vshCommandRun(vshControl *ctl, const vshCmd *cmd) { int ret = TRUE; @@ -5659,7 +5659,7 @@ vshCommandRun(vshControl * ctl, vshCmd * cmd) #define VSH_TK_END 3 static int -vshCommandGetToken(vshControl * ctl, char *str, char **end, char **res) +vshCommandGetToken(vshControl *ctl, char *str, char **end, char **res) { int tk = VSH_TK_NONE; int quote = FALSE; @@ -5730,7 +5730,7 @@ vshCommandGetToken(vshControl * ctl, char *str, char **end, char **res) } static int -vshCommandParse(vshControl * ctl, char *cmdstr) +vshCommandParse(vshControl *ctl, char *cmdstr) { char *str; char *tkdata = NULL; @@ -5915,7 +5915,7 @@ vshDomainVcpuStateToString(int state) } static int -vshConnectionUsability(vshControl * ctl, virConnectPtr conn, int showerror) +vshConnectionUsability(vshControl *ctl, virConnectPtr conn, int showerror) { /* TODO: use something like virConnectionState() to * check usability of the connection @@ -5929,7 +5929,7 @@ vshConnectionUsability(vshControl * ctl, virConnectPtr conn, int showerror) } static void -vshDebug(vshControl * ctl, int level, const char *format, ...) +vshDebug(vshControl *ctl, int level, const char *format, ...) { va_list ap; @@ -5946,7 +5946,7 @@ vshDebug(vshControl * ctl, int level, const char *format, ...) } static void -vshPrintExtra(vshControl * ctl, const char *format, ...) +vshPrintExtra(vshControl *ctl, const char *format, ...) { va_list ap; @@ -5960,7 +5960,7 @@ vshPrintExtra(vshControl * ctl, const char *format, ...) static void -vshError(vshControl * ctl, int doexit, const char *format, ...) +vshError(vshControl *ctl, int doexit, const char *format, ...) { va_list ap; @@ -5987,7 +5987,7 @@ vshError(vshControl * ctl, int doexit, const char *format, ...) } static void * -_vshMalloc(vshControl * ctl, size_t size, const char *filename, int line) +_vshMalloc(vshControl *ctl, size_t size, const char *filename, int line) { void *x; @@ -5999,7 +5999,7 @@ _vshMalloc(vshControl * ctl, size_t size, const char *filename, int line) } static void * -_vshCalloc(vshControl * ctl, size_t nmemb, size_t size, const char *filename, int line) +_vshCalloc(vshControl *ctl, size_t nmemb, size_t size, const char *filename, int line) { void *x; @@ -6011,7 +6011,7 @@ _vshCalloc(vshControl * ctl, size_t nmemb, size_t size, const char *filename, in } static void * -_vshRealloc(vshControl * ctl, void *ptr, size_t size, const char *filename, int line) +_vshRealloc(vshControl *ctl, void *ptr, size_t size, const char *filename, int line) { void *x; @@ -6024,7 +6024,7 @@ _vshRealloc(vshControl * ctl, void *ptr, size_t size, const char *filename, int } static char * -_vshStrdup(vshControl * ctl, const char *s, const char *filename, int line) +_vshStrdup(vshControl *ctl, const char *s, const char *filename, int line) { char *x; @@ -6041,7 +6041,7 @@ _vshStrdup(vshControl * ctl, const char *s, const char *filename, int line) * Initialize connection. */ static int -vshInit(vshControl * ctl) +vshInit(vshControl *ctl) { if (ctl->conn) return FALSE; @@ -6357,7 +6357,7 @@ vshReadline (vshControl *ctl, const char *prompt) * Deinitialize virsh */ static int -vshDeinit(vshControl * ctl) +vshDeinit(vshControl *ctl) { vshCloseLogFile(ctl); free(ctl->name); @@ -6377,7 +6377,7 @@ vshDeinit(vshControl * ctl) * Print usage */ static void -vshUsage(vshControl * ctl, const char *cmdname) +vshUsage(vshControl *ctl, const char *cmdname) { vshCmdDef *cmd; @@ -6413,7 +6413,7 @@ vshUsage(vshControl * ctl, const char *cmdname) * */ static int -vshParseArgv(vshControl * ctl, int argc, char **argv) +vshParseArgv(vshControl *ctl, int argc, char **argv) { char *last = NULL; int i, end = 0, help = 0; -- 1.6.0.rc1.29.gf08e3

2 2

[libvirt] PATCH: Support container XML enhancements
by Daniel P. Berrange 01 Aug '08

01 Aug '08

This is something I previously submitted as part of one of the LXC patches, but I figure it makes sense on its own, since OpenVZ needs this now too. This adds two new XML elements to the domain XML format: - An <init> block within <os> allowing specification of the path for a binary to run when starting the container - aka 'init' by any other name. First we also specify that all containers will use an OS type of 'exe' - as in executable - the container equivalent of 'hvm' <os> <type>exe</type> <init>/sbin/init</init> </os> - An <filesystem> element for specifying how the container's filesystem is to be provided. This can actually be useful for full-machine virt too such as KVM which have host filesystem pass-through. There are various ways to configure it: eg to use '/some/directory' as the root filesystem for a container <filesystem type='mount'> <source dir='/some/directory'/> <target dir='/'/> </filesystem> eg to use a template called 'fedora9web' as the root filesystem for a container <filesystem type='template'> <source name='fedora9web'/> <target dir='/'/> </filesystem> eg to use a file containing a filesystem as the root filesystem <filesystem type='file'> <source file='/some/file.img'/> <target dir='/'/> </filesystem> eg to use a disk partition or other block device (eg LVM) containing a filesystem as the root filesystem <filesystem type='block'> <source dev='/dev/VolGroup00/Fedora9Web'/> <target dir='/'/> </filesystem> If setting the root filesystem, the target path will be '/', some container based virt allows the host OS root filesystem to be used in the guest, and merely specify additive mounts at specific locations, eg to override just /home within a container <filesystem type='mount'> <source dir='/some/directory'/> <target dir='/home'/> </filesystem> I believe this should satisfy all the OpenVZ, LXC and Linux-VServer drivers' requirements around filesystems Daniel diff -r 5614da5fe9ef src/domain_conf.c --- a/src/domain_conf.c Fri Jul 25 15:38:46 2008 +0100 +++ b/src/domain_conf.c Tue Jul 29 16:03:38 2008 +0100 @@ -86,6 +86,12 @@ "virtio", "xen") +VIR_ENUM_IMPL(virDomainFS, VIR_DOMAIN_FS_TYPE_LAST, + "mount", + "block", + "file", + "template") + VIR_ENUM_IMPL(virDomainNet, VIR_DOMAIN_NET_TYPE_LAST, "user", "ethernet", @@ -234,6 +240,18 @@ VIR_FREE(def->driverType); virDomainDiskDefFree(def->next); + VIR_FREE(def); +} + +void virDomainFSDefFree(virDomainFSDefPtr def) +{ + if (!def) + return; + + VIR_FREE(def->src); + VIR_FREE(def->dst); + + virDomainFSDefFree(def->next); VIR_FREE(def); } @@ -345,6 +363,7 @@ virDomainGraphicsDefFree(def->graphics); virDomainInputDefFree(def->inputs); virDomainDiskDefFree(def->disks); + virDomainFSDefFree(def->fss); virDomainNetDefFree(def->nets); virDomainChrDefFree(def->serials); virDomainChrDefFree(def->parallels); @@ -355,6 +374,7 @@ VIR_FREE(def->os.type); VIR_FREE(def->os.arch); VIR_FREE(def->os.machine); + VIR_FREE(def->os.init); VIR_FREE(def->os.kernel); VIR_FREE(def->os.initrd); VIR_FREE(def->os.cmdline); @@ -620,6 +640,89 @@ error: virDomainDiskDefFree(def); + def = NULL; + goto cleanup; +} + + +/* Parse the XML definition for a disk + * @param node XML nodeset to parse for disk definition + */ +static virDomainFSDefPtr +virDomainFSDefParseXML(virConnectPtr conn, + xmlNodePtr node) { + virDomainFSDefPtr def; + xmlNodePtr cur; + char *type = NULL; + char *source = NULL; + char *target = NULL; + + if (VIR_ALLOC(def) < 0) { + virDomainReportError(conn, VIR_ERR_NO_MEMORY, NULL); + return NULL; + } + + type = virXMLPropString(node, "type"); + if (type) { + if ((def->type = virDomainFSTypeFromString(type)) < 0) { + virDomainReportError(conn, VIR_ERR_INTERNAL_ERROR, + _("unknown filesystem type '%s'"), type); + goto error; + } + } else { + def->type = VIR_DOMAIN_FS_TYPE_MOUNT; + } + + cur = node->children; + while (cur != NULL) { + if (cur->type == XML_ELEMENT_NODE) { + if ((source == NULL) && + (xmlStrEqual(cur->name, BAD_CAST "source"))) { + + if (def->type == VIR_DOMAIN_FS_TYPE_MOUNT) + source = virXMLPropString(cur, "dir"); + else if (def->type == VIR_DOMAIN_FS_TYPE_FILE) + source = virXMLPropString(cur, "file"); + else if (def->type == VIR_DOMAIN_FS_TYPE_BLOCK) + source = virXMLPropString(cur, "dev"); + else if (def->type == VIR_DOMAIN_FS_TYPE_TEMPLATE) + source = virXMLPropString(cur, "name"); + } else if ((target == NULL) && + (xmlStrEqual(cur->name, BAD_CAST "target"))) { + target = virXMLPropString(cur, "dir"); + } else if (xmlStrEqual(cur->name, BAD_CAST "readonly")) { + def->readonly = 1; + } + } + cur = cur->next; + } + + if (source == NULL) { + virDomainReportError(conn, VIR_ERR_NO_SOURCE, + target ? "%s" : NULL, target); + goto error; + } + + if (target == NULL) { + virDomainReportError(conn, VIR_ERR_NO_TARGET, + source ? "%s" : NULL, source); + goto error; + } + + def->src = source; + source = NULL; + def->dst = target; + target = NULL; + +cleanup: + VIR_FREE(type); + VIR_FREE(target); + VIR_FREE(source); + + return def; + + error: + virDomainFSDefFree(def); def = NULL; goto cleanup; } @@ -1351,6 +1454,10 @@ dev->type = VIR_DOMAIN_DEVICE_DISK; if (!(dev->data.disk = virDomainDiskDefParseXML(conn, node))) goto error; + } else if (xmlStrEqual(node->name, BAD_CAST "filesystem")) { + dev->type = VIR_DOMAIN_DEVICE_FS; + if (!(dev->data.fs = virDomainFSDefParseXML(conn, node))) + goto error; } else if (xmlStrEqual(node->name, BAD_CAST "interface")) { dev->type = VIR_DOMAIN_DEVICE_NET; if (!(dev->data.net = virDomainNetDefParseXML(conn, node))) @@ -1560,7 +1667,21 @@ } } - if (!def->os.bootloader) { + /* + * Booting options for different OS types.... + * + * - A bootloader (and optional kernel+initrd) (xen) + * - A kernel + initrd (xen) + * - A boot device (and optional kernel+initrd) (hvm) + * - An init script (exe) + */ + + if (STREQ(def->os.type, "exe")) { + def->os.init = virXPathString(conn, "string(./os/init[1])", ctxt); + } + + if (STREQ(def->os.type, "xen") || + STREQ(def->os.type, "hvm")) { def->os.kernel = virXPathString(conn, "string(./os/kernel[1])", ctxt); def->os.initrd = virXPathString(conn, "string(./os/initrd[1])", ctxt); def->os.cmdline = virXPathString(conn, "string(./os/cmdline[1])", ctxt); @@ -1610,12 +1731,9 @@ def->os.type, def->os.arch, type); - if (!emulator) { - virDomainReportError(conn, VIR_ERR_INTERNAL_ERROR, - "%s", _("unsupported guest type")); - goto error; - } - if (!(def->emulator = strdup(emulator))) { + + if (emulator && + !(def->emulator = strdup(emulator))) { virDomainReportError(conn, VIR_ERR_NO_MEMORY, NULL); goto error; } @@ -1648,6 +1766,23 @@ ptr = ptr->next; } } + } + VIR_FREE(nodes); + + /* analysis of the filesystems */ + if ((n = virXPathNodeSet(conn, "./devices/filesystem", ctxt, &nodes)) < 0) { + virDomainReportError(conn, VIR_ERR_INTERNAL_ERROR, + "%s", _("cannot extract filesystem devices")); + goto error; + } + for (i = n - 1 ; i >= 0 ; i--) { + virDomainFSDefPtr fs = virDomainFSDefParseXML(conn, + nodes[i]); + if (!fs) + goto error; + + fs->next = def->fss; + def->fss = fs; } VIR_FREE(nodes); @@ -2202,6 +2337,57 @@ } static int +virDomainFSDefFormat(virConnectPtr conn, + virBufferPtr buf, + virDomainFSDefPtr def) +{ + const char *type = virDomainFSTypeToString(def->type); + + if (!type) { + virDomainReportError(conn, VIR_ERR_INTERNAL_ERROR, + _("unexpected filesystem type %d"), def->type); + return -1; + } + + virBufferVSprintf(buf, + " <filesystem type='%s'>\n", + type); + + if (def->src) { + switch (def->type) { + case VIR_DOMAIN_FS_TYPE_MOUNT: + virBufferEscapeString(buf, " <source dir='%s'/>\n", + def->src); + break; + + case VIR_DOMAIN_FS_TYPE_BLOCK: + virBufferEscapeString(buf, " <source dev='%s'/>\n", + def->src); + break; + + case VIR_DOMAIN_FS_TYPE_FILE: + virBufferEscapeString(buf, " <source file='%s'/>\n", + def->src); + break; + + case VIR_DOMAIN_FS_TYPE_TEMPLATE: + virBufferEscapeString(buf, " <source name='%s'/>\n", + def->src); + } + } + + virBufferVSprintf(buf, " <target dir='%s'/>\n", + def->dst); + + if (def->readonly) + virBufferAddLit(buf, " <readonly/>\n"); + + virBufferAddLit(buf, " </filesystem>\n"); + + return 0; +} + +static int virDomainNetDefFormat(virConnectPtr conn, virBufferPtr buf, virDomainNetDefPtr def) @@ -2479,6 +2665,7 @@ unsigned char *uuid; char uuidstr[VIR_UUID_STRING_BUFLEN]; virDomainDiskDefPtr disk; + virDomainFSDefPtr fs; virDomainNetDefPtr net; virDomainSoundDefPtr sound; virDomainInputDefPtr input; @@ -2548,6 +2735,9 @@ else virBufferVSprintf(&buf, ">%s</type>\n", def->os.type); + if (def->os.init) + virBufferEscapeString(&buf, " <init>%s</init>\n", + def->os.init); if (def->os.loader) virBufferEscapeString(&buf, " <loader>%s</loader>\n", def->os.loader); @@ -2621,6 +2811,13 @@ if (virDomainDiskDefFormat(conn, &buf, disk) < 0) goto cleanup; disk = disk->next; + } + + fs = def->fss; + while (fs) { + if (virDomainFSDefFormat(conn, &buf, fs) < 0) + goto cleanup; + fs = fs->next; } net = def->nets; diff -r 5614da5fe9ef src/domain_conf.h --- a/src/domain_conf.h Fri Jul 25 15:38:46 2008 +0100 +++ b/src/domain_conf.h Tue Jul 29 16:03:38 2008 +0100 @@ -91,6 +91,28 @@ unsigned int shared : 1; virDomainDiskDefPtr next; +}; + + +/* Two types of disk backends */ +enum virDomainFSType { + VIR_DOMAIN_FS_TYPE_MOUNT, /* Better named 'bind' */ + VIR_DOMAIN_FS_TYPE_BLOCK, + VIR_DOMAIN_FS_TYPE_FILE, + VIR_DOMAIN_FS_TYPE_TEMPLATE, + + VIR_DOMAIN_FS_TYPE_LAST +}; + +typedef struct _virDomainFSDef virDomainFSDef; +typedef virDomainFSDef *virDomainFSDefPtr; +struct _virDomainFSDef { + int type; + char *src; + char *dst; + unsigned int readonly : 1; + + virDomainFSDefPtr next; }; @@ -262,6 +284,7 @@ /* Flags for the 'type' field in next struct */ enum virDomainDeviceType { VIR_DOMAIN_DEVICE_DISK, + VIR_DOMAIN_DEVICE_FS, VIR_DOMAIN_DEVICE_NET, VIR_DOMAIN_DEVICE_INPUT, VIR_DOMAIN_DEVICE_SOUND, @@ -273,6 +296,7 @@ int type; union { virDomainDiskDefPtr disk; + virDomainFSDefPtr fs; virDomainNetDefPtr net; virDomainInputDefPtr input; virDomainSoundDefPtr sound; @@ -318,6 +342,7 @@ char *machine; int nBootDevs; int bootDevs[VIR_DOMAIN_BOOT_LAST]; + char *init; char *kernel; char *initrd; char *cmdline; @@ -357,6 +382,7 @@ virDomainGraphicsDefPtr graphics; virDomainDiskDefPtr disks; + virDomainFSDefPtr fss; virDomainNetDefPtr nets; virDomainInputDefPtr inputs; virDomainSoundDefPtr sounds; @@ -411,6 +437,7 @@ void virDomainGraphicsDefFree(virDomainGraphicsDefPtr def); void virDomainInputDefFree(virDomainInputDefPtr def); void virDomainDiskDefFree(virDomainDiskDefPtr def); +void virDomainFSDefFree(virDomainFSDefPtr def); void virDomainNetDefFree(virDomainNetDefPtr def); void virDomainChrDefFree(virDomainChrDefPtr def); void virDomainSoundDefFree(virDomainSoundDefPtr def); @@ -481,6 +508,7 @@ VIR_ENUM_DECL(virDomainDisk) VIR_ENUM_DECL(virDomainDiskDevice) VIR_ENUM_DECL(virDomainDiskBus) +VIR_ENUM_DECL(virDomainFS) VIR_ENUM_DECL(virDomainNet) VIR_ENUM_DECL(virDomainChr) VIR_ENUM_DECL(virDomainSoundModel) -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

4 10

[libvirt] [PATCH] Const-correctness in virsh.c
by Richard W.M. Jones 01 Aug '08

01 Aug '08

This rather tedious patch adds const-correctness to the command & info structures in virsh. It's worth noting that it compiles without warning, and the tests still run. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v

3 2

[libvirt] PATCH: Fix setting of bridge forward-delay
by Daniel P. Berrange 01 Aug '08

01 Aug '08

The libvirt virtual networking allows setting of the forward-delay parameter. This is the delay the kernel inserts before it starts forwarding traffic when a guest VIF is added to a bridge. The default network config sets this to zero, and previously we had a bug where we accidentally called brSetForwardDelay() based on the STP parameter which was zero, so we did in fact have a forward delay of 0 as desired. Rich then fixed this bug, and thus we no longer accidentally call the brSetForardDelay() method. Unfortuntely the place where we *do* delibrately call it is conditionalized on if (network->def->delay So if you set a forward delay of zero, we never explicitly set this on the bridge. Thus the kernel's default setting applies which is 15 seconds. The fix is trivial - just remove the conditional. So previously you could see traffic forwaarding delayed by the kernel for 30 seconds Aug 1 11:34:16 t60wlan kernel: device vnet0 entered promiscuous mode Aug 1 11:34:16 t60wlan kernel: virbr0: port 1(vnet0) entering listening state Aug 1 11:34:31 t60wlan kernel: virbr0: port 1(vnet0) entering learning state Aug 1 11:34:46 t60wlan kernel: virbr0: topology change detected, propagating Aug 1 11:34:46 t60wlan kernel: virbr0: port 1(vnet0) entering forwarding state Now it applies immediately Aug 1 11:40:07 t60wlan kernel: device vnet0 entered promiscuous mode Aug 1 11:40:07 t60wlan kernel: virbr0: port 1(vnet0) entering listening state Aug 1 11:40:07 t60wlan kernel: virbr0: port 1(vnet0) entering learning state Aug 1 11:40:07 t60wlan kernel: virbr0: topology change detected, propagating Aug 1 11:40:07 t60wlan kernel: virbr0: port 1(vnet0) entering forwarding state Daniel Index: src/qemu_driver.c =================================================================== RCS file: /data/cvs/libvirt/src/qemu_driver.c,v retrieving revision 1.98 diff -u -r1.98 qemu_driver.c --- src/qemu_driver.c 30 Jul 2008 09:20:19 -0000 1.98 +++ src/qemu_driver.c 1 Aug 2008 10:46:36 -0000 @@ -1480,8 +1480,7 @@ } - if (network->def->delay && - (err = brSetForwardDelay(driver->brctl, network->def->bridge, network->def->delay))) { + if ((err = brSetForwardDelay(driver->brctl, network->def->bridge, network->def->delay))) { qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, _("failed to set bridge forward delay to %ld"), network->def->delay); -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

3 7

Re: [libvirt] Contribution to libvirt
by rajesh battala 01 Aug '08

01 Aug '08

hi Daniel. thanks a lot.. i will start working on it.. thanks ----- Original Message ---- From: Daniel Veillard <veillard(a)redhat.com> To: rajesh battala <rajesh.battala(a)yahoo.co.in> Cc: libvir-list(a)redhat.com Sent: Friday, 1 August, 2008 12:28:45 PM Subject: Re: [libvirt] Contribution to libvirt On Fri, Aug 01, 2008 at 12:15:38PM +0530, rajesh battala wrote: > hi all.. > i am interested to contribute to libvirt. > i want to contribute to the java bindings. > is there any procedure for that. > plz let me know i ddint find doc on the site. Discuss what you would like to provide here, send patches in unified diff format against the CVS head. See http://libvirt.org/bugs.html http://libvirt.org/java.html Basically it's like for any other project, I suggest you read what Rich Jones wrote on the topic: http://et.redhat.com/~rjones/how-to-supply-code-to-open-source-projects/ Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/ Unlimited freedom, unlimited storage. Get it now, on http://help.yahoo.com/l/in/yahoo/mail/yahoomail/tools/tools-08.html/

2 1

[libvirt] [PATCH]: Add carriage returns to qemudLog
by Chris Lalancette 01 Aug '08

01 Aug '08

Since qemudLog just maps to fprintf(stderr), add carriage returns every where it is used, so it's easier on the eyes while debugging. Signed-off-by: Chris Lalancette <clalance(a)redhat.com>

3 2

[libvirt] [PATCH] Add link to how-to-contribute doc from HACKING file
by Richard W.M. Jones 01 Aug '08

01 Aug '08

Very trivial patch which adds a link to my document on how to contribute to open source projects to the HACKING file. http://et.redhat.com/~rjones/how-to-supply-code-to-open-source-projects/ Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones Read my OCaml programming blog: http://camltastic.blogspot.com/ Fedora now supports 59 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora

3 2

[libvirt] libvirt, XEN, bridged network and arp
by Christoph Höger 01 Aug '08

01 Aug '08

Hi, Ive got a severe networking problem over here: When I boot up my machine (debian lenny) using virsh 0.4.4 on an debian etch, a new virtual eth device (something like vif97.0) is assigned to that machine and that device is attached to my bridge virbr1. That is fine. Not so fine is the fact, that no arp packages come over to my bridge for about 5 seconds or so. During that time I can see a lot of arp-who-has on vifXX.0 but nothing on virbr1 so there are no answers and the result is my guest machine not mounting nfs directories on boot. After some time (e.g. after login) networking works fine - but thats definitely too late - I need those directories mounted on boot. Is there a way to fix that?

2 1

[libvirt] PATCH: 0/14: Generic XML parsers/formatters for all drivers
by Daniel P. Berrange 01 Aug '08

01 Aug '08

The following series of patchs provide a generic XML parser and formatter for the network and domain XML config formats. They then switch over the test, qemu, Xend and XM drivers to these APIs. The LXC driver is work in progress. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

4 43

[libvirt] Contribution to libvirt
by rajesh battala 01 Aug '08

01 Aug '08

hi all.. i am interested to contribute to libvirt. i want to contribute to the java bindings. is there any procedure for that. plz let me know i ddint find doc on the site. thanks rajesh Unlimited freedom, unlimited storage. Get it now, on http://help.yahoo.com/l/in/yahoo/mail/yahoomail/tools/tools-08.html/

3 2

[libvirt] [PATCH] Minor doc tweaks
by Charles Duffy 01 Aug '08

01 Aug '08

Per subject; clarifies the distinction between virDomainCreateLinux and virDomainDefineXML+virDomainCreate, and adds documentation for the autoport display attribute.

2 1

[libvirt] [Charles_Duffy@messageone.com: [PATCH] autoport overrides actual VNC port number in dump-xml]
by Daniel P. Berrange 01 Aug '08

01 Aug '08

Forwarding message that was sent to wrong list... ----- Forwarded message from Charles Duffy <Charles_Duffy(a)messageone.com> ----- > To: kvm(a)vger.kernel.org > From: Charles Duffy <Charles_Duffy(a)messageone.com> > Subject: [PATCH] autoport overrides actual VNC port number in dump-xml > Date: Wed, 30 Jul 2008 00:32:57 -0500 > > Per subject; if autoport is in use for a host, the current > virDomainGraphicsDefFormat code always emits "port=-1", even if a port > is assigned to the host; this leaves no way for a client to find the VNC > port assigned to the host in question. > > --------------090103050500010408080902 > Content-Type: text/x-diff; > name="libvirt-fix-vnc-port-output.patch" > Content-Transfer-Encoding: 7bit > Content-Disposition: inline; > filename="libvirt-fix-vnc-port-output.patch" > > diff --git a/src/domain_conf.c b/src/domain_conf.c > index d629093..ece471e 100644 > --- a/src/domain_conf.c > +++ b/src/domain_conf.c > @@ -2431,11 +2431,11 @@ virDomainGraphicsDefFormat(virConnectPtr conn, > > switch (def->type) { > case VIR_DOMAIN_GRAPHICS_TYPE_VNC: > - if (def->data.vnc.autoport) > - virBufferAddLit(buf, " port='-1'"); > - else if (def->data.vnc.port) > + if (def->data.vnc.port) > virBufferVSprintf(buf, " port='%d'", > def->data.vnc.port); > + else if (def->data.vnc.autoport) > + virBufferAddLit(buf, " port='-1'"); > > virBufferVSprintf(buf, " autoport='%s'", > def->data.vnc.autoport ? "yes" : "no"); > > --------------090103050500010408080902-- > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo(a)vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ----- End forwarded message ----- -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

3 7

[libvirt] [PATCH] qemudDomainCreate check if domain is already active
by Guido Günther 01 Aug '08

01 Aug '08

Hi, currently virsh create foo.xml overwrites running domains. In case of qemu this leaves detached qemu processes around and the domain creation fails later on being unable to start other domains afterwards - not nice. Attached patch checks if we already have a running domain by that name and in this case refuses to create a new domain from xml by that name. Probably this check needs to be pushed further upward since this might affect other hypervisors too, haven't checked that though. Cheers, -- Guido

4 13

[libvirt] [PATCH] Detailed XML errors version 4
by Richard W.M. Jones 01 Aug '08

01 Aug '08

Updated to report only the first error, as suggested by Dan. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v

3 2

[libvirt] listing domains on Fedora 8 XEN kernel
by Steve Oliphant 01 Aug '08

01 Aug '08

I am having a problem being able to get domain information in an Fedora 8 XEN environment.The code does not receive an error status on the XEN kernel and does not get any information. The same code running on the non XEN kernel works fine. I am running default configuration files. Is this a known issue? Do I need to tweak the configuration files? Is there anything else I need to do get the code to work on the XEN kernel? Please point me in the right direction. If any other information is required to assist in answering my question, please let me know. Thank you in advance for your help. Steven Oliphant Software installed: rpm -qa | grep kernel kernel-headers-2.6.25.9-40.fc8 kernel-devel-2.6.23.1-42.fc8 kernel-2.6.23.1-42.fc8 kernel-xen-2.6.21-2950.fc8 kernel-2.6.25.9-40.fc8 kernel-devel-2.6.25.9-40.fc8 kernel-xen-2.6.21.7-3.fc8 rpm -qa | grep xen xen-devel-3.1.2-2.fc8 xenwatch-0.5.2-2.fc8 kernel-xen-2.6.21-2950.fc8 xen-debuginfo-3.1.2-2.fc8 kernel-xen-2.6.21.7-3.fc8 xen-libs-3.1.2-2.fc8 xen-3.1.2-2.fc8 rpm -qa | grep virt libvirt-devel-0.4.4-1.fc8 ruby-libvirt-0.0.7-1.fc8 libvirt-python-0.4.4-1.fc8 python-virtinst-0.300.2-4.fc8 virt-manager-0.5.3-2.fc8 libvirt-debuginfo-0.4.4-1.fc8 libvirt-0.4.4-1.fc8 Non XEN kernel: uname -a Linux steve-1.verizon.net 2.6.25.9-40.fc8 #1 SMP Fri Jun 27 16:25:53 EDT 2008 i686 athlon i386 GNU/Linux XEN kernel uname -a Linux steve-1.verizon.net 2.6.21.7-3.fc8xen #1 SMP Thu Mar 20 14:57:53 EDT 2008 i686 athlon i386 GNU/Linux Code sample: #include <stdio.h> #include <libvirt/libvirt.h> #define DOMAIN_COUNT 10 /** * getInfo: * * extract the virtual machine information */ static void getInfo(void) { virConnectPtr conn = NULL; /* the hypervisor connection */ virDomainPtr dom = NULL; /* the domain being checked */ int ret; int id; int i, j, k, ids[DOMAIN_COUNT]; char *names[DOMAIN_COUNT]; /* NULL means connect to local Xen hypervisor */ conn = virConnectOpen(NULL); if (conn == NULL) { fprintf(stderr, "Failed to connect to hypervisor\n"); goto error; } /* Get the active domain list */ i = virConnectListDomains(conn, &ids[0], DOMAIN_COUNT); if (i < 0) { fprintf(stderr, "Failed to list the domains\n"); goto error; } for (j = 0;j < i;j++) { if (ids[j] != 0) { id = ids[j]; fprintf(stdout, "Active Domain: %d\n", id); /* Get the information */ } } /* Get defined Domain Names */ ret = virConnectListDefinedDomains (conn, names, DOMAIN_COUNT); if (ret < 0) { fprintf(stderr, "Failed to get Domain Names\n"); goto error; } for (k = 0;k < ret;k++) { printf("Inactive Domain Name: %s\n", names[k]); } error: if (dom != NULL) virDomainFree(dom); if (conn != NULL) virConnectClose(conn); } int main() { getInfo(); return(0); }

1 1

[libvirt] what ever happened to the SCSI HBA storage backend?
by David Lively 31 Jul '08

31 Jul '08

Hi Folks - I see Daniel Berrange submitted a SCSI HBA storage backend in March. What ever happened to that? I'd be happy to pick this up if there's more work to do (is there a code base later than the posted patch?) In the longer run, I'm looking towards adding support necessary for FC environments (like multipath). Also, it seems (to my iSCSI-ignorant mind) that iSCSI should be just another flavor of the SCSI driver (kind of like netfs is a flavor of the fs driver ...). Is anyone working on such a refactoring? Thanks, Dave

2 1

[libvirt] [PATCH] fix compilation for MinGW (with LXC)
by Atsushi SAKAI 31 Jul '08

31 Jul '08

Hello, Dan Smith May I commit this patch for MinGW compilation? veth.c is not necessary for MinGW. Thanks Atsushi SAKAI

4 5

[libvirt] [PATCH] Detailed XML errors using the _private field
by Richard W.M. Jones 30 Jul '08

30 Jul '08

Here is a patch which uses the _private field to store the virConnectPtr. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v

2 1

[libvirt] [PATCH 0/2] Detailed XML errors (with thread-local storage this time)
by Richard W.M. Jones 30 Jul '08

30 Jul '08

I've just seen Daniel Veillard's message about the '_private' field. In the meantime here is a solution using thread-local storage implemented on top of pthreads, which may be of interest. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones Read my OCaml programming blog: http://camltastic.blogspot.com/ Fedora now supports 59 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora

1 2

[libvirt] PATCH: Validate all test suite XML files against schema
by Daniel P. Berrange 30 Jul '08

30 Jul '08

After frequent prompting from John I've implemented a small test case to validate all the domain XML files we have in the test suite against the defined RNG schema. This showed one minor bug in the schema :-) Daniel diff -r c44225477420 docs/libvirt.rng --- a/docs/libvirt.rng Wed Jul 30 14:20:38 2008 +0100 +++ b/docs/libvirt.rng Wed Jul 30 16:17:19 2008 +0100 @@ -141,6 +141,7 @@ </attribute> <attribute name='machine'> <choice> + <value>xenfv</value> <value>pc</value> <value>isapc</value> </choice> diff -r c44225477420 tests/Makefile.am --- a/tests/Makefile.am Wed Jul 30 14:20:38 2008 +0100 +++ b/tests/Makefile.am Wed Jul 30 16:17:19 2008 +0100 @@ -37,13 +37,14 @@ test-lib.sh \ xmlrpcserver.py \ qemuxml2argvdata \ - nodeinfodata + nodeinfodata \ + domainschematest noinst_PROGRAMS = xmlrpctest xml2sexprtest sexpr2xmltest virshtest conftest \ reconnect xmconfigtest xencapstest qemuxml2argvtest qemuxml2xmltest \ nodeinfotest statstest qparamtest -test_scripts = +test_scripts = domainschematest if WITH_LIBVIRTD test_scripts += \ test_conf.sh \ diff -r c44225477420 tests/domainschematest --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/tests/domainschematest Wed Jul 30 16:17:19 2008 +0100 @@ -0,0 +1,32 @@ +#!/bin/sh + +test -z "$srcdir" && srcdir=`pwd` + +DOMAINDIRS="qemuxml2argvdata sexpr2xmldata xmconfigdata xml2sexprdata" + +n=0 +f=0 +for dir in $DOMAINDIRS +do + XML=`find $dir -name '*.xml'` + + for xml in $XML + do + n=`expr $n + 1` + printf "%4d) %-60s " $n $xml + result=`xmllint --relaxng $srcdir/../docs/libvirt.rng --noout $xml 2>&1` + ret=$? + if test $ret = 0; then + echo "OK" + else + echo "FAILED" + echo $result + f=`expr $f + 1` + fi + done +done +echo "Validated $n files, $f failed" + +ret=0 +test $f != 0 && ret=255 +exit $ret -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 1

[libvirt] [PATCH] Detailed XML errors when XML is not well-formed
by Richard W.M. Jones 30 Jul '08

30 Jul '08

This patch changes the implementations lots of functions which parse XML documents, so that if the XML document is not well-formed then we get detailed error messages. The general form of the change is: static void catchXMLError (void *ctx, const char *msg ATTRIBUTE_UNUSED, ...) { // a callback which calls virDomainReportError } virDomainDefPtr virDomainDefParseString(virConnectPtr conn, virCapsPtr caps, const char *xmlStr) { xmlParserCtxtPtr pctxt; pctxt = xmlNewParserCtxt (); pctxt->sax->error = catchXMLError; xml = xmlCtxtReadDoc (pctxt, //...) etc. There are some unavoidable shortcomings: (1) There is no place to stash user pointers during the callback (the suggestively named pctxt->userData field is already used for something else), so we cannot pass the virConnectPtr to the error function. As a result, virterror will store the error in a global variable, and callers will probably not be able to access it. (2) The XML parser routinely produces multiple error messages, and virterror throws away all but the last one. The errors do, however, get printed to stderr. You can test this by using 'virsh define', 'virsh net-define', 'virsh pool-define', etc. on not-well-formed XML files. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v

3 2