- Devel - libvirt List Archives

[libvirt] PATCH: Fix const-ness for virRun/virExec
by Daniel P. Berrange 09 Aug '08

09 Aug '08

The exec() family of UNIX functions have broken const-ness in the argv[] parameter. For inexplicable reasons, I followed this brokeness when originally doing the virRun/virExec functions. So every caller is either using wrong const-ness, or having to cast when calling them. This patch fixes the virRun/virExec API const-ness, so we only need apply a cast at the time we finally call exec() src/iptables.c | 12 ++++++------ src/lxc_driver.c | 2 +- src/openvz_driver.c | 34 +++++++++++++++++----------------- src/qemu_conf.c | 4 ++-- src/qemu_conf.h | 2 +- src/qemu_driver.c | 6 +++--- src/storage_backend.c | 4 ++-- src/storage_backend_disk.c | 4 ++-- src/storage_backend_fs.c | 8 ++++---- src/storage_backend_iscsi.c | 6 +++--- src/storage_backend_logical.c | 12 ++++++------ src/util.c | 16 ++++++++-------- src/util.h | 6 +++--- src/veth.c | 8 ++++---- tests/qemuxml2argvtest.c | 2 +- 15 files changed, 63 insertions(+), 63 deletions(-) Daniel diff -r cc63ab958867 src/iptables.c --- a/src/iptables.c Thu Aug 07 15:00:21 2008 +0100 +++ b/src/iptables.c Thu Aug 07 22:59:08 2008 +0100 @@ -57,7 +57,7 @@ typedef struct { char *rule; - char **argv; + const char **argv; int command_idx; } iptRule; @@ -91,7 +91,7 @@ const char *path) { char arg[PATH_MAX]; - char *argv[4]; + const char *argv[4]; snprintf(arg, sizeof(arg), "--custom-rules=ipv4:%s:%s", table, path); @@ -278,7 +278,7 @@ static int iptRulesAppend(iptRules *rules, char *rule, - char **argv, + const char **argv, int command_idx) { if (VIR_REALLOC_N(rules->rules, rules->nrules+1) < 0) { @@ -385,7 +385,7 @@ } static char * -argvToString(char **argv) +argvToString(const char *const *argv) { int len, i; char *ret, *p; @@ -415,7 +415,7 @@ { va_list args; int retval = ENOMEM; - char **argv; + const char **argv; char *rule = NULL; const char *s; int n, command_idx; @@ -571,7 +571,7 @@ for (i = 0; i < rules->nrules; i++) { iptRule *rule = &rules->rules[i]; - char *orig; + const char *orig; orig = rule->argv[rule->command_idx]; rule->argv[rule->command_idx] = (char *) "--delete"; diff -r cc63ab958867 src/lxc_driver.c --- a/src/lxc_driver.c Thu Aug 07 15:00:21 2008 +0100 +++ b/src/lxc_driver.c Thu Aug 07 22:59:08 2008 +0100 @@ -1288,7 +1288,7 @@ int user_netns = 0; int kern_netns = 0; - if (virRun(NULL, (char **)argv, &ip_rc) == 0) + if (virRun(NULL, argv, &ip_rc) == 0) user_netns = WIFEXITED(ip_rc) && (WEXITSTATUS(ip_rc) != 255); if (lxcCheckContainerSupport(CLONE_NEWNET) == 0) diff -r cc63ab958867 src/openvz_driver.c --- a/src/openvz_driver.c Thu Aug 07 15:00:21 2008 +0100 +++ b/src/openvz_driver.c Thu Aug 07 22:59:08 2008 +0100 @@ -91,13 +91,13 @@ unsigned int flags ATTRIBUTE_UNUSED); static int openvzDomainUndefine(virDomainPtr dom); -static void cmdExecFree(char *cmdExec[]); +static void cmdExecFree(const char *cmdExec[]); static int openvzGetProcessInfo(unsigned long long *cpuTime, int vpsid); struct openvz_driver ovz_driver; -static void cmdExecFree(char *cmdExec[]) +static void cmdExecFree(const char *cmdExec[]) { int i=-1; while(cmdExec[++i]) @@ -111,7 +111,7 @@ 0 - OK */ static int openvzDomainDefineCmd(virConnectPtr conn, - char *args[], + const char *args[], int maxarg, struct openvz_vm_def *vmdef) { @@ -287,7 +287,7 @@ return -1; } - if (virRun(dom->conn, (char **)prog, NULL) < 0) { + if (virRun(dom->conn, prog, NULL) < 0) { openvzError(dom->conn, VIR_ERR_INTERNAL_ERROR, _("Could not exec %s"), VZCTL); return -1; @@ -319,7 +319,7 @@ return -1; } - if (virRun(dom->conn, (char **)prog, NULL) < 0) { + if (virRun(dom->conn, prog, NULL) < 0) { openvzError(dom->conn, VIR_ERR_INTERNAL_ERROR, _("Could not exec %s"), VZCTL); return -1; @@ -333,7 +333,7 @@ virDomainNetDefPtr net) { int rc = 0, narg; - char *prog[OPENVZ_MAX_ARG]; + const char *prog[OPENVZ_MAX_ARG]; char *mac = NULL; #define ADD_ARG_LIT(thisarg) \ @@ -391,7 +391,7 @@ if (prog[0] != NULL){ ADD_ARG_LIT("--save"); - if (virRun(conn, (char **)prog, NULL) < 0) { + if (virRun(conn, prog, NULL) < 0) { openvzError(conn, VIR_ERR_INTERNAL_ERROR, _("Could not exec %s"), VZCTL); rc = -1; @@ -427,7 +427,7 @@ struct openvz_vm_def *vmdef = NULL; struct openvz_vm *vm = NULL; virDomainPtr dom = NULL; - char *prog[OPENVZ_MAX_ARG]; + const char *prog[OPENVZ_MAX_ARG]; prog[0] = NULL; if ((vmdef = openvzParseVMDef(conn, xml, NULL)) == NULL) @@ -453,7 +453,7 @@ //TODO: set number virtual CPUs //TODO: set quota - if (virRun(conn, (char **)prog, NULL) < 0) { + if (virRun(conn, prog, NULL) < 0) { openvzError(conn, VIR_ERR_INTERNAL_ERROR, _("Could not exec %s"), VZCTL); goto exit; @@ -489,7 +489,7 @@ virDomainPtr dom = NULL; struct openvz_driver *driver = (struct openvz_driver *) conn->privateData; const char *progstart[] = {VZCTL, "--quiet", "start", NULL, NULL}; - char *progcreate[OPENVZ_MAX_ARG]; + const char *progcreate[OPENVZ_MAX_ARG]; progcreate[0] = NULL; if (!(vmdef = openvzParseVMDef(conn, xml, NULL))) @@ -514,7 +514,7 @@ goto exit; } - if (virRun(conn, (char **)progcreate, NULL) < 0) { + if (virRun(conn, progcreate, NULL) < 0) { openvzError(conn, VIR_ERR_INTERNAL_ERROR, _("Could not exec %s"), VZCTL); goto exit; @@ -534,7 +534,7 @@ progstart[3] = vmdef->name; - if (virRun(conn, (char **)progstart, NULL) < 0) { + if (virRun(conn, progstart, NULL) < 0) { openvzError(conn, VIR_ERR_INTERNAL_ERROR, _("Could not exec %s"), VZCTL); goto exit; @@ -572,7 +572,7 @@ return -1; } - if (virRun(dom->conn, (char **)prog, NULL) < 0) { + if (virRun(dom->conn, prog, NULL) < 0) { openvzError(dom->conn, VIR_ERR_INTERNAL_ERROR, _("Could not exec %s"), VZCTL); return -1; @@ -604,7 +604,7 @@ return -1; } - if (virRun(conn, (char **)prog, NULL) < 0) { + if (virRun(conn, prog, NULL) < 0) { openvzError(conn, VIR_ERR_INTERNAL_ERROR, _("Could not exec %s"), VZCTL); return -1; @@ -629,7 +629,7 @@ return -1; } - if (virRun(conn, (char **)prog, NULL) < 0) { + if (virRun(conn, prog, NULL) < 0) { openvzError(conn, VIR_ERR_INTERNAL_ERROR, _("Could not exec %s"), VZCTL); return -1; } @@ -742,7 +742,7 @@ char *endptr; const char *cmd[] = {VZLIST, "-ovpsid", "-H" , NULL}; - ret = virExec(conn, (char **)cmd, &pid, -1, &outfd, &errfd); + ret = virExec(conn, cmd, &pid, -1, &outfd, &errfd); if(ret == -1) { openvzError(conn, VIR_ERR_INTERNAL_ERROR, _("Could not exec %s"), VZLIST); @@ -779,7 +779,7 @@ const char *cmd[] = {VZLIST, "-ovpsid", "-H", "-S", NULL}; /* the -S options lists only stopped domains */ - ret = virExec(conn, (char **)cmd, &pid, -1, &outfd, &errfd); + ret = virExec(conn, cmd, &pid, -1, &outfd, &errfd); if(ret == -1) { openvzError(conn, VIR_ERR_INTERNAL_ERROR, _("Could not exec %s"), VZLIST); diff -r cc63ab958867 src/qemu_conf.c --- a/src/qemu_conf.c Thu Aug 07 15:00:21 2008 +0100 +++ b/src/qemu_conf.c Thu Aug 07 22:59:08 2008 +0100 @@ -711,7 +711,7 @@ struct qemud_driver *driver, virDomainObjPtr vm, int qemuCmdFlags, - char ***retargv, + const char ***retargv, int **tapfds, int *ntapfds, const char *migrateFrom) { @@ -728,7 +728,7 @@ struct utsname ut; int disableKQEMU = 0; int qargc = 0, qarga = 0; - char **qargv = NULL; + const char **qargv = NULL; uname(&ut); diff -r cc63ab958867 src/qemu_conf.h --- a/src/qemu_conf.h Thu Aug 07 15:00:21 2008 +0100 +++ b/src/qemu_conf.h Thu Aug 07 22:59:08 2008 +0100 @@ -95,7 +95,7 @@ struct qemud_driver *driver, virDomainObjPtr dom, int qemuCmdFlags, - char ***argv, + const char ***argv, int **tapfds, int *ntapfds, const char *migrateFrom); diff -r cc63ab958867 src/qemu_driver.c --- a/src/qemu_driver.c Thu Aug 07 15:00:21 2008 +0100 +++ b/src/qemu_driver.c Thu Aug 07 22:59:08 2008 +0100 @@ -842,7 +842,7 @@ struct qemud_driver *driver, virDomainObjPtr vm, const char *migrateFrom) { - char **argv = NULL, **tmp; + const char **argv = NULL, **tmp; int i, ret; char logfile[PATH_MAX]; struct stat sb; @@ -1087,7 +1087,7 @@ static int qemudBuildDnsmasqArgv(virConnectPtr conn, virNetworkObjPtr network, - char ***argv) { + const char ***argv) { int i, len, r; char buf[PATH_MAX]; @@ -1184,7 +1184,7 @@ dhcpStartDhcpDaemon(virConnectPtr conn, virNetworkObjPtr network) { - char **argv; + const char **argv; int ret, i; if (network->def->ipAddress == NULL) { diff -r cc63ab958867 src/storage_backend.c --- a/src/storage_backend.c Thu Aug 07 15:00:21 2008 +0100 +++ b/src/storage_backend.c Thu Aug 07 22:59:08 2008 +0100 @@ -403,7 +403,7 @@ /* Run the program and capture its output */ - if (virExec(conn, (char**)prog, &child, -1, &fd, NULL) < 0) { + if (virExec(conn, prog, &child, -1, &fd, NULL) < 0) { goto cleanup; } @@ -537,7 +537,7 @@ v[i] = NULL; /* Run the program and capture its output */ - if (virExec(conn, (char**)prog, &child, -1, &fd, NULL) < 0) { + if (virExec(conn, prog, &child, -1, &fd, NULL) < 0) { goto cleanup; } diff -r cc63ab958867 src/storage_backend_disk.c --- a/src/storage_backend_disk.c Thu Aug 07 15:00:21 2008 +0100 +++ b/src/storage_backend_disk.c Thu Aug 07 22:59:08 2008 +0100 @@ -410,7 +410,7 @@ NULL, }; - if (virRun(conn, (char**)prog, NULL) < 0) + if (virRun(conn, prog, NULL) < 0) return -1; return 0; @@ -469,7 +469,7 @@ snprintf(end, sizeof(end)-1, "%lluB", endOffset); end[sizeof(end)-1] = '\0'; - if (virRun(conn, (char**)cmdargv, NULL) < 0) + if (virRun(conn, cmdargv, NULL) < 0) return -1; /* Blow away free extent info, as we're about to re-populate it */ diff -r cc63ab958867 src/storage_backend_fs.c --- a/src/storage_backend_fs.c Thu Aug 07 15:00:21 2008 +0100 +++ b/src/storage_backend_fs.c Thu Aug 07 22:59:08 2008 +0100 @@ -571,7 +571,7 @@ } mntargv[source_index] = src; - if (virRun(conn, (char**)mntargv, NULL) < 0) { + if (virRun(conn, mntargv, NULL) < 0) { VIR_FREE(src); return -1; } @@ -625,7 +625,7 @@ mntargv[1] = pool->def->target.path; mntargv[2] = NULL; - if (virRun(conn, (char**)mntargv, NULL) < 0) { + if (virRun(conn, mntargv, NULL) < 0) { return -1; } return 0; @@ -940,7 +940,7 @@ imgargv[5] = size; imgargv[6] = NULL; - if (virRun(conn, (char **)imgargv, NULL) < 0) { + if (virRun(conn, imgargv, NULL) < 0) { unlink(vol->target.path); return -1; } @@ -975,7 +975,7 @@ imgargv[2] = vol->target.path; imgargv[3] = NULL; - if (virRun(conn, (char **)imgargv, NULL) < 0) { + if (virRun(conn, imgargv, NULL) < 0) { unlink(vol->target.path); return -1; } diff -r cc63ab958867 src/storage_backend_iscsi.c --- a/src/storage_backend_iscsi.c Thu Aug 07 15:00:21 2008 +0100 +++ b/src/storage_backend_iscsi.c Thu Aug 07 22:59:08 2008 +0100 @@ -158,7 +158,7 @@ "--targetname", pool->def->source.devices[0].path, action, NULL }; - if (virRun(conn, (char **)cmdargv, NULL) < 0) + if (virRun(conn, cmdargv, NULL) < 0) return -1; return 0; @@ -507,7 +507,7 @@ ISCSIADM, "--mode", "session", "-r", session, "-R", NULL, }; - if (virRun(conn, (char **)cmdargv, NULL) < 0) + if (virRun(conn, cmdargv, NULL) < 0) return -1; return 0; @@ -524,7 +524,7 @@ "--portal", portal, NULL }; - if (virRun(conn, (char **)cmdsendtarget, NULL) < 0) + if (virRun(conn, cmdsendtarget, NULL) < 0) return -1; return virStorageBackendISCSIConnection(conn, pool, portal, "--login"); diff -r cc63ab958867 src/storage_backend_logical.c --- a/src/storage_backend_logical.c Thu Aug 07 15:00:21 2008 +0100 +++ b/src/storage_backend_logical.c Thu Aug 07 22:59:08 2008 +0100 @@ -83,7 +83,7 @@ cmdargv[2] = pool->def->name; cmdargv[3] = NULL; - if (virRun(conn, (char**)cmdargv, NULL) < 0) + if (virRun(conn, cmdargv, NULL) < 0) return -1; return 0; @@ -324,14 +324,14 @@ */ vgargv[n++] = pool->def->source.devices[i].path; pvargv[1] = pool->def->source.devices[i].path; - if (virRun(conn, (char**)pvargv, NULL) < 0) + if (virRun(conn, pvargv, NULL) < 0) goto cleanup; } vgargv[n++] = NULL; /* Now create the volume group itself */ - if (virRun(conn, (char**)vgargv, NULL) < 0) + if (virRun(conn, vgargv, NULL) < 0) goto cleanup; VIR_FREE(vgargv); @@ -422,7 +422,7 @@ VGREMOVE, "-f", pool->def->name, NULL }; - if (virRun(conn, (char**)cmdargv, NULL) < 0) + if (virRun(conn, cmdargv, NULL) < 0) return -1; /* XXX clear the PVs too ? ie pvremove ? probably ought to */ @@ -453,7 +453,7 @@ snprintf(size, sizeof(size)-1, "%lluK", vol->capacity/1024); size[sizeof(size)-1] = '\0'; - if (virRun(conn, (char**)cmdargv, NULL) < 0) + if (virRun(conn, cmdargv, NULL) < 0) return -1; if ((fd = open(vol->target.path, O_RDONLY)) < 0) { @@ -514,7 +514,7 @@ LVREMOVE, "-f", vol->target.path, NULL }; - if (virRun(conn, (char**)cmdargv, NULL) < 0) + if (virRun(conn, cmdargv, NULL) < 0) return -1; return 0; diff -r cc63ab958867 src/util.c --- a/src/util.c Thu Aug 07 15:00:21 2008 +0100 +++ b/src/util.c Thu Aug 07 22:59:08 2008 +0100 @@ -102,8 +102,8 @@ static int _virExec(virConnectPtr conn, - char **argv, - int *retpid, int infd, int *outfd, int *errfd, int non_block) { + const char *const*argv, + int *retpid, int infd, int *outfd, int *errfd, int non_block) { int pid, null; int pipeout[2] = {-1,-1}; int pipeerr[2] = {-1,-1}; @@ -185,7 +185,7 @@ if (pipeerr[1] > 0) close(pipeerr[1]); - execvp(argv[0], argv); + execvp(argv[0], (char **) argv); _exit(1); @@ -207,16 +207,16 @@ int virExec(virConnectPtr conn, - char **argv, - int *retpid, int infd, int *outfd, int *errfd) { + const char *const*argv, + int *retpid, int infd, int *outfd, int *errfd) { return(_virExec(conn, argv, retpid, infd, outfd, errfd, 0)); } int virExecNonBlock(virConnectPtr conn, - char **argv, - int *retpid, int infd, int *outfd, int *errfd) { + const char *const*argv, + int *retpid, int infd, int *outfd, int *errfd) { return(_virExec(conn, argv, retpid, infd, outfd, errfd, 1)); } @@ -238,7 +238,7 @@ */ int virRun(virConnectPtr conn, - char **argv, + const char *const*argv, int *status) { int childpid, exitstatus, ret; diff -r cc63ab958867 src/util.h --- a/src/util.h Thu Aug 07 15:00:21 2008 +0100 +++ b/src/util.h Thu Aug 07 22:59:08 2008 +0100 @@ -27,11 +27,11 @@ #include "util-lib.h" #include "verify.h" -int virExec(virConnectPtr conn, char **argv, int *retpid, +int virExec(virConnectPtr conn, const char *const*argv, int *retpid, int infd, int *outfd, int *errfd); -int virExecNonBlock(virConnectPtr conn, char **argv, int *retpid, +int virExecNonBlock(virConnectPtr conn, const char *const*argv, int *retpid, int infd, int *outfd, int *errfd); -int virRun(virConnectPtr conn, char **argv, int *status); +int virRun(virConnectPtr conn, const char *const*argv, int *status); int __virFileReadAll(const char *path, int maxlen, diff -r cc63ab958867 src/veth.c --- a/src/veth.c Thu Aug 07 15:00:21 2008 +0100 +++ b/src/veth.c Thu Aug 07 22:59:08 2008 +0100 @@ -104,7 +104,7 @@ } DEBUG("veth1: %s veth2: %s", veth1, veth2); - rc = virRun(NULL, (char**)argv, &cmdResult); + rc = virRun(NULL, argv, &cmdResult); if (0 == rc) { rc = cmdResult; @@ -137,7 +137,7 @@ DEBUG("veth: %s", veth); - rc = virRun(NULL, (char**)argv, &cmdResult); + rc = virRun(NULL, argv, &cmdResult); if (0 == rc) { rc = cmdResult; @@ -172,7 +172,7 @@ else argv[2] = "up"; - rc = virRun(NULL, (char**)argv, &cmdResult); + rc = virRun(NULL, argv, &cmdResult); if (0 == rc) { rc = cmdResult; @@ -210,7 +210,7 @@ goto error_out; argv[5] = pid; - rc = virRun(NULL, (char**)argv, &cmdResult); + rc = virRun(NULL, argv, &cmdResult); if (0 == rc) rc = cmdResult; diff -r cc63ab958867 tests/qemuxml2argvtest.c --- a/tests/qemuxml2argvtest.c Thu Aug 07 15:00:21 2008 +0100 +++ b/tests/qemuxml2argvtest.c Thu Aug 07 22:59:08 2008 +0100 @@ -26,7 +26,7 @@ char argvData[MAX_FILE]; char *expectargv = &(argvData[0]); char *actualargv = NULL; - char **argv = NULL; + const char **argv = NULL; char **tmp = NULL; int ret = -1, len, flags; virDomainDefPtr vmdef = NULL; -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

3 2

[libvirt] Release of libvirt-java-0.2.1
by Daniel Veillard 08 Aug '08

08 Aug '08

Following the refactoring patch by Tóth István, it was a good idea to make a release awoiding all the know leaks and providing the storage API. Sor libvirt-java-0.2.1 is available at the usual place: ftp://libvirt.org/libvirt/java/ thanks Tóth ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

1 0

[libvirt] Question SSH support and libirt on Windows
by Atsushi SAKAI 08 Aug '08

08 Aug '08

Hi, Rich I have a question about SSH support of libvirt on Windows. Is there any reason for not supporting SSH. It is just because it lacks manpower? Thanks Atsushi SAKAI

3 2

[libvirt] [PATCH] fix xmlint in separate build dir
by Guido Günther 07 Aug '08

07 Aug '08

Hi, attached patch lets the domainschema check work when building in $build instead of $src. Otherwise it won't find the xml files to validate. -- Guido

2 1

[libvirt] ISCSI Live Migration with LUN backed VMs
by Tim Hughes 07 Aug '08

07 Aug '08

I am using iscsi backed VMs which use a separate LUN for each VM. This is all good until I try to live migrate because the LUN is not logged into on the new machine. Does anyone have a way of handling logging into and out of iscsi luns during the migration ? Tim Hughes mailto:thughes@thegoldfish.org

3 3

[libvirt] default networking issues
by Bryan Kearney 07 Aug '08

07 Aug '08

Need some help about where to look next. I am running a Fedora 9 machine, up to date on the releaed rpms. SELinux is permissive, iptables is stopped. I have followed the instructions for NAT forwarding [1]. When I launch a guest in virt manager it uses the default network, and is assigned an IP address in the 192.168.122 space. It can do dns resolution, but can not wget a known website (www.cnn.com) From my host machine, I can ssh into the guest. Where is the next place I should look. Is the fact that I am running in a corporate network causing me issues? Thanks! -- bk [1] http://wiki.libvirt.org/page/Networking#NAT_forwarding_.28aka_.22virtual_ne…

5 5

[libvirt] [PATCH] The logic in veth.c that searches for free interface names takes into account
by Dan Smith 07 Aug '08

07 Aug '08

only current devices, but not device names already planned for the other half of a container's device pair. Thus, the search can result in attempting to create a pair of devices such as veth1 and veth1, which obviously does not work. This patch augments the logic to be a little smarter in this regard, and should fix one case where attempting to start a container results in an error message of "unable to create device pair". diff -r 8c5e6387e449 -r 8545f7ac1f0f src/veth.c --- a/src/veth.c Tue Aug 05 16:45:07 2008 +0000 +++ b/src/veth.c Wed Aug 06 08:14:16 2008 -0700 @@ -92,17 +92,18 @@ DEBUG("veth1: %s veth2: %s", veth1, veth2); - if (1 > strlen(veth1)) { + while ((1 > strlen(veth1)) || STREQ(veth1, veth2)) { vethDev = getFreeVethName(veth1, veth1MaxLen, 0); ++vethDev; DEBUG("assigned veth1: %s", veth1); } - if (1 > strlen(veth2)) { + while ((1 > strlen(veth2)) || STREQ(veth1, veth2)) { vethDev = getFreeVethName(veth2, veth2MaxLen, vethDev); DEBUG("assigned veth2: %s", veth2); } + DEBUG("veth1: %s veth2: %s", veth1, veth2); rc = virRun(NULL, (char**)argv, &cmdResult); if (0 == rc) {

3 3

[libvirt] update from gnulib
by Jim Meyering 07 Aug '08

07 Aug '08

I've just checked in a big batch of changes from gnulib. Each of those changes has been reviewed by at least two people (see bug-gnulib(a)gnu.org) and most of them address problems also reported on that list, or e.g., on bug-coreutils, bug-m4, etc. However, I suspect some of them have not yet been exercised on RHEL4/5 systems, so test builds there may be interesting. >From e6440820773161436812ccad7eba6d555a8186dd Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Thu, 7 Aug 2008 10:28:22 +0200 Subject: [PATCH] update from gnulib * build-aux/mktempd (rand_bytes, mktempd): * build-aux/useless-if-before-free (FILE): * build-aux/vc-list-files: * gnulib/lib/.cvsignore: * gnulib/lib/Makefile.am: * gnulib/lib/poll.c (poll): * gnulib/lib/stdbool.in.h (_GL_STDBOOL_H, true): * gnulib/lib/stdio-impl.h (fp_, fp_ub): * gnulib/lib/stdio.in.h (vasprintf, obstack_printf) (obstack_vprintf): * gnulib/lib/vasnprintf.c (_GNU_SOURCE, sprintf, IF_LINT, exp) (remainder, scale10_round_decimal_long_double) (scale10_round_decimal_double, pad_ourselves): * gnulib/m4/gnulib-cache.m4: * gnulib/m4/gnulib-common.m4 (gl_MODULE_INDICATOR): * gnulib/m4/gnulib-tool.m4 (gl_LOCAL_DIR, gl_M4_BASE, gl_PO_BASE) (gl_DOC_BASE, gl_TESTS_BASE, gl_WITH_TESTS, gl_LIB, gl_LGPL) (gl_MAKEFILE_NAME, gl_MACRO_PREFIX, gl_PO_DOMAIN, gl_VC_FILES): * gnulib/m4/lock.m4 (gl_LOCK_EARLY_BODY, gl_PREREQ_LOCK) (gl_DISABLE_THREADS): * gnulib/m4/onceonly.m4: * gnulib/m4/posix-shell.m4 (gl_POSIX_SHELL): * gnulib/m4/stdio_h.m4 (gl_STDIO_H_DEFAULTS): * gnulib/tests/test-getaddrinfo.c (ENABLE_DEBUGGING, dbgprintf) (simple): * gnulib/tests/test-stdint.c (UINTMAX_MAX, or): * gnulib/tests/test-vc-list-files-cvs.sh (compare): * gnulib/tests/test-vc-list-files-git.sh (compare): --- build-aux/mktempd | 6 +++- build-aux/useless-if-before-free | 32 +++++++++++++++--------- build-aux/vc-list-files | 5 ++- gnulib/lib/.cvsignore | 12 ++++---- gnulib/lib/Makefile.am | 15 +++++++++++- gnulib/lib/poll.c | 34 ++++++++++++++++++------- gnulib/lib/stdbool.in.h | 6 ++-- gnulib/lib/stdio-impl.h | 4 +- gnulib/lib/stdio.in.h | 20 +++++++++++++++ gnulib/lib/vasnprintf.c | 25 +++++++++++++++---- gnulib/m4/gnulib-cache.m4 | 21 ++++++++++++++- gnulib/m4/gnulib-common.m4 | 9 ++++++- gnulib/m4/gnulib-tool.m4 | 28 ++++++++++++++++++++- gnulib/m4/lock.m4 | 37 +++++++++++++++++++++------- gnulib/m4/onceonly.m4 | 15 +++++++---- gnulib/m4/posix-shell.m4 | 7 +++-- gnulib/m4/stdio_h.m4 | 6 ++++- gnulib/tests/test-getaddrinfo.c | 41 +++++++++++++++++++------------ gnulib/tests/test-stdint.c | 6 ++++- gnulib/tests/test-vc-list-files-cvs.sh | 3 +- gnulib/tests/test-vc-list-files-git.sh | 3 +- 21 files changed, 249 insertions(+), 86 deletions(-)

2 2

[libvirt] Is CVS server working?
by Atsushi SAKAI 07 Aug '08

07 Aug '08

Hi, CVS server anoncvs@libvirt.org:2401/data/cvs is working? I can see git repository but CVS repository are not. Thanks Atsushi SAKAI

2 3

[libvirt] [PATCH] Install default storage pool
by Cole Robinson 07 Aug '08

07 Aug '08

The attached patch adds a default pool definition to install with libvirt. The pool is a directory pool, hardcoded to use /var/lib/libvirt/images, though this is replaced with %{_localstatedir}/lib/libvirt/images if installing via rpm. Since /var/lib/libvirt/images may not exist if installing from tar.gz, the pool is set not to autostart by default via that method. This patch isn't ready to apply though, since there is one issue I don't know how to solve. We don't want every rpm upgrade to install the default pool, since we don't want the default to continually resurrect itself if a user explicitly deletes it. The default network handles this by checking if libvirtd has been installed. Since libvirtd and virtual network support were introduced around the same time, this makes sense. However for storage, I can't think of any simple check we can make. If we used the same as the default network, all f8 or f9 upgrades wouldn't install the default pool. I can't really think of anything to check, besides maybe doing some sort of time comparison on when /usr/share/libvirt/storage/default.xml was accessed. This code is just hardcoded to always add it. Any ideas? Thanks, Cole

2 1

[libvirt] [patch][doc] fix typos 20080807
by Atsushi SAKAI 07 Aug '08

07 Aug '08

Hi, Typo fixes on document. formatdomain.html | 22 +++++++++++----------- formatdomain.html.in | 22 +++++++++++----------- java.html | 2 +- java.html.in | 2 +- 4 files changed, 24 insertions(+), 24 deletions(-) Thanks Atsushi SAKAI

2 1

[libvirt] How does virt-manager send shutdown?
by Bryan Kearney 07 Aug '08

07 Aug '08

How does virt-manager send shutdown to guests? Does it depend on if you are running kvm or xen? I have been building images with acpid enabled and acpi=force on the command line. After upgrading to f9 and running kvm my images no longer respond to shutdown. Is there a tweak which I have missed? - bk

5 8

[libvirt] [PATCH] storage pool discovery
by David Lively 06 Aug '08

06 Aug '08

Hi - The attached patch implements virConnectDiscoverStoragePools mostly as specified by Daniel Berrange in: http://www.redhat.com/archives/libvir-list/2008-February/msg00107.html Daniel wasn't happy with the interface for this function because it wasn't sufficiently general, so it currently doesn't exist. I've attempted to generalize his proposed interface by changing the "hostname" argument to a "srcSpec" argument, which is intended to be a XML storage pool <source> element. Note that srcSpec is not necessary for some (local) pool types. For example, to discover existing LVM volume groups, there's no need to specify a source: virsh # pool-discover logical While discovering nfs shares requires a <source> document to specify the host to query: virsh # pool-discover netfs "<source><host name='share' /></source>" Currently (i.e., in this patch) I've implemented discovery support only for the "logical" and "netfs" pools. I plan on covering the other types once we've agreed upon the API. While this patch is rather large, the vast majority of it is "generic" (not specific to any particular type of storage pool) code, which I mostly took from Daniel's submission. I could easily break the storage-pool-type-specific pieces into separate patches, but those changes are already segregated into the appropriate storage_backend_ files. * Known Issues * I made the virsh interface take a XML string rather than a filename. I found it convenient, but AFAIK the rest of the commands that take XML take it from a file, so perhaps that should be changed (just let me know what you'd prefer). I realize the description of srcSpec is kind of fuzzy. For instance, for netfs discovery, the <source> must have a <host> element (to specify the host to query), but shouldn't have a <dir> element since the exported dirs are exactly what we're trying to discover in this case. So this really needs to be documented accurately for each storage pool type. (Where?) Finally, there's an underspecification issue. The XML pool descriptions returned are supposed to be usable as valid input to virStoragePoolDefineXML. But these descriptions include some data (pool name, target path) that isn't specified by the discover input or the discovered resources. For now, I'm making up a somewhat arbitrary pool name (logical: VolGroup name, netfs: last component of export path). And I don't even specify <target><path> in the "netfs" discovery output (which means it's not valid input to virStoragePoolDefineXML until a target path is added). Dave

4 14

[libvirt] [PATCH] fix failing "make syntax-check"
by Jim Meyering 06 Aug '08

06 Aug '08

"make syntax-check" just started failing. This fixes it: fix failing "make syntax-check" * src/stats_linux.c: Don't include <c-ctype.h> no longer used. --- ChangeLog | 3 +++ src/stats_linux.c | 1 - 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index c23799c..ea6f1da 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,8 @@ Tue Aug 6 13:30:44 CEST 2008 Jim Meyering <meyering(a)redhat.com> + fix failing "make syntax-check" + * src/stats_linux.c: Don't include <c-ctype.h> no longer used. + work around MinGW build failure due to its lack of inet_aton Use inet_pton instead; pull in gnulib's module by the same name. * src/network_conf.c (virNetworkDefParseXML): Use inet_pton, diff --git a/src/stats_linux.c b/src/stats_linux.c index 897251b..3f7dd52 100644 --- a/src/stats_linux.c +++ b/src/stats_linux.c @@ -19,7 +19,6 @@ #include <string.h> #include <unistd.h> #include <regex.h> -#include "c-ctype.h" #ifdef WITH_XEN #include <xs.h> -- 1.6.0.rc1.92.g189f7

2 2

[libvirt] Memory corruption with CVS tip + python
by Chris Lalancette 06 Aug '08

06 Aug '08

All, FYI, I'm running into some memory corruption when using CVS tip and trying to use an older virt-install command. I won't have time to debug this today, so I thought I would mention it on-list in case someone else wants to take a crack at it. My system is an AMD system running RHEL-5.2 x86_64 bits, so it has python-virtinst-0.300.2-8.el5 installed. Basically, I did this: # cvs co libvirt # cd libvirt # ./autogen.sh # make dist >From here, I took the resulting .tar.gz, and dumped it into /usr/src/redhat/SOURCES, and then took the SPEC file from the Fedora 9 sources. I had to modify the very top of it (since RHEL-5 rpmbuild didn't like the macros for whatever reason), but if I read the logic right, I put these flags at the top: %define with_polkit 0 %define with_proxy yes %define with_qemu 0 Then I built and installed a libvirt and libvirt-python RPM with this. Finally, I restarted libvirtd, and then tried to run the following command: [root@amd1 libvirt]# virt-install -n test -f /var/lib/xen/images/test.img -s 10 -r 768 -v -c /var/lib/xen/images/boot.iso -d --vnc Wed, 06 Aug 2008 07:59:10 DEBUG DistroInstaller location is a local file/path: /var/lib/xen/images/boot.iso Starting install... Segmentation fault [root@amd1 libvirt]# It happens every time, so it should be fairly easy to track down. Chris Lalancette

1 0

[libvirt] incorrect data in online documentation (I think)
by matthew chan 06 Aug '08

06 Aug '08

Hi The online documentation mentions that the XML <memory> node units are in byte, but from the example code I have observed, it seems more likely to be in kilobytes. Could someone verify + change if necessary please? Thanks, Matt

2 1

[libvirt] [PATCH]: Fix sexpr generation again
by Chris Lalancette 06 Aug '08

06 Aug '08

DanB pointed out that my sexpr xend_internal patch from yesterday broke one of the regression tests. The problem is that the xenDaemonFormatSxpr{Disk,Net} functions are shared between domain creation time and attaching disk time. Unfortunately, though, Xend expects something different during these two times. During domain creation time, it wants the "(device" in front of the sexpr, while during attach time it does not. To remedy this situation, I added a flag to these two functions to differentiate between these two modes. With this patch in place, all of the regression tests pass. Signed-off-by: Chris Lalancette <clalance(a)redhat.com>

3 2

Re: [libvirt] PATCH: 0/7: Re-factor LXC driver
by Daniel P. Berrange 05 Aug '08

05 Aug '08

On Tue, Aug 05, 2008 at 09:04:34PM +0400, Evgeniy V. Sokolov wrote: > > >This is a long overdue followup to my previous set of patches to make the > >LXC driver use the new domain XML apis. Getting this merged is a blocker > >for the new libvirt release, now we've turned on LXC by default. Likewise > >we need to get OpenVZ fully ported to new XML before release too. > Daniel, do you plan to finish port of OpenVZ ? or I will do it. I'm happy todo the work to at least port the code, but I don't have a OpenVZ enabled machine, so would neeed someone else to actually test if its works :-) Ideally I think we should aim todo a release next week, so I'll look at whatever the state of the OpenVZ code is this coming weekend, and work from that. Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 1

[libvirt] [PATCH]: Fix "virsh attach-disk" and "virsh attach-interface"
by Chris Lalancette 05 Aug '08

05 Aug '08

With the recent refactoring of the domain code, plus the changes with the Xend code, a couple of bugs were introduced into the attach-disk and attach-interface functionality. This patch fixes 3 bugs: 1) In xenDaemonAttachDevice(), there is a switch statement to determine which of the xenDaemonFormatSxpr{Disk,Net} functions to call. Unfortunately, the case statements are all missing the corresponding "break", so we always fall-through to the default error case. This patch just adds the appropriate break statements. 2) (minor) In xenDaemonDomainDefineXML (that's a mouthful!), there is a stray "fprintf". This is now converted to a proper virXendError(). 3) xenDaemonFormatSxpr{Disk,Net} were adding an extra (device to the front of the sexpr expressions that xend did not expect (this is Xend on RHEL 5.2). Because of this, the attaches would fail. The patch fixes this by removing the (device from the front, which makes attach-disk and attach-interface work again. Signed-off-by: Chris Lalancette <clalance(a)redhat.com>

3 4

[libvirt] [PATCH]: Rework xenLinuxDomainDeviceID to support more devices
by Chris Lalancette 05 Aug '08

05 Aug '08

Recently upstream Xen added support for having xvd devices > 16. For the most part, this doesn't really concern libvirt, since for things like attach and detach we just pass it through and let xend worry about whether it is supported or not. The one place this breaks down is in the stats collecting code, where we need to figure out the device number so we can go digging in /sys for the statistics. To remedy this, I've re-written xenLinuxDomainDeviceID() to use regular expressions to figure out the device number from the name. The major advantage is that now xenLinuxDomainDeviceID() looks fairly identical to tools/python/xen/util/blkif.py (in the Xen sources), so that adding additional devices in the future should be much easier. It also reduces the size of the code, and, in my opinion, the code complexity. With this patch in place, I was able to get block statistics both on older style devices (/dev/xvda) and on the new, expanded devices (/dev/xvdaa). Signed-off-by: Chris Lalancette <clalance(a)redhat.com>

4 10

[libvirt] [PATCH] Save uuid when define/create domain
by Evgeniy Sokolov 05 Aug '08

05 Aug '08

Hi, There was bug. UUID defined in XML or generated during define/create was not saved to config. Then it was regenerated in virDrvStateInitialize. Attached patch fix bug.

2 1

[libvirt] libvirt-java storage support and refactoring
by Tóth István 05 Aug '08

05 Aug '08

Hello! This patch contains the following: - The complete storage handling API - Fixing memory leaks in the VirConnect JNI implementation I've written the new classes using a new approach. I've found that libvirt for the most part has a very perdicitble and repetitive API (great design!), and as a result I've found myself copying the same code over and over again. I've decided to make generic JNI functions, that can handle multiple libvirt functions with function pointers. The generic functions are in generic.c and they are used extensively in the new Storage JNI implementation. I'd like to have your input on this architecture, my current plan is to refactor all trivial JNI functions to use these generics, unless there are objections. The positive aspects of the new architecture: - No code duplication, one generic function fix affects all similar functions - Less code The negative aspects: - Ugly syntax (but JNI is ugly enough already) - Easier to make errors in JNI code due to function type casts. I think that the benefits outweigh the negatives, esepecialy when we start cleaning up memory allocation, 64/32 bit cleannes stuff, threading, it will have to be done in one function, instead of 3 or 30 cut'n'pasted ones, scattered in 5 files. best regards István Index: src/org/libvirt/Connect.java =================================================================== RCS file: /data/cvs/libvirt-java/src/org/libvirt/Connect.java,v retrieving revision 1.1 diff -u -r1.1 Connect.java --- src/org/libvirt/Connect.java 18 Jul 2008 14:37:21 -0000 1.1 +++ src/org/libvirt/Connect.java 2 Aug 2008 15:21:11 -0000 @@ -1,5 +1,9 @@ package org.libvirt; +import org.libvirt.LibvirtException; +import org.libvirt.StoragePool; +import org.libvirt.StorageVol; + /** * The Connect object represents a connection to a local or remote hypervisor/driver. * @@ -541,4 +545,157 @@ private native int _setDom0Memory(long memory) throws LibvirtException; + /** + * Provides the number of inactive storage pools + * + * @return the number of pools found + * @throws LibvirtException + */ + public int numOfDefinedStoragePools() throws LibvirtException { + return _numOfDefinedStoragePools(VCP); + } + + private native int _numOfDefinedStoragePools(long VCP) throws LibvirtException; + + /** + * Provides the number of active storage pools + * + * @return the number of pools found + * @throws LibvirtException + */ + public int numOfStoragePools() throws LibvirtException { + return _numOfStoragePools(VCP); + } + + private native int _numOfStoragePools(long VCP) throws LibvirtException; + + /** + * Provides the list of names of inactive storage pools. + * + * @return an Array of Strings that contains the names of the defined storage pools + * @throws LibvirtException + */ + public String[] listDefinedStoragePools() throws LibvirtException { + return _listDefinedStoragePools(VCP); + } + + private native String[] _listDefinedStoragePools(long VCP) + throws LibvirtException; + + /** + * Provides the list of names of active storage pools. + * + * @return an Array of Strings that contains the names of the defined storage pools + * @throws LibvirtException + */ + public String[] listStoragePools() throws LibvirtException { + return _listStoragePools(VCP); + } + + private native String[] _listStoragePools(long VCP) + throws LibvirtException; + + /** + * Create a new storage based on its XML description. + * The pool is not persistent, so its definition will disappear when it is destroyed, or if the host is restarted + * + * @param xmlDesc XML description for new pool + * @param flags future flags, use 0 for now + * @return StoragePool object + * @throws LibvirtException + */ + public StoragePool storagePoolCreateXML(String xmlDesc, int flags) + throws LibvirtException { + return new StoragePool(this, _virStoragePoolCreateXML(VCP, xmlDesc, flags)); + } + + private native long _virStoragePoolCreateXML(long VCP, String xmlDesc, int flags) + throws LibvirtException; + + /** + * Define a new inactive storage pool based on its XML description. + * The pool is persistent, until explicitly undefined. + * + * @param xmlDesc XML description for new pool + * @param flags flags future flags, use 0 for now + * @return StoragePool object + * @throws LibvirtException + */ + public StoragePool storagePoolDefineXML(String xml, int flags) + throws LibvirtException { + return new StoragePool(this, _virStoragePoolDefineXML(VCP, xml, flags)); + } + + private native long _virStoragePoolDefineXML(long VCP, String xml, int flags) + throws LibvirtException; + + /** + * Fetch a storage pool based on its unique name + * + * @param name name of pool to fetch + * @return StoragePool object + * @throws LibvirtException + */ + public StoragePool storagePoolLookupByName(String name) + throws LibvirtException { + return new StoragePool(this, _virStoragePoolLookupByName(VCP, name)); + } + + private native long _virStoragePoolLookupByName(long VCP, String name) + throws LibvirtException; + + /** + * Fetch a storage pool based on its globally unique id + * + * @param UUID globally unique id of pool to fetch + * @return a new network object + * @throws LibvirtException + */ + public StoragePool storagePoolLookupByUUID(int[] UUID) + throws LibvirtException { + return new StoragePool(this, _virStoragePoolLookupByUUID(VCP, UUID)); + } + + private native long _virStoragePoolLookupByUUID(long VCP, int[] UUID); + + /** + * Fetch a storage pool based on its globally unique id + * + * @param UUID globally unique id of pool to fetch + * @return VirStoragePool object + * @throws LibvirtException + */ + public StoragePool storagePoolLookupByUUIDString(String UUID) + throws LibvirtException { + return new StoragePool(this, _virStoragePoolLookupByUUIDString(VCP, UUID)); + } + + private native long _virStoragePoolLookupByUUIDString(long VCP, String UUID) + throws LibvirtException; + + /** + * Fetch a a storage volume based on its globally unique key + * + * @param key globally unique key + * @return a storage volume + */ + public StorageVol storageVolLookupByKey(String key){ + return new StorageVol(this, _virStorageVolLookupByKey(VCP, key)); + } + + private native long _virStorageVolLookupByKey(long VCP, String key); + + /** + * Fetch a storage volume based on its locally (host) unique path + * + * @param path locally unique path + * @return a storage volume + */ + public StorageVol storageVolLookupByPath(String path){ + return new StorageVol(this, _virStorageVolLookupByPath(VCP, path)); + } + + private native long _virStorageVolLookupByPath(long VCP, String path); + + } Index: src/jni/org_libvirt_Connect.c =================================================================== RCS file: /data/cvs/libvirt-java/src/jni/org_libvirt_Connect.c,v retrieving revision 1.2 diff -u -r1.2 org_libvirt_Connect.c --- src/jni/org_libvirt_Connect.c 22 Jul 2008 08:27:42 -0000 1.2 +++ src/jni/org_libvirt_Connect.c 2 Aug 2008 15:21:11 -0000 @@ -6,7 +6,8 @@ #include <assert.h> -//TODO We are leaking UTFChars all over the place. We need to strcpy, then release every string we get from JAVA, and not use them directly! +//TODO We are leaking UTFChars all over the place. We need to release every string we get from JAVA with ReleaseStringUTFChars! (Done) +//TODO The same for *ArrayElements JNIEXPORT jint JNICALL Java_org_libvirt_Connect__1virInitialize (JNIEnv *env, jclass cls){ @@ -47,8 +48,11 @@ } JNIEXPORT jint JNICALL Java_org_libvirt_Connect__1getMaxVcpus - (JNIEnv *env, jobject obj, jlong VCP, jstring type){ - return virConnectGetMaxVcpus((virConnectPtr)VCP , (*env)->GetStringUTFChars(env, type, NULL)); + (JNIEnv *env, jobject obj, jlong VCP, jstring j_type){ + const char *type = (*env)->GetStringUTFChars(env, j_type, NULL); + int retval = (jlong)virConnectGetMaxVcpus((virConnectPtr)VCP, type); + (*env)->ReleaseStringUTFChars(env, j_type, type); + return retval; }; JNIEXPORT jstring JNICALL Java_org_libvirt_Connect__1getType @@ -76,7 +80,7 @@ JNIEXPORT jlong JNICALL Java_org_libvirt_Connect__1getVersion (JNIEnv *env, jobject obj, jlong VCP){ unsigned long hvVer=0; - int retval = virConnectGetVersion((virConnectPtr)VCP, &hvVer); + long retval = virConnectGetVersion((virConnectPtr)VCP, &hvVer); return (jlong)(hvVer); }; @@ -146,31 +150,35 @@ JNIEXPORT jlong JNICALL Java_org_libvirt_Connect__1open - (JNIEnv *env, jobject obj, jstring uri){ + (JNIEnv *env, jobject obj, jstring j_uri){ virConnectPtr vc; + const char *uri=(*env)->GetStringUTFChars(env, j_uri, NULL); //Initialize the libvirt VirtConn Object - vc=virConnectOpen((*env)->GetStringUTFChars(env, uri, NULL)); + vc=virConnectOpen(uri); + (*env)->ReleaseStringUTFChars(env, j_uri, uri); if(vc==NULL){ //We have a pending java exception, let's return assert((*env)->ExceptionOccurred(env)); return (jlong)NULL; } - //Initialized the error handler for this connection + //Initialize the error handler for this connection virConnSetErrorFunc(vc, env, virErrorHandler); return (jlong)vc; }; JNIEXPORT jlong JNICALL Java_org_libvirt_Connect__1openReadOnly - (JNIEnv *env, jobject obj, jstring uri){ + (JNIEnv *env, jobject obj, jstring j_uri){ virConnectPtr vc; - + const char *uri=(*env)->GetStringUTFChars(env, j_uri, NULL); + //Initialize the libvirt VirtConn Object - vc=virConnectOpenReadOnly((*env)->GetStringUTFChars(env, uri, NULL)); + vc=virConnectOpenReadOnly(uri); + (*env)->ReleaseStringUTFChars(env, j_uri, uri); if(vc==NULL){ //We have a pending java exception, let's return assert((*env)->ExceptionOccurred(env)); @@ -184,10 +192,10 @@ }; JNIEXPORT jlong JNICALL Java_org_libvirt_Connect__1openAuth - (JNIEnv *env, jobject obj, jstring uri, jobject j_auth, jint flags){ + (JNIEnv *env, jobject obj, jstring j_uri, jobject j_auth, jint flags){ virConnectPtr vc; - virError error; + const char *uri=(*env)->GetStringUTFChars(env, j_uri, NULL); virConnectAuth *auth = malloc(sizeof(virConnectAuth)); @@ -222,8 +230,9 @@ cb_wrapper->env = env; cb_wrapper->auth = j_auth; auth->cbdata=cb_wrapper; - - vc=virConnectOpenAuth((*env)->GetStringUTFChars(env, uri, NULL), auth, flags); + + vc=virConnectOpenAuth(uri, auth, flags); + (*env)->ReleaseStringUTFChars(env, j_uri, uri); if (vc==NULL){ //We have a pending java exception, let's return assert((*env)->ExceptionOccurred(env)); @@ -237,18 +246,27 @@ } JNIEXPORT jlong JNICALL Java_org_libvirt_Connect__1virNetworkCreateXML - (JNIEnv *env, jobject obj, jlong VCP, jstring xmlDesc){ - return (jlong)virNetworkCreateXML((virConnectPtr)VCP, (*env)->GetStringUTFChars(env, xmlDesc, NULL)); + (JNIEnv *env, jobject obj, jlong VCP, jstring j_xmlDesc){ + const char *xmlDesc=(*env)->GetStringUTFChars(env, j_xmlDesc, NULL); + jlong retval = (jlong)virNetworkCreateXML((virConnectPtr)VCP, xmlDesc); + (*env)->ReleaseStringUTFChars(env, j_xmlDesc, xmlDesc); + return retval; } JNIEXPORT jlong JNICALL Java_org_libvirt_Connect__1virNetworkDefineXML -(JNIEnv *env, jobject obj, jlong VCP, jstring xmlDesc){ - return (jlong)virNetworkDefineXML((virConnectPtr)VCP, (*env)->GetStringUTFChars(env, xmlDesc, NULL)); +(JNIEnv *env, jobject obj, jlong VCP, jstring j_xmlDesc){ + const char *xmlDesc=(*env)->GetStringUTFChars(env, j_xmlDesc, NULL); + jlong retval = (jlong)virNetworkDefineXML((virConnectPtr)VCP, xmlDesc); + (*env)->ReleaseStringUTFChars(env, j_xmlDesc, xmlDesc); + return retval; } JNIEXPORT jlong JNICALL Java_org_libvirt_Connect__1virNetworkLookupByName - (JNIEnv *env, jobject obj, jlong VCP, jstring name){ - return (jlong)virNetworkLookupByName((virConnectPtr)VCP, (*env)->GetStringUTFChars(env, name, NULL)); + (JNIEnv *env, jobject obj, jlong VCP, jstring j_name){ + const char *name=(*env)->GetStringUTFChars(env, j_name, NULL); + jlong retval = (jlong)virNetworkLookupByName((virConnectPtr)VCP, name); + (*env)->ReleaseStringUTFChars(env, j_name, name); + return retval; } JNIEXPORT jlong JNICALL Java_org_libvirt_Connect__1virNetworkLookupByUUID @@ -264,8 +282,11 @@ JNIEXPORT jlong JNICALL Java_org_libvirt_Connect__1virNetworkLookupByUUIDString - (JNIEnv *env, jobject obj, jlong VCP, jstring UUID){ - return (jlong)virNetworkLookupByUUIDString((virConnectPtr)VCP, (*env)->GetStringUTFChars(env, UUID, NULL)); + (JNIEnv *env, jobject obj, jlong VCP, jstring j_UUID){ + const char *uuid=(*env)->GetStringUTFChars(env, j_UUID, NULL); + jlong retval = (jlong)virNetworkLookupByUUIDString((virConnectPtr)VCP, uuid); + (*env)->ReleaseStringUTFChars(env, j_UUID, uuid); + return retval; } JNIEXPORT jobject JNICALL Java_org_libvirt_Connect__1virNodeInfo @@ -342,8 +363,11 @@ } JNIEXPORT jlong JNICALL Java_org_libvirt_Connect__1virDomainLookupByName - (JNIEnv *env, jobject obj, jlong VCP, jstring name){ - return (jlong)virDomainLookupByName((virConnectPtr)VCP, (*env)->GetStringUTFChars(env, name, NULL)); + (JNIEnv *env, jobject obj, jlong VCP, jstring j_name){ + const char *name=(*env)->GetStringUTFChars(env, j_name, NULL); + jlong retval = (jlong)virDomainLookupByName((virConnectPtr)VCP, name); + (*env)->ReleaseStringUTFChars(env, j_name, name); + return retval; } JNIEXPORT jlong JNICALL Java_org_libvirt_Connect__1virDomainLookupByUUID @@ -358,8 +382,11 @@ } JNIEXPORT jlong JNICALL Java_org_libvirt_Connect__1virDomainLookupByUUIDString - (JNIEnv *env, jobject obj, jlong VCP, jstring UUID){ - return (jlong)virDomainLookupByUUIDString((virConnectPtr)VCP, (*env)->GetStringUTFChars(env, UUID, NULL)); + (JNIEnv *env, jobject obj, jlong VCP, jstring j_UUID){ + const char *UUID=(*env)->GetStringUTFChars(env, j_UUID, NULL); + jlong retval = (jlong)virDomainLookupByUUIDString((virConnectPtr)VCP, UUID); + (*env)->ReleaseStringUTFChars(env, j_UUID, UUID); + return retval; } JNIEXPORT jlong JNICALL Java_org_libvirt_Connect__1virGetLibVirVersion @@ -376,26 +403,115 @@ type = (*env)->GetStringUTFChars(env, j_type, NULL); virGetVersion(&libVer, type, &typeVer); + (*env)->ReleaseStringUTFChars(env, j_type, type); return libVer; } JNIEXPORT jlong JNICALL Java_org_libvirt_Connect__1virDomainCreateLinux - (JNIEnv *env, jobject obj, jlong VCP, jstring xmlDesc, jint flags){ - return(jlong)virDomainCreateLinux((virConnectPtr)VCP, (*env)->GetStringUTFChars(env, xmlDesc, NULL), flags); + (JNIEnv *env, jobject obj, jlong VCP, jstring j_xmlDesc, jint flags){ + const char *xmlDesc=(*env)->GetStringUTFChars(env, j_xmlDesc, NULL); + jlong retval = (jlong)virDomainCreateLinux((virConnectPtr)VCP, xmlDesc, flags); + (*env)->ReleaseStringUTFChars(env, j_xmlDesc, xmlDesc); + return retval; } JNIEXPORT jlong JNICALL Java_org_libvirt_Connect__1virDomainDefineXML - (JNIEnv *env, jobject obj, jlong VCP, jstring xmlDesc){ - return(jlong)virDomainDefineXML((virConnectPtr)VCP, (*env)->GetStringUTFChars(env, xmlDesc, NULL)); + (JNIEnv *env, jobject obj, jlong VCP, jstring j_xmlDesc){ + const char *xmlDesc=(*env)->GetStringUTFChars(env, j_xmlDesc, NULL); + jlong retval = (jlong)virDomainDefineXML((virConnectPtr)VCP, xmlDesc); + (*env)->ReleaseStringUTFChars(env, j_xmlDesc, xmlDesc); + return retval; } JNIEXPORT jint JNICALL Java_org_libvirt_Connect__1virDomainRestore - (JNIEnv *env, jobject obj, jlong VCP, jstring from){ - return virDomainRestore((virConnectPtr)VCP, (char*)(*env)->GetStringUTFChars(env, from, NULL)); + (JNIEnv *env, jobject obj, jlong VCP, jstring j_from){ + const char *from=(*env)->GetStringUTFChars(env, j_from, NULL); + jint retval = (jint)virDomainRestore((virConnectPtr)VCP, from); + (*env)->ReleaseStringUTFChars(env, j_from, from); + return retval; } JNIEXPORT jint JNICALL Java_org_libvirt_Connect__1setDom0Memory (JNIEnv *env, jobject obj, jlong memory){ return virDomainSetMemory(NULL, memory); } + +JNIEXPORT jint JNICALL Java_org_libvirt_Connect__1numOfDefinedStoragePools + (JNIEnv *env, jobject obj, jlong VCP){ + return virConnectNumOfDefinedStoragePools((virConnectPtr)VCP); +} + +JNIEXPORT jint JNICALL Java_org_libvirt_Connect__1numOfStoragePools + (JNIEnv *env, jobject obj, jlong VCP){ + return virConnectNumOfStoragePools((virConnectPtr)VCP); +} + +JNIEXPORT jobjectArray JNICALL Java_org_libvirt_Connect__1listDefinedStoragePools +(JNIEnv *env, jobject obj, jlong VCP){ + int maxnames; + char **names; + int c; + jobjectArray j_names=NULL; + if((maxnames = virConnectNumOfDefinedStoragePools((virConnectPtr)VCP))<0) + return NULL; + names= (char**)calloc(maxnames, sizeof(char*)); + if(virConnectListDefinedStoragePools((virConnectPtr)VCP, names, maxnames)>=0){ + j_names= (jobjectArray)(*env)->NewObjectArray(env, maxnames, + (*env)->FindClass(env,"java/lang/String"), + (*env)->NewStringUTF(env,"")); + for(c=0; c<maxnames; c++){ + (*env)->SetObjectArrayElement(env, j_names, c, (*env)->NewStringUTF(env, names[c])); + } + } + free(names); + + return j_names; +} + +JNIEXPORT jobjectArray JNICALL Java_org_libvirt_Connect__1listStoragePools +(JNIEnv *env, jobject obj, jlong VCP){ + int maxnames; + char **names; + int c; + jobjectArray j_names=NULL; + if((maxnames = virConnectNumOfStoragePools((virConnectPtr)VCP))<0) + return NULL; + names= (char**)calloc(maxnames, sizeof(char*)); + if(virConnectListStoragePools((virConnectPtr)VCP, names, maxnames)>=0){ + j_names= (jobjectArray)(*env)->NewObjectArray(env, maxnames, + (*env)->FindClass(env,"java/lang/String"), + (*env)->NewStringUTF(env,"")); + for(c=0; c<maxnames; c++){ + (*env)->SetObjectArrayElement(env, j_names, c, (*env)->NewStringUTF(env, names[c])); + } + } + free(names); + + return j_names; +} + +JNIEXPORT jlong JNICALL Java_org_libvirt_Connect__1virStoragePoolCreateXML +(JNIEnv *env, jobject obj, jlong VCP, jstring j_xmlDesc, jint flags){ + const char *xmlDesc=(*env)->GetStringUTFChars(env, j_xmlDesc, NULL); + jlong retval = (jlong)virStoragePoolCreateXML((virConnectPtr)VCP, xmlDesc, flags); + (*env)->ReleaseStringUTFChars(env, j_xmlDesc, xmlDesc); + return retval; +} + +JNIEXPORT jlong JNICALL Java_org_libvirt_Connect__1virStoragePoolDefineXML +(JNIEnv *env, jobject obj, jlong VCP, jstring j_xmlDesc, jint flags){ + const char *xmlDesc=(*env)->GetStringUTFChars(env, j_xmlDesc, NULL); + jlong retval = (jlong)virStoragePoolDefineXML((virConnectPtr)VCP, xmlDesc, flags); + (*env)->ReleaseStringUTFChars(env, j_xmlDesc, xmlDesc); + return retval; +} + +JNIEXPORT jlong JNICALL Java_org_libvirt_Connect__1virStoragePoolLookupByName +(JNIEnv *env, jobject obj, jlong VCP, jstring j_name){ + const char *name=(*env)->GetStringUTFChars(env, j_name, NULL); + jlong retval = (jlong)virStoragePoolLookupByName((virConnectPtr)VCP, name); + (*env)->ReleaseStringUTFChars(env, j_name, name); + return retval; +} + Index: src/jni/Makefile.am =================================================================== RCS file: /data/cvs/libvirt-java/src/jni/Makefile.am,v retrieving revision 1.5 diff -u -r1.5 Makefile.am --- src/jni/Makefile.am 18 Jul 2008 14:37:21 -0000 1.5 +++ src/jni/Makefile.am 2 Aug 2008 15:21:11 -0000 @@ -4,7 +4,13 @@ org_libvirt_Domain.h \ org_libvirt_Domain_CreateFlags.h \ org_libvirt_Domain_MigrateFlags.h \ - org_libvirt_Domain_XMLFlags.h + org_libvirt_Domain_XMLFlags.h \ + org_libvirt_StoragePool_BuildFlags.h \ + org_libvirt_StoragePool_DeleteFlags.h \ + org_libvirt_StoragePool.h \ + org_libvirt_StorageVol_Type.h \ + org_libvirt_StorageVol_DeleteFlags.h \ + org_libvirt_StorageVol.h BUILT_SOURCES = $(GENERATED) @@ -18,12 +24,22 @@ org_libvirt_Domain.h org_libvirt_Domain_CreateFlags.h org_libvirt_Domain_MigrateFlags.h org_libvirt_Domain_XMLFlags.h : $(JAVA_CLASS_ROOT)/org/libvirt/Domain.class $(JAVAH) -classpath $(JAVA_CLASS_ROOT) org.libvirt.Domain + +org_libvirt_StoragePool.h org_libvirt_StoragePool_BuildFlags.h org_libvirt_StoragePool_DeleteFlags.h : $(JAVA_CLASS_ROOT)/org/libvirt/StoragePool.class + $(JAVAH) -classpath $(JAVA_CLASS_ROOT) org.libvirt.StoragePool + +org_libvirt_StorageVol.h org_libvirt_StorageVol_Type.h org_libvirt_StorageVol_DeleteFlags.h : $(JAVA_CLASS_ROOT)/org/libvirt/StorageVol.class + $(JAVAH) -classpath $(JAVA_CLASS_ROOT) org.libvirt.StorageVol lib_LTLIBRARIES = libvirt_jni.la libvirt_jni_la_SOURCES = \ org_libvirt_Network.c \ org_libvirt_Connect.c \ org_libvirt_Domain.c \ + org_libvirt_StoragePool.c \ + org_libvirt_StorageVol.c \ + generic.c \ + generic.h \ ErrorHandler.c \ ErrorHandler.h \ ConnectAuthCallbackBridge.c \ Index: libvirt-java.spec.in =================================================================== RCS file: /data/cvs/libvirt-java/libvirt-java.spec.in,v retrieving revision 1.9 diff -u -r1.9 libvirt-java.spec.in --- libvirt-java.spec.in 18 Jul 2008 14:37:21 -0000 1.9 +++ libvirt-java.spec.in 2 Aug 2008 15:21:10 -0000 @@ -1,7 +1,7 @@ Summary: Java bindings for the libvirt virtualization API Name: libvirt-java Version: @VERSION@ -Release: 1%{?dist} +Release: 2%{?dist} License: LGPLv2+ Group: Development/Libraries Source: http://libvirt.org/sources/java/libvirt-java-%{version}.tar.gz Index: src/jni/generic.c =================================================================== RCS file: src/jni/generic.c diff -N src/jni/generic.c --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ src/jni/generic.c 1 Jan 1970 00:00:00 -0000 @@ -0,0 +1,128 @@ +#include "generic.h" +#include <jni.h> +#include <stdlib.h> + +jint generic__virObj__int +(JNIEnv *env, jobject obj, jlong virObj1, int (*virFunc1)(void*) ){ + return (jint)virFunc1((void*)virObj1); +} + +jint generic__virObj_int__int + (JNIEnv *env, jobject obj, jlong virObj1, jint arg1, int (*virFunc1)(void*, int)){ + return (jint)virFunc1((void*)virObj1, arg1); +} + +jstring generic__virObj__conststring + (JNIEnv *env, jobject obj, jlong virObj1, const char* (*virFunc1)(void*)){ + jstring j_retstring=NULL; + const char *retstring; + if((retstring = virFunc1((void*)virObj1))){ + j_retstring = (*env)->NewStringUTF(env, retstring); + } + return j_retstring; +} + +jstring generic__virObj__string + (JNIEnv *env, jobject obj, jlong virObj1, char* (*virFunc1)(void*)){ + jstring j_retstring=NULL; + char *retstring; + if((retstring = virFunc1((void*)virObj1))){ + j_retstring = (*env)->NewStringUTF(env, retstring); + free(retstring); + } + return j_retstring; +} + +jstring generic__virObj_int__string + (JNIEnv *env, jobject obj, jlong virObj, jint arg1, char* (*virFunc1)(void*, int)){ + jstring j_retstring; + char* retstring = NULL; + if((retstring = virFunc1((void*)virObj, arg1))){ + j_retstring = (*env)->NewStringUTF(env, retstring); + free(retstring); + } + return j_retstring; +} + +jboolean generic_getAutostart + (JNIEnv *env, jobject obj, jlong virObj, int (*VirFunc1)(void*, int*)){ + int autostart=0; + VirFunc1((virStoragePoolPtr)virObj, &autostart); + return (jboolean)autostart; +} + +jintArray generic_getUUID + (JNIEnv *env, jobject obj, jlong virObj1, int (*virFunc1)(void*, unsigned char*)){ + unsigned char uuid[VIR_UUID_BUFLEN]; + jintArray j_uuid; + int c; + int uuidbyte; + + if(virFunc1((void*)virObj1, uuid)<0) + return NULL; + //unpack UUID + j_uuid=(*env)->NewIntArray(env, VIR_UUID_BUFLEN); + for(c=0; c<VIR_UUID_BUFLEN; c++){ + uuidbyte=uuid[c]; + (*env)->SetIntArrayRegion(env, j_uuid, c, 1, &uuidbyte); + } + return j_uuid; +} + +jstring generic_getUUIDString + (JNIEnv *env, jobject obj, jlong virObj, int (*virFunc1)(void*, char*)){ + char uuidString[VIR_UUID_STRING_BUFLEN]; + virFunc1((void*)virObj, uuidString); + return (*env)->NewStringUTF(env, uuidString); +} + +JNIEXPORT jobjectArray JNICALL generic_list_stringarray + (JNIEnv *env, jobject obj, jlong virObj, int (*virFunc1)(void*, char ** const, int), int (*virFunc2)(void*)){ + int maxnames; + char **names; + int c; + jobjectArray j_names=NULL; + if((maxnames = virFunc2((void*)virObj))<0) + return NULL; + names= (char**)calloc(maxnames, sizeof(char*)); + if(virFunc1((void*)virObj, names, maxnames)>=0){ + j_names= (jobjectArray)(*env)->NewObjectArray(env, maxnames, + (*env)->FindClass(env,"java/lang/String"), + (*env)->NewStringUTF(env,"")); + for(c=0; c<maxnames; c++){ + (*env)->SetObjectArrayElement(env, j_names, c, (*env)->NewStringUTF(env, names[c])); + } + } + free(names); + + return j_names; +} + +JNIEXPORT jlong JNICALL generic_lookupBy_string + (JNIEnv *env, jobject obj, jlong virObj, jstring j_stringid, void* (*virFunc1)(void*, const char *)){ + const char *stringid=(*env)->GetStringUTFChars(env, j_stringid, NULL); + jlong retval = (jlong)virFunc1((void*)virObj, stringid); + (*env)->ReleaseStringUTFChars(env, j_stringid, stringid); + return retval; +} + +JNIEXPORT jlong JNICALL generic_lookupBy_none + (JNIEnv *env, jobject obj, jlong virObj, void* (*virFunc1)(void*)){ + return (jlong)virFunc1((void*)virObj); +} + +JNIEXPORT jlong JNICALL generic_CreateDefineXML + (JNIEnv *env, jobject obj, jlong virObj, jstring j_xmlDesc, void* (*virFunc1) (void*, const char *)){ + const char *xmlDesc=(*env)->GetStringUTFChars(env, j_xmlDesc, NULL); + jlong retval = (jlong)virFunc1((void*)virObj, xmlDesc); + (*env)->ReleaseStringUTFChars(env, j_xmlDesc, xmlDesc); + return retval; +} + +JNIEXPORT jlong JNICALL generic_CreateDefineXML_with_flags + (JNIEnv *env, jobject obj, jlong virObj, jstring j_xmlDesc, jint flags, void* (*virFunc1) (void*, const char *, unsigned int)){ + const char *xmlDesc=(*env)->GetStringUTFChars(env, j_xmlDesc, NULL); + jlong retval = (jlong)virFunc1((void*)virObj, xmlDesc, flags); + (*env)->ReleaseStringUTFChars(env, j_xmlDesc, xmlDesc); + return retval; +} Index: src/jni/org_libvirt_StoragePool.c =================================================================== RCS file: src/jni/org_libvirt_StoragePool.c diff -N src/jni/org_libvirt_StoragePool.c --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ src/jni/org_libvirt_StoragePool.c 1 Jan 1970 00:00:00 -0000 @@ -0,0 +1,117 @@ +#include <libvirt/libvirt.h> +#include "org_libvirt_StoragePool.h" +#include "generic.h" + + +JNIEXPORT jint JNICALL Java_org_libvirt_StoragePool__1build + (JNIEnv *env, jobject obj, jlong VSPP, jint flags){ + return generic__virObj_int__int(env, obj, VSPP, flags, (int (*)(void*, int))&virStoragePoolBuild); +} + +JNIEXPORT jint JNICALL Java_org_libvirt_StoragePool__1create + (JNIEnv *env, jobject obj, jlong VSPP, jint flags){ + return generic__virObj_int__int(env, obj, VSPP, flags, (int (*)(void*, int))&virStoragePoolCreate); +} + +JNIEXPORT jint JNICALL Java_org_libvirt_StoragePool__1delete + (JNIEnv *env, jobject obj, jlong VSPP, jint flags){ + return generic__virObj_int__int(env, obj, VSPP, flags, (int (*)(void*, int))&virStoragePoolDelete); +} + +JNIEXPORT jint JNICALL Java_org_libvirt_StoragePool__1destroy + (JNIEnv *env, jobject obj, jlong VSPP){ + return generic__virObj__int(env, obj, VSPP, (int (*)(void*))&virStoragePoolDelete); +} + +JNIEXPORT jint JNICALL Java_org_libvirt_StoragePool__1free + (JNIEnv *env, jobject obj, jlong VSPP){ + return generic__virObj__int(env, obj, VSPP, (int (*)(void*))&virStoragePoolFree); +} + +JNIEXPORT jboolean JNICALL Java_org_libvirt_StoragePool__1getAutostart + (JNIEnv *env, jobject obj, jlong VSPP){ + return generic_getAutostart(env, obj, VSPP, (int (*)(void*, int*))&virStoragePoolGetAutostart); +} + +JNIEXPORT jobject JNICALL Java_org_libvirt_StoragePool__1getInfo + (JNIEnv *env, jobject obj, jlong VSPP){ + + virStoragePoolInfo storagePoolInfo; + + jobject j_info; + + //Get the data + if(virStoragePoolGetInfo((virStoragePoolPtr)VSPP, &storagePoolInfo)<0) + return NULL; + + //get the field Ids of info + jclass j_storagePoolInfo_cls = (*env)->FindClass(env,"org/libvirt/StoragePoolInfo"); + jmethodID j_storagePoolInfo_constructor = (*env)->GetMethodID(env, j_storagePoolInfo_cls, "<init>", "(IJJJ)V"); + + //Long live encapsulation + j_info=(*env)->NewObject(env, + j_storagePoolInfo_cls, + j_storagePoolInfo_constructor, + storagePoolInfo.state, + storagePoolInfo.capacity, + storagePoolInfo.allocation, + storagePoolInfo.available); + + return j_info; +} + +JNIEXPORT jstring JNICALL Java_org_libvirt_StoragePool__1getName + (JNIEnv *env, jobject obj, jlong VSPP){ + return generic__virObj__conststring(env, obj, VSPP, (const char* (*)(void*))&virStoragePoolGetName); +} + +JNIEXPORT jintArray JNICALL Java_org_libvirt_StoragePool__1getUUID + (JNIEnv *env, jobject obj, jlong VSPP){ + return generic_getUUID(env, obj, VSPP, (int (*)(void*, unsigned char*))&virStoragePoolGetUUID); +} + +JNIEXPORT jstring JNICALL Java_org_libvirt_StoragePool__1getUUIDString + (JNIEnv *env, jobject obj, jlong VSPP){ + return generic_getUUIDString(env, obj, VSPP, (int (*)(void*, char*))&virStoragePoolGetUUIDString); +} + +JNIEXPORT jstring JNICALL Java_org_libvirt_StoragePool__1getXMLDesc + (JNIEnv *env, jobject obj, jlong VSPP, jint flags){ + return generic__virObj_int__string(env, obj, VSPP, flags, (char* (*)(void*, int))&virStoragePoolGetXMLDesc); +} + +JNIEXPORT jobjectArray JNICALL Java_org_libvirt_StoragePool__1listVolumes + (JNIEnv *env, jobject obj, jlong VSPP){ + return generic_list_stringarray(env, obj, VSPP, (int (*)(void*, char ** const, int))&virStoragePoolListVolumes, (int (*)(void*))&virStoragePoolNumOfVolumes); +} + +JNIEXPORT jint JNICALL Java_org_libvirt_StoragePool__1numOfVolumes + (JNIEnv *env, jobject obj, jlong VSPP){ + return generic__virObj__int(env, obj, VSPP, (int (*)(void*))&virStoragePoolNumOfVolumes); +} + +JNIEXPORT void JNICALL Java_org_libvirt_StoragePool__1refresh + (JNIEnv *env, jobject obj, jlong VSPP, jint flags){ + generic__virObj_int__int(env, obj, VSPP, flags, (int (*)(void*, int))&virStoragePoolRefresh); +} + +JNIEXPORT void JNICALL Java_org_libvirt_StoragePool__1setAutostart + (JNIEnv *env, jobject obj, jlong VSPP, jint flags){ + generic__virObj_int__int(env, obj, VSPP, flags, (int (*)(void*, int))&virStoragePoolSetAutostart); +} + +JNIEXPORT void JNICALL Java_org_libvirt_StoragePool__1undefine +(JNIEnv *env, jobject obj, jlong VSPP){ + generic__virObj__int(env, obj, VSPP, (int (*)(void*))&virStoragePoolUndefine); +} + +JNIEXPORT jlong JNICALL Java_org_libvirt_StoragePool__1storageVolLookupByName + (JNIEnv *env, jobject obj, jlong VSPP, jstring name){ + return generic_lookupBy_string(env, obj, VSPP, name, (void* (*)(void*, const char *))&virStorageVolLookupByName); +} + +JNIEXPORT jlong JNICALL Java_org_libvirt_StoragePool__1storageVolCreateXML + (JNIEnv *env, jobject obj, jlong VSPP, jstring xmlDesc, jint flags){ + return generic_CreateDefineXML_with_flags(env, obj, VSPP, xmlDesc, flags, (void* (*)(void*, const char *, unsigned int))&virStorageVolCreateXML); +} + Index: src/org/libvirt/StorageVolInfo.java =================================================================== RCS file: src/org/libvirt/StorageVolInfo.java diff -N src/org/libvirt/StorageVolInfo.java --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ src/org/libvirt/StorageVolInfo.java 1 Jan 1970 00:00:00 -0000 @@ -0,0 +1,53 @@ +package org.libvirt; + +public class StorageVolInfo { + + /** + * The type of the Volume + */ + public VirStorageVolType type; + /** + * Logical size bytes + */ + public long capacity; + /** + * Current allocation bytes + */ + public long allocation; + + public static enum VirStorageVolType{ + /** + * Regular file based volumes + */ + VIR_STORAGE_VOL_FILE, + /** + * Block based volumes + */ + VIR_STORAGE_VOL_BLOCK, + } + + /** + * This is meant to be called from the JNI side, as a convenience constructor + * + * @param type the type, as defined by libvirt + * @param capacity + * @param allocation + */ + StorageVolInfo(int type, long capacity, long allocation){ + switch(type){ + case 0: this.type=VirStorageVolType.VIR_STORAGE_VOL_FILE; break; + case 1: this.type=VirStorageVolType.VIR_STORAGE_VOL_BLOCK; break; + default: assert(false); + } + this.capacity = capacity; + this.allocation = allocation; + } + + public String toString(){ + StringBuffer result = new StringBuffer(""); + result.append("type:" + type + "\n"); + result.append("capacity:" + capacity + "\n"); + result.append("allocation:" + allocation + "\n"); + return result.toString(); + } +} Index: src/org/libvirt/StorageVol.java =================================================================== RCS file: src/org/libvirt/StorageVol.java diff -N src/org/libvirt/StorageVol.java --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ src/org/libvirt/StorageVol.java 1 Jan 1970 00:00:00 -0000 @@ -0,0 +1,158 @@ +package org.libvirt; + +public class StorageVol { + + static final class DeleteFlags{ + /** + * Delete metadata only (fast) + */ + static final int VIR_STORAGE_POOL_DELETE_NORMAL = 0; + /** + * Clear all data to zeros (slow) + */ + static final int VIR_STORAGE_POOL_DELETE_ZEROED = 1; + } + + public static enum Type { + /** + * Regular file based volumes + */ + VIR_STORAGE_VOL_FILE, + /** + * Block based volumes + */ + VIR_STORAGE_VOL_BLOCK + } + + /** + * the native virStorageVolPtr. + */ + private long VSVP; + + /** + * The VirConnect Object that represents the Hypervisor of this Domain + */ + private Connect virConnect; + + + /** + * Constructs a VirStorageVol object from a known native virStoragePoolPtr, and a VirConnect object. + * For use when native libvirt returns a virStorageVolPtr, i.e. error handling. + * + * @param virConnect the Domain's hypervisor + * @param VSVP the native virStorageVolPtr + */ + StorageVol(Connect virConnect, long VSVP){ + this.virConnect = virConnect; + this.VSVP = VSVP; + } + + /** + * Fetch a storage pool which contains this volume + * + * @return StoragePool object, + * @throws LibvirtException + */ + public StoragePool storagePoolLookupByVolume() + throws LibvirtException { + return new StoragePool(virConnect, _storagePoolLookupByVolume(VSVP)); + } + + private native long _storagePoolLookupByVolume(long VSVP) + throws LibvirtException; + + /** + * Delete the storage volume from the pool + * + * @param flags future flags, use 0 for now + * @throws LibvirtException + */ + public void delete(int flags) throws LibvirtException{ + _delete(VSVP, flags); + } + + private native int _delete(long VSVP, int flags) throws LibvirtException; + + /** + * Release the storage volume handle. The underlying storage volume contains to exist + * + * @throws LibvirtException + */ + public void free() throws LibvirtException{ + _free(VSVP); + } + + private native int _free(long VSVP) throws LibvirtException; + + /** + * Provides the connection object associated with a storage volume. The reference counter on the connection is not increased by this call. + * + * @return the Connect object + */ + public Connect getConnect(){ + return virConnect; + } + + /** + * Fetches volatile information about the storage volume such as its current allocation + * + * @return StorageVolInfo object + * @throws LibvirtException + */ + public StorageVolInfo getInfo() throws LibvirtException{ + return _getInfo(VSVP); + } + + private native StorageVolInfo _getInfo(long VSVP) throws LibvirtException; + + /** + * Fetch the storage volume key. This is globally unique, so the same volume will have the same key no matter what host it is accessed from + * + * @return the key + * @throws LibvirtException + */ + public String getKey() throws LibvirtException{ + return _getKey(VSVP); + } + + private native String _getKey(long VSVP) throws LibvirtException; + + /** + * Fetch the storage volume name. This is unique within the scope of a pool + * + * @return the name + * @throws LibvirtException + */ + public String getName() throws LibvirtException{ + return _getName(VSVP); + } + + private native String _getName(long VSVP) throws LibvirtException; + + /** + * Fetch the storage volume path. + * Depending on the pool configuration this is either persistent across hosts, or dynamically assigned at pool startup. + * Consult pool documentation for information on getting the persistent naming + * + * @return + * @throws LibvirtException + */ + public String getPath() throws LibvirtException{ + return _getPath(VSVP); + } + + private native String _getPath(long VSVP) throws LibvirtException; + + /** + * Fetch an XML document describing all aspects of this storage volume + * + * @param flags flags for XML generation (unused, pass 0) + * @return the XML document + * @throws LibvirtException + */ + public String getXMLDesc(int flags) throws LibvirtException{ + return _getXMLDesc(VSVP, flags); + } + + private native String _getXMLDesc(long VSVP, int flags) throws LibvirtException; +} Index: src/org/libvirt/StoragePoolInfo.java =================================================================== RCS file: src/org/libvirt/StoragePoolInfo.java diff -N src/org/libvirt/StoragePoolInfo.java --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ src/org/libvirt/StoragePoolInfo.java 1 Jan 1970 00:00:00 -0000 @@ -0,0 +1,73 @@ +package org.libvirt; + +public class StoragePoolInfo { + + /** + * the running state + */ + public StoragePoolState state; + + /** + * Logical size bytes + */ + public long capacity; + + /** + * Current allocation bytes + */ + public long allocation; + + /** + * Remaining free space bytes + */ + public long available; + + public static enum StoragePoolState { + /** + * Not running + */ + VIR_STORAGE_POOL_INACTIVE, + /** + * Initializing pool, not available + */ + VIR_STORAGE_POOL_BUILDING, + /** + * Running normally + */ + VIR_STORAGE_POOL_RUNNING, + /** + * Running degraded + */ + VIR_STORAGE_POOL_DEGRADED, + } + + /** + * This is meant to be called from the JNI side, as a convenience constructor + * + * @param state the state, as defined by libvirt + * @param capacity + * @param allocation + * @param available + */ + StoragePoolInfo(int state, long capacity, long allocation, long available){ + switch(state){ + case 0: this.state=StoragePoolState.VIR_STORAGE_POOL_INACTIVE; break; + case 1: this.state=StoragePoolState.VIR_STORAGE_POOL_BUILDING; break; + case 2: this.state=StoragePoolState.VIR_STORAGE_POOL_RUNNING; break; + case 3: this.state=StoragePoolState.VIR_STORAGE_POOL_DEGRADED; break; + default: assert(false); + } + this.capacity = capacity; + this.allocation = allocation; + this.available = available; + } + + public String toString(){ + StringBuffer result = new StringBuffer(""); + result.append("state:" + state + "\n"); + result.append("capacity:" + capacity + "\n"); + result.append("allocation:" + allocation + "\n"); + result.append("available:" + available + "\n"); + return result.toString(); + } +} Index: src/org/libvirt/StoragePool.java =================================================================== RCS file: src/org/libvirt/StoragePool.java diff -N src/org/libvirt/StoragePool.java --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ src/org/libvirt/StoragePool.java 1 Jan 1970 00:00:00 -0000 @@ -0,0 +1,286 @@ +package org.libvirt; + +public class StoragePool { + + static final class BuildFlags{ + /** + * Regular build from scratch + */ + static final int VIR_STORAGE_POOL_BUILD_NEW = 0; + /** + * Repair / reinitialize + */ + static final int VIR_STORAGE_POOL_BUILD_REPAIR = 1; + /** + * Extend existing pool + */ + static final int VIR_STORAGE_POOL_BUILD_RESIZE = 2; + } + + static final class DeleteFlags{ + /** + * Delete metadata only (fast) + */ + static final int VIR_STORAGE_POOL_DELETE_NORMAL = 0; + /** + * Clear all data to zeros (slow) + */ + static final int VIR_STORAGE_POOL_DELETE_ZEROED = 1; + } + + /** + * the native virStoragePoolPtr. + */ + private long VSPP; + + /** + * The VirConnect Object that represents the Hypervisor of this Domain + */ + private Connect virConnect; + + + /** + * Constructs a VirStoragePool object from a known native virStoragePoolPtr, and a VirConnect object. + * For use when native libvirt returns a virStoragePoolPtr, i.e. error handling. + * + * @param virConnect the Domain's hypervisor + * @param VSPP the native virStoragePoolPtr + */ + StoragePool(Connect virConnect, long VSPP){ + this.virConnect = virConnect; + this.VSPP = VSPP; + } + + /** + * Build the underlying storage pool + * + * @param flags future flags, use 0 for now + */ + public void build(int flags) throws LibvirtException{ + _build(VSPP, flags); + } + + private native int _build(long VSPP, int flags) throws LibvirtException; + + /** + * Starts this inactive storage pool + * + * @param flags future flags, use 0 for now + */ + public void create(int flags) throws LibvirtException{ + _create(VSPP, flags); + } + + private native int _create(long VSPP, int flags) throws LibvirtException; + + /** + * Delete the underlying pool resources. This is a non-recoverable operation. + * The virStoragePool object itself is not free'd. + * + * @param flags flags for obliteration process + */ + public void delete(int flags) throws LibvirtException{ + _delete(VSPP, flags); + } + + private native int _delete(long VSPP, int flags) throws LibvirtException; + + /** + * Destroy an active storage pool. + * This will deactivate the pool on the host, but keep any persistent config associated with it. + * If it has a persistent config it can later be restarted with virStoragePoolCreate(). + * This does not free the associated virStoragePoolPtr object. + */ + public void destroy() throws LibvirtException{ + _destroy(VSPP); + } + + private native int _destroy(long VSPP) throws LibvirtException; + + /** + * Free a storage pool object, releasing all memory associated with it. + * Does not change the state of the pool on the host. + */ + public void free() throws LibvirtException{ + _free(VSPP); + } + + private native int _free(long VSPP) throws LibvirtException; + + + /** + * Fetches the value of the autostart flag, which determines whether the pool is automatically started at boot time + * + * @return the result + * @throws LibvirtException + */ + public boolean getAutostart() throws LibvirtException{ + return _getAutostart(VSPP); + } + + private native boolean _getAutostart(long VSPP) throws LibvirtException; + + /** + * Provides the connection pointer associated with a storage pool. + * + * @return the Connect object + */ + public Connect getConnect(){ + return virConnect; + } + /** + * Get volatile information about the storage pool such as free space / usage summary + * + * @return a StoragePoolInfo object describing this storage pool + * @throws LibvirtException + */ + public StoragePoolInfo getInfo() throws LibvirtException{ + return _getInfo(VSPP); + } + + private native StoragePoolInfo _getInfo(long VSPP) throws LibvirtException; + + /** + * Fetch the locally unique name of the storage pool + * + * @return the name + * @throws LibvirtException + */ + public String getName() throws LibvirtException{ + return _getName(VSPP); + } + + private native String _getName(long VSPP) throws LibvirtException; + + /** + * Fetch the globally unique ID of this storage pool + * + * @return the UUID as an unpacked int array + * @throws LibvirtException + */ + public int[] getUUID() throws LibvirtException{ + return _getUUID(VSPP); + } + + private native int[] _getUUID(long VSPP) throws LibvirtException; + + + /** + * Fetch the globally unique ID of the storage pool as a string + * + * @return the UUID in canonical String format + * @throws LibvirtException + */ + public String getUUIDString() throws LibvirtException{ + return _getUUIDString(VSPP); + } + + private native String _getUUIDString(long VSPP) throws LibvirtException; + + /** + * Fetch an XML document describing all aspects of the storage pool. + * This is suitable for later feeding back into the virStoragePoolCreateXML method. + * + * @param flags flags for XML format options (set of virDomainXMLFlags) + * @return a XML document + *-java @throws LibvirtException + */ + public String getXMLDesc(int flags) throws LibvirtException{ + return _getXMLDesc(VSPP, flags); + } + + private native String _getXMLDesc(long VSPP, int flags) throws LibvirtException; + + /** + * Fetch list of storage volume names + * + * @return an Array of Strings that contains the names of the storage volumes + * @throws LibvirtException + */ + public String[] listVolumes() throws LibvirtException { + return _listVolumes(VSPP); + } + + private native String[] _listVolumes(long VSPP) + throws LibvirtException; + + /** + * Fetch the number of storage volumes within a pool + * + * @return the number of storage pools + * @throws LibvirtException + */ + public int numOfVolumes() throws LibvirtException { + return _numOfVolumes(VSPP); + } + + private native int _numOfVolumes(long VSPP) throws LibvirtException; + + /** + * Request that the pool refresh its list of volumes. + * This may involve communicating with a remote server, and/or initializing new devices at the OS layer + * + * @param flags flags to control refresh behaviour (currently unused, use 0) + * @throws LibvirtException + */ + public void refresh(int flags) throws LibvirtException { + _refresh(VSPP, flags); + } + + private native void _refresh(long VSPP, int flags) throws LibvirtException; + + /** + * Sets the autostart flag + * + * @param autostart new flag setting + * @throws LibvirtException + */ + public void setAutostart(int autostart) throws LibvirtException { + _setAutostart(VSPP, autostart); + } + + private native void _setAutostart(long VSPP, int autostart) throws LibvirtException; + + /** + * Undefine an inactive storage pool + * + * @throws LibvirtException + */ + public void undefine() throws LibvirtException { + _undefine(VSPP); + } + + private native void _undefine(long VSPP) throws LibvirtException; + + /** + * Fetch an object representing to a storage volume based on its name within a pool + * + * @param name name of storage volume + * @return The StorageVol object found + * @throws LibvirtException + */ + public StorageVol storageVolLookupByName(String name) + throws LibvirtException { + return new StorageVol(virConnect, _storageVolLookupByName(VSPP, name)); + } + + private native long _storageVolLookupByName(long VSPP, String name) + throws LibvirtException; + + /** + * Create a storage volume within a pool based on an XML description. Not all pools support creation of volumes + * + * @param xmlDesc description of volume to create + * @param flags flags for creation (unused, pass 0) + * @return the storage volume + * @throws LibvirtException + */ + public StorageVol storageVolCreateXML(String xmlDesc, int flags) + throws LibvirtException { + return new StorageVol(virConnect, _storageVolCreateXML(VSPP, xmlDesc, flags)); + } + + private native long _storageVolCreateXML(long VSPP, String xmlDesc, int flags) + throws LibvirtException; + +} Index: src/jni/org_libvirt_StorageVol.c =================================================================== RCS file: src/jni/org_libvirt_StorageVol.c diff -N src/jni/org_libvirt_StorageVol.c --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ src/jni/org_libvirt_StorageVol.c 1 Jan 1970 00:00:00 -0000 @@ -0,0 +1,65 @@ +#include "org_libvirt_StorageVol.h" +#include "generic.h" +#include <libvirt/libvirt.h> + +JNIEXPORT jlong JNICALL Java_org_libvirt_StorageVol__1storagePoolLookupByVolume + (JNIEnv *env, jobject obj, jlong VSVP){ + return generic_lookupBy_none(env, obj, VSVP, (void* (*)(void*))&virStoragePoolLookupByVolume); +} + +JNIEXPORT jint JNICALL Java_org_libvirt_StorageVol__1delete + (JNIEnv *env, jobject obj, jlong VSVP, jint flags){ + return generic__virObj_int__int(env, obj, VSVP, flags, (int (*)(void*, int))&virStorageVolDelete); +} + +JNIEXPORT jint JNICALL Java_org_libvirt_StorageVol__1free + (JNIEnv *env, jobject obj, jlong VSVP){ + return generic__virObj__int(env, obj, VSVP, (int (*)(void*))&virStorageVolFree); +} + +JNIEXPORT jobject JNICALL Java_org_libvirt_StorageVol__1getInfo +(JNIEnv *env, jobject obj, jlong VSVP){ + + virStorageVolInfo storageVolInfo; + + jobject j_info; + + //Get the data + if(virStorageVolGetInfo((virStorageVolPtr)VSVP, &storageVolInfo)<0) + return NULL; + + //get the field Ids of info + jclass j_storageVolInfo_cls = (*env)->FindClass(env,"org/libvirt/StorageVolInfo"); + jmethodID j_storageVolInfo_constructor = (*env)->GetMethodID(env, j_storageVolInfo_cls, "<init>", "(IJJ)V"); + + //Long live encapsulation + j_info=(*env)->NewObject(env, + j_storageVolInfo_cls, + j_storageVolInfo_constructor, + storageVolInfo.type, + storageVolInfo.capacity, + storageVolInfo.allocation); + + return j_info; +} + +JNIEXPORT jstring JNICALL Java_org_libvirt_StorageVol__1getKey + (JNIEnv *env, jobject obj, jlong VSVP){ + return generic__virObj__conststring(env, obj, VSVP, (const char* (*)(void*))&virStorageVolGetKey); +} + +JNIEXPORT jstring JNICALL Java_org_libvirt_StorageVol__1getName + (JNIEnv *env, jobject obj, jlong VSVP){ + return generic__virObj__conststring(env, obj, VSVP, (const char* (*)(void*))&virStorageVolGetName); +} + +JNIEXPORT jstring JNICALL Java_org_libvirt_StorageVol__1getPath + (JNIEnv *env, jobject obj, jlong VSVP){ + return generic__virObj__string(env, obj, VSVP, (char* (*)(void*))&virStorageVolGetPath); +} + +JNIEXPORT jstring JNICALL Java_org_libvirt_StorageVol__1getXMLDesc + (JNIEnv *env, jobject obj, jlong VSVP, jint flags){ + return generic__virObj_int__string(env, obj, VSVP, flags, (char* (*)(void*, int))&virStorageVolGetXMLDesc); +} + Index: src/jni/generic.h =================================================================== RCS file: src/jni/generic.h diff -N src/jni/generic.h --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ src/jni/generic.h 1 Jan 1970 00:00:00 -0000 @@ -0,0 +1,88 @@ +#ifndef GENERIC_H_ +#define GENERIC_H_ +#include <jni.h> +#include <libvirt/libvirt.h> + +/* + * Generic wrapper with a virObj argument returning an int + * (for functions like virDomainFree) + */ +jint generic__virObj__int + (JNIEnv *env, jobject obj, jlong virObj1, int (*virFunc1)(void*)); + +/* + * Generic wrapper with a virObj and an int arguments returning an int + * (for functions like virStorageVolDelete) + */ +jint generic__virObj_int__int + (JNIEnv *env, jobject obj, jlong virObj1, jint arg1, int (*virFunc1)(void*, int)); + +/* + * Generic wrapper with a virObj arguments returning a constant String + * (for functions like virNetworkGetBridgeName ) + */ +jstring generic__virObj__conststring + (JNIEnv *env, jobject obj, jlong virObj1, const char* (*virFunc1)(void*)); + +/* + * Generic wrapper with a virObj arguments returning a String to be freed by the caller + * (for functions like virNetworkGetName) + */ +jstring generic__virObj__string + (JNIEnv *env, jobject obj, jlong virObj1, char* (*virFunc1)(void*)); + +/* + * Generic wrapper with a virObj and an int argument returning a String to be freed by the caller + * (for functions like virStoragePoolGetXMLDesc) + */ +jstring generic__virObj_int__string + (JNIEnv *env, jobject obj, jlong virObj, jint arg1, char* (*virFunc1)(void*, int)); + +/* + * Generic wrapper for the *getAutoStart functions + */ +jboolean generic_getAutostart + (JNIEnv *env, jobject obj, jlong virObj, int (*VirFunc1)(void*, int*)); + +/* + * Generic wrapper for the *getUUID functions + */ +jintArray generic_getUUID + (JNIEnv *env, jobject obj, jlong virObj1, int (*virFunc1)(void*, unsigned char*)); + +/* + * Generic wrapper for the *getUUIDString functions + */ +jstring generic_getUUIDString + (JNIEnv *env, jobject obj, jlong virObj, int (*virFunc1)(void*, char*)); + +/* + * Generic wrapper for the *List* functions that return an array of strings + * virFunc1 is the *List* function + * virFunc2 is the corresponding *NumOf* function + */ +JNIEXPORT jobjectArray JNICALL generic_list_stringarray + (JNIEnv *env, jobject obj, jlong virObj, int (*virFunc1)(void*, char ** const, int), int (*virFunc2)(void*)); + +/* + * Generic wrapper for the *LookupBy* functions that take a string and return a VirObject + */ +JNIEXPORT jlong JNICALL generic_lookupBy_string + (JNIEnv *env, jobject obj, jlong virObj, jstring j_stringid, void* (*virFunc1)(void*, const char *)); + +/* + * Generic wrapper for the *LookupBy* functions that take no argument and return a VirObject + */ +JNIEXPORT jlong JNICALL generic_lookupBy_none + (JNIEnv *env, jobject obj, jlong virObj, void* (*virFunc1)(void*)); + +/* + * Generic wrapper for the *CreateXML* and *DefineXML* functions that take no flags and return VirObject + */ +JNIEXPORT jlong JNICALL generic_CreateDefineXML + (JNIEnv *env, jobject obj, jlong virObj, jstring j_xmlDesc, void* (*virFunc1) (void*, const char *)); + +JNIEXPORT jlong JNICALL generic_CreateDefineXML_with_flags + (JNIEnv *env, jobject obj, jlong virObj, jstring j_xmlDesc, jint flags, void* (*virFunc1) (void*, const char *, unsigned int)); + +#endif /*GENERIC_H_*/

8 10

[libvirt] [PATCH] make distclean: remove generated source files
by Jim Meyering 05 Aug '08

05 Aug '08

"make distcheck" is failing because two generated source files are left behind. It requires that all generated files be removed. This fixes it: >From a7f4c47140ed0e585f1135e0f7917bc32f145997 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Mon, 4 Aug 2008 16:10:03 +0200 Subject: [PATCH] make distclean: remove generated source files * src/Makefile.am (DISTCLEANFILES): Define to $(BUILT_SOURCES) so "make distcheck" passes. --- src/Makefile.am | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 556ad0a..5d238cd 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -189,3 +189,4 @@ install-exec-local: $(MKDIR_P) $(DESTDIR)$(localstatedir)/cache/libvirt CLEANFILES = *.gcov .libs/*.gcda .libs/*.gcno *.gcno *.gcda +DISTCLEANFILES = $(BUILT_SOURCES) -- 1.6.0.rc1.36.g5ff70

3 3

[libvirt] fix syntax check error
by Atsushi SAKAI 04 Aug '08

04 Aug '08

Hi, This patch fixes syntax error(found TAB(s)) http://builder.virt-manager.org/module-libvirt--devel.html Thanks Atsushi SAKAI

3 2

[libvirt] Question about virbr(dnsmasq)
by Nobuhiro Itou 04 Aug '08

04 Aug '08

Hi all. I have the question about the option of dnsmasq that libvirt sets as a default virtual network. Why does dnsmasq listen to all NICs as specified "--except-interface lo"? And, at the following conditions, the message is output to /var/log/messages. Do you know why it is output? Conditions: 1) Dnsmasq is started by libvirt. And... # ps -ef | grep dnsmasq nobody 5877 5754 0 Jul30 ? 00:00:00 /usr/sbin/dnsmasq --keep-in-foreground --strict-order --bind-interfaces --pid-file --conf-file --listen-address 192.168.122.1 --except-interface lo --dhcp-leasefile=/var/lib/libvirt/dhcp-default.leases --dhcp-range 192.168.122.2,192.168.122.254 2) chenge the network address to '0.0.0.0'. And... # ifconfig eth3 0 up 3) Dnsmasq recieves DHCPINFORM message from other DHCP servers. Message: dnsmasq[5877]: no address range available for DHCP request via eth3 Thank you Nobuhiro Itou

2 2