- Devel - libvirt List Archives

[libvirt] [PATCH]: (trivial) getpwuid is not OOM
by Guido Günther 07 Oct '08

07 Oct '08

Hi, we shouldn't print an oom error message when actually getpwuid failed. Cheers, -- Guido

2 1

[libvirt] When bridge doesn't exist
by Anton Protopopov 07 Oct '08

07 Oct '08

Assume that we want to add a bridge to LAN to a guest. We saying to libvirt: ... <interface type="bridge"> <source bridge="BRIDGE"> </interface> ... What is the right behaviour of libvirt in case bridge BRIDGE doesn't exist---return an error or try to create that bridge? If it is the former, then who must create that bridge?

1 0

[libvirt] Routed Networking - Ubuntu Hardy KVM and LibVirt
by Barry Robinson 07 Oct '08

07 Oct '08

Gday, I have been searching for information on how to configure KVM guest OS' to do simple routing from their associated vnetX address to the host machine's ethernet network subnet (lets say eth0/192.168.0.0/24). I understand that by default the clients are NAT'ed to the Host's adapter. This is a handy feature, but it does not suit the setup I am trying to apply. Basically, I am trying to do simple routing from the host subnet (192.168.0.0/24) to the client's subnet (192.168.17.0/24), and back again. So I can talk to 192.168.0.0/24 addresses and they can talk to 192.168.17.0/24 (routing rule has been added so this is possible). There should be no NAT involved. The following is about as close as I have come to getting this solution. However, I still need to add in the iptables -A FORWARD -i vnetX -o eth0 -j ACCEPT rule in after the machine is booted. Is it possible to do this as part of the script process, or is there a post-ifup script that can be run? /etc/libvirt/qemu/network/routed-net.xml: <network> <name>routed-net</name> <uuid></uuid> <bridge name="virbr%d" /> <ip address="192.168.32.1" netmask="255.255.255.0"> <dhcp> <range start="192.168.32.33" end="192.168.32.63" /> </dhcp> </ip> </network> I have tried using the <forward='routed' /> option (under the bridge name option). This does add the forward rules, but for some reason still applies the MASQUERADE rule to the 192.168.17.0/24 network. (eg. 0 0 MASQUERADE all -- * * 192.168.32.0/24 0.0.0.0/0 ) libvirtd seems to hide it's firewall rulesets pretty well, cause I can't even find them to manually add/remove rules. Not in any place obvious (that I can find), like /etc. Any help would be appreciated. Apologies if this topic has been covered... can't find it anywhere using Google. Cheers, Barry Linseed Technologies Open Source IT Solutions Phone: 0415131452 Email: brobinson(a)linseed.com.au Website: http://www.linseed.com.au

2 1

[libvirt] PATCH: 0 of 5: Remove all linked lists
by Daniel P. Berrange 07 Oct '08

07 Oct '08

I've been doing some proof of concept work to make the libvirtd daemon multi-threaded, and this in turns mean that the QEMU / LXC / OpenVZ drivers need to have some degree of locking on their internal data structures. Unforatunately the internal domain/network/storage APIs make extensive use of linked lists for tracking objects. This makes it incredibly hard to do fine grained locking of individual objects - eg, deleting one object requires locking the object it points to, and one the pointing to it in the linked list, as well as the list itself. This would be so complex we'd inevitably introduce locking bugs. So the series of patches which follow replace all linked lists with explicitly sized arrays. This means I only need 2 levels of locks, one on the driver object, and one of the domain/network/storage object being manipulated. The semantics for this are nice & easy to define. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 13

[libvirt] [PATCH] Centralize use of DEBUG macros
by Cole Robinson 06 Oct '08

06 Oct '08

Currently the DEBUG and DEBUG0 macros are duplicated in every file that uses them. This patch moves the macros to internal.h, removes the needless duplication, and now every file gets them for free. Seems to work as expected in my testing. Thanks, Cole

3 6

[libvirt] [PATCH] Slim xmllint test output
by Cole Robinson 06 Oct '08

06 Oct '08

This patch simply slims down the output from the xmllint tests to not overrun a single line, only printing the relevant information about the xml file (parent directory and name, not fully qualified path). Purely cosmetic, but more useful IMO. Thanks, Cole

2 2

[libvirt] [PATCH] Fix possible segfault if starting qemu vm with an inactive virtual network
by Cole Robinson 06 Oct '08

06 Oct '08

The attached patch fixes a possible segfault if trying to start a domain which tries to use an inactive virtual network. We should explicitly catch that error and report it, but that's a separate patch. Thanks, Cole

3 3

[libvirt] [PATCH] use C99 initializers for virState
by Guido Günther 06 Oct '08

06 Oct '08

Hi, attached patch uses C99 initializers for virStateDriver. Makes reading easier and extending the structure less error prone. -- Guido

3 2

[libvirt] [PATCH] fix build in separate build-dir
by Guido Günther 06 Oct '08

06 Oct '08

Hi, building in a separate build dir is currently broken since the Makefile is looking for libvirt.policy in the wrong location. Fix attached. Cheers, -- Guido

2 1

[libvirt] [discuss] The new cgroup patches for libvirt
by Balbir Singh 03 Oct '08

03 Oct '08

Hi, Everyone, I've seen a new set of patches from Dan Smith, which implement cgroup support for libvirt. While the patches seem simple, there are some issues that have been pointed out in the posting itself. I hope that libvirt will switch over (may be after your concerns are addressed and definitely in the longer run) to using libcgroups rather than having an internal implementation of cgroups. The advantages of switching over would be using the functionality that libcgroup already provides libcgroups (libcg.sf.net) provides 1. Ability to configure and mount cgroups and controllers via initscripts and a configuration file 2. An API to control and read cgroups information 3. Thread safety around API calls 4. Daemons to automatically classify a task based on a certain set of rules 5. API to extract current cgroup classification (where is the task currently in the cgroup hierarchy) While re-implementing might sound like a cool thing to do, here are the drawbacks 1. It leads to code duplication and reduces code reuse 2. It leads to confused users I understand that in the past there has been a perception that libcgroups might not yet be ready, because we did not have ABI stability built into the library and the header file had old comments about things changing. I would urge the group to look at the current implementation of libcgroups (look at v0.32) and help us 1. Fix any issues you see or point them to us 2. Add new API or request for new API that can help us integrate better with libvirt -- Balbir

4 11

[libvirt] [PATCH 0 of 2] [RFC] Add cgroup manipulation and LXC driver support
by Dan Smith 03 Oct '08

03 Oct '08

This patch set adds basic cgroup support to the LXC driver. It consists of a small internal cgroup manipulation API, as well as changes to the driver itself to utilize the support. Currently, we just set a memory limit and the allowed devices list. The cgroup.{c,h} interface can be easily redirected to libcgroup in the future if and when the decision to move in that direction is made. Some discussion on the following points is probably warranted, to help determine how deep we want to go with this internal implementation, in terms' of supporting complex system configurations, etc. - What to do if controllers are mounted in multiple places - What to do if memory and device controllers aren't present - What to do if the root group is set for exclusive cpuset behavior Some additional caveats are noted per-patch as well.

3 16

[libvirt] [PATCH 0 of 2] Add cgroup manipulation and LXC driver support
by Dan Smith 03 Oct '08

03 Oct '08

This is my updated set for cgroup manipulation. I think I have addressed all of the concerns and comments so far. There are no major caveats I'm aware of with this round.

3 15

[libvirt] [PATCH] Clean up some uses qemudDebug
by Cole Robinson 02 Oct '08

02 Oct '08

The patch cleans up some uses of qemudDebug, moving them over to use the DEBUG macros. There are still lots of uses of qemudDebug in qemud/*, but I don't know if they can/should be moved over to use DEBUG. Thanks, Cole

1 0

[libvirt] [PATCH] Fix > 1 char device for qemu VM
by Cole Robinson 02 Oct '08

02 Oct '08

Trying to start a qemu guest with more than 1 character device (serial or parallel, doesn't count for console) always times out. There was an error in the code that would strip the pty path qemu spits out, which confused the parsing after being called more than twice. The attached patch fixes this. I verified that guests with 0, 1, and 2 serial devices all boot fine. Thanks, Cole

3 4

[libvirt] ./configure issues
by David Brain 01 Oct '08

01 Oct '08

Hi, Trying to compile libvirt on Centos 5.2, get the following when running configure: .... checking for struct _xmlURI.query_raw... no checking gnutls/gnutls.h usability... yes checking gnutls/gnutls.h presence... yes checking for gnutls/gnutls.h... yes checking for gnutls_handshake in -lgnutls... no configure: error: You must install the GnuTLS library in order to compile and run libvirt It's definitely installed: Installed Packages gnutls.x86_64 1.4.1-3.el5_1 installed gnutls.i386 1.4.1-3.el5_1 installed gnutls-devel.i386 1.4.1-3.el5_1 installed gnutls-devel.x86_64 1.4.1-3.el5_1 installed gnutls-utils.x86_64 1.4.1-3.el5_1 installed xmlsec1-gnutls.x86_64 1.2.9-8.1 installed xmlsec1-gnutls.i386 1.2.9-8.1 installed xmlsec1-gnutls-devel.i386 1.2.9-8.1 installed xmlsec1-gnutls-devel.x86_64 1.2.9-8.1 installed Thanks, David.

2 2

[libvirt] Overriding vnetN with the <target> element in xml configuration not working
by Ahmed Medhat 01 Oct '08

01 Oct '08

Hello, I've been trying to dedicated a vnet interface to each virtual machine in order to be able to monitor their traffic, looking at http://libvirt.org/formatdomain.html#elementsNICSBridge it says that a virtual machine could have a specific vnetN specified in the xml element <target>, like <target dev='vnet7'/> . Unfortunately its not working and still it comes with vnet(current+1), here's my configuration for a qemu-kvm guest. <interface type='bridge'> <source bridge='virbr0'/> <target dev='vnet7'/> <mac address='00:16:3e:6c:1f:9d'/> </interface> I'm running on F9 x86_64, libvirt-0.4.4-2.fc9.x86_64 libvirt-python-0.4.4-2.fc9.x86_64 kvm-65-7.fc9.x86_64 qemu-0.9.1-6.fc9.x86_64 I haven't yet tested this with a RHEL box to know if it is version specific issue to open a bugzilla report, any input is appreciated. /* || Thanks, Ahmed Medhat || ultimatetux [at] gmail [dot] com || +2-012-4184768 || In a world without walls and fences, who needs Windows and Gates? */

2 4

[libvirt] [PATCH] fix network interface parsing
by Jim Fehlig 01 Oct '08

01 Oct '08

Hi All, While testing libvirt 0.4.5 and 0.4.6 I noticed only one network interface in domain xml for a xen guest regardless of number actually assigned. Turns out the last interface parsed is always placed on head of nets list instead of appending to tail. Patch attached. Cheers, Jim

2 1

Re: [libvirt] Release of libvirt-0.4.6
by Dale Bewley 30 Sep '08

30 Sep '08

----- "Daniel Veillard" <veillard(a)redhat.com> wrote: > On Fri, Sep 26, 2008 at 09:17:43AM -0700, Dale Bewley wrote: > > I see that 0.4.5 for F9 just made it through bodhi, but there is no > F8 build in bodhi. > > https://admin.fedoraproject.org/updates/F9/FEDORA-2008-7768 > > > > Please release a 0.4.6 F8 update for the benefit of us using F8 > dom0. I'm stuck on non-HVM hardware for the foreseeable future, so KVM > isn't an option for me. And F9 isn't an option for me since there is > no dom0 support. > > Well it wasn't clear that the new release would really fixes things > for the Xen users (which is as we all expect the community still > using Fedora 8), is there anything in particular you were looking for > in this specific release ? It was looking more risky than potentially > useful to update there. > > Daniel I'm on the last F8 update (0.4.4) and my problem[1] I would love to see fixed is the desynchronization that occurs between libvirtd and xend if I shutdown a guest. Until xend is restarted, libvirt utils can't find the domU. [1] https://www.redhat.com/archives/fedora-xen/2008-June/msg00059.html There were a lot of fixes listed[2] for 0.4.5. I don't know if they fix this problem, but some of them sound like they would come close in the code. [2] https://www.redhat.com/archives/libvir-list/2008-September/msg00186.html -- Dale Bewley - Unix Administrator - Shields Library - UC Davis GPG: 0xB098A0F3 0D5A 9AEB 43F4 F84C 7EFD 1753 064D 2583 B098 A0F3

2 1

Re: [libvirt] [PATCH] fix creating of openvz bridge device
by Evgeniy V. Sokolov 29 Sep '08

29 Sep '08

> > This behaviour contradicts with description found in docs (in which > <source> tag specify interface in host, not in container). I think, > the previous bridge must be specified as > <interface type='bridge'> > <mac address='00:16:3e:34:21:9e'/> > - <source bridge='eth10'/> > + <target dev='eth10'/> > </interface> > > You are right. It is bug. > > Well, here is the patch, that fixes that behaviour. Your patch is half of fix. It require to fix openvzReadNetworkConf() in openvz_conf.c. > > P.S. Are someone going to implement > <interface type='bridge'> > ... > <source bridge="..."> > ... > </interface> > part of openvz driver? :) I plan to implement it in a month. It will be fine if you are ready to develop the feature.

2 2

[libvirt] Release of libvirt-0.4.6
by Daniel Veillard 29 Sep '08

29 Sep '08

As promised after we discovered a couple of serious bugs in 0.4.5, a new release was in order, so I pushed 0.4.6 yesterday evening, it's available as usual at ftp://libvirt.org/libvirt/ There is no major change in this release, just the bug fixes a few improvements and some cleanup: * Documentation: - fix some comments in API (Anton Protopopov) - cleanup and extension of bindings and windows pages (Richard Jones) * Portability: - missing include file (Richard Jones) * Bug fixes: - avoid a segfault if missing qemu emulator (Cole Robinson) - reading vncdisplay from xend domain (Cole Robinson) - segfault in OpenVZ (Evgeniy Sokolov) - fix parsing of pool without a source (Chris Lalancette and Daniel Berrange) * Improvements: - add storage disk volume delete (Cole Robinson) - KVM dynamic max CPU detection (Guido Günther) - spec file improvement for minimal builds (Ben Guthro) - improved error message in XM configuration module (Richard Jones) - network config in OpenVZ support (Evgeniy Sokolov) - enable stopping a pool in logical storage backend and cleanup deletion of pool (Chris Lalancette) * Cleanups: - deadcode removal (Nguyen Anh Quynh) - fix one test case (Daniel Berrange) - various strings and space cleanups (Daniel Berrange) - structure initialization cleanup (Chris Lalancette) Thanks everybody for the patches and feedback ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

4 6

[libvirt] [PATCH] fix creating of openvz bridge device
by Anton Protopopov 26 Sep '08

26 Sep '08

> > > This behaviour contradicts with description found in docs (in which >> <source> tag specify interface in host, not in container). I think, >> the previous bridge must be specified as >> <interface type='bridge'> >> <mac address='00:16:3e:34:21:9e'/> >> - <source bridge='eth10'/> >> + <target dev='eth10'/> >> </interface> >> > You are right. It is bug. Well, here is the patch, that fixes that behaviour. P.S. Are someone going to implement <interface type='bridge'> ... <source bridge="..."> ... </interface> part of openvz driver? :)

1 0

[libvirt] openvz support in libvirt
by Anton Protopopov 26 Sep '08

26 Sep '08

Hello. To start with, I have the following questions: Does libvirt support the xml format for openvz driver described in the next thread? http://www.redhat.com/archives/libvir-list/2008-July/msg00312.html (I think, that it does not. But will it support it in future? :)) What libvirt functionality does openvz driver support? (Openvz does not mentioned in http://libvirt.org/hvsupport.html) Anton.

4 6

[libvirt] [PATCH] Some virsh(1) man page fixes
by Mark McLoughlin 25 Sep '08

25 Sep '08

Hi, Just looking at virsh(1), I noticed a reference to xm that should have referred to virsh. Found some other things as I fixed: - Explanation of run states was after the bit about the freecell command - State codes like 'r' for running aren't displayed with virsh - Reference to "xm pause" instead of "virsh suspend" - "virsh create" explanation confusing and references "xm create"; fixed it up to what I think was the original intention - Some of the command sections were over-indented - References to xmdomain.cfg - Make "see also" reference virt-install, virt-top, virt-mem and virt-df manpages rather than xmdomain.cfg and xentop Cheers, Mark. Index: docs/virsh.pod =================================================================== RCS file: /data/cvs/libvirt/docs/virsh.pod,v retrieving revision 1.17 diff -u -p -r1.17 docs/virsh.pod --- docs/virsh.pod 1 Aug 2008 14:30:41 -0000 1.17 +++ docs/virsh.pod 25 Sep 2008 10:12:48 -0000 @@ -148,65 +148,62 @@ B<virsh> list Name is the name of the domain. ID the domain numeric id. - State is the run state (see below). - -=item B<freecell> optional I<cellno> - -Prints the available amount of memory on the machine or within a -NUMA cell if I<cellno> is provided. +State is the run state (see below). =over 4 B<STATES> +The State field lists 6 states for a domain, and which ones the +current domain is in. -The State field lists 6 states for a Xen Domain, and which ones the -current Domain is in. - -=item B<r - running> +=item B<running> The domain is currently running on a CPU -=item B<b - blocked> +=item B<blocked> The domain is blocked, and not running or runnable. This can be caused because the domain is waiting on IO (a traditional wait state) or has gone to sleep because there was nothing else for it to do. -=item B<p - paused> +=item B<paused> The domain has been paused, usually occurring through the administrator -running B<xm pause>. When in a paused state the domain will still +running B<virsh suspend>. When in a paused state the domain will still consume allocated resources like memory, but will not be eligible for -scheduling by the Xen hypervisor. +scheduling by the hypervisor. -=item B<s - shutdown> +=item B<shutdown> The domain is in the process of shutting down, i.e. the guest operating system has been notified and should be in the process of stopping its operations gracefully. -=item B<c - crashed> +=item B<crashed> The domain has crashed, which is always a violent ending. Usually this state can only occur if the domain has been configured not to -restart on crash. See L<xmdomain.cfg> for more info. +restart on crash. -=item B<d - dying> +=item B<dying> The domain is in process of dying, but hasn't completely shutdown or crashed. =back +=item B<freecell> optional I<cellno> + +Prints the available amount of memory on the machine or within a +NUMA cell if I<cellno> is provided. + =head1 DOMAIN COMMANDS The following commands manipulate domains directly, as stated previously most commands take domain-id as the first parameter. The I<domain-id> can be specified as an short integer, a name or a full UUID. -=over 4 - =item B<autostart> optional I<--disable> I<domain-id> Configure a domain to be automatically started at boot. @@ -219,7 +216,7 @@ Connect the virtual serial console for t =item B<create> I<FILE> -Create a domain from an XML <file> an easy way to create one if you have a pre-existing xen guest created via B<xm> create <XMLFILE>. +Create a domain from an XML <file>. An easy way to create the XML <file> is to use the B<dumpxml> command to obtain the definition of a pre-existing guest. B<Example> @@ -303,9 +300,8 @@ command run from the console. The comma executed the reboot action, which may be significantly before the domain actually reboots. -For xen vm the behavior of what happens to a domain when it reboots is set by the -I<on_reboot> parameter of the xmdomain.cfg file when the domain was -created. +The exact behavior of a domain when it reboots is set by the +I<on_reboot> parameter in the domain's XML definition. =item B<restore> I<state-file> @@ -360,9 +356,8 @@ to perform graceful shutdown, so there i succeed, and may take a variable length of time depending on what services must be shutdown in the domain. -For a xen guest vm the behavior of what happens to a domain when it reboots is set by the -I<on_shutdown> parameter of the xmdomain.cfg file when the domain was -created. +The exact behavior of a domain when it shuts down is set by the +I<on_shutdown> parameter in the domain's XML definition. =item B<start> I<domain-name> @@ -404,8 +399,6 @@ and I<cpulist> is a comma separated list Output the IP address and port number for the VNC display. If the information is not available the processes will provide an exit code of 1. -=back - =head1 DEVICES COMMANDS The following commands manipulate devices associated to domains. @@ -414,8 +407,6 @@ To better understand the values allowed reading the documentation at L<http://libvirt.org/format.html> on the format of the device sections to get the most accurate set of accepted values. -=over 4 - =item B<attach-device> I<domain-id> I<FILE> Attach a device to the domain, using a device definition in an XML file. @@ -456,8 +447,6 @@ I<type> can be either I<network> to indi It is recommended to use the I<mac> option to distinguish between the interfaces if more than one are present on the domain. -=back - =head1 VIRTUAL NETWORKS COMMANDS The following commands manipulate networks. Libvirt has the capability to @@ -467,8 +456,6 @@ see the documentation at L<http://libvir of the command for virtual networks are similar to the one used for domains, but the way to name a virtual network is either by its name or UUID. -=over 4 - =item B<net-autostart> I<network> optional I<--disable> Configure a virtual network to be automatically started at boot. @@ -528,29 +515,23 @@ Undefine the configuration for an inacti Convert a network name to network UUID. -=back - =head1 ENVIRONMENT -=over 4 - =item VIRSH_DEFAULT_CONNECT_URI The hypervisor to connect to by default. Set this to a URI, in the same format as accepted by the B<connect> option. -=back - =head1 SEE ALSO -L<xm(1)>, L<xmdomain.cfg(5)>, L<xentop(1)> , L<http://www.libvirt.org/> +L<virt-install(1)>, L<xm(1)>, L<virt-top(1)>, L<virt-mem(1)>, L<virt-df(1)>, L<http://www.libvirt.org/> =head1 AUTHOR Andrew Puch <apuch @ redhat.com> Daniel Veillard <veillard @ redhat.com> - Based on the xm man paged by + Based on the xm man page by: Sean Dague <sean at dague dot net> Daniel Stekloff <dsteklof at us dot ibm dot com>

3 3

[libvirt] Some Windows binaries
by Richard W.M. Jones 25 Sep '08

25 Sep '08

This is not an official distribution, but if you add the following repository to any Fedora 8 / 9 or Rawhide box, then you will get the latest MinGW packages. The mingw32-libvirt package contains Windows binaries, libvirt-0.dll and virsh.exe. http://www.annexia.org/tmp/mingw/fedora-9/i386/ or http://www.annexia.org/tmp/mingw/fedora-9/x86_64/ Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top

1 0

[libvirt] [PATCH] avoid problem for parallel buld in python subdir
by Daniel Veillard 25 Sep '08

25 Sep '08

Seems very hard to hit but one could get a problem with generation of the python bindings, https://bugzilla.redhat.com/show_bug.cgi?id=463733 the enclosed patch is by Dan Berrange Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

2 1