- Devel - libvirt List Archives

[libvirt] _lstat link failure on mingw
by Jim Meyering 07 Nov '08

07 Nov '08

This fixes a problem spotted by Rich Jones yesterday: >From 5d5042ad904f8da6ffff93c1a5e392cd4d9b86a1 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Thu, 6 Nov 2008 20:46:46 +0100 Subject: [PATCH] tweak lstat.c to avoid mingw link failure * gnulib/lib/lstat.c: Include <sys/stat.h> *before* the use of stat in orig_stat. Otherwise, on mingw (which lacks lstat), any program using the lstat module would not get the redefinition- to-stat provided by gnulib's sys/stat.h. --- gnulib/lib/lstat.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/gnulib/lib/lstat.c b/gnulib/lib/lstat.c index 3d1bca8..aa5e8c4 100644 --- a/gnulib/lib/lstat.c +++ b/gnulib/lib/lstat.c @@ -25,15 +25,15 @@ #include <sys/stat.h> #undef __need_system_sys_stat_h +/* Specification. */ +#include <sys/stat.h> + static inline int orig_lstat (const char *filename, struct stat *buf) { return lstat (filename, buf); } -/* Specification. */ -#include <sys/stat.h> - #include <string.h> #include <errno.h> -- 1.6.0.3.756.gb776d

3 2

[libvirt] [PATCH] mark a few diagnostics for translation
by Jim Meyering 07 Nov '08

07 Nov '08

FYI. This is trivial, so I'll push it soon unless someone objects. >From d5d9bc7e5473ea3ce40c4af70a2085c316023723 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Thu, 6 Nov 2008 20:41:34 +0100 Subject: [PATCH] mark a few diagnostics for translation * src/lxc_conf.c (lxcLoadDriverConfig): Mark a diagnostic. * src/lxc_driver.c (lxcDomainStart): Likewise. * po/POTFILES.in: Add src/lxc_conf.c. * Makefile.maint (msg_gen_function): Add virReportErrorHelper and lxcError. --- Makefile.maint | 3 ++- po/POTFILES.in | 1 + src/lxc_conf.c | 5 ++--- src/lxc_driver.c | 2 +- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/Makefile.maint b/Makefile.maint index d856469..28b1c3f 100644 --- a/Makefile.maint +++ b/Makefile.maint @@ -353,6 +353,8 @@ msg_gen_function += qemudReportError msg_gen_function += openvzLog msg_gen_function += openvzError msg_gen_function += virDomainReportError +msg_gen_function += virReportErrorHelper +msg_gen_function += lxcError # Uncomment the following and run "make syntax-check" to see diagnostics # that are not yet marked for translation, but that need to be rewritten @@ -360,7 +362,6 @@ msg_gen_function += virDomainReportError # msg_gen_function += error # msg_gen_function += virXenError # msg_gen_function += testError -# msg_gen_function += lxcError func_or := $(shell printf '$(msg_gen_function)'|tr -s '[[:space:]]' '|') func_re := ($(func_or)) diff --git a/po/POTFILES.in b/po/POTFILES.in index fdb34b5..3f8fdd2 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -7,6 +7,7 @@ src/datatypes.c src/domain_conf.c src/iptables.c src/libvirt.c +src/lxc_conf.c src/lxc_container.c src/lxc_controller.c src/lxc_driver.c diff --git a/src/lxc_conf.c b/src/lxc_conf.c index 76f4e9d..0db9bb5 100644 --- a/src/lxc_conf.c +++ b/src/lxc_conf.c @@ -83,8 +83,7 @@ int lxcLoadDriverConfig(lxc_driver_t *driver) return 0; no_memory: - lxcError(NULL, NULL, VIR_ERR_NO_MEMORY, "configDir"); + lxcError(NULL, NULL, VIR_ERR_NO_MEMORY, + "%s", _("while loading LXC driver config")); return -1; } - - diff --git a/src/lxc_driver.c b/src/lxc_driver.c index 8bfd27d..583c4ff 100644 --- a/src/lxc_driver.c +++ b/src/lxc_driver.c @@ -857,7 +857,7 @@ static int lxcDomainStart(virDomainPtr dom) if (!vm) { lxcError(conn, dom, VIR_ERR_INVALID_DOMAIN, - "no domain with uuid"); + _("no domain named %s"), dom->name); goto cleanup; } -- 1.6.0.3.756.gb776d

1 0

[libvirt] RFC: Domain events add DEFINED and UNDEFINED events
by Daniel P. Berrange 07 Nov '08

07 Nov '08

We currently have the following list of events for domains: VIR_DOMAIN_EVENT_ADDED, VIR_DOMAIN_EVENT_REMOVED, VIR_DOMAIN_EVENT_STARTED, VIR_DOMAIN_EVENT_SUSPENDED, VIR_DOMAIN_EVENT_RESUMED, VIR_DOMAIN_EVENT_STOPPED, VIR_DOMAIN_EVENT_SAVED, VIR_DOMAIN_EVENT_RESTORED, The QEMU driver supports all of them, except for ADDED and REMOVED. I was looking at adding these and wondering how exactly we should define the semantics Originally I was just going to emit 'ADDED' from virDomainDefine() driver impl and 'REMOVED' from virDomainUndefine(). This does not, however, take into account that there are two sorts of domains, so called 'persistent' and 'transient' domains. With a transient domain, there is no config file, so the first time you know about the domain is when it is booted via virDomainCreateXML(), and all trace of it disappears when it shuts down, or migrates, or is saved. With a persistent domain though, it is visible before it is booted, and remains visible after shutdown/migrate/save etc. The current set of events does not allow applications to get this level of visibility. eg when receiving a VIR_DOMAIN_EVENT_STOPPED event, there is no way to know wether the domain was transient / persistent, and thus whether to remove it from your list of VMs, or simply mark it shutoff. So, I'd like to propose that we do the following: - Clarify the semantics for * VIR_DOMAIN_EVENT_ADDED Emitted when a domain comes into existance, by which I mean a previously known inactive domain is defined, or a transient domain is booted. This is emited before any other events for a domain with that UUID/name. * VIR_DOMAIN_EVENT_REMOVED Emitted when a domains goes out of existance, by which I mean a transient domain shuts down / migrates / is saved, or a persistent domain is undefined. This is the last event ever to be emitted for a domain with that UUID/name. - Create two more events * VIR_DOMAIN_EVENT_DEFINED Emitted whenenever a domain's config file is created. This can be when a peristent domain is first defined, when it is later re-defined, or when an transient domain gains a confi file, becoming persistent. * VIR_DOMAIN_EVENT_UNDEFINED Emitted when a domain's config file is removed. With this complete set of events, virt-manager is able to track domains without ever having to poll for the domain listing. I think we also need to provide some way for an application to determine what set of events a hypervisor backend supports. eg, if it only supports the STARTED/STOPPED events, virt-manager would still need to do polling to find out about defined/undefined domains. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

3 4

[libvirt] [PATCH] Xen events
by Ben Guthro 06 Nov '08

06 Nov '08

The following patch implements a framework for emitting events from the Xen driver, via monitoring xenstore. Currently, this only emits the STARTED, and STOPPED events, as this is all that seems to be available via monitoring xenstore. xen_unified.c | 162 +++++++++++++++++++++++ xen_unified.h | 38 +++++ xs_internal.c | 408 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++- xs_internal.h | 51 +++++++ 4 files changed, 657 insertions(+), 2 deletions(-)

2 2

[libvirt] Problem with fullyvirtualized guest direct kernel boot
by Max Martynov 06 Nov '08

06 Nov '08

Hi All, I am trying to use fullyvirtualized guest direct kernel boot, but all I see is the following error: libvir: Xen Daemon error : POST operation failed: (xend.err 'Error creating domain: (2, \'Invalid kernel\', "elf_xen_note_check: ERROR: Not a Xen-ELF image: No ELF notes or \'__xen_guest\' section found.\\n")') Kernel, initrd and root file system are extracted from working Fedora 9 disk image without any additional tinkering. Guest Fedora is clean and was installed from scratch. When I use this whole disk image with fullyvirtualized guest BIOS boot with, everything works fine. I also tried paravirtualized guest bootloader with another linux kernel and it also works fine. Xen version is 3.2.1-rc1-pre. Host OS is Ubuntu Hardy. Here is the libvirt config for direct kernel boot: <domain type='xen' id='18'> <name>test1</name> <uuid>4dea22b31d52d8f32516782e98ab3fa0</uuid> <os> <type>linux</type> <loader>/usr/lib/xen/boot/hvmloader</loader> <kernel>/tmp/vmlinuz-2.6.25-14.fc9.i686</kernel> <initrd>/tmp/initrd-2.6.25-14.fc9.i686.img</initrd> <root>/dev/sda1</root> <cmdline>ro</cmdline> </os> <memory>524288</memory> <vcpu>1</vcpu> <devices> <emulator>/usr/lib/xen/bin/qemu-dm</emulator> <disk type='file'> <driver name="tap" type="aio"/> <source file='/tmp/f9_disassembled/root.img'/> <target dev='sda1'/> </disk> <disk type='file'> <driver name="tap" type="aio"/> <source file='/tmp/swap'/> <target dev='sda3'/> </disk> <interface type='bridge'> <source bridge='eth0'/> <mac address='00:16:3e:5d:c7:9e'/> <script path='/etc/xen/scripts/vif-bridge'/> </interface> <graphics type='vnc' port='5904'/> </devices> </domain> What do you think can be the cause of this issue? -- Thanks, Max <libvir-list(a)redhat.com>

2 3

[libvirt] [PATCH] cleanup of loging definitions
by Daniel Veillard 06 Nov '08

06 Nov '08

Currently the debugFlag switch, the VIR_DEBUG, DEBUG and DEBUG0 macros were scattered in various places, duplicated once (or twice) per generated binaries. This patch moves everything in one virtlog.h header, one virtlog.c file and set up the makefiles so that the various binaries refers to the same bits. That's a cleanup with no functional change to prepare the real loging APIs, patch and the 2 new files attached, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

2 3

[libvirt] Openvz bridge support
by Anton Protopopov 06 Nov '08

06 Nov '08

Hi, 2008/10/14 Daniel P. Berrange <berrange(a)redhat.com> > This patch series is derived from Anton Protopopov /Evgeniy Sokolov > bridge device patches. It first does some generic refactoring of MAC > address handler in all drivers, then adds code to extract openvz version > number, then does network config, and finally does filesystem config. Are these patches will be commited some day? Or they are still work-in-progress? Or they are just forgotten? :)

3 2

[libvirt] Libvirt CVS fails to build on PPC
by Chris Lalancette 06 Nov '08

06 Nov '08

Actually, the subject isn't strictly true. Libvirt CVS currently fails to build when using this configuration on any platform: ./configure --build=i686-redhat-linux-gnu --host=i686-redhat-linux-gnu --target=i386-redhat-linux-gnu --program-prefix= --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib --libexecdir=/usr/libexec --localstatedir=/var --sharedstatedir=/usr/com --mandir=/usr/share/man --infodir=/usr/share/info --without-xen --without-qemu --with-init-script=redhat --with-qemud-pid-file=/var/run/libvirt_qemud.pid --with-remote-file=/var/run/libvirtd.pid (the important part is the --without-xen --without-qemu in there). This just happens to be the configuration that koji uses when it is building the ppc libvirt package. There are a lot of build errors, but they start with: network_driver.c:64: error: expected specifier-qualifier-list before 'iptablesContext' network_driver.c: In function 'networkStartup': network_driver.c:124: error: 'struct network_driver' has no member named 'logDir' This seems to stem from the new module refactoring. I'm not entirely sure what's the correct way to fix it, however; I *think* we always want to build the network_driver at this point, but if that's the case, then we need to make sure we have the header files for iptablesContext and friends included. Dan, any ideas? -- Chris Lalancette

2 2

[libvirt] [PATCH] dynamic debug patch
by Daniel Veillard 05 Nov '08

05 Nov '08

First version of a small patch allowing to gather debug informations from a running libvirt daemon. Basically one can send signal USR2 to the daemon, the daemon will from that point dump its current internal state and all verbose debug output to a file /tmp/libvirt_debug_xxxx. When sending back signal USR2 the file is closed and can be looked at for analysis, this allow to save extensive debug informations from a running daemon. The patch is rather minimal right now, it just applies to qemud/qemud.c, modifies it to have global variables for error and information output FILE, an init routing setting them up and hooking a handler for USR2, the handler, a very minimal state dump. But it works as is. Now I would like to extend that debugging to the library itself, so any app linking to libvirt can be debugged in the same way. I would also like to add debugging routines for most internal data structures. I'm still wondering about the best form for those, should they use a FILE * argument, an fd argument or a virBufferPtr for genericity (probably the later would make most sense). #ifdef ENABLE_DEBUG void virConnectDebug(virBufferPtr buf, virConnectPtr conn); #endif and similar for main internal data structures and drivers The patch is just a work in progress but trying to get early feedback. Maybe this could be used to get remote introspection capabilities too but ATM I'm more looking at providing an easy way to get debug informations on a libvirt program. Also I'm unclear, do we really want to have all the debug strings internationalized with _() , that's more work for localization team and it's unclear this would benefit 'end users'. Patch and an example of log attached, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

2 4

[libvirt] [PATCH 0/3]: Better debug output from virExec/virRun
by Cole Robinson 05 Nov '08

05 Nov '08

The following three patches add improved debug output for the virExec and virRun commands. The full argv is now logged, and virRun reads the command stdout and stderr for use in error reporting. Thanks, Cole

3 12

[libvirt] [PATCH] plug two leaks and fix a diagnostic
by Jim Meyering 05 Nov '08

05 Nov '08

Without this patch, running make check would trigger this minor leak: 10 bytes in 1 blocks are definitely lost in loss record 1 of 20 at 0x4A0739E: malloc (vg_replace_malloc.c:207) by 0x3F872808A1: strdup (strdup.c:43) by 0x4CA2503: qemudLoadDriverConfig (qemu_conf.c:70) by 0x4CA7EA7: qemudStartup (qemu_driver.c:216) by 0x4C3AEBC: __virStateInitialize (libvirt.c:592) by 0x4096B6: qemudInitialize (qemud.c:738) by 0x40CCCF: main (qemud.c:2216) Looking into it, I found there were actually two separate leaks and an erroneous diagnostic. This fixes them: >From b1f17b05e59cf12aa3f73fde1be713dbadf02f76 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Wed, 5 Nov 2008 14:50:24 +0100 Subject: [PATCH] plug two leaks and fix a diagnostic * src/qemu_conf.c (qemudLoadDriverConfig): Don't leak ->vncListen. Fix an erroneous copy-and-pasted diagnostic. * src/qemu_driver.c (qemudShutdown): Don't leak another ->vncListen. --- src/qemu_conf.c | 3 ++- src/qemu_driver.c | 1 + 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/qemu_conf.c b/src/qemu_conf.c index 54ac23d..0e3b959 100644 --- a/src/qemu_conf.c +++ b/src/qemu_conf.c @@ -118,9 +118,10 @@ int qemudLoadDriverConfig(struct qemud_driver *driver, p = virConfGetValue (conf, "vnc_listen"); CHECK_TYPE ("vnc_listen", VIR_CONF_STRING); if (p && p->str) { + VIR_FREE(driver->vncListen); if (!(driver->vncListen = strdup(p->str))) { qemudReportError(NULL, NULL, NULL, VIR_ERR_NO_MEMORY, - "%s", _("failed to allocate vncTLSx509certdir")); + "%s", _("failed to allocate vnc_listen")); virConfFree(conf); return -1; } diff --git a/src/qemu_driver.c b/src/qemu_driver.c index 4adeb73..5d108ed 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -314,6 +314,7 @@ qemudShutdown(void) { VIR_FREE(qemu_driver->configDir); VIR_FREE(qemu_driver->autostartDir); VIR_FREE(qemu_driver->vncTLSx509certdir); + VIR_FREE(qemu_driver->vncListen); /* Free domain callback list */ virDomainEventCallbackListFree(qemu_driver->domainEventCallbacks); -- 1.6.0.3.756.gb776d

2 2

[libvirt] [PATCH]: vgscan before doing logical pool discovery
by Chris Lalancette 05 Nov '08

05 Nov '08

Assume that you have an iSCSI target available, and on that iSCSI target 1 LUN is exported. On that 1 LUN, you have an LVM volume group (say, myvg), with 2 logical volumes (say, lv1 and lv2). Now you execute the following sequence of commands: 1) virsh define iscsi_pool.xml 2) virsh start iscsi_pool 3) virsh find-storage-pool-sources-as logical With that sequence, you would expect step 3) to return XML similar to: <sources><source><name>myvg</name><device path='/dev/sdb'/></source></sources> However, what you instead get is: <sources/>. That's because if you just try to do storage pool discovery on a logical pool without ever touching the logical pool in any fashion, pvs (what we use to do discovery) doesn't return anything. If you touch the logical volume group at all (say, with vgscan), they then suddenly appear. To make sure we see all of the potential volume groups when doing pool discovery, make sure to run vgscan before we run pvs. With this patch in place, logical discovery just does the right thing. Signed-off-by: Chris Lalancette <clalance(a)redhat.com>

2 2

[libvirt] New Libvirt Implementation - OpenNebula
by Ruben S. Montero 05 Nov '08

05 Nov '08

Dear all, You may find of interest a new implementation of the libvirt virtualization API. This new implementation adds support to OpenNebula, a distributed VM manager system. The implementation of libvirt on top of a distributed VM manager, like OpenNebula, provides an abstraction of a whole cluster of resources (each one with its hypervisor). In this way, you can use any libvirt tool (e.g. virsh, virt-manager) and XML domain descriptions at a distributed level. For example, you may create a new domain with 'virsh create', then OpenNebula will look for a suitable resource, transfer the VM images and boot your VM using any of the supported hypervisors. The distributed management is completely transparent to the libvirt application. This is, a whole cluster can be managed as any other libvirt node. The current implementation is targeted for libvirt 0.4.4, and includes a patch to the libvirt source tree (mainly to modify the autotools files), and a libvirt driver. More information and download instructions can be found at: * http://trac.opennebula.org/wiki/LibvirtOpenNebula * http://www.opennebula.org Cheers Ruben -- +---------------------------------------------------------------+ Dr. Ruben Santiago Montero Associate Professor Distributed System Architecture Group (http://dsa-research.org) URL: http://dsa-research.org/doku.php?id=people:ruben Weblog: http://blog.dsa-research.org/?author=7 GridWay, http://www.gridway.org OpenNEbula, http://www.opennebula.org +---------------------------------------------------------------+

5 15

[libvirt] PATCH: 0/11: Fully modular drivers and optional dlopen support
by Daniel P. Berrange 05 Nov '08

05 Nov '08

The following series of patches clean up our internal modularization to remove unneccessary dependancies between source files, and make everything follow a consistent pattern of XXXX.h declaring stuff in XXXX.c. Later in the series is plays some games with the linker scripts, and finally makes all hypervisor drivers fully modular, and optionally dlopen'able. The 10'th patch in this series is a pre-requisite to enable us to merge David's host device patches, since it lets us avoid GPL/LGPL compat issues from DBus/HAL. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 27

[libvirt] PATCH: Pass -uuid and -domid to QEMU if available
by Daniel P. Berrange 04 Nov '08

04 Nov '08

Latest QEMU code now allows setting of the UUID in its SMBIOS data tables via the -uuid command line arg. THis patch makes use of that feature by pasing in the libvirt UUID for the VM. While doing this I also added support for the Xenner specific -domid flag Daniel Index: src/qemu_conf.c =================================================================== RCS file: /data/cvs/libvirt/src/qemu_conf.c,v retrieving revision 1.103 diff -u -p -r1.103 qemu_conf.c --- src/qemu_conf.c 28 Oct 2008 17:43:25 -0000 1.103 +++ src/qemu_conf.c 3 Nov 2008 12:52:06 -0000 @@ -439,6 +439,10 @@ int qemudExtractVersionInfo(const char * flags |= QEMUD_CMD_FLAG_NO_REBOOT; if (strstr(help, "-name")) flags |= QEMUD_CMD_FLAG_NAME; + if (strstr(help, "-uuid")) + flags |= QEMUD_CMD_FLAG_UUID; + if (strstr(help, "-domid")) + flags |= QEMUD_CMD_FLAG_DOMID; if (strstr(help, "-drive")) flags |= QEMUD_CMD_FLAG_DRIVE; if (strstr(help, "boot=on")) @@ -713,6 +717,8 @@ int qemudBuildCommandLine(virConnectPtr int qenvc = 0, qenva = 0; const char **qenv = NULL; const char *emulator; + char uuid[VIR_UUID_STRING_BUFLEN]; + char domid[50]; uname(&ut); @@ -723,6 +729,8 @@ int qemudBuildCommandLine(virConnectPtr !ut.machine[4]) ut.machine[1] = '6'; + virUUIDFormat(vm->def->uuid, uuid); + /* Need to explicitly disable KQEMU if * 1. Arch matches host arch * 2. Guest is 'qemu' @@ -802,6 +810,7 @@ int qemudBuildCommandLine(virConnectPtr snprintf(memory, sizeof(memory), "%lu", vm->def->memory/1024); snprintf(vcpus, sizeof(vcpus), "%lu", vm->def->vcpus); + snprintf(domid, sizeof(domid), "%d", vm->def->id); ADD_ENV_LIT("LC_ALL=C"); @@ -834,6 +843,15 @@ int qemudBuildCommandLine(virConnectPtr ADD_ARG_LIT("-name"); ADD_ARG_LIT(vm->def->name); } + if (qemuCmdFlags & QEMUD_CMD_FLAG_UUID) { + ADD_ARG_LIT("-uuid"); + ADD_ARG_LIT(uuid); + } + if (qemuCmdFlags & QEMUD_CMD_FLAG_DOMID) { + ADD_ARG_LIT("-domid"); + ADD_ARG_LIT(domid); + } + /* * NB, -nographic *MUST* come before any serial, or monitor * or parallel port flags due to QEMU craziness, where it Index: src/qemu_conf.h =================================================================== RCS file: /data/cvs/libvirt/src/qemu_conf.h,v retrieving revision 1.43 diff -u -p -r1.43 qemu_conf.h --- src/qemu_conf.h 23 Oct 2008 13:18:18 -0000 1.43 +++ src/qemu_conf.h 3 Nov 2008 12:52:06 -0000 @@ -44,6 +44,8 @@ enum qemud_cmd_flags { QEMUD_CMD_FLAG_DRIVE = (1 << 3), QEMUD_CMD_FLAG_DRIVE_BOOT = (1 << 4), QEMUD_CMD_FLAG_NAME = (1 << 5), + QEMUD_CMD_FLAG_UUID = (1 << 6), + QEMUD_CMD_FLAG_DOMID = (1 << 7), /* Xenner only */ }; /* Main driver state */ Index: src/qemu_driver.c =================================================================== RCS file: /data/cvs/libvirt/src/qemu_driver.c,v retrieving revision 1.144 diff -u -p -r1.144 qemu_driver.c --- src/qemu_driver.c 29 Oct 2008 14:32:41 -0000 1.144 +++ src/qemu_driver.c 3 Nov 2008 12:52:07 -0000 @@ -860,10 +860,12 @@ static int qemudStartVMDaemon(virConnect return -1; } + vm->def->id = driver->nextvmid++; if (qemudBuildCommandLine(conn, driver, vm, qemuCmdFlags, &argv, &progenv, &tapfds, &ntapfds, migrateFrom) < 0) { close(vm->logfile); + vm->def->id = -1; vm->logfile = -1; return -1; } @@ -901,10 +903,10 @@ static int qemudStartVMDaemon(virConnect ret = virExec(conn, argv, progenv, &keepfd, &vm->pid, vm->stdin_fd, &vm->stdout_fd, &vm->stderr_fd, VIR_EXEC_NONBLOCK); - if (ret == 0) { - vm->def->id = driver->nextvmid++; + if (ret == 0) vm->state = migrateFrom ? VIR_DOMAIN_PAUSED : VIR_DOMAIN_RUNNING; - } + else + vm->def->id = -1; for (i = 0 ; argv[i] ; i++) VIR_FREE(argv[i]); Index: tests/qemuxml2argvtest.c =================================================================== RCS file: /data/cvs/libvirt/tests/qemuxml2argvtest.c,v retrieving revision 1.32 diff -u -p -r1.32 qemuxml2argvtest.c --- tests/qemuxml2argvtest.c 10 Oct 2008 16:52:20 -0000 1.32 +++ tests/qemuxml2argvtest.c 3 Nov 2008 12:52:07 -0000 @@ -43,7 +43,10 @@ static int testCompareXMLToArgvFiles(con memset(&vm, 0, sizeof vm); vm.def = vmdef; - vm.def->id = -1; + if (extraFlags & QEMUD_CMD_FLAG_DOMID) + vm.def->id = 6; + else + vm.def->id = -1; vm.pid = -1; flags = QEMUD_CMD_FLAG_VNC_COLON | @@ -196,6 +199,8 @@ mymain(int argc, char **argv) DO_TEST("input-xen", 0); DO_TEST("misc-acpi", 0); DO_TEST("misc-no-reboot", 0); + DO_TEST("misc-uuid", QEMUD_CMD_FLAG_NAME | + QEMUD_CMD_FLAG_UUID | QEMUD_CMD_FLAG_DOMID); DO_TEST("net-user", 0); DO_TEST("net-virtio", 0); Index: tests/qemuxml2argvdata/qemuxml2argv-misc-uuid.args =================================================================== RCS file: tests/qemuxml2argvdata/qemuxml2argv-misc-uuid.args diff -N tests/qemuxml2argvdata/qemuxml2argv-misc-uuid.args --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ tests/qemuxml2argvdata/qemuxml2argv-misc-uuid.args 3 Nov 2008 12:52:07 -0000 @@ -0,0 +1 @@ +LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test /usr/bin/qemu -S -M pc -m 214 -smp 1 -name QEMUGuest1 -uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 -domid 6 -nographic -monitor pty -boot c -hda /dev/HostVG/QEMUGuest1 -net none -serial none -parallel none -usb Index: tests/qemuxml2argvdata/qemuxml2argv-misc-uuid.xml =================================================================== RCS file: tests/qemuxml2argvdata/qemuxml2argv-misc-uuid.xml diff -N tests/qemuxml2argvdata/qemuxml2argv-misc-uuid.xml --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ tests/qemuxml2argvdata/qemuxml2argv-misc-uuid.xml 3 Nov 2008 12:52:07 -0000 @@ -0,0 +1,25 @@ +<domain type='qemu'> + <name>QEMUGuest1</name> + <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> + <memory>219200</memory> + <currentMemory>219200</currentMemory> + <vcpu>1</vcpu> + <os> + <type arch='i686' machine='pc'>hvm</type> + <boot dev='hd'/> + </os> + <features> + <acpi/> + </features> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <emulator>/usr/bin/qemu</emulator> + <disk type='block' device='disk'> + <source dev='/dev/HostVG/QEMUGuest1'/> + <target dev='hda' bus='ide'/> + </disk> + </devices> +</domain> -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 2

[libvirt] one more warning
by Jim Meyering 04 Nov '08

04 Nov '08

One more warning question: Compiling with all storage backends disabled, I get this: storage_backend.c:91: warning: comparison of unsigned expression < 0 is always false That's because of this code: static virStorageBackendPtr backends[] = { #if WITH_STORAGE_DIR &virStorageBackendDirectory, #endif #if WITH_STORAGE_FS &virStorageBackendFileSystem, &virStorageBackendNetFileSystem, #endif #if WITH_STORAGE_LVM &virStorageBackendLogical, #endif #if WITH_STORAGE_ISCSI &virStorageBackendISCSI, #endif #if WITH_STORAGE_DISK &virStorageBackendDisk, #endif }; virStorageBackendPtr virStorageBackendForType(int type) { unsigned int i; for (i = 0 ; i < ARRAY_CARDINALITY(backends); i++) if (backends[i]->type == type) return backends[i]; virStorageReportError(NULL, VIR_ERR_INTERNAL_ERROR, _("missing backend for pool type %d"), type); return NULL; } The above loses because ARRAY_CARDINALITY(backends) is 0. One solution is to always have at least one backend, e.g., the first one, in which case, this patch works fine: [but if you like this (i don't), it'd make sense also to remove the configure-time option ] diff --git a/src/storage_backend.c b/src/storage_backend.c index e33f98c..264cc53 100644 --- a/src/storage_backend.c +++ b/src/storage_backend.c @@ -56,9 +56,7 @@ #if WITH_STORAGE_DISK #include "storage_backend_disk.h" #endif -#if WITH_STORAGE_DIR #include "storage_backend_fs.h" -#endif VIR_ENUM_IMPL(virStorageBackendPartTable, VIR_STORAGE_POOL_DISK_LAST, @@ -66,9 +64,7 @@ VIR_ENUM_IMPL(virStorageBackendPartTable, "mac", "bsd", "pc98", "sun", "lvm2"); static virStorageBackendPtr backends[] = { -#if WITH_STORAGE_DIR &virStorageBackendDirectory, -#endif #if WITH_STORAGE_FS &virStorageBackendFileSystem, &virStorageBackendNetFileSystem, Another way is to add a NULL pointer at the end and change the loop not to use the array size at all: for (i = 0; backends[i]; i++) if (backends[i]->type == type) return backends[i]; I chose the latter: diff --git a/src/storage_backend.c b/src/storage_backend.c index e33f98c..1f4ed10 100644 --- a/src/storage_backend.c +++ b/src/storage_backend.c @@ -82,13 +82,14 @@ static virStorageBackendPtr backends[] = { #if WITH_STORAGE_DISK &virStorageBackendDisk, #endif + NULL }; virStorageBackendPtr virStorageBackendForType(int type) { unsigned int i; - for (i = 0 ; i < ARRAY_CARDINALITY(backends); i++) + for (i = 0; backends[i]; i++) if (backends[i]->type == type) return backends[i];

2 1

[libvirt] Does libvirt support Solaris Zones?
by jovialGuy _ 03 Nov '08

03 Nov '08

Hi! I have a quick question, does libvirt latest release supports Solaris Zones? I know it supports LDoms and xVM support is being integrated towards xVM Server. But which release to date supports Solaris Zones? Regards, Jovial

4 3

[libvirt] [PATCH] set cache=off on -disk line in qemu driver if <shareable/> (but not <readonly/>) is set.
by Charles Duffy 03 Nov '08

03 Nov '08

As cache=off is necessary for clustering filesystems such as GFS (and such is the point of shareable, yes?), I believe this is correct behavior. Comments?

4 5

[libvirt] Have any commands in libvirt to run a domain
by Ian jonhson 03 Nov '08

03 Nov '08

Hi all, Are there any commands in console to start/suspend/resume/stop a domain? Is it possible to start a domain as following command: # libvirt-command -cpu <cpu cycle> -mem <memory> -disk <disk quota> -network <network bandwith> -template <windows> If not, can I build this command with existing libvirt API? Thanks, Ian

2 1

[libvirt] [PATCH]: Allow arbitrary paths to virStorageVolLookupByPath
by Chris Lalancette 03 Nov '08

03 Nov '08

In ovirt, we have to scan iSCSI LUN's for LVM storage when they are first added to the database. To do this, we do roughly the following: iscsi_pool = libvirt.define_and_start_iscsi_pool("/dev/disk/by-id") iscsi_pool.add_luns_to_db logical = conn.discover_storage_pool_sources("logical") for each logical_volume_group in logical: for each device in logical_volume_group: iscsi_pool.lookup_vol_by_path(device.path) And then we use that information to associate an iSCSI LUN with this volume group. The problem is that there is an mis-match between how we define the iscsi pool (with /dev/disk/by-id devices), and what data the discover_storage_pool_sources() returns (/dev devices), so we can't easily associate the two. The following patch implements stable path naming when the virStorageVolLookupByPath method is called. Basically, it tries to convert whatever path it is given (say /dev/sdc) into the form currently used by the Pool (say /dev/disk/by-id). It then goes and looks up the form in the pool, and returns the storageVolume object as appropriate. Note that it only tries to do this for the Pool types where it makes sense, namely iSCSI and disk; all other pool types stay exactly the same. With this in place, we can solve the mis-match in the above code, and LVM scanning seems to work in ovirt. Signed-off-by: Chris Lalancette <clalance(a)redhat.com>

2 7

[libvirt] Error setting up graphics device:list index out of range
by Frederik Himpe 03 Nov '08

03 Nov '08

When I try to create a new KVM VM x86_64, os variant Ubuntu Hardy, it fails at the end with this message: Error setting up graphics device:list index out of range Traceback (most recent call last): File "/usr/share/virt-manager/virtManager/create.py", line 640, in finish guest._graphics_dev = virtinst.VirtualGraphics (type=virtinst.VirtualGraphics.TYPE_VNC) File "/usr/lib/python2.5/site-packages/virtinst/Guest.py", line 207, in __init__ self.set_keymap(keymap) File "/usr/lib/python2.5/site-packages/virtinst/Guest.py", line 219, in set_keymap val = util.default_keymap() File "/usr/lib/python2.5/site-packages/virtinst/util.py", line 293, in default_keymap kt = s.split('"')[1] IndexError: list index out of range What could be wrong here? I'm using virt-manager 0.6.0, libvirt 0.4.6, python-virtinst 0.400.0 on Mandriva Linux 2009.0 x86_64. -- Frederik Himpe

1 0

[libvirt] Domain Events Python Bindings (Round 2)
by Ben Guthro 31 Oct '08

31 Oct '08

Attached are the python bindings for domain events as previously submitted: https://www.redhat.com/archives/libvir-list/2008-October/msg00707.html https://www.redhat.com/archives/libvir-list/2008-October/msg00668.html I have resolved most of the issues Daniel V. commented on I also addressed a number of ref counting problems. examples/domain-events/events-python/event-test.py | 186 ++++++++ python/Makefile.am | 5 python/generator.py | 19 python/libvir.c | 441 +++++++++++++++++++++ python/libvir.py | 20 python/libvirt_wrap.h | 27 + python/types.c | 47 ++ python/virConnect.py | 43 ++ 8 files changed, 782 insertions(+), 6 deletions(-)

2 5

[libvirt] [Q]Why does libvirt check size of memory in xenStoreDriver?
by S.Sakamoto 31 Oct '08

31 Oct '08

Hi, I have a question. Why does libvirt check size of memory in xenStoreDomainSetMemory of xs_internal.c? In the xen not exclude lifecycle, when I do the following command for the domain that is shutoff, error message is output and return value is 0 and the definition file(=/etc/xen/XXX) is updated. -------------------- # virsh setmem(or setmaxmem) guestdom 65535(4096-65535) libvir: Xen Store error : invalid argument in xenStoreDomainSetMemory # echo $? 0 -------------------- As a result that I research this, this error message is output by the check of the memory size in xenStoreDriver. Because libvirt checks the memory size of under 4096 in libvirt.c, I think that libvirt should check memory size range of 4096-65535 in libvirt.c. Thanks, Shigeki Sakamoto.

4 5

[libvirt] [PATCH]: Implement ruby-libvirt storage pool discovery binding
by Chris Lalancette 31 Oct '08

31 Oct '08

Attached is a pretty simple patch to implement the virConnectFindStoragePoolSources() binding for ruby-libvirt.This capability went into libvirt-0.4.5, so any version of libvirt that has storage API support should have support for this call. There's not much more to say; it works in my testing, and the implementation is pretty straightforward. Signed-off-by: Chris Lalancette <clalance(a)redhat.com>

2 2

[libvirt] [PATCH]: Update ruby-libvirt migrate binding to use rb_scan_args
by Chris Lalancette 31 Oct '08

31 Oct '08

It's really not a good idea to hand parse variable number of args to a ruby binding, like I implemented for the "migrate" method. Convert this to use rb_scan_args, which is the proper way to do it, and matches all of the other variable argument implementations in the binding. Signed-off-by: Chris Lalancette <clalance(a)redhat.com>

2 2