- Devel - libvirt List Archives

[libvirt] libvirt 0.5.0 and KVM migration
by Mickaël Canévet 02 Dec '08

02 Dec '08

Hi, I just installed libvirt 0.5.0 on Debian Lenny with KVM 0.72 to try KVM migration support. When I try to migrate a VM from one node to the other one, I have this error message: libvir: error : this function is not supported by the hypervisor: virDomainMigrate Is it really supposed to work ? Do I have to upgrade KVM to a newer version ? Thank you for your answers and congratulation for your precious work. -- _______________________________________________________________________ Mickaël Canévet. European Molecular Biology Laboratory (EMBL) Grenoble Outstation. FRANCE _______________________________________________________________________

3 6

[libvirt] Doubt over Kvm migration support in libvirt 0.5.0
by Shanmuga Rajan 02 Dec '08

02 Dec '08

I am using libvirt(python) to develop a small application which will manage my nodes which running in KVM. But when i tried migration i got this error. >>> vs.migrate(conn, libvirt.VIR_MIGRATE_LIVE,'testtt','192.168.1.82',0) libvir: error : this function is not supported by the hypervisor: virDomainMigrate Traceback (most recent call last): File "<stdin>", line 1, in ? File "/usr/lib64/python2.4/site-packages/libvirt.py", line 301, in migrate if ret is None:raise libvirtError('virDomainMigrate() failed', dom=self) libvirt.libvirtError: virDomainMigrate() failed this function is not supported by the hypervisor: virDomainMigrate i am running kvm-66 taken from Centos-5 Testing repositary and libvirt 0.5.0( 0.5.0: Nov 25 2008 release note says that support for kvm migration included) i am bit confused after reading this... Please any one help me in this. Thanks and Regards, -Shan

3 2

[libvirt] [PATCH] qemud/qemud.c (qemudCleanup): Plug a leak.
by Jim Meyering 01 Dec '08

01 Dec '08

Hi Dan, With your patches, "make check" hits one new leak: 40 bytes in 1 blocks are definitely lost in loss record 9 of 65 at 0x4A05174: calloc (vg_replace_malloc.c:397) by 0x447F29: virAllocN (memory.c:128) by 0x40CD82: qemudRunLoop (qemud.c:1839) by 0x40E713: main (qemud.c:2462) This fixes it: >From 9230c41d3deb00b4a0bb6800126e5cd41a350a54 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Mon, 1 Dec 2008 15:07:40 +0100 Subject: [PATCH] * qemud/qemud.c (qemudCleanup): Plug a leak. --- qemud/qemud.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/qemud/qemud.c b/qemud/qemud.c index 94f5918..8518bd5 100644 --- a/qemud/qemud.c +++ b/qemud/qemud.c @@ -1942,6 +1942,7 @@ static void qemudCleanup(struct qemud_server *server) { virStateCleanup(); + VIR_FREE(server->workers); free(server); } -- 1.6.0.4.1044.g77718

1 0

[libvirt] avoid "make check" hang on daemon-conf
by Jim Meyering 01 Dec '08

01 Dec '08

Hi Dan, With your 28-part patch, I was getting a daemon-conf failure in "make check". This fixes it: Unless you tell me otherwise, I will apply most of this right away, (and let you remove the space-before-max_clients in your patch) since no other part of this change conflicts with your series. >From 57842865f8845c788408e18033f739cf02987ca3 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Mon, 1 Dec 2008 14:12:44 +0100 Subject: [PATCH] tests: daemon-conf: accommodate new numeric-valued config params: This test would hang when failing to perturb the new numeric (and non-boolean) valued parameters, max_clients, max_workers, min_workers. * tests/daemon-conf: Require that all commented out settings in libvirtd.conf have the same form. Before, two parameters were not being tested, since a space had snuck between the leading "#" and the "param = value" parts. Apply each RHS-value-perturbing transformation separately, not in series. Let VERBOSE=yes turn on debugging. Be more verbose by default, since this is a relatively long-running test. * qemud/libvirtd.conf: Normalize the spacing around each setting that is to be perturbed by tests/daemon-conf. --- qemud/libvirtd.conf | 10 ++++++---- tests/daemon-conf | 32 ++++++++++++++++++++++++++------ 2 files changed, 32 insertions(+), 10 deletions(-) diff --git a/qemud/libvirtd.conf b/qemud/libvirtd.conf index f269766..b0962f2 100644 --- a/qemud/libvirtd.conf +++ b/qemud/libvirtd.conf @@ -1,7 +1,10 @@ # Master libvirt daemon configuration file # # For further information consult http://libvirt.org/format.html - +# +# NOTE: the tests/daemon-conf regression test script requires +# that each "PARAMETER = VALUE" line in this file have the parameter +# name just after a leading "#". ################################################################# # @@ -45,7 +48,7 @@ # Override the default configuration which binds to all network # interfaces. This can be a numeric IPv4/6 address, or hostname # -# listen_addr = "192.168.0.1" +#listen_addr = "192.168.0.1" # Flag toggling mDNS advertizement of the libvirt service. @@ -233,7 +236,7 @@ # The maximum number of concurrent client connections to allow # over all sockets combined. -# max_clients = 20 +#max_clients = 20 # The minimum limit sets the number of workers to start up @@ -243,4 +246,3 @@ # of clients allowed #min_workers = 5 #max_workers = 20 - diff --git a/tests/daemon-conf b/tests/daemon-conf index db1f0d3..03189d5 100755 --- a/tests/daemon-conf +++ b/tests/daemon-conf @@ -1,6 +1,11 @@ #!/bin/sh # Get coverage of libvirtd's config-parsing code. +if test "$VERBOSE" = yes; then + set -x + libvirtd --version +fi + # Boilerplate code to set up a test directory, cd into it, # and to ensure we remove it upon completion. this_test_() { echo "./$0" | sed 's,.*/,,'; } @@ -12,8 +17,14 @@ trap '(exit $?); exit $?' 1 2 13 15 mkdir "$t_" || fail=1 cd "$t_" || fail=1 +conf="$abs_top_srcdir/qemud/libvirtd.conf" + +# Ensure that each commented out PARAMETER = VALUE line has the expected form. +grep '[a-z_] *= *[^ ]' "$conf" | grep -vE '^#[a-z_]+ = ' \ + && { echo "$0: found unexpected lines (above) in $conf" 1>&2; exit 1; } + # Start with the sample libvirtd.conf file, uncommenting all real directives. -sed -n 's/^#$[^ #]$/\1/p' $abs_top_srcdir/qemud/libvirtd.conf > tmp.conf +sed -n 's/^#$[^ #]$/\1/p' "$conf" > tmp.conf # Iterate through that list of directives, corrupting one RHS at a # time and running libvirtd with the resulting config. Each libvirtd @@ -22,16 +33,23 @@ n=$(wc -l < tmp.conf) i=1 while :; do param_name=$(sed -n "$i"'s/ = .*//p' tmp.conf) + printf "testing with corrupted config: $param_name\n" 1>&2 rhs=$(sed -n "$i"'s/.* = $.*$/\1/p' tmp.conf) f=in$i.conf - # Change an RHS that starts with '"' or '[' to "3". - # Change an RHS that starts with 0 or 1 to the string '"foo"'. - sed "$i"'s/ = [["].*/ = 3/;'"$i"'s/ = [01].*/ = "foo"/' tmp.conf > $f + case $rhs in + # Change an RHS that starts with '"' or '[' to "3". + [[\"]*) sed "$i"'s/ = [["].*/ = 3/' tmp.conf > $f;; + # Change an RHS that starts with a digit to the string '"foo"'. + [0-9]*) sed "$i"'s/ = [0-9].*/ = "foo"/' tmp.conf > $f;; + esac + + # Run libvirtd, expecting it to fail. libvirtd --config=$f 2> err && fail=1 + case $rhs in # '"'*) msg='should be a string';; '"'*) msg='invalid type: got long; expected string';; - [01]*) msg='invalid type: got string; expected long';; + [0-9]*) msg='invalid type: got string; expected long';; '['*) msg='must be a string or list of strings';; *) echo "unexpected RHS: $rhs" 1>&2; fail=1;; esac @@ -48,8 +66,10 @@ while :; do done # Run with the unmodified config file. +sleep_secs=2 +printf "running libvirtd with a valid config file ($sleep_secs seconds)\n" 1>&2 libvirtd --config=tmp.conf > log 2>&1 & pid=$! -sleep 2 +sleep $sleep_secs kill $pid # Expect an orderly shut-down and successful exit. -- 1.6.0.4.1044.g77718

1 0

[libvirt] KVM/qemu: problems with autostart of vms with non-bridged nets
by Gerd von Egidy 01 Dec '08

01 Dec '08

Hi, I'm using libvirt 0.5.0 to manage my kvm domains. Everything works fine except autostarting vms which use a network device not directly bridged to hw. I have the following net defined (and set to autostart): <network> <name>local</name> <uuid>7ec7a457-0b8e-4670-3b4a-2d0914288daa</uuid> <bridge stp='on' forwardDelay='0' /> <ip address='192.168.100.1' netmask='255.255.255.0'> <dhcp> <range start='192.168.100.128' end='192.168.100.254' /> </dhcp> </ip> </network> When a vm using this net is autostarted I get the following error: libvir: error : invalid connection pointer in virNetworkLookupByName libvir: QEMU error : internal error Network 'local' not found Failed to autostart VM 'testlocalnet': internal error Network 'local' not found I took a dive into the code and found two problems causing this: 1. initialization order: qemuStateDriver is registered (and thus initialized) before networkStateDriver. This means the network is not up yet when qemu does it's autostart. I could fix this with the attached patch. 2. missing virConnectPtr during autostart of the vm: in src/qemu_driver.c:145, qemudAutostartConfigs() you can find this call: int ret = qemudStartVMDaemon(NULL, driver, vm, NULL); This means virConnectPtr conn is NULL within qemudStartVMDaemon(). Following the calls: qemudStartVMDaemon() -> qemudBuildCommandLine() -> qemudNetworkIfaceConnect() -> virNetworkLookupByName() virNetworkLookupByName bails out if called with invalid virConnectPtr. This means starting this vm fails. Currently I'm not familiar enough with the libvirt structures to come up with an idea how to fix this. Could anybody with a deeper knowledge of the code take a look at this? Thank you very much. Kind regards, Gerd diff -r -u libvirt-0.5.0.orig/qemud/qemud.c libvirt-0.5.0/qemud/qemud.c --- libvirt-0.5.0.orig/qemud/qemud.c 2008-11-21 13:47:32.000000000 +0100 +++ libvirt-0.5.0/qemud/qemud.c 2008-11-30 21:27:06.000000000 +0100 @@ -761,22 +761,13 @@ * If they try to use a open a connection for a module that * is not loaded they'll get a suitable error at that point */ - virDriverLoadModule("qemu"); - virDriverLoadModule("lxc"); - virDriverLoadModule("uml"); virDriverLoadModule("network"); virDriverLoadModule("storage"); virDriverLoadModule("nodedev"); + virDriverLoadModule("qemu"); + virDriverLoadModule("lxc"); + virDriverLoadModule("uml"); #else -#ifdef WITH_QEMU - qemuRegister(); -#endif -#ifdef WITH_LXC - lxcRegister(); -#endif -#ifdef WITH_UML - umlRegister(); -#endif #ifdef WITH_NETWORK networkRegister(); #endif @@ -786,6 +777,15 @@ #if defined(HAVE_HAL) || defined(HAVE_DEVKIT) nodedevRegister(); #endif +#ifdef WITH_QEMU + qemuRegister(); +#endif +#ifdef WITH_LXC + lxcRegister(); +#endif +#ifdef WITH_UML + umlRegister(); +#endif #endif virEventRegisterImpl(virEventAddHandleImpl, -- Address (better: trap) for people I really don't want to get mail from: james(a)cactusamerica.com

2 2

[libvirt] [PATCH] avoid format string warnings
by Jim Meyering 01 Dec '08

01 Dec '08

Hi Dan, I've just applied all of your changes, built, and saw some new warnings: uml_driver.c:1742: warning: format not a string literal and no format arguments uml_driver.c:1748: warning: format not a string literal and no format arguments uml_driver.c:1785: warning: format not a string literal and no format arguments openvz_conf.c:468: warning: format not a string literal and no format arguments But they were introduced before your changes. Here's the patch, on top of your changes. Note that as is, the patch does not apply to the latest in CVS, so my checking it in there would induce merge conflicts for you. So I'll hold off until after your 28-part series is committed. Jim >From fb32deb5dfb2a3c6b598de619f25c0bae4314a05 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Mon, 1 Dec 2008 11:17:08 +0100 Subject: [PATCH] avoid format string warnings * src/uml_driver.c (umlDomainBlockPeek): Put "%s" before each literal format string with no % directive. * src/openvz_conf.c (openvzGetNodeCPUs): Likewise. --- src/openvz_conf.c | 2 +- src/uml_driver.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/openvz_conf.c b/src/openvz_conf.c index fc4ef20..1361c53 100644 --- a/src/openvz_conf.c +++ b/src/openvz_conf.c @@ -466,7 +466,7 @@ openvzGetNodeCPUs(void) if (virNodeInfoPopulate(NULL, &nodeinfo) < 0) { openvzError(NULL, VIR_ERR_INTERNAL_ERROR, - _("Cound not read nodeinfo")); + "%s", _("Cound not read nodeinfo")); return 0; } diff --git a/src/uml_driver.c b/src/uml_driver.c index d2f2c7b..8d33c70 100644 --- a/src/uml_driver.c +++ b/src/uml_driver.c @@ -1740,13 +1740,13 @@ umlDomainBlockPeek (virDomainPtr dom, if (!vm) { umlReportError (dom->conn, dom, NULL, VIR_ERR_INVALID_DOMAIN, - _("no domain with matching uuid")); + "%s", _("no domain with matching uuid")); goto cleanup; } if (!path || path[0] == '\0') { umlReportError(dom->conn, dom, NULL, VIR_ERR_INVALID_ARG, - _("NULL or empty path")); + "%s", _("NULL or empty path")); goto cleanup; } @@ -1783,7 +1783,7 @@ umlDomainBlockPeek (virDomainPtr dom, ret = 0; } else { umlReportError (dom->conn, dom, NULL, VIR_ERR_INVALID_ARG, - _("invalid path")); + "%s", _("invalid path")); } cleanup: -- 1.6.0.4.1044.g77718

1 0

[libvirt] Memory leak in xen_inotify.c
by Niraj Tolia 30 Nov '08

30 Nov '08

Hi, It looks like xenInotifyOpen() in xen_inotify.c has an opendir() call. However, as there is no corresponding closedir() and opendir() uses malloc internally, valgrind reports this as a memory leak. Adding a closedir() to the end of this function should fix this. Cheers, Niraj

2 1

[libvirt] libvirt + xen 3.2.1 oddities
by Guido Günther 28 Nov '08

28 Nov '08

Hi, I just ran across these oddities when using a bit more libvirt+xen: 1.) virsh setmaxmem: On a running domain: # virsh setmaxmem domain 256000 completes but virsh dumpxml as well as the config.sxp still shows the old amount of memory. Looks as the set_maxmem hypercall simply gets ignored. xm mem-max works as expected. Smells like a bug in the ioctl? 2.) virsh list: Sometimes (didn't find a pattern yet) when shutting down a running domains and restarting it I'm seeing: Id Name State ---------------------------------- 0 Domain-0 running 2 foo idle libvir: Xen Daemon error : GET operation failed: xend_get: error from xen daemon: libvir: Xen Daemon error : GET operation failed: xend_get: error from xen daemon: libvir: Xen Daemon error : GET operation failed: xend_get: error from xen daemon: libvir: Xen Daemon error : GET operation failed: xend_get: error from xen daemon: 7 bar idle Note that the number of errors the corresponds to the number of shutdowns. VirXen_getdomaininfolist returns 7 in the above case. virDomainLookupByID later on fails for these "additional" domains. 3.) virsh list: Duplicate domains: Id Name State ---------------------------------- 0 Domain-0 running libvir: Xen Daemon error : GET operation failed: xend_get: error from xen daemon: libvir: Xen Daemon error : GET operation failed: xend_get: error from xen daemon: libvir: Xen Daemon error : GET operation failed: xend_get: error from xen daemon: 14 bar no state libvir: Xen Daemon error : GET operation failed: xend_get: error from xen daemon: 16 bar idle Domain 14 can't be shut down (xm list only lists domain 16). Could be a similar problem as the above. This is all libvirt 0.4.6 (but the code looks very similar in gurrent CVS) and xen-3.2.1 on Debian. The detected ABI is hypervisor call v2, sys ver6 dom ver5. And from a quick glance at the libxen-dev package the structs seem to match. Cheers, -- Guido

3 7

[libvirt] PATCH: Fix XM driver handling of disks without source file
by Daniel P. Berrange 28 Nov '08

28 Nov '08

It is possible for disks to be listed without a source file against them, eg a CDROM device with no media loaded. The XenD driver handles this, but the XM driver incorrectly generates XML with a <source file=''/> element instead of omitting the element entirely. This causes a bogus SXEXPR to be sent to XenD when starting the domain. This patch does three things - Makes the generic domain_conf.c XML parser accept XML docs with a bogus <source file=''/> and convert the source to NULL, instead of passing along the empty string "". This protects against broken apps - Makes the XM driver correctly generate XML in the first place, so omitting the <source> tag entirely. This is the root cause fix - Adds a test case for the XM driver to validate handling of devices with a source file src/domain_conf.c | 8 +++ src/xm_internal.c | 70 ++++++++++++++++------------ tests/xmconfigdata/test-no-source-cdrom.cfg | 23 +++++++++ tests/xmconfigdata/test-no-source-cdrom.xml | 46 ++++++++++++++++++ tests/xmconfigtest.c | 1 5 files changed, 120 insertions(+), 28 deletions(-) Daniel Index: src/xm_internal.c =================================================================== RCS file: /data/cvs/libvirt/src/xm_internal.c,v retrieving revision 1.102 diff -u -p -r1.102 xm_internal.c --- src/xm_internal.c 25 Nov 2008 11:18:08 -0000 1.102 +++ src/xm_internal.c 27 Nov 2008 12:14:57 -0000 @@ -828,7 +828,7 @@ xenXMDomainConfigParse(virConnectPtr con while (list) { char *head; char *offset; - char *tmp, *tmp1; + char *tmp; if ((list->type != VIR_CONF_STRING) || (list->str == NULL)) goto skipdisk; @@ -850,10 +850,15 @@ xenXMDomainConfigParse(virConnectPtr con goto skipdisk; if ((offset - head) >= (PATH_MAX-1)) goto skipdisk; - if (VIR_ALLOC_N(disk->src, (offset - head) + 1) < 0) - goto no_memory; - strncpy(disk->src, head, (offset - head)); - disk->src[(offset-head)] = '\0'; + + if (offset == head) { + disk->src = NULL; /* No source file given, eg CDROM with no media */ + } else { + if (VIR_ALLOC_N(disk->src, (offset - head) + 1) < 0) + goto no_memory; + strncpy(disk->src, head, (offset - head)); + disk->src[(offset-head)] = '\0'; + } head = offset + 1; /* Remove legacy ioemu: junk */ @@ -871,32 +876,41 @@ xenXMDomainConfigParse(virConnectPtr con /* Extract source driver type */ - if (disk->src && - (tmp = strchr(disk->src, ':')) != NULL) { - if (VIR_ALLOC_N(disk->driverName, (tmp - disk->src) + 1) < 0) - goto no_memory; - strncpy(disk->driverName, disk->src, (tmp - disk->src)); - disk->driverName[tmp - disk->src] = '\0'; - } else { - if (!(disk->driverName = strdup("phy"))) - goto no_memory; - tmp = disk->src; - } + if (disk->src) { + /* The main type phy:, file:, tap: ... */ + if ((tmp = strchr(disk->src, ':')) != NULL) { + if (VIR_ALLOC_N(disk->driverName, (tmp - disk->src) + 1) < 0) + goto no_memory; + strncpy(disk->driverName, disk->src, (tmp - disk->src)); + disk->driverName[tmp - disk->src] = '\0'; - /* And the source driver sub-type */ - if (STRPREFIX(disk->driverName, "tap")) { - if (!(tmp1 = strchr(tmp+1, ':')) || !tmp1[0]) - goto skipdisk; - if (VIR_ALLOC_N(disk->driverType, (tmp1-(tmp+1))) < 0) - goto no_memory; - strncpy(disk->driverType, tmp+1, (tmp1-(tmp+1))); - memmove(disk->src, disk->src+(tmp1-disk->src)+1, strlen(disk->src)-(tmp1-disk->src)); - } else { - disk->driverType = NULL; - if (disk->src[0] && tmp) - memmove(disk->src, disk->src+(tmp-disk->src)+1, strlen(disk->src)-(tmp-disk->src)); + /* Strip the prefix we found off the source file name */ + memmove(disk->src, disk->src+(tmp-disk->src)+1, + strlen(disk->src)-(tmp-disk->src)); + } + + /* And the sub-type for tap:XXX: type */ + if (disk->driverName && + STREQ(disk->driverName, "tap")) { + if (!(tmp = strchr(disk->src, ':'))) + goto skipdisk; + if (VIR_ALLOC_N(disk->driverType, (tmp - disk->src) + 1) < 0) + goto no_memory; + strncpy(disk->driverType, disk->src, (tmp - disk->src)); + disk->driverType[tmp - disk->src] = '\0'; + + /* Strip the prefix we found off the source file name */ + memmove(disk->src, disk->src+(tmp-disk->src)+1, + strlen(disk->src)-(tmp-disk->src)); + } } + /* No source, or driver name, so fix to phy: */ + if (!disk->driverName && + !(disk->driverName = strdup("phy"))) + goto no_memory; + + /* phy: type indicates a block device */ disk->type = STREQ(disk->driverName, "phy") ? VIR_DOMAIN_DISK_TYPE_BLOCK : VIR_DOMAIN_DISK_TYPE_FILE; Index: src/domain_conf.c =================================================================== RCS file: /data/cvs/libvirt/src/domain_conf.c,v retrieving revision 1.39 diff -u -p -r1.39 domain_conf.c --- src/domain_conf.c 21 Nov 2008 11:42:51 -0000 1.39 +++ src/domain_conf.c 27 Nov 2008 12:15:06 -0000 @@ -546,6 +546,14 @@ virDomainDiskDefParseXML(virConnectPtr c source = virXMLPropString(cur, "file"); else source = virXMLPropString(cur, "dev"); + + /* People sometimes pass a bogus '' source path + when they mean to omit the source element + completely. eg CDROM without media. This is + just a little compatability check to help + those broken apps */ + if (source && STREQ(source, "")) + VIR_FREE(source); } else if ((target == NULL) && (xmlStrEqual(cur->name, BAD_CAST "target"))) { target = virXMLPropString(cur, "dev"); Index: tests/xmconfigtest.c =================================================================== RCS file: /data/cvs/libvirt/tests/xmconfigtest.c,v retrieving revision 1.24 diff -u -p -r1.24 xmconfigtest.c --- tests/xmconfigtest.c 24 Nov 2008 19:23:39 -0000 1.24 +++ tests/xmconfigtest.c 27 Nov 2008 12:15:13 -0000 @@ -229,6 +229,7 @@ mymain(int argc, char **argv) DO_TEST("fullvirt-sound", 2); DO_TEST("escape-paths", 2); + DO_TEST("no-source-cdrom", 2); virCapabilitiesFree(caps); Index: tests/xmconfigdata/test-no-source-cdrom.cfg =================================================================== RCS file: tests/xmconfigdata/test-no-source-cdrom.cfg diff -N tests/xmconfigdata/test-no-source-cdrom.cfg --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ tests/xmconfigdata/test-no-source-cdrom.cfg 27 Nov 2008 12:15:27 -0000 @@ -0,0 +1,23 @@ +name = "test" +uuid = "cc2315e7-d26a-307a-438c-6d188ec4c09c" +maxmem = 382 +memory = 350 +vcpus = 1 +builder = "hvm" +kernel = "/usr/lib/xen/boot/hvmloader" +boot = "c" +pae = 1 +acpi = 1 +apic = 1 +localtime = 0 +on_poweroff = "destroy" +on_reboot = "destroy" +on_crash = "destroy" +device_model = "/usr/lib/xen/bin/qemu-dm" +sdl = 0 +vnc = 1 +vncunused = 1 +disk = [ "phy:/dev/sda8,hda,w", ",hdc:cdrom,r" ] +vif = [ "mac=00:16:3e:0a:7b:39,bridge=xenbr0,type=ioemu" ] +parallel = "none" +serial = "pty" Index: tests/xmconfigdata/test-no-source-cdrom.xml =================================================================== RCS file: tests/xmconfigdata/test-no-source-cdrom.xml diff -N tests/xmconfigdata/test-no-source-cdrom.xml --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ tests/xmconfigdata/test-no-source-cdrom.xml 27 Nov 2008 12:15:27 -0000 @@ -0,0 +1,46 @@ +<domain type='xen'> + <name>test</name> + <uuid>cc2315e7-d26a-307a-438c-6d188ec4c09c</uuid> + <memory>391168</memory> + <currentMemory>358400</currentMemory> + <vcpu>1</vcpu> + <os> + <type arch='i686' machine='xenfv'>hvm</type> + <loader>/usr/lib/xen/boot/hvmloader</loader> + <boot dev='hd'/> + </os> + <features> + <acpi/> + <apic/> + <pae/> + </features> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>destroy</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <emulator>/usr/lib/xen/bin/qemu-dm</emulator> + <disk type='block' device='disk'> + <driver name='phy'/> + <source dev='/dev/sda8'/> + <target dev='hda' bus='ide'/> + </disk> + <disk type='block' device='cdrom'> + <driver name='phy'/> + <target dev='hdc' bus='ide'/> + <readonly/> + </disk> + <interface type='bridge'> + <mac address='00:16:3e:0a:7b:39'/> + <source bridge='xenbr0'/> + </interface> + <serial type='pty'> + <target port='0'/> + </serial> + <console type='pty'> + <target port='0'/> + </console> + <input type='mouse' bus='ps2'/> + <graphics type='vnc' port='-1' autoport='yes'/> + </devices> +</domain> -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 2

[libvirt] PATCH: Fix QEMU/UML use of libnuma
by Daniel P. Berrange 28 Nov '08

28 Nov '08

The 2.x series of numactl releases changed the ABI/API for certain libnuma.so functions we use. Fortunately it turns out that they provide back-compatability of both ABI and API with a combo of linker script magic, and header file inline compat functions. So, all we need todo is #define NUMA_VERSION1_COMPATIBILITY before include numa.h in our code. This new code did, however, expose a bug in our use of the existing API. We were calculating size in bytes, instead of size in longs, so were passing a buffer that was 8 times to large. Harmless, but the new libnuma validates that the buffer is expected size. So this patch also fixes us to pass & allocate correct buffer size. Finally, also add a missing BuildRequire on numactl-devel, and fixes the libvirtd automake build dependancy Daniel Index: libvirt.spec.in =================================================================== RCS file: /data/cvs/libvirt/libvirt.spec.in,v retrieving revision 1.103 diff -u -p -r1.103 libvirt.spec.in --- libvirt.spec.in 26 Nov 2008 14:46:49 -0000 1.103 +++ libvirt.spec.in 27 Nov 2008 13:20:24 -0000 @@ -124,6 +124,8 @@ BuildRequires: lvm2 BuildRequires: iscsi-initiator-utils # For disk driver BuildRequires: parted-devel +# For QEMU/LXC numa info +BuildRequires: numactl-devel Obsoletes: libvir # Fedora build root suckage Index: qemud/Makefile.am =================================================================== RCS file: /data/cvs/libvirt/qemud/Makefile.am,v retrieving revision 1.61 diff -u -p -r1.61 Makefile.am --- qemud/Makefile.am 21 Nov 2008 12:27:11 -0000 1.61 +++ qemud/Makefile.am 27 Nov 2008 13:20:24 -0000 @@ -87,7 +87,6 @@ libvirtd_LDFLAGS = \ $(COVERAGE_LDFLAGS) \ $(POLKIT_LIBS) -libvirtd_DEPENDENCIES = ../src/libvirt.la libvirtd_LDADD = \ ../gnulib/lib/libgnu.la @@ -129,6 +128,9 @@ libvirtd_CFLAGS += $(AVAHI_CFLAGS) libvirtd_LDADD += $(AVAHI_LIBS) endif +libvirtd_DEPENDENCIES = $(libvirtd_LDADD) + + default_xml_dest = libvirt/qemu/networks/default.xml install-data-local: install-init install-data-sasl install-data-polkit mkdir -p $(DESTDIR)$(sysconfdir)/libvirt/qemu/networks/autostart Index: src/qemu_conf.c =================================================================== RCS file: /data/cvs/libvirt/src/qemu_conf.c,v retrieving revision 1.108 diff -u -p -r1.108 qemu_conf.c --- src/qemu_conf.c 19 Nov 2008 16:58:23 -0000 1.108 +++ src/qemu_conf.c 27 Nov 2008 13:20:24 -0000 @@ -37,6 +37,7 @@ #include <sys/utsname.h> #if HAVE_NUMACTL +#define NUMA_VERSION1_COMPATIBILITY 1 #include <numa.h> #endif @@ -300,11 +301,11 @@ qemudCapsInitGuest(virCapsPtr caps, #if HAVE_NUMACTL #define MAX_CPUS 4096 #define MAX_CPUS_MASK_SIZE (sizeof(unsigned long)) -#define MAX_CPUS_MASK_LEN (MAX_CPUS / MAX_CPUS_MASK_SIZE) -#define MAX_CPUS_MASK_BYTES (MAX_CPUS / 8) +#define MAX_CPUS_MASK_BITS (MAX_CPUS_MASK_SIZE * 8) +#define MAX_CPUS_MASK_LEN (MAX_CPUS / (MAX_CPUS_MASK_BITS)) #define MASK_CPU_ISSET(mask, cpu) \ - (((mask)[((cpu) / MAX_CPUS_MASK_SIZE)] >> ((cpu) % MAX_CPUS_MASK_SIZE)) & 1) + (((mask)[((cpu) / MAX_CPUS_MASK_BITS)] >> ((cpu) % MAX_CPUS_MASK_BITS)) & 1) static int qemudCapsInitNUMA(virCapsPtr caps) @@ -322,7 +323,8 @@ qemudCapsInitNUMA(virCapsPtr caps) goto cleanup; for (n = 0 ; n <= numa_max_node() ; n++) { - if (numa_node_to_cpus(n, mask, MAX_CPUS_MASK_BYTES) < 0) + + if (numa_node_to_cpus(n, mask, MAX_CPUS_MASK_LEN) < 0) goto cleanup; for (ncpus = 0, i = 0 ; i < MAX_CPUS ; i++) Index: src/qemu_driver.c =================================================================== RCS file: /data/cvs/libvirt/src/qemu_driver.c,v retrieving revision 1.160 diff -u -p -r1.160 qemu_driver.c --- src/qemu_driver.c 21 Nov 2008 12:16:08 -0000 1.160 +++ src/qemu_driver.c 27 Nov 2008 13:20:25 -0000 @@ -45,6 +45,7 @@ #include <sys/ioctl.h> #if HAVE_NUMACTL +#define NUMA_VERSION1_COMPATIBILITY 1 #include <numa.h> #endif Index: src/uml_conf.c =================================================================== RCS file: /data/cvs/libvirt/src/uml_conf.c,v retrieving revision 1.1 diff -u -p -r1.1 uml_conf.c --- src/uml_conf.c 19 Nov 2008 16:58:23 -0000 1.1 +++ src/uml_conf.c 27 Nov 2008 13:20:25 -0000 @@ -37,6 +37,7 @@ #include <sys/utsname.h> #if HAVE_NUMACTL +#define NUMA_VERSION1_COMPATIBILITY 1 #include <numa.h> #endif @@ -56,11 +57,11 @@ #if HAVE_NUMACTL #define MAX_CPUS 4096 #define MAX_CPUS_MASK_SIZE (sizeof(unsigned long)) -#define MAX_CPUS_MASK_LEN (MAX_CPUS / MAX_CPUS_MASK_SIZE) -#define MAX_CPUS_MASK_BYTES (MAX_CPUS / 8) +#define MAX_CPUS_MASK_BITS (MAX_CPUS_MASK_SIZE * 8) +#define MAX_CPUS_MASK_LEN (MAX_CPUS / (MAX_CPUS_MASK_BITS)) #define MASK_CPU_ISSET(mask, cpu) \ - (((mask)[((cpu) / MAX_CPUS_MASK_SIZE)] >> ((cpu) % MAX_CPUS_MASK_SIZE)) & 1) + (((mask)[((cpu) / MAX_CPUS_MASK_BITS)] >> ((cpu) % MAX_CPUS_MASK_BITS)) & 1) static int umlCapsInitNUMA(virCapsPtr caps) @@ -78,7 +79,8 @@ umlCapsInitNUMA(virCapsPtr caps) goto cleanup; for (n = 0 ; n <= numa_max_node() ; n++) { - if (numa_node_to_cpus(n, mask, MAX_CPUS_MASK_BYTES) < 0) + + if (numa_node_to_cpus(n, mask, MAX_CPUS_MASK_LEN) < 0) goto cleanup; for (ncpus = 0, i = 0 ; i < MAX_CPUS ; i++) Index: src/uml_driver.c =================================================================== RCS file: /data/cvs/libvirt/src/uml_driver.c,v retrieving revision 1.2 diff -u -p -r1.2 uml_driver.c --- src/uml_driver.c 21 Nov 2008 10:06:28 -0000 1.2 +++ src/uml_driver.c 27 Nov 2008 13:20:25 -0000 @@ -46,6 +46,7 @@ #include <sys/inotify.h> #if HAVE_NUMACTL +#define NUMA_VERSION1_COMPATIBILITY 1 #include <numa.h> #endif -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

3 3

[libvirt] Hide fully-virtualized network devices to domU with PV drivers
by Iain Watson 28 Nov '08

28 Nov '08

Hello, I have a problem with libvirt which I hope someone on this list might be able to help with. I have many DomU images which all have PV drivers loaded for network. I want to start these DomU guests with only the PV network device being visible from within the DomU. In testing I have been able to create the required system with the 'xm' command. The important part of the network line is "type=none". The complete line looks like: vif = [ "mac=00:16:3e:00:a5:57,bridge=eth0,script=vif-bridge,type=none" ] With libvirt I have tried adding "<model type='none'/>" into the interface section but this errors with "qemu: Unsupported NIC: none" so I'm obviously missing something obvious. The complete interface section looks like: <interface type='bridge'> <mac address='00:16:3e:00:a5:57'/> <source bridge='eth0'/> <target dev='vif9.0'/> <model type='none'/> </interface> I have been able to achieve the required configuration if I completely omit an 'interface' section and once the DomU has booted I use virsh to add an interface to the domain. Unfortunately if I then reboot the DomU the guest comes back up with two network interfaces visible to it and the qemu-dm line has added a "-net ...,model=rtl8139" option. Having hunted around I am yet to find a way to configure a domU in libvirt so the networking available to the guest is the way I require. As I can do this with xm, I'm hoping someone on this list can point me in the right direction to also do this with libvirt. Thanks in advance, Iain Watson

1 0

[libvirt] [PATCH 1/2]: Give /dev/disk/by-{id, path} a chance to exist
by Chris Lalancette 28 Nov '08

28 Nov '08

This patch is the same idea as my previous patch for giving /dev/disk/by-{id,path} a chance to exist. Currently libvirt can race with udev creation of /dev/disk/by-{id,path}, so if we fail to open the directory, retry up to 5 seconds. This is only likely to happen on hosts that are: 1) diskless (so /dev/disk/by-{id,path} doesn't exist already), and 2) slow, and/or heavily loaded (meaning that udev can take some time to create the /dev nodes). Based on the feedback from Dan and Jim, I updated the patch to look more like what is elsewhere in libvirt. Signed-off-by: Chris Lalancette <clalance(a)redhat.com> Index: src/storage_backend.c =================================================================== RCS file: /data/cvs/libvirt/src/storage_backend.c,v retrieving revision 1.29 diff -u -r1.29 storage_backend.c --- a/src/storage_backend.c 17 Nov 2008 11:19:33 -0000 1.29 +++ b/src/storage_backend.c 26 Nov 2008 12:09:36 -0000 @@ -291,6 +291,7 @@ DIR *dh; struct dirent *dent; char *stablepath; + int opentries = 0; /* Short circuit if pool has no target, or if its /dev */ if (pool->def->target.path == NULL || @@ -304,12 +305,17 @@ if (!STRPREFIX(pool->def->target.path, "/dev")) goto ret_strdup; - /* The pool is pointing somewhere like /dev/disk/by-path - * or /dev/disk/by-id, so we need to check all symlinks in - * the target directory and figure out which one points - * to this device node + /* We loop here because /dev/disk/by-{id,path} may not have existed + * before we started this operation, so we have to give it some time to + * get created. */ + reopen: if ((dh = opendir(pool->def->target.path)) == NULL) { + opentries++; + if (errno == ENOENT && opentries < 50) { + usleep(100 * 1000); + goto reopen; + } virStorageReportError(conn, VIR_ERR_INTERNAL_ERROR, _("cannot read dir %s: %s"), pool->def->target.path, @@ -317,6 +323,11 @@ return NULL; } + /* The pool is pointing somewhere like /dev/disk/by-path + * or /dev/disk/by-id, so we need to check all symlinks in + * the target directory and figure out which one points + * to this device node + */ while ((dent = readdir(dh)) != NULL) { if (dent->d_name[0] == '.') continue;

2 2

[libvirt] PATCH: Allow automatic driver probe for remote TCP connections
by Daniel P. Berrange 27 Nov '08

27 Nov '08

When connecting to a local libvirt you can let it automatically probe the hypervisor URI if you don't know it ahead of time. This doesn't work with remote URIs because you need to have something to put in the URI scheme before the hostname qemu+ssh://somehost/system xen+tcp://somehost/system This is then translated into the URI qemu:///system xen:/// It occurred to me that we can trivially enable probing with all existing libvirtd daemon releases, simply by fixing the client side. All we need todo is invent a new generic URI scheme, and convert that to empty string This patch adds a 'remote' URI scheme, usable like this remote+ssh://somehost/ remote+tcp://somehost/ remote://somehost/ remote+tls://somehost/ remote+ext://somehost/ In all these styles, the URI passed to the remote daemon is "", causing it to probe. As a demonstration, here's an example using virsh and two hosts I have, one running Xen, the other QEMU See it automatically choosing QEMU.... $ virsh --connect remote+ssh://root@lettuce/ version Compiled against library: libvir 0.5.0 Using library: libvir 0.5.0 Running hypervisor: QEMU 0.9.1 And choosing Xen.... $ virsh --connect remote+ssh://root@pumpkin/ version Compiled against library: libvir 0.5.0 Using library: libvir 0.5.0 Running hypervisor: Xen 3.1.0 This finally makes the Avahi broadcasts useful - they only include info on the hostname + data transport (SSH, TCP, TLS), not the HV type. So letting us use auto-probing remotely is the missing link. NB. we've got a small problem with the virGetVersion() API - it does not take a connection URI - just a hypervisor type. It then directly checks the statically declared 'version' field in the virDriverPtr struct. This no longer works now that some drivers are linked directly into the libvirt daemon. I'm thinking that perhaps we can just change the virGetVersion() apis so that instead of looking in virDriverPtr struct, we just include the version numbers directly in virGetVersion as a static const lookup table. Meanwhile, this patch also includes a change to virsh to stop it calling virGetVersion(), though this hunk instead intended to apply to CVS. Daniel Index: remote_internal.c =================================================================== RCS file: /data/cvs/libvirt/src/remote_internal.c,v retrieving revision 1.108 diff -u -p -r1.108 remote_internal.c --- remote_internal.c 21 Nov 2008 12:31:04 -0000 1.108 +++ remote_internal.c 26 Nov 2008 21:58:47 -0000 @@ -430,28 +430,40 @@ doRemoteOpen (virConnectPtr conn, /* Construct the original name. */ if (!name) { - xmlURI tmpuri = { - .scheme = conn->uri->scheme, + if (STREQ(conn->uri->scheme, "remote") || + STRPREFIX(conn->uri->scheme, "remote+")) { + /* Allow remote serve to probe */ + name = strdup(""); + } else { + xmlURI tmpuri = { + .scheme = conn->uri->scheme, #ifdef HAVE_XMLURI_QUERY_RAW - .query_raw = qparam_get_query (vars), + .query_raw = qparam_get_query (vars), #else - .query = qparam_get_query (vars), + .query = qparam_get_query (vars), #endif - .path = conn->uri->path, - .fragment = conn->uri->fragment, - }; - - /* Evil, blank out transport scheme temporarily */ - if (transport_str) { - assert (transport_str[-1] == '+'); - transport_str[-1] = '\0'; - } + .path = conn->uri->path, + .fragment = conn->uri->fragment, + }; + + /* Evil, blank out transport scheme temporarily */ + if (transport_str) { + assert (transport_str[-1] == '+'); + transport_str[-1] = '\0'; + } + + name = (char *) xmlSaveUri (&tmpuri); - name = (char *) xmlSaveUri (&tmpuri); +#ifdef HAVE_XMLURI_QUERY_RAW + VIR_FREE(tmpuri.query_raw); +#else + VIR_FREE(tmpuri.query); +#endif - /* Restore transport scheme */ - if (transport_str) - transport_str[-1] = '+'; + /* Restore transport scheme */ + if (transport_str) + transport_str[-1] = '+'; + } } free_qparam_set (vars); Index: virsh.c =================================================================== RCS file: /data/cvs/libvirt/src/virsh.c,v retrieving revision 1.175 diff -u -p -r1.175 virsh.c --- virsh.c 24 Nov 2008 07:13:30 -0000 1.175 +++ virsh.c 26 Nov 2008 21:58:51 -0000 @@ -4357,7 +4357,6 @@ cmdVersion(vshControl *ctl, const vshCmd const char *hvType; unsigned long libVersion; unsigned long includeVersion; - unsigned long apiVersion; int ret; unsigned int major; unsigned int minor; @@ -4380,7 +4379,8 @@ cmdVersion(vshControl *ctl, const vshCmd vshPrint(ctl, _("Compiled against library: libvir %d.%d.%d\n"), major, minor, rel); - ret = virGetVersion(&libVersion, hvType, &apiVersion); + + ret = virGetVersion(&libVersion, NULL, NULL); if (ret < 0) { vshError(ctl, FALSE, "%s", _("failed to get the library version")); return FALSE; @@ -4392,13 +4392,6 @@ cmdVersion(vshControl *ctl, const vshCmd vshPrint(ctl, _("Using library: libvir %d.%d.%d\n"), major, minor, rel); - major = apiVersion / 1000000; - apiVersion %= 1000000; - minor = apiVersion / 1000; - rel = apiVersion % 1000; - vshPrint(ctl, _("Using API: %s %d.%d.%d\n"), hvType, - major, minor, rel); - ret = virConnectGetVersion(ctl->conn, &hvVersion); if (ret < 0) { vshError(ctl, FALSE, "%s", _("failed to get the hypervisor version")); -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 2

[libvirt] [PATCH] Prefer xend setmaxmem interface
by Jim Fehlig 27 Nov '08

27 Nov '08

As discussed in [1], prefer xend interface for setting max memory. Regards, Jim [1] https://www.redhat.com/archives/libvir-list/2008-November/msg00339.html

3 3

[libvirt] [PATCH 0/2]: Make storage_backend device scanning more reliable
by Chris Lalancette 26 Nov '08

26 Nov '08

All, This is a 2 part patch series to make libvirt backend device scanning more reliable. In particular, this is important for things that can create/destroy udev /dev nodes, since at present we can race with the udev creation. Note that this takes over the previous patch that I posted to retry /dev/disk/by-{id,path} scanning. Signed-off-by: Chris Lalancette <clalance(a)redhat.com>

2 1

[libvirt] make not invoking rpcgen remote_protocol.x
by Kenneth Nagin 26 Nov '08

26 Nov '08

I am attempting to add some new libvirt functions that I intend to submit for your approval. I have made changes to remote_protocol.x. Initially it generated the expected files. However, after making a few changes the make no causes it to generate files. Manually invoke rpcgen -c remote_protocol.x > remote_protocol.c seems to get around the compile problem. But now I'm getting a "Remote error : marshaling args" I 'm think there is a problem in the make. Kenneth Nagin

3 4

[libvirt] libvirt_low_level_storage_api
by shahar＠compal1.qumranet.com 26 Nov '08

26 Nov '08

Hi All, here is an initial version of the operations required for SolidICE and the proposed high level interface. I would like to discuss how to map it to libvirt calls and what libvirt calls are missing. Thanks, Shahar Frank HostLevel --------- enumarateLuns(): return: returns all luns visible by the host. In case multipathing is enabled then only the multipath device should be in the return list. enumerateISCSILuns(target): params: target - ISCSI target Description: enumerate all ISCSI luns on a specific target return: list of getBlockInfo(name or UUID): return: at least uuid & size enumerateVGs(): return: VG UUID list open issues - should we assume ISCSI auto connect or FC login? StoragePool level ----------------- createVolumeGroup(name, devices): params: name = name devices - a list of UUIDs description: Should create a volume group out of the UUID list In case multipathing is enabled then only the multipath device should be used In case it is not a PV yet then a PV is to be created. Return: Uuid of the VG removeVolumeGroup(VG): params: VG - uuid of the Volume group Description: Remove all remains for the VolumeGroup (LVs, PVs ...) Return: Sucsess/failure mountNFS(server, remotePath, localPath, params) params: server - the NFS server name or IP temotePath - remote server export path localPath - local path to mount on params - nfs mount params description: mounts the remote export onto the local path using the mount params return: success/failure unmount(localPath, forceFlag) params: localPath - the local path to unmount forceFlag - a flag indicating whether to force unmount description: unmounts local path (trivial) return: success/failure Open issues: 1. NFS configuration persistency? 2. What happens in case the libvirt is restarted should it be reconfigured? VolumeGroup level ----------------- listPV(VG): params: VG - Volume group UUID Description: Lists all PV in a specific volume group Return: A list of PV UUIDs infoPV(VG, PV) params: VG - Volume group UUID PV - Physical volume UUID description: trivial return: returns the PV information (at least size & path) extendVolumeGroup(VG, devices): params: VG - Volume Group UUID devices - a list of UUIDs description: This function adds Phisical Volume to the VolumeGroup. Each UUID device is checked, In case multipathing is enabled then only the multipath device should be used (PV create in case it's not) and added to the volume group return: success/fauilure removePV(VG, PV): params: VG - Volume Group UUID PV - Physical volume's UUID to be removed description: removes the physical volume return: success failure LV operations -------------- listLVs(VG): params: VG - Volume Group UUID description: trivial return: list of all LV UUIDs infoLV(VG, LV): params: VG - Volume Group UUID LV - Logical Volume UUID description: trivial return: returns LV information (at least size and path) createLV(VG, LvName, size): params: VG - Volume Group UUID LvName - name of the logical volume Size - size of logical volume description: creates a logical volume with name LvName and the requested size return: LV UUID extendLV(VG, LV, size): params: VG - Volume Group UUID LV - Logical Volume UUID description: extends LV with additional size return: success/failure removeLV(VG,LV): params: VG - Volume Group UUID LV - Logical Volume UUID description: return: snapshotLV(VG, LV, size): params: VG - Volume Group UUID LV - Logical Volume UUID size - Initial size of snapshot volume description: creeates a snapshot of LV return: UUID of snapshot

2 1

[libvirt] serial console runs out of buffer and console messages soft lock the CPU
by Bryan McLellan 26 Nov '08

26 Nov '08

I recently started configuring guests to use both a serial console and a graphics element. One of the nodes with this configuration kept locking up after running for some time. Trying to access the guest through virt-manager would leave virt-viewer hung at the connecting to screen. The guest would not respond to any network traffic including icmp. The user would destroy the domain and restart it to recover. Eventually the problem came to me and I found that immediately upon running 'virsh console domain' the guest would recover. The console contained: BUG: soft lockup - CPU#0 stuck for 94393s! [postgresql-8.3:4975] I discovered a bug in a puppet recipe caused postgres to reload regularly, printing a message to the console each time. Running puppet in a loop to continue producing these messages to the console caused another lockup that was recoverable by accessing the serial console in the same manner. I have since fixed that recipe, but I'm uncomfortable about the possibility of this happening again. Is there a way to configure libvirt to cache the serial console on the host so the buffer on the guest does not fill up when you aren't connected to the console, or should I disable the serial console? Bryan https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/301897

3 2

[libvirt] Packages in the path to getting a Windows binary of libvirt, built from Fedora
by Richard W.M. Jones 26 Nov '08

26 Nov '08

It seems like we should have the base MinGW (Windows cross-compiler) packages in Fedora 11 by the end of this week. This email is to document the additional packages we need to get approved, in order to get the cross-compiled libvirt and virt tools into (or buildable by) Fedora 11. If you want to help out, please start reviewing by following the Bugzilla links, and looking at the approved packaging guidelines at http://fedoraproject.org/wiki/Packaging/MinGW. ** For libvirt itself: mingw32-libgpg-error https://bugzilla.redhat.com/show_bug.cgi?id=467403 mingw32-libgcrypt https://bugzilla.redhat.com/show_bug.cgi?id=467410 mingw32-gnutls https://bugzilla.redhat.com/show_bug.cgi?id=467414 mingw32-gettext https://bugzilla.redhat.com/show_bug.cgi?id=467398 mingw32-libxml2 https://bugzilla.redhat.com/show_bug.cgi?id=467405 mingw32-portablexdr https://bugzilla.redhat.com/show_bug.cgi?id=467324 mingw32-readline https://bugzilla.redhat.com/show_bug.cgi?id=467399 mingw32-termcap https://bugzilla.redhat.com/show_bug.cgi?id=467329 OR a very brave person can try porting ncurses to Windows. mingw32-iconv https://bugzilla.redhat.com/show_bug.cgi?id=467325 mingw32-zlib https://bugzilla.redhat.com/show_bug.cgi?id=454416 mingw32-libvirt https://bugzilla.redhat.com/show_bug.cgi?id=467418 ** For the C based tools (gtk-vnc, virt-viewer, ovirt-viewer, vinagre): All of the above plus: mingw32-gtk2 https://bugzilla.redhat.com/show_bug.cgi?id=467420 mingw32-glib2 https://bugzilla.redhat.com/show_bug.cgi?id=467402 mingw32-cairo https://bugzilla.redhat.com/show_bug.cgi?id=467416 mingw32-jasper https://bugzilla.redhat.com/show_bug.cgi?id=467408 mingw32-libpng https://bugzilla.redhat.com/show_bug.cgi?id=467397 mingw32-libjpeg https://bugzilla.redhat.com/show_bug.cgi?id=467401 mingw32-libtiff (?) Optional dependency for GTK2, but not yet packaged. mingw32-pango https://bugzilla.redhat.com/show_bug.cgi?id=467419 mingw32-atk https://bugzilla.redhat.com/show_bug.cgi?id=467409 mingw32-pixman https://bugzilla.redhat.com/show_bug.cgi?id=467376 mingw32-freetype https://bugzilla.redhat.com/show_bug.cgi?id=467396 mingw32-fontconfig https://bugzilla.redhat.com/show_bug.cgi?id=467413 mingw32-libidn No Bugzilla Review Request yet, see the mercurial repository. http://hg.et.redhat.com/misc/fedora-mingw--devel mingw32-openssl https://bugzilla.redhat.com/show_bug.cgi?id=467395 mingw32-libssh2 No Bugzilla Review Request yet, see the mercurial repository. http://hg.et.redhat.com/misc/fedora-mingw--devel mingw32-gtk-vnc https://bugzilla.redhat.com/show_bug.cgi?id=467421 mingw32-curl No Bugzilla Review Request yet, see the mercurial repository. http://hg.et.redhat.com/misc/fedora-mingw--devel ** For the Python based tools (virt-install, virt-manager etc), we're hoping to go straight to Python 3 on the basis that it will be easier to contribute patches upstream, and it seems the build system for Python 3 will be a bit saner than for Python 2.x. You can help by making sure that all Python software is "Python 3 clean". If you have python 2.6, then just add the '-3' flag to the command line in order to warn about features which are deprecated and will be removed in Python 3. ** For the OCaml based tools (virt-df, virt-top): mingw32-ocaml mingw32-ocaml-calendar mingw32-ocaml-csv mingw32-ocaml-curses mingw32-ocaml-extlib mingw32-ocaml-findlib mingw32-ocaml-lablgl mingw32-ocaml-lablgtk mingw32-ocaml-libvirt mingw32-ocaml-xml-light (None of these are in Bugzilla yet, and for good reason because I may just do them as subpackages of the OCaml packages already in Fedora). ** I haven't had any particular requests for Ruby tools yet. OVirt itself is a standalone appliance and it doesn't need porting to Windows. ovirt-viewer is a C application and is being written concurrently on Linux and Windows anyway. I'm not sure if there are other standalone bits of ovirt which would make sense being ported to Windows. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v

1 0

[libvirt] Are there interfaces to change IP address of given domain before it runn
by Ian jonhson 26 Nov '08

26 Nov '08

Dear all, I has created a image file in local filesystem. And now, I wrote a program based on libvirt to run two instances of given image file. But I found they are using the same IP address which make them cut off the network. So, I wonder there are any solution to guarantee that both VM instances would be given different IP address after they are started. Thanks in advance, Ian

3 5

[libvirt] [PATCH] small fixes for the spec file
by Daniel Veillard 26 Nov '08

26 Nov '08

While sarting to build the RPMs for Fedora I noticed that there were a couple of cleanup patches missing about the handling of configuration files, and we forgot to add the dependancy on hal/hal-devel. We should also probably list hal and devkit support as modular options in the spec too. But this patch is just to harmonize with Fedora, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

3 2

[libvirt] [PATCH]: Give /dev/disk/by-{id,path} a chance to exist
by Chris Lalancette 26 Nov '08

26 Nov '08

All, When refreshing a storage pool (say, an iSCSI pool), one of the things it does is to generate the stable path for each of the LUNs via virStorageBackendStablePath. That, in turn, has the following code: /* The pool is pointing somewhere like /dev/disk/by-path * or /dev/disk/by-id, so we need to check all symlinks in * the target directory and figure out which one points * to this device node */ if ((dh = opendir(pool->def->target.path)) == NULL) { virStorageReportError(conn, VIR_ERR_INTERNAL_ERROR, _("cannot read dir %s: %s"), pool->def->target.path, strerror(errno)); return NULL; } For a normal machine, that code is totally legit; /dev/disk/by-{id,path} almost certainly exists because of your hard drive, etc. However, this may not be the case in the stateless ovirt environment, since /dev/disk/by-{id,path} is created on-demand by udev. It's basically a race between udev creating the directory and libvirt scanning the directory. The following patch just adds a retry to the code above so that if it doesn't exist when we first get there, we give it time to come into being. If it still hasn't shown up 5 seconds after we started, we give up and throw the error. Signed-off-by: Chris Lalancette <clalance(a)redhat.com>

3 2

[libvirt] Release of libvirt-0.5.0
by Daniel Veillard 26 Nov '08

26 Nov '08

This is a long expected release, with a lot of new features, as a result the small version number is increased. The release was actually done yesterday evening, and the tarballs and signed RPMs are at: ftp://libvirt.org/libvirt/ As stated there is a huge amount of new features and improvement in this release, as well as a lot of bug fixes, the list is quite long : New features: - CPU and scheduler support for LXC (Dan Smith) - SDL display configuration (Daniel Berrange) - domain lifecycle event support for QEmu and Xen with python bindings (Ben Guthro and Daniel Berrange) - KVM/QEmu migration support (Rich Jones and Chris Lalancette) - User Mode Linux driver (Daniel Berrange) - API for node device enumeration using HAL and DeviceKit with python bindings (David Lively) Portability: - RHEL build fixes - VPATH build (Guido Gunther) - many MinGW related cleanups and fixes (Richard Jones) - compilation without libvirtd (Richard Jones) - Add a Windows icon (Richard Jones) - sys/poll.h portability fixes (Daniel Berrange) - gnulib and mingw cleanups (Jim Meyering) Documentation: - virsh man page cleanups (Mark McLoughlin) - doc for NIC model selection (Richard Jones) - monitoring section - link to AMQP bindings - new APIs - UML driver docs (Daniel Berrange) Bug fixes: - Xen interfaces ordering (Jim Fehlig) - startup timeout with multiple pty (Cole Robinson) - segfault if QEmu without active virtual network (Cole Robinson) - qemu small leak (Eduardo Habkost) - index creation for more than 26 disks (Sanjay Rao and Chris Wright) - virRealloc handling of 0 (Daniel Berrange) - missing pointer initialization (Chris Lalancette) - bus device index bug (Guido Gunther) - avoid crash in some error patch (Chris Lalancette) - fix a problem in storage back-end (Chris Lalancette) - minimum domain memory size check for Xen (Shigeki Sakamoto) - switch off QEmu cache if device is shared (Charles Duffy) - logical volume definition before scan bug (Chris Lalancette) - a couple of memory leaks on QEmu vnc (Jim Meyering) - lvs parsing fixes (Cole Robinson) Improvements: - LXC resources control and internal cgroup API (Dan Smith) - virDomainCreateLinux renamed virDomainDefineXML - network driver modularization (Daniel Berrange) - change the way domain and net are reported in errors (Jim Meyering) - partition table scan on iSCSI (Chris Lalancette) - qemudDiskDeviceName to handle normal disks (Guido Gunther) - qemudDomainBlockStats improvement (Guido Gunther) - scsi/virtio hotplug support for KVM (Guido Gunther) - USB hot addition in QEmu (Guido Gunther) - logical pool and storage backend XML dump improvement (Chris Lalancette) - MAC addresses prefix per driver (Daniel Berrange) - OpenVZ getVersion support (Daniel Berrange) - hot removal of scsi/virtio disks for KVM (Guido Gunther) - test storage driver (Cole Robinson) - iSCSI and disk storage driver improvement on path handling (Chris Lalancette) - UUID and ID support for Xenner (Daniel Berrange) - better logging when when executing commands (Cole Robinson) - bridged network for OpenVZ (Daniel Berrange) - OpenVZ config file params (Evgeniy Sokolov) - allow to build drivers as libtool convenience libs (Daniel Berrange) - fully versioned linker script for exported ABI (Daniel Berrange) - Push URI probing down into drivers open (Daniel Berrange) - move all stateful drivers into the daemon binary (Daniel Berrange) - improve domain event with a detail field (Daniel Berrange) - domain events for QEMU driver (Daniel Berrange) - event unregister callback crash (David Lively) - plug a few leaks (Daniel Berrange) - internal APIs for handling node device XML config (David Lively) - tweaks to node device implementation (Daniel Berrange) - OpenVZ vCPUs values init (Evgeniy Sokolov) Cleanups: - C99 initializers (Guido Gunther) - test output (Cole Robinson) - debug macro centralization (Cole Robinson) - various error handling (Guido Gunther) - safewrite use cleanup (Jim Meyering) - centralize error reporting logic (Cole Robinson) - avoid printf warnings (Daniel Berrange) - use arrays instead of list for internal APIs (Daniel Berrange) - remove many format string warnings Jim Meyering) - avoid syntax check warnings (Chris Lalancette) - improve po-check and list generation (Jim Meyering) - .gitignore generation and handling (Jim Meyering) - use ARRAY_CARDINALITY (Jim Meyering) - gnulib updates and switch to use netdb.h (Jim Meyering) - drop usage of socket_errno (Jim Meyering) - remove socketcompat.h (Jim Meyering) - more tests (Jim Meyering) - drop virStringList (Daniel Berrange) - reformatting and isolation of the error APIs (Daniel Berrange) - cleanup internal.h and move internal APIs in specific headers (Daniel Berrange) - move domain events helpers into domain_events.c (Daniel Berrange) - cleanup the way optional modules are compiled (Daniel Berrange) - add new logging module - optional dlopen of drivers (Daniel Berrange) - various new tests (Jim Meyering) - cleanups when Xen is not configured in (Daniel Berrange) - add some missing functions comments (Jim Meyering) With the amount of new feature and code I would not be surprized if a new release was needed within the next couple of weeks, still people are invited to upgrade and submit reports in case of troubles. Thanks a lot to everybody who contributed to this release, it is really great to see new people providing significant patches, and the amount of feedback received on the list. Again, thanks to everybody, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] Fedora 10 Release and Virtualization News
by Dale Bewley 25 Nov '08

25 Nov '08

Sorry for the annoying cross post. The next Fedora Weekly News[1] will be published Monday, one day before the release of Fedora 10. I would like dedicate a special section of the Virtualization Beat[2] to touting the advances and new features in F10. As with the release notes[3], I am seeking your input. (A little late, I know.) I'm interested not only in the new virtualization features and breakthroughs found in the F10 release, but also any updates that might be right around the corner in f10-updates. Perhaps you have some special insight into the upstream progress of pv_ops, or maybe you know about a almost complete implementation of a libvirt API feature into virt-manager or... I'm sorry if this is a little scattershot. For sometime, I've considered trying to present questions in interview style to each of these lists, but I just haven't gotten that together. The publication deadline is Sunday night, but I'll be able to use anything in the next edition of FWN. Please contribute, even if you read this on Monday. [1] http://fedoraproject.org/wiki/FWN [2] http://fedoraproject.org/wiki/FWN/Beats/Virtualization [3] http://fedoraproject.org/wiki/Docs/Beats/Virtualization -- Dale Bewley - Unix Administrator - Shields Library - UC Davis GPG: 0xB098A0F3 0D5A 9AEB 43F4 F84C 7EFD 1753 064D 2583 B098 A0F3

3 2

[libvirt] doc nits
by Jim Meyering 25 Nov '08

25 Nov '08

I noticed the following go by yesterday, but won't have time to address them: Function comment for virConnectDomainEventRegister lacks description of arg freecb Function comment for virNodeDeviceGetName lacks description of the function Function comment for virNodeDeviceGetParent lacks description of the function Function comment for virNodeDeviceNumOfCaps lacks description of the function Function comment for virNodeDeviceNumOfCaps lacks description of the function Missing * in function comment for virDomainMigrateFinish Missing * in function comment for virDomainMigrateFinish2 Missing * in function comment for virDomainMigratePerform Missing * in function comment for virDomainMigratePrepare Missing * in function comment for virDomainMigratePrepare2 Missing * in function comment for virDrvSupportsFeature

2 2