- Devel - libvirt List Archives

[libvirt] libvirt / virt-manager issue with NFS share as storage plus a philosophy question - resend w/subject
by mike.hinz＠yr20.com 06 May '09

06 May '09

I had originally posted a plea for help on the virt-manager related list, but the same issue exists with virsh and this list seems to have higher traffic. I'd been chatting on the irc channel with various people about this, but wanted to put this on the mail list for the record and to also raise a philosophical question. First, we've confirmed that Fedora 11 preview (fully updated) has an issue with properly mounting NFS shares without the noacl option. Fedora 10 works fine with regard to mounting NFS shares. That issue causes problems when attempting to write files to an NFS share and more importantly, for this group, causes problems when attempting to create an NFS based storage pool and then subsequently creating volumes on said NFS share. That bug is 499178. This was all figured out with Openfiler support and with the support of the fine folks working on libvirt and virt-manager. There is a somewhat ugly workaround for this and I can describe it in case anyone is interested. Now comes the philosophy piece: It seems like that the way that libvirt and virt-manager want to handle storage is to be able to fully control the mounting process. That seems to me to be a very nice thing as you have a single way to manage storage along with your VMs. However, at least with respect to NFS, there are a number of parameters that people might need to give to the mount command for things like performance optimization and who knows what else. Note that this is a consideration completely aside from the bug issue above. It seems to me that either you have to just use the user created mount points, either manually or by fstab OR you have to allow all the possible options to be passed if you want to fully control the process. Right now, it's tricky to do, if you want to get paras passed for tuning or whatever and requires some tricky handwork to get it done. One way to accomplish this from the user input perspective would be to add an 'options' input field that could take multiple parameters on the step 2 of 2 page of the 'add storage pool' function. So, is my thinking all screwed up about this or is there merit to this concept? I tend to think, at least right now, that the logical thing is to either have the user create the mount points through the normal mechanisms that have in place roughly forever and then you just ask for what these are with respect to the NFS pools or you have to allow for user to pass the required parameters via your mechanism, although there are certainly many, many options when it comes to NFS. Thanks for all the help to date! I hope the above is helpful! Regards, Mike Hinz President YR20 1718 Fry Road, Suite 440 Houston, TX 77084 mike.hinz(a)yr20.com 832-225-1293 (o) 713-594-3095 (m) 832-550-2657 (f) Regards, Mike Hinz President YR20 1718 Fry Road, Suite 440 Houston, TX 77084 mike.hinz(a)yr20.com 832-225-1293 (o) 713-594-3095 (m) 832-550-2657 (f)

2 1

[libvirt] Cannot determine QEMU argv syntax with KVM 85
by Frederik Himpe 06 May '09

06 May '09

With KVM 85, it is impossible to start domains with libvirtd anymore (I tried both libvirtd 0.6.1 and 0.6.3): # virsh start Cooker error: Failed to start domain Cooker error: internal error Cannot determine QEMU argv syntax /usr/bin/qemu-kvm When I downgrade to KMV 84, everything is working again. KVM 85's output of qemu --help: # LC_ALL=C /usr/bin/qemu-kvm --help QEMU PC emulator version 0.10.0 (kvm-85), Copyright (c) 2003-2008 Fabrice Bellard usage: qemu [options] [disk_image] 'disk_image' is a raw hard image image for IDE hard disk 0 Standard options: -h or -help display this help and exit -M machine select emulated machine (-M ? for list) -cpu cpu select CPU (-cpu ? for list) -smp n set the number of CPUs to 'n' [default=1] -fda/-fdb file use 'file' as floppy disk 0/1 image -hda/-hdb file use 'file' as IDE hard disk 0/1 image -hdc/-hdd file use 'file' as IDE hard disk 2/3 image -cdrom file use 'file' as IDE cdrom image (cdrom is ide1 master) -drive [file=file][,if=type][,bus=n][,unit=m][,media=d][,index=i] [,cyls=c,heads=h,secs=s[,trans=t]][,snapshot=on|off] [,cache=writethrough|writeback|none][,format=f][,serial=s] [,boot=on|off] use 'file' as a drive image -mtdblock file use 'file' as on-board Flash memory image -sd file use 'file' as SecureDigital card image -pflash file use 'file' as a parallel flash image -boot [a|c|d|n] boot on floppy (a), hard disk (c), CD-ROM (d), or network (n) -snapshot write to temporary files instead of disk image files -m megs set virtual RAM size to megs MB [default=128] -k language use keyboard layout (for example 'fr' for French) -audio-help print list of audio drivers and their options -soundhw c1,... enable audio support and only specified sound cards (comma separated list) use -soundhw ? to get the list of supported cards use -soundhw all to enable all of them -usb enable the USB driver (will be the default soon) -usbdevice name add the host or guest USB device 'name' -name string set the name of the guest -uuid %08x-%04x-%04x-%04x-%012x specify machine UUID Display options: -nographic disable graphical output and redirect serial I/Os to console -curses use a curses/ncurses interface instead of SDL -no-frame open SDL window without a frame and window decorations -alt-grab use Ctrl-Alt-Shift to grab mouse (instead of Ctrl-Alt) -no-quit disable SDL window close capability -sdl enable SDL -portrait rotate graphical output 90 deg left (only PXA LCD) -vga [std|cirrus|vmware|none] select video card type -full-screen start in full screen -vnc display start a VNC server on display i386 target only: -win2k-hack use it when installing Windows 2000 to avoid a disk full bug -rtc-td-hack use it to fix time drift in Windows ACPI HAL -no-fd-bootchk disable boot signature checking for floppy disks -no-acpi disable ACPI -no-hpet disable HPET -acpitable [sig=str][,rev=n][,oem_id=str][,oem_table_id=str][,oem_rev=n][,asl_compiler_id=str][,asl_compiler_rev=n][,data=file1[:file2]...] ACPI table description Network options: -net nic[,vlan=n][,macaddr=addr][,model=type][,name=str] create a new Network Interface Card and connect it to VLAN 'n' -net user[,vlan=n][,name=str][,hostname=host] connect the user mode network stack to VLAN 'n' and send hostname 'host' to DHCP clients -net tap[,vlan=n][,name=str][,fd=h][,ifname=name][,script=file][,downscript=dfile] connect the host TAP network interface to VLAN 'n' and use the network scripts 'file' (default=/etc/qemu-ifup) and 'dfile' (default=/etc/qemu-ifdown); use '[down]script=no' to disable script execution; use 'fd=h' to connect to an already opened TAP interface -net socket[,vlan=n][,name=str][,fd=h][,listen=[host]:port][,connect=host:port] connect the vlan 'n' to another VLAN using a socket connection -net socket[,vlan=n][,name=str][,fd=h][,mcast=maddr:port] connect the vlan 'n' to multicast maddr and port -net vde[,vlan=n][,name=str][,sock=socketpath][,port=n][,group=groupname][,mode=octalmode] connect the vlan 'n' to port 'n' of a vde switch running on host and listening for incoming connections on 'socketpath'. Use group 'groupname' and mode 'octalmode' to change default ownership and permissions for communication port. -net none use it alone to have zero network devices; if no -net option is provided, the default is '-net nic -net user' -tftp dir allow tftp access to files in dir [-net user] -bootp file advertise file in BOOTP replies -smb dir allow SMB access to files in 'dir' [-net user] -redir [tcp|udp]:host-port:[guest-host]:guest-port redirect TCP or UDP connections from host to guest [-net user] -bt hci,null dumb bluetooth HCI - doesn't respond to commands -bt hci,host[:id] use host's HCI with the given name -bt hci[,vlan=n] emulate a standard HCI in virtual scatternet 'n' -bt vhci[,vlan=n] add host computer to virtual scatternet 'n' using VHCI -bt device:dev[,vlan=n] emulate a bluetooth device 'dev' in scatternet 'n' Linux boot specific: -kernel bzImage use 'bzImage' as kernel image -append cmdline use 'cmdline' as kernel command line -initrd file use 'file' as initial ram disk Debug/Expert options: -serial dev redirect the serial port to char device 'dev' -parallel dev redirect the parallel port to char device 'dev' -monitor dev redirect the monitor to char device 'dev' -pidfile file write PID to 'file' -singlestep always run in singlestep mode -S freeze CPU at startup (use 'c' to start execution) -gdb dev wait for gdb connection on 'dev' -s shorthand for -gdb tcp::1234 -d item1,... output log to /tmp/qemu.log (use -d ? for a list of log items) -hdachs c,h,s[,t] force hard disk 0 physical geometry and the optional BIOS translation (t=none or lba) (usually qemu can guess them) -L path set the directory for the BIOS, VGA BIOS and keymaps -bios file set the filename for the BIOS -no-reboot exit instead of rebooting -no-shutdown stop before shutdown -loadvm [tag|id] start right away with a saved state (loadvm in monitor) -daemonize daemonize QEMU after initializing -option-rom rom load a file, rom, into the option ROM space -clock force the use of the given methods for timer alarm. To see what timers are available use -clock ? -localtime set the real time clock to local time [default=utc] -startdate select initial date of the clock -icount [N|auto] enable virtual instruction counter with 2^N clock ticks per instruction -echr chr set terminal escape character instead of ctrl-a -virtioconsole c set virtio console -show-cursor show cursor -tb-size n set TB size -incoming p prepare for incoming migration, listen on port p -chroot dir Chroot to dir just before starting the VM. -runas user Change to user id user just before starting the VM. -no-kvm disable KVM hardware virtualization -no-kvm-irqchip disable KVM kernel mode PIC/IOAPIC/LAPIC -no-kvm-pit disable KVM kernel mode PIT -no-kvm-pit-reinjection disable KVM kernel mode PIT interrupt reinjection -pcidevice host=bus:dev.func[,dma=none][,name=string] expose a PCI device to the guest OS. dma=none: don't perform any dma translations (default is to use an iommu) 'string' is used in log output. -enable-nesting enable support for running a VM inside the VM (AMD only) -cpu-vendor STRING override the cpuid vendor string -nvram FILE provide ia64 nvram contents -tdf enable guest time drift compensation -kvm-shadow-memory MEGABYTES allocate MEGABYTES for kvm mmu shadowing -mempath FILE provide backing storage for guest RAM -mem-prealloc preallocate guest memory (use with -mempath) During emulation, the following keys are useful: ctrl-alt-f toggle full screen ctrl-alt-n switch to virtual console 'n' ctrl-alt toggle mouse and keyboard grab When using -nographic, press 'ctrl-a h' to get some help. The working KVM 84 gives this: # LC_ALL=C /usr/bin/qemu-kvm --help QEMU PC emulator version 0.9.1 (kvm-84), Copyright (c) 2003-2008 Fabrice Bellard usage: qemu [options] [disk_image] 'disk_image' is a raw hard image image for IDE hard disk 0 Standard options: -h or -help display this help and exit -M machine select emulated machine (-M ? for list) -cpu cpu select CPU (-cpu ? for list) -smp n set the number of CPUs to 'n' [default=1] -fda/-fdb file use 'file' as floppy disk 0/1 image -hda/-hdb file use 'file' as IDE hard disk 0/1 image -hdc/-hdd file use 'file' as IDE hard disk 2/3 image -cdrom file use 'file' as IDE cdrom image (cdrom is ide1 master) -drive [file=file][,if=type][,bus=n][,unit=m][,media=d][,index=i] [,cyls=c,heads=h,secs=s[,trans=t]][,snapshot=on|off] [,cache=writethrough|writeback|none][,format=f][,serial=s] [,boot=on|off] use 'file' as a drive image -mtdblock file use 'file' as on-board Flash memory image -sd file use 'file' as SecureDigital card image -pflash file use 'file' as a parallel flash image -boot [a|c|d|n] boot on floppy (a), hard disk (c), CD-ROM (d), or network (n) -snapshot write to temporary files instead of disk image files -m megs set virtual RAM size to megs MB [default=128] -k language use keyboard layout (for example "fr" for French) -audio-help print list of audio drivers and their options -soundhw c1,... enable audio support and only specified sound cards (comma separated list) use -soundhw ? to get the list of supported cards use -soundhw all to enable all of them -usb enable the USB driver (will be the default soon) -usbdevice name add the host or guest USB device 'name' -name string set the name of the guest -uuid %08x-%04x-%04x-%04x-%012x specify machine UUID Display options: -nographic disable graphical output and redirect serial I/Os to console -curses use a curses/ncurses interface instead of SDL -no-frame open SDL window without a frame and window decorations -alt-grab use Ctrl-Alt-Shift to grab mouse (instead of Ctrl-Alt) -no-quit disable SDL window close capability -sdl enable SDL -portrait rotate graphical output 90 deg left (only PXA LCD) -vga [std|cirrus|vmware|none] select video card type -full-screen start in full screen -vnc display start a VNC server on display -name string set the name of the guest -uuid %08x-%04x-%04x-%04x-%012x specify machine UUID Network options: -net nic[,vlan=n][,macaddr=addr][,model=type][,name=str] create a new Network Interface Card and connect it to VLAN 'n' -net user[,vlan=n][,name=str][,hostname=host] connect the user mode network stack to VLAN 'n' and send hostname 'host' to DHCP clients -net tap[,vlan=n][,name=str][,fd=h][,ifname=name][,script=file][,downscript=dfile] connect the host TAP network interface to VLAN 'n' and use the network scripts 'file' (default=/etc/qemu-ifup) and 'dfile' (default=/etc/qemu-ifdown); use '[down]script=no' to disable script execution; use 'fd=h' to connect to an already opened TAP interface -net socket[,vlan=n][,name=str][,fd=h][,listen=[host]:port][,connect=host:port] connect the vlan 'n' to another VLAN using a socket connection -net socket[,vlan=n][,name=str][,fd=h][,mcast=maddr:port] connect the vlan 'n' to multicast maddr and port -net vde[,vlan=n][,name=str][,sock=socketpath][,port=n][,group=groupname][,mode=octalmode] connect the vlan 'n' to port 'n' of a vde switch running on host and listening for incoming connections on 'socketpath'. Use group 'groupname' and mode 'octalmode' to change default ownership and permissions for communication port. -net none use it alone to have zero network devices; if no -net option is provided, the default is '-net nic -net user' -tftp dir allow tftp access to files in dir [-net user] -bootp file advertise file in BOOTP replies -smb dir allow SMB access to files in 'dir' [-net user] -redir [tcp|udp]:host-port:[guest-host]:guest-port redirect TCP or UDP connections from host to guest [-net user] -bt hci,null dumb bluetooth HCI - doesn't respond to commands -bt hci,host[:id] use host's HCI with the given name -bt hci[,vlan=n] emulate a standard HCI in virtual scatternet 'n' -bt vhci[,vlan=n] add host computer to virtual scatternet 'n' using VHCI -bt device:dev[,vlan=n] emulate a bluetooth device 'dev' in scatternet 'n' i386 target only: -win2k-hack use it when installing Windows 2000 to avoid a disk full bug -rtc-td-hack use it to fix time drift in Windows ACPI HAL -no-fd-bootchk disable boot signature checking for floppy disks -no-acpi disable ACPI -no-hpet disable HPET Linux boot specific: -kernel bzImage use 'bzImage' as kernel image -append cmdline use 'cmdline' as kernel command line -initrd file use 'file' as initial ram disk Debug/Expert options: -serial dev redirect the serial port to char device 'dev' -parallel dev redirect the parallel port to char device 'dev' -monitor dev redirect the monitor to char device 'dev' -pidfile file write PID to 'file' -S freeze CPU at startup (use 'c' to start execution) -s wait gdb connection to port -p port set gdb connection port [default=1234] -d item1,... output log to /tmp/qemu.log (use -d ? for a list of log items) -hdachs c,h,s[,t] force hard disk 0 physical geometry and the optional BIOS translation (t=none or lba) (usually qemu can guess them) -L path set the directory for the BIOS, VGA BIOS and keymaps -bios file set the filename for the BIOS -no-kvm disable KVM hardware virtualization -no-kvm-irqchip disable KVM kernel mode PIC/IOAPIC/LAPIC -no-kvm-pit disable KVM kernel mode PIT -no-kvm-pit-reinjection disable KVM kernel mode PIT interrupt reinjection -enable-nesting enable support for running a VM inside the VM (AMD only) -pcidevice host=bus:dev.func[,dma=none][,name=string] expose a PCI device to the guest OS. dma=none: don't perform any dma translations (default is to use an iommu) 'string' is used in log output. -no-reboot exit instead of rebooting -no-shutdown stop before shutdown -loadvm [tag|id] start right away with a saved state (loadvm in monitor) -daemonize daemonize QEMU after initializing -tdf inject timer interrupts that got lost -kvm-shadow-memory megs set the amount of shadow pages to be allocated -mem-path set the path to hugetlbfs/tmpfs mounted directory, also enables allocation of guest memory with huge pages -mem-prealloc toggles preallocation of -mem-path backed physical memory at startup. Default is enabled. -option-rom rom load a file, rom, into the option ROM space -clock force the use of the given methods for timer alarm. To see what timers are available use -clock ? -localtime set the real time clock to local time [default=utc] -startdate select initial date of the clock -icount [N|auto] enable virtual instruction counter with 2^N clock ticks per instruction -echr chr set terminal escape character instead of ctrl-a -virtioconsole c set virtio console -show-cursor show cursor -tb-size n set TB size -incoming p prepare for incoming migration, listen on port p During emulation, the following keys are useful: ctrl-alt-f toggle full screen ctrl-alt-n switch to virtual console 'n' ctrl-alt toggle mouse and keyboard grab When using -nographic, press 'ctrl-a h' to get some help. Packages installed: libvirt-debug-0.6.3-1mdv2009.1 python-virtinst-0.400.3-1mdv2009.1 libvirt-utils-0.6.3-1mdv2009.1 virt-manager-0.7.0-2mdv2009.1 virt-viewer-0.0.3-2mdv2009.0 python-libvirt-0.6.3-1mdv2009.1 lib64virt0-0.6.3-1mdv2009.1 What could be wrong here? -- Frederik Himpe

2 1

[libvirt] [PATCH 0/1] Added Networking API to change/create/etc. hostonly/internal network in VirtualBox
by Pritesh Kothari 06 May '09

06 May '09

Hi All: [PATCH 0/1]: Contains sample xml file showing features supported so far. [PATCH 1/1]: Contains the patch for adding Networking API to change/create/etc. hostonly/internal network in VirtualBox Regards, Pritesh

2 2

[libvirt] [PATCH 1/2] Support for 'hostonly' and 'internal' network in VirtualBox
by Pritesh Kothari 06 May '09

06 May '09

Hi All, I have added the support for hostonly and internal network as suggested on irc and list and am attaching the patch for same. PATCH 1/2: contains changes in the xml parsing/formatting on libvirt side namely adding a mode attribute to <source> tag in domain/interface xml PATCH 2/2: contains changes in the vbox driver itself. Regards, Pritesh

2 1

[libvirt] [PATCH 1/1] Added Networking API to change/create/etc. hostonly/internal network in VirtualBox
by Pritesh Kothari 06 May '09

06 May '09

Hi All: [PATCH 0/1]: Contains sample xml file showing features supported so far. [PATCH 1/1]: Contains the patch for adding Networking API to change/create/etc. hostonly/internal network in VirtualBox Regards, Pritesh

2 1

[libvirt] USB pass-through only works after many disconnects at the beginning
by Felix Schwarz 06 May '09

06 May '09

Hi, I want to pass through a USB device to a KVM guest (Windows 2000). My host OS is a standard Fedora 10, 64 bit. However, the device is only passed to the guest when I use qemu monitor directly and only after several tries... The device has no Linux drivers ('AVM GmbH ISDN-Controller FRITZ!Card v2.0') so I think I don't have to tell the kernel not to use it. I have KVM 74 and tried initially with libvirt 0.5.1 so from what I read this should be ok. At first I added this to my domain xml via virsh: <hostdev mode='subsystem' type='usb'> <source> <vendor id='0x....'/> <product id='0x....'/> </source> </hostdev> However, the device did not turn up in the guest. Therefore I updated libvirt/-python 0.6.1 and python-virtinst from updates-testing and recompiled virt-manager 0.7 from F11 because I read that virt-manager 0.7 had some support for USB pass-through. Now I had some new UI, but it turned out that using that did not produce better results... After that I called qemu-kvm directly with '-usb -usbdevice host:...:...'. qemu produced this output on my terminal: husb: open device 2.9 husb: config #1 need -1 husb: 1 interfaces claimed for configuration -1 husb: grabbed usb device 2.9 husb: config #1 need 1 USBDEVFS_DISCONNECT: No such device husb: device 2.9 disconnected When I used qemu monitor to re-attach the device, something liek that happened (re-attached multiple times): husb: open device 2.11 husb: config #1 need -1 husb: 1 interfaces claimed for configuration -1 husb: grabbed usb device 2.11 husb: config #1 need 1 husb: 1 interfaces claimed for configuration 1 husb: config #1 need 1 USBDEVFS_DISCONNECT: No such device husb: config #1 need 1 USBDEVFS_DISCONNECT: No such device husb: config #1 need 1 USBDEVFS_DISCONNECT: No such device husb: device 2.11 disconnected ... Eventually (after several tries), the device was attached and no more disconnects happened. After that I could use the device as expected. However plain qemu is not what I would like to have. I read about 'virsh attach-device' so I tried to use my usb hostdev snippet but to no avail (even after 10s of tries). So how can I use USB pass through? Could this be Windows-related? Judging from all the other threads (like [1]) it should be really easy to use. fs [1] https://www.redhat.com/archives/libvir-list/2009-February/msg00387.html

3 4

[libvirt] (no subject)
by mike.hinz＠yr20.com 05 May '09

05 May '09

I had originally posted a plea for help on the virt-manager related list, but the same issue exists with virsh and this list seems to have higher traffic. I'd been chatting on the irc channel with various people about this, but wanted to put this on the mail list for the record and to also raise a philosophical question. First, we've confirmed that Fedora 11 preview (fully updated) has an issue with properly mounting NFS shares without the noacl option. Fedora 10 works fine with regard to mounting NFS shares. That issue causes problems when attempting to write files to an NFS share and more importantly, for this group, causes problems when attempting to create an NFS based storage pool and then subsequently creating volumes on said NFS share. That bug is 499178. This was all figured out with Openfiler support and with the support of the fine folks working on libvirt and virt-manager. There is a somewhat ugly workaround for this and I can describe it in case anyone is interested. Now comes the philosophy piece: It seems like that the way that libvirt and virt-manager want to handle storage is to be able to fully control the mounting process. That seems to me to be a very nice thing as you have a single way to manage storage along with your VMs. However, at least with respect to NFS, there are a number of parameters that people might need to give to the mount command for things like performance optimization and who knows what else. Note that this is a consideration completely aside from the bug issue above. It seems to me that either you have to just use the user created mount points, either manually or by fstab OR you have to allow all the possible options to be passed if you want to fully control the process. Right now, it's tricky to do, if you want to get paras passed for tuning or whatever and requires some tricky handwork to get it done. One way to accomplish this from the user input perspective would be to add an 'options' input field that could take multiple parameters on the step 2 of 2 page of the 'add storage pool' function. So, is my thinking all screwed up about this or is there merit to this concept? I tend to think, at least right now, that the logical thing is to either have the user create the mount points through the normal mechanisms that have in place roughly forever and then you just ask for what these are with respect to the NFS pools or you have to allow for user to pass the required parameters via your mechanism, although there are certainly many, many options when it comes to NFS. Thanks for all the help to date! I hope the above is helpful! Regards, Mike Hinz President YR20 1718 Fry Road, Suite 440 Houston, TX 77084 mike.hinz(a)yr20.com 832-225-1293 (o) 713-594-3095 (m) 832-550-2657 (f)

1 0

[libvirt] pool default not starting on f10
by Jason Guiditta 05 May '09

05 May '09

Hello, hopefully this is something simple I just don't understand how to debug, but right now, it is keeping me from creating any new VMs. As stated in the subject, I am running F10, on x86_64 arch. Libvirt version is 0.6.1-5.fc10. Using virt-manager to create a new vm, when I get to the step to create a disk image, I get the error: 'Storage parameter error. internal error storage pool is not active'. Running virsh pool-start default gets me: error: Failed to start pool default error: out of memory Note there is no reason my machine would be out of memory, is has 6GB and nothing else running (and tried this right after booting) virsh pool-list --all shows default is inactive and 'yes' for autostart I would be happy to file a bug if needed, but thought I would throw this out to the list first to see if I was just unaware of some simple fix. Let me know if there are other details I can provide to make this easier to solve. Thanks, -j

2 6

[libvirt] [PATCH v2] Don't throw away QEMU startup errors when migrating.
by Cole Robinson 05 May '09

05 May '09

The attached patch removes the error message squashing that can take place in the qemu driver when launching a new VM via restore or migrate. Thanks, Cole

2 2

[libvirt] [PATCH] Test driver VolCreate cleanups
by Cole Robinson 05 May '09

05 May '09

The attached patch fixes some small issues with VolCreateXML implementation in the test driver. Thanks, Cole

2 2

[libvirt] [PATCH] Remove some old debugging code
by Cole Robinson 05 May '09

05 May '09

The attached patch removes some debugging code accidentally applied with my async vol creation patches. Thanks, Cole

2 2

[libvirt] [PATCH] Use correct error code in public VolCreateXML
by Cole Robinson 05 May '09

05 May '09

The attached patch fixes a use of an incorrect error code in libvirt.c VolCreateXML. Thanks, Cole

2 2

[libvirt] [PATCH 0/1] NPIV node device backend
by David Allan 05 May '09

05 May '09

Here is an initial implementation of the NPIV support backend using the node device API. It only implements create. Destroy should be fairly straightforward, but I want to get the patch out to the list for comment while I continue to work. The code currently requires the device name and host number to be specified in the XML, but it does not use those values. I will clean that up. The user will not be able to specify either of those values, as they are created by the system when it discovers the newly created device. <device> <name>foo</name> <parent>pci_10df_fe00_scsi_host_0</parent> <capability type='scsi_host'> <host>99999</host> <capability type='fc_host'> <wwnn>c0001b0000000018</wwnn> <wwpn>c0001b1000000018</wwpn> </capability> </capability> </device>

2 2

[libvirt] Patch: Fix build with -Werror=format-security cflag
by Frederik Himpe 05 May '09

05 May '09

This patch is needed to build libvirt with -Werror=format-security gcc cflag, which is used by default on Mandriva diff -ur libvirt-0.6.3.orig/src/virsh.c libvirt-0.6.3/src/virsh.c --- libvirt-0.6.3.orig/src/virsh.c 2009-04-15 21:43:26.000000000 +0200 +++ libvirt-0.6.3/src/virsh.c 2009-05-02 13:56:11.000000000 +0200 @@ -4463,7 +4463,7 @@ } /* Print this device */ - vshPrint(ctl, indentBuf); + vshPrint(ctl, "%s", indentBuf); vshPrint(ctl, "%s\n", devices[devid]); @@ -4487,7 +4487,7 @@ /* If there is a child device, then print another blank line */ if (nextlastdev != -1) { - vshPrint(ctl, indentBuf); + vshPrint(ctl, "%s", indentBuf); vshPrint(ctl, " |\n"); } @@ -4511,7 +4511,7 @@ /* If there was no child device, and we're the last in * a list of devices, then print another blank line */ if (nextlastdev == -1 && devid == lastdev) { - vshPrint(ctl, indentBuf); + vshPrint(ctl, "%s", indentBuf); vshPrint(ctl, "\n"); } }

2 1

[libvirt] [PATCH 0/7] Improve QEMU process startup error reporting
by Cole Robinson 04 May '09

04 May '09

Error reporting for failed QEMU processes isn't too great at the moment. A couple cases I have hit: - Trying to start a VM with a cdrom pointing to a nonexistent file. The svirt hook function choked on this and indicated as much in the domain log, but I still had to wait for the pidfile timeout (10 seconds), and the only error reported was 'Domain did not show up'. - QEMU dies quickly at startup. Happened with the pulse audio issue, or if we build cli args incorrectly. The reporting here varies: if QEMU dies before writing out the pidfile, the above case applies. If the pidfile is written, we timeout in ReadLogOutput, and it's hit or miss whether we even report the logfile output to the user. The following patches improve the above cases by ensuring we never have to wait for a timeout, and that the logfile output is always reported in the error message. Cole Robinson (7): Add documentation for __virExec and virExec virExec: Delay daemonizing as long as possible. Add helper function virExecDaemonize Report qemu log data if we fail to daemonize the process. Add pidfile argument to __virExec Check that QEMU is still alive while reading startup output. Don't throw away QEMU startup errors when migrating. src/libvirt_private.syms | 2 +- src/proxy_internal.c | 16 +-- src/qemu_conf.c | 7 - src/qemu_driver.c | 105 +++++++---- src/remote_internal.c | 15 +-- src/uml_driver.c | 11 +- src/util.c | 186 +++++++++++++++----- src/util.h | 15 ++- .../qemuxml2argvdata/qemuxml2argv-boot-cdrom.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-boot-floppy.args | 2 +- .../qemuxml2argv-boot-network.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-bootloader.args | 2 +- .../qemuxml2argv-clock-localtime.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-clock-utc.args | 2 +- .../qemuxml2argv-console-compat.args | 2 +- .../qemuxml2argv-disk-cdrom-empty.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-disk-cdrom.args | 2 +- .../qemuxml2argv-disk-drive-boot-cdrom.args | 2 +- .../qemuxml2argv-disk-drive-boot-disk.args | 2 +- .../qemuxml2argv-disk-drive-cache-v1-none.args | 2 +- .../qemuxml2argv-disk-drive-cache-v1-wb.args | 2 +- .../qemuxml2argv-disk-drive-cache-v1-wt.args | 2 +- .../qemuxml2argv-disk-drive-cache-v2-none.args | 2 +- .../qemuxml2argv-disk-drive-cache-v2-wb.args | 2 +- .../qemuxml2argv-disk-drive-cache-v2-wt.args | 2 +- .../qemuxml2argv-disk-drive-fmt-qcow.args | 2 +- .../qemuxml2argv-disk-drive-shared.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-disk-floppy.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-many.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-usb.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-disk-virtio.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-disk-xenvbd.args | 2 +- .../qemuxml2argv-graphics-sdl-fullscreen.args | 2 +- .../qemuxml2argv-graphics-sdl.args | 2 +- .../qemuxml2argv-graphics-vnc-sasl.args | 2 +- .../qemuxml2argv-graphics-vnc-tls.args | 2 +- .../qemuxml2argv-graphics-vnc.args | 2 +- .../qemuxml2argv-hostdev-pci-address.args | 2 +- .../qemuxml2argv-hostdev-usb-address.args | 2 +- .../qemuxml2argv-hostdev-usb-product.args | 2 +- .../qemuxml2argv-input-usbmouse.args | 2 +- .../qemuxml2argv-input-usbtablet.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-input-xen.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-migrate.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-minimal.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-misc-acpi.args | 2 +- .../qemuxml2argv-misc-no-reboot.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-misc-uuid.args | 2 +- .../qemuxml2argv-net-eth-ifname.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-net-eth.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-net-user.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-net-virtio.args | 2 +- .../qemuxml2argv-parallel-tcp.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-restore-v1.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-restore-v2.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-serial-dev.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-serial-file.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-serial-many.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-serial-pty.args | 2 +- .../qemuxml2argv-serial-tcp-telnet.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-serial-tcp.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-serial-udp.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-serial-unix.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-serial-vc.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-sound.args | 2 +- 65 files changed, 288 insertions(+), 183 deletions(-)

2 18

[libvirt] Virtio Disk Drivers and Windows
by Aaron Clausen 04 May '09

04 May '09

I've imported a Windows Server 2003 as a guest using the IDE drivers. When I try to use the virtio drivers instead, Windows just blue screens. Am I stuck with the IDE drivers under Windows? -- Aaron Clausen mightymartianca(a)gmail.com

1 1

[libvirt] [PATCH] Fix a comment typo in storage_backend_fs.c
by Cole Robinson 04 May '09

04 May '09

This comment hid from my attempt to 'grep FILE_BOCHS', which is the actual name of the constant. Thanks, Cole

2 2

[libvirt] VM image running on 2 Intels
by Zvi Dubitzky 30 Apr '09

30 Apr '09

I have 2 types of hosts as below ( each is 64 bits processor . number of processor is not equal . First has 1G memory . the second 3 G memor): IBM blade HS21 with Intel Xeon L5320 (1,86Ghz) . 8 processors (blade) IBM desktop with Intel(R) Core(TM)2 Duo CPU E6550 @ 2.33GHz I have generated an Ubuntu 8.10 client image on the first . It runs smooth on the first via virsh . It runs ok on the second but not well via virsh ( define + start <xml> ). just by a direct : sudo qemu-system-x86_64 call . If I generate a similar image on the second host (using same .iso Ubuntu CD image) then it runs on the first and second host smoothly via virsh (define + start <xml>) Is there an explanation for that ? Also : please comment if the below qemu-system-x86_64 explicit image start of a VM and the same done by a virsh command by : define + start <.xml> are equivalent and if not what change should I make to the .xml file (below) 1. sudo qemu-system-x86_64 -hda <path/to/image/file> -m 512 -net nic, model=e1000 -nic tap 2. The xml file thanks Zvi Dubitzky Virtualization and System Architecture Email:dubi@il.ibm.com IBM Haifa Research Laboratory Phone: +972-4-8296182 Haifa, 31905, ISRAEL

2 1

[libvirt] [PATCH 1/2] support for multiple graphics devices
by Pritesh Kothari 30 Apr '09

30 Apr '09

Hi All, I have added support for multiple graphics devices, the patches are as below. I have checked them against current cvs head and works fine PATCH 1/2: contains changes in libvirt for multiple graphics devices PATCH 2/2: contains corresponding changes in qemu driver. Regards, Pritesh

2 1

[libvirt] libvirt will create two guest with the same name, but with different UUIDs
by Kaitlin Rupert 30 Apr '09

30 Apr '09

Hi, libvirt allows you to create two guests with same name, but with different UUIDs. This causes some problems in the reporting though. virsh will report that a guest is running (when it isn't). This also causes some confusion for the dominfo call - virsh will only return info for one of the guests. I've seen similar issues when using the virDomainLookupByName() API. I suspect all the issues are the same bug, but I haven't had a chance to track down where. Thanks! # virsh version Compiled against library: libvir 0.6.3 Using library: libvir 0.6.3 Using API: QEMU 0.6.3 Running hypervisor: QEMU 0.9.1 # virsh list --all Id Name State ---------------------------------- 109 demo2 running - domU1 shut off - test_domain shut off # virsh dumpxml demo2 <domain type='kvm' id='109'> <name>demo2</name> <uuid>4dea24b3-1d52-d8f3-2516-782e98a23fa0</uuid> <memory>131072</memory> <currentMemory>131072</currentMemory> <vcpu>1</vcpu> <os> <type arch='i686' machine='pc'>hvm</type> <boot dev='hd'/> </os> <clock offset='utc'/> <on_poweroff>restart</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>restart</on_crash> <devices> <emulator>/usr/bin/qemu-kvm</emulator> <disk type='file' device='disk'> <source file='/tmp/default-kvm-dimage'/> <target dev='hda' bus='ide'/> </disk> <interface type='user'> <mac address='24:42:53:21:52:45'/> </interface> <input type='mouse' bus='ps2'/> <graphics type='vnc' port='5900' autoport='yes'/> </devices> </domain> # cat demo2 <domain type='kvm' id='55'> <name>demo2</name> <uuid>4dea24b3-1d52-d8f3-2516-782e98a23fa3</uuid> <memory>131072</memory> <currentMemory>131072</currentMemory> <vcpu>1</vcpu> <os> <type arch='i686' machine='pc'>hvm</type> <boot dev='hd'/> </os> <clock offset='utc'/> <on_poweroff>restart</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>restart</on_crash> <devices> <emulator>/usr/bin/qemu-kvm</emulator> <disk type='file' device='disk'> <source file='/tmp/default-kvm-dimage'/> <target dev='hda' bus='ide'/> </disk> <interface type='user'> <mac address='24:42:53:21:52:45'/> </interface> <input type='mouse' bus='ps2'/> <graphics type='vnc' port='5902' autoport='yes'/> </devices> </domain> # virsh define demo2 Domain demo2 defined from demo2 # virsh list --all Id Name State ---------------------------------- 109 demo2 running - demo2 running - domU1 shut off - test_domain shut off # ps -ef | grep qemu root 11464 1 96 09:04 ? 00:02:12 /usr/bin/qemu-kvm -S -M pc -cpu qemu32 -m 128 -smp 1 -name demo2 -uuid 4dea24b3-1d52-d8f3-2516-782e98a23fa0 -monitor pty -pidfile /var/run/libvirt/qemu//demo2.pid -no-acpi -boot c -drive file=/tmp/default-kvm-dimage,if=ide,index=0,boot=on -net nic,macaddr=24:42:53:21:52:45,vlan=0 -net user,vlan=0 -serial none -parallel none -usb -vnc 127.0.0.1:0 root 11483 27407 0 09:06 pts/1 00:00:00 grep qemu # -- Kaitlin Rupert IBM Linux Technology Center kaitlin(a)linux.vnet.ibm.com

2 1

[libvirt] PATCH: Add a new error code for invalid operations
by Daniel P. Berrange 29 Apr '09

29 Apr '09

A number of operations are only valid when the corresponding object is in a particular state. eg, you can only suspend a domain, if it is currently running. We don't have a very consistent way of reporting this problem across drivers, so this patch introduces a new error code for this situation called VIR_ERR_INVALID_OPERATION. This code is intended to be used if the operation is supported, but not applicable for the object at this time. It updates the Xen and QEMU drivers to use this error code. Daniel diff -r 2e97361b7242 include/libvirt/virterror.h --- a/include/libvirt/virterror.h Mon Apr 27 11:44:32 2009 +0100 +++ b/include/libvirt/virterror.h Mon Apr 27 12:12:23 2009 +0100 @@ -157,6 +157,7 @@ typedef enum { VIR_ERR_INVALID_NODE_DEVICE,/* invalid node device object */ VIR_ERR_NO_NODE_DEVICE,/* node device not found */ VIR_ERR_NO_SECURITY_MODEL, /* security model not found */ + VIR_ERR_OPERATION_INVALID, /* operation is not applicable at this time */ } virErrorNumber; /** diff -r 2e97361b7242 src/qemu_driver.c --- a/src/qemu_driver.c Mon Apr 27 11:44:32 2009 +0100 +++ b/src/qemu_driver.c Mon Apr 27 12:12:23 2009 +0100 @@ -1325,7 +1325,7 @@ static int qemudStartVMDaemon(virConnect FD_ZERO(&keepfd); if (virDomainIsActive(vm)) { - qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, + qemudReportError(conn, NULL, NULL, VIR_ERR_OPERATION_INVALID, "%s", _("VM is already active")); return -1; } @@ -2214,7 +2214,7 @@ static int qemudDomainSuspend(virDomainP goto cleanup; } if (!virDomainIsActive(vm)) { - qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_FAILED, + qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_INVALID, "%s", _("domain is not running")); goto cleanup; } @@ -2267,7 +2267,7 @@ static int qemudDomainResume(virDomainPt goto cleanup; } if (!virDomainIsActive(vm)) { - qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_FAILED, + qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_INVALID, "%s", _("domain is not running")); goto cleanup; } @@ -2755,7 +2755,7 @@ static int qemudDomainSave(virDomainPtr } if (!virDomainIsActive(vm)) { - qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_FAILED, + qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_INVALID, "%s", _("domain is not running")); goto cleanup; } @@ -2890,7 +2890,7 @@ static int qemudDomainSetVcpus(virDomain } if (virDomainIsActive(vm)) { - qemudReportError(dom->conn, dom, NULL, VIR_ERR_NO_SUPPORT, "%s", + qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_INVALID, "%s", _("cannot change vcpu count of an active domain")); goto cleanup; } @@ -2942,8 +2942,16 @@ qemudDomainPinVcpu(virDomainPtr dom, vm = virDomainFindByUUID(&driver->domains, dom->uuid); qemuDriverUnlock(driver); - if (!virDomainIsActive(vm)) { - qemudReportError(dom->conn, dom, NULL, VIR_ERR_INVALID_ARG, + if (!vm) { + char uuidstr[VIR_UUID_STRING_BUFLEN]; + virUUIDFormat(dom->uuid, uuidstr); + qemudReportError(dom->conn, dom, NULL, VIR_ERR_NO_DOMAIN, + _("no domain with matching uuid '%s'"), uuidstr); + goto cleanup; + } + + if (!virDomainIsActive(vm)) { + qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_INVALID, "%s",_("cannot pin vcpus on an inactive domain")); goto cleanup; } @@ -3003,8 +3011,16 @@ qemudDomainGetVcpus(virDomainPtr dom, vm = virDomainFindByUUID(&driver->domains, dom->uuid); qemuDriverUnlock(driver); - if (!virDomainIsActive(vm)) { - qemudReportError(dom->conn, dom, NULL, VIR_ERR_INVALID_ARG, + if (!vm) { + char uuidstr[VIR_UUID_STRING_BUFLEN]; + virUUIDFormat(dom->uuid, uuidstr); + qemudReportError(dom->conn, dom, NULL, VIR_ERR_NO_DOMAIN, + _("no domain with matching uuid '%s'"), uuidstr); + goto cleanup; + } + + if (!virDomainIsActive(vm)) { + qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_INVALID, "%s",_("cannot pin vcpus on an inactive domain")); goto cleanup; } @@ -3248,7 +3264,7 @@ static int qemudDomainRestore(virConnect vm = virDomainFindByName(&driver->domains, def->name); if (vm) { if (virDomainIsActive(vm)) { - qemudReportError(conn, NULL, NULL, VIR_ERR_OPERATION_FAILED, + qemudReportError(conn, NULL, NULL, VIR_ERR_OPERATION_INVALID, _("domain is already active as '%s'"), vm->def->name); goto cleanup; } else { @@ -3503,7 +3519,7 @@ static int qemudDomainUndefine(virDomain } if (virDomainIsActive(vm)) { - qemudReportError(dom->conn, dom, NULL, VIR_ERR_INTERNAL_ERROR, + qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_INVALID, "%s", _("cannot delete active domain")); goto cleanup; } @@ -3900,7 +3916,7 @@ static int qemudDomainAttachDevice(virDo if (!virDomainIsActive(vm)) { qemuDriverUnlock(driver); - qemudReportError(dom->conn, dom, NULL, VIR_ERR_INTERNAL_ERROR, + qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_INVALID, "%s", _("cannot attach device on inactive domain")); goto cleanup; } @@ -4052,7 +4068,7 @@ static int qemudDomainDetachDevice(virDo if (!virDomainIsActive(vm)) { qemuDriverUnlock(driver); - qemudReportError(dom->conn, dom, NULL, VIR_ERR_INTERNAL_ERROR, + qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_INVALID, "%s", _("cannot detach device on inactive domain")); goto cleanup; } @@ -4212,7 +4228,7 @@ qemudDomainBlockStats (virDomainPtr dom, goto cleanup; } if (!virDomainIsActive (vm)) { - qemudReportError (dom->conn, dom, NULL, VIR_ERR_OPERATION_FAILED, + qemudReportError (dom->conn, dom, NULL, VIR_ERR_OPERATION_INVALID, "%s", _("domain is not running")); goto cleanup; } @@ -4351,7 +4367,7 @@ qemudDomainInterfaceStats (virDomainPtr } if (!virDomainIsActive(vm)) { - qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_FAILED, + qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_INVALID, "%s", _("domain is not running")); goto cleanup; } @@ -4497,7 +4513,7 @@ qemudDomainMemoryPeek (virDomainPtr dom, } if (!virDomainIsActive(vm)) { - qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_FAILED, + qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_INVALID, "%s", _("domain is not running")); goto cleanup; } @@ -4824,7 +4840,7 @@ qemudDomainMigratePerform (virDomainPtr } if (!virDomainIsActive(vm)) { - qemudReportError (dom->conn, dom, NULL, VIR_ERR_OPERATION_FAILED, + qemudReportError (dom->conn, dom, NULL, VIR_ERR_OPERATION_INVALID, "%s", _("domain is not running")); goto cleanup; } diff -r 2e97361b7242 src/virterror.c --- a/src/virterror.c Mon Apr 27 11:44:32 2009 +0100 +++ b/src/virterror.c Mon Apr 27 12:12:23 2009 +0100 @@ -1018,6 +1018,12 @@ virErrorMsg(virErrorNumber error, const else errmsg = _("Security model not found: %s"); break; + case VIR_ERR_OPERATION_INVALID: + if (info == NULL) + errmsg = _("Requested operation is not valid"); + else + errmsg = _("Requested operation is not valid: %s"); + break; } return (errmsg); } diff -r 2e97361b7242 src/xen_internal.c --- a/src/xen_internal.c Mon Apr 27 11:44:32 2009 +0100 +++ b/src/xen_internal.c Mon Apr 27 12:12:23 2009 +0100 @@ -1068,9 +1068,14 @@ xenHypervisorGetSchedulerType(virDomainP } priv = (xenUnifiedPrivatePtr) domain->conn->privateData; - if (priv->handle < 0 || domain->id < 0) { + if (priv->handle < 0) { virXenErrorFunc(domain->conn, VIR_ERR_INTERNAL_ERROR, __FUNCTION__, - "priv->handle or domain->id invalid", 0); + "priv->handle invalid", 0); + return NULL; + } + if (domain->id < 0) { + virXenError(domain->conn, VIR_ERR_OPERATION_INVALID, + "%s", _("domain is not running")); return NULL; } @@ -1143,9 +1148,14 @@ xenHypervisorGetSchedulerParameters(virD } priv = (xenUnifiedPrivatePtr) domain->conn->privateData; - if (priv->handle < 0 || domain->id < 0) { + if (priv->handle < 0) { virXenErrorFunc(domain->conn, VIR_ERR_INTERNAL_ERROR, __FUNCTION__, - "priv->handle or domain->id invalid", 0); + "priv->handle invalid", 0); + return -1; + } + if (domain->id < 0) { + virXenError(domain->conn, VIR_ERR_OPERATION_INVALID, + "%s", _("domain is not running")); return -1; } @@ -1241,9 +1251,14 @@ xenHypervisorSetSchedulerParameters(virD } priv = (xenUnifiedPrivatePtr) domain->conn->privateData; - if (priv->handle < 0 || domain->id < 0) { - virXenErrorFunc (domain->conn, VIR_ERR_INTERNAL_ERROR, __FUNCTION__, - "priv->handle or domain->id invalid", 0); + if (priv->handle < 0) { + virXenErrorFunc(domain->conn, VIR_ERR_INTERNAL_ERROR, __FUNCTION__, + "priv->handle invalid", 0); + return -1; + } + if (domain->id < 0) { + virXenError(domain->conn, VIR_ERR_OPERATION_INVALID, + "%s", _("domain is not running")); return -1; } diff -r 2e97361b7242 src/xend_internal.c --- a/src/xend_internal.c Mon Apr 27 11:44:32 2009 +0100 +++ b/src/xend_internal.c Mon Apr 27 12:12:23 2009 +0100 @@ -2970,7 +2970,7 @@ xenDaemonDomainSuspend(virDomainPtr doma } if (domain->id < 0) { - virXendError(domain->conn, VIR_ERR_INVALID_ARG, + virXendError(domain->conn, VIR_ERR_OPERATION_INVALID, _("Domain %s isn't running."), domain->name); return(-1); } @@ -2997,7 +2997,7 @@ xenDaemonDomainResume(virDomainPtr domai } if (domain->id < 0) { - virXendError(domain->conn, VIR_ERR_INVALID_ARG, + virXendError(domain->conn, VIR_ERR_OPERATION_INVALID, _("Domain %s isn't running."), domain->name); return(-1); } @@ -3025,7 +3025,7 @@ xenDaemonDomainShutdown(virDomainPtr dom } if (domain->id < 0) { - virXendError(domain->conn, VIR_ERR_INVALID_ARG, + virXendError(domain->conn, VIR_ERR_OPERATION_INVALID, _("Domain %s isn't running."), domain->name); return(-1); } @@ -3054,7 +3054,7 @@ xenDaemonDomainReboot(virDomainPtr domai } if (domain->id < 0) { - virXendError(domain->conn, VIR_ERR_INVALID_ARG, + virXendError(domain->conn, VIR_ERR_OPERATION_INVALID, _("Domain %s isn't running."), domain->name); return(-1); } @@ -3085,7 +3085,7 @@ xenDaemonDomainDestroy(virDomainPtr doma } if (domain->id < 0) { - virXendError(domain->conn, VIR_ERR_INVALID_ARG, + virXendError(domain->conn, VIR_ERR_OPERATION_INVALID, _("Domain %s isn't running."), domain->name); return(-1); } @@ -3160,7 +3160,7 @@ xenDaemonDomainSave(virDomainPtr domain, } if (domain->id < 0) { - virXendError(domain->conn, VIR_ERR_INVALID_ARG, + virXendError(domain->conn, VIR_ERR_OPERATION_INVALID, _("Domain %s isn't running."), domain->name); return(-1); } @@ -3197,7 +3197,7 @@ xenDaemonDomainCoreDump(virDomainPtr dom } if (domain->id < 0) { - virXendError(domain->conn, VIR_ERR_INVALID_ARG, + virXendError(domain->conn, VIR_ERR_OPERATION_INVALID, _("Domain %s isn't running."), domain->name); return(-1); } -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 1

[libvirt] [PATCH] Remove unused file volume format 'dir'
by Cole Robinson 29 Apr '09

29 Apr '09

It isn't documented, detected, and barely has any code accomodating it. Appears to be left over from an earlier iteration of the storage APIs. Thanks, Cole

2 2

[libvirt] [PATCH 2/2] Support for 'hostonly' and 'internal' network in VirtualBox
by Pritesh Kothari 29 Apr '09

29 Apr '09

Hi All, I have added the support for hostonly and internal network as suggested on irc and list and am attaching the patch for same. PATCH 1/2: contains changes in the xml parsing/formatting on libvirt side namely adding a mode attribute to <source> tag in domain/interface xml PATCH 2/2: contains changes in the vbox driver itself. Regards, Pritesh

1 0

[libvirt] [PATCH] fix soem missing directories and ownership in spec file
by Daniel Veillard 28 Apr '09

28 Apr '09

The spec file in CVs was missing the creation fo some directories and forgot to take ownership of the cache subdir used for memory dumps with QEmu/KVM Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

2 2

[libvirt] PATCH: Allow for quiet build output
by Daniel P. Berrange 28 Apr '09

28 Apr '09

The following patch is a slightly gross hack that puts a wrapper around libtool to make it STFU, and only print the name of the output file, and associated input files. Since we can't change the automake generated Makefile.in to add '@' in front of all libtool commands, this sill won't be quiet by default. To make it really quiet you need to run 'make -s' eg, a short transcript with this applied.... $ make -s Making all in gnulib/lib (CC) -o c-ctype.lo c-ctype.c (CC) -o asnprintf.lo asnprintf.c (CC) -o physmem.lo physmem.c (CC) -o printf-args.lo printf-args.c (CC) -o printf-parse.lo printf-parse.c (CC) -o tempname.lo tempname.c (CC) -o vasnprintf.lo vasnprintf.c (LD) -o libgnu.la c-ctype.lo asnprintf.lo physmem.lo printf-args.lo printf-parse.lo tempname.lo vasnprintf.lo Making all in include Making all in libvirt Making all in src (CC) -o bridge.lo bridge.c (CC) -o buf.lo buf.c (CC) -o conf.lo conf.c (CC) -o event.lo event.c (CC) -o hash.lo hash.c (CC) -o iptables.lo iptables.c (CC) -o logging.lo logging.c (CC) -o memory.lo memory.c (CC) -o pci.lo pci.c (CC) -o qparams.lo qparams.c (CC) -o threads.lo threads.c (CC) -o uuid.lo uuid.c (CC) -o util.lo util.c (CC) -o virterror.lo virterror.c (CC) -o xml.lo xml.c (LD) -o libvirt_util.la bridge.lo buf.lo conf.lo event.lo hash.lo iptables.lo logging.lo memory.lo pci.lo qparams.lo threads.lo uuid.lo util.lo virterror.lo xml.lo (CC) -o libvirt_driver_la-driver.lo driver.c (CC) -o libvirt_driver_la-datatypes.lo datatypes.c (CC) -o libvirt_driver_la-domain_event.lo domain_event.c (CC) -o libvirt_driver_la-stats_linux.lo stats_linux.c (CC) -o libvirt_driver_la-libvirt.lo libvirt.c (CC) -o libvirt_driver_la-capabilities.lo capabilities.c (CC) -o libvirt_driver_la-domain_conf.lo domain_conf.c (CC) -o libvirt_driver_la-nodeinfo.lo nodeinfo.c (CC) -o libvirt_driver_la-network_conf.lo network_conf.c (CC) -o libvirt_driver_la-storage_conf.lo storage_conf.c (CC) -o libvirt_driver_la-node_device_conf.lo node_device_conf.c (LD) -o libvirt_driver.la libvirt_driver_la-driver.lo libvirt_driver_la-datatypes.lo libvirt_driver_la-domain_event.lo libvirt_driver_la-stats_linux.lo libvirt_driver_la-libvirt.lo libvirt_driver_la-capabilities.lo libvirt_driver_la-domain_conf.lo libvirt_driver_la-nodeinfo.lo libvirt_driver_la-network_conf.lo libvirt_driver_la-storage_conf.lo libvirt_driver_la-node_device_conf.lo (CC) -o test.lo test.c (LD) -o libvirt_driver_test.la test.lo (CC) -o libvirt_driver_remote_la-remote_internal.lo remote_internal.c (CC) -o libvirt_driver_remote_la-remote_protocol.lo ../qemud/remote_protocol.c (LD) -o libvirt_driver_remote.la libvirt_driver_remote_la-remote_internal.lo libvirt_driver_remote_la-remote_protocol.lo (CC) -o libvirt_driver_xen_la-proxy_internal.lo proxy_internal.c Aside from changing libtool and automake themselves, I don't see any easier way to do this better. b/mylibtool | 62 ++++++++++++++++++++++++++++ examples/domain-events/events-c/Makefile.am | 3 + examples/hellolibvirt/Makefile.am | 3 + gnulib/lib/Makefile.am | 3 + proxy/Makefile.am | 3 + qemud/Makefile.am | 3 + src/Makefile.am | 3 + tests/Makefile.am | 3 + tools/Makefile.am | 3 + 9 files changed, 86 insertions(+) Daniel diff -r f60b121571f2 examples/domain-events/events-c/Makefile.am --- a/examples/domain-events/events-c/Makefile.am Mon Apr 27 12:12:23 2009 +0100 +++ b/examples/domain-events/events-c/Makefile.am Tue Apr 28 12:26:44 2009 +0100 @@ -1,3 +1,6 @@ +AM_LIBTOOLFLAGS = --silent +LIBTOOL = $(top_srcdir)/mylibtool + INCLUDES = -I@top_srcdir@/include noinst_PROGRAMS = event-test event_test_CFLAGS = $(WARN_CFLAGS) diff -r f60b121571f2 examples/hellolibvirt/Makefile.am --- a/examples/hellolibvirt/Makefile.am Mon Apr 27 12:12:23 2009 +0100 +++ b/examples/hellolibvirt/Makefile.am Tue Apr 28 12:26:44 2009 +0100 @@ -1,3 +1,6 @@ +AM_LIBTOOLFLAGS = --silent +LIBTOOL = $(top_srcdir)/mylibtool + INCLUDES = -I@top_srcdir@/include noinst_PROGRAMS = hellolibvirt hellolibvirt_CFLAGS = $(WARN_CFLAGS) diff -r f60b121571f2 gnulib/lib/Makefile.am --- a/gnulib/lib/Makefile.am Mon Apr 27 12:12:23 2009 +0100 +++ b/gnulib/lib/Makefile.am Tue Apr 28 12:26:44 2009 +0100 @@ -11,6 +11,9 @@ # Generated by gnulib-tool. # Reproduce by: gnulib-tool --import --dir=. --lib=libgnu --source-base=gnulib/lib --m4-base=gnulib/m4 --doc-base=doc --tests-base=gnulib/tests --aux-dir=build-aux --with-tests --lgpl=2 --libtool --macro-prefix=gl --no-vc-files c-ctype close connect getaddrinfo gethostname getpass gettext inet_pton ioctl mkstemp mktempd perror physmem poll posix-shell random_r recv send setsockopt socket stpcpy strerror strndup strsep sys_stat time_r useless-if-before-free vasprintf vc-list-files verify +AM_LIBTOOLFLAGS = --silent +LIBTOOL = $(top_srcdir)/mylibtool + AUTOMAKE_OPTIONS = 1.5 gnits SUBDIRS = diff -r f60b121571f2 mylibtool --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/mylibtool Tue Apr 28 12:26:44 2009 +0100 @@ -0,0 +1,62 @@ +#!/bin/sh + +mode=libtool +cfiles="" +ofiles="" +afiles="" + +wantnext=0 +for v in "$@" +do + case $v + in + --mode=compile) + mode=CC + ;; + --mode=link) + mode=LD + ;; + esac + + case $v + in + *.c) + cfiles="$cfiles $v" + ;; + *.o) + if [ "$mode" = "LD" -o "$wantnext" = "1" ]; then + ofiles="$ofiles $v" + fi + ;; + *.lo) + if [ "$mode" = "LD" -o "$wantnext" = "1" ]; then + ofiles="$ofiles $v" + fi + ;; + esac + + if [ "$mode" = "LD" -a "$wantnext" = "1" ]; then + afiles="$afiles $v" + fi + + if [ "$v" = "-o" ]; then + wantnext=1 + else + wantnext=0 + fi +done + +#afiles=`echo $afiles | sed -e 's/ /\n/g' | sort | uniq | tr '\n' ' '` +#cfiles=`echo $cfiles | sed -e 's/ /\n/g' | sort | uniq | tr '\n' ' '` +#ofiles=`echo $ofiles | sed -e 's/ /\n/g' | sort | uniq | tr '\n' ' '` + +args="" +test -n "$afiles" && args="$args -o$afiles" +test -n "$ofiles" -a "$mode" = "CC" && args="$args -o" +test -n "$ofiles" && args="$args$ofiles" +test -n "$cfiles" && args="$args$cfiles" + +echo "($mode)$args" + +here=`dirname $0` +exec $here/libtool "$@" diff -r f60b121571f2 proxy/Makefile.am --- a/proxy/Makefile.am Mon Apr 27 12:12:23 2009 +0100 +++ b/proxy/Makefile.am Tue Apr 28 12:26:44 2009 +0100 @@ -1,5 +1,8 @@ ## Process this file with automake to produce Makefile.in +AM_LIBTOOLFLAGS = --silent +LIBTOOL = $(top_srcdir)/mylibtool + if WITH_PROXY INCLUDES = -I$(top_srcdir)/gnulib/lib -I../gnulib/lib \ -I$(top_builddir)/include -I@top_srcdir@/include \ diff -r f60b121571f2 qemud/Makefile.am --- a/qemud/Makefile.am Mon Apr 27 12:12:23 2009 +0100 +++ b/qemud/Makefile.am Tue Apr 28 12:26:44 2009 +0100 @@ -1,5 +1,8 @@ ## Process this file with automake to produce Makefile.in +AM_LIBTOOLFLAGS = --silent +LIBTOOL = $(top_srcdir)/mylibtool + DAEMON_SOURCES = \ event.c event.h \ qemud.c qemud.h \ diff -r f60b121571f2 src/Makefile.am --- a/src/Makefile.am Mon Apr 27 12:12:23 2009 +0100 +++ b/src/Makefile.am Tue Apr 28 12:26:44 2009 +0100 @@ -1,5 +1,8 @@ ## Process this file with automake to produce Makefile.in +AM_LIBTOOLFLAGS = --silent +LIBTOOL = $(top_srcdir)/mylibtool + INCLUDES = \ -I$(top_srcdir)/gnulib/lib -I../gnulib/lib \ -I../include \ diff -r f60b121571f2 tests/Makefile.am --- a/tests/Makefile.am Mon Apr 27 12:12:23 2009 +0100 +++ b/tests/Makefile.am Tue Apr 28 12:26:44 2009 +0100 @@ -1,5 +1,8 @@ ## Process this file with automake to produce Makefile.in +AM_LIBTOOLFLAGS = --silent +LIBTOOL = $(top_srcdir)/mylibtool + SHELL = $(PREFERABLY_POSIX_SHELL) SUBDIRS = confdata sexpr2xmldata \ diff -r f60b121571f2 tools/Makefile.am --- a/tools/Makefile.am Mon Apr 27 12:12:23 2009 +0100 +++ b/tools/Makefile.am Tue Apr 28 12:26:44 2009 +0100 @@ -1,3 +1,6 @@ + +AM_LIBTOOLFLAGS = --silent +LIBTOOL = $(top_srcdir)/mylibtool bin_SCRIPTS = \ virt-xml-validate -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

1 0