- Devel - libvirt List Archives

[libvirt] [PATCH 1/2] Added new filesystem glusterfs
by Harshavardhana 07 Jul '09

07 Jul '09

Added new enum for glusterfs, a new netfs based filesystem --- src/storage_conf.c | 2 +- src/storage_conf.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/storage_conf.c b/src/storage_conf.c index 5f724dc..16ed906 100644 --- a/src/storage_conf.c +++ b/src/storage_conf.c @@ -68,7 +68,7 @@ VIR_ENUM_IMPL(virStoragePoolFormatFileSystem, VIR_ENUM_IMPL(virStoragePoolFormatFileSystemNet, VIR_STORAGE_POOL_NETFS_LAST, - "auto", "nfs") + "auto", "nfs", "glusterfs") VIR_ENUM_IMPL(virStoragePoolFormatDisk, VIR_STORAGE_POOL_DISK_LAST, diff --git a/src/storage_conf.h b/src/storage_conf.h index 8a4fed2..27dc4a7 100644 --- a/src/storage_conf.h +++ b/src/storage_conf.h @@ -151,7 +151,6 @@ struct _virStoragePoolSourceHost { int protocol; }; - /* * Available extents on the underlying storage */ @@ -366,6 +365,7 @@ VIR_ENUM_DECL(virStoragePoolFormatFileSystem) enum virStoragePoolFormatFileSystemNet { VIR_STORAGE_POOL_NETFS_AUTO = 0, VIR_STORAGE_POOL_NETFS_NFS, + VIR_STORAGE_POOL_NETFS_GLUSTERFS, VIR_STORAGE_POOL_NETFS_LAST, }; VIR_ENUM_DECL(virStoragePoolFormatFileSystemNet) -- 1.6.0.6

1 0

[libvirt] make distcheck failure
by Guido Günther 07 Jul '09

07 Jul '09

Hi, in current git make distcheck currently fails on me with: make[5]: Entering directory `/var/scratch/debian/libvirt/cvs/libvirt/libvirt-0.6.5/_build/gnulib/lib' /bin/sh ../../../mylibtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../../../gnulib/lib -I../.. -I../../intl -g -O2 -MT c-ctype.lo -MD -MP -MF .deps/c-ctype.Tpo -c -o c-ctype.lo ../../../gnulib/lib/c-ctype.c (CC) -o c-ctype.lo ../../../gnulib/lib/c-ctype.c ../../../mylibtool: line 58: /var/scratch/debian/libvirt/cvs/libvirt/libvirt-0.6.5/_build/gnulib/lib/../../../libtool: No such file or directory ../../../mylibtool: line 58: exec: /var/scratch/debian/libvirt/cvs/libvirt/libvirt-0.6.5/_build/gnulib/lib/../../../libtool: cannot execute: No such file or directory make[5]: *** [c-ctype.lo] Error 126 Any ideas? Cheers, -- Guido

2 1

[libvirt] Save and restore with KVM!
by Erkan Unal 06 Jul '09

06 Jul '09

Hi, First of all, I want to ask: is there a libvirt user mailing list? I generally see people exchanging ideas on development of libvirt in this mailing list. So feel free to direct me to the right place if this is not the main mailing list for these kind of questions. I am having problems with save and restore commands in virsh when I try to save and restore KVM virtual machines. After I initiate restore operation, instead of starting where I left during the save operation, it is restarting the VM. Therefore, I need to ask what should I check for these operations to execute correctly? What kind of vm disk types: qcow or vmdk? Which versions of qemu, kvm and libvirt combinations? currently I have libvirt 0.6.5, qemu 0.9.1, kvm-82 on fedora core 8 with kernel version of 2.6.26.8. Thanks, Erkan Unal

2 1

[libvirt] [PATCH] createLinux requires full-access connection
by Dan Kenigsberg 06 Jul '09

06 Jul '09

--- docs/examples/python/domstart.py | 2 +- python/tests/create.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/examples/python/domstart.py b/docs/examples/python/domstart.py index 64434c4..52fb79e 100755 --- a/docs/examples/python/domstart.py +++ b/docs/examples/python/domstart.py @@ -32,7 +32,7 @@ if len(sys.argv) != 2: (name, xmldesc) = read_domain(sys.argv[1]) -conn = libvirt.openReadOnly(None) +conn = libvirt.open(None) if conn == None: print 'Failed to open connection to the hypervisor' sys.exit(1) diff --git a/python/tests/create.py b/python/tests/create.py index 0da89a9..d2c434e 100755 --- a/python/tests/create.py +++ b/python/tests/create.py @@ -52,7 +52,7 @@ else: initrdU = "<initrd>" + initrdU + "</initrd>" -conn = libvirt.openReadOnly(None) +conn = libvirt.open(None) if conn == None: print 'Failed to open connection to the hypervisor' sys.exit(1) -- 1.6.2.5

3 2

[libvirt] [PATCH] Do a correct format mapping of partitions 2
by Henrik Persson 06 Jul '09

06 Jul '09

I make a new try from a different mail client now. /Henrik

4 5

Re: [libvirt] Patch to include arm variants in virsh capabilities
by C.J. Adams-Collier 05 Jul '09

05 Jul '09

> On Wed, Jul 01, 2009 at 11:02:16AM -0700, C.J. Adams-Collier wrote: > > Hey folks, > > > > I got an android and wanted to set up an armel debian vm to test out > > some code. I had to launch it directly with qemu-system-arm, though, > > since virsh didn't have an arm option to select. > > > > This is a patch against the debian version of the source after applying > > debian-specific changes. If you'd like a patch against mainline, I'd be > > willing to do that. > > > > http://karma.colliertech.org/~cjac/tmp/add-arm.patch > > Well, this list is really about upstream patches not distro specific > ones, I just verified that it applies cleanly against CVS. > and I could not access said patch [1]. That is weird. I hope it was just a fluke! Attached. > Send a patch against the > latest version or CVS/git as an mail attachemnt and we will try to add > it. Alrighty. I see that the mips machines are separated into 'mips' and 'mipsel'. I don't know anything about the endian-ness of the various machines (aside from versatilepb, which is little), so I just left them all in the generic qemu_arch_info.arch="arm" table entry. > Daniel Cheers, C.J. > [1] the server seems down I got an HTTP request timeout. hurm... I'm getting hits at least hourly from a site revproxied by the same host ( http://wp.colliertech.org/cj/ ) - perhaps it was a coincidental outage (*shakes fist at comcast*)? > -- > Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ > daniel <at> veillard.com | Rpmfind RPM search engine http://rpmfind.net/ > http://veillard.com/ | virtualization library http://libvirt.org/

3 5

[libvirt] Release of libvirt-0.6.5
by Daniel Veillard 03 Jul '09

03 Jul '09

As scheduled, the new version is available on the server: ftp://libvirt.org/libvirt/ This is mostly a bug fix release, though it includes some serious improvements for storage/NPIV and on the OpenNebula driver: * New features - create storage columes on disk backend (Henrik Persson) - drop of capabilities based on libcap-ng when possible (Daniel Berrange) * Portability - fix build on non-Linux targets (Daniel Berrange) * Documentation - typo and english fixes (Runa Bhattacharjee and Garry Dolley) - Docs on extending APIs (Dave Allan) - cleanup of debug and logging documentation (Amy Griffis) - add HACKING doc to the website (Daniel Berrange) - documentation for OpenNebula driver (Abel Miguez Rodriguez) * Bug fixes - forbid autostart on transcient networks - xen device removal crash (Daniel Berrange) - re-detection of transient VMs after libvirtd restart(Daniel Berrange) - bug in virFindFileInPath (Daniel Berrange) - handle new availheap sysctl in Xen (Daniel Berrange) - allow USB hostdev product 0 (Cole Robinson) - cleanup when creating a storage pool fails (Henrik Persson) - domain id fix on redefinition in test driver (Cole Robinson) - fix raw storage allocation (Cole Robinson) - memory reporting for inactive qemu drivers (Cole Robinson) - segfault if storage pool has no type attribute (Cole Robinson) - OpenNebula compilation issues (Javier Fontan) - dominfo command without security driver (Daniel Berrange) - domain state problems after migration or destroy (Federico Simoncelli) - leak in node device parsing (Dave Allan) - storage pool definitions reading at startup (Cole Robinson) - bogus WWN in NPIV support (David Allan) - avoid a segfault with recent Xen (Sascha) - cope with libnuma failures on weird topologies (Dan Berrange) - crash in QEMU driver with bad capabilities data (Dan Berrange) - trying to re-create a pool should not destroy it (Dave Allan) - endless loop in node device XML dump (Cole Robinson) - Re-label shared and readonly images (Dan Berrange) * Improvements - create and destroy NPIV support (David Allan) - networking in UML driver (Daniel Berrange) - HAL driver restart thread safety (Daniel Berrange) - capabilities and nodeinfo APIs for LXC (Daniel Berrange) - iNUMA API for VBox (Daniel Berrange) - dynamically search and use kvm-img qemu-img or qcow-create (Doug Goldstein) - fix qemu and kvm version parsing (Mark McLoughlin) - serial number for HAL storage (Dave Allan) - improve error reporting for virConnectOpen URIs (Daniel Berrange) - include OS driver name in device XML (Daniel Berrange) - fix qemu command flags fetching (Cole Robinson) - check that qemu support -drive format= (Cole Robinson) - improve emulator detection (Cole Robinson) - changes to config parser to accomodate VMX syntax (Matthias Bolte) - update network schemas and driver for missing elements (Satoru SATOH) - avoid changing file context if not needed (Tim Waugh) - skip labelling if no src path (Cole Robinson) - add arm emulation if qemu-system-arm is present (C.J. Adams-Collier) * Cleanups - daemon check logging env variables (Daniel Berrange) - User Mode Linux start and stop cleanups (Daniel Berrange) - share the NUMA api implementations (Daniel Berrange) - storage module dependancies (Dave Allan) - refactor storage XML parsing (Cole Robinson) - big cleanup of logging code (Amy Griffis) - superfluous % on format (Matthias Bolte) - cleanups and updates on OpenNebula driver (Daniel Berrange and Abel Miguez Rodriguez) thanks everybody for report, patches, documentation, etc ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] gitignore & cscope
by Dave Allan 03 Jul '09

03 Jul '09

Could we add cscope's files to .gitignore? Dave diff --git a/.gitignore b/.gitignore index 1b36694..ca73a98 100644 --- a/.gitignore +++ b/.gitignore @@ -19,6 +19,8 @@ config.status config.sub configure coverage +cscope.files +cscope.out libtool libvirt-*.tar.gz libvirt.pc

4 3

[libvirt] [PATCH 1/2] Re-label shared and readonly images
by Mark McLoughlin 03 Jul '09

03 Jul '09

From: Daniel P. Berrange <berrange(a)redhat.com> This patch was posted ages ago here: https://bugzilla.redhat.com/493692 But was never posted upstream AFAICT. Signed-off-by: Mark McLoughlin <markmc(a)redhat.com> --- src/security_selinux.c | 27 +++++++++++++++++---------- 1 files changed, 17 insertions(+), 10 deletions(-) diff --git a/src/security_selinux.c b/src/security_selinux.c index 4fb7c86..87073d2 100644 --- a/src/security_selinux.c +++ b/src/security_selinux.c @@ -24,11 +24,12 @@ #include "virterror_internal.h" #include "util.h" #include "memory.h" - +#include "logging.h" #define VIR_FROM_THIS VIR_FROM_SECURITY static char default_domain_context[1024]; +static char default_content_context[1024]; static char default_image_context[1024]; #define SECURITY_SELINUX_VOID_DOI "0" #define SECURITY_SELINUX_NAME "selinux" @@ -148,8 +149,13 @@ SELinuxInitialize(virConnectPtr conn) close(fd); ptr = strchrnul(default_image_context, '\n'); - *ptr = '\0'; - + if (*ptr == '\n') { + *ptr = '\0'; + strcpy(default_content_context, ptr+1); + ptr = strchrnul(default_content_context, '\n'); + if (*ptr == '\n') + *ptr = '\0'; + } return 0; } @@ -313,6 +319,8 @@ SELinuxSetFilecon(virConnectPtr conn, const char *path, char *tcon) { char ebuf[1024]; + VIR_INFO("Setting SELinux context on '%s' to '%s'", path, tcon); + if(setfilecon(path, tcon) < 0) { virSecurityReportError(conn, VIR_ERR_ERROR, _("%s: unable to set security context " @@ -337,9 +345,6 @@ SELinuxRestoreSecurityImageLabel(virConnectPtr conn, char *newpath = NULL; const char *path = disk->src; - if (disk->readonly || disk->shared) - return 0; - if ((err = virFileResolveLink(path, &newpath)) < 0) { virReportSystemError(conn, err, _("cannot resolve symlink %s"), path); @@ -366,8 +371,13 @@ SELinuxSetSecurityImageLabel(virConnectPtr conn, { const virSecurityLabelDefPtr secdef = &vm->def->seclabel; - if (secdef->imagelabel) + if (disk->shared) { + return SELinuxSetFilecon(conn, disk->src, default_image_context); + } else if (disk->readonly) { + return SELinuxSetFilecon(conn, disk->src, default_content_context); + } else if (secdef->imagelabel) { return SELinuxSetFilecon(conn, disk->src, secdef->imagelabel); + } return 0; } @@ -441,9 +451,6 @@ SELinuxSetSecurityLabel(virConnectPtr conn, if (secdef->imagelabel) { for (i = 0 ; i < vm->def->ndisks ; i++) { - if (vm->def->disks[i]->readonly || - vm->def->disks[i]->shared) continue; - if (SELinuxSetSecurityImageLabel(conn, vm, vm->def->disks[i]) < 0) return -1; } -- 1.6.2.5

2 5

[libvirt] vTPM support in libvirt
by Andreas Sommer 02 Jul '09

02 Jul '09

I'm wondering if there will be vTPM support in libvirt in the near future?! Xen does support it already with the configuration "vtpm = ['instance=1,backend=0']", for example. So it would be great if the libvirt XML format supported it, too... For example like this: <devices> <vtpm instance="1" backend="xxx" /> </devices> Both attributes are optional. The backend attribute is a VM ID (on Xen, only zero for dom0 is supported) and could be implemented as a UUID?! What do you think? Are there any efforts to introducing that? Cheers Andreas

6 13

[libvirt] [Patch] Fix network driver not to forget to save <domain/> in network XML file
by Satoru SATOH 02 Jul '09

02 Jul '09

It seems that libvirt network driver can understand /network/domain element but it does not save this configuration into the network definition XML file correctly (looks completely forgetting about it). Here is a fix for this problem. (see also: rhbz#505720) --- src/network_conf.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/network_conf.c b/src/network_conf.c index 1e0cbb8..1b50b84 100644 --- a/src/network_conf.c +++ b/src/network_conf.c @@ -592,6 +592,9 @@ char *virNetworkDefFormat(virConnectPtr conn, def->stp ? "on" : "off", def->delay); + if (def->domain) + virBufferVSprintf(&buf, " <domain name='%s'/>\n", def->domain); + if (def->ipAddress || def->netmask) { virBufferAddLit(&buf, " <ip"); -- 1.6.3.2

3 2

[libvirt] [Patch] Network schema fixes and updates
by Satoru SATOH 02 Jul '09

02 Jul '09

This is a patch to make network schema (network.rng) to support some neat features (/netowrk/domain, //dhcp/host/*). --- docs/schemas/network.rng | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng index 34c0163..a4281a5 100644 --- a/docs/schemas/network.rng +++ b/docs/schemas/network.rng @@ -1,6 +1,7 @@  <element name="network" xmlns="http://relaxng.org/ns/structure/1.0" datatypeLibrary="http://www.w3.org/2001/XMLSchema-datatypes"> + <interleave>  <element name="name"><text/></element> @@ -43,6 +44,11 @@ </element> </optional> <optional> + <element name="domain"> + <attribute name="name"><text/></attribute> + </element> + </optional> + <optional>  <!-- FIXME: address, netmask and the start and end of the ranges @@ -63,7 +69,15 @@ <attribute name="end"><text/></attribute> </element> </zeroOrMore> + <zeroOrMore> + <element name="host"> + <attribute name="mac"><text/></attribute> + <attribute name="name"><text/></attribute> + <attribute name="ip"><text/></attribute> + </element> + </zeroOrMore> </element> </element> </optional> + </interleave> </element> -- 1.6.3.2

3 2

[libvirt] [PATCH 0/1] Fix pool create when pool already exists
by David Allan 02 Jul '09

02 Jul '09

When storagePoolCreate is called to define a pool that already exists, it mistakenly destroys the existing pool. This patch fixes the problem. Dave

5 8

[libvirt] Patch to include arm variants in virsh capabilities
by C.J. Adams-Collier 02 Jul '09

02 Jul '09

Hey folks, I got an android and wanted to set up an armel debian vm to test out some code. I had to launch it directly with qemu-system-arm, though, since virsh didn't have an arm option to select. This is a patch against the debian version of the source after applying debian-specific changes. If you'd like a patch against mainline, I'd be willing to do that. http://karma.colliertech.org/~cjac/tmp/add-arm.patch Cheers, C.J.

2 1

[libvirt] [PATCH] Fix node dumpxml infinite loop
by Cole Robinson 01 Jul '09

01 Jul '09

With current git, doing: 'virsh nodedev-dumpxml computer' locks up the daemon. The list iteration in update_caps was only happening conditionally: if that condition wasn't met, we loop forever. - Cole

3 2

[libvirt] PATCH: Opennebula Documentation updates
by "Abel Míguez Rodríguez" 01 Jul '09

01 Jul '09

Hi, here are some changes to apply at the ONE Documentation, Thanks Abel Miguez Rodriguez ---- Distributed System Architecture Group (http://dsa-research.org) GridWay, http://www.gridway.org OpenNEbula, http://www.opennebula.org

2 1

[libvirt] fix for crash in NPIV code
by Dave Allan 01 Jul '09

01 Jul '09

DV found a place in the NPIV code that was freeing the wrong thing in the error case causing a segfault. The patch to fix it follows. Dave diff --git a/src/node_device.c b/src/node_device.c index cd9f0ef..c5b839b 100644 --- a/src/node_device.c +++ b/src/node_device.c @@ -489,8 +489,8 @@ get_wwns(virConnectPtr conn, if (*wwnn == NULL || *wwpn == NULL) { /* Free the other one, if allocated... */ - VIR_FREE(wwnn); - VIR_FREE(wwpn); + VIR_FREE(*wwnn); + VIR_FREE(*wwpn); ret = -1; virReportOOMError(conn); }

2 1

[libvirt] PATCH : Opennebula documentation
by "Abel Míguez Rodríguez" 01 Jul '09

01 Jul '09

Hi, Attached is the OpenNebula driver documentation and a patch. The main Documentation file is "drvone.html.in" along with it a patch that includes: the API supported by the driver, an entry at "Documentation>Drivers" and a link to the documentation at "drivers.hmtl.in" Thanks --- sitemap.html.in.bak 2009-07-01 12:43:53.000000000 +0200 +++ sitemap.html.in 2009-06-30 18:19:44.000000000 +0200 @@ -148,6 +148,10 @@ <a href="drvvbox.html">VirtualBox</a> Driver for VirtualBox </li> + <li> + <a href="drvone.html">OpenNebula</a> + Driver for OpenNebula + </li> </ul> </li> <li> --- drivers.html.in.bak 2009-07-01 14:54:57.000000000 +0200 +++ drivers.html.in 2009-07-01 14:55:33.000000000 +0200 @@ -23,6 +23,7 @@ <li><a href="drvtest.html">Test</a></li> <li><a href="drvopenvz.html">OpenVZ</a></li> <li><a href="drvvbox.html">VirtualBox</a></li> + <li><a href="drvone.html">OpenNebula</a></li> </ul> </body> </html> --- hvsupport.html.in.bak 2009-07-01 12:41:36.000000000 +0200 +++ hvsupport.html.in 2009-07-01 13:02:38.000000000 +0200 @@ -22,6 +22,7 @@ updated on 2008-06-05. <th><a href="drvkvm.html">KVM</a></th> <th><a href="remote.html">Remote</a></th> <th><a href="drvvbox.html">VirtualBox</a></th> + <th><a href="drvone.html">ONE</a></th> </tr> <tr> <td> virConnectClose </td> @@ -31,6 +32,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectGetCapabilities </td> @@ -40,6 +42,7 @@ updated on 2008-06-05. <td> ≥ 0.2.1 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectGetHostname </td> @@ -49,6 +52,7 @@ updated on 2008-06-05. <td> ≥ 0.3.3 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virConnectGetMaxVcpus </td> @@ -58,6 +62,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virConnectGetType </td> @@ -67,6 +72,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectGetURI </td> @@ -76,6 +82,7 @@ updated on 2008-06-05. <td> ≥ 0.3.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectGetVersion </td> @@ -85,6 +92,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectListDefinedDomains </td> @@ -94,6 +102,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectListDomains </td> @@ -103,6 +112,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectNumOfDefinedDomains </td> @@ -112,6 +122,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectNumOfDomains </td> @@ -121,6 +132,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectOpen </td> @@ -130,6 +142,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectOpenAuth </td> @@ -139,6 +152,7 @@ updated on 2008-06-05. <td> </td> <td> </td> <td> </td> + <td> </td> </tr> <tr> <td> virConnectOpenReadOnly </td> @@ -148,6 +162,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainAttachDevice </td> @@ -157,6 +172,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virDomainBlockPeek </td> @@ -166,6 +182,7 @@ updated on 2008-06-05. <td> 0.4.3 </td> <td> x </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainBlockStats </td> @@ -175,6 +192,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.2 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainCoreDump </td> @@ -184,6 +202,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainCreate </td> @@ -193,6 +212,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainCreateLinux </td> @@ -202,6 +222,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainDefineXML </td> @@ -211,6 +232,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainDestroy </td> @@ -220,6 +242,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainDetachDevice </td> @@ -229,6 +252,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virDomainFree </td> @@ -238,6 +262,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainGetAutostart </td> @@ -247,11 +272,12 @@ updated on 2008-06-05. <td> ≥ 0.2.1 </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainGetConnect </td> <td> 0.3.0 </td> - <td colspan="5"> not a HV function </td> + <td colspan="6"> not a HV function </td> </tr> <tr> <td> virDomainGetID </td> @@ -261,6 +287,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainGetInfo </td> @@ -270,6 +297,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainGetMaxMemory </td> @@ -279,6 +307,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virDomainGetMaxVcpus </td> @@ -288,6 +317,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainGetName </td> @@ -297,6 +327,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainGetOSType </td> @@ -306,6 +337,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainGetSchedulerParameters </td> @@ -315,6 +347,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainGetSchedulerType </td> @@ -324,6 +357,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainGetUUID </td> @@ -333,6 +367,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainGetUUIDString </td> @@ -342,6 +377,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainGetVcpus </td> @@ -351,6 +387,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainInterfaceStats </td> @@ -360,6 +397,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.2 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainGetXMLDesc </td> @@ -369,6 +407,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virDomainLookupByID </td> @@ -378,6 +417,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainLookupByName </td> @@ -387,6 +427,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainLookupByUUID </td> @@ -396,6 +437,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainLookupByUUIDString </td> @@ -405,6 +447,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainMigrate </td> @@ -414,6 +457,7 @@ updated on 2008-06-05. <td> x </td> <td> 0.3.2 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainPinVcpu </td> @@ -423,6 +467,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainReboot </td> @@ -432,6 +477,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virDomainRestore </td> @@ -441,6 +487,8 @@ updated on 2008-06-05. <td> ≥ 0.3.2 </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> + </tr> <tr> <td> virDomainResume </td> @@ -450,6 +498,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainSave </td> @@ -459,6 +508,7 @@ updated on 2008-06-05. <td> ≥ 0.3.2 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virDomainSetAutostart </td> @@ -468,6 +518,7 @@ updated on 2008-06-05. <td> ≥ 0.2.1 </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainSetMaxMemory </td> @@ -476,6 +527,7 @@ updated on 2008-06-05. <td> x </td> <td> x </td> <td> ≥ 0.3.0 </td> + <td> x </td> </tr> <tr> <td> virDomainSetMemory </td> @@ -485,6 +537,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virDomainSetSchedulerParameters </td> @@ -494,6 +547,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainSetVcpus </td> @@ -503,6 +557,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainShutdown </td> @@ -512,6 +567,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainSuspend </td> @@ -521,6 +577,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainUndefine </td> @@ -530,17 +587,18 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virGetVersion </td> <td> All </td> <td> All </td> - <td colspan="4"> Returns -1 if HV unsupported. </td> + <td colspan="5"> Returns -1 if HV unsupported. </td> </tr> <tr> <td> virInitialize </td> <td> 0.1.0 </td> - <td colspan="5"> not a HV function </td> + <td colspan="6"> not a HV function </td> </tr> <tr> <td> virDomainMemoryPeek </td> @@ -550,6 +608,7 @@ updated on 2008-06-05. <td> 0.4.3 </td> <td> x </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virNodeGetInfo </td> @@ -559,6 +618,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virNodeGetFreeMemory </td> @@ -568,6 +628,7 @@ updated on 2008-06-05. <td> x </td> <td> x </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virNodeGetCellsFreeMemory </td> @@ -577,6 +638,7 @@ updated on 2008-06-05. <td> x </td> <td> x </td> <td> x </td> + <td> x </td> </tr> </table> <h3>Network functions</h3> Abel Miguez Rodriguez ---- Distributed System Architecture Group (http://dsa-research.org) GridWay, http://www.gridway.org OpenNEbula, http://www.opennebula.org

3 2

[libvirt] libvirt 0.6.4: Confusing error message during virDomainRestore() if network not started
by Charles Duffy 01 Jul '09

01 Jul '09

Howdy, 'yall -- I found myself scratching my head for a few minutes trying to start a VM image via virDomainRestore(). Looking through the header definition in the XML, it read as follows: <interface type="network"> <mac address="00:15:3d:49:ec:0e"/> <source network="fvte-MIXED-DEFAULT"/> <target dev="vnet3"/> <model type="e1000"/> </interface> ...and on trying to do a virDomainRestore(), it exited with the following: Traceback (most recent call last): File "/usr/bin/fvte", line 8, in <module> load_entry_point('fvte==1.0', 'console_scripts', 'fvte')() File "/local/home-aux/cduffy/public_git/fvte/src/m1/fvte/cli.py", line 1838, in main cli.cmdloop() File "/opt/python25/lib/python2.5/cmd.py", line 142, in cmdloop stop = self.onecmd(line) File "/local/home-aux/cduffy/public_git/fvte/src/m1/fvte/cli.py", line 1791, in onecmd cmd.Cmd.onecmd(self, c) File "/opt/python25/lib/python2.5/cmd.py", line 219, in onecmd return func(arg) File "/local/home-aux/cduffy/public_git/fvte/src/m1/fvte/cli.py", line 1538, in do_mode self._vmm.vh_set_runmode(name, desired) File "/local/home-aux/cduffy/public_git/fvte/src/m1/fvte/vmmanip.py", line 324, in vh_set_runmode succp = (0 == virt['connect'].restore(ramfile)) File "/opt/python25/lib/python2.5/site-packages/libvirt.py", line 1224, in restore if ret == -1: raise libvirtError ('virDomainRestore() failed', conn=self) libvirt.libvirtError: internal error Failed to add tap interface 'vnet%d' to bridge 'fvtebr0' : No such device The actual issue was that the fvte-MIXED-DEFAULT network was not running, and an appropriate "virsh net-start" allowed the domain to restore correctly; detecting this condition and providing a clearer error message would probably be a Good Thing.

1 0

[libvirt] Patch to include arm variants in virsh capabilities
by C.J. Adams-Collier 01 Jul '09

01 Jul '09

Hey folks, I got an android and wanted to set up an armel debian vm to test out some code. I had to launch it directly with qemu-system-arm, though, since virsh didn't have an arm option to select. This is a patch against the debian version of the source after applying debian-specific changes. If you'd like a patch against mainline, I'd be willing to do that. http://karma.colliertech.org/~cjac/tmp/add-arm.patch Cheers, C.J.

1 0

[libvirt] While connecting through xen+ssh, virConnectClose doesn't close the connection
by Alexandru Nedelcu 01 Jul '09

01 Jul '09

Hi, I'm trying to create a Perl script with Sys::Virt (perl bindings). I'm also using Virsh for testing / experimenting, so this is in no way related to my Perl script (I mentioned it because there might be a sollution that I could use / implement). When connecting to libvirtd using a xen+ssh// connection, it connects, libvirt commands are executing, but on virsh "quit" (or when my script terminates), the connection is blocked. It bothers me because my script doesn't terminate. While running with LIBVIRT_DEBUG=1 I get the following messages: 14:30:51.086: debug : virDomainFree:1893 : domain=0x8791ff8 14:30:51.086: debug : virUnrefDomain:367 : unref domain 0x8791ff8 malcolm 1 14:30:51.086: debug : virReleaseDomain:325 : release domain 0x8791ff8 malcolm 14:30:51.087: debug : virReleaseDomain:337 : unref connection 0x87308a0 3 14:30:51.087: debug : virDomainFree:1893 : domain=0x8791f28 14:30:51.087: debug : virUnrefDomain:367 : unref domain 0x8791f28 Domain-0 1 14:30:51.087: debug : virReleaseDomain:325 : release domain 0x8791f28 Domain-0 14:30:51.087: debug : virReleaseDomain:337 : unref connection 0x87308a0 2 14:30:51.087: debug : virConnectClose:1203 : conn=0x87308a0 14:30:51.087: debug : call:6947 : Doing call 2 (nil) 14:30:51.087: debug : call:7017 : We have the buck 2 0x8796f68 0x8796f68 14:30:51.090: debug : processCallRecvLen:6605 : Got length, now need 28 total (24 more) 14:30:51.090: debug : processCalls:6873 : Giving up the buck 2 0x8796f68 (nil) 14:30:51.090: debug : call:7048 : All done with our call 2 (nil) 0x8796f68 Is this normal? Thanks,

1 0

[libvirt] PATCH : Opennebula, adding xen i686 domain capability and updating some error messages
by "Abel Míguez Rodríguez" 01 Jul '09

01 Jul '09

Hi, this patch uses "OPERATION_INVALID" error instead "OPERATION_FAILED" error where should be used, also adds a missing capability, defining Xen i686 domains. Thanks for the patches, --- one_driver.c.bak 2009-06-30 15:02:28.000000000 +0200 +++ one_driver.c 2009-06-30 15:02:29.000000000 +0200 @@ -505,7 +505,7 @@ static int oneDomainShutdown(virDomainPt ret= 0; goto return_point; } - oneError(dom->conn, dom, VIR_ERR_OPERATION_FAILED, + oneError(dom->conn, dom, VIR_ERR_OPERATION_INVALID, _("Wrong state to perform action")); goto return_point; } @@ -541,7 +541,7 @@ static int oneDomainDestroy(virDomainPtr if(c_oneCancel(vm->pid)) { /* VM not running, delete the instance at ONE DB */ if(c_oneFinalize(vm->pid)){ - oneError(dom->conn, dom, VIR_ERR_OPERATION_FAILED, + oneError(dom->conn, dom, VIR_ERR_OPERATION_INVALID, _("Wrong state to perform action")); goto return_point; } @@ -576,11 +576,11 @@ static int oneDomainSuspend(virDomainPtr ret=0; goto return_point; } - oneError(dom->conn, dom, VIR_ERR_OPERATION_FAILED, + oneError(dom->conn, dom, VIR_ERR_OPERATION_INVALID, _("Wrong state to perform action")); goto return_point; } - oneError(dom->conn,dom,VIR_ERR_OPERATION_FAILED, + oneError(dom->conn,dom,VIR_ERR_OPERATION_INVALID, _("domain is not running")); } else { oneError(dom->conn, dom, VIR_ERR_INVALID_DOMAIN, @@ -609,11 +609,11 @@ static int oneDomainResume(virDomainPtr ret=0; goto return_point; } - oneError(dom->conn, dom, VIR_ERR_OPERATION_FAILED, + oneError(dom->conn, dom, VIR_ERR_OPERATION_INVALID, _("Wrong state to perform action")); goto return_point; } - oneError(dom->conn,dom,VIR_ERR_OPERATION_FAILED, + oneError(dom->conn,dom,VIR_ERR_OPERATION_INVALID, _("domain is not paused ")); } else { oneError(dom->conn, dom, VIR_ERR_INVALID_DOMAIN, --- one_conf.c.bak 2009-06-30 15:01:06.000000000 +0200 +++ one_conf.c 2009-06-30 15:00:58.000000000 +0200 @@ -94,6 +94,27 @@ virCapsPtr oneCapsInit(void) { goto no_memory; } + if ((guest = virCapabilitiesAddGuest(caps, + "xen", + "i686", + 32, + NULL, + NULL, + 0, + NULL)) == NULL) + { + goto no_memory; + } + if (virCapabilitiesAddGuestDomain(guest, + "one", + NULL, + NULL, + 0, + NULL) == NULL) + { + goto no_memory; + } + return caps; Abel Miguez Rodriguez ---- Distributed System Architecture Group (http://dsa-research.org) GridWay, http://www.gridway.org OpenNEbula, http://www.opennebula.org

3 4

[libvirt] [PATCH] logging: remove unused level 0
by Amy Griffis 01 Jul '09

01 Jul '09

Some more logging cleanup. Remove all references to log level 0, and replace with VIR_LOG_DEBUG where appropriate. Also change any hard numbers to the corresponding VirLogPriority and add VIR_LOG_DEFAULT for the starting log level. Signed-off-by: Amy Griffis <amy.griffis(a)hp.com --- docs/logging.html.in | 6 ++---- qemud/libvirtd.conf | 5 ++--- qemud/qemud.c | 11 ++++++----- src/logging.c | 10 +++++----- src/logging.h | 2 ++ 5 files changed, 17 insertions(+), 17 deletions(-) diff --git a/docs/logging.html.in b/docs/logging.html.in index 11ea68c..fcd100f 100644 --- a/docs/logging.html.in +++ b/docs/logging.html.in @@ -49,7 +49,6 @@ <ul> <li>log_level: accepts the following values: <ul> - <li>0: no logging at all</li> <li>4: only errors</li> <li>3: warnings and errors</li> <li>2: informations, warnings and errors</li> @@ -84,20 +83,19 @@ </ul> In all cases the x prefix is the minimal level, acting as a filter: <ul> - <li>0: everything</li> <li>1: DEBUG</li> <li>2: INFO</li> <li>3: WARNING</li> <li>4: ERROR</li> </ul> Multiple output can be defined , they just need to be separated by - spaces, e.g.: <code>"3:syslog:libvirtd 0:file:/tmp/libvirt.log"</code> + spaces, e.g.: <code>"3:syslog:libvirtd 1:file:/tmp/libvirt.log"</code> will log all warnings and errors to syslog under the libvirtd ident but also log everything debugging and informations included in the file <code>/tmp/libvirt.log</code> For example setting up the following: <pre>export LIBVIRT_DEBUG=1 -export LIBVIRT_LOG_OUTPUTS="0:file:virsh.log"</pre> +export LIBVIRT_LOG_OUTPUTS="1:file:virsh.log"</pre> and then running virsh will accumulate the logs in the <code>virsh.log</code> file in a way similar to: <pre>14:29:04.771: debug : virInitialize:278 : register drivers diff --git a/qemud/libvirtd.conf b/qemud/libvirtd.conf index 1fd5918..49de466 100644 --- a/qemud/libvirtd.conf +++ b/qemud/libvirtd.conf @@ -269,7 +269,7 @@ # Logging controls # -# Logging level: 0 none, 4 errors, 3 warnings, 2 informations, 1 debug +# Logging level: 4 errors, 3 warnings, 2 informations, 1 debug # basically 1 will log everything possible #log_level = 3 @@ -303,13 +303,12 @@ # x:file:file_path # output to a file, with the given filepath # In all case the x prefix is the minimal level, acting as a filter -# 0: everything # 1: DEBUG # 2: INFO # 3: WARNING # 4: ERROR # -# Multiple output can be defined , they just need to be separated by spaces. +# Multiple output can be defined, they just need to be separated by spaces. # e.g.: # log_outputs="3:syslog:libvirtd" # to log all warnings and errors to syslog under the libvirtd ident diff --git a/qemud/qemud.c b/qemud/qemud.c index b5e3665..da20aa9 100644 --- a/qemud/qemud.c +++ b/qemud/qemud.c @@ -128,7 +128,7 @@ static int sigwrite = -1; /* Signal handler pipe */ static int ipsock = 0; /* -l Listen for TCP/IP */ /* Defaults for logging */ -static int log_level = 3; +static int log_level = VIR_LOG_DEFAULT; static char *log_filters = NULL; static char *log_outputs = NULL; @@ -2499,15 +2499,16 @@ qemudSetLogging(virConfPtr conf, const char *filename) { log_outputs = strdup(debugEnv); } if (!log_outputs) { + char *tmp = NULL; if (godaemon) { - char *tmp = NULL; if (virAsprintf (&tmp, "%d:syslog:libvirtd", log_level) < 0) goto free_and_fail; - virLogParseOutputs (tmp); - VIR_FREE (tmp); } else { - virLogParseOutputs("0:stderr:libvirtd"); + if (virAsprintf(&tmp, "%d:stderr", log_level) < 0) + goto free_and_fail; } + virLogParseOutputs(tmp); + VIR_FREE(tmp); } else { virLogParseOutputs(log_outputs); } diff --git a/src/logging.c b/src/logging.c index fd1d5d4..d13ae0f 100644 --- a/src/logging.c +++ b/src/logging.c @@ -119,7 +119,7 @@ static int virLogNbOutputs = 0; /* * Default priorities */ -static virLogPriority virLogDefaultPriority = VIR_LOG_WARN; +static virLogPriority virLogDefaultPriority = VIR_LOG_DEFAULT; static int virLogResetFilters(void); static int virLogResetOutputs(void); @@ -174,7 +174,7 @@ int virLogStartup(void) { virLogLen = 0; virLogStart = 0; virLogEnd = 0; - virLogDefaultPriority = VIR_LOG_WARN; + virLogDefaultPriority = VIR_LOG_DEFAULT; virLogUnlock(); return(0); } @@ -196,7 +196,7 @@ int virLogReset(void) { virLogLen = 0; virLogStart = 0; virLogEnd = 0; - virLogDefaultPriority = VIR_LOG_WARN; + virLogDefaultPriority = VIR_LOG_DEFAULT; virLogUnlock(); return(0); } @@ -689,7 +689,7 @@ int virLogParseOutputs(const char *outputs) { virSkipSpaces(&cur); while (*cur != 0) { prio= virParseNumber(&cur); - if ((prio < 0) || (prio > 4)) + if ((prio < VIR_LOG_DEBUG) || (prio > VIR_LOG_ERROR)) return(-1); if (*cur != ':') return(-1); @@ -770,7 +770,7 @@ int virLogParseFilters(const char *filters) { virSkipSpaces(&cur); while (*cur != 0) { prio= virParseNumber(&cur); - if ((prio < 0) || (prio > 4)) + if ((prio < VIR_LOG_DEBUG) || (prio > VIR_LOG_ERROR)) return(-1); if (*cur != ':') return(-1); diff --git a/src/logging.h b/src/logging.h index d99bb31..0b9ae79 100644 --- a/src/logging.h +++ b/src/logging.h @@ -77,6 +77,8 @@ typedef enum { VIR_LOG_ERROR, } virLogPriority; +#define VIR_LOG_DEFAULT VIR_LOG_WARN + /** * virLogOutputFunc: * @category: the category for the message

3 3

[libvirt] Upcoming 0.6.5 release and switching the main SCM engine (to git)
by Daniel Veillard 01 Jul '09

01 Jul '09

A couple of things I wanted to raise. - First we have a release 0.6.5 at the end of the week, so we are in bug fix mode, it would be good if people could make a round of testing of the latest CVS/git version or the snapshot at ftp://libvirt.org/libvirt/libvirt-cvs-snapshot.tar.gz The snapshot generation was proken in the previous months but I fixed it today. - Another point is that we use CVS as the SCM, that's historical, that's what I was used to when I created the project but clearly most people now use the git mirror (or mercurial) to generate their patches. I tried to assert how much git was prevalent, at least for patches embedded within the mail content a large majority are git generated: paphio:~/Mail -> tail -100000 libvir | grep "^diff" | wc -l 268 paphio:~/Mail -> tail -100000 libvir | grep "^diff" | grep -- '-git' | wc -l 182 that doesn't account mails which are attached and base64 encoded but I think it's reasonnable to conclude most of people sending patches generated them out of a git tree. CVS certainly show its age, too ! So my plan would be to switch out of CVS and make git the primary SCM, Jim Meyering is already maintaining the current git tree, so the plan would be to create a new main git tree on libvirt.org based on the existing git://git.et.redhat.com/libvirt.git tree, maybe fixing a couple of things in the process, and desactivate the CVS server after a couple of week grace period. I think once the decision is taken it's better to do it earlier than late, and I'm thinking that this could be done earlier next week if Jim schedule allows and there is no objection. That would allow to manage the set of patches for the following release only under git and not need an SCM transition in the course of preparing 0.6.6 (or 0.7.0). - Speaking of the following release, I'm shooting for a slightly smaller development cycle, in order to be able to push the next version in time for Fedora 12 Beta, this means a new release at the end of July, so only a bit more than a couple of weeks for pushing the changes, I really hope we will be able to include a first version of the ESX driver and Power Hyprvisor, if it's the case I think it will be worth bumping the release name to 0.7.0 . Feedback and opinions welcome, I hope git is not too uncontroversial :-) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

2 1

[libvirt] feature or bug?
by Gene Czarcinski 30 Jun '09

30 Jun '09

Yet another question. I am using the virt-manager GUI. When I begin to define a new guest and attempt to "browse" to specify where the iso image file is, the GUI dialog brings me up in my home directory. But, almost everything associated with libvirt is done as the root user. By default, why isn't the initial directory "/var/lib/libvirt/images"? Gene

2 1