- Devel - libvirt List Archives

[libvirt] preview comments
by Gene Czarcinski 09 Jul '09

09 Jul '09

I am currently running the set of "preview" packages: ------------------- libvirt.x86_64 0.6.5-1.fc11 @rawvirt libvirt-python.x86_64 0.6.5-1.fc11 @rawvirt qemu.x86_64 2:0.10.50-8.kvm87.fc11 @rawvirt qemu-common.x86_64 2:0.10.50-8.kvm87.fc11 @rawvirt qemu-img.x86_64 2:0.10.50-8.kvm87.fc11 @rawvirt qemu-kvm.x86_64 2:0.10.50-8.kvm87.fc11 @rawvirt qemu-system-arm.x86_64 2:0.10.50-8.kvm87.fc11 @rawvirt qemu-system-cris.x86_64 2:0.10.50-8.kvm87.fc11 @rawvirt qemu-system-m68k.x86_64 2:0.10.50-8.kvm87.fc11 @rawvirt qemu-system-mips.x86_64 2:0.10.50-8.kvm87.fc11 @rawvirt qemu-system-ppc.x86_64 2:0.10.50-8.kvm87.fc11 @rawvirt qemu-system-sh4.x86_64 2:0.10.50-8.kvm87.fc11 @rawvirt qemu-system-sparc.x86_64 2:0.10.50-8.kvm87.fc11 @rawvirt qemu-system-x86.x86_64 2:0.10.50-8.kvm87.fc11 @rawvirt qemu-user.x86_64 2:0.10.50-8.kvm87.fc11 @rawvirt -------------------------------------------- So far I have been very pleased! Not only does it work but it scratches my itch on how file contexts are handled ... when a guest begins to run, the context is set and when it stops, the context is restored. I notice this is not only being done for not only for ISO image files but for logical volumes also. Very good! However (you knew this was coming), I have found an undesirable characteristic (commonly called a bug) which I will be reporting to bugzilla. The problem occurs if two or more guests are sharing a file such as an ISO image file (which should be perfectly reasonable to share). The "virt_content_t" context is set when the first guest starts running and the additional guests will use that. However, when one of these guests stops running, the context is reset which will block the file from the other guests. I suspect a simply implementation was used which uses restorecon to reset the file's context when a guest stops. Unfortunately, I believe that the "fix" is going to be a lot more difficult and complex to implement. However, if it does take some time to fix, I still prefer the new way where file contexts are restored even if there is a known problem which, for right now means that for running multiple guests using the same file it is "don't do that". Gene

1 0

[libvirt] bootstrap/autogen.sh warnings/errors
by Daniel P. Berrange 09 Jul '09

09 Jul '09

Since the gnulib change, running autogen.sh prints out tonnes of warnings and results in errors during configure. This trace from RHEL-5 completes eventually, but throws errors. On Fedora 11 it won't complete configure at all, failing most header tests with errors about 'long long long', yes that's 3 longs. RHEL5: Putting files in AC_CONFIG_AUX_DIR, `build-aux'. aclocal:configure.in:12: warning: macro `AM_SILENT_RULES' not found in library aclocal:gnulib/m4/gnulib-comp.m4:189: warning: macro `AM_XGETTEXT_OPTION' not found in library configure.in:53: warning: AC_TYPE_LONG_LONG_INT is m4_require'd but is not m4_defun'd configure.in:53: AC_TYPE_LONG_LONG_INT is required by... gnulib/m4/stdint.m4:301: gl_STDINT_H is expanded from... gnulib/m4/gnulib-comp.m4:287: gl_INIT is expanded from... configure.in:53: the top level configure.in:53: warning: AC_TYPE_UNSIGNED_LONG_LONG_INT is m4_require'd but is not m4_defun'd configure.in:53: AC_TYPE_UNSIGNED_LONG_LONG_INT is required by... gnulib/m4/vasnprintf.m4:38: gl_PREREQ_PRINTF_ARGS is expanded from... gnulib/m4/vasnprintf.m4:30: gl_REPLACE_VASNPRINTF is expanded from... gnulib/m4/vasnprintf.m4:13: gl_FUNC_VASNPRINTF is expanded from... gnulib/m4/vasnprintf.m4:52: gl_PREREQ_PRINTF_PARSE is expanded from... gnulib/m4/intmax_t.m4:61: gt_AC_TYPE_INTMAX_T is expanded from... configure.in:53: gt_AC_TYPE_INTMAX_T is required by... gnulib/m4/vasnprintf.m4:65: _gl_DEFUN_ONCE([gl_PREREQ_VASNPRINTF]) is expanded from... configure.in:53: _gl_DEFUN_ONCE([gl_PREREQ_VASNPRINTF]) is required by... gnulib/m4/vasnprintf.m4:65: gl_PREREQ_VASNPRINTF is expanded from... configure.in:53: warning: AC_TYPE_LONG_LONG_INT is m4_require'd but is not m4_defun'd configure.in:53: AC_TYPE_LONG_LONG_INT is required by... gnulib/m4/stdint.m4:301: gl_STDINT_H is expanded from... gnulib/m4/gnulib-comp.m4:287: gl_INIT is expanded from... configure.in:53: the top level configure.in:53: warning: AC_TYPE_UNSIGNED_LONG_LONG_INT is m4_require'd but is not m4_defun'd configure.in:53: AC_TYPE_UNSIGNED_LONG_LONG_INT is required by... gnulib/m4/vasnprintf.m4:38: gl_PREREQ_PRINTF_ARGS is expanded from... gnulib/m4/vasnprintf.m4:30: gl_REPLACE_VASNPRINTF is expanded from... gnulib/m4/vasnprintf.m4:13: gl_FUNC_VASNPRINTF is expanded from... gnulib/m4/vasnprintf.m4:52: gl_PREREQ_PRINTF_PARSE is expanded from... gnulib/m4/intmax_t.m4:61: gt_AC_TYPE_INTMAX_T is expanded from... configure.in:53: gt_AC_TYPE_INTMAX_T is required by... gnulib/m4/vasnprintf.m4:65: _gl_DEFUN_ONCE([gl_PREREQ_VASNPRINTF]) is expanded from... configure.in:53: _gl_DEFUN_ONCE([gl_PREREQ_VASNPRINTF]) is required by... gnulib/m4/vasnprintf.m4:65: gl_PREREQ_VASNPRINTF is expanded from... configure.in:53: warning: AC_TYPE_LONG_LONG_INT is m4_require'd but is not m4_defun'd configure.in:53: AC_TYPE_LONG_LONG_INT is required by... gnulib/m4/stdint.m4:301: gl_STDINT_H is expanded from... gnulib/m4/gnulib-comp.m4:287: gl_INIT is expanded from... configure.in:53: the top level configure.in:53: warning: AC_TYPE_UNSIGNED_LONG_LONG_INT is m4_require'd but is not m4_defun'd configure.in:53: AC_TYPE_UNSIGNED_LONG_LONG_INT is required by... gnulib/m4/vasnprintf.m4:38: gl_PREREQ_PRINTF_ARGS is expanded from... gnulib/m4/vasnprintf.m4:30: gl_REPLACE_VASNPRINTF is expanded from... gnulib/m4/vasnprintf.m4:13: gl_FUNC_VASNPRINTF is expanded from... gnulib/m4/vasnprintf.m4:52: gl_PREREQ_PRINTF_PARSE is expanded from... gnulib/m4/intmax_t.m4:61: gt_AC_TYPE_INTMAX_T is expanded from... configure.in:53: gt_AC_TYPE_INTMAX_T is required by... gnulib/m4/vasnprintf.m4:65: _gl_DEFUN_ONCE([gl_PREREQ_VASNPRINTF]) is expanded from... configure.in:53: _gl_DEFUN_ONCE([gl_PREREQ_VASNPRINTF]) is required by... gnulib/m4/vasnprintf.m4:65: gl_PREREQ_VASNPRINTF is expanded from... configure.in: installing `build-aux/install-sh' configure.in: installing `build-aux/missing' docs/examples/Makefile.am: installing `build-aux/depcomp' examples/domain-events/events-c/Makefile.am: installing `build-aux/compile' src/Makefile.am:390: variable `libvirt_driver_interface_la_LDFLAGS' is defined but no program or src/Makefile.am:390: library has `libvirt_driver_interface_la' as canonic name (possible typo) Makefile.am: installing `./INSTALL' configure.in:53: warning: AC_TYPE_LONG_LONG_INT is m4_require'd but is not m4_defun'd configure.in:53: AC_TYPE_LONG_LONG_INT is required by... gnulib/m4/stdint.m4:301: gl_STDINT_H is expanded from... gnulib/m4/gnulib-comp.m4:287: gl_INIT is expanded from... configure.in:53: the top level configure.in:53: warning: AC_TYPE_UNSIGNED_LONG_LONG_INT is m4_require'd but is not m4_defun'd configure.in:53: AC_TYPE_UNSIGNED_LONG_LONG_INT is required by... gnulib/m4/vasnprintf.m4:38: gl_PREREQ_PRINTF_ARGS is expanded from... gnulib/m4/vasnprintf.m4:30: gl_REPLACE_VASNPRINTF is expanded from... gnulib/m4/vasnprintf.m4:13: gl_FUNC_VASNPRINTF is expanded from... gnulib/m4/vasnprintf.m4:52: gl_PREREQ_PRINTF_PARSE is expanded from... gnulib/m4/intmax_t.m4:61: gt_AC_TYPE_INTMAX_T is expanded from... configure.in:53: gt_AC_TYPE_INTMAX_T is required by... gnulib/m4/vasnprintf.m4:65: _gl_DEFUN_ONCE([gl_PREREQ_VASNPRINTF]) is expanded from... configure.in:53: _gl_DEFUN_ONCE([gl_PREREQ_VASNPRINTF]) is required by... gnulib/m4/vasnprintf.m4:65: gl_PREREQ_VASNPRINTF is expanded from... configure:11495: error: possibly undefined macro: AC_TYPE_LONG_LONG_INT If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. configure:11496: error: possibly undefined macro: AC_TYPE_UNSIGNED_LONG_LONG_INT checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking for gawk... gawk checking whether make sets $(MAKE)... yes checking build system type... x86_64-redhat-linux-gnu checking host system type... x86_64-redhat-linux-gnu checking for gcc... gcc checking for C compiler default output file name... a.out checking whether the C compiler works... yes checking whether we are cross compiling... no checking for suffix of executables... checking for suffix of object files... o checking whether we are using the GNU C compiler... yes checking whether gcc accepts -g... yes checking for gcc option to accept ANSI C... none needed checking for style of include used by make... GNU checking dependency style of gcc... gcc3 checking for a BSD-compatible install... /usr/bin/install -c checking how to run the C preprocessor... gcc -E checking for ranlib... ranlib checking for egrep... grep -E checking for ANSI C header files... yes checking for sys/types.h... yes checking for sys/stat.h... yes checking for stdlib.h... yes checking for string.h... yes checking for memory.h... yes checking for strings.h... yes checking for inttypes.h... yes checking for stdint.h... yes checking for unistd.h... yes checking minix/config.h usability... no checking minix/config.h presence... no checking for minix/config.h... no checking whether it is safe to define __EXTENSIONS__... yes checking for _LARGEFILE_SOURCE value needed for large files... no checking for fseeko... yes checking for working alloca.h... yes checking for alloca... yes checking arpa/inet.h usability... yes checking arpa/inet.h presence... yes checking for arpa/inet.h... yes checking sys/socket.h usability... yes checking sys/socket.h presence... yes checking for sys/socket.h... yes checking errno.h usability... yes checking errno.h presence... yes checking for errno.h... yes checking float.h usability... yes checking float.h presence... yes checking for float.h... yes checking netdb.h usability... yes checking netdb.h presence... yes checking for netdb.h... yes checking netinet/in.h usability... yes checking netinet/in.h presence... yes checking for netinet/in.h... yes checking stdio_ext.h usability... yes checking stdio_ext.h presence... yes checking for stdio_ext.h... yes checking termios.h usability... yes checking termios.h presence... yes checking for termios.h... yes checking sys/time.h usability... yes checking sys/time.h presence... yes checking for sys/time.h... yes checking sys/mman.h usability... yes checking sys/mman.h presence... yes checking for sys/mman.h... yes checking sys/ioctl.h usability... yes checking sys/ioctl.h presence... yes checking for sys/ioctl.h... yes checking sys/filio.h usability... no checking sys/filio.h presence... no checking for sys/filio.h... no checking sys/select.h usability... yes checking sys/select.h presence... yes checking for sys/select.h... yes checking for stdint.h... (cached) yes checking wchar.h usability... yes checking wchar.h presence... yes checking for wchar.h... yes checking stdio.h usability... yes checking stdio.h presence... yes checking for stdio.h... yes checking for stdlib.h... (cached) yes checking for string.h... (cached) yes checking for sys/stat.h... (cached) yes checking time.h usability... yes checking time.h presence... yes checking for time.h... yes checking for unistd.h... (cached) yes checking sys/wait.h usability... yes checking sys/wait.h presence... yes checking for sys/wait.h... yes checking whether the preprocessor supports include_next... yes checking for inline... inline checking whether <sys/socket.h> is self-contained... yes checking for shutdown... yes checking whether <sys/socket.h> defines the SHUT_* macros... yes checking for struct sockaddr_storage... yes checking for sa_family_t... yes checking for complete errno.h... yes checking whether stdin defaults to large file offsets... yes checking for library containing gethostbyname... none required checking for gethostbyname... yes checking for library containing getservbyname... none required checking for getservbyname... yes checking for C/C++ restrict keyword... __restrict checking for IPv4 sockets... yes checking for IPv6 sockets... yes checking whether getdelim is declared... yes checking whether getline is declared... yes checking whether getpass is declared... yes checking for __fsetlocking... yes checking for tcgetattr... yes checking for tcsetattr... yes checking for gettimeofday... yes checking for lstat... yes checking for mprotect... yes checking for vasnprintf... no checking whether fflush_unlocked is declared... yes checking whether flockfile is declared... yes checking whether fputs_unlocked is declared... yes checking whether funlockfile is declared... yes checking whether putc_unlocked is declared... yes checking for struct timeval... yes checking whether malloc, realloc, calloc are POSIX compliant... yes checking for mmap... yes checking for MAP_ANONYMOUS... yes checking for memchr... yes checking whether memchr works... yes checking for special C compiler options needed for large files... no checking for _FILE_OFFSET_BITS value needed for large files... no checking for _LARGE_FILES value needed for large files... no checking for external symbol _system_configuration... no checking whether <sys/select.h> is self-contained... yes checking whether snprintf is declared... yes checking for stdbool.h that conforms to C99... yes checking for _Bool... yes ./configure: line 11495: AC_TYPE_LONG_LONG_INT: command not found ./configure: line 11496: AC_TYPE_UNSIGNED_LONG_LONG_INT: command not found checking whether strdup is declared... yes checking for working strerror function... yes checking whether strndup is declared... yes checking whether strnlen is declared... yes checking whether stat file-mode macros are broken... no checking for struct timespec in <time.h>... yes ./configure: line 12443: AC_TYPE_LONG_LONG_INT: command not found checking for wchar_t... yes checking for wint_t... yes ./configure: line 12570: AC_TYPE_LONG_LONG_INT: command not found checking for size_t... yes checking for inttypes.h... yes checking for stdint.h... yes ./configure: line 12763: AC_TYPE_LONG_LONG_INT: command not found checking for intmax_t... yes ./configure: line 12847: AC_TYPE_LONG_LONG_INT: command not found checking for snprintf... yes checking for strnlen... yes checking for wcslen... yes checking for wcsnlen... yes checking for mbrtowc... yes checking for wcrtomb... yes checking whether _snprintf is declared... no checking whether ungetc works on arbitrary bytes... yes checking for alloca as a compiler built-in... yes checking for fseeko... yes configure: checking how to do getaddrinfo, freeaddrinfo and getnameinfo checking for library containing getaddrinfo... none required checking for getaddrinfo... yes checking for gai_strerror (possibly via ws2tcpip.h)... yes checking for struct sockaddr.sa_len... no checking whether getaddrinfo is declared... yes checking whether freeaddrinfo is declared... yes checking whether gai_strerror is declared... yes checking whether getnameinfo is declared... yes checking for struct addrinfo... yes checking for getdelim... yes checking for gethostname... yes checking for getline... yes checking for working getline function... yes checking for getpagesize... yes checking for getpass... yes checking for gettimeofday with POSIX signature... yes checking whether gettimeofday clobbers localtime buffer... no checking for library containing gethostbyname... (cached) none required checking for gethostbyname... (cached) yes checking for library containing inet_ntop... none required checking whether inet_ntop is declared... yes checking for inet_pton... yes checking whether inet_pton is declared... yes checking whether lseek detects pipes... yes checking whether lstat dereferences a symlink specified with a trailing slash... yes checking for working mkstemp... yes checking whether <netinet/in.h> is self-contained... yes checking for sys/pstat.h... no checking for sys/sysmp.h... no checking for sys/sysinfo.h... yes checking for machine/hal_sysinfo.h... no checking for sys/table.h... no checking for sys/param.h... yes checking for sys/sysctl.h... yes checking for sys/systemcfg.h... no checking for pstat_getstatic... no checking for pstat_getdynamic... no checking for sysmp... no checking for getsysinfo... no checking for sysctl... yes checking for table... no checking poll.h usability... yes checking poll.h presence... yes checking for poll.h... yes checking for poll... yes checking for a shell that conforms to POSIX... /bin/sh checking for random_r... yes checking whether select supports a 0 argument... yes checking for library containing getservbyname... (cached) none required checking for getservbyname... (cached) yes checking for stdint.h... (cached) yes checking for SIZE_MAX... yes checking for snprintf... (cached) yes checking whether snprintf respects a size of 1... yes checking for socklen_t... yes ./configure: line 21828: test: =: unary operator expected ./configure: line 21835: test: =: unary operator expected checking whether stdint.h conforms to C99... yes checking for random.h... no checking for struct random_data... yes checking for stpcpy... yes F11 libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, `build-aux'. libtoolize: copying file `build-aux/ltmain.sh' libtoolize: putting macros in `gnulib/m4'. libtoolize: copying file `gnulib/m4/libtool.m4' libtoolize: copying file `gnulib/m4/ltoptions.m4' libtoolize: copying file `gnulib/m4/ltsugar.m4' libtoolize: copying file `gnulib/m4/ltversion.m4' libtoolize: copying file `gnulib/m4/lt~obsolete.m4' libtoolize: Consider adding `AC_CONFIG_MACRO_DIR([m4])' to configure.in and libtoolize: rerunning libtoolize, to keep the correct libtool macros in-tree. gnulib/m4/gnulib-comp.m4:189: warning: macro `AM_XGETTEXT_OPTION' not found in library configure.in:53: warning: gl_AC_HEADER_INTTYPES_H is m4_require'd but not m4_defun'd gnulib/m4/intmax_t.m4:35: gt_AC_TYPE_INTMAX_T is expanded from... gnulib/m4/vasnprintf.m4:41: gl_PREREQ_PRINTF_PARSE is expanded from... gnulib/m4/vasnprintf.m4:15: gl_REPLACE_VASNPRINTF is expanded from... gnulib/m4/vasnprintf.m4:7: gl_FUNC_VASNPRINTF is expanded from... gnulib/m4/gnulib-comp.m4:34: gl_INIT is expanded from... configure.in:53: the top level configure.in:53: warning: gl_AC_HEADER_STDINT_H is m4_require'd but not m4_defun'd configure.in:53: warning: gl_AC_HEADER_INTTYPES_H is m4_require'd but not m4_defun'd gnulib/m4/intmax_t.m4:35: gt_AC_TYPE_INTMAX_T is expanded from... gnulib/m4/vasnprintf.m4:41: gl_PREREQ_PRINTF_PARSE is expanded from... gnulib/m4/vasnprintf.m4:15: gl_REPLACE_VASNPRINTF is expanded from... gnulib/m4/vasnprintf.m4:7: gl_FUNC_VASNPRINTF is expanded from... gnulib/m4/gnulib-comp.m4:34: gl_INIT is expanded from... configure.in:53: the top level configure.in:53: warning: gl_AC_HEADER_STDINT_H is m4_require'd but not m4_defun'd configure.in:53: warning: gl_AC_HEADER_INTTYPES_H is m4_require'd but not m4_defun'd gnulib/m4/intmax_t.m4:35: gt_AC_TYPE_INTMAX_T is expanded from... gnulib/m4/vasnprintf.m4:41: gl_PREREQ_PRINTF_PARSE is expanded from... gnulib/m4/vasnprintf.m4:15: gl_REPLACE_VASNPRINTF is expanded from... gnulib/m4/vasnprintf.m4:7: gl_FUNC_VASNPRINTF is expanded from... gnulib/m4/gnulib-comp.m4:34: gl_INIT is expanded from... configure.in:53: the top level configure.in:53: warning: gl_AC_HEADER_STDINT_H is m4_require'd but not m4_defun'd configure.in:66: installing `build-aux/compile' configure.in:14: installing `build-aux/config.guess' configure.in:14: installing `build-aux/config.sub' configure.in:8: installing `build-aux/install-sh' configure.in:8: installing `build-aux/missing' docs/examples/Makefile.am: installing `build-aux/depcomp' src/Makefile.am:390: variable `libvirt_driver_interface_la_LDFLAGS' is defined but no program or src/Makefile.am:390: library has `libvirt_driver_interface_la' as canonical name (possible typo) Makefile.am: installing `./INSTALL' configure.in:53: warning: gl_AC_HEADER_INTTYPES_H is m4_require'd but not m4_defun'd gnulib/m4/intmax_t.m4:35: gt_AC_TYPE_INTMAX_T is expanded from... gnulib/m4/vasnprintf.m4:41: gl_PREREQ_PRINTF_PARSE is expanded from... gnulib/m4/vasnprintf.m4:15: gl_REPLACE_VASNPRINTF is expanded from... gnulib/m4/vasnprintf.m4:7: gl_FUNC_VASNPRINTF is expanded from... gnulib/m4/gnulib-comp.m4:34: gl_INIT is expanded from... configure.in:53: the top level configure.in:53: warning: gl_AC_HEADER_STDINT_H is m4_require'd but not m4_defun'd configure:14195: error: possibly undefined macro: gl_AC_HEADER_INTTYPES_H If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. configure:14196: error: possibly undefined macro: gl_AC_HEADER_STDINT_H checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking for a thread-safe mkdir -p... /bin/mkdir -p checking for gawk... gawk checking whether make sets $(MAKE)... yes checking build system type... i686-pc-linux-gnu checking host system type... i686-pc-linux-gnu checking for gcc... gcc checking for C compiler default output file name... a.out checking whether the C compiler works... yes checking whether we are cross compiling... no checking for suffix of executables... checking for suffix of object files... o checking whether we are using the GNU C compiler... yes checking whether gcc accepts -g... yes checking for gcc option to accept ISO C89... none needed checking for style of include used by make... GNU checking dependency style of gcc... gcc3 checking for a BSD-compatible install... /usr/bin/install -c checking how to run the C preprocessor... gcc -E checking for ranlib... ranlib checking for grep that handles long lines and -e... /bin/grep checking for egrep... /bin/grep -E checking for ANSI C header files... yes checking for sys/types.h... yes checking for sys/stat.h... yes checking for stdlib.h... yes checking for string.h... yes checking for memory.h... yes checking for strings.h... yes checking for inttypes.h... yes checking for stdint.h... yes checking for unistd.h... yes checking minix/config.h usability... no checking minix/config.h presence... no checking for minix/config.h... no checking whether it is safe to define __EXTENSIONS__... yes checking for _LARGEFILE_SOURCE value needed for large files... no checking for working alloca.h... yes checking for alloca... yes checking arpa/inet.h usability... yes checking arpa/inet.h presence... yes checking for arpa/inet.h... yes checking sys/socket.h usability... yes checking sys/socket.h presence... yes checking for sys/socket.h... yes checking errno.h usability... yes checking errno.h presence... yes checking for errno.h... yes checking float.h usability... yes checking float.h presence... yes checking for float.h... yes checking netdb.h usability... yes checking netdb.h presence... yes checking for netdb.h... yes checking netinet/in.h usability... yes checking netinet/in.h presence... yes checking for netinet/in.h... yes checking stdio_ext.h usability... yes checking stdio_ext.h presence... yes checking for stdio_ext.h... yes checking termios.h usability... yes checking termios.h presence... yes checking for termios.h... yes checking sys/time.h usability... yes checking sys/time.h presence... yes checking for sys/time.h... yes checking sys/mman.h usability... yes checking sys/mman.h presence... yes checking for sys/mman.h... yes checking sys/ioctl.h usability... yes checking sys/ioctl.h presence... yes checking for sys/ioctl.h... yes checking sys/filio.h usability... no checking sys/filio.h presence... no checking for sys/filio.h... no checking sys/select.h usability... yes checking sys/select.h presence... yes checking for sys/select.h... yes checking for stdint.h... (cached) yes checking wchar.h usability... yes checking wchar.h presence... yes checking for wchar.h... yes checking stdio.h usability... yes checking stdio.h presence... yes checking for stdio.h... yes checking for stdlib.h... (cached) yes checking for string.h... (cached) yes checking for sys/stat.h... (cached) yes checking time.h usability... yes checking time.h presence... yes checking for time.h... yes checking for unistd.h... (cached) yes checking sys/wait.h usability... yes checking sys/wait.h presence... yes checking for sys/wait.h... yes checking whether the preprocessor supports include_next... yes checking for inline... inline checking whether <sys/socket.h> is self-contained... yes checking for shutdown... yes checking whether <sys/socket.h> defines the SHUT_* macros... yes checking for struct sockaddr_storage... yes checking for sa_family_t... yes checking for complete errno.h... yes checking whether stdin defaults to large file offsets... yes checking for library containing gethostbyname... none required checking for gethostbyname... yes checking for library containing getservbyname... none required checking for getservbyname... yes checking for C/C++ restrict keyword... __restrict checking for IPv4 sockets... yes checking for IPv6 sockets... yes checking whether getdelim is declared... yes checking whether getline is declared... yes checking whether getpass is declared... yes checking for __fsetlocking... yes checking for tcgetattr... yes checking for tcsetattr... yes checking for gettimeofday... yes checking for lstat... yes checking for mprotect... yes checking for vasnprintf... no checking whether fflush_unlocked is declared... yes checking whether flockfile is declared... yes checking whether fputs_unlocked is declared... yes checking whether funlockfile is declared... yes checking whether putc_unlocked is declared... yes checking for struct timeval... yes checking whether malloc, realloc, calloc are POSIX compliant... yes checking for mmap... yes checking for MAP_ANONYMOUS... yes checking for memchr... yes checking whether memchr works... yes checking for special C compiler options needed for large files... no checking for _FILE_OFFSET_BITS value needed for large files... 64 checking for external symbol _system_configuration... no checking whether <sys/select.h> is self-contained... yes checking whether snprintf is declared... yes checking for stdbool.h that conforms to C99... yes checking for _Bool... yes checking for long long int... yes checking for unsigned long long int... yes checking whether strdup is declared... yes checking for working strerror function... yes checking whether strndup is declared... yes checking whether strnlen is declared... yes checking whether stat file-mode macros are broken... no checking for struct timespec in <time.h>... yes checking for wchar_t... yes checking for wint_t... yes checking for size_t... yes ./configure: line 14195: gl_AC_HEADER_INTTYPES_H: command not found ./configure: line 14196: gl_AC_HEADER_STDINT_H: command not found checking for intmax_t... no checking for snprintf... yes checking for strnlen... yes checking for wcslen... yes checking for wcsnlen... yes checking for mbrtowc... yes checking for wcrtomb... yes checking whether _snprintf is declared... no checking whether ungetc works on arbitrary bytes... yes checking for alloca as a compiler built-in... yes checking for a thread-safe mkdir -p... /bin/mkdir -p checking for fseeko... yes configure: checking how to do getaddrinfo, freeaddrinfo and getnameinfo checking for library containing getaddrinfo... none required checking for getaddrinfo... no checking for getaddrinfo in ws2tcpip.h and -lws2_32... no checking for gai_strerror (possibly via ws2tcpip.h)... no checking for struct sockaddr.sa_len... no checking whether getaddrinfo is declared... no checking whether freeaddrinfo is declared... no checking whether gai_strerror is declared... no checking whether getnameinfo is declared... no checking for struct addrinfo... no checking for getdelim... yes checking for gethostname... yes checking for getline... yes checking for working getline function... yes checking for getpagesize... yes checking for getpass... yes checking for gettimeofday with POSIX signature... yes checking whether gettimeofday clobbers localtime buffer... no checking for library containing gethostbyname... (cached) none required checking for gethostbyname... (cached) yes checking for library containing inet_ntop... none required checking whether inet_ntop is declared... no checking for inet_pton... yes checking whether inet_pton is declared... no checking whether lseek detects pipes... yes checking whether lstat dereferences a symlink specified with a trailing slash... no checking for working mkstemp... no checking whether <netinet/in.h> is self-contained... no checking for netinet/in.h... (cached) yes checking for a thread-safe mkdir -p... /bin/mkdir -p checking for sys/pstat.h... no checking for sys/sysmp.h... no checking for sys/sysinfo.h... no checking for machine/hal_sysinfo.h... no checking for sys/table.h... no checking for sys/param.h... no checking for sys/sysctl.h... no checking for sys/systemcfg.h... no checking for pstat_getstatic... no checking for pstat_getdynamic... no checking for sysmp... no checking for getsysinfo... no checking for sysctl... yes checking for table... no checking poll.h usability... no checking poll.h presence... yes configure: WARNING: poll.h: present but cannot be compiled configure: WARNING: poll.h: check for missing prerequisite headers? configure: WARNING: poll.h: see the Autoconf documentation configure: WARNING: poll.h: section "Present But Cannot Be Compiled" configure: WARNING: poll.h: proceeding with the preprocessor's result configure: WARNING: poll.h: in the future, the compiler will take precedence checking for poll.h... yes checking for poll... yes checking for a shell that conforms to POSIX... /bin/sh checking for random_r... yes checking whether select supports a 0 argument... yes checking for library containing getservbyname... (cached) none required checking for getservbyname... (cached) yes checking for stdint.h... (cached) yes checking for SIZE_MAX... yes checking for snprintf... (cached) yes checking whether snprintf respects a size of 1... yes checking for socklen_t... yes checking whether stdint.h conforms to C99... no checking sys/inttypes.h usability... no checking sys/inttypes.h presence... no checking for sys/inttypes.h... no checking sys/bitypes.h usability... no checking sys/bitypes.h presence... yes configure: WARNING: sys/bitypes.h: present but cannot be compiled configure: WARNING: sys/bitypes.h: check for missing prerequisite headers? configure: WARNING: sys/bitypes.h: see the Autoconf documentation configure: WARNING: sys/bitypes.h: section "Present But Cannot Be Compiled" configure: WARNING: sys/bitypes.h: proceeding with the preprocessor's result configure: WARNING: sys/bitypes.h: in the future, the compiler will take precedence checking for sys/bitypes.h... yes checking for bit size of ptrdiff_t... 32 checking for bit size of size_t... 32 checking for bit size of sig_atomic_t... 32 checking for bit size of wchar_t... 32 checking for bit size of wint_t... 32 checking whether sig_atomic_t is signed... yes checking whether wchar_t is signed... yes checking whether wint_t is signed... no checking for ptrdiff_t integer literal suffix... checking for size_t integer literal suffix... u checking for sig_atomic_t integer literal suffix... checking for wchar_t integer literal suffix... l checking for wint_t integer literal suffix... u checking for random.h... no checking for struct random_data... yes checking for stpcpy... yes checking for strdup... yes checking for working strndup... yes checking for working strnlen... no checking for strsep... yes checking whether <sys/ioctl.h> declares ioctl... yes checking for a thread-safe mkdir -p... /bin/mkdir -p checking whether <sys/select.h> is self-contained... (cached) yes checking for a thread-safe mkdir -p... /bin/mkdir -p checking whether <sys/socket.h> is self-contained... (cached) yes checking for shutdown... (cached) yes checking whether <sys/socket.h> defines the SHUT_* macros... (cached) yes checking for struct sockaddr_storage... (cached) yes checking for sa_family_t... (cached) yes checking for a thread-safe mkdir -p... /bin/mkdir -p checking for nlink_t... yes checking for a thread-safe mkdir -p... /bin/mkdir -p checking for a thread-safe mkdir -p... /bin/mkdir -p checking whether localtime_r is compatible with its POSIX signature... yes checking for ptrdiff_t... no checking for vasprintf... yes checking whether <wchar.h> is standalone... yes checking for stdint.h... (cached) yes checking for library containing setsockopt... none needed checking for wchar_t... (cached) yes checking for wint_t... (cached) yes checking for shutdown... (cached) yes checking for gcc... (cached) gcc checking whether we are using the GNU C compiler... (cached) yes checking whether gcc accepts -g... (cached) yes checking for gcc option to accept ISO C89... (cached) none needed checking dependency style of gcc... (cached) gcc3 checking for an ANSI C-conforming const... yes checking for function prototypes... yes checking for string.h... (cached) yes checking for a sed that does not truncate output... /bin/sed checking for fgrep... /bin/grep -F checking for ld used by gcc... /usr/bin/ld checking if the linker (/usr/bin/ld) is GNU ld... yes checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B checking the name lister (/usr/bin/nm -B) interface... BSD nm checking whether ln -s works... yes checking the maximum length of command line arguments... 1966080 checking whether the shell understands some XSI constructs... yes checking whether the shell understands "+="... yes checking for /usr/bin/ld option to reload object files... -r checking for objdump... objdump checking how to recognize dependent libraries... pass_all checking for ar... ar checking for strip... strip checking for ranlib... (cached) ranlib checking command to parse /usr/bin/nm -B output from gcc object... ok checking for dlfcn.h... no checking for objdir... .libs checking if gcc supports -fno-rtti -fno-exceptions... no checking for gcc option to produce PIC... -fPIC -DPIC checking if gcc PIC flag -fPIC -DPIC works... yes checking if gcc static flag -static works... no checking if gcc supports -c -o file.o... yes checking if gcc supports -c -o file.o... (cached) yes checking whether the gcc linker (/usr/bin/ld) supports shared libraries... yes checking whether -lc should be explicitly linked in... no checking dynamic linker characteristics... GNU/Linux ld.so checking how to hardcode library paths into programs... immediate checking whether stripping libraries is possible... yes checking if libtool supports shared libraries... yes checking whether to build shared libraries... yes checking whether to build static libraries... yes checking whether gcc and cc understand -c and -o together... yes checking whether compiler accepts -Wall... yes checking whether compiler accepts -Wformat... yes checking whether compiler accepts -Wformat-security... yes checking whether compiler accepts -Wmissing-prototypes... yes checking whether compiler accepts -Wnested-externs... yes checking whether compiler accepts -Wpointer-arith... yes checking whether compiler accepts -Wextra... yes checking whether compiler accepts -Wshadow... yes checking whether compiler accepts -Wcast-align... yes checking whether compiler accepts -Wwrite-strings... yes checking whether compiler accepts -Waggregate-return... yes checking whether compiler accepts -Wstrict-prototypes... yes checking whether compiler accepts -Winline... yes checking whether compiler accepts -Wredundant-decls... yes checking whether compiler accepts -Wno-sign-compare... yes checking whether compiler accepts -Wp,-D_FORTIFY_SOURCE=2... yes checking whether compiler accepts -fexceptions... yes checking whether compiler accepts -fasynchronous-unwind-tables... yes checking whether compiler accepts -Werror... yes checking what language compliance flags to pass to the C compiler... checking whether compiler accepts -Wno-redundant-decls... yes checking for special C compiler options needed for large files... (cached) no checking for _FILE_OFFSET_BITS value needed for large files... (cached) 64 checking for cfmakeraw... yes checking for regexec... yes checking for uname... yes checking for sched_getaffinity... yes checking for getuid... yes checking for getgid... yes checking for posix_fallocate... yes checking for mmap... (cached) yes checking for readlink... yes checking for strerror_r... yes checking for strtok_r... yes checking for getmntent_r... yes checking for getgrnam_r... yes checking for getpwuid_r... yes checking pwd.h usability... no checking pwd.h presence... yes configure: WARNING: pwd.h: present but cannot be compiled configure: WARNING: pwd.h: check for missing prerequisite headers? configure: WARNING: pwd.h: see the Autoconf documentation configure: WARNING: pwd.h: section "Present But Cannot Be Compiled" configure: WARNING: pwd.h: proceeding with the preprocessor's result configure: WARNING: pwd.h: in the future, the compiler will take precedence checking for pwd.h... yes checking paths.h usability... no checking paths.h presence... yes configure: WARNING: paths.h: present but cannot be compiled configure: WARNING: paths.h: check for missing prerequisite headers? configure: WARNING: paths.h: see the Autoconf documentation configure: WARNING: paths.h: section "Present But Cannot Be Compiled" configure: WARNING: paths.h: proceeding with the preprocessor's result configure: WARNING: paths.h: in the future, the compiler will take precedence checking for paths.h... yes checking regex.h usability... no checking regex.h presence... yes configure: WARNING: regex.h: present but cannot be compiled configure: WARNING: regex.h: check for missing prerequisite headers? configure: WARNING: regex.h: see the Autoconf documentation configure: WARNING: regex.h: section "Present But Cannot Be Compiled" configure: WARNING: regex.h: proceeding with the preprocessor's result configure: WARNING: regex.h: in the future, the compiler will take precedence checking for regex.h... yes checking sys/syslimits.h usability... no checking sys/syslimits.h presence... no checking for sys/syslimits.h... no checking sys/utsname.h usability... no checking sys/utsname.h presence... yes configure: WARNING: sys/utsname.h: present but cannot be compiled configure: WARNING: sys/utsname.h: check for missing prerequisite headers? configure: WARNING: sys/utsname.h: see the Autoconf documentation configure: WARNING: sys/utsname.h: section "Present But Cannot Be Compiled" configure: WARNING: sys/utsname.h: proceeding with the preprocessor's result configure: WARNING: sys/utsname.h: in the future, the compiler will take precedence checking for sys/utsname.h... yes checking for sys/wait.h... (cached) yes checking winsock2.h usability... no checking winsock2.h presence... no checking for winsock2.h... no checking sched.h usability... no checking sched.h presence... yes configure: WARNING: sched.h: present but cannot be compiled configure: WARNING: sched.h: check for missing prerequisite headers? configure: WARNING: sched.h: see the Autoconf documentation configure: WARNING: sched.h: section "Present But Cannot Be Compiled" configure: WARNING: sched.h: proceeding with the preprocessor's result configure: WARNING: sched.h: in the future, the compiler will take precedence checking for sched.h... yes checking for termios.h... (cached) yes checking sys/poll.h usability... no checking sys/poll.h presence... yes configure: WARNING: sys/poll.h: present but cannot be compiled configure: WARNING: sys/poll.h: check for missing prerequisite headers? configure: WARNING: sys/poll.h: see the Autoconf documentation configure: WARNING: sys/poll.h: section "Present But Cannot Be Compiled" configure: WARNING: sys/poll.h: proceeding with the preprocessor's result configure: WARNING: sys/poll.h: in the future, the compiler will take precedence checking for sys/poll.h... yes checking syslog.h usability... no checking syslog.h presence... yes configure: WARNING: syslog.h: present but cannot be compiled configure: WARNING: syslog.h: check for missing prerequisite headers? configure: WARNING: syslog.h: see the Autoconf documentation configure: WARNING: syslog.h: section "Present But Cannot Be Compiled" configure: WARNING: syslog.h: proceeding with the preprocessor's result configure: WARNING: syslog.h: in the future, the compiler will take precedence checking for syslog.h... yes checking for xdrmem_create in -lportablexdr... no checking for library containing xdrmem_create... none required checking for gettext in -lintl... no checking for rpcgen... /usr/bin/rpcgen checking pthread.h usability... no checking pthread.h presence... yes configure: WARNING: pthread.h: present but cannot be compiled configure: WARNING: pthread.h: check for missing prerequisite headers? configure: WARNING: pthread.h: see the Autoconf documentation configure: WARNING: pthread.h: section "Present But Cannot Be Compiled" configure: WARNING: pthread.h: proceeding with the preprocessor's result configure: WARNING: pthread.h: in the future, the compiler will take precedence checking for pthread.h... yes checking for pthread_join in -lpthread... yes checking for rm... /bin/rm checking for mv... /bin/mv checking for tar... /bin/tar checking for xmllint... /usr/bin/xmllint checking for xmlcatalog... /usr/bin/xmlcatalog checking for xsltproc... /usr/bin/xsltproc checking for augparse... /usr/bin/augparse checking for a thread-safe mkdir -p... /bin/mkdir -p checking for dnsmasq... /usr/sbin/dnsmasq checking for brctl... /usr/sbin/brctl checking for udevadm... /sbin/udevadm checking for udevsettle... /sbin/udevsettle checking for modprobe... /sbin/modprobe checking where to write libvirtd PID file... /var/run/libvirtd.pid checking for init script flavor... redhat checking for lokkit... /usr/sbin/lokkit checking for iptables... /sbin/iptables checking for xs_read in -lxenstore... yes checking for xen/xen.h... no configure: error: Cannot find standard Xen headers. Is xen-devel installed? Config.log says configure:40254: checking for xen/xen.h configure:40277: gcc -c -g -O2 conftest.c >&5 In file included from conftest.c:192: /usr/include/stdint.h:139: error: 'long long long' is too long for GCC /usr/include/stdint.h:139: error: 'long long long' is too long for GCC Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

1 1

[libvirt] [PATCH] doc: clone+build instructions
by Jim Meyering 09 Jul '09

09 Jul '09

I realized it'd be nice to include instructions on how to build from a just-cloned repository, so copied most of this new file, README-hacking, from coreutils: >From 7ffc5ce3ebb0769c0edc9f6fa9dc25e315ffdcf3 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Wed, 8 Jul 2009 21:37:59 +0200 Subject: [PATCH] doc: clone+build instructions * README-hacking: New file. * bootstrap: Remove obsolete comments. --- README-hacking | 74 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ bootstrap | 8 +----- 2 files changed, 75 insertions(+), 7 deletions(-) create mode 100644 README-hacking diff --git a/README-hacking b/README-hacking new file mode 100644 index 0000000..3463da2 --- /dev/null +++ b/README-hacking @@ -0,0 +1,74 @@ +-*- outline -*- + +These notes intend to help people working on the checked-out sources. +These requirements do not apply when building from a distribution tarball. +See also HACKING for more detailed libvirt contribution guidelines. + +* Requirements + +We've opted to keep only the highest-level sources in the GIT repository. +This eases our maintenance burden, (fewer merges etc.), but imposes more +requirements on anyone wishing to build from the just-checked-out sources. +Note the requirements to build the released archive are much less and +are just the requirements of the standard ./configure && make procedure. +Specific development tools and versions will be checked for and listed by +the bootstrap script. See README-prereq for specific notes on obtaining +these prerequisite tools. + +Valgrind <http://valgrind.org/> is also highly recommended, if +Valgrind supports your architecture. See also README-valgrind. + +While building from a just-cloned source tree may require installing a +few prerequisites, later, a plain `git pull && make' should be sufficient. + +* First GIT checkout + +You can get a copy of the source repository like this: + + $ git clone git://libvirt.org/libvirt + $ cd libvirt + +The next step is to get and check other files needed to build, +which are extracted from other source packages: + + $ ./bootstrap + +Then run this to create e.g., Makefiles and ./configure, +and to invoke ./configure: + + $ ./autogen.sh + +And there you are! Just + + $ make + $ make check + +At this point, there should be no difference between your local copy, +and the GIT master copy: + + $ git diff + +should output no difference. + +Enjoy! + +----- + +Copyright (C) 2002-2009 Free Software Foundation, Inc. + +This program is free software: you can redistribute it and/or modify +it under the terms of the GNU General Public License as published by +the Free Software Foundation, either version 3 of the License, or +(at your option) any later version. + +This program is distributed in the hope that it will be useful, +but WITHOUT ANY WARRANTY; without even the implied warranty of +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +GNU General Public License for more details. + +You should have received a copy of the GNU General Public License +along with this program. If not, see <http://www.gnu.org/licenses/>. + +Local Variables: +indent-tabs-mode: nil +End: diff --git a/bootstrap b/bootstrap index 0754d02..8b81e0e 100755 --- a/bootstrap +++ b/bootstrap @@ -1,11 +1,5 @@ #!/bin/sh -# Run this after autogen.sh, to pull in all of the gnulib-related bits. -# It's important to run *after* autogen.sh, since it updates some of -# the same files autogen.sh does, yet those from gnulib are newer, -# and match the tests. So if a gnulib bug has been fixed since the -# snapshot taken for whatever gettext release you're using, yet you -# run "make check" against the wrong version, the corresponding unit -# test in gl-tests/ may well fail. +# Run this before autogen.sh, to pull in all of the gnulib-related bits. usage() { echo >&2 "\ -- 1.6.3.3.524.g8586b

2 6

[libvirt] the role of libvirtd
by Hugh O. Brock 08 Jul '09

08 Jul '09

Hello all. I spent quite a while yesterday in a meeting with a client interested in using libvirt for a large project. They are quite happy in general with the direction things are going. However they have objections to a couple of libvirt design points that have come up in multiple cases in the past, including in developing the other project I'm involved in, oVirt. Specifically, they would really prefer that libvirtd be a one-stop shop for everything they need to do on a virtualization host, including things we have traditionally held out-of-scope for libvirt. A partial list of those things would include: * In-depth multipath config management * Hardware lifecycle management (power-off, reboot, etc.) * HA configuration ... and pretty much anything else you might want to do on a piece of hardware that is hosting virtual machines. My initial reaction of course was to tell them "Well you should just use a separate agent for that sort of thing." But of course this means making a separate connection to the node depending on what operation you want to perform, which is cumbersome. So I guess what I'm asking is, why *not* expand the scope of libvirtd to be a one-stop shop for managing a node? Is there a really good reason it shouldn't have the remaining capabilities libvirt users want? Is that reason good enough to balance the headache our users have to deal with in coming up with a separate package to handle the tasks libvirtd does not? Slings, arrows, or thunderous applause welcome... Take care, --Hugh

4 5

[libvirt] [PATCH] use gnulib via a submodule
by Jim Meyering 08 Jul '09

08 Jul '09

Please NOTE: do not apply the changes below. They are incomplete because I've removed all the boring, repetitive parts. If you want to apply something, use this: http://meyering.net/code/tmp/libvirt-submodule.patch.bz2 For an overall summary of the process of hooking up gnulib as a submodule, see the long commit log for 5/7, below: Subject: [PATCH 5/7] make .gnulib a submodule I'm not sure all of 1/7 is welcome, but at least the silent-rules part seems in line with what people here like, considering that mylibtool does something similar. With this, you might be comfortable removing mylibtool. Jim >From 41e0b6942648065dcf00e9aee3f961297464a336 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Mon, 6 Jul 2009 19:06:00 +0200 Subject: [PATCH 1/7] configure.in: use automake-1.11 --- configure.in | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/configure.in b/configure.in index 29c8867..1170958 100644 --- a/configure.in +++ b/configure.in @@ -5,7 +5,8 @@ AC_CONFIG_SRCDIR([src/libvirt.c]) AC_CONFIG_AUX_DIR([build-aux]) AM_CONFIG_HEADER([config.h]) dnl Make automake keep quiet about wildcards & other GNUmake-isms -AM_INIT_AUTOMAKE([-Wno-portability]) +AM_INIT_AUTOMAKE([1.11 color-tests parallel-tests -Wno-portability]) +AM_SILENT_RULES([yes]) # make --enable-silent-rules the default. AC_CANONICAL_HOST LIBVIRT_MAJOR_VERSION=`echo $VERSION | awk -F. '{print $1}'` -- 1.6.3.3.524.g8586b >From d73c9fc35bdcac3c1f8b24cad226fc879325d3c2 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Mon, 6 Jul 2009 18:23:44 +0200 Subject: [PATCH 2/7] * Makefile.cfg: Rename to... * cfg.mk: ...this. New file. --- Makefile.cfg => cfg.mk | 0 1 files changed, 0 insertions(+), 0 deletions(-) rename Makefile.cfg => cfg.mk (100%) diff --git a/Makefile.cfg b/cfg.mk similarity index 100% rename from Makefile.cfg rename to cfg.mk -- 1.6.3.3.524.g8586b >From 1cacbc7f4c883f763606e0bed36bd8d149add0d9 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Mon, 6 Jul 2009 18:28:10 +0200 Subject: [PATCH 3/7] Prepare to use maint.mk from gnulib Since Makefile.maint will soon come from gnulib's maint.mk, sync Makefile.maint to have the same contents (modulo minor things). In syncing it, we have to remove some libvirt-specific rules. Since we want to keep them (of course), put those in cfg.mk. * Makefile.maint: Merge from gnulib's maint.mk. * cfg.mk (sc_avoid_write): New rule. From Makefile.cfg. (sc_prohibit_strcmp_and_strncmp): Likewise, and rename. (sc_prohibit_asprintf, sc_prohibit_VIR_ERR_NO_MEMORY): Likewise. (sc_prohibit_nonreentrant): Likewise. (sc_prohibit_ctype_h): Likewise. (sc_TAB_in_indentation, sc_avoid_ctype_macros): Likewise. (sc_prohibit_virBufferAdd_with_string_literal): Likewise. (sc_prohibit_gethostby): Likewise. (sc_libvirt_unmarked_diagnostics): Likewise. Also, rename the rule, inserting "_libvirt", since this rule is a specialization of the one in gnulib. * GNUmakefile: Include cfg.mk, not Makefile.cfg * .x-sc_prohibit_strcmp_and_strncmp: New file. * Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp_and_strncmp . --- .x-sc_prohibit_strcmp_and_strncmp | 1 + GNUmakefile | 4 +- Makefile.am | 1 + Makefile.maint | 734 +++++++++++++++++-------------------- cfg.mk | 163 ++++++++ 5 files changed, 505 insertions(+), 398 deletions(-) create mode 100644 .x-sc_prohibit_strcmp_and_strncmp diff --git a/.x-sc_prohibit_strcmp_and_strncmp b/.x-sc_prohibit_strcmp_and_strncmp new file mode 100644 index 0000000..b7c456e --- /dev/null +++ b/.x-sc_prohibit_strcmp_and_strncmp @@ -0,0 +1 @@ +^gnulib/ diff --git a/GNUmakefile b/GNUmakefile index 157f432..e6d4178 100644 --- a/GNUmakefile +++ b/GNUmakefile @@ -40,7 +40,7 @@ export TAR_OPTIONS = --owner=0 --group=0 --numeric-owner include Makefile -include $(srcdir)/Makefile.cfg +include $(srcdir)/cfg.mk include $(srcdir)/Makefile.maint else diff --git a/Makefile.am b/Makefile.am index 681034a..dd98ff2 100644 --- a/Makefile.am +++ b/Makefile.am @@ -16,6 +16,7 @@ EXTRA_DIST = \ .x-sc_avoid_if_before_free \ .x-sc_require_config_h_first \ .x-sc_prohibit_strcmp \ + .x-sc_prohibit_strcmp_and_strncmp \ .x-sc_require_config_h \ .x-sc_prohibit_nonreentrant \ Makefile.nonreentrant \ ... -- 1.6.3.3.524.g8586b >From a4b10833246264377c9c0c99a0178c3e9b6af0f7 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Mon, 6 Jul 2009 19:17:06 +0200 Subject: [PATCH 4/7] skip some of gnulib's new rules * cfg.mk (local-checks-to-skip): Add these: sc_error_message_uppercase, sc_program_name, sc_require_test_exit_idiom, sc_makefile_check. --- cfg.mk | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/cfg.mk b/cfg.mk index 3c9feb6..35bedd1 100644 --- a/cfg.mk +++ b/cfg.mk @@ -52,6 +52,10 @@ local-checks-to-skip = \ sc_system_h_headers \ sc_tight_scope \ sc_two_space_separator_in_usage \ + sc_error_message_uppercase \ + sc_program_name \ + sc_require_test_exit_idiom \ + sc_makefile_check \ sc_useless_cpp_parens useless_free_options = \ -- 1.6.3.3.524.g8586b >From 856172836da7f639323702aff67489e9a74d47d5 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Tue, 7 Jul 2009 11:22:52 +0200 Subject: [PATCH 5/7] make .gnulib a submodule This makes it so we record (via a git submodule) a snapshot of whatever version of gnulib we're using, and none of gnulib sources are in the libvirt repository. The result is that we have as much reproducibility as when we version-controlled imported copies of the gnulib sources, but without the hassle of the manual process we used when syncing with upstream. Note that when you clone libvirt, you get only the libvirt repository, but when you first run ./bootstrap, it clones gnulib (at the SHA1 recorded via the submodule), creating the .gnulib/ hierarchy. Then, the bootstrap script runs gnulib-tool to populate gnulib/ with the files that make up the selected modules. Put the following in your ~/.gitconfig file. [alias] syncsub = submodule foreach git pull origin master The update procedure is simple: git syncsub ...build & test... git commit -m 'gnulib: sync submodule to latest' .gnulib * .gitmodules: New file. * .gnulib: Initialize. * bootstrap: Set up to use the new submodule. Stop using --no-vc-files. Don't remove .gitignore files. Don't use or create .cvsignore. Diagnose an invalid --gnulib-srcdir=DIR argument. * build-aux/vc-list-files: Delete file, now pulled from gnulib. * build-aux/useless-if-before-free: Likewise. * po/POTFILES.in: Remove gnulib/lib/gai_strerror.c, since it no longer contains translatable strings. * gnulib/*: Remove gnulib/ hierarchy. --- .gitignore | 1 + .gitmodules | 3 + .gnulib | 1 + bootstrap | 45 +- build-aux/useless-if-before-free | 180 -- build-aux/vc-list-files | 107 - gnulib/lib/.cvsignore | 26 - gnulib/lib/.gitignore | 26 - gnulib/lib/Makefile.am | 1241 -------- gnulib/lib/alloca.c | 489 ---- gnulib/lib/alloca.in.h | 56 - gnulib/lib/arpa/.cvsignore | 1 - gnulib/lib/arpa/.gitignore | 1 - gnulib/lib/arpa_inet.in.h | 90 - ... diff --git a/.gitignore b/.gitignore index ca73a98..964580c 100644 --- a/.gitignore +++ b/.gitignore @@ -34,3 +34,4 @@ stamp-h stamp-h.in stamp-h1 update.log +tests/*.log diff --git a/.gitmodules b/.gitmodules new file mode 100644 index 0000000..7acb1ea --- /dev/null +++ b/.gitmodules @@ -0,0 +1,3 @@ +[submodule "gnulib"] + path = .gnulib + url = git://git.sv.gnu.org/gnulib.git diff --git a/.gnulib b/.gnulib new file mode 160000 index 0000000..1203e8d --- /dev/null +++ b/.gnulib @@ -0,0 +1 @@ +Subproject commit 1203e8d1f62dec3d2436dffadd5c20793cf84366 diff --git a/bootstrap b/bootstrap index baf52e7..7ce28da 100755 --- a/bootstrap +++ b/bootstrap @@ -40,25 +40,31 @@ do esac done -cleanup_gnulib() { - st=$? - rm -fr .gnulib - exit $st -} +# Get gnulib files. case ${GNULIB_SRCDIR--} in -) - if [ ! -d .gnulib ]; then + echo "$0: getting gnulib files..." + git submodule init || exit $? + git submodule update || exit $? + GNULIB_SRCDIR=.gnulib + ;; +*) + # Redirect the gnulib submodule to the directory on the command line + # if possible. + if test -d "$GNULIB_SRCDIR"/.git && \ + git config --file .gitmodules submodule.gnulib.url >/dev/null; then + git submodule init + GNULIB_SRCDIR=`cd $GNULIB_SRCDIR && pwd` + git config --replace-all submodule.gnulib.url $GNULIB_SRCDIR echo "$0: getting gnulib files..." - - trap cleanup_gnulib 1 2 13 15 - - git clone --depth 1 git://git.sv.gnu.org/gnulib .gnulib || - cleanup_gnulib - - trap - 1 2 13 15 + git submodule update || exit $? + GNULIB_SRCDIR=.gnulib + else + echo >&2 "$0: invalid gnulib srcdir: $GNULIB_SRCDIR" + exit 1 fi - GNULIB_SRCDIR=.gnulib + ;; esac gnulib_tool=$GNULIB_SRCDIR/gnulib-tool @@ -103,20 +109,9 @@ vc-list-files # put *.[ch] files in new gnulib/lib/ dir. $gnulib_tool \ - --no-vc-files \ --lgpl=2 \ --with-tests \ --m4-base=gnulib/m4 \ --source-base=gnulib/lib \ --tests-base=gnulib/tests \ --import $modules - -rm -f \ - .gitignore \ - gnulib/lib/.gitignore \ - gnulib/m4/.gitignore \ - gnulib/tests/.gitignore - -(cd gnulib/lib && - (cat .cvsignore; \ - ls -1 *.in.h|sed 's/\.in\.h/.h/') | sort -u > .t; mv .t .cvsignore) diff --git a/po/POTFILES.in b/po/POTFILES.in index 973f580..357cd70 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -1,4 +1,3 @@ -gnulib/lib/gai_strerror.c qemud/qemud.c qemud/remote.c src/bridge.c ... -- 1.6.3.3.524.g8586b >From ab811737a6914133bf12a46d4c5b5a2a2bdd9ee9 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Tue, 7 Jul 2009 12:05:18 +0200 Subject: [PATCH 6/7] remove all .cvsignore files --- .cvsignore | 34 ------------------------- build-aux/.cvsignore | 10 ------- build-aux/.gitignore | 2 + docs/.cvsignore | 4 --- docs/devhelp/.cvsignore | 3 -- docs/examples/.cvsignore | 7 ----- docs/examples/python/.cvsignore | 2 - docs/schemas/.cvsignore | 2 - examples/domain-events/events-c/.cvsignore | 6 ---- examples/hellolibvirt/.cvsignore | 5 ---- include/.cvsignore | 2 - include/libvirt/.cvsignore | 2 - m4/.cvsignore | 37 ---------------------------- po/.cvsignore | 15 ----------- proxy/.cvsignore | 5 ---- python/.cvsignore | 15 ----------- python/tests/.cvsignore | 2 - qemud/.cvsignore | 12 --------- src/.cvsignore | 20 --------------- tests/.cvsignore | 28 --------------------- tests/confdata/.cvsignore | 2 - tests/sexpr2xmldata/.cvsignore | 2 - tests/xencapsdata/.cvsignore | 2 - tests/xmconfigdata/.cvsignore | 2 - tests/xml2sexprdata/.cvsignore | 2 - tools/.cvsignore | 4 --- 26 files changed, 2 insertions(+), 225 deletions(-) ... -- 1.6.3.3.524.g8586b >From b718b0763f8fbfc35af586fa6d132d39259d0e11 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Tue, 7 Jul 2009 18:08:45 +0200 Subject: [PATCH 7/7] use gnumakefile and maintainer-makefile modules from gnulib * bootstrap (modules): Add gnumakefile and maintainer-makefile. * GNUmakefile: Remove file, now provided by gnulib. * Makefile.maint: Remove. Replaced by maint.mk from gnulib. .gitignore: Add GNUmakefile and maint.mk. * cfg.mk (prev_version_file): Disable this feature. Setting this to /dev/null avoids an otherwise harmless diagnostic. --- .gitignore | 2 + GNUmakefile | 60 ----- Makefile.maint | 770 -------------------------------------------------------- bootstrap | 2 + cfg.mk | 3 + 5 files changed, 7 insertions(+), 830 deletions(-) delete mode 100644 GNUmakefile delete mode 100644 Makefile.maint ... diff --git a/bootstrap b/bootstrap index 7ce28da..b0de3df 100755 --- a/bootstrap +++ b/bootstrap @@ -78,8 +78,10 @@ getaddrinfo gethostname getpass gettext +gnumakefile inet_pton ioctl +maintainer-makefile mkstemp mktempd perror diff --git a/cfg.mk b/cfg.mk index 35bedd1..736f7c0 100644 --- a/cfg.mk +++ b/cfg.mk @@ -227,3 +227,6 @@ sc_libvirt_unmarked_diagnostics: | grep '[ ]"' && \ { echo '$(ME): found unmarked diagnostic(s)' 1>&2; \ exit 1; } || : + +# We don't use this feature of maint.mk. +prev_version_file = /dev/null -- 1.6.3.3.524.g8586b

3 13

[libvirt] turn off dnsmasq
by Mike Power 08 Jul '09

08 Jul '09

I have a series of kvm vms I am running via libvirt. I have bind9 and dhcp3-server installed and I am happy with their configuration. The problem I have is that dhcp3-server and dnsmasq are currently fighting over who hands out the ip address. My vms work when they get their ip from dhcp3-server, and they fail when dnsmasq hands out the ip address. Unfortunately I can not get dnsmasq to stop handing out ip addresses. This is the configuration of my default network: <network> <name>default</name> <bridge name="virbr%d" /> <forward/> <ip address="192.168.122.1" netmask="255.255.255.0"> </ip> </network> Notice in the ip tag the optional dhcp tag is missing. Thus dnsmasq I thought, was supposed to leave well enough alone. It doesn't. I can turn off dhcp3-server and start up a host. What I see in the syslog is: Jul 7 08:52:21 vmhost dnsmasq[3420]: DHCPREQUEST(virbr0) 192.168.122.244 52:54:00:8f:7c:a4 Jul 7 08:52:21 vmhost dnsmasq[3420]: DHCPACK(virbr0) 192.168.122.244 52:54:00:8f:7c:a4 host1000 Then when I run ifconfig on the host1000 vm, it has an ip address that it obviously got from dnsmasq. I just need dnsmasq to stop handing out IPs, how do I do that? Mike Power

2 1

[libvirt] [PATCH 3/4] fix another failing "make distcheck" (qemuhelptest)
by Jim Meyering 08 Jul '09

08 Jul '09

This fixes another "make distcheck" (or non-srcdir) build failure: >From f9523d014a590fb881c14397f8c3869f328d023c Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Wed, 8 Jul 2009 08:35:24 +0200 Subject: [PATCH 3/4] fix another failing "make distcheck" (qemuhelptest) It failed in a non-srcdir build because those 5 sample output files were not included in the distribution tarball. Include them. * tests/Makefile.am (qemuhelpdata, EXTRA_DIST): Include these: kvm-74, kvm-86, qemu-0.10.5, qemu-0.9.1, qemu-kvm-0.10.5. --- tests/Makefile.am | 10 +++++++++- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 3d98d69..f8bde34 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -36,6 +36,13 @@ LDADDS = \ $(LIBSOCKET) \ $(COVERAGE_LDFLAGS) +qemuhelpdata = \ + kvm-74 \ + kvm-86 \ + qemu-0.10.5 \ + qemu-0.9.1 \ + qemu-kvm-0.10.5 + EXTRA_DIST = \ oomtrace.pl \ test-lib.sh \ @@ -51,7 +58,8 @@ EXTRA_DIST = \ storagevolschematest \ storagevolschemadata \ nodedevschematest \ - nodedevschemadata + nodedevschemadata \ + $(patsubst %,qemuhelpdata/%,$(qemuhelpdata)) noinst_PROGRAMS = virshtest conftest \ nodeinfotest statstest qparamtest -- 1.6.3.3.524.g8586b

3 4

[libvirt] [PATCH 4/4] generate ChangeLog from git logs into distribution tarball
by Jim Meyering 08 Jul '09

08 Jul '09

This is what I started out working on, before I noticed the "make distcheck" failures. >From 9fd0624b8cee33b8c725464d289cc5ce33ffc1c3 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Wed, 8 Jul 2009 08:54:25 +0200 Subject: [PATCH 4/4] generate ChangeLog from git logs into distribution tarball No longer maintain a version-controlled ChangeLog file, but do continue to include a ChangeLog file in distribution tarball. * Makefile.am (gen-ChangeLog): New rule. (dist-hook): Depend on it. (EXTRA_DIST): Add ChangeLog-old. * bootstrap (modules): Add gitlog-to-changelog. * ChangeLog: Remove file. Renamed to... * ChangeLog-old: ...this. New file. * autogen.sh: Touch ChangeLog, to ensure it exists. For automake. --- ChangeLog => ChangeLog-old | 2 +- Makefile.am | 15 +++++++++++++++ autogen.sh | 3 +++ bootstrap | 1 + build-aux/.gitignore | 1 + 5 files changed, 21 insertions(+), 1 deletions(-) rename ChangeLog => ChangeLog-old (99%) diff --git a/ChangeLog b/ChangeLog-old similarity index 99% rename from ChangeLog rename to ChangeLog-old index b266de6..c3b41e2 100644 --- a/ChangeLog +++ b/ChangeLog-old @@ -1207,7 +1207,7 @@ Fri Apr 24 13:17:47 BST 2009 Daniel P. Berrange <berrange(a)redhat.com> Fix network config in XM driver * src/xm_internal.c: Fix setting of bridge & script parameters in VIF config - * src/xend_internal.h, src/xend_internal.c: Export the + * src/xend_internal.h, src/xend_internal.c: Export the default bridge script name to XM driver * tests/xmconfigdata/*: Update to take account of script= setting in VIF config diff --git a/Makefile.am b/Makefile.am index c251f96..f9efff5 100644 --- a/Makefile.am +++ b/Makefile.am @@ -9,6 +9,7 @@ SUBDIRS = gnulib/lib include src qemud tools proxy docs gnulib/tests \ ACLOCAL_AMFLAGS = -I m4 -I gnulib/m4 EXTRA_DIST = \ + ChangeLog-old \ libvirt.spec libvirt.spec.in \ mingw32-libvirt.spec.in \ libvirt.pc libvirt.pc.in \ @@ -49,3 +50,17 @@ clean-cov: # disable this check distuninstallcheck: + +dist-hook: gen-ChangeLog + +# Generate the ChangeLog file (with all entries since the switch to git) +# and insert it into the directory we're about to use to create a tarball. +gen_start_date = 2009-07-04 +.PHONY: gen-ChangeLog +gen-ChangeLog: + if test -d .git; then \ + $(top_srcdir)/build-aux/gitlog-to-changelog \ + --since=$(gen_start_date) > $(distdir)/cl-t; \ + rm -f $(distdir)/ChangeLog; \ + mv $(distdir)/cl-t $(distdir)/ChangeLog; \ + fi diff --git a/autogen.sh b/autogen.sh index 788729f..c026112 100755 --- a/autogen.sh +++ b/autogen.sh @@ -54,6 +54,9 @@ if test -z "$*"; then echo "to pass any to it, please specify them on the $0 command line." fi +# Automake requires that ChangeLog exist. +touch ChangeLog + autopoint --force #rm -rf m4 libtoolize --copy --force diff --git a/bootstrap b/bootstrap index b0de3df..0754d02 100755 --- a/bootstrap +++ b/bootstrap @@ -78,6 +78,7 @@ getaddrinfo gethostname getpass gettext +gitlog-to-changelog gnumakefile inet_pton ioctl diff --git a/build-aux/.gitignore b/build-aux/.gitignore index af6c366..62188c1 100644 --- a/build-aux/.gitignore +++ b/build-aux/.gitignore @@ -10,3 +10,4 @@ mkinstalldirs mktempd /useless-if-before-free /vc-list-files +/gitlog-to-changelog -- 1.6.3.3.524.g8586b

3 3

[libvirt] netcf error message...
by Shahar Klein 08 Jul '09

08 Jul '09

folowing the instructions in netcf I'm trying to run some basic interface configuration via libvirt patched with the netcf patches I get error messages - but the interface(eth1) seem to be managed correctly - do I have an aug(what is that?) problem? virsh # iface-define /root/libvirt_working/eth1.xml error: Failed to define interface from /root/libvirt_working/eth1.xml error: internal error could not get interface XML description (netcf: unspecified error - aug_save failed) virsh # iface-list Name State MAC Address -------------------------------------------- eth0 active 00:18:fe:28:7d:82 lo active 00:00:00:00:00:00 virsh # iface-start eth1 Interface eth1 started virsh # iface-list Name State MAC Address -------------------------------------------- eth0 active 00:18:fe:28:7d:82 eth1 active 00:18:fe:28:7d:83 lo active 00:00:00:00:00:00

1 0

[libvirt] kernel summit topic - 'containers end-game'
by Serge E. Hallyn 08 Jul '09

08 Jul '09

A topic on ksummit agenda is 'containers end-game and how do we get there'. So for starters, looking just at application (and system) containers, what do the libvirt and liblxc projects want to see in kernel support that is currently missing? Are there specific things that should be done soon to make containers more useful and usable? More generally, the topic raises the question... what 'end-games' are there? A few I can think of off-hand include: 1. resource control 2. lightweight virtual servers 3. (or 2.5) unprivileged containers/jail-on-steroids (lightweight virtual servers in which you might, just maybe, almost, be able to give away a root account, at least as much as you could do so with a kvm/qemu/xen partition) 4. checkpoint, restart, and migration For each end-game, what kernel pieces do we think are missing? For instance, people seem agreed that resource control needs io control :) Containers imo need a user namespace. I think there are quite a few network namespace exploiters who require sysfs directory tagging (or some equivalent) to allow us to migrate physical devices into network namespaces. And checkpoint/restart needs... checkpoint/restart. thanks, -serge

5 14

[libvirt] PATCH: Fix LXC container capabilities
by Daniel P. Berrange 08 Jul '09

08 Jul '09

My previous change to LXC container capabilties setup has a fairly stupid bug in it. The container init process starts off with no capabilities whatsoever :-( This was caused by a bogus capng_lock() call which meant that all capabilities were cleared when the init process was exec'd. The capng_lock call sets NOROOT & NROOT_LOCKED flags in the process secure bits. This is not neccessary for the init process - we have reduced the bounding set which is sufficient for our security goals. With the capng_lock() call removed, the init process gets its permitted and effective sets filled to match the bounding set which is the desired scenario. Daniel diff --git a/src/lxc_container.c b/src/lxc_container.c index 950dd50..b3978df 100644 --- a/src/lxc_container.c +++ b/src/lxc_container.c @@ -675,16 +675,9 @@ static int lxcContainerDropCapabilities(void) _("failed to apply capabilities: %d"), ret); return -1; } - - /* Need to prevent them regaining any caps on exec */ - if ((ret = capng_lock()) < 0) { - lxcError(NULL, NULL, VIR_ERR_INTERNAL_ERROR, - _("failed to lock capabilities: %d"), ret); - return -1; - } - #else - VIR_WARN0(_("libcap-ng support not compiled in, unable to clear capabilities")); + /* Don't warn, since this ends up going to the guest console and annoying admins + VIR_WARN0(_("libcap-ng support not compiled in, unable to clear capabilities")); */ #endif return 0; } -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 1

[libvirt] Cannot get network to work with LXC
by James Yu 08 Jul '09

08 Jul '09

Hi all, I tried to use the first xml config in http://libvirt.org/drvlxc.html to setup my first light weight container. However, I was unable to get the container's network to work. When I tried to give the interface an IP, I got the following error message: sh-4.0# /sbin/ifconfig veth1 192.168.0.1/24 SIOCSIFADDR: Permission denied SIOCSIFNETMASK: Permission denied SIOCGIFADDR: Cannot assign requested address SIOCSIFBROADCAST: Permission denied SIOCSIFFLAGS: Permission denied sh-4.0# Any advise ? This is a UTF-8 formatted mail ----------------------------------------------- James C.-C.Yu

3 2

[libvirt] PATCH: Video device config
by Tom Hughes 08 Jul '09

08 Jul '09

I recently posted a patch on the RedHat bugzilla (bug #467038) to add a model attribute to the graphics element so that the different graphics cards supported by QEMU could be selected. Apparently that approach has been rejected in the past however, and the preferred approach is to add a separate video element. I've taken the patch that Daniel Berrange posted here a few months ago that added the necessary XML handling for the new element and extended it by filling in the QEMU driver code to make it use the model details as well as fixing the default video model for XEN domains as per the list of outstanding issues given with the original patch. The updated patch is attached, and based on the list of outstanding tasks given before what remains to be done is: - Add RNG XML schemas & website docs - Make Xen drivers use this info for setting stdvga=1|0 config arg - Make VirtualBox use this info in whatever way it needs Tom -- Tom Hughes (tom(a)compton.nu) http://www.compton.nu/

3 3

[libvirt] [PATCH 2/4] fix failing "make distcheck"
by Jim Meyering 08 Jul '09

08 Jul '09

Make distcheck would fail without this: >From e2f91000a33168d2aaac89f94f1b11c633c579f0 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Wed, 8 Jul 2009 08:15:54 +0200 Subject: [PATCH 2/4] fix failing "make distcheck" * docs/Makefile.am (xml): Distribute testpool.xml and testvol.xml, which are referenced from testnode.xml. --- docs/Makefile.am | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index 43d04c3..4bdb827 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -55,7 +55,9 @@ xml = \ testdomfv0.xml \ testnetdef.xml \ testnetpriv.xml \ - testnode.xml + testnode.xml \ + testpool.xml \ + testvol.xml fig = \ libvirt-net-logical.fig \ -- 1.6.3.3.524.g8586b

3 2

[libvirt] [PATCH 1/4] Don't use mylibtool, (subsumed by automake's silent rules)
by Jim Meyering 08 Jul '09

08 Jul '09

Its use was causing a non-srcdir build to fail. * Makefile.am (EXTRA_DIST): Remove mylibtool. * configure.in: Don't use mylibtool. --- An alternative (if you don't want to use automake's silent-rules option) would be to keep mylibtool, but to use $(abs_top_srcdir) rather than $(top_srcdir) in that script. Makefile.am | 3 +-- configure.in | 4 ---- 2 files changed, 1 insertions(+), 6 deletions(-) diff --git a/Makefile.am b/Makefile.am index dd98ff2..c251f96 100644 --- a/Makefile.am +++ b/Makefile.am @@ -20,8 +20,7 @@ EXTRA_DIST = \ .x-sc_require_config_h \ .x-sc_prohibit_nonreentrant \ Makefile.nonreentrant \ - autogen.sh \ - mylibtool + autogen.sh man_MANS = virsh.1 diff --git a/configure.in b/configure.in index 1170958..a6f6754 100644 --- a/configure.in +++ b/configure.in @@ -59,10 +59,6 @@ dnl Support building Win32 DLLs (must appear *before* AM_PROG_LIBTOOL) AC_LIBTOOL_WIN32_DLL AM_PROG_LIBTOOL -dnl Override normal libtool in favour of our quiet version -LIBTOOL='$(SHELL) $(top_srcdir)/mylibtool' -AC_SUBST([LIBTOOL]) - AM_PROG_CC_C_O VERSION_SCRIPT_FLAGS=-Wl,--version-script= -- 1.6.3.3.524.g8586b

2 4

[libvirt] PATCH 2/2: Support <video> element in QEMU driver
by Daniel P. Berrange 08 Jul '09

08 Jul '09

This patch extends the QEMU driver to support the <video> element for configuring the type of video adapter exposed to the guest. It implements the XML -> ARGV and ARGV -> XML conversions, so both import & export work. Some of the existing tests are updated to use the <video> element to get test coverage. The QEMU help parsing test is changed to use symbolic constants instead of black magic hex constants. This supports both old -std-vga and new -vga style QEMU args. Daniel From: Daniel P. Berrange <berrange(a)redhat.com> Date: Mon, 6 Jul 2009 14:59:19 +0100 Subject: [PATCH 2/3] Support <video> element for QEMU guests * src/qemu_conf.c, src/qemu_conf.h: Use -vga or -std-vga when starting guests if video card is present * tests/qemuhelptest.c: Change to use constants instead of hardcoded hex numbers, and add VGA support * tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl-fullscreen.xml, tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.args, tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.xml, tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.args, tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.xml, tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-tls.xml, tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc.xml, tests/qemuxml2argvdata/qemuxml2argv-input-xen.xml: Add <video> element for testing graphics adapter * tests/qemuxml2argvtest.c: Add QEMUD_CMD_FLAG_VGA flag * tests/qemuxml2xmltest.c: Add missing graphics-vnc-sasl/tls tests --- src/qemu_conf.c | 89 ++++++++++++++++++++ src/qemu_conf.h | 1 + tests/qemuhelptest.c | 66 +++++++++++++- .../qemuxml2argv-graphics-sdl-fullscreen.xml | 3 + .../qemuxml2argv-graphics-sdl.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-graphics-sdl.xml | 3 + .../qemuxml2argv-graphics-vnc-sasl.args | 2 +- .../qemuxml2argv-graphics-vnc-sasl.xml | 3 + .../qemuxml2argv-graphics-vnc-tls.xml | 3 + .../qemuxml2argvdata/qemuxml2argv-graphics-vnc.xml | 3 + tests/qemuxml2argvdata/qemuxml2argv-input-xen.xml | 3 + tests/qemuxml2argvtest.c | 2 +- tests/qemuxml2xmltest.c | 2 + 13 files changed, 174 insertions(+), 8 deletions(-) diff --git a/src/qemu_conf.c b/src/qemu_conf.c index 9ca60b9..6337045 100644 --- a/src/qemu_conf.c +++ b/src/qemu_conf.c @@ -78,6 +78,15 @@ VIR_ENUM_IMPL(qemuDiskCacheV2, VIR_DOMAIN_DISK_CACHE_LAST, "writethrough", "writeback"); +VIR_ENUM_DECL(qemuVideo) + +VIR_ENUM_IMPL(qemuVideo, VIR_DOMAIN_VIDEO_TYPE_LAST, + "std", + "cirrus", + "vmware", + NULL, /* no arg needed for xen */ + NULL /* don't support vbox */); + int qemudLoadDriverConfig(struct qemud_driver *driver, const char *filename) { @@ -455,6 +464,8 @@ static unsigned int qemudComputeCmdFlags(const char *help, if (strstr(help, "format=")) flags |= QEMUD_CMD_FLAG_DRIVE_FORMAT; } + if (strstr(help, "-vga") && !strstr(help, "-std-vga")) + flags |= QEMUD_CMD_FLAG_VGA; if (strstr(help, "boot=on")) flags |= QEMUD_CMD_FLAG_DRIVE_BOOT; if (version >= 9000) @@ -1533,6 +1544,53 @@ int qemudBuildCommandLine(virConnectPtr conn, ADD_ARG_LIT("-full-screen"); } + if (def->nvideos) { + if (def->nvideos > 1) { + qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, + "%s", _("only one video card is currentely supported")); + goto error; + } + + if (qemuCmdFlags & QEMUD_CMD_FLAG_VGA) { + if (def->videos[0]->type == VIR_DOMAIN_VIDEO_TYPE_XEN) { + /* nothing - vga has no effect on Xen pvfb */ + } else { + const char *vgastr = qemuVideoTypeToString(def->videos[0]->type); + if (!vgastr) { + qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, + _("video type %s is not supported with QEMU"), + virDomainVideoTypeToString(def->videos[0]->type)); + goto error; + } + + ADD_ARG_LIT("-vga"); + ADD_ARG_LIT(vgastr); + } + } else { + + switch (def->videos[0]->type) { + case VIR_DOMAIN_VIDEO_TYPE_VGA: + ADD_ARG_LIT("-std-vga"); + break; + + case VIR_DOMAIN_VIDEO_TYPE_VMVGA: + ADD_ARG_LIT("-vmwarevga"); + break; + + case VIR_DOMAIN_VIDEO_TYPE_XEN: + case VIR_DOMAIN_VIDEO_TYPE_CIRRUS: + /* No special args - this is the default */ + break; + + default: + qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, + _("video type %s is not supported with QEMU"), + virDomainVideoTypeToString(def->videos[0]->type)); + goto error; + } + } + } + /* Add sound hardware */ if (def->nsounds) { int size = 100; @@ -2428,6 +2486,7 @@ virDomainDefPtr qemuParseCommandLine(virConnectPtr conn, char *path; int nnics = 0; const char **nics = NULL; + int video = VIR_DOMAIN_VIDEO_TYPE_CIRRUS; if (!progargv[0]) { qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, @@ -2805,6 +2864,18 @@ virDomainDefPtr qemuParseCommandLine(virConnectPtr conn, def->os.bootloader = strdup(val); if (!def->os.bootloader) goto no_memory; + } else if (STREQ(arg, "-vmwarevga")) { + video = VIR_DOMAIN_VIDEO_TYPE_VMVGA; + } else if (STREQ(arg, "-std-vga")) { + video = VIR_DOMAIN_VIDEO_TYPE_VGA; + } else if (STREQ(arg, "-vga")) { + WANT_VALUE(); + video = qemuVideoTypeFromString(val); + if (video < 0) { + qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, + _("unknown video adapter type '%s'"), val); + goto error; + } } else if (STREQ(arg, "-domid")) { WANT_VALUE(); /* ignore, generted on the fly */ @@ -2859,6 +2930,24 @@ virDomainDefPtr qemuParseCommandLine(virConnectPtr conn, def->graphics[def->ngraphics++] = sdl; } + if (def->ngraphics) { + virDomainVideoDefPtr vid; + if (VIR_ALLOC(vid) < 0) + goto no_memory; + if (def->virtType == VIR_DOMAIN_VIRT_XEN) + vid->type = VIR_DOMAIN_VIDEO_TYPE_XEN; + else + vid->type = video; + vid->vram = virDomainVideoDefaultRAM(def, vid->type); + vid->heads = 1; + + if (VIR_REALLOC_N(def->videos, def->nvideos+1) < 0) { + virDomainVideoDefFree(vid); + goto no_memory; + } + def->videos[def->nvideos++] = vid; + } + VIR_FREE(nics); if (!def->name) { diff --git a/src/qemu_conf.h b/src/qemu_conf.h index c0ed46d..9065821 100644 --- a/src/qemu_conf.h +++ b/src/qemu_conf.h @@ -57,6 +57,7 @@ enum qemud_cmd_flags { QEMUD_CMD_FLAG_DRIVE_CACHE_V2 = (1 << 12), /* Is the cache= flag wanting new v2 values */ QEMUD_CMD_FLAG_KVM = (1 << 13), /* Whether KVM is compiled in */ QEMUD_CMD_FLAG_DRIVE_FORMAT = (1 << 14), /* Is -drive format= avail */ + QEMUD_CMD_FLAG_VGA = (1 << 15), /* Is -vga avail */ }; /* Main driver state */ diff --git a/tests/qemuhelptest.c b/tests/qemuhelptest.c index bf8a293..73eae54 100644 --- a/tests/qemuhelptest.c +++ b/tests/qemuhelptest.c @@ -89,11 +89,67 @@ mymain(int argc, char **argv) ret = -1; \ } while (0) - DO_TEST("qemu-0.9.1", 0x002f, 9001, 0, 0); - DO_TEST("kvm-74", 0x633e, 9001, 1, 74); - DO_TEST("qemu-0.10.5", 0x5c6f, 10005, 0, 0); - DO_TEST("qemu-kvm-0.10.5", 0x7d7e, 10005, 1, 0); - DO_TEST("kvm-86", 0x7d7e, 10050, 1, 0); + DO_TEST("qemu-0.9.1", + QEMUD_CMD_FLAG_KQEMU | + QEMUD_CMD_FLAG_VNC_COLON | + QEMUD_CMD_FLAG_NO_REBOOT | + QEMUD_CMD_FLAG_DRIVE | + QEMUD_CMD_FLAG_NAME, + 9001, 0, 0); + DO_TEST("kvm-74", + QEMUD_CMD_FLAG_VNC_COLON | + QEMUD_CMD_FLAG_NO_REBOOT | + QEMUD_CMD_FLAG_DRIVE | + QEMUD_CMD_FLAG_DRIVE_BOOT | + QEMUD_CMD_FLAG_NAME | + QEMUD_CMD_FLAG_VNET_HDR | + QEMUD_CMD_FLAG_MIGRATE_KVM_STDIO | + QEMUD_CMD_FLAG_KVM | + QEMUD_CMD_FLAG_DRIVE_FORMAT, + 9001, 1, 74); + DO_TEST("qemu-0.10.5", + QEMUD_CMD_FLAG_KQEMU | + QEMUD_CMD_FLAG_VNC_COLON | + QEMUD_CMD_FLAG_NO_REBOOT | + QEMUD_CMD_FLAG_DRIVE | + QEMUD_CMD_FLAG_NAME | + QEMUD_CMD_FLAG_UUID | + QEMUD_CMD_FLAG_MIGRATE_QEMU_TCP | + QEMUD_CMD_FLAG_MIGRATE_QEMU_EXEC | + QEMUD_CMD_FLAG_DRIVE_CACHE_V2 | + QEMUD_CMD_FLAG_DRIVE_FORMAT | + QEMUD_CMD_FLAG_VGA, + 10005, 0, 0); + DO_TEST("qemu-kvm-0.10.5", + QEMUD_CMD_FLAG_VNC_COLON | + QEMUD_CMD_FLAG_NO_REBOOT | + QEMUD_CMD_FLAG_DRIVE | + QEMUD_CMD_FLAG_DRIVE_BOOT | + QEMUD_CMD_FLAG_NAME | + QEMUD_CMD_FLAG_UUID | + QEMUD_CMD_FLAG_VNET_HDR | + QEMUD_CMD_FLAG_MIGRATE_QEMU_TCP | + QEMUD_CMD_FLAG_MIGRATE_QEMU_EXEC | + QEMUD_CMD_FLAG_DRIVE_CACHE_V2 | + QEMUD_CMD_FLAG_KVM | + QEMUD_CMD_FLAG_DRIVE_FORMAT | + QEMUD_CMD_FLAG_VGA, + 10005, 1, 0); + DO_TEST("kvm-86", + QEMUD_CMD_FLAG_VNC_COLON | + QEMUD_CMD_FLAG_NO_REBOOT | + QEMUD_CMD_FLAG_DRIVE | + QEMUD_CMD_FLAG_DRIVE_BOOT | + QEMUD_CMD_FLAG_NAME | + QEMUD_CMD_FLAG_UUID | + QEMUD_CMD_FLAG_VNET_HDR | + QEMUD_CMD_FLAG_MIGRATE_QEMU_TCP | + QEMUD_CMD_FLAG_MIGRATE_QEMU_EXEC | + QEMUD_CMD_FLAG_DRIVE_CACHE_V2 | + QEMUD_CMD_FLAG_KVM | + QEMUD_CMD_FLAG_DRIVE_FORMAT | + QEMUD_CMD_FLAG_VGA, + 10050, 1, 0); return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl-fullscreen.xml b/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl-fullscreen.xml index fe1fe1a..f3fc588 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl-fullscreen.xml +++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl-fullscreen.xml @@ -20,5 +20,8 @@ </disk> <input type='mouse' bus='ps2'/> <graphics type='sdl' display=':0.1' xauth='/root/.Xauthority' fullscreen='yes'/> + <video> + <model type='cirrus' vram='9216' heads='1'/> + </video> </devices> </domain> diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.args b/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.args index 3b2b049..f908252 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.args @@ -1 +1 @@ -LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test XAUTHORITY=/root/.Xauthority DISPLAY=:0.1 /usr/bin/qemu -S -M pc -m 214 -smp 1 -monitor pty -no-acpi -boot c -hda /dev/HostVG/QEMUGuest1 -net none -serial none -parallel none -usb +LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test XAUTHORITY=/root/.Xauthority DISPLAY=:0.1 /usr/bin/qemu -S -M pc -m 214 -smp 1 -monitor pty -no-acpi -boot c -hda /dev/HostVG/QEMUGuest1 -net none -serial none -parallel none -usb -std-vga diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.xml b/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.xml index 1e04f12..431c3c9 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.xml +++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.xml @@ -20,5 +20,8 @@ </disk> <input type='mouse' bus='ps2'/> <graphics type='sdl' display=':0.1' xauth='/root/.Xauthority'/> + <video> + <model type='vga' vram='9216' heads='1'/> + </video> </devices> </domain> diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.args b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.args index a41a57c..bd63540 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.args @@ -1 +1 @@ -LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test SASL_CONF_DIR=/root/.sasl2 /usr/bin/qemu -S -M pc -m 214 -smp 1 -monitor pty -no-acpi -boot c -hda /dev/HostVG/QEMUGuest1 -net none -serial none -parallel none -usb -vnc 127.0.0.1:3,sasl +LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test SASL_CONF_DIR=/root/.sasl2 /usr/bin/qemu -S -M pc -m 214 -smp 1 -monitor pty -no-acpi -boot c -hda /dev/HostVG/QEMUGuest1 -net none -serial none -parallel none -usb -vnc 127.0.0.1:3,sasl -vga cirrus diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.xml b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.xml index cbaa1da..b6f99d3 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.xml +++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.xml @@ -20,5 +20,8 @@ </disk> <input type='mouse' bus='ps2'/> <graphics type='vnc' port='5903' autoport='no' listen='127.0.0.1'/> + <video> + <model type='cirrus' vram='9216' heads='1'/> + </video> </devices> </domain> diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-tls.xml b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-tls.xml index cbaa1da..b6f99d3 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-tls.xml +++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-tls.xml @@ -20,5 +20,8 @@ </disk> <input type='mouse' bus='ps2'/> <graphics type='vnc' port='5903' autoport='no' listen='127.0.0.1'/> + <video> + <model type='cirrus' vram='9216' heads='1'/> + </video> </devices> </domain> diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc.xml b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc.xml index cbaa1da..b6f99d3 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc.xml +++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc.xml @@ -20,5 +20,8 @@ </disk> <input type='mouse' bus='ps2'/> <graphics type='vnc' port='5903' autoport='no' listen='127.0.0.1'/> + <video> + <model type='cirrus' vram='9216' heads='1'/> + </video> </devices> </domain> diff --git a/tests/qemuxml2argvdata/qemuxml2argv-input-xen.xml b/tests/qemuxml2argvdata/qemuxml2argv-input-xen.xml index 1e80317..fea7f8e 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-input-xen.xml +++ b/tests/qemuxml2argvdata/qemuxml2argv-input-xen.xml @@ -20,5 +20,8 @@ </disk> <input type='mouse' bus='xen'/> <graphics type='vnc' port='5903' autoport='no' listen='127.0.0.1'/> + <video> + <model type='xen' vram='4096' heads='1'/> + </video> </devices> </domain> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 28609eb..2a93018 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -216,7 +216,7 @@ mymain(int argc, char **argv) driver.vncSASL = 1; driver.vncSASLdir = strdup("/root/.sasl2"); - DO_TEST("graphics-vnc-sasl", 0); + DO_TEST("graphics-vnc-sasl", QEMUD_CMD_FLAG_VGA); driver.vncTLS = 1; driver.vncTLSx509verify = 1; driver.vncTLSx509certdir = strdup("/etc/pki/tls/qemu"); diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index ab9943d..7db7611 100644 --- a/tests/qemuxml2xmltest.c +++ b/tests/qemuxml2xmltest.c @@ -102,6 +102,8 @@ mymain(int argc, char **argv) DO_TEST("disk-drive-cache-v1-wb"); DO_TEST("disk-drive-cache-v1-none"); DO_TEST("graphics-vnc"); + DO_TEST("graphics-vnc-sasl"); + DO_TEST("graphics-vnc-tls"); DO_TEST("graphics-sdl"); DO_TEST("graphics-sdl-fullscreen"); DO_TEST("input-usbmouse"); -- 1.6.2.5 -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 2

[libvirt] [PATCH] provide the object name on lookup error
by Daniel Veillard 08 Jul '09

08 Jul '09

There were a number of places where the object name was not not reported, based on the use I don't think the string could be NULL in any of those. I also fixed a few POOL error which were really VOLume ones. Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

4 5

[libvirt] daily builds of pristine upstream sources for qemu, qemu-kvm, and libvirt
by Dustin Kirkland 07 Jul '09

07 Jul '09

Howdy, developers of qemu, qemu-kvm, and libvirt. I periodically see bug reports on these lists from users of Ubuntu packages of these projects. Since these users are often running some version of the project older than the current development branch, it's more interesting to know if the user can reproduce the bug on the latest development sources. I have constructed some automation that builds Debian/Ubuntu binaries for amd64, i386, and lpia platforms directly from your master git repositories every day at 11:00 UTC, and publishes them in a special, opt-in repository. These daily builds also drop any specific patches we may be carrying, in order to minimize the delta between the binaries built and your upstream sources. * https://launchpad.net/~ubuntu-virt/+archive/virt-daily-upstream In the event that an Ubuntu user reports a problem, and there's an interest in trying to reproduce the problem against the tip of the development branch, we can point them at this resource for testing purposes. Additionally, this tool also has the ability to expose build breakages. For example (let's not debug this in this thread), at the moment, qemu's build is broken, somewhere near: .... LINK cris-softmmu/qemu-system-cris ../libqemu_common.a(esdaudio.o): In function `qesd_run_in': /build/buildd/qemu-0.10.50.20090707062004/audio/esdaudio.c:400: undefined reference to `audio_pt_lock' .... Launchpad publishes the full build logs available for each architecture at the link above. For the above example, the specific build log is: * http://launchpadlibrarian.net/28761559/buildlog_ubuntu-karmic-amd64.qemu_0.… If anyone has suggestions as to the utility of this resource, I would appreciate constructive feedback. Cheers, -- :-Dustin

1 0

[libvirt] [PATCH] allow to set path to xen userspace tools
by Guido Günther 07 Jul '09

07 Jul '09

Hi, attached patch makes the path to the xen userspace tools configurable. Debian keeps this under /usr/lib/xen-default/ instead of /usr/lib/xen/. We don't have the amd64 libs in /usr/lib64/xen either so we can use: ./configure --with-xen-tools=/usr/lib/xen-defaults --with-xen-tools64=/usr/lib/xen-defaults instead of patching src/xen_internals.c directly. Skipping above options gives the current behaviour. I checked that "make check" still passes. O.k. to apply? Cheers, -- Guido

3 3

[libvirt] [PATCH] Power Hypervisor Support for libvirt - minimum set of features
by Eduardo Otubo 07 Jul '09

07 Jul '09

Hello all, This is the initial patch for the driver for IBM Power Hypervisors. The minimum set of features are now implemented: list, list --all and dumpxml. Here is the Changeset since last PATCH I sent: * The URI has changed to: phyp://user@[hmc|ivm]/managed_system. If the system is a HMC+VIOS based, only an HMC authentication will be required. Commands will be sent to VIOS trough HMC command line. And if the system is an IVM based, then just provide the username and password for IVM. * Since the Power Hypervisor has no information about UUID's, I built a little database (uuid_db) to store and associate LPAR ID's with UUID randomly generated by the API. * The command dumpxml is implemented, but there are some informations missing. Fetching informations like fstab, os type, uptime, IP addr and so on, will only be available in a future versions of the HMC system. * The TODO list is now set to implement life cycle functions. Thanks in advance, []'s -- Eduardo Otubo Software Engineer Linux Technology Center IBM Systems & Technology Group Mobile: +55 19 8135 0885 otubo(a)linux.vnet.ibm.com

2 7

[libvirt] PATCH: 0/3: Run QEMU guests within a CGroup
by Daniel P. Berrange 07 Jul '09

07 Jul '09

Recent Linux kernels have a new concept of 'CGroups' which is a way to group tasks on the system and apply policy to them as a whole. We already use this in the LXC container driver, to control total memory usage of things runing within a container. This patch series is a proof of concept to make use of CGroups in the QEMU driver. The idea is that we have a 3 level cgroup hierarchy - Top level; contains the libvirtd daemon itself - 2nd level: one per libvirt driver, but dos not contain any processes. - 3rd level: one per guest VM. Contains the QEMU process The host admin can do control on the top level and 2nd level to set an overall system policy. libvirt will then provide APIs / capabilities to control individual VMs policy. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

4 10

[libvirt] [PATCH 1/2] Added new filesystem glusterfs
by Harshavardhana 07 Jul '09

07 Jul '09

Added new enum for glusterfs, another netfs based filesystem. --- src/storage_conf.c | 2 +- src/storage_conf.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/storage_conf.c b/src/storage_conf.c index 5f724dc..16ed906 100644 --- a/src/storage_conf.c +++ b/src/storage_conf.c @@ -68,7 +68,7 @@ VIR_ENUM_IMPL(virStoragePoolFormatFileSystem, VIR_ENUM_IMPL(virStoragePoolFormatFileSystemNet, VIR_STORAGE_POOL_NETFS_LAST, - "auto", "nfs") + "auto", "nfs", "glusterfs") VIR_ENUM_IMPL(virStoragePoolFormatDisk, VIR_STORAGE_POOL_DISK_LAST, diff --git a/src/storage_conf.h b/src/storage_conf.h index 8a4fed2..27dc4a7 100644 --- a/src/storage_conf.h +++ b/src/storage_conf.h @@ -151,7 +151,6 @@ struct _virStoragePoolSourceHost { int protocol; }; - /* * Available extents on the underlying storage */ @@ -366,6 +365,7 @@ VIR_ENUM_DECL(virStoragePoolFormatFileSystem) enum virStoragePoolFormatFileSystemNet { VIR_STORAGE_POOL_NETFS_AUTO = 0, VIR_STORAGE_POOL_NETFS_NFS, + VIR_STORAGE_POOL_NETFS_GLUSTERFS, VIR_STORAGE_POOL_NETFS_LAST, }; VIR_ENUM_DECL(virStoragePoolFormatFileSystemNet) -- 1.6.0.6

2 1

[libvirt] Can't boot guest after adding an IDE storage
by M. Mohan Kumar 07 Jul '09

07 Jul '09

Hi, We installed Fedora 11 guest in an emulated SCSI disk using virt-install. After the installation the guest was shutdown and additional IDE virtual storage was added to the guest. When we try to boot the guest from virt-manager, it tries to boot from the newly added IDE storage (instead of installed SCSI storage) and fails to boot. It seems that how the disk devices are sorted is the problem. There is a bug opened to track this issue: https://bugzilla.redhat.com/show_bug.cgi?id=507271 As dicussed in the bugzilla, ideally there should be a 'bootable' flag for each storage device. Also virt-manager could another option to specify which disk to boot from. Regards, M. Mohan Kumar

3 2

[libvirt] [PATCH] don't raise a missing network as an internal error
by Daniel Veillard 07 Jul '09

07 Jul '09

https://bugzilla.redhat.com/show_bug.cgi?id=509189 When defining a domain referencing a missing network the erro should not be raised as an internal error. Patch by Paolo Bonzini looks fine to me, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

2 2

[libvirt] Switch from CVS to GIT is done
by Daniel Veillard 07 Jul '09

07 Jul '09

Thanks to Jim Meyering we now have a new git repository, I deprecated the CVS repository, it's read only, you should still be able to keep it around to make patches for a few weeks if needed. The new repo is at: http://libvirt.org/git/?p=libvirt.git;a=summary Unfortunately Jim had to clean up the conversion from CVS that was used previously at git://git.et.redhat.com/libvirt.git so the two are not compatible and the best is to clone a new tree using git clone git://libvirt.org/libvirt.git and then copying over your set of patches with "git format-patch" in the old dir and "git am" to paste them into the new cloned-dir (Jim can certainly provide more details if needed). Let us know if you see something weird in the new tree or on the web site, I have updated the download informations at http://libvirt.org/downloads.html A few things may change but I guess the switch is done at this point, Many thanks to Jim for maintaining the old tree and the migration ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

6 16