- Devel - libvirt List Archives

[libvirt] Fedora MinGW - need for *.def files
by Richard W.M. Jones 16 Nov '09

16 Nov '09

[This is just a FYI ...] Upstream binutils or gcc changed the default way that symbols are exported for cross-compiled (Fedora MinGW) DLLs. Previously all symbols were exported. Now they are only exported if they are explicitly listed in a *.def file. There are two ways that libvirt could be changed to do the right thing here. Either (probably simplest) add '-export-all-symbols' to the libtool command line. This would have to be done conditionally based on Win32 being the compilation target. Or create a *.def file. It looks like: LIBRARY libvirt.dll DESCRIPTION "libvirt foo blah" EXPORTS <<list of symbol names, one per line>> http://msdn.microsoft.com/en-us/library/d91k01sh%28VS.80%29.aspx http://msdn.microsoft.com/en-us/library/28d6s79h%28VS.80%29.aspx The LIBRARY and DESCRIPTION lines are optional. You have to add '-export-symbols libvirt.def' to the libtool command line. (It's not clear to me at the moment if you only do this for Windows or if it's safe to pass this on all platforms -- the documentation for this is very sparse). There is a third method: you can munge all the code by adding __declspec(dllexport) to all exported symbols in the header files, conditionally of course. I'm pretty sure that's the worst of all worlds. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top

5 13

[libvirt] nested VMs
by Gerry Reno 16 Nov '09

16 Nov '09

I tried nesting VM's but the hw virt flags are not passed to the next level QEMU-CPU. What version is this going to be available so we have reasonable acceleration? -Gerry

3 4

[libvirt] [PATCH] only remove masquerade rules in NAT mode
by Guido Günther 16 Nov '09

16 Nov '09

Hi, attached patch makes sure we only remove the masquerade rules if forwardType == VIR_NETWORK_FORWARD_NAT and not if forwardType == VIR_NETWORK_FORWARD_ROUTE since we don't use them there. This fixes: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=549949 O.k. to apply? -- Guido

2 3

[libvirt] Security driver on el5
by Daniel Berteaud 16 Nov '09

16 Nov '09

Hi. I'm running libvirt (0.7.2) on a CentOS 5.4 host. It's working quite well, but only if I configure selinux in permissive mode. I've tried to build libvirt with selinux enabled, but no matter what I try, it's still disabled. After some searching, I've found that: http://article.gmane.org/gmane.comp.emulators.libvirt/12282 "- Added a configure.in check for selinux_virtual_domain_context_path() and selinux_virtual_image_context_path() and make it disable the SELinux driver if these aren't found. These functions are new on F11, so we don't want to break build on RHEL-5 & earlier Fedora." Does this means there's no way to get selinux security driver on el5 (or anything before fedora 11) ? Regards, Daniel -- Daniel Berteaud FIREWALL-SERVICES SARL. Société de Services en Logiciels Libres Technopôle Montesquieu 33650 MARTILLAC Tel : 05 56 64 15 32 Fax : 05 56 64 15 32 Mail: daniel(a)firewall-services.com Web : http://www.firewall-services.com

2 1

[libvirt] [PATCH] Whitespace cleanup for pre-tags on the website
by Matthias Bolte 16 Nov '09

16 Nov '09

--- docs/drvlxc.html.in | 80 +++++++++--------- docs/drvone.html.in | 89 +++++++++++---------- docs/drvopenvz.html.in | 22 +++--- docs/drvqemu.html.in | 48 ++++++------ docs/drvtest.html.in | 16 ++-- docs/drvuml.html.in | 22 +++--- docs/drvvbox.html.in | 194 ++++++++++++++++++++++----------------------- docs/drvxen.html.in | 22 +++--- docs/formatdomain.html.in | 3 +- docs/storage.html.in | 18 ++--- 10 files changed, 253 insertions(+), 261 deletions(-) diff --git a/docs/drvlxc.html.in b/docs/drvlxc.html.in index f67b7d0..cfcfdab 100644 --- a/docs/drvlxc.html.in +++ b/docs/drvlxc.html.in @@ -13,24 +13,24 @@ start it using <p></p> <pre> <domain type='lxc'> - <name>vm1</name> - <memory>500000</memory> - <os> - <type>exe</type> - <init>/bin/sh</init> - </os> - <vcpu>1</vcpu> - <clock offset='utc'/> - <on_poweroff>destroy</on_poweroff> - <on_reboot>restart</on_reboot> - <on_crash>destroy</on_crash> - <devices> - <emulator>/usr/libexec/libvirt_lxc</emulator> - <interface type='network'> - <source network='default'/> - </interface> - <console type='pty' /> - </devices> + <name>vm1</name> + <memory>500000</memory> + <os> + <type>exe</type> + <init>/bin/sh</init> + </os> + <vcpu>1</vcpu> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <emulator>/usr/libexec/libvirt_lxc</emulator> + <interface type='network'> + <source network='default'/> + </interface> + <console type='pty' /> + </devices> </domain> </pre> @@ -42,28 +42,28 @@ debootstrap, whatever) under /opt/vm-1-root: <p></p> <pre> <domain type='lxc'> - <name>vm1</name> - <memory>32768</memory> - <os> - <type>exe</type> - <init>/init</init> - </os> - <vcpu>1</vcpu> - <clock offset='utc'/> - <on_poweroff>destroy</on_poweroff> - <on_reboot>restart</on_reboot> - <on_crash>destroy</on_crash> - <devices> - <emulator>/usr/libexec/libvirt_lxc</emulator> - <filesystem type='mount'> - <source dir='/opt/vm-1-root'/> - <target dir='/'/> - </filesystem> - <interface type='network'> - <source network='default'/> - </interface> - <console type='pty' /> - </devices> + <name>vm1</name> + <memory>32768</memory> + <os> + <type>exe</type> + <init>/init</init> + </os> + <vcpu>1</vcpu> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <emulator>/usr/libexec/libvirt_lxc</emulator> + <filesystem type='mount'> + <source dir='/opt/vm-1-root'/> + <target dir='/'/> + </filesystem> + <interface type='network'> + <source network='default'/> + </interface> + <console type='pty' /> + </devices> </domain> </pre> diff --git a/docs/drvone.html.in b/docs/drvone.html.in index 1745be1..036c0c7 100644 --- a/docs/drvone.html.in +++ b/docs/drvone.html.in @@ -27,12 +27,13 @@ tools and VM description files.</p> <p>The Uri of the driver protocol is "one". Some example connection Uris for the driver are: </p> -<pre> one:/// (local access) - one+unix:/// (local access) - one://example.com/ (remote access) - one+tcp://example.com/ (remote access, SASl/Kerberos) - one+ssh://user@example.com/ (remote access, SSH tunnelled) - </pre> +<pre> +one:/// (local access) +one+unix:/// (local access) +one://example.com/ (remote access) +one+tcp://example.com/ (remote access, SASl/Kerberos) +one+ssh://user@example.com/ (remote access, SSH tunnelled) +</pre> <h2> <a name="xmlconfig"></a>Example domain XML config</h2> <p>There are some limitations on the XML attributes that may be @@ -42,51 +43,51 @@ driver:</p> <h3>Paravirtualized guest direct kernel boot </h3> -<pre> <domain type='one'> - <name>vm01</name> - <memory>32768</memory> - <vcpu>1</vcpu> +<pre> +<domain type='one'> + <name>vm01</name> + <memory>32768</memory> + <vcpu>1</vcpu> - <os> - <type>linux</type> - <kernel>/boot/vmlinuz-2.6.24-17-xen</kernel> - <initrd>/boot/initrd.img-2.6.24-17-xen</initrd> - <cmdline></cmdline> - <root>sda1</root> - </os> + <os> + <type>linux</type> + <kernel>/boot/vmlinuz-2.6.24-17-xen</kernel> + <initrd>/boot/initrd.img-2.6.24-17-xen</initrd> + <cmdline></cmdline> + <root>sda1</root> + </os> - <devices> + <devices> + <disk type='file' device='disk'> + <source file='/images/sgehosts/01/disk.img'/> + <target dev='sda1'/> + </disk> - <disk type='file' device='disk'> - <source file='/images/sgehosts/01/disk.img'/> - <target dev='sda1'/> - </disk> + <disk type='file' device='disk'> + <source file='/images/sgehosts/01/swap.img'/> + <target dev='sda2'/> + </disk> - <disk type='file' device='disk'> - <source file='/images/sgehosts/01/swap.img'/> - <target dev='sda2'/> - </disk> + <disk type='file' device='cdrom'> + <source file='/images/iso/cdrom.iso'/> + <target dev='hdc'/> + <readonly/> + </disk> - <disk type='file' device='cdrom'> - <source file='/images/iso/cdrom.iso'/> - <target dev='hdc'/> - <readonly/> - </disk> +  + <interface type='bridge'> + <source bridge='eth0'/> + <mac address='00:16:3e:5d:c7:9e'/> + </interface> -  - <interface type='bridge'> - <source bridge='eth0'/> - <mac address='00:16:3e:5d:c7:9e'/> - </interface> - -  - <interface type='network'> - <source network='onenetwork'/> - </interface> - </devices> - </domain> - </pre> +  + <interface type='network'> + <source network='onenetwork'/> + </interface> + </devices> +</domain> +</pre> <p> <b>Note:</b> The "<interface type='network'>" will attach the interface to a previously configured network (named diff --git a/docs/drvopenvz.html.in b/docs/drvopenvz.html.in index b2beadb..e446b1a 100644 --- a/docs/drvopenvz.html.in +++ b/docs/drvopenvz.html.in @@ -19,13 +19,13 @@ the libvirt driver are: </p> - <pre> - openvz:///system (local access) - openvz+unix:///system (local access) - openvz://example.com/system (remote access, TLS/x509) - openvz+tcp://example.com/system (remote access, SASl/Kerberos) - openvz+ssh://root@example.com/system (remote access, SSH tunnelled) - </pre> +<pre> +openvz:///system (local access) +openvz+unix:///system (local access) +openvz://example.com/system (remote access, TLS/x509) +openvz+tcp://example.com/system (remote access, SASl/Kerberos) +openvz+ssh://root@example.com/system (remote access, SSH tunnelled) +</pre> <h2>Notes on bridged networking</h2> @@ -60,10 +60,10 @@ must be created containing </p> - <pre> +<pre> #!/bin/bash EXTERNAL_SCRIPT="/usr/sbin/vznetaddbr" - </pre> +</pre> <p> The host OS is now ready to allow bridging of guest containers, which @@ -83,7 +83,7 @@ EXTERNAL_SCRIPT="/usr/sbin/vznetaddbr" matches the templates known to OpenVZ tools. </p> - <pre> +<pre> <domain type='openvz' id='104'> <name>104</name> <uuid>86c12009-e591-a159-6e9f-91d18b85ef78</uuid> @@ -104,7 +104,7 @@ EXTERNAL_SCRIPT="/usr/sbin/vznetaddbr" </interface> </devices> </domain> - </pre> +</pre> </body> </html> diff --git a/docs/drvqemu.html.in b/docs/drvqemu.html.in index 996ed3e..c5c826c 100644 --- a/docs/drvqemu.html.in +++ b/docs/drvqemu.html.in @@ -43,16 +43,16 @@ is "qemu". Some example conection URIs for the libvirt driver are: </p> - <pre> - qemu:///session (local access to per-user instance) - qemu+unix:///session (local access to per-user instance) - - qemu:///system (local access to system instance) - qemu+unix:///system (local access to system instance) - qemu://example.com/system (remote access, TLS/x509) - qemu+tcp://example.com/system (remote access, SASl/Kerberos) - qemu+ssh://root@example.com/system (remote access, SSH tunnelled) - </pre> +<pre> +qemu:///session (local access to per-user instance) +qemu+unix:///session (local access to per-user instance) + +qemu:///system (local access to system instance) +qemu+unix:///system (local access to system instance) +qemu://example.com/system (remote access, TLS/x509) +qemu+tcp://example.com/system (remote access, SASl/Kerberos) +qemu+ssh://root@example.com/system (remote access, SSH tunnelled) +</pre> <h2><a name="security">Driver security architecture</a></h2> @@ -167,7 +167,7 @@ parent directories </p> <pre> - chmod o+x /path/to/directory +chmod o+x /path/to/directory </pre> <p> In particular note that if using the "system" instance @@ -383,12 +383,12 @@ The list of shared devices a guest is allowed access to is </p> - <pre> - /dev/null, /dev/full, /dev/zero, - /dev/random, /dev/urandom, - /dev/ptmx, /dev/kvm, /dev/kqemu, - /dev/rtc, /dev/hpet, /dev/net/tun - </pre> +<pre> +/dev/null, /dev/full, /dev/zero, +/dev/random, /dev/urandom, +/dev/ptmx, /dev/kvm, /dev/kqemu, +/dev/rtc, /dev/hpet, /dev/net/tun +</pre> <p> In the event of unanticipated needs arising, this can be customized @@ -397,10 +397,10 @@ should be run as root, prior to starting libvirtd </p> - <pre> - mkdir /dev/cgroup - mount -t cgroup none /dev/cgroup -o devices - </pre> +<pre> +mkdir /dev/cgroup +mount -t cgroup none /dev/cgroup -o devices +</pre> <p> libvirt will then place each virtual machine in a cgroup at @@ -430,6 +430,7 @@ LOGNAME=test /usr/bin/qemu -S -M pc -m 214 -smp 1 \ /dev/HostVG/QEMUGuest1 -net none -serial none \ -parallel none -usb EOF + $ virsh domxml-from-native qemu-argv demo.args <domain type='qemu'> <uuid>00000000-0000-0000-0000-000000000000</uuid> @@ -452,7 +453,7 @@ $ virsh domxml-from-native qemu-argv demo.args </disk> </devices> </domain> - </pre> +</pre> <p>NB, don't include the literral \ in the args, put everything on one line</p> @@ -488,6 +489,7 @@ $ virsh domxml-from-native qemu-argv demo.args </devices> </domain> EOF + $ virsh domxml-to-native qemu-argv demo.xml LC_ALL=C PATH=/usr/bin:/bin HOME=/home/test \ USER=test LOGNAME=test /usr/bin/qemu -S -M pc \ @@ -495,7 +497,7 @@ $ virsh domxml-to-native qemu-argv demo.xml -monitor pty -no-acpi -boot c -drive \ file=/dev/HostVG/QEMUGuest1,if=ide,index=0 -net none \ -serial none -parallel none -usb - </pre> +</pre> <h2><a name="xmlconfig">Example domain XML config</a></h2> diff --git a/docs/drvtest.html.in b/docs/drvtest.html.in index 0547fbb..b5814c3 100644 --- a/docs/drvtest.html.in +++ b/docs/drvtest.html.in @@ -12,14 +12,14 @@ for the libvirt driver are: </p> - <pre> - test:///default (local access, default config) - test:///path/to/driver/config.xml (local access, custom config) - test+unix:///default (local access, default config, via daemon) - test://example.com/default (remote access, TLS/x509) - test+tcp://example.com/default (remote access, SASl/Kerberos) - test+ssh://root@example.com/default (remote access, SSH tunnelled) - </pre> +<pre> +test:///default (local access, default config) +test:///path/to/driver/config.xml (local access, custom config) +test+unix:///default (local access, default config, via daemon) +test://example.com/default (remote access, TLS/x509) +test+tcp://example.com/default (remote access, SASl/Kerberos) +test+ssh://root@example.com/default (remote access, SSH tunnelled) +</pre> </body> </html> diff --git a/docs/drvuml.html.in b/docs/drvuml.html.in index 25a417f..9e5db95 100644 --- a/docs/drvuml.html.in +++ b/docs/drvuml.html.in @@ -24,16 +24,16 @@ URIs are </p> - <pre> - uml:///session (local access to per-user instance) - uml+unix:///session (local access to per-user instance) +<pre> +uml:///session (local access to per-user instance) +uml+unix:///session (local access to per-user instance) - uml:///system (local access to system instance) - uml+unix:///system (local access to system instance) - uml://example.com/system (remote access, TLS/x509) - uml+tcp://example.com/system (remote access, SASl/Kerberos) - uml+ssh://root@example.com/system (remote access, SSH tunnelled) - </pre> +uml:///system (local access to system instance) +uml+unix:///system (local access to system instance) +uml://example.com/system (remote access, TLS/x509) +uml+tcp://example.com/system (remote access, SASl/Kerberos) +uml+ssh://root@example.com/system (remote access, SSH tunnelled) +</pre> <h2>Example XML configuration</h2> @@ -58,7 +58,7 @@ thus accessible with "virsh console" or equivalent tools </p> - <pre> +<pre> <domain type='uml'> <name>demo</name> <uuid>b4433fc2-a22e-ffb3-0a3d-9c173b395800</uuid> @@ -77,6 +77,6 @@ <console type='pty'/> </devices> </domain> - </pre> +</pre> </body> </html> diff --git a/docs/drvvbox.html.in b/docs/drvvbox.html.in index 73372f1..ef55757 100644 --- a/docs/drvvbox.html.in +++ b/docs/drvvbox.html.in @@ -13,107 +13,105 @@ The uri of the driver protocol is "vbox". Some example connection URIs for the driver are: </p> - <pre> - vbox:///session (local access to per-user instance) - vbox+unix:///session (local access to per-user instance) - vbox+tcp://user@example.com/session (remote access, SASl/Kerberos) - vbox+ssh://user@example.com/session (remote access, SSH tunnelled) - </pre> +<pre> +vbox:///session (local access to per-user instance) +vbox+unix:///session (local access to per-user instance) +vbox+tcp://user@example.com/session (remote access, SASl/Kerberos) +vbox+ssh://user@example.com/session (remote access, SSH tunnelled) +</pre> <h2><a name="xmlconfig">Example domain XML config</a></h2> - <pre> - <domain type='vbox'> - <name>vbox</name> - <uuid>4dab22b31d52d8f32516782e98ab3fa0</uuid> - - <os> - <type>hvm</type> - <boot dev='cdrom'/> - <boot dev='hd'/> - <boot dev='fd'/> - <boot dev='network'/> - </os> - - <memory>654321</memory> - <vcpu>1</vcpu> - - <features> - <pae/> - <acpi/> - <apic/> - </features> - - <devices> - <disk type='file' device='cdrom'> - <source file='/home/user/Downloads/slax-6.0.9.iso'/> - <target dev='hdc'/> - <readonly/> - </disk> - - <disk type='file' device='disk'> - <source file='/home/user/tmp/vbox.vdi'/> - <target dev='hdd'/> - </disk> - - <disk type='file' device='floppy'> - <source file='/home/user/tmp/WIN98C.IMG'/> - <target dev='fda'/> - </disk> - -  - <interface type='bridge'> - <source bridge='eth0'/> - <mac address='00:16:3e:5d:c7:9e'/> - <model type='am79c973'/> - </interface> - -  - <interface type='user'> - <mac address='56:16:3e:5d:c7:9e'/> - <model type='82540eM'/> - </interface> - - <sound model='sb16'/> - - <parallel type='dev'> - <source path='/dev/pts/1'/> - <target port='0'/> - </parallel> - - <parallel type='dev'> - <source path='/dev/pts/2'/> - <target port='1'/> - </parallel> - - <serial type="dev"> - <source path="/dev/ttyS0"/> - <target port="0"/> - </serial> - - <serial type="pipe"> - <source path="/tmp/serial.txt"/> - <target port="1"/> - </serial> - - <hostdev mode='subsystem' type='usb'> - <source> - <vendor id='0x1234'/> - <product id='0xbeef'/> - </source> - </hostdev> - - <hostdev mode='subsystem' type='usb'> - <source> - <vendor id='0x4321'/> - <product id='0xfeeb'/> - </source> - </hostdev> - - </devices> - - </domain> - </pre> +<pre> +<domain type='vbox'> + <name>vbox</name> + <uuid>4dab22b31d52d8f32516782e98ab3fa0</uuid> + + <os> + <type>hvm</type> + <boot dev='cdrom'/> + <boot dev='hd'/> + <boot dev='fd'/> + <boot dev='network'/> + </os> + + <memory>654321</memory> + <vcpu>1</vcpu> + + <features> + <pae/> + <acpi/> + <apic/> + </features> + + <devices> + <disk type='file' device='cdrom'> + <source file='/home/user/Downloads/slax-6.0.9.iso'/> + <target dev='hdc'/> + <readonly/> + </disk> + + <disk type='file' device='disk'> + <source file='/home/user/tmp/vbox.vdi'/> + <target dev='hdd'/> + </disk> + + <disk type='file' device='floppy'> + <source file='/home/user/tmp/WIN98C.IMG'/> + <target dev='fda'/> + </disk> + +  + <interface type='bridge'> + <source bridge='eth0'/> + <mac address='00:16:3e:5d:c7:9e'/> + <model type='am79c973'/> + </interface> + +  + <interface type='user'> + <mac address='56:16:3e:5d:c7:9e'/> + <model type='82540eM'/> + </interface> + + <sound model='sb16'/> + + <parallel type='dev'> + <source path='/dev/pts/1'/> + <target port='0'/> + </parallel> + + <parallel type='dev'> + <source path='/dev/pts/2'/> + <target port='1'/> + </parallel> + + <serial type="dev"> + <source path="/dev/ttyS0"/> + <target port="0"/> + </serial> + + <serial type="pipe"> + <source path="/tmp/serial.txt"/> + <target port="1"/> + </serial> + + <hostdev mode='subsystem' type='usb'> + <source> + <vendor id='0x1234'/> + <product id='0xbeef'/> + </source> + </hostdev> + + <hostdev mode='subsystem' type='usb'> + <source> + <vendor id='0x4321'/> + <product id='0xfeeb'/> + </source> + </hostdev> + </devices> +</domain> +</pre> </body> </html> diff --git a/docs/drvxen.html.in b/docs/drvxen.html.in index fbad477..a6f0e57 100644 --- a/docs/drvxen.html.in +++ b/docs/drvxen.html.in @@ -54,13 +54,13 @@ the libvirt driver are: </p> - <pre> - xen:/// (local access, direct) - xen+unix:/// (local access, via daemon) - xen://example.com/ (remote access, TLS/x509) - xen+tcp://example.com/ (remote access, SASl/Kerberos) - xen+ssh://root@example.com/ (remote access, SSH tunnelled) - </pre> +<pre> +xen:/// (local access, direct) +xen+unix:/// (local access, via daemon) +xen://example.com/ (remote access, TLS/x509) +xen+tcp://example.com/ (remote access, SASl/Kerberos) +xen+ssh://root@example.com/ (remote access, SSH tunnelled) +</pre> <h2><a name="imex">Import and export of libvirt domain XML configs</a></h2> @@ -114,8 +114,7 @@ <input type='mouse' bus='xen'/> <graphics type='vnc' port='-1' autoport='yes' listen='0.0.0.0'/> </devices> -</domain> - </pre> +</domain></pre> <h3><a name="xmlexport">Converting from domain XML to XM config files</a></h3> @@ -125,7 +124,7 @@ format. </p> - <pre># virsh -c xen:/// domxml-to-native xen-xm rhel5pv.xml + <pre>$ virsh -c xen:/// domxml-to-native xen-xm rhel5pv.xml name = "rhel5pv" uuid = "8f07fe28-753f-2729-d76d-bdbd892f949a" maxmem = 2500 @@ -143,8 +142,7 @@ vnc = 1 vncunused = 1 vnclisten = "0.0.0.0" disk = [ "tap:aio:/var/lib/xen/images/rhel5pv.img,xvda,w", "tap:qcow:/root/qcow1-xen.img,xvdd,w" ] -vif = [ "mac=00:16:3e:60:36:ba,bridge=virbr0,script=vif-bridge,vifname=vif5.0" ] - </pre> +vif = [ "mac=00:16:3e:60:36:ba,bridge=virbr0,script=vif-bridge,vifname=vif5.0" ]</pre> <h2><a name="xmlconfig">Example domain XML config</a></h2> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 52889af..05047d3 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -750,8 +750,7 @@ qemu-kvm -net nic,model=? /dev/null <video type='vga' nvram='8192' heads='1'> <acceleration accel3d='yes' accel3d='yes' /> </video> - ... - </pre> + ...</pre> <dl> <dt><code>video</code></dt> diff --git a/docs/storage.html.in b/docs/storage.html.in index 2d48a59..904fc7c 100644 --- a/docs/storage.html.in +++ b/docs/storage.html.in @@ -45,8 +45,7 @@ libvirt. <target> <path>/var/lib/virt/images</path> </target> - </pool> - </pre> + </pool></pre> <h3>Valid pool format types</h3> <p> @@ -101,8 +100,7 @@ libvirt. <target> <path>/var/lib/virt/images</path> </target> - </pool> - </pre> + </pool></pre> <h3>Valid pool format types</h3> <p> @@ -172,8 +170,7 @@ libvirt. <target> <path>/var/lib/virt/images</path> </target> - </pool> - </pre> + </pool></pre> <h3>Valid pool format types</h3> <p> @@ -215,8 +212,7 @@ libvirt. <target> <path>/dev/HostVG</path> </target> - </pool> - </pre> + </pool></pre> <h3>Valid pool format types</h3> <p> @@ -248,8 +244,7 @@ libvirt. <target> <path>/dev</path> </target> - </pool> - </pre> + </pool></pre> <h3>Valid pool format types</h3> <p> @@ -338,8 +333,7 @@ libvirt. <target> <path>/dev/disk/by-path</path> </target> - </pool> - </pre> + </pool></pre> <h3>Valid pool format types</h3> <p> -- 1.6.0.4

2 1

[libvirt] Re: device type 'interface' cannot be attached
by Ian Woodstock 16 Nov '09

16 Nov '09

----- "Gerry Reno" <greno(a)verizon.net> wrote: > Gerry Reno wrote: > > Gerry Reno wrote: > >> I'm using libvirt 0.6.2 on F11 x86_64 and CPU supports hw > >> virtualization. When I try to do 'virsh attach-interface ...' I get > >> an error that the function is not supported by the hypervisor device > >> type 'interface' cannot be attached. Is this command not supported? > >> Or is there something special I need to do? I found it in the man page. > >> > > > > > > I have a private network declared now, thank you Mark. > > > > And here is how I am trying to attach an interface: > > # cat PRIVBR0.xml > > <network> > > <name>PRIVBR0</name> > > <bridge name='privbr0'/> > > <ip address='172.19.0.1' netmask='255.255.0.0'> > > </ip> > > </network> > > > > # virsh net-list --all > > Name State Autostart > > ----------------------------------------- > > PRIVBR0 active yes > > default active no > > > > # virsh attach-interface CC bridge privbr0 > > error: this function is not supported by the hypervisor: device type > > 'interface' cannot be attached > > > > # grep emulator CC.xml > > <emulator>/usr/bin/qemu-kvm</emulator> > > > > > > I tried the 'attach-interface' both while the domain is running and > > while shutdown. Neither works. > > > > Can anyone see something wrong in what I'm doing here or the reason > > that 'attach-interface' is failing? > > > > -Gerry > > > I have also tried this as 'attach-device' with the same result: > > # cat INTERFACE_PRIVBR0.xml > <interface type='bridge'> > <mac address='00:0c:01:41:50:01'/> > <source bridge='privbr0'/> > </interface> > > # virsh attach-device CC INTERFACE_PRIVBR0.xml > error: Failed to attach device from INTERFACE_PRIVBR0.xml > error: this function is not supported by the hypervisor: device type > 'interface' cannot be attached > > I opened the following bug on this issue: > https://bugzilla.redhat.com/show_bug.cgi?id=537688 > Hot adding nics to qemu was added in libvirt 0.7 > > -Gerry > > -- > Libvir-list mailing list > Libvir-list(a)redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list >

2 1

[libvirt] device type 'interface' cannot be attached
by Gerry Reno 15 Nov '09

15 Nov '09

I'm using libvirt 0.6.2 on F11 x86_64 and CPU supports hw virtualization. When I try to do 'virsh attach-interface ...' I get an error that the function is not supported by the hypervisor device type 'interface' cannot be attached. Is this command not supported? Or is there something special I need to do? I found it in the man page. -Gerry

1 2

[libvirt] How to keep VM definitions in sync across hosts?
by Thomas Treutner 15 Nov '09

15 Nov '09

Hi, is there any best-practice how to keep VM definitions in sync across a couple of hosts? Is it reasonable to put /etc/libvirt/qemu/ on a NFS share? Or are there better ways? How does oVirt solve that? I'm asking because I'm currently setting up a four node "cluster" with KVM and libvirt. Previously, with Xen, I used libvirt only for changing currently running VMs (setmem, migrate etc.), but with KVM, I'd like to use libvirt the way it is intented to ;-) So I assume that VM definitions are required to be available and in sync among all nodes for doing live migration. I don't want to rsync them or wrap the virsh URI edit inside a for-loop, as I assume there are better ways? I'd like to do virsh URI edit once and have the changes propagated automagically. kr,tom

2 2

[libvirt] [PATCH] fix detach-disk for inactive xen domains
by Jim Fehlig 15 Nov '09

15 Nov '09

detach-disk was not working for inactive xen domains due to lookup of device ID from xenstore. When detaching disks there is no need to use device id as device name can be used directly. Unfortunately that same is not true for network devices. In fact, AFAICT, there is no way to "hot unplug" a network device from inactive domain using xen tools. I have tested attaching/detaching disks to/from both active and inactive domains. I've also ensured no regressions in attaching/detaching network devices on active domains and attaching network devices on inactive domains. As noted above, detaching network devices from inactive domains does not work, but I'm not sure what we can do about that since xen tools themselves don't support this. Any suggestions are kindly welcomed. Oh, and I also ensured all of these scenarios work with both PV and HVM domains. Regards, Jim

2 1

[libvirt] [PATCH] esx: Add documentation to the website
by Matthias Bolte 15 Nov '09

15 Nov '09

* docs/drivers.html.in: list the ESX driver * docs/drvesx.html.in: the new ESX driver documentation * docs/hvsupport.html.in: add the ESX driver to the matrix * docs/index.html.in, docs/sitemap.html.in: list the ESX driver * src/esx/esx_driver.c: fix and cleanup some comments --- docs/drivers.html.in | 1 + docs/drvesx.html.in | 497 ++++++++++++++++++++++++++++++++++++++++++++++++ docs/hvsupport.html.in | 69 +++++++- docs/index.html.in | 3 + docs/sitemap.html.in | 4 + src/esx/esx_driver.c | 8 +- 6 files changed, 574 insertions(+), 8 deletions(-) create mode 100644 docs/drvesx.html.in diff --git a/docs/drivers.html.in b/docs/drivers.html.in index 983115a..7e31434 100644 --- a/docs/drivers.html.in +++ b/docs/drivers.html.in @@ -24,6 +24,7 @@ <li><strong><a href="drvopenvz.html">OpenVZ</a></strong></li> <li><strong><a href="drvvbox.html">VirtualBox</a></strong></li> <li><strong><a href="drvone.html">OpenNebula</a></strong></li> + <li><strong><a href="drvesx.html">VMware ESX</a></strong></li> </ul> </body> </html> diff --git a/docs/drvesx.html.in b/docs/drvesx.html.in new file mode 100644 index 0000000..893c1e2 --- /dev/null +++ b/docs/drvesx.html.in @@ -0,0 +1,497 @@ +<html><body> + <h1>VMware ESX hypervisor driver</h1> + <ul id="toc"></ul> + <p> + The libvirt VMware ESX driver can manage VMware ESX/ESXi 3.5/4.0 and + VMware GSX 2.0, also called VMware Server 2.0, and possibly later + versions. + </p> + + + <h2><a name="prereq">Deployment pre-requisites</a></h2> + <p> + None. Any out-of-the-box installation of ESX/GSX should work. No + preparations are required on the server side, no libvirtd must be + installed on the ESX server. The driver uses version 2.5 of the remote, + SOAP based + <a href="http://www.vmware.com/support/developer/vc-sdk/visdk25pubs/ReferenceGuide/"> + VMware Virtual Infrastructure API</a> to communicate with the + ESX server, like the VMware Virtual Infrastructure Client does. Since + version 4.0 this API is called + <a href="http://www.vmware.com/support/developer/vc-sdk/visdk400pubs/ReferenceGuide/"> + VMware vSphere API</a>. + </p> + + <h2><a name="uri">Connections to the VMware ESX driver</a></h2> + <p> + Some example remote connection URIs for the driver are: + </p> +<pre> +esx://example.com (ESX over HTTPS) +gsx://example.com (GSX over HTTPS) +esx://example.com/?transport=http (ESX over HTTP) +esx://example.com/?no_verify=1 (ESX over HTTPS, but doesn't verify the server's SSL certificate) +</pre> + + + <h3><a name="uriformat">URI Format</a></h3> + <p> + URIs have this general form ('[...]' marks an optional part). + </p> +<pre> +type://[username@]hostname[:port]/[?extraparameters] +</pre> + <p> + The <code>type://</code> is either <code>esx://</code> or + <code>gsx://</code> and the driver selects the default port depending + on it. For ESX the default HTTPS port is 443, for GSX it is 8333. If + the port parameter is given, it overrides the default port. + </p> + + + <h4>Extra parameters</h4> + <p> + Extra parameters can be added to a URI as part of the query string + (the part following '?'). The driver understands the extra parameters + shown below. + </p> + <table class="top_table"> + <tr> + <th>Name</th> + <th>Values</th> + <th>Meaning</th> + </tr> + <tr> + <td> + <code>transport</code> + </td> + <td> + <code>http</code> or <code>https</code> + </td> + <td> + Overrides the default HTTPS transport. For ESX the default + HTTP port is 80, for GSX it is 8222. + </td> + </tr> + <tr> + <td> + <code>vcenter</code> + </td> + <td> + Hostname of a VMware vCenter + </td> + <td> + In order to perform a migration the driver needs to know the + VMware vCenter for the ESX server. + </td> + </tr> + <tr> + <td> + <code>no_verify</code> + </td> + <td> + <code>0</code> or <code>1</code> + </td> + <td> + If set to 1, this disables libcurl client checks of the server's + SSL certificate. The default value it 0. + </td> + </tr> + </table> + + + <h3><a name="auth">Authentication</a></h3> + <p> + In order to perform any useful operation the driver needs to log into + the ESX server. Therefore, only <code>virConnectOpenAuth</code> can be + used to connect to an ESX server, <code>virConnectOpen</code> and + <code>virConnectOpenReadOnly</code> don't work. + To log into an ESX server or vCenter the driver will request + credentials using the callback passed to the + <code>virConnectOpenAuth</code> function. The driver passes the + hostname as challenge parameter to the callback. This enables the + callback to distinguish between requests for ESX server and vCenter. + </p> + <p> + <strong>Note</strong>: During the ongoing driver development, testing + is done using an unrestricted <code>root</code> account. Problems may + occur if you use a restricted account. Detailed testing with restricted + accounts has not been done yet. + </p> + + + <h2><a name="xmlspecial">Specialties in the domain XML config</a></h2> + <p> + There are several specialties in the domain XML config for ESX domains. + </p> + + <h3>Restrictions</h3> + <p> + There are some restrictions for some values of the domain XML config. + The driver will complain if this restrictions are violated. + </p> + <ul> + <li> + Memory size has to be a multiple of 4096 + </li> + <li> + Number of virtual CPU has to be 1 or a multiple of 2 + </li> + <li> + Valid MAC address prefixes are <code>00:0c:29</code> and + <code>00:50:56</code> + </li> + </ul> + + + <h3>Datastore references</h3> + <p> + Storage is managed in datastores. VMware uses a special path format to + reference files in a datastore. Basically, the datastore name is put + into squared braces in front of the path. + </p> +<pre> +[datastore] directory/filename +</pre> + <p> + To define a new domain the driver converts the domain XML into a + VMware VMX file and uploads it to a datastore known to the ESX server. + Because multiple datastores may be known to an ESX server the driver + needs to decide to which datastores the VMX file should be uploaded. + The driver deduces this information from the path of the source of the + first file-based harddisk listed in the domain XML. + </p> + + + <h3>Available hardware</h3> + <p> + VMware ESX supports different models of SCSI controllers and network + cards. + </p> + + <h4>SCSI controller models</h4> + <dl> + <dt><code>buslogic</code></dt> + <dd> + BusLogic SCSI controller for older guests. + </dd> + <dt><code>lsilogic</code></dt> + <dd> + LSI Logic SCSI controller for recent guests. + </dd> + </dl> + <p> + Here a domain XML snippet: + </p> +<pre> + ... + <disk type='file' device='disk'> + <driver name='<strong>lsilogic</strong>'/> + <source file='[local-storage] Fedora11/Fedora11.vmdk'/> + <target dev='sda' bus='scsi'/> + </disk> + ... +</pre> + + + <h4>Network card models</h4> + <dl> + <dt><code>vlance</code></dt> + <dd> + AMD PCnet32 network card for older guests. + </dd> + <dt><code>vmxnet</code>, <code>vmxnet3</code></dt> + <dd> + Special VMware VMXnet network card, requires VMware tools inside + the guest. + </dd> + <dt><code>e1000</code></dt> + <dd> + Intel E1000 network card for recent guests. + </dd> + </dl> + <p> + Here a domain XML snippet: + </p> +<pre> + ... + <interface type='bridge'> + <mac address='00:50:56:25:48:c7'/> + <source bridge='VM Network'/> + <model type='<strong>e1000</strong>'/> + </interface> + ... +</pre> + + + <h2><a name="importexport">Import and export of domain XML configs</a></h2> + <p> + The ESX driver currently supports a native config format known as + <code>vmware-vmx</code> to handle VMware VMX configs. + </p> + + + <h3><a name="xmlimport">Converting from VMware VMX config to domain XML config</a></h3> + <p> + The <code>virsh domxml-from-native</code> provides a way to convert an + existing VMware VMX config into a domain XML config that can then be + used by libvirt. + </p> +<pre> +$ cat > demo.vmx << EOF +#!/usr/bin/vmware +config.version = "8" +virtualHW.version = "4" +floppy0.present = "false" +nvram = "Fedora11.nvram" +deploymentPlatform = "windows" +virtualHW.productCompatibility = "hosted" +tools.upgrade.policy = "useGlobal" +powerType.powerOff = "default" +powerType.powerOn = "default" +powerType.suspend = "default" +powerType.reset = "default" +displayName = "Fedora11" +extendedConfigFile = "Fedora11.vmxf" +scsi0.present = "true" +scsi0.sharedBus = "none" +scsi0.virtualDev = "lsilogic" +memsize = "1024" +scsi0:0.present = "true" +scsi0:0.fileName = "/vmfs/volumes/498076b2-02796c1a-ef5b-000ae484a6a3/Fedora11/Fedora11.vmdk" +scsi0:0.deviceType = "scsi-hardDisk" +ide0:0.present = "true" +ide0:0.clientDevice = "true" +ide0:0.deviceType = "cdrom-raw" +ide0:0.startConnected = "false" +ethernet0.present = "true" +ethernet0.networkName = "VM Network" +ethernet0.addressType = "vpx" +ethernet0.address = "00:50:56:91:48:c7" +chipset.onlineStandby = "false" +guestOSAltName = "Red Hat Enterprise Linux 5 (32-Bit)" +guestOS = "rhel5" +uuid.bios = "50 11 5e 16 9b dc 49 d7-f1 71 53 c4 d7 f9 17 10" +snapshot.action = "keep" +sched.cpu.min = "0" +sched.cpu.units = "mhz" +sched.cpu.shares = "normal" +sched.mem.minsize = "0" +sched.mem.shares = "normal" +toolScripts.afterPowerOn = "true" +toolScripts.afterResume = "true" +toolScripts.beforeSuspend = "true" +toolScripts.beforePowerOff = "true" +scsi0:0.redo = "" +tools.syncTime = "false" +uuid.location = "56 4d b5 06 a2 bd fb eb-ae 86 f7 d8 49 27 d0 c4" +sched.cpu.max = "unlimited" +sched.swap.derivedName = "/vmfs/volumes/498076b2-02796c1a-ef5b-000ae484a6a3/Fedora11/Fedora11-7de040d8.vswp" +tools.remindInstall = "TRUE" +EOF + +$ virsh -c esx://example.com domxml-from-native vmware-vmx demo.vmx +Enter username for example.com [root]: +Enter root password for example.com: +<domain type='vmware'> + <name>Fedora11</name> + <uuid>50115e16-9bdc-49d7-f171-53c4d7f91710</uuid> + <memory>1048576</memory> + <currentMemory>1048576</currentMemory> + <vcpu>1</vcpu> + <os> + <type arch='i686'>hvm</type> + </os> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <disk type='file' device='disk'> + <driver name='lsilogic'/> + <source file='[local-storage] Fedora11/Fedora11.vmdk'/> + <target dev='sda' bus='scsi'/> + </disk> + <interface type='bridge'> + <mac address='00:50:56:91:48:c7'/> + <source bridge='VM Network'/> + </interface> + </devices> +</domain> +</pre> + + + <h3><a name="xmlexport">Converting from domain XML config to VMware VMX config</a></h3> + <p> + The <code>virsh domxml-to-native</code> provides a way to convert a + domain XML config into a VMware VMX config. + </p> +<pre> +$ cat > demo.xml << EOF +<domain type='vmware'> + <name>Fedora11</name> + <uuid>50115e16-9bdc-49d7-f171-53c4d7f91710</uuid> + <memory>1048576</memory> + <currentMemory>1048576</currentMemory> + <vcpu>1</vcpu> + <os> + <type arch='x86_64'>hvm</type> + </os> + <devices> + <disk type='file' device='disk'> + <driver name='lsilogic'/> + <source file='[local-storage] Fedora11/Fedora11.vmdk'/> + <target dev='sda' bus='scsi'/> + </disk> + <interface type='bridge'> + <mac address='00:50:56:25:48:c7'/> + <source bridge='VM Network'/> + </interface> + </devices> +</domain> +EOF + +$ virsh -c esx://example.com domxml-to-native vmware-vmx demo.xml +Enter username for example.com [root]: +Enter root password for example.com: +config.version = "8" +virtualHW.version = "4" +guestOS = "other-64" +uuid.bios = "50 11 5e 16 9b dc 49 d7-f1 71 53 c4 d7 f9 17 10" +displayName = "Fedora11" +memsize = "1024" +numvcpus = "1" +scsi0.present = "true" +scsi0.virtualDev = "lsilogic" +scsi0:0.present = "true" +scsi0:0.deviceType = "scsi-hardDisk" +scsi0:0.fileName = "/vmfs/volumes/local-storage/Fedora11/Fedora11.vmdk" +ethernet0.present = "true" +ethernet0.networkName = "VM Network" +ethernet0.connectionType = "bridged" +ethernet0.addressType = "static" +ethernet0.address = "00:50:56:25:48:C7" +</pre> + + + <h2><a name="xmlconfig">Example domain XML configs</a></h2> + + <h3>Fedora11 on x86_64</h3> +<pre> +<domain type='vmware'> + <name>Fedora11</name> + <uuid>50115e16-9bdc-49d7-f171-53c4d7f91710</uuid> + <memory>1048576</memory> + <currentMemory>1048576</currentMemory> + <vcpu>1</vcpu> + <os> + <type arch='x86_64'>hvm</type> + </os> + <devices> + <disk type='file' device='disk'> + <source file='[local-storage] Fedora11/Fedora11.vmdk'/> + <target dev='sda' bus='scsi'/> + </disk> + <interface type='bridge'> + <mac address='00:50:56:25:48:c7'/> + <source bridge='VM Network'/> + </interface> + </devices> +</domain> +</pre> + + + <h2><a name="migration">Migration</a></h2> + <p> + A migration cannot be initiated on an ESX server directly, a VMware + vCenter is necessary for this. The vCenter hostname has to be passed + to the driver via the <code>vcenter</code> query parameter. + </p> +<pre> +esx://example.com/?vcenter=example-vcenter.com +</pre> + <p> + Here an example how to migrate the domain <code>Fedora11</code> from + ESX server <code>example-src.com</code> to ESX server + <code>example-dst.com</code> involving vCenter + <code>example-vcenter.com</code> using <code>virsh</code>. + </p> +<pre> +$ virsh -c esx://example-src.com/?vcenter=example-vcenter.com migrate Fedora11 esx://example-dst.com/?vcenter=example-vcenter.com +Enter username for example-src.com [root]: +Enter root password for example-src.com: +Enter username for example-vcenter.com [administrator]: +Enter administrator password for example-vcenter.com: +Enter username for example-dst.com [root]: +Enter root password for example-dst.com: +Enter username for example-vcenter.com [administrator]: +Enter administrator password for example-vcenter.com: +</pre> + + + <h2><a name="scheduler">Scheduler configuration</a></h2> + <p> + The driver exposes the ESX CPU scheduler. The parameters listed below + are available to control the scheduler. + </p> + <dl> + <dt><code>reservation</code></dt> + <dd> + The amount of CPU resource in MHz that is guaranteed to be + available to the domain. Valid values are 0 and greater. + </dd> + <dt><code>limit</code></dt> + <dd> + The CPU utilization of the domain will be + limited to this value in MHz, even if more CPU resources are + available. If the limit is set to -1, the CPU utilization of the + domain is unlimited. If the limit is not set to -1, it must be + greater than or equal to the reservation. + </dd> + <dt><code>shares</code></dt> + <dd> + Shares are used to determine relative CPU + allocation between domains. In general, a domain with more shares + gets proportionally more of the CPU resource. Valid values are 0 + and greater. The special values -1, -2 and -3 represent the + predefined shares level <code>low</code>, <code>normal</code> and + <code>high</code>. + </dd> + </dl> + + + <h2><a name="tools">VMware tools</a></h2> + <p> + Some actions require installed VMware tools. If the VMware tools are + not installed in the guest and one of the actions below is to be + performed the ESX server raises an error and the driver reports it. + </p> + <ul> + <li> + <code>virDomainReboot</code> + </li> + <li> + <code>virDomainShutdown</code> + </li> + </ul> + + + <h2><a name="links">Links</a></h2> + <ul> + <li> + <a href="http://www.vmware.com/support/developer/vc-sdk/"> + VMware vSphere Web Services SDK Documentation + </a> + </li> + <li> + <a href="http://www.vmware.com/pdf/esx3_memory.pdf"> + The Role of Memory in VMware ESX Server 3 + </a> + </li> + <li> + <a href="http://www.sanbarrow.com/vmx.html"> + VMware VMX config parameters + </a> + </li> + </ul> +</body></html> diff --git a/docs/hvsupport.html.in b/docs/hvsupport.html.in index 4775561..4cc2634 100644 --- a/docs/hvsupport.html.in +++ b/docs/hvsupport.html.in @@ -23,6 +23,7 @@ updated on <i>2008-06-05</i>. <th><a href="remote.html">Remote</a></th> <th><a href="drvvbox.html">VirtualBox</a></th> <th><a href="drvone.html">ONE</a></th> + <th><a href="drvesx.html">ESX</a></th> </tr> <tr> <td> virConnectClose </td> @@ -33,6 +34,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> ≥ 0.6.4 </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virConnectGetCapabilities </td> @@ -43,6 +45,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> ≥ 0.6.4 </td> + <td> ≥ 0.7.1 </td> </tr> <tr> <td> virConnectGetHostname </td> @@ -53,6 +56,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> x </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virConnectGetMaxVcpus </td> @@ -63,6 +67,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> x </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virConnectGetType </td> @@ -73,6 +78,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> ≥ 0.6.4 </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virConnectGetURI </td> @@ -83,6 +89,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> ≥ 0.6.4 </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virConnectGetVersion </td> @@ -93,6 +100,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> ≥ 0.6.4 </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virConnectListDefinedDomains </td> @@ -103,6 +111,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> ≥ 0.6.4 </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virConnectListDomains </td> @@ -113,6 +122,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> ≥ 0.6.4 </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virConnectNumOfDefinedDomains </td> @@ -123,6 +133,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> ≥ 0.6.4 </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virConnectNumOfDomains </td> @@ -133,6 +144,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> ≥ 0.6.4 </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virConnectOpen </td> @@ -143,6 +155,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> ≥ 0.6.4 </td> + <td> x </td> </tr> <tr> <td> virConnectOpenAuth </td> @@ -153,6 +166,7 @@ updated on <i>2008-06-05</i>. <td> </td> <td> </td> <td> </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virConnectOpenReadOnly </td> @@ -163,6 +177,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> x </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainAttachDevice </td> @@ -173,6 +188,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainBlockPeek </td> @@ -183,6 +199,7 @@ updated on <i>2008-06-05</i>. <td> x </td> <td> x </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainBlockStats </td> @@ -193,6 +210,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.2 </td> <td> x </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainCoreDump </td> @@ -203,6 +221,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> x </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainCreate </td> @@ -213,6 +232,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> ≥ 0.6.4 </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virDomainCreateLinux </td> @@ -223,6 +243,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> ≥ 0.6.4 </td> + <td> x </td> </tr> <tr> <td> virDomainDefineXML </td> @@ -233,6 +254,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> ≥ 0.6.4 </td> + <td> ≥ 0.7.2 </td> </tr> <tr> <td> virDomainDestroy </td> @@ -243,6 +265,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> ≥ 0.6.4 </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virDomainDetachDevice </td> @@ -253,6 +276,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainFree </td> @@ -263,6 +287,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> ≥ 0.6.4 </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virDomainGetAutostart </td> @@ -273,11 +298,12 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> x </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainGetConnect </td> <td> 0.3.0 </td> - <td colspan="6"> not a HV function </td> + <td colspan="7"> not a HV function </td> </tr> <tr> <td> virDomainGetID </td> @@ -288,6 +314,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> ≥ 0.6.4 </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virDomainGetInfo </td> @@ -298,6 +325,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> ≥ 0.6.4 </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virDomainGetMaxMemory </td> @@ -308,6 +336,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> x </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virDomainGetMaxVcpus </td> @@ -318,6 +347,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> x </td> <td> x </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virDomainGetName </td> @@ -328,6 +358,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> ≥ 0.6.4 </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virDomainGetOSType </td> @@ -338,6 +369,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> ≥ 0.6.4 </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virDomainGetSchedulerParameters </td> @@ -348,6 +380,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> x </td> <td> x </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virDomainGetSchedulerType </td> @@ -358,6 +391,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> x </td> <td> x </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virDomainGetUUID </td> @@ -368,6 +402,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> ≥ 0.6.4 </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virDomainGetUUIDString </td> @@ -378,6 +413,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> ≥ 0.6.4 </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virDomainGetVcpus </td> @@ -388,6 +424,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> x </td> <td> x </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virDomainInterfaceStats </td> @@ -398,6 +435,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.2 </td> <td> x </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainGetXMLDesc </td> @@ -408,6 +446,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> x </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virDomainLookupByID </td> @@ -418,6 +457,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> ≥ 0.6.4 </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virDomainLookupByName </td> @@ -428,6 +468,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> ≥ 0.6.4 </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virDomainLookupByUUID </td> @@ -438,6 +479,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> ≥ 0.6.4 </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virDomainLookupByUUIDString </td> @@ -448,6 +490,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> ≥ 0.6.4 </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virDomainMigrate </td> @@ -458,6 +501,7 @@ updated on <i>2008-06-05</i>. <td> 0.3.2 </td> <td> x </td> <td> x </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virDomainPinVcpu </td> @@ -468,6 +512,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> x </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainReboot </td> @@ -478,6 +523,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> x </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virDomainRestore </td> @@ -488,7 +534,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> x </td> <td> x </td> - + <td> x </td> </tr> <tr> <td> virDomainResume </td> @@ -499,6 +545,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> ≥ 0.6.4 </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virDomainSave </td> @@ -509,6 +556,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainSetAutostart </td> @@ -519,6 +567,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> x </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainSetMaxMemory </td> @@ -528,6 +577,8 @@ updated on <i>2008-06-05</i>. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virDomainSetMemory </td> @@ -538,6 +589,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> x </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virDomainSetSchedulerParameters </td> @@ -548,6 +600,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> x </td> <td> x </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virDomainSetVcpus </td> @@ -558,6 +611,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> x </td> <td> x </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virDomainShutdown </td> @@ -568,6 +622,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> ≥ 0.6.4 </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virDomainSuspend </td> @@ -578,6 +633,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> ≥ 0.6.4 </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virDomainUndefine </td> @@ -588,17 +644,18 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> ≥ 0.6.4 </td> + <td> ≥ 0.7.1 </td> </tr> <tr> <td> virGetVersion </td> <td> All </td> <td> All </td> - <td colspan="5"> Returns -1 if HV unsupported. </td> + <td colspan="6"> Returns -1 if HV unsupported. </td> </tr> <tr> <td> virInitialize </td> <td> 0.1.0 </td> - <td colspan="6"> not a HV function </td> + <td colspan="7"> not a HV function </td> </tr> <tr> <td> virDomainMemoryPeek </td> @@ -609,6 +666,7 @@ updated on <i>2008-06-05</i>. <td> x </td> <td> x </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virNodeGetInfo </td> @@ -619,6 +677,7 @@ updated on <i>2008-06-05</i>. <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> <td> x </td> + <td> ≥ 0.7.0 </td> </tr> <tr> <td> virNodeGetFreeMemory </td> @@ -629,6 +688,7 @@ updated on <i>2008-06-05</i>. <td> x </td> <td> x </td> <td> x </td> + <td> ≥ 0.7.2 </td> </tr> <tr> <td> virNodeGetCellsFreeMemory </td> @@ -639,6 +699,7 @@ updated on <i>2008-06-05</i>. <td> x </td> <td> x </td> <td> x </td> + <td> x </td> </tr> </table> <h3>Network functions</h3> diff --git a/docs/index.html.in b/docs/index.html.in index efb7e8a..57ea84e 100644 --- a/docs/index.html.in +++ b/docs/index.html.in @@ -56,6 +56,9 @@ The <a href="http://www.virtualbox.org/">VirtualBox</a> hypervisor </li> <li> + The <a href="http://www.vmware.com/">VMware ESX and GSX</a> hypervisors + </li> + <li> Storage on IDE/SCSI/USB disks, FibreChannel, LVM, iSCSI, NFS and filesystems </li> </ul> diff --git a/docs/sitemap.html.in b/docs/sitemap.html.in index a999da4..424897f 100644 --- a/docs/sitemap.html.in +++ b/docs/sitemap.html.in @@ -160,6 +160,10 @@ <a href="drvone.html">OpenNebula</a> <span>Driver for OpenNebula</span> </li> + <li> + <a href="drvesx.html">VMware ESX</a> + <span>Driver for VMware ESX</span> + </li> </ul> </li> <li> diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index fe75aa3..b84250c 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -247,7 +247,7 @@ esxCapsInit(virConnectPtr conn) * If no port is specified the default port is set dependent on the scheme and * transport parameter: * - esx+http 80 - * - esx+https 433 + * - esx+https 443 * - gsx+http 8222 * - gsx+https 8333 * @@ -2791,13 +2791,13 @@ esxDomainUndefine(virDomainPtr domain) * * - reservation (VIR_DOMAIN_SCHED_FIELD_LLONG >= 0, in megaherz) * - * Amount of CPU resource that is guaranteed available to the domain. + * The amount of CPU resource that is guaranteed to be available to the domain. * * * - limit (VIR_DOMAIN_SCHED_FIELD_LLONG >= 0, or -1, in megaherz) * - * The CPU utilization of the domain will not exceed this limit, even if - * there are available CPU resources. If the limit is set to -1, the CPU + * The CPU utilization of the domain will be limited to this value, even if + * more CPU resources are available. If the limit is set to -1, the CPU * utilization of the domain is unlimited. If the limit is not set to -1, it * must be greater than or equal to the reservation. * -- 1.6.0.4

2 2

[libvirt] [PATCH] esx: Fix CPU clock Hz to MHz conversion
by Matthias Bolte 15 Nov '09

15 Nov '09

--- src/esx/esx_driver.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index b84250c..5737fe9 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -878,7 +878,7 @@ esxNodeGetInfo(virConnectPtr conn, virNodeInfoPtr nodeinfo) nodeinfo->memory = memorySize / 1024; /* Scale from bytes to kilobytes */ nodeinfo->cpus = cpuInfo_numCpuCores; - nodeinfo->mhz = cpuInfo_hz / (1024 * 1024); /* Scale from hz to mhz */ + nodeinfo->mhz = cpuInfo_hz / (1000 * 1000); /* Scale from hz to mhz */ nodeinfo->nodes = numaInfo_numNodes; nodeinfo->sockets = cpuInfo_numCpuPackages; nodeinfo->cores = cpuInfo_numCpuPackages > 0 -- 1.6.0.4

2 2

[libvirt] [PATCH] esx: Fix memory leak in esxVI_HostCpuIdInfo_Free()
by Matthias Bolte 15 Nov '09

15 Nov '09

--- src/esx/esx_vi_types.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/esx/esx_vi_types.c b/src/esx/esx_vi_types.c index 73d3069..9af9f73 100644 --- a/src/esx/esx_vi_types.c +++ b/src/esx/esx_vi_types.c @@ -1496,6 +1496,7 @@ ESX_VI__TEMPLATE__FREE(HostCpuIdInfo, { esxVI_HostCpuIdInfo_Free(&item->_next); + esxVI_Int_Free(&item->level); VIR_FREE(item->vendor); VIR_FREE(item->eax); VIR_FREE(item->ebx); -- 1.6.0.4

2 1

[libvirt] [PATCH] esx: Fix MAC address formatting
by Matthias Bolte 15 Nov '09

15 Nov '09

VMware uses two MAC address prefixes: 00:0c:29 and 00:50:56. The 00:0c:29 prefix is used for ESX server generated addresses. The 00:50:56 prefix is split into two parts. MAC addresses above 00:50:56:3f:ff:ff are generated by a vCenter. The rest of the 00:50:56 prefix can be assigned manually. Any MAC address within the 00:0c:29 and 00:50:56 prefix can be specified in a domain XML config and the driver will handle the details internally. * src/esx/esx_vmx.c: fix MAC address formatting * tests/xml2vmxdata/*: update test files accordingly --- src/esx/esx_vmx.c | 21 ++++++++++++++++++--- tests/xml2vmxdata/xml2vmx-esx-in-the-wild-1.vmx | 2 +- tests/xml2vmxdata/xml2vmx-esx-in-the-wild-2.vmx | 1 + tests/xml2vmxdata/xml2vmx-esx-in-the-wild-3.vmx | 1 + tests/xml2vmxdata/xml2vmx-esx-in-the-wild-4.vmx | 4 ++-- tests/xml2vmxdata/xml2vmx-ethernet-bridged.vmx | 4 ++-- tests/xml2vmxdata/xml2vmx-ethernet-custom.vmx | 4 ++-- tests/xml2vmxdata/xml2vmx-ethernet-e1000.vmx | 4 ++-- tests/xml2vmxdata/xml2vmx-gsx-in-the-wild-1.vmx | 1 + tests/xml2vmxdata/xml2vmx-gsx-in-the-wild-2.vmx | 1 + tests/xml2vmxdata/xml2vmx-gsx-in-the-wild-3.vmx | 2 ++ tests/xml2vmxdata/xml2vmx-gsx-in-the-wild-4.vmx | 1 + 12 files changed, 34 insertions(+), 12 deletions(-) diff --git a/src/esx/esx_vmx.c b/src/esx/esx_vmx.c index 97ad43e..9a9fe0a 100644 --- a/src/esx/esx_vmx.c +++ b/src/esx/esx_vmx.c @@ -277,8 +277,10 @@ def->nets[0]... ethernet0.addressType = "vpx" # default to "generated" ->mac = <value> <=> ethernet0.generatedAddress = "<value>" - # 00:0c:29 prefix for autogenerated mac's + # 00:0c:29 prefix for autogenerated mac's -> ethernet0.addressType = "generated" # 00:50:56 prefix for manual configured mac's + # 00:50:56:00:00:00 - 00:50:56:3f:ff:ff -> ethernet0.addressType = "static" + # 00:50:56:40:00:00 - 00:50:56:ff:ff:ff -> ethernet0.addressType = "vpx" # 00:05:69 old prefix from esx 1.5 @@ -2687,12 +2689,25 @@ esxVMX_FormatEthernet(virConnectPtr conn, virDomainNetDefPtr def, virFormatMacAddr(def->mac, mac_string); - if ((def->mac[0] == 0x00 && def->mac[1] == 0x0c && def->mac[2] == 0x29) || - (def->mac[0] == 0x00 && def->mac[1] == 0x50 && def->mac[2] == 0x56)) { + if (def->mac[0] == 0x00 && def->mac[1] == 0x0c && def->mac[2] == 0x29) { virBufferVSprintf(buffer, "ethernet%d.addressType = \"generated\"\n", controller); virBufferVSprintf(buffer, "ethernet%d.generatedAddress = \"%s\"\n", controller, mac_string); + virBufferVSprintf(buffer, "ethernet%d.generatedAddressOffset = \"0\"\n", + controller); + } else if (def->mac[0] == 0x00 && def->mac[1] == 0x50 && def->mac[2] == 0x56) { + if (def->mac[3] <= 0x3f) { + virBufferVSprintf(buffer, "ethernet%d.addressType = \"static\"\n", + controller); + virBufferVSprintf(buffer, "ethernet%d.address = \"%s\"\n", + controller, mac_string); + } else { + virBufferVSprintf(buffer, "ethernet%d.addressType = \"vpx\"\n", + controller); + virBufferVSprintf(buffer, "ethernet%d.generatedAddress = \"%s\"\n", + controller, mac_string); + } } else { ESX_ERROR(conn, VIR_ERR_INTERNAL_ERROR, "Unsupported MAC address prefix '%02X:%02X:%02X', expecting " diff --git a/tests/xml2vmxdata/xml2vmx-esx-in-the-wild-1.vmx b/tests/xml2vmxdata/xml2vmx-esx-in-the-wild-1.vmx index ea14588..077d907 100644 --- a/tests/xml2vmxdata/xml2vmx-esx-in-the-wild-1.vmx +++ b/tests/xml2vmxdata/xml2vmx-esx-in-the-wild-1.vmx @@ -13,5 +13,5 @@ scsi0:0.fileName = "/vmfs/volumes/498076b2-02796c1a-ef5b-000ae484a6a3/Fedora11/F ethernet0.present = "true" ethernet0.networkName = "VM Network" ethernet0.connectionType = "bridged" -ethernet0.addressType = "generated" +ethernet0.addressType = "vpx" ethernet0.generatedAddress = "00:50:56:91:48:C7" diff --git a/tests/xml2vmxdata/xml2vmx-esx-in-the-wild-2.vmx b/tests/xml2vmxdata/xml2vmx-esx-in-the-wild-2.vmx index 05e3d46..f507548 100644 --- a/tests/xml2vmxdata/xml2vmx-esx-in-the-wild-2.vmx +++ b/tests/xml2vmxdata/xml2vmx-esx-in-the-wild-2.vmx @@ -36,3 +36,4 @@ ethernet0.networkName = "VM Network" ethernet0.connectionType = "bridged" ethernet0.addressType = "generated" ethernet0.generatedAddress = "00:0C:29:3C:98:3E" +ethernet0.generatedAddressOffset = "0" diff --git a/tests/xml2vmxdata/xml2vmx-esx-in-the-wild-3.vmx b/tests/xml2vmxdata/xml2vmx-esx-in-the-wild-3.vmx index d418475..10559fb 100644 --- a/tests/xml2vmxdata/xml2vmx-esx-in-the-wild-3.vmx +++ b/tests/xml2vmxdata/xml2vmx-esx-in-the-wild-3.vmx @@ -22,3 +22,4 @@ ethernet0.networkName = "VM Network" ethernet0.connectionType = "bridged" ethernet0.addressType = "generated" ethernet0.generatedAddress = "00:0C:29:F5:C3:0C" +ethernet0.generatedAddressOffset = "0" diff --git a/tests/xml2vmxdata/xml2vmx-esx-in-the-wild-4.vmx b/tests/xml2vmxdata/xml2vmx-esx-in-the-wild-4.vmx index 68f6d6d..068f0f8 100644 --- a/tests/xml2vmxdata/xml2vmx-esx-in-the-wild-4.vmx +++ b/tests/xml2vmxdata/xml2vmx-esx-in-the-wild-4.vmx @@ -13,12 +13,12 @@ scsi0:0.fileName = "/vmfs/volumes/498076b2-02796c1a-ef5b-000ae484a6a3/virtMonSer ethernet0.present = "true" ethernet0.networkName = "VM Network" ethernet0.connectionType = "bridged" -ethernet0.addressType = "generated" +ethernet0.addressType = "vpx" ethernet0.generatedAddress = "00:50:56:91:66:D4" ethernet1.present = "true" ethernet1.networkName = "VM Switch 2" ethernet1.connectionType = "bridged" -ethernet1.addressType = "generated" +ethernet1.addressType = "vpx" ethernet1.generatedAddress = "00:50:56:91:0C:51" serial0.present = "true" serial0.fileType = "file" diff --git a/tests/xml2vmxdata/xml2vmx-ethernet-bridged.vmx b/tests/xml2vmxdata/xml2vmx-ethernet-bridged.vmx index 73ca8a8..7d9c6f7 100644 --- a/tests/xml2vmxdata/xml2vmx-ethernet-bridged.vmx +++ b/tests/xml2vmxdata/xml2vmx-ethernet-bridged.vmx @@ -8,5 +8,5 @@ numvcpus = "1" ethernet0.present = "true" ethernet0.networkName = "VM Network" ethernet0.connectionType = "bridged" -ethernet0.addressType = "generated" -ethernet0.generatedAddress = "00:50:56:11:22:33" +ethernet0.addressType = "static" +ethernet0.address = "00:50:56:11:22:33" diff --git a/tests/xml2vmxdata/xml2vmx-ethernet-custom.vmx b/tests/xml2vmxdata/xml2vmx-ethernet-custom.vmx index cc42140..fb4b116 100644 --- a/tests/xml2vmxdata/xml2vmx-ethernet-custom.vmx +++ b/tests/xml2vmxdata/xml2vmx-ethernet-custom.vmx @@ -9,5 +9,5 @@ ethernet0.present = "true" ethernet0.networkName = "VM Network" ethernet0.connectionType = "custom" ethernet0.vnet = "vmnet7" -ethernet0.addressType = "generated" -ethernet0.generatedAddress = "00:50:56:11:22:33" +ethernet0.addressType = "static" +ethernet0.address = "00:50:56:11:22:33" diff --git a/tests/xml2vmxdata/xml2vmx-ethernet-e1000.vmx b/tests/xml2vmxdata/xml2vmx-ethernet-e1000.vmx index dd2c86d..3aed46c 100644 --- a/tests/xml2vmxdata/xml2vmx-ethernet-e1000.vmx +++ b/tests/xml2vmxdata/xml2vmx-ethernet-e1000.vmx @@ -9,5 +9,5 @@ ethernet0.present = "true" ethernet0.virtualDev = "e1000" ethernet0.networkName = "VM Network" ethernet0.connectionType = "bridged" -ethernet0.addressType = "generated" -ethernet0.generatedAddress = "00:50:56:11:22:33" +ethernet0.addressType = "static" +ethernet0.address = "00:50:56:11:22:33" diff --git a/tests/xml2vmxdata/xml2vmx-gsx-in-the-wild-1.vmx b/tests/xml2vmxdata/xml2vmx-gsx-in-the-wild-1.vmx index 8b2d6a4..526fe3c 100644 --- a/tests/xml2vmxdata/xml2vmx-gsx-in-the-wild-1.vmx +++ b/tests/xml2vmxdata/xml2vmx-gsx-in-the-wild-1.vmx @@ -14,3 +14,4 @@ ethernet0.connectionType = "custom" ethernet0.vnet = "/dev/vmnet1" ethernet0.addressType = "generated" ethernet0.generatedAddress = "00:0C:29:D6:2B:D3" +ethernet0.generatedAddressOffset = "0" diff --git a/tests/xml2vmxdata/xml2vmx-gsx-in-the-wild-2.vmx b/tests/xml2vmxdata/xml2vmx-gsx-in-the-wild-2.vmx index d811b7f..34f006d 100644 --- a/tests/xml2vmxdata/xml2vmx-gsx-in-the-wild-2.vmx +++ b/tests/xml2vmxdata/xml2vmx-gsx-in-the-wild-2.vmx @@ -14,3 +14,4 @@ ethernet0.connectionType = "custom" ethernet0.vnet = "/dev/vmnet1" ethernet0.addressType = "generated" ethernet0.generatedAddress = "00:0C:29:D6:CB:A4" +ethernet0.generatedAddressOffset = "0" diff --git a/tests/xml2vmxdata/xml2vmx-gsx-in-the-wild-3.vmx b/tests/xml2vmxdata/xml2vmx-gsx-in-the-wild-3.vmx index 7109fb9..a2a3575 100644 --- a/tests/xml2vmxdata/xml2vmx-gsx-in-the-wild-3.vmx +++ b/tests/xml2vmxdata/xml2vmx-gsx-in-the-wild-3.vmx @@ -14,9 +14,11 @@ ethernet0.connectionType = "custom" ethernet0.vnet = "/dev/vmnet1" ethernet0.addressType = "generated" ethernet0.generatedAddress = "00:0C:29:C4:BE:5A" +ethernet0.generatedAddressOffset = "0" ethernet1.present = "true" ethernet1.networkName = "net2" ethernet1.connectionType = "custom" ethernet1.vnet = "/dev/vmnet2" ethernet1.addressType = "generated" ethernet1.generatedAddress = "00:0C:29:C4:BE:64" +ethernet1.generatedAddressOffset = "0" diff --git a/tests/xml2vmxdata/xml2vmx-gsx-in-the-wild-4.vmx b/tests/xml2vmxdata/xml2vmx-gsx-in-the-wild-4.vmx index ee9b8c9..765d35c 100644 --- a/tests/xml2vmxdata/xml2vmx-gsx-in-the-wild-4.vmx +++ b/tests/xml2vmxdata/xml2vmx-gsx-in-the-wild-4.vmx @@ -14,3 +14,4 @@ ethernet0.connectionType = "custom" ethernet0.vnet = "/dev/vmnet2" ethernet0.addressType = "generated" ethernet0.generatedAddress = "00:0C:29:C5:E3:5D" +ethernet0.generatedAddressOffset = "0" -- 1.6.0.4

2 1

[libvirt] [PATCH] Change DTD references to use public instead of system identifier
by Matthias Bolte 15 Nov '09

15 Nov '09

Debian's /etc/xml/catalog doesn't contain system identifiers, so use public identifiers instead. * docs/Makefile.am: use public instead of system identifier * docs/site.xsl: use matching public identifier --- docs/Makefile.am | 6 +++--- docs/site.xsl | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index d819869..d53f305 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -106,7 +106,7 @@ ChangeLog.html.in: ChangeLog.xml ChangeLog.xsl %.html: %.html.tmp @(if [ -x $(XMLLINT) -a -x $(XMLCATALOG) ] ; then \ - if $(XMLCATALOG) /etc/xml/catalog "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd" > /dev/null ; then \ + if $(XMLCATALOG) /etc/xml/catalog "-//W3C//DTD XHTML 1.0 Strict//EN" > /dev/null ; then \ echo "Validating $@" ; \ $(XMLLINT) --nonet --format --valid $< > $@ || : ; \ else echo "missing XHTML1 DTD" ; fi ; fi ); @@ -117,7 +117,7 @@ html/index.html: libvirt-api.xml newapi.xsl page.xsl sitemap.html.in echo "Rebuilding the HTML pages from the XML API" ; \ $(XSLTPROC) --nonet $(srcdir)/newapi.xsl libvirt-api.xml ; fi ) -@(if [ -x $(XMLLINT) -a -x $(XMLCATALOG) ] ; then \ - if $(XMLCATALOG) /etc/xml/catalog "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd" > /dev/null ; then \ + if $(XMLCATALOG) /etc/xml/catalog "-//W3C//DTD XHTML 1.0 Strict//EN" > /dev/null ; then \ echo "Validating the resulting XHTML pages" ; \ $(XMLLINT) --nonet --valid --noout html/*.html ; \ else echo "missing XHTML1 DTD" ; fi ; fi ); @@ -159,4 +159,4 @@ uninstall-local: for h in $(apihtml); do rm $(DESTDIR)$(HTML_DIR)/$$h; done for p in $(apipng); do rm $(DESTDIR)$(HTML_DIR)/$$p; done for f in $(devhelphtml) $(devhelppng) $(devhelpcss); do \ - rm $(DESTDIR)$(DEVHELP_DIR)$$f ; done \ No newline at end of file + rm $(DESTDIR)$(DEVHELP_DIR)$$f ; done diff --git a/docs/site.xsl b/docs/site.xsl index b2983bd..86cfd41 100644 --- a/docs/site.xsl +++ b/docs/site.xsl @@ -11,7 +11,7 @@ method="xml" encoding="ISO-8859-1" indent="yes" - doctype-public="-//W3C//DTD XHTML 1.0//EN" + doctype-public="-//W3C//DTD XHTML 1.0 Strict//EN" doctype-system="http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"/> <xsl:variable name="href_base" select="''"/> -- 1.6.0.4

2 1

[libvirt] [PATCH] esx: Handle 'vmxnet3' in esxVMX_FormatEthernet()
by Matthias Bolte 15 Nov '09

15 Nov '09

In commit 3c80fac2588cbc9e5ee7e7069e1ca4468f2359d3 'vmxnet3' handling was added to esxVMX_ParseEthernet(), but not to the inverse function esxVMX_FormatEthernet(). --- src/esx/esx_vmx.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/esx/esx_vmx.c b/src/esx/esx_vmx.c index 536bf2d..97ad43e 100644 --- a/src/esx/esx_vmx.c +++ b/src/esx/esx_vmx.c @@ -1758,7 +1758,8 @@ esxVMX_ParseEthernet(virConnectPtr conn, virConfPtr conf, int controller, STRCASENEQ(virtualDev, "e1000")) { ESX_ERROR(conn, VIR_ERR_INTERNAL_ERROR, "Expecting VMX entry '%s' to be 'vlance' or 'vmxnet' or " - "'vmxnet3' or 'e1000' but found '%s'", virtualDev_name, virtualDev); + "'vmxnet3' or 'e1000' but found '%s'", virtualDev_name, + virtualDev); goto failure; } @@ -2646,11 +2647,12 @@ esxVMX_FormatEthernet(virConnectPtr conn, virDomainNetDefPtr def, if (def->model != NULL) { if (STRCASENEQ(def->model, "vlance") && STRCASENEQ(def->model, "vmxnet") && + STRCASENEQ(def->model, "vmxnet3") && STRCASENEQ(def->model, "e1000")) { ESX_ERROR(conn, VIR_ERR_INTERNAL_ERROR, "Expecting domain XML entry 'devices/interfase/model' " - "to be 'vlance' or 'vmxnet' or 'e1000' but found '%s'", - def->model); + "to be 'vlance' or 'vmxnet' or 'vmxnet3' or 'e1000' but " + "found '%s'", def->model); return -1; } -- 1.6.0.4

2 1

[libvirt] [PATCH] Fix compilation of libvirt against xen-unstable
by Jim Fehlig 15 Nov '09

15 Nov '09

libvirt fails to compile against current xen-unstable. This patch fixes it. Regards, Jim

2 1

[libvirt] make install fails, missing HTML files
by Thomas Treutner 14 Nov '09

14 Nov '09

Hi, I'm not sure if this is a bug or if I'm missing some tools: When doing a fresh git clone && ./autogen.sh, make install fails because it complains about some missing HTML doc files. # ./autogen.sh ...... configure: Libraries configure: configure: libxml: -I/usr/include/libxml2 -lxml2 configure: libcurl: no configure: libssh2: no configure: gnutls: -lgnutls -lpthread configure: sasl: -lsasl2 configure: avahi: no configure: polkit: no configure: selinux: no configure: apparmor: no configure: numactl: no configure: capng: no configure: xen: -lxenstore configure: hal: no configure: devkit: no configure: netcf: no configure: xmlrpc: no ....... # make ......... make[3]: Leaving directory `/root/tmp/libvirt/docs' (./apibuild.py) missing XHTML1 DTD missing XHTML1 DTD missing XHTML1 DTD missing XHTML1 DTD missing XHTML1 DTD missing XHTML1 DTD ..... (lots more) # ll docs/*html | wc -l 8 # ll docs/*html.in | wc -l 51 Could someone please cross-check? thx,kr tom

4 13

[libvirt] Entering freeze for 0.7.3
by Daniel Veillard 13 Nov '09

13 Nov '09

I think that all expected feature patches have been pushed to git head so it's time to enter feature freeze, and just do cleanup and bug fixing patches until next friday. So the plan is to get 0.7.3 out on the 20th and we then have one month before the end of year holliday season to push the following release (probably 0.7.4 as I don't see a major feature landing in next month, but we never know). so let's focuse on debug for the coming week ! happy hacking :-) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] [PATCH 1/2] Fix cleanup when state driver init fails
by Daniel P. Berrange 13 Nov '09

13 Nov '09

* daemon/libvirtd.c: Fix incorrect goto label causing cleanup to be missed when state driver init fails --- daemon/libvirtd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index ef07460..1caa4ce 100644 --- a/daemon/libvirtd.c +++ b/daemon/libvirtd.c @@ -3153,7 +3153,7 @@ int main(int argc, char **argv) { * seriously delay OS bootup process */ if (virStateInitialize(server->privileged) < 0) { VIR_ERROR0("Driver state initialization failed"); - goto error; + goto shutdown; } /* Start accepting new clients from network */ -- 1.6.2.5

3 6

[libvirt] [PATCH 1/2] Fix guestfwdTarget indentation in domain.rng
by Matthew Booth 13 Nov '09

13 Nov '09

* docs/schemas/domain.rng: Fix up some 4 space indentation --- docs/schemas/domain.rng | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng index b75f17e..1bf44fd 100644 --- a/docs/schemas/domain.rng +++ b/docs/schemas/domain.rng @@ -1052,11 +1052,11 @@ </define> <define name="guestfwdTarget"> <element name="target"> - <attribute name="type"> - <value>guestfwd</value> - </attribute> - <attribute name="address"/> - <attribute name="port"/> + <attribute name="type"> + <value>guestfwd</value> + </attribute> + <attribute name="address"/> + <attribute name="port"/> </element> </define> <define name="channel"> -- 1.6.2.5

2 2

[libvirt] [PATCH 1/2] Remove obsolte devicekit checks
by Daniel P. Berrange 13 Nov '09

13 Nov '09

Device kit support was removed, but the configure.ac checks were left in place. A number of the XXX_REQUIRED=X.Y.Z variables were not declared in the correct location (ie top of the file) * configure.in: Remove device kit checks & move mis-placed variables to correct location --- configure.in | 66 +++++---------------------------------------------------- 1 files changed, 6 insertions(+), 60 deletions(-) diff --git a/configure.in b/configure.in index df8eba2..1c705b2 100644 --- a/configure.in +++ b/configure.in @@ -34,6 +34,12 @@ AVAHI_REQUIRED="0.6.0" POLKIT_REQUIRED="0.6" PARTED_REQUIRED="1.8.0" NETCF_REQUIRED="0.1.3" +UDEV_REQUIRED=145 +PCIACCESS_REQUIRED=0.10.0 +XMLRPC_REQUIRED=1.14.0 +HAL_REQUIRED=0.5.0 +DEVMAPPER_REQUIRED=1.0.0 +LIBCURL_REQUIRED="7.18.0" dnl Checks for C compiler. AC_PROG_CC @@ -472,8 +478,6 @@ PKG_PROG_PKG_CONFIG dnl OpenNebula driver Compilation setting dnl -XMLRPC_REQUIRED=1.14.0 - XMLRPC_CFLAGS= XMLRPC_LIBS= if test "x$with_one" = "xyes" -o "x$with_one" = "xcheck"; then @@ -1304,7 +1308,6 @@ fi AM_CONDITIONAL([WITH_STORAGE_MPATH], [test "$with_storage_mpath" = "yes"]) if test "$with_storage_mpath" = "yes"; then - DEVMAPPER_REQUIRED=0.0 DEVMAPPER_CFLAGS= DEVMAPPER_LIBS= PKG_CHECK_MODULES([DEVMAPPER], [devmapper >= $DEVMAPPER_REQUIRED], [], [DEVMAPPER_FOUND=no]) @@ -1379,7 +1382,6 @@ dnl LIBCURL_CFLAGS="" LIBCURL_LIBS="" -LIBCURL_REQUIRED="7.18.0" LIBCURL_FOUND="no" if test "$with_esx" = "yes" -o "$with_esx" = "check"; then @@ -1655,7 +1657,6 @@ LV_LIBTOOL_OBJDIR=${lt_cv_objdir-.} AC_SUBST([LV_LIBTOOL_OBJDIR]) dnl HAL, DeviceKit, or libudev library for host device enumeration -HAL_REQUIRED=0.0 HAL_CFLAGS= HAL_LIBS= AC_ARG_WITH([hal], @@ -1694,61 +1695,7 @@ AM_CONDITIONAL([HAVE_HAL], [test "x$with_hal" = "xyes"]) AC_SUBST([HAL_CFLAGS]) AC_SUBST([HAL_LIBS]) -DEVKIT_REQUIRED=0.0 -DEVKIT_CFLAGS= -DEVKIT_LIBS= -AC_ARG_WITH([devkit], - [ --with-devkit use DeviceKit for host device enumeration], - [], - [with_devkit=no]) -if test "$with_libvirtd" = "no" ; then - with_devkit=no -fi - -dnl Extra check needed while devkit pkg-config info missing glib2 dependency -PKG_CHECK_MODULES(GLIB2, glib-2.0 >= 0.0,,[ - if test "x$with_devkit" = "xcheck"; then - with_devkit=no - elif test "x$with_devkit" = "xyes"; then - AC_MSG_ERROR([required package DeviceKit requires package glib-2.0]) - fi]) - -if test "x$with_devkit" = "xyes" -o "x$with_devkit" = "xcheck"; then - PKG_CHECK_MODULES(DEVKIT, devkit-gobject >= $DEVKIT_REQUIRED, - [with_devkit=yes], [ - if test "x$with_devkit" = "xcheck" ; then - with_devkit=no - else - AC_MSG_ERROR( - [You must install DeviceKit-devel >= $DEVKIT_REQUIRED to compile libvirt]) - fi - ]) - if test "x$with_devkit" = "xyes" ; then - AC_DEFINE_UNQUOTED([HAVE_DEVKIT], 1, - [use DeviceKit for host device enumeration]) - - dnl Add glib2 flags explicitly while devkit pkg-config info missing glib2 dependency - DEVKIT_CFLAGS="$GLIB2_CFLAGS $DEVKIT_CFLAGS" - DEVKIT_LIBS="$GLIB2_LIBS $DEVKIT_LIBS" - - dnl Add more flags apparently required for devkit to work properly - DEVKIT_CFLAGS="$DEVKIT_CFLAGS -D_POSIX_PTHREAD_SEMANTICS -D_REENTRANT" - - old_CFLAGS=$CFLAGS - old_LDFLAGS=$LDFLAGS - CFLAGS="$CFLAGS $DEVKIT_CFLAGS" - LDFLAGS="$LDFLAGS $DEVKIT_LIBS" - AC_CHECK_FUNCS([devkit_client_connect],,[with_devkit=no]) - CFLAGS="$old_CFLAGS" - LDFLAGS="$old_LDFLAGS" - fi -fi -AM_CONDITIONAL([HAVE_DEVKIT], [test "x$with_devkit" = "xyes"]) -AC_SUBST([DEVKIT_CFLAGS]) -AC_SUBST([DEVKIT_LIBS]) - -UDEV_REQUIRED=145 UDEV_CFLAGS= UDEV_LIBS= AC_ARG_WITH([udev], @@ -1781,7 +1728,6 @@ if test "x$with_udev" = "xyes" -o "x$with_udev" = "xcheck"; then CFLAGS="$old_CFLAGS" LDFLAGS="$old_LDFLAGS" fi - PCIACCESS_REQUIRED=0.10.0 PCIACCESS_CFLAGS= PCIACCESS_LIBS= PKG_CHECK_MODULES([PCIACCESS], [pciaccess >= $PCIACCESS_REQUIRED], [], [PCIACCESS_FOUND=no]) -- 1.6.2.5

2 3

[libvirt] [PATCH 0/4] AppArmor updates
by Jamie Strandboge 13 Nov '09

13 Nov '09

Hi, The following patchset contains various cleanups for the AppArmor driver. It assumes that the patch contained in the email with the following subject is already applied: [libvirt] [PATCH] fix virt-aa-helper failure when host arch and os.type arch are different This patch was ACKed but never applied. When committing that patch, please also chmod 755 ./tests/virt-aa-helper-test. 1_aa_profile_updates.patch: Adds pulseaudio, alsa and preliminary save/restore to the example apparmor abstraction. Also allows libvirtd access to inet dgram, inet6 dgram, inet6 stream and /usr/lib/libvirt/*. 2_aa_require_absolute_path.patch: Require absolute path for dynamic added files. This is required by AppArmor and conveniently prevents adding tcp consoles to the profile. This fixes https://launchpad.net/bugs/460271. 3_aa_deny_write_to_readonly.patch: Suppress confusing and misleading apparmor denied message when kvm/qemu tries to open a libvirt specified readonly file (such as a cdrom) with write permissions. libvirt uses the readonly attribute for the security driver only, and has no way of telling kvm/qemu that the device should be opened readonly. This fixes https://launchpad.net/bugs/453335. 4_aa_driver_cleanups.patch: Implements all changes requested by DV except for getting rid of readlink(). I can't use virFileResolveLink() because it lstat()s the file and uses st.st_size to create a buffer. Unfortunately, running lstat() on /proc/self/exe results in st.st_size to be 0. The changes pass 'syntax-check'. secaatest and virt-aa-helper-test both pass (there are several problems in the test suite causing 'make check' to fail. These are all unrelated to these patches). Jamie -- Jamie Strandboge | http://www.canonical.com

2 5

[libvirt] [PATCH] Fix incorrect reference counting logic in qemu monitor open
by Daniel P. Berrange 13 Nov '09

13 Nov '09

The QEMU monitor open method would not take a reference on the virDomainObjPtr until it had successfully opened the monitor. The cleanup code upon failure to open though would call qemuMonitorClose() which would in turn decrement the reference count. This caused the virDoaminObjPtr to be mistakenly freed and then the whole driver crashes * src/qemu/qemu_monitor.c: Fix reference counting in qemuMonitorOpen --- src/qemu/qemu_monitor.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 2357734..f0ef81b 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -456,6 +456,7 @@ qemuMonitorOpen(virDomainObjPtr vm, mon->vm = vm; mon->eofCB = eofCB; qemuMonitorLock(mon); + virDomainObjRef(vm); switch (vm->monitor_chr->type) { case VIR_DOMAIN_CHR_TYPE_UNIX: @@ -499,8 +500,6 @@ qemuMonitorOpen(virDomainObjPtr vm, goto cleanup; } - virDomainObjRef(vm); - VIR_DEBUG("New mon %p fd =%d watch=%d", mon, mon->fd, mon->watch); qemuMonitorUnlock(mon); -- 1.6.2.5

2 1

[libvirt] [PATCH 1/5] Fix formatting of XML for an inactive guest
by Daniel P. Berrange 13 Nov '09

13 Nov '09

If the virDomainDefPtr object has an 'id' of -1, then forcably set the VIR_DOMAIN_XML_INACTIVE flag to ensure generated XML does not include any cruft from the previously running guest such as console PTY path, or VNC port. * src/conf/domain_conf.c: Set VIR_DOMAIN_XML_INACTIVE if def->id is -1. Replace checks for def->id == -1 with check against flags & VIR_DOMAIN_XML_INACTIVE. --- src/conf/domain_conf.c | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9e37452..c2c07ca 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -4407,7 +4407,6 @@ virDomainInputDefFormat(virConnectPtr conn, static int virDomainGraphicsDefFormat(virConnectPtr conn, virBufferPtr buf, - virDomainDefPtr vm, virDomainGraphicsDefPtr def, int flags) { @@ -4424,7 +4423,7 @@ virDomainGraphicsDefFormat(virConnectPtr conn, switch (def->type) { case VIR_DOMAIN_GRAPHICS_TYPE_VNC: if (def->data.vnc.port && - (!def->data.vnc.autoport || vm->id != -1)) + (!def->data.vnc.autoport || !(flags & VIR_DOMAIN_XML_INACTIVE))) virBufferVSprintf(buf, " port='%d'", def->data.vnc.port); else if (def->data.vnc.autoport) @@ -4579,7 +4578,10 @@ char *virDomainDefFormat(virConnectPtr conn, goto cleanup; } - if (def->id >= 0) + if (def->id == -1) + flags |= VIR_DOMAIN_XML_INACTIVE; + + if (!(flags & VIR_DOMAIN_XML_INACTIVE)) virBufferVSprintf(&buf, "<domain type='%s' id='%d'>\n", type, def->id); else virBufferVSprintf(&buf, "<domain type='%s'>\n", type); @@ -4770,7 +4772,7 @@ char *virDomainDefFormat(virConnectPtr conn, goto cleanup; for (n = 0 ; n < def->ngraphics ; n++) - if (virDomainGraphicsDefFormat(conn, &buf, def, def->graphics[n], flags) < 0) + if (virDomainGraphicsDefFormat(conn, &buf, def->graphics[n], flags) < 0) goto cleanup; } -- 1.6.2.5

3 11

[libvirt] [PATCH] Fix initscript to check daemon pidfile
by Daniel P. Berrange 13 Nov '09

13 Nov '09

The libvirtd initscript could get confused between the system and session instances of the daemon. To avoid this it is neccessary to check the pidfile explicitly. * daemon/libvirtd.init.in: Always check the pidfile of the system daemon to avoid confusion with the session daemons --- daemon/libvirtd.init.in | 11 ++++++----- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/daemon/libvirtd.init.in b/daemon/libvirtd.init.in index 43c2d68..071fe2c 100644 --- a/daemon/libvirtd.init.in +++ b/daemon/libvirtd.init.in @@ -40,6 +40,7 @@ SERVICE=libvirtd PROCESS=libvirtd +PIDFILE=@localstatedir@/run/$SERVICE.pid LIBVIRTD_CONFIG= LIBVIRTD_ARGS= @@ -59,7 +60,7 @@ start() { echo -n $"Starting $SERVICE daemon: " mkdir -p @localstatedir@/cache/libvirt rm -rf @localstatedir@/cache/libvirt/* - KRB5_KTNAME=$KRB5_KTNAME daemon --check $SERVICE $PROCESS --daemon $LIBVIRTD_CONFIG_ARGS $LIBVIRTD_ARGS + KRB5_KTNAME=$KRB5_KTNAME daemon --pidfile $PIDFILE --check $SERVICE $PROCESS --daemon $LIBVIRTD_CONFIG_ARGS $LIBVIRTD_ARGS RETVAL=$? echo [ $RETVAL -eq 0 ] && touch @localstatedir@/lock/subsys/$SERVICE @@ -68,12 +69,12 @@ start() { stop() { echo -n $"Stopping $SERVICE daemon: " - killproc $PROCESS + killproc -p $PIDFILE $PROCESS RETVAL=$? echo if [ $RETVAL -eq 0 ]; then rm -f @localstatedir@/lock/subsys/$SERVICE - rm -f @localstatedir@/run/$SERVICE.pid + rm -f $PIDFILE rm -rf @localstatedir@/cache/libvirt/* fi } @@ -86,7 +87,7 @@ restart() { reload() { echo -n $"Reloading $SERVICE configuration: " - killproc $PROCESS -HUP + killproc -p $PIDFILE $PROCESS -HUP RETVAL=$? echo return $RETVAL @@ -98,7 +99,7 @@ case "$1" in $1 ;; status) - status $PROCESS + status -p $PIDFILE $PROCESS RETVAL=$? ;; force-reload) -- 1.6.2.5

2 1