- Devel - libvirt List Archives

[libvirt] [PATCH 00/13] Add support for all QEMU event notifications
by Daniel P. Berrange 25 Mar '10

25 Mar '10

This series adds support for (nearly) all QEMU event notifications that are currently supported by the new JSON mode monitor. - Guest reboot - RTC adjustment - Watchdog firing - Block IO errors - Graphics client connect/disconnect It required two new public APIs, and a bunch of extra function callback typedefs which will be shown in each following commit message. This scheme is extensible to support any further events against domains. It does not support events on other types of object (storage, node devices, etc), but those can follow exactly the same API design scheme should we need them in the future. We don't want to unify them at the public API level, since internally they need to dispatch to separate drivers anyway. I'm generally happy with the public API for the events, with the exception of the graphics event which is horribly complex due to the large amount of data. I'm not sure if there's a way to make that event nicer.... The full diffstat for all patches daemon/dispatch.h | 10 daemon/libvirtd.c | 20 daemon/libvirtd.h | 2 daemon/remote.c | 348 ++++++++++++++-- daemon/remote_dispatch_args.h | 2 daemon/remote_dispatch_prototypes.h | 16 daemon/remote_dispatch_table.h | 37 + examples/domain-events/events-c/event-test.c | 168 ++++++- include/libvirt/libvirt.h.in | 106 ++++ src/conf/domain_event.c | 580 ++++++++++++++++++++++++--- src/conf/domain_event.h | 82 +++ src/driver.c | 4 src/driver.h | 18 src/esx/esx_driver.c | 2 src/libvirt.c | 133 +++++- src/libvirt_private.syms | 16 src/libvirt_public.syms | 6 src/lxc/lxc_driver.c | 60 ++ src/opennebula/one_driver.c | 2 src/openvz/openvz_driver.c | 2 src/phyp/phyp_driver.c | 2 src/qemu/qemu_driver.c | 290 +++++++++++++ src/qemu/qemu_monitor.c | 77 +++ src/qemu/qemu_monitor.h | 39 + src/qemu/qemu_monitor_json.c | 144 ++++++ src/remote/remote_driver.c | 459 +++++++++++++++++---- src/remote/remote_protocol.c | 111 +++++ src/remote/remote_protocol.h | 185 ++++++-- src/remote/remote_protocol.x | 65 ++- src/test/test_driver.c | 58 ++ src/uml/uml_driver.c | 2 src/vbox/vbox_tmpl.c | 155 +++++-- src/xen/xen_driver.c | 71 ++- src/xenapi/xenapi_driver.c | 2 34 files changed, 2947 insertions(+), 327 deletions(-) Daniel

3 36

[libvirt] [PATCH 0/1] Disk error policy
by David Allan 25 Mar '10

25 Mar '10

The following patch adds support for setting the disk error policy to the domain XML and using it when setting up the qemu command line. It specifies the werror=somepolicy,rerror=somepolicy flags to tell qemu what to do in the case of an io error. This patch is my first foray into the setup of the qemu command line, so please review with heightened care. Dave David Allan (1): Add disk error policy to domain XML docs/schemas/domain.rng | 12 +++++++++++- src/conf/domain_conf.c | 15 +++++++++++++++ src/conf/domain_conf.h | 10 ++++++++++ src/libvirt_private.syms | 2 +- src/qemu/qemu_conf.c | 12 +++++++++--- tests/qemuhelptest.c | 1 + tests/qemuxml2argvtest.c | 3 +++ 7 files changed, 50 insertions(+), 5 deletions(-)

4 4

[libvirt] [PATCH] Add entry point logging for cpu functions
by Jiri Denemark 25 Mar '10

25 Mar '10

--- src/cpu/cpu.c | 46 ++++++++++++++++++++++++++++++++++++++++++++-- 1 files changed, 44 insertions(+), 2 deletions(-) diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c index be0f15e..183862a 100644 --- a/src/cpu/cpu.c +++ b/src/cpu/cpu.c @@ -23,6 +23,7 @@ #include <config.h> +#include "logging.h" #include "memory.h" #include "xml.h" #include "cpu.h" @@ -73,6 +74,8 @@ cpuCompareXML(virCPUDefPtr host, virCPUDefPtr cpu = NULL; virCPUCompareResult ret = VIR_CPU_COMPARE_ERROR; + VIR_DEBUG("host=%p, xml=%s", host, NULLSTR(xml)); + if (!(doc = virXMLParseString(xml, "cpu.xml"))) goto cleanup; @@ -104,6 +107,8 @@ cpuCompare(virCPUDefPtr host, { struct cpuArchDriver *driver; + VIR_DEBUG("host=%p, cpu=%p", host, cpu); + if ((driver = cpuGetSubDriver(host->arch)) == NULL) return VIR_CPU_COMPARE_ERROR; @@ -126,6 +131,13 @@ cpuDecode(virCPUDefPtr cpu, { struct cpuArchDriver *driver; + VIR_DEBUG("cpu=%p, data=%p, nmodels=%u", cpu, data, nmodels); + if (models) { + unsigned int i; + for (i = 0; i < nmodels; i++) + VIR_DEBUG("models[%u]=%s", i, NULLSTR(models[i])); + } + if (models == NULL && nmodels != 0) { virCPUReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("nonzero nmodels doesn't match with NULL models")); @@ -163,6 +175,11 @@ cpuEncode(const char *arch, { struct cpuArchDriver *driver; + VIR_DEBUG("arch=%s, cpu=%p, forced=%p, required=%p, " + "optional=%p, disabled=%p, forbidden=%p", + NULLSTR(arch), cpu, forced, required, + optional, disabled, forbidden); + if ((driver = cpuGetSubDriver(arch)) == NULL) return -1; @@ -184,6 +201,8 @@ cpuDataFree(const char *arch, { struct cpuArchDriver *driver; + VIR_DEBUG("arch=%s, data=%p", NULLSTR(arch), data); + if (data == NULL) return; @@ -206,6 +225,8 @@ cpuNodeData(const char *arch) { struct cpuArchDriver *driver; + VIR_DEBUG("arch=%s", NULLSTR(arch)); + if ((driver = cpuGetSubDriver(arch)) == NULL) return NULL; @@ -227,6 +248,8 @@ cpuGuestData(virCPUDefPtr host, { struct cpuArchDriver *driver; + VIR_DEBUG("host=%p, guest=%p, data=%p", host, guest, data); + if ((driver = cpuGetSubDriver(host->arch)) == NULL) return VIR_CPU_COMPARE_ERROR; @@ -254,6 +277,16 @@ cpuBaselineXML(const char **xmlCPUs, char *cpustr; unsigned int i; + VIR_DEBUG("ncpus=%u, nmodels=%u", ncpus, nmodels); + if (xmlCPUs) { + for (i = 0; i < ncpus; i++) + VIR_DEBUG("xmlCPUs[%u]=%s", i, NULLSTR(xmlCPUs[i])); + } + if (models) { + for (i = 0; i < nmodels; i++) + VIR_DEBUG("models[%u]=%s", i, NULLSTR(models[i])); + } + if (xmlCPUs == NULL && ncpus != 0) { virCPUReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("nonzero ncpus doesn't match with NULL xmlCPUs")); @@ -320,6 +353,17 @@ cpuBaseline(virCPUDefPtr *cpus, { struct cpuArchDriver *driver; virCPUDefPtr cpu; + unsigned int i; + + VIR_DEBUG("ncpus=%u, nmodels=%u", ncpus, nmodels); + if (cpus) { + for (i = 0; i < ncpus; i++) + VIR_DEBUG("cpus[%u]=%p", i, cpus[i]); + } + if (models) { + for (i = 0; i < nmodels; i++) + VIR_DEBUG("models[%u]=%s", i, NULLSTR(models[i])); + } if (cpus == NULL && ncpus != 0) { virCPUReportError(VIR_ERR_INTERNAL_ERROR, @@ -349,8 +393,6 @@ cpuBaseline(virCPUDefPtr *cpus, } if ((cpu = driver->baseline(cpus, ncpus, models, nmodels))) { - int i; - cpu->type = VIR_CPU_TYPE_GUEST; cpu->match = VIR_CPU_MATCH_EXACT; VIR_FREE(cpu->arch); -- 1.7.0.3

2 2

[libvirt] Sleeping 50 microseconds in qemuDomainWaitForMigrationComplete?
by Matthias Bolte 25 Mar '10

25 Mar '10

There is this nanosleep call in the QEMU driver. /* Poll every 50ms for progress & to allow cancellation */ struct timespec ts = { .tv_sec = 0, .tv_nsec = 50 * 1000ull }; [...] nanosleep(&ts, NULL); The comment says 50ms (assuming m is for milli and not for micro. because normally u is used for micro) but the actual nanosleep call is done with 50 microseconds. Is the comment right and the code wrong? I assume so, because 50 microseconds is pretty short and 50 milliseconds sounds more reasonable. Matthias

2 1

[libvirt] [PATCH 0/6] Support VNC password changes on running guests v2
by Daniel P. Berrange 25 Mar '10

25 Mar '10

This patch introduces a new virDomainUpdateDeviceFlags() API to allow the configuration of a device to be changed on the fly. It ports the existing CDROM media change code in all drivers to use this new API (keeps old support too). It then adds VNC password change support in the QEMU driver using this new API v2: Fix feedback from first posting

3 14

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt
by Anthony Liguori 25 Mar '10

25 Mar '10

On 03/24/2010 07:25 AM, Paul Brook wrote: >> I can't quite see what such a libqemu would buy us compared to straight >> QMP. >> >> Talking QMP should be easy, provided you got a suitable JSON library. >> > I agree. My undesranding is this was one of the large motivations behind using > JSON: It's a common protocol that already has convenient bindings in most > languages. If it's hard[1] for third parties to bind QMP to their favourite > language/framework then IMHO we've done it wrong. > You can't have convenient bindings to an RPC in C because it doesn't support dynamic dispatch. With most types of RPC, you have an IDL description and a code generator. But regardless of that, there are advantages to us providing a libqemu. The biggest one is that we can standardize transport implementations that include discovery mechanisms. If the core of libqemu provided an extensible transport interface, and a generic QMP request/completion mechanism, in a Python binding, you would never use the IDL generated wrappers but instead use dynamic dispatch to invoke arbitrary QMP requests. But the advantage is that if libvirt provided an API for a QMP transport encapsulated in their secure protocol, then provided the plumbed that API through their Python interface, you could use it for free in Python without having to reinvent the wheel. Regards, Anthony Liguori > Paul > > [1] Hard compared to any other sane RPC mechanism. Some languages make > everything hard :-) >

2 1

[libvirt] [PATCH] build: suppress distracting build output
by Jim Meyering 24 Mar '10

24 Mar '10

While building "make check", I saw this scroll by (too quickly to see what it was), but it was different enough from the rest that... CCLD libvirt.la CCLD libvirt_test.la make check-local make[3]: Entering directory `/home/j/w/co/libvirt/src' if test -x '/usr/bin/augparse'; then \ '/usr/bin/augparse' -I ./qemu \ ./qemu/test_libvirtd_qemu.aug; \ fi if test -x '/usr/bin/augparse'; then \ '/usr/bin/augparse' -I ./lxc \ ./lxc/test_libvirtd_lxc.aug; \ fi CC libvirtd-event.o CC libvirtd-libvirtd.o I scrolled back to investigate. Not a problem, but let's eliminate the distraction. Here's a patch. With it, instead of the above "if test..." lines, you'll see this single line: GEN augeas-check >From 84eb6effdd0241a8bae196d4b77d873aea7fd3db Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Wed, 24 Mar 2010 09:39:54 +0100 Subject: [PATCH] build: suppress distracting build output * src/Makefile.am (augeas-check): New target, just to give the existing rule a name. At the same time, prefix the commands with $(AM_V_GEN), to avoid unexpected build output with V=0 which is the default. --- src/Makefile.am | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 0aa3443..5f6b325 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -766,15 +766,18 @@ EXTRA_DIST += \ $(SECRET_DRIVER_SOURCES) \ $(VBOX_DRIVER_EXTRA_DIST) -check-local: +check-local: augeas-check + +.PHONY: augeas-check +augeas-check: if WITH_QEMU - if test -x '$(AUGPARSE)'; then \ + $(AM_V_GEN)if test -x '$(AUGPARSE)'; then \ '$(AUGPARSE)' -I $(srcdir)/qemu \ $(srcdir)/qemu/test_libvirtd_qemu.aug; \ fi endif if WITH_LXC - if test -x '$(AUGPARSE)'; then \ + $(AM_V_GEN)if test -x '$(AUGPARSE)'; then \ '$(AUGPARSE)' -I $(srcdir)/lxc \ $(srcdir)/lxc/test_libvirtd_lxc.aug; \ fi -- 1.7.0.3.435.g097f4

2 1

[libvirt] [PATCH] vbox: Fix segfault on empty device source
by Matthias Bolte 24 Mar '10

24 Mar '10

<source file=''/> results in def->disks[i]->src == NULL. But vboxDomainDefineXML didn't check def->disks[i]->src for NULL and expected it to be a valid string. Add checks for def->disks[i]->src != NULL to fix the segfault. --- src/vbox/vbox_tmpl.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index 1765d63..fefed1f 100644 --- a/src/vbox/vbox_tmpl.c +++ b/src/vbox/vbox_tmpl.c @@ -3519,7 +3519,8 @@ static virDomainPtr vboxDomainDefineXML(virConnectPtr conn, const char *xml) { DEBUG("disk(%d) shared: %s", i, def->disks[i]->shared ? "True" : "False"); if (def->disks[i]->device == VIR_DOMAIN_DISK_DEVICE_CDROM) { - if (def->disks[i]->type == VIR_DOMAIN_DISK_TYPE_FILE) { + if (def->disks[i]->type == VIR_DOMAIN_DISK_TYPE_FILE && + def->disks[i]->src != NULL) { IDVDDrive *dvdDrive = NULL; /* Currently CDROM/DVD Drive is always IDE * Secondary Master so neglecting the following @@ -3801,7 +3802,8 @@ static virDomainPtr vboxDomainDefineXML(virConnectPtr conn, const char *xml) { DEBUG("disk(%d) readonly: %s", i, def->disks[i]->readonly ? "True" : "False"); DEBUG("disk(%d) shared: %s", i, def->disks[i]->shared ? "True" : "False"); - if (def->disks[i]->type == VIR_DOMAIN_DISK_TYPE_FILE) { + if (def->disks[i]->type == VIR_DOMAIN_DISK_TYPE_FILE && + def->disks[i]->src != NULL) { IMedium *medium = NULL; PRUnichar *mediumUUID = NULL; PRUnichar *mediumFileUtf16 = NULL; -- 1.6.3.3

3 4

[libvirt] error: internal error canonical hostname pointed to localhost, but this is not allowed
by Kenneth Nagin 24 Mar '10

24 Mar '10

When trying to migrate a VM the destination libvirtd virGetHostnameLocalhost throws an internal error. I issue this command from the source host. > virsh migrate rel-vm1 qemu+tls://croton/system error: internal error canonical hostname pointed to localhost, but this is not allowed The destination host throws the error: 14:14:57.914: debug : virDomainMigratePrepare2:3740 : dconn=0xed17e0, cookie=0x7f983a352d68, cookielen=0x7f983a352d74, uri_in=(null), uri_out=0xe8c360,flags=0, dname=(null), bandwidth=0, dom_xml=<domain type='kvm' id='1'> <name>rel-vm1</name> <uuid>c0c98fc9-8cd6-e246-a06e-b5ce37c4f05e</uuid> <memory>262144</memory> <currentMemory>262144</currentMemory> <vcpu>1</vcpu> <os> <type arch='x86_64' machine='pc-0.11'>hvm</type> <boot dev='hd'/> </os> <clock offset='utc'/> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>destroy</on_crash> <devices> <emulator>/usr/libexec/qemu-kvm</emulator> <disk type='file' device='disk'> <source file='/share/images/nagin/rel-vm1/rel-vm1.img'/> <target dev='hda' bus='ide'/> <alias name='ide0-0-0'/> <address type='drive' controller='0' bus='0' unit='0'/> </disk> <controller type='ide' index='0'> <alias name='ide0'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x1'/> </controller> <input type='mouse' bus='ps2'/> <graphics type='vnc' port='5900' autoport='yes'/> <video> <model type='cirrus' vram='9216' heads='1'/> <alias name='video0'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/> </video> </devices> </domain> 14:14:57.914: error : virGetHostnameLocalhost:2372 : internal error canonical hostname pointed to localhost, but this is not allowed libvir: error : internal error canonical hostname pointed to localhost, but this is not allowed 14:14:57.914: debug : remoteSerializeError:141 : prog=536903814 ver=1 proc=108 type=1 serial=3, msg=internal error canonical hostname pointed to localhost, but this is not allowed The libvirt version is the tip of git: [root@croton rel-vm1]# virsh version Compiled against library: libvir 0.7.7 Using library: libvir 0.7.7 Using API: QEMU 0.7.7 Running hypervisor: QEMU 0.12.1 Changing qemudDomainMigratePrepare2 call to virGetHostnameLocalhost from: if ((hostname = virGetHostnameLocalhost(0)) == NULL) to: if ((hostname = virGetHostnameLocalhost(1)) == NULL) seems to fix the problem. But maybe this is only masking a another problem. --Kenneth Nagin

3 3

[libvirt] ANNOUNCE: virt-manager 0.8.4 and virtinst 0.500.3
by Cole Robinson 24 Mar '10

24 Mar '10

I'm happy to announce two new releases: virt-manager 0.8.4: virt-manager is a desktop application for managing KVM and Xen virtual machines via libvirt. virtinst 0.500.3: virtinst is a collection of command line tools for provisioning libvirt virtual machines, including virt-install and virt-clone. The releases can be downloaded from: http://virt-manager.org/download.html The direct download links are: http://virt-manager.org/download/sources/virt-manager/virt-manager-0.8.4.ta… http://virt-manager.org/download/sources/virtinst/virtinst-0.500.3.tar.gz The virt-manager release includes: - Import install option: create a VM using an existing OS image - Support multiple boot devices and boot order - Watchdog device support - Enable setting a human readable VM description. - Option to manually specify a bridge name, if bridge isn't detected by virt-manager The virtinst release includes: - virt-install: New --watchdog option: configure a virtual watchdog dev - virt-install: New --soundhw option: More flexible sound configuration deprecates --sound, though back compat is maintained - virt-install: New --security option: configure VM security driver - virt-install: New --description option: set a human readable desc - Better OS defaults: Use <video> VGA and <sound> AC97 if supported Thanks to everyone who has contributed to this release through testing, bug reporting, submitting patches, and otherwise sending in feedback! Thanks, Cole

1 0

[libvirt] Two issues regarding TFTP support in virtual networks...
by Darryl L. Pierce 24 Mar '10

24 Mar '10

The first is just a wiki fix: the wiki says this functionality is available as of 0.7.1 of libvirt. The code though is only in the 0.7.2 tag and later. So the wiki should say 0.7.2 instead. The second regards how I'm using it and what I'm doing wrong. I'm creating a virtual network and pointing it to a temporary directory where I've run livecd-iso-to-pxeboot to setup an ISO file for PXE booting. So the network XML looks like this: (mcpierce@mcpierce-desktop:node-image)$ sudo virsh net-dumpxml testbr541 <network> <name>testbr541</name> <uuid>f389317f-8420-7516-df9d-756b7deb3d37</uuid> <forward mode='nat'/> <bridge name='testbr541' stp='on' delay='0' /> <ip address='192.168.31.1' netmask='255.255.255.0'> <tftp root='/tmp/tmp.3B8opJfBXw/tftpboot/' /> <dhcp> <range start='192.168.31.100' end='192.168.31.199' /> </dhcp> </ip> </network> When I start up the VM, I see it get an IP address within the range specified, but it never pxeboots the ISO image. To what directory should the root attribute be pointed? -- Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc. Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/

2 14

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt
by Markus Armbruster 24 Mar '10

24 Mar '10

Paul Brook <paul(a)codesourcery.com> writes: >> > IMO the no_user flag is a bug, and should not exist. >> >> Sorry, what's that? > > Usually an indication that a device has been incorrectly or inproperly > converted to the qdev interface. Can also be an indication that the device can't support multiple instances. For instance: commit 39a51dfda835a75c0ebbfd92705b96e4de77f795 Author: Markus Armbruster <armbru(a)redhat.com> Date: Tue Oct 27 13:52:13 2009 +0100 qdev: Tag isa-fdc, PIIX3 IDE and PIIX4 IDE as no-user These devices are created automatically, and attempting to create another one with -device fails with "qemu: hardware error: register_ioport_write: invalid opaque". Signed-off-by: Markus Armbruster <armbru(a)redhat.com> Signed-off-by: Anthony Liguori <aliguori(a)us.ibm.com> With no-user, we at least fail with a decent error message. I don't think it's fair to demand that a qdev conversion must relax restrictions that haven't otherwise bothered us to be correct and proper. We'll relax them if and when they bother us enough to make somebody send a decent patch. And yes, there are better ways to disallow multiple instances of a device than declaring it no-user. Patches welcome.

1 0

[libvirt] [RFC]: Snapshot API
by Chris Lalancette 24 Mar '10

24 Mar '10

Hello, As some of you know, I've been working on a new snapshot API. This API is heavily based on DanB's earlier API proposed here: https://www.redhat.com/archives/libvir-list/2010-January/msg00626.html I've made some modifications to make it more libvirt-ish, and to add a couple of features I think it lacked. The full documentation is below. Any comments are appreciated. /* NOTE: struct _virDomainSnapshot is a private structure, ala * struct _virDomain. */ typedef struct _virDomainSnapshot virDomainSnapshot; /* Take a snapshot of the current VM state */ virDomainSnapshotPtr virDomainSnapshotCreateXML(virDomainPtr domain, const char *xmlDesc, unsigned int flags); /* Dump the XML of a snapshot */ /* NOTE: see below for proposed XML */ char *virDomainSnapshotGetXMLDesc(virDomainSnapshotPtr snapshot, unsigned int flags); /* Return the number of snapshots for this domain */ int virDomainSnapshotNum(virDomainPtr domain, unsigned int flags); /* Get the names of all snapshots for this domain */ int virDomainListSnapshotNames(virDomainPtr domain, char **names, int nameslen, unsigned int flags); /* Get a handle to a named snapshot */ virDomainSnapshotPtr virDomainSnapshotLookupByName(virDomainPtr domain, const char *name, unsigned int flags); /* Set this snapshot as the current one for a domain, to be * used next time domain is started */ int virDomainSnapshotActivate(virDomainSnapshotPtr snapshot, unsigned int flags); /* Deactivate a snapshot - with no flags, the snapshot is not used anymore, * but also not removed. With a MERGE flag, it merges the snapshot into * the base image. With a DISCARD flag, it deletes the snapshot. MERGE * and DISCARD are mutually-exclusive. Note that this operation can * generally only happen when the domain is shut down, though this is * hypervisor-specific */ typedef enum { VIR_DOMAIN_SNAPSHOT_DEACTIVATE_MERGE, VIR_DOMAIN_SNAPSHOT_DEACTIVATE_DISCARD, } virDomainSnapshotDeactivate; int virDomainSnapshotDeactivate(virDomainSnapshotPtr snapshot, unsigned int flags); int virDomainSnapshotFree(virDomainSnapshotPtr snapshot); NOTE: During snapshot creation, *none* of the fields are required. That is, you can call virDomainSnapshotCreateXML() with an XML of "<domainsnapshot/>". In this case, the individual driver will make up a <name> for you, the <creationdate> will be set to the current time+date, <description> will be empty, <state> will be "off", <compression> will be empty, and <parent> will be empty. If you do want to specify some fields during virDomainSnapshotCreateXML(), note that the only ones that are settable are <name>, <description>, <compression>, and <parent>; the rest are ignored, and filled in by the driver when the snapshot is actually created. NOTE: <parent> is used to create "trees" of snapshots, and may or may not be supported by individual hypervisor implementations. If <parent> is specified and the underlying hypervisor does not support it, an error will be thrown. NOTE: <compression> is used to compress snapshots, and may or may not be supported by individual hypervisor implementations. If <compression> is specified and the underlying hypervisor does not support it, an error will be thrown. <domainsnapshot> <name>XYZ</name> <creationdate>...</creationdate> <description> ....blah.... </description> <state>RUNNING</state> <domain> <uuid>XXXXX-XXXX-XXXX-XXXX-XXXXXXXXX</uuid> </domain> <compression>gzip</compression> <parent> <name>ABC</name> </parent> </domainsnapshot> The virsh commands will be: virsh snapshot-create [--compress] <dom> <xmlfile> virsh snapshot-list <dom> virsh snapshot-dumpxml <dom> <name> virsh snapshot-activate <dom> <snapshotname> virsh snapshot-deactivate <dom> <snapshotname> [--merge|--delete] -- Chris Lalancette

6 22

[libvirt] Unable to open virt-manager
by Doron Fediuck 24 Mar '10

24 Mar '10

Hi, I'm trying to work remotely on a server with F12, using vnc. When I start virt-manager, I do not get the authentication popup, and instead I get this message: Unable to open connection to hypervisor URI 'qemu:///system': authentication failed Traceback (most recent call last): File "/usr/share/virt-manager/virtManager/connection.py", line 872, in _try_open None], flags) File "/usr/lib64/python2.6/site-packages/libvirt.py", line 102, in openAuth if ret is None:raise libvirtError('virConnectOpenAuth() failed') libvirtError: authentication failed RPM versions: libvirt-0.7.1-15.fc12.x86_64 libvirt-client-0.7.1-15.fc12.x86_64 python-virtinst-0.500.1-2.fc12.noarch virt-viewer-0.2.0-1.fc12.x86_64 virt-manager-0.8.2-1.fc12.noarch virt-ctrl-1.0.1-4.fc12.x86_64 libvirt-python-0.7.1-15.fc12.x86_64 Any idea what causes the popup to fail ?

2 3

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt
by Avi Kivity 24 Mar '10

24 Mar '10

On 03/24/2010 02:30 PM, Paul Brook wrote: >> On 03/23/2010 09:24 PM, Anthony Liguori wrote: >> >>> We also provide an API for guest creation (the qemu command line). >>> >> As an aside, I'd like to see all command line options have qmp >> equivalents (most of them can be implemented with a 'set' command that >> writes qdev values). This allows a uniform way to control a guest, >> whether at startup or runtime. You start with a case, cold-plug a >> motherboard, cpus, memory, disk controllers, and power it on. >> > The main blocker to this is converting all the devices to qdev. "partial" > conversions are not sufficient. It's approximately the same problem as a > machine config file. If you have one then the other should be fairly trivial. > Agreed. > IMO the no_user flag is a bug, and should not exist. > Sorry, what's that? -- error compiling committee.c: too many arguments to function

1 0

[libvirt] prematurely pushed my build/portability/clean-up patches
by Jim Meyering 24 Mar '10

24 Mar '10

Jim Meyering wrote: > Eric Blake wrote: >> On 03/23/2010 09:07 AM, Philipp Hahn wrote: >>> The conversion from seconds to milliseconds should only be done for >>> actual delays >= 0, not for the magic -1 value used for infinite >>> timeouts. >> >> ACK. > > Thanks. I pushed that. Whoops. While pushing that, I mistakenly also pushed my four unreviewed build/portability/clean-up patches. Sorry about that.

1 0

[libvirt] [PATCH] poll(-0.001) does not sleep forever.
by Philipp Hahn 24 Mar '10

24 Mar '10

The conversion from seconds to milliseconds should only be done for actual delays >= 0, not for the magic -1 value used for infinite timeouts. Signed-off-by: Philipp Hahn <hahn(a)univention.de> --- examples/domain-events/events-python/event-test.py | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

3 2

[libvirt] [PATCH] tests: Don't add extra padding if counter mod 40 is 0
by Matthias Bolte 24 Mar '10

24 Mar '10

--- tests/test-lib.sh | 10 ++++++---- tests/testutils.c | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/tests/test-lib.sh b/tests/test-lib.sh index 43265f3..57fd438 100644 --- a/tests/test-lib.sh +++ b/tests/test-lib.sh @@ -55,10 +55,12 @@ test_final() if test "$verbose" = "0" ; then mod=`eval "expr $ $counter + 1 $ % 40"` - for i in `seq $mod 40` - do - echo -n " " - done + if test "$mod" != "0" -a "$mod" != "1" ; then + for i in `seq $mod 40` + do + echo -n " " + done + fi if test "$status" = "0" ; then printf " %-3d OK\n" $counter else diff --git a/tests/testutils.c b/tests/testutils.c index 8764673..99bd9df 100644 --- a/tests/testutils.c +++ b/tests/testutils.c @@ -531,7 +531,7 @@ cleanup: virResetLastError(); if (!virTestGetVerbose()) { int i; - for (i = (testCounter % 40) ; i < 40 ; i++) + for (i = (testCounter % 40) ; i > 0 && i < 40 ; i++) fprintf(stderr, " "); fprintf(stderr, " %-3d %s\n", testCounter, ret == 0 ? "OK" : "FAIL"); } -- 1.6.3.3

3 5

[libvirt] [PATCH] Don't mix relative and absolute paths.
by Philipp Hahn 23 Mar '10

23 Mar '10

autoconf goes to great lengths to calculate a proper MKINSTALLDIRS path, so just export the variable for gettext, but don't overwrite it with a broken path: $(top_builddir) is a relative path, while $ac_aux_dir can be an absolute path. Signed-off-by: Philipp Hahn <hahn(a)univention.de> --- configure.ac | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

2 2

[libvirt] [PATCH 0/3] Refactor XML parsing code
by Jiri Denemark 23 Mar '10

23 Mar '10

Almost identical XML parsing code for either strings or files was copied 15 times. Since it was needed on two other places for parsing CPU XML strings with correct error reporting, I decided to factor the parsing code out to xml.c and used this one implementation in all other places. Jiri Denemark (3): Introduce XML parsing utility functions Use common XML parsing functions Fix error reporting when parsing CPU XML strings src/conf/domain_conf.c | 130 ++++++--------------------------------- src/conf/interface_conf.c | 93 ++++------------------------ src/conf/network_conf.c | 93 ++++------------------------ src/conf/node_device_conf.c | 60 +----------------- src/conf/secret_conf.c | 56 ++--------------- src/conf/storage_conf.c | 110 +++------------------------------- src/cpu/cpu.c | 11 ++- src/util/xml.c | 142 ++++++++++++++++++++++++++++++++++++++++++- src/util/xml.h | 19 ++++++ 9 files changed, 231 insertions(+), 483 deletions(-)

2 7

[libvirt] [RFC] events scripts support
by Daniel Veillard 23 Mar '10

23 Mar '10

We would like to introduce a way to configure system wide a script which would be called when some event happens. The script is a single executable set as a libvirtd option by the system administrator (assuming one runs the system libvirtd) or the user (assuming a user run libvirtd). The script could be invoked on daemon events, for example starting stopping, or reloading (SIGHUP), on domain events for example before a domain starts, or after its stops, and possibly on other kind of events detected by the daemon (storage or interface ...) My current thinking is to add the following two variables to libvirtd.conf: # Event scripts # An optional path to a script handling various kind of events like # domain start, domain end, pre and post migration, etc... # The events_script must be a path to the script or binary handling # the # events. # The events_set is a list of space separated name for the event type # the script should receive # # events_script="/etc/libvirt/events" # events_set="daemon domain" The script aruguments would be - the object kind: e.g. "domain" - the object name: e.g. the domain name - the event itself: e.g. "start" - sub event qualifier: e.g. "before" - an optional extra information for example in case of migration the destination or source So for example if the two variables as set as sugegsted, /etc/libvirt/events domain foo start before would be run by the daemon before the lunch of a domain which could have been initiated by the user when running "virsh foo start". The script exec return value is expected to be 0 unless indicating an error, in that case the libvirtd command would fail, for example if the command launched for "virsh foo start" failed with an error value the domain won't be started. This is a new kind of API in libvirt(d) so I'm submitting this for review. There could be some challenging issues, for example naming i.e. is the object "external" name like 'foo' the right thing to pass or should we also provide the uuid, making sure the arguments for the scripts and the behaviour is generic enough, and also how to handle potential recursion and avoid deadlock if the events script happen to use libvirt. I hope to have some initial patches by tomorrow, but I'm probably forgetting things, so feedback welcome ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

4 6

Re: [libvirt] FW: [PATCH 1/4] Addition of XenAPI support to libvirt
by Daniel Veillard 23 Mar '10

23 Mar '10

On Fri, Feb 19, 2010 at 11:33:36AM +0000, Sharadha Prabhakar (3P) wrote: > > thanks for the patch, just started to look at it. > > I assume that by libxenserver you mean the code to be added under src > in a following patch, right ? > > -> libxenserver is a library which provides APIs for performing various > Operations on the hypervisor. You can download it from > http://community.citrix.com/download/attachments/38633496/libxenserver-5.5.… > libxenserver folder should be in the same directory level of libvirt. Sorry that's not possible. Either the code is in libvirt, and in that case it doesn't have to be downloaded, but part of the patch submission (and managed on this list) , or it's a new external dependancy and it's availability must be checked by configure.ac. If we add a new dependancy, it must also be checked for Licence compatibility. So far we have always refused to use a third party library to access the hypervisor itself, libvirt(d) talking directly to the hypervisor components or launching it directly. For example we don't rely on the VMWare libraries to talk to ESX. > [...] > > +endif > > +#libvirt_driver_xenapi_la_LIBADD = $(XENAPI_LIBS) > > +libvirt_driver_xenapi_la_CFLAGS = $(XEN_CFLAGS) \ > > + $(shell xml2-config --cflags) \ > > + $(shell curl-config --cflags) > > +libvirt_driver_xenapi_la_LDFLAGS = -L@top_srcdir@/../libxenserver/ -lxenserver -g $(shell xml2-config --libs) \ > > + $(shell curl-config --libs) > > Hum, libxml2 is already fully detected in configure.ac, use the > LIBXML_* variables instead of trying to exec xml2-config. > > -> I've added the LIBXML_ flags in Makefile.am and posted the patch. okay, we will review this, but note that we start the feature freeze for 0.7.7 this week-end, so next week is more likely to be focused on bug fixes for already commited features. > Similary libcurl i looked at in configure.ac for ESX, this need > to be modified to be checked more generally and the LIBCURL_* > variables need to be used here too. > > -> I didn't quite understand the libcurl part you mentioned. I too noticed that ESX has > a piece of code in configure.ac to set the libcurl flags, do you want me to do add a similar > bit of code in configure.ac for XenAPI that defines LIBCURL flags and then add in my Makefile.am? the code to look for libcurl in configure.ac is currently only activated if esx support is on. It must be run if either esx or xen-api are selected, the ESX portion need to be modified accordingly, and your parts and Makefiles patches too. Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

3 3

[libvirt] XenAPI remote storage - target path
by Sharadha Prabhakar (3P) 23 Mar '10

23 Mar '10

Hi, I'm trying to write a Remote Storage driver for XenAPI. I see that target-path is used for both storage pools and volumes. In the case of XenAPI remote storage, the storage is not mounted on the local host where libvirt is running. Storage is maintained in a remote location only. In this case how do I specify target-path and how do I go about creating a VM with storage using libvirt APIs with virsh and virt-manager. Virt-manager expects me to give an absolute path for target-path. But In my case I don't have an absolute path. Can I have a target path like this for a particular storage volume "/storage pool uuid/storage-vol uuid"? This will help me identify which storage pool is Libvirt talking about and which volume in it. Using this information I can fetch data from The remote location and give it back to libvirt. Is this approach ok or does libvirt support my specific remote storage case in some way. Could someone clarify please? Regards, Sharadha

3 4

[libvirt] Can not display graphical console of lxc Virtual Machine.
by Kumar L Srikanth-B22348 23 Mar '10

23 Mar '10

Hi all, I am trying to display the graphical console of a lxc virtual machine which was already created and running. For this, I am using 'virt-viewer'. But, when I execute the following command, it's throwing some errors. [root@localhost lxc_devel]# virt-viewer --connect lxc:/// vm2_fedora --debug ** (virt-viewer:11988): DEBUG: Add handle 4 1 0x217c140 ** (virt-viewer:11988): DEBUG: Add timeout 0x217e4f0 -1 0x7fda386cb990 0x217c140 1 ** (virt-viewer:11988): DEBUG: Skipping inactive resize ** (virt-viewer:11988): DEBUG: Failed to activate viewer can anyone help me. Please suggest me if any other ways of doing it. Regards, Srikanth.

2 1

[libvirt] [PATCH 0/6] Support VNC password changes on running guests
by Daniel P. Berrange 23 Mar '10

23 Mar '10

This patch introduces a new virDomainUpdateDeviceFlags() API to allow the configuration of a device to be changed on the fly. It ports the existing CDROM media change code in all drivers to use this new API (keeps old support too). It then adds VNC password change support in the QEMU driver using this new API

2 13