- Devel - libvirt List Archives

[libvirt] [PATCH] Consolidate interface related functions in interface.c
by Stefan Berger 12 Apr '10

12 Apr '10

I am consolidating network interface related functions used in nwfilter and macvtap code in utils/interface.c. All function names are prefixed with 'Iface'. The following functions are now available through interface.h: int IfaceCtrl(const char *name, bool up); int IfaceUp(const char *name); int IfaceDown(const char *name); int IfaceCheck(bool reportError, const char *ifname, const unsigned char *macaddr, int ifindex); int IfaceGetIndex(bool reportError, const char *ifname, int *ifindex); I added 'int ifindex' as parameter to IfaceCheck to the original function and modified the code accordingly. Signed-off-by: Stefan Berger <stefanb(a)us.ibm.com> --- src/Makefile.am | 1 src/libvirt_private.syms | 4 src/nwfilter/nwfilter_gentech_driver.c | 120 ----------------- src/nwfilter/nwfilter_gentech_driver.h | 2 src/nwfilter/nwfilter_learnipaddr.c | 3 src/util/interface.c | 224 +++++++++++++++++++++++++++++++++ src/util/interface.h | 31 ++++ src/util/macvtap.c | 112 ---------------- 8 files changed, 269 insertions(+), 228 deletions(-) Index: libvirt-acl/src/nwfilter/nwfilter_gentech_driver.c =================================================================== --- libvirt-acl.orig/src/nwfilter/nwfilter_gentech_driver.c +++ libvirt-acl/src/nwfilter/nwfilter_gentech_driver.c @@ -23,16 +23,11 @@ #include <config.h> -#include <stdint.h> -#include <sys/socket.h> -#include <sys/ioctl.h> -#include <linux/if.h> - #include "internal.h" #include "memory.h" #include "logging.h" -#include "datatypes.h" +#include "interface.h" #include "domain_conf.h" #include "virterror_internal.h" #include "nwfilter_gentech_driver.h" @@ -792,117 +787,6 @@ _virNWFilterInstantiateFilter(virConnect } -// FIXME: move chgIfFlags, ifUp, checkIf into common file & share w/ macvtap.c - -/* - * chgIfFlags: Change flags on an interface - * @ifname : name of the interface - * @flagclear : the flags to clear - * @flagset : the flags to set - * - * The new flags of the interface will be calculated as - * flagmask = (~0 ^ flagclear) - * newflags = (curflags & flagmask) | flagset; - * - * Returns 0 on success, errno on failure. - */ -static int chgIfFlags(const char *ifname, short flagclear, short flagset) { - struct ifreq ifr; - int rc = 0; - int flags; - short flagmask = (~0 ^ flagclear); - int fd = socket(PF_PACKET, SOCK_DGRAM, 0); - - if (fd < 0) - return errno; - - if (virStrncpy(ifr.ifr_name, - ifname, strlen(ifname), sizeof(ifr.ifr_name)) == NULL) { - rc = ENODEV; - goto err_exit; - } - - if (ioctl(fd, SIOCGIFFLAGS, &ifr) < 0) { - rc = errno; - goto err_exit; - } - - flags = (ifr.ifr_flags & flagmask) | flagset; - - if (ifr.ifr_flags != flags) { - ifr.ifr_flags = flags; - - if (ioctl(fd, SIOCSIFFLAGS, &ifr) < 0) - rc = errno; - } - -err_exit: - close(fd); - return rc; -} - -/* - * ifUp - * @name: name of the interface - * @up: 1 for up, 0 for down - * - * Function to control if an interface is activated (up, 1) or not (down, 0) - * - * Returns 0 in case of success or an errno code in case of failure. - */ -static int -ifUp(const char *name, int up) -{ - return chgIfFlags(name, - (up) ? 0 : IFF_UP, - (up) ? IFF_UP : 0); -} - - -/** - * checkIf - * - * @ifname: Name of the interface - * @macaddr: expected MAC address of the interface - * - * FIXME: the interface's index is another good parameter to check - * - * Determine whether a given interface is still available. If so, - * it must have the given MAC address. - * - * Returns an error code ENODEV in case the interface does not exist - * anymore or its MAC address is different, 0 otherwise. - */ -int -checkIf(const char *ifname, const unsigned char *macaddr) -{ - struct ifreq ifr; - int fd = socket(PF_PACKET, SOCK_DGRAM, 0); - int rc = 0; - - if (fd < 0) - return errno; - - if (virStrncpy(ifr.ifr_name, - ifname, strlen(ifname), sizeof(ifr.ifr_name)) == NULL) { - rc = ENODEV; - goto err_exit; - } - - if (ioctl(fd, SIOCGIFHWADDR, &ifr) < 0) { - rc = errno; - goto err_exit; - } - - if (memcmp(&ifr.ifr_hwaddr.sa_data, macaddr, 6) != 0) - rc = ENODEV; - - err_exit: - close(fd); - return rc; -} - - int virNWFilterInstantiateFilterLate(virConnectPtr conn, const char *ifname, @@ -926,7 +810,7 @@ virNWFilterInstantiateFilterLate(virConn driver); if (rc) { //something went wrong... 'DOWN' the interface - if (ifUp(ifname ,0)) { + if (IfaceDown(ifname)) { // assuming interface disappeared... _virNWFilterTeardownFilter(ifname); } Index: libvirt-acl/src/util/interface.c =================================================================== --- /dev/null +++ libvirt-acl/src/util/interface.c @@ -0,0 +1,226 @@ +/* + * interface.c: interface support functions + * + * Copyright (C) 2010 IBM Corp. + * Copyright (C) 2010 Stefan Berger + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + * + * chgIfaceFlags originated from bridge.c + * + * Author: Stefan Berger <stefanb(a)us.ibm.com> + */ + +#include <config.h> + +#include <sys/socket.h> +#include <sys/ioctl.h> +#include <linux/if.h> + +#include "internal.h" + +#include "util.h" +#include "interface.h" +#include "virterror_internal.h" + +#define ifaceError(code, ...) \ + virReportErrorHelper(NULL, VIR_FROM_NET, code, __FILE__, \ + __FUNCTION__, __LINE__, __VA_ARGS__) + +/* + * chgIfFlags: Change flags on an interface + * + * @ifname : name of the interface + * @flagclear : the flags to clear + * @flagset : the flags to set + * + * The new flags of the interface will be calculated as + * flagmask = (~0 ^ flagclear) + * newflags = (curflags & flagmask) | flagset; + * + * Returns 0 on success, errno on failure. + */ +static int chgIfaceFlags(const char *ifname, short flagclear, short flagset) { + struct ifreq ifr; + int rc = 0; + int flags; + short flagmask = (~0 ^ flagclear); + int fd = socket(PF_PACKET, SOCK_DGRAM, 0); + + if (fd < 0) + return errno; + + if (virStrncpy(ifr.ifr_name, + ifname, strlen(ifname), sizeof(ifr.ifr_name)) == NULL) { + rc = ENODEV; + goto err_exit; + } + + if (ioctl(fd, SIOCGIFFLAGS, &ifr) < 0) { + rc = errno; + goto err_exit; + } + + flags = (ifr.ifr_flags & flagmask) | flagset; + + if (ifr.ifr_flags != flags) { + ifr.ifr_flags = flags; + + if (ioctl(fd, SIOCSIFFLAGS, &ifr) < 0) + rc = errno; + } + +err_exit: + close(fd); + return rc; +} + + +/* + * IfaceCtrl + * @name: name of the interface + * @up: true (1) for up, false (0) for down + * + * Function to control if an interface is activated (up, 1) or not (down, 0) + * + * Returns 0 in case of success or an errno code in case of failure. + */ +int +IfaceCtrl(const char *name, bool up) +{ + return chgIfaceFlags(name, + (up) ? 0 : IFF_UP, + (up) ? IFF_UP : 0); +} + + +/** + * IfaceCheck + * + * @reportError: whether to report errors or keep silent + * @ifname: Name of the interface + * @macaddr: expected MAC address of the interface; not checked if NULL + * @ifindex: expected index of the interface; not checked if '-1' + * + * Determine whether a given interface is still available. If so, + * it must have the given MAC address and if an interface index is + * passed, it must also match the interface index. + * + * Returns 0 on success, an error code on failure. + * ENODEV : if interface with given name does not exist or its interface + * index is different than the one passed + * EINVAL : if interface name is invalid (too long) + */ +int +IfaceCheck(bool reportError, const char *ifname, + const unsigned char *macaddr, int ifindex) +{ + struct ifreq ifr; + int fd = -1; + int rc = 0; + int idx; + + if (macaddr != NULL) { + fd = socket(PF_PACKET, SOCK_DGRAM, 0); + if (fd < 0) + return errno; + + if (virStrncpy(ifr.ifr_name, + ifname, strlen(ifname), sizeof(ifr.ifr_name)) == NULL) { + if (reportError) + ifaceError(VIR_ERR_INTERNAL_ERROR, + _("invalid interface name %s"), + ifname); + rc = EINVAL; + goto err_exit; + } + + if (ioctl(fd, SIOCGIFHWADDR, &ifr) < 0) { + if (reportError) + ifaceError(VIR_ERR_INTERNAL_ERROR, + _("coud not get MAC address of interface %s"), + ifname); + rc = errno; + goto err_exit; + } + + if (memcmp(&ifr.ifr_hwaddr.sa_data, macaddr, VIR_MAC_BUFLEN) != 0) { + rc = ENODEV; + goto err_exit; + } + } + + if (ifindex != -1) { + rc = IfaceGetIndex(reportError, ifname, &idx); + if (rc == 0 && idx != ifindex) + rc = ENODEV; + } + + err_exit: + if (fd >= 0) + close(fd); + + return rc; +} + + +/** + * IfaceGetIndex + * + * @reportError: whether to report errors or keep silent + * @ifname : Name of the interface whose index is to be found + * @ifindex: Pointer to int where the index will be written into + * + * Get the index of an interface given its name. + * + * Returns 0 on success, an error code on failure. + * ENODEV : if interface with given name does not exist + * EINVAL : if interface name is invalid (too long) + */ +int +IfaceGetIndex(bool reportError, const char *ifname, int *ifindex) +{ + int rc = 0; + struct ifreq ifreq; + int fd = socket(PF_PACKET, SOCK_DGRAM, 0); + + if (fd < 0) + return errno; + + if (virStrncpy(ifreq.ifr_name, ifname, strlen(ifname), + sizeof(ifreq.ifr_name)) == NULL) { + if (reportError) + ifaceError(VIR_ERR_INTERNAL_ERROR, + _("invalid interface name %s"), + ifname); + rc = EINVAL; + goto err_exit; + } + + if (ioctl(fd, SIOCGIFINDEX, &ifreq) >= 0) + *ifindex = ifreq.ifr_ifindex; + else { + if (reportError) + ifaceError(VIR_ERR_INTERNAL_ERROR, + _("interface %s does not exist"), + ifname); + rc = ENODEV; + } + +err_exit: + close(fd); + + return rc; +} Index: libvirt-acl/src/util/interface.h =================================================================== --- /dev/null +++ libvirt-acl/src/util/interface.h @@ -0,0 +1,31 @@ +/* + * interface.h: interface helper APIs for libvirt + * + * Copyright (C) 2010 IBM Corporation, Inc. + * + * See COPYING.LIB for the License of this software + * + * Stefan Berger <stefanb(a)us.ibm.com> + */ +#ifndef __VIR_INTERFACE_H__ +# define __VIR_INTERFACE_H__ + +#include "datatypes.h" + +int IfaceCtrl(const char *name, bool up); + +static inline int IfaceUp(const char *name) { + return IfaceCtrl(name, true); +} + +static inline int IfaceDown(const char *name) { + return IfaceCtrl(name, false); +} + +int IfaceCheck(bool reportError, const char *ifname, + const unsigned char *macaddr, int ifindex); + +int IfaceGetIndex(bool reportError, const char *ifname, int *ifindex); + +#endif /* __VIR_INTERFACE_H__ */ + Index: libvirt-acl/src/Makefile.am =================================================================== --- libvirt-acl.orig/src/Makefile.am +++ libvirt-acl/src/Makefile.am @@ -67,6 +67,7 @@ UTIL_SOURCES = \ util/processinfo.c util/processinfo.h \ util/hostusb.c util/hostusb.h \ util/network.c util/network.h \ + util/interface.c util/interface.h \ util/qparams.c util/qparams.h \ util/stats_linux.c util/stats_linux.h \ util/storage_file.c util/storage_file.h \ Index: libvirt-acl/src/libvirt_private.syms =================================================================== --- libvirt-acl.orig/src/libvirt_private.syms +++ libvirt-acl/src/libvirt_private.syms @@ -681,6 +681,10 @@ virFileWaitForDevices; virFileMatchesNameSuffix; virArgvToString; +# interface.h +IfaceCtrl; +IfaceCheck; +IfaceGetIndex; # usb.h usbGetDevice; Index: libvirt-acl/src/nwfilter/nwfilter_learnipaddr.c =================================================================== --- libvirt-acl.orig/src/nwfilter/nwfilter_learnipaddr.c +++ libvirt-acl/src/nwfilter/nwfilter_learnipaddr.c @@ -43,6 +43,7 @@ #include "memory.h" #include "logging.h" #include "datatypes.h" +#include "interface.h" #include "virterror_internal.h" #include "threads.h" #include "conf/nwfilter_params.h" @@ -339,7 +340,7 @@ learnIPAddressThread(void *arg) break; } /* listening on linkdev, check whether VM's dev is still there */ - if (checkIf(req->ifname, req->macaddr)) { + if (IfaceCheck(false, req->ifname, req->macaddr, -1)) { req->status = ENODEV; break; } Index: libvirt-acl/src/util/macvtap.c =================================================================== --- libvirt-acl.orig/src/util/macvtap.c +++ libvirt-acl/src/util/macvtap.c @@ -44,6 +44,7 @@ # include "util.h" # include "memory.h" # include "macvtap.h" +# include "interface.h" # include "conf/domain_conf.h" # include "virterror_internal.h" @@ -193,109 +194,6 @@ nlAppend(struct nlmsghdr *nlm, int totle static int -getIfIndex(bool reportError, - const char *ifname, - int *idx) -{ - int rc = 0; - struct ifreq ifreq; - int fd = socket(PF_PACKET, SOCK_DGRAM, 0); - - if (fd < 0) - return errno; - - if (virStrncpy(ifreq.ifr_name, ifname, strlen(ifname), - sizeof(ifreq.ifr_name)) == NULL) { - if (reportError) - macvtapError(VIR_ERR_INTERNAL_ERROR, - _("invalid interface name %s"), - ifname); - rc = EINVAL; - goto err_exit; - } - if (ioctl(fd, SIOCGIFINDEX, &ifreq) >= 0) - *idx = ifreq.ifr_ifindex; - else { - if (reportError) - macvtapError(VIR_ERR_INTERNAL_ERROR, - _("interface %s does not exist"), - ifname); - rc = ENODEV; - } - -err_exit: - close(fd); - - return rc; -} - - -/* - * chgIfFlags: Change flags on an interface - * @ifname : name of the interface - * @flagclear : the flags to clear - * @flagset : the flags to set - * - * The new flags of the interface will be calculated as - * flagmask = (~0 ^ flagclear) - * newflags = (curflags & flagmask) | flagset; - * - * Returns 0 on success, errno on failure. - */ -static int chgIfFlags(const char *ifname, short flagclear, short flagset) { - struct ifreq ifr; - int rc = 0; - int flags; - short flagmask = (~0 ^ flagclear); - int fd = socket(PF_PACKET, SOCK_DGRAM, 0); - - if (fd < 0) - return errno; - - if (virStrncpy(ifr.ifr_name, - ifname, strlen(ifname), sizeof(ifr.ifr_name)) == NULL) { - rc = ENODEV; - goto err_exit; - } - - if (ioctl(fd, SIOCGIFFLAGS, &ifr) < 0) { - rc = errno; - goto err_exit; - } - - flags = (ifr.ifr_flags & flagmask) | flagset; - - if (ifr.ifr_flags != flags) { - ifr.ifr_flags = flags; - - if (ioctl(fd, SIOCSIFFLAGS, &ifr) < 0) - rc = errno; - } - -err_exit: - close(fd); - return rc; -} - -/* - * ifUp - * @name: name of the interface - * @up: 1 for up, 0 for down - * - * Function to control if an interface is activated (up, 1) or not (down, 0) - * - * Returns 0 in case of success or an errno code in case of failure. - */ -static int -ifUp(const char *name, int up) -{ - return chgIfFlags(name, - (up) ? 0 : IFF_UP, - (up) ? IFF_UP : 0); -} - - -static int link_add(const char *type, const unsigned char *macaddress, int macaddrsize, const char *ifname, @@ -314,7 +212,7 @@ link_add(const char *type, char *recvbuf = NULL; int recvbuflen; - if (getIfIndex(true, srcdev, &ifindex) != 0) + if (IfaceGetIndex(true, srcdev, &ifindex) != 0) return -1; *retry = 0; @@ -708,7 +606,7 @@ openMacvtapTap(const char *tgifname, *res_ifname = NULL; if (tgifname) { - if(getIfIndex(false, tgifname, &ifindex) == 0) { + if(IfaceGetIndex(false, tgifname, &ifindex) == 0) { if (STRPREFIX(tgifname, MACVTAP_NAME_PREFIX)) { goto create_name; @@ -727,7 +625,7 @@ create_name: retries = 5; for (c = 0; c < 8192; c++) { snprintf(ifname, sizeof(ifname), MACVTAP_NAME_PATTERN, c); - if (getIfIndex(false, ifname, &ifindex) == ENODEV) { + if (IfaceGetIndex(false, ifname, &ifindex) == ENODEV) { rc = link_add(type, macaddress, 6, ifname, linkdev, macvtapMode, &do_retry); if (rc == 0) @@ -741,7 +639,7 @@ create_name: cr_ifname = ifname; } - rc = ifUp(cr_ifname, 1); + rc = IfaceUp(cr_ifname); if (rc != 0) { virReportSystemError(errno, _("cannot 'up' interface %s -- another " Index: libvirt-acl/src/nwfilter/nwfilter_gentech_driver.h =================================================================== --- libvirt-acl.orig/src/nwfilter/nwfilter_gentech_driver.h +++ libvirt-acl/src/nwfilter/nwfilter_gentech_driver.h @@ -63,6 +63,4 @@ void virNWFilterDomainFWUpdateCB(void *p const char *name ATTRIBUTE_UNUSED, void *data); -int checkIf(const char *ifname, const unsigned char *macaddr); - #endif

2 2

[libvirt] [PATCH] add nwfilter functions to virsh man page
by Stefan Berger 12 Apr '10

12 Apr '10

Unfortunately after the 0.8.0 release, but here's a beginning of the documentation of the nwfilter functionality. Signed-off-by; Stefan Berger <stefanb(a)us.ibm.com> --- tools/virsh.pod | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 53 insertions(+) Index: libvirt-acl/tools/virsh.pod =================================================================== --- libvirt-acl.orig/tools/virsh.pod +++ libvirt-acl/tools/virsh.pod @@ -840,6 +840,59 @@ children of this snapshot. =back +=head1 NWFILTER COMMMANDS + +The following commands manipulate network filters. Network filters allow +to filter the network traffic comming from and going to virtual machines. +Individual network traffic filters are written in XML, may contain +references to other network filters, describe traffic filtering rules, +or contain both. Network filters are referenced by virtual machines +from within their interface description. A network filter may be referenced +by multiple virtual machines' interfaces. + +=over 4 + +=item B<nwfilter-define> I<xmlfile> + +Make a new network filter known to libvirt. If a network filter with +the same name already exists, it will be replaced with the new XML. +Any running virtual machine referencing this network filter will have +its network traffic rules adapted. If for any reason the network traffic +filtering rules cannot be instantiated by any of the running virtual +machines, then the new XML will be rejected. + +=item B<nwfilter-undefine> I<nwfilter-name> + +Delete a network filter. The deletion will fail if any running virtual +machine is currently using this network filter. + +=item B<nwfilter-list> + +List all of the available network filters. + +=item B<nwfilter-dumpxml> I<nwfilter-name> + +Output the network filter XML. + +=item B<nwfilter-edit> I<nwfilter-name> + +Edit the XML of a network filter. + +This is equivalent to: + + virsh nwfilter-dumpxml myfilter > myfilter.xml + edit myfilter.xml + virsh nwfilter-define myfilter.xml + +except that it does some error checking. +The new network filter may be rejected due to the same reason as +mention in I<nwfilter-define>. + +The editor used can be supplied by the C<$VISUAL> or C<$EDITOR> environment +variables, and defaults to C<vi>. + +=back + =head1 ENVIRONMENT The following environment variables can be set to alter the behaviour

2 2

[libvirt] cannot start a qemu64 model on an Intel host
by Dan Kenigsberg 12 Apr '10

12 Apr '10

If I specify <cpu match="exact"> <model>qemu64</model> </cpu> according to the new cpu schema, I get error: internal error guest CPU is not compatible with host CPU because qemu64 supports svm, and my host does not. However, the error remains when I explicitly ask to disable svm with <feature policy="disable" name="svm"/> I am not sure if this is a bug or an intended feature, but I'd expect cpu_disable taken into account when doing x86ModelCompare(host_model, cpu_require) Regards, Dan.

2 2

[libvirt] Release of libvirt-0.8.0
by Daniel Veillard 12 Apr '10

12 Apr '10

After heroic efforts in the last couple of weeks it is out ! That's by large the release packed with most new features ever, and the changelog is simply huge. I hope we didn't introduce too many bugs, but we certainly fixed a very large amount in the first place ! Tarball is available as usual from ftp://libvirt.org/libvirt/ And I won't try to sumarize the following ! Features: - esx: Add domain snapshot support (Matthias Bolte) - Snapshot API framework. (Chris Lalancette) - Add managed save API entry points (Daniel Veillard) - timer subselection for domain clock (Laine Stump) - Add hook utilities (Daniel Veillard) - cpuUpdate() for updating guest CPU according to host CPU (Jiri Denemark) - Network filtering API (Stefan Berger) - Introduce a new virDomainUpdateDeviceFlags public API (Daniel P. Berrange) - Introduce a new public API for domain events (Daniel P. Berrange) - Public virDomainMigrateSetMaxDowntime API (Jiri Denemark) - Add public API for volume wiping (David Allan) - xenapi: Initial commit of the new driver (Sharadha Prabhakar) Documentation: - Add documentation for synchronous hooks (Daniel Veillard) - Small fixes to virsh man page (Luiz Capitulino) - Avoid using multicast addresses for Ethernet MAC examples (redshift) - Fix unterminated B<...> in virsh man page (Jiri Denemark) - Document all options of virsh dumpxml (Jiri Denemark) - virsh: improve documentation (Eric Blake) - Document snapshot virsh commands in the man page. (Chris Lalancette) - Website documentation for the snapshot XML. (Chris Lalancette) - website: Add archive link for libvirt-users list (Matthias Bolte) - virsh: improve man page (Eric Blake) - Mention direct device support since 0.7.7 in docs (Stefan Berger) - esx: Improve documentation about remote URIs (Matthias Bolte) - doc: fix typos in hacking.html.in; mark HACKING as read-only (Jim Meyering) - doc: fix more typos in HACKING (Jim Meyering) - hacking: add a section on preprocessor conventions (Eric Blake) - hacking: fix typos (Eric Blake) - Update hacking.html.in (David Allan) Portability: - Fix Win32 portability problems (Daniel P. Berrange) - This patch fixes some compilation issues for the RHEL5 build (Stefan Berger) - util: Add stubs for some functions on Windows (Matthias Bolte) - Add HAVE_PTHREAD_H guard for pthread_sigmask (Matthias Bolte) - bootstrap: Enable copy-mode for MinGW builds (Matthias Bolte) - util: Handle lack of (f)chmod and (f)chown on Windows (Matthias Bolte) - bootstrap: Remove rsync from buildreq list (Matthias Bolte) - Make sure virtTestCaptureProgramOutput has a body on Windows (Matthias Bolte) - Fix export of virConnectAuthPtrDefault for MinGW builds (Matthias Bolte) - Make sure uid_t and gid_t are available (Matthias Bolte) Bug Fixes: - nwfilter: Fix memory leak on daemon init and shutdown (Stefan Berger) - More event callback fixes (Daniel P. Berrange) - Fix error in nwfilter test driver (Stefan Berger) - qemu: catch cdrom change error (Ryan Harper) - nwfilter: fix for directionality of ICMP traffic (Stefan Berger) - Fix CPU comparison for x86 arch (Jiri Denemark) - Don't ignore guest CPU selection when unsupported by HV (Jiri Denemark) - domain_event.c: don't deref NULL on an OOM error path (Jim Meyering) - nwfiler: fix due to non-symmetric src mac address match in iptables (Stefan Berger) - qemu_driver.c: don't close an arbitrary file descriptor (Jim Meyering) - Add VIR_DOMAIN_XML_INACTIVE flag when parsing domain XML (Jamie Strandboge) - virt-aa-helper should not fail if profile was removed (Jamie Strandboge) - Do nor clear caps when invoking virt-aa-helper (Jamie Strandboge) - virterror.c: avoid erroneous case "fall-through" (Jim Meyering) - Increase the number of available VNC ports. (Chris Lalancette) - Only assign newDef when we have a new def. (Chris Lalancette) - nwfilter: Fix random index in virNWFilterRuleDefDetailsFormat (Matthias Bolte) - xenapi: Fix uninitialized variable warning (Matthias Bolte) - Add a missing break statement to nwfilter errors. (Chris Lalancette) - VBox: Fix use of uninitialized value (Jiri Denemark) - Allow domain disk images on root-squash NFS to coexist with security driver. (Laine Stump) - Don't use virFileReadLimFD in qemuDomainRestore. (Chris Lalancette) - nwfilter's XML parser bug fixes (Stefan Berger) - ESX test case needs '/' in interface name (Stefan Berger) - Fix linker errors in proxy (Matthias Bolte) - virConnectGetLibVersion: Avoid error message on success. (Paolo Smiraglia) - Fix daemon hook script initialization (Daniel Veillard) - Fix QEMU cpu affinity at startup to include all threads (Daniel P. Berrange) - Fix "make check" run requesting authentication (Stefan Berger) - Don't replace persistent domain config with migrated config (Jiri Denemark) - Fix build break (David Allan) - esx: Make the conf parser compare names case insensitive in VMX mode (Matthias Bolte) - vbox: Fix segfault on empty device source (Matthias Bolte) - python example: poll(-0.001) does not sleep forever (Philipp Hahn) - Fix error reporting when parsing CPU XML strings (Jiri Denemark) - virDiskNameToIndex: ignore trailing digits (Jim Meyering) - esx: Fix potential memory leak in esxVI_BuildFullTraversalSpecItem (Matthias Bolte) - Avoid libvirtd crash when cgroups is not configured on host (Jim Fehlig) - security: selinux: Fix crash when releasing non-existent label (Cole Robinson) - Don't crash without a security driver (Guido Günther) - qemu: Fix FD leak in qemudStartVMDaemon (Matthias Bolte) - util: ensure virMutexInit is not recursive (Eric Blake) - Fix logroate rpm build breakage (Daniel Veillard) - Fix LSB compliance of init script (Daniel Veillard) - python: Fix networkLookupByUUID (Philip Hahn) - Fix make dist with XenAPI changes (Cole Robinson) - xenapi: Don't leak url and caps in case of error (Matthias Bolte) - xenapi: Check for NULL before accessing the scheme (Matthias Bolte) - xenapi: Request a username if there is non in the URI (Matthias Bolte) - xenapi: Check for valid private data in xenapiSessionErrorHandle (Matthias Bolte) - Use fsync() at the end of file allocation instead of O_DSYNC (Jiri Denemark) - security: Set permissions for kernel/initrd (Cole Robinson) - qemu: Fix USB by product with security enabled (Cole Robinson) - Make nodeGetInfo report the correct number of NUMA nodes. (Chris Lalancette) - Fix crash in virsh after bogus command (Chris Lalancette) - Fix virsh command 'cd' (Chris Lalancette) - Fix hang in qemudDomainCoreDump. (Chris Lalancette) - Make sure qemudDomainSetVcpus doesn't hang. (Chris Lalancette) - Fix a JSON CPU information bug. (Chris Lalancette) - Free resources on error in udev startup (David Allan) - Fix up nodeinfo parsing code. (Chris Lalancette) - Wipe nodeinfo structure before filling it (Jiri Denemark) - macvtap build detection fix (Stefan Berger) - Fix virDomainGetXMLDesc cache settings output (Soren Hansen) - Fix locking in qemudDomainMemoryStats (Adam Litke) - qemu restore: don't let corrupt input provoke unwarranted OOM (Jim Meyering) - virFileReadLimFD: diagnose maxlen <= 0, rather than passing it on... (Jim Meyering) - xen: don't let bogus packets trigger over-allocation and segfault (Jim Meyering) Improvements: - Rename virsh "revert-to-snapshot" to "snapshot-revert" (Chris Lalancette) - nwfilter: Process DHCP option to determine whether packet is a DHCP_OFFER (Stefan Berger) - Add enospace option to qemu disk error policy (David Allan) - nwfilter: More XML parser test cases (Stefan Berger) - remote: Replace some virRaiseError with remoteError (Matthias Bolte) - Generate libvirt.def from libvirt.syms (Matthias Bolte) - Fix up python bindings for new event callbacks (Daniel P. Berrange) - esx: Allow 'lsisas1068' as SCSI controller type (Matthias Bolte) - esx: Report an error for invalid arguments in esxList(Defined)Domains (Matthias Bolte) - nwfilter: Support for learning a VM's IP address (Stefan Berger) - Properly advertise cpuselection guest capability (Jiri Denemark) - Update of the apparmor regression tests (Jamie Strandboge) - Improve the apparmor example (Jamie Strandboge) - Improve virt-aa-helper to handle SDL graphics and cleanups (Jamie Strandboge) - Adjust virt-aa-helper to handle pci devices (Jamie Strandboge) - Add backingstore support to apparmor (Jamie Strandboge) - build: avoid autogen on 'make clean' (Eric Blake) - Add filter schema for nwfilter XML, extend domain XML schema (Stefan Berger) - Add filter schema for nwfilter XML, extend domain XML schema (Stefan Berger) - nwfilter: Fix instantiated layer 2 rules for 'inout' direction (Stefan Berger) - Better error reporting in virsh. (Chris Lalancette) - Snapshot virsh implementation. (Chris Lalancette) - Snapshots for VBox (Jiri Denemark) - Snapshot QEMU driver. (Chris Lalancette) - Snapshot internal methods. (Chris Lalancette) - xenapi: Add managedsave entries to the driver struct (Matthias Bolte) - Add a managedsave command to virsh (Daniel Veillard) - Implement managed save operations for qemu driver (Daniel Veillard) - Implement remote protocol for managed save (Daniel Veillard) - build: improve check for out-of-date .gnulib submodule (Eric Blake) - optimizes the validation of the name of an interface (Stefan Berger) - adds a couple of test cases for the XML parsing test suite (Stefan Berger) - build: import latest gnulib (Eric Blake) - Changes to clock timer XML to match final design. (Laine Stump) - Keep build quiet for generated file (Daniel P. Berrange) - Keep track of guest paused state after disk IO / watchdog events (Daniel P. Berrange) - virsh: add 'exit' as an alias for 'quit' (Eric Blake) - maint: mark xenapiSessionErrorHandler messages for translation (Jim Meyering) - Blank out invalid interface names with escaped letters etc. (Stefan Berger) - esx: Generate most SOAP mapping and improve inheritance handling (Matthias Bolte) - Distribute nwfilter xml files and add them to rpm (Daniel Veillard) - Make sure nwfilter headers are part of distribution (Daniel Veillard) - maint: show which compiler warning triggered (Eric Blake) - build: automate the rerun of autogen.sh (Eric Blake) - makes the entries in the int-2-string maps more readable (Stefan Berger) - Add ip6tables support for IPv6 filtering (Stefan Berger) - Add support for so-far missing protocols for iptables filtering (Stefan Berger) - Implement the qemu-kvm backend of clock timer elements (Laine Stump) - Add flags to indicate presence of timekeeping-related qemu options (Laine Stump) - Add timer element to domain schema (Laine Stump) - virsh: support VISUAL, and allow metacharacters in EDITOR (Eric Blake) - Add dummy nwfilter driver to test driver (Stefan Berger) - Add script hook support to the LXC driver (Daniel Veillard) - Add script hook support to the QEmu driver (Daniel Veillard) - Add the script hook support to the libvirt daemon (Daniel Veillard) - Add an error module and message for the hooks subsystem (Daniel Veillard) - Export virPipeReadUntilEOF internally (Daniel Veillard) - Introduce UPDATE_CPU flag for virDomainGetXMLDesc (Jiri Denemark) - Helper function for making a copy of virCPUDefPtr (Jiri Denemark) - filter new files through cppi, so syntax-check passes once again (Jim Meyering) - Add disk error policy to domain XML (David Allan) - build: don't lose prior configure args on autogen.sh (Eric Blake) - build: update gnulib (Eric Blake) - Add some examples filters (Stefan Berger) - Extensions for iptables rules (Stefan Berger) - Add IPv6 support for the ebtables layer (Stefan Berger) - Add qemu support (Stefan Berger) - Core driver implementation with ebtables support (Stefan Berger) - Add XML parser extensions for network filtering (Stefan Berger) - Add virsh support for new CLI commands (Stefan Berger) - Definition of the wire format, RPC client & server (Stefan Berger) - Add Network filtering internal API (Stefan Berger) - Add Network filtering public API (Stefan Berger) - Add recursive locks (Stefan Berger) - Implement VNC password change in QEMU (Daniel P. Berrange) - Allow parsing <graphics> in device XML (Daniel P. Berrange) - Introduce a update-device command in virsh (Daniel P. Berrange) - Implement virDomainUpdateDeviceFlags API in all drivers with media change (Daniel P. Berrange) - Remote protocol impl for virDomainUpdateDeviceFlags (Daniel P. Berrange) - Add domain events for graphics network clients (Daniel P. Berrange) - Add support for an explicit IO error event (Daniel P. Berrange) - Add support for an explicit watchdog event (Daniel P. Berrange) - Add support for an explicit RTC change event (Daniel P. Berrange) - Add support for an explicit guest reboot event (Daniel P. Berrange) - Rename domain lifecycle event message (Daniel P. Berrange) - Convert domain events example to new API (Daniel P. Berrange) - Remote driver & daemon impl of new event API (Daniel P. Berrange) - Support new event register/deregister APis in all drivers except remote (Daniel P. Berrange) - Add new internal domain events APIs for handling other event types (Daniel P. Berrange) - Refactor domain events to handle multiple event types (Daniel P. Berrange) - Make internal domain events struct definitions private (Daniel P. Berrange) - tests: teach syntax-check that virDomainDefFree has free-like semantics (Jim Meyering) - Add entry point logging for cpu functions (Jiri Denemark) - build: suppress distracting build output (Jim Meyering) - maint: add syntax-check rule to prohibit use of test's -a operator (Jim Meyering) - tests: shell script portability and clean-up (Jim Meyering) - tests: Don't add extra padding if counter mod 40 is 0 (Matthias Bolte) - Use common XML parsing functions (Jiri Denemark) - Introduce XML parsing utility functions (Jiri Denemark) - virDomainDiskDefAssignAddress: return int, not void (Jim Meyering) - tests: do not use the ":disk" suffix in sample xml input (Jim Meyering) - util: Make some conditional symbols unconditional (Matthias Bolte) - Export conditional state driver symbols only when they are defined (Matthias Bolte) - esx: Add esxVI_LookupVirtualMachineByName (Matthias Bolte) - esx: Generate method mappings via macros (Matthias Bolte) - Add migrate-setmaxdowntime command to virsh (Jiri Denemark) - Implement virDomainMigrateSetMaxDowntime in qemu driver (Jiri Denemark) - Implement virDomainMigrateSetMaxDowntime in remote driver (Jiri Denemark) - Wire protocol and dispatcher for virDomainMigrateSetMaxDowntime (Jiri Denemark) - Internal driver API for virDomainMigrateSetMaxDowntime (Jiri Denemark) - Virsh support for vol wiping (David Allan) - Simplified version of volume wiping based on feedback from the list. (David Allan) - Implement remote bits for vol wiping (David Allan) - Implement the public API for vol wiping (David Allan) - Define the internal driver API for vol wiping (David Allan) - Support vhost-net mode at qemu startup for virtio network devices (Laine Stump) - maint: enforce recent N_ usage (Eric Blake) - Allow suspend during live migration (Jiri Denemark) - do not require two ./autogen.sh runs to permit "make" (Jim Meyering) - esx: Move username and password helper functions to authhelper.c (Matthias Bolte) - Use WARN_CFLAGS when compiling virsh.c (Jiri Denemark) - qemu: Add some debugging at domain startup (Cole Robinson) - qemu: pass the information when disks are read-only (Daniel Veillard) - macvtap: Only export symbols if support is enabled (Matthias Bolte) - Only use the numa functions when they are available. (Chris Lalancette) - Allow devices without a parent (Ed Swierk) - build: change to gnulib module list should rerun bootstrap (Eric Blake) - build: enforce preprocessor indentation (Eric Blake) - build: update gnulib submodule to newer (but not latest) (Jim Meyering) - Make virsh reconnect when losing connection (Daniel Veillard) - Change logrotate to be per-hypervisor logs (Daniel Veillard) - build: consistently indent preprocessor directives (Eric Blake) - virsh: use N_ rather than gettext_noop (Eric Blake) - virsh: fix existing N_ uses (Eric Blake) - Get thread and socket information in virsh nodeinfo. (Chris Lalancette) - Eliminate large stack buffer in doTunnelSendAll (Laine Stump) - build: consistently use C99 varargs macros (Eric Blake) Cleanups: - Fix some cppi prepocessor indentation issues (Daniel Veillard) - Cleanup the msg_gen_function list in cfg.mk (Matthias Bolte) - remote: Remove virConnectPtr from error/errorf (Matthias Bolte) - Remove undefined symbols from symbols file (Matthias Bolte) - Add missing nwfilter_learnipaddr.c to POTFILES.in (Daniel P. Berrange) - Avoid searching for windres when not building for Windows (Diego Elio Pettenò) - Executable does not belong into repository. (Stefan Berger) - xenXMDomainDefineXML: remove dead store and useless/leaky virGetDomain (Jim Meyering) - createRawFileOpHook: avoid dead stores (Jim Meyering) - qemudDomainGetSecurityLabel: avoid dead store to "type" (Jim Meyering) - Cleanup x86Compute() (Jiri Denemark) - qemuDomainSnapshotLoad: avoid dead store (Jim Meyering) - maint: s/initialis/initializ/ (Eric Blake) - Fix 'avialable' typo (Matthias Bolte) - macvtap: Remove virConnectPtr from ReportError (Matthias Bolte) - phyp: Remove virConnectPtr from PHYP_ERROR (Matthias Bolte) - esx: Mark error messages for translation (Matthias Bolte) - vbox: Mark all error messages for translation (Matthias Bolte) - Clarify an error message in setmem. (Chris Lalancette) - Fix up comments for isEncrypted, isSecure, domainIsActive, and domainIsPersistent. (Chris Lalancette) - Fix compiler warning about unused conn parameter (Matthias Bolte) - openvz: Remove virConnectPtr from openvzError (Matthias Bolte) - one: Remove virConnectPtr from oneError (Matthias Bolte) - uml: Remove virConnectPtr from umlReportError (Matthias Bolte) - Remove virConnectPtr from eventReportError (Matthias Bolte) - Remove virConnectPtr from virLibConnError (Matthias Bolte) - xen: Remove virConnectPtr from xenUnifiedError (Matthias Bolte) - Remove virConnectPtr from nodeReportError (Matthias Bolte) - netcf: Remove virConnectPtr from interfaceReportError (Matthias Bolte) - xen: Remove virConnectPtr from virXenInotifyError (Matthias Bolte) - xen: Remove virConnectPtr from virXenStoreError (Matthias Bolte) - xen: Remove virConnectPtr from virXenError/virXenErrorFunc (Matthias Bolte) - xen: Remove virConnectPtr from virXMError (Matthias Bolte) - xen: Remove virConnectPtr from virXendError (Matthias Bolte) - proxy: Remove virConnectPtr from virProxyError (Matthias Bolte) - vbox: Remove virConnectPtr from vboxError (Matthias Bolte) - test: Remove virConnectPtr from testError (Matthias Bolte) - Remove unnecessary trailing \n in log messages (Matthias Bolte) - Fix compiler warning about non-literal format string (Matthias Bolte) - removes the virConnectPtr parameter where not necessary (Stefan Berger) - Clarified error message (David Allan) - Eliminate compiler warning about non-const format string (Laine Stump) - Get rid of the regular expressions (Stefan Berger) - Use the virStrToLong_ui() function rather than virStrToLong_i() (Stefan Berger) - Make virDomainLoadConfig static. (Chris Lalancette) - Eliminate compile warnings in nwfilter error log calls (Laine Stump) - Only parse 'CPU XML' in virCPUDefParseXML() (Jim Fehlig) - Replace sscanf in PCI device address parsing (Matthias Bolte) - xen: Use virStrToLong_i instead of sscanf for XenD port parsing (Matthias Bolte) - xenapi: Use virStrToLong_i instead of sscanf for CPU map parsing (Matthias Bolte) - openvz: Use strtok_r instead of sscanf for VPS UUID parsing (Matthias Bolte) - xen: Use virParseMacAddr instead of sscanf (Matthias Bolte) - vbox: Replace atoi with virStrToLong_i (Matthias Bolte) - cgroup: Replace sscanf with virStrToLong_ll (Matthias Bolte) - Refactor major.minor.micro version parsing into a function (Matthias Bolte) - Replace sscanf in nwfilter rule parsing (Matthias Bolte) - Replace sscanf in legacy device address parsing (Matthias Bolte) - build: more fallout from test -a (Eric Blake) - Fix apibuild.py warning about virNWFilterLookupByUUIDString (Matthias Bolte) - maint: remove redundant tests after virStrToLong (Eric Blake) - maint: update AUTHORS (Eric Blake) - maint: fix cpp indentation syntax-check failure (Jim Meyering) - Add virt-aa-helper and secaatest to .gitignore (Matthias Bolte) - esx: Remove redundant semicolons (Matthias Bolte) - Use libvirt's existing ipv6/ipv4 parser/printer (Stefan Berger) - Remove driver dependency from nwfilter_conf.c (Stefan Berger) - Fix a merge error leftover (Daniel Veillard) - Use enum of virDomainNetType (Stefan Berger) - Silence cppi syntax-check warning (Daniel Veillard) - maint: update syntax-check rule to also catch test's -o operator (Eric Blake) - build: don't use "test cond1 -o cond2": it's not portable (Eric Blake) - build: don't use "test cond1 -a cond2" in configure: it's not portable (Jim Meyering) - Remove interfaceRegister from libvirt_private.syms (Matthias Bolte) - esx: Cleanup file header comments (Matthias Bolte) - maint: enforce recent copyright style (Eric Blake) - maint: make Red Hat copyright notices consistent (Eric Blake) - maint: fix typo (Eric Blake) - docs: <pre> cannot be nested in (Matthias Bolte) - .gitignore: Ignore generated daemon/libvirtd.logrotate (Cole Robinson) - phyp: Use virRequestUsername and virRequestPassword (Matthias Bolte) - fix two "make syntax check" failures (Jim Meyering) - Fix syntax-check errors (Jiri Denemark) - Fix error messages in qemu text monitor (Jiri Denemark) - Fix compiler warnings in virsh.c (Laine Stump) - Silence compiler complaints about non-literal format strings (Laine Stump) - Remove qemudDomainSetMaxMemory. (Chris Lalancette) - Fix copy&paste typos in virProcessInfoGetAffinity (Jiri Denemark) - AUTHORS: add recent contributors (Eric Blake) - Fix format string warnings (Laine Stump) - ebtablesAddRemoveRule: avoid dead store (Jim Meyering) - virInterfaceDefParseBond: avoid dead stores (Jim Meyering) - xenXMDomainConfigParse: avoid dead store (Jim Meyering) - qemuMonitorTextGetMemoryStats: decrease risk of false positive in parsing (Jim Meyering) A lot of people helped for this release, including a number of new contributors, so let's all enjoy before the bugs start to pop up :-) ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] Documentation for synchronous hooks
by Daniel Veillard 12 Apr '10

12 Apr '10

Was still missing from main commits and would be needed for 0.8.0 Add documentation for synchronous hooks * docs/sitemap.html.in: add in navigation under Documentation/Deployment/Hooks * docs/hooks.html.in: new doc describing current support for 0.8.0 diff --git a/docs/hooks.html.in b/docs/hooks.html.in new file mode 100644 index 0000000..4ebeec3 --- /dev/null +++ b/docs/hooks.html.in @@ -0,0 +1,71 @@ +<?xml version="1.0"?> +<html> + <body> + <h1>Hooks for specific system management</h1> + Libvirt includes synchronous hooks starting from version 0.8.0, + this is a way to tie specific tailored system actions at specific + time. This is based on scripts being called on the Host where the + hypervisor is running, if the script is present when the libvirtd + daemon is doing some significant actions. + The scripts are expected to execute quickly, return a zero exit + status if all conditions are set for the daemon to continue the + action (non zero will be considered a failure which may + be ignored but in general will stops the ongoing operation). + The script also should not call back into libvirt as the daemon + is waiting for the script exit and deadlock is likely to occur + otherwise. + The scripts are stored in the directory <code>/etc/libvirt/hooks/</code> + when using a standard installation path + (<code>$SYSCONF_DIR/libvirt/hook/</code> in general). + The scripts gets arguments as parameter on their command line: + <ul> + <li> the first argument is the name of the object involved in the + operation or '-' if there is none. + <li> the second argument is the name of the operation. + <li> the third argument is a suboperation indication like 'start' + 'end' or '-' if there is none. + <li> the last argument is an extra argument string or '-' if there + is none. + </ul> + There is currently scripts for 3 domains of operation: + <ul> + <li><code>/etc/libvirt/hooks/daemon</code> script if + present is called at 3 points in time: + at daemon startup, typically started with the following + arguments: + <pre>/etc/libvirt/hooks/daemon - start - start</pre> + at daemon shutdown when it is about to exit, with the following + arguments: + <pre>/etc/libvirt/hooks/daemon - shutdown - shutdown</pre> + When the daemon is asked to reload its driver state when + receiving the SIGHUP signal, arguments are: + <pre>/etc/libvirt/hooks/daemon - reload begin SIGHUP</pre> + </li> + <li><code>/etc/libvirt/hooks/qemu</code> script and + <code>/etc/libvirt/hooks/lxc</code> to associate hooks for domain + operation on the respective QEmu/KVM and LXC drivers. + The domain related hooks also receive the full XML description + for the concerned domain on their stdin, which allows to get + all the informations from the domain, including UUID or storage + if that is needed for the script operation. + Currently only domain startup and domain end operations + involve the hook, the first one just before the domain gets + created. + For example if starting a QEmu domain named <code>test</code> + the following script will get called: + <pre>/etc/libvirt/hooks/qemu test start begin -</pre> + note that a non-zero return value from the script will abort the + domain startup operation, and if an error string is passed on + stderr by the hook script, it will be provided back to the user + at the libvirt API level. + For domain shutdown, the script will be called just after the + domain has finished execution, and the script will get: + <pre>/etc/libvirt/hooks/qemu test stopped end -</pre> + It is expected that other operation will be associated to hooks + but at the time of 0.8.0 only those 2 are associated to domains + lifecycle + </li> + </ul> + + </body> +</html> diff --git a/docs/sitemap.html.in b/docs/sitemap.html.in index 0c3f0c3..0117c8d 100644 --- a/docs/sitemap.html.in +++ b/docs/sitemap.html.in @@ -50,6 +50,10 @@ <a href="logging.html">Logging</a> The library and the daemon logging support </li> + <li> + <a href="hooks.html">Hooks</a> + Hooks for system specific management + </li> </ul> </li> <li> -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

3 3

[libvirt] [PATCH v1 0/2] Add missing protocol filters for IPv4 and add IPv6 support
by Stefan Berger 12 Apr '10

12 Apr '10

The first one of the following two patches adds support for filtering of ah, esp and udplite protocols. The 2nd one adds support for filtering of IPv6 traffic. With this now nearly all protocols of IPv4 and IPv6 (except mh) as supported by iptables/ip6tables are reachable via the filtering XML. Some features of those protocols still need support in data structures and XML attributes, though. Another thing that's missing is support for filtering of IPv6's NDP traffic (IPv6 equivalent of ARP) but there's no support for this in ebtables. Regards, Stefan

2 7

[libvirt] migration flags
by Kenneth Nagin 12 Apr '10

12 Apr '10

Could someone explain the usage of the following migration flags: --p2p --direct --tunneled --persistent Kenneth Nagin

2 1

[libvirt] creating domain with same name and different UUID
by Nikola Ciprich 12 Apr '10

12 Apr '10

Hello, I have small problem with libvirt, which I'm trying to solve... I'm using defineXML function to create KVM machines. from time to time, I need to delete the domain, and create new one with the same name. every newly created domain has new UUID. and this is where the problem starts, defineXML function documentation tells that previous definition domain would be overriden if it already exists, but it ends up with following error: libvir: Domain Config error : operation failed: domain 'vmnci01' already exists with uuid 8d9795b3-461e-11df-9882-00304834195b Traceback (most recent call last): File "/usr/libexec/vm2.py", line 173, in ? vm.start() File "/usr/libexec/vmmain2.py", line 433, in start self.dom = self.svconn.defineXML(self.xmldef.vm.domain.xml()) File "/usr/lib64/python2.4/site-packages/libvirt.py", line 1120, in defineXML if ret is None:raise libvirtError('virDomainDefineXML() failed', conn=self) libvirt.libvirtError: operation failed: domain 'vmnci01' already exists with uuid 8d9795b3-461e-11df-9882-00304834195b If I try to undefine domain first, it still seems to behave weirdly: [root@vbox1 libexec]# vm __start__ vmnci01 undefining domain... Starting HVM guest vmnci01 libvir: QEMU error : Domain not found: no domain with matching uuid '8d9795b3-461e-11df-9882-00304834195b' Traceback (most recent call last): File "/usr/libexec/vm2.py", line 173, in ? vm.start() File "/usr/libexec/vmmain2.py", line 436, in start self.dom.create() File "/usr/lib64/python2.4/site-packages/libvirt.py", line 300, in create if ret == -1: raise libvirtError ('virDomainCreate() failed', dom=self) libvirt.libvirtError: Domain not found: no domain with matching uuid '8d9795b3-461e-11df-9882-00304834195b' Could anybody help me with this? Am I doing something wrong? Currently, I'm using libvirt-0.7.6 Thanks a lot in advance! with best regards nik A -- ------------------------------------- Ing. Nikola CIPRICH LinuxBox.cz, s.r.o. 28. rijna 168, 709 01 Ostrava tel.: +420 596 603 142 fax: +420 596 621 273 mobil: +420 777 093 799 www.linuxbox.cz mobil servis: +420 737 238 656 email servis: servis(a)linuxbox.cz -------------------------------------

2 1

[libvirt] question about libvirt-tck/libivrt-perl
by Gerhard Stenzel 12 Apr '10

12 Apr '10

Hi, I have a small libvirt-TCK script, which fails in a for me unexpected way: ########################################################## use strict; use warnings; use Term::ReadKey; use Test::More tests => 4; use Sys::Virt::TCK; my $tck = Sys::Virt::TCK->new(); my $conn = eval { $tck->setup(); }; BAIL_OUT "failed to setup test harness: $@" if $@; END { $tck->cleanup if $tck; } # first domain my $xml = $tck->generic_domain("tck")->as_xml; my $dom; ok_domain(sub { $dom = $conn->create_domain($xml) }, "defined domain config"); my $uuid = $dom->get_uuid_string(); diag $uuid; $xml = $dom->get_xml_description; diag "Starting inactive domain config"; ok($dom->get_id() > 0, "running domain has an ID > 0"); $dom->destroy; # new domain my $newxml = $tck->generic_domain("tck")->as_xml; my $newdom; ok_domain(sub { $newdom = $conn->create_domain($newxml) }, "defined domain config"); my $newuuid = $newdom->get_uuid_string(); diag $newuuid; $newxml = $newdom->get_xml_description(); ok($newdom->get_id() > 0, "running domain has an ID > 0"); $newdom->destroy; ########################################################## scripts/network/001-prepare-image.t .. 1..4 ok 1 - defined domain config # 4317db52-00bb-3cac-5639-91cdce05a717 # Starting inactive domain config ok 2 - running domain has an ID > 0 ok 3 - defined domain config # 4317db52-00bb-3cac-5639-91cdce05a717 libvirt error code: 42, message: Domain not found: no domain with matching uuid '4317db52-00bb-3cac-5639-91cdce05a717' # Looks like you planned 4 tests but ran 3. # Looks like your test exited with 255 just after 3. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/4 subtests Test Summary Report ------------------- scripts/network/001-prepare-image.t (Wstat: 65280 Tests: 3 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 4 tests but ran 3. Files=1, Tests=3, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.19 cusr 0.04 csys = 0.26 CPU) Result: FAIL ########################################################## If I change my $newxml = $tck->generic_domain("tck")->as_xml; to my $newxml = $tck->generic_domain("tck2")->as_xml; the script works as expected. I am wondering if this is a problem in the libvirt-perl wrapper or working as designed and my expectation is simply wrong? Thanks in advance... -- Best regards, Gerhard Stenzel, ----------------------------------------------------------------------------------------------------------------------------------- IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martin Jetter Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294

3 4

[libvirt] [PATCH 0/1] enospace disk error policy
by David Allan 12 Apr '10

12 Apr '10

Dan Kenigsberg requested that we add an option to explicitly request enospace as the disk error policy. David Allan (1): Add enospace option to qemu disk error policy docs/schemas/domain.rng | 1 + src/conf/domain_conf.c | 3 +- src/conf/domain_conf.h | 1 + src/qemu/qemu_conf.c | 2 + tests/qemuargv2xmltest.c | 3 ++ ...uxml2argv-disk-drive-error-policy-enospace.args | 1 + ...muxml2argv-disk-drive-error-policy-enospace.xml | 32 ++++++++++++++++++++ 7 files changed, 42 insertions(+), 1 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-error-policy-enospace.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-error-policy-enospace.xml

5 6

[libvirt] libvirt: C++ or Java?
by Ganesh Pagade 12 Apr '10

12 Apr '10

Hello, I am planning to develop a management application for managing Redhat Xen and Redhat KVM hypervisors. I am evaluating the Java bindings versus the C++ version of libvirt. As part of evaluation, I could not find meaningful answers to the questions below. Hence, I thought that people on this mailing list would be the most appropriate to comment on them. Can you please let me know your views? 1. Are all functions that are available in C API available in Java? 2. Are Java bindings added along with every enhancement to C API? 3. If answer to above question is negative, typically how long does it takes for the addition of Java bindings for the enhancement? 4. Most of libvirt based third party management applications use which of Java bindings or C API? 5. What are your good/bad experiences while using either of C API or Java bindings? 6. What is your concluding personal recommendation? And finally, since libvirt is a Redhat Emerging Technology project, does Redhat or any other third party service providers provide paid assistance, support? Appreciate your time. Thanks. Regards, Ganesh

3 2

[libvirt] [PATCH 0/6]: Domain Snapshot API
by Chris Lalancette 12 Apr '10

12 Apr '10

Hello, Here is the next set of patches for the snapshot API. This set is much more complete, and implements the virDomainRevertToSnapshot() semantic instead of virDomainCreateFromSnapshot() that we discussed earlier. I've also incorporated all of the comments from the review of the first round of patches. Aside from implementation bugs, I consider this patchset complete. The only thing missing from the patches is real documentation along the lines of the API docs that we had discussed on-list. Next week I'll followup with some additions to the documentation that explain the semantics of these calls. Again review and comments are welcome. Chris Lalancette

6 24

[libvirt] [PATCH] Rename virsh "revert-to-snapshot" to "snapshot-revert"
by Chris Lalancette 12 Apr '10

12 Apr '10

Signed-off-by: Chris Lalancette <clalance(a)redhat.com> --- tools/virsh.c | 10 +++++----- tools/virsh.pod | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 8017beb..d5fe6c4 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -8514,22 +8514,22 @@ cleanup: } /* - * "revert-to-snapshot" command + * "snapshot-revert" command */ -static const vshCmdInfo info_revert_to_snapshot[] = { +static const vshCmdInfo info_snapshot_revert[] = { {"help", N_("Revert a domain to a snapshot")}, {"desc", N_("Revert domain to snapshot")}, {NULL, NULL} }; -static const vshCmdOptDef opts_revert_to_snapshot[] = { +static const vshCmdOptDef opts_snapshot_revert[] = { {"domain", VSH_OT_DATA, VSH_OFLAG_REQ, N_("domain name, id or uuid")}, {"snapshotname", VSH_OT_DATA, VSH_OFLAG_REQ, N_("snapshot name")}, {NULL, 0, 0, NULL} }; static int -cmdDomainRevertToSnapshot(vshControl *ctl, const vshCmd *cmd) +cmdDomainSnapshotRevert(vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom = NULL; int ret = FALSE; @@ -8786,7 +8786,7 @@ static const vshCmdDef commands[] = { {"snapshot-delete", cmdSnapshotDelete, opts_snapshot_delete, info_snapshot_delete}, {"snapshot-dumpxml", cmdSnapshotDumpXML, opts_snapshot_dumpxml, info_snapshot_dumpxml}, {"snapshot-list", cmdSnapshotList, opts_snapshot_list, info_snapshot_list}, - {"revert-to-snapshot", cmdDomainRevertToSnapshot, opts_revert_to_snapshot, info_revert_to_snapshot}, + {"snapshot-revert", cmdDomainSnapshotRevert, opts_snapshot_revert, info_snapshot_revert}, {NULL, NULL, NULL, NULL} }; diff --git a/tools/virsh.pod b/tools/virsh.pod index 46ba813..4af5603 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -819,12 +819,12 @@ List all of the available snapshots for the given domain. Output the snapshot XML for the domain's snapshot named I<snapshot>. -=item B<revert-to-snapshot> I<domain> I<snapshot> +=item B<snapshot-revert> I<domain> I<snapshot> Revert the given domain to the snapshot specified by I<snapshot>. Be aware that this is a destructive action; any changes in the domain since the snapshot was taken will be lost. Also note that the state of the domain after -revert-to-snapshot is complete will be the state of the domain at the time +snapshot-revert is complete will be the state of the domain at the time the original snapshot was taken. =item B<snapshot-delete> I<domain> I<snapshot> I<--children> -- 1.6.6.1

2 2

[libvirt] [PATCH 0/2]: Two small fixes
by Luiz Capitulino 12 Apr '10

12 Apr '10

Two small issues I found while testing libvirt under QMP, there is also a third I won't fix today: dommemstat doesn't work under QMP.

2 5

[libvirt] [PATCH 0/2] Enhance checking of supported flags in drivers
by Jiri Denemark 12 Apr '10

12 Apr '10

I think we need a simple and consistent way of checking whether flags passed to API entry points in drivers are valid/supported or not. So far some entry points don't check flags at all and some checks for 0 when no flags are expected/supported. The first patch introduces a macro which can be called with a whitelist of supported flags (more info about it inside the patch). I don't particularily like introducing a new header file but non of existing header files looked like a good place to stick this macro in. If you think such a place exist, I'll be very happy to adapt the patch. The second patch changes all API calls introduced since the last release to use the macro for checking valid flags. I'm not sure if we can change existing API calls to do the same as it could break some badly written apps which pass invalid flags. My opinion is that we may often do that as such apps don't use the API in a documented/valid way. But even if my thinking is correct, we don't want to change it before 0.8.0. Jirka Jiri Denemark (2): Introduce virCheckFlags for consistent flags checking Use virCheckFlags for APIs added in 0.8.0 src/Makefile.am | 3 +- src/esx/esx_driver.c | 44 ++++++++++++------------- src/nwfilter/nwfilter_driver.c | 5 ++- src/qemu/qemu_driver.c | 69 +++++++++++++++++++--------------------- src/storage/storage_driver.c | 7 +--- src/util/checks.h | 37 +++++++++++++++++++++ src/vbox/vbox_tmpl.c | 42 +++++++++++++++++------- src/xen/xend_internal.c | 5 +++ 8 files changed, 133 insertions(+), 79 deletions(-) create mode 100644 src/util/checks.h

2 3

[libvirt] [PATCH] nwfilter: Fix memory leak on daemon init and shutdown
by Stefan Berger 12 Apr '10

12 Apr '10

This patch fixes a memory leak on daemon init and shutdown. The module was initialized twice and not shut down. Signed-off-by: Stefan Berger <stefanb(a)us.ibm.com>

2 2

[libvirt] libvirt Error Domain didn't show up
by Roche, Christian (EXT-Other - MA/Rabat) 12 Apr '10

12 Apr '10

Hi there, I'm trying to use kvm on CentOS 5.4 64-bit to virtualize Windows Server 2003. I've been able to install and start the system using 1GB of memory, however when I try to increase the amount of memory available to the VM to 4GB by editing /etc/libvirt/qemu/windows2003.xml, I get the following message when starting the VM through virt-manager: --------------------------------- Error starting domain: internal error Domain windows2003 didn't show up Traceback (most recent call last): File "/usr/share/virt-manager/virtManager/engine.py", line 498, in run_domain vm.startup() File "/usr/share/virt-manager/virtManager/domain.py", line 573, in startup self.vm.create() File "/usr/lib64/python2.4/site-packages/libvirt.py", line 287, in create if ret == -1: raise libvirtError ('virDomainCreate() failed', dom=self) libvirtError: internal error Domain windows2003 didn't show up --------------------------------- Here is the content of /var/log/libvirt/qemu/windows2003.log : --------------------------------- LC_ALL=C PATH=/sbin:/usr/sbin:/bin:/usr/bin /usr/bin/qemu-system-x86_64 -S -M pc -no-kqemu -m 4096 -smp 4 -monitor pty -pidfile /var/run/libvirt/qemu//windows2003.pid -localtime -boot c -hda /dev/mapper/Raid5-Windows -cdrom /var/lib/libvirt/images/viostor.iso -net nic,macaddr=54:52:00:07:a9:b6,vlan=0 -net tap,fd=16,script=,vlan=0,ifname=vnet0 -serial pty -parallel none -usb -usbdevice tablet -vnc 127.0.0.1:0 -k fr QEMU PC emulator version 0.9.0, Copyright (c) 2003-2007 Fabrice Bellard usage: qemu [options] [disk_image] 'disk_image' is a raw hard image image for IDE hard disk 0 Standard options: -M machine select emulated machine (-M ? for list) -fda/-fdb file use 'file' as floppy disk 0/1 image -hda/-hdb file use 'file' as IDE hard disk 0/1 image blah blah blah --------------------------------- It looks like qemu is unhappy about the memory parameter. Here is my config: >uname -a Linux silver 2.6.18-164.15.1.el5 #1 SMP Wed Mar 17 11:30:06 EDT 2010 x86_64 x86_64 x86_64 GNU/Linux >grep virt /var/log/rpmpkgs libvirt-0.6.3-20.1.el5_4.x86_64.rpm libvirt-python-0.6.3-20.1.el5_4.x86_64.rpm python-virtinst-0.400.3-5.el5.noarch.rpm virt-manager-0.6.1-8.el5.x86_64.rpm Any idea ? Thanks, Christian Roche NSN/Rabat +212 6 61 44 11 71

1 0

Re: [libvirt] Domain not stable while created...
by Sankamesh 12 Apr '10

12 Apr '10

Thanks Mr. Stefan Will that crash mainly be due to the kernel ? Since am not sure about that,else I should try with different image. When I use via a config file using "xm create libvirt-ttylinux.conf ", then the domain runs stable.... But when I use the virsh -c xen:/// define libvirt-ttylinux.xml" and "virsh start ttyimage, it crashes after sometime. The ibvirt-ttylinux.conf file :: -------------------------------------------------------------------------------------------------------------------------------- kernel = "/boot/vmlinuz-2.6.18-164.2.1.el5xen" ramdisk= "/boot/initrd-2.6.18-164.2.1.el5xen.img" memory = 64 name = "ttylinux" disk = ['file:/usr/local/ttylinux-xen-libvirt/ttylinux-xen.img,sda1,w'] root = "/dev/sda1 ro" vif = [''] -------------------------------------------------------------------------------------------------------------------------------- I give the same Xen kernel parameter here in xml file, and use virsh to create domain --------------------------------------------------------------------------------------------------------------------------------------- <?xml version="1.0" encoding="utf-8"?> <domain type='xen'> <name>ttyimage</name> <os> <type>linux</type> <kernel>/boot/vmlinuz-2.6.18-164.2.1.el5xen</kernel> <initrd>/boot/initrd-2.6.18-164.2.1.el5xen.img</initrd> </os> <memory>65536</memory> <vcpu>1</vcpu> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>destroy</on_crash> <devices> <graphics type='vnc' port='5900'/> <disk type='file'> <source file='/usr/local/ttylinux-xen-libvirt/ttylinux-xen.img' /> <target dev='sda1' /> </disk> <interface type='bridge'> <source bridge='virbr0' /> <mac address='00:1d:60:ec:ae:1c' /> <target dev='testnimb-0' /> </interface> </devices> </domain> --------------------------------------------------------------------------------------------------------------------------------------- My Boot grub file data:: --------------------------------------------------------------------------------------------------------------------------------------title Scientific Linux (2.6.18-164.2.1.el5xen) root (hd0,0) kernel /xen.gz-2.6.18-164.2.1.el5 module /vmlinuz-2.6.18-164.2.1.el5xen ro root=LABEL=/1 rhgb quiet module /initrd-2.6.18-164.2.1.el5xen.img -------------------------------------------------------------------------------------------------------------------------------------- Why is this difference between the xm (when i destroy the image,domain is also destroyed) and virsh (domain is not destroyed while destroying the image) . I doubt that am making some mistake with the xml file .... Is that true? Kindly give some suggestions Thanks ________________________________ libvir-list-bounces(a)redhat.com wrote on 04/10/2010 09:47:17 AM: > libvir-list > > Hello, > > Thanks Alex > > I created a domain using "virsh -c xen:/// define libvirt-ttylinux.xml" and > "virsh start ttyimage" for a simple ttyimage. > > Problem I face is that the image shutsdown immedialtely once virsh > start guest is typed. > I checked the Xend Logs > ---------------------------------------------------------------------------------------------------------- > ---[2010-04-11 07:08:02 xend 3155] DEBUG (DevController:116) > DevController: writing {'frontend-id': '6', 'domain': 'ttyimage', [...] > [2010-04-11 07:08:02 xend 3155] DEBUG (vfbif:11) Spawn: ['/usr/lib/ > xen/bin/qemu-dm', '-M', 'xenpv', '-d', '6', '-domain-name', > 'ttyimage', '-vnc', '127.0.0.1:0', '-vncunused', '-k', 'en-us'] > [2010-04-11 07:08:02 xend.XendDomainInfo 3155] DEBUG > (XendDomainInfo:992) Storing VM details: {'shadow_memory': '0', > 'uuid': 'd5e916b0-bc2d-01f9-8156-4808c754f67a', 'on_reboot': > 'restart', 'start_time': '1270937282.29', 'on_poweroff': 'destroy', > 'name': 'ttyimage', 'xend/restart_count': '0', 'vcpus': '1', > 'vcpu_avail': '1', 'memory': '64', 'on_crash': 'destroy', 'image': > '(linux (kernel /boot/vmlinuz-2.6.18-164.2.1.el5xen))', 'maxmem': '64'} > [2010-04-11 07:08:02 xend.XendDomainInfo 3155] DEBUG > (XendDomainInfo:1027) Storing domain details: {'console/ring-ref': > '65674', 'console/port': '2', 'name': 'ttyimage', 'console/limit': > '1048576', 'vm': '/vm/d5e916b0-bc2d-01f9-8156-4808c754f67a', > 'domid': '6', 'cpu/0/availability': 'online', 'memory/target': > '65536', 'store/ring-ref': '65675', 'store/port': '1'} > [2010-04-11 07:08:02 xend.XendDomainInfo 3155] DEBUG > (XendDomainInfo:1249) XendDomainInfo.handleShutdownWatch > [2010-04-11 07:08:02 xend 3155] DEBUG (DevController:158) Waiting > for devices vif. > [2010-04-11 07:08:02 xend 3155] DEBUG (DevController:164) Waiting for 0. > [2010-04-11 07:08:02 xend 3155] DEBUG (DevController:509) > hotplugStatusCallback /local/domain/0/backend/vif/6/0/hotplug-status. > [2010-04-11 07:08:51 xend 3155] INFO (XendDomain:387) Domain > ttyimage (6) unpaused. > [2010-04-11 07:08:54 xend.XendDomainInfo 3155] WARNING > (XendDomainInfo:1177) Domain has crashed: name=ttyimage id=6. You domain crashed here... Is the VM image and kernel in that image known to work? Regards, Stefan Send free SMS to your Friends on Mobile from your Yahoo! Messenger. Download Now! http://messenger.yahoo.com/download.php

2 1

[libvirt] about qemu monitor mode.
by Osier Yang 12 Apr '10

12 Apr '10

Hello there libvirt compiles JSON mode as the default qemu monitor mode if yajl-devel is available. As a result of this solution, the user has no way to change into the text mode. And because the qemu QMP always lacks commands currently, such as "savevm", it will prevent us creating the snapshot of domain, especially for us who want to do some testing. What I think is could we add the configuration item in qemu.conf? so that the user can choose which mode to use, such as: monitor_mode=json #monitor_mode=text Regards osier

2 1

[libvirt] libvirt: C++ or Java
by Gokhale, Shashibhushan 11 Apr '10

11 Apr '10

Hello, I am planning to develop a management application for managing Redhat Xen and Redhat KVM hypervisors. I am evaluating the Java bindings versus the C++ version of libvirt. As part of evaluation, I could not find meaningful answers to the questions below. Hence, I thought that people on this mailing list would be the most appropriate to comment on them. Can you please let me know your views? 1. Are all functions that are available in C API available in Java? 2. Are Java bindings added along with every enhancement to C API? 3. If answer to above question is negative, typically how long does it takes for the addition of Java bindings for the enhancement? 4. Most of libvirt based third party management applications use which of Java bindings or C API? 5. What are your good/bad experiences while using either of C API or Java bindings? 6. What is your concluding personal recommendation? And finally, since libvirt is a Redhat Emerging Technology project, does Redhat or any other third party service providers provide paid assistance, support? Thanks, Shashi

1 0

[libvirt] Domain not stable while created...
by Sankamesh 10 Apr '10

10 Apr '10

Hello, I am using Scientific Linux 5.4 and xen. I want to deploy a sample ttyimage by creating a domain using virsh create. My configuration file is : ----------------------------------------------------------------------------------------------------- <?xml version="1.0" encoding="utf-8"?> <domain type='xen'> <name>ttyimage</name> <os> <type>linux</type> <kernel>/boot/vmlinuz-2.6.18-164.2.1.el5xen</kernel> </os> <memory>65536</memory> <vcpu>1</vcpu> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>destroy</on_crash> <devices> <graphics type='vnc' port='5900'/> <disk type='file'> <source file='/usr/local/ttylinux-xen-libvirt/ttylinux-xen.img' /> <target dev='sda' /> </disk> <interface type='bridge'> <source bridge='virbr0' /> <mac address='00:1d:60:ec:ae:1c' /> <target dev='testnimb-0' /> </interface> </devices> </domain> ------------------------------------------------------------------------------------------------------- when I use "virsh -c "xen:///" create libvirt-ttylinux.xml " to create a domain, the domain is crated and i can view the image (in paused mode) using the virt-manager. and when I resume the image it ,disappears (domain gets destroyed) after nearly 10 seconds..... Further when I use vncviewer localhost::5900 when the image is running (during the 10 sec) ,i can view the console. But it closes once the domain is destroyed. Can someone explain why the image is not stable??? how can I make the domain to be stable???? Thanks in advance The INTERNET now has a personality. YOURS! See your Yahoo! Homepage. http://in.yahoo.com/

3 3

Re: [libvirt] [RFC] Unify KVM kernel-space and user-space code into a single project
by Antoine Martin 09 Apr '10

09 Apr '10

Hi, I am moving this thread here as this seems more appropriate. Sorry it has taken so long.. Here are 2 things that really get in the way of moving my existing installations to libvirt: * I tend to store much meta data with each VM instance: it can be things like ownership (contact details as text), monitoring info (sms phone numbers), backup (list of paths), firewall rules (custom syntax, with failover rules, etc), etc. At the moment, these extra bits of information consist of just a few optional lines of shell in each VM's definition file. I can extend these whenever I need, enumerate the VMs using the standard mechanism and trigger my specific actions as needed (firewall rules, backup or whatever). I see no way of doing this with libvirt. But please correct me if I am wrong. * not everything is exposed via libvirt: virsh can retrieve vncdisplay but libvirt (or at least the python bindings) does not. How come? This happens to be one thing I need for writing a libvirt backend for my virtual desktop software. Cheers Antoine Antoine Martin wrote: > Hi Daniel, > > I'll take a look and get back to you asap. > > Cheers > Antoine > > Daniel P. Berrange wrote: >> On Tue, Mar 23, 2010 at 03:00:28AM +0700, Antoine Martin wrote: >>> On 03/23/2010 02:15 AM, Anthony Liguori wrote: >>>> On 03/22/2010 12:55 PM, Avi Kivity wrote: >>>>>> Lets look at the ${HOME}/.qemu/qmp/ enumeration method suggested by >>>>>> Anthony. >>>>>> There's numerous ways that this can break: >>>>> I don't like it either. We have libvirt for enumerating guests. >>>> We're stuck in a rut with libvirt and I think a lot of the >>>> dissatisfaction with qemu is rooted in that. It's not libvirt that's >>>> the probably, but the relationship between qemu and libvirt. >>> +1 >>> The obvious reason why so many people still use shell scripts rather >>> than libvirt is because if it just doesn't provide what they need. >>> Every time I've looked at it (and I've been looking for a better >>> solution for many years), it seems that it would have provided most of >>> the things I needed, but the remaining bits were unsolvable. >> If you happen to remember what missing features prevented you choosing >> libvirt, that would be invaluable information for us, to see if there >> are quick wins that will help out. We got very useful feedback when >> recently asking people this same question > >> http://rwmj.wordpress.com/2010/01/07/quick-quiz-what-stops-you-from-using-l… > >> Allowing arbitrary passthrough of QEMU commands/args will solve some of >> these issues, but certainly far from solving all of them. eg guest cut+ >> paste, host side control of guest screen resolution, easier x509/TLS >> configuration for remote management, soft reboot, Windows desktop support >> for virt-manager, host network interface management/setup, etc > >> Regards, >> Daniel

5 13

[libvirt] [PATCH] nwfilter: Process DHCP option to determine whether packet is a DHCP_OFFER
by Stefan Berger 09 Apr '10

09 Apr '10

I mistakenly took the op field in the DHCP message as the DHCP_OFFER type. Rather than basing the decision to read the VM's IP address on that field, process the appended DHCP options where option 53 indicates the actual type of the packet. I am also reading the broadcast address of the VM, but don't use it so far. Signed-off-by: Stefan Berger <stefanb(a)us.ibm.com> --- src/nwfilter/nwfilter_learnipaddr.c | 61 +++++++++++++++++++++++++++++++++--- 1 file changed, 56 insertions(+), 5 deletions(-) Index: libvirt-acl/src/nwfilter/nwfilter_learnipaddr.c =================================================================== --- libvirt-acl.orig/src/nwfilter/nwfilter_learnipaddr.c +++ libvirt-acl/src/nwfilter/nwfilter_learnipaddr.c @@ -64,6 +64,13 @@ struct f_arphdr { } ATTRIBUTE_PACKED; +struct dhcp_option { + uint8_t code; + uint8_t len; + uint8_t value[0]; /* length varies */ +} ATTRIBUTE_PACKED; + + /* structure representing DHCP message */ struct dhcp { uint8_t op; @@ -78,9 +85,12 @@ struct dhcp { uint32_t siaddr; uint32_t giaddr; uint8_t chaddr[16]; - /* omitted */ + uint8_t zeroes[192]; + uint32_t magic; + struct dhcp_option options[0]; } ATTRIBUTE_PACKED; +#define DHCP_MSGT_DHCPOFFER 2 struct ether_vlan_header { @@ -212,6 +222,40 @@ virNWFilterGetIpAddrForIfname(const char #ifdef HAVE_LIBPCAP +static void +procDHCPOpts(struct dhcp *dhcp, int dhcp_opts_len, + uint32_t *vmaddr, uint32_t *bcastaddr, + enum howDetect *howDetected) { + struct dhcp_option *dhcpopt = &dhcp->options[0]; + + while (dhcp_opts_len >= 2) { + + switch (dhcpopt->code) { + + case 28: /* Broadcast address */ + if (dhcp_opts_len >= 6) { + uint32_t *tmp = (uint32_t *)&dhcpopt->value; + (*bcastaddr) = ntohl(*tmp); + } + break; + + case 53: /* Message type */ + if (dhcp_opts_len >= 3) { + uint8_t *val = (uint8_t *)&dhcpopt->value; + switch (*val) { + case DHCP_MSGT_DHCPOFFER: + *vmaddr = dhcp->yiaddr; + *howDetected = DETECT_DHCP; + break; + } + } + } + dhcp_opts_len -= (2 + dhcpopt->len); + dhcpopt = (struct dhcp_option*)((char *)dhcpopt + 2 + dhcpopt->len); + } +} + + /** * learnIPAddressThread * arg: pointer to virNWFilterIPAddrLearnReq structure @@ -236,12 +280,13 @@ learnIPAddressThread(void *arg) struct ether_header *ether_hdr; struct ether_vlan_header *vlan_hdr; virNWFilterIPAddrLearnReqPtr req = arg; - uint32_t vmaddr = 0; + uint32_t vmaddr = 0, bcastaddr = 0; unsigned int ethHdrSize; char *listen_if = (strlen(req->linkdev) != 0) ? req->linkdev : req->ifname; int to_ms = (strlen(req->linkdev) != 0) ? 1000 : 0; + int dhcp_opts_len; char macaddr[VIR_MAC_STRING_BUFLEN]; virBuffer buf = VIR_BUFFER_INITIALIZER; char *filter= NULL; @@ -382,12 +427,18 @@ learnIPAddressThread(void *arg) sizeof(struct dhcp)) { struct dhcp *dhcp = (struct dhcp *) ((char *)udphdr + sizeof(udphdr)); - if (dhcp->op == 2 /* DHCP OFFER */ && + if (dhcp->op == 2 /* BOOTREPLY */ && !memcmp(&dhcp->chaddr[0], req->macaddr, 6)) { - vmaddr = dhcp->yiaddr; - howDetected = DETECT_DHCP; + dhcp_opts_len = header.len - + (ethHdrSize + iphdr->ihl * 4 + + sizeof(struct udphdr) + + sizeof(struct dhcp)); + procDHCPOpts(dhcp, dhcp_opts_len, + &vmaddr, + &bcastaddr, + &howDetected); } } }

2 1

[libvirt] [PATCH] Fix error in nwfilter test driver
by Stefan Berger 09 Apr '10

09 Apr '10

Trivial fix for the c&p error in the nwfilter test driver. Signed-off-by: Stefan Berger <stefanb(a)us.ibm.com> Index: libvirt-acl/src/test/test_driver.c =================================================================== --- libvirt-acl.orig/src/test/test_driver.c +++ libvirt-acl/src/test/test_driver.c @@ -5212,7 +5212,7 @@ static virDrvOpenStatus testNWFilterOpen if (STRNEQ(conn->driver->name, "Test")) return VIR_DRV_OPEN_DECLINED; - conn->secretPrivateData = conn->privateData; + conn->nwfilterPrivateData = conn->privateData; return VIR_DRV_OPEN_SUCCESS; }

2 2

[libvirt] libvirt: C++ or Java
by Gokhale, Shashibhushan 09 Apr '10

09 Apr '10

Hello, I am planning to develop a management application for managing Redhat Xen and Redhat KVM hypervisors. I am evaluating the Java bindings versus the C++ version of libvirt. As part of evaluation, I could not find meaningful answers to the questions below. Hence, I thought that people on this mailing list would be the most appropriate to comment on them. Can you please let me know your views? 1. Are all functions that are available in C API available in Java? 2. Are Java bindings added along with every enhancement to C API? 3. If answer to above question is negative, typically how long does it takes for the addition of Java bindings for the enhancement? 4. Most of libvirt based third party management applications use which of Java bindings or C API? 5. What are your good/bad experiences while using either of C API or Java bindings? 6. What is your concluding personal recommendation? And finally, since libvirt is a Redhat Emerging Technology project, does Redhat or any other third party service providers provide paid assistance, support? Thanks, Shashi

1 0