- Devel - libvirt List Archives

[libvirt] [PATCH] qemu: Error prompt when saving a shutoff domain
by Osier Yang 17 Feb '11

17 Feb '11

* src/qemu/qemu_driver.c --- src/qemu/qemu_driver.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index c581cfe..8570e67 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -4647,6 +4647,12 @@ static int qemudDomainSave(virDomainPtr dom, const char *path) goto cleanup; } + if (!virDomainObjIsActive(vm)) { + qemuReportError(VIR_ERR_OPERATION_INVALID, + "%s", _("domain is not running")); + goto cleanup; + } + ret = qemudDomainSaveFlag(driver, dom, vm, path, compressed); cleanup: -- 1.7.4

3 5

[libvirt] [PATCH 1/2] build-sys: fix build when daemon is disabled by not installing libvirtd.8
by Diego Elio Pettenò 17 Feb '11

17 Feb '11

Since the rule to build libvirtd.8 is within the WITH_LIBVIRTD conditional, so declare the man page in there as well. Without this change, build without daemon will fail. --- .gnulib | 2 +- daemon/Makefile.am | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.gnulib b/.gnulib index 1629006..11fbc57 160000 --- a/.gnulib +++ b/.gnulib @@ -1 +1 @@ -Subproject commit 1629006348e1f66f07ce3ddcf3ebd2d14556cfce +Subproject commit 11fbc57405a118e6ec9a3ebc19bbf5ececdae4d6 diff --git a/daemon/Makefile.am b/daemon/Makefile.am index 963d64f..dbf0ac3 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -41,12 +41,12 @@ EXTRA_DIST = \ $(AVAHI_SOURCES) \ $(DAEMON_SOURCES) -man_MANS = libvirtd.8 - BUILT_SOURCES = if WITH_LIBVIRTD +man_MANS = libvirtd.8 + sbin_PROGRAMS = libvirtd confdir = $(sysconfdir)/libvirt/ -- 1.7.2

4 9

[libvirt] [PATCH] maint: delete unused 'make install' step
by Eric Blake 16 Feb '11

16 Feb '11

Libxml2-Logo-90x34.gif was removed from the repository in Sep 2009 (commit d6d528c) because our docs no longer reference it. * docs/Makefile.am (install-data-local): Don't install missing file. --- Pushing this under the trivial rule. docs/Makefile.am | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index 473bbbf..d0fe918 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -187,7 +187,6 @@ install-data-local: $(mkinstalldirs) $(DESTDIR)$(HTML_DIR) for f in $(css) $(dot_html) $(gif) $(png); do \ $(INSTALL) -m 0644 $(srcdir)/$$f $(DESTDIR)$(HTML_DIR); done - -$(INSTALL) -m 0644 $(srcdir)/Libxml2-Logo-90x34.gif $(DESTDIR)$(HTML_DIR) $(mkinstalldirs) $(DESTDIR)$(HTML_DIR)/html for h in $(apihtml); do \ $(INSTALL) -m 0644 $(srcdir)/$$h $(DESTDIR)$(HTML_DIR)/html; done -- 1.7.4

1 0

[libvirt] [libvirt-php] Merge rpm spec files
by Lyre 16 Feb '11

16 Feb '11

Merge php-libvirt.spec & libvirt-php.obs.spec to libvirt-php.spec, which will pack libvirt-php into two packages: libvirt-php: the extension itself with the configuration file. libvirt-php-doc: document package for libvirt-php This spec file should works for Fedora 14, RHEL 6, openSuSE 11.3 and SLES 11 SP1. * renamed: libvirt-php.obs.spec -> libvirt-php.spec * deleted: php-libvirt.spec * libvirt-php.spec: Added %dir for libvirt-php-doc to satisfy SLES. * Makefile.am: changed the spec file name for distting. --- Makefile.am | 2 +- libvirt-php.obs.spec | 81 ------------------------------------------------- libvirt-php.spec | 82 ++++++++++++++++++++++++++++++++++++++++++++++++++ php-libvirt.spec | 43 -------------------------- 4 files changed, 83 insertions(+), 125 deletions(-) delete mode 100644 libvirt-php.obs.spec create mode 100644 libvirt-php.spec delete mode 100644 php-libvirt.spec diff --git a/Makefile.am b/Makefile.am index eac6726..aa19b88 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1,3 +1,3 @@ SUBDIRS = src docs -EXTRA_DIST = libvirt-php.obs.spec +EXTRA_DIST = libvirt-php.spec diff --git a/libvirt-php.obs.spec b/libvirt-php.obs.spec deleted file mode 100644 index da59676..0000000 --- a/libvirt-php.obs.spec +++ /dev/null @@ -1,81 +0,0 @@ -%define req_libvirt_version 0.6.2 - -%if 0%{?suse_version} || 0%{?sles_version} -%define php_confdir %{_sysconfdir}/php5/conf.d -%define php_extdir %{_libdir}/php5/extensions -%else -%define php_confdir %{_sysconfdir}/php.d -%define php_extdir %{_libdir}/php/modules -%endif - -Name: libvirt-php -Version: 0.4 -Release: 1%{?dist}%{?extra_release} -Summary: PHP language binding for Libvirt - -%if 0%{?suse_version} || 0%{?sles_version} -Group: Development/Libraries/PHP -%else -Group: Development/Libraries -%endif -License: PHP -URL: http://libvirt.org/ -Source0: http://libvirt.org/sources/libvirt-php-%{version}.tar.gz -BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root - -BuildRequires: php-devel -BuildRequires: libvirt-devel >= %{req_libvirt_version} -BuildRequires: libxml2-devel -%if 0%{?suse_version} || 0%{?sles_version} -BuildRequires: xhtml-dtd -%else -BuildRequires: xhtml1-dtds -%endif -Requires: libvirt >= %{req_libvirt_version} -%if 0%{?suse_version} || 0%{?sles_version} -Requires: php5 -%else -Requires: php -%endif - -%description -PHP language bindings for Libvirt API. -For more details see: http://phplibvirt.cybersales.cz/ http://www.libvirt.org/ http://www.php.net/ - -%package -n libvirt-php-doc -Summary: Document of libvirt-php -Group: Development/Libraries/PHP -Requires: libvirt-php = %{version} - -%description -n libvirt-php-doc -PHP language bindings for Libvirt API. -For more details see: http://phplibvirt.cybersales.cz/ http://www.libvirt.org/ http://www.php.net/ - -This package contain the document for libvirt-php. - -%prep -%setup -q -n libvirt-php-%{version} - -%build -%configure -./configure --with-html-dir=%{_datadir}/doc --with-html-subdir=%{name}-%{version}/html -make %{?_smp_mflags} - -%install -make install DESTDIR=%{buildroot} - -%clean -rm -rf %{buildroot} - -%files -%defattr(-,root,root,-) -%{php_extdir}/libvirt-php.so -%config(noreplace) %{php_confdir}/libvirt-php.ini - -%files -n libvirt-php-doc -%defattr(-,root,root,-) -%doc -%{_datadir}/doc/%{name}-%{version}/html - -%changelog - diff --git a/libvirt-php.spec b/libvirt-php.spec new file mode 100644 index 0000000..5ac61b0 --- /dev/null +++ b/libvirt-php.spec @@ -0,0 +1,82 @@ +%define req_libvirt_version 0.6.2 + +%if 0%{?suse_version} || 0%{?sles_version} +%define php_confdir %{_sysconfdir}/php5/conf.d +%define php_extdir %{_libdir}/php5/extensions +%else +%define php_confdir %{_sysconfdir}/php.d +%define php_extdir %{_libdir}/php/modules +%endif + +Name: libvirt-php +Version: 0.4 +Release: 1%{?dist}%{?extra_release} +Summary: PHP language binding for Libvirt + +%if 0%{?suse_version} || 0%{?sles_version} +Group: Development/Libraries/PHP +%else +Group: Development/Libraries +%endif +License: PHP +URL: http://libvirt.org/ +Source0: http://libvirt.org/sources/libvirt-php-%{version}.tar.gz +BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root + +BuildRequires: php-devel +BuildRequires: libvirt-devel >= %{req_libvirt_version} +BuildRequires: libxml2-devel +%if 0%{?suse_version} || 0%{?sles_version} +BuildRequires: xhtml-dtd +%else +BuildRequires: xhtml1-dtds +%endif +Requires: libvirt >= %{req_libvirt_version} +%if 0%{?suse_version} || 0%{?sles_version} +Requires: php5 +%else +Requires: php +%endif + +%description +PHP language bindings for Libvirt API. +For more details see: http://phplibvirt.cybersales.cz/ http://www.libvirt.org/ http://www.php.net/ + +%package -n libvirt-php-doc +Summary: Document of libvirt-php +Group: Development/Libraries/PHP +Requires: libvirt-php = %{version} + +%description -n libvirt-php-doc +PHP language bindings for Libvirt API. +For more details see: http://phplibvirt.cybersales.cz/ http://www.libvirt.org/ http://www.php.net/ + +This package contain the document for libvirt-php. + +%prep +%setup -q -n libvirt-php-%{version} + +%build +%configure +./configure --with-html-dir=%{_datadir}/doc --with-html-subdir=%{name}-%{version}/html +make %{?_smp_mflags} + +%install +make install DESTDIR=%{buildroot} + +%clean +rm -rf %{buildroot} + +%files +%defattr(-,root,root,-) +%{php_extdir}/libvirt-php.so +%config(noreplace) %{php_confdir}/libvirt-php.ini + +%files -n libvirt-php-doc +%defattr(-,root,root,-) +%doc +%dir %{_datadir}/doc/%{name}-%{version} +%{_datadir}/doc/%{name}-%{version}/html + +%changelog + diff --git a/php-libvirt.spec b/php-libvirt.spec deleted file mode 100644 index b7bc92d..0000000 --- a/php-libvirt.spec +++ /dev/null @@ -1,43 +0,0 @@ -Name: php-libvirt -Version: 0.4 -Release: 1%{?dist}%{?extra_release} -Summary: PHP language binding for Libvirt -Group: Development/Libraries -License: PHP -URL: http://libvirt.org/ -Source0: http://libvirt.org/sources/libvirt-php-%{version}.tar.gz -BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - -BuildRequires: php-devel -BuildRequires: libvirt-devel -BuildRequires: libxml2-devel -Requires: libvirt -Requires: php(zend-abi) = %{php_zend_api} -Requires: php(api) = %{php_core_api} - - -%description -PHP language bindings for Libvirt API. -For more details see: http://phplibvirt.cybersales.cz/ http://www.libvirt.org/ http://www.php.net/ - -%prep -%setup -q -n libvirt-php-%{version} - -%build -%configure --with-html-dir=%{_datadir}/doc --with-html-subdir=%{name}-%{version}/html -make %{?_smp_mflags} - -%install -rm -rf %{buildroot} -make install DESTDIR=%{buildroot} - -%clean -rm -rf %{buildroot} - -%files -%defattr(-,root,root,-) -%{_libdir}/php/modules/libvirt-php.so -%{_sysconfdir}/php.d/libvirt-php.ini -%doc %{_datadir}/doc/%{name}-%{version}/html - -%changelog -- 1.7.1

3 2

[libvirt] [PATCH SNMP] Add automated build control script
by Daniel P. Berrange 16 Feb '11

16 Feb '11

* .gitignore: Ignore build directory * autobuild.sh: Add automated build script * autogen.sh: Helper for re-generating autotools files * libvirt-snmp.spec.in: Add extra_release and remove substitution of mibdir since RPM path shouldn't change regardless of current configure args --- .gitignore | 1 + autobuild.sh | 42 ++++++++++++++++++++++++++++++++++++++++++ autogen.sh | 24 ++++++++++++++++++++++++ libvirt-snmp.spec.in | 6 +++--- 4 files changed, 70 insertions(+), 3 deletions(-) create mode 100755 autobuild.sh create mode 100755 autogen.sh diff --git a/.gitignore b/.gitignore index 98613d5..ed2e9f7 100644 --- a/.gitignore +++ b/.gitignore @@ -9,6 +9,7 @@ *.orig *.rej *~ +/build /.git-module-status Makefile Makefile.in diff --git a/autobuild.sh b/autobuild.sh new file mode 100755 index 0000000..5eecb39 --- /dev/null +++ b/autobuild.sh @@ -0,0 +1,42 @@ +#!/bin/sh + +set -e +set -v + +test -n "$1" && RESULTS=$1 || RESULTS=results.log +: ${AUTOBUILD_INSTALL_ROOT=$HOME/builder} + +# Make things clean. +test -f Makefile && make -k distclean || : + +rm -rf build +mkdir build +cd build + +MIBDIR=$AUTOBUILD_INSTALL_ROOT/share/snmp/mibs +mkdir -p $MIBDIR + +../autogen.sh --prefix=$AUTOBUILD_INSTALL_ROOT \ + --with-mibdir=$MIBDIR + +make +make install + +make check | tee "$RESULTS" + +rm -f *.tar.gz +make dist + +if [ -n "$AUTOBUILD_COUNTER" ]; then + EXTRA_RELEASE=".auto$AUTOBUILD_COUNTER" +else + NOW=`date +"%s"` + EXTRA_RELEASE=".$USER$NOW" +fi + +if [ -f /usr/bin/rpmbuild ]; then + rpmbuild --nodeps \ + --define "extra_release $EXTRA_RELEASE" \ + --define "_sourcedir `pwd`" \ + -ba --clean libvirt-snmp.spec +fi diff --git a/autogen.sh b/autogen.sh new file mode 100755 index 0000000..917e923 --- /dev/null +++ b/autogen.sh @@ -0,0 +1,24 @@ +#!/bin/sh +# Run this to generate all the initial makefiles, etc. + +set -e +srcdir=`dirname $0` +test -z "$srcdir" && srcdir=. + +THEDIR=`pwd` +cd $srcdir + +if test -z "$*"; then + echo "I am going to run ./configure with not arguments - if you " + echo "wish to pass any extra arguments to it, please specify them on " + echo "the $0 command line." +fi + +autoreconf -i -f + +cd $THEDIR + +$srcdir/configure "$@" && { + echo + echo "Now type 'make' to compile libvirt-snmp." +} diff --git a/libvirt-snmp.spec.in b/libvirt-snmp.spec.in index 7ec8a3f..6082a7a 100644 --- a/libvirt-snmp.spec.in +++ b/libvirt-snmp.spec.in @@ -1,6 +1,6 @@ Name: libvirt-snmp Version: @VERSION@ -Release: 1%{?dist} +Release: 1%{?dist}%{?extra_release} Summary: SNMP functionality for libvirt Group: Development/Libraries @@ -36,8 +36,8 @@ rm -rf $RPM_BUILD_ROOT %files %defattr(-,root,root,-) %{_bindir}/libvirtMib_subagent -@MIB_DIR@/LIBVIRT-MIB.txt -%doc +%{_datadir}/snmp/mibs/LIBVIRT-MIB.txt +%doc README NEWS ChangeLog AUTHORS -- 1.7.4

2 1

[libvirt] [libvirt-php 0/3] Eliminated complilation warnings
by Lyre 16 Feb '11

16 Feb '11

Hi all: These patch added the -Wall option for compiler, and eliminated all warnings. Lyre (3): Added -Wall option Fixed some compilation warnings Eliminated ununsed variables src/Makefile.am | 4 +- src/libvirt.c | 65 +++++++++--------------------------------------------- 2 files changed, 13 insertions(+), 56 deletions(-)

2 4

[libvirt] [libvirt-php 0/2] Updated building system
by Lyre 16 Feb '11

16 Feb '11

Fixed the install location of libvirt-php.ini; Added an spec file for openSuSE Build Service. Lyre (2): Fixed the php configuration file Added libvirt-php.obs.spec Makefile.am | 2 + aclocal.m4 | 4 +- libvirt-php.obs.spec | 80 ++++++++++++++++++++++++++++++++++++++++++++++++++ src/Makefile.am | 7 ++-- 4 files changed, 88 insertions(+), 5 deletions(-) create mode 100644 libvirt-php.obs.spec

4 9

[libvirt] CfP 6th Workshop on Virtualization in High-Performance Cloud Computing (VHPC'11)
by VHPC2011 16 Feb '11

16 Feb '11

Apologies if you received multiple copies of this message. ================================================================= CALL FOR PAPERS 6th Workshop on Virtualization in High-Performance Cloud Computing VHPC'11 as part of Euro-Par 2011, Bordeaux, France ================================================================= Date: August 30, 2011 Euro-Par 2011: http://europar2011.bordeaux.inria.fr/ Workshop URL: http://vhpc.org SUBMISSION DEADLINE: Abstracts: May 2, 2011 Full Paper: June 13, 2011 Scope: Virtualization has become a common abstraction layer in modern data centers, enabling resource owners to manage complex infrastructure independently of their applications. Conjointly virtualization is becoming a driving technology for a manifold of industry grade IT services. The cloud concept includes the notion of a separation between resource owners and users, adding services such as hosted application frameworks and queuing. Utilizing the same infrastructure, clouds carry significant potential for use in high-performance scientific computing. The ability of clouds to provide for requests and releases of vast computing resource dynamically and close to the marginal cost of providing the services is unprecedented in the history of scientific and commercial computing. Distributed computing concepts that leverage federated resource access are popular within the grid community, but have not seen previously desired deployed levels so far. Also, many of the scientific datacenters have not adopted virtualization or cloud concepts yet. This workshop aims to bring together industrial providers with the scientific community in order to foster discussion, collaboration and mutual exchange of knowledge and experience. The workshop will be one day in length, composed of 20 min paper presentations, each followed by 10 min discussion sections. Presentations may be accompanied by interactive demonstrations. It concludes with a 30 min panel discussion by presenters. TOPICS Topics include, but are not limited to, the following subjects: - Virtualization in cloud, cluster and grid environments - VM-based cloud performance modeling - Workload characterizations for VM-based environments - Software as a Service (SaaS) - Cloud reliability, fault-tolerance, and security - Cloud, cluster and grid filesystems - QoS and and service levels - Cross-layer VM optimizations - Virtualized I/O and storage - Virtualization and HPC architectures including NUMA - System and process/bytecode VM convergence - Paravirtualized driver development - Research and education use cases - VM cloud, cluster distribution algorithms - MPI on virtual machines and clouds - Cloud frameworks and API sets - Checkpointing of large compute jobs - Cloud load balancing - Accelerator virtualization - Instrumentation interfaces and languages - Hardware support for virtualization - High-performance network virtualization - Auto-tuning of VMM and VM parameters - High-speed interconnects - Hypervisor extensions and tools for cluster and grid computing - VMMs/Hypervisors - Cloud use cases including optimizations - Performance modeling - Fault tolerant VM environments - VMM performance tuning on various load types - Cloud provisioning - Virtual machine monitor platforms - Pass-through VM device access - Management, deployment of VM-based environments PAPER SUBMISSION Papers submitted to the workshop will be reviewed by at least two members of the program committee and external reviewers. Submissions should include abstract, key words, the e-mail address of the corresponding author, and must not exceed 10 pages, including tables and figures at a main font size no smaller than 11 point. Submission of a paper should be regarded as a commitment that, should the paper be accepted, at least one of the authors will register and attend the conference to present the work. Accepted papers will be published in the Springer LNCS series - the format must be according to the Springer LNCS Style. Initial submissions are in PDF, accepted papers will be requested to provided source files. Format Guidelines: http://www.springer.de/comp/lncs/authors.html Submission Link: http://edas.info/newPaper.php?c=10155 CHAIR Michael Alexander (chair), IBM, Austria Gianluigi Zanetti (co-chair), CRS4, Italy PROGRAM COMMITTEE Paolo Anedda, CRS4, Italy Volker Buege, University of Karlsruhe, Germany Giovanni Busonera, CRS4, Italy Roberto Canonico, University of Napoli, Italy Tommaso Cucinotta, Scuola Superiore Sant'Anna, Italy William Gardner, University of Guelph, Canada Werner Fischer, Thomas-Krenn AG, Germany Wolfgang Gentzsch, Max Planck Gesellschaft, Germany Marcus Hardt, Forschungszentrum Karlsruhe, Germany Sverre Jarp, CERN, Switzerland Shantenu Sjha, Louisiana State University, USA Xuxian Jiang, NC State, USA Kenji Kaneda, Google, USA Simone Leo, CRS4, Italy Ignancio Llorente, Universidad Complutense de Madrid, Spain, Naoya Maruyama, Tokyo Institute of Technology, Japan Jean-Marc Menaud, Ecole des Mines de Nantes, France Anastassios Nanos, National Technical University of Athens, Greece Jose Renato Santos, HP Labs, USA Deepak Singh, Amazon Webservices, USA Boria Sotomayor, University of Chicago, USA Yoshio Turner, HP Labs, USA Kurt Tutschku, University of Vienna, Austria Lizhe Wang, Indiana University, USA Chao-Tung Yang, Tunghai University, China DURATION: Workshop Duration is one day. GENERAL INFORMATION The workshop will be held as part of Euro-Par 2011, organized by INRIA, CNRS and the University of Bordeaux I, II, France. Euro-Par 2011: http://europar2011.bordeaux.inria.fr/

1 0

[libvirt] virDomainMigrate, "suitable default" for omitted bandwidth parameter
by Thomas Treutner 16 Feb '11

16 Feb '11

Hi, does somebody know what the following paragraph exactly means resp. what it should mean? "The maximum bandwidth (in Mbps) that will be used to do migration can be specified with the bandwidth parameter. *If set to 0, libvirt will choose a suitable default*." http://libvirt.org/html/libvirt-libvirt.html#virDomainMigrate What is the "suitable default"? I looked through the code for qemu and the only call to qemuMonitorSetMigrationSpeed() I can find is in ./src/qemu/qemu_driver.c:8406, using libvirt 0.8.7. When I remember correctly the second condition in a conjunction will not be evaluated if the first one evaluates to false? So if resource == 0, no limit will be set? I ask because I discovered that qemu is live migrating with a hard coded throttle of 32MiB/s for historic reasons, which is an activated handbrake if you have GBit Ethernet and additionally annoying when thinking about qemu's broken way of live migration (no maximum amount of iterations, no forced action, no error message, no abortion - no *nothing*.). Effectively *using* GBit Ethernet often solves this problem as the bandwidth to transfer dirty pages is quadrupled. Also see qemu mailing list, Message-ID: <4D52D95D.3030300(a)scripty.at> There was a short discussion on IRC where concerns of "breaking libvirt" when deactivating the default limit were stated. If there really are applications that depend on handbraked live migration, I think these applications just should pass the limit they need to virDomainMigrate(). What do you think? regards, -t

2 1

[libvirt] Html docs for win32 build?
by Justin Clift 16 Feb '11

16 Feb '11

Hi Matthias, Thinking we should include the generated html docs in the win32 installer. Any thoughts/objections? Also, thinking that if we do, it shouldn't be too hard to install the xhtml1-dtds and use them during the libvirt compile process. As a quick test, since I'd already worked out the steps for the xhtml1 bits when packaging OSX, it was pretty easy to cut-n-paste the bits into a rough script to do it (attached). Any use? Regards and best wishes, Justin Clift

2 2

[libvirt] [PATCH] docs: fix typos
by Eric Blake 16 Feb '11

16 Feb '11

* docs/drvopenvz.html.in: Spell administrator correctly. * docs/drvuml.html.in: Likewise. * src/qemu/qemu.conf: Likewise. Fix other typos, too. --- Pushing under the obvious rule. docs/drvopenvz.html.in | 2 +- docs/drvuml.html.in | 2 +- src/qemu/qemu.conf | 25 +++++++++++++------------ 3 files changed, 15 insertions(+), 14 deletions(-) diff --git a/docs/drvopenvz.html.in b/docs/drvopenvz.html.in index 485d209..ddd6ac1 100644 --- a/docs/drvopenvz.html.in +++ b/docs/drvopenvz.html.in @@ -55,7 +55,7 @@ openvz+ssh://root@example.com/system (remote access, SSH tunnelled) OpenVZ releases later than 3.0.23 ship with a standard network device setup script that is able to setup bridging, named <code>/usr/sbin/vznetaddbr</code>. For releases prior to 3.0.23, this - script must be created manually by the host OS adminstrator. The + script must be created manually by the host OS administrator. The simplest way is to just download the latest version of this script from a newer OpenVZ release, or upstream source repository. Then a generic configuration file <code>/etc/vz/vznetctl.conf</code> diff --git a/docs/drvuml.html.in b/docs/drvuml.html.in index 9e5db95..d18e9cc 100644 --- a/docs/drvuml.html.in +++ b/docs/drvuml.html.in @@ -7,7 +7,7 @@ guests built for User Mode Linux. UML requires no special support in the host kernel, so can be used by any user of any linux system, provided they have enough free RAM for their guest's needs, though there are - certain restrictions on network connectivity unless the adminstrator + certain restrictions on network connectivity unless the administrator has pre-created TAP devices. </p> diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf index 66310d4..8c6b996 100644 --- a/src/qemu/qemu.conf +++ b/src/qemu/qemu.conf @@ -47,7 +47,7 @@ # The default TLS configuration only uses certificates for the server # allowing the client to verify the server's identity and establish -# and encrypted channel. +# an encrypted channel. # # It is possible to use x509 certificates for authentication too, by # issuing a x509 certificate to every client who needs to connect. @@ -62,9 +62,9 @@ # VNC passwords. This parameter is only used if the per-domain # XML config does not already provide a password. To allow # access without passwords, leave this commented out. An empty -# string will still enable passwords, but be rejected by QEMU +# string will still enable passwords, but be rejected by QEMU, # effectively preventing any use of VNC. Obviously change this -# example here before you set this +# example here before you set this. # # vnc_password = "XYZ12345" @@ -115,7 +115,7 @@ # server-cert.pem - the server certificate signed with ca-cert.pem # server-key.pem - the server private key # -# This option allows the certificate directory to be changed +# This option allows the certificate directory to be changed. # # spice_tls_x509_cert_dir = "/etc/pki/libvirt-spice" @@ -124,8 +124,8 @@ # per-domain XML config does not already provide a password. To # allow access without passwords, leave this commented out. An # empty string will still enable passwords, but be rejected by -# QEMU effectively preventing any use of SPICE. Obviously change -# this example here before you set this +# QEMU, effectively preventing any use of SPICE. Obviously change +# this example here before you set this. # # spice_password = "XYZ12345" @@ -134,15 +134,15 @@ # on the host, then the security driver will automatically disable # itself. If you wish to disable QEMU SELinux security driver while # leaving SELinux enabled for the host in general, then set this -# to 'none' instead +# to 'none' instead. # # security_driver = "selinux" -# The user ID for QEMU processes run by the system instance +# The user ID for QEMU processes run by the system instance. #user = "root" -# The group ID for QEMU processes run by the system instance +# The group ID for QEMU processes run by the system instance. #group = "root" # Whether libvirt should dynamically change file ownership @@ -155,14 +155,15 @@ # # - 'cpu' - use for schedular tunables # - 'devices' - use for device whitelisting +# - 'memory' - use for memory tunables # # NB, even if configured here, they won't be used unless -# the adminsitrator has mounted cgroups. eg +# the administrator has mounted cgroups, e.g.: # # mkdir /dev/cgroup # mount -t cgroup -o devices,cpu,memory none /dev/cgroup # -# They can be mounted anywhere, and different controlers +# They can be mounted anywhere, and different controllers # can be mounted in different locations. libvirt will detect # where they are located. # @@ -175,7 +176,7 @@ # all sound device, and all PTY devices are allowed. # # This will only need setting if newer QEMU suddenly -# wants some device we don't already know a bout. +# wants some device we don't already know about. # #cgroup_device_acl = [ # "/dev/null", "/dev/full", "/dev/zero", -- 1.7.4

2 1

[libvirt] Anyone looked at GXemul - the ARM emulator?
by Justin Clift 16 Feb '11

16 Feb '11

Hi all, Just came across an ARM emulator project that seems well developed and going decently: http://gxemul.sourceforge.net Kind of wondering if anyone has tried it out? Obviously also thinking it would be interesting if someone knows of a libvirt driver for it. :> Regards and best wishes, Justin Clift

1 0

[libvirt] [PATCH 0/2] Fix tests failures on some architectures
by Jiri Denemark 15 Feb '11

15 Feb '11

This fixes the following test failures seen on some architectures: TEST: qemuxml2argvtest ........................................ 40 ........................................ 80 .............................!.!!!!! 116 FAIL Jiri Denemark (2): tests: Fake host capabilities properly qemu: Fix command line generation with faked host CPU src/qemu/qemu_command.c | 8 +++++--- tests/testutilsqemu.c | 8 +++++--- 2 files changed, 10 insertions(+), 6 deletions(-) -- 1.7.4.1

3 7

[libvirt] [PATCH] Avoid empty strings when --with-packager(-version) is not specified
by Matthias Bolte 15 Feb '11

15 Feb '11

I pushed this patch already ACKed by Eric: https://www.redhat.com/archives/libvir-list/2011-February/msg00550.html Matthias

1 0

[libvirt] [PATCH] build: address clang reports about virCommand
by Eric Blake 15 Feb '11

15 Feb '11

clang had 5 reports against virCommand; three were false positives (a NULL deref in ProcessIO solved by sa_assert, and two uninitialized memory operations solved by adding an initializer), but two were real. * src/util/command.c (virCommandProcessIO): Fix real bug of possible NULL dereference. Teach clang that buf is never NULL. (virCommandRun): Teach clang that infd is only ever accessed when initialized. --- src/util/command.c | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/util/command.c b/src/util/command.c index abd2dc4..0845db4 100644 --- a/src/util/command.c +++ b/src/util/command.c @@ -1,7 +1,7 @@ /* * command.c: Child command execution * - * Copyright (C) 2010 Red Hat, Inc. + * Copyright (C) 2010-2011 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -881,6 +881,8 @@ virCommandProcessIO(virCommandPtr cmd) buf = cmd->errbuf; len = &errlen; } + /* Silence a false positive from clang. */ + sa_assert(buf); done = read(fds[i].fd, data, sizeof(data)); if (done < 0) { @@ -930,9 +932,9 @@ virCommandProcessIO(virCommandPtr cmd) ret = 0; cleanup: - if (*cmd->outbuf) + if (cmd->outbuf && *cmd->outbuf) (*cmd->outbuf)[outlen] = '\0'; - if (*cmd->errbuf) + if (cmd->errbuf && *cmd->errbuf) (*cmd->errbuf)[errlen] = '\0'; return ret; } @@ -950,7 +952,7 @@ virCommandRun(virCommandPtr cmd, int *exitstatus) int ret = 0; char *outbuf = NULL; char *errbuf = NULL; - int infd[2]; + int infd[2] = { -1, -1 }; struct stat st; bool string_io; bool async_io = false; -- 1.7.4

2 2

[libvirt] [PATCH] qemu: don't mask real error with oom report
by Eric Blake 15 Feb '11

15 Feb '11

* src/qemu/qemu_command.c (qemuBuildCommandLine): Don't report oom after qemuBuildControllerDevStr, which reported its own errors. --- src/qemu/qemu_command.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 3ba0950..63d5edc 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -3102,7 +3102,7 @@ qemuBuildCommandLine(virConnectPtr conn, char *devstr; if (!(devstr = qemuBuildControllerDevStr(def->controllers[i], qemuCmdFlags))) - goto no_memory; + goto error; virCommandAddArg(cmd, devstr); VIR_FREE(devstr); -- 1.7.4

2 2

[libvirt] [PATCH] virsh: Fix improper freecell --cellno command behavior
by Michal Privoznik 15 Feb '11

15 Feb '11

Non-digit characters were accepted in --cellno resulting in unwanted behavior: 'virsh freecell --cellno foo' wasn't rejected. --- This fix addresses bug 639587 tools/virsh.c | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index c2d165d..765566d 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -2283,7 +2283,7 @@ cmdFreecell(vshControl *ctl, const vshCmd *cmd) { int func_ret = FALSE; int ret; - int cell, cell_given; + int cell, cell_given, cellStr_given; unsigned long long memory; unsigned long long *nodes = NULL; int all_given; @@ -2295,6 +2295,13 @@ cmdFreecell(vshControl *ctl, const vshCmd *cmd) cell = vshCommandOptInt(cmd, "cellno", &cell_given); all_given = vshCommandOptBool(cmd, "all"); + vshCommandOptString(cmd, "cellno", &cellStr_given); + + if (cellStr_given && !cell_given) { + vshError(ctl, "%s", _("cell number must not contain any " + "non-digit characters.")); + goto cleanup; + } if (all_given && cell_given) { vshError(ctl, "%s", _("--cellno and --all are mutually exclusive. " -- 1.7.3.5

2 1

[libvirt] [PATCH] qemu: avoid NULL derefs
by Eric Blake 15 Feb '11

15 Feb '11

The processWatchdogEvent fix is real, although it can only trigger on OOM, since bad things happen if doCoreDump is called with a NULL pathname argument. The other fixes silence clang, but aren't a real bug because virReportErrorHelper tolerates a NULL format string even though *printf does not. * src/qemu/qemu_driver.c (processWatchdogEvent): Exit on OOM. (qemuDomainIsActive, qemuDomainIsPersistent, qemuDomainIsUpdated): Provide valid message. --- Another valid clang finding. Maybe we whould mark virReportErrorHelper as ATTRIBUTE_NONNULL for the format string argument, and require all clients to pass in a valid error string (after all, that's what the printf attritube already assumes, and passing NULL just means that we aren't giving back any useful error information to the user); but that can be a separate cleanup. src/qemu/qemu_driver.c | 23 +++++++++++++++++------ 1 files changed, 17 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index c581cfe..82a2210 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3489,7 +3489,10 @@ static int qemuDomainIsActive(virDomainPtr dom) obj = virDomainFindByUUID(&driver->domains, dom->uuid); qemuDriverUnlock(driver); if (!obj) { - qemuReportError(VIR_ERR_NO_DOMAIN, NULL); + char uuidstr[VIR_UUID_STRING_BUFLEN]; + virUUIDFormat(dom->uuid, uuidstr); + qemuReportError(VIR_ERR_NO_DOMAIN, + _("no domain with matching uuid '%s'"), uuidstr); goto cleanup; } ret = virDomainObjIsActive(obj); @@ -3510,7 +3513,10 @@ static int qemuDomainIsPersistent(virDomainPtr dom) obj = virDomainFindByUUID(&driver->domains, dom->uuid); qemuDriverUnlock(driver); if (!obj) { - qemuReportError(VIR_ERR_NO_DOMAIN, NULL); + char uuidstr[VIR_UUID_STRING_BUFLEN]; + virUUIDFormat(dom->uuid, uuidstr); + qemuReportError(VIR_ERR_NO_DOMAIN, + _("no domain with matching uuid '%s'"), uuidstr); goto cleanup; } ret = obj->persistent; @@ -3531,7 +3537,10 @@ static int qemuDomainIsUpdated(virDomainPtr dom) obj = virDomainFindByUUID(&driver->domains, dom->uuid); qemuDriverUnlock(driver); if (!obj) { - qemuReportError(VIR_ERR_NO_DOMAIN, NULL); + char uuidstr[VIR_UUID_STRING_BUFLEN]; + virUUIDFormat(dom->uuid, uuidstr); + qemuReportError(VIR_ERR_NO_DOMAIN, + _("no domain with matching uuid '%s'"), uuidstr); goto cleanup; } ret = obj->updated; @@ -4981,12 +4990,14 @@ static void processWatchdogEvent(void *data, void *opaque) case VIR_DOMAIN_WATCHDOG_ACTION_DUMP: { char *dumpfile; - int i; - i = virAsprintf(&dumpfile, "%s/%s-%u", + if (virAsprintf(&dumpfile, "%s/%s-%u", driver->autoDumpPath, wdEvent->vm->def->name, - (unsigned int)time(NULL)); + (unsigned int)time(NULL)) < 0) { + virReportOOMError(); + break; + } qemuDriverLock(driver); virDomainObjLock(wdEvent->vm); -- 1.7.4

2 2

[libvirt] [PATCH] virDomainMemoryStats: avoid null dereference
by Eric Blake 15 Feb '11

15 Feb '11

* src/libvirt.c (virDomainMemoryStats): Check domain before flags. --- Another valid bug found by clang. User's generally should't call virDomainMemoryStats(NULL,...), but we don't forbid it elsewhere, and doing so is not supposed to crash libvirt. All other flags checks in this file occur after validating the object first. src/libvirt.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 479a9b5..f65cc24 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -4411,12 +4411,6 @@ int virDomainMemoryStats (virDomainPtr dom, virDomainMemoryStatPtr stats, VIR_DOMAIN_DEBUG(dom, "stats=%p, nr_stats=%u", stats, nr_stats); - if (flags != 0) { - virLibDomainError(VIR_ERR_INVALID_ARG, - _("flags must be zero")); - goto error; - } - virResetLastError(); if (!VIR_IS_CONNECTED_DOMAIN (dom)) { @@ -4424,6 +4418,12 @@ int virDomainMemoryStats (virDomainPtr dom, virDomainMemoryStatPtr stats, virDispatchError(NULL); return -1; } + if (flags != 0) { + virLibDomainError(VIR_ERR_INVALID_ARG, + _("flags must be zero")); + goto error; + } + if (!stats || nr_stats == 0) return 0; -- 1.7.4

2 2

[libvirt] libvirt 0.8.7 tests failure on arm and ppc
by Serge E. Hallyn 15 Feb '11

15 Feb '11

Hi, as per the message after the tests fail, I'm reporting this on the list. Hopefully someone has seen this before. I've not yet tried this with the latest git snapshot. With 0.8.7, I get: TEST: qemuxml2argvtest ........................................ 40 ........................................ 80 .............................!.!!!!! 116 FAIL -serge

4 9

[libvirt] [PATCH] macvtap: Work-around failing nl_connect calls (weird problem)
by Stefan Berger 15 Feb '11

15 Feb '11

When trying to start / stop a domain with macvtap device (direct type of interface) having a device description like this one here <interface type='direct'> <source dev='static' mode='vepa'/> </interface> then I see netlink related errors when a 'virsh edit' session is happening at the same time. So, to reproduce this error you should try the following (on a kernel supporting macvtap): virsh edit <macvtap domain> -> do not terminate the edit sessions virsh start <macvtap domain> -> works virsh destroy <macvtap domain> -> leaves a macvtap device due to nl_connect failing virsh start <macvtap domain> -> does not start anymore That should make it fail. The work-around basically keeps on allocating new netlink library handles until the nl_connect() succeeds. New netlink library handles cause the next available port (intern to libnl; nl_pid) to be allocated. For every ongoing virsh edit session, one new handle seems to be required. So for 2 virsh edit session, the 3rd one (usually) works. I do not know what in the system is causing this, but my guess it that 'something' is blocking the same port (nl_pid) -- it may not be in libvirt but in a dependent library that's not using libnl (?). Signed-off-by: Stefan Berger <stefanb(a)linux.vnet.ibm.com> Index: libvirt-acl/src/util/macvtap.c =================================================================== --- libvirt-acl.orig/src/util/macvtap.c +++ libvirt-acl/src/util/macvtap.c @@ -120,13 +120,43 @@ int nlComm(struct nl_msg *nl_msg, fd_set readfds; int fd; int n; - struct nl_handle *nlhandle = nl_handle_alloc(); + struct nl_handle **nlhandles = NULL; struct nlmsghdr *nlmsg = nlmsg_hdr(nl_msg); + unsigned int idx = 0, num_elms = 1, i; - if (!nlhandle) - return -1; +realloc: + if (VIR_REALLOC_N(nlhandles, num_elms * sizeof(struct nl_handle *)) < 0) { + virReportOOMError(); + rc = -1; + goto err_exit; + } + + for (i = idx; i < num_elms ; i++) + nlhandles[i] = NULL; + +next_handle: + nlhandles[idx] = nl_handle_alloc(); - if (nl_connect(nlhandle, NETLINK_ROUTE) < 0) { + if (nlhandles[idx] == NULL) { + virReportOOMError(); + rc = -1; + goto err_exit; + } + + if (nl_connect(nlhandles[idx], NETLINK_ROUTE) < 0) { + VIR_DEBUG0("Could not create netlink socket - trying a new one\n"); + /* get a new handle and keep the ones we have */ + idx++; + if (idx < num_elms) + goto next_handle; + /* need to reallocate */ + num_elms += 10; + if (idx < 500) + goto realloc; + + macvtapError(VIR_ERR_INTERNAL_ERROR, "%s [%s]", + _("Could not create netlink socket"), + nl_geterror()); rc = -1; goto err_exit; } @@ -135,15 +165,16 @@ int nlComm(struct nl_msg *nl_msg, nlmsg->nlmsg_pid = getpid(); - nbytes = nl_send_auto_complete(nlhandle, nl_msg); + nbytes = nl_send_auto_complete(nlhandles[idx], nl_msg); if (nbytes < 0) { virReportSystemError(errno, - "%s", _("cannot send to netlink socket")); + "%s [%s]", _("cannot send to netlink socket"), + nl_geterror()); rc = -1; goto err_exit; } - fd = nl_socket_get_fd(nlhandle); + fd = nl_socket_get_fd(nlhandles[idx]); FD_ZERO(&readfds); FD_SET(fd, &readfds); @@ -160,7 +191,7 @@ int nlComm(struct nl_msg *nl_msg, goto err_exit; } - *respbuflen = nl_recv(nlhandle, &nladdr, respbuf, NULL); + *respbuflen = nl_recv(nlhandles[idx], &nladdr, respbuf, NULL); if (*respbuflen <= 0) rc = -1; @@ -171,7 +202,12 @@ err_exit: *respbuflen = 0; } - nl_handle_destroy(nlhandle); + if (nlhandles) + for (idx = 0; idx < num_elms; idx++) + nl_handle_destroy(nlhandles[idx]); + + VIR_FREE(nlhandles); + return rc; }

2 5

[libvirt] [PATCH] docs: added link for nimbus to apps page
by Justin Clift 15 Feb '11

15 Feb '11

--- docs/apps.html.in | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/docs/apps.html.in b/docs/apps.html.in index d8bc265..8b949f3 100644 --- a/docs/apps.html.in +++ b/docs/apps.html.in @@ -197,6 +197,18 @@ </dd> </dl> + <h2><a name="iaas">Infrastructure as a Service (IaaS)</a></h2> + + <dl> + <dt><a href="http://www.nimbusproject.org">Nimbus</a></dt> + <dd> + Nimbus is an open-source toolkit focused on providing + Infrastructure-as-a-Service (IaaS) capabilities to the scientific + community. It uses libvirt for communication with all KVM and Xen + virtual machines. + </dd> + </dl> + <h2><a name="libraries">Libraries</a></h2> <dl> -- 1.7.4.1

4 6

[libvirt] Mails rejected by mailist?
by Lyre 15 Feb '11

15 Feb '11

Hi all: I've tried to send a patch for libvirt-php using git send-email yesterday. My user.email is configured as a gmail address, that is this one. But git sent patches from local postfix. git CC the patchs to my gmail and I can revice it, but not listed on the maillist. Is it rejected by the maillist? And what should I do to send the patches?

4 5

[libvirt] [PATCH] Output commandline on status != 0 in virCommandWait
by Matthias Bolte 15 Feb '11

15 Feb '11

I pushed this one as suggested by Daniel in https://www.redhat.com/archives/libvir-list/2011-February/msg00519.html Matthias

1 0

[libvirt] [PATCH 0/3 PHP] Misc changes to build / git
by Daniel P. Berrange 15 Feb '11

15 Feb '11

This series does some cleanups to GIT and introduces support for automated build testing

3 9