- Devel - libvirt List Archives

[libvirt] [PATCH v2 0/4] Interface pools and passthrough mode
by Shradha Shah 12 Dec '11

12 Dec '11

Interface Pools and Passthrough mode: Current Method: The passthrough mode uses a macvtap direct connection to connect each guest to the network. The physical interface to be used is picked from among those listed in <interface> sub elements of the <forward> element. The current specification for <forward> extends to allow 0 or more <interface> sub-elements: Example: <forward mode='passthrough' dev='eth10'/> <interface dev='eth10'/> <interface dev='eth12'/> <interface dev='eth18'/> <interface dev='eth20'/> </forward> However with an ethernet card with 64 VF's or more, the above method gets tedious on the system. On the other hand, just parameterizing a string (eth%d) is inadequate, eg, when there are multiple non-contiguous ranges. Proposed Method: The 4 patches provided: i) Introduce a new element 'pf' to implicitly create an interface pool of all the Virtual Functions attached to the specified Physical Function. ii) Modify the networkAllocateActualDevice, networkNotifyActualDevice and networkReleaseActualDevice API to use the above mentioned interface pool in the passthrough mode. Hence Libvirt will now support both the methods mentioned below: * Explicit interface list. App inputs: <forward mode='passthrough'> <interface dev='eth10'/> <interface dev='eth11'/> <interface dev='eth12'/> <interface dev='eth13'/> </forward> libvirt does not change XML * Automatically interface list from PF. App inputs: <forward mode='passthrough'> <pf dev='eth0'/> </forward> libvirt expands XML to be <forward mode='passthrough'> <pf dev='eth0'/> <interface dev='eth10'/> <interface dev='eth11'/> <interface dev='eth12'/> <interface dev='eth13'/> </forward> In the above case we need to differentiate between the implicit and explicit interface pool, which can be done by comparing the dumpxml from active and inactive domains. This will need the addition of the flag VIR_NETWORK_XML_INACTIVE to virNetworkGetXMLDesc() as mentioned in a previous suggestion. I will post this as a separate patch series. Shradha Shah (4): Added function pciSysfsFile to enable access to the PCI SYSFS files. Added Function virNetDevGetVirtualFunctions Adding the element pf to network xml. Functionality to implicitly get interface pool from SR-IOV PF. docs/schemas/network.rng | 7 +++ src/conf/network_conf.c | 69 ++++++++++++++++++++++++++++++-- src/conf/network_conf.h | 3 + src/network/bridge_driver.c | 93 +++++++++++++++++++++++++++++++++--------- src/util/pci.c | 39 ++++++++++++++++++ src/util/pci.h | 7 +++ src/util/virnetdev.c | 83 ++++++++++++++++++++++++++++++++++++++ src/util/virnetdev.h | 6 +++ 8 files changed, 283 insertions(+), 24 deletions(-) -- 1.7.4.4

1 4

[libvirt] [PATCH] security: don't try to label network disks
by Josh Durgin 12 Dec '11

12 Dec '11

Network disks don't have paths to be resolved or files to be checked for ownership. ee3efc41e6233e625aa03003bf3127319ccd546f checked this for some image label functions, but was partially reverted in a refactor. This finishes adding the check to each security driver's set and restore label methods for images. Signed-off-by: Josh Durgin <josh.durgin(a)dreamhost.com> --- src/security/security_apparmor.c | 3 +++ src/security/security_dac.c | 6 ++++++ src/security/security_selinux.c | 3 +++ 3 files changed, 12 insertions(+), 0 deletions(-) diff --git a/src/security/security_apparmor.c b/src/security/security_apparmor.c index db7e7dc..3a01a21 100644 --- a/src/security/security_apparmor.c +++ b/src/security/security_apparmor.c @@ -606,6 +606,9 @@ AppArmorRestoreSecurityImageLabel(virSecurityManagerPtr mgr, virDomainObjPtr vm, virDomainDiskDefPtr disk ATTRIBUTE_UNUSED) { + if (disk->type == VIR_DOMAIN_DISK_TYPE_NETWORK) + return 0; + return reload_profile(mgr, vm, NULL, false); } diff --git a/src/security/security_dac.c b/src/security/security_dac.c index 0e75319..9f8a320 100644 --- a/src/security/security_dac.c +++ b/src/security/security_dac.c @@ -180,6 +180,9 @@ virSecurityDACSetSecurityImageLabel(virSecurityManagerPtr mgr, if (!priv->dynamicOwnership) return 0; + if (disk->type == VIR_DOMAIN_DISK_TYPE_NETWORK) + return 0; + return virDomainDiskDefForeachPath(disk, virSecurityManagerGetAllowDiskFormatProbing(mgr), false, @@ -199,6 +202,9 @@ virSecurityDACRestoreSecurityImageLabelInt(virSecurityManagerPtr mgr, if (!priv->dynamicOwnership) return 0; + if (disk->type == VIR_DOMAIN_DISK_TYPE_NETWORK) + return 0; + /* Don't restore labels on readoly/shared disks, because * other VMs may still be accessing these * Alternatively we could iterate over all running diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index 78c0d45..6ef61c7 100644 --- a/src/security/security_selinux.c +++ b/src/security/security_selinux.c @@ -636,6 +636,9 @@ SELinuxSetSecurityImageLabel(virSecurityManagerPtr mgr, if (secdef->norelabel) return 0; + if (disk->type == VIR_DOMAIN_DISK_TYPE_NETWORK) + return 0; + return virDomainDiskDefForeachPath(disk, allowDiskFormatProbing, true, -- 1.7.1

3 2

Re: [libvirt] macvtap support in libvirt 0.9.8
by Amit Tewari 12 Dec '11

12 Dec '11

Hi all, When I see dmesg on host machine it gives error- "macvtap0: no IPv6 routers present" Is this error causing saome problem.. Even if guest starts it gives error "Bringing up interface eth0: Device eth0 does not seem to be present, delaying initialization. [FAILED]" Is this dmesg = - "macvtap0: no IPv6 routers present" the cause??? ________________________________ From: libvir-list-bounces(a)redhat.com [mailto:libvir-list-bounces@redhat.com] On Behalf Of Amit Tewari Sent: Monday, December 12, 2011 3:50 PM To: libvir-list(a)redhat.com Subject: Re: [libvirt] macvtap support in libvirt 0.9.8 Hi all, Please ignore my previous mail.. This is my test scenario My test environment Host os=rhel6.1 Guest os = rhel6.1 Libvirt=0.9.8 Kvm hypervisor I am creating a macvtap interface on host machine at eth0 interface #ip link show macvtap0 51: macvtap0@eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UNKNOWN qlen 500 link/ether 1e:aa:f7:43:7e:3d brd ff:ff:ff:ff:ff:ff I have made this entry in guest xml file <interface type='direct'> <mac address=1e:aa:f7:43:7e:3d'/> <source dev='eth0' mode='bridge'/> <model type='virtio'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> </interface> Now when I start the guest #virsh start guest It gives following message error: Failed to start domain guest error: Cannot set interface flags on 'macvtap1': Device or resource busy Please let me know what else we need to do to make macvtap work on kvm. ________________________________ From: libvir-list-bounces(a)redhat.com [mailto:libvir-list-bounces@redhat.com] On Behalf Of Amit Tewari Sent: Monday, December 12, 2011 3:22 PM To: libvir-list(a)redhat.com Subject: [libvirt] macvtap support in libvirt 0.9.8 Hi all, My test environment Host os=rhel6.1 Guest os = rhel6.1 Libvirt=0.9.8 Kvm hypervisor I am creating a macvtap interface on host machine at eth0 interface #ip link show macvtap0 51: macvtap0@eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UNKNOWN qlen 500 link/ether 1e:aa:f7:43:7e:3d brd ff:ff:ff:ff:ff:ff I have made this entry in guest xml file <interface type='direct'> <mac address=1e:aa:f7:43:7e:3d'/> <source dev='eth0' mode='bridge'/> <model type='virtio'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> </interface> Now when I start the guest #virsh start guest It gives following message "Bringing up interface eth0: Device eth0 does not seem to be present, delaying initialization. [FAILED]" Guest eth interface does not create. what is the problem. Please let me know what else we need to do to make macvtap work on kvm. DISCLAIMER: ------------------------------------------------------------------------ ----------------------------------------------- The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. It shall not attach any liability on the originator or NECHCL or its affiliates. Any views or opinions presented in this email are solely those of the author and may not necessarily reflect the opinions of NECHCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of the author of this e-mail is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. . ------------------------------------------------------------------------ ----------------------------------------------- DISCLAIMER: ------------------------------------------------------------------------ ----------------------------------------------- The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. It shall not attach any liability on the originator or NECHCL or its affiliates. Any views or opinions presented in this email are solely those of the author and may not necessarily reflect the opinions of NECHCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of the author of this e-mail is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. . ------------------------------------------------------------------------ ----------------------------------------------- DISCLAIMER: ----------------------------------------------------------------------------------------------------------------------- The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. It shall not attach any liability on the originator or NECHCL or its affiliates. Any views or opinions presented in this email are solely those of the author and may not necessarily reflect the opinions of NECHCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of the author of this e-mail is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. . -----------------------------------------------------------------------------------------------------------------------

1 0

[libvirt] [PATCH 1/1] Fix make uninstall
by Dave Allan 12 Dec '11

12 Dec '11

Make uninstall currently fails with the following message: rmdir /etc/sasl2/ rmdir: failed to remove `/etc/sasl2/': Directory not empty That's fine (correct in fact) so force the command to return success with || : --- daemon/Makefile.am | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/daemon/Makefile.am b/daemon/Makefile.am index 22a9d38..023410e 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -351,7 +351,7 @@ install-data-sasl: uninstall-data-sasl: rm -f $(DESTDIR)$(sysconfdir)/sasl2/libvirt.conf - rmdir $(DESTDIR)$(sysconfdir)/sasl2/ + rmdir $(DESTDIR)$(sysconfdir)/sasl2/ || : else install-data-sasl: uninstall-data-sasl: -- 1.7.4.4

2 1

[libvirt] macvtap support in libvirt 0.9.8
by Amit Tewari 12 Dec '11

12 Dec '11

Hi all, My test environment Host os=rhel6.1 Guest os = rhel6.1 Libvirt=0.9.8 Kvm hypervisor I am creating a macvtap interface on host machine at eth0 interface #ip link show macvtap0 51: macvtap0@eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UNKNOWN qlen 500 link/ether 1e:aa:f7:43:7e:3d brd ff:ff:ff:ff:ff:ff I have made this entry in guest xml file <interface type='direct'> <mac address=1e:aa:f7:43:7e:3d'/> <source dev='eth0' mode='bridge'/> <model type='virtio'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> </interface> Now when I start the guest #virsh start guest It gives following message "Bringing up interface eth0: Device eth0 does not seem to be present, delaying initialization. [FAILED]" Guest eth interface does not create. what is the problem. Please let me know what else we need to do to make macvtap work on kvm. DISCLAIMER: ----------------------------------------------------------------------------------------------------------------------- The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. It shall not attach any liability on the originator or NECHCL or its affiliates. Any views or opinions presented in this email are solely those of the author and may not necessarily reflect the opinions of NECHCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of the author of this e-mail is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. . -----------------------------------------------------------------------------------------------------------------------

1 0

Re: [libvirt] virsh console giving Error
by Amit Tewari 12 Dec '11

12 Dec '11

Hi, I added this (in /etc/grub.conf) ---- console=tty0 console=ttyS0,115200 ----- But still same error is coming. -----Original Message----- From: libvir-list-bounces(a)redhat.com [mailto:libvir-list-bounces@redhat.com] On Behalf Of Amit Tewari Sent: Monday, December 12, 2011 12:36 PM To: Kashyap Chamarthy Cc: libvir-list(a)redhat.com Subject: Re: [libvirt] virsh console giving Error Hi, I am using libvirt 0.9.7 -----Original Message----- From: Kashyap Chamarthy [mailto:kchamart@redhat.com] Sent: Monday, December 12, 2011 12:32 PM To: Amit Tewari Cc: libvir-list(a)redhat.com Subject: Re: [libvirt] virsh console giving Error On 12/12/2011 12:16 PM, Amit Tewari wrote: > Hi all, > > Following is my test environment > > Host os= rhel6.1 > > Guest os=rhel6.1 > > Hypervisor - kvm > > > > I have a created a guest machine using virt-install command. And it has created guest > successfully. > > But now when I issue following command > > #virsh console guest > > > > Following error is displayed - > > > > "Error: internal error character device (null) is not using a PTY" > > > > Please let me no how can I avoid this error. You have not specified what distribution, version of libvirt are you using. First, can you ensure if you have serial console set up in your guest by checking if you have the below directives in your guest kernel's command line options (in /etc/grub.conf) ---- console=tty0 console=ttyS0,115200 ---- If not, you can add it by running the below (ensure the guest is shut-off): # virt-edit guest /etc/grub.conf 'virt-edit' tool comes with libguestfs-tools-c package. -- /kashyap > > > > Regards > > Amit Tewari > > > > -- > libvir-list mailing list > libvir-list(a)redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list DISCLAIMER: ------------------------------------------------------------------------ ----------------------------------------------- The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. It shall not attach any liability on the originator or NECHCL or its affiliates. Any views or opinions presented in this email are solely those of the author and may not necessarily reflect the opinions of NECHCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of the author of this e-mail is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. . ------------------------------------------------------------------------ ----------------------------------------------- -- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list DISCLAIMER: ----------------------------------------------------------------------------------------------------------------------- The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. It shall not attach any liability on the originator or NECHCL or its affiliates. Any views or opinions presented in this email are solely those of the author and may not necessarily reflect the opinions of NECHCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of the author of this e-mail is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. . -----------------------------------------------------------------------------------------------------------------------

1 0

[libvirt] virsh console giving Error
by Amit Tewari 12 Dec '11

12 Dec '11

Hi all, Following is my test environment Host os= rhel6.1 Guest os=rhel6.1 Hypervisor - kvm I have a created a guest machine using virt-install command. And it has created guest successfully. But now when I issue following command #virsh console guest Following error is displayed - "Error: internal error character device (null) is not using a PTY" Please let me no how can I avoid this error. Regards Amit Tewari DISCLAIMER: ----------------------------------------------------------------------------------------------------------------------- The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. It shall not attach any liability on the originator or NECHCL or its affiliates. Any views or opinions presented in this email are solely those of the author and may not necessarily reflect the opinions of NECHCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of the author of this e-mail is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. . -----------------------------------------------------------------------------------------------------------------------

2 1

[libvirt] Virtio Balloon Dynamic behaviour ??
by Pankaj Rawat 12 Dec '11

12 Dec '11

Hi all, I want to be clear in details regarding Virtio balloon Driver in RHEL 6.1 KVM hypervisor In documentations it is written that Virtio balloon driver allow the guest to expand its memory dynamically . Now I want to know the meaning of dynamically ... Whether it means 1) We can change the memory of guest using libvirt API only i.e by using virsh setmem command at runtime (VERIFIED) 2) Or the guest itself can check that it is running out of memory so it request host for some memory and when the host respond by giving back memory it expands its memory size. Which is automation The 1st option is working fine Now can anyone tell me that memory expantion can be done dynamically(point 2) also DISCLAIMER: ----------------------------------------------------------------------------------------------------------------------- The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. It shall not attach any liability on the originator or NECHCL or its affiliates. Any views or opinions presented in this email are solely those of the author and may not necessarily reflect the opinions of NECHCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of the author of this e-mail is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. . -----------------------------------------------------------------------------------------------------------------------

1 0

[libvirt] [test-API][PATCH] Add test case get_cpu_shares.py for cpu scheduler info testing
by Nan Zhang 12 Dec '11

12 Dec '11

* repos/domain/get_cpu_shares.py: get the value of cpu_shares property of the guest. --- lib/domainAPI.py | 2 +- repos/domain/get_cpu_shares.py | 109 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 110 insertions(+), 1 deletions(-) create mode 100644 repos/domain/get_cpu_shares.py diff --git a/lib/domainAPI.py b/lib/domainAPI.py index a6efab7..0058254 100644 --- a/lib/domainAPI.py +++ b/lib/domainAPI.py @@ -546,7 +546,7 @@ class DomainAPI(object): def set_sched_params_flags(self, domname, params, flags): try: dom_obj = self.get_domain_by_name(domname) - retval = dom_obj.setSchedulerParameters(params, flags) + retval = dom_obj.setSchedulerParametersFlags(params, flags) return retval except libvirt.libvirtError, e: message = e.get_error_message() diff --git a/repos/domain/get_cpu_shares.py b/repos/domain/get_cpu_shares.py new file mode 100644 index 0000000..be7e649 --- /dev/null +++ b/repos/domain/get_cpu_shares.py @@ -0,0 +1,109 @@ +#!/usr/bin/env python +"""Get the value of cpu_shares property of the guest + domain:get_cpu_shares + guestname + xxx + flags + 0|1|2 +""" + +__author__ = 'Nan Zhang: nzhang(a)redhat.com' +__date__ = 'Tue Sep 27, 2011' +__version__ = '0.1.0' +__credits__ = 'Copyright (C) 2011 Red Hat, Inc.' +__all__ = ['check_params', 'check_cpu_shares', 'get_cpu_shares'] + +import os +import re +import sys +import time +from xml.dom import minidom + + +def append_path(path): + """Append root path of package""" + if path in sys.path: + pass + else: + sys.path.append(path) + +pwd = os.getcwd() +result = re.search('(.*)libvirt-test-API', pwd) +append_path(result.group(0)) + +from lib import connectAPI +from lib import domainAPI +from utils.Python import utils +from utils.Python import xmlbuilder +from exception import LibvirtAPI + +def check_params(params): + """Verify inputing parameter dictionary""" + logger = params['logger'] + keys = ['guestname', 'flags'] + for key in keys: + if key not in params: + logger.error("%s is required" %key) + return 1 + return 0 + +def check_cpu_shares(params, util, guestname, cpu_shares): + """Check the value of cpu_shares""" + logger = params['logger'] + cmd = "cat /cgroup/cpu/libvirt/qemu/%s/cpu.shares" % guestname + ret, out = util.exec_cmd(cmd, shell=True) + if ret: + logger.error("fail to get the value of cpu_shares: %s" % out[0]) + return 0 + else: + logger.info("the value of cpu_shares: %s (getting from cgroup)" % out[0]) + + if cmp(int(out[0]), cpu_shares): + return 1 + else: + logger.info("the value of cpu_shares does match the original \ +cpu scheduler information.") + return 0 + +def get_cpu_shares(params): + """Get the cpu scheduler information""" + # Initiate and check parameters + params_check_result = check_params(params) + if params_check_result: + return 1 + logger = params['logger'] + guestname = params['guestname'] + flags = params['flags'] + + # Connect to local hypervisor connection URI + util = utils.Utils() + uri = util.get_uri('127.0.0.1') + conn = connectAPI.ConnectAPI() + virconn = conn.open(uri) + + caps = conn.get_caps() + logger.debug(caps) + + domobj = domainAPI.DomainAPI(virconn) + try: + sched_info = domobj.get_sched_params_flags(guestname, int(flags)) + cpu_shares = sched_info['cpu_shares'] + logger.debug("the value of cpu_shares is %s" % cpu_shares) + except LibvirtAPI, e: + logger.error("API error message: %s, error code is %s" % + (e.response()['message'], e.response()['code'])) + return 1 + + check_result = check_cpu_shares(params, util, guestname, cpu_shares) + if check_result: + logger.error("cpu_shares does not match.") + conn.close() + return 1 + + logger.info("success to get scheduler parameters.") + conn.close() + return 0 + +def get_cpu_shares_clean(): + """Clean testing environment""" + pass -- 1.7.4.4

1 0

[libvirt] [PATCH 1/6] Allow network model to contain "-"
by Michael Ellerman 12 Dec '11

12 Dec '11

From: Michael Ellerman <michael(a)ellerman.id.au> In QEMU PPC64 we have a network device called "spapr-vlan". We can specify this using the existing syntax for network devices, however libvirt currently rejects "spapr-vlan" in virDomainNetDefParseXML() because of the "-". Fix the code to accept "-". Signed-off-by: Michael Ellerman <michael(a)ellerman.id.au> --- src/conf/domain_conf.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 75e51a0..5de33b9 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -3703,8 +3703,7 @@ virDomainNetDefParseXML(virCapsPtr caps, if (model != NULL) { int i; for (i = 0 ; i < strlen(model) ; i++) { - int char_ok = c_isalnum(model[i]) || model[i] == '_'; - if (!char_ok) { + if (!c_isalnum(model[i]) && model[i] != '_' && model[i] != '-') { virDomainReportError(VIR_ERR_INVALID_ARG, "%s", _("Model name contains invalid characters")); goto error; -- 1.7.7.3

3 16

[libvirt] (no subject)
by Osier Yang 10 Dec '11

10 Dec '11

Hi, all This is a basic implementation of libvirt Native Linux KVM Tool driver. Note that this is just made with my own interest and spare time, it's not an endorsement/effort by Red Hat, and it isn't supported by Red Hat officially. Basically, the driver is designed as *stateful*, as KVM tool doesn't maintain any info about the guest except a socket which for its own IPC. And it's implemented by using KVM tool binary, which is name "kvm" currently, along with cgroup controllers "cpuacct", and "memory" support. And as one of KVM tool's pricinple is to allow both the non-root and root user to play with. The driver is designed to support root and non-root too, just like QEMU does. Example of the connection URI: virsh -c kvmtool:///system virsh -c kvmtool:///session virsh -c kvmtool+unix:///system virsh -c kvmtool+unix:///session The implementation can support more or less than 15 virsh commands currently, including basic domain cycle operations (define/undefine, start/destroy, suspend/resume, console, setmem, schedinfo, dumpxml, ,autostart, dominfo, etc.) About the domain configuration: * "kernel": must be specified as KVM tool only support boots from the kernel currently (no integration with BIOS app yet). * "disk": only virtio bus is supported, and device type must be 'disk'. * "serial/console": only one console is supported, of type serial or virtio (can extend to support multiple console as long as kvm tool supports, libvirt already supported mutiple console, see upstream commit 0873b688c). * "p9fs": only support specifying the source dir, and mount tag, only type of 'mount' is supported. * "memballoon": only virtio is supported, and there is no way to config the addr. * Multiple "disk" and "p9fs" is supported. * Graphics and network are not supported, will explain below. Please see "[PATCH 7/8]" for an example of the domain config. (which contains all the XMLs supported by current implementation). The problems of Native Linux KVM Tool from libvirt p.o.v: * Some destros package "qemu-kvm" as "kvm", also "kvm" is a long established name for "KVM" itself, so naming the project as "kvm" might be not a good idea. I assume it will be named as "kvmtool" in this implementation, never mind this if you don't like that, it can be updated easily. :-) * It still doesn't have an official package yet, even no "make install". means we have no way to check the dependancy and do the checking when 'configure'. I assume it will be installed as "/usr/bin/kvmtool" in this implementation. This is the main reason which can prevents upstream libvirt accepting the patches I guess. * Lacks of options for user's configuration, such as "-vnc", there is no option for user to configure the properties for the "vnc", such as the port. It hides things, doesn't provide ways to query the properties too, this causes problems for libvirt to add the vnc support, as vnc clients such as virt-manager, virt-viewer, have no way to connect the guest. Even vncviewer can't. * KVM tool manages the network completely itself (with DHCP support?), no way to configure, except specify the modes (user|tap|none). I have not test it yet, but it should need explicit script to setup the network rules(e.g. NAT) for the guest access outside world. Anyway, there is no way for libvirt to control the guest network. * There is a gap about the domain status between KVM tool and libvirt, it's caused by KVM tool unlink()s the guest socket when user exits from console (both text and graphic), but libvirt still think the guest is running. * KVM tool uses $HOME/.kvm_tool as the state dir, and no way to configure, I made a small patch to allow KVM tool accept a ENV variable, which is "KVM_STATE_DIR", it's used across the driver. I made a simple patch against kvm tool to let the whole patches work. See "[PATCH] kvm tools.....". As generally we want the state dir of a driver can be "/var/run/libvirt/kvmtool/..." for root user or "$HOME/.libvirt/kvmtool/run" for non-root user. * kvmtoolGetVersion is just broken now, as what "./kvm version" returns is something like "3.0.rc5.873.gb73216", however, libvirt wants things like "2.6.40.6-0". This might be not a problem as long as KVM tool has a official package. * console connection is implemented by setup ptys in libvirt, stdout/stderr of kvm tool process is redirected to the master pty, and libvirt connects to the slave pty. This works fine now, but it might be better if kvm tool could provide more advanced console mechanisms. Just like QEMU does? * Not much ways existed yet for external apps or user to query the guest informations. But this might be changed soon per KVM tool grows up quickly. * It will be quite desireable if kvm tool could report the capabilities, of which is lacked by QEMU forever (seems so), it causes much pain for upper layer mgmt apps. See the RFC by Daniel Berrange in QEMU list for more details: http://lists.nongnu.org/archive/html/qemu-devel/2010-06/msg00921.html As a conclusion, it seems to me that KVM tool dosesn't consider too much about the interface for upper layer management tools, (generally, upper layer apps will want good interface to set/get), which might be no good for KVM tool future development. Thoughts, and opinions? Thanks. [PATCH 1/7] kvmtool: Add configure support [PATCH] kvm tools: Introduce an ENV variable for the state dir [PATCH 2/7] kvmtool: Add documents [PATCH 3/7] kvmtool: Add new enums and error codes for the driver [PATCH 4/7] kvmtool: Add hook support for kvmtool domain [PATCH 5/7] kvmtool: Add new domain type [PATCH 6/7] conf: Set source type of the stub console [PATCH 7/7] kvmtool: Implementation for kvm tool driver Regards, Osier

4 25

[libvirt] libvirt hyper-v
by Andy Li 10 Dec '11

10 Dec '11

Dear Sir or Madam: I am engineer who want to connect hyper-v R2 via libvirt 0.9.3, but after create ceritificate file, and set the hyper-v winRM status to AllowUnencrypted="true" Then I connect the hyper-v by the command: virsh -c hyperv://192.168.58.26:5985 it always reply: Error: unable to complete TLS handshake: A TLS packet with unexpected length was received Error: failed to connect to the hypervisor Hope you can help me, thank you very much in advance. Thanks, Andy Li MFG Software Developer Department of Storage Products R&D, SCS Universal Scientific Industrial (Shanghai) Co., Ltd 421 Lishizhen Rd, Pudong New Area, Shanghai,P.R. China, 201203 Tel : +86 -21-5896 6996 ext. 81453 Fax : +86 -21-5080 4268

2 1

[libvirt] [PATCH] test: fix potential lock corruption in test driver
by Laine Stump 10 Dec '11

10 Dec '11

From: Laine Stump <laine(a)redhat.com> In some error situations, the function testDomainRestoreFlags() could unlock the test driver mutex without first locking it. This patch moves the lock operation earlier, so that it occurs before any potential jump down to the unlock call. I found this problem while auditing the test driver lock usage to determine the cause of a hang while running the following test: cd tests; while true; do printf x; ./undefine; done This patch *does not* solve that problem, but we now understand its actual source, and danpb is working on a patch. --- src/test/test_driver.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index ce94a17..89f7df1 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -1861,6 +1861,8 @@ testDomainRestoreFlags(virConnectPtr conn, return -1; } + testDriverLock(privconn); + if ((fd = open(path, O_RDONLY)) < 0) { virReportSystemError(errno, _("cannot read domain image '%s'"), @@ -1900,7 +1902,6 @@ testDomainRestoreFlags(virConnectPtr conn, } xml[len] = '\0'; - testDriverLock(privconn); def = virDomainDefParseString(privconn->caps, xml, 1 << VIR_DOMAIN_VIRT_TEST, VIR_DOMAIN_XML_INACTIVE); -- 1.7.7.3

2 2

[libvirt] [PATCH] test: replace deprecated "fedora-13" machine with "pc-0.13"
by Laine Stump 10 Dec '11

10 Dec '11

One of the xml tests in the test suite was created using a now-deprecated qemu machine type ("fedora-13", which was only ever valid for Fedora builds of qemu). Although strictly speaking it's not necessary to replace it with an actual supported qemu machine type (since the xml in question is never actually sent to qemu), this patch changes it to the actually-supported "pc-0.13" just for general tidiness. (Also, on some Fedora builds which contain a special patch to rid the world of "fedora-13", having it mentioned in the test suite will cause make check to fail.) --- .../qemuxml2argv-encrypted-disk.args | 2 +- .../qemuxml2argv-encrypted-disk.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemuxml2argvdata/qemuxml2argv-encrypted-disk.args b/tests/qemuxml2argvdata/qemuxml2argv-encrypted-disk.args index 1da0073..c6634fd 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-encrypted-disk.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-encrypted-disk.args @@ -1,5 +1,5 @@ LC_ALL=C PATH=/sbin:/usr/sbin:/bin:/usr/bin HOME=/root USER=root LOGNAME=root \ -/usr/bin/qemu -S -M fedora-13 -m 1024 -smp 1,sockets=1,cores=1,threads=1 -name \ +/usr/bin/qemu -S -M pc-0.13 -m 1024 -smp 1,sockets=1,cores=1,threads=1 -name \ encryptdisk -uuid 496898a6-e6ff-f7c8-5dc2-3cf410945ee9 -nographic -nodefconfig \ -nodefaults -chardev socket,id=monitor,\ path=//var/lib/libvirt/qemu/encryptdisk.monitor,server,nowait -mon \ diff --git a/tests/qemuxml2argvdata/qemuxml2argv-encrypted-disk.xml b/tests/qemuxml2argvdata/qemuxml2argv-encrypted-disk.xml index f5e5d74..fdcf624 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-encrypted-disk.xml +++ b/tests/qemuxml2argvdata/qemuxml2argv-encrypted-disk.xml @@ -5,7 +5,7 @@ <currentMemory>524288</currentMemory> <vcpu>1</vcpu> <os> - <type arch='i686' machine='fedora-13'>hvm</type> + <type arch='i686' machine='pc-0.13'>hvm</type> <boot dev='hd'/> </os> <clock offset='utc'/> -- 1.7.7.3

2 2

[libvirt] [PATCH] network: don't add iptables rules for externally managed networks
by Laine Stump 10 Dec '11

10 Dec '11

From: Laine Stump <laine(a)redhat.com> This patch addresses https://bugzilla.redhat.com/show_bug.cgi?id=760442 When a network has any forward type other than route, nat or none, the network configuration should be done completely external to libvirt - libvirt only uses these types to allow configuring guests in a manner that isn't tied to a specific host (all the host-specific information, in particular interface names, port profile data, and bandwidth configuration is in the network definition, and the guest configuration only references it). Due to a bug in the bridge network driver, libvirt was adding iptables rules for networks with forward type='bridge' etc. any time libvirtd was restarted while one of these networks was active. This patch eliminates that error by only "reloading" iptables rules if forward type is route, nat, or none. --- src/network/bridge_driver.c | 18 +++++++++++++----- 1 files changed, 13 insertions(+), 5 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 63338a2..44c80e1 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -1470,14 +1470,22 @@ networkReloadIptablesRules(struct network_driver *driver) VIR_INFO("Reloading iptables rules"); for (i = 0 ; i < driver->networks.count ; i++) { - virNetworkObjLock(driver->networks.objs[i]); - if (virNetworkObjIsActive(driver->networks.objs[i])) { - networkRemoveIptablesRules(driver, driver->networks.objs[i]); - if (networkAddIptablesRules(driver, driver->networks.objs[i]) < 0) { + virNetworkObjPtr network = driver->networks.objs[i]; + + virNetworkObjLock(network); + if (virNetworkObjIsActive(network) && + ((network->def->forwardType == VIR_NETWORK_FORWARD_NONE) || + (network->def->forwardType == VIR_NETWORK_FORWARD_NAT) || + (network->def->forwardType == VIR_NETWORK_FORWARD_ROUTE))) { + /* Only the three L3 network types that are configured by libvirt + * need to have iptables rules reloaded. + */ + networkRemoveIptablesRules(driver, network); + if (networkAddIptablesRules(driver, network) < 0) { /* failed to add but already logged */ } } - virNetworkObjUnlock(driver->networks.objs[i]); + virNetworkObjUnlock(network); } } -- 1.7.7.3

2 2

[libvirt] [PATCH 0/6] Allow minimal bandwidth guarantee
by Michal Privoznik 09 Dec '11

09 Dec '11

Since 0.9.4 release libvirt supports setting some QoS attributes on virtual bridges and/or virtual interfaces. Average and peak rate, namely. It lacks minimal guaranteed bandwidth aka 'floor' attribute, though. This patch set tries to fill that hole. However, there are some things you want to know before diving into individual patches: 1) Hierarchical shaping The whole magic hidden in here: Classes [1] can have multiple children and form a tree. A class can borrow unused bandwidth from other sibling classes up to its 'ceil'. This is done in kernel, though. Classes does not share any info among interfaces. Therefore we need to group traffic from domain interfaces so it goes over one point (a bridge). It is now obvious why this functionality is limited to VIR_DOMAIN_NET_TYPE_NETWORK only as the other bridged network type (VIR_DOMAIN_NET_TYPE_BRIDGE:) is meant to be not managed or touched by libvirt at all. This patches build that tree of classes. On network startup, a root class with one child class are created. This child is supposed to be catchment for all interfaces which will ever be plugged and don't have any 'floor'. Once we have network prepared, an interface may be plugged in. That means on a domain startup, as we create virtual devices for a domain and plug them into a bridge, we can create separate class for created interface (if it is needed = has 'floor' set). Class are distinguished by u_int16 identifier which: - needs to be unique among one bridge, obviously - we want to keep, and pass on interface unplugging 2) Network status file Because of the class ID I am mentioning above, I found myself in need of saving next free class ID among with network, so it survives daemon reboots. That's what 5th patch does actually. On interface plug event an unique class ID is taken and on successful QoS set it is stored into an interface. Having said that, domain status XML was extended to keep pair <interface alias; class id> 3) Tying interface traffic with class is done via filter [2]. Filters direct packets into a classes during which packet undergoes examination. Such filter is caller classifier. For example, filter classify packets based on their marks, src/dest ip address, port, etc. And here comes another magic trick. But not so nice as the first one. Libvirt does not know anything about guest (interface) ip address(es). The only thing that libvirt knows for sure is MAC address. But for some reason, filters refuse to use ebtables marks even if iptables marks works well. Filters, however does not support classifying by MAC address. Well, not directly. u32 filter can match any part of a packet at any offset. Offset 0 is start of IP header. And offsets can be negative :) 1: http://tldp.org/HOWTO/Traffic-Control-HOWTO/components.html#c-class 2: http://tldp.org/HOWTO/Traffic-Control-HOWTO/components.html#c-filter Michal Privoznik (6): bandwidth: add new 'floor' attribute bandwidth: Create hierarchical shaping classes bandwidth: Create (un)plug functions bandwidth: Create network (un)plug functions network: Create status files domain: Keep assigned class_id in domstatus XML daemon/libvirtd.c | 3 + docs/formatdomain.html.in | 21 +++- docs/schemas/networkcommon.rng | 5 + po/POTFILES.in | 1 + src/conf/domain_conf.c | 10 +- src/conf/domain_conf.h | 1 + src/conf/netdev_bandwidth_conf.c | 81 +++++++++++--- src/conf/netdev_bandwidth_conf.h | 3 +- src/conf/network_conf.c | 220 ++++++++++++++++++++++++++++++++------ src/conf/network_conf.h | 9 ++ src/libvirt_network.syms | 2 + src/libvirt_private.syms | 2 + src/lxc/lxc_driver.c | 3 +- src/network/bridge_driver.c | 109 +++++++++++++++++-- src/network/bridge_driver.h | 7 ++ src/qemu/qemu_command.c | 20 +++- src/qemu/qemu_domain.c | 66 +++++++++++- src/qemu/qemu_process.c | 12 ++ src/util/virnetdevbandwidth.c | 205 ++++++++++++++++++++++++++++++++++-- src/util/virnetdevbandwidth.h | 19 +++- src/util/virnetdevmacvlan.c | 2 +- 21 files changed, 710 insertions(+), 91 deletions(-) -- 1.7.3.4

1 6

[libvirt] [PATCH] virsh: plug memory leak on cmdDomblkstat
by ajia＠redhat.com 09 Dec '11

09 Dec '11

From: Alex Jia <ajia(a)redhat.com> Detected by valgrind. Leak introduced in commit 88a993b: * tools/virsh.c: fix memory leak on cmdDomblkstat. * how to reproduce? % valgrind -v --leak-check=full virsh cmdDomblkstat <domain name> * actual valgrind result: ==6573== 1,836 bytes in 1 blocks are definitely lost in loss record 110 of 124 ==6573== at 0x4A05FDE: malloc (vg_replace_malloc.c:236) ==6573== by 0x330D71497D: xdr_string (in /lib64/libc-2.12.so) ==6573== by 0x4D26CED: xdr_remote_nonnull_string (remote_protocol.c:30) ==6573== by 0x4D28138: xdr_remote_domain_get_xml_desc_ret (remote_protocol.c:1418) ==6573== by 0x4D3C0C2: virNetMessageDecodePayload (virnetmessage.c:382) ==6573== by 0x4D3279F: virNetClientProgramCall (virnetclientprogram.c:382) ==6573== by 0x4D0D50B: callWithFD (remote_driver.c:4339) ==6573== by 0x4D0D5AB: call (remote_driver.c:4360) ==6573== by 0x4D16EAF: remoteDomainGetXMLDesc (remote_client_bodies.h:861) ==6573== by 0x4CF9F4F: virDomainGetXMLDesc (libvirt.c:4098) ==6573== by 0x4154D9: cmdDomblklist (virsh.c:1722) ==6573== by 0x4149E2: vshCommandRun (virsh.c:16365) ==6573== ==6573== 46,009 (352 direct, 45,657 indirect) bytes in 1 blocks are definitely lost in loss record 123 of 124 ==6573== at 0x4A05FDE: malloc (vg_replace_malloc.c:236) ==6573== by 0x3318286DC6: xmlXPathNewContext (in /usr/lib64/libxml2.so.2.7.6) ==6573== by 0x4C79AE2: virXMLParseHelper (xml.c:779) ==6573== by 0x415512: cmdDomblklist (virsh.c:1726) ==6573== by 0x4149E2: vshCommandRun (virsh.c:16365) ==6573== by 0x427743: main (virsh.c:17867) ==6573== ==6573== LEAK SUMMARY: ==6573== definitely lost: 2,188 bytes in 2 blocks ==6573== indirectly lost: 45,657 bytes in 332 blocks ==6573== possibly lost: 0 bytes in 0 blocks ==6573== still reachable: 128,034 bytes in 1,364 blocks ==6573== suppressed: 0 bytes in 0 blocks Signed-off-by: Alex Jia <ajia(a)redhat.com> --- tools/virsh.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index a51478f..7c2f3fc 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -1757,6 +1757,9 @@ cmdDomblklist(vshControl *ctl, const vshCmd *cmd) cleanup: VIR_FREE(disks); virDomainFree(dom); + VIR_FREE(xml); + xmlFreeDoc(xmldoc); + xmlXPathFreeContext(ctxt); return ret; } -- 1.7.1

3 3

Re: [libvirt] how to use macvtap in kvm guest
by Amit Tewari 09 Dec '11

09 Dec '11

Hi, No guest can not get ip. When I do ifup eth0 it give error device not found. Hostos=rhel 6.x86_64 Guest os= rhel 6.x86_64 Libvirt =0.8.7 Macvtap driver is loaded. Qemu-kvm= 0.12.1.2 i think this error is creating problem macvtap0:no ipv6 routers present ________________________________ From: xhu [mailto:xhu@redhat.com] Sent: Friday, December 09, 2011 10:53 AM To: Amit Tewari Cc: libvir-list(a)redhat.com Subject: Re: [libvirt] how to use macvtap in kvm guest On 12/09/2011 12:28 PM, Amit Tewari wrote: Hi I am creating macvtap0 interface on my eth1 interface. ip link show macvtap0 133: macvtap0@eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UNKNOWN qlen 500 link/ether 3e:63:18:f3:49:63 brd ff:ff:ff:ff:ff:ff guest interface file- <interface type='direct'> <mac address='3e:63:18:f3:49:63'/> <source dev='eth0' mode='bridge'/> <model type='virtio'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/> </interface> Now when I do- Virsh define guest works fine But when I do virsh start guest can guest gain ip? Dmesg shows error macvtap0:no ipv6 routers present libvirtd[24907]: segfault at 0 ip 0000003e22280062 sp 00007fd3057f8cb8 error 4 in libc-2.12.so[3e22200000+187000] and even if guest starts its eth interface is not created could you provide your host os, guest os, libvirt, qemu-kvm version? it is fine as i tried, no segment fault message and the guest can get ip. DISCLAIMER: ------------------------------------------------------------------------ ----------------------------------------------- The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. It shall not attach any liability on the originator or NECHCL or its affiliates. Any views or opinions presented in this email are solely those of the author and may not necessarily reflect the opinions of NECHCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of the author of this e-mail is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. . ------------------------------------------------------------------------ ----------------------------------------------- -- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list DISCLAIMER: ----------------------------------------------------------------------------------------------------------------------- The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. It shall not attach any liability on the originator or NECHCL or its affiliates. Any views or opinions presented in this email are solely those of the author and may not necessarily reflect the opinions of NECHCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of the author of this e-mail is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. . -----------------------------------------------------------------------------------------------------------------------

2 1

[libvirt] [PATCH] fix memory leak in src/nodeinfo.c
by Stefan Berger 09 Dec '11

09 Dec '11

Fix memory leak: ==27534== 24 bytes in 1 blocks are definitely lost in loss record 207 of 530 ==27534== at 0x4A05E46: malloc (vg_replace_malloc.c:195) ==27534== by 0x38EC26EC37: vasprintf (in /lib64/libc-2.13.so) ==27534== by 0x4E998E6: virVasprintf (util.c:1677) ==27534== by 0x4E999F1: virAsprintf (util.c:1695) ==27534== by 0x4F1EAAC: nodeGetInfo (nodeinfo.c:593) ==27534== by 0x47948F: qemuCapsInitCPU (qemu_capabilities.c:855) ==27534== by 0x4796B1: qemuCapsInit (qemu_capabilities.c:915) ==27534== by 0x456550: qemuCreateCapabilities (qemu_driver.c:245) ==27534== by 0x4578C4: qemudStartup (qemu_driver.c:580) ==27534== by 0x4F20886: virStateInitialize (libvirt.c:852) ==27534== by 0x420E55: daemonRunStateInit (libvirtd.c:1156) ==27534== by 0x4E94C56: virThreadHelper (threads-pthread.c:157) Mark this leaked variable as const char * when it is passed into another function. --- src/nodeinfo.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) Index: libvirt-iterator/src/nodeinfo.c =================================================================== --- libvirt-iterator.orig/src/nodeinfo.c +++ libvirt-iterator/src/nodeinfo.c @@ -68,7 +68,7 @@ /* NB, this is not static as we need to call it from the testsuite */ int linuxNodeInfoCPUPopulate(FILE *cpuinfo, - char *sysfs_cpudir, + const char *sysfs_cpudir, virNodeInfoPtr nodeinfo); static int linuxNodeGetCPUStats(FILE *procstat, @@ -199,7 +199,7 @@ static int parse_core(unsigned int cpu) } int linuxNodeInfoCPUPopulate(FILE *cpuinfo, - char *sysfs_cpudir, + const char *sysfs_cpudir, virNodeInfoPtr nodeinfo) { char line[1024]; @@ -597,9 +597,12 @@ int nodeGetInfo(virConnectPtr conn ATTRI ret = linuxNodeInfoCPUPopulate(cpuinfo, sysfs_cpuinfo, nodeinfo); VIR_FORCE_FCLOSE(cpuinfo); - if (ret < 0) + if (ret < 0) { + VIR_FREE(sysfs_cpuinfo); return -1; + } + VIR_FREE(sysfs_cpuinfo); /* Convert to KB. */ nodeinfo->memory = physmem_total () / 1024;

2 2

[libvirt] [PATCH v2] fix error when parsing ppc64 models on x86 host
by Stefan Berger 09 Dec '11

09 Dec '11

When parsing ppc64 models on an x86 host an out-of-memory error message is displayed due to it checking for retcpus being NULL. Fix this by removing the check whether retcpus is NULL since we will realloc into this variable. Also in the X86 model parser display the OOM error at the location where it happens. --- v2: Fixing leak of 'cpus' --- src/qemu/qemu_capabilities.c | 37 ++++++++++++++++++++----------------- 1 file changed, 20 insertions(+), 17 deletions(-) Index: libvirt-iterator/src/qemu/qemu_capabilities.c =================================================================== --- libvirt-iterator.orig/src/qemu/qemu_capabilities.c +++ libvirt-iterator/src/qemu/qemu_capabilities.c @@ -443,8 +443,10 @@ qemuCapsParseX86Models(const char *outpu if (retcpus) { unsigned int len; - if (VIR_REALLOC_N(cpus, count + 1) < 0) + if (VIR_REALLOC_N(cpus, count + 1) < 0) { + virReportOOMError(); goto error; + } if (next) len = next - p - 1; @@ -456,8 +458,10 @@ qemuCapsParseX86Models(const char *outpu len -= 2; } - if (!(cpus[count] = strndup(p, len))) + if (!(cpus[count] = strndup(p, len))) { + virReportOOMError(); goto error; + } } count++; } while ((p = next)); @@ -491,12 +495,7 @@ qemuCapsParsePPCModels(const char *outpu const char *next; unsigned int count = 0; const char **cpus = NULL; - int i; - - if (!retcpus) { - VIR_DEBUG("No retcpus specified"); - return -1; - } + int i, ret; do { const char *t; @@ -523,32 +522,38 @@ qemuCapsParsePPCModels(const char *outpu if (retcpus) { unsigned int len; - if (VIR_REALLOC_N(cpus, count + 1) < 0) + if (VIR_REALLOC_N(cpus, count + 1) < 0) { virReportOOMError(); + ret = -1; goto error; + } len = t - p - 1; - if (!(cpus[count] = strndup(p, len))) + if (!(cpus[count] = strndup(p, len))) { virReportOOMError(); + ret = -1; goto error; + } } count++; } while ((p = next)); if (retcount) *retcount = count; - if (retcpus) + if (retcpus) { *retcpus = cpus; - return 0; + cpus = NULL; + } + ret = 0; error: if (cpus) { for (i = 0; i < count; i++) VIR_FREE(cpus[i]); + VIR_FREE(cpus); } - VIR_FREE(cpus); - return -1; + return ret; } int @@ -587,10 +592,8 @@ qemuCapsProbeCPUModels(const char *qemu, if (virCommandRun(cmd, NULL) < 0) goto cleanup; - if (parse(output, count, cpus) < 0) { - virReportOOMError(); + if (parse(output, count, cpus) < 0) goto cleanup; - } ret = 0;

2 2

[libvirt] [PATCH] threadpool: Don't wait on condition if pool has no workers
by Michal Privoznik 09 Dec '11

09 Dec '11

Pool creates new workers dynamically. However, it is possible for a pool to have no workers. If we want to free that pool, we don't want to wait on quit condition as it will never be signaled. --- Pushing under trivial rule src/util/threadpool.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/util/threadpool.c b/src/util/threadpool.c index c16e2af..883d1e5 100644 --- a/src/util/threadpool.c +++ b/src/util/threadpool.c @@ -258,7 +258,8 @@ void virThreadPoolFree(virThreadPoolPtr pool) virCondBroadcast(&pool->prioCond); } - ignore_value(virCondWait(&pool->quit_cond, &pool->mutex)); + if (pool->nWorkers > 0 || pool->nPrioWorkers > 0) + ignore_value(virCondWait(&pool->quit_cond, &pool->mutex)); while ((job = pool->jobList.head)) { pool->jobList.head = pool->jobList.head->next; -- 1.7.3.4

2 5

[libvirt] [PATCH] fix error when parsing ppc64 models on x86 host
by Stefan Berger 09 Dec '11

09 Dec '11

When parsing ppc64 models on an x86 host an out-of-memory error message is displayed due to it checking for retcpus being NULL. Fix this by removing the check whether retcpus is NULL since we will realloc into this variable. Also in the X86 model parser display the OOM error at the location where it happens. --- src/qemu/qemu_capabilities.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) Index: libvirt-iterator/src/qemu/qemu_capabilities.c =================================================================== --- libvirt-iterator.orig/src/qemu/qemu_capabilities.c +++ libvirt-iterator/src/qemu/qemu_capabilities.c @@ -443,8 +443,10 @@ qemuCapsParseX86Models(const char *outpu if (retcpus) { unsigned int len; - if (VIR_REALLOC_N(cpus, count + 1) < 0) + if (VIR_REALLOC_N(cpus, count + 1) < 0) { + virReportOOMError(); goto error; + } if (next) len = next - p - 1; @@ -456,8 +458,10 @@ qemuCapsParseX86Models(const char *outpu len -= 2; } - if (!(cpus[count] = strndup(p, len))) + if (!(cpus[count] = strndup(p, len))) { + virReportOOMError(); goto error; + } } count++; } while ((p = next)); @@ -493,11 +497,6 @@ qemuCapsParsePPCModels(const char *outpu const char **cpus = NULL; int i; - if (!retcpus) { - VIR_DEBUG("No retcpus specified"); - return -1; - } - do { const char *t; @@ -587,10 +586,8 @@ qemuCapsProbeCPUModels(const char *qemu, if (virCommandRun(cmd, NULL) < 0) goto cleanup; - if (parse(output, count, cpus) < 0) { - virReportOOMError(); + if (parse(output, count, cpus) < 0) goto cleanup; - } ret = 0;

2 1

[libvirt] [PATCH] virsh: correct the cmdDomIfGetLink function return value error
by ajia＠redhat.com 09 Dec '11

09 Dec '11

From: Alex Jia <ajia(a)redhat.com> * tools/virsh.c: Although finding interface with matching mac addr, forgot to set 'ret' boolean value to 'true'. * how to reproduce? % virsh domif-getlink <guest name> <interface mac> % echo $? Signed-off-by: Alex Jia <ajia(a)redhat.com> --- tools/virsh.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 276e1cc..91c3459 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -1538,6 +1538,7 @@ cmdDomIfGetLink (vshControl *ctl, const vshCmd *cmd) mac = virXMLPropString(cur, "address"); if (STRCASEEQ(mac, iface)){ + ret = true; goto hit; } } -- 1.7.1

3 4

[libvirt] FYI: SpecVirt results using libvirt + KVM
by Daniel P. Berrange 09 Dec '11

09 Dec '11

Some folks may be aware of the SpecVirt benchmark, where KVM is giving the competition something to worry about :-) http://www.spec.org/virt_sc2010/results/ >From the POV of libvirt uses though, there has been one annoyance with the previously submitted results though, in that they have been invoking the KVM command line directly. This has made it harder for people who are deploying KVM using libvirt to replicate the optimal configurations. I'm pleased to be able to point out that the latest result published for KVM by IBM has in fact been done using libvirt! You can clearly see how the guests are being configured with libvirt and the results demonstrate that using libvirt to manage KVM does not involve sacrificing any of the performance that KVM offers: http://www.spec.org/virt_sc2010/results/res2011q4/ This can only continue to get better as our communities work together to add more performance related features to both libvirt and KVM :-) Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

1 0

[libvirt] [PATCH] bridge: Fix forward delay APIs
by Jiri Denemark 09 Dec '11

09 Dec '11

Due to copy&paste error in c1df2c14b590b3d68b707aa4f3a570f95a6bc548, virNetDevBridge[SG]etSTPDelay APIs were accessing wrong file. --- src/util/virnetdevbridge.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virnetdevbridge.c b/src/util/virnetdevbridge.c index e246b2c..08c8f5c 100644 --- a/src/util/virnetdevbridge.c +++ b/src/util/virnetdevbridge.c @@ -395,7 +395,7 @@ int virNetDevBridgeSetSTPDelay(const char *brname, if ((fd = virNetDevSetupControl(brname, &ifr)) < 0) goto cleanup; - ret = virNetDevBridgeSet(brname, "stp_state", MS_TO_JIFFIES(delay), + ret = virNetDevBridgeSet(brname, "forward_delay", MS_TO_JIFFIES(delay), fd, &ifr); cleanup: @@ -426,7 +426,7 @@ int virNetDevBridgeGetSTPDelay(const char *brname, if ((fd = virNetDevSetupControl(brname, &ifr)) < 0) goto cleanup; - ret = virNetDevBridgeGet(brname, "stp_state", &i, + ret = virNetDevBridgeGet(brname, "forward_delay", &i, fd, &ifr); *delayms = JIFFIES_TO_MS(i); -- 1.7.8

2 1