- Devel - libvirt List Archives

Re: [libvirt] FW: macvtap not working on rhel 6.1 x86 machine
by Amit Tewari 15 Dec '11

15 Dec '11

hi, i want the kvm guest machine to connect to network using macvtap.. I tried this vepa mode it is also not working. My test environment Host os=rhel6.1 Guest os = rhel6.1 Libvirt=0.8.7 Kvm hypervisor I have made this entry in guest xml file <interface type='direct'> <source dev='eth0' mode='bridge'/> <model type='virtio'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> </interface> Now when I start the guest #virsh start guest Following macvtap0 is created on host and is shown below #ip link show macvtap0 51: macvtap0@eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UNKNOWN qlen 500 link/ether 52:54:00:55:AE:B5brd ff:ff:ff:ff:ff:ff but when the guest is up and I try to perform # ifup eth0 eth0 has same mac address as that of macvatap0 that is 52:54:00:55:AE:B5 due to this guest is not able to get dhcp address nor static ip address is working. Please let me know how macvtap work on kvm. -----Original Message----- From: Gerhard Stenzel [mailto:gstenzel@linux.vnet.ibm.com] Sent: Thursday, December 15, 2011 3:47 PM To: Amit Tewari Cc: libvir-list(a)redhat.com Subject: Re: [libvirt] FW: macvtap not working on rhel 6.1 x86 machine On Thu, 2011-12-15 at 15:20 +0530, Amit Tewari wrote: > > > Hi all, > > > > My test environment > > Host os=rhel6.1 x86 machine > > Guest os = rhel6.1 > > Libvirt=0.8.7 > > Kvm hypervisor > Hi, maybe it would help if you try to explain first, what you are trying to achieve, what your setup looks like (including your DHCP setup and switch infrastructure). Here (http://libvirt.org/formatdomain.html) you will find the following xml sample, which works: ... <devices> <interface type='direct'> <source dev='eth0' mode='vepa'/> </interface> </devices> ... This will connect your VM directly to the same network as eth0. Please be aware that, depending on your switch configuration (supports hair pin mode or not), your host might not be able to talk to your VM and vice versa. -- Best regards, Gerhard Stenzel, ----------------------------------------------------------------------------------------------------------------------------------- IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martin Jetter Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294 DISCLAIMER: ----------------------------------------------------------------------------------------------------------------------- The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. It shall not attach any liability on the originator or NECHCL or its affiliates. Any views or opinions presented in this email are solely those of the author and may not necessarily reflect the opinions of NECHCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of the author of this e-mail is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. . -----------------------------------------------------------------------------------------------------------------------

2 1

[libvirt] [PATCH] qemu: Fix race between async and query jobs
by Jiri Denemark 15 Dec '11

15 Dec '11

If an async job run on a domain will stop the domain at the end of the job, a concurrently run query job can hang in qemu monitor nothing can be done with that domain from this point on. An attempt to start such domain results in "Timed out during operation: cannot acquire state change lock" error. However, quite a few things have to happen at the right time... There must be an async job running, which stops a domain at the end. This race was with dump --crash but other similar jobs, such as (managed)save and migration, should be able to trigger this bug as well. While this async job is processing its last monitor command, that is a query-migrate to which qemu replies with status "completed", a new libvirt API that results in a query job must arrive and stay waiting until the query-migrate command finishes. Once query-migrate is done but before the async job closes qemu monitor while stopping the domain, the other thread needs to wake up and call qemuMonitorSend to send its command to qemu. Before qemu gets a chance to respond to this command, the async job needs to close the monitor. At this point, the query job thread is waiting for a condition that no-one will ever signal so it never finishes the job. --- src/qemu/qemu_monitor.c | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 4141fb7..35648ae 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -750,6 +750,20 @@ void qemuMonitorClose(qemuMonitorPtr mon) VIR_FORCE_CLOSE(mon->fd); } + /* In case another thread is waiting for its monitor command to be + * processed, we need to wake it up with appropriate error set. + */ + if (mon->msg) { + if (mon->lastError.code == VIR_ERR_OK) { + qemuReportError(VIR_ERR_OPERATION_FAILED, + _("Qemu monitor was closed")); + virCopyLastError(&mon->lastError); + virResetLastError(); + } + mon->msg->finished = 1; + virCondSignal(&mon->notify); + } + if (qemuMonitorUnref(mon) > 0) qemuMonitorUnlock(mon); } -- 1.7.8

2 2

[libvirt] FW: macvtap not working on rhel 6.1 x86 machine
by Amit Tewari 15 Dec '11

15 Dec '11

Hi all, My test environment Host os=rhel6.1 x86 machine Guest os = rhel6.1 Libvirt=0.8.7 Kvm hypervisor I am creating macvtap interface on host machine ip link add link eth1 name macvtap0 type macvtap ip link set macvtap0 up ip link show macvtap0 25: macvtap0@eth1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UNKNOWN qlen 500 link/ether a2:70:4e:05:4a:4e brd ff:ff:ff:ff:ff:ff Now when use arp -a to check macvtap0 hardware address entry it shows ? (10.0.7.1) at <incomplete> on macvtap0 If I assign ip address to macvtap and then ping on network , it says "destination not reachable" ping 10.0.7.1 -I macvtap0 PING 10.0.7.1 (10.0.7.1) from 10.0.1.61 macvtap0: 56(84) bytes of data. >From 10.0.1.61 icmp_seq=2 Destination Host Unreachable >From 10.0.1.61 icmp_seq=3 Destination Host Unreachable If I use tcpdump -I eth1 it shows packets 14:42:39.967158 ARP, Request who-has 10.0.7.1 tell 10.0.7.4, length 28 14:42:39.967257 ARP, Reply 10.0.7.1 is-at 00:16:35:65:b5:1e (oui Unknown), length 46 14:42:40.967167 ARP, Request who-has 10.0.7.1 tell 10.0.7.4, length 28 14:42:40.967229 ARP, Reply 10.0.7.1 is-at 00:16:35:65:b5:1e (oui Unknown), length 46 So macvtap0 is unknown interface. Request does go to eth1 inteface. Please let me know redhat 6.1 support macvtap or not?... I have to use it for kvm virtual machine.. DISCLAIMER: ----------------------------------------------------------------------------------------------------------------------- The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. It shall not attach any liability on the originator or NECHCL or its affiliates. Any views or opinions presented in this email are solely those of the author and may not necessarily reflect the opinions of NECHCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of the author of this e-mail is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. . -----------------------------------------------------------------------------------------------------------------------

2 1

[libvirt] [PATCH 0/4] Add new public API virDomainGetPcpusUsage and pcpuinfo command in virsh
by Lai Jiangshan 15 Dec '11

15 Dec '11

"virt-top -1" can call virDomainGetPcpusUsage() periodically and get the CPU activities per CPU. (still require virt-top site patch). virsh is also added a pcpuinfo command which calls virDomainGetPcpusUsage(), it gets information about the physic CPUs, such as the usage of CPUs, the current attached vCPUs. # virsh pcpuinfo rhel6 CPU: 0 Curr VCPU: - Usage: 47.3 CPU: 1 Curr VCPU: 1 Usage: 46.8 CPU: 2 Curr VCPU: 0 Usage: 52.7 CPU: 3 Curr VCPU: - Usage: 44.1 Lai Jiangshan (4): Add new public API virDomainGetPcpusUsage remote: support new API virDomainGetPcpusUsage for remote driver qemu: implemnt new API virDomainGetPcpusUsage for qemu driver Enable the pcpuinfo command in virsh daemon/remote.c | 68 ++++++++++++++++++++++++++++++ include/libvirt/libvirt.h.in | 5 ++ python/generator.py | 1 + src/driver.h | 7 +++ src/libvirt.c | 51 +++++++++++++++++++++++ src/libvirt_public.syms | 5 ++ src/qemu/qemu.conf | 5 +- src/qemu/qemu_conf.c | 3 +- src/qemu/qemu_driver.c | 74 +++++++++++++++++++++++++++++++++ src/remote/remote_driver.c | 51 +++++++++++++++++++++++ src/remote/remote_protocol.x | 17 +++++++- src/remote_protocol-structs | 13 ++++++ src/util/cgroup.c | 7 +++ src/util/cgroup.h | 1 + tools/virsh.c | 93 ++++++++++++++++++++++++++++++++++++++++++ tools/virsh.pod | 5 ++ 16 files changed, 402 insertions(+), 4 deletions(-) -- 1.7.4.4

2 7

Re: [libvirt] macvtap nt working on kvm
by Amit Tewari 15 Dec '11

15 Dec '11

Hi Stefan, May be you can try again this test of macvtap on your environment, but please remove the bridge from eth0. because macvtap doesent work with bridge setup. -----Original Message----- From: Amit Tewari Sent: Thursday, December 15, 2011 9:05 AM To: 'Laine Stump'; libvir-list(a)redhat.com Subject: RE: [libvirt] macvtap nt working on kvm Hi, Actually macvatap doesn't work with bridge. So once the physical device is attached to a bridge, a macvtap attached to that device no longer works. In my case there is no bridge on the interface. but still guest os is not able to get ip address. Is there no support for macvtap on red hat 6.1 x_86 platforms? -----Original Message----- From: libvir-list-bounces(a)redhat.com [mailto:libvir-list-bounces@redhat.com] On Behalf Of Laine Stump Sent: Thursday, December 15, 2011 2:31 AM To: libvir-list(a)redhat.com Subject: Re: [libvirt] macvtap nt working on kvm On 12/14/2011 02:26 PM, Stefan Berger wrote: > On 12/14/2011 07:40 AM, Amit Tewari wrote: >> >> Hi all, >> >> My test environment >> >> Host os=rhel6.1 >> >> Guest os = rhel6.1 >> >> Libvirt=0.8.7 >> >> Kvm hypervisor >> >> I have made this entry in guest xml file >> >> <interface type='direct'> >> >> <source dev='eth0' mode='bridge'/> >> >> <model type='virtio'/> >> >> <address type='pci' domain='0x0000' bus='0x00' slot='0x03' >> function='0x0'/> >> >> </interface> >> >> Now when I start the guest >> >> *#virsh start guest* >> >> Following macvtap0 is created on host and is shown below >> >> #*ip link show macvtap0* >> >> 51: macvtap0@eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc >> mq state UNKNOWN qlen 500 >> >> link/ether 52:54:00:55:AE:B5brd ff:ff:ff:ff:ff:ff >> >> but when the guest is up and I try to perform >> >> ** >> >> *# ifup eth0* >> >> *eth0 has same mac address as that of macvatap0 that is >> 52:54:00:55:AE:B5* >> >> ** >> >> *due to this guest is not able to get dhcp address nor static ip >> address is working*. >> >> Please let me know how macvtap work on kvm. >> > > I have tried your setup on my machine with the following host > configuration: > > # brctl show > bridge name bridge id STP enabled interfaces > br0 8000.001a64d00016 no eth0 > virbr0 8000.000000000000 yes > > If I use the configuration as you have shown it doesn't work for me, > either. However, if I use > > <source dev='br0' mode='bridge'/> > > then it works as expected. Do you happen to have a similar > configuration on the host with the interface the macvtap device wants > to use as 'source' being bridged? Interesting. So you're saying that once the physical device is attached to a bridge, a macvtap attached to that device no longer works? That's useful to know :-) -- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list DISCLAIMER: ----------------------------------------------------------------------------------------------------------------------- The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. It shall not attach any liability on the originator or NECHCL or its affiliates. Any views or opinions presented in this email are solely those of the author and may not necessarily reflect the opinions of NECHCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of the author of this e-mail is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. . -----------------------------------------------------------------------------------------------------------------------

1 0

Re: [libvirt] macvtap nt working on kvm
by Amit Tewari 15 Dec '11

15 Dec '11

Hi, Actually macvatap doesn't work with bridge. So once the physical device is attached to a bridge, a macvtap attached to that device no longer works. In my case there is no bridge on the interface. but still guest os is not able to get ip address. Is there no support for macvtap on red hat 6.1 x_86 platforms? -----Original Message----- From: libvir-list-bounces(a)redhat.com [mailto:libvir-list-bounces@redhat.com] On Behalf Of Laine Stump Sent: Thursday, December 15, 2011 2:31 AM To: libvir-list(a)redhat.com Subject: Re: [libvirt] macvtap nt working on kvm On 12/14/2011 02:26 PM, Stefan Berger wrote: > On 12/14/2011 07:40 AM, Amit Tewari wrote: >> >> Hi all, >> >> My test environment >> >> Host os=rhel6.1 >> >> Guest os = rhel6.1 >> >> Libvirt=0.8.7 >> >> Kvm hypervisor >> >> I have made this entry in guest xml file >> >> <interface type='direct'> >> >> <source dev='eth0' mode='bridge'/> >> >> <model type='virtio'/> >> >> <address type='pci' domain='0x0000' bus='0x00' slot='0x03' >> function='0x0'/> >> >> </interface> >> >> Now when I start the guest >> >> *#virsh start guest* >> >> Following macvtap0 is created on host and is shown below >> >> #*ip link show macvtap0* >> >> 51: macvtap0@eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc >> mq state UNKNOWN qlen 500 >> >> link/ether 52:54:00:55:AE:B5brd ff:ff:ff:ff:ff:ff >> >> but when the guest is up and I try to perform >> >> ** >> >> *# ifup eth0* >> >> *eth0 has same mac address as that of macvatap0 that is >> 52:54:00:55:AE:B5* >> >> ** >> >> *due to this guest is not able to get dhcp address nor static ip >> address is working*. >> >> Please let me know how macvtap work on kvm. >> > > I have tried your setup on my machine with the following host > configuration: > > # brctl show > bridge name bridge id STP enabled interfaces > br0 8000.001a64d00016 no eth0 > virbr0 8000.000000000000 yes > > If I use the configuration as you have shown it doesn't work for me, > either. However, if I use > > <source dev='br0' mode='bridge'/> > > then it works as expected. Do you happen to have a similar > configuration on the host with the interface the macvtap device wants > to use as 'source' being bridged? Interesting. So you're saying that once the physical device is attached to a bridge, a macvtap attached to that device no longer works? That's useful to know :-) -- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list DISCLAIMER: ----------------------------------------------------------------------------------------------------------------------- The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. It shall not attach any liability on the originator or NECHCL or its affiliates. Any views or opinions presented in this email are solely those of the author and may not necessarily reflect the opinions of NECHCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of the author of this e-mail is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. . -----------------------------------------------------------------------------------------------------------------------

1 0

[libvirt] [PATCH RESEND] qemu: Do not free the device from activePciHostdevs if it's in use
by Osier Yang 15 Dec '11

15 Dec '11

* src/qemu/qemu_hostdev.c (qemuDomainReAttachHostdevDevices): pciDeviceListFree(pcidevs) in the end free()s the device even if it's in use by other domain, which can cause rase. How to reproduce: <script> virsh nodedev-dettach pci_0000_00_19_0 virsh start test virsh attach-device test hostdev.xml virsh start test2 for i in {1..5}; do echo "[ -- ${i}th time --]" virsh nodedev-reattach pci_0000_00_19_0 done echo "clean up" virsh destroy test virsh nodedev-reattach pci_0000_00_19_0 </script> Device pci_0000_00_19_0 dettached Domain test started Device attached successfully error: Failed to start domain test2 error: Requested operation is not valid: PCI device 0000:00:19.0 is in use by domain test [ -- 1th time --] Device pci_0000_00_19_0 re-attached [ -- 2th time --] Device pci_0000_00_19_0 re-attached [ -- 3th time --] Device pci_0000_00_19_0 re-attached [ -- 4th time --] Device pci_0000_00_19_0 re-attached [ -- 5th time --] Device pci_0000_00_19_0 re-attached clean up Domain test destroyed Device pci_0000_00_19_0 re-attached The patch also fixes another problem, there won't be error like "qemuDomainReAttachHostdevDevices: Not reattaching active device 0000:00:19.0" in daemon log if some device is in active. As pciResetDevice and pciReattachDevice won't be called for the device anymore. This is sensiable as we already reported error when preparing the device if it's active. Blindly trying to pciResetDevice & pciReattachDevice on the device and getting an error is just redundant. --- src/qemu/qemu_hostdev.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index 9137388..60401f0 100644 --- a/src/qemu/qemu_hostdev.c +++ b/src/qemu/qemu_hostdev.c @@ -414,8 +414,10 @@ void qemuDomainReAttachHostdevDevices(struct qemud_driver *driver, */ activeDev = pciDeviceListFind(driver->activePciHostdevs, dev); if (activeDev && - STRNEQ_NULLABLE(name, pciDeviceGetUsedBy(activeDev))) + STRNEQ_NULLABLE(name, pciDeviceGetUsedBy(activeDev))) { + pciDeviceListSteal(pcidevs, dev); continue; + } /* pciDeviceListFree() will take care of freeing the dev. */ pciDeviceListSteal(driver->activePciHostdevs, dev); -- 1.7.7.3

2 2

[libvirt] [PATCH RESEND] qemu: Honor the original properties of PCI device when detaching
by Osier Yang 15 Dec '11

15 Dec '11

This patch fixes two problems: 1) The device will be reattached to host even if it's not managed, as there is a "pciDeviceSetManaged". 2) The device won't be reattached to host with original driver properly. As it doesn't honor the device original properties which are maintained by driver->activePciHostdevs. --- src/qemu/qemu_hotplug.c | 17 +++++++++-------- 1 files changed, 9 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 96c0070..19e4a41 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -1960,6 +1960,7 @@ int qemuDomainDetachHostPciDevice(struct qemud_driver *driver, qemuDomainObjPrivatePtr priv = vm->privateData; int i, ret; pciDevice *pci; + pciDevice *activePci; for (i = 0 ; i < vm->def->nhostdevs ; i++) { if (vm->def->hostdevs[i]->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS || @@ -2019,16 +2020,16 @@ int qemuDomainDetachHostPciDevice(struct qemud_driver *driver, detach->source.subsys.u.pci.bus, detach->source.subsys.u.pci.slot, detach->source.subsys.u.pci.function); - if (!pci) - ret = -1; - else { - pciDeviceSetManaged(pci, detach->managed); - pciDeviceListDel(driver->activePciHostdevs, pci); - if (pciResetDevice(pci, driver->activePciHostdevs, NULL) < 0) + if (pci) { + activePci = pciDeviceListSteal(driver->activePciHostdevs, pci); + if (pciResetDevice(activePci, driver->activePciHostdevs, NULL)) + qemuReattachPciDevice(activePci, driver); + else ret = -1; - pciDeviceReAttachInit(pci); - qemuReattachPciDevice(pci, driver); pciFreeDevice(pci); + pciFreeDevice(activePci); + } else { + ret = -1; } if (qemuCapsGet(priv->qemuCaps, QEMU_CAPS_DEVICE) && -- 1.7.7.3

2 2

[libvirt] [PATCH 0/4] Add support for QEMU guest agent control
by Daniel P. Berrange 15 Dec '11

15 Dec '11

The QEMU guest agent "/usr/bin/qemu-ga" has some handy functions for controlling the guest, not least, shutdown/reboot and filesystem freeze/thaw. In Fedora 15/16 the semantics of the ACPI power button have been changed to suspend-to-RAM which breaks our current shutdown implementation. By adding support for the agent we gain a more predictable way to shutdown / reboot guests. NB: the code currently has the same "flaw" as the monitor, in so much as we wait forever for a guest agent reply. We need to add a timeout ability to the agent code

3 17

[libvirt] macvtap nt working on kvm
by Amit Tewari 14 Dec '11

14 Dec '11

Hi all, My test environment Host os=rhel6.1 Guest os = rhel6.1 Libvirt=0.8.7 Kvm hypervisor I have made this entry in guest xml file <interface type='direct'> <source dev='eth0' mode='bridge'/> <model type='virtio'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> </interface> Now when I start the guest #virsh start guest Following macvtap0 is created on host and is shown below #ip link show macvtap0 51: macvtap0@eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UNKNOWN qlen 500 link/ether 52:54:00:55:AE:B5brd ff:ff:ff:ff:ff:ff but when the guest is up and I try to perform # ifup eth0 eth0 has same mac address as that of macvatap0 that is 52:54:00:55:AE:B5 due to this guest is not able to get dhcp address nor static ip address is working. Please let me know how macvtap work on kvm. DISCLAIMER: ----------------------------------------------------------------------------------------------------------------------- The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. It shall not attach any liability on the originator or NECHCL or its affiliates. Any views or opinions presented in this email are solely those of the author and may not necessarily reflect the opinions of NECHCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of the author of this e-mail is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. . -----------------------------------------------------------------------------------------------------------------------

3 3

Re: [libvirt] libvirt support on QNX
by Chandrashekhar Jamadarkhani (cjamadar) 14 Dec '11

14 Dec '11

Config.h file is missing in qnx. What is the path to config.h in linux ? Build Error (pasted here for one file only) src/util/iptables.c:22:20: error: config.h: No such file or directory Thanks, Chandrashekhar -----Original Message----- From: Chandrashekhar Jamadarkhani (cjamadar) Sent: Wednesday, December 14, 2011 3:24 PM To: 'Daniel P. Berrange' Subject: RE: libvirt support on QNX Thanks Daniel ! We are using Jamfile instead of Makefile in our build environment. Let me check how can I build the same in our build environment. Thanks, Chandarshekhar -----Original Message----- From: Daniel P. Berrange [mailto:berrange@redhat.com] Sent: Wednesday, December 14, 2011 2:56 PM To: Chandrashekhar Jamadarkhani (cjamadar) Subject: Re: libvirt support on QNX On Wed, Dec 14, 2011 at 02:50:31PM +0530, Chandrashekhar Jamadarkhani (cjamadar) wrote: > Thanks Daniel. I should port only src/rpc to QNX or anything else I need to port to QNX ? You basically want to build with ./configure \ --enable-compile-warnings=error \ --without-xen \ --without-qemu \ --without-openvz \ --without-lxc \ --without-vbox \ --without-xenapi \ --without-esx \ --without-uml \ --without-sasl \ --without-avahi \ --without-polkit \ --without-python \ --without-libvirtd \ --without-phyp \ --without-hyperv \ --without-netcf \ --without-audit \ --without-dtrace And then fix whatever fails to build (if anything). This should only be stuff in src/util src/conf src/rpc src/remote Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

2 1

[libvirt] [PATCH 0/3] spec file fixes
by Eric Blake 14 Dec '11

14 Dec '11

Several spec file patches that I've noticed by comparing against open BZs and existing RPMs. Probably all worth including in 0.9.8, but I'm not comfortable pushing them without a review. Eric Blake (3): spec: always autoreconf when building rpm spec: add dmidecode as prereq spec: fix sanlock dependency libvirt.spec.in | 30 +++++++++++++++++++++--------- 1 files changed, 21 insertions(+), 9 deletions(-) -- 1.7.7.3

5 25

[libvirt] [PATCH] python: Expose blockPeek and memoryPeek in Python binding
by Osier Yang 14 Dec '11

14 Dec '11

An simple example to show to use it: \#! /usr/bin/python import os import sys import libvirt disk = "/var/lib/libvirt/images/test.img" conn = libvirt.open(None) dom = conn.lookupByName('test') mem_contents = dom.memoryPeek(0, 128, libvirt.VIR_MEMORY_VIRTUAL); sys.stdout.write(mem_contents) % python test.py | hexdump 0000000 1660 0209 0000 0000 0000 0000 0000 0000 0000010 0000 0000 0000 0000 d3a0 01d0 0000 0000 0000020 --- python/generator.py | 1 + python/libvirt-override-api.xml | 17 +++++++++ python/libvirt-override.c | 75 +++++++++++++++++++++++++++++++++++++++ 3 files changed, 93 insertions(+), 0 deletions(-) diff --git a/python/generator.py b/python/generator.py index 88c52b9..1657f4f 100755 --- a/python/generator.py +++ b/python/generator.py @@ -262,6 +262,7 @@ py_types = { 'unsigned char *': ('z', None, "charPtr", "char *"), 'char *': ('z', None, "charPtr", "char *"), 'const char *': ('z', None, "charPtrConst", "const char *"), + 'size_t': ('n', None, "size_t", "size_t"), 'virDomainPtr': ('O', "virDomain", "virDomainPtr", "virDomainPtr"), 'const virDomainPtr': ('O', "virDomain", "virDomainPtr", "virDomainPtr"), diff --git a/python/libvirt-override-api.xml b/python/libvirt-override-api.xml index 7c18763..2e0c7cb 100644 --- a/python/libvirt-override-api.xml +++ b/python/libvirt-override-api.xml @@ -405,5 +405,22 @@ <arg name='flags' type='unsigned int' info='an OR'ed set of virDomainModificationImpact'/> <return type='int' info='0 in case of success, -1 in case of failure'/> </function> + <function name='virDomainBlockPeek' file='python'> + <info>Read the contents of domain's disk device</info> + <arg name='dom' type='virDomainPtr' info='pointer to the domain'/> + <arg name='disk' type='const char *' info='disk name'/> + <arg name='offset' type='unsigned long long' info='offset within block device'/> + <arg name='size' type='size_t' info='size to read'/> + <arg name='flags' type='unsigned int' info='unused, always passed 0'/> + <return type='char *' info='the returned buffer or None in case of error'/> + </function> + <function name='virDomainMemoryPeek' file='python'> + <info>Read the contents of domain's memory</info> + <arg name='dom' type='virDomainPtr' info='pointer to the domain'/> + <arg name='start' type='unsigned long long' info='start of memory to peek'/> + <arg name='size' type='size_t' info='size of memory to peek'/> + <arg name='flags' type='unsigned int' info='an OR'ed set of virDomainMemoryFlags'/> + <return type='char *' info='the returned buffer or None in case of error'/> + </function> </symbols> </api> diff --git a/python/libvirt-override.c b/python/libvirt-override.c index 9e98918..64d7943 100644 --- a/python/libvirt-override.c +++ b/python/libvirt-override.c @@ -5017,6 +5017,79 @@ libvirt_virDomainMigrateGetMaxSpeed(PyObject *self ATTRIBUTE_UNUSED, PyObject *a return(py_retval); } +static PyObject * +libvirt_virDomainBlockPeek(PyObject *self ATTRIBUTE_UNUSED, + PyObject *args) { + PyObject *py_retval = NULL; + int c_retval; + virDomainPtr domain; + PyObject *pyobj_domain; + const char *disk; + unsigned long long offset; + size_t size; + char *buf; + unsigned int flags; + + if (!PyArg_ParseTuple(args, (char *)"OzLni:virDomainBlockPeek", &pyobj_domain, + &disk, &offset, &size, &flags)) + return(NULL); + + domain = (virDomainPtr) PyvirDomain_Get(pyobj_domain); + + if ((buf = malloc(size)) == NULL) + return VIR_PY_NONE; + + LIBVIRT_BEGIN_ALLOW_THREADS; + c_retval = virDomainBlockPeek(domain, disk, offset, size, buf, flags); + LIBVIRT_END_ALLOW_THREADS; + + if (c_retval < 0) + goto cleanup; + + py_retval = PyString_FromStringAndSize(buf, size); + +cleanup: + memset(buf, 0, size); + free(buf); + return py_retval; +} + +static PyObject * +libvirt_virDomainMemoryPeek(PyObject *self ATTRIBUTE_UNUSED, + PyObject *args) { + PyObject *py_retval = NULL; + int c_retval; + virDomainPtr domain; + PyObject *pyobj_domain; + unsigned long long start; + size_t size; + char *buf; + unsigned int flags; + + if (!PyArg_ParseTuple(args, (char *)"OLni:virDomainMemoryPeek", &pyobj_domain, + &start, &size, &flags)) + return(NULL); + + domain = (virDomainPtr) PyvirDomain_Get(pyobj_domain); + + if ((buf = malloc(size)) == NULL) + return VIR_PY_NONE; + + LIBVIRT_BEGIN_ALLOW_THREADS; + c_retval = virDomainMemoryPeek(domain, start, size, buf, flags); + LIBVIRT_END_ALLOW_THREADS; + + if (c_retval < 0) + goto cleanup; + + py_retval = PyString_FromStringAndSize(buf, size); + +cleanup: + memset(buf, 0, size); + free(buf); + return py_retval; +} + /************************************************************************ * * * The registration stuff * @@ -5112,6 +5185,8 @@ static PyMethodDef libvirtMethods[] = { {(char *) "virDomainGetBlockIoTune", libvirt_virDomainGetBlockIoTune, METH_VARARGS, NULL}, {(char *) "virDomainSendKey", libvirt_virDomainSendKey, METH_VARARGS, NULL}, {(char *) "virDomainMigrateGetMaxSpeed", libvirt_virDomainMigrateGetMaxSpeed, METH_VARARGS, NULL}, + {(char *) "virDomainBlockPeek", libvirt_virDomainBlockPeek, METH_VARARGS, NULL}, + {(char *) "virDomainMemoryPeek", libvirt_virDomainMemoryPeek, METH_VARARGS, NULL}, {NULL, NULL, 0, NULL} }; -- 1.7.1

2 2

[libvirt] [PATCH] rpc: retry to call dup() if fcntl with CLOEXEC fails
by dongsu.park＠profitbricks.com 14 Dec '11

14 Dec '11

From: Dongsu Park <dongsu.park(a)profitbricks.com> If fcntl with F_DUPFD_CLOEXEC fails, we need to try again to use dup() to get the fd, instead of giving up right away. Signed-off-by: Dongsu Park <dongsu.park(a)profitbricks.com> Signed-off-by: Vasilis Liaskovitis <vasilis.liaskovitis(a)profitbricks.com> --- src/rpc/virnetsocket.c | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c index af4fc5e..25c7891 100644 --- a/src/rpc/virnetsocket.c +++ b/src/rpc/virnetsocket.c @@ -778,8 +778,15 @@ int virNetSocketDupFD(virNetSocketPtr sock, bool cloexec) { int fd; - if (cloexec) + if (cloexec) { fd = fcntl(sock->fd, F_DUPFD_CLOEXEC); + /* retry to use dup if fcntl fails */ + if (fd < 0) { + virReportSystemError(errno, "%s", + _("fcntl failed, reverting to dup")); + fd = dup(sock->fd); + } + } else fd = dup(sock->fd); if (fd < 0) { -- 1.7.7.2

2 1

[libvirt] Fwd: [MacPorts] #32523: libvirt: update to 0.9.8
by Justin Clift 14 Dec '11

14 Dec '11

Hi all, Just an FYI. Libvirt is now available through the Mac "MacPorts" package system, as well as HomeBrew. Hope that's useful. :) Regards and best wishes, Justin Clift Begin forwarded message: > From: MacPorts <noreply(a)macports.org> > Subject: Re: [MacPorts] #32523: libvirt: update to 0.9.8 > Date: 14 December 2011 3:39:10 PM AEDT > To: ryandesign(a)macports.org, jclift(a)redhat.com > Cc: macports-tickets(a)lists.macosforge.org > Reply-To: macports-dev(a)lists.macosforge.org > > #32523: libvirt: update to 0.9.8 > --------------------------------------+------------------------------------- > Reporter: ryandesign@… | Owner: jclift@… > Type: defect | Status: closed > Priority: Normal | Milestone: > Component: ports | Version: 2.0.3 > Resolution: fixed | Keywords: haspatch > Port: libvirt | > --------------------------------------+------------------------------------- > Changes (by ryandesign@…): > > * status: new => closed > * resolution: => fixed > > > Comment: > > r87956. > > -- > Ticket URL: <https://trac.macports.org/ticket/32523#comment:4> > MacPorts <http://www.macports.org/> > Ports system for Mac OS -- Aeolus Community Manager http://www.aeolusproject.org

1 0

Re: [libvirt] libvirt support on QNX
by Chandrashekhar Jamadarkhani (cjamadar) 14 Dec '11

14 Dec '11

In which dir the source code for libvirt RPC client driver located to port it to QNX ? Is it in libvirt-0.9.8/src/remote ? Thanks, Chandrashekhar Hi Daniel, Thanks Daniel for the info. I was talking only about porting libvirt RPC client driver to QNX for starting/monitoring VMs running on remote RHEL based host. Let me try porting the libvirt RPC client driver to QNX. Thanks, Chandrashekhar -----Original Message----- From: Daniel P. Berrange [mailto:berrange redhat com] Sent: Wednesday, November 16, 2011 4:07 PM To: Chandrashekhar Jamadarkhani (cjamadar) Cc: libvir-list redhat com Subject: Re: [libvirt] libvirt support on QNX On Wed, Nov 16, 2011 at 03:32:19PM +0530, Chandrashekhar Jamadarkhani (cjamadar) wrote: > Hi, > > > > I'm planning to use libvirt in a remote machine which is running on QNX > RTOS. Whether libvirt is ported to QNX, if not any problems in porting > libvirt lib to QNX ? AFAIK, no one has ever said they've tried libvirt on QNX. I presume you are talking about the libvirt RPC client driver only, or are you planning to create some kind of hypervisor driver too ? The libvirt RPC client driver is probably the most portable bit of our code, only depending on a good sockets layer implementation & GNUTLS. So if you pass flags to configure to disable all drivers, except for the remote driver, you should be able to build it without undue trouble. Regards, Daniel

2 1

[libvirt] [test-API][PATCH 1/2] Add support for spice graphics
by Nan Zhang 14 Dec '11

14 Dec '11

* utils/Python/xmlgenerator.py: This extends graphics element for spice XML composing, and support sub-elements settings for audio, images, streaming and so on: <graphics type='spice' autoport='yes'> <image compression='auto_glz'/> <jpeg compression='auto'/> <zlib compression='auto'/> <playback compression='on'/> <streaming mode='filter'/> <clipboard copypaste='no'/> </graphics> * utils/Python/xmlbuilder.py: Add 2 methods add_graphics() and build_graphics() to XmlBuilder class. --- utils/Python/xmlbuilder.py | 36 +++++++++++++++++++++++- utils/Python/xmlgenerator.py | 62 +++++++++++++++++++++++++++++++++++++---- 2 files changed, 91 insertions(+), 7 deletions(-) diff --git a/utils/Python/xmlbuilder.py b/utils/Python/xmlbuilder.py index 5a0f8c8..739eccb 100644 --- a/utils/Python/xmlbuilder.py +++ b/utils/Python/xmlbuilder.py @@ -64,6 +64,13 @@ class XmlBuilder: hostdev_node, domain.getElementsByTagName("console")[0]) return hostdev + def add_graphics(self, params, domain): + graphics = xmlgenerator.graphics_xml(params) + graphics_node = domain.importNode(graphics.childNodes[0], True) + domain.getElementsByTagName("devices")[0].insertBefore( + graphics_node, domain.getElementsByTagName("console")[0]) + return graphics + def build_domain_install(self, params): domain = xmlgenerator.domain_xml(params, True) self.add_disk(params, domain) @@ -151,6 +158,12 @@ class XmlBuilder: self.write_toxml(hostdev) return hostdev.toxml() + def build_graphics(self, params): + graphics = xmlgenerator.graphics_xml(params) + if __DEBUG__: + self.write_toxml(graphics) + return graphics.toxml() + def build_pool(self, params): pool = xmlgenerator.pool_xml(params) if __DEBUG__: @@ -242,6 +255,20 @@ if __name__ == "__main__": interfacexml = xmlobj.build_interface(params) + #-------------------------- + # get graphics xml string + #-------------------------- + print '=' * 30, 'graphics xml', '=' * 30 + params['graphtype'] = 'spice' + params['image'] = 'auto_glz' + params['jpeg'] = 'auto' + params['zlib'] = 'auto' + params['playback'] = 'on' + params['streaming'] = 'filter' + params['clipboard'] = 'no' + + graphicsxml = xmlobj.build_graphics(params) + #--------------------- # get pool xml string #--------------------- @@ -297,6 +324,13 @@ if __name__ == "__main__": params['memory'] = '1048576' params['vcpu'] = '2' params['inputbus'] = 'usb' + params['graphtype'] = 'spice' + params['image'] = 'auto_glz' + params['jpeg'] = 'auto' + params['zlib'] = 'auto' + params['playback'] = 'on' + params['streaming'] = 'filter' + params['clipboard'] = 'no' params['sound'] = 'ac97' params['bootcd'] = '/iso/rhel5.iso' @@ -367,7 +401,7 @@ if __name__ == "__main__": #---------------------------------------- # get domain snapshot xml string #---------------------------------------- - params['name'] = 'hello' + params['snapshotname'] = 'hello' params['description'] = 'hello snapshot' snapshot_xml = xmlobj.build_domain_snapshot(params) diff --git a/utils/Python/xmlgenerator.py b/utils/Python/xmlgenerator.py index d57dd33..460f2e5 100644 --- a/utils/Python/xmlgenerator.py +++ b/utils/Python/xmlgenerator.py @@ -233,12 +233,6 @@ def domain_xml(params, install = False): input_element.setAttribute('bus', 'ps2') devices_element.appendChild(input_element) - # <graphics> - graphics_element = domain.createElement('graphics') - graphics_element.setAttribute('type', 'vnc') - graphics_element.setAttribute('port', '-1') - graphics_element.setAttribute('keymap', 'en-us') - devices_element.appendChild(graphics_element) domain_element.appendChild(devices_element) # <sound> @@ -253,6 +247,62 @@ def domain_xml(params, install = False): return domain +def graphics_xml(params): + graphics = xml.dom.minidom.Document() + # <graphics> + graphics_element = graphics.createElement('graphics') + if not params.has_key('graphtype'): + params['graphtype'] == 'vnc' + + graphics_element.setAttribute('type', params['graphtype']) + graphics.appendChild(graphics_element) + + if params['graphtype'] == 'vnc': + graphics_element.setAttribute('port', '-1') + graphics_element.setAttribute('keymap', 'en-us') + elif params['graphtype'] == 'spice': + graphics_element.setAttribute('autoport', 'yes') + if params.has_key('image'): + image_element = graphics.createElement('image') + # image to set image compression (accepts + # auto_glz, auto_lz, quic, glz, lz, off) + image_element.setAttribute('compression', params['image']) + graphics_element.appendChild(image_element) + if params.has_key('jpeg'): + jpeg_element = graphics.createElement('jpeg') + # jpeg for JPEG compression for images over wan (accepts + # auto, never, always) + jpeg_element.setAttribute('compression', params['jpeg']) + graphics_element.appendChild(jpeg_element) + if params.has_key('zlib'): + zlib_element = graphics.createElement('zlib') + # zlib for configuring wan image compression (accepts + # auto, never, always) + zlib_element.setAttribute('compression', params['zlib']) + graphics_element.appendChild(zlib_element) + if params.has_key('playback'): + playback_element = graphics.createElement('playback') + # playback for enabling audio stream compression (accepts on or off) + playback_element.setAttribute('compression', params['playback']) + graphics_element.appendChild(playback_element) + if params.has_key('streaming'): + streaming_element = graphics.createElement('streaming') + # streamming for settings it's mode attribute to one of + # filter, all or off + streaming_element.setAttribute('mode', params['streaming']) + graphics_element.appendChild(streaming_element) + if params.has_key('clipboard'): + clipboard_element = graphics.createElement('clipboard') + # Copy & Paste functionality is enabled by default, and can + # be disabled by setting the copypaste property to no + clipboard_element.setAttribute('copypaste', params['clipboard']) + graphics_element.appendChild(clipboard_element) + else: + print 'Wrong graphics type was specified.' + sys.exit(1) + + return graphics + def disk_xml(params, cdrom = False): disk = xml.dom.minidom.Document() # <disk> -- START -- 1.7.4.4

2 4

[libvirt] [test-API][PATCH] Add test case set_cpu_shares.py for setting cpu scheduler info
by Nan Zhang 14 Dec '11

14 Dec '11

* repos/domain/set_cpu_shares.py: set the value of cpu_shares property of the guest. --- repos/domain/set_cpu_shares.py | 111 ++++++++++++++++++++++++++++++++++++++++ 1 files changed, 111 insertions(+), 0 deletions(-) create mode 100644 repos/domain/set_cpu_shares.py diff --git a/repos/domain/set_cpu_shares.py b/repos/domain/set_cpu_shares.py new file mode 100644 index 0000000..4560809 --- /dev/null +++ b/repos/domain/set_cpu_shares.py @@ -0,0 +1,111 @@ +#!/usr/bin/env python +"""Set the value of cpu_shares property of the guest + domain:set_cpu_shares + guestname + xxx + flags + 0|1|2 +""" + +__author__ = 'Nan Zhang: nzhang(a)redhat.com' +__date__ = 'Tue Sep 27, 2011' +__version__ = '0.1.0' +__credits__ = 'Copyright (C) 2011 Red Hat, Inc.' +__all__ = ['check_params', 'check_cpu_shares', 'set_cpu_shares'] + +import os +import re +import sys +import time +from xml.dom import minidom + + +def append_path(path): + """Append root path of package""" + if path in sys.path: + pass + else: + sys.path.append(path) + +pwd = os.getcwd() +result = re.search('(.*)libvirt-test-API', pwd) +append_path(result.group(0)) + +from lib import connectAPI +from lib import domainAPI +from utils.Python import utils +from utils.Python import xmlbuilder +from exception import LibvirtAPI + +def check_params(params): + """Verify inputing parameter dictionary""" + logger = params['logger'] + keys = ['guestname', 'flags'] + for key in keys: + if key not in params: + logger.error("%s is required" %key) + return 1 + return 0 + +def check_cpu_shares(params, util, guestname, cpu_shares): + """Check the value of cpu_shares""" + logger = params['logger'] + cmd = "cat /cgroup/cpu/libvirt/qemu/%s/cpu.shares" % guestname + ret, out = util.exec_cmd(cmd, shell=True) + if ret: + logger.error("fail to set the value of cpu_shares: %s" % out[0]) + return 0 + else: + logger.info("from cgroup, the value of cpu_shares is %s" % out[0]) + + if cmp(int(out[0]), cpu_shares): + return 1 + else: + logger.info("the value of cpu_shares does match the original \ +cpu scheduler information.") + return 0 + +def set_cpu_shares(params): + """Get the cpu scheduler information""" + # Initiate and check parameters + params_check_result = check_params(params) + if params_check_result: + return 1 + logger = params['logger'] + guestname = params['guestname'] + flags = params['flags'] + schedinfo = {} + schedinfo['cpu_shares'] = 2048 + cpu_shares = schedinfo['cpu_shares'] + + # Connect to local hypervisor connection URI + util = utils.Utils() + uri = util.get_uri('127.0.0.1') + conn = connectAPI.ConnectAPI() + virconn = conn.open(uri) + + caps = conn.get_caps() + logger.debug(caps) + + domobj = domainAPI.DomainAPI(virconn) + try: + domobj.set_sched_params_flags(guestname, schedinfo, int(flags)) + logger.debug("set the value of cpu_shares with %s" % cpu_shares) + except LibvirtAPI, e: + logger.error("API error message: %s, error code is %s" % + (e.response()['message'], e.response()['code'])) + return 1 + + check_result = check_cpu_shares(params, util, guestname, cpu_shares) + if check_result: + logger.error("cpu_shares does not match.") + conn.close() + return 1 + + logger.info("success to set scheduler parameters.") + conn.close() + return 0 + +def set_cpu_shares_clean(): + """Clean testing environment""" + pass -- 1.7.4.4

4 8

Re: [libvirt] macvtap not working on kvm
by Amit Tewari 14 Dec '11

14 Dec '11

Hi all, In same previous scenario of macvtap ,Im not able to assign dhcp address to guest interface, and if I assign static ip of my lan to guest interface , than also it is not able to connect to the network.. ________________________________ From: libvir-list-bounces(a)redhat.com [mailto:libvir-list-bounces@redhat.com] On Behalf Of Amit Tewari Sent: Tuesday, December 13, 2011 5:11 PM To: xhu Cc: libvir-list(a)redhat.com Subject: Re: [libvirt] macvtap not working on kvm Hi, Actually udev renames the eth0 interface in guest to eth1 because macvtap0 has different mac address then eth0 on host.. Is there some way so that we can prevent changing this rename of eth0 to eth1 on guest. I don't want to change udev files. ________________________________ From: xhu [mailto:xhu@redhat.com] Sent: Tuesday, December 13, 2011 3:01 PM To: Amit Tewari Cc: libvir-list(a)redhat.com Subject: Re: [libvirt] macvtap not working on kvm On 12/13/2011 12:59 PM, Amit Tewari wrote: Hi all, My test environment Host os=rhel6.1 Guest os = rhel6.1 Libvirt=0.9.8 Kvm hypervisor I have made this entry in guest xml file <interface type='direct'> <source dev='eth0' mode='bridge'/> <model type='virtio'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> </interface> Now when I start the guest #virsh start guest Following macvtap0 is created on host and is shown below #ip link show macvtap0 51: macvtap0@eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UNKNOWN qlen 500 link/ether 52:54:00:55:AE:B5brd ff:ff:ff:ff:ff:ff but when the guest is up and I try to perform # ifup eth0 It gives following message "Bringing up interface eth0: Device eth0 does not seem to be present, delaying initialization. [FAILED]" The interface name may change to ethN(N may be 1 or 2 ...) due to the change of guest interface mac address. You can log in guest and use command: "ip link show" to get the value of N. Then create ifcfg-ethN for it and use "ifup ethN" to start it in guest. Guest eth interface does not create. What is the problem? When I checked dmesg on host it gives following message-"macvatp0: ipv6 routers not present" Please let me know how macvtap work on kvm. DISCLAIMER: ------------------------------------------------------------------------ ----------------------------------------------- The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. It shall not attach any liability on the originator or NECHCL or its affiliates. Any views or opinions presented in this email are solely those of the author and may not necessarily reflect the opinions of NECHCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of the author of this e-mail is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. . ------------------------------------------------------------------------ ----------------------------------------------- -- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list DISCLAIMER: ------------------------------------------------------------------------ ----------------------------------------------- The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. It shall not attach any liability on the originator or NECHCL or its affiliates. Any views or opinions presented in this email are solely those of the author and may not necessarily reflect the opinions of NECHCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of the author of this e-mail is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. . ------------------------------------------------------------------------ ----------------------------------------------- DISCLAIMER: ----------------------------------------------------------------------------------------------------------------------- The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. It shall not attach any liability on the originator or NECHCL or its affiliates. Any views or opinions presented in this email are solely those of the author and may not necessarily reflect the opinions of NECHCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of the author of this e-mail is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. . -----------------------------------------------------------------------------------------------------------------------

1 0

[libvirt] [PATCH] python: Expose memoryPeek to Python binding
by Osier Yang 14 Dec '11

14 Dec '11

--- python/libvirt-override-api.xml | 8 ++++++++ python/libvirt-override.c | 33 +++++++++++++++++++++++++++++++++ 2 files changed, 41 insertions(+), 0 deletions(-) diff --git a/python/libvirt-override-api.xml b/python/libvirt-override-api.xml index 87db67b..2e0c7cb 100644 --- a/python/libvirt-override-api.xml +++ b/python/libvirt-override-api.xml @@ -414,5 +414,13 @@ <arg name='flags' type='unsigned int' info='unused, always passed 0'/> <return type='char *' info='the returned buffer or None in case of error'/> </function> + <function name='virDomainMemoryPeek' file='python'> + <info>Read the contents of domain's memory</info> + <arg name='dom' type='virDomainPtr' info='pointer to the domain'/> + <arg name='start' type='unsigned long long' info='start of memory to peek'/> + <arg name='size' type='size_t' info='size of memory to peek'/> + <arg name='flags' type='unsigned int' info='an OR'ed set of virDomainMemoryFlags'/> + <return type='char *' info='the returned buffer or None in case of error'/> + </function> </symbols> </api> diff --git a/python/libvirt-override.c b/python/libvirt-override.c index 4839e08..032cc47 100644 --- a/python/libvirt-override.c +++ b/python/libvirt-override.c @@ -5051,6 +5051,38 @@ libvirt_virDomainBlockPeek(PyObject *self ATTRIBUTE_UNUSED, return py_retval; } +static PyObject * +libvirt_virDomainMemoryPeek(PyObject *self ATTRIBUTE_UNUSED, + PyObject *args) { + PyObject *py_retval; + int c_retval; + virDomainPtr domain; + PyObject *pyobj_domain; + unsigned long long start; + size_t size; + char *buf; + unsigned int flags; + + if (!PyArg_ParseTuple(args, (char *)"OLni:virDomainMemoryPeek", &pyobj_domain, + &start, &size, &flags)) + return(NULL); + + domain = (virDomainPtr) PyvirDomain_Get(pyobj_domain); + + if ((buf = malloc(size)) == NULL) + return VIR_PY_NONE; + + LIBVIRT_BEGIN_ALLOW_THREADS; + c_retval = virDomainMemoryPeek(domain, start, size, buf, flags); + LIBVIRT_END_ALLOW_THREADS; + + if (c_retval < 0) + return VIR_PY_NONE; + + py_retval = libvirt_charPtrWrap(buf); + return py_retval; +} + /************************************************************************ * * * The registration stuff * @@ -5147,6 +5179,7 @@ static PyMethodDef libvirtMethods[] = { {(char *) "virDomainSendKey", libvirt_virDomainSendKey, METH_VARARGS, NULL}, {(char *) "virDomainMigrateGetMaxSpeed", libvirt_virDomainMigrateGetMaxSpeed, METH_VARARGS, NULL}, {(char *) "virDomainBlockPeek", libvirt_virDomainBlockPeek, METH_VARARGS, NULL}, + {(char *) "virDomainMemoryPeek", libvirt_virDomainMemoryPeek, METH_VARARGS, NULL}, {NULL, NULL, 0, NULL} }; -- 1.7.1

2 2

[libvirt] [PATCH 0/2] virsh: allow to specify pci address with attach-interface
by KAMEZAWA Hiroyuki 14 Dec '11

14 Dec '11

Now, at using attach-interface, pci address of the device is determined automatically. This is nice. But in some situation, users may want to specify pci address by hand. For example, when users want to use multifunction pci device, he need to specify pci slot. This patch allows to specify pci address with attach-interface. Then, this kind of script can run to assign multiple nics in a slot. == #!/bin/bash -x DOM=$1 SLOT=$2 NUM=$3 for i in `seq 0 $NUM`; do virsh attach-interface --domain $DOM --type='network' --source=default\ --persistent --model=virtio --address=pci:0000:00:$SLOT:0$i --multifunction; done == Because I moved placement of some functions in virsh.c, diffstat seems big... virsh.c | 948 ++++++++++++++++++++++++++++++++------------------------------ virsh.pod | 4 2 files changed, 495 insertions(+), 457 deletions(-) Thanks, -Kame

1 2

[libvirt] [PATCH] virsh: support multifunction in attach-disk
by KAMEZAWA Hiroyuki 14 Dec '11

14 Dec '11

From: KAMEZAWA Hiroyuki <kamezawa.hiroyu(a)jp.fujitsu.com> PCI <address...> can be specified by attach-disk but multifunction cannot be specified. add --multifunction support. --- tools/virsh.c | 7 ++++++- tools/virsh.pod | 3 ++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index d58b827..346b440 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -12661,6 +12661,7 @@ static const vshCmdOptDef opts_attach_disk[] = { {"serial", VSH_OT_STRING, 0, N_("serial of disk device")}, {"shareable", VSH_OT_BOOL, 0, N_("shareable between domains")}, {"address", VSH_OT_STRING, 0, N_("address of disk device")}, + {"multifunction", VSH_OT_BOOL, 0, N_("use multifunction pci under specified address")}, {NULL, 0, 0, NULL} }; @@ -12916,9 +12917,13 @@ cmdAttachDisk(vshControl *ctl, const vshCmd *cmd) if (diskAddr.type == DISK_ADDR_TYPE_PCI) { virBufferAsprintf(&buf, " <address type='pci' domain='0x%04x'" - " bus ='0x%02x' slot='0x%02x' function='0x%0x' />\n", + " bus ='0x%02x' slot='0x%02x' function='0x%0x'", diskAddr.addr.pci.domain, diskAddr.addr.pci.bus, diskAddr.addr.pci.slot, diskAddr.addr.pci.function); + if (vshCommandOptBool(cmd, "multifunction")) + virBufferAsprintf(&buf, " multifunction='on' />\n"); + else + virBufferAsprintf(&buf, " />\n"); } else { vshError(ctl, "%s", _("expecting a pci:0000.00.00.00 address.")); goto cleanup; diff --git a/tools/virsh.pod b/tools/virsh.pod index fe92714..1a778f9 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -1273,7 +1273,7 @@ the device does not use managed mode. =item B<attach-disk> I<domain-id> I<source> I<target> [I<--driver driver>] [I<--subdriver subdriver>] [I<--cache cache>] [I<--type type>] [I<--mode mode>] [I<--persistent>] [I<--sourcetype soucetype>] -[I<--serial serial>] [I<--shareable>] [I<--address address>] +[I<--serial serial>] [I<--shareable>] [I<--address address>] [I<--multifunction>] Attach a new disk device to the domain. I<source> and I<target> are paths for the files and devices. @@ -1291,6 +1291,7 @@ I<serial> is the serial of disk device. I<shareable> indicates the disk device is shareable between domains. I<address> is the address of disk device in the form of pci:domain.bus.slot.function, scsi:controller.bus.unit or ide:controller.bus.unit. +I<multifunction> indicates specified pci address is a multifunction pci device address. =item B<attach-interface> I<domain-id> I<type> I<source> [I<--target target>] [I<--mac mac>] [I<--script script>] [I<--model model>] -- 1.7.4.1

3 5

[libvirt] [PATCH v3] virsh: Add option to undefine storage with domains
by Peter Krempa 14 Dec '11

14 Dec '11

Add an option for virsh undefine command, to remove associated storage volumes while undefining a domain. This patch alows the user to remove associated (libvirt managed ) storage volumes while undefining a domain. The new option --storage for the undefine command takes a string argument that consists of comma separated list of target or source path of volumes to be undefined. Volumes are removed after the domain has been successfuly undefined, If a volume is not part of a storage pool, the user is warned to remove the volume in question himself. Option --wipe-storage may be specified along with this, that ensures the image is wiped before removing. Option --remove-all-storage enables the user to remove all storage. The name is chosen long as the users shoudl be aware what they're about to do. --- Changes to v2 based on reveiw by Eric: ( http://www.redhat.com/archives/libvir-list/2011-September/msg00481.html ) - First undefine the domain, then undefine volumes - Add option to remove all volumes - Fix typos and strange wordings - Change retur value to failure if some operations on volumes fail. tools/virsh.c | 143 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ tools/virsh.pod | 18 +++++++ 2 files changed, 161 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index d58b827..281ffa9 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -1924,6 +1924,13 @@ static const vshCmdInfo info_undefine[] = { static const vshCmdOptDef opts_undefine[] = { {"domain", VSH_OT_DATA, VSH_OFLAG_REQ, N_("domain name or uuid")}, {"managed-save", VSH_OT_BOOL, 0, N_("remove domain managed state file")}, + {"storage", VSH_OT_DATA, VSH_OFLAG_NONE, + N_("remove associated storage volumes (comma separated list of targets " + "or source paths) (see domblklist)")}, + {"remove-all-storage", VSH_OT_BOOL, 0, + N_("remove all associated storage volumes (use with caution)")}, + {"wipe-storage", VSH_OT_BOOL, VSH_OFLAG_NONE, + N_("wipe data on the removed volumes")}, {"snapshots-metadata", VSH_OT_BOOL, 0, N_("remove all domain snapshot metadata, if inactive")}, {NULL, 0, 0, NULL} @@ -1940,6 +1947,9 @@ cmdUndefine(vshControl *ctl, const vshCmd *cmd) /* User-requested actions. */ bool managed_save = vshCommandOptBool(cmd, "managed-save"); bool snapshots_metadata = vshCommandOptBool(cmd, "snapshots-metadata"); + bool wipe_storage = vshCommandOptBool(cmd, "wipe-storage"); + bool remove_storage = false; + bool remove_all_storage = vshCommandOptBool(cmd, "remove-all-storage"); /* Positive if these items exist. */ int has_managed_save = 0; int has_snapshots_metadata = 0; @@ -1949,6 +1959,22 @@ cmdUndefine(vshControl *ctl, const vshCmd *cmd) bool snapshots_safe = false; int rc = -1; int running; + /* list of volumes to remove along with this domain */ + char *volumes = NULL; + const char *volume; + char *saveptr = NULL; + char *def = NULL; + char *source = NULL; + char *target = NULL; + int i; + + xmlNodePtr *vol_nodes = NULL; + int nvolumes = 0; + xmlXPathContextPtr ctxt = NULL; + xmlDocPtr doc = NULL; + virStorageVolPtr vol = NULL; + bool vol_del_failed = false; + if (managed_save) { flags |= VIR_DOMAIN_UNDEFINE_MANAGED_SAVE; @@ -1965,6 +1991,18 @@ cmdUndefine(vshControl *ctl, const vshCmd *cmd) if (!(dom = vshCommandOptDomain(ctl, cmd, &name))) return false; + /* check if a string that should contain list of volumes to remove is present */ + if (vshCommandOptString(cmd, "storage", (const char **)&volumes) > 0) { + /* caution volumes has to be re-assigned as it would be doulbe freed */ + volumes = vshStrdup(ctl, volumes); + + if (remove_all_storage) { + vshError(ctl, _("Specified both --storage and --remove-all-storage")); + goto cleanup; + } + remove_storage = true; + } + /* Do some flag manipulation. The goal here is to disable bits * from flags to reduce the likelihood of a server rejecting * unknown flag bits, as well as to track conditions which are @@ -2027,6 +2065,20 @@ cmdUndefine(vshControl *ctl, const vshCmd *cmd) snapshots_safe = true; } + /* Stash domain description for later use */ + if (remove_storage || remove_all_storage) { + if (running) { + vshError(ctl, _("Storage volume deletion is supported only on stopped domains")); + goto cleanup; + } + + if (!(def = virDomainGetXMLDesc(dom, 0))) { + vshError(ctl, _("Could not retrieve domain XML description")); + goto cleanup; + } + } + + /* Generally we want to try the new API first. However, while * virDomainUndefineFlags was introduced at the same time as * VIR_DOMAIN_UNDEFINE_MANAGED_SAVE in 0.9.4, the @@ -2076,9 +2128,100 @@ out: ret = true; } else { vshError(ctl, _("Failed to undefine domain %s"), name); + goto cleanup; + } + + /* try to undefine storage volumes associated with this domain, if it's requested */ + if (remove_storage || remove_all_storage) { + ret = false; + doc = virXMLParseStringCtxt(def, _("(domain_definition)"), &ctxt); + if (!doc) + goto cleanup; + + nvolumes = virXPathNodeSet("./devices/disk", ctxt, &vol_nodes); + + if (nvolumes < 0) + goto cleanup; + + for (i = 0; i < nvolumes; i++) { + ctxt->node = vol_nodes[i]; + VIR_FREE(target); + VIR_FREE(source); + if (vol) { + virStorageVolFree(vol); + vol = NULL; + } + + /* get volume source and target paths */ + if (!(target = virXPathString("string(./target/@dev)", ctxt))) { + vshError(ctl, _("Failed to enumerate devices")); + goto cleanup; + } + + if (!(source = virXPathString("string(" + "./source/@file|" + "./source/@dir|" + "./source/@name|" + "./source/@dev)", ctxt)) && + virGetLastError()) + goto cleanup; + + if (volumes) { + volume = strtok_r(volumes, ",", &saveptr); + while (volume) { + if (STREQ_NULLABLE(volume, target) || + STREQ_NULLABLE(volume, source)) + break; + volume = strtok_r(NULL, ",", &saveptr); + } + if (!volume) + continue; + } + + if (!source) + continue; + + if (!(vol = virStorageVolLookupByPath(ctl->conn, source))) { + vshPrint(ctl, + _("Storage volume '%s' is not managed by libvirt. " + "Remove it manually.\n"), source); + virResetLastError(); + continue; + } + + if (wipe_storage) { + vshPrint(ctl, _("Wiping volume '%s' ... "), source); + fflush(stdout); + if (virStorageVolWipe(vol, 0) < 0) { + vshError(ctl, _("Failed! Volume not removed.")); + vol_del_failed = true; + continue; + } else { + vshPrint(ctl, _("Done.\n")); + } + } + + /* delete the volume */ + if (virStorageVolDelete(vol, 0) < 0) { + vshError(ctl, _("Failed to remove storage volume '%s'"), + source); + vol_del_failed = true; + } + vshPrint(ctl, _("Volume '%s' removed.\n"), source); + } + + if (!vol_del_failed) + ret = true; } cleanup: + VIR_FREE(source); + VIR_FREE(target); + VIR_FREE(volumes); + VIR_FREE(def); + VIR_FREE(vol_nodes); + xmlFreeDoc(doc); + xmlXPathFreeContext(ctxt); virDomainFree(dom); return ret; } diff --git a/tools/virsh.pod b/tools/virsh.pod index fe92714..c0b55bd 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -1179,6 +1179,7 @@ Output the device used for the TTY console of the domain. If the information is not available the processes will provide an exit code of 1. =item B<undefine> I<domain-id> [I<--managed-save>] [I<--snapshots-metadata>] +[I<--storage> B<volumes> I<--wipe-storage> I<--remove-all-storage>] Undefine a domain. If the domain is running, this converts it to a transient domain, without stopping it. If the domain is inactive, @@ -1194,6 +1195,23 @@ domain. Without the flag, attempts to undefine an inactive domain with snapshot metadata will fail. If the domain is active, this flag is ignored. +The I<--storage> flag takes a parameter B<volumes>, that is a comma separated +list of volume target names or source paths of storage volumes to be removed +along with the undefined domain. Volumes can be undefined and thus removed only +on inactive domains. Volume deletion is only attempted after the domain is +undefined; if not all of the requested volumes could be deleted, the the +error message indicates what still remains behind. If a volume path is not +found in the domain definition, it's treated as if the volume was successfuly +deleteted. +(See B<domblklist> for list of target names associated to a domain). +Example: --storage vda,vdb,vdc + +The I<--remove-all-storage> flag specifies, that all domain's storage volumes +should be deleted. + +The flag I<--wipe-storage> specifies that the storage volumes should be +wiped before removal. + NOTE: For an inactive domain, the domain name or UUID must be used as the I<domain-id>. -- 1.7.3.4

2 1

[libvirt] [PATCH] virsh: Print error message if argument parsing fails for cmdNodesuspend
by Peter Krempa 14 Dec '11

14 Dec '11

If parsing of arguments failed, virsh did silently exit returning and error state, but not specifying the possible problem. * tools/virsh: cmdNodesuspend: - error handling added --- tools/virsh.c | 12 +++++++++--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index d58b827..ebda248 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -5270,14 +5270,20 @@ cmdNodeSuspend(vshControl *ctl, const vshCmd *cmd) if (!vshConnectionUsability(ctl, ctl->conn)) return false; - if (vshCommandOptString(cmd, "target", &target) < 0) + if (vshCommandOptString(cmd, "target", &target) < 0) { + vshError(ctl, _("Invalid suspend target argument")); return false; + } - if (vshCommandOptLongLong(cmd, "duration", &duration) < 0) + if (vshCommandOptLongLong(cmd, "duration", &duration) < 0) { + vshError(ctl, _("Invalid suspend duration argument")); return false; + } - if (vshCommandOptUInt(cmd, "flags", &flags) < 0) + if (vshCommandOptUInt(cmd, "flags", &flags) < 0) { + vshError(ctl, _("Invalid suspend flags argument")); return false; + } if (STREQ(target, "mem")) suspendTarget = VIR_NODE_SUSPEND_TARGET_MEM; -- 1.7.3.4

4 6

[libvirt] [PATCH] docs: tweak 'virsh edit' wording
by Eric Blake 14 Dec '11

14 Dec '11

I was wondering why 'virsh edit' didn't support the same '--inactive' option as 'virsh dumpxml'; reading the source code showed that --inactive was already implied, and that the only way to alter a running guest rather than affecting next boot is by hot-plugging individual devices, or by something complex like saving the guest and modifying the save image. * tools/virsh.pod (define, edit): Mention behavior when guest is already running. --- tools/virsh.pod | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index fe92714..965b215 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -497,7 +497,8 @@ B<Example> =item B<define> I<FILE> Define a domain from an XML <file>. The domain definition is registered -but not started. +but not started. If domain is already running, the changes will take +effect on the next boot. =item B<destroy> I<domain-id> @@ -717,11 +718,12 @@ specified, then the output will be escaped for use in XML. =item B<edit> I<domain-id> -Edit the XML configuration file for a domain. +Edit the XML configuration file for a domain, which will affect the +next boot of the guest. This is equivalent to: - virsh dumpxml domain > domain.xml + virsh dumpxml --inactive domain > domain.xml vi domain.xml (or make changes with your other text editor) virsh define domain.xml -- 1.7.7.4

2 2