- Devel - libvirt List Archives

[libvirt] Migration failure related to EOF from Monitor
by Shradha Shah 22 Feb '12

22 Feb '12

Hello All, I am trying to migrate a KVM guest while implementing the patches for PCI-Passthrough of SRIOV Vf's and I repeatedly see the following error: [root@c6100k cwd]# virsh migrate --live dibenchvm1 qemu+ssh://c6100l.uk.level5networks.com/system error: operation failed: migration job: unexpectedly failed I have turned on debugging in /etc/libvirt/libvirtd.conf and I see the following debug in /var/log/libvirt/libvirtd.log 10:37:26.632: 2449: error : qemuMonitorIO:584 : internal error End of file from monitor 10:37:26.632: 2449: debug : qemuMonitorIO:617 : Error on monitor internal error End of file from monitor 10:37:26.632: 2449: debug : virEventPollUpdateHandle:145 : Update handle w=21 e=12 10:37:26.632: 2449: debug : virEventPollInterruptLocked:676 : Skip interrupt, 1 -1497479264 10:37:26.632: 2449: debug : qemuMonitorIO:640 : Triggering EOF callback 10:37:26.632: 2449: debug : qemuProcessHandleMonitorEOF:125 : Received EOF on 0x7f588c003540 'dibenchvm1' 10:37:26.632: 2449: debug : qemuProcessStop:3271 : Shutting down VM 'dibenchvm1' pid=18739 migrated=0 10:37:26.632: 2449: debug : qemuMonitorClose:765 : mon=0x7f588c00c7f0 10:37:26.632: 2449: debug : virEventPollRemoveHandle:172 : Remove handle w=21 10:37:26.633: 2449: debug : virEventPollRemoveHandle:185 : mark delete 9 20 10:37:26.633: 2449: debug : virEventPollInterruptLocked:676 : Skip interrupt, 1 -1497479264 10:37:26.633: 2449: debug : qemuProcessKill:3217 : vm=dibenchvm1 pid=18739 gracefully=0 10:37:26.633: 2449: debug : qemuProcessAutoDestroyRemove:3736 : vm=dibenchvm1 uuid=a4452511-0f97-734a-dbcc-f4c66f821956 10:37:26.633: 2449: debug : virSecurityDACRestoreSecurityAllLabel:504 : Restoring security label on dibenchvm1 migrated=0 May I ask for suggestions on how I can debug the monitor and find out the reason why the qemu monitor dies? Many Thanks, Regards, Shradha Shah

3 2

Re: [libvirt] [Qemu-devel] [PATCH v5 12/12] suspend: add qmp events
by Gerd Hoffmann 22 Feb '12

22 Feb '12

On 02/17/12 18:33, Luiz Capitulino wrote: > On Wed, 15 Feb 2012 11:28:21 +0100 > Gerd Hoffmann <kraxel(a)redhat.com> wrote: > >> Send qmp events on suspend and wakeup so libvirt >> has a chance to track the vm state. [ added libvirt to Cc:, leaving full context. this is about qmp events when the guest enters/leaves s3 ]. >> Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com> >> --- >> monitor.c | 6 ++++++ >> monitor.h | 2 ++ >> vl.c | 15 +++++++++++++++ >> 3 files changed, 23 insertions(+), 0 deletions(-) >> >> diff --git a/monitor.c b/monitor.c >> index aadbdcb..e6f5fad 100644 >> --- a/monitor.c >> +++ b/monitor.c >> @@ -485,6 +485,12 @@ void monitor_protocol_event(MonitorEvent event, QObject *data) >> case QEVENT_BLOCK_JOB_CANCELLED: >> event_name = "BLOCK_JOB_CANCELLED"; >> break; >> + case QEVENT_SUSPEND: >> + event_name = "SUSPEND"; >> + break; >> + case QEVENT_WAKEUP: >> + event_name = "WAKEUP"; >> + break; >> default: >> abort(); >> break; >> diff --git a/monitor.h b/monitor.h >> index b72ea07..9df3bab 100644 >> --- a/monitor.h >> +++ b/monitor.h >> @@ -38,6 +38,8 @@ typedef enum MonitorEvent { >> QEVENT_SPICE_DISCONNECTED, >> QEVENT_BLOCK_JOB_COMPLETED, >> QEVENT_BLOCK_JOB_CANCELLED, >> + QEVENT_SUSPEND, >> + QEVENT_WAKEUP, >> QEVENT_MAX, >> } MonitorEvent; >> >> diff --git a/vl.c b/vl.c >> index bfdcb7c..570ea05 100644 >> --- a/vl.c >> +++ b/vl.c >> @@ -1416,6 +1416,7 @@ static void qemu_system_suspend(void) >> { >> pause_all_vcpus(); >> notifier_list_notify(&suspend_notifiers, NULL); >> + monitor_protocol_event(QEVENT_SUSPEND, NULL); >> is_suspended = true; >> } >> >> @@ -1436,12 +1437,26 @@ void qemu_register_suspend_notifier(Notifier *notifier) >> >> void qemu_system_wakeup_request(WakeupReason reason) >> { >> + static const char *names[] = { >> + [QEMU_WAKEUP_REASON_OTHER] = "other", >> + [QEMU_WAKEUP_REASON_RTC] = "rtc", >> + [QEMU_WAKEUP_REASON_PMTIMER] = "pmtimer", > > Is the reason really important for mngt? Can we just leave it out? I assumed the wakeup reason could be useful, but dunno. Zapping the code is no problem of course. Lets ask mgmt aka libvirt folks ;) cheers, Gerd >> + }; >> + const char *name; >> + QObject *data; >> + >> if (!is_suspended) { >> return; >> } >> if (!(wakeup_reason_mask & (1 << reason))) { >> return; >> } >> + >> + name = (reason < ARRAY_SIZE(names)) ? names[reason] : "unknown"; >> + data = qobject_from_jsonf("{ 'reason': %s }", name); >> + monitor_protocol_event(QEVENT_WAKEUP, data); >> + qobject_decref(data); >> + >> notifier_list_notify(&wakeup_notifiers, &reason); >> reset_requested = 1; >> qemu_notify_event(); >

3 3

[libvirt] [PATCH] virsh: Enhance list command to ease creation of shell scripts
by Peter Krempa 22 Feb '12

22 Feb '12

This patch adds new options to the "virsh list" command enabling filtering of persistent and transient domains along with the option to print only UUIDs or names of domains instead of printing the table. Option --name prints domain names (one per line) instead of the default table. Similarly --uuid prints domain's UUID. The option --table is an alias for the default behavior. Aditionaly --persistent and/or --transient may be specified to filter the output of domains. --- tools/virsh.c | 176 ++++++++++++++++++++++++++++++++++++++++-------------- tools/virsh.pod | 20 ++++++- 2 files changed, 148 insertions(+), 48 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 66ba61c..10160de 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -888,6 +888,11 @@ static const vshCmdInfo info_list[] = { static const vshCmdOptDef opts_list[] = { {"inactive", VSH_OT_BOOL, 0, N_("list inactive domains")}, {"all", VSH_OT_BOOL, 0, N_("list inactive & active domains")}, + {"transient", VSH_OT_BOOL, 0, N_("list transient domains")}, + {"persistent", VSH_OT_BOOL, 0, N_("list persistent domains")}, + {"uuid", VSH_OT_BOOL, 0, N_("list uuid's only")}, + {"name", VSH_OT_BOOL, 0, N_("list domain names only")}, + {"table", VSH_OT_BOOL, 0, N_("list table (default)")}, {"managed-save", VSH_OT_BOOL, 0, N_("mark domains with managed save state")}, {"title", VSH_OT_BOOL, 0, N_("show short domain description")}, @@ -905,13 +910,41 @@ cmdList(vshControl *ctl, const vshCmd *cmd ATTRIBUTE_UNUSED) char **names = NULL; int maxname = 0; bool managed = vshCommandOptBool(cmd, "managed-save"); - bool desc = vshCommandOptBool(cmd, "title"); + bool optTitle = vshCommandOptBool(cmd, "title"); + bool optTable = vshCommandOptBool(cmd, "table"); + bool optUUID = vshCommandOptBool(cmd, "uuid"); + bool optName = vshCommandOptBool(cmd, "name"); + bool optPersistent = vshCommandOptBool(cmd, "persistent"); + bool optTransient = vshCommandOptBool(cmd, "transient"); + bool persistUsed = true; + virDomainPtr dom = NULL; char *title; + char uuid[VIR_UUID_STRING_BUFLEN]; int state; + int persistent; bool ret = false; inactive |= all; + /* process arguments */ + if (!optPersistent && !optTransient) { + optPersistent = true; + optTransient = true; + persistUsed = false; + } + + if ((optTable && optName) || + (optTable && optUUID) || + (optName && optUUID)) { + vshError(ctl, "%s", + _("Only one argument from --table, --name and --uuid" + "may be specified.")); + return false; + } + + if (!optUUID && !optName) + optTable = true; + if (!vshConnectionUsability(ctl, ctl->conn)) return false; @@ -924,14 +957,15 @@ cmdList(vshControl *ctl, const vshCmd *cmd ATTRIBUTE_UNUSED) if (maxid) { ids = vshMalloc(ctl, sizeof(int) * maxid); - if ((maxid = virConnectListDomains(ctl->conn, &ids[0], maxid)) < 0) { + if ((maxid = virConnectListDomains(ctl->conn, ids, maxid)) < 0) { vshError(ctl, "%s", _("Failed to list active domains")); goto cleanup; } - qsort(&ids[0], maxid, sizeof(int), idsorter); + qsort(ids, maxid, sizeof(int), idsorter); } } + if (inactive) { maxname = virConnectNumOfDefinedDomains(ctl->conn); if (maxname < 0) { @@ -941,7 +975,9 @@ cmdList(vshControl *ctl, const vshCmd *cmd ATTRIBUTE_UNUSED) if (maxname) { names = vshMalloc(ctl, sizeof(char *) * maxname); - if ((maxname = virConnectListDefinedDomains(ctl->conn, names, maxname)) < 0) { + if ((maxname = virConnectListDefinedDomains(ctl->conn, + names, + maxname)) < 0) { vshError(ctl, "%s", _("Failed to list inactive domains")); goto cleanup; } @@ -950,77 +986,125 @@ cmdList(vshControl *ctl, const vshCmd *cmd ATTRIBUTE_UNUSED) } } - if (desc) { - vshPrintExtra(ctl, "%-5s %-30s %-10s %s\n", _("Id"), _("Name"), _("State"), _("Title")); - vshPrintExtra(ctl, "-----------------------------------------------------------\n"); - } else { - vshPrintExtra(ctl, " %-5s %-30s %s\n", _("Id"), _("Name"), _("State")); - vshPrintExtra(ctl, "----------------------------------------------------\n"); + /* print table header in legacy mode */ + if (optTable) { + vshPrintExtra(ctl, " %-5s %-30s %-10s", + _("Id"), _("Name"), _("State")); + if (optTitle) + vshPrintExtra(ctl, "%-20s", _("Title")); + + vshPrintExtra(ctl, "\n" + "-----------------------------------------------------------\n"); } for (i = 0; i < maxid; i++) { - virDomainPtr dom = virDomainLookupByID(ctl->conn, ids[i]); + dom = virDomainLookupByID(ctl->conn, ids[i]); /* this kind of work with domains is not atomic operation */ if (!dom) continue; - if (desc) { - if (!(title = vshGetDomainDescription(ctl, dom, true, 0))) + if (persistUsed) { + persistent = virDomainIsPersistent(dom); + if (persistent < 0) { + vshError(ctl, "%s", + _("Failed to determine domain's persistent state")); goto cleanup; + } - vshPrint(ctl, "%-5d %-30s %-10s %s\n", - virDomainGetID(dom), - virDomainGetName(dom), - _(vshDomainStateToString(vshDomainState(ctl, dom, NULL))), - title); - VIR_FREE(title); - } else { - vshPrint(ctl, " %-5d %-30s %s\n", - virDomainGetID(dom), - virDomainGetName(dom), - _(vshDomainStateToString(vshDomainState(ctl, dom, NULL)))); + if ((persistent && !optPersistent) || + (!persistent && !optTransient)) { + virDomainFree(dom); + dom = NULL; + continue; + } } + + if (optTable) { + vshPrint(ctl, " %-5d %-30s %-10s", + virDomainGetID(dom), + virDomainGetName(dom), + _(vshDomainStateToString(vshDomainState(ctl, dom, NULL)))); + + if (optTitle) { + if (!(title = vshGetDomainDescription(ctl, dom, true, 0))) + goto cleanup; + + vshPrint(ctl, "%-20s", title); + VIR_FREE(title); + } + + vshPrint(ctl, "\n"); + } else if (optUUID) { + if (virDomainGetUUIDString(dom, uuid) < 0) { + vshError(ctl, "%s", + _("Failed to get domain's UUID")); + goto cleanup; + } + vshPrint(ctl, "%s\n", uuid); + } else if (optName) { + vshPrint(ctl, "%s\n", virDomainGetName(dom)); + } + virDomainFree(dom); + dom = NULL; } + for (i = 0; i < maxname; i++) { - virDomainPtr dom = virDomainLookupByName(ctl->conn, names[i]); + dom = virDomainLookupByName(ctl->conn, names[i]); /* this kind of work with domains is not atomic operation */ - if (!dom) { - VIR_FREE(names[i]); + if (!dom) continue; - } - state = vshDomainState(ctl, dom, NULL); - if (managed && state == VIR_DOMAIN_SHUTOFF && - virDomainHasManagedSaveImage(dom, 0) > 0) - state = -2; + if (!optPersistent) { + virDomainFree(dom); + dom = NULL; + continue; + } - if (desc) { - if (!(title = vshGetDomainDescription(ctl, dom, true, 0))) - goto cleanup; + if (optTable) { + state = vshDomainState(ctl, dom, NULL); + if (managed && state == VIR_DOMAIN_SHUTOFF && + virDomainHasManagedSaveImage(dom, 0) > 0) + state = -2; - vshPrint(ctl, "%-5s %-30s %-10s %s\n", - "-", - names[i], - state == -2 ? _("saved") : _(vshDomainStateToString(state)), - title); - VIR_FREE(title); - } else { - vshPrint(ctl, " %-5s %-30s %s\n", + vshPrint(ctl, " %-5s %-30s %-10s", "-", names[i], state == -2 ? _("saved") : _(vshDomainStateToString(state))); - } - virDomainFree(dom); - VIR_FREE(names[i]); + if (optTitle) { + if (!(title = vshGetDomainDescription(ctl, dom, true, 0))) + goto cleanup; + + vshPrint(ctl, "%-20s", title); + VIR_FREE(title); + } + + vshPrint(ctl, "\n"); + } else if (optUUID) { + if (virDomainGetUUIDString(dom, uuid) < 0) { + vshError(ctl, "%s", + _("Failed to get domain's UUID")); + goto cleanup; + } + vshPrint(ctl, "%s\n", uuid); + } else if (optName) { + vshPrint(ctl, "%s\n", names[i]); + } + + virDomainFree(dom); + dom = NULL; } ret = true; cleanup: + if (dom) + virDomainFree(dom); VIR_FREE(ids); + for (i = 0; i < maxname; i++) + VIR_FREE(names[i]); VIR_FREE(names); return ret; } diff --git a/tools/virsh.pod b/tools/virsh.pod index 0d5a41d..aa29c00 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -280,6 +280,8 @@ The XML also show the NUMA topology information if available. Inject NMI to the guest. =item B<list> [I<--inactive> | I<--all>] [I<--managed-save>] [I<--title>] + [I<--name> | <I--table> | <I--uuid>] [I<--persistent>] + [I<--transient>] Prints information about existing domains. If no options are specified it prints out information about running domains. @@ -348,10 +350,24 @@ crashed. If I<--managed-save> is specified, then domains that have managed save state (only possible if they are in the B<shut off> state) will -instead show as B<saved> in the listing. +instead show as B<saved> in the listing. This flag is usable only with the +default I<--table> output. + +If I<--name> is specified, domain names are printed instead of the table +formated one per line. If I<--uuid> is specified domain's UUID's are printed +instead of names. Flag I<--table> specifies that the legacy table-formated +output should be used. This is the default. All of these are mutually +exclusive. + +Flag I<--persistent> specifies that persistent domains should be printed. +Similarly I<--transiet> enables output of transient domains. These flags +may be combined. Default behavior is as though both were specifiedi (Although +if any of these flags is specified, the check for the persistence state is done +and may fail. If none of these flags is specified, the check is skipped). If I<--title> is specified, then the domain note is printed. The output then -the output looks as follows. +the output looks as follows. This flag is usable only with the default +I<--table> output. B<virsh> list --title Id Name State Title -- 1.7.3.4

3 3

[libvirt] [PATCH] configure: Define program name if not found
by Michal Privoznik 22 Feb '12

22 Feb '12

AC_CHECK_PROG checks for program in given path. However, if it doesn't exists, [variable] is set to [value-if-not-found]. We don't want this to be the empty string in case of 'modprobe' and 'scrub' as we want to fallback to runtime detection. --- configure.ac | 4 ++-- src/util/pci.c | 5 ----- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/configure.ac b/configure.ac index 4493b94..732f4fe 100644 --- a/configure.ac +++ b/configure.ac @@ -211,11 +211,11 @@ AC_PATH_PROG([UDEVADM], [udevadm], [], [/sbin:/usr/sbin:/usr/local/sbin:$PATH]) AC_PATH_PROG([UDEVSETTLE], [udevsettle], [], [/sbin:/usr/sbin:/usr/local/sbin:$PATH]) -AC_PATH_PROG([MODPROBE], [modprobe], [], +AC_PATH_PROG([MODPROBE], [modprobe], [modprobe], [/sbin:/usr/sbin:/usr/local/sbin:$PATH]) AC_PATH_PROG([OVSVSCTL], [ovs-vsctl], [ovs-vsctl], [/sbin:/usr/sbin:/usr/local/sbin:$PATH]) -AC_PATH_PROG([SCRUB], [scrub], [], +AC_PATH_PROG([SCRUB], [scrub], [scrub], [/sbin:/usr/sbin:/usr/local/sbin:$PATH]) AC_DEFINE_UNQUOTED([DNSMASQ],["$DNSMASQ"], diff --git a/src/util/pci.c b/src/util/pci.c index 633dcd8..c660e8d 100644 --- a/src/util/pci.c +++ b/src/util/pci.c @@ -40,11 +40,6 @@ #include "virterror_internal.h" #include "virfile.h" -/* avoid compilation breakage on some systems */ -#ifndef MODPROBE -# define MODPROBE "modprobe" -#endif - #define PCI_SYSFS "/sys/bus/pci/" #define PCI_ID_LEN 10 /* "XXXX XXXX" */ #define PCI_ADDR_LEN 13 /* "XXXX:XX:XX.X" */ -- 1.7.3.4

2 2

[libvirt] [PATCH] util: Fix virFileAccessibleAs return path from parent
by Michal Privoznik 22 Feb '12

22 Feb '12

Despite documentation, if we do fork() parent always returns -1 even if file is accessible. Which is wrong obviously. --- src/util/util.c | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/util/util.c b/src/util/util.c index 3406b7b..04a0e79 100644 --- a/src/util/util.c +++ b/src/util/util.c @@ -724,8 +724,12 @@ virFileAccessibleAs(const char *path, int mode, return -1; } - errno = status; - return -1; + if (!status) { + errno = status; + return -1; + } + + return 0; } /* child. -- 1.7.3.4

2 2

[libvirt] [PATCH 0/2] VMware Workstation domainXMLFromNative support
by Jean-Baptiste Rouault 22 Feb '12

22 Feb '12

These patches add domainXMLFromNative to the vmware driver and add support for more network configurations in vmx files Jean-Baptiste Rouault (2): vmware: implement domainXMLFromNative vmx: Better Workstation vmx handling src/vmware/vmware_driver.c | 31 +++++++++++++++++++++++++++++++ src/vmx/vmx.c | 29 ++++++++++++++++++----------- 2 files changed, 49 insertions(+), 11 deletions(-) -- 1.7.9

2 5

[libvirt] Fwd: a question about sanlock
by Alex Jia 22 Feb '12

22 Feb '12

Hi Daniel, Thanks for your quick reply, from safety point of view, yes, libvirt should exit, but, your alternative solution is more friendly for users, however, I haven't any idea about this now, maybe, others want to do this, so forward it to libvirt-list. Thanks & Regards, Alex ----- Forwarded Message ----- From: "Daniel P. Berrange" <berrange(a)redhat.com> To: "Alex Jia" <ajia(a)redhat.com> Cc: libvirt-users(a)redhat.com Sent: Wednesday, February 22, 2012 4:19:28 PM Subject: Re: [libvirt] a question about sanlock On Wed, Feb 22, 2012 at 02:04:09AM -0500, Alex Jia wrote: > Hi Daniel, > I got a question about lock manager, if I enable 'sanlock' in qemu.conf and > uncomment 'auto_disk_leases = 1' in qemu-sanlock.conf then restart libvirtd > service, libvirtd will be dead, I know I should also uncomment 'host_id = 1' > in qemu-sanlock.conf, because I enable 'auto_disk_leases'. The question is > the libvirtd must die due to a error users configuration? or could we give > some warning information instead of libvirtd die? I think this is a safety issue - if someone is deploying libvirt in an scenario where they want locking, then we must be very careful not to accidentally run without locking. So if someone accidentally mis-configures one of their libvirtd instances to not have any host_id parameter, I felt the only safe thing todo was to exit. An alternative would be to allow libvirtd to start, but then make sure it refuses to start any guests. I'm happy to take patches for the latter if someone wants to... Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

1 0

[libvirt] Effect of cluster size on read write performance
by Pankaj Rawat 22 Feb '12

22 Feb '12

Hi all The cluster -size increase write performance when the qcow2 image is not expanded , surely with increase in cluster_size the disk space used increases but that is not my concern. Can anyone tell what is the effect of cluster size on read and write performance on qcow2 image after expantion? DISCLAIMER: ----------------------------------------------------------------------------------------------------------------------- The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. It shall not attach any liability on the originator or NECHCL or its affiliates. Any views or opinions presented in this email are solely those of the author and may not necessarily reflect the opinions of NECHCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of the author of this e-mail is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. . -----------------------------------------------------------------------------------------------------------------------

2 1

[libvirt] virtio-win-0.1-22 balloon install fails on 2008R2
by sean darcy 21 Feb '12

21 Feb '12

Trying to install the virtio-win-0.1-22.iso balloon driver on Windows 2008R2: E:\Wlh\amd64>x:\microsoft\WinDDK\7600.16385.win7_wdk.100208-1538\tools\devcon\amd64\devcon.exe install BALLOON.inf PCI\VEN_1AF4&DEV_1002&SUBSYS_00051AF4&REV_00 Device node created. Install is complete when drivers are installed... Updating drivers for PCI\VEN_1AF4 from E:\Wlh\amd64\BALLOON.inf. devcon.exe failed. 'DEV_1002' is not recognized as an internal or external command, operable program or batch file. 'SUBSYS_00051AF4' is not recognized as an internal or external command, operable program or batch file. 'REV_00' is not recognized as an internal or external command, operable program or batch file. Any help appreciated. sean

2 2

[libvirt] [PATCH] esx: Correctly disable HTTP Expect header usage of libcurl
by Matthias Bolte 21 Feb '12

21 Feb '12

Adding "Expect:" to the header list stops libcurl from sending a Expect header at all. Before, a dummy Expect header was added that might confuse HTTP proxies and result in HTTP error code 417 being reported. --- src/esx/esx_vi.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/esx/esx_vi.c b/src/esx/esx_vi.c index 14ad50a..6004aac 100644 --- a/src/esx/esx_vi.c +++ b/src/esx/esx_vi.c @@ -293,14 +293,14 @@ esxVI_CURL_Connect(esxVI_CURL *curl, esxUtil_ParsedUri *parsedUri) "Content-Type: text/xml; charset=UTF-8"); /* - * Add a dummy expect header to stop CURL from waiting for a response code + * Add an empty expect header to stop CURL from waiting for a response code * 100 (Continue) from the server before continuing the POST operation. * Waiting for this response would slowdown each communication with the * server by approx. 2 sec, because the server doesn't send the expected * 100 (Continue) response and the wait times out resulting in wasting * approx. 2 sec per POST operation. */ - curl->headers = curl_slist_append(curl->headers, "Expect: nothing"); + curl->headers = curl_slist_append(curl->headers, "Expect:"); if (curl->headers == NULL) { ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, "%s", -- 1.7.4.1

2 2

[libvirt] [PATCH 0/6] (informational) conf support for <interface type='hostdev'>
by Laine Stump 21 Feb '12

21 Feb '12

This series of patches enhances the domain parser/formatter code to support a sort of "intelligent hostdev", i.e. PCI passthrough where device-type specific initialization is done prior to assigning the device to the guest, in particular to allow setting the MAC address and do 802.1QbX setup for network devices. Rather than adding all of the device-type specific config to <hostdev>, I accomplish this through adding a new type of <interface> element, type='hostdev'. When an interface is type='hostdev' the following is changed: * in the toplevel device, the managed attribute can be specified (with identical results as when it's specified in a <hostdev> * The <source> element can specify a pci address or usb address, just as can be done in <hostdev>. One notable difference is that the type of the address is specified directly in the source <address> element, rather than as an attribute of the toplevel device (that's how it's done for <hostdev>, but for <interface>, the toplevel element's type attribute is already used). These patches include only the parser/formatter, test (for domainschematest, and qemuxml2xmltest only), and doc changes; they still need to be hooked into the domain's device lists (a type=hostdev interface will reside in both the interface list (for configuration and memory management) and hostdev list (for attach/detach, and tracking of which devices are assigned)). I don't intend to push these patches until that part is also done, but some other people are doing work that depends on the changes to config format and data structures, so I'm sending these patches now both to unblock them, as well as to get feedback from everyone else on what needs to be changed. The first 4 patches are just setup for the real new code - they reorder and refactor existing code to allow greater re-use of existing code and easier plugin of the new code. Patch 5/6 is just a couple of lines, and patch 6/6 provides the new functionality.

2 18

[libvirt] Network not Persistent
by Shradha Shah 21 Feb '12

21 Feb '12

Hello All, I am currently working on patches for PCI-passthrough of SRIOV VF's and I am facing an issue with the network definition not being persistent. I am using a new forward mode = hostdev and the network xml is as follows: <network> <name>pci-passthrough-network</name> <uuid>81ff0d90-c91e-6742-64da-4a736edb9a8f</uuid> <forward mode="hostdev"> <pf dev="eth2"/> </forward> </network> Command line used is: # virsh net-define pci_passthrough_network.xml The network is defined successfully and I can use it at this point. But if I restart libvirt after defining the above network, I lose the network definition. After restart libvirt does not possess any knowledge of the above network. This does not happen when I use forward mode="bridge". I have cross referenced the function call path of networkDefine for both the forwarding modes and I can't seem to find the problem. Is there some function I am missing? May I ask for your help to solve this issue? Many Thanks, Regards, Shradha Shah

3 5

[libvirt] [PATCH] lib: Fix function documentation for virConnectListDomains
by Peter Krempa 21 Feb '12

21 Feb '12

Clarify the documentation of virConnectListDomains. --- src/libvirt.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index a55d823..6294196 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -1818,23 +1818,23 @@ error: virDispatchError(conn); return -1; } /** * virConnectListDomains: * @conn: pointer to the hypervisor connection * @ids: array to collect the list of IDs of active domains * @maxids: size of @ids * - * Collect the list of active domains, and store their ID in @maxids + * Collect the list of active domains, and store their IDs in array @ids * - * Returns the number of domain found or -1 in case of error + * Returns the number of domains found or -1 in case of error */ int virConnectListDomains(virConnectPtr conn, int *ids, int maxids) { VIR_DEBUG("conn=%p, ids=%p, maxids=%d", conn, ids, maxids); virResetLastError(); if (!VIR_IS_CONNECT(conn)) { virLibConnError(VIR_ERR_INVALID_CONN, __FUNCTION__); -- 1.7.3.4

2 1

[libvirt] [PATCH] virsh: Fix docs for list command
by Peter Krempa 21 Feb '12

21 Feb '12

Commit fad5cd210899dfde4afe36712754dc921c3f3051 introduced option to display domain's title in the list command output. There was a mistake in the virsh man page example for this command stating --note instead of --title. --- Pushed under trivial rule. tools/virsh.pod | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 6730b8b..0d5a41d 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -353,7 +353,7 @@ instead show as B<saved> in the listing. If I<--title> is specified, then the domain note is printed. The output then the output looks as follows. -B<virsh> list --note +B<virsh> list --title Id Name State Title ----------------------------------------------- 0 Domain-0 running Mailserver 1 -- 1.7.3.4

1 0

[libvirt] [PATCH] daemon: Plug memory leak on remoteDispatchAuthList
by Alex Jia 21 Feb '12

21 Feb '12

Detected by valgrind. Leak is introuduced in commit fcdfa31. * daemon/remote.c (remoteDispatchAuthList): fix memory leak on failure path. * Actual result ==26844== 150,592 bytes in 9,602 blocks are definitely lost in loss record 735 of 738 ==26844== at 0x4A05FDE: malloc (vg_replace_malloc.c:236) ==26844== by 0x36AEAFEDE7: __vasprintf_chk (in /lib64/libc-2.12.so) ==26844== by 0x36C3A59B03: virVasprintf (stdio2.h:199) ==26844== by 0x36C3A59BA7: virAsprintf (util.c:1827) ==26844== by 0x4335F5: remoteDispatchAuthListHelper (remote.c:2054) ==26844== by 0x36C3B10394: virNetServerProgramDispatch (virnetserverprogram.c:416) ==26844== by 0x36C3B11620: virNetServerHandleJob (virnetserver.c:164) ==26844== by 0x36C3A57AAB: virThreadPoolWorker (threadpool.c:144) ==26844== by 0x36C3A573C8: virThreadHelper (threads-pthread.c:161) ==26844== by 0x36AEE077F0: start_thread (in /lib64/libpthread-2.12.so) ==26844== by 0x36AEAE570C: clone (in /lib64/libc-2.12.so) Notes, the test is in a loop, so you will see a quite big leaks. Signed-off-by: Alex Jia <ajia(a)redhat.com> --- daemon/remote.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/daemon/remote.c b/daemon/remote.c index 74a5f16..9018c15 100644 --- a/daemon/remote.c +++ b/daemon/remote.c @@ -2054,6 +2054,7 @@ remoteDispatchAuthList(virNetServerPtr server ATTRIBUTE_UNUSED, if (virAsprintf(&ident, "pid:%lld,uid:%d", (long long) callerPid, callerUid) < 0) { virReportOOMError(); + VIR_FREE(ident); goto cleanup; } VIR_INFO("Bypass polkit auth for privileged client %s", ident); -- 1.7.1

2 4

[libvirt] Release of libvirt-0.9.10
by Daniel Veillard 21 Feb '12

21 Feb '12

As planned I made the release yesterday, it is tagged in git and available at: ftp://libvirt.org/libvirt/ both as tarball and signed rpms for Fedora 16. This is again a relatively large release with close to 300 commits, and we got a significant number of added feature in the last month, along with the usual improvement and bug fixes: Features: - Add support for sVirt in the LXC driver (Daniel P. Berrange) - block rebase: add new API virDomainBlockRebase (Eric Blake) - API: Add api to set and get domain metadata (Peter Krempa) - virDomainGetDiskErrors public API (Jiri Denemark) - conf: add rawio attribute to disk element of domain XML (Taku Izumi) - Add new public API virDomainGetCPUStats() (KAMEZAWA Hiroyuki) - Introduce virDomainPMSuspendForDuration API (Michal Privoznik) - resize: add virStorageVolResize() API (Zeeshan Ali (Khattak)) - Add a virt-host-validate command to sanity check HV config (Daniel P. Berrange) - Add new virDomainShutdownFlags API (Daniel P. Berrange) - QEMU guest agent support (Daniel P. Berrange) Documentation: - fix typo in python bindings (Eric Blake) - conf: small changes to comments in virDomainDeviceInfo (Laine Stump) - Clarify the purpose of domxml-from-native (Dave Allan) - Enhance documentation of the old-style boot configuration (Jiri Denemark) - virterror.c: Fix several spelling mistakes (Philipp Hahn) - Add detail to documentation on storage pools and volumes. (Dave Allan) - fill out rawio description (Laine Stump) - XenXs: Update documentation (Philipp Hahn) - reorder public header (Eric Blake) - tweak recent suspend API additions (Eric Blake) - Add missing docs for <viridian/> feature flag (Daniel P. Berrange) - fix virsh man page (Eric Blake) - fix a few small typos in formatdomain.html.in (Laine Stump) - src/datatypes.h: fix typo (Alon Levy) - Clarify semantics of virDomainMigrate{,ToURI}2 (Jiri Denemark) - Add missed RNG schema for interface (Osier Yang) - Add documentation new ways to access members of variables (Stefan Berger) - virsh: improve doMigrate function docs (Alex Jia) - standardize description of flags (Eric Blake) - Document Android application using libvirt (Michal Privoznik) Portability: - virpidfile: replace fopen/fwrite/fscanf with more portable version (Marc-André Lureau) - util: Do not use PRIx64 macro (Osier Yang) - Replace truncate() with ftruncate() (Daniel P. Berrange) - build: avoid gcc 4.7 warning about inlines (Eric Blake) - lxc: Fix build with AppArmor (Jiri Denemark) - Update gnulib to fix mingw64 compilation errors (Marc-André Lureau) - tests: virnettlscontexttest needs gnutls-2.6.0 (Philipp Hahn) - qemu: Silent bogus warning about unitialized variable (Jiri Denemark) - build: fix text regression (Eric Blake) - Add virt-host-validate.1 to Mingw32 RPM spec file list (Daniel P. Berrange) - build: fix missing include (Eric Blake) - qemu: support qmp on RHEL/CentOS qemu (Eric Blake) - util: Include stdint.h because of uint32_t (Michal Privoznik) - Cast pointer to int using intptr_t (Marc-André Lureau) - build: fix header order on mingw (Eric Blake) - errcode is typedef by mingw, rename an argument name (Marc-André Lureau) - Add missing virGetGroupName() (Marc-André Lureau) - build: skip lxc with too-old glibc (Eric Blake) - Remove dmidecode dependancy outside PC arches (Daniel Veillard) - build: fix bootstrap on fresh clone (Eric Blake) - tests: Add qemuxml2argv tests for PPC64 pseries machine (Michael Ellerman) - tests: Teach qemuxml2argvtest about spapr-vio addresses (Michael Ellerman) - Disable netcf if building without libvirtd (Daniel P. Berrange) - build: fix build on mingw with netcf available (Eric Blake) - build: avoid spurious compiler warning (Eric Blake) Bug Fixes: - rpc: Plug memory leaks on doRemoteOpen() failure path (Alex Jia) - GetCPUStats: fix overflow test (Lai Jiangshan) - python: Correct arguments number for migrateSetMaxSpeed (Osier Yang) - qemu: fix persistent setting of blkiodevice weights (Eric Blake) - qemu: Fix memory leak when building -cpu argument (Jiri Denemark) - security: Driver 'none' cannot create confined guests (Jiri Denemark) - seclabel: Do not output relabel attribute for type 'none' (Jiri Denemark) - virsh: Plug memory leak on cmdDesc (Alex Jia) - virsh: Do not check the input XML at virsh layer for cmdDetachDevice (Osier Yang) - On systems with dmidecode version 2.10 or older, (Prerna Saxena) - storage: Don't unsparsify images when cloning (Cole Robinson) - build: don't require avahi during install (Laine Stump) - pyhton: Don't link against libvirt_util.la (Michal Privoznik) - xen-xm: SIGSEGV in xenXMDomainDefineXML: filename (Philipp Hahn) - xen-xm: fix data loss in domain edit (Philipp Hahn) - virsh: Fix resource leak while listing inactive domains with titles (Peter Krempa) - xen_xm: Fix SIGSEGV in xenXMDomainDefineXML (Philipp Hahn) - qemu: Fix seamless spice migration (Jiri Denemark) - apparmor: Add missing comma (Jiri Denemark) - virsh: Avoid invalid read of size errors (Alex Jia) - qemu: eliminate "Ignoring open failure" when using root-squash NFS (Laine Stump) - conf: Plug memory on virDomainDiskDefParseXML (Alex Jia) - virsh: Plug memory leak on cmdUndefine (Alex Jia) - network: fix testsuite regression (Eric Blake) - network: Avoid memory leaks on networkBuildDnsmasqArgv (Alex Jia) - python: correct a copy-paste error (Alex Jia) - qemu: Don't jump to endjob if no job was even started (Michal Privoznik) - qemu: fix my typo at commit 74e034964c32edb1732d0ff7642f3977f3587d72 (Taku Izumi) - qemu: Fix segfault in qemuMonitorTextGetBlockInfo (Hendrik Schwartke) - tests: fix reversed comparisons (Eric Blake) - qemu: avoid double free of qemu help output (Eric Blake) - apparmor: Fix use of uninitialized random_data (Jiri Denemark) - storage: Fix any VolLookupByPath if we have an empty logical pool (Cole Robinson) - Don't bind mount onto a char device for /dev/ptmx in LXC (Daniel P. Berrange) - xen: Don't crash when we fail to init caps (Guido Günther) - xen: properly report out of memory when hvm_type is too small (Guido Günther) - threads: check for failure to set thread-local value (Eric Blake) - Fix rpc generator to anchor matches for method names (Daniel P. Berrange) - Fix startup of LXC containers with filesystems containing symlinks (Daniel P. Berrange) - qemu: Prohibit reattaching node device if it is in use (Osier Yang) - qemu: Don't break domain with 0:0:2.0 assigned to anything but VGA (Jiri Denemark) - Fixed dumpxml of <iotune> parameters (Martin Kletzander) - nwfilter: fix typing error in filter (Stefan Berger) - events: Return the correct number of registered events (Adam Litke) - uuid: fix off-by-one (Eric Blake) - build: fix virsh reformat fallout (Eric Blake) - stream: Check for stream EOF (Michal Privoznik) - Do not generate security_model when fs driver is anything but 'path' (Deepak C Shetty) - qemu: check for kvm availability before starting kvm guests (Laine Stump) - qemu: fix a typo on qemuDomainSetBlkioParameters (Alex Jia) - config: report error when script given for inappropriate interface type (Laine Stump) Improvements: - python: make other APIs share common {get, set}PyVirTypedParameter (Guannan Ren) - npiv: Auto-generate WWN if it's not specified (Osier Yang) - Remove single quotes from audit records (Marcelo Cerri) - domain: add implicit USB controller (Marc-André Lureau) - python: refactoring virTypedParameter conversion for NUMA tuning APIs (Guannan Ren) - qemu: make blkiodevice weights easier to read (Eric Blake) - sysinfo: simplify function signature (Eric Blake) - Populate /dev/std{in,out,err} symlinks in LXC containers (Daniel P. Berrange) - Update symbols file for virFileDirectFd/virFileWrapperFd rename (Daniel P. Berrange) - virsh: Fix flag semantics and docs for "desc" command (Peter Krempa) - qemu: Always use iohelper for domain save (Jiri Denemark) - qemu: Always use iohelper for dumping domain core (Jiri Denemark) - util: Generalize virFileDirectFd (Jiri Denemark) - Allow polkit auth for VNC and SSH users (Cole Robinson) - seclabel: make code and RNG match (Eric Blake) - maint: Add test output files to .gitignore (Peter Krempa) - tests: Fix build with -Werror (Jiri Denemark) - maint: consolidate several .gitignore files (Eric Blake) - util: refactor virFileOpenAs (Laine Stump) - util: rename netlink.[ch] to virnetlink.[ch] (D. Herrendoerfer) - virsh: add --graceful switch to destroy command (Laine Stump) - qemu: new GRACEFUL flag for virDomainDestroy w/ QEMU support (Laine Stump) - Added missing memory reporting into python bindings (Martin Kletzander) - python: use libvirt_util to avoid raw free (Eric Blake) - build: expand rule to cover testsuite (Eric Blake) - build: prohibit raw malloc and free (Eric Blake) - build: clean up CPPFLAGS/INCLUDES usage (Eric Blake) - command: allow merging stdout and stderr in string capture (Eric Blake) - maint: prune duplicate listings in AUTHORS (Eric Blake) - virsh: extension of virsh attach-disk for rawio (Taku Izumi) - Fixed connection definition for non-SELinux builds (Martin Kletzander) - Added RSS reporting (Martin Kletzander) - Added RSS information gathering into qemudGetProcessInfo (Martin Kletzander) - Set a security context on /dev and /dev/pts mounts (Daniel P. Berrange) - Add two new security label types (Daniel P. Berrange) - Re-add domain device seclabel parsing / formatting (Daniel P. Berrange) - Revert changes to sec label parsing (Daniel P. Berrange) - tests: dynamically replace dnsmasq path (Philipp Hahn) - xen_xs: name xendConfigVersion magic numbers (Philipp Hahn) - block rebase: initial qemu implementation (Eric Blake) - block rebase: wire up remote protocol (Eric Blake) - qemu: Add support for virDomainGetMetadata and virDomainSetMetadata (Peter Krempa) - virsh: Add support for modifying domain description and titles (Peter Krempa) - xml: Add element <title> to allow short description of domains (Peter Krempa) - build: add missing virStorageFileResize to libvirt_private.syms (Laine Stump) - build: add missing virCommandAddCap to libvirt_private.syms (Laine Stump) - daemon: Allow overriding NOFILES ulimit for the daemon as well (Michal Privoznik) - python: Add binding for virDomainGetDiskErrors (Jiri Denemark) - virsh: Implement domblkerror command (Jiri Denemark) - qemu: Implement virDomainGetDiskErrors (Jiri Denemark) - Remote protocol for virDomainGetDiskErrors (Jiri Denemark) - command: Fix ATTRIBUTE_UNUSED on virSetCapabilities (Michal Privoznik) - simplify block of codes (Alex Jia) - qemu: make qemu processes to retain rawio capability (Taku Izumi) - util: extend virExecWithHook() (Taku Izumi) - util: add functions to keep capabilities (Taku Izumi) - Implement virStorageVolResize() for FS backend (Zeeshan Ali (Khattak)) - resize: slightly alter signature (Eric Blake) - qemu: add "romfile" support to specify device boot ROM (Laine Stump) - qemu: (and conf) support rombar for network devices (Laine Stump) - conf: relocate rombar and boot order parse/format (Laine Stump) - conf: put all guest-related HostdevDef data in one object (Laine Stump) - xen: Don't add <console> to xml for dom0 (Cole Robinson) - remote handler for virDomainGetCPUStats() (KAMEZAWA Hiroyuki) - virsh: Expose new virDomainPMSuspendForDuration API (Michal Privoznik) - resize: implement remote protocol for virStorageVolResize() (Zeeshan Ali (Khattak)) - Return more error output if policykit auth fails. (Cole Robinson) - Add new error code VIR_ERROR_AUTH_CANCELLED (Cole Robinson) - Move virEmitXMLWarning into xml.h (Daniel P. Berrange) - Move virMacAddrXXX functions to src/util/virmacaddr.[ch] (Daniel P. Berrange) - Rename virXXXXMacAddr to virMacAddrXXX (Daniel P. Berrange) - qemu: parse and create -cpu ...,-kvmclock (Paolo Bonzini) - conf: add kvmclock timer (Paolo Bonzini) - qemu: do not create useless <cpu> element (Paolo Bonzini) - qemu: get arch name from <cpu> element (Paolo Bonzini) - qemu: detect arch correctly for KVM (Paolo Bonzini) - x86: add kvm32 and kvm64, update qemu64 (Paolo Bonzini) - qemu: parse -enable-kvm (Paolo Bonzini) - qemu: require qmp on new enough qemu (Eric Blake) - nwfilter: Rebuild filters only if new filter is different than current (Stefan Berger) - nwfilter: Force instantiation of filters upon driver reload (Stefan Berger) - qemu: Refactor qemuMonitorGetBlockInfo (Jiri Denemark) - Update VIRT_CONTROL audit record with pid. (Marcelo Cerri) - build: allow for 64-bit pid in daemon (Eric Blake) - daemon: convert virRun to virCommand (Eric Blake) - hash: minor touchups (Eric Blake) - Replace hashing algorithm with murmurhash (Daniel P. Berrange) - Rename hash.h and hash.c to virhash.h and virhash.c (Daniel P. Berrange) - Convert various virHash functions to use size_t / uint32 (Daniel P. Berrange) - Introduce new API for generating random numbers (Daniel P. Berrange) - schema: Relax schema for domain name (Peter Krempa) - storage: Support different wiping algorithms (Michal Privoznik) - lxc: export container=lxc-libvirt for systemd (Eric Blake) - Add virFileTouch for creating empty files (Daniel P. Berrange) - virsh: Expose new VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE flag (Michal Privoznik) - snapshots: Introduce VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE flag (Michal Privoznik) - qemu_agent: Create file system freeze and thaw functions (Michal Privoznik) - qemu: Emit bootindex even for direct boot (Jiri Denemark) - metadata: group metadata next to description (Eric Blake) - build: simplify xmlFreeNode usage (Eric Blake) - Allow custom metadata in domain configuration XML (Zeeshan Ali (Khattak)) - virCommandProcessIO(): make poll() usage more robust (Laszlo Ersek) - Allow choice of shutdown method via virsh (Daniel P. Berrange) - Wire up QEMU agent to reboot/shutdown APIs (Daniel P. Berrange) - hashtest: Initialize variable in virHashEqual test (Michal Privoznik) - Add test case for virHashEqual function (Stefan Berger) - Compare two hash tables for equality (Stefan Berger) - virsh: let domif-{get,set}link take target name (Taku Izumi) - maint: cleanup qemu capabilities (Eric Blake) - maint: enforce use of _LAST marker (Eric Blake) - API: make declaration of _LAST enum values conditional (Eric Blake) - error: drop old-style error reporting (Eric Blake) - util: use new virTypedParameter helpers (Eric Blake) - util: add new file for virTypedParameter utils (Eric Blake) - lxc: use live/config helper (Eric Blake) - build: silence some compiler warnings from gnulib (Eric Blake) - Rename APIs for fetching UNIX socket credentials (Daniel P. Berrange) - Add virGetGroupName to convert from GID to group name (Daniel P. Berrange) - Remove duplicate call to virNetSASLSessionGetIdentity (Daniel P. Berrange) - Also retrieve GID from SO_PEERCRED (Daniel P. Berrange) - Added capability checking for block <iotune> setting. (Martin Kletzander) - qemu: Introduce inactive PCI device list (Osier Yang) - Permission change for systemtap examples. (Martin Kletzander) - Add new attribute wrpolicy to <driver> element (Deepak C Shetty) - tests: avoid dirname in tests (Eric Blake) - qemu: Add support for host CPU modes (Jiri Denemark) - Taint domains configured with cpu mode=host-passthrough (Jiri Denemark) - cpu: Update guest CPU in host-* mode (Jiri Denemark) - Add support for cpu mode attribute (Jiri Denemark) - cpu: Optionally forbid fallback CPU models (Jiri Denemark) - tests: Print XML file name in verbose CPU test (Jiri Denemark) - docs: Expose alias tag in domain RNG schema (Osier Yang) - docs: Add readonly to filesystem RNG schema (Osier Yang) - conf: Remove do-nothing validation functions (Michael Ellerman) - Make drive unit attribute optional in the XML schema (Michael Ellerman) - virsh domiflist: change output (Taku Izumi) - export virNetDevGetVirtualFunctions as a private symbol (Paolo Bonzini) - virsh: Two new fields for command domblklist (Osier Yang) - qemu: Support copy on read for disk (Osier Yang) - Added check for maximum number of vcpus exceeding topology limit (Martin Kletzander) - build: update to latest gnulib (Eric Blake) - Rsync keymaps.csv file with GTK-VNC (Daniel P. Berrange) - Re-write LXC controller end-of-file I/O handling yet again (Daniel P. Berrange) - Allow 10 chars for domain IDs & 30 chars for names in virsh list (Daniel P. Berrange) - virsh: New command print summary of all virtual interfaces (Osier Yang) - Added new option to virsh net-dumpxml called --inactive (Shradha Shah) - Functionality to implicitly get interface pool from SR-IOV PF. (Shradha Shah) - Adding the element pf to network xml. (Shradha Shah) - Added Function virNetDevGetVirtualFunctions (Shradha Shah) - Added function pciSysfsFile to enable access to the PCI SYSFS files. (Shradha Shah) - Add test cases for new ways to access variables in filters (Stefan Berger) - Address side effects of accessing vars via index (Stefan Berger) - Add access to elements of variables via index (Stefan Berger) - Introduce possibility to have an iterator per variable (Stefan Berger) - Optimize the elements the iterator visits. (Stefan Berger) - apparmor: Mark pid parameter as unused (Jiri Denemark) - Change security driver APIs to use virDomainDefPtr instead of virDomainObjPtr (Daniel P. Berrange) - snapshot: allow reuse of existing files in disk snapshot (Eric Blake) - PolicyKit: Check auth before asking client to obtain it (Jim Fehlig) - qemu: add new disk device='lun' for bus='virtio' & type='block' (Laine Stump) - qemu: add capabilities flags related to SG_IO (Laine Stump) - qemu: one more client to live/config helper (Eric Blake) Cleanups: - python: drop unused function (Eric Blake) - python: drop redundant function (Eric Blake) - Replace TAB with white spaces (Osier Yang) - qemu: Clenup qemuDomainSetInterfaceParameters (Michal Privoznik) - conf: remove duplicate call to VIR_FREE(info->alias) (Laine Stump) - xml: fix struct typos (Eric Blake) - Remove tabs from libvirt_public.syms & enforce it (Daniel P. Berrange) So thanks everybody for your contributions for this release, be it ideas, patches, or reports, enjoy, and let's shoot for another release within one month, keep the patches flowing ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

5 12

[libvirt] [Bug] [vbox-driver] attach-device
by Gravok 20 Feb '12

20 Feb '12

Hi, using the version from git I can't attach devices to my domain (using attach-device) neither using the virsh or a language binding. In both cases it throws a OutOfMemory exception. It gets thrown in vbox_tmpl.c:5340, although I got 7gb of RAM left. Am I doing something wrong, or is this a bug ? Thanks ! -- Empfehlen Sie GMX DSL Ihren Freunden und Bekannten und wir belohnen Sie mit bis zu 50,- Euro! https://freundschaftswerbung.gmx.de

2 3

Re: [libvirt] [virt-tools-list] virt-manager destroys symlinks to guest configs
by Cole Robinson 20 Feb '12

20 Feb '12

On 02/20/2012 11:21 AM, Jakub Mroziński wrote: > Hi, > virt-manager after saving guest config destroy symlink to this file and > creates new file. How to reproduce: > > cd /etc/libvirt/qemu > # mv openbsd.xml /mount/ > # ln -s /mount/openbsd.xml > # ls -l openbsd.xml > lrwxrwxrwx 1 root root 49 Feb 20 17:09 openbsd.xml -> /mount/openbsd.xml > # virt-manager > > Now we need to edit host openbsd in virt-manager then "Apply" changes and we got: > # ls -l openbsd.xml > -rw------- 1 root root 2076 Feb 20 17:13 openbsd.xml > > I have network storage and move every configuration there. On host i want have > only symlinks. I know that i can do workaround, but i dont want. > > This solution was working (i dont know on which version) fine but after > upgrade it doesn't work. > > virt-manager - 0.9.1-1 (debian testing) > virt-manager defers to libvirt for all changes like this. Did you update libvirt at the same time? - Cole

2 1

[libvirt] ANNOUNCE: libvirt-glib release 0.0.5
by Daniel P. Berrange 20 Feb '12

20 Feb '12

am pleased to announce that a new release of the libvirt-glib package, version 0.0.4 is now available from ftp://libvirt.org/libvirt/glib/ The packages are GPG signed with Key fingerprint: DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF (4096R) New in this release: - Require libvirt >= 0.9.10 - Fix error after finishing a stream - Use G_PARAM_STATIC_STRINGS - Add config for readonly disks - Add config for description/metadata - Fix type when creating storage volumes - Remove some bogus g_error usage - Import GNULIB's compiler warning flags support & fix problems - Add API for resizing storage volumes - Add API to check if a domain is saved - Add config for disk cache method - Add APIs to get node information - Add flags for deleting domains libvirt-glib comprises three distinct libraries: - libvirt-glib - Integrate with the GLib event loop and error handling - libvirt-gconfig - Representation of libvirt XML documents as GObjects - libvirt-gobject - Mapping of libvirt APIs into the GObject type system NB: While libvirt aims to be API/ABI stable, for the first few releases, we are *NOT* guaranteeing that libvirt-glib libraries are API/ABI stable. ABI stability will only be guaranteed once the bulk of the APIs have been fleshed out and proved in non-trivial application usage. We anticipate this will be within the next 6 months in order to line up with Fedora 17. Follow up comments about libvirt-glib should be directed to the regular libvir-list redhat com development list. Thanks to all the people involved in contributing to this release. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

1 0

Re: [libvirt] fix ix86 macros
by Eric Blake 20 Feb '12

20 Feb '12

On 02/17/2012 08:27 AM, Peter Robinson wrote: > commit 79ae809020d041ec2d10982a60a9eaf4782ca843 > Author: Peter Robinson <pbrobinson(a)gmail.com> > Date: Fri Feb 17 15:27:03 2012 +0000 > > fix ix86 macros > > libvirt.spec | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > --- > diff --git a/libvirt.spec b/libvirt.spec > index 2c7f6c0..d0b82bd 100644 > --- a/libvirt.spec > +++ b/libvirt.spec > @@ -22,7 +22,7 @@ > > # RHEL-5 builds are client-only for s390, ppc > %if 0%{?rhel} == 5 > -%ifnarch i386 i586 i686 x86_64 ia64 > +%ifnarch %{ix86} x86_64 ia64 ... Thanks for this fix. We'd also like to apply it to upstream libvirt.git, in the file libvirt.spec.in, so we don't have to repeat this type of fix in the future. Is it all right if I attribute such a patch in your name? -- Eric Blake eblake(a)redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org

2 2

[libvirt] [libvirt-glib] Fixes to gvir_domain_*save*() docs
by Zeeshan Ali (Khattak) 20 Feb '12

20 Feb '12

From: "Zeeshan Ali (Khattak)" <zeeshanak(a)gnome.org> The saved state of a domain is restored using gvir_domain_start() rather than gvir_domain_resume(). --- libvirt-gobject/libvirt-gobject-domain.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt-gobject/libvirt-gobject-domain.c b/libvirt-gobject/libvirt-gobject-domain.c index 0cbb0fe..23ad882 100644 --- a/libvirt-gobject/libvirt-gobject-domain.c +++ b/libvirt-gobject/libvirt-gobject-domain.c @@ -735,7 +735,7 @@ cleanup: * @flags: extra flags, currently unused * @err: Place-holder for possible errors * - * Saves the state of the domain on disk and stops it. Use #gvir_domain_resume + * Saves the state of the domain on disk and stops it. Use #gvir_domain_start * to restore the saved state of the domain. A saved domain can be restored * even after shutdown/reboot of host machine. * @@ -860,7 +860,7 @@ gboolean gvir_domain_get_persistent(GVirDomain *dom) * @dom: the domain * * Returns: TRUE if a stopped domain has a saved state to which it can be - * restored to using #gvir_domain_resume, FALSE otherwise. + * restored to using #gvir_domain_start, FALSE otherwise. */ gboolean gvir_domain_get_saved(GVirDomain *dom) { -- 1.7.7.6

2 1

[libvirt] [libvirt-glib] API to get node information about the connection
by Zeeshan Ali (Khattak) 20 Feb '12

20 Feb '12

From: "Zeeshan Ali (Khattak)" <zeeshanak(a)gnome.org> Mostly just a wrapper around virNodeGetInfo() and virNodeInfo struct. --- libvirt-gobject/libvirt-gobject-connection.c | 49 ++++++++++++++++++++++++++ libvirt-gobject/libvirt-gobject-connection.h | 17 +++++++++ libvirt-gobject/libvirt-gobject.sym | 2 + 3 files changed, 68 insertions(+), 0 deletions(-) diff --git a/libvirt-gobject/libvirt-gobject-connection.c b/libvirt-gobject/libvirt-gobject-connection.c index cb19e9d..fc8595d 100644 --- a/libvirt-gobject/libvirt-gobject-connection.c +++ b/libvirt-gobject/libvirt-gobject-connection.c @@ -71,6 +71,21 @@ gvir_connection_error_quark(void) return g_quark_from_static_string("gvir-connection"); } +static GVirNodeInfo * +gvir_node_info_copy(GVirNodeInfo *info) +{ + return g_slice_dup(GVirNodeInfo, info); +} + +static void +gvir_node_info_free(GVirNodeInfo *info) +{ + g_slice_free(GVirNodeInfo, info); +} + +G_DEFINE_BOXED_TYPE(GVirNodeInfo, gvir_node_info, + gvir_node_info_copy, gvir_node_info_free) + static void gvir_connection_get_property(GObject *object, guint prop_id, GValue *value, @@ -1338,3 +1353,37 @@ GVirStoragePool *gvir_connection_create_storage_pool return g_object_ref(pool); } + +/** + * gvir_connection_get_node_info: + * @conn: the connection + * @err: return location for any #GError + * + * Returns: (transfer full): the info + */ +GVirNodeInfo *gvir_connection_get_node_info(GVirConnection *conn, + GError **err) +{ + GVirConnectionPrivate *priv = conn->priv; + virNodeInfo info; + GVirNodeInfo *ret; + + if (virNodeGetInfo(priv->conn, &info) < 0) { + gvir_set_error_literal(err, GVIR_CONNECTION_ERROR, + 0, + "Unable to get node info"); + return NULL; + } + + ret = g_slice_new(GVirNodeInfo); + g_utf8_strncpy (ret->model, info.model, sizeof (ret->model)); + ret->memory = info.memory; + ret->cpus = info.cpus; + ret->mhz = info.mhz; + ret->nodes = info.nodes; + ret->sockets = info.sockets; + ret->cores = info.cores; + ret->threads = info.threads; + + return ret; +} diff --git a/libvirt-gobject/libvirt-gobject-connection.h b/libvirt-gobject/libvirt-gobject-connection.h index 477a0c3..3cc60a2 100644 --- a/libvirt-gobject/libvirt-gobject-connection.h +++ b/libvirt-gobject/libvirt-gobject-connection.h @@ -38,6 +38,19 @@ G_BEGIN_DECLS #define GVIR_TYPE_CONNECTION_HANDLE (gvir_connection_handle_get_type ()) +typedef struct _GVirNodeInfo GVirNodeInfo; +struct _GVirNodeInfo +{ + gchar model[32]; /* string indicating the CPU model */ + gulong memory; /* memory size in kilobytes */ + guint cpus; /* the number of active CPUs */ + guint mhz; /* expected CPU frequency */ + guint nodes; /* the number of NUMA cell, 1 for unusual NUMA topologies or uniform memo */ + guint sockets; /* number of CPU sockets per node if nodes > 1, total number of CPU socke */ + guint cores; /* number of cores per socket */ + guint threads; /* number of threads per core */ +}; + typedef struct _GVirConnection GVirConnection; typedef struct _GVirConnectionPrivate GVirConnectionPrivate; typedef struct _GVirConnectionClass GVirConnectionClass; @@ -69,6 +82,7 @@ struct _GVirConnectionClass GType gvir_connection_get_type(void); GType gvir_connection_handle_get_type(void); +GType gvir_node_info_get_type(void); GVirConnection *gvir_connection_new(const char *uri); gboolean gvir_connection_open(GVirConnection *conn, @@ -174,6 +188,9 @@ GVirStoragePool *gvir_connection_create_storage_pool GVirStream *gvir_connection_get_stream(GVirConnection *conn, guint flags); +GVirNodeInfo *gvir_connection_get_node_info(GVirConnection *conn, + GError **err); + G_END_DECLS #endif /* __LIBVIRT_GOBJECT_CONNECTION_H__ */ diff --git a/libvirt-gobject/libvirt-gobject.sym b/libvirt-gobject/libvirt-gobject.sym index a02191e..1ad6b53 100644 --- a/libvirt-gobject/libvirt-gobject.sym +++ b/libvirt-gobject/libvirt-gobject.sym @@ -4,6 +4,7 @@ LIBVIRT_GOBJECT_0.0.4 { gvir_init_object_check; gvir_connection_get_type; + gvir_node_info_get_type; gvir_connection_new; gvir_connection_open; gvir_connection_open_async; @@ -29,6 +30,7 @@ LIBVIRT_GOBJECT_0.0.4 { gvir_connection_create_domain; gvir_connection_create_storage_pool; gvir_connection_start_domain; + gvir_connection_get_node_info; gvir_domain_device_get_type; -- 1.7.7.6

2 1

[libvirt] [libvirt-glib 1/2] API to get node information about the connection
by Zeeshan Ali (Khattak) 20 Feb '12

20 Feb '12

From: "Zeeshan Ali (Khattak)" <zeeshanak(a)gnome.org> Mostly just a wrapper around virNodeGetInfo() and virNodeInfo struct. --- libvirt-gobject/libvirt-gobject-connection.c | 49 ++++++++++++++++++++++++++ libvirt-gobject/libvirt-gobject-connection.h | 17 +++++++++ libvirt-gobject/libvirt-gobject.sym | 1 + 3 files changed, 67 insertions(+), 0 deletions(-) diff --git a/libvirt-gobject/libvirt-gobject-connection.c b/libvirt-gobject/libvirt-gobject-connection.c index cb19e9d..c2691f7 100644 --- a/libvirt-gobject/libvirt-gobject-connection.c +++ b/libvirt-gobject/libvirt-gobject-connection.c @@ -71,6 +71,21 @@ gvir_connection_error_quark(void) return g_quark_from_static_string("gvir-connection"); } +static GVirNodeInfo * +gvir_node_info_copy(GVirNodeInfo *info) +{ + return g_slice_dup(GVirNodeInfo, info); +} + +static void +gvir_node_info_free(GVirNodeInfo *info) +{ + g_slice_free(GVirNodeInfo, info); +} + +G_DEFINE_BOXED_TYPE(GVirNodeInfo, gvir_node_info, + gvir_node_info_copy, gvir_node_info_free) + static void gvir_connection_get_property(GObject *object, guint prop_id, GValue *value, @@ -1338,3 +1353,37 @@ GVirStoragePool *gvir_connection_create_storage_pool return g_object_ref(pool); } + +/** + * gvir_connection_get_node_info: + * @conn: the connection + * @err: return location for any #GError + * + * Returns: (transfer full): the info + */ +GVirNodeInfo *gvir_connection_get_node_info(GVirConnection *conn, + GError **err) +{ + GVirConnectionPrivate *priv = conn->priv; + virNodeInfo info; + GVirNodeInfo *ret; + + if (virNodeGetInfo(priv->conn, &info) < 0) { + gvir_set_error_literal(err, GVIR_CONNECTION_ERROR, + 0, + "Unable to get node info"); + return NULL; + } + + ret = g_slice_new(GVirNodeInfo); + g_memmove (ret->model, info.model, sizeof (ret->model)); + ret->memory = info.memory; + ret->cpus = info.cpus; + ret->mhz = info.mhz; + ret->nodes = info.nodes; + ret->sockets = info.sockets; + ret->cores = info.cores; + ret->threads = info.threads; + + return ret; +} diff --git a/libvirt-gobject/libvirt-gobject-connection.h b/libvirt-gobject/libvirt-gobject-connection.h index 477a0c3..3cc60a2 100644 --- a/libvirt-gobject/libvirt-gobject-connection.h +++ b/libvirt-gobject/libvirt-gobject-connection.h @@ -38,6 +38,19 @@ G_BEGIN_DECLS #define GVIR_TYPE_CONNECTION_HANDLE (gvir_connection_handle_get_type ()) +typedef struct _GVirNodeInfo GVirNodeInfo; +struct _GVirNodeInfo +{ + gchar model[32]; /* string indicating the CPU model */ + gulong memory; /* memory size in kilobytes */ + guint cpus; /* the number of active CPUs */ + guint mhz; /* expected CPU frequency */ + guint nodes; /* the number of NUMA cell, 1 for unusual NUMA topologies or uniform memo */ + guint sockets; /* number of CPU sockets per node if nodes > 1, total number of CPU socke */ + guint cores; /* number of cores per socket */ + guint threads; /* number of threads per core */ +}; + typedef struct _GVirConnection GVirConnection; typedef struct _GVirConnectionPrivate GVirConnectionPrivate; typedef struct _GVirConnectionClass GVirConnectionClass; @@ -69,6 +82,7 @@ struct _GVirConnectionClass GType gvir_connection_get_type(void); GType gvir_connection_handle_get_type(void); +GType gvir_node_info_get_type(void); GVirConnection *gvir_connection_new(const char *uri); gboolean gvir_connection_open(GVirConnection *conn, @@ -174,6 +188,9 @@ GVirStoragePool *gvir_connection_create_storage_pool GVirStream *gvir_connection_get_stream(GVirConnection *conn, guint flags); +GVirNodeInfo *gvir_connection_get_node_info(GVirConnection *conn, + GError **err); + G_END_DECLS #endif /* __LIBVIRT_GOBJECT_CONNECTION_H__ */ diff --git a/libvirt-gobject/libvirt-gobject.sym b/libvirt-gobject/libvirt-gobject.sym index 7a2f65d..9e63773 100644 --- a/libvirt-gobject/libvirt-gobject.sym +++ b/libvirt-gobject/libvirt-gobject.sym @@ -4,6 +4,7 @@ LIBVIRT_GOBJECT_0.0.4 { gvir_init_object_check; gvir_connection_get_type; + gvir_node_info_get_type; gvir_connection_new; gvir_connection_open; gvir_connection_open_async; -- 1.7.7.6

2 5

[libvirt] libvirt-0.9.10.1 maybe?
by Doug Goldstein 20 Feb '12

20 Feb '12

Given the issues discovered after 0.9.10's release I was wondering if you guys wanted to put out a 0.9.10.1. Here's the list of the patches I've cherry picked based on the list comments and think would qualify. If not that's ok. 18942b9bea8a5a8a4d52c0cdde253ae91be338a6 e0d4b0db9e4cc045d9660f955ddccfabd098a91b 2ccc4a607f6e122aff2e3b9d133d6e6b4b661a1e fcdfa31f3cad32f41ef5e7933c58d986ab7fc6c9 c05ec920219dc9fad9230c3cea7c1fb17d29ddc3 4c1c361127b6f5ce56be980ca7ea06f829c53399 15a280bb6d2de16b2f54dd7ca667a5a69363558c d2728cc24581d8a2f40c7ffed2a10fd2da79015f -- Doug Goldstein

1 0

[libvirt] [PATCH 0/10]virtio-scsi: New device address logic for SCSI devices
by Osier Yang 17 Feb '12

17 Feb '12

This patch series completed the support for the first 3 parts of Paolo's proposal: http://permalink.gmane.org/gmane.comp.emulators.libvirt/50428 The 3 parts are: * SCSI controller models * Stable addressing for SCSI devices * LUN passthrough: block devices [PATCH 1/10] and [PATCH 2/10] add two new "scsi" controllers, "ibmvscsi" and "virtio-scsi". [PATCH 3/10] is to set the default controller model for scsi controller when parsing and implicit controller addtion. [PATCH 4/10] adds a helper functions to get a disk controller's model. [PATCH 5/10] introduces attribute "target" for device addressing XML. "target" is useless for model "lsilogic", for which it's not printed out when formating XML. [PATCH 7/10] builds the qemu command line for the new addressing format. The logic is: 1) If the disk controller model is "lsilogic": -drive file=/dev/sda,if=none,id=drive-scsi0-0-3,\ format=raw -device scsi-disk,bus=scsi0.0,\ scsi-id=0,drive=drive-scsi0-0-3-0,id=scsi0-0-3-0 libvirt attrs --> qdev properties: bus=scsi<controller>.0 scsi-id=<unit> 2) If the disk controller model is other else: The command line will be like: -drive file=/dev/sda,if=none,id=drive-scsi0-0-3-0,\ format=raw -device scsi-disk,bus=scsi0.0,channel=0,\ scsi-id=3,lun=0,drive=drive-scsi0-0-3-0,id=scsi0-0-3-0 libvirt attrs --> qdev properties: bus=scsi<controller>.0 channel=<bus> scsi-id=<target> lun=<unit> [PATCH 01/10] qemu: Add ibmvscsi controller model [PATCH 02/10] qemu: Add virtio-scsi controller model [PATCH 03/10] conf: Set default scsi controller model when parsing [PATCH 04/10] conf: Add helper function to look up disk controller [PATCH 05/10] conf: Introduce new attribute for device address [PATCH 06/10] qemu: New cap flag to indicate if channel is supported [PATCH 07/10] qemu: Build command line for the new address format [PATCH 08/10] tests: Update qemu tests to be consistent with new [PATCH 09/10] tests: Update vmx tests to be consistent with new [PATCH 10/10] tests: Add tests for virtio-scsi and ibmvscsi Regards, Osier

2 19