- Devel - libvirt List Archives

[libvirt] [PATCHv3 1/2] add parameter flags to D.get_cpu_stats()
by Hu Tao 27 Apr '12

27 Apr '12

--- examples/get_cpu_stats.ml | 2 +- libvirt/libvirt.ml | 6 +++++- libvirt/libvirt.mli | 6 +++++- libvirt/libvirt_c_oneoffs.c | 21 +++++++++++++++++---- 4 files changed, 28 insertions(+), 7 deletions(-) diff --git a/examples/get_cpu_stats.ml b/examples/get_cpu_stats.ml index 79d5c3c..962a2a4 100644 --- a/examples/get_cpu_stats.ml +++ b/examples/get_cpu_stats.ml @@ -25,7 +25,7 @@ let () = let stats = let dom = D.lookup_by_name conn domname in - D.get_cpu_stats dom nr_pcpus in + D.get_cpu_stats dom nr_pcpus [D.None;] in Array.iteri ( fun n params -> diff --git a/libvirt/libvirt.ml b/libvirt/libvirt.ml index 53c5bb4..de303f7 100644 --- a/libvirt/libvirt.ml +++ b/libvirt/libvirt.ml @@ -348,6 +348,10 @@ struct | TypedFieldFloat of float | TypedFieldBool of bool | TypedFieldString of string + type get_cpu_stats_flags = + | None + | Vcpu + type migrate_flag = Live type memory_flag = Virtual @@ -417,7 +421,7 @@ struct external set_vcpus : [>`W] t -> int -> unit = "ocaml_libvirt_domain_set_vcpus" external pin_vcpu : [>`W] t -> int -> string -> unit = "ocaml_libvirt_domain_pin_vcpu" external get_vcpus : [>`R] t -> int -> int -> int * vcpu_info array * string = "ocaml_libvirt_domain_get_vcpus" - external get_cpu_stats : [>`R] t -> int -> typed_param list array = "ocaml_libvirt_domain_get_cpu_stats" + external get_cpu_stats : [>`R] t -> int -> get_cpu_stats_flags list -> typed_param list array = "ocaml_libvirt_domain_get_cpu_stats" external get_max_vcpus : [>`R] t -> int = "ocaml_libvirt_domain_get_max_vcpus" external attach_device : [>`W] t -> xml -> unit = "ocaml_libvirt_domain_attach_device" external detach_device : [>`W] t -> xml -> unit = "ocaml_libvirt_domain_detach_device" diff --git a/libvirt/libvirt.mli b/libvirt/libvirt.mli index 0913a63..5a7e536 100644 --- a/libvirt/libvirt.mli +++ b/libvirt/libvirt.mli @@ -442,6 +442,10 @@ sig | TypedFieldFloat of float | TypedFieldBool of bool | TypedFieldString of string + type get_cpu_stats_flags = + | None + | Vcpu + type migrate_flag = Live type memory_flag = Virtual @@ -559,7 +563,7 @@ sig for a domain. See the libvirt documentation for details of the array and bitmap returned from this function. *) - val get_cpu_stats : [>`R] t -> int -> typed_param list array + val get_cpu_stats : [>`R] t -> int -> get_cpu_stats_flags list -> typed_param list array (** [get_pcpu_stats dom nr_pcpu] returns the physical CPU stats for a domain. See the libvirt documentation for details. *) diff --git a/libvirt/libvirt_c_oneoffs.c b/libvirt/libvirt_c_oneoffs.c index 3d42b73..5d1e8b2 100644 --- a/libvirt/libvirt_c_oneoffs.c +++ b/libvirt/libvirt_c_oneoffs.c @@ -532,20 +532,33 @@ extern int virDomainGetCPUStats (virDomainPtr domain, #endif CAMLprim value -ocaml_libvirt_domain_get_cpu_stats (value domv, value nr_pcpusv) +ocaml_libvirt_domain_get_cpu_stats (value domv, value nr_pcpusv, value flagsv) { #ifdef HAVE_VIRDOMAINGETCPUSTATS - CAMLparam2 (domv, nr_pcpusv); + CAMLparam3 (domv, nr_pcpusv, flagsv); CAMLlocal5 (cpustats, param_head, param_node, typed_param, typed_param_value); CAMLlocal1 (v); virDomainPtr dom = Domain_val (domv); virConnectPtr conn = Connect_domv (domv); int nr_pcpus = Int_val (nr_pcpusv); + int flags = 0; virTypedParameterPtr params; int r, cpu, ncpus, nparams, i, j, pos; + /* Iterate over the list of flags. */ + for (; flagsv != Val_int (0); flagsv = Field (flagsv, 1)) + { + switch (Int_val(Field(flagsv, 0))) { + case 1: /* Vcpu */ + flags |= VIR_DOMAIN_CPU_STATS_VCPU; + break; + default: + break; + } + } + /* get percpu information */ - NONBLOCKING (nparams = virDomainGetCPUStats(dom, NULL, 0, 0, 1, 0)); + NONBLOCKING (nparams = virDomainGetCPUStats(dom, NULL, 0, 0, 1, flags)); CHECK_ERROR (nparams < 0, conn, "virDomainGetCPUStats"); if ((params = malloc(sizeof(*params) * nparams * 128)) == NULL) @@ -556,7 +569,7 @@ ocaml_libvirt_domain_get_cpu_stats (value domv, value nr_pcpusv) while (cpu < nr_pcpus) { ncpus = nr_pcpus - cpu > 128 ? 128 : nr_pcpus - cpu; - NONBLOCKING (r = virDomainGetCPUStats(dom, params, nparams, cpu, ncpus, 0)); + NONBLOCKING (r = virDomainGetCPUStats(dom, params, nparams, cpu, ncpus, flags)); CHECK_ERROR (r < 0, conn, "virDomainGetCPUStats"); for (i = 0; i < ncpus; i++) { -- 1.7.1

1 2

[libvirt] How to disconnect a NIC
by Hendrik Schwartke 27 Apr '12

27 Apr '12

Hi, some time ago I wrote I patch to change the source bridge of a running domain. Now I'm wondering what's the best way to disconnect a NIC. My first thought was to set virDomainNetDef.data.bridge.brname to NULL. There are quite some places in the code that had to be modified to support this, but that should be doable. Another idea is to create a new interface type 'disconnected'. The purpose of this type would be specifying NICs (whose link state is either up or down) without any network connectivity. The type of this interface had to be changeable while the domain is running. Any thoughts would greatly appreciated. Hendrik Schwartke

1 0

[libvirt] Files too long for tar archive
by Cole Robinson 27 Apr '12

27 Apr '12

In building the libvirt-0.9.11.2 stable tarball, I saw these errors: tar: libvirt-0.9.11.2/tests/nodeinfodata/linux-nodeinfo-sysfs-test-1/cpu/cpu0/topology/thread_siblings_list: file name is too long (max 99); not dumped tar: libvirt-0.9.11.2/tests/nodeinfodata/linux-nodeinfo-sysfs-test-1/cpu/cpu0/topology/physical_package_id: file name is too long (max 99); not dumped tar: libvirt-0.9.11.2/tests/nodeinfodata/linux-nodeinfo-sysfs-test-1/cpu/cpu1/topology/thread_siblings_list: file name is too long (max 99); not dumped tar: libvirt-0.9.11.2/tests/nodeinfodata/linux-nodeinfo-sysfs-test-1/cpu/cpu1/topology/physical_package_id: file name is too long (max 99); not dumped tar: Exiting with failure status due to previous errors As indicated the files were not in the tarball. Can we just update the tar format in configure or does that come with caveats? Thanks, Cole

2 1

[libvirt] udevadm settle can take too long
by Jim Paris 27 Apr '12

27 Apr '12

Hi, http://bugs.debian.org/663931 is a bug I'm hitting, where virt-manager times out on the initial connection to libvirt. The basic problem is that, while checking storage volumes, virt-manager causes libvirt to call "udevadm settle". There's an interaction where libvirt's earlier use of network namespaces (to probe LXC features) had caused some uevents to be sent that get filtered out before they reach udev. This confuses "udevadm settle" a bit, and so it sits there waiting for a 2-3 minute built-in timeout before returning. Eventually libvirtd prints: 2012-04-22 18:22:18.678+0000: 30503: warning : virKeepAliveTimer:182 : No response from client 0x7feec4003630 after 5 keepalive messages in 30 seconds and virt-manager prints: 2012-04-22 18:22:18.931+0000: 30647: warning : virKeepAliveSend:128 : Failed to send keepalive response to client 0x25004e0 and the connection gets dropped. One workaround could be to specify a shorter timeout when doing the settle. The patch appended below allows virt-manager to work, although the connection still has to wait for the 10 second timeout before it succeeds. I don't know what a better solution would be, though. It seems the udevadm behavior might not be considered a bug from the udev/kernel point of view: https://lkml.org/lkml/2012/4/22/60 I'm using Linux 3.2.14 with libvirt 0.9.11. You can trigger the udevadm issue using a program I posted at the Debian bug report link above. -jim >From 17e5b9ebab76acb0d711e8bc308023372fbc4180 Mon Sep 17 00:00:00 2001 From: Jim Paris <jim(a)jtan.com> Date: Sun, 22 Apr 2012 14:35:47 -0400 Subject: [PATCH] shorten udevadmin settle timeout Otherwise, udevadmin settle can take so long that connections from e.g. virt-manager will get closed. --- src/util/util.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/util.c b/src/util/util.c index 6e041d6..dfe458e 100644 --- a/src/util/util.c +++ b/src/util/util.c @@ -2593,9 +2593,9 @@ virFileFindMountPoint(const char *type ATTRIBUTE_UNUSED) void virFileWaitForDevices(void) { # ifdef UDEVADM - const char *const settleprog[] = { UDEVADM, "settle", NULL }; + const char *const settleprog[] = { UDEVADM, "settle", "--timeout", "10", NULL }; # else - const char *const settleprog[] = { UDEVSETTLE, NULL }; + const char *const settleprog[] = { UDEVSETTLE, "--timeout", "10", NULL }; # endif int exitstatus; -- 1.7.7

3 5

[libvirt] [PATCH] qemu: improve errors related to offline domains
by Eric Blake 26 Apr '12

26 Apr '12

https://bugzilla.redhat.com/show_bug.cgi?id=816662 pointed out that attempting 'virsh blockpull' on an offline domain gave a misleading error message about qemu lacking support for the operation, even when qemu was specifically updated to support it. The real problem is that we have several capabilities that are only determined when starting a domain, and therefore are still clear when first working with an inactive domain (namely, any capability set by qemuMonitorJSONCheckCommands). While this patch was able to hoist an existing check in one of the three culprits, it had to add redundant checks in the other two places (because you always have to check for an active domain after obtaining a VM job lock, but the capability bits were being checked prior to obtaining the job lock). Someday it would be nice to patch libvirt to cache the set of capabilities per qemu binary (as determined by inode and timestamp), rather than re-probing the binary every time a domain is started, and to teach the cache how to query the monitor during the one time the probe is made rather than having to wait until a guest is started; then, a capability probe would succeed even for offline guests because it just refers to the cache, and the single check for an active domain after grabbing the job lock would be sufficient. But since that will involve a lot more coding, I'm happy to go with this simpler solution for an immediate solution. * src/qemu/qemu_driver.c (qemuDomainPMSuspendForDuration) (qemuDomainSnapshotCreateXML, qemuDomainBlockJobImpl): Check for offline state before checking an online-only cap. --- src/qemu/qemu_driver.c | 24 ++++++++++++++++++------ 1 files changed, 18 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index d3aa34d..3a1c1c4 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -10389,6 +10389,12 @@ qemuDomainSnapshotCreateXML(virDomainPtr domain, goto cleanup; if (flags & VIR_DOMAIN_SNAPSHOT_CREATE_DISK_ONLY) { + if (!virDomainObjIsActive(vm)) { + qemuReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("disk snapshots of inactive domains not " + "implemented yet")); + goto cleanup; + } if (virDomainSnapshotAlignDisks(def, VIR_DOMAIN_DISK_SNAPSHOT_EXTERNAL, false) < 0) @@ -10443,12 +10449,6 @@ qemuDomainSnapshotCreateXML(virDomainPtr domain, * makes sense, such as checking that qemu-img recognizes the * snapshot name in at least one of the domain's disks? */ } else if (flags & VIR_DOMAIN_SNAPSHOT_CREATE_DISK_ONLY) { - if (!virDomainObjIsActive(vm)) { - qemuReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("disk snapshots of inactive domains not " - "implemented yet")); - goto cleanup; - } if (qemuDomainSnapshotCreateDiskActive(domain->conn, driver, &vm, snap, flags) < 0) goto cleanup; @@ -11642,6 +11642,12 @@ qemuDomainBlockJobImpl(virDomainPtr dom, const char *path, const char *base, _("no domain with matching uuid '%s'"), uuidstr); goto cleanup; } + if (!virDomainObjIsActive(vm)) { + qemuReportError(VIR_ERR_OPERATION_INVALID, "%s", + _("domain is not running")); + goto endjob; + } + priv = vm->privateData; if (qemuCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKJOB_ASYNC)) { async = true; @@ -12637,6 +12643,12 @@ qemuDomainPMSuspendForDuration(virDomainPtr dom, priv = vm->privateData; + if (!virDomainObjIsActive(vm)) { + qemuReportError(VIR_ERR_OPERATION_INVALID, + "%s", _("domain is not running")); + goto endjob; + } + if (!qemuCapsGet(priv->qemuCaps, QEMU_CAPS_WAKEUP) && (target == VIR_NODE_SUSPEND_TARGET_MEM || target == VIR_NODE_SUSPEND_TARGET_HYBRID)) { -- 1.7.7.6

2 3

[libvirt] (no subject)
by Shi Jin 26 Apr '12

26 Apr '12

http://asshappens.com/wp-content/plugins/bmorn.html?zr=aa.gffz&zny=ggj.ffnf…

1 0

[libvirt] [PATCH] macvtap: fix a typo
by Stefan Berger 26 Apr '12

26 Apr '12

Below patch fixes the following coverity findings Error: OVERRUN_STATIC: /libvirt/src/qemu/qemu_command.c:152: overrun-buffer-val: Overrunning static array "net->mac" of size 6 bytes by passing it as an argument to a function which indexes it at byte position 15. /libvirt/src/util/virnetdevmacvlan.c:948: access_dbuff_const: Calling "virNetDevMacVLanVPortProfileRegisterCallback" indexes array "macaddress" at byte position 15. /libvirt/src/util/virnetdevmacvlan.c:773: access_dbuff_const: Calling "memcpy" indexes array "macaddress" with index "16UL" at byte position 15. Error: OVERRUN_STATIC: /libvirt/src/qemu/qemu_migration.c:2744: overrun-buffer-val: Overrunning static array "net->mac" of size 6 bytes by passing it as an argument to a function which indexes it at byte position 15. /libvirt/src/util/virnetdevmacvlan.c:773: access_dbuff_const: Calling "memcpy" indexes array "macaddress" with index "16UL" at byte position 15. Error: OVERRUN_STATIC: /libvirt/src/qemu/qemu_driver.c:435: overrun-buffer-val: Overrunning static array "net->mac" of size 6 bytes by passing it as an argument to a function which indexes it at byte position 15. /libvirt/src/util/virnetdevmacvlan.c:1036: access_dbuff_const: Calling "virNetDevMacVLanVPortProfileRegisterCallback" indexes array "macaddress" at byte position 15. /libvirt/src/util/virnetdevmacvlan.c:773: access_dbuff_const: Calling "memcpy" indexes array "macaddress" with index "16UL" at byte position 15. --- src/util/virnetdevmacvlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: libvirt-acl/src/util/virnetdevmacvlan.c =================================================================== --- libvirt-acl.orig/src/util/virnetdevmacvlan.c +++ libvirt-acl/src/util/virnetdevmacvlan.c @@ -435,7 +435,7 @@ static const uint32_t modeMap[VIR_NETDEV struct virNetlinkCallbackData { char *cr_ifname; virNetDevVPortProfilePtr virtPortProfile; - unsigned char macaddress[VIR_UUID_BUFLEN]; + unsigned char macaddress[VIR_MAC_BUFLEN]; char *linkdev; int vf; unsigned char vmuuid[VIR_UUID_BUFLEN];

2 1

[libvirt] [PATCH 1/2] [TCK] nwfilter: Adapt test program and cases to recent iptables
by Stefan Berger 26 Apr '12

26 Apr '12

Recent iptables fixes a lot of issues with missing spaces and other information that was previously not reported properly. To make the test program and test cases work on old and newer installations of iptables tools, some adjustments need to be made. Fix a 'file not found error' when running this tool from the shell directly. --- scripts/nwfilter/nwfilter2vmtest.sh | 6 +++--- scripts/nwfilter/nwfilterxml2fwallout/conntrack-test.fwall | 12 ++++++------ 2 files changed, 9 insertions(+), 9 deletions(-) Index: libvirt-tck/scripts/nwfilter/nwfilter2vmtest.sh =================================================================== --- libvirt-tck.orig/scripts/nwfilter/nwfilter2vmtest.sh +++ libvirt-tck/scripts/nwfilter/nwfilter2vmtest.sh @@ -9,7 +9,7 @@ VIRSH=virsh # For each line starting with uri=, remove the prefix and set the hold # space to the rest of the line. Then at file end, print the hold # space, which is effectively the last uri= line encountered. -uri=$(sed -n '/^uri[ ]*=[ ]*/ { +[ -r "$LIBVIRT_TCK_CONFIG" ] && uri=$(sed -n '/^uri[ ]*=[ ]*/ { s/// h } @@ -147,12 +147,12 @@ checkExpectedOutput() { break fi - diff ${tmpfile} ${tmpfile2} >/dev/null + diff -w ${tmpfile} ${tmpfile2} >/dev/null if [ $? -ne 0 ]; then if [ $(($flags & $FLAG_VERBOSE)) -ne 0 ]; then echo "FAIL ${xmlfile} : ${cmd}" - diff ${tmpfile} ${tmpfile2} + diff -w ${tmpfile} ${tmpfile2} fi failctr=$(($failctr + 1)) if [ $(($flags & $FLAG_WAIT)) -ne 0 ]; then Index: libvirt-tck/scripts/nwfilter/nwfilterxml2fwallout/conntrack-test.fwall =================================================================== --- libvirt-tck.orig/scripts/nwfilter/nwfilterxml2fwallout/conntrack-test.fwall +++ libvirt-tck/scripts/nwfilter/nwfilterxml2fwallout/conntrack-test.fwall @@ -1,18 +1,18 @@ -#iptables -L FI-vnet0 -n +#iptables -L FI-vnet0 -n | sed 's|#conn/|#conn src/|' Chain FI-vnet0 (1 references) target prot opt source destination -DROP icmp -- 0.0.0.0/0 0.0.0.0/0 #conn/32 > 1 -DROP tcp -- 0.0.0.0/0 0.0.0.0/0 #conn/32 > 2 +DROP icmp -- 0.0.0.0/0 0.0.0.0/0 #conn src/32 > 1 +DROP tcp -- 0.0.0.0/0 0.0.0.0/0 #conn src/32 > 2 RETURN all -- 0.0.0.0/0 0.0.0.0/0 state NEW,ESTABLISHED ctdir REPLY #iptables -L FO-vnet0 -n Chain FO-vnet0 (1 references) target prot opt source destination ACCEPT all -- 0.0.0.0/0 0.0.0.0/0 state ESTABLISHED ctdir ORIGINAL -#iptables -L HI-vnet0 -n +#iptables -L HI-vnet0 -n | sed 's|#conn/|#conn src/|' Chain HI-vnet0 (1 references) target prot opt source destination -DROP icmp -- 0.0.0.0/0 0.0.0.0/0 #conn/32 > 1 -DROP tcp -- 0.0.0.0/0 0.0.0.0/0 #conn/32 > 2 +DROP icmp -- 0.0.0.0/0 0.0.0.0/0 #conn src/32 > 1 +DROP tcp -- 0.0.0.0/0 0.0.0.0/0 #conn src/32 > 2 RETURN all -- 0.0.0.0/0 0.0.0.0/0 state NEW,ESTABLISHED ctdir REPLY #iptables -L libvirt-host-in -n | grep vnet0 | tr -s " " HI-vnet0 all -- 0.0.0.0/0 0.0.0.0/0 [goto] PHYSDEV match --physdev-in vnet0

2 2

[libvirt] [PATCH] util: fix error messages in virNetlinkEventServiceStart
by Laine Stump 26 Apr '12

26 Apr '12

Some of the error messages in this function should have been virReportSystemError (since they have an errno they want to log), but were mistakenly written as netlinkError, which expects a libvirt error code instead. The result was that when one of the errors was encountered, "No error message provided" would be printed instead of something meaningful (see https://bugzilla.redhat.com/show_bug.cgi?id=816465 for an example). --- src/util/virnetlink.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c index 7017275..b2e9d51 100644 --- a/src/util/virnetlink.c +++ b/src/util/virnetlink.c @@ -238,8 +238,8 @@ virNetlinkEventCallback(int watch, if (length == 0) return; if (length < 0) { - netlinkError(errno, - "%s", _("nl_recv returned with error")); + virReportSystemError(errno, + "%s", _("nl_recv returned with error")); return; } @@ -349,28 +349,28 @@ virNetlinkEventServiceStart(void) srv->netlinknh = nl_handle_alloc(); if (!srv->netlinknh) { - netlinkError(errno, - "%s", _("cannot allocate nlhandle for virNetlinkEvent server")); + virReportSystemError(errno, + "%s", _("cannot allocate nlhandle for virNetlinkEvent server")); goto error_locked; } if (nl_connect(srv->netlinknh, NETLINK_ROUTE) < 0) { - netlinkError(errno, - "%s", _("cannot connect to netlink socket")); + virReportSystemError(errno, + "%s", _("cannot connect to netlink socket")); goto error_server; } fd = nl_socket_get_fd(srv->netlinknh); if (fd < 0) { - netlinkError(errno, - "%s", _("cannot get netlink socket fd")); + virReportSystemError(errno, + "%s", _("cannot get netlink socket fd")); goto error_server; } if (nl_socket_set_nonblocking(srv->netlinknh)) { - netlinkError(errno, "%s", - _("cannot set netlink socket nonblocking")); + virReportSystemError(errno, "%s", + _("cannot set netlink socket nonblocking")); goto error_server; } -- 1.7.10

2 2

[libvirt] building error
by Wen Congyang 26 Apr '12

26 Apr '12

When I build libvirt, I meet the following error message sometimes: make[4]: Entering directory `/home/wency/rpmbuild/BUILD/libvirt-0.9.11/docs' GEN libvirt-api.xml GEN libvirt-qemu-api.xml GEN html/index.html ./libvirt-api.xml:2450: parser error : AttValue: ' expected <function name='virConnectDomainEventDeregister' file='libvi ^ ./libvirt-api.xml:2450: parser error : attributes construct error <function name='virConnectDomainEventDeregister' file='libvi ^ ./libvirt-api.xml:2450: parser error : Couldn't find end of Start Tag function line 2450 <function name='virConnectDomainEventDeregister' file='libvi ^ ./libvirt-api.xml:2450: parser error : Premature end of data in tag symbols line 1129 <function name='virConnectDomainEventDeregister' file='libvi ^ ./libvirt-api.xml:2450: parser error : Premature end of data in tag api line 2 <function name='virConnectDomainEventDeregister' file='libvi ^ unable to parse ./libvirt-api.xml make[4]: *** [html/index.html] Error 6 make[4]: *** Waiting for unfinished jobs.... If I rebuild it without anything change, the building will success.

3 3

[libvirt] [PATCH] blockjob: fix block-stream bandwidth race
by Eric Blake 26 Apr '12

26 Apr '12

With RHEL 6.2, virDomainBlockPull(dom, dev, bandwidth, 0) has a race with non-zero bandwidth: there is a window between the block_stream and block_job_set_speed monitor commands where an unlimited amount of data was let through, defeating the point of a throttle. This race was first identified in commit a9d3495e, and libvirt was able to reduce the size of the window for that race. In the meantime, the qemu developers decided to fix things properly; per this message: https://lists.gnu.org/archive/html/qemu-devel/2012-04/msg03793.html the fix will be in qemu 1.1, and changes block-job-set-speed to use a different parameter name, as well as adding a new optional parameter to block-stream, which eliminates the race altogether. Since our documentation already mentioned that we can refuse a non-zero bandwidth for some hypervisors, I think the best solution is to do just that for RHEL 6.2 qemu, so that the race is obvious to the user. Meanwhile the code must be fixed to honor actual qemu 1.1 naming. * src/qemu/qemu_monitor.h (enum BLOCK_JOB_CMD): Drop unused value. * src/qemu/qemu_driver.c (qemuDomainBlockJobImpl): Reject bandwidth during pull with too-old qemu. * src/qemu/qemu_monitor_json.c (qemuMonitorJSONBlockJob): Support difference between RHEL 6.2 and qemu 1.1 block pull. * src/libvirt.c (virDomainBlockPull, virDomainBlockRebase): Document this. --- src/libvirt.c | 6 +++- src/qemu/qemu_driver.c | 8 ++++-- src/qemu/qemu_monitor.h | 3 +- src/qemu/qemu_monitor_json.c | 53 +++++++++++++++++++++++------------------ 4 files changed, 40 insertions(+), 30 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index af42d3b..67f324a 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -18145,7 +18145,8 @@ error: * The maximum bandwidth (in Mbps) that will be used to do the copy can be * specified with the bandwidth parameter. If set to 0, libvirt will choose a * suitable default. Some hypervisors do not support this feature and will - * return an error if bandwidth is not 0. + * return an error if bandwidth is not 0; in this case, it might still be + * possible for a later call to virDomainBlockJobSetSpeed() to succeed. * * This is shorthand for virDomainBlockRebase() with a NULL base. * @@ -18263,7 +18264,8 @@ error: * The maximum bandwidth (in Mbps) that will be used to do the copy can be * specified with the bandwidth parameter. If set to 0, libvirt will choose a * suitable default. Some hypervisors do not support this feature and will - * return an error if bandwidth is not 0. + * return an error if bandwidth is not 0; in this case, it might still be + * possible for a later call to virDomainBlockJobSetSpeed() to succeed. * * When @base is NULL and @flags is 0, this is identical to * virDomainBlockPull(). diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index c3555ca..d3aa34d 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -11654,6 +11654,11 @@ qemuDomainBlockJobImpl(virDomainPtr dom, const char *path, const char *base, _("partial block pull not supported with this " "QEMU binary")); goto cleanup; + } else if (mode == BLOCK_JOB_PULL && bandwidth) { + qemuReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("setting bandwidth at start of block pull not " + "supported with this QEMU binary")); + goto cleanup; } device = qemuDiskPathToAlias(vm, path, &idx); @@ -11676,9 +11681,6 @@ qemuDomainBlockJobImpl(virDomainPtr dom, const char *path, const char *base, * relying on qemu to do this. */ ret = qemuMonitorBlockJob(priv->mon, device, base, bandwidth, info, mode, async); - if (ret == 0 && mode == BLOCK_JOB_PULL && bandwidth) - ret = qemuMonitorBlockJob(priv->mon, device, NULL, bandwidth, NULL, - BLOCK_JOB_SPEED_INTERNAL, async); qemuDomainObjExitMonitorWithDriver(driver, vm); if (ret < 0) goto endjob; diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h index f3cdcdd..dc02964 100644 --- a/src/qemu/qemu_monitor.h +++ b/src/qemu/qemu_monitor.h @@ -530,8 +530,7 @@ typedef enum { BLOCK_JOB_ABORT = 0, BLOCK_JOB_INFO = 1, BLOCK_JOB_SPEED = 2, - BLOCK_JOB_SPEED_INTERNAL = 3, - BLOCK_JOB_PULL = 4, + BLOCK_JOB_PULL = 3, } BLOCK_JOB_CMD; int qemuMonitorBlockJob(qemuMonitorPtr mon, diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index eb58f13..de76609 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -3430,22 +3430,29 @@ qemuMonitorJSONBlockJob(qemuMonitorPtr mon, unsigned long bandwidth, virDomainBlockJobInfoPtr info, int mode, - bool async) + bool modern) { int ret = -1; virJSONValuePtr cmd = NULL; virJSONValuePtr reply = NULL; const char *cmd_name = NULL; - if (base && (mode != BLOCK_JOB_PULL || !async)) { + if (base && (mode != BLOCK_JOB_PULL || !modern)) { qemuReportError(VIR_ERR_INTERNAL_ERROR, _("only modern block pull supports base: %s"), base); return -1; } + if (bandwidth && mode == BLOCK_JOB_PULL && !modern) { + qemuReportError(VIR_ERR_INTERNAL_ERROR, + _("only modern block pull supports bandwidth: %lu"), + bandwidth); + return -1; + } + bandwidth *= 1024ULL * 1024ULL; /* Scale MiB to bytes */ switch ((BLOCK_JOB_CMD) mode) { case BLOCK_JOB_ABORT: - cmd_name = async ? "block-job-cancel" : "block_job_cancel"; + cmd_name = modern ? "block-job-cancel" : "block_job_cancel"; cmd = qemuMonitorJSONMakeCommand(cmd_name, "s:device", device, NULL); break; case BLOCK_JOB_INFO: @@ -3453,19 +3460,24 @@ qemuMonitorJSONBlockJob(qemuMonitorPtr mon, cmd = qemuMonitorJSONMakeCommand(cmd_name, NULL); break; case BLOCK_JOB_SPEED: - case BLOCK_JOB_SPEED_INTERNAL: - cmd_name = async ? "block-job-set-speed" : "block_job_set_speed"; - cmd = qemuMonitorJSONMakeCommand(cmd_name, "s:device", - device, "U:value", - bandwidth * 1024ULL * 1024ULL, - NULL); + cmd_name = modern ? "block-job-set-speed" : "block_job_set_speed"; + cmd = qemuMonitorJSONMakeCommand(cmd_name, "s:device", device, + modern ? "U:speed" : "U:value", + bandwidth, NULL); break; case BLOCK_JOB_PULL: - cmd_name = async ? "block-stream" : "block_stream"; - cmd = qemuMonitorJSONMakeCommand(cmd_name, - "s:device", device, - base ? "s:base" : NULL, base, - NULL); + cmd_name = modern ? "block-stream" : "block_stream"; + if (bandwidth) + cmd = qemuMonitorJSONMakeCommand(cmd_name, + "s:device", device, + "U:speed", bandwidth, + base ? "s:base" : NULL, base, + NULL); + else + cmd = qemuMonitorJSONMakeCommand(cmd_name, + "s:device", device, + base ? "s:base" : NULL, base, + NULL); break; } @@ -3477,14 +3489,9 @@ qemuMonitorJSONBlockJob(qemuMonitorPtr mon, if (ret == 0 && virJSONValueObjectHasKey(reply, "error")) { ret = -1; if (qemuMonitorJSONHasError(reply, "DeviceNotActive")) { - /* If a job completes before we get a chance to set the - * speed, we don't want to fail the original command. */ - if (mode == BLOCK_JOB_SPEED_INTERNAL) - ret = 0; - else - qemuReportError(VIR_ERR_OPERATION_INVALID, - _("No active operation on device: %s"), - device); + qemuReportError(VIR_ERR_OPERATION_INVALID, + _("No active operation on device: %s"), + device); } else if (qemuMonitorJSONHasError(reply, "DeviceInUse")){ qemuReportError(VIR_ERR_OPERATION_FAILED, _("Device %s in use"), device); @@ -3497,7 +3504,7 @@ qemuMonitorJSONBlockJob(qemuMonitorPtr mon, _("Command '%s' is not found"), cmd_name); } else { qemuReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Unexpected error")); + _("Unexpected error")); } } -- 1.7.7.6

3 4

[libvirt] SR-IOV VLANs
by Dax Kelson 26 Apr '12

26 Apr '12

How should libvirt deal with different SR-IOV VLAN scenarios? Hardware with full SR-IOV and ACS support is increasingly available and in production. I just took delivery of such a server this week. It would be nice if the software can fully take advantage of the hardware. == Scenario A - Transparent VLAN == In the first scenario a /single/ VLAN can be tied to a a VF and the tagging and stripping of the VLAN tag happens outside of the view of the VM. Since the VLAN management happens outside the VM there isn't any security concerns from a malicious VM. Today this can configured with the ip command: ip link set <pf> vf <vfN> vlan <vlanID> But, unless I'm reading it wrong, libvirtd will blow away any pre-configured transparent VLAN in qemuDomainHostdevNetConfigReplace == Scenario B - VM VLAN tagging == In the second scenario, tagged frames are delivered to the VM and the VM uses them like normal. There are security considerations here. You don't want a malicious VM to access arbitrary VLANs. There should be a way to have a whitelist of allowed VLAN tags that can be enforced per VF at lower layer than the VM. Unfortunately it doesn't seem like hardware today supports this granularity. The Intel x540 datasheet indicates that a VLAN filter can be programmed with up to 8 VLANs, but I'm not sure if that is per VF or a global limit. With Emulex hardware, running: "ip link set <pf> vf <vfN> vlan 4095" allows the VM with the given VF to configure any VLAN. Likewise, the Intel ixgbe driver has ixgbe_set_vlan_anti_spoofing (and ixgbe_set_mac_anti_spoofing) on a per VF basis. It isn't clear to me if IFLA_VF_SPOOFCHK toggles both or just the mac anti spoofing.

1 0

[libvirt] [PATCH 0/4] Fix tunnelled migration
by Jiri Denemark 26 Apr '12

26 Apr '12

All bugs fixed by the following patches were spotted while testing tunnelled migration. However, the first three of them may also be hit in other scenarios. Jiri Denemark (4): qemu: Preserve original error during migration rpc: Discard non-blocking calls only when necessary qemu: Fix detection of failed migration qemu: Avoid bogus error at the end of tunnelled migration src/qemu/qemu_migration.c | 171 +++++++++++++++++++++++++++++++++++++-------- src/rpc/virnetclient.c | 21 +++--- 2 files changed, 151 insertions(+), 41 deletions(-) -- 1.7.8.5

2 9

[libvirt] [PATCHv3] keepalive: Add ability to disable keepalive messages
by Peter Krempa 26 Apr '12

26 Apr '12

The docs for virConnectSetKeepAlive() advertise that this function should be able to disable keepalives on negative or zero interval time. This patch removes the check that prohibited this and adds code to disable keepalives on negative/zero interval. * src/libvirt.c: virConnectSetKeepAlive(): - remove check for negative values * src/rpc/virnetclient.c * src/rpc/virnetclient.h: - add virNetClientKeepAliveStop() to disable keepalive messages * src/remote/remote_driver.c: remoteSetKeepAlive(): -add ability to disable keepalives --- Diff to v2: - fixed whitespace - added a note that disabling client keepalives does actualy not influence keepalives sent by the daemon src/libvirt.c | 10 ++++------ src/probes.d | 2 +- src/remote/remote_driver.c | 7 ++++++- src/rpc/virkeepalive.c | 36 ++++++++++++++++++++++++++---------- src/rpc/virkeepalive.h | 1 + src/rpc/virnetclient.c | 8 ++++++++ src/rpc/virnetclient.h | 2 ++ 7 files changed, 48 insertions(+), 18 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index af42d3b..b01ebba 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -18433,6 +18433,10 @@ error: * messages. Failure to do so may result in connections being closed * unexpectedly. * + * Note: This API function controls only keepalive messages sent by the client. + * If the server is configured to use keepalive you still need to run the event + * loop to respond to them, even if you disable keepalives by this function. + * * Returns -1 on error, 0 on success, 1 when remote party doesn't support * keepalive messages. */ @@ -18452,12 +18456,6 @@ int virConnectSetKeepAlive(virConnectPtr conn, return -1; } - if (interval <= 0) { - virLibConnError(VIR_ERR_INVALID_ARG, - _("negative or zero interval make no sense")); - goto error; - } - if (conn->driver->setKeepAlive) { ret = conn->driver->setKeepAlive(conn, interval, count); if (ret < 0) diff --git a/src/probes.d b/src/probes.d index 9d70cc9..e56dc3e 100644 --- a/src/probes.d +++ b/src/probes.d @@ -78,7 +78,7 @@ provider libvirt { probe rpc_keepalive_ref(void *ka, void *client, int refs); probe rpc_keepalive_free(void *ka, void *client, int refs); probe rpc_keepalive_start(void *ka, void *client, int interval, int count); - probe rpc_keepalive_stop(void *ka, void *client); + probe rpc_keepalive_stop(void *ka, void *client, bool all); probe rpc_keepalive_send(void *ka, void *client, int prog, int vers, int proc); probe rpc_keepalive_received(void *ka, void *client, int prog, int vers, int proc); probe rpc_keepalive_timeout(void *ka, void *client, int coundToDeath, int idle); diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index af46384..7863b73 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -4631,7 +4631,12 @@ remoteSetKeepAlive(virConnectPtr conn, int interval, unsigned int count) goto cleanup; } - ret = virNetClientKeepAliveStart(priv->client, interval, count); + if (interval > 0) { + ret = virNetClientKeepAliveStart(priv->client, interval, count); + } else { + virNetClientKeepAliveStop(priv->client); + ret = 0; + } cleanup: remoteDriverUnlock(priv); diff --git a/src/rpc/virkeepalive.c b/src/rpc/virkeepalive.c index 06b8e63..a5c2b1a 100644 --- a/src/rpc/virkeepalive.c +++ b/src/rpc/virkeepalive.c @@ -372,32 +372,48 @@ cleanup: } -void -virKeepAliveStop(virKeepAlivePtr ka) +static void +virKeepAliveStopInternal(virKeepAlivePtr ka, bool all) { virKeepAliveLock(ka); PROBE(RPC_KEEPALIVE_STOP, - "ka=%p client=%p", - ka, ka->client); + "ka=%p client=%p all=%d", + ka, ka->client, all); if (ka->timer > 0) { virEventRemoveTimeout(ka->timer); ka->timer = -1; } - if (ka->responseTimer > 0) { - virEventRemoveTimeout(ka->responseTimer); - ka->responseTimer = -1; - } + if (all) { + if (ka->responseTimer > 0) { + virEventRemoveTimeout(ka->responseTimer); + ka->responseTimer = -1; + } - virNetMessageFree(ka->response); - ka->response = NULL; + virNetMessageFree(ka->response); + ka->response = NULL; + } virKeepAliveUnlock(ka); } +void +virKeepAliveStop(virKeepAlivePtr ka) +{ + virKeepAliveStopInternal(ka, true); +} + + +void +virKeepAliveStopSending(virKeepAlivePtr ka) +{ + virKeepAliveStopInternal(ka, false); +} + + bool virKeepAliveCheckMessage(virKeepAlivePtr ka, virNetMessagePtr msg) diff --git a/src/rpc/virkeepalive.h b/src/rpc/virkeepalive.h index f1654eb..af9e722 100644 --- a/src/rpc/virkeepalive.h +++ b/src/rpc/virkeepalive.h @@ -49,6 +49,7 @@ int virKeepAliveStart(virKeepAlivePtr ka, int interval, unsigned int count); void virKeepAliveStop(virKeepAlivePtr ka); +void virKeepAliveStopSending(virKeepAlivePtr ka); bool virKeepAliveCheckMessage(virKeepAlivePtr ka, virNetMessagePtr msg); diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c index 33b7701..d88288d 100644 --- a/src/rpc/virnetclient.c +++ b/src/rpc/virnetclient.c @@ -248,6 +248,14 @@ virNetClientKeepAliveStart(virNetClientPtr client, return ret; } +void +virNetClientKeepAliveStop(virNetClientPtr client) +{ + virNetClientLock(client); + virKeepAliveStopSending(client->keepalive); + virNetClientUnlock(client); +} + static void virNetClientKeepAliveDeadCB(void *opaque) { diff --git a/src/rpc/virnetclient.h b/src/rpc/virnetclient.h index 7c30d2b..13b4f96 100644 --- a/src/rpc/virnetclient.h +++ b/src/rpc/virnetclient.h @@ -104,4 +104,6 @@ int virNetClientKeepAliveStart(virNetClientPtr client, int interval, unsigned int count); +void virNetClientKeepAliveStop(virNetClientPtr client); + #endif /* __VIR_NET_CLIENT_H__ */ -- 1.7.3.4

2 2

[libvirt] [PATCH] build: fix bootstrap on RHEL
by Eric Blake 25 Apr '12

25 Apr '12

Commit 8fe455fd364cd7462e02170084c45a58ee302cc3 tried to work around a regression introduced in upstream gnulib that requires gettext 0.18 or newer on all projects using bootstrap, by making libvirt require gettext 0.18. But this fails on RHEL 6.2, which still ships gettext 0.17. Revert that change, and instead, import the latest round of gnulib updates that fix that problem properly. If you have already built in the window where libvirt required 0.18, be aware that incremental updates may run into problems: this is because 'autopoint --force' will not downgrade m4/po.m4 back to an older version, but it must be downgraded back to 0.17 levels to work with this patch. You may either manually remove that file then rerun bootstrap, or it may prove easier to just clean up all non-git files to start from a clean slate. * bootstrap.conf: Revert minimum gettext back to 0.17. * configure.ac: Likewise. * .gnulib: Update to latest, for bootstrap fixes. * bootstrap: Resync from gnulib. --- Pushing under the build-breaker rule (and this took me a lot longer than I wanted, but I'm happy with the solution). * .gnulib f15a17d...bb2f564 (6): > bootstrap: only force latest Makefile.in.in for gettext module > doc: Mention reason for replacement on glibc/Linux systems. > pwrite: Don't replace on all platforms. > rint* tests: Avoid gcc warnings. > users.txt: Update. > Large File Support for native Windows platforms. .gnulib | 2 +- bootstrap | 12 ++++++++++-- bootstrap.conf | 2 +- configure.ac | 2 +- 4 files changed, 13 insertions(+), 5 deletions(-) diff --git a/.gnulib b/.gnulib index f15a17d..bb2f564 160000 --- a/.gnulib +++ b/.gnulib @@ -1 +1 @@ -Subproject commit f15a17dc1f5d2b1fc8a423795c54b211552c0483 +Subproject commit bb2f5640d5379c5b4eec2d62341413bbab1aa308 diff --git a/bootstrap b/bootstrap index 5aa73cc..6b45868 100755 --- a/bootstrap +++ b/bootstrap @@ -1,6 +1,6 @@ #! /bin/sh # Print a version string. -scriptversion=2012-04-19.22; # UTC +scriptversion=2012-04-25.17; # UTC # Bootstrap this package from checked-out sources. @@ -873,7 +873,15 @@ if test $with_gettext = yes; then } ' po/Makevars.template >po/Makevars || exit 1 - cat $GNULIB_SRCDIR/build-aux/po/Makefile.in.in > po/Makefile.in.in || exit 1 + # If the 'gettext' module is in use, grab the latest Makefile.in.in. + # If only the 'gettext-h' module is in use, assume autopoint already + # put the correct version of this file into place. + case $gnulib_modules in + *gettext-h*) ;; + *gettext*) + cp $GNULIB_SRCDIR/build-aux/po/Makefile.in.in po/Makefile.in.in || exit 1 + ;; + esac if test -d runtime-po; then # Similarly for runtime-po/Makevars, but not quite the same. diff --git a/bootstrap.conf b/bootstrap.conf index 56911e0..c6620e5 100644 --- a/bootstrap.conf +++ b/bootstrap.conf @@ -195,7 +195,7 @@ buildreq="\ autoconf 2.59 automake 1.9.6 autopoint - -gettext 0.18 +gettext 0.17 git 1.5.5 gzip - libtool - diff --git a/configure.ac b/configure.ac index 5936d31..89fe818 100644 --- a/configure.ac +++ b/configure.ac @@ -2300,7 +2300,7 @@ dnl compute the difference between save_CPPFLAGS and CPPFLAGS and append it dnl to INCLUDES in order to preserve changes made by gettext but in a place dnl that does not break the build save_CPPFLAGS="$CPPFLAGS" -AM_GNU_GETTEXT_VERSION([0.18]) +AM_GNU_GETTEXT_VERSION([0.17]) AM_GNU_GETTEXT([external]) GETTEXT_CPPFLAGS= if test "x$save_CPPFLAGS" != "x$CPPFLAGS"; then -- 1.7.7.6

1 0

[libvirt] More SR-IOV VF support needed (IFLA_VF_VLAN/IFLA_VF_SPOOFCHK)
by Dax Kelson 25 Apr '12

25 Apr '12

Hi guys, I have some brand new hardware with a Intel X540-AT2 10Gbe NIC. I see that 0.9.11 added <interface type='hostdev'> with the ability define a MAC address to address the randomly generated MAC address issue. Thank you! I believe that additional functionality is needed in two areas, namely support for transparent VLAN tagging and the ability to disable MAC spoof checking within the NIC's embedded switch. With transparent VLAN tagging (IFLA_VF_VLAN), the PF transparently tags all traffic from the VF with a configured VLAN ID and strips the VLAN tag from traffic going to the VM. The VM is not aware of the VLAN tag. Disabling of the MAC spoof check (IFLA_VF_SPOOFCHK) allows the VM to be able to do NIC bonding of two VFs. These two features correspond to the following commands: ip link set em<X> vf <n> vlan <VLAN> ip link set em<X> vf <n> spoofchk [on|off] (note, requires iproute2 v3.3.0) As far as XML format, how about something like: <devices> <interface type='hostdev'> <source> <address type='pci' domain='0x0000' bus='0x00' slot='0x07' function='0x0'/> </source> <mac address='52:54:00:6d:90:02'> <vlan id='241'> <disablespoofchk/> </interface> </devices> Comments? Dax Kelson Guru Labs

1 0

[libvirt] [PATCHv2] keepalive: Add ability to disable keepalive messages
by Peter Krempa 25 Apr '12

25 Apr '12

The docs for virConnectSetKeepAlive() advertise that this function should be able to disable keepalives on negative or zero interval time. This patch removes the check that prohibited this and adds code to disable keepalives on negative/zero interval. * src/libvirt.c: virConnectSetKeepAlive(): - remove check for negative values * src/rpc/virnetclient.c * src/rpc/virnetclient.h: - add virNetClientKeepAliveStop() to disable keepalive messages * src/remote/remote_driver.c: remoteSetKeepAlive(): -add ability to disable keepalives --- Diff to v1: - added virKeepAliveStopSending() that does not unregister the timer needed to handle server keepalives - moved implementation of virKeepAliveStop() to virKeepAliveStopInternal() - added usage of the new function on the apropriate place - modified systemtap definitions to accomodate new argument src/libvirt.c | 6 ------ src/probes.d | 2 +- src/remote/remote_driver.c | 7 ++++++- src/rpc/virkeepalive.c | 38 ++++++++++++++++++++++++++++---------- src/rpc/virkeepalive.h | 1 + src/rpc/virnetclient.c | 8 ++++++++ src/rpc/virnetclient.h | 2 ++ 7 files changed, 46 insertions(+), 18 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index af42d3b..3f043e1 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -18452,12 +18452,6 @@ int virConnectSetKeepAlive(virConnectPtr conn, return -1; } - if (interval <= 0) { - virLibConnError(VIR_ERR_INVALID_ARG, - _("negative or zero interval make no sense")); - goto error; - } - if (conn->driver->setKeepAlive) { ret = conn->driver->setKeepAlive(conn, interval, count); if (ret < 0) diff --git a/src/probes.d b/src/probes.d index 9d70cc9..e56dc3e 100644 --- a/src/probes.d +++ b/src/probes.d @@ -78,7 +78,7 @@ provider libvirt { probe rpc_keepalive_ref(void *ka, void *client, int refs); probe rpc_keepalive_free(void *ka, void *client, int refs); probe rpc_keepalive_start(void *ka, void *client, int interval, int count); - probe rpc_keepalive_stop(void *ka, void *client); + probe rpc_keepalive_stop(void *ka, void *client, bool all); probe rpc_keepalive_send(void *ka, void *client, int prog, int vers, int proc); probe rpc_keepalive_received(void *ka, void *client, int prog, int vers, int proc); probe rpc_keepalive_timeout(void *ka, void *client, int coundToDeath, int idle); diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index af46384..7863b73 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -4631,7 +4631,12 @@ remoteSetKeepAlive(virConnectPtr conn, int interval, unsigned int count) goto cleanup; } - ret = virNetClientKeepAliveStart(priv->client, interval, count); + if (interval > 0) { + ret = virNetClientKeepAliveStart(priv->client, interval, count); + } else { + virNetClientKeepAliveStop(priv->client); + ret = 0; + } cleanup: remoteDriverUnlock(priv); diff --git a/src/rpc/virkeepalive.c b/src/rpc/virkeepalive.c index 06b8e63..345c69d 100644 --- a/src/rpc/virkeepalive.c +++ b/src/rpc/virkeepalive.c @@ -372,32 +372,50 @@ cleanup: } -void -virKeepAliveStop(virKeepAlivePtr ka) +static void +virKeepAliveStopInternal(virKeepAlivePtr ka, bool all) { virKeepAliveLock(ka); PROBE(RPC_KEEPALIVE_STOP, - "ka=%p client=%p", - ka, ka->client); + "ka=%p client=%p all=%d", + ka, ka->client, all); if (ka->timer > 0) { virEventRemoveTimeout(ka->timer); ka->timer = -1; } - if (ka->responseTimer > 0) { - virEventRemoveTimeout(ka->responseTimer); - ka->responseTimer = -1; - } + if (all) + { + + if (ka->responseTimer > 0) { + virEventRemoveTimeout(ka->responseTimer); + ka->responseTimer = -1; + } - virNetMessageFree(ka->response); - ka->response = NULL; + virNetMessageFree(ka->response); + ka->response = NULL; + } virKeepAliveUnlock(ka); } +void +virKeepAliveStop(virKeepAlivePtr ka) +{ + virKeepAliveStopInternal(ka, true); +} + + +void +virKeepAliveStopSending(virKeepAlivePtr ka) +{ + virKeepAliveStopInternal(ka, false); +} + + bool virKeepAliveCheckMessage(virKeepAlivePtr ka, virNetMessagePtr msg) diff --git a/src/rpc/virkeepalive.h b/src/rpc/virkeepalive.h index f1654eb..af9e722 100644 --- a/src/rpc/virkeepalive.h +++ b/src/rpc/virkeepalive.h @@ -49,6 +49,7 @@ int virKeepAliveStart(virKeepAlivePtr ka, int interval, unsigned int count); void virKeepAliveStop(virKeepAlivePtr ka); +void virKeepAliveStopSending(virKeepAlivePtr ka); bool virKeepAliveCheckMessage(virKeepAlivePtr ka, virNetMessagePtr msg); diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c index 33b7701..d88288d 100644 --- a/src/rpc/virnetclient.c +++ b/src/rpc/virnetclient.c @@ -248,6 +248,14 @@ virNetClientKeepAliveStart(virNetClientPtr client, return ret; } +void +virNetClientKeepAliveStop(virNetClientPtr client) +{ + virNetClientLock(client); + virKeepAliveStopSending(client->keepalive); + virNetClientUnlock(client); +} + static void virNetClientKeepAliveDeadCB(void *opaque) { diff --git a/src/rpc/virnetclient.h b/src/rpc/virnetclient.h index 7c30d2b..13b4f96 100644 --- a/src/rpc/virnetclient.h +++ b/src/rpc/virnetclient.h @@ -104,4 +104,6 @@ int virNetClientKeepAliveStart(virNetClientPtr client, int interval, unsigned int count); +void virNetClientKeepAliveStop(virNetClientPtr client); + #endif /* __VIR_NET_CLIENT_H__ */ -- 1.7.3.4

1 1

[libvirt] [PATCH] virNetDevMacVLanVPortProfileRegisterCallback: Fix segfault
by Michal Privoznik 25 Apr '12

25 Apr '12

Currently, we are calling memcpy(virtPortProfile, ...) unconditionally. Which means if virtPortProfile is NULL we SIGSEGV. Therefore, add check to call memcpy() conditionally. (gdb) bt #0 virNetDevMacVLanVPortProfileRegisterCallback (ifname=0x7ffff3f1ee60 "macvtap0", macaddress=0x7fffe8096e34 "RT", linkdev=0x7fffe8098b90 "eth0", vmuuid=0x7fffe8099558 "l\220*\237u`\326\213\325\227F\f-B\bD0g\t\350\377\177", virtPortProfile=0x0, vmOp=VIR_NETDEV_VPORT_PROFILE_OP_CREATE) at /usr/include/bits/string3.h:52 #1 0x00007ffff7782446 in virNetDevMacVLanCreateWithVPortProfile (tgifname=<optimized out>, macaddress=0x7fffe8096e34 "RT", linkdev=0x7fffe8098b90 "eth0", mode=<optimized out>, withTap=true, vnet_hdr=0, vmuuid=0x7fffe8099558 "l\220*\237u`\326\213\325\227F\f-B\bD0g\t\350\377\177", virtPortProfile=0x0, res_ifname=0x7ffff3f1ef00, vmOp=VIR_NETDEV_VPORT_PROFILE_OP_CREATE, stateDir=0x7fffe800d900 "/var/run/libvirt/qemu", bandwidth=0x0) at util/virnetdevmacvlan.c:954 #2 0x00000000004738d4 in qemuPhysIfaceConnect () #3 0x000000000047e5f3 in qemuBuildCommandLine () #4 0x000000000049a404 in qemuProcessStart () #5 0x0000000000468ac9 in qemuDomainObjStart () #6 0x0000000000469112 in qemuDomainStartWithFlags () #7 0x00007ffff77ef0c6 in virDomainCreate (domain=0x768cb0) at libvirt.c:8162 #8 0x000000000043e158 in remoteDispatchDomainCreateHelper () #9 0x00007ffff783d835 in virNetServerProgramDispatchCall (msg=0x7fffe80cbe50, client=0x7699d0, server=0x7658a0, prog=0x770ab0) at rpc/virnetserverprogram.c:416 #10 virNetServerProgramDispatch (prog=0x770ab0, server=0x7658a0, client=0x7699d0, msg=0x7fffe80cbe50) at rpc/virnetserverprogram.c:289 #11 0x00007ffff7839961 in virNetServerHandleJob (jobOpaque=<optimized out>, opaque=0x7658a0) at rpc/virnetserver.c:161 #12 0x00007ffff776c1ce in virThreadPoolWorker (opaque=<optimized out>) at util/threadpool.c:144 #13 0x00007ffff776b876 in virThreadHelper (data=<optimized out>) at util/threads-pthread.c:161 #14 0x00007ffff74f0e2c in start_thread () from /lib64/libpthread.so.0 #15 0x00007ffff723766d in clone () from /lib64/libc.so.6 --- src/util/virnetdevmacvlan.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/util/virnetdevmacvlan.c b/src/util/virnetdevmacvlan.c index 879d846..c2fd6d0 100644 --- a/src/util/virnetdevmacvlan.c +++ b/src/util/virnetdevmacvlan.c @@ -769,9 +769,11 @@ virNetDevMacVLanVPortProfileRegisterCallback(const char *ifname, goto memory_error; if ((calld->cr_ifname = strdup(ifname)) == NULL) goto memory_error; - if (VIR_ALLOC(calld->virtPortProfile) < 0) - goto memory_error; - memcpy(calld->virtPortProfile, virtPortProfile, sizeof(*virtPortProfile)); + if (virtPortProfile) { + if (VIR_ALLOC(calld->virtPortProfile) < 0) + goto memory_error; + memcpy(calld->virtPortProfile, virtPortProfile, sizeof(*virtPortProfile)); + } if (VIR_ALLOC_N(calld->macaddress, VIR_MAC_BUFLEN) < 0) goto memory_error; memcpy(calld->macaddress, macaddress, VIR_MAC_BUFLEN); -- 1.7.8.5

4 5

[libvirt] [PATCH] macvtap: use embedded buffers for MAC address and UUID
by Stefan Berger 25 Apr '12

25 Apr '12

Use embedded buffers for the MAC addresses and the VM's UUID. --- src/util/virnetdevmacvlan.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) Index: libvirt-acl/src/util/virnetdevmacvlan.c =================================================================== --- libvirt-acl.orig/src/util/virnetdevmacvlan.c +++ libvirt-acl/src/util/virnetdevmacvlan.c @@ -435,10 +435,10 @@ static const uint32_t modeMap[VIR_NETDEV struct virNetlinkCallbackData { char *cr_ifname; virNetDevVPortProfilePtr virtPortProfile; - unsigned char *macaddress; + unsigned char macaddress[VIR_UUID_BUFLEN]; char *linkdev; int vf; - unsigned char *vmuuid; + unsigned char vmuuid[VIR_UUID_BUFLEN]; enum virNetDevVPortProfileOp vmOp; unsigned int linkState; }; @@ -728,9 +728,7 @@ virNetlinkCallbackDataFree(virNetlinkCal if (calld) { VIR_FREE(calld->cr_ifname); VIR_FREE(calld->virtPortProfile); - VIR_FREE(calld->macaddress); VIR_FREE(calld->linkdev); - VIR_FREE(calld->vmuuid); } VIR_FREE(calld); } @@ -772,14 +770,10 @@ virNetDevMacVLanVPortProfileRegisterCall if (VIR_ALLOC(calld->virtPortProfile) < 0) goto memory_error; memcpy(calld->virtPortProfile, virtPortProfile, sizeof(*virtPortProfile)); - if (VIR_ALLOC_N(calld->macaddress, VIR_MAC_BUFLEN) < 0) - goto memory_error; - memcpy(calld->macaddress, macaddress, VIR_MAC_BUFLEN); + memcpy(calld->macaddress, macaddress, sizeof(calld->macaddress)); if ((calld->linkdev = strdup(linkdev)) == NULL) goto memory_error; - if (VIR_ALLOC_N(calld->vmuuid, VIR_UUID_BUFLEN) < 0) - goto memory_error; - memcpy(calld->vmuuid, vmuuid, VIR_UUID_BUFLEN); + memcpy(calld->vmuuid, vmuuid, sizeof(calld->vmuuid)); calld->vmOp = vmOp;

2 2

[libvirt] [test-API] add docs files TESTCASE.py and TESTCASES.conf
by Guannan Ren 25 Apr '12

25 Apr '12

*docs/TESTCASE.py: an template of testcase.py *docs/TESTCASES.conf: an template of testcase config file with simple explanation --- docs/TESTCASE.py | 45 ++++++++++++++++++++++++++++++++ docs/TESTCASES.conf | 70 +++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 115 insertions(+), 0 deletions(-) create mode 100644 docs/TESTCASE.py create mode 100644 docs/TESTCASES.conf diff --git a/docs/TESTCASE.py b/docs/TESTCASE.py new file mode 100644 index 0000000..48adb56 --- /dev/null +++ b/docs/TESTCASE.py @@ -0,0 +1,45 @@ +#! /usr/bin/env python +# How to write a new testcase + +# If testcase wants to use the connection object offered +# by the framework or share variables between testcases +# import sharedmod module. +import sharedmod + +# List parameters supported by the testcase in the two +# global tuple variables with a ',' at the end of last element. +# Both of them are mandatory. +required_params = ('option1', 'option2',) +optional_params = () + +# The check function is optional. This is for some testcases that +# need to check whether specific hardware is present on box or +# testing environment is good before testing. +# Return value 0 means check pass, 1 means to skip the +# testcase during running. +def TESTCASE_check(params): + logger = params['logger'] + ... + return 0 + +# This is the main testing function, The function name must be +# the same as the file name of the testcase. params['logger'] is +# provided by framework for logging. +# Return value 0 means the success of testing, 1 means testing failure. +# It is mandatory. +def TESTCASE(params): + logger = params['logger'] + ... + return 0 + +# The clean function is optional. This is for testcases that dirtied +# testing environment after executed. If keyword 'clean' is set +# just below the testcase in testcase config file, the clean function +# defined in the testcase.py will be invoked by framework to do the +# cleaning job. +# Return value is optional too, 1 means clean failure, but will not +# stop the run of testing. +def TESTCASE_clean(params): + logger = params['logger'] + ... + return 0 diff --git a/docs/TESTCASES.conf b/docs/TESTCASES.conf new file mode 100644 index 0000000..1ca351b --- /dev/null +++ b/docs/TESTCASES.conf @@ -0,0 +1,70 @@ +# single line comments looks like this + +/* + Multiline comments look like this. + The lines enclosed by the C style comments will + be skipped by parser.py +*/ + +############################################################### +# Indentation: +# An indent level is four spaces, do not use tabs to indent. +# + +# .----------- testcase: The first line contains the module name and the test case name separated by a colon and is not indented. +# | +domain:undefine + +# .-------- options: Indent options by an indent level(four spaces) +# | + guestname + +# .---- value: Indent Values by two indent levels(eight spaces) +# | + fedoraVM + +################################################################ +# +# Keywords: 'clean', 'times', 'sleep', '{start_loop, end_loop}' +# + +# 'clean': invoke the clean function in previous testcase +clean + +# 'times': repeat testcase 'repos/domain/install_linux_cdrom.py' N times +domain:install_linux_cdrom times 2 + guestname + fedoraVM + memory + 1024 + vcpu + 1 + +# 'sleep 5': pause the run of testing for N seconds. +sleep 5 + +# The pair of 'start_loop' and 'end_loop' will +# run the testcases between them N loops +domain:start start_loop + guestname + fedoraVM + +domain:destroy end_loop 3 + guestname + fedoraVM + +################################################################ +# +# Options: 'times', 'cleanup' +# always be the last line of testcase config file +# + +# .---------------------- repeat the above testcases n more times. +# | .-------------- invoke the clean function in all of above testcases +# | | +options times=2 cleanup=enable + +# python libvirt-test-api.py -t repos/domain/undefine.py repos/domain/install_linux_cdrom.py \ +# repos/domain/start.py repos/domain/destroy.py +# +# The command generates a template of tescase file like above -- 1.7.7.5

1 1

[libvirt] [test-API PATCH] use global variable domain_cache_folder to as cache folder for guest install
by Guannan Ren 25 Apr '12

25 Apr '12

--- global.cfg | 15 +++++++++------ repos/domain/install_linux_cdrom.py | 22 ++++++++++------------ 2 files changed, 19 insertions(+), 18 deletions(-) diff --git a/global.cfg b/global.cfg index 6cfdcac..7b7b7cb 100644 --- a/global.cfg +++ b/global.cfg @@ -142,6 +143,8 @@ defaultnic = virtio static_uuid = 05867c1a-afeb-300e-e55e-2673391ae080 # path to a disk image containing a preinstalled guest for testing testfullimagepath = /var/lib/libvirt/images/f14.img +# path to store temporary iso and kickstart file +domain_cache_folder = /var/cache/libvirt-test-api ################################################################ # diff --git a/repos/domain/install_linux_cdrom.py b/repos/domain/install_linux_cdrom.py index 60d12a7..f70ebc3 100644 --- a/repos/domain/install_linux_cdrom.py +++ b/repos/domain/install_linux_cdrom.py @@ -36,18 +36,16 @@ VM_STAT = "virsh --quiet list --all| grep \"\\b%s\\b\"|grep off" VM_DESTROY = "virsh destroy %s" VM_UNDEFINE = "virsh undefine %s" -BOOT_DIR = "/var/lib/libvirt/boot/" HOME_PATH = os.getcwd() -def prepare_cdrom(*args): +def prepare_cdrom(ostree, ks, guestname, cache_folder, logger): """ to customize boot.iso file to add kickstart file into it for automatic guest installation """ - ostree, ks, guestname, logger = args ks_name = os.path.basename(ks) - new_dir = os.path.join(HOME_PATH, guestname) - logger.info("creating a new folder for customizing custom.iso file in it") + new_dir = os.path.join(cache_folder, guestname) + logger.info("creating a workshop folder for customizing custom.iso file") if os.path.exists(new_dir): logger.info("the folder exists, remove it") @@ -68,7 +66,7 @@ def prepare_cdrom(*args): shutil.copy('utils/ksiso.sh', new_dir) src_path = os.getcwd() - logger.info("enter into the workshop folder: %s" % new_dir) + logger.debug("enter folder: %s" % new_dir) os.chdir(new_dir) shell_cmd = 'sh ksiso.sh %s' % ks_name @@ -76,8 +74,8 @@ def prepare_cdrom(*args): (status, text) = commands.getstatusoutput(shell_cmd) logger.debug(text) - logger.info("make custom.iso file, change to original directory: %s" % - src_path) + + logger.debug("go back to original directory: %s" % src_path) os.chdir(src_path) def prepare_boot_guest(domobj, xmlstr, guestname, installtype, logger): @@ -194,13 +192,13 @@ def install_linux_cdrom(params): logger.debug('kisckstart file: \n %s' % ks) logger.info('prepare installation...') + cache_folder = envparser.get_value("variables", "domain_cache_folder") - bootcd = '%s/custom.iso' % \ - (os.path.join(HOME_PATH, guestname)) - logger.debug("the bootcd path is %s" % bootcd) logger.info("begin to customize the custom.iso file") - prepare_cdrom(ostree, ks, guestname, logger) + prepare_cdrom(ostree, ks, guestname, cache_folder, logger) + bootcd = '%s/custom.iso' % \ + (os.path.join(cache_folder, guestname)) xmlstr = xmlstr.replace('CUSTOMISO', bootcd) logger.debug('dump installation guest xml:\n%s' % xmlstr) -- 1.7.7.5

1 0

[libvirt] [test-API PATCH 0/4] problems fixed during testcase run
by Guannan Ren 25 Apr '12

25 Apr '12

I ran a loop of existing testcases to ensure the cleanup that we did these days is neat and successful. The four patches is the final update. first, update testcase config files in cases folder to use new params of testcases. second, Fix a framework bug. third, add missing modules. fourth, final testcases cleanup.

3 21

[libvirt] [test-API PATCH] move log.py and format.py into src, cleanup module import code
by Guannan Ren 25 Apr '12

25 Apr '12

--- libvirt-test-api | 2 +- src/casecfgcheck.py | 2 -- src/env_clear.py | 4 ++-- src/env_inspect.py | 2 +- src/env_parser.py | 6 +----- src/exception.py | 2 -- {utils => src}/format.py | 0 src/generator.py | 12 ++++++------ {utils => src}/log.py | 0 src/log.xsl | 2 +- src/log_generator.py | 2 +- src/parser.py | 4 ++-- src/proxy.py | 2 +- 13 files changed, 16 insertions(+), 24 deletions(-) rename {utils => src}/format.py (100%) rename {utils => src}/log.py (100%) diff --git a/libvirt-test-api b/libvirt-test-api index cec7679..4c8d515 100755 --- a/libvirt-test-api +++ b/libvirt-test-api @@ -27,7 +27,7 @@ from src import proxy from src import generator from src import env_clear from src import process -from utils import log +from src import log from src.log_generator import LogGenerator from src.activityfilter import Filter from src.casecfgcheck import CaseCfgCheck diff --git a/src/casecfgcheck.py b/src/casecfgcheck.py index 252f4a4..755b03f 100644 --- a/src/casecfgcheck.py +++ b/src/casecfgcheck.py @@ -15,8 +15,6 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -from src import proxy - class CaseCfgCheck(object): """validate the options in testcase config file""" def __init__(self, proxy_obj, activities_list): diff --git a/src/env_clear.py b/src/env_clear.py index a4a8a8e..fa3b62c 100644 --- a/src/env_clear.py +++ b/src/env_clear.py @@ -18,8 +18,8 @@ # This module matches the reference of clearing function from each testcase # to the corresponding testcase's argument in the order of testcase running -from src import mapper -from utils import log +import mapper +import log class EnvClear(object): """ Generate a callable class of executing clearing function in diff --git a/src/env_inspect.py b/src/env_inspect.py index 4942b33..b260ff8 100644 --- a/src/env_inspect.py +++ b/src/env_inspect.py @@ -19,7 +19,7 @@ import commands import libvirt -from src import sharedmod +import sharedmod def check_libvirt(logger): virsh = 'virsh -v' diff --git a/src/env_parser.py b/src/env_parser.py index cf4168f..f02af57 100644 --- a/src/env_parser.py +++ b/src/env_parser.py @@ -21,11 +21,7 @@ import ConfigParser import os import sys -dir = os.path.dirname(sys.modules[__name__].__file__) -absdir = os.path.abspath(dir) -sys.path.append(os.path.split(absdir)[0]) - -from src import exception +import exception class Envparser(object): def __init__(self, configfile): diff --git a/src/exception.py b/src/exception.py index 9b61bac..70d0175 100644 --- a/src/exception.py +++ b/src/exception.py @@ -17,8 +17,6 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -import libvirt - class LibvirtException(Exception): code = 200 message = "General libvirt-test-suite Exception" diff --git a/utils/format.py b/src/format.py similarity index 100% rename from utils/format.py rename to src/format.py diff --git a/src/generator.py b/src/generator.py index 5b9a0a2..d4b0388 100644 --- a/src/generator.py +++ b/src/generator.py @@ -24,12 +24,12 @@ import sys import os import traceback -from src import mapper -from src.testcasexml import xml_file_to_str -from src import env_parser -from src import env_inspect -from utils import log -from utils import format +import mapper +from testcasexml import xml_file_to_str +import env_parser +import env_inspect +import log +import format class FuncGen(object): """ To generate a callable testcase""" diff --git a/utils/log.py b/src/log.py similarity index 100% rename from utils/log.py rename to src/log.py diff --git a/src/log.xsl b/src/log.xsl index 577a0a5..589a720 100644 --- a/src/log.xsl +++ b/src/log.xsl @@ -5,7 +5,7 @@ <html> <head> <title>Libvirt testing log</title> - <link rel="stylesheet" href="src/log.css" type="text/css" media="screen" /> + <link rel="stylesheet" href="log.css" type="text/css" media="screen" /> <script language="javascript"> <![CDATA[ var xmlDOc; diff --git a/src/log_generator.py b/src/log_generator.py index a001ef2..be483d6 100644 --- a/src/log_generator.py +++ b/src/log_generator.py @@ -22,7 +22,7 @@ import copy from xml.dom import minidom from xml.dom.minidom import Document -from src import exception +import exception class LogGenerator(object): """ Generate and parser log xml file diff --git a/src/parser.py b/src/parser.py index 8a861fd..38f0424 100644 --- a/src/parser.py +++ b/src/parser.py @@ -23,8 +23,8 @@ import sys import copy import string -from src import exception -from src import env_parser +import exception +import env_parser class CaseFileParser(object): """ Parser the case configuration file to generate a data list. diff --git a/src/proxy.py b/src/proxy.py index fe50fff..4751b3b 100644 --- a/src/proxy.py +++ b/src/proxy.py @@ -20,7 +20,7 @@ # The proxy examines the list of unique test cases, received from the # generator and import each test case from appropriate module directory. -from src import exception +import exception class Proxy(object): """ The Proxy class is used for getting function reference """ -- 1.7.7.5

2 5

[libvirt] some questions
by user-mirror 25 Apr '12

25 Apr '12

Nice to meet you!I'm a college student from Xi'an China.I have some questions when using virt-manager to migrate virtual machine live based on shared memory.I found a website telling me how to migrate virtual machine live by virt-manager and here is the websitehttp://www.ibm.com/developerworks/cn/linux/l-cn-mgrtvm2/index.html(s… it's written in Chinese).However,we find that the virtual machine running on the dest host is a blank screen and virt-manager shows the virtual machine is running.We don't know why it's a blank screen and i wish you dear developers can do me a favor.Thanks very much and hope to receive your E-mails!

3 2

[libvirt] some questions
by user-mirror 24 Apr '12

24 Apr '12

Nice to meet you!I'm a college student from Xi'an China.I have some questions when using virt-manager to migrate virtual machine live based on shared memory.I found a website telling me how to migrate virtual machine live by virt-manager and here is the websitehttp://www.ibm.com/developerworks/cn/linux/l-cn-mgrtvm2/index.html(s… it's written in Chinese).However,we find that the virtual machine running on the dest host is a blank screen and virt-manager shows the virtual machine is running.We don't know why it's a blank screen and i wish you dear developers can do me a favor.Thanks very much and hope to receive your E-mails!

1 0