- Devel - libvirt List Archives

[libvirt] [PATCH] qemu: Don't update count of vCPUs if hot-unplug has failed
by Peter Krempa 16 Jan '13

16 Jan '13

After live change of cpu counts, the number of processor threads is verified. This patch makes use of this approach to check if qemu ignored the request for cpu hot-unplug and report an appropriate message. --- src/qemu/qemu_driver.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 39175f4..c4be130 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3697,6 +3697,15 @@ static int qemuDomainHotplugVcpus(virQEMUDriverPtr driver, goto cleanup; } + /* check if hotplug has failed */ + if (vcpus < oldvcpus && ncpupids == oldvcpus) { + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", + _("qemu didn't unplug the vCPUs properly")); + vcpus = oldvcpus; + ret = -1; + goto cleanup; + } + if (ncpupids != vcpus) { virReportError(VIR_ERR_INTERNAL_ERROR, _("got wrong number of vCPU pids from QEMU monitor. " -- 1.8.1

2 2

[libvirt] [PATCH 00/10] Resolve CHECKED_RETURN errors found by Coverity
by John Ferlan 16 Jan '13

16 Jan '13

Bug: https://bugzilla.redhat.com/show_bug.cgi?id=880388 This set of patches resolves the "CHECKED_RETURN (CWE-252)" errors found by Coverity. John Ferlan (10): interface: Check and handle error for virAsprintf() calls. parallels: Check and handle error for virAsprintf() calls. Ignore the return inparallelsMakePoolName() since subsequent check validates name was allocated. rpc: Check status when attempting to set SO_REUSEADDR flag on outgoing connection. On failure, VIR_WARN(), but continue to connect. vmware: Ignore the return status check for vmwareUpdateVMStatus in convenience routine vmwareDomainObjListUpdateDomain xen: Check return status for setting TCP_NODELAY option and generate a VIR_DEBUG message on failure. Allow connection to continue. virlockspacetest: Check return on mkdir for LOCKSPACE_DIR vmx2xmltest: Check and handle error for virAsprintf() calls. xml2vmxtest: Check and handle error for virAsprintf() calls. virsh: Ignore error returns for virBufferTrim(). phyp: Check and handle select() errors from waitsocket(). src/interface/interface_backend_udev.c | 5 ++-- src/parallels/parallels_storage.c | 5 ++-- src/phyp/phyp_driver.c | 42 ++++++++++++++++++++++++++-------- src/rpc/virnetsocket.c | 4 +++- src/vmware/vmware_driver.c | 2 +- src/xen/xend_internal.c | 6 +++-- tests/virlockspacetest.c | 3 ++- tests/vmx2xmltest.c | 7 ++++-- tests/xml2vmxtest.c | 5 ++-- tools/virsh.c | 4 ++-- 10 files changed, 56 insertions(+), 27 deletions(-) -- 1.7.11.7

4 32

[libvirt] [PATCH] libvirt: lxc: don't mkdir when selinux is disabled
by Gao feng 16 Jan '13

16 Jan '13

libvirt lxc will fail to start when selinux is disabled. error: Failed to start domain noroot error: internal error guest failed to start: PATH=/bin:/sbin TERM=linux container=lxc-libvirt container_uuid=b9873916-3516-c199-8112-1592ff694a9e LIBVIRT_LXC_UUID=b9873916-3516-c199-8112-1592ff694a9e LIBVIRT_LXC_NAME=noroot /bin/sh 2013-01-09 11:04:05.384+0000: 1: info : libvirt version: 1.0.1 2013-01-09 11:04:05.384+0000: 1: error : lxcContainerMountBasicFS:546 : Failed to mkdir /sys/fs/selinux: No such file or directory 2013-01-09 11:04:05.384+0000: 7536: info : libvirt version: 1.0.1 2013-01-09 11:04:05.384+0000: 7536: error : virLXCControllerRun:1466 : error receiving signal from container: Input/output error 2013-01-09 11:04:05.404+0000: 7536: error : virCommandWait:2287 : internal error Child process (ip link del veth1) unexpected exit status 1: Cannot find device "veth1" fix this problem by checking if selinuxfs is mounted in host before we try to create dir /sys/fs/selinux. Signed-off-by: Gao feng <gaofeng(a)cn.fujitsu.com> --- src/lxc/lxc_container.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index 9f22923..d7f4960 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -540,13 +540,6 @@ static int lxcContainerMountBasicFS(bool pivotRoot, VIR_DEBUG("Processing %s -> %s", mnts[i].src, mnts[i].dst); - if (virFileMakePath(mnts[i].dst) < 0) { - virReportSystemError(errno, - _("Failed to mkdir %s"), - mnts[i].src); - goto cleanup; - } - srcpath = mnts[i].src; /* Skip if mount doesn't exist in source */ @@ -554,6 +547,13 @@ static int lxcContainerMountBasicFS(bool pivotRoot, (access(srcpath, R_OK) < 0)) continue; + if (virFileMakePath(mnts[i].dst) < 0) { + virReportSystemError(errno, + _("Failed to mkdir %s"), + mnts[i].src); + goto cleanup; + } + VIR_DEBUG("Mount %s on %s type=%s flags=%x, opts=%s", srcpath, mnts[i].dst, mnts[i].type, mnts[i].mflags, mnts[i].opts); if (mount(srcpath, mnts[i].dst, mnts[i].type, mnts[i].mflags, mnts[i].opts) < 0) { -- 1.7.11.7

3 3

[libvirt] [PATCH v2] Add 'lxc-enter-namespace' command to virsh
by Daniel P. Berrange 16 Jan '13

16 Jan '13

From: "Daniel P. Berrange" <berrange(a)redhat.com> Add a 'lxc-enter-namespace' command which accepts a domain name and then a command + args to run, attached to the container eg virsh -c lxc:/// lxc-enter-namespace demo -- /bin/ps -auxf Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- tools/Makefile.am | 1 + tools/virsh-domain.c | 94 ++++++++++++++++++++++++++++++++++++++++++++++++++++ tools/virsh.pod | 8 +++++ 3 files changed, 103 insertions(+) diff --git a/tools/Makefile.am b/tools/Makefile.am index 878a114..8a0429c 100644 --- a/tools/Makefile.am +++ b/tools/Makefile.am @@ -133,6 +133,7 @@ virsh_LDADD = \ $(STATIC_BINARIES) \ $(WARN_CFLAGS) \ ../src/libvirt.la \ + ../src/libvirt-lxc.la \ ../src/libvirt-qemu.la \ ../gnulib/lib/libgnu.la \ $(LIBXML_LIBS) \ diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index e91939c..1fee681 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -43,11 +43,13 @@ #include "conf/domain_conf.h" #include "console.h" #include "viralloc.h" +#include "vircommand.h" #include "virutil.h" #include "virfile.h" #include "virjson.h" #include "virkeycode.h" #include "virmacaddr.h" +#include "virprocess.h" #include "virstring.h" #include "virsh-domain-monitor.h" #include "virerror.h" @@ -6771,6 +6773,97 @@ cleanup: } /* + * "lxc-enter-namespace" namespace + */ +static const vshCmdInfo info_lxc_enter_namespace[] = { + {"help", N_("LXC Guest Enter Namespace")}, + {"desc", N_("Run an arbitrary lxc guest enter namespace; use at your own risk")}, + {NULL, NULL} +}; + +static const vshCmdOptDef opts_lxc_enter_namespace[] = { + {"domain", VSH_OT_DATA, VSH_OFLAG_REQ, N_("domain name, id or uuid")}, + {NULL, 0, 0, NULL} +}; + +static bool +cmdLxcEnterNamespace(vshControl *ctl, const vshCmd *cmd) +{ + virDomainPtr dom = NULL; + bool ret = false; + const vshCmdOpt *opt = NULL; + char **cmdargv = NULL; + size_t ncmdargv = 0; + pid_t pid; + int nfdlist; + int *fdlist; + size_t i; + + dom = vshCommandOptDomain(ctl, cmd, NULL); + if (dom == NULL) + goto cleanup; + + while ((opt = vshCommandOptArgv(cmd, opt))) { + if (VIR_EXPAND_N(cmdargv, ncmdargv, 1) < 0) { + vshError(ctl, _("%s: %d: failed to allocate argv"), + __FILE__, __LINE__); + } + cmdargv[ncmdargv-1] = opt->data; + } + if (VIR_EXPAND_N(cmdargv, ncmdargv, 1) < 0) { + vshError(ctl, _("%s: %d: failed to allocate argv"), + __FILE__, __LINE__); + } + cmdargv[ncmdargv - 1] = NULL; + + if ((nfdlist = virDomainLxcOpenNamespace(dom, &fdlist, 0)) < 0) + goto cleanup; + + /* Fork once because we don't want to affect + * virsh's namespace itself + */ + if (virFork(&pid) < 0) + goto cleanup; + if (pid == 0) { + if (virDomainLxcEnterNamespace(dom, + nfdlist, + fdlist, + NULL, + NULL, + 0) < 0) + _exit(255); + + /* Fork a second time because entering the + * pid namespace only takes effect after fork + */ + if (virFork(&pid) < 0) + _exit(255); + if (pid == 0) { + execv(cmdargv[0], cmdargv); + _exit(255); + } else { + if (virProcessWait(pid, NULL) < 0) + _exit(255); + } + _exit(0); + } else { + for (i = 0 ; i < nfdlist ; i++) + VIR_FORCE_CLOSE(fdlist[i]); + VIR_FREE(fdlist); + if (virProcessWait(pid, NULL) < 0) + goto cleanup; + } + + ret = true; + +cleanup: + if (dom) + virDomainFree(dom); + VIR_FREE(cmdargv); + return ret; +} + +/* * "dumpxml" command */ static const vshCmdInfo info_dumpxml[] = { @@ -8760,6 +8853,7 @@ const vshCmdDef domManagementCmds[] = { {"inject-nmi", cmdInjectNMI, opts_inject_nmi, info_inject_nmi, 0}, {"send-key", cmdSendKey, opts_send_key, info_send_key, 0}, {"send-process-signal", cmdSendProcessSignal, opts_send_process_signal, info_send_process_signal, 0}, + {"lxc-enter-namespace", cmdLxcEnterNamespace, opts_lxc_enter_namespace, info_lxc_enter_namespace, 0}, {"managedsave", cmdManagedSave, opts_managedsave, info_managedsave, 0}, {"managedsave-remove", cmdManagedSaveRemove, opts_managedsaveremove, info_managedsaveremove, 0}, diff --git a/tools/virsh.pod b/tools/virsh.pod index c9ebc8f..e2a2aec 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -3056,6 +3056,14 @@ When I<--aysnc> is given, the command waits for timeout whether success or failed. And when I<--block> is given, the command waits forever with blocking timeout. +=item B<lxc-enter-namespace> I<domain> -- /path/to/binary [arg1, [arg2, ...]] + +Enter the namespace of I<domain> and execute the command C</path/to/binary> +passing the requested args. The binary path is relative to the container +root filesystem, not the host root filesystem. The binary will inherit the +environment variables / console visible to virsh. This command only works +when connected to the LXC hypervisor driver. + =back =head1 ENVIRONMENT -- 1.7.11.7

2 1

[libvirt] [PATCH] build: add new file, for lxc_protocol checking
by Eric Blake 16 Jan '13

16 Jan '13

Commit 509eb51 added lxc_protocol.x; but without the initial checkin of src/lxc_protocol-structs, 'make check' would fail for anyone with pdwtags installed: make[3]: *** No rule to make target `lxc_protocol-structs', needed by `check-protocol'. Stop. * src/lxc_protocol-structs: New file. --- Pushing under the build-breaker rule. src/lxc_protocol-structs | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 src/lxc_protocol-structs diff --git a/src/lxc_protocol-structs b/src/lxc_protocol-structs new file mode 100644 index 0000000..eb54172 --- /dev/null +++ b/src/lxc_protocol-structs @@ -0,0 +1,13 @@ +/* -*- c -*- */ +struct remote_nonnull_domain { + remote_nonnull_string name; + remote_uuid uuid; + int id; +}; +struct lxc_domain_open_namespace_args { + remote_nonnull_domain dom; + u_int flags; +}; +enum lxc_procedure { + LXC_PROC_DOMAIN_OPEN_NAMESPACE = 1, +}; -- 1.8.0.2

2 1

[libvirt] [PATCH 0/8] *Persistent vHBA support in storage pool
by Osier Yang 16 Jan '13

16 Jan '13

This is the 3rd part to implement NPIV migration support [1]. Part 1: https://www.redhat.com/archives/libvir-list/2013-January/msg00859.html Part 2: (Already ACKed by Michal) https://www.redhat.com/archives/libvir-list/2013-January/msg00859.html The patches are based on Part 2. The new XMLs might be too long, might be deserved to have them as sub-elements of <adapter>. But I'd like to see the feedback first. Osier Yang (8): New XML attributes for storage pool source adapter storage: Make the adapter name be consistent with node device driver storage: Move virStorageBackendSCSIGetHostNumber into iscsi backend phyp: Prohibit fc_host adapter for phyp driver util: Add helper to get the scsi host name by iterating over sysfs util: Fix bug of managing vport storage: Add startPool and stopPool for scsi backend storage: Guess the parent if it's not specified for vHBA docs/formatstorage.html.in | 15 ++- docs/schemas/storagepool.rng | 33 +++++- src/conf/storage_conf.c | 123 ++++++++++++++++-- src/conf/storage_conf.h | 23 +++- src/libvirt_private.syms | 4 + src/phyp/phyp_driver.c | 15 ++- src/storage/storage_backend_iscsi.c | 39 ++++++- src/storage/storage_backend_scsi.c | 190 +++++++++++++++++++-------- src/storage/storage_backend_scsi.h | 3 - src/util/virutil.c | 196 +++++++++++++++++++++++++++- src/util/virutil.h | 7 + tests/storagepoolxml2xmlin/pool-scsi.xml | 2 +- tests/storagepoolxml2xmlin/pool-scsi1.xml | 15 ++ tests/storagepoolxml2xmlout/pool-scsi.xml | 2 +- tests/storagepoolxml2xmlout/pool-scsi1.xml | 18 +++ tests/storagepoolxml2xmltest.c | 1 + 16 files changed, 602 insertions(+), 84 deletions(-) create mode 100644 tests/storagepoolxml2xmlin/pool-scsi1.xml create mode 100644 tests/storagepoolxml2xmlout/pool-scsi1.xml [1] https://www.redhat.com/archives/libvir-list/2012-November/msg00826.html Regards, Osier

1 8

[libvirt] [PATCH 0/2] Add total number of physical cores to the capabilities output
by Peter Krempa 15 Jan '13

15 Jan '13

https://bugzilla.redhat.com/show_bug.cgi?id=888503 The values added by this patch help avoid management applications the dodgy approach of multiplying values in the nodeinfo structure to gather data needed for their management decisions. Peter Krempa (2): nodeinfo: Gather total number of physical cores and fix tests capabilities: Add total number of cores and threads to the XML docs/formatcaps.html.in | 2 +- docs/schemas/capability.rng | 8 +++++++ src/conf/cpu_conf.c | 4 ++++ src/conf/cpu_conf.h | 2 ++ src/libvirt_private.syms | 1 + src/nodeinfo.c | 37 ++++++++++++++++++++++------- src/nodeinfo.h | 2 ++ src/qemu/qemu_capabilities.c | 3 ++- tests/nodeinfodata/linux-x86-test1.expected | 2 +- tests/nodeinfodata/linux-x86-test2.expected | 2 +- tests/nodeinfodata/linux-x86-test3.expected | 2 +- tests/nodeinfodata/linux-x86-test4.expected | 2 +- tests/nodeinfodata/linux-x86-test5.expected | 2 +- tests/nodeinfodata/linux-x86-test6.expected | 2 +- tests/nodeinfodata/linux-x86-test7.expected | 2 +- tests/nodeinfodata/linux-x86-test8.expected | 2 +- tests/nodeinfotest.c | 11 +++++---- tests/testutilsqemu.c | 2 ++ 18 files changed, 66 insertions(+), 22 deletions(-) -- 1.8.1

2 3

[libvirt] Libvirt node is not getting booted through network
by Varun Bhatnagar 15 Jan '13

15 Jan '13

Hi, I am trying to boot my node through network with the following configuration: But I am getting an error message saying: Even my network setting is not getting reflected in the Virtualbox. Can anyone suggest me what is wrong with this configuration. I think to boot a node from network we need to define a boot server but where shall I add that, I am confused.... Any help will be appreciated. Thanks in advance. Regards, Varun =====-----=====-----===== Notice: The information contained in this e-mail message and/or attachments to it may contain confidential or privileged information. If you are not the intended recipient, any dissemination, use, review, distribution, printing or copying of the information contained in this e-mail message and/or attachments to it are strictly prohibited. If you have received this communication in error, please notify us by reply e-mail or telephone and immediately and permanently delete the message and any attachments. Thank you

1 0

[libvirt] [PATCH] .gitignore: Sort alphabetically
by Michal Privoznik 15 Jan '13

15 Jan '13

--- Pushed under trivial rule .gitignore | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index f71c30c..be83e28 100644 --- a/.gitignore +++ b/.gitignore @@ -63,8 +63,8 @@ /docs/devhelp/libvirt.devhelp /docs/hvsupport.html.in /docs/libvirt-api.xml -/docs/libvirt-qemu-*.xml /docs/libvirt-lxc-*.xml +/docs/libvirt-qemu-*.xml /docs/libvirt-refs.xml /docs/search.php /docs/todo.html.in @@ -161,8 +161,8 @@ /tests/reconnect /tests/secaatest /tests/seclabeltest -/tests/securityselinuxtest /tests/securityselinuxlabeltest +/tests/securityselinuxtest /tests/sexpr2xmltest /tests/shunloadtest /tests/sockettest -- 1.8.0.2

1 0

[libvirt] [PATCH 0/4 v3] New API virNodeDeviceLookupSCSIHostByWWN
by Osier Yang 15 Jan '13

15 Jan '13

For easy reviewing, this is splitted from [1]. v2 - v3: * Validate the specified wwnn,wwpn pair before applying it to the new API in virsh-nodedev.c v1 - v2: * Per Daniel's suggestion, change the API name from virNodeDeviceLookupByWWN into virNodeDeviceLookupSCSIHostByWWN. Osier Yang (4): Introduce API virNodeDeviceLookupSCSIHostByWWN remote: Wire up the remote protocol nodedev: Implement virNodeDeviceLookupSCSIHostByWWN virsh: Use virNodeDeviceLookupSCSIHostByWWN include/libvirt/libvirt.h.in | 5 ++ src/driver.h | 6 ++ src/libvirt.c | 46 ++++++++++++++++ src/libvirt_public.syms | 1 + src/node_device/node_device_driver.c | 13 +++-- src/node_device/node_device_driver.h | 4 ++ src/node_device/node_device_hal.c | 1 + src/node_device/node_device_udev.c | 1 + src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 13 ++++- src/remote_protocol-structs | 9 +++ src/rpc/gendispatch.pl | 5 ++- tools/virsh-nodedev.c | 97 ++++++++++++++++++++++++++-------- tools/virsh.pod | 15 +++-- 14 files changed, 181 insertions(+), 36 deletions(-) [1] https://www.redhat.com/archives/libvir-list/2013-January/msg00328.html Regards, Osier

1 5

[libvirt] [PATCH 0/4] Resolve UNINIT errors found by Coverity
by John Ferlan 15 Jan '13

15 Jan '13

This set of patches resolves "Error: UNINIT (CWE-457)" errors found by Coverity John Ferlan (4): parallels: Resolve issues with uninitialized 'ret' value openvz: Need to initialize 'ret' for kb_per_pages error path lxc: Initialize dst due to potential cleanup usage before setting interface: Need to initialize 'add_to_list' src/interface/interface_backend_udev.c | 2 +- src/lxc/lxc_driver.c | 2 +- src/openvz/openvz_conf.c | 2 +- src/parallels/parallels_storage.c | 19 ++++++++++++++----- 4 files changed, 17 insertions(+), 8 deletions(-) -- 1.7.11.7

4 13

[libvirt] [PATCH 0/9 v2] Miscs of nodedev
by Osier Yang 15 Jan '13

15 Jan '13

This is the second part of [1]. Some of them are preparations for persistent vHBA support in storage pool, some are fixes, some are improvements. v1 - v2: * One more patch: 9/9 Osier Yang (9): nodedev: Remove the unused enum nodedev: Introduce two new flags for listAll API util: Add one helper virReadFCHost to read the value of fc_host entry nodedev: Use access instead of stat nodedev: Refactor the helpers nodedev: Dump max vports and vports in use for HBA's XML nodedev: Fix the improper logic when enumerating SRIOV VF nodedev: Abstract nodeDeviceVportCreateDelete as util function cleanup libvirt_private.syms docs/formatnode.html.in | 10 +- docs/schemas/nodedev.rng | 6 + include/libvirt/libvirt.h.in | 20 +- src/conf/node_device_conf.c | 41 +- src/conf/node_device_conf.h | 16 +- src/libvirt.c | 2 + src/libvirt_private.syms | 1160 +++++++++++++++-------------- src/node_device/node_device_driver.c | 110 +--- src/node_device/node_device_driver.h | 19 +- src/node_device/node_device_hal.c | 15 +- src/node_device/node_device_linux_sysfs.c | 245 ++---- src/node_device/node_device_udev.c | 14 +- src/util/virpci.c | 36 +- src/util/virutil.c | 224 ++++++ src/util/virutil.h | 19 + tools/virsh-nodedev.c | 6 + tools/virsh.pod | 7 +- 17 files changed, 1034 insertions(+), 916 deletions(-) Regards, Osier

3 28

Re: [libvirt] [RFC qom-cpu v2 1/2] target-i386: Convert CPU definitions into X86CPU subclasses
by Eduardo Habkost 15 Jan '13

15 Jan '13

On Tue, Jan 15, 2013 at 09:41:04AM +0100, Igor Mammedov wrote: > On Mon, 10 Dec 2012 23:59:31 +0100 > Andreas Färber <afaerber(a)suse.de> wrote: > > > TODO: sort classes for -cpu ?, generalize X86CPUListState, more testing > > > > Signed-off-by: Andreas Färber <afaerber(a)suse.de> > > Cc: Eduardo Habkost <ehabkost(a)redhat.com> > > Cc: Igor Mammedov <imammedo(a)redhat.com> [...] > The patch is just renaming of the current builtin_x86_defs > into a bunch of functions and polluting X86CPUClass > with fields from the former x86_def_t. > object_new() still creates a dummy cpu instance whose defaults > are still manually copied from X86CPUClass instead of x86_def_t. > That's a good thing, isn't it? It means the patch is easier to review. :-) No patch alone will do everything we want, because we want to do a lot. We need to do it one step at a time. (BTW, why are you looking at this RFC instead of the more recent one, that I have sent on Jan 4? [that's very similar to this one]) > What's the point in having dummy sub-classes? > How it can help in your CPU re-factoring? It will help us to unify the CPU creation/realization code that's duplicated over all the architectures. It will give libvirt an easy mechanism to list the available CPU models that won't require parsing help output (using "qom-list-types" QMP command). > > > On the other hand converting features to static properties first and > then converting X86CPU to sub-classes, yields already initialized to > defaults sub-class completely removing notion of x86_def_t and > not polluting X86CPUClass with redundant fields. I wouldn't disagree with this approach in principle, but I believe our main problem today is lack of reviewer bandwidth. I learned the hard way that trying to clean up everything before implementing something will make sure the code takes forever to be reviewed. > For example see following patches on > https://github.com/imammedo/qemu/commits/x86-cpu-classes.Jan142013 > > e9fd18f qdev: extend DEFINE_GENERIC_PROP() to support default values > c65eca9 qdev: make qdev_prop_find_bit return non const so prop default value could be modified > 0311952 allow to expolit default value static props for model, family, stepping & vendor props > 8b3080e target-i386: add helpers to change default values of static properties before object is created > ed506d3 target-i386: prepare for subclasses to have its own instance of static properties definitions > a48e252 target-i386: declare subclass for qemu64 cpu model > 9c556c2 target-i386: move cpu_x86_init() & cpu_x86_register() into it and switch to subclasses. PS: implemended only for qemu64 > f5dbfe6 CPU_CLASS_NAME(qemu64) hack > 00e15b8 target-i386: properties list are per subclass: do not set them in superclass to avoid defaults set by subclass be over-written > > -- > Regards, > Igor -- Eduardo

1 0

[libvirt] [PATCH 0/9] Add ability to connect to LXC namespaces
by Daniel P. Berrange 15 Jan '13

15 Jan '13

This series introduces an LXC specific library libvirt-lxc.so which adds ability for a process to connect to the namespaces used by an LXC container from outside. It uses FD passing magic to allow the caller to connect, even if it is not root.

3 23

[libvirt] [test-API][PATCH] Add logical volume download and upload cases
by Wayne Sun 15 Jan '13

15 Jan '13

This is for logical volume download and upload testing. * using download and upload API under class virStream. they are functions act as same with download/upload APIs under class virStorageVol, just different entrance. * using logical volume specified xml to create volume. no need to provide volume format. * check method is the same with dir vol download/upload cases. Signed-off-by: Wayne Sun <gsun(a)redhat.com> --- cases/storage_logical_vol_upload_download.conf | 179 ++++++++++++++++++++++++ repos/storage/logical_vol_download.py | 125 +++++++++++++++++ repos/storage/logical_vol_upload.py | 152 ++++++++++++++++++++ 3 files changed, 456 insertions(+), 0 deletions(-) create mode 100644 cases/storage_logical_vol_upload_download.conf create mode 100644 repos/storage/logical_vol_download.py create mode 100644 repos/storage/logical_vol_upload.py diff --git a/cases/storage_logical_vol_upload_download.conf b/cases/storage_logical_vol_upload_download.conf new file mode 100644 index 0000000..51b640e --- /dev/null +++ b/cases/storage_logical_vol_upload_download.conf @@ -0,0 +1,179 @@ +storage:define_logical_pool + poolname + $defaultpoolname + sourcename + $defaultpoolname + sourcepath + $defaultpartition + +storage:build_logical_pool + poolname + $defaultpoolname + +storage:activate_pool + poolname + $defaultpoolname + +storage:logical_vol_download + poolname + $defaultpoolname + volname + $defaultvolumename + capacity + 50 + offset + 0 + length + 0 +clean + +storage:delete_logical_volume + poolname + $defaultpoolname + volname + $defaultvolumename + +storage:logical_vol_download + poolname + $defaultpoolname + volname + $defaultvolumename + capacity + 50 + offset + 0 + length + 1048576 +clean + +storage:delete_logical_volume + poolname + $defaultpoolname + volname + $defaultvolumename + +storage:logical_vol_download + poolname + $defaultpoolname + volname + $defaultvolumename + capacity + 50 + offset + 1048576 + length + 0 +clean + +storage:delete_logical_volume + poolname + $defaultpoolname + volname + $defaultvolumename + +storage:logical_vol_download + poolname + $defaultpoolname + volname + $defaultvolumename + capacity + 50 + offset + 1048576 + length + 1048576 +clean + +storage:delete_logical_volume + poolname + $defaultpoolname + volname + $defaultvolumename + +storage:logical_vol_upload + poolname + $defaultpoolname + volname + $defaultvolumename + capacity + 50 + offset + 0 + length + 0 +clean + +storage:delete_logical_volume + poolname + $defaultpoolname + volname + $defaultvolumename + +storage:logical_vol_upload + poolname + $defaultpoolname + volname + $defaultvolumename + capacity + 50 + offset + 0 + length + 1048576 +clean + +storage:delete_logical_volume + poolname + $defaultpoolname + volname + $defaultvolumename + +storage:logical_vol_upload + poolname + $defaultpoolname + volname + $defaultvolumename + capacity + 50 + offset + 1048576 + length + 0 +clean + +storage:delete_logical_volume + poolname + $defaultpoolname + volname + $defaultvolumename + +storage:logical_vol_upload + poolname + $defaultpoolname + volname + $defaultvolumename + capacity + 50 + offset + 1048576 + length + 1048576 +clean + +storage:delete_logical_volume + poolname + $defaultpoolname + volname + $defaultvolumename + +storage:destroy_pool + poolname + $defaultpoolname + +storage:delete_logical_pool + poolname + $defaultpoolname + +storage:undefine_pool + poolname + $defaultpoolname diff --git a/repos/storage/logical_vol_download.py b/repos/storage/logical_vol_download.py new file mode 100644 index 0000000..9797f36 --- /dev/null +++ b/repos/storage/logical_vol_download.py @@ -0,0 +1,125 @@ +#!/usr/bin/env python +# logical storage volume download testing + +import os +import string +from xml.dom import minidom + +import libvirt +from libvirt import libvirtError + +from src import sharedmod +from utils import utils + +required_params = ('poolname', 'volname', 'capacity', 'offset', 'length',) +optional_params = {'xml' : 'xmls/logical_volume.xml', + } + +def get_pool_path(poolobj): + """ get pool xml description + """ + poolxml = poolobj.XMLDesc(0) + + logger.debug("the xml description of pool is %s" % poolxml) + + doc = minidom.parseString(poolxml) + path_element = doc.getElementsByTagName('path')[0] + textnode = path_element.childNodes[0] + path_value = textnode.data + + return path_value + +def write_file(path, capacity): + """write test data to file + """ + logger.info("write %sM data into file %s" % (capacity, path)) + f = open(path, 'w') + datastr = ''.join(string.lowercase + string.uppercase + + string.digits + '.' + '\n') + repeat = capacity / 64 + data = ''.join(repeat * datastr) + f.write(data) + f.close() + +def handler(stream, data, file_): + return file_.write(data) + +def logical_vol_download(params): + """test volume download and check""" + global logger + logger = params['logger'] + poolname = params['poolname'] + volname = params['volname'] + offset = int(params['offset']) + length = int(params['length']) + capacity = int(params['capacity']) + xmlstr = params['xml'] + + logger.info("the poolname is %s, volname is %s" % + (poolname, volname)) + logger.info("download offset is: %s" % offset) + logger.info("the data length to download is: %s" % length) + + conn = sharedmod.libvirtobj['conn'] + try: + poolobj = conn.storagePoolLookupByName(poolname) + path_value = get_pool_path(poolobj) + volume_path = path_value + "/" + volname + logger.debug("volume target path: %s" % volume_path) + + xmlstr = xmlstr.replace('TARGETPATH', volume_path) + logger.debug("volume xml:\n%s" % xmlstr) + + logger.info("create %s logical storage volume" % volname) + vol = poolobj.createXML(xmlstr, 0) + logger.debug("current created storage volume: %s" % + poolobj.listVolumes()) + + write_file(volume_path, capacity) + origdigest = utils.digest(volume_path, offset, length) + logger.debug("the md5 hex digest of data read from %s is: %s" % + (volume_path, origdigest)) + + st = conn.newStream(0) + + test_path = path_value + "/" + "vol_test" + + f = open(test_path, 'w') + logger.info("start download") + st.download(vol, offset, length, 0) + logger.info("downloaded all data") + st.recvAll(handler, f) + logger.info("finished stream") + st.finish() + f.close() + + newdigest = utils.digest(test_path, 0, 0) + logger.debug("the md5 hex digest of data read from %s is: %s" % + (test_path, newdigest)) + + if origdigest == newdigest: + logger.info("file digests match, download succeed") + else: + logger.error("file digests not match, download failed") + return 1 + + except libvirtError, e: + logger.error("libvirt call failed: " + str(e)) + return 1 + + return 0 + +def logical_vol_download_clean(params): + """clean testing environment""" + poolname = params['poolname'] + volname = params['volname'] + + conn = sharedmod.libvirtobj['conn'] + poolobj = conn.storagePoolLookupByName(poolname) + path_value = get_pool_path(poolobj) + test_path = path_value + "/" + "vol_test" + + if os.path.exists(test_path): + os.unlink(test_path) + + return 0 diff --git a/repos/storage/logical_vol_upload.py b/repos/storage/logical_vol_upload.py new file mode 100644 index 0000000..fc03ee6 --- /dev/null +++ b/repos/storage/logical_vol_upload.py @@ -0,0 +1,152 @@ +#!/usr/bin/env python +# logical storage volume upload testing, offset and length can +# only be chosen in 0 and 1048576. + +import os +import string +from xml.dom import minidom + +import libvirt +from libvirt import libvirtError + +from src import sharedmod +from utils import utils + +required_params = ('poolname', 'volname', 'capacity', 'offset', 'length',) +optional_params = {'xml' : 'xmls/logical_volume.xml', + } + +def get_pool_path(poolobj): + """ get pool xml description + """ + poolxml = poolobj.XMLDesc(0) + + logger.debug("the xml description of pool is %s" % poolxml) + + doc = minidom.parseString(poolxml) + path_element = doc.getElementsByTagName('path')[0] + textnode = path_element.childNodes[0] + path_value = textnode.data + + return path_value + +def write_file(path): + """write 1M test data to file + """ + logger.info("write 1M data into file %s" % path) + f = open(path, 'w') + datastr = ''.join(string.lowercase + string.uppercase + + string.digits + '.' + '\n') + data = ''.join(16384 * datastr) + f.write(data) + f.close() + +def handler(stream, data, file_): + return file_.read(data) + +def logical_vol_upload(params): + """test volume download and check""" + global logger + logger = params['logger'] + poolname = params['poolname'] + volname = params['volname'] + offset = int(params['offset']) + length = int(params['length']) + capacity = int(params['capacity']) + xmlstr = params['xml'] + + logger.info("the poolname is %s, volname is %s" % + (poolname, volname)) + logger.info("download offset is: %s" % offset) + logger.info("the data length to download is: %s" % length) + + conn = sharedmod.libvirtobj['conn'] + try: + poolobj = conn.storagePoolLookupByName(poolname) + path_value = get_pool_path(poolobj) + volume_path = path_value + "/" + volname + logger.debug("volume target path: %s" % volume_path) + + xmlstr = xmlstr.replace('TARGETPATH', volume_path) + logger.debug("volume xml:\n%s" % xmlstr) + + logger.info("create %s logical storage volume" % volname) + vol = poolobj.createXML(xmlstr, 0) + logger.debug("current created storage volume: %s" % + poolobj.listVolumes()) + + test_path = path_value + "/" + "vol_test" + write_file(test_path) + olddigest = utils.digest(test_path, 0, 0) + logger.debug("the old file digest is: %s" % olddigest) + + if offset: + origdigestpre = utils.digest(volume_path, 0, offset) + else: + origdigestpre = '' + logger.debug("the original pre region digest is: %s" % origdigestpre) + + origdigestpost = utils.digest(volume_path, offset + 1024 * 1024, 0) + logger.debug("the original post region digest is: %s" % origdigestpost) + + st = conn.newStream(0) + + f = open(test_path, 'r') + logger.info("start upload") + st.upload(vol, offset, length, 0) + logger.info("sent all data") + st.sendAll(handler, f) + logger.info("finished stream") + st.finish() + f.close() + + newdigest = utils.digest(volume_path, offset, 1024 * 1024) + logger.debug("the new file digest is: %s" % olddigest) + + if offset: + newdigestpre = utils.digest(volume_path, 0, offset) + else: + newdigestpre = '' + logger.debug("the new pre region digest is: %s" % origdigestpre) + + newdigestpost = utils.digest(volume_path, offset + 1024 * 1024, 0) + logger.debug("the new post region digest is: %s" % origdigestpost) + + if newdigestpre == origdigestpre: + logger.info("file pre region digests match") + else: + logger.error("file pre region digests not match") + return 1 + + if olddigest == newdigest: + logger.info("file digests match") + else: + logger.error("file digests not match") + return 1 + + if newdigestpost == origdigestpost: + logger.info("file post region digests match") + else: + logger.error("file post region digests not match") + return 1 + + except libvirtError, e: + logger.error("libvirt call failed: " + str(e)) + return 1 + + return 0 + +def logical_vol_upload_clean(params): + """clean testing environment""" + poolname = params['poolname'] + volname = params['volname'] + + conn = sharedmod.libvirtobj['conn'] + poolobj = conn.storagePoolLookupByName(poolname) + path_value = get_pool_path(poolobj) + test_path = path_value + "/" + "vol_test" + + if os.path.exists(test_path): + os.unlink(test_path) + + return 0 -- 1.7.1

2 1

[libvirt] [test-API][PATCH] Add volume resize case with delta flag
by Wayne Sun 15 Jan '13

15 Jan '13

Only storage backend for RBD (RADOS Block Device), FS and directory have the resizeVol function, so only testing dir volume here. Flags 'allocate' and 'shrik' are with bug: https://bugzilla.redhat.com/show_bug.cgi?id=804516 they are not supported yet, so leave the case for later. * using volume resize API with flag VIR_STORAGE_VOL_RESIZE_DELTA * using volume info API to get volume info and check * add dir volume resize conf Signed-off-by: Wayne Sun <gsun(a)redhat.com> --- cases/storage_dir_vol_resize_delta.conf | 47 +++++++++++++++++++ repos/storage/vol_resize_delta.py | 75 +++++++++++++++++++++++++++++++ 2 files changed, 122 insertions(+), 0 deletions(-) create mode 100644 cases/storage_dir_vol_resize_delta.conf create mode 100644 repos/storage/vol_resize_delta.py diff --git a/cases/storage_dir_vol_resize_delta.conf b/cases/storage_dir_vol_resize_delta.conf new file mode 100644 index 0000000..58e15bf --- /dev/null +++ b/cases/storage_dir_vol_resize_delta.conf @@ -0,0 +1,47 @@ +storage:create_dir_pool + poolname + $defaultpoolname + +storage:create_dir_volume + poolname + $defaultpoolname + volname + $defaultvolumename + volformat + $defaultvolumetype + capacity + $defaultvolumesize + +storage:vol_resize_delta + poolname + $defaultpoolname + volname + $defaultvolumename + capacity + 1M + +storage:vol_resize_delta + poolname + $defaultpoolname + volname + $defaultvolumename + capacity + 2G + +storage:vol_resize_delta + poolname + $defaultpoolname + volname + $defaultvolumename + capacity + 4096K + +storage:delete_dir_volume + poolname + $defaultpoolname + volname + $defaultvolumename + +storage:destroy_pool + poolname + $defaultpoolname diff --git a/repos/storage/vol_resize_delta.py b/repos/storage/vol_resize_delta.py new file mode 100644 index 0000000..a87941e --- /dev/null +++ b/repos/storage/vol_resize_delta.py @@ -0,0 +1,75 @@ +#!/usr/bin/env python +# volume resize testing with delta flags, libvirt storage +# driver only support dir now + +import libvirt +from libvirt import libvirtError + +from src import sharedmod +from utils import utils + +required_params = ('poolname', 'volname', 'capacity',) +optional_params = {} + +def vol_resize_delta(params): + """test volume resize with delta flags""" + + global logger + logger = params['logger'] + poolname = params['poolname'] + volname = params['volname'] + capacity = params['capacity'] + + logger.info("the poolname is %s, volname is %s" % + (poolname, volname)) + + logger.info("the capacity given is %s" % capacity) + out = utils.get_capacity_suffix_size(capacity) + capacity_val = out['capacity_byte'] + logger.debug("the capacity to byte is %s" % capacity_val) + + conn = sharedmod.libvirtobj['conn'] + try: + poolobj = conn.storagePoolLookupByName(poolname) + vol = poolobj.storageVolLookupByName(volname) + + logger.info("get volume info before resize") + out = vol.info() + pre_capacity = out[1] + pre_allocation = out[2] + logger.info("volume capacity is %s bytes, allocation is %s bytes" % + (pre_capacity, pre_allocation)) + + flag = libvirt.VIR_STORAGE_VOL_RESIZE_DELTA + logger.info("resize %s with capacity %s in pool %s using flag: %s" + % (volname, capacity, poolname, flag)) + + vol.resize(capacity_val, flag) + + logger.info("get volume info after resize") + out = vol.info() + post_capacity = out[1] + post_allocation = out[2] + logger.info("volume capacity is %s bytes, allocation is %s bytes" % + (post_capacity, post_allocation)) + + logger.info("check resize effect") + if post_capacity - pre_capacity == capacity_val: + logger.info("increased size is expected") + else: + logger.error("increase size not equal to set, resize failed") + return 1 + + if pre_allocation == post_allocation: + logger.info("allocation is expected") + else: + logger.error("allocation changed, resize failed") + return 1 + + logger.info("resize succeed") + + except libvirtError, e: + logger.error("libvirt call failed: " + str(e)) + return 1 + + return 0 -- 1.7.1

2 1

[libvirt] [test-API][PATCH] Add find storage pool sources cases
by Wayne Sun 15 Jan '13

15 Jan '13

Add cases for testing findStoragePoolSources API * add 3 cases for storage type 'netfs', 'iscsi' and 'logical' * add 2 xmls for 'netfs' and 'iscsi' find 'logical' storage pool sources did not require xml start with source tag and xml could be empty * add test conf for find storage pool sources Signed-off-by: Wayne Sun <gsun(a)redhat.com> --- cases/find_storage_pool_sources.conf | 31 +++++++++++ repos/storage/find_iscsi_pool_sources.py | 72 ++++++++++++++++++++++++ repos/storage/find_logical_pool_sources.py | 82 ++++++++++++++++++++++++++++ repos/storage/find_netfs_pool_sources.py | 71 ++++++++++++++++++++++++ repos/storage/xmls/iscsi_pool_source.xml | 3 + repos/storage/xmls/netfs_pool_source.xml | 4 ++ 6 files changed, 263 insertions(+), 0 deletions(-) create mode 100644 cases/find_storage_pool_sources.conf create mode 100644 repos/storage/find_iscsi_pool_sources.py create mode 100644 repos/storage/find_logical_pool_sources.py create mode 100644 repos/storage/find_netfs_pool_sources.py create mode 100644 repos/storage/xmls/iscsi_pool_source.xml create mode 100644 repos/storage/xmls/netfs_pool_source.xml diff --git a/cases/find_storage_pool_sources.conf b/cases/find_storage_pool_sources.conf new file mode 100644 index 0000000..d2e86db --- /dev/null +++ b/cases/find_storage_pool_sources.conf @@ -0,0 +1,31 @@ +storage:find_iscsi_pool_sources + sourcehost + $iscsi_server + +storage:find_netfs_pool_sources + sourcehost + $nfs_server + +storage:define_logical_pool + poolname + $defaultpoolname + sourcename + $defaultpoolname + sourcepath + $defaultpartition + +storage:build_logical_pool + poolname + $defaultpoolname + +storage:find_logical_pool_sources + sourcepath + $defaultpartition + +storage:delete_logical_pool + poolname + $defaultpoolname + +storage:undefine_pool + poolname + $defaultpoolname diff --git a/repos/storage/find_iscsi_pool_sources.py b/repos/storage/find_iscsi_pool_sources.py new file mode 100644 index 0000000..4b758d2 --- /dev/null +++ b/repos/storage/find_iscsi_pool_sources.py @@ -0,0 +1,72 @@ +#!/usr/bin/env python +# Test finding storage pool source of 'iscsi' type + +from xml.dom import minidom + +import libvirt +from libvirt import libvirtError + +from src import sharedmod +from utils import utils + +required_params = ('sourcehost',) +optional_params = {'xml' : 'xmls/iscsi_pool_source.xml', + } + +def check_pool_sources(host, xmlstr): + """check the iscsi sources with command: + iscsiadm --mode discovery --type sendtargets --portal + """ + source_val = [] + + doc = minidom.parseString(xmlstr) + for diskTag in doc.getElementsByTagName("source"): + device_element = diskTag.getElementsByTagName("device")[0] + attr = device_element.getAttributeNode('path') + path_val = attr.nodeValue + + source_val.append(path_val) + + logger.debug("pool source info list is: %s" % source_val) + + cmd = "iscsiadm --mode discovery --type sendtargets --portal %s:3260,1 |\ + awk -F' ' '{print $2}'" % host + ret, path_list = utils.exec_cmd(cmd, shell=True) + + logger.debug("iscsiadm command output list is: %s" % path_list) + + if source_val == path_list: + logger.info("source list matched with iscsiadm command output") + return 0 + else: + logger.error("source list did not match with iscsiadm command output") + return 1 + +def find_iscsi_pool_sources(params): + """Find iscsi type storage pool sources from xml""" + global logger + logger = params['logger'] + sourcehost = params['sourcehost'] + xmlstr = params['xml'] + + conn = sharedmod.libvirtobj['conn'] + try: + + logger.debug("storage source spec xml:\n%s" % xmlstr) + + logger.info("find pool sources of iscsi type") + source_xml = conn.findStoragePoolSources('iscsi', xmlstr, 0) + logger.info("pool sources xml description is:\n %s" % source_xml) + + ret = check_pool_sources(sourcehost, source_xml) + if ret: + logger.error("pool sources check failed") + return 1 + else: + logger.info("pool sources check succeed") + + except libvirtError, e: + logger.error("libvirt call failed: " + str(e)) + return 1 + + return 0 diff --git a/repos/storage/find_logical_pool_sources.py b/repos/storage/find_logical_pool_sources.py new file mode 100644 index 0000000..255d879 --- /dev/null +++ b/repos/storage/find_logical_pool_sources.py @@ -0,0 +1,82 @@ +#!/usr/bin/env python +# Test finding storage pool source of 'logical' type + +from xml.dom import minidom + +import libvirt +from libvirt import libvirtError + +from src import sharedmod +from utils import utils + +required_params = ('sourcepath',) +optional_params = {'xml' : 'xmls/logical_pool.xml', + } + +def check_pool_sources(xmlstr): + """check the logical sources with command: + pvs --noheadings -o pv_name,vg_name + """ + source_val = {} + source_cmp = {} + + doc = minidom.parseString(xmlstr) + for diskTag in doc.getElementsByTagName("source"): + device_element = diskTag.getElementsByTagName("device")[0] + attr = device_element.getAttributeNode('path') + path_val = attr.nodeValue + + name_element = diskTag.getElementsByTagName("name")[0] + textnode = name_element.childNodes[0] + name_val = textnode.data + + source_val.update({path_val: name_val, }) + + logger.debug("pool source info dict is: %s" % source_val) + + cmd = "pvs --noheadings -o pv_name,vg_name | awk -F' ' '{print $1}'" + ret, path_list = utils.exec_cmd(cmd, shell=True) + + cmd = "pvs --noheadings -o pv_name,vg_name | awk -F' ' '{print $2}'" + ret, name_list = utils.exec_cmd(cmd, shell=True) + + for i in range(len(path_list)): + source_cmp.update({path_list[i]: name_list[i]}) + + logger.debug("pvs command output dict is: %s" % source_cmp) + + if source_val == source_cmp: + logger.info("source dict match with pvs command output") + return 0 + else: + logger.error("source dict did not match with pvs command output") + return 1 + +def find_logical_pool_sources(params): + """Find logical type storage pool sources from xml""" + global logger + logger = params['logger'] + sourcepath = params['sourcepath'] + xmlstr = params['xml'] + + conn = sharedmod.libvirtobj['conn'] + try: + + logger.debug("storage source spec xml:\n%s" % xmlstr) + + logger.info("find pool sources of logical type") + source_xml = conn.findStoragePoolSources('logical', xmlstr, 0) + logger.info("pool sources xml description is:\n %s" % source_xml) + + ret = check_pool_sources(source_xml) + if ret: + logger.error("pool sources check failed") + return 1 + else: + logger.info("pool sources check succeed") + + except libvirtError, e: + logger.error("libvirt call failed: " + str(e)) + return 1 + + return 0 diff --git a/repos/storage/find_netfs_pool_sources.py b/repos/storage/find_netfs_pool_sources.py new file mode 100644 index 0000000..bc71233 --- /dev/null +++ b/repos/storage/find_netfs_pool_sources.py @@ -0,0 +1,71 @@ +#!/usr/bin/env python +# Test finding storage pool source of 'netfs' type + +from xml.dom import minidom + +import libvirt +from libvirt import libvirtError + +from src import sharedmod +from utils import utils + +required_params = ('sourcehost',) +optional_params = {'xml' : 'xmls/netfs_pool_source.xml', + } + +def check_pool_sources(host, xmlstr): + """check the netfs sources with command: + showmount --no-headers -e HOSTNAME + """ + source_val = [] + + doc = minidom.parseString(xmlstr) + for diskTag in doc.getElementsByTagName("source"): + device_element = diskTag.getElementsByTagName("dir")[0] + attr = device_element.getAttributeNode('path') + path_val = attr.nodeValue + + source_val.append(path_val) + + logger.debug("pool source info list is: %s" % source_val) + + cmd = "showmount --no-headers -e %s | awk -F' ' '{print $1}'" % host + ret, path_list = utils.exec_cmd(cmd, shell=True) + + logger.debug("showmount command output list is: %s" % path_list) + + if source_val == path_list: + logger.info("source list matched with showmount command output") + return 0 + else: + logger.error("source list did not match with showmount command output") + return 1 + +def find_netfs_pool_sources(params): + """Find netfs type storage pool sources from xml""" + global logger + logger = params['logger'] + sourcehost = params['sourcehost'] + xmlstr = params['xml'] + + conn = sharedmod.libvirtobj['conn'] + try: + + logger.debug("storage source spec xml:\n%s" % xmlstr) + + logger.info("find pool sources of netfs type") + source_xml = conn.findStoragePoolSources('netfs', xmlstr, 0) + logger.info("pool sources xml description is:\n %s" % source_xml) + + ret = check_pool_sources(sourcehost, source_xml) + if ret: + logger.error("pool sources check failed") + return 1 + else: + logger.info("pool sources check succeed") + + except libvirtError, e: + logger.error("libvirt call failed: " + str(e)) + return 1 + + return 0 diff --git a/repos/storage/xmls/iscsi_pool_source.xml b/repos/storage/xmls/iscsi_pool_source.xml new file mode 100644 index 0000000..93216c5 --- /dev/null +++ b/repos/storage/xmls/iscsi_pool_source.xml @@ -0,0 +1,3 @@ +<source> + <host name="SOURCEHOST"/> +</source> diff --git a/repos/storage/xmls/netfs_pool_source.xml b/repos/storage/xmls/netfs_pool_source.xml new file mode 100644 index 0000000..6a2aeea --- /dev/null +++ b/repos/storage/xmls/netfs_pool_source.xml @@ -0,0 +1,4 @@ +<source> + <host name="SOURCEHOST"/> + <format type="nfs"/> +</source> -- 1.7.1

2 1

[libvirt] [test-API][PATCH] Add the volume clone case
by Wayne Sun 15 Jan '13

15 Jan '13

This is for volume clone testing by using createXMLFrom API * add the vol_clone case under storage it is general for all pool types * add cases into confs: cases/storage_dir.conf cases/storage_logical.conf cases/storage_netfs.conf * add variable 'defaultvolclonename' in global.cfg Signed-off-by: Wayne Sun <gsun(a)redhat.com> --- cases/storage_dir.conf | 14 +++++++ cases/storage_logical.conf | 14 +++++++ cases/storage_netfs.conf | 14 +++++++ global.cfg | 2 + repos/storage/vol_clone.py | 81 ++++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 125 insertions(+), 0 deletions(-) create mode 100644 repos/storage/vol_clone.py diff --git a/cases/storage_dir.conf b/cases/storage_dir.conf index dcac700..38b349d 100644 --- a/cases/storage_dir.conf +++ b/cases/storage_dir.conf @@ -20,6 +20,20 @@ storage:create_dir_volume capacity $defaultvolumesize +storage:vol_clone + poolname + $defaultpoolname + volname + $defaultvolumename + clonevolname + $defaultvolclonename + +storage:delete_dir_volume + poolname + $defaultpoolname + volname + $defaultvolclonename + storage:delete_dir_volume poolname $defaultpoolname diff --git a/cases/storage_logical.conf b/cases/storage_logical.conf index 3334abd..d374dfa 100644 --- a/cases/storage_logical.conf +++ b/cases/storage_logical.conf @@ -22,6 +22,20 @@ storage:create_logical_volume capacity $defaultvolumesize +storage:vol_clone + poolname + $defaultpoolname + volname + $defaultvolumename + clonevolname + $defaultvolclonename + +storage:delete_logical_volume + poolname + $defaultpoolname + volname + $defaultvolclonename + storage:delete_logical_volume poolname $defaultpoolname diff --git a/cases/storage_netfs.conf b/cases/storage_netfs.conf index e764813..f486ff4 100644 --- a/cases/storage_netfs.conf +++ b/cases/storage_netfs.conf @@ -24,6 +24,20 @@ storage:create_netfs_volume capacity $defaultvolumesize +storage:vol_clone + poolname + $defaultpoolname + volname + $defaultvolumename + clonevolname + $defaultvolclonename + +storage:delete_netfs_volume + poolname + $defaultpoolname + volname + $defaultvolclonename + storage:delete_netfs_volume poolname $defaultpoolname diff --git a/global.cfg b/global.cfg index 9e28614..182acbd 100644 --- a/global.cfg +++ b/global.cfg @@ -156,6 +156,8 @@ defaultpoolname = test_api_pool defaultpoolpath = /var/lib/libvirt/images/dir_pool # default volume name for creating new volume defaultvolumename = test_api_volume +# default clone volume name for clone a volume +defaultvolclonename = test_clone_volume # default volume type for creating a new volume defaultvolumetype = raw # default volume capacity for creating a new volume diff --git a/repos/storage/vol_clone.py b/repos/storage/vol_clone.py new file mode 100644 index 0000000..abf5644 --- /dev/null +++ b/repos/storage/vol_clone.py @@ -0,0 +1,81 @@ +#!/usr/bin/env python +# volume clone testing + +import os +from xml.dom import minidom + +import libvirt +from libvirt import libvirtError + +from src import sharedmod + +required_params = ('poolname', 'volname', 'clonevolname',) +optional_params = {} + +def prepare_clone_xml(xmlstr, volname): + """prepare clone xmldesc by replace name element + with clone souce volume xml + """ + doc = minidom.parseString(xmlstr) + oldname = doc.getElementsByTagName("name")[0] + + newname = doc.createElement('name') + newnameval = doc.createTextNode(volname) + newname.appendChild(newnameval) + + volume = doc.getElementsByTagName('volume')[0] + + volume.replaceChild(newname, oldname) + newxmlstr = doc.toxml() + + return newxmlstr + +def vol_clone(params): + """volume clone testing""" + + global logger + logger = params['logger'] + poolname = params['poolname'] + volname = params['volname'] + clonevolname = params['clonevolname'] + + logger.info("the poolname is %s, volname is %s" % (poolname, volname)) + logger.info("the clone volume name is %s" % clonevolname) + + conn = sharedmod.libvirtobj['conn'] + try: + poolobj = conn.storagePoolLookupByName(poolname) + old_vol = poolobj.storageVolLookupByName(volname) + + xmlstr = old_vol.XMLDesc(0) + newxmlstr = prepare_clone_xml(xmlstr, clonevolname) + logger.debug("volume xml:\n%s" % newxmlstr) + + logger.info("clone volume %s from source volume %s" % + (clonevolname, volname)) + + old_volnum = poolobj.numOfVolumes() + + new_vol = poolobj.createXMLFrom(newxmlstr, old_vol, 0) + poolobj.refresh(0) + + new_volnum = poolobj.numOfVolumes() + + logger.debug("new cloned volume path is: %s" % new_vol.path()) + if os.access(new_vol.path(), os.R_OK): + logger.info("cloned volume path exist") + else: + logger.error("cloned volume path not exist") + return 1 + + if new_volnum > old_volnum: + logger.info("clone succeed") + else: + logger.error("clone failed") + return 1 + + except libvirtError, e: + logger.error("libvirt call failed: " + str(e)) + return 1 + + return 0 -- 1.7.1

2 1

[libvirt] [PATCH] docs: remove extra "
by Eric Blake 15 Jan '13

15 Jan '13

* tools/virsh.pod: Fix typo. --- Pushing under the trivial rule. tools/virsh.pod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 3687a4d..c9ebc8f 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -2095,7 +2095,7 @@ destroy and re-start the network. I<command> is one of "add-first", "add-last", "add" (a synonym for add-last), "delete", or "modify". -I<section> is one of ""bridge", "domain", "ip", "ip-dhcp-host", +I<section> is one of "bridge", "domain", "ip", "ip-dhcp-host", "ip-dhcp-range", "forward", "forward-interface", "forward-pf", "portgroup", "dns-host", "dns-txt", or "dns-srv", each section being named by a concatenation of the xml element hierarchy leading to the -- 1.8.0.2

1 0

[libvirt] [PATCH v2] Build breaker securityselinuxhelper.c
by John Ferlan 15 Jan '13

15 Jan '13

v2: syntax-check - need space on # include Commit 907a39e7 missed adding the WITH_ATTR around #include <attr/xattr.h> resulting in a build failure: CC libsecurityselinuxhelper_la-securityselinuxhelper.lo securityselinuxhelper.c:27:24: fatal error: attr/xattr.h: No such file or directory compilation terminated. make[2]: *** [libsecurityselinuxhelper_la-securityselinuxhelper.lo] Error 1 make[2]: Leaving directory `/home/jferlan/libvirt.work/tests' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/jferlan/libvirt.work' make: *** [all] Error 2 --- tests/securityselinuxhelper.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/securityselinuxhelper.c b/tests/securityselinuxhelper.c index daad7dd..a9656a8 100644 --- a/tests/securityselinuxhelper.c +++ b/tests/securityselinuxhelper.c @@ -24,7 +24,9 @@ #include <string.h> #include <unistd.h> #include <errno.h> -#include <attr/xattr.h> +#if WITH_ATTR +# include <attr/xattr.h> +#endif /* -- 1.7.11.7

3 2

[libvirt] [PATCH] Don't try to include xattr.h if not available
by Guido Günther 15 Jan '13

15 Jan '13

--- tests/securityselinuxhelper.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/securityselinuxhelper.c b/tests/securityselinuxhelper.c index abe4d7c..bd5ea87 100644 --- a/tests/securityselinuxhelper.c +++ b/tests/securityselinuxhelper.c @@ -24,7 +24,9 @@ #include <string.h> #include <unistd.h> #include <errno.h> -#include <attr/xattr.h> +#ifdef WITH_ATTR +# include <attr/xattr.h> +#endif /* -- 1.7.10.4

1 0

[libvirt] [ANNOUNCE] libvirt-glib 0.1.5 release
by Daniel P. Berrange 15 Jan '13

15 Jan '13

I am pleased to announce that a new release of the libvirt-glib package, version 0.1.5, is now available from ftp://libvirt.org/libvirt/glib/ The packages are GPG signed with Key fingerprint: DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF (4096R) New in this release: - Add support for bridge interface types in guest XML - Add API to open a read-only connection - Add support for smartcard devices in guest XML - Remove storage volume from pool list after deleting it libvirt-glib comprises three distinct libraries: - libvirt-glib - Integrate with the GLib event loop and error handling - libvirt-gconfig - Representation of libvirt XML documents as GObjects - libvirt-gobject - Mapping of libvirt APIs into the GObject type system NB: While libvirt aims to be API/ABI stable forever, with libvirt-glib we are not yet guaranteeing that libvirt-glib libraries are API/ABI permanently stable. As of the 0.0.8 release, we have tentatively frozen the API/ABI with the intent of being longterm stable hereafter, but there is still a small chance we might find flaws requiring an API/ABI change. The likelihood of this is low, however, and we will strive to avoid it. Follow up comments about libvirt-glib should be directed to the regular libvir-list(a)redhat.com development list. Thanks to all the people involved in contributing to this release. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

1 0

[libvirt] [PATCH] Build breaker securityselinuxhelper.c
by John Ferlan 15 Jan '13

15 Jan '13

Commit 907a39e7 missed adding the WITH_ATTR around #include <attr/xattr.h> resulting in a build failure: CC libsecurityselinuxhelper_la-securityselinuxhelper.lo securityselinuxhelper.c:27:24: fatal error: attr/xattr.h: No such file or directory compilation terminated. make[2]: *** [libsecurityselinuxhelper_la-securityselinuxhelper.lo] Error 1 make[2]: Leaving directory `/home/jferlan/libvirt.work/tests' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/jferlan/libvirt.work' make: *** [all] Error 2 --- tests/securityselinuxhelper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/securityselinuxhelper.c b/tests/securityselinuxhelper.c index daad7dd..206d936 100644 --- a/tests/securityselinuxhelper.c +++ b/tests/securityselinuxhelper.c @@ -24,7 +24,9 @@ #include <string.h> #include <unistd.h> #include <errno.h> +#if WITH_ATTR #include <attr/xattr.h> +#endif /* -- 1.7.11.7

1 0

[libvirt] [PATCH] build: work around broken kernel header
by Eric Blake 15 Jan '13

15 Jan '13

I got this scary warning during ./configure on rawhide: checking linux/if_bridge.h usability... no checking linux/if_bridge.h presence... yes configure: WARNING: linux/if_bridge.h: present but cannot be compiled configure: WARNING: linux/if_bridge.h: check for missing prerequisite headers? configure: WARNING: linux/if_bridge.h: see the Autoconf documentation configure: WARNING: linux/if_bridge.h: section "Present But Cannot Be Compiled" configure: WARNING: linux/if_bridge.h: proceeding with the compiler's result configure: WARNING: ## ------------------------------------- ## configure: WARNING: ## Report this to libvir-list(a)redhat.com ## configure: WARNING: ## ------------------------------------- ## checking for linux/if_bridge.h... no * configure.ac (AC_CHECK_HEADERS): Provide struct in6_addr, since linux/if_bridge.h uses it without declaring it. --- Pushing under the build-breaker rule. I also plan on opening a BZ against the kernel headers. configure.ac | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 753916c..31e7f80 100644 --- a/configure.ac +++ b/configure.ac @@ -978,7 +978,9 @@ dnl if test "$with_linux" = "yes"; then if test "$with_qemu" = "yes" || test "$with_lxc" = "yes" ; then AC_CHECK_HEADERS([linux/param.h linux/sockios.h linux/if_bridge.h linux/if_tun.h],, - AC_MSG_ERROR([You must install kernel-headers in order to compile libvirt with QEMU or LXC support])) + [AC_MSG_ERROR([You must install kernel-headers in order to compile libvirt with QEMU or LXC support])], + [[#include <netinet/ip6.h> + ]]) fi fi -- 1.7.1

1 2

[libvirt] [PATCH] maint: typo fix
by Eric Blake 15 Jan '13

15 Jan '13

I noticed this typo while configuring on a freshly-installed machine. * m4/virt-udev.m4: Correct pciaccess name. --- Pushing under the trivial rule. m4/virt-udev.m4 | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/m4/virt-udev.m4 b/m4/virt-udev.m4 index bf4623d..55673bf 100644 --- a/m4/virt-udev.m4 +++ b/m4/virt-udev.m4 @@ -22,7 +22,7 @@ AC_DEFUN([LIBVIRT_CHECK_UDEV],[ LIBVIRT_CHECK_PKG([UDEV], [libudev], [145]) if test "$with_udev" = "yes" && test "$with_pciaccess" != "yes" ; then - AC_MSG_ERROR([You must install the pciaccesss module to build with udev]) + AC_MSG_ERROR([You must install the pciaccess module to build with udev]) fi ]) -- 1.7.1

1 0