- Devel - libvirt List Archives

[libvirt] [PATCH] build: Regenerate man pages on version bump
by Jiri Denemark 29 Jan '13

29 Jan '13

Whenever libvirt version changes in configure.ac, we need to regenerate man pages so that they contain correct version info. --- daemon/Makefile.am | 2 +- tools/Makefile.am | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/daemon/Makefile.am b/daemon/Makefile.am index 72c6190..4d5c2fd 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -395,7 +395,7 @@ endif # WITH_LIBVIRTD POD2MAN = pod2man -c "Virtualization Support" \ -r "$(PACKAGE)-$(VERSION)" -s 8 -$(srcdir)/libvirtd.8.in: libvirtd.pod.in +$(srcdir)/libvirtd.8.in: libvirtd.pod.in $(top_srcdir)/configure.ac $(AM_V_GEN)$(POD2MAN) --name LIBVIRTD $< $@ \ && if grep 'POD ERROR' $@ ; then rm $@; exit 1; fi diff --git a/tools/Makefile.am b/tools/Makefile.am index 8a0429c..0010c39 100644 --- a/tools/Makefile.am +++ b/tools/Makefile.am @@ -61,7 +61,7 @@ virt-xml-validate: virt-xml-validate.in Makefile $(AM_V_GEN)sed -e 's|[@]schemadir@|$(pkgdatadir)/schemas|' < $< > $@ \ || (rm $@ && exit 1) && chmod +x $@ -virt-xml-validate.1: virt-xml-validate.in +virt-xml-validate.1: virt-xml-validate.in $(top_srcdir)/configure.ac $(AM_V_GEN)$(POD2MAN) --name VIRT-XML-VALIDATE $< $(srcdir)/$@ \ && if grep 'POD ERROR' $(srcdir)/$@ ; then \ rm $(srcdir)/$@; exit 1; fi @@ -70,12 +70,12 @@ virt-pki-validate: virt-pki-validate.in Makefile $(AM_V_GEN)sed -e 's|[@]sysconfdir@|$(sysconfdir)|' < $< > $@ \ || (rm $@ && exit 1) && chmod +x $@ -virt-pki-validate.1: virt-pki-validate.in +virt-pki-validate.1: virt-pki-validate.in $(top_srcdir)/configure.ac $(AM_V_GEN)$(POD2MAN) --name VIRT-PKI-VALIDATE $< $(srcdir)/$@ \ && if grep 'POD ERROR' $(srcdir)/$@ ; then \ rm $(srcdir)/$@; exit 1; fi -virt-host-validate.1: virt-host-validate.c +virt-host-validate.1: virt-host-validate.c $(top_srcdir)/configure.ac $(AM_V_GEN)$(POD2MAN) --name VIRT-HOST-VALIDATE $< $(srcdir)/$@ \ && if grep 'POD ERROR' $(srcdir)/$@ ; then \ rm $(srcdir)/$@; exit 1; fi @@ -85,7 +85,7 @@ virt-sanlock-cleanup: virt-sanlock-cleanup.in Makefile -e 's|[@]localstatedir@|$(localstatedir)|' < $< > $@ \ || (rm $@ && exit 1) && chmod +x $@ -virt-sanlock-cleanup.8: virt-sanlock-cleanup.in +virt-sanlock-cleanup.8: virt-sanlock-cleanup.in $(top_srcdir)/configure.ac $(AM_V_GEN)$(POD2MAN) --name VIRT-SANLOCK-CLEANUP $< $(srcdir)/$@ \ && if grep 'POD ERROR' $(srcdir)/$@ ; then \ rm $(srcdir)/$@; exit 1; fi @@ -171,7 +171,7 @@ virsh_win_icon.$(OBJEXT): virsh_win_icon.rc --output-format coff --output $@ endif -virsh.1: virsh.pod +virsh.1: virsh.pod $(top_srcdir)/configure.ac $(AM_V_GEN)$(POD2MAN) $< $(srcdir)/$@ \ && if grep 'POD ERROR' $(srcdir)/$@ ; then \ rm $(srcdir)/$@; exit 1; fi -- 1.8.1.1

2 2

[libvirt] [PATCH 0/2] conf: fix some memory leaks
by Ján Tomko 29 Jan '13

29 Jan '13

Ján Tomko (2): conf: Fix cpumask leak in virDomainDefFree conf: Fix leaks in virNetworkObjUpdateParseFile src/conf/domain_conf.c | 2 +- src/conf/network_conf.c | 19 +++++++++++-------- 2 files changed, 12 insertions(+), 9 deletions(-) -- 1.7.8.6

3 7

[libvirt] [libvirt-sandbox][PATCH] Don't redefine _FORTIFY_SOURCE macro
by Michal Privoznik 29 Jan '13

29 Jan '13

If the _FORTIFY_SOURCE has been already defined, we unconditionally redefine it, leaving us with warning/error thrown at compilation time. --- m4/virt-compile-warnings.m4 | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/m4/virt-compile-warnings.m4 b/m4/virt-compile-warnings.m4 index cdcbad9..894ab59 100644 --- a/m4/virt-compile-warnings.m4 +++ b/m4/virt-compile-warnings.m4 @@ -84,8 +84,13 @@ AC_DEFUN([LIBVIRT_SANDBOX_COMPILE_WARNINGS],[ gl_WARN_ADD([-Wframe-larger-than=4096]) # Use improved glibc headers - AC_DEFINE([_FORTIFY_SOURCE], [2], - [enable compile-time and run-time bounds-checking, and some warnings]) + AH_VERBATIM([FORTIFY_SOURCE], + [/* Enable compile-time and run-time bounds-checking, and some warnings, + without upsetting newer glibc. */ + #if !defined _FORTIFY_SOURCE && defined __OPTIMIZE__ && __OPTIMIZE__ + # define _FORTIFY_SOURCE 2 + #endif + ]) # Extra special flags dnl -fstack-protector stuff passes gl_WARN_ADD with gcc -- 1.8.0.2

2 2

[libvirt] [PATCH] LXC: create directory /dev/shm automatically
by Gao feng 29 Jan '13

29 Jan '13

Now we mount /dev as tmpfs and haven't created directory /dev/shm,so the glibc api such as shm_open/sem_open will create files under dir /dev.(since /dev is mounted as tmpfs) Through these api still useable in container,but this cause directory /dev looks a little chaos. This patch create directory /dev/shm automatically,the files created by shm_open/sem_open will stay in this directroy. Signed-off-by: Gao feng <gaofeng(a)cn.fujitsu.com> --- src/lxc/lxc_container.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index 497539c..5150564 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -586,6 +586,13 @@ static int lxcContainerMountBasicFS(bool pivotRoot, "devfs", "/dev", "tmpfs", opts); goto cleanup; } + + VIR_DEBUG("create directory /dev/shm for POSIX shared memory and named semphore"); + if (virFileMakePath("/dev/shm") < 0) { + virReportSystemError(errno, "%s", + _("Failed to mkdir /dev/shm")); + goto cleanup; + } } rc = 0; -- 1.7.11.7

3 8

[libvirt] Candidate Release 2 of libvirt-1.0.2
by Daniel Veillard 29 Jan '13

29 Jan '13

I have just tagged the rc2 in git and pushed the associated tarball and rpms for F17 to the FTP area: ftp://libvirt.org/libvirt/ Seems to work just fine for m limited testing, but please give it a try, and let's limit commits to only bug fixes until the release. I think I will push 1.0.2 final on Wednesday morning if everything is going fine until then, thanks for any testing and feedback ! Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

4 3

[libvirt] [PATCH v3 0/3] add pci-bridge support
by liguang 29 Jan '13

29 Jan '13

Now, it's impossible to arrange devices into multi-pci-bus, for example: <sound model='ac97'> <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0'/> </sound> <video> <model type='cirrus' vram='9216' heads='1'/> <address type='pci' domain='0x0000' bus='0x1' slot='0x02' function='0x0'/> </video> libvirt will complain about "bus != 0", fortunately, qemu supports pci-to-pci bridge, if we want to use multi-pci-bus, we can define 2 pci bridge controllers, then attach 1 to the other as a subordinate pci-bus, so, 2 pci-buses appear. for example: <controller type='pci-bridge' index='0'/> <controller type='pci-bridge' index='1'> <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/> </controller> <sound model='ac97'> <address type='pci' domain='0x0000' bus='0x01' slot='0x02' function='0x0'/> </sound> <video> <model type='cirrus' vram='9216' heads='1'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/> </video> src/conf/domain_conf.c | 5 ++++- src/conf/domain_conf.h | 1 + docs/schemas/domaincommon.rng | 1 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 70 ++++++++++++++++++++----- 6 files changed, 57 insertions(+), 23 deletions(-)

4 11

[libvirt] ANNOUNCE: libvirt 0.9.6.4 maintenance release
by Cole Robinson 29 Jan '13

29 Jan '13

libvirt 0.9.6.4 maintenance release is now available. This is libvirt 0.9.6 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-0.9.6.4.tar.gz Changes in this version: * rpc: Fix crash on error paths of message dispatching * qemu: Clear async job when p2p migration fails early For info about past maintenance releases, see: http://wiki.libvirt.org/page/Maintenance_Releases Thanks, Cole

1 0

[libvirt] ANNOUNCE: libvirt 0.9.11.9 maintenance release
by Cole Robinson 29 Jan '13

29 Jan '13

libvirt 0.9.11.9 maintenance release is now available. This is libvirt 0.9.11 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-0.9.11.9.tar.gz Changes in this version: * Fix race condition when destroying guests * rpc: Fix crash on error paths of message dispatching * util: fix botched check for new netlink request filters * util: add missing error log messages when failing to get netlink VFINFO * util: fix functions that retrieve SRIOV VF info * network: prevent dnsmasq from listening on localhost For info about past maintenance releases, see: http://wiki.libvirt.org/page/Maintenance_Releases Thanks, Cole

1 0

[libvirt] ANNOUNCE: libvirt 0.10.2.3 maintenance release
by Cole Robinson 29 Jan '13

29 Jan '13

libvirt 0.10.2.3 maintenance release is now available. This is libvirt 0.10.2 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-0.10.2.3.tar.gz Changes in this version: * selinux: Only create the selabel_handle once. * Skip bulk relabelling of resources in SELinux driver when used with LXC * selinux: Resolve resource leak using the default disk label * rpc: Fix crash on error paths of message dispatching * nwfilter: Remove unprivileged code path to set base * Fix nwfilter driver reload/shutdown handling when unprivileged * call virstateCleanup to do the cleanup before libvirtd exits * Fix race condition when destroying guests * build: move file deleting action from %files list to %install * build: libvirt-guests files misplaced in specfile * qemu: Relax hard RSS limit * util: fix botched check for new netlink request filters * util: add missing error log messages when failing to get netlink VFINFO * util: fix functions that retrieve SRIOV VF info * virsh: Fix POD syntax * build: install libvirt sysctl file correctly * build: .service files don't need to be executable * build: use common .in replacement mechanism * tools: Only install guests init script if --with-init=script=redhat * build: fix syntax-check tab violation * build: check for pod errors * daemon: Use $(AM_V_GEN) in a few more places * build: Add libxenctrl to LIBXL_LIBS * Convert libxl driver to Xen 4.2 * Introduce APIs for splitting/joining strings * network: prevent dnsmasq from listening on localhost For info about past maintenance releases, see: http://wiki.libvirt.org/page/Maintenance_Releases Thanks, Cole

1 0

[libvirt] [PATCHv2 0/7] Add additional data for the NUMA topology info
by Peter Krempa 29 Jan '13

29 Jan '13

This version fixes most of coments on v1 by DanPB and Martin. The two things that are not yet done are: 1) docs and 2) support for the xend driver I will follow up with those tomorrow after I create a testbed for xen. There are 2 new patches: 1/7: fixes bad comment for a bitmap function 7/7: adds data for the test driver Peter Krempa (7): util: Fix docs for virBitmapParse schema: Make the cpuset type reusable across schema files schemas: Add schemas for more CPU topology information in the caps XML conf: Split out NUMA topology formatting to simplify access to data capabilities: Switch CPU data in NUMA topology to a struct capabilities: Add additional data to the NUMA topology info test: Add support for thread and core information for the test driver docs/schemas/basictypes.rng | 6 +++ docs/schemas/capability.rng | 11 ++++++ docs/schemas/domaincommon.rng | 5 --- src/conf/capabilities.c | 92 ++++++++++++++++++++++++++++++------------- src/conf/capabilities.h | 14 ++++++- src/nodeinfo.c | 75 +++++++++++++++++++++++++++++------ src/qemu/qemu_process.c | 2 +- src/test/test_driver.c | 24 +++++++++-- src/util/virbitmap.c | 16 ++++---- src/xen/xend_internal.c | 25 ++++++------ 10 files changed, 201 insertions(+), 69 deletions(-) -- 1.8.1.1

4 20

[libvirt] [PATCH] auto-create pci-bridge controller info
by liguang 29 Jan '13

29 Jan '13

if some devices specify a pci bus number that haven't been defined by a pci-bridge controller then fill the required correct controller info silently. it based on previous add pci-bridge support patches, https://www.redhat.com/archives/libvir-list/2013-January/msg00577.html Signed-off-by: liguang <lig.fnst(a)cn.fujitsu.com> --- src/conf/domain_conf.c | 95 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 95 insertions(+), 0 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 8ebe77d..dabd374 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -11756,6 +11756,98 @@ virDomainDefMaybeAddSmartcardController(virDomainDefPtr def) } +static int +virDomainDefMaybeAddPcibridgeController(virDomainDefPtr def) +{ + int i, idx = 0; + + for (i = 0; i < def->nnets; i++) { + if (def->nets[i]->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) + continue; + idx = def->nets[i]->info.addr.pci.bus; + if (virDomainDefMaybeAddController(def, + VIR_DOMAIN_CONTROLLER_TYPE_PCIBRIDGE, + idx) < 0) + return -1; + } + + for (i = 0; i < def->nsounds; i++) { + if (def->sounds[i]->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) + continue; + idx = def->sounds[i]->info.addr.pci.bus; + if (virDomainDefMaybeAddController(def, + VIR_DOMAIN_CONTROLLER_TYPE_PCIBRIDGE, + idx) < 0) + return -1; + } + + for (i = 0; i < def->nvideos; i++) { + if (def->videos[i]->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) + continue; + idx = def->videos[i]->info.addr.pci.bus; + if (virDomainDefMaybeAddController(def, + VIR_DOMAIN_CONTROLLER_TYPE_PCIBRIDGE, + idx) < 0) + return -1; + } + + for (i = 0; i < def->ncontrollers; i++) { + if (def->controllers[i]->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) + continue; + idx = def->controllers[i]->info.addr.pci.bus; + if (virDomainDefMaybeAddController(def, + VIR_DOMAIN_CONTROLLER_TYPE_PCIBRIDGE, + idx) < 0) + return -1; + } + + for (i = 0; i < def->nfss; i++) { + if (def->fss[i]->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) + continue; + idx = def->fss[i]->info.addr.pci.bus; + if (virDomainDefMaybeAddController(def, + VIR_DOMAIN_CONTROLLER_TYPE_PCIBRIDGE, + idx) < 0) + return -1; + } + + for (i = 0; i < def->nhostdevs; i++) { + if (def->hostdevs[i]->info->type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) + continue; + idx = def->hostdevs[i]->info->addr.pci.bus; + if (virDomainDefMaybeAddController(def, + VIR_DOMAIN_CONTROLLER_TYPE_PCIBRIDGE, + idx) < 0) + return -1; + } + + for (i = 0; i < def->ndisks; i++) { + if (def->disks[i]->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) + continue; + idx = def->disks[i]->info.addr.pci.bus; + if (virDomainDefMaybeAddController(def, + VIR_DOMAIN_CONTROLLER_TYPE_PCIBRIDGE, + idx) < 0) + return -1; + } + + if (def->watchdog->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) + idx = def->watchdog->info.addr.pci.bus; + if (virDomainDefMaybeAddController(def, + VIR_DOMAIN_CONTROLLER_TYPE_PCIBRIDGE, + idx) < 0) + return -1; + + if (def->memballoon->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) + idx = def->memballoon->info.addr.pci.bus; + if (virDomainDefMaybeAddController(def, + VIR_DOMAIN_CONTROLLER_TYPE_PCIBRIDGE, + idx) < 0) + return -1; + + return 0; +} + /* * Based on the declared <address/> info for any devices, * add necessary drive controllers which are not already present @@ -11790,6 +11882,9 @@ int virDomainDefAddImplicitControllers(virDomainDefPtr def) if (virDomainDefMaybeAddSmartcardController(def) < 0) return -1; + if (virDomainDefMaybeAddPcibridgeController(def) < 0) + return -1; + return 0; } -- 1.7.2.5

4 5

[libvirt] [Libvirt][Test]How to test storage solely in Libvirt?
by harryxiyou 28 Jan '13

28 Jan '13

Hi all, I wanna test if a storage driver (like Sheepdog) works well in Libvirt separately. How should i finish this job. Could anyone give me some suggestions? -- Thanks Harry Wei

4 7

[libvirt] [RFC PATCH 0/n] Glue domain and storage
by Osier Yang 28 Jan '13

28 Jan '13

This is the 4th part to implement NPIV migration support [1]. Part 1: https://www.redhat.com/archives/libvir-list/2013-January/msg00859.html Part 2: (Already ACKed by Michal) https://www.redhat.com/archives/libvir-list/2013-January/msg00859.html Part 3: https://www.redhat.com/archives/libvir-list/2013-January/msg01012.html This set is based on above 3 ones. The subject "Glue domain and storage" is a bit bigger than what this series does. This set only tries to support using the storage for domain disks. And the storage might be further used by disk backing chains, or future scsi-host passthrough, etc, if the pricinple is correct. However, this can setup the basis, which can be extended for future stuffs. This introduces new XMLs to specify the disk source with storage like (See PATCH 3/n for more details): <disk type='file' device='disk'> <driver name='qemu' type='raw' cache='none'/> <source type='pool'> <pool uuid|name="$var"/> <volume name|path|key='$var'/> <seclabel relabel='no'/> </source> <target dev='vdb' bus='virtio'/> </disk> And before domain starting, the source represented by storage is translated into the real underlying source. Disk of type 'network' is not supported yet. But I'd like post the patches as soon as possible to make sure I'm not on the wrong road. Osier Yang (6): eng: Remove the duplicate definition rng: Change the datatype for volume name for common use Introduce new XMLs to specify disk source using storage pool/vol New files to glue domain and storage together Implement translateDiskSourcePool qemu: Translate the source when starting domain docs/formatdomain.html.in | 31 ++- docs/schemas/basictypes.rng | 6 + docs/schemas/domaincommon.rng | 156 +++++--- docs/schemas/storagepool.rng | 10 +- docs/schemas/storagevol.rng | 8 +- src/Makefile.am | 3 +- src/conf/domain_conf.c | 426 ++++++++++++++++---- src/conf/domain_conf.h | 46 +++ src/conf/domain_storage.c | 45 ++ src/conf/domain_storage.h | 37 ++ src/libvirt_private.syms | 6 + src/qemu/qemu_driver.c | 7 + src/storage/storage_driver.c | 207 ++++++++++ .../qemuxml2argv-disk-source-pool.xml | 36 ++ tests/qemuxml2xmltest.c | 1 + 15 files changed, 865 insertions(+), 160 deletions(-) create mode 100644 src/conf/domain_storage.c create mode 100644 src/conf/domain_storage.h create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-source-pool.xml [1] https://www.redhat.com/archives/libvir-list/2012-November/msg00826.html Regards, Osier

4 19

[libvirt] [Libvirt][Sheepdog]How to test Sheepdog patch
by harryxiyou 28 Jan '13

28 Jan '13

Hi Morita and other developers, I have done following jobs. 1, git clone git://libvirt.org/libvirt.git 2, cd libvirt 3, git reset --hard 036ad50 4, ./autogen.sh 5, make NOTE: step 3 calls back to Morita's patch for Libvirt version, which is here http://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=036ad5052b43fe9f0d197e… After step 5, i have following questions. 1, I am not clear about how to test Sheepdog. Actually, i just wanna study Sheepdog driver, then i will program our driver for Libvirt. 2, I am not clear about how Sheepdog, Libvirt and QEMU communicate with each other. Before my test for Sheepdog patch for Libvirt, i have to build Sheepdog, Libvirt and QEMU environment, right? Morita, i have seen your patch for Libvirt but i do not find it calls for Sheepdog functions, so it does not have to build Sheepdog environment, right? -- Thanks Harry Wei

2 2

[libvirt] [Sheepdog][Libvirt]How should i test sheepdog in libvirt
by harryxiyou 28 Jan '13

28 Jan '13

Hi Morita, I just wanna test if sheepdog works well in libvirt. I am not sure if i can only use libvirt environment to finish this test? Or maybe i should also set up QEMU/Sheepdog/Openstack environment, right? I have done following jobs. 1, git clone git://libvirt.org/libvirt.git 2, cd libvirt 3, git reset --hard v0.9.13 4, ./autogen.sh && make NOTE: Step 3 just call back to libvirt version 0.9.13, which you, Morita, patched for Libvirt at around this version. (Your patch is here http://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=036ad5052b43fe9f0d197e…) I just wanna study the original patch for libvirt. After step 4, if i can use tool virsh(under libvirt/tools dir) to test sheepdog driver? Therefore, i am not sure how i should use tool virsh to test if Sheepdog driver works well in libvirt. If i can finish this test only with libvirt ENV.?(Or also should set up QEMU/Sheepdog/Openstack environment) How should i do next step? Could anyone give me some suggestions? Thanks in advance ;-) -- Thanks Harry Wei

2 7

[libvirt] [Libvirt][QEMU]The relationships between Libvirt and QEMU indetails
by harryxiyou 27 Jan '13

27 Jan '13

Hi Daniel and other developers, We have programed a HLFS(HDFS based Log-Structured FileSystem) driver for QEMU, which you can see it here. http://cloudxy.googlecode.com/svn/trunk/hlfs/patches/hlfs_driver_for_qemu_1… And i have tested in QEMU environment, which works well for us. Now, we wanna add a HLFS driver(Volume storage) for Libvirt(The same as Sheepdog) but i am not sure how to test HLFS driver for Libvirt. How could i know if the HLFS driver for Libvirt works well? I guess libvirt uses qemu interfaces(QEMU way) to finish the real jobs like create/delete volumes. I wanna use command 'virsh' to finish them, which the logical procedure like this: virsh --> libvirt client --> libvirt server --> QEMU Therefore, 'virsh' cannot work for me. I do not know how to test it with command 'virsh' solely. Or maybe i must build QEMU environment for this test, right? In brief, i am not clear about the relationships between Libvirt and QEMU. How do they(QEMU and Libvirt) communicate with each other? How could i test create/delete volumes of Sheepdog/HLFS only with Libvirt environment? Could anyone give me some suggestions? Thanks in advance;-) -- Thanks Harry Wei

1 0

[libvirt] [PATCH] virlog: remove old code comment
by Doug Goldstein 27 Jan '13

27 Jan '13

Setting the log output prefix to 0 is not supported and in fact results in the following message: warning : virLogParseOutputs:1021 : Ignoring invalid log output setting. --- src/util/virlog.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/util/virlog.c b/src/util/virlog.c index acd42c1..24ec9d3 100644 --- a/src/util/virlog.c +++ b/src/util/virlog.c @@ -1261,7 +1261,6 @@ static int virLogAddOutputToJournald(int priority) * x:file:file_path * output to a file, with the given filepath * In all case the x prefix is the minimal level, acting as a filter - * 0: everything * 1: DEBUG * 2: INFO * 3: WARNING -- 1.7.12.4

2 1

[libvirt] [PATCH 0/7] Introduce virCommandDoAsyncIO
by Michal Privoznik 27 Jan '13

27 Jan '13

Currently, if we want to use IO with asynchronous command we have to copy code from virFileWrapperFd to misuse our event loop for reading and writing to the command. However, we can extend our virCommand implementation to automatically set things up. Michal Privoznik (7): virCommand: Introduce virCommandDoAsyncIO Introduce event loop to commandtest tests: Create test for virCommandDoAsyncIO virFileWrapperFd: Switch to new virCommandDoAsyncIO qemu: Catch stderr of image decompression binary qemu: Catch stderr of image compression binary qemu: Destroy domain on decompression binary error src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 9 +- src/qemu/qemu_migration.c | 9 +- src/util/vircommand.c | 214 ++++++++++++++++++++++++++++++++++++++++++-- src/util/vircommand.h | 1 + src/util/virfile.c | 82 +---------------- tests/commanddata/test3.log | 2 +- tests/commandtest.c | 136 ++++++++++++++++++++++++++++ 8 files changed, 365 insertions(+), 89 deletions(-) -- 1.8.0.2

2 15

[libvirt] qemu kvm-pit device arg missing?
by Doug Goldstein 27 Jan '13

27 Jan '13

With a domain defined with the following: <clock offset='utc'> <timer name='pit' tickpolicy='delay'/> <timer name='rtc' tickpolicy='catchup'/> </clock> The following define is set: VIR_DOMAIN_TIMER_TICKPOLICY_DELAY for VIR_DOMAIN_TIMER_NAME_PIT. And VIR_DOMAIN_TIMER_TICKPOLICY_CATCHUP for VIR_DOMAIN_TIMER_NAME_RTC. I see where for the RTC we'll set -rtc,driftfix=slew (well -rtc,base=X,driftfix=slew) or -rtc-td-hack for older qemu's. But for the kvm-pit, we pass with qemu{,-kvm} 1.1 and lower -no-kvm-pit-reinjection but with qemu{,-kvm} 1.2 the QEMU_CAPS_NO_KVM_PIT is not set, nor detected via QMP so nothing is ever passed. I even looked through the QMP commands passed once the process is started and there doesn't seem to be anything passed. I was expecting with qemu{,-kvm} 1.2 and newer to see -device kvm-pit,lost_tick_policy=discard appear on the command line but didn't. Am I missing something? Or is this command line argument not necessary any longer? -- Doug Goldstein

1 0

[libvirt] [PATCH] Make python objects inherit from 'object' base class
by Daniel P. Berrange 27 Jan '13

27 Jan '13

From: "Daniel P. Berrange" <berrange(a)redhat.com> As of python >= 2.2, it is recommended that all objects inherit from the 'object' base class. We already require python >= 2.3 for libvirt for thread macro support, so we should follow this best practice. See also http://stackoverflow.com/questions/4015417/python-class-inherits-object This is motivated the patch Rich just did for libguestfs https://www.redhat.com/archives/libguestfs/2013-January/msg00063.html Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- python/generator.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/generator.py b/python/generator.py index f853d77..a079fc5 100755 --- a/python/generator.py +++ b/python/generator.py @@ -1413,7 +1413,7 @@ def buildWrappers(module): classes.write(" %s.__init__(self, _obj=_obj)\n\n" % ( classes_ancestor[classname])) else: - classes.write("class %s:\n" % (classname)) + classes.write("class %s(object):\n" % (classname)) if classname in [ "virDomain", "virNetwork", "virInterface", "virStoragePool", "virStorageVol", "virNodeDevice", "virSecret","virStream", "virNWFilter" ]: -- 1.8.1

3 2

[libvirt] [PATCH 0/2] Resolve Coverity issues in vbox_tmpl.c
by John Ferlan 26 Jan '13

26 Jan '13

This pair of patches resolves what amount to false positives in the vbox_tmpl.c code relating to attempts to dereference NULL in the 2002 VBOX_API_VERSION call to 'vboxIIDFromUUID()'. It also removes "false postives" from the various VBOX_UTF*_FREE() macros. Some code paths checked if the arg was valid prior to calling free. That triggered Coverity into tagging other uses of the variables where the check wasn't performed. While these changes resolve the Coverity issues there still exists a "problem" where the VBOX_UTF<n>_TO_UTF<m> macros don't check the return status from the called function nor does the code that uses the macros always check the returned arg2 for validity (125 occurrances). John Ferlan (2): vbox: Address false positive for NULL dereference vbox: Adjust the UTF FREE macros src/vbox/vbox_tmpl.c | 77 ++++++++++++++++++++++++++-------------------------- 1 file changed, 38 insertions(+), 39 deletions(-) -- 1.7.11.7

2 5

[libvirt] [PATCH] Make sure we only abort without libcurl if $with_esx = yes
by Guido Günther 26 Jan '13

26 Jan '13

--- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 712918f..4bd3c3e 100644 --- a/configure.ac +++ b/configure.ac @@ -1810,7 +1810,7 @@ dnl check for (ESX) dnl if test "$with_curl" != "yes" ; then - if test "$with_esx" = "check"; then + if test "$with_esx" != "yes"; then with_esx=no else AC_MSG_ERROR([Curl is required for the ESX driver]) -- 1.7.10.4

2 2

[libvirt] [PATCH] virsh: Add --print-xml flag for attach-disk command
by Peter Krempa 26 Jan '13

26 Jan '13

The flag causes the XML of the disk that would be attached to be printed instead. --- tools/virsh-domain.c | 46 ++++++++++++++++++++++++++++------------------ tools/virsh.pod | 5 ++++- 2 files changed, 32 insertions(+), 19 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 026dac1..829e475 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -317,6 +317,12 @@ static const vshCmdOptDef opts_attach_disk[] = { .flags = 0, .help = N_("use multifunction pci under specified address") }, + {.name = "print-xml", + .type = VSH_OT_BOOL, + .flags = 0, + .help = N_("print XML document rather than attach the disk") + }, + {.name = NULL} }; @@ -480,11 +486,11 @@ cmdAttachDisk(vshControl *ctl, const vshCmd *cmd) unsigned int flags; const char *stype = NULL; virBuffer buf = VIR_BUFFER_INITIALIZER; - char *xml; + char *xml = NULL; struct stat st; if (!(dom = vshCommandOptDomain(ctl, cmd, NULL))) - goto cleanup; + return false; if (vshCommandOptString(cmd, "source", &source) <= 0) goto cleanup; @@ -620,27 +626,31 @@ cmdAttachDisk(vshControl *ctl, const vshCmd *cmd) xml = virBufferContentAndReset(&buf); - if (vshCommandOptBool(cmd, "config")) { - flags = VIR_DOMAIN_AFFECT_CONFIG; - if (virDomainIsActive(dom) == 1) - flags |= VIR_DOMAIN_AFFECT_LIVE; - ret = virDomainAttachDeviceFlags(dom, xml, flags); - } else { - ret = virDomainAttachDevice(dom, xml); - } - - VIR_FREE(xml); + if (!vshCommandOptBool(cmd, "print-xml")) { + if (vshCommandOptBool(cmd, "config")) { + flags = VIR_DOMAIN_AFFECT_CONFIG; + if (virDomainIsActive(dom) == 1) + flags |= VIR_DOMAIN_AFFECT_LIVE; + ret = virDomainAttachDeviceFlags(dom, xml, flags); + } else { + ret = virDomainAttachDevice(dom, xml); + } - if (ret != 0) { - vshError(ctl, "%s", _("Failed to attach disk")); + if (ret != 0) { + vshError(ctl, "%s", _("Failed to attach disk")); + goto cleanup; + } else { + vshPrint(ctl, "%s", _("Disk attached successfully\n")); + } } else { - vshPrint(ctl, "%s", _("Disk attached successfully\n")); - functionReturn = true; + vshPrint(ctl, "%s", xml); } + functionReturn = true; + cleanup: - if (dom) - virDomainFree(dom); + VIR_FREE(xml); + virDomainFree(dom); virBufferFreeAndReset(&buf); return functionReturn; } diff --git a/tools/virsh.pod b/tools/virsh.pod index e2a2aec..fd0f762 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -1787,7 +1787,7 @@ needed if the device does not use managed mode. [I<--driver driver>] [I<--subdriver subdriver>] [I<--cache cache>] [I<--type type>] [I<--mode mode>] [I<--config>] [I<--sourcetype soucetype>] [I<--serial serial>] [I<--shareable>] [I<--rawio>] [I<--address address>] -[I<--multifunction>] +[I<--multifunction>] [I<--print-xml>] Attach a new disk device to the domain. I<source> is path for the files and devices. I<target> controls the bus or @@ -1817,6 +1817,9 @@ scsi:controller.bus.unit or ide:controller.bus.unit. I<multifunction> indicates specified pci address is a multifunction pci device address. +If I<--print-xml> is specified, then the XML of the disk that would be attached +is printed instead. + =item B<attach-interface> I<domain> I<type> I<source> [I<--target target>] [I<--mac mac>] [I<--script script>] [I<--model model>] [I<--config>] [I<--inbound average,peak,burst>] [I<--outbound average,peak,burst>] -- 1.8.1.1

3 3

[libvirt] [PATCH 0/6] libxl bug and race fixes
by Jim Fehlig 26 Jan '13

26 Jan '13

This series fixes several bugs and races in the libxl driver, as described in the commit messages of the individual patches. One of the races was discussed on the xen-devel ml [1] and resulted in two fixes in libxl [2,3]. I've tested this series with and without the libxl patches. All of the previously discovered races are fixed with this series and the libxl patches. It is possible to fire asserts in libxl with this series and without the libxl patches, but that is no worse than the current behavior. The libxl patches have not yet been committed upstream, hence the 'XXXX' for commit id in patch 1. I will respond to the xen-devel thread now with an ACK on the libxl patches (and a reference to this series) so those can be committed. I'll fixup the commit message for patch 1 later, but wanted to get this series on the list for review before the 1.0.2 freeze. [1] http://lists.xen.org/archives/html/xen-devel/2012-11/msg01016.html [2] http://lists.xen.org/archives/html/xen-devel/2012-12/msg00684.html [3] http://lists.xen.org/archives/html/xen-devel/2012-12/msg00685.html Jim Fehlig (6): libxl: Fix handling of timeouts libxl: Fix races in libxl event code libxl: Fix race between destruction of objects libxl: Explicitly remove timeouts libxl: Fix removing non-persistent domain after save libxl: Find domain object in event handler src/libxl/libxl_conf.h | 9 ++ src/libxl/libxl_driver.c | 298 ++++++++++++++++++++++++++++++++++------------- 2 files changed, 226 insertions(+), 81 deletions(-) -- 1.8.0.1

2 18

[libvirt] [PATCH v2] python: Fix bindings for virDomainSnapshotGet{Domain, Connect}
by Jiri Denemark 26 Jan '13

26 Jan '13

https://bugzilla.redhat.com/show_bug.cgi?id=895882 virDomainSnapshot.getDomain() and virDomainSnapshot.getConnect() wrappers around virDomainSnapshotGet{Domain,Connect} were not supposed to be ever implemented. The class should contain proper domain() and connect() accessors that fetch python objects stored internally within the class. While domain() was already provided, connect() was missing. This patch adds connect() method to virDomainSnapshot class and reimplements getDomain() and getConnect() methods as aliases to domain() and connect() for backward compatibility. --- python/generator.py | 4 +++- python/libvirt-override-virDomainSnapshot.py | 8 ++++++++ src/libvirt.c | 10 ++++++++-- 3 files changed, 19 insertions(+), 3 deletions(-) diff --git a/python/generator.py b/python/generator.py index f853d77..5894616 100755 --- a/python/generator.py +++ b/python/generator.py @@ -527,6 +527,8 @@ skip_function = ( "virNWFilterGetConnect", "virStoragePoolGetConnect", "virStorageVolGetConnect", + "virDomainSnapshotGetConnect", + "virDomainSnapshotGetDomain", # only useful in C code, python code uses dict for typed parameters "virTypedParamsAddBoolean", @@ -953,7 +955,6 @@ classes_destructors = { class_skip_connect_impl = { "virConnect" : True, - "virDomainSnapshot": True, } class_domain_impl = { @@ -1436,6 +1437,7 @@ def buildWrappers(module): " self._conn = conn._conn\n") elif classname in [ "virDomainSnapshot" ]: classes.write(" self._dom = dom\n") + classes.write(" self._conn = dom.connect()\n") classes.write(" if _obj != None:self._o = _obj;return\n") classes.write(" self._o = None\n\n"); destruct=None diff --git a/python/libvirt-override-virDomainSnapshot.py b/python/libvirt-override-virDomainSnapshot.py index 3da7bfd..bf708a5 100644 --- a/python/libvirt-override-virDomainSnapshot.py +++ b/python/libvirt-override-virDomainSnapshot.py @@ -1,3 +1,11 @@ + def getConnect(self): + """Get the connection that owns the domain that a snapshot was created for""" + return self.connect() + + def getDomain(self): + """Get the domain that a snapshot was created for""" + return self.domain() + def listAllChildren(self, flags): """List all child snapshots and returns a list of snapshot objects""" ret = libvirtmod.virDomainSnapshotListAllChildren(self._o, flags) diff --git a/src/libvirt.c b/src/libvirt.c index d5d561c..fa39881 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -17850,7 +17850,10 @@ virDomainSnapshotGetName(virDomainSnapshotPtr snapshot) * virDomainSnapshotGetDomain: * @snapshot: a snapshot object * - * Get the domain that a snapshot was created for + * Get the domain that a snapshot was created for. + * + * WARNING: When writing libvirt bindings in other languages, do not use this + * function. Instead, store the domain and the snapshot object together. * * Returns the domain or NULL. */ @@ -17874,7 +17877,10 @@ virDomainSnapshotGetDomain(virDomainSnapshotPtr snapshot) * virDomainSnapshotGetConnect: * @snapshot: a snapshot object * - * Get the connection that owns the domain that a snapshot was created for + * Get the connection that owns the domain that a snapshot was created for. + * + * WARNING: When writing libvirt bindings in other languages, do not use this + * function. Instead, store the connection and the snapshot object together. * * Returns the connection or NULL. */ -- 1.8.1.1

3 5