- Devel - libvirt List Archives

[libvirt] [PATCH] Conditionally compile storagevolxml2argvtest
by Daniel P. Berrange 16 Apr '13

16 Apr '13

From: "Daniel P. Berrange" <berrange(a)redhat.com> Only compile storagevolxml2argvtest if WITH_STORAGE is set, because it links to that driver Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> Pushed as a Win32 build breaker fix --- tests/Makefile.am | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/Makefile.am b/tests/Makefile.am index 888968d..7689453 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -174,7 +174,9 @@ endif test_programs += nwfilterxml2xmltest +if WITH_STORAGE test_programs += storagevolxml2argvtest +endif test_programs += storagevolxml2xmltest storagepoolxml2xmltest @@ -472,11 +474,15 @@ nwfilterxml2xmltest_SOURCES = \ testutils.c testutils.h nwfilterxml2xmltest_LDADD = $(LDADDS) +if WITH_STORAGE storagevolxml2argvtest_SOURCES = \ storagevolxml2argvtest.c \ testutils.c testutils.h storagevolxml2argvtest_LDADD = \ ../src/libvirt_driver_storage_impl.la $(LDADDS) +else +EXTRA_DIST += storagevolxml2argvtest.c +endif storagevolxml2xmltest_SOURCES = \ storagevolxml2xmltest.c \ -- 1.8.1.4

1 0

[libvirt] [PATCH] Conditionalize use of symlink() function in test suite
by Daniel P. Berrange 16 Apr '13

16 Apr '13

From: "Daniel P. Berrange" <berrange(a)redhat.com> On Win32 symlink() is not available, so virstoragetest.c must be conditionalized to avoid compile failures. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> Pushed as a win32 build breaker fix --- configure.ac | 2 +- tests/virstoragetest.c | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 11b332f..789d1c9 100644 --- a/configure.ac +++ b/configure.ac @@ -194,7 +194,7 @@ dnl Availability of various common functions (non-fatal if missing), dnl and various less common threadsafe functions AC_CHECK_FUNCS_ONCE([cfmakeraw geteuid getgid getgrnam_r getmntent_r \ getpwuid_r getuid initgroups kill mmap newlocale posix_fallocate \ - posix_memalign regexec sched_getaffinity setns]) + posix_memalign regexec sched_getaffinity setns symlink]) dnl Availability of pthread functions (if missing, win32 threading is dnl assumed). Because of $LIB_PTHREAD, we cannot use AC_CHECK_FUNCS_ONCE. diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c index d495e6a..0e6ba9e 100644 --- a/tests/virstoragetest.c +++ b/tests/virstoragetest.c @@ -161,12 +161,14 @@ testPrepImages(void) if (virCommandRun(cmd, NULL) < 0) goto skip; +#ifdef HAVE_SYMLINK /* Create some symlinks in a sub-directory. */ if (symlink("../qcow2", datadir "/sub/link1") < 0 || symlink("../wrap", datadir "/sub/link2") < 0) { fprintf(stderr, "unable to create symlink"); goto cleanup; } +#endif ret = 0; cleanup: @@ -364,6 +366,7 @@ mymain(void) canonraw, absraw, datadir, VIR_STORAGE_FILE_RAW, true, 1024, false, }; +#if HAVE_SYMLINK const testFileData link1_rel = { canonraw, "../raw", "sub/../sub/..", VIR_STORAGE_FILE_RAW, true, 1024, false, @@ -380,6 +383,7 @@ mymain(void) canonqcow2, "../sub/link1", datadir "/sub/../sub", VIR_STORAGE_FILE_QCOW2, true, 1024, false, }; +#endif /* The actual tests, in several groups. */ @@ -522,6 +526,7 @@ mymain(void) chain12a, EXP_PASS, chain12b, ALLOW_PROBE | EXP_PASS); +#ifdef HAVE_SYMLINK /* Rewrite qcow2 and wrap file to use backing names relative to a * symlink from a different directory */ virCommandFree(cmd); @@ -545,6 +550,7 @@ mymain(void) chain13a, ALLOW_PROBE | EXP_PASS, chain13c, EXP_PASS, chain13c, ALLOW_PROBE | EXP_PASS); +#endif /* Final cleanup */ testCleanupImages(); -- 1.8.1.4

1 0

[libvirt] [PATCH] Fix signature of dummy virNetlinkCommand stub
by Daniel P. Berrange 16 Apr '13

16 Apr '13

From: "Daniel P. Berrange" <berrange(a)redhat.com> The second param of virNetlinkCommand should be struct nlmsghdr, not unsigned char. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> Pushed as a Win32 build breaker fix --- src/util/virnetlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c index af1985c..d340eda 100644 --- a/src/util/virnetlink.c +++ b/src/util/virnetlink.c @@ -752,7 +752,7 @@ virNetlinkShutdown(void) } int virNetlinkCommand(struct nl_msg *nl_msg ATTRIBUTE_UNUSED, - unsigned char **respbuf ATTRIBUTE_UNUSED, + struct nlmsghdr **resp ATTRIBUTE_UNUSED, unsigned int *respbuflen ATTRIBUTE_UNUSED, uint32_t src_pid ATTRIBUTE_UNUSED, uint32_t dst_pid ATTRIBUTE_UNUSED, -- 1.8.1.4

1 0

[libvirt] [PATCH] Add empty stub for virThreadCancel on Win32
by Daniel P. Berrange 16 Apr '13

16 Apr '13

From: "Daniel P. Berrange" <berrange(a)redhat.com> Win32 does not like undefined symbols, so define an empty virThreadCancel impl. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> Pushed as a Win32 build breaker fix --- src/util/virthreadwin32.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/util/virthreadwin32.c b/src/util/virthreadwin32.c index 0ad7e5c..4543ad8 100644 --- a/src/util/virthreadwin32.c +++ b/src/util/virthreadwin32.c @@ -357,6 +357,8 @@ void virThreadJoin(virThreadPtr thread) } } +void virThreadCancel(virThreadPtr thread ATTRIBUTE_UNUSED) +{} int virThreadLocalInit(virThreadLocalPtr l, virThreadLocalCleanup c) -- 1.8.1.4

1 0

[libvirt] [PATCH] Don't enable -fPIE on Win32 platforms
by Daniel P. Berrange 16 Apr '13

16 Apr '13

From: "Daniel P. Berrange" <berrange(a)redhat.com> On win32, all code is position independent and adding -fPIE to the compiler flags results in warnings being printed Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> Pushed as a Win32 build breaker fix --- m4/virt-compile-pie.m4 | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/m4/virt-compile-pie.m4 b/m4/virt-compile-pie.m4 index 1b62041..cceb495 100644 --- a/m4/virt-compile-pie.m4 +++ b/m4/virt-compile-pie.m4 @@ -21,10 +21,15 @@ dnl AC_DEFUN([LIBVIRT_COMPILE_PIE],[ PIE_CFLAGS= PIE_LDFLAGS= - gl_COMPILER_OPTION_IF([-fPIE -DPIE], [ + case "$host" in + *-*-mingw* | *-*-msvc* | *-*-cygwin* ) + ;; dnl All code is position independent on Win32 target + *) + gl_COMPILER_OPTION_IF([-fPIE -DPIE], [ PIE_CFLAGS="-fPIE -DPIE" PIE_LDFLAGS="-pie" - ]) + ]) + esac AC_SUBST([PIE_CFLAGS]) AC_SUBST([PIE_LDFLAGS]) ]) -- 1.8.1.4

1 0

[libvirt] [PATCH v3 00/16]
by Daniel P. Berrange 16 Apr '13

16 Apr '13

This is an update of https://www.redhat.com/archives/libvir-list/2013-April/msg00352.html Currently libvirt creates a cgroups hiearchy at $LOCATION-OF-LIBVIRTD/libvirt/{qemu,lxc}/$GUEST-NAME eg /sys/fs/cgroup ├── blkio │ └── libvirt │ ├── lxc │ │ └── busy │ └── qemu │ └── vm1 ├── cpu,cpuacct │ ├── libvirt │ │ ├── lxc │ │ │ └── busy │ │ └── qemu │ │ └── vm1 │ │ ├── emulator │ │ └── vcpu0 │ └── system │ ├── abrtd.service │ ....snip.... │ └── upower.service ├── cpuset │ └── libvirt │ ├── lxc │ │ └── busy │ └── qemu │ └── vm1 │ ├── emulator │ └── vcpu0 ├── devices │ └── libvirt │ ├── lxc │ │ └── busy │ └── qemu │ └── vm1 ├── freezer │ └── libvirt │ ├── lxc │ │ └── busy │ └── qemu │ └── vm1 ├── memory │ └── libvirt │ ├── lxc │ │ └── busy │ └── qemu │ └── vm1 ├── net_cls ├── perf_event This series changes it so that libvirt creates cgroups at /system/$VMNAME.{qemu,lxc}.libvirt and allows configuration of the "resource partition" (ie the "/system" bit) via the XML. So we get a layout like this: /sys/fs/cgroup ├── blkio │ └── system │ ├── demo.lxc.libvirt │ └── vm1.qemu.libvirt ├── cpu,cpuacct │ └── system │ ├── abrtd.service │ ....snip.... │ ├── demo.lxc.libvirt │ ....snip.... │ └── vm1.qemu.libvirt │ ├── emulator │ └── vcpu0 ├── cpuset │ └── system │ ├── demo.lxc.libvirt │ └── vm1.qemu.libvirt │ ├── emulator │ └── vcpu0 ├── devices │ └── system │ ├── demo.lxc.libvirt │ └── vm1.qemu.libvirt ├── freezer │ └── system │ ├── demo.lxc.libvirt │ └── vm1.qemu.libvirt ├── memory │ └── system │ ├── demo.lxc.libvirt │ └── vm1.qemu.libvirt ├── net_cls ├── perf_event Flattening out the libvirt created hiearchy has serious performance wins, due to poor kernel scalability with deep hierarchies. It also makes it easier to configure system wide policy for resource usage across system services and virtual machines / containers, since they all live at the top level in comon resource partitions. Changes since v2: - Merge previously ACKed patches - Incorporate Gao Feng's changes to LXC cgroup mount setup

4 43

[libvirt] [PATCH] maint: update to latest gnulib
by Eric Blake 15 Apr '13

15 Apr '13

Upstream gnulib determined that we were needlessly compiling in gnulib's regex instead of glibc's when targetting new-enough glibc, because the m4 test was being too strict in requiring a particular answer to undefined behavior. https://lists.gnu.org/archive/html/bug-gnulib/2013-04/msg00032.html * .gnulib: Update to latest, for regex. --- I verified that on F18, the final size of libvirtd shrinks after applying this patch, because of this change to config.cache: -gl_cv_func_re_compile_pattern_working=${gl_cv_func_re_compile_pattern_working=no} +gl_cv_func_re_compile_pattern_working=${gl_cv_func_re_compile_pattern_working=yes} Pushing under the agreement that gnulib fixes outside of freeze are generally trivial. * .gnulib 076ac82...92f3a4c (1): > regex-tests, regex: allow glibc re_search behavior .gnulib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gnulib b/.gnulib index 076ac82..92f3a4c 160000 --- a/.gnulib +++ b/.gnulib @@ -1 +1 @@ -Subproject commit 076ac82d1d7f4df54630f1b4917b3c14f227f032 +Subproject commit 92f3a4c8e52e64c233e260431d095dbf88554c14 -- 1.8.1.4

1 0

[libvirt] [PATCH] Use unsigned int instead of unsigned
by Osier Yang 15 Apr '13

15 Apr '13

Though they are the same thing, mixed use of them is uncomfortable. "unsigned" is used a lot in old codes, this just tries to change the ones in utils. --- src/util/virpci.c | 65 +++++++++++++++++++++++++++++-------------------------- src/util/virpci.h | 24 ++++++++++---------- 2 files changed, 46 insertions(+), 43 deletions(-) diff --git a/src/util/virpci.c b/src/util/virpci.c index caf1d40..d94ff54 100644 --- a/src/util/virpci.c +++ b/src/util/virpci.c @@ -51,18 +51,18 @@ #define SRIOV_ERROR -1 struct _virPCIDevice { - unsigned domain; - unsigned bus; - unsigned slot; - unsigned function; + unsigned int domain; + unsigned int bus; + unsigned int slot; + unsigned int function; char name[PCI_ADDR_LEN]; /* domain:bus:slot.function */ char id[PCI_ID_LEN]; /* product vendor */ char *path; const char *used_by; /* The domain which uses the device */ - unsigned pcie_cap_pos; - unsigned pci_pm_cap_pos; + unsigned int pcie_cap_pos; + unsigned int pci_pm_cap_pos; bool has_flr; bool has_pm_reset; bool managed; @@ -76,7 +76,7 @@ struct _virPCIDevice { struct _virPCIDeviceList { virObjectLockable parent; - unsigned count; + unsigned int count; virPCIDevicePtr *devs; }; @@ -222,9 +222,9 @@ virPCIDeviceConfigClose(virPCIDevicePtr dev, int cfgfd) static int virPCIDeviceRead(virPCIDevicePtr dev, int cfgfd, - unsigned pos, + unsigned int pos, uint8_t *buf, - unsigned buflen) + unsigned int buflen) { memset(buf, 0, buflen); @@ -239,7 +239,7 @@ virPCIDeviceRead(virPCIDevicePtr dev, } static uint8_t -virPCIDeviceRead8(virPCIDevicePtr dev, int cfgfd, unsigned pos) +virPCIDeviceRead8(virPCIDevicePtr dev, int cfgfd, unsigned int pos) { uint8_t buf; virPCIDeviceRead(dev, cfgfd, pos, &buf, sizeof(buf)); @@ -247,7 +247,7 @@ virPCIDeviceRead8(virPCIDevicePtr dev, int cfgfd, unsigned pos) } static uint16_t -virPCIDeviceRead16(virPCIDevicePtr dev, int cfgfd, unsigned pos) +virPCIDeviceRead16(virPCIDevicePtr dev, int cfgfd, unsigned int pos) { uint8_t buf[2]; virPCIDeviceRead(dev, cfgfd, pos, &buf[0], sizeof(buf)); @@ -255,7 +255,7 @@ virPCIDeviceRead16(virPCIDevicePtr dev, int cfgfd, unsigned pos) } static uint32_t -virPCIDeviceRead32(virPCIDevicePtr dev, int cfgfd, unsigned pos) +virPCIDeviceRead32(virPCIDevicePtr dev, int cfgfd, unsigned int pos) { uint8_t buf[4]; virPCIDeviceRead(dev, cfgfd, pos, &buf[0], sizeof(buf)); @@ -265,9 +265,9 @@ virPCIDeviceRead32(virPCIDevicePtr dev, int cfgfd, unsigned pos) static int virPCIDeviceWrite(virPCIDevicePtr dev, int cfgfd, - unsigned pos, + unsigned int pos, uint8_t *buf, - unsigned buflen) + unsigned int buflen) { if (lseek(cfgfd, pos, SEEK_SET) != pos || safewrite(cfgfd, buf, buflen) != buflen) { @@ -280,14 +280,14 @@ virPCIDeviceWrite(virPCIDevicePtr dev, } static void -virPCIDeviceWrite16(virPCIDevicePtr dev, int cfgfd, unsigned pos, uint16_t val) +virPCIDeviceWrite16(virPCIDevicePtr dev, int cfgfd, unsigned int pos, uint16_t val) { uint8_t buf[2] = { (val >> 0), (val >> 8) }; virPCIDeviceWrite(dev, cfgfd, pos, &buf[0], sizeof(buf)); } static void -virPCIDeviceWrite32(virPCIDevicePtr dev, int cfgfd, unsigned pos, uint32_t val) +virPCIDeviceWrite32(virPCIDevicePtr dev, int cfgfd, unsigned int pos, uint32_t val) { uint8_t buf[4] = { (val >> 0), (val >> 8), (val >> 16), (val >> 24) }; virPCIDeviceWrite(dev, cfgfd, pos, &buf[0], sizeof(buf)); @@ -370,7 +370,9 @@ virPCIDeviceIterDevices(virPCIDeviceIterPredicate predicate, } static uint8_t -virPCIDeviceFindCapabilityOffset(virPCIDevicePtr dev, int cfgfd, unsigned capability) +virPCIDeviceFindCapabilityOffset(virPCIDevicePtr dev, + int cfgfd, + unsigned int capability) { uint16_t status; uint8_t pos; @@ -407,7 +409,7 @@ virPCIDeviceFindCapabilityOffset(virPCIDevicePtr dev, int cfgfd, unsigned capabi static unsigned int virPCIDeviceFindExtendedCapabilityOffset(virPCIDevicePtr dev, int cfgfd, - unsigned capability) + unsigned int capability) { int ttl; unsigned int pos; @@ -496,7 +498,7 @@ virPCIDeviceDetectFunctionLevelReset(virPCIDevicePtr dev, int cfgfd) * and that a D3hot->D0 transition will results in a full * internal reset, not just a soft reset. */ -static unsigned +static unsigned int virPCIDeviceDetectPowerManagementReset(virPCIDevicePtr dev, int cfgfd) { if (dev->pci_pm_cap_pos) { @@ -1341,10 +1343,10 @@ virPCIDeviceReadID(virPCIDevicePtr dev, const char *id_name) } int -virPCIGetAddrString(unsigned domain, - unsigned bus, - unsigned slot, - unsigned function, +virPCIGetAddrString(unsigned int domain, + unsigned int bus, + unsigned int slot, + unsigned int function, char **pciConfigAddr) { virPCIDevicePtr dev = NULL; @@ -1365,10 +1367,10 @@ cleanup: } virPCIDevicePtr -virPCIDeviceNew(unsigned domain, - unsigned bus, - unsigned slot, - unsigned function) +virPCIDeviceNew(unsigned int domain, + unsigned int bus, + unsigned int slot, + unsigned int function) { virPCIDevicePtr dev; char *vendor = NULL; @@ -1458,12 +1460,13 @@ void virPCIDeviceSetManaged(virPCIDevicePtr dev, bool managed) dev->managed = managed; } -unsigned virPCIDeviceGetManaged(virPCIDevicePtr dev) +unsigned int +virPCIDeviceGetManaged(virPCIDevicePtr dev) { return dev->managed; } -unsigned +unsigned int virPCIDeviceGetUnbindFromStub(virPCIDevicePtr dev) { return dev->unbind_from_stub; @@ -1475,7 +1478,7 @@ virPCIDeviceSetUnbindFromStub(virPCIDevicePtr dev, bool unbind) dev->unbind_from_stub = unbind; } -unsigned +unsigned int virPCIDeviceGetRemoveSlot(virPCIDevicePtr dev) { return dev->remove_slot; @@ -1487,7 +1490,7 @@ virPCIDeviceSetRemoveSlot(virPCIDevicePtr dev, bool remove_slot) dev->remove_slot = remove_slot; } -unsigned +unsigned int virPCIDeviceGetReprobe(virPCIDevicePtr dev) { return dev->reprobe; diff --git a/src/util/virpci.h b/src/util/virpci.h index 0c4a8d2..67bee3d 100644 --- a/src/util/virpci.h +++ b/src/util/virpci.h @@ -41,10 +41,10 @@ struct _virPCIDeviceAddress { unsigned int function; }; -virPCIDevicePtr virPCIDeviceNew(unsigned domain, - unsigned bus, - unsigned slot, - unsigned function); +virPCIDevicePtr virPCIDeviceNew(unsigned int domain, + unsigned int bus, + unsigned int slot, + unsigned int function); void virPCIDeviceFree(virPCIDevicePtr dev); const char *virPCIDeviceGetName(virPCIDevicePtr dev); @@ -62,17 +62,17 @@ int virPCIDeviceReset(virPCIDevicePtr dev, void virPCIDeviceSetManaged(virPCIDevice *dev, bool managed); -unsigned virPCIDeviceGetManaged(virPCIDevice *dev); +unsigned int virPCIDeviceGetManaged(virPCIDevice *dev); void virPCIDeviceSetUsedBy(virPCIDevice *dev, const char *used_by); const char *virPCIDeviceGetUsedBy(virPCIDevice *dev); -unsigned virPCIDeviceGetUnbindFromStub(virPCIDevicePtr dev); +unsigned int virPCIDeviceGetUnbindFromStub(virPCIDevicePtr dev); void virPCIDeviceSetUnbindFromStub(virPCIDevice *dev, bool unbind); -unsigned virPCIDeviceGetRemoveSlot(virPCIDevicePtr dev); +unsigned int virPCIDeviceGetRemoveSlot(virPCIDevicePtr dev); void virPCIDeviceSetRemoveSlot(virPCIDevice *dev, bool remove_slot); -unsigned virPCIDeviceGetReprobe(virPCIDevicePtr dev); +unsigned int virPCIDeviceGetReprobe(virPCIDevicePtr dev); void virPCIDeviceSetReprobe(virPCIDevice *dev, bool reprobe); void virPCIDeviceReattachInit(virPCIDevice *dev); @@ -135,10 +135,10 @@ int virPCIGetSysfsFile(char *virPCIDeviceName, char **pci_sysfs_device_link) ATTRIBUTE_RETURN_CHECK; -int virPCIGetAddrString(unsigned domain, - unsigned bus, - unsigned slot, - unsigned function, +int virPCIGetAddrString(unsigned int domain, + unsigned int bus, + unsigned int slot, + unsigned int function, char **pciConfigAddr) ATTRIBUTE_NONNULL(5) ATTRIBUTE_RETURN_CHECK; -- 1.8.1.4

2 3

[libvirt] [PATCH] Do more complete initialization of libgcrypt
by Daniel P. Berrange 15 Apr '13

15 Apr '13

From: "Daniel P. Berrange" <berrange(a)redhat.com> If libvirt makes any gcry_control() calls, then this prevents gnutls for doing any initialization. As such we must take care to do full initialization of libcrypt on a par with what gnutls would have done. In particular we must disable "sec mem" for cases where the user does not have mlock() permission. We also skip our init of libgcrypt if something else (ie the app using libvirt) has beaten us to it. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- src/libvirt.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index c5221f5..7c0a873 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -409,8 +409,14 @@ virGlobalInit(void) goto error; #ifdef WITH_GNUTLS - gcry_control(GCRYCTL_SET_THREAD_CBS, &virTLSThreadImpl); - gcry_check_version(NULL); + if (gcry_control(GCRYCTL_ANY_INITIALIZATION_P) == 0) { + gcry_control(GCRYCTL_SET_THREAD_CBS, &virTLSThreadImpl); + gcry_check_version(NULL); + + gcry_control(GCRYCTL_DISABLE_SECMEM, NULL, 0); + gcry_control(GCRYCTL_INITIALIZATION_FINISHED, NULL, 0); + gcry_control(GCRYCTL_ENABLE_QUICK_RANDOM, 0); + } #endif virLogSetFromEnv(); -- 1.8.1.4

3 5

[libvirt] [PATCH 0/1] qemu: Add Secure Shell (ssh) network block device.
by Richard W.M. Jones 15 Apr '13

15 Apr '13

This patch allows you to use the qemu Secure Shell (ssh) block device. This is not upstream yet, but you can find my latest version here: http://lists.nongnu.org/archive/html/qemu-devel/2013-04/threads.html#01703 This patch lets you specify a ssh device like this: <disk type='network' device='disk'> <source protocol='ssh' name='/remote/path/to/disk/image'> <host name='remote-server.example.com'/> </source> <driver name='qemu' type='raw'/> <target dev='vda' bus='virtio'/> </disk> Patched qemu will connect to remote-server.example.com using libssh2, and access /remote/path/to/disk/image using the sftp protocol. This works for both read and write. Of course, since you'll have to use a patched qemu, you will also need to fiddle with the <emulator> setting. One current problem with this patch is that you have to manually set the SSH_AUTH_SOCK environment variable to point at your ssh-agent (since qemu's ssh block device requires ssh-agent authentication). I added the following to my XML, your value will be different: <qemu:commandline> <qemu:env name="SSH_AUTH_SOCK" value="/tmp/ssh-DThteVfEeOq3/agent.1773" /> </qemu:commandline> Some shortcomings: - Does not allow you to specify the host_key_check parameter. - No tests. - Not sure how best to deal with the ssh-agent authentication socket problem. Use libvirt secrets? If so, how? - I did not test if you can specify an alternate remote user. - I did not test (or care) if parsing qemu command lines works. Rich.

2 7

[libvirt] [PATCH 0/2] Domain object lookup improvements
by Peter Krempa 15 Apr '13

15 Apr '13

This series finishes refactoring of domain object retrieval in the qemu driver and improves error message if the domain object can't be found. This is a prequel for changing of the locking model of virDomain objects. Peter Krempa (2): qemu: Refactor lookup of domain object qemu: Report also domain name in error message when domain object wasn't found src/qemu/qemu_driver.c | 343 +++++++++++-------------------------------------- 1 file changed, 75 insertions(+), 268 deletions(-) -- 1.8.1.5

2 5

[libvirt] [PATCH v4 1/2] Add USB option capability
by Li Zhang 15 Apr '13

15 Apr '13

From: Li Zhang <zhlcindy(a)linux.vnet.ibm.com> To avoid the collision for creating USB controllers in machine->init() and -device xx command line, it needs to set usb=off to avoid one USB controller created in machine->init(). So that libvirt can use -device or -usb to create USB controller sucessfully. So QEMU_CAPS_MACHINE_USB_OPT capability is added, and it is for QEMU v1.3.0 onwards which supports USB option. Signed-off-by: Li Zhang <zhlcindy(a)linux.vnet.ibm.com> --- v4 -> v3: * Add one new test case for USB option * Rebase it with latest version v3 -> v2: * Set QEMU_CAPS_MACHINE_USB_OPT with help string v2 -> v1: * Rename QEMU_CAPS_USB_OPT to QEMU_CAPS_MACHINE_USB_OPT suggested by Daniel * Corret QEMU version with v1.3.0 suggested by Daniel src/qemu/qemu_capabilities.c | 9 +++++++++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 6 ++++++ 3 files changed, 16 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 50712b0..07cda1f 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -216,6 +216,7 @@ VIR_ENUM_IMPL(virQEMUCaps, QEMU_CAPS_LAST, "ipv6-migration", /* 135 */ "machine-opt", + "machine-usb-opt", ); struct _virQEMUCaps { @@ -1078,6 +1079,10 @@ virQEMUCapsComputeCmdFlags(const char *help, if (strstr(help, "-machine")) virQEMUCapsSet(qemuCaps, QEMU_CAPS_MACHINE_OPT); + /* USB option is supported v1.3.0 onwards */ + if (qemuCaps->version >= 1003000) + virQEMUCapsSet(qemuCaps, QEMU_CAPS_MACHINE_USB_OPT); + /* * Handling of -incoming arg with varying features * -incoming tcp (kvm >= 79, qemu >= 0.10.0) @@ -2435,6 +2440,10 @@ virQEMUCapsInitQMP(virQEMUCapsPtr qemuCaps, virQEMUCapsInitQMPBasic(qemuCaps); + /* USB option is supported v1.3.0 onwards */ + if (qemuCaps->version >= 1003000) + virQEMUCapsSet(qemuCaps, QEMU_CAPS_MACHINE_USB_OPT); + if (!(archstr = qemuMonitorGetTargetArch(mon))) goto cleanup; diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h index b2dc588..9f24d6a 100644 --- a/src/qemu/qemu_capabilities.h +++ b/src/qemu/qemu_capabilities.h @@ -176,6 +176,7 @@ enum virQEMUCapsFlags { QEMU_CAPS_SCSI_MEGASAS = 134, /* -device megasas */ QEMU_CAPS_IPV6_MIGRATION = 135, /* -incoming [::] */ QEMU_CAPS_MACHINE_OPT = 136, /* -machine xxxx*/ + QEMU_CAPS_MACHINE_USB_OPT = 137, /* -machine xxx,usb=on/off */ QEMU_CAPS_LAST, /* this must always be the last item */ }; diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 53caba5..d051056 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -5234,6 +5234,12 @@ qemuBuildMachineArgStr(virCommandPtr cmd, virCommandAddArg(cmd, "-machine"); virBufferAdd(&buf, def->os.machine, -1); + /* To avoid the collision of creating USB controllers when calling + * machine->init in QEMU, it needs to set usb=off + */ + if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_MACHINE_USB_OPT)) + virBufferAsprintf(&buf, ",usb=off"); + if (def->mem.dump_core) { if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_DUMP_GUEST_CORE)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", -- 1.8.1.4

2 9

[libvirt] [PATCH 0/4] cleanup: Use bool type instead of bitfield - More
by Osier Yang 13 Apr '13

13 Apr '13

Which are missed with pattern ": 1" in the previous cleanup series. After these, all the bitfield use under src/conf/ are destroyed, except the ones which are required by the existing APIs. Osier Yang (4): cleanup: Change datatype of accel's members to boolean cleanup: Change datatype of graphic's members to boolean cleanup: Change datatype of usbdev->allow to boolean cleanup: Change datatype of net->stp to boolean src/conf/domain_conf.c | 44 ++++++++++++++++++++-------------------- src/conf/domain_conf.h | 20 +++++++++--------- src/conf/network_conf.c | 2 +- src/conf/network_conf.h | 2 +- src/parallels/parallels_driver.c | 4 ++-- src/qemu/qemu_command.c | 6 +++--- src/vbox/vbox_tmpl.c | 6 +++--- src/vmx/vmx.c | 4 ++-- src/xenxs/xen_sxpr.c | 4 ++-- src/xenxs/xen_xm.c | 2 +- 10 files changed, 47 insertions(+), 47 deletions(-) -- 1.8.1.4

3 9

[libvirt] [RFC] Fix https://bugzilla.redhat.com/show_bug.cgi?id=461931
by harryxiyou 13 Apr '13

13 Apr '13

Hi Osier, >From the actual bug messages like fowllowing Actual results: Traceback (most recent call last): File "/usr/share/virt-manager/virtManager/createvol.py", line 191, in _async_vol_create poolobj = self.vol.install(meter=meter) File "/usr/lib/python2.5/site-packages/virtinst/Storage.py", line 893, in install (self.name, str(e))) RuntimeError: Couldn't create storage volume 'virt-stor-dir-bochs.img': '/usr/bin/qemu-img exited with non-zero status 1 and signal 0' It seems that libvirt calls command 'qemu-img' to create a volume of bochs but it failed. So the problem may no matter with Libvirt itself. I am not sure if qemu supports to create a volume of bochs. Or something wrong with QEMU? -- Thanks Harry Wei

2 3

[libvirt] [PATCH v6 00/11] Add support for guests with TPM passthrough device
by Stefan Berger 13 Apr '13

13 Apr '13

Hello! The following set of patches adds support to libvirt for adding a TPM passthrough device to a QEMU guest. Support for this was recently accepted into QEMU. This set of patches borrows a lot from the recently added support for rng's. Regards, Stefan --- v5->v6: - followed tree to 039a3283 - simplified virTPMFindCancelPath in 4/11 following D. Berrange's comments v4->v5: - followed tree to b83b31d8 - addressed D. Berrange's comments on patches 4, 7, 10, 11 & nit on 6 - droped code to parse QEMU cmd line with TPM since this requires editing of the resulting XML v3->v4: - followed tree to ce65b435 - followed comments on v3 v2->v3: - followed tree to 03122d7b - some nits I found fixed v1->v2: - Followed Daniel Berrange's comments (except for the one on de-consolidating the JSON monitor code)

3 20

[libvirt] [libvirt-designer v3] Add Vala API
by Zeeshan Ali (Khattak) 13 Apr '13

13 Apr '13

From: "Zeeshan Ali (Khattak)" <zeeshanak(a)gnome.org> This is mostly (modified) copy&paste from libvirt-glib. --- v3: Added .metadata file to correct init functions vapi. Makefile.am | 2 +- configure.ac | 37 +++++++++++++++++++++++++++++++++++++ vapi/LibvirtDesigner-1.0.metadata | 2 ++ vapi/Makefile.am | 28 ++++++++++++++++++++++++++++ vapi/libvirt-designer-1.0.deps | 2 ++ 5 files changed, 70 insertions(+), 1 deletion(-) create mode 100644 vapi/LibvirtDesigner-1.0.metadata create mode 100644 vapi/Makefile.am create mode 100644 vapi/libvirt-designer-1.0.deps diff --git a/Makefile.am b/Makefile.am index 7801b63..b928f83 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1,5 +1,5 @@ -SUBDIRS = libvirt-designer examples docs +SUBDIRS = libvirt-designer vapi examples docs ACLOCAL_AMFLAGS = -I m4 diff --git a/configure.ac b/configure.ac index a9c5c34..c999826 100644 --- a/configure.ac +++ b/configure.ac @@ -71,10 +71,46 @@ if test "x$enable_examples" != "xno" ; then fi AM_CONDITIONAL(WITH_EXAMPLES, [test "x$enable_examples" = "xyes"]) +AC_ARG_ENABLE([vala], + AS_HELP_STRING([--enable-vala], [enable Vala binding generation]), + [], [enable_vala=check]) +if test "x$enable_introspection" = "xyes" ; then + if test "x$enable_vala" != "xno" ; then + AC_PATH_PROG(VAPIGEN, vapigen, no) + if test "x$VAPIGEN" == "xno"; then + if test "x$enable_vala" == "xcheck" ; then + enable_vala=no + else + AC_MSG_ERROR([Cannot find the "vapigen" binary in your PATH]) + fi + fi + AC_SUBST(VAPIGEN) + fi + if test "x$enable_vala" != "xno" ; then + AC_MSG_CHECKING([$VAPIGEN support for --metadatadir]) + $VAPIGEN --help | grep metadatadir 1>/dev/null 2>&1 + if test $? != 0 ; then + if test "x$enable_vala" == "xcheck" ; then + enable_vala=no + AC_MSG_RESULT([no]) + else + AC_MSG_ERROR(["vapigen" binary in your PATH is too old (< 0.13)]) + fi + else + AC_MSG_RESULT([no]) + fi + fi + if test "x$enable_vala" = "xcheck" ; then + enable_vala=yes + fi +fi +AM_CONDITIONAL([WITH_VALA], [test "x$enable_vala" = "xyes"]) + AC_OUTPUT(Makefile libvirt-designer/Makefile libvirt-designer.spec libvirt-designer-1.0.pc + vapi/Makefile docs/Makefile examples/Makefile) @@ -83,6 +119,7 @@ AC_MSG_NOTICE([Configuration summary]) AC_MSG_NOTICE([=====================]) AC_MSG_NOTICE([]) AC_MSG_NOTICE([]) +AC_MSG_NOTICE([ Vala API: $enable_vala]) AC_MSG_NOTICE([ examples: $enable_examples]) AC_MSG_NOTICE([]) AC_MSG_NOTICE([]) diff --git a/vapi/LibvirtDesigner-1.0.metadata b/vapi/LibvirtDesigner-1.0.metadata new file mode 100644 index 0000000..44f6726 --- /dev/null +++ b/vapi/LibvirtDesigner-1.0.metadata @@ -0,0 +1,2 @@ +init.argv unowned +init_check.argv unowned diff --git a/vapi/Makefile.am b/vapi/Makefile.am new file mode 100644 index 0000000..6136216 --- /dev/null +++ b/vapi/Makefile.am @@ -0,0 +1,28 @@ +NULL = + +if WITH_VALA +vapidir = $(datadir)/vala/vapi +vapi_DATA = \ + libvirt-designer-1.0.deps \ + libvirt-designer-1.0.vapi \ + $(NULL) + +libvirt-designer-1.0.vapi: $(top_builddir)/libvirt-designer/LibvirtDesigner-1.0.gir + $(AM_V_GEN)$(VAPIGEN) \ + --vapidir=$(builddir) \ + --pkg gio-2.0 \ + --pkg libosinfo-1.0 \ + --pkg libvirt-gconfig-1.0 \ + --library libvirt-designer-1.0 \ + --metadatadir=$(srcdir) \ + $< +endif + +CLEANFILES = \ + libvirt-designer-1.0.vapi \ + $(NULL) + +EXTRA_DIST = \ + LibvirtDesigner-1.0.metadata \ + libvirt-designer-1.0.deps \ + $(NULL) diff --git a/vapi/libvirt-designer-1.0.deps b/vapi/libvirt-designer-1.0.deps new file mode 100644 index 0000000..ba30bfd --- /dev/null +++ b/vapi/libvirt-designer-1.0.deps @@ -0,0 +1,2 @@ +libosinfo-1.0 +libvirt-gconfig-1.0 -- 1.8.1.4

2 2

[libvirt] Shared desktop: grant permission to start/stop/pause/resume guests only
by Thorsten Hesemeyer 13 Apr '13

13 Apr '13

Hi all, for a shared desktop configuration, is there an option to grant the permission to start, stop, pause or resume the kvm guest only? User roles in shared desktop environment configuration: Power user - fully manage libvirt / KVM guests Regular user - start, stop, pause and resume libvirt / KVM guests In other words, we are looking for an opportunity to: a) prevent regular users from modifying the libvirt / kvm guest but b) enable them to start, stop, pause, resume libvirt / kvm guests Currently I see two options: a) No specific libvirt permission: Regular users cannot start a virtual guest (without help). If users forget to shutdown the kvm client and try to poweroff the Linux system, they are asked for an admin/management user password to stop the virtual machine. So they need help to shutdown their machine - not good. b) Enable libvirt manage via policy kit: "manage" permission can be granted via overruling the default org.libvirt.unix.manage policy kit action. The manage right enables to modify the libvirt / kvm guest, which is too much in our case. Is there an option to grant the start/stop/pause/resume permission only? Does libvirt offer this kind of granularity? Kind regards, Thorsten Hesemeyer

4 3

[libvirt] [PATCH v5 00/11] Add support for guests with TPM passthrough device
by Stefan Berger 12 Apr '13

12 Apr '13

Hello! The following set of patches adds support to libvirt for adding a TPM passthrough device to a QEMU guest. Support for this was recently accepted into QEMU. This set of patches borrows a lot from the recently added support for rng's. Regards, Stefan --- v4->v5: - followed tree to b83b31d8 - addressed D. Berrange's comments on patches 4, 7, 10, 11 & nit on 6 - droped code to parse QEMU cmd line with TPM since this requires editing of the resulting XML v3->v4: - followed tree to ce65b435 - followed comments on v3 v2->v3: - followed tree to 03122d7b - some nits I found fixed v1->v2: - Followed Daniel Berrange's comments (except for the one on de-consolidating the JSON monitor code)

2 16

[libvirt] [PATCH] conf: Allow for non-contiguous device boot orders
by Peter Krempa 12 Apr '13

12 Apr '13

This patch adds the ability to configure non-contiguous boot orders on boot devices. This allows unplugging devices that have boot order specified without breaking migration. The new code now uses a slightly less memory efficient approach to store the boot order fields in a hashtable instead of a bitmap. --- src/conf/domain_conf.c | 66 ++++++++++++++++++++++++-------------------------- 1 file changed, 32 insertions(+), 34 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index cc26f21..80a90e1 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -2876,7 +2876,7 @@ cleanup: static int virDomainDeviceBootParseXML(xmlNodePtr node, int *bootIndex, - virBitmapPtr bootMap) + virHashTablePtr bootHash) { char *order; int boot; @@ -2895,18 +2895,19 @@ virDomainDeviceBootParseXML(xmlNodePtr node, goto cleanup; } - if (bootMap) { - bool set; - if (virBitmapGetBit(bootMap, boot - 1, &set) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("boot orders have to be contiguous and starting from 1")); + if (bootHash) { + if (virHashLookup(bootHash, order)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("boot order '%s' used for more than one device"), + order); goto cleanup; - } else if (set) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("boot order %d used for more than one device"), boot); + } + + if (virHashAddEntry(bootHash, order, (void *) 1) < 0) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("Failed to add element to boot order hash")); goto cleanup; } - ignore_value(virBitmapSetBit(bootMap, boot - 1)); } *bootIndex = boot; @@ -2922,7 +2923,7 @@ cleanup: */ static int virDomainDeviceInfoParseXML(xmlNodePtr node, - virBitmapPtr bootMap, + virHashTablePtr bootHash, virDomainDeviceInfoPtr info, unsigned int flags) { @@ -2973,7 +2974,7 @@ virDomainDeviceInfoParseXML(xmlNodePtr node, } if (boot) { - if (virDomainDeviceBootParseXML(boot, &info->bootIndex, bootMap)) + if (virDomainDeviceBootParseXML(boot, &info->bootIndex, bootHash)) goto cleanup; } @@ -3945,7 +3946,7 @@ static virDomainDiskDefPtr virDomainDiskDefParseXML(virCapsPtr caps, xmlNodePtr node, xmlXPathContextPtr ctxt, - virBitmapPtr bootMap, + virHashTablePtr bootHash, virSecurityLabelDefPtr* vmSeclabels, int nvmSeclabels, unsigned int flags) @@ -4660,7 +4661,7 @@ virDomainDiskDefParseXML(virCapsPtr caps, } def->info.type = VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI; } else { - if (virDomainDeviceInfoParseXML(node, bootMap, &def->info, + if (virDomainDeviceInfoParseXML(node, bootHash, &def->info, flags | VIR_DOMAIN_XML_INTERNAL_ALLOW_BOOT) < 0) goto error; } @@ -5318,7 +5319,7 @@ static virDomainNetDefPtr virDomainNetDefParseXML(virCapsPtr caps, xmlNodePtr node, xmlXPathContextPtr ctxt, - virBitmapPtr bootMap, + virHashTablePtr bootHash, unsigned int flags) { virDomainNetDefPtr def; @@ -5513,7 +5514,7 @@ virDomainNetDefParseXML(virCapsPtr caps, } def->info.type = VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI; } else { - if (virDomainDeviceInfoParseXML(node, bootMap, &def->info, + if (virDomainDeviceInfoParseXML(node, bootHash, &def->info, flags | VIR_DOMAIN_XML_INTERNAL_ALLOW_BOOT | VIR_DOMAIN_XML_INTERNAL_ALLOW_ROM) < 0) goto error; @@ -7988,7 +7989,7 @@ error: static virDomainHostdevDefPtr virDomainHostdevDefParseXML(const xmlNodePtr node, xmlXPathContextPtr ctxt, - virBitmapPtr bootMap, + virHashTablePtr bootHash, unsigned int flags) { virDomainHostdevDefPtr def; @@ -8029,7 +8030,7 @@ virDomainHostdevDefParseXML(const xmlNodePtr node, } if (def->info->type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE) { - if (virDomainDeviceInfoParseXML(node, bootMap, def->info, + if (virDomainDeviceInfoParseXML(node, bootHash, def->info, flags | VIR_DOMAIN_XML_INTERNAL_ALLOW_BOOT | VIR_DOMAIN_XML_INTERNAL_ALLOW_ROM) < 0) goto error; @@ -8063,7 +8064,7 @@ error: static virDomainRedirdevDefPtr virDomainRedirdevDefParseXML(const xmlNodePtr node, - virBitmapPtr bootMap, + virHashTablePtr bootHash, unsigned int flags) { xmlNodePtr cur; @@ -8113,7 +8114,7 @@ virDomainRedirdevDefParseXML(const xmlNodePtr node, def->source.chr.data.spicevmc = VIR_DOMAIN_CHR_SPICEVMC_USBREDIR; } - if (virDomainDeviceInfoParseXML(node, bootMap, &def->info, + if (virDomainDeviceInfoParseXML(node, bootHash, &def->info, flags | VIR_DOMAIN_XML_INTERNAL_ALLOW_BOOT) < 0) goto error; @@ -9098,8 +9099,7 @@ static char *virDomainDefDefaultEmulator(virDomainDefPtr def, static int virDomainDefParseBootXML(xmlXPathContextPtr ctxt, - virDomainDefPtr def, - unsigned long *bootCount) + virDomainDefPtr def) { xmlNodePtr *nodes = NULL; int i, n; @@ -9196,7 +9196,6 @@ virDomainDefParseBootXML(xmlXPathContextPtr ctxt, def->os.bios.rt_set = true; } - *bootCount = deviceBoot; ret = 0; cleanup: @@ -9394,8 +9393,7 @@ virDomainDefParseXML(virCapsPtr caps, virDomainDefPtr def; unsigned long count; bool uuid_generated = false; - virBitmapPtr bootMap = NULL; - unsigned long bootMapSize = 0; + virHashTablePtr bootHash = NULL; xmlNodePtr cur; bool usb_none = false; bool usb_other = false; @@ -10289,10 +10287,10 @@ virDomainDefParseXML(virCapsPtr caps, } if (STREQ(def->os.type, "hvm")) { - if (virDomainDefParseBootXML(ctxt, def, &bootMapSize) < 0) + if (virDomainDefParseBootXML(ctxt, def) < 0) + goto error; + if (!(bootHash = virHashCreate(5, NULL))) goto error; - if (bootMapSize && !(bootMap = virBitmapNew(bootMapSize))) - goto no_memory; } def->emulator = virXPathString("string(./devices/emulator[1])", ctxt); @@ -10313,7 +10311,7 @@ virDomainDefParseXML(virCapsPtr caps, virDomainDiskDefPtr disk = virDomainDiskDefParseXML(caps, nodes[i], ctxt, - bootMap, + bootHash, def->seclabels, def->nseclabels, flags); @@ -10413,7 +10411,7 @@ virDomainDefParseXML(virCapsPtr caps, virDomainNetDefPtr net = virDomainNetDefParseXML(caps, nodes[i], ctxt, - bootMap, + bootHash, flags); if (!net) goto error; @@ -10796,7 +10794,7 @@ virDomainDefParseXML(virCapsPtr caps, for (i = 0 ; i < n ; i++) { virDomainHostdevDefPtr hostdev; - hostdev = virDomainHostdevDefParseXML(nodes[i], ctxt, bootMap, flags); + hostdev = virDomainHostdevDefParseXML(nodes[i], ctxt, bootHash, flags); if (!hostdev) goto error; @@ -10912,7 +10910,7 @@ virDomainDefParseXML(virCapsPtr caps, goto no_memory; for (i = 0 ; i < n ; i++) { virDomainRedirdevDefPtr redirdev = virDomainRedirdevDefParseXML(nodes[i], - bootMap, + bootHash, flags); if (!redirdev) goto error; @@ -11029,7 +11027,7 @@ virDomainDefParseXML(virCapsPtr caps, if (virDomainDefAddImplicitControllers(def) < 0) goto error; - virBitmapFree(bootMap); + virHashFree(bootHash); return def; @@ -11038,7 +11036,7 @@ no_memory: error: VIR_FREE(tmp); VIR_FREE(nodes); - virBitmapFree(bootMap); + virHashFree(bootHash); virDomainDefFree(def); return NULL; } -- 1.8.1.5

2 3

[libvirt] libvirt libxl driver leaking libxl_event's?
by Ian Campbell 12 Apr '13

12 Apr '13

Hi Jim, I don't see any calls to libxl_event_dispose in libvirt.git, libxl_event.h says in relation to the event_occurs callback: * event becomes owned by the application and must be freed, either * by event_occurs or later. so does this mean the memory referenced by event is leaked by libxlEventHandler? libxl_event only contains dynamic allocations for LIBXL_EVENT_TYPE_DISK_EJECT which you don't seem to register for so the issue is probably benign but worth noting I think. Ian.

2 3

[libvirt] [libvirt-designer] Fix 'be find' typo in error message
by Christophe Fergeau 12 Apr '13

12 Apr '13

--- Pushed under the trivial rule. Christophe examples/virtxml.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/virtxml.c b/examples/virtxml.c index 49a7b4e..20aa621 100644 --- a/examples/virtxml.c +++ b/examples/virtxml.c @@ -547,7 +547,7 @@ main(int argc, char *argv[]) } if (!os) { - print_error("Operating system could not be find or guessed"); + print_error("Operating system could not be found or guessed"); goto cleanup; } -- 1.8.1.4

1 0

[libvirt] [RFC] Usage about 'virsh vol-wipe vol_name'
by harryxiyou 12 Apr '13

12 Apr '13

Hi all, I am not very clear about the usage of ‘virsh vol-wipe vol_name’. I think if 'virsh vol-wipe vol_name' can just wipe all the datas in this volume and it is similar as we format a volume which the datas would be wiped, right? After this wipe, we can use this volume like a new one. However, if users just want to wipe portions data of this volume, which command(interface) of libvirt could finish? -- Thanks Harry Wei

2 7

Re: [libvirt] fail to convert qemu xml to args with libvirt-1.0.4: An error occurred, but the cause is unknown
by Yin Olivia-R63875 12 Apr '13

12 Apr '13

Hi Daniel, I also tried libvirt-1.0.4 on my X86 machine. user@x86:~ $ uname -a Linux 2.6.32-33-server #70-Ubuntu SMP Thu Jul 7 22:28:30 UTC 2011 x86_64 GNU/Linux user@x86:~ $ which virsh /usr/local/bin/virsh user@x86:~ $ /usr/local/bin/virsh --version 1.0.4 user@x86:~ $ cd libvirt-1.0.4/tests/qemuxml2argvdata user@x86:~/libvirt-1.0.4/tests/qemuxml2argvdata $ virsh domxml-to-native qemu-argv qemuxml2argv-disk-virtio.xml >1.dom error：An error occurred, but the cause is unknown Best Regards, Olivia > -----Original Message----- > From: Yin Olivia-R63875 > Sent: Thursday, April 11, 2013 10:18 AM > To: 'Daniel P. Berrange' > Cc: 'libvirt-users(a)redhat.com'; 'libvir-list(a)redhat.com' > Subject: RE: fail to convert qemu xml to args with libvirt-1.0.4: An error > occurred, but the cause is unknown > > Hi Daniel, > > Just Ping. > Did you ever successfully convert QEMU xml file to argv on other platforms? > > Best Regards, > Olivia > > > -----Original Message----- > > From: Yin Olivia-R63875 > > Sent: Tuesday, April 09, 2013 1:22 PM > > To: 'libvir-list(a)redhat.com' > > Cc: 'libvirt-users(a)redhat.com' > > Subject: fail to convert qemu xml to args with libvirt-1.0.4: An error > > occurred, but the cause is unknown > > > > Hi, > > > > I used to convert qemu XML to args with libvirt-1.0.3. > > But it failed to convert with libvirt-1.0.4. > > > > # virsh domxml-to-native qemu-argv test.xml >test.sh > > error: An error occurred, but the cause is unknown > > > > > > Comparing the debug file as below: > > 1) lbvirt-1.0.3 > > <cut> > > 2013-04-09 03:23:47.296+0000: 2669: debug : > > virEventPollInterruptLocked:716 : Interrupting > > 2013-04-09 03:23:47.296+0000: 2669: debug : virNetClientIO:1807 : All > > done with our call head=(nil) call=0x100871c0 rv=0 > > 2013-04-09 03:23:47.297+0000: 2670: debug : virEventPollRunOnce:640 : > > Poll got 1 event(s) > > 2013-04-09 03:23:47.297+0000: 2670: debug : > > virEventPollDispatchTimeouts:425 : Dispatch 0 > > 2013-04-09 03:23:47.297+0000: 2669: debug : virNetMessageFree:73 : > > msg=0x10087500 nfds=0 cb=(nil) > > 2013-04-09 03:23:47.297+0000: 2670: debug : > > virEventPollDispatchHandles:470 : Dispatch 1 > > 2013-04-09 03:23:47.297+0000: 2670: debug : > > virEventPollDispatchHandles:484 : i=0 w=1 > > 2013-04-09 03:23:47.297+0000: 2669: debug : virConnectClose:1483 : > > conn=0x100878b8 <cut> > > > > 2) libvirt-1.0.4 > > <cut> > > 2013-04-09 03:07:58.012+0000: 2834: debug : > > virEventPollInterruptLocked:716 : Interrupting > > 2013-04-09 03:07:58.012+0000: 2834: debug : virNetClientIO:1810 : All > > done with our call head=(nil) call=0x10089db8 rv=0 > > 2013-04-09 03:07:58.012+0000: 2835: debug : virEventPollRunOnce:640 : > > Poll got 1 event(s) > > 2013-04-09 03:07:58.012+0000: 2835: debug : > > virEventPollDispatchTimeouts:425 : Dispatch 0 > > 2013-04-09 03:07:58.012+0000: 2834: error : > > virNetClientProgramDispatchError:175 : An error occurred, but the > > cause is unknown > > 2013-04-09 03:07:58.012+0000: 2835: debug : > > virEventPollDispatchHandles:470 : Dispatch 1 > > 2013-04-09 03:07:58.012+0000: 2834: debug : virNetMessageFree:73 : > > msg=0x1008a0f8 nfds=0 cb=(nil) > > 2013-04-09 03:07:58.012+0000: 2835: debug : > > virEventPollDispatchHandles:484 : i=0 w=1 > > 2013-04-09 03:07:58.012+0000: 2835: debug : > > virEventPollDispatchHandles:498 : EVENT_POLL_DISPATCH_HANDLE: watch=1 > > events=1 > > 2013-04-09 03:07:58.012+0000: 2835: debug : > > virEventPollCleanupTimeouts:516 : Cleanup 0 > > 2013-04-09 03:07:58.013+0000: 2835: debug : > > virEventPollCleanupTimeouts:552 : Found 0 out of 0 timeout slots used, > > releasing 0 > > 2013-04-09 03:07:58.013+0000: 2835: debug : > virEventPollCleanupHandles:564 : > > Cleanup 2 > > 2013-04-09 03:07:58.013+0000: 2834: debug : virConnectClose:1483 : > > conn=0x1008a4b0 <cut> > > > > > > How can I debug this cause unknown error? > > > > Best Regards, > > Olivia

1 0

[libvirt] [RFC] virCommandRun return error number
by harryxiyou 12 Apr '13

12 Apr '13

Hi all, I copy portions of libvirt/src/storage/storage_backend_sheepdog.c [...] 125 ret = virCommandRun(cmd, NULL); 126 if (ret == 0) 127 ret = virStorageBackendSheepdogParseNodeInfo(pool->def, output); [...] I found virCommandRun may return '-1', which hinds something error happens. However, Sheepdog hasn't check here. Maybe i have come up with this bug. I cannot remember clearly. Could anyone please give me some suggestions? If ture, i will give a patch for this bug ;-). -- Thanks Harry Wei

4 9

[libvirt] [PATCH v2 0/2] Add error handling to optional arguments in cmdCPUStats
by John Ferlan 12 Apr '13

12 Apr '13

https://bugzilla.redhat.com/show_bug.cgi?id=907732 Also added informational message when count value is larger than number of CPUs present. Original code commit '31047e2b' quietly changes it and continues on. Prior to patch 2/2, no errors were seen for following sequences virsh cpu-stats guest xyz virsh cpu-stats guest --start xyz virsh cpu-stats guest --count xyz virsh cpu-stats guest --count 99999999999 With patch 2/2, the following errors are displayed for the above sequence error: Unable to parse integer parameter for start error: Unable to parse integer parameter for start error: Unable to parse integer parameter for CPUs to show error: Unable to parse integer parameter for CPUs to show Additionally, the following will be displayed on negative value input: virsh cpu-stats guest --start -1 error: Invalid value for start CPU virsh cpu-stats guest --count -1 error: Invalid value for number of CPUs to show Using a --count parameter value larger than the number of vCPUs on the system will display the following: virsh cpu-stats guest --count 8 Only 4 CPUs available to show CPU0: cpu_time 10.770466061 seconds vcpu_time 8.327848192 seconds ... Diff to v1 - Split into 2 patches (one for struct defs, one for argument processing) - Adjust argument processessing to delineate between bad argument and invalid value (eg, negative CPU start number or count) - Only display the > # cpus message when too large a value is supplied John Ferlan (2): Remove extraneous comma in info_cpu_stats and opts_cpu_stats Add error handling to optional arguments in cmdCPUStats tools/virsh-domain.c | 33 ++++++++++++++++++++++++++++----- 1 file changed, 28 insertions(+), 5 deletions(-) -- 1.8.1.4

3 6