- Devel - libvirt List Archives

[libvirt] [PATCH v2 0/3] ensure diskchain is not broken on guest bootup
by Guannan Ren 01 Aug '13

01 Aug '13

v1->v2: Add a helper function qemuDiskChainCheckBroken to check diskchain after invoking qemuDomainDetermineDiskChain() This patchset try to check whether the diskchain is broken or not when domain boot up. If dischain is broken, report like: virsh start rhel6qcow2 error: Failed to start domain rhel6qcow2 error: invalid argument: Backing file '/var/lib/libvirt/images/thirddisk' of \ image '/var/lib/libvirt/images/thirddisk.snap3' is missing. For storage pool, it still can list volumes out even if their diskchain is broken Guannan Ren(3) qemu: refactor qemuDomainCheckDiskPresence for only disk presence check qemu: add helper functions for diskchain checking qemu: check presence of each disk and its backing file as well src/libvirt_private.syms | 1 + src/qemu/qemu_domain.c | 133 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------- src/qemu/qemu_domain.h | 3 ++ src/qemu/qemu_process.c | 6 ---- src/util/virstoragefile.c | 47 +++++++++++++++++++++++++++++++ src/util/virstoragefile.h | 2 ++ 6 files changed, 141 insertions(+), 51 deletions(-)

2 14

[libvirt] [PATCH] Configuring systemd to restart libvirt on abort
by Mooli Tayer 31 Jul '13

31 Jul '13

From: Mooli Tayer <mtayer(a)redhat.com> This will create a respawn behaviour in case libvirt process exits due to an uncaught signal not specified as a clean exit status. see http://www.freedesktop.org/software/systemd/man/systemd.service.html --- daemon/libvirtd.service.in | 1 + 1 file changed, 1 insertion(+) diff --git a/daemon/libvirtd.service.in b/daemon/libvirtd.service.in index aa5913b..b3c0849 100644 --- a/daemon/libvirtd.service.in +++ b/daemon/libvirtd.service.in @@ -15,6 +15,7 @@ EnvironmentFile=-/etc/sysconfig/libvirtd ExecStart=@sbindir@/libvirtd $LIBVIRTD_ARGS ExecReload=/bin/kill -HUP $MAINPID KillMode=process +Restart=on-abort # Override the maximum number of opened files #LimitNOFILE=2048 -- 1.8.3.1

5 6

[libvirt] [PATCH] xen: Avoid double free of virDomainDef in xenDaemonCreateXML
by Stefan Bader 31 Jul '13

31 Jul '13

Beside dumpxml still being broken with the xen driver (hint [1] ;) ) there is also a quite annoying problem of creating new definitions now failing. Using virt-manager this even disrupts the connection to the host and the guest is not created persistent although it does come up. -Stefan [1] https://www.redhat.com/archives/libvir-list/2013-July/msg01183.html >From 0e90fac9004996a6517ce1bd4d7b9c6ebef6c45c Mon Sep 17 00:00:00 2001 From: Stefan Bader <stefan.bader(a)canonical.com> Date: Tue, 30 Jul 2013 20:48:33 +0200 Subject: [PATCH] xen: Avoid double free of virDomainDef in xenDaemonCreateXML The virDomainDef is allocated by the caller and also used after calling to xenDaemonCreateXML. So it must not get freed by the callee. Signed-off-by: Stefan Bader <stefan.bader(a)canonical.com> --- src/xen/xend_internal.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/xen/xend_internal.c b/src/xen/xend_internal.c index 9d61fca..1ce36e6 100644 --- a/src/xen/xend_internal.c +++ b/src/xen/xend_internal.c @@ -2171,7 +2171,6 @@ xenDaemonCreateXML(virConnectPtr conn, virDomainDefPtr def) if (xenDaemonDomainResume(conn, def) < 0) goto error; - virDomainDefFree(def); return 0; error: -- 1.8.1.2

2 1

[libvirt] [PATCH] Don't mark parentIndex with ATTRIBUTE_UNUSED
by Ján Tomko 31 Jul '13

31 Jul '13

parentIndex is used in virNetworkDefUpdateIPDHCPRange --- Pushed as trivial. src/conf/network_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index b903df9..e3998f3 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c @@ -3416,15 +3416,15 @@ cleanup: virNetworkDHCPHostDefClear(&host); return ret; } static int virNetworkDefUpdateIPDHCPRange(virNetworkDefPtr def, unsigned int command, - int parentIndex ATTRIBUTE_UNUSED, + int parentIndex, xmlXPathContextPtr ctxt, /* virNetworkUpdateFlags */ unsigned int fflags ATTRIBUTE_UNUSED) { size_t i; int ret = -1; virNetworkIpDefPtr ipdef = virNetworkIpDefByIndex(def, parentIndex); -- 1.8.1.5

1 0

[libvirt] [PATCH] Remove VIR_DOMAIN_SHUTDOWN_CRASHED from public API
by Daniel P. Berrange 31 Jul '13

31 Jul '13

From: "Daniel P. Berrange" <berrange(a)redhat.com> The VIR_DOMAIN_SHUTDOWN_CRASHED state constant does not appear to be used in the QEMU code anyway. It also doesn't make much (any) sense, since the 'shutdown' state is a transient state between 'running' and 'shutoff' which is only used by the Xen driver. It was added in commit 14e7e0ae8db9843aea80245a3d9e6cf5f2ef720d which post-dates v1.1.0, so is safe to remove before 1.1.1 Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- include/libvirt/libvirt.h.in | 1 - src/conf/domain_conf.c | 3 +-- tools/virsh-domain-monitor.c | 2 -- 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index c0eb25b..4eae7bf 100644 --- a/include/libvirt/libvirt.h.in +++ b/include/libvirt/libvirt.h.in @@ -191,7 +191,6 @@ typedef enum { typedef enum { VIR_DOMAIN_SHUTDOWN_UNKNOWN = 0, /* the reason is unknown */ VIR_DOMAIN_SHUTDOWN_USER = 1, /* shutting down on user request */ - VIR_DOMAIN_SHUTDOWN_CRASHED = 2, /* domain crashed */ #ifdef VIR_ENUM_SENTINELS VIR_DOMAIN_SHUTDOWN_LAST diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index a86be8c..783df96 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -667,8 +667,7 @@ VIR_ENUM_IMPL(virDomainPausedReason, VIR_DOMAIN_PAUSED_LAST, VIR_ENUM_IMPL(virDomainShutdownReason, VIR_DOMAIN_SHUTDOWN_LAST, "unknown", - "user", - "crashed") + "user") VIR_ENUM_IMPL(virDomainShutoffReason, VIR_DOMAIN_SHUTOFF_LAST, "unknown", diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c index 773f96d..98fe7fe 100644 --- a/tools/virsh-domain-monitor.c +++ b/tools/virsh-domain-monitor.c @@ -240,8 +240,6 @@ vshDomainStateReasonToString(int state, int reason) switch ((virDomainShutdownReason) reason) { case VIR_DOMAIN_SHUTDOWN_USER: return N_("user"); - case VIR_DOMAIN_SHUTDOWN_CRASHED: - return N_("crashed"); case VIR_DOMAIN_SHUTDOWN_UNKNOWN: case VIR_DOMAIN_SHUTDOWN_LAST: ; -- 1.8.1.4

4 3

[libvirt] [PATCH] Rename VIR_DOMAIN_PAUSED_GUEST_PANICKED to VIR_DOMAIN_PAUSED_CRASHED
by Daniel P. Berrange 31 Jul '13

31 Jul '13

From: "Daniel P. Berrange" <berrange(a)redhat.com> The VIR_DOMAIN_PAUSED_GUEST_PANICKED constant is badly named, leaking the QEMU event name. Elsewhere in the API we use 'CRASHED' rather than 'PANICKED', and the addition of 'GUEST' is redundant since all events are guest related. Thus rename it to VIR_DOMAIN_PAUSED_CRASHED, which matches with VIR_DOMAIN_RUNNING_CRASHED and VIR_DOMAIN_EVENT_CRASHED. It was added in commit 14e7e0ae8db9843aea80245a3d9e6cf5f2ef720d which post-dates v1.1.0, so is safe to rename before 1.1.1 Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- include/libvirt/libvirt.h.in | 2 +- src/qemu/qemu_monitor.c | 2 +- src/qemu/qemu_process.c | 2 +- tools/virsh-domain-monitor.c | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index 4eae7bf..7bd3559 100644 --- a/include/libvirt/libvirt.h.in +++ b/include/libvirt/libvirt.h.in @@ -181,7 +181,7 @@ typedef enum { VIR_DOMAIN_PAUSED_FROM_SNAPSHOT = 7, /* paused after restoring from snapshot */ VIR_DOMAIN_PAUSED_SHUTTING_DOWN = 8, /* paused during shutdown process */ VIR_DOMAIN_PAUSED_SNAPSHOT = 9, /* paused while creating a snapshot */ - VIR_DOMAIN_PAUSED_GUEST_PANICKED = 10, /* paused due to a guest panicked event */ + VIR_DOMAIN_PAUSED_CRASHED = 10, /* paused due to a guest crash */ #ifdef VIR_ENUM_SENTINELS VIR_DOMAIN_PAUSED_LAST diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 0b73411..5b2fb04 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -3335,7 +3335,7 @@ int qemuMonitorVMStatusToPausedReason(const char *status) return VIR_DOMAIN_PAUSED_WATCHDOG; case QEMU_MONITOR_VM_STATUS_GUEST_PANICKED: - return VIR_DOMAIN_PAUSED_GUEST_PANICKED; + return VIR_DOMAIN_PAUSED_CRASHED; /* unreachable from this point on */ case QEMU_MONITOR_VM_STATUS_LAST: diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index e8e459e..d631a6f 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -2724,7 +2724,7 @@ qemuProcessUpdateState(virQEMUDriverPtr driver, virDomainObjPtr vm) newState = VIR_DOMAIN_SHUTDOWN; newReason = VIR_DOMAIN_SHUTDOWN_UNKNOWN; ignore_value(VIR_STRDUP_QUIET(msg, "shutdown")); - } else if (reason == VIR_DOMAIN_PAUSED_GUEST_PANICKED) { + } else if (reason == VIR_DOMAIN_PAUSED_CRASHED) { newState = VIR_DOMAIN_CRASHED; newReason = VIR_DOMAIN_CRASHED_PANICKED; ignore_value(VIR_STRDUP_QUIET(msg, "crashed")); diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c index 98fe7fe..b29b82a 100644 --- a/tools/virsh-domain-monitor.c +++ b/tools/virsh-domain-monitor.c @@ -228,8 +228,8 @@ vshDomainStateReasonToString(int state, int reason) return N_("shutting down"); case VIR_DOMAIN_PAUSED_SNAPSHOT: return N_("creating snapshot"); - case VIR_DOMAIN_PAUSED_GUEST_PANICKED: - return N_("guest panicked"); + case VIR_DOMAIN_PAUSED_CRASHED: + return N_("crashed"); case VIR_DOMAIN_PAUSED_UNKNOWN: case VIR_DOMAIN_PAUSED_LAST: ; -- 1.8.1.4

3 2

[libvirt] [PATCH V5] add console support in libxl
by Bamvor Jian Zhang 30 Jul '13

30 Jul '13

this patch introduce the console api in libxl driver for both pv and hvm guest. and import and update the libxlMakeChrdevStr function which was deleted in commit dfa1e1dd. Signed-off-by: Bamvor Jian Zhang <bjzhang(a)suse.com> --- Changes since V4: 1), using proper error instead of VIR_ERR_INTERNAL_ERROR. 2), treat safe as unsupported flags in libxl openConsole api. 3), some format and minor logic changes. Changes since V3: implicity forbit dev_name pass to libxl driver due to only one console supported by libxl. Changes since V2: 1), forbid parallel configure because libxl do not support it 2), only support one serial on libxl driver. 3), also remove console code in libxl driver, AFAICS serial is enough for connecting to libxl console. Changes since V1: 1), add virDomainOpenConsoleEnsureACL 3), remove virReportOOMErrorFull when virAsprintf fail. 4), change size_t for non-nagetive number in libxlDomainOpenConsole size_t i; size_t num = 0; 5), fix for make check (1), replace virAsprintf with VIR_STRDUP in two places (2), delete space. src/libxl/libxl_conf.c | 104 +++++++++++++++++++++++++++++++++++++++++++++++ src/libxl/libxl_conf.h | 3 ++ src/libxl/libxl_driver.c | 93 ++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 200 insertions(+) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 5273a26..827dfdd 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -331,6 +331,92 @@ error: } static int +libxlMakeChrdevStr(virDomainChrDefPtr def, char **buf) +{ + virDomainChrSourceDef srcdef = def->source; + const char *type = virDomainChrTypeToString(srcdef.type); + + if (!type) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + "%s", _("unknown chrdev type")); + return -1; + } + + switch (srcdef.type) { + case VIR_DOMAIN_CHR_TYPE_NULL: + case VIR_DOMAIN_CHR_TYPE_STDIO: + case VIR_DOMAIN_CHR_TYPE_VC: + case VIR_DOMAIN_CHR_TYPE_PTY: + if (VIR_STRDUP(*buf, type) < 0) + return -1; + break; + + case VIR_DOMAIN_CHR_TYPE_FILE: + case VIR_DOMAIN_CHR_TYPE_PIPE: + if (virAsprintf(buf, "%s:%s", type, srcdef.data.file.path) < 0) + return -1; + break; + + case VIR_DOMAIN_CHR_TYPE_DEV: + if (VIR_STRDUP(*buf, srcdef.data.file.path) < 0) + return -1; + break; + + case VIR_DOMAIN_CHR_TYPE_UDP: { + const char *connectHost = srcdef.data.udp.connectHost; + const char *bindHost = srcdef.data.udp.bindHost; + const char *bindService = srcdef.data.udp.bindService; + + if (connectHost == NULL) + connectHost = ""; + if (bindHost == NULL) + bindHost = ""; + if (bindService == NULL) + bindService = "0"; + + if (virAsprintf(buf, "udp:%s:%s@%s:%s", + connectHost, + srcdef.data.udp.connectService, + bindHost, + bindService) < 0) + return -1; + break; + } + + case VIR_DOMAIN_CHR_TYPE_TCP: { + const char *prefix; + + if (srcdef.data.tcp.protocol == VIR_DOMAIN_CHR_TCP_PROTOCOL_TELNET) + prefix = "telnet"; + else + prefix = "tcp"; + + if (virAsprintf(buf, "%s:%s:%s%s", + prefix, + srcdef.data.tcp.host, + srcdef.data.tcp.service, + srcdef.data.tcp.listen ? ",server,nowait" : "") < 0) + return -1; + break; + } + + case VIR_DOMAIN_CHR_TYPE_UNIX: + if (virAsprintf(buf, "unix:%s%s", + srcdef.data.nix.path, + srcdef.data.nix.listen ? ",server,nowait" : "") < 0) + return -1; + break; + + default: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("unsupported chardev '%s'"), type); + return -1; + } + + return 0; +} + +static int libxlMakeDomBuildInfo(virDomainObjPtr vm, libxl_domain_config *d_config) { virDomainDefPtr def = vm->def; @@ -411,6 +497,24 @@ libxlMakeDomBuildInfo(virDomainObjPtr vm, libxl_domain_config *d_config) if (VIR_STRDUP(b_info->u.hvm.boot, bootorder) < 0) goto error; + if (def->nserials) { + if (def->nserials > 1) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + "%s", + _("Only one serial device is supported by libxl")); + goto error; + } + if (libxlMakeChrdevStr(def->serials[0], &b_info->u.hvm.serial) < 0) + goto error; + } + + if (def->nparallels) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + "%s", + _("Parallel devices are not supported by libxl")); + goto error; + } + /* * The following comment and calculation were taken directly from * libxenlight's internal function libxl_get_required_shadow_memory(): diff --git a/src/libxl/libxl_conf.h b/src/libxl/libxl_conf.h index 942cdd5..aa57710 100644 --- a/src/libxl/libxl_conf.h +++ b/src/libxl/libxl_conf.h @@ -34,6 +34,7 @@ # include "configmake.h" # include "virportallocator.h" # include "virobject.h" +# include "virchrdev.h" # define LIBXL_VNC_PORT_MIN 5900 @@ -94,6 +95,8 @@ struct _libxlDomainObjPrivate { /* per domain libxl ctx */ libxl_ctx *ctx; + /* console */ + virChrdevsPtr devs; libxl_evgen_domain_death *deathW; /* list of libxl timeout registrations */ diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 98b1985..0d42062 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -417,6 +417,9 @@ libxlDomainObjPrivateAlloc(void) libxl_osevent_register_hooks(priv->ctx, &libxl_event_callbacks, priv); + if (!(priv->devs = virChrdevAlloc())) + return NULL; + return priv; } @@ -428,6 +431,7 @@ libxlDomainObjPrivateDispose(void *obj) if (priv->deathW) libxl_evdisable_domain_death(priv->ctx, priv->deathW); + virChrdevFree(priv->devs); libxl_ctx_free(priv->ctx); } @@ -4493,6 +4497,94 @@ cleanup: return ret; } + +static int +libxlDomainOpenConsole(virDomainPtr dom, + const char *dev_name, + virStreamPtr st, + unsigned int flags) +{ + libxlDriverPrivatePtr driver = dom->conn->privateData; + virDomainObjPtr vm = NULL; + int ret = -1; + virDomainChrDefPtr chr = NULL; + libxlDomainObjPrivatePtr priv; + char *console = NULL; + + virCheckFlags(VIR_DOMAIN_CONSOLE_FORCE, -1); + + if (dev_name) { + /* XXX support device aliases in future */ + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Named device aliases are not supported")); + goto cleanup; + } + + libxlDriverLock(driver); + vm = virDomainObjListFindByUUID(driver->domains, dom->uuid); + libxlDriverUnlock(driver); + if (!vm) { + char uuidstr[VIR_UUID_STRING_BUFLEN]; + virUUIDFormat(dom->uuid, uuidstr); + virReportError(VIR_ERR_NO_DOMAIN, + _("No domain with matching uuid '%s'"), uuidstr); + goto cleanup; + } + + if (virDomainOpenConsoleEnsureACL(dom->conn, vm->def) < 0) + goto cleanup; + + if (!virDomainObjIsActive(vm)) { + virReportError(VIR_ERR_OPERATION_INVALID, + "%s", _("domain is not running")); + goto cleanup; + } + + priv = vm->privateData; + + if (vm->def->nserials) + chr = vm->def->serials[0]; + + if (!chr) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("cannot find character device %s"), + NULLSTR(dev_name)); + goto cleanup; + } + + if (chr->source.type != VIR_DOMAIN_CHR_TYPE_PTY) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("character device %s is not using a PTY"), + NULLSTR(dev_name)); + goto cleanup; + } + + ret = libxl_primary_console_get_tty(priv->ctx, vm->def->id, &console); + if (ret) + goto cleanup; + + if (VIR_STRDUP(chr->source.data.file.path, console) < 0) + goto cleanup; + + /* handle mutually exclusive access to console devices */ + ret = virChrdevOpen(priv->devs, + &chr->source, + st, + (flags & VIR_DOMAIN_CONSOLE_FORCE) != 0); + + if (ret == 1) { + virReportError(VIR_ERR_OPERATION_FAILED, "%s", + _("Active console session exists for this domain")); + ret = -1; + } + +cleanup: + VIR_FREE(console); + if (vm) + virObjectUnlock(vm); + return ret; +} + static int libxlDomainSetSchedulerParameters(virDomainPtr dom, virTypedParameterPtr params, int nparams) @@ -4875,6 +4967,7 @@ static virDriver libxlDriver = { .domainManagedSave = libxlDomainManagedSave, /* 0.9.2 */ .domainHasManagedSaveImage = libxlDomainHasManagedSaveImage, /* 0.9.2 */ .domainManagedSaveRemove = libxlDomainManagedSaveRemove, /* 0.9.2 */ + .domainOpenConsole = libxlDomainOpenConsole, /* 1.1.2 */ .domainIsActive = libxlDomainIsActive, /* 0.9.0 */ .domainIsPersistent = libxlDomainIsPersistent, /* 0.9.0 */ .domainIsUpdated = libxlDomainIsUpdated, /* 0.9.0 */ -- 1.8.1.4

2 2

[libvirt] [PATCH] maint: fix typo for SENTINEL
by Eric Blake 30 Jul '13

30 Jul '13

* src/openvz/openvz_driver.c: Use correct spelling. * src/vmware/vmware_conf.c: Likewise. * src/vmware/vmware_conf.h: Likewise. * src/vmware/vmware_driver.c: Likewise. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- Pushing under the trivial rule. src/openvz/openvz_driver.c | 24 ++++++++++++------------ src/vmware/vmware_conf.c | 4 ++-- src/vmware/vmware_conf.h | 2 +- src/vmware/vmware_driver.c | 18 +++++++++--------- 4 files changed, 24 insertions(+), 24 deletions(-) diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index de4e4ff..d268647 100644 --- a/src/openvz/openvz_driver.c +++ b/src/openvz/openvz_driver.c @@ -564,12 +564,12 @@ cleanup: * key value. This lets us declare the argv on the * stack and just splice in the domain name after */ -#define PROGRAM_SENTINAL ((char *)0x1) +#define PROGRAM_SENTINEL ((char *)0x1) static void openvzSetProgramSentinal(const char **prog, const char *key) { const char **tmp = prog; while (tmp && *tmp) { - if (*tmp == PROGRAM_SENTINAL) { + if (*tmp == PROGRAM_SENTINEL) { *tmp = key; break; } @@ -580,7 +580,7 @@ static void openvzSetProgramSentinal(const char **prog, const char *key) static int openvzDomainSuspend(virDomainPtr dom) { struct openvz_driver *driver = dom->conn->privateData; virDomainObjPtr vm; - const char *prog[] = {VZCTL, "--quiet", "chkpnt", PROGRAM_SENTINAL, "--suspend", NULL}; + const char *prog[] = {VZCTL, "--quiet", "chkpnt", PROGRAM_SENTINEL, "--suspend", NULL}; int ret = -1; openvzDriverLock(driver); @@ -618,7 +618,7 @@ cleanup: static int openvzDomainResume(virDomainPtr dom) { struct openvz_driver *driver = dom->conn->privateData; virDomainObjPtr vm; - const char *prog[] = {VZCTL, "--quiet", "chkpnt", PROGRAM_SENTINAL, "--resume", NULL}; + const char *prog[] = {VZCTL, "--quiet", "chkpnt", PROGRAM_SENTINEL, "--resume", NULL}; int ret = -1; openvzDriverLock(driver); @@ -658,7 +658,7 @@ openvzDomainShutdownFlags(virDomainPtr dom, unsigned int flags) { struct openvz_driver *driver = dom->conn->privateData; virDomainObjPtr vm; - const char *prog[] = {VZCTL, "--quiet", "stop", PROGRAM_SENTINAL, NULL}; + const char *prog[] = {VZCTL, "--quiet", "stop", PROGRAM_SENTINEL, NULL}; int ret = -1; int status; @@ -721,7 +721,7 @@ static int openvzDomainReboot(virDomainPtr dom, { struct openvz_driver *driver = dom->conn->privateData; virDomainObjPtr vm; - const char *prog[] = {VZCTL, "--quiet", "restart", PROGRAM_SENTINAL, NULL}; + const char *prog[] = {VZCTL, "--quiet", "restart", PROGRAM_SENTINEL, NULL}; int ret = -1; int status; @@ -1041,7 +1041,7 @@ openvzDomainCreateXML(virConnectPtr conn, const char *xml, virDomainDefPtr vmdef = NULL; virDomainObjPtr vm = NULL; virDomainPtr dom = NULL; - const char *progstart[] = {VZCTL, "--quiet", "start", PROGRAM_SENTINAL, NULL}; + const char *progstart[] = {VZCTL, "--quiet", "start", PROGRAM_SENTINEL, NULL}; virCheckFlags(0, NULL); @@ -1126,7 +1126,7 @@ openvzDomainCreateWithFlags(virDomainPtr dom, unsigned int flags) { struct openvz_driver *driver = dom->conn->privateData; virDomainObjPtr vm; - const char *prog[] = {VZCTL, "--quiet", "start", PROGRAM_SENTINAL, NULL }; + const char *prog[] = {VZCTL, "--quiet", "start", PROGRAM_SENTINEL, NULL }; int ret = -1; int status; @@ -1180,7 +1180,7 @@ openvzDomainUndefineFlags(virDomainPtr dom, { struct openvz_driver *driver = dom->conn->privateData; virDomainObjPtr vm; - const char *prog[] = { VZCTL, "--quiet", "destroy", PROGRAM_SENTINAL, NULL }; + const char *prog[] = { VZCTL, "--quiet", "destroy", PROGRAM_SENTINEL, NULL }; int ret = -1; int status; @@ -1228,7 +1228,7 @@ openvzDomainSetAutostart(virDomainPtr dom, int autostart) { struct openvz_driver *driver = dom->conn->privateData; virDomainObjPtr vm; - const char *prog[] = { VZCTL, "--quiet", "set", PROGRAM_SENTINAL, + const char *prog[] = { VZCTL, "--quiet", "set", PROGRAM_SENTINEL, "--onboot", autostart ? "yes" : "no", "--save", NULL }; int ret = -1; @@ -1326,7 +1326,7 @@ static int openvzDomainSetVcpusInternal(virDomainObjPtr vm, unsigned int nvcpus) { char str_vcpus[32]; - const char *prog[] = { VZCTL, "--quiet", "set", PROGRAM_SENTINAL, + const char *prog[] = { VZCTL, "--quiet", "set", PROGRAM_SENTINEL, "--cpus", str_vcpus, "--save", NULL }; unsigned int pcpus; pcpus = openvzGetNodeCPUs(); @@ -1685,7 +1685,7 @@ openvzDomainSetMemoryInternal(virDomainObjPtr vm, unsigned long long mem) { char str_mem[16]; - const char *prog[] = { VZCTL, "--quiet", "set", PROGRAM_SENTINAL, + const char *prog[] = { VZCTL, "--quiet", "set", PROGRAM_SENTINEL, "--kmemsize", str_mem, "--save", NULL }; diff --git a/src/vmware/vmware_conf.c b/src/vmware/vmware_conf.c index 23da92d..e00c66c 100644 --- a/src/vmware/vmware_conf.c +++ b/src/vmware/vmware_conf.c @@ -205,7 +205,7 @@ vmwareSetSentinal(const char **prog, const char *key) const char **tmp = prog; while (tmp && *tmp) { - if (*tmp == PROGRAM_SENTINAL) { + if (*tmp == PROGRAM_SENTINEL) { *tmp = key; break; } @@ -392,7 +392,7 @@ int vmwareMoveFile(char *srcFile, char *dstFile) { const char *cmdmv[] = - { "mv", PROGRAM_SENTINAL, PROGRAM_SENTINAL, NULL }; + { "mv", PROGRAM_SENTINEL, PROGRAM_SENTINEL, NULL }; if (!virFileExists(srcFile)) { virReportError(VIR_ERR_INTERNAL_ERROR, _("file %s does not exist"), diff --git a/src/vmware/vmware_conf.h b/src/vmware/vmware_conf.h index cb11aca..6666eaf 100644 --- a/src/vmware/vmware_conf.h +++ b/src/vmware/vmware_conf.h @@ -28,7 +28,7 @@ # include "virthread.h" # define VIR_FROM_THIS VIR_FROM_VMWARE -# define PROGRAM_SENTINAL ((char *)0x1) +# define PROGRAM_SENTINEL ((char *)0x1) # define TYPE_PLAYER 0 # define TYPE_WORKSTATION 1 diff --git a/src/vmware/vmware_driver.c b/src/vmware/vmware_driver.c index 988552f..74591d6 100644 --- a/src/vmware/vmware_driver.c +++ b/src/vmware/vmware_driver.c @@ -252,8 +252,8 @@ vmwareStopVM(struct vmware_driver *driver, virDomainShutoffReason reason) { const char *cmd[] = { - VMRUN, "-T", PROGRAM_SENTINAL, "stop", - PROGRAM_SENTINAL, "soft", NULL + VMRUN, "-T", PROGRAM_SENTINEL, "stop", + PROGRAM_SENTINEL, "soft", NULL }; vmwareSetSentinal(cmd, vmw_types[driver->type]); @@ -273,8 +273,8 @@ static int vmwareStartVM(struct vmware_driver *driver, virDomainObjPtr vm) { const char *cmd[] = { - VMRUN, "-T", PROGRAM_SENTINAL, "start", - PROGRAM_SENTINAL, PROGRAM_SENTINAL, NULL + VMRUN, "-T", PROGRAM_SENTINEL, "start", + PROGRAM_SENTINEL, PROGRAM_SENTINEL, NULL }; const char *vmxPath = ((vmwareDomainPtr) vm->privateData)->vmxPath; @@ -446,8 +446,8 @@ vmwareDomainSuspend(virDomainPtr dom) virDomainObjPtr vm; const char *cmd[] = { - VMRUN, "-T", PROGRAM_SENTINAL, "pause", - PROGRAM_SENTINAL, NULL + VMRUN, "-T", PROGRAM_SENTINEL, "pause", + PROGRAM_SENTINEL, NULL }; int ret = -1; @@ -495,7 +495,7 @@ vmwareDomainResume(virDomainPtr dom) virDomainObjPtr vm; const char *cmd[] = { - VMRUN, "-T", PROGRAM_SENTINAL, "unpause", PROGRAM_SENTINAL, + VMRUN, "-T", PROGRAM_SENTINEL, "unpause", PROGRAM_SENTINEL, NULL }; int ret = -1; @@ -544,8 +544,8 @@ vmwareDomainReboot(virDomainPtr dom, unsigned int flags) const char * vmxPath = NULL; virDomainObjPtr vm; const char *cmd[] = { - VMRUN, "-T", PROGRAM_SENTINAL, - "reset", PROGRAM_SENTINAL, "soft", NULL + VMRUN, "-T", PROGRAM_SENTINEL, + "reset", PROGRAM_SENTINEL, "soft", NULL }; int ret = -1; -- 1.8.3.1

2 1

[libvirt] [PATCH] spec: Use --enable-werror on RHEL
by Jiri Denemark 30 Jul '13

30 Jul '13

As RHEL provides a stable tool chain, we don't have to worry about frequent changes in reported compiler warnings (which prevents us from enabling -Werror unconditionally). --- libvirt.spec.in | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index e74f774..6d6203b 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -352,6 +352,14 @@ %endif +# RHEL releases provide stable tool chains and so it is safe to turn +# compiler warning into errors without being worried about frequent +# changes in reported warnings +%if 0%{?rhel} + %define enable_werror --enable-werror +%endif + + Summary: Library providing a simple virtualization API Name: libvirt Version: @VERSION@ @@ -1386,6 +1394,7 @@ of recent versions of Linux (and other OSes). %{with_packager_version} \ --with-qemu-user=%{qemu_user} \ --with-qemu-group=%{qemu_group} \ + %{?enable_werror} \ %{init_scripts} make %{?_smp_mflags} gzip -9 ChangeLog -- 1.8.3.2

2 2

[libvirt] [PATCH] spec: RHEL-7 does not have sanlock on i686
by Jiri Denemark 30 Jul '13

30 Jul '13

--- libvirt.spec.in | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 6236c08..e74f774 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -245,11 +245,16 @@ %if 0%{?fedora} >= 16 %define with_sanlock 0%{!?_without_sanlock:%{server_drivers}} %endif -%if 0%{?rhel} >= 6 +%if 0%{?rhel} == 6 %ifarch %{ix86} x86_64 %define with_sanlock 0%{!?_without_sanlock:%{server_drivers}} %endif %endif +%if 0%{?rhel} >= 7 + %ifarch x86_64 + %define with_sanlock 0%{!?_without_sanlock:%{server_drivers}} + %endif +%endif # Enable libssh2 transport for new enough distros %if 0%{?fedora} >= 17 -- 1.8.3.2

2 2

[libvirt] [PATCH] spec: Disable libssh2 support for RHEL
by Jiri Denemark 30 Jul '13

30 Jul '13

From: Peter Krempa <pkrempa(a)redhat.com> https://bugzilla.redhat.com/show_bug.cgi?id=905513 Libssh2 isn't reliable enough to support the libvirt transport using it. The problems include mishandling of "known_hosts" files that may confuse users. --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index a3a831f..6236c08 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -252,7 +252,7 @@ %endif # Enable libssh2 transport for new enough distros -%if 0%{?fedora} >= 17 || 0%{?rhel} >= 6 +%if 0%{?fedora} >= 17 %define with_libssh2 0%{!?_without_libssh2:1} %endif -- 1.8.3.2

2 2

[libvirt] [PATCH] tests: Put a mock library at the start of LD_PRELOAD
by Jiri Denemark 30 Jul '13

30 Jul '13

This fixes vircgrouptest when run in a sandbox which already overrides open() and others. --- tests/testutils.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/testutils.h b/tests/testutils.h index 27af5da..8583747 100644 --- a/tests/testutils.h +++ b/tests/testutils.h @@ -87,8 +87,9 @@ int virtTestMain(int argc, perror(lib); \ return EXIT_FAILURE; \ } \ - if (virAsprintf(&newenv, "%s%s%s", preload ? preload : "", \ - preload ? ":" : "", lib) < 0) { \ + if (!preload) { \ + newenv = (char *) lib; \ + } else if (virAsprintf(&newenv, "%s:%s", lib, preload) < 0) { \ perror("virAsprintf"); \ return EXIT_FAILURE; \ } \ -- 1.8.3.2

2 2

[libvirt] [PATCH] spec: Don't mix commands with macro definitions
by Jiri Denemark 30 Jul '13

30 Jul '13

%build section should first define all required macros and then run commands. Interleaving them makes it harder to spot what commands are run. --- libvirt.spec.in | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 6d6203b..0fdba54 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1333,10 +1333,6 @@ of recent versions of Linux (and other OSes). %define init_scripts --with-init_script=redhat %endif -%if 0%{?enable_autotools} - autoreconf -if -%endif - %if %{with_selinux} %if 0%{?fedora} >= 17 || 0%{?rhel} >= 7 %define with_selinux_mount --with-selinux-mount="/sys/fs/selinux" @@ -1345,6 +1341,11 @@ of recent versions of Linux (and other OSes). %endif %endif + +%if 0%{?enable_autotools} + autoreconf -if +%endif + %configure %{?_without_xen} \ %{?_without_qemu} \ %{?_without_openvz} \ -- 1.8.3.2

2 2

[libvirt] 3rd pass at virt-login-shell for joining an LXC Container
by dwalsh＠redhat.com 30 Jul '13

30 Jul '13

All comments applied except for comments below. Also additional cleanup of error handling. > You'll need to call virGetUserDirectory() before any fork(), since it > calls code which is not async-signal safe. The reason I did this is I needed to call it after the shell setuid, if I call it earlier it sees the UID=0 and gives me /root. I added a new interface char *virGetUserDirectoryByUID(uid_t uid); Since the original interface does not take a UID. > Hmm, looking at this again, I'm wondering you need to fork() > at all. In virsh we do the double-fork dance, because virsh > is an interactive shell & we don't want to affect other parts > of virsh. > This login shell though is different - its only job is to run > inside the namespace. So can't the main process just enter > the namespace directly ? I think you still need to do the second fork to make sure the /bin/sh PID gets put in the container. Otherwise you will have a process running within the container without a local PID. [PATCH] virt-login-shell joins users into lxc container.

4 10

[libvirt] [PATCH] Configuring systemd to restart libvirt on abort
by Mooli Tayer 30 Jul '13

30 Jul '13

----- Original Message ----- > On Mon, Jul 29, 2013 at 05:36:21PM +0300, Mooli Tayer wrote: > > From: Mooli Tayer <mtayer(a)redhat.com> > > > > This will create a respawn behaviour in case libvirt > > process exits due to an uncaught signal not specified > > as a clean exit status. > > see http://www.freedesktop.org/software/systemd/man/systemd.service.html > > --- > > daemon/libvirtd.service.in | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/daemon/libvirtd.service.in b/daemon/libvirtd.service.in > > index aa5913b..b3c0849 100644 > > --- a/daemon/libvirtd.service.in > > +++ b/daemon/libvirtd.service.in > > @@ -15,6 +15,7 @@ EnvironmentFile=-/etc/sysconfig/libvirtd > > ExecStart=@sbindir@/libvirtd $LIBVIRTD_ARGS > > ExecReload=/bin/kill -HUP $MAINPID > > KillMode=process > > +Restart=on-abort > > # Override the maximum number of opened files > > #LimitNOFILE=2048 > > I'm wondering whether 'on-abort' is the best choice or if > 'on-failure' or 'always' are better. The systemd.service > man page says > > [quote] > Takes one of no, on-success, on-failure, > on-abort, or always. If set to no (the > default) the service will not be restarted. If > set to on-success it will be restarted only > when the service process exits cleanly. In > this context, a clean exit means an exit code > of 0, or one of the signals SIGHUP, SIGINT, > SIGTERM, or SIGPIPE, and additionally, exit > statuses and signals specified in > SuccessExitStatus=. If set to on-failure the > service will be restarted when the process > exits with an nonzero exit code, is terminated > by a signal (including on core dump), when an > operation (such as service reload) times out, > and when the configured watchdog timeout is > triggered. If set to on-abort the service will > be restarted only if the service process exits > due to an uncaught signal not specified as a > clean exit status. If set to always the > service will be restarted regardless whether > it exited cleanly or not, got terminated > abnormally by a signal or hit a timeout. > [/quote] > > I tend towards saying 'on-failure' here. I agree. we defiantly want restart in the 'on-failure' cases. > > Daniel > -- > |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| > |: http://libvirt.org -o- http://virt-manager.org :| > |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| > |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| > > -- > libvir-list mailing list > libvir-list(a)redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list >

3 3

[libvirt] [PATCH] Support apparmor in RPM spec
by Daniel P. Berrange 30 Jul '13

30 Jul '13

From: "Daniel P. Berrange" <berrange(a)redhat.com> If libapparmor-devel happens to be installed when building the RPM, it will failed due to unlisted virt-aa-helper in %files. Add support for apparmor in the spec, so that we can explicitly turn it on/off, defaulting to off in all distros. This causes --without-apparmor to be given to configure, preventing the build failures if the user happens to have libapparmor-devel present. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- libvirt.spec.in | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index a3a831f..6212b3c 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -100,6 +100,9 @@ %define with_numactl 0%{!?_without_numactl:%{server_drivers}} %define with_selinux 0%{!?_without_selinux:%{server_drivers}} +# Just hardcode to off, since few people ever have apparmor RPMs installed +%define with_apparmor 0%{!?_without_apparmor:0} + # A few optional bits off by default, we enable later %define with_polkit 0%{!?_without_polkit:0} %define with_capng 0%{!?_without_capng:0} @@ -472,6 +475,9 @@ BuildRequires: avahi-devel %if %{with_selinux} BuildRequires: libselinux-devel %endif +%if %{with_apparmor} +BuildRequires: libapparmor-devel +%endif %if %{with_network} BuildRequires: dnsmasq >= 2.41 BuildRequires: iptables @@ -1268,6 +1274,10 @@ of recent versions of Linux (and other OSes). %define _without_selinux --without-selinux %endif +%if ! %{with_apparmor} + %define _without_apparmor --without-apparmor +%endif + %if ! %{with_hal} %define _without_hal --without-hal %endif @@ -1367,6 +1377,7 @@ of recent versions of Linux (and other OSes). %{?_without_netcf} \ %{?_without_selinux} \ %{?_with_selinux_mount} \ + %{?_without_apparmor} \ %{?_without_hal} \ %{?_without_udev} \ %{?_without_yajl} \ @@ -1835,6 +1846,11 @@ fi %endif %attr(0755, root, root) %{_libexecdir}/libvirt_iohelper + + %if %{with_apparmor} +%attr(0755, root, root) %{_libexecdir}/virt-aa-helper + %endif + %attr(0755, root, root) %{_sbindir}/libvirtd %attr(0755, root, root) %{_sbindir}/virtlockd -- 1.8.3.1

2 2

[libvirt] [PATCH] Fix minor typos in messages and docs
by Yuri Chornoivan 30 Jul '13

30 Jul '13

2 1

[libvirt] [PATCH] Delete obsolete / unused python test files
by Daniel P. Berrange 30 Jul '13

30 Jul '13

From: "Daniel P. Berrange" <berrange(a)redhat.com> The python/tests directory contains a number of so called "tests" for the python API. These are all hardcoded to look for Xen and cannot be run in any automated fashion, and no one is ever manually running them. Given that they don't meaningully contribute to the test coverage, delete them. For some reason these tests were also copied into the filesystem as part of 'make install'. The change to the RPM in commit 3347a4203278ec93d7b0ceb88b5ed10e4f14765c caused a build failure, since it removed the code which deleted these installed tests. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- configure.ac | 2 +- python/Makefile.am | 2 - python/tests/Makefile.am | 52 ----------------- python/tests/basic.py | 31 ---------- python/tests/create.py | 146 ----------------------------------------------- python/tests/error.py | 42 -------------- python/tests/node.py | 34 ----------- python/tests/uuid.py | 41 ------------- 8 files changed, 1 insertion(+), 349 deletions(-) delete mode 100644 python/tests/Makefile.am delete mode 100755 python/tests/basic.py delete mode 100755 python/tests/create.py delete mode 100755 python/tests/error.py delete mode 100755 python/tests/node.py delete mode 100755 python/tests/uuid.py diff --git a/configure.ac b/configure.ac index 35a5d76..084d864 100644 --- a/configure.ac +++ b/configure.ac @@ -2447,7 +2447,7 @@ AC_OUTPUT(Makefile src/Makefile include/Makefile docs/Makefile \ libvirt.pc libvirt.spec mingw-libvirt.spec \ po/Makefile.in \ include/libvirt/Makefile include/libvirt/libvirt.h \ - python/Makefile python/tests/Makefile \ + python/Makefile \ daemon/Makefile \ tools/Makefile \ tests/Makefile \ diff --git a/python/Makefile.am b/python/Makefile.am index 7eb42c6..925e1f4 100644 --- a/python/Makefile.am +++ b/python/Makefile.am @@ -16,8 +16,6 @@ ## License along with this library. If not, see ## <http://www.gnu.org/licenses/>. -SUBDIRS= . tests - INCLUDES = \ $(PYTHON_INCLUDES) \ -I$(top_builddir)/gnulib/lib \ diff --git a/python/tests/Makefile.am b/python/tests/Makefile.am deleted file mode 100644 index 0fd3c78..0000000 --- a/python/tests/Makefile.am +++ /dev/null @@ -1,52 +0,0 @@ -## Copyright (C) 2005-2011, 2013 Red Hat, Inc. -## -## This library is free software; you can redistribute it and/or -## modify it under the terms of the GNU Lesser General Public -## License as published by the Free Software Foundation; either -## version 2.1 of the License, or (at your option) any later version. -## -## This library is distributed in the hope that it will be useful, -## but WITHOUT ANY WARRANTY; without even the implied warranty of -## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -## Lesser General Public License for more details. -## -## You should have received a copy of the GNU Lesser General Public -## License along with this library. If not, see -## <http://www.gnu.org/licenses/>. - -EXAMPLE_DIR = $(datadir)/doc/libvirt-python-$(VERSION)/examples - -PYTESTS= \ - basic.py \ - create.py \ - uuid.py \ - error.py \ - node.py - -EXTRA_DIST = $(PYTESTS) - -if WITH_PYTHON -tests: $(PYTESTS) - @echo "## running Python regression tests" - -@(PYTHONPATH="..:../.libs:../src/.libs:$(srcdir)/../src:$$PYTHONPATH";\ - export PYTHONPATH; \ - LD_LIBRARY_PATH="$(top_builddir)/src/.libs:$$LD_LIBRARY_PATH" ; \ - export LD_LIBRARY_PATH; \ - for test in $(PYTESTS) ; \ - do log=`$(PYTHON) $(srcdir)/$$test` ; \ - if [ "`echo $$log | grep OK`" = "" ] ; then \ - echo "-- $$test" ; echo "$$log" ; fi ; done) -else -tests: -endif - -clean: - rm -f *.pyc core - -install-data-local: - $(mkinstalldirs) $(DESTDIR)$(EXAMPLE_DIR) - -(for test in $(PYTESTS); \ - do $(INSTALL) -m 0644 $(srcdir)/$$test $(DESTDIR)$(EXAMPLE_DIR) ; done) - -uninstall-local: - for test in $(PYTESTS); do rm -f $(DESTDIR)$(EXAMPLE_DIR)/$$test; done diff --git a/python/tests/basic.py b/python/tests/basic.py deleted file mode 100755 index c6dec81..0000000 --- a/python/tests/basic.py +++ /dev/null @@ -1,31 +0,0 @@ -#!/usr/bin/python -u -import libvirt -import sys -import os - -if not os.access("/proc/xen", os.R_OK): - print 'System is not running a Xen kernel' - sys.exit(1) - -conn = libvirt.openReadOnly(None) -if conn == None: - print 'Failed to open connection to the hypervisor' - sys.exit(1) - -# print conn - -try: - dom0 = conn.lookupByName("Domain-0") -except: - print 'Failed to find the main domain' - sys.exit(1) - -# print dom0 - -print "Domain 0: id %d running %s" % (dom0.ID(), dom0.OSType()) -print dom0.info() -del dom0 -del conn -print "OK" - -sys.exit(0) diff --git a/python/tests/create.py b/python/tests/create.py deleted file mode 100755 index 815ccc4..0000000 --- a/python/tests/create.py +++ /dev/null @@ -1,146 +0,0 @@ -#!/usr/bin/python -u -import libvirt -import sys -import os -import time - -if not os.access("/proc/xen", os.R_OK): - print 'System is not running a Xen kernel' - sys.exit(1) - -# -# Try to provide default OS images paths here, of course non standard -# -osroots = [ - "/u/fc4-2.img", - "/u/fc4.img", - "/xen/fc4.img", -] - -okay = 1 - -osroot = None -for root in osroots: - if os.access(root, os.R_OK): - osroot = root - break - -if osroot == None: - print "Could not find a guest OS root, edit to add the path in osroots" - sys.exit(1) - -kernel=open("/proc/version").read().split() -kernelOv = kernel[2] - -if kernelOv.find('hypervisor'): - kernelU = "/boot/vmlinuz-" + kernelOv.replace('hypervisor', 'guest') - initrdU = "/boot/initrd-" + kernelOv.replace('hypervisor', 'guest') + ".img" -elif kernelOv.find('xen0'): - kernelU = "/boot/vmlinuz-" + kernelOv.replace('xen0', 'xenU') - initrdU = "/boot/initrd-" + kernelOv.replace('xen0', 'xenU') + ".img" - -if not os.access(kernelU, os.R_OK): - print "Did not find the guest kernel %s" % (kernelU) - sys.exit(1) - -kernelU = "<kernel>" + kernelU + "</kernel>" - -if not os.access(initrdU, os.R_OK): - print "Did not find the guest initrd %s" % (initrdU) - initrdU = "" -else: - initrdU = "<initrd>" + initrdU + "</initrd>" - - -conn = libvirt.open(None) -if conn == None: - print 'Failed to open connection to the hypervisor' - sys.exit(1) - -xmldesc="""<domain type='xen'> - <name>test</name> - <os> - <type>linux</type> -""" + kernelU + initrdU + """ - <cmdline> root=/dev/sda1 ro selinux=0 3</cmdline> - </os> - <memory>131072</memory> - <vcpu>1</vcpu> - <devices> - <disk type='file'> - <source file='%s'/> - <target dev='sda1'/> - </disk> - <interface type='bridge'> - <source bridge='xenbr0'/> - <mac address='aa:00:00:00:00:12'/> - <script path='/etc/xen/scripts/vif-bridge'/> - </interface> - </devices> -</domain> -""" % (osroot) - -dom = conn.createLinux(xmldesc, 0) -if dom == None: - print 'Failed to create a test domain' - sys.exit(1) - -# print dom - -print "Domain: id %d running %s" % (dom.ID(), dom.OSType()) - -print "Suspending test domain for 5 seconds" -if dom.suspend() != 0: - print 'Failed to suspend domain test' - dom.destroy() - del dom - del conn - sys.exit(1) - -infos = dom.info() -time.sleep(5) -infos2 = dom.info() -if infos[4] != infos2[4]: - print 'Suspended domain test got CPU cycles' - okay = 0 - -print "resuming test domain for 10 seconds" -if dom.resume() != 0: - print 'Failed to resume domain test' - dom.destroy() - del dom - del conn - sys.exit(1) - -time.sleep(10) -print "shutdown of test domain" - -if dom.shutdown() != 0: - okay = 0 - print 'Failed to shutdown domain test' - -i = 0 -while i < 30: - time.sleep(1) - i = i + 1 - try: - t = dom.info()[4] - except: - okay = 0 - t = -1 - break - - if t == 0: - break - -if t != 0: - print 'Shutdown failed destroying domain test' - okay = 0 - dom.destroy() - -del dom -del conn -if okay == 1: - print "OK" - -sys.exit(0) diff --git a/python/tests/error.py b/python/tests/error.py deleted file mode 100755 index 295f9a7..0000000 --- a/python/tests/error.py +++ /dev/null @@ -1,42 +0,0 @@ -#!/usr/bin/python -u -# -# Tests global error handlers at the python level. -# -import libvirt -import sys -import os - -errno = None - -def handler(ctxt, err): - global errno - - #print "handler(%s, %s)" % (ctxt, err) - errno = err - -libvirt.registerErrorHandler(handler, 'context') - -conn = libvirt.openReadOnly(None) -if conn == None: - print 'Failed to open connection to the hypervisor' - sys.exit(1) - -try: - dom0 = conn.lookupByName("Does_not_exist") - print 'strange found a Does_not_exist domain' - sys.exit(1) -except: - pass - -del conn - -if errno == None: - print 'failed to get an error' -elif errno[0] == libvirt.VIR_ERR_NO_CONNECT or \ - errno[0] == libvirt.VIR_ERR_INVALID_DOMAIN or \ - errno[0] == libvirt.VIR_ERR_GET_FAILED: - print "OK" -else: - print 'got unexpected error:', errno - -sys.exit(0) diff --git a/python/tests/node.py b/python/tests/node.py deleted file mode 100755 index f199fc3..0000000 --- a/python/tests/node.py +++ /dev/null @@ -1,34 +0,0 @@ -#!/usr/bin/python -u -import libvirt -import sys -import os - -if not os.access("/proc/xen", os.R_OK): - print 'System is not running a Xen kernel' - sys.exit(1) - -conn = libvirt.openReadOnly(None) -if conn == None: - print 'Failed to open connection to the hypervisor' - sys.exit(1) - -try: - (model, memory, cpus, mhz, nodes, socket, cores, threads) = conn.getInfo() -except: - print 'Failed to extract the current node information' - sys.exit(1) - -print "Xen running on %d %s processors at %d MHz, %d MBytes of memory" % ( - cpus, model, mhz, memory) - -if cpus > nodes * socket * cores * threads: - print "Erroneous CPU information" - sys.exit(1) - -if cpus < nodes * socket * cores * threads: - print "Strange, running in degrated mode, some CPU are not available" - -del conn -print "OK" - -sys.exit(0) diff --git a/python/tests/uuid.py b/python/tests/uuid.py deleted file mode 100755 index db48e80..0000000 --- a/python/tests/uuid.py +++ /dev/null @@ -1,41 +0,0 @@ -#!/usr/bin/python -u -import libvirt -import sys -import os - -if not os.access("/proc/xen", os.R_OK): - print 'System is not running a Xen kernel' - sys.exit(1) - -conn = libvirt.openReadOnly(None) -if conn == None: - print 'Failed to open connection to the hypervisor' - sys.exit(1) - -ids = conn.listDomainsID() -if ids == None or len(ids) == 0: - print 'Failed to list running domains' - sys.exit(1) - -id = ids[-1] - -try: - dom = conn.lookupByID(id) -except: - print 'Failed to find the domain %d' - sys.exit(1) - -name0 = dom.name() -uuid = dom.UUID() -print "Using domain %s" % (name0) -try: - dom2 = conn.lookupByUUID(uuid) -except: - print 'Failed to lookup domain %d based on its UUID' - sys.exit(1) -if dom2.name() != name0: - print 'lookup of %s based on UUID brings a different domain %s' % ( - name0, dom2.name()) - -print "OK" -sys.exit(0) -- 1.8.3.1

3 2

[libvirt] Release of libvirt-1.1.1
by Daniel Veillard 30 Jul '13

30 Jul '13

As planned the release is out, tagged in git and available at the usual place: ftp://libvirt.org/libvirt/ This is a rather large release, including around 380 commits (time to take some vacations !) with a large set of bug fixes, including 3 CVE security ones, and large improvements over the code base. The localization got updates for no less then 18 languages too, with 8 of them being nearly 100% complete ! Features: - Adding device removal or deletion events (Jiri Denemark) - Introduce new domain create APIs to pass pre-opened FDs to LXC (Daniel P. Berrange) - Add interface versions for Xen 4.3 (Stefan Bader) - Add new public API virDomainSetMemoryStatsPeriod (John Ferlan) - Various LXC improvements (Daniel P. Berrange and Gao feng) Security: - security: fix deadlock with prefork (Eric Blake) - CVE-2013-4153 qemu: Fix double free of returned JSON array in qemuAgentGetVCPUs() (Peter Krempa) - CVE-2013-4154 qemu: Prevent crash of libvirtd without guest agent configuration (Alex Jia) - CVE-2013-2230 Fix crash when multiple event callbacks were registered (Ján Tomko) Documentation: - formatdomain.html.in: Document implementation limitation of QoS (Michal Privoznik) - formatdomain.html.in: Correctly use <code/> in #elementQoS (Michal Privoznik) - Fix copy-paste-error in virNodeGetMemoryStats (Philipp Hahn) - virsh: Mention --driver in man page for nodedev-detach (Peter Krempa) - maint: tweak use of <a> in HACKING (Eric Blake) - maint: fix typo in qemu error message (Eric Blake) - daemon: Fix command example in libvirtd.sasl (Cole Robinson) - Put virt-sanlock-cleanup into section 8 (Guido Günther) - Document hypervisor drivers that support certain timer models (Peter Krempa) Portability: - build: fix shunloadtest breakage (Eric Blake) - examples: fix mingw build vs. printf (Eric Blake) - build: skip systemd mock on non-Linux (Eric Blake) - Fix dbus message reading code on big endian hosts (Daniel P. Berrange) - build: fix another virdbus issue on mingw (Eric Blake) - build: fix virutil build on mingw (Eric Blake) - build: fix virthread build on mingw (Eric Blake) - build: fix virdbus build on mingw (Eric Blake) - build: fix vircgroup build on mingw (Eric Blake) - Conditionalize build of virCgroupValidateMachineGroup (Daniel P. Berrange) - build: fix VPATH 'make check' (Eric Blake) - cpu: Fix one compile error for PPC. (Li Zhang) - virdbustest: Don't pass number of arguments as long long (Guido Günther) - Fix virCgroupAvailable() w/o HAVE_GETMNTENT_R defined (Roman Bogorodskiy) - Fix link_addr detection (Roman Bogorodskiy) - build: work around broken kernel headers (Eric Blake) - dbus: work with older dbus (Eric Blake) - Use AC_LINK_IFELSE (Guido Günther) - Check for link_addr more thoroughly (Guido Günther) - Fix bridge routines detection on kFreeBSD (Roman Bogorodskiy) - Fix build with clang (Ján Tomko) - build: don't ship access syms files in tarball (Eric Blake) - build: work around mingw header pollution (Eric Blake) - build: avoid build failure without gnutls (Eric Blake) Bug Fixes: - Fix probing of legacy Xen driver to not leave URI set (Daniel P. Berrange) - caps: use -device for primary video when qemu >=1.6 (Guannan Ren) - Resolve Coverity complaint in storagevolxml2argvtest (Ján Tomko) - Don't check validity of missing attributes in DNS SRV XML (Ján Tomko) - Set the number of elements 0 in virNetwork*Clear (Ján Tomko) - conf:Fix a copy paste error (Alex Jia) - virLXCMonitorClose: Unlock domain while closing monitor (Michal Privoznik) - libxl: Correctly initialize vcpu bitmap (Stefan Bader) - Add new virAuth symbols to private.syms (Ján Tomko) - Use qemuOpenFile in qemu_driver.c (Martin Kletzander) - Make qemuOpenFile aware of per-VM DAC seclabel. (Martin Kletzander) - domain_event: Resolve memory leak found by Valgrind (John Ferlan) - lxc: Resolve Coverity warning (John Ferlan) - qemu: Take error path if acquiring of job fails in qemuDomainSaveInternal (Peter Krempa) - build: fix make rpm failure (Laine Stump) - virsh: fix change-media bug on disk block type (Guannan Ren) - tests: Free test at the end of GetDeviceAliases JSON test (Jiri Denemark) - vmware: Fix bogus CPU arch copy (Jiri Denemark) - qemu: Shorten SCSI hostdev alias to avoid QEMU failure (Viktor Mihajlovski) - Add virtio-scsi to fallback models of scsi controller (Martin Kletzander) - qemuhotplugtest: Resolve some memleaks (Michal Privoznik) - qemuDomainDetachChrDevice: Don't leak @charAlias (Michal Privoznik) - Fix impl of virDomainCreateWithFlags remote client helper (Daniel P. Berrange) - cgroup: reuse buffer for getline (Ján Tomko) - Create directory for lease files if it's missing (Guido Günther) - rbd: Do not free the secret if it is not set (Wido den Hollander) - Make logical pools independent on target path (Martin Kletzander) - qemu: add macvlan delete to qemuDomainAttachNetDevice cleanup (Matthew Rosato) - qemuBuildChrDeviceCommandLine: Don't leak devstr (Michal Privoznik) - conf: reject pci-root controllers with non-zero indexes (Ján Tomko) - nodeinfo: Don't fail on non-contiguous NUMA topologies (hejia hejia) - util: make virSetUIDGID async-signal-safe (Eric Blake) - qemu_hostdev: Resolve Coverity issue (John Ferlan) - storage_backend: Resolve Coverity issue (John Ferlan) - virsh-nodedev: Resolve Coverity issues (John Ferlan) - virsh-interface: Resolve Coverity issues (John Ferlan) - virsh-domain-monitor: Resolve Coverity issues (John Ferlan) - testutils: Resolve Coverity issues (John Ferlan) - hellolibvirt: Resolve Coverity issues (John Ferlan) - storage: return -1 when fs pool can't be mounted (Ján Tomko) - qemu: fix double free in qemuMigrationPrepareDirect (Ján Tomko) - Properly detect VMDK with internal version 2 (Martin Kletzander) - Resolve Coverity complaints in tests/securityselinuxlabeltest.c (John Ferlan) - Paused domain should remain paused after migration (Jiri Denemark) - conf: don't check hyperv spinlock retries if disabled (Ján Tomko) - Fix NULL dereference caused by ACL filtering of domains (Jiri Denemark) - Unlock the storage volume object after looking it up (Ján Tomko) - libxl: fix deadlock in libxlReconnectDomain (Marek Marczykowski-Górecki) - LXC: fix memory leak when userns configuration is incorrect (Gao feng) - virNetDevBandwidthUnplug: Don't leak @cmd (Michal Privoznik) - virCgroupNewPartition: Don't leak @newpath (Michal Privoznik) - qemuNodeDeviceDetachFlags: Avoid use of uninitialized variables (Michal Privoznik) - qemu: fix return value of qemuDomainBlockPivot on errors (Ján Tomko) Improvements: - tests: consistently use virFilePrintf (Eric Blake) - Rename VIR_DOMAIN_PAUSED_GUEST_PANICKED to VIR_DOMAIN_PAUSED_CRASHED (Daniel P. Berrange) - Remove VIR_DOMAIN_SHUTDOWN_CRASHED from public API (Daniel P. Berrange) - spec: Cat test-suite.log if make check fails (Jiri Denemark) - build: avoid uninitialized use warning (Eric Blake) - Set default partition in libvirtd instead of libvirt_lxc (Daniel P. Berrange) - virStateDriver - Separate AutoStart from Initialize (John Ferlan) - Separate out StateAutoStart from StateInitialize (John Ferlan) - Remove redundant free in virNetworkDNSHostDefParseXML (Ján Tomko) - Remove double space in error messages (Ján Tomko) - Fix virsh snapshot-list error reporting (Jim Fehlig) - Skip detecting placement if controller is disabled (Daniel P. Berrange) - Add 'controllers' arg to virCgroupNewDetect (Daniel P. Berrange) - Fix detection of 'emulator' cgroup (Daniel P. Berrange) - Make virCgroupIsValidMachine static (Daniel P. Berrange) - Introduce a more convenient virCgroupNewDetectMachine (Daniel P. Berrange) - Add inputpool to storagevolxml2argvtest (Ján Tomko) - Move volume XMLs out of storagevolxml2argvdata (Ján Tomko) - Move pool XML out of storagevolxml2argvdata (Ján Tomko) - Use separate macros for failure/success in vol-to-argv test (Ján Tomko) - tests: PCI controller checks (Ján Tomko) - Don't overwrite errors in qemuTranslateDiskSourcePool (Ján Tomko) - Protection against doing bad stuff to the root group (Daniel P. Berrange) - Convert LXC driver to use virCgroupNewMachine (Daniel P. Berrange) - Convert QEMU driver to use virCgroupNewMachine (Daniel P. Berrange) - New cgroups API for atomically creating machine cgroups (Daniel P. Berrange) - Add a colon after 'internal error' (Ján Tomko) - Expose ownership ID parsing (Martin Kletzander) - qemu: set/validate slot/connection type when assigning slots for PCI devices (Laine Stump) - qemu: make QEMU_PCI_ADDRESS_(SLOT|FUNCTION)_LAST less misleading (Laine Stump) - qemu: only check for PIIX3-specific device addrs on pc-* machinetypes (Laine Stump) - qemu: turn qemuDomainPCIAddressBus into a struct (Laine Stump) - valgrind.supp: Add more valgrind suppression paths (John Ferlan) - Create + setup cgroups atomically for LXC process (Daniel P. Berrange) - Create + setup cgroups atomically for QEMU process (Daniel P. Berrange) - Remove obsolete cgroups creation apis (Daniel P. Berrange) - Auto-detect existing cgroup placement (Daniel P. Berrange) - Add API for checking if a cgroup is valid for a domain (Daniel P. Berrange) - Add a virCgroupNewDetect API for finding cgroup placement (Daniel P. Berrange) - Add logic for handling systemd-machined non-existance (Daniel P. Berrange) - Fix handling of DBus errors emitted by the bus itself (Daniel P. Berrange) - storage: Add connection for autostart storage pool (John Ferlan) - Adjust 'ceph' authentication secret usage for rbd pool. (John Ferlan) - storage: Support "chap" authentication for iscsi pool (John Ferlan) - qemu_common: Create qemuBuildVolumeString() to process storage pool (John Ferlan) - qemu: Create a common qemuGetSecretString (John Ferlan) - qemu: Add source pool auth info to virDomainDiskDef for iSCSI (John Ferlan) - bridge driver: use more general function names (Roman Bogorodskiy) - Add virDBusMessage(Encode,Decode) stubs (Roman Bogorodskiy) - qemu: Translate the volume type disk source before cgroup setting (Osier Yang) - conf: Ignore the volume type disk if its mode is "direct" (Osier Yang) - qemu: Translate the iscsi pool/volume disk source (John Ferlan) - conf: Introduce virDomainDiskSourceIsBlockType (John Ferlan) - conf: Introduce new XML tag "mode" for disk source (John Ferlan) - storage_iscsi: Reflect the default target port (John Ferlan) - bridge driver: s/network_driver/virNetworkDriverState/ (Roman Bogorodskiy) - Convert remainder of cgroups code to report errors (Daniel P. Berrange) - Convert the virCgroupKill* APIs to report errors (Daniel P. Berrange) - Report full errors from virCgroupNew* (Daniel P. Berrange) - Add helpers for dealing with system errors (Daniel P. Berrange) - Add API for calling systemd-machined's DBus API (Daniel P. Berrange) - Introduce virDBusCallMethod & virDBusMessageRead methods (Daniel P. Berrange) - cpu: Let explicit features override model features (Jiri Denemark) - cpu: Store arch in virCPUData (Jiri Denemark) - Replace union cpuData with virCPUData (Jiri Denemark) - cpu_x86: Use x86-specific CPU data structure (Jiri Denemark) - LXC: Set default driver for image backed filesystems (Daniel P. Berrange) - LXC: Fix some error reporting in filesystem setup (Daniel P. Berrange) - qemu: Unplug devices that disappeared when libvirtd was down (Jiri Denemark) - qemu: Introduce qemuMonitorGetDeviceAliases (Jiri Denemark) - conf: Make error reporting in virDomainDefFindDevice optional (Jiri Denemark) - util: Non-existent string array does not contain any string (Jiri Denemark) - Change s/i/iv/ in test code to avoid syntax-check (Daniel P. Berrange) - Allow test cases to be run selectively (Daniel P. Berrange) - maint: update to latest gnulib (Eric Blake) - autogen: Handle case when libvirt's submodule (Michal Privoznik) - security_dac: compute supplemental groups before fork (Eric Blake) - security: framework for driver PreFork handler (Eric Blake) - qemu: Emit VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED events (Jiri Denemark) - qemu: Remove devices only after DEVICE_DELETED event (Jiri Denemark) - qemu: Add support for DEVICE_DELETED event (Jiri Denemark) - Add virDomainDefFindDevice for looking up a device by its alias (Jiri Denemark) - Clarify virDomainDetachDeviceFlags documentation (Jiri Denemark) - examples: Handle VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED event (Jiri Denemark) - Add VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED event (Jiri Denemark) - qemu: Separate char device removal into a standalone function (Jiri Denemark) - qemu: Set cpuset.cpus for domain process (Osier Yang) - caps: Add helpers to convert NUMA nodes to corresponding CPUs (Peter Krempa) - Introduce lxcDomObjFromDomain (Michal Privoznik) - Remove lxcDriverLock from almost everywhere (Michal Privoznik) - lxc: Make activeUsbHostdevs use locks (Michal Privoznik) - Stop accessing driver->caps directly in LXC driver (Michal Privoznik) - lxc: switch to virCloseCallbacks API (Michal Privoznik) - Introduce annotations for virLXCDriverPtr fields (Michal Privoznik) - lxc: Use atomic ops for driver->nactive (Michal Privoznik) - Introduce a virLXCDriverConfigPtr object (Michal Privoznik) - virLXCDriver: Drop unused @cgroup (Michal Privoznik) - qemu: Move close callbacks handling into util/virclosecallbacks.c (Michal Privoznik) - virAsprintf: correctly check return value (Ján Tomko) - Merge virCommandPreserveFD / virCommandTransferFD (Daniel P. Berrange) - Enable FD passing when starting guests with virsh (Daniel P. Berrange) - LXC: Wire up the virDomainCreate{XML}WithFiles methods (Daniel P. Berrange) - Introduce remote protocol support for virDomainCreate{XML}WithFiles (Daniel P. Berrange) - maint: Make ctags work out of the box (Jiri Denemark) - esx: Support for disk-only and quiescing snapshots. (Geoff Hickey) - libxl: implement virDomainGetNumaParameters (Dario Faggioli) - libxl: advertise the support for VIR_TYPED_PARAM_STRING (Dario Faggioli) - lxc_container: Don't call virGetGroupList during exec (Michal Privoznik) - qemuDomainGetSchedulerType: Prefer qemuDomObjFromDomain (Michal Privoznik) - virSecurityManagerGenLabel: Skip seclabels without model (Michal Privoznik) - lxcCapsInit: Allocate primary security driver unconditionally (Michal Privoznik) - qemu: Separate host device removal into a standalone function (Jiri Denemark) - qemu: Separate net device removal into a standalone function (Jiri Denemark) - qemu: Separate controller removal into a standalone function (Jiri Denemark) - qemu: Separate disk device removal into a standalone function (Jiri Denemark) - qemu: Add qemuDomainReleaseDeviceAddress to remove any address (Jiri Denemark) - build: avoid compiler warning on shadowed name (Eric Blake) - LXC: Change the owner of live attached host devices (Gao feng) - LXC: Change the owner of host devices to the root of container (Gao feng) - LXC: Create host devices for container on host side (Gao feng) - LXC: Change the owner of live attached disk device (Gao feng) - LXC: Move virLXCControllerChown to lxc_container.c (Gao feng) - LXC: controller: change the owner of disk to the root of container (Gao feng) - LXC: Setup disks for container on host side (Gao feng) - Allow balloon driver collection to be adjusted dynamically (John Ferlan) - Implement the virDomainSetMemoryStatsPeriod for QEMU driver (John Ferlan) - Specify remote protocol for virDomainSetMemoryStatsPeriod (John Ferlan) - Add capability to fetch balloon stats (John Ferlan) - Determine whether to start balloon memory stats gathering. (John Ferlan) - Add 'period' for Memballoon statistics gathering capability (John Ferlan) - qemuhotplugtest: Introduce test for chardev hotplug (Michal Privoznik) - qemu: Implement chardev hotplug on live level (Michal Privoznik) - qemu: Implement chardev hotplug on config level (Michal Privoznik) - domain_conf: Auto fill chardev port (Michal Privoznik) - cpu: Allow fine tuning of "host-model" cpu (Peter Krempa) - cpu: Clean up code style (Peter Krempa) - cpu: Add virCPUDefUpdateFeature() (Peter Krempa) - conf: Clean up error reporting in cpu definition parsing (Peter Krempa) - storage_conf: Merge AuthChap and AuthCephx into AuthSecret (John Ferlan) - storage_conf: Move username processing into common function (John Ferlan) - storage_pool: Rework chap XML to mimic ceph (John Ferlan) - storage_conf: Move auth processing into virStoragePoolDefParseAuth (John Ferlan) - storage_conf: Introduce virStoragePoolAuthSecretPtr (John Ferlan) - storage_conf: Adjust virStoragePoolAuthType enum (John Ferlan) - Add qemuMonitorJSONSetObjectProperty() method for QMP qom-set command (John Ferlan) - Add qemuMonitorJSONGetObjectProperty() method for QMP qom-get command (John Ferlan) - Add qemuMonitorJSONGetObjectListPaths() method for QMP qom-list command (John Ferlan) - pci: make virPCIDeviceReset more autonomous (Laine Stump) - pci: reorder static functions (Laine Stump) - python: return dictionary without value in case of no blockjob (Guannan Ren) - Change domain controller index type to unsigned (Jincheng Miao) - Add a couple of debug statements to LXC driver (Daniel P. Berrange) - qemu: Introduce qemuBuildChrDeviceStr (Michal Privoznik) - qemu_command: Honour chardev alias assignment with a function (Michal Privoznik) - qemu_monitor: Introduce qemuMonitorDetachCharDev (Michal Privoznik) - qemu_monitor: Introduce qemuMonitorAttachCharDev (Michal Privoznik) - qemu_monitor_json: Move InetSocketAddress build to a separate function (Michal Privoznik) - domain_conf: Introduce chardev hotplug helpers (Michal Privoznik) - remote: Improve libssh2 password authentication (Peter Krempa) - libssh2: Improve password based authentication (Peter Krempa) - virAuth: Don't require virConnectPtr to retrieve authentication creds (Peter Krempa) - util: add virGetGroupList (Eric Blake) - util: improve user lookup helper (Eric Blake) - maint: update to latest gnulib (Eric Blake) - qemu: Fix hot (un-)plug error codes and messages (Michal Privoznik) - conf: Rework virDomainDeviceDefParse (Michal Privoznik) - conf: Extend device types handled by virDomainDeviceDefParse (Michal Privoznik) - LXC: remove some incorrect setting ATTRIBUTE_UNUSED (Gao feng) - qemu: Slightly increase memory limit (Jiri Denemark) - util: add rebase fix that was accidentally omitted from previous patch (Laine Stump) - util: use VIR_(APPEND|DELETE)_ELEMENT for pci/usb device lists (Laine Stump) - Prevent use of 'int' data type & 'ii', 'jj', 'kk' var names for loops (Daniel P. Berrange) - Convert 'int i' to 'size_t i' in examples/ files (Daniel P. Berrange) - Convert 'int i' to 'size_t i' in python/ files (Daniel P. Berrange) - Convert 'int i' to 'size_t i' in src/ files (Daniel P. Berrange) - Convert 'int i' to 'size_t i' in src/cpu/ files (Daniel P. Berrange) - Convert 'int i' to 'size_t i' in src/hyperv/ files (Daniel P. Berrange) - Convert 'int i' to 'size_t i' in src/interface/ files (Daniel P. Berrange) - Convert 'int i' to 'size_t i' in src/network/ files (Daniel P. Berrange) - Convert 'int i' to 'size_t i' in src/libxl/ files (Daniel P. Berrange) - Convert 'int i' to 'size_t i' in src/locking/ files (Daniel P. Berrange) - Convert 'int i' to 'size_t i' in src/lxc/ files (Daniel P. Berrange) - Convert 'int i' to 'size_t i' in src/node_device/ files (Daniel P. Berrange) - Convert 'int i' to 'size_t i' in src/nwfilter/ files (Daniel P. Berrange) - Convert 'int i' to 'size_t i' in src/openvz/ files (Daniel P. Berrange) - Convert 'int i' to 'size_t i' in src/parallels/ files (Daniel P. Berrange) - Convert 'int i' to 'size_t i' in src/phyp/ files (Daniel P. Berrange) - Convert 'int i' to 'size_t i' in src/qemu files (Daniel P. Berrange) - Convert 'int i' to 'size_t i' in src/remote/ files (Daniel P. Berrange) - Convert 'int i' to 'size_t i' in src/rpc/ files (Daniel P. Berrange) - Convert 'int i' to 'size_t i' in src/secret/ files (Daniel P. Berrange) - Convert 'int i' to 'size_t i' in src/security files (Daniel P. Berrange) - Convert 'int i' to 'size_t i' in src/test/ files (Daniel P. Berrange) - Convert 'int i' to 'size_t i' in src/uml/ files (Daniel P. Berrange) - Convert 'int i' to 'size_t i' in src/vbox/ files (Daniel P. Berrange) - Convert 'int i' to 'size_t i' in src/storage/ files (Daniel P. Berrange) - Convert 'int i' to 'size_t i' in src/{esx,vmx,vmware} files (Daniel P. Berrange) - Convert 'int i' to 'size_t i' in src/{xen,xenapi,xenxs} files (Daniel P. Berrange) - Convert 'int i' to 'size_t i' in tools/ files (Daniel P. Berrange) - Convert 'int i' to 'size_t i' in tests/ files (Daniel P. Berrange) - Convert 'int i' to 'size_t i' in src/util/ files (Daniel P. Berrange) - Convert 'int i' to 'size_t i' in src/conf/ files (Daniel P. Berrange) - Convert 'int i' to 'size_t i' in daemon/ files (Daniel P. Berrange) - Adapt to VIR_ALLOC and virAsprintf in tools/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in tests/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in src/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in src/xenxs/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in src/xenapi/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in src/xen/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in src/vmx/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in src/vmware/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in src/vbox/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in src/util/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in src/uml/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in src/test/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in src/storage/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in src/security/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in src/secret/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in src/rpc/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in src/remote/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in src/qemu/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in src/phyp/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in src/parallels/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in src/openvz/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in src/nwfilter/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in src/network/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in src/node_device/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in src/lxc/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in src/locking/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in src/libxl/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in src/interface/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in src/hyperv/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in src/esx/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in src/cpu/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in src/conf/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in src/access/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in daemon/* (Michal Privoznik) - Adapt to VIR_ALLOC and virAsprintf in docs/ (Michal Privoznik) - Introduce OOM reporting to virAsprintf (Michal Privoznik) - viralloc: Report OOM error on failure (Michal Privoznik) - build: honor autogen.sh --no-git (Eric Blake) - LXC: hostdev: create parent directory for hostdev (Gao feng) - LXC: hostdev: introduce lxcContainerSetupHostdevCapsMakePath (Gao feng) - LXC: Create /dev/tty within a container (Richard Weinberger) - scsi: Fix construction of sysfs device path (Viktor Mihajlovski) - selinux: Always generate imagelabel (Peter Krempa) - selinux: Cleanup coding style (Peter Krempa) - qemu: Set RLIMIT_MEMLOCK when memoryBacking/locked is used (Jiri Denemark) - qemu: Use qemuDomainMemoryLimit when computing memory for VFIO (Jiri Denemark) - qemu: Move memory limit computation to a reusable function (Jiri Denemark) - Don't spam logs with "port 0 must be in range" errors (Jiri Denemark) - qemu: Release correct websocket port (Jiri Denemark) - conf: virDomainObjListRemoveLocked function (Marek Marczykowski-Górecki) - maint: update to latest gnulib (Eric Blake) - Extend the ACL test case to validate filter rule checks (Daniel P. Berrange) - Add access control filtering of interface objects (Daniel P. Berrange) - Add access control filtering of nwfilter objects (Daniel P. Berrange) - Add access control filtering of secret objects (Daniel P. Berrange) - Add access control filtering of storage objects (Daniel P. Berrange) - Add access control filtering of node device objects (Daniel P. Berrange) - Add access control filtering of network objects (Daniel P. Berrange) - Change signature of ACL filter functions (Daniel P. Berrange) - Add access control filtering of domain objects (Daniel P. Berrange) - qemu: Allow seamless migration for domains with multiple graphics (Martin Kletzander) - qemu: Don't miss errors when changing graphics passwords (Martin Kletzander) - LXC: blkio: allow to setup weight_device (Gao feng) - qemu: Implement 'oncrash' coredump events when guest panicked (Chen Fan) - qemu: Implement 'oncrash' events when guest panicked (Chen Fan) - qemu: expose qemuProcessShutdownOrReboot() (Chen Fan) - qemu: refactor processWatchdogEvent (Chen Fan) - libvirt: Define domain crash event types (Chen Fan) - Add some misc debugging to LXC startup (Daniel P. Berrange) - Ignore failure to mount SELinux filesystem in container (Daniel P. Berrange) - LXC: fuse: Change files owner to the root user of container (Gao feng) - LXC: controller: change the owner of /dev/pts and ptmx to the root of container (Gao feng) - LXC: controller: change the owner of devices created on host (Gao feng) - LXC: controller: change the owner of /dev to the root user of container (Gao feng) - LXC: controller: change the owner of tty devices to the root user of container (Gao feng) - LXC: Creating devices for container on host side (Gao feng) - LXC: introduce virLXCControllerSetupUserns and lxcContainerSetID (Gao feng) - LXC: sort the uidmap/gidmap of domain (Gao feng) - LXC: enable user namespace only when user set the uidmap (Gao feng) - LXC: Introduce New XML element for user namespace (Gao feng) - qemu: Improve info message and remove a variable in qemuDomainManagedSave (Peter Krempa) - libxl: implement per NUMA node free memory reporting (Dario Faggioli) - build: configure must not affect tarball contents (Eric Blake) - Drop iptablesContext (Roman Bogorodskiy) - qemu: indentation fix (Ján Tomko) - qemu: Implement CPUs check against machine type's cpu-max (Michal Novotny) Cleanups: - python: Drop TODO (Cole Robinson) - maint: split long lines in Makefiles (Eric Blake) - tests: split long lines (Eric Blake) - qemu: Cleanup coding style nits in qemu_cgroup.c (Peter Krempa) So thanks everybody for the contributions to this large release, be it with bug reports code, ideas, documentation or localizations ! Enjoy ! Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] [v1.0.5-maint PATCH] lxc: correctly backport /dev/tty fix
by Eric Blake 29 Jul '13

29 Jul '13

https://bugzilla.redhat.com/show_bug.cgi?id=982317 maint-only patch; reported by Geert Jansen Commit 17cdc298 tried to backport upstream 90a0c6d, but in resolving conflicts, failed to account that upstream commit e1d32bb refactored code to leave off a leading /dev. * src/lxc/lxc_container.c (lxcContainerPopulateDevices): Use correct device name. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- src/lxc/lxc_container.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index 8497c10..972486b 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -839,7 +839,7 @@ static int lxcContainerPopulateDevices(char **ttyPaths, size_t nttyPaths) { LXC_DEV_MAJ_MEMORY, LXC_DEV_MIN_FULL, 0666, "/dev/full" }, { LXC_DEV_MAJ_MEMORY, LXC_DEV_MIN_RANDOM, 0666, "/dev/random" }, { LXC_DEV_MAJ_MEMORY, LXC_DEV_MIN_URANDOM, 0666, "/dev/urandom" }, - { LXC_DEV_MAJ_TTY, LXC_DEV_MIN_TTY, 0666, "/tty" }, + { LXC_DEV_MAJ_TTY, LXC_DEV_MIN_TTY, 0666, "/dev/tty" }, }; const struct { const char *src; -- 1.8.3.1

2 2

[libvirt] Linking fails on FreeBSD
by Roman Bogorodskiy 29 Jul '13

29 Jul '13

Hi, Linking fails on FreeBSD: CCLD libvirt.la /usr/bin/ld: ./.libs/libvirt_util.a(libvirt_util_la-vircgroup.o): relocation R_X86_64_PC32 against `virCgroupPartitionEscape' can not be used when making a shared object; recompile with -fPIC /usr/bin/ld: final link failed: Bad value Following the suggestion and re-compiling with -fPIC doesn't help. Anybody has an idea how to fix that? Roman Bogorodskiy

5 21

[libvirt] ANNOUNCE: Perl binding Sys-Virt release 1.1.0
by Daniel P. Berrange 29 Jul '13

29 Jul '13

I am pleased to announce that release 1.1.0 of Sys-Virt, the libvirt Perl API binding is now available for download: http://search.cpan.org/CPAN/authors/id/D/DA/DANBERR/Sys-Virt-1.1.0.tar.gz Changed in this release: - Add support for v3 of migration APIs - Add all new constants in libvirt 1.1.0 - Fix handling of sparse typed parameters - Fix misc typos in docs Further information, including online API documentation & previous release archives, is available from the CPAN home page http://search.cpan.org/dist/Sys-Virt/ Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

1 0

[libvirt] [PATCH v2] Fix dbus message reading code on big endian hosts
by Daniel P. Berrange 29 Jul '13

29 Jul '13

From: "Daniel P. Berrange" <berrange(a)redhat.com> The way we were casting small (<32bit) integers was broken on big endian hosts, causing stack smashing. This was detected in the test suite either by test failures due to incorrect results, or by libc/gcc abort'ing with its stack canary triggered. In v2: - Added missing change to virdbus.c Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- src/util/virdbus.c | 6 +++--- tests/virdbustest.c | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/util/virdbus.c b/src/util/virdbus.c index 4ce6c46..33f3379 100644 --- a/src/util/virdbus.c +++ b/src/util/virdbus.c @@ -738,7 +738,7 @@ virDBusMessageIterDecode(DBusMessageIter *rootiter, switch (*t) { case DBUS_TYPE_BYTE: - GET_NEXT_VAL(unsigned char, int, "%d"); + GET_NEXT_VAL(unsigned char, unsigned char, "%d"); break; case DBUS_TYPE_BOOLEAN: @@ -746,11 +746,11 @@ virDBusMessageIterDecode(DBusMessageIter *rootiter, break; case DBUS_TYPE_INT16: - GET_NEXT_VAL(dbus_int16_t, int, "%d"); + GET_NEXT_VAL(dbus_int16_t, short, "%d"); break; case DBUS_TYPE_UINT16: - GET_NEXT_VAL(dbus_uint16_t, unsigned int, "%d"); + GET_NEXT_VAL(dbus_uint16_t, short unsigned, "%d"); break; case DBUS_TYPE_INT32: diff --git a/tests/virdbustest.c b/tests/virdbustest.c index fb241ee..61de937 100644 --- a/tests/virdbustest.c +++ b/tests/virdbustest.c @@ -54,8 +54,8 @@ static int testMessageSimple(const void *args ATTRIBUTE_UNUSED) int ret = -1; unsigned char in_byte = 200, out_byte = 0; int in_bool = true, out_bool = false; - int in_int16 = 12000, out_int16 = 0; - unsigned int in_uint16 = 32000, out_uint16 = 0; + short in_int16 = 0xfefe, out_int16 = 0; + unsigned short in_uint16 = 32000, out_uint16 = 0; int in_int32 = 100000000, out_int32 = 0; unsigned int in_uint32 = 200000000, out_uint32 = 0; long long in_int64 = 1000000000000, out_int64 = 0; @@ -232,8 +232,8 @@ static int testMessageStruct(const void *args ATTRIBUTE_UNUSED) int ret = -1; unsigned char in_byte = 200, out_byte = 0; int in_bool = true, out_bool = false; - int in_int16 = 12000, out_int16 = 0; - unsigned int in_uint16 = 32000, out_uint16 = 0; + short in_int16 = 12000, out_int16 = 0; + unsigned short in_uint16 = 32000, out_uint16 = 0; int in_int32 = 100000000, out_int32 = 0; unsigned int in_uint32 = 200000000, out_uint32 = 0; long long in_int64 = 1000000000000, out_int64 = 0; -- 1.8.1.4

3 4

[libvirt] [PATCH] Fix dbus message reading code on big endian hosts
by Daniel P. Berrange 29 Jul '13

29 Jul '13

From: "Daniel P. Berrange" <berrange(a)redhat.com> The way we were casting small (<32bit) integers was broken on big endian hosts, causing stack smashing. This was detected in the test suite either by test failures due to incorrect results, or by libc/gcc abort'ing with its stack canary triggered. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- tests/virdbustest.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/virdbustest.c b/tests/virdbustest.c index fb241ee..61de937 100644 --- a/tests/virdbustest.c +++ b/tests/virdbustest.c @@ -54,8 +54,8 @@ static int testMessageSimple(const void *args ATTRIBUTE_UNUSED) int ret = -1; unsigned char in_byte = 200, out_byte = 0; int in_bool = true, out_bool = false; - int in_int16 = 12000, out_int16 = 0; - unsigned int in_uint16 = 32000, out_uint16 = 0; + short in_int16 = 0xfefe, out_int16 = 0; + unsigned short in_uint16 = 32000, out_uint16 = 0; int in_int32 = 100000000, out_int32 = 0; unsigned int in_uint32 = 200000000, out_uint32 = 0; long long in_int64 = 1000000000000, out_int64 = 0; @@ -232,8 +232,8 @@ static int testMessageStruct(const void *args ATTRIBUTE_UNUSED) int ret = -1; unsigned char in_byte = 200, out_byte = 0; int in_bool = true, out_bool = false; - int in_int16 = 12000, out_int16 = 0; - unsigned int in_uint16 = 32000, out_uint16 = 0; + short in_int16 = 12000, out_int16 = 0; + unsigned short in_uint16 = 32000, out_uint16 = 0; int in_int32 = 100000000, out_int32 = 0; unsigned int in_uint32 = 200000000, out_uint32 = 0; long long in_int64 = 1000000000000, out_int64 = 0; -- 1.8.1.4

1 1

[libvirt] [PATCH] spec: Cat test-suite.log if make check fails
by Jiri Denemark 29 Jul '13

29 Jul '13

Current automake enables parallel test by default, which means test details are only logged in test-suite.log and not printed to stderr. This patch makes test failures directly visible in RPM build logs even when parallel tests are turned on. --- libvirt.spec.in | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 81101e8..a3a831f 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1482,7 +1482,11 @@ do printf '#!/bin/sh\nexit 0\n' > $i chmod +x $i done -make check +if ! make check VIR_TEST_DEBUG=1 +then + cat test-suite.log || true + exit 1 +fi %if %{with_libvirtd} %pre daemon -- 1.8.3.2

2 2