- Devel - libvirt List Archives

[Libvir] more missing #include's of "config.h"
by Jim Meyering 06 Dec '07

06 Dec '07

This is the last of the non-generated files requiring #include "config.h": Include "config.h" in remaining non-generated files. * docs/examples/info1.c: Likewise. * docs/examples/suspend.c: Likewise. * proxy/libvirt_proxy.c: Likewise. * python/libvir.c: Likewise. * python/types.c: Likewise. * src/event.c: Likewise. * src/xm_internal.c: Likewise. * tests/reconnect.c: Likewise. * tests/testutils.c: Likewise. Signed-off-by: Jim Meyering <meyering(a)redhat.com> --- docs/examples/info1.c | 2 ++ docs/examples/suspend.c | 2 ++ proxy/libvirt_proxy.c | 4 +++- python/libvir.c | 4 +++- python/types.c | 4 +++- src/event.c | 1 + src/xm_internal.c | 2 ++ tests/reconnect.c | 2 ++ tests/testutils.c | 2 ++ 9 files changed, 20 insertions(+), 3 deletions(-) diff --git a/docs/examples/info1.c b/docs/examples/info1.c index f17bde8..53a9844 100644 --- a/docs/examples/info1.c +++ b/docs/examples/info1.c @@ -9,6 +9,8 @@ * copy: see Copyright for the status of this software. */ +#include "config.h" + #include <stdio.h> #include <libvirt/libvirt.h> diff --git a/docs/examples/suspend.c b/docs/examples/suspend.c index 80e4da7..5bc47a4 100644 --- a/docs/examples/suspend.c +++ b/docs/examples/suspend.c @@ -11,6 +11,8 @@ * copy: see Copyright for the status of this software. */ +#include "config.h" + #include <stdlib.h> #include <stdio.h> #include <libvirt/libvirt.h> diff --git a/proxy/libvirt_proxy.c b/proxy/libvirt_proxy.c index d7deb44..152df56 100644 --- a/proxy/libvirt_proxy.c +++ b/proxy/libvirt_proxy.c @@ -2,13 +2,15 @@ * proxy_svr.c: root suid proxy server for Xen access to APIs with no * side effects from unauthenticated clients. * - * Copyright (C) 2006 Red Hat, Inc. + * Copyright (C) 2006, 2007 Red Hat, Inc. * * See COPYING.LIB for the License of this software * * Daniel Veillard <veillard(a)redhat.com> */ +#include "config.h" + #include <stdio.h> #include <stdlib.h> #include <unistd.h> diff --git a/python/libvir.c b/python/libvir.c index bab34b3..a025afd 100644 --- a/python/libvir.c +++ b/python/libvir.c @@ -4,11 +4,13 @@ * entry points where an automatically generated stub is * unpractical * - * Copyright (C) 2005 Red Hat, Inc. + * Copyright (C) 2005, 2007 Red Hat, Inc. * * Daniel Veillard <veillard(a)redhat.com> */ +#include "config.h" + #include <Python.h> #include "libvirt/libvirt.h" #include "libvirt/virterror.h" diff --git a/python/types.c b/python/types.c index cc0f2b1..146bb24 100644 --- a/python/types.c +++ b/python/types.c @@ -2,11 +2,13 @@ * types.c: converter functions between the internal representation * and the Python objects * - * Copyright (C) 2005 Red Hat, Inc. + * Copyright (C) 2005, 2007 Red Hat, Inc. * * Daniel Veillard <veillard(a)redhat.com> */ +#include "config.h" + #include "libvirt_wrap.h" PyObject * diff --git a/src/event.c b/src/event.c index 2fe9a26..7dcbf32 100644 --- a/src/event.c +++ b/src/event.c @@ -21,6 +21,7 @@ * Author: Daniel P. Berrange <berrange(a)redhat.com> */ +#include "config.h" #include "event.h" diff --git a/src/xm_internal.c b/src/xm_internal.c index 43263d7..07abbb1 100644 --- a/src/xm_internal.c +++ b/src/xm_internal.c @@ -23,6 +23,8 @@ */ #ifdef WITH_XEN +#include "config.h" + #include <dirent.h> #include <time.h> #include <sys/stat.h> diff --git a/tests/reconnect.c b/tests/reconnect.c index 246e3bb..d94f5c7 100644 --- a/tests/reconnect.c +++ b/tests/reconnect.c @@ -1,3 +1,5 @@ +#include "config.h" + #include <stdio.h> #include <stdlib.h> #include "libvirt/libvirt.h" diff --git a/tests/testutils.c b/tests/testutils.c index 6121785..1141edb 100644 --- a/tests/testutils.c +++ b/tests/testutils.c @@ -10,6 +10,8 @@ * $Id$ */ +#include "config.h" + #include <stdio.h> #include <stdlib.h> #include <sys/time.h> -- 1.5.3.7.1006.g8c6a6

3 5

[Libvir] schedifo for qemu guests.
by Fabian Deutsch 06 Dec '07

06 Dec '07

Hey. I'm using Fedora 8 and the included libvirt and virt-manager packages. I just noticed that it is not possible so set scheddunling for qemu guests. Could this be implemented by setting the guests nice value, so instances are handled different by Linux's prcoess scheduler? - fabian

3 3

[Libvir] [PATCH] qemud/qemud.c (qemudInitPaths): Remove unused code.
by Jim Meyering 06 Dec '07

06 Dec '07

Here, "base" is set, gets memory allocated for it, and is written to, then freed, but it is never used. diff --git a/qemud/qemud.c b/qemud/qemud.c index f88ed42..6b515d9 100644 --- a/qemud/qemud.c +++ b/qemud/qemud.c @@ -644,10 +644,8 @@ static int qemudInitPaths(struct qemud_server *server, char *sockname, char *roSockname, int maxlen) { - char *base = 0; uid_t uid = geteuid(); - if (!uid) { if (snprintf (sockname, maxlen, "%s/run/libvirt/libvirt-sock", LOCAL_STATE_DIR) >= maxlen) @@ -678,15 +676,8 @@ static int qemudInitPaths(struct qemud_server *server, if (snprintf(server->logDir, PATH_MAX, "%s/.libvirt/log", pw->pw_dir) >= PATH_MAX) goto snprintf_error; - if (asprintf (&base, "%s/.libvirt", pw->pw_dir) == -1) { - qemudLog (QEMUD_ERR, "out of memory in asprintf"); - return -1; - } - } /* !remote */ - if (base) free (base); - return 0; snprintf_error: -- 1.5.3.7.949.g2221a6

2 2

[Libvir] [PATCH] Virsh prompt
by Richard W.M. Jones 06 Dec '07

06 Dec '07

The virsh prompt seems to depend on your UID, rather than whether the connection is really readonly or not. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

3 2

[Libvir] [PATCH] Add --without-libvirtd option
by Richard W.M. Jones 06 Dec '07

06 Dec '07

This patch adds a configure option --without-libvirtd which disables building of libvirtd. It doesn't attempt any type of auto-detection and the default is still to build libvirtd. I had to move stuff around in the qemud/Makefile.am file in order to bring the libvirtd-dependent parts together, but I didn't change any of it. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

3 2

[Libvir] Use of getpass
by Richard W.M. Jones 06 Dec '07

06 Dec '07

We recently added a call to getpass(3) function. Needless to say this doesn't exist on Windows. More seriously the man-page for getpass on Linux has strong exhortations not to use the function. NAME getpass - get a password SYNOPSIS #include <unistd.h> char *getpass( const char * prompt ); DESCRIPTION This function is obsolete. Do not use it. The getpass() function opens /dev/tty (the controlling terminal of the process), outputs the string prompt, turns off echoing, reads one line (the "password"), restores the terminal state and closes /dev/tty again. [...] CONFORMING TO Present in SUSv2, but marked LEGACY. Removed in POSIX.1-2001. Should we remove it? Replace it? Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

3 4

[Libvir] moving "aux" files into a subdir
by Jim Meyering 06 Dec '07

06 Dec '07

I noticed that gnulib-tool had deposited a file named link-warning.h into the top-level directory. How odd, I thought. This doesn't affect other projects because most of them define what autoconf calls the "AUX" directory, with a line like this in configure.in or configure.ac: AC_CONFIG_AUX_DIR(build-aux) If you don't define that, it defaults to the top level directory, and that's where files pulled in by gettextize like these are deposited: config.guess compile libtool ltconfig ltmain.sh config.sub config.rpath mkinstalldirs Rather than committing link-warning.h in the top-level, I propose to add the above AC_CONFIG_AUX_DIR line. That change should be transparent to all the other tools, and would let me commit link-warning.h in the build-aux subdir, instead of in the top-level dir. Any objection?

2 2

[Libvir] Preliminary packages for libvirt on Debian
by Richard W.M. Jones 06 Dec '07

06 Dec '07

These are preliminary packages for libvirt 0.3.3 on Debian. The libvirt package is derived from the one in Ubuntu, originally packaged by Andrew Mitchell. Xen --- Unfortunately a patch is needed to the base Xen package in Debian, so that it includes the header files needed by libvirt. Doubly unfortunately because of the strange way that Xen is packaged in Debian it isn't possible to modify the changelog (therefore the version or release number) without some voodoo which I don't understand[1]. So the version here has the same version/release as the one currently in Debian testing. As a result you'll have to manually install it using dpkg. Binary for i386: http://et.redhat.com/~rjones/debian-libvirt/xen-docs-3.1_3.1.1-1_all.deb http://et.redhat.com/~rjones/debian-libvirt/xen-hypervisor-3.1-1-i386_3.1.1… http://et.redhat.com/~rjones/debian-libvirt/xen-hypervisor-3.1-1-i386-nonpa… http://et.redhat.com/~rjones/debian-libvirt/xen-utils-3.1-1_3.1.1-1_i386.deb Patch required to get the right header files: http://et.redhat.com/~rjones/debian-libvirt/debian-xen-includes.patch libvirt ------- Source: http://et.redhat.com/~rjones/debian-libvirt/libvirt_0.3.3-1.diff.gz http://et.redhat.com/~rjones/debian-libvirt/libvirt_0.3.3-1.dsc http://et.redhat.com/~rjones/debian-libvirt/libvirt_0.3.3-1_i386.changes http://et.redhat.com/~rjones/debian-libvirt/libvirt_0.3.3.orig.tar.gz Binary for i386: http://et.redhat.com/~rjones/debian-libvirt/libvirt0_0.3.3-1_i386.deb http://et.redhat.com/~rjones/debian-libvirt/libvirt-bin_0.3.3-1_i386.deb http://et.redhat.com/~rjones/debian-libvirt/libvirt-dev_0.3.3-1_i386.deb http://et.redhat.com/~rjones/debian-libvirt/python-libvirt_0.3.3-1_i386.deb virt-install & virt-manager --------------------------- I'm working on these, although I managed to "brick" my Debian install because of some stupidity in pycentral ... Rich. [1] See this thread for the full details: http://lists.alioth.debian.org/pipermail/pkg-xen-devel/2007-November/001506… -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

2 1

[Libvir] [PATCH] Clean up a warning in remote_internal.c
by Richard W.M. Jones 06 Dec '07

06 Dec '07

After applying this patch, you can compile CVS libvirt with -Werror. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

3 2

[Libvir] [PATCH] fix compilation if readline lib is not available
by Daniel Veillard 06 Dec '07

06 Dec '07

The current CVS code doesn't compile on RHEL5/F6 because readline lib there require ncurses, and we removed that check earlier. Sor we find the readline headers but the lib is not found. Unfortunately virsh.c tests the availablility of the header to use readline, and link time failures follow. The patch below: - exports a READLINE_CFLAGS from configure if used - use the READLINE_CFLAGS when compiling virsh.c - change virsh.c to rely on this instead of the header test - adds a message about readline usage at the end of configure configure: Miscellaneous configure: configure: Debug: no configure: Readline: yes configure: Another patch available soon should fix the readline library detection itself, Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

3 8