- Devel - libvirt List Archives

[libvirt] PATCH Remove unused openvz code
by Daniel P. Berrange 25 Jul '08

25 Jul '08

The openvz driver currrently generates a compile warning due to this unused function. If no one objects I'll shortly remove it. I intend to turn on openvz and LXC driver compilation for the nightly builds to get more testing coverage Daniel diff -r 59140de4e7a9 src/openvz_driver.c --- a/src/openvz_driver.c Mon Jul 21 18:27:29 2008 +0100 +++ b/src/openvz_driver.c Tue Jul 22 22:12:22 2008 +0100 @@ -91,32 +91,11 @@ unsigned int flags ATTRIBUTE_UNUSED); static int openvzDomainUndefine(virDomainPtr dom); -static int convCmdbufExec(char cmdbuf[], char *cmdExec[]); static void cmdExecFree(char *cmdExec[]); static int openvzGetProcessInfo(unsigned long long *cpuTime, int vpsid); struct openvz_driver ovz_driver; - -static int convCmdbufExec(char cmdbuf[], char *cmdExec[]) -{ - int i=0, limit = OPENVZ_MAX_ARG - 1; - char cmdWord[CMDOP_LEN]; - while(*cmdbuf) - { - if(i >= limit) - { - cmdExec[i] = NULL; - return -1; - } - sscanf(cmdbuf, "%s", cmdWord); - cmdbuf += strlen(cmdWord); - while(*cmdbuf == ' ') cmdbuf++; - cmdExec[i++] = strdup(cmdWord); - } - cmdExec[i] = NULL; - return i; -} static void cmdExecFree(char *cmdExec[]) { -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 1

[libvirt] Couple qemu driver bugs after xml refactoring
by Cole Robinson 25 Jul '08

25 Jul '08

Hi all, I've hit a couple bugs in the qemu driver with the recent domain xml refactoring. I've debugged them but in both cases I'm not sure what the optimal solutions are, so I'm just laying them out here: 1) Previously defining a qemu guest without a 'listen' address specified in the graphics tag would default to 127.0.0.1 (hardcoded in qemu_driver->vncListen). Current xml doesn't set this default, and will build a qemu command line with an entry like '-vnc (null):1'. Not sure if the default should be set at the parsing level or the driver level. 2) If a cpuset isn't specified, def->cpumask is null. However qemudInitCpus from qemu_driver.c doesn't know how to handle this, causing libvirtd to crash. This function is also using QEMUD_CPUMASK_LEN which I think should be replaced with VIR_DOMAIN_CPUMASK_LEN. I tried the obvious fix of just skipping the dependent code if cpumask is null, but there still seemed to be problems and I didn't dig much deeper. Thanks, Cole

4 6

[libvirt] Double free in test driver error handling (0.4.4)
by Tóth István 25 Jul '08

25 Jul '08

While debugging the libvirt-java error handling problem, Ive found that if I call the test driver with a bad uri, the application instantly bombs with a double free error. Try to run the attached test program to trigger the bug. regards István #include <libvirt/libvirt.h> #include <stdio.h> int main(){ int ret=virInitialize(); virConnectOpen("test:///defaultt"); }

3 2

[libvirt] [PATCH]: libvirt.h: very xen centric
by Guido Günther 25 Jul '08

25 Jul '08

Hi, while reading through that I noticed libvirt.h is quiet xen centric. Purely cosmetic patch attached, -- Guido

3 2

[libvirt] [PATCH] qemudOpenMonitor: fix open(2) error check
by Guido Günther 25 Jul '08

25 Jul '08

Hi, open returns -1 on failure. Pointed out by Guido Trotter on: http://bugs.debian.org/492250 Patch against current CVS attached. -- Guido

3 2

[libvirt] [PATCH] fix Relax-NG pattern matching
by John Levon 25 Jul '08

25 Jul '08

Don't use unescaped meta-characters. Signed-off-by: John Levon <john.levon(a)sun.com> Index: docs/libvirt.rng =================================================================== RCS file: /data/cvs/libvirt/docs/libvirt.rng,v retrieving revision 1.9 diff -u -r1.9 libvirt.rng --- docs/libvirt.rng 10 Jul 2008 08:05:39 -0000 1.9 +++ docs/libvirt.rng 24 Jul 2008 16:40:16 -0000 @@ -840,7 +840,7 @@ </define> <define name='domainName'> <data type='string'> - <param name="pattern">[A-Za-z0-9_.:/\+\-&-]+</param> + <param name="pattern">[A-Za-z0-9_\.\+\-&:/]+</param> </data> </define> <define name='genericName'> @@ -860,22 +860,22 @@ </define> <define name='filePath'> <data type='string'> - <param name="pattern">[a-zA-Z0-9_\+\-%./&]+</param> + <param name="pattern">[a-zA-Z0-9_\.\+\-&/%]+</param> </data> </define> <define name='absFilePath'> <data type='string'> - <param name="pattern">/[a-zA-Z0-9_\+\-%./&]+</param> + <param name="pattern">/[a-zA-Z0-9_\.\+\-&/%]+</param> </data> </define> <define name='devicePath'> <data type='string'> - <param name="pattern">/[a-zA-Z0-9_\+\-%/]+</param> + <param name="pattern">/[a-zA-Z0-9_\+\-/%]+</param> </data> </define> <define name='deviceName'> <data type='string'> - <param name="pattern">[a-zA-Z0-9_\-:./]+</param> + <param name="pattern">[a-zA-Z0-9_\.\-:/]+</param> </data> </define> <define name='addrMAC'>

2 1

[libvirt] Virt-Manager, libvirt & TLS
by Geoff Wiener 24 Jul '08

24 Jul '08

Hi! This is my first post to either of these list, I have been lurking, (sorry to cross post but I don't know if this is a virt-manager or libvirt question). So first off thank you to everyone for all your efforts. I think libvirt and virt-manager are excellent! I've built a pair of server s in the lab with a Xen stack and have been attempting to get virt-manager 0.5.4 to communicate with, first libvirt 0.4.2 and then libvirt 0.4.4 using TLS across the network in a "client / server" configuration unsuccessfully. All the machines are on the same subnet (192.168.4.x/24). I can make Virt-Manager communicate with Libvirt over TCP without authentication so now that I know the installation works I want to further secure it using TLS. I've read everything I can get my hands on, subscribe to the lists and feel that I must be making a simple error ;I could really use a fresh perspective. I would really appreciate any feedback you can offer. Here's my configuration and testing method. Workstation Ubuntu Hardy Heron 64 bit Virt-manager 0.5.4 Server Distribution = CentOS 5.1 (64 bit) Kernel = 2.6.18.8-xen (compiled from source) Xen = 3.2.1.gz virsh # version Compiled against library: libvir 0.4.4 Using library: libvir 0.4.4 Using API: Xen 3.0.1 Running hypervisor: Xen 3.2.0 /usr/local/etc/libvirt/libvirtd.conf Listen_tcp = 1 auth_unix_ro = "none" auth_unix_rw="none" auth_tcp="none" In this configuration I can use "Remove Password or Kerberos" to connect. I just enter the hostname of the Xen machine and Virt-Manager lets me see all the Domains that are running (or shutdown if I virsh define them) as well as look at their consoles (if the vfb is configured correctly). I followed the configuration notes at: http://libvirt.org/remote.html with a couple of exceptions: 1. I already have a linux based CA that I use with OpenVPN so I used that CA root certificate and just generated client and server cert / key pairs for my client and server (I tested with just one server) 2. I reverted back to the default libvirtd.conf to setup for TLS and noticed that the default paths for the certificate locations were not in line with the documentation on the web page but there were commented sections as follows that matched the documentation, so I uncommented them: key_file = "/etc/pki/libvirt/private/serverkey.pem" cert_file = "/etc/pki/libvirt/servercert.pem" ca_file = "/etc/pki/CA/cacert.pem" #crl_file = "/etc/pki/CA/crl.pem" Note: I did not uncomment the CRL_FILE path as I do not want to use a CRL at this time 3. On the server I execute "libvirtd -listen -verbose" (libvirtd output) attached 4. virt-manager 0.5.4 (as root) , File, Open Connection Hypervisor: Xen Connection: Remote SSL/TLS with x509 certificate Hostname: vxen-01.aenigmacorp.com (I have a host entry for this machine) The virt-manager console reports "unable to open a connection to the libvirt management daemon". Verify that the "libvirtd" daemon has been started. Then, in details there is a lot of info (see virt-manager output) 5. If I tail /root/.virt-manager/virt-manager.log I get the following output (see virt-manager.log) That about sums it up. I have not read any instructions that ask me to copy the CA root certificate to the client, is that required? And if so where would I put it. Also, whenever I attempt to connect there are no errors appearing in the libvirtd output, which is a bit surprising. I would have expected that by using -verbose on the libvirtd command line that i would see more info. Lin 94 in the libvirt.py script is definitely trying to do some kind of authentication but I don't really know what to do to troubleshot this next? I still don't know if my issue is related to the client or the server? Any advice would be greatly appreciated. Many thanks Geoff Wiener

2 2

[libvirt] [PATCH] qemuDriver: check for migrate command
by Guido Günther 24 Jul '08

24 Jul '08

Hi, qemu doesn't know about "migrate" used to save a qemu/kvm domain. Current CVS fails silently - this patch checks if the command if available. Cheers, -- Guido

3 2

[libvirt] xml format for openvz driver
by Evgeniy Sokolov 24 Jul '08

24 Jul '08

Hello! I made review of domain XML format for driver in libvirt. And I have several questions and additions. For tag domain: need to add "vmid" or "id" - currenly tag "name" is used for ID. OpenVZ has mandatory parameter ID, but it also support optional parameter "name", which is not implemented for openvz driver now. I plan to support of "name" in future. For tag domain/os: need to add "ostemplate" desirable "config" For tag domain/devices/disk: need to add "diskspace" desirable "diskinodes" - it is optional because of "disknodes" are over very rarely. For tag domain/devices/interface: How to describe, if want to add ip addresses for routing network? Also, OpenVZ may move network adapter to VM (for example, eth1), adapter becomes inaccessible on harware node. How to describe it? Is it ethernet type? Thanks! Evgeniy

3 10

[libvirt] [FeatureRequest/RFC] non-volitile domain defines
by Stefan de Konink 23 Jul '08

23 Jul '08

I think I have already sent an email about this to the list, but no reply on this specific point. Libvirt is currently capable of storing storage, networks, the only thing that is really missing is the direct storage of domains. I wonder if a patch would be accepted that stores defined domains (live) to disk upon change. Some sort of dumpxml per define/attach/etc. when a domain is undefined the file is removed. Stefan

3 9