- Devel - libvirt List Archives

[libvirt] [PATCH] Sanitize qemu monitor reads
by Cole Robinson 25 Sep '08

25 Sep '08

Reading from the qemu monitor pulls in a whole bunch of useless control characters. For example, sending the command 'somecomm' to the monitor returns: somecomm unknown command: 'somecomm' (qemu) Which is 36 characters, however we end up reading over 200. The amount we read actually grows quadratically as a function of the command length. This prevents us from reporting monitor output to the user (incase some command fails) and seriously diminishes the value of the domain logfiles. The attached patch tries to sanitize this a bit. After reading all the output, we search for the first occurrence of the full command string. If found, we search from there for the first newline (which marks the beginning of the monitor response). If these are found, we only return the command, and everything after the newline. If only the command is found, we just drop everything before it. I've tested this on f9 and f8, there didn't seem to be any problems. I think this should be pretty future proof as well, so we hopefully won't be throwing out anything valuable. Thanks, Cole

2 2

[libvirt] [PATCH] Log virRun command output, return with error
by Cole Robinson 24 Sep '08

24 Sep '08

The attached patch adds some extra logging to the virRun command. The full argv is now logged with DEBUG, as well as the commands stdout and stderr (if anything is found). Also, if the command returns an error, we raise the stderr content with the reported error msg. This will significantly help with debugging certain issues, particularly with the storage driver which makes heavy use of virRun. Thanks, Cole

4 3

[libvirt] [PATCH] fix spec file when building without qemu
by Daniel Veillard 24 Sep '08

24 Sep '08

While trying to build libvirt 0.4.6 for Fedora, I got an error when building on ppc64 which is the only architecture where qemu support is disabled. Files which were conditional to qemu were installed nonetheless in the build root: Checking for unpackaged file(s): /usr/lib/rpm/check-files /builddir/build/BUILDROOT/libvirt-0.4.6-1.fc10.ppc64 error: Installed (but unpackaged) file(s) found: /etc/libvirt/qemu/networks/autostart/default.xml /etc/libvirt/qemu/networks/default.xml /usr/share/augeas/lenses/libvirtd_qemu.aug /usr/share/augeas/lenses/tests/test_libvirtd_qemu.aug The following patch doesn't look ideal but allows to fix the problem. Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

2 1

[libvirt] [PATCH 3/3]: Implement logical stopPool and deletePool more fully
by Chris Lalancette 24 Sep '08

24 Sep '08

This patch does a few things. 1) Clean up a bunch of comments which I believe are no longer valid, or just slightly wrong 2) Enable the stopPool command for the logical backend. The comment in the code worries about a situation where you try to "stop" the logical volume that your rootfs is on, for example. However, that situation is already taken care of by the LVM tools; if the logical volume you try to stop is active, it will throw an error saying that the LV is in use, and won't stop it. Therefore, it should be pretty safe to try to stop logical volumes; it will fail for ones that are in use, but will stop volumes that have been properly torn down ahead of time. 3) In deletePool, remove the -f from the vgremove command. Besides the fact that we probably don't usually want to force things, the -f option doesn't exist prior to F-9, so this would fail on F-8, RHEL-5, etc. 4) In deletePool, implement pvremove of all source devices. Note that this should also be relatively safe; it will only pvremove devices that we had previously pvcreate'd in createPool, which means they were all under control of libvirt. It will not pvremove devices on an LVM that you previously created, but were just scanning with libvirt. Signed-off-by: Chris Lalancette <clalance(a)redhat.com>

3 5

[libvirt] Monitoring guest state (xen hvms)
by Matthew Donovan 24 Sep '08

24 Sep '08

I would like to be able to monitor the state of a Xen guest OS via virDomainGetInfo (and Domain.getInfo() in the Java bindings.) When I start, pause, and resume the guest via the libvirt API, it works as expected. However, if I shutdown the guest vm by opening a VNC window and actually selecting "shutdown" via the OS's favorite mechanism (e.g. Start -> Shutdown in Windows), I lose the state. In other words, virDomainGetInfo() returns NOSTATE. There was some conversation on this list a while ago about virDomainGetInfo() returning NOSTATE so I added some code and recompiled libvirt to print the value of the domain_flags returned from the xen hypervisor. _When_ it printed this value, it was always zero. I stress the "when" part because after the OS completely shuts down, the value of domain_flags is no longer printed. I started virsh and did a list of VMs and the guest is gone. However, if I look at "xm list", the domain is still there. Is there a reliable way to monitor the guest state when the guest is shutdown internally (i.e. via the guest OS itself)? Thanks -matthew

1 0

[libvirt] [RFC] Events API
by David Lively 24 Sep '08

24 Sep '08

Hi - We have some folks looking into the implementation of events (just VM state transition events, for now) in libvirtd. I've been assuming that events will be XML strings, something like: <event type="domain-state-transition" timestamp="xxxxx"> <domain-id>22</domain-id> <old-state>nostate</old-state> <new-state>running</new-state> </event> where the contents of the <event> element are determined by the event type, and the attributes type and timestamp are required. Originally, I was thinking one would listen for events by registering a callback, something like: int virConnectAddEventHandler(virConnPtr conn, char **filter, virEventHandler handler, void *arg) where filter is either NULL, indicating interest in all events, or else a NULL-terminated vector of event type names, allowing filtering by event type. void handler(conn, const char *eventXML, arg) would be called for each matching event. I'm a little concerned that a vector of event type names isn't really adequate for specifying a filter. Does this need to be more general (XPathString exprs??) But my larger concern is that an asynchronous callback mechanism (as proposed above) assumes the presence of some thread / process from which to make the callbacks. This works fine in the libvirtd context, but not outside of it. For instance, we build a "client only" version of libvirt with ONLY the remote driver, which currently doesn't require pthreads at all. Introducing asynchronous callbacks into the API means pthreads is now required for this. I'm not sure how much requiring this extra thread matters. If it does, we could always define a synchronous delivery mechanism instead. For instance, we could have a virDeliverEvents(conn) call to make the callbacks for any outstanding events. Or we could just dispense with callbacks altogether, and return a readable (pipe) fd from which the client can read events. Comments?? Dave P.S. We'll also need an internal API for sending events (most likely, an extension of the existing virEvent stuff), but let's get the basic shape of the external interface agreed upon first.

7 19

[libvirt] [PATCH 1/3]: Cleanup the virStorageDriver structs
by Chris Lalancette 23 Sep '08

23 Sep '08

This patch just cleans up the virStorageDriver structs so that they use the .functionPointer = functionname syntax of gcc. This makes it much easier to grep in the code later. This patch also re-arranges the order of the function pointers in remote_internal so that it matches the definition of virStorageDriver in src/driver.h. While not strictly necessary, it does make it a little more sane when looking at it in the future. Signed-off-by: Chris Lalancette <clalance(a)redhat.com>

4 5

[libvirt] [PATCH 2/3]: Fix storage_conf parsing for empty <source>
by Chris Lalancette 23 Sep '08

23 Sep '08

This patch fixes a minor bug in the storage_conf parsing. Creating logical volume pool XML without a source definition is a valid operation (for example, if you just want to scan an already existing LVM group), but this bug was making the parser reject that XML. Bugfix from Dan Berrange, tested by me. Signed-off-by: Chris Lalancette <clalance(a)redhat.com>

4 3

[libvirt] [PATCH] Add libvirt.h to ignore files
by James Morris 23 Sep '08

23 Sep '08

Shouldn't libvirt.h be ignored by SCMS ? ---- libvirt.h is automatically generated: it should be ignored by SCM tools. Signed-off-by: James Morris <jmorris(a)namei.org> --- diff --git a/include/libvirt/.cvsignore b/include/libvirt/.cvsignore index 282522d..7bd42da 100644 --- a/include/libvirt/.cvsignore +++ b/include/libvirt/.cvsignore @@ -1,2 +1,3 @@ Makefile Makefile.in +libvirt.h diff --git a/include/libvirt/.gitignore b/include/libvirt/.gitignore index 282522d..7bd42da 100644 --- a/include/libvirt/.gitignore +++ b/include/libvirt/.gitignore @@ -1,2 +1,3 @@ Makefile Makefile.in +libvirt.h

2 1

[libvirt] [PATCH] read network config in OpenVZ driver
by Evgeniy Sokolov 23 Sep '08

23 Sep '08

This patch add possibility to load network configuration for container in OpenVZ driver. It support routing network and bridge devices. This types is currently supported in create/define command. Also, patch contain fix to small bug in openvzReadConfigParam method.

4 9