- Devel - libvirt List Archives

[libvirt] [PATCH] (virCgroupSetValueStr): Use safe_write, not write.
by Jim Meyering 08 Oct '08

08 Oct '08

"make syntax-check" was failing. This fixes it: >From 155aea5141553fd9fab19aedc4df1613abae771c Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Tue, 7 Oct 2008 23:10:03 +0200 Subject: [PATCH] Tue Oct 7 23:08:51 CEST 2008 Jim Meyering <meyering(a)redhat.com> * src/cgroup.c (virCgroupSetValueStr): Use safe_write, not write. --- ChangeLog | 4 ++++ src/cgroup.c | 2 +- 2 files changed, 5 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index 619d2b6..88b746e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +Tue Oct 7 23:08:51 CEST 2008 Jim Meyering <meyering(a)redhat.com> + + * src/cgroup.c (virCgroupSetValueStr): Use safe_write, not write. + Tue Oct 7 18:33:39 CEST 2008 Daniel Veillard <veillard(a)redhat.com> * src/qemu_driver.c: another OOM handling cleanup (Guido Günther) diff --git a/src/cgroup.c b/src/cgroup.c index a7d2ca9..ed206dc 100644 --- a/src/cgroup.c +++ b/src/cgroup.c @@ -649,7 +649,7 @@ int virCgroupAddTask(virCgroupPtr group, pid_t pid) goto done; } - if (write(fd, pidstr, strlen(pidstr)) <= 0) { + if (safe_write(fd, pidstr, strlen(pidstr)) <= 0) { rc = -errno; goto done; } -- 1.6.0.2.307.gc4275

3 2

[libvirt] virsh connect
by devi thapa 08 Oct '08

08 Oct '08

Hi All, I have created a virtual network using virsh. I want to connect to the virtual machine, without being asked password. Can I achieve this using command virsh connect <name> Please help me out with this. Regards, Devi.

2 1

[libvirt] [PATCH] Reboot support for QEMU/KVM
by Eduardo Habkost 08 Oct '08

08 Oct '08

This patch implements reboot support on qemu_driver. It is so simple that I am wondering if there is some problem I am missing, that would be the reason it wasn't implemented yet. I hope not. :) Signed-off-by: Eduardo Habkost <ehabkost(a)redhat.com> --- src/qemu_driver.c | 23 ++++++++++++++++++++++- 1 files changed, 22 insertions(+), 1 deletions(-) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index a88cb75..9ce53ad 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -2182,6 +2182,27 @@ static int qemudDomainShutdown(virDomainPtr dom) { } +static int qemudDomainReboot(virDomainPtr dom) { + struct qemud_driver *driver = (struct qemud_driver *)dom->conn->privateData; + virDomainObjPtr vm = virDomainFindByID(driver->domains, dom->id); + char* info; + + if (!vm) { + qemudReportError(dom->conn, dom, NULL, VIR_ERR_INVALID_DOMAIN, + _("no domain with matching id %d"), dom->id); + return -1; + } + + if (qemudMonitorCommand(driver, vm, "system_reset", &info) < 0) { + qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_FAILED, + "%s", _("reboot operation failed")); + return -1; + } + VIR_FREE(info); + return 0; +} + + static int qemudDomainDestroy(virDomainPtr dom) { struct qemud_driver *driver = (struct qemud_driver *)dom->conn->privateData; virDomainObjPtr vm = virDomainFindByID(driver->domains, dom->id); @@ -4032,7 +4053,7 @@ static virDriver qemuDriver = { qemudDomainSuspend, /* domainSuspend */ qemudDomainResume, /* domainResume */ qemudDomainShutdown, /* domainShutdown */ - NULL, /* domainReboot */ + qemudDomainReboot, /* domainReboot */ qemudDomainDestroy, /* domainDestroy */ qemudDomainGetOSType, /* domainGetOSType */ qemudDomainGetMaxMemory, /* domainGetMaxMemory */ -- 1.5.5.GIT

2 2

[libvirt] [PATCH 0 of 3] Add cpu.shares support to LXC driver
by Dan Smith 08 Oct '08

08 Oct '08

This set adds {Get,Set}SchedulerParameters support to the LXC driver. A single parameter of "cpu_shares" is added, which gets/sets the cpu.shares key in the domain's cgroup. I also added bits to "virsh schedinfo" to support this.

2 7

[libvirt] [PATCH]: (trivial) handle OOM as everywhere else
by Guido Günther 08 Oct '08

08 Oct '08

Hi, we print an error message on OOM conditions in qemudStartup() at the end of the function, no need to do it differently in one place. Cheers, -- Guido

2 1

[libvirt] [PATCH]: (trivial) getpwuid is not OOM
by Guido Günther 08 Oct '08

08 Oct '08

Hi, we shouldn't print an oom error message when actually getpwuid failed. Cheers, -- Guido

2 1

[libvirt] When bridge doesn't exist
by Anton Protopopov 07 Oct '08

07 Oct '08

Assume that we want to add a bridge to LAN to a guest. We saying to libvirt: ... <interface type="bridge"> <source bridge="BRIDGE"> </interface> ... What is the right behaviour of libvirt in case bridge BRIDGE doesn't exist---return an error or try to create that bridge? If it is the former, then who must create that bridge?

1 0

[libvirt] Routed Networking - Ubuntu Hardy KVM and LibVirt
by Barry Robinson 07 Oct '08

07 Oct '08

Gday, I have been searching for information on how to configure KVM guest OS' to do simple routing from their associated vnetX address to the host machine's ethernet network subnet (lets say eth0/192.168.0.0/24). I understand that by default the clients are NAT'ed to the Host's adapter. This is a handy feature, but it does not suit the setup I am trying to apply. Basically, I am trying to do simple routing from the host subnet (192.168.0.0/24) to the client's subnet (192.168.17.0/24), and back again. So I can talk to 192.168.0.0/24 addresses and they can talk to 192.168.17.0/24 (routing rule has been added so this is possible). There should be no NAT involved. The following is about as close as I have come to getting this solution. However, I still need to add in the iptables -A FORWARD -i vnetX -o eth0 -j ACCEPT rule in after the machine is booted. Is it possible to do this as part of the script process, or is there a post-ifup script that can be run? /etc/libvirt/qemu/network/routed-net.xml: <network> <name>routed-net</name> <uuid></uuid> <bridge name="virbr%d" /> <ip address="192.168.32.1" netmask="255.255.255.0"> <dhcp> <range start="192.168.32.33" end="192.168.32.63" /> </dhcp> </ip> </network> I have tried using the <forward='routed' /> option (under the bridge name option). This does add the forward rules, but for some reason still applies the MASQUERADE rule to the 192.168.17.0/24 network. (eg. 0 0 MASQUERADE all -- * * 192.168.32.0/24 0.0.0.0/0 ) libvirtd seems to hide it's firewall rulesets pretty well, cause I can't even find them to manually add/remove rules. Not in any place obvious (that I can find), like /etc. Any help would be appreciated. Apologies if this topic has been covered... can't find it anywhere using Google. Cheers, Barry Linseed Technologies Open Source IT Solutions Phone: 0415131452 Email: brobinson(a)linseed.com.au Website: http://www.linseed.com.au

2 1

[libvirt] PATCH: 0 of 5: Remove all linked lists
by Daniel P. Berrange 07 Oct '08

07 Oct '08

I've been doing some proof of concept work to make the libvirtd daemon multi-threaded, and this in turns mean that the QEMU / LXC / OpenVZ drivers need to have some degree of locking on their internal data structures. Unforatunately the internal domain/network/storage APIs make extensive use of linked lists for tracking objects. This makes it incredibly hard to do fine grained locking of individual objects - eg, deleting one object requires locking the object it points to, and one the pointing to it in the linked list, as well as the list itself. This would be so complex we'd inevitably introduce locking bugs. So the series of patches which follow replace all linked lists with explicitly sized arrays. This means I only need 2 levels of locks, one on the driver object, and one of the domain/network/storage object being manipulated. The semantics for this are nice & easy to define. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 13

[libvirt] [PATCH] Centralize use of DEBUG macros
by Cole Robinson 07 Oct '08

07 Oct '08

Currently the DEBUG and DEBUG0 macros are duplicated in every file that uses them. This patch moves the macros to internal.h, removes the needless duplication, and now every file gets them for free. Seems to work as expected in my testing. Thanks, Cole

3 6