- Devel - libvirt List Archives

[libvirt] [PATCH] Make SELinuxSecurityDriverProbe() fail on Fedora 10
by Mark McLoughlin 16 Apr '09

16 Apr '09

Running "make check" on F10, I get: libvir: Security Labeling error : SELinuxInitialize: cannot open SELinux virtual domain context file /etc/selinux/targeted/contexts/virtual_domain_context: No such file or directory Failed to start security driverFAIL: seclabeltest Seems virtual_domain_context isn't available on F10. Haven't investigated further, just want to have "make check" pass. Signed-off-by: Mark McLoughlin <markmc(a)redhat.com> --- src/security_selinux.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/src/security_selinux.c b/src/security_selinux.c index ac317d7..c0b4a67 100644 --- a/src/security_selinux.c +++ b/src/security_selinux.c @@ -218,7 +218,13 @@ done: static int SELinuxSecurityDriverProbe(void) { - return is_selinux_enabled() ? SECURITY_DRIVER_ENABLE : SECURITY_DRIVER_DISABLE; + if (!is_selinux_enabled()) + return SECURITY_DRIVER_DISABLE; + + if (!virFileExists(selinux_virtual_domain_context_path())) + return SECURITY_DRIVER_DISABLE; + + return SECURITY_DRIVER_ENABLE; } static int -- 1.6.0.6

3 2

[libvirt] [PATCH 1/1] changes in src/lxc_container.c so that it passes make syntax-check
by Pritesh Kothari 16 Apr '09

16 Apr '09

Hi All, This patch just clean up src/lxc_container.c so that the make syntax-check passes. Regards, Pritesh

2 1

[libvirt] [PATCH] Fix lxc syntax-check failure
by Mark McLoughlin 16 Apr '09

16 Apr '09

>From 7ebf401c747b61b44bdba0aebc85fbead7ec1d12 Mon Sep 17 00:00:00 2001 From: Mark McLoughlin <markmc(a)redhat.com> Date: Thu, 16 Apr 2009 11:36:41 +0100 Subject: Fixes: CHECK: avoid_if_before_free src/lxc_container.c: if (oldroot) VIR_FREE(oldroot) src/lxc_container.c: if (newroot) VIR_FREE(newroot) Makefile.maint: found useless "if" before "free" above and: src/lxc_container.c:317: Makefile.maint: found trailing blank(s) Signed-off-by: Mark McLoughlin <markmc(a)redhat.com> --- src/lxc_container.c | 16 ++++++++-------- 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/lxc_container.c b/src/lxc_container.c index ff115d1..67c66bd 100644 --- a/src/lxc_container.c +++ b/src/lxc_container.c @@ -282,9 +282,11 @@ static int lxcContainerChildMountSort(const void *a, const void *b) static int lxcContainerPivotRoot(virDomainFSDefPtr root) { - int rc; + int rc, ret; char *oldroot = NULL, *newroot = NULL; + ret = -1; + /* root->parent must be private, so make / private. */ if (mount("", "/", NULL, MS_PRIVATE|MS_REC, NULL) < 0) { virReportSystemError(NULL, errno, "%s", @@ -312,7 +314,7 @@ static int lxcContainerPivotRoot(virDomainFSDefPtr root) oldroot); goto err; } - + /* Create a directory called 'new' in tmpfs */ if (virAsprintf(&newroot, "%s/new", oldroot) < 0) { virReportOOMError(NULL); @@ -366,15 +368,13 @@ static int lxcContainerPivotRoot(virDomainFSDefPtr root) goto err; } + ret = 0; + +err: VIR_FREE(oldroot); VIR_FREE(newroot); - return 0; - -err: - if (oldroot) VIR_FREE(oldroot); - if (newroot) VIR_FREE(newroot); - return -1; + return ret; } static int lxcContainerPopulateDevices(void) -- 1.6.0.6

2 1

[libvirt] problem to connect to libvirtd as ordinary user
by Sebastian Reitenbach 16 Apr '09

16 Apr '09

Hi, I'm trying to setup an eucalyptus cloud managing my virtual xen nodes. I'm on SLES11, x86_64. I compiled libvirt-0.6.2 with the following configure parameters: ./configure --prefix=/usr --without-storage-iscsi --without-remote --without-sasl --without-openvz --without-storage-disk below the parameters I've set in the /etc/libvirt/libvirt.conf file: listen_tls = 0 listen_tcp = 1 unix_sock_group = "libvirt" unix_sock_ro_perms = "0777" unix_sock_rw_perms = "0777" unix_sock_dir = "/var/run/libvirt" auth_unix_ro = "none" auth_unix_rw = "none" auth_tcp = "none" auth_tls = "none" log_level = 1 log_outputs="0:stderr" as root, I can run "virsh list" or "virsh -c xen+unix:/// list" and it just works, however, I cannot do this as user eucalyptus. The user eucalyptus is a member of the libvirt group. # id eucalyptus uid=1000(eucalyptus) gid=1000(eucalyptus) groups=1000(eucalyptus),0(root),16 (dialout),17(audio),33(video),100(users),1001(libvirt) I ran virsh through strace, to see what happens: strace virsh.bin -c xen+unix:/// list ... open("/proc/xen/privcmd", O_RDWR) = -1 EACCES (Permission denied) ... Shouldn't the permissions of /proc/xen/privcmd be OK due to the libvirt.conf file? However, I changed them, and now the strace output looks like this: chmod 777 /proc/xen/privcmd strace virsh.bin -c xen+unix:/// list ... open("/proc/xen/privcmd", O_RDWR) = 3 ioctl(3, SNDCTL_DSP_RESET, 0x7fff4721a0f0) = 196611 mlock(0x7fff4721a070, 72) = 0 mlock(0x7fff47219f00, 136) = 0 ioctl(3, SNDCTL_DSP_RESET, 0x7fff47219d80) = -1 EACCES (Permission denied) munlock(0x7fff47219f00, 136) = 0 munlock(0x7fff4721a070, 72) = 0 mlock(0x7fff4721a070, 72) = 0 mlock(0x7fff47219f00, 136) = 0 ioctl(3, SNDCTL_DSP_RESET, 0x7fff47219d80) = -1 EACCES (Permission denied) munlock(0x7fff47219f00, 136) = 0 munlock(0x7fff4721a070, 72) = 0 mlock(0x7fff4721a070, 72) = 0 mlock(0x7fff47219f00, 136) = 0 ioctl(3, SNDCTL_DSP_RESET, 0x7fff47219d80) = -1 EACCES (Permission denied) munlock(0x7fff47219f00, 136) = 0 munlock(0x7fff4721a070, 72) = 0 mlock(0x7fff4721a070, 72) = 0 mlock(0x7fff47219f00, 136) = 0 ioctl(3, SNDCTL_DSP_RESET, 0x7fff47219d80) = 0 munlock(0x7fff47219f00, 136) = 0 munlock(0x7fff4721a070, 72) = 0 mlock(0x7fff47219e00, 136) = 0 ioctl(3, SNDCTL_DSP_RESET, 0x7fff47219d80) = 0 munlock(0x7fff47219e00, 136) = 0 close(3) = 0 ... actually, there is no sound card at all, I wonder what the SNDCTL_DSP_RESET is doing there. After the close(3), the virsh is only looking for language to generate the error message: error: failed to connect to the hypervisor Those xen versions are installed: xen-doc-pdf-3.3.1_18546_12-3.1 xen-doc-html-3.3.1_18546_12-3.1 xen-3.3.1_18546_12-3.1 xen-libs-3.3.1_18546_12-3.1 xen-tools-3.3.1_18546_12-3.1 xen-kmp-default-3.3.1_18546_12_2.6.27.19_5-3.1 kernel-xen-base-2.6.27.19-5.1 kernel-xen-2.6.27.19-5.1 xen-devel-3.3.1_18546_12-3.1 any idea what is wrong here? kind regards sebastian

2 2

[libvirt] [Docs] More work on the API and architecture
by Daniel Veillard 15 Apr '09

15 Apr '09

Another patch, incomplete adding a new page api.html[.in] with the goals of describing the main API concepts, architectures, naming conventions, etc ... It includes Dan's graphics and a change of how the stylesheet process the .html.in content allowing to turn <code class='docref'>foo</code> into a link to reference for foo in the API page. Ultimately I should be able to load the API description from the stylesheet and do that link generation automagically without any markup (like all the links in the API reference). Still need to write the drivers and remote sections, and augment some of the APIs entry points, but it's a first step and better in than out. Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

2 2

[libvirt] XML network model type stripped on define.
by Adrian Garay 15 Apr '09

15 Apr '09

Greetings! I am currently testing Centos5.3, KVM-84, libvirt from the Centos default packages and a Vista 32 guest. I am unfortunately experiencing difficulties with the default realtek8139 network driver, the solution for which I've read would be to change the emulated network device type to e1000. When editing the xml file for my guest, I change: <interface type='bridge'> <mac address='00:16:3e:38:a8:ad'/> <source bridge='br0'/> </interface> to: <interface type='bridge'> <mac address='00:16:3e:38:a8:ad'/> <source bridge='br0'/> <model type='e1000'/> </interface> and then doing a: virsh --connect qemu:///system define /etc/libvirt/qemu/vista32.xml The correct guest is updated, but the model type information I've just added is stripped from my XML and I'm once again left with an 8139 emulated nic. According to the command: qemu-kvm -net nic,model=? /dev/null I should be able to use the e1000 driver. My sincerest apologies if this is already known, or I'm missing something terribly obvious. I am new to mailing lists (this would be my first!) Thanks in advance.

3 5

[libvirt] libvirt 0.3.3 and unix_sock_group
by Daniel Labrosse 15 Apr '09

15 Apr '09

Hi All, I've been using libvirt 0..4.4 for a few weeks now. I have unix_sock_group = "mygroup" set so that i can perform non-root management capabilities on the host. I have recently installed a new host running Scientific Linux 5.3 and libvirt 0.3.3 comes as default. First off, there is no libvirtd.conf file included with 0.3.3, so I copied the file from libvirt 0.4.4 (which is running on my Fedora 8 box). I am still unable to get non-root management capabilities (i.e virsh create etc) after a restart of libvirtd. Is this feature supported in libvirt 0.3.3? Perhaps the file format is different between versions and hence unix_sock_group isnt being read correctly? hope you can help. thanks Daniel

2 2

[libvirt] [PATCH] trivial fix for virsh return value bug
by Daniel Veillard 15 Apr '09

15 Apr '09

https://bugzilla.redhat.com/show_bug.cgi?id=495954 virsh ttyconsole [node] always sets a return code of 1 we initialize ret to FALSE, but don't set it to TRUE when the operation succeeds Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

1 1

[libvirt] [PATCH] add some text to http://libvirt.org/drvlxc.html
by Serge E. Hallyn 15 Apr '09

15 Apr '09

--- drvlxc-orig.html 2009-04-15 09:36:48.000000000 -0500 +++ drvlxc.html 2009-04-15 09:44:27.000000000 -0500 @@ -140,7 +140,89 @@ </div> <div id="content"> - <h1>LXC container driver</h1> +<h1>LXC container driver</h1> +<p> +The libvirt LXC driver manages "Linux Containers". Containers are sets of processes +with private namespaces which can (but don't always) look like separate machines, but +do not have their own OS. Here are two example configurations. The first is a very +light-weight "application container" which does not have it's own root image. You would +start it using +</p> + +<h3>Example config version 1</h3> +<p> +<pre> +<domain type='lxc'> + <name>vm1</name> + <memory>500000</memory> + <os> + <type>exe</type> + <init>/bin/sh</init> + </os> + <vcpu>1</vcpu> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <emulator>/usr/libexec/libvirt_lxc</emulator> + <interface type='network'> + <source network='default'/> + </interface> + <console type='pty' /> + </devices> +</domain> +</pre> +</p> + +<p> +The next example assumes there is a private root filesystem +(perhaps hand-crafted using busybox, or installed from media, +debootstrap, whatever) under /opt/vm-1-root: +</p> +<p> +<pre> +<domain type='lxc'> + <name>vm1</name> + <memory>32768</memory> + <os> + <type>exe</type> + <init>/init</init> + </os> + <vcpu>1</vcpu> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <emulator>/usr/libexec/libvirt_lxc</emulator> + <filesystem type='mount'> + <source dir='/opt/vm-1-root'/> + <target dir='/'/> + </filesystem> + <interface type='network'> + <source network='default'/> + </interface> + <console type='pty' /> + </devices> +</domain> + +</pre> +</p> + +<p> +In both cases, you can define and start a container using: +<pre> +lxc --connect lxc:/// define v1.xml +lxc --connect lxc:/// start v1.xml +</pre> +and then get a console using: +<pre> +lxc --connect lxc:/// console v1 +</pre> +Now doing 'ps -ef' will only show processes in the container, for +instance. +</p> </div> </div> <div id="footer">

2 1

[libvirt] virsh ttyconsole [node] has rc of 1?
by Darryl L. Pierce 15 Apr '09

15 Apr '09

I have a script that's breaking when trying to get the ttyconsole for a node. The script gets the console by invoking: virsh ttyconsole [nodename] The script also has trap on error enabled, and the above command has a return code of 1. This is causing the script to exit at that point. Is this a bug? Or is there a reason that return code is 1 and not 0? -- Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc. Virtual Machine Management - http://www.ovirt.org/ Is fearr Gaeilge bhriste ná Béarla cliste.

2 1