- Devel - libvirt List Archives

[libvirt] [PATCH] Fix reading storage pool defs on driver startup
by Cole Robinson 25 Jun '09

25 Jun '09

The recent storage refactoring I committed broke reading pool definitions from disk on driver startup: the result was that none of your pools would be defined. Frankly not sure how I managed to miss the brokenness, sorry about that! Also refactor the startup code to match the existing network and domain conventions. Thanks, Cole

2 1

[libvirt] Fix the no debug build
by Amy Griffis 25 Jun '09

25 Jun '09

The --enable-debug=no build breaks building the UML driver because of __VA_ARGS__ in the virLogMessage macro. I fixed this by converting umlLog() calls to use the standard logging macros instead. The only problem I see with doing this is what Daniel had mentioned a while back. Disabling debug actually turns off the entire logging module instead of just the debug output. I can work on fixing that part in another patch. Signed-off-by: Amy Griffis <amy.griffis(a)hp.com> diff --git a/src/uml_driver.c b/src/uml_driver.c index 7949d4f..7aeb7bf 100644 --- a/src/uml_driver.c +++ b/src/uml_driver.c @@ -66,9 +66,6 @@ static int umlShutdown(void); -#define umlLog(level, msg, ...) \ - virLogMessage(__FILE__, level, __func__, __LINE__, 0, msg, __VA_ARGS__) - static void umlDriverLock(struct uml_driver *driver) { virMutexLock(&driver->lock); @@ -95,8 +92,7 @@ static int umlSetCloseExec(int fd) { goto error; return 0; error: - umlLog(VIR_LOG_ERROR, - "%s", _("Failed to set close-on-exec file descriptor flag\n")); + VIR_ERROR0(_("Failed to set close-on-exec file descriptor flag")); return -1; } @@ -136,7 +132,7 @@ umlAutostartConfigs(struct uml_driver *driver) { !virDomainIsActive(driver->domains.objs[i]) && umlStartVMDaemon(conn, driver, driver->domains.objs[i]) < 0) { virErrorPtr err = virGetLastError(); - umlLog(VIR_LOG_ERROR, _("Failed to autostart VM '%s': %s\n"), + VIR_ERROR(_("Failed to autostart VM '%s': %s"), driver->domains.objs[i]->def->name, err->message); } } @@ -368,13 +364,13 @@ umlStartup(int privileged) { if ((uml_driver->inotifyFD = inotify_init()) < 0) { - umlLog(VIR_LOG_ERROR, "%s", _("cannot initialize inotify")); + VIR_ERROR0(_("cannot initialize inotify")); goto error; } if (virFileMakePath(uml_driver->monitorDir) < 0) { char ebuf[1024]; - umlLog(VIR_LOG_ERROR, _("Failed to create monitor directory %s: %s"), + VIR_ERROR(_("Failed to create monitor directory %s: %s"), uml_driver->monitorDir, virStrerror(errno, ebuf, sizeof ebuf)); goto error; } @@ -407,8 +403,7 @@ umlStartup(int privileged) { return 0; out_of_memory: - umlLog (VIR_LOG_ERROR, - "%s", _("umlStartup: out of memory\n")); + VIR_ERROR0(_("umlStartup: out of memory")); error: VIR_FREE(userdir); @@ -825,25 +820,25 @@ static int umlStartVMDaemon(virConnectPtr conn, tmp = progenv; while (*tmp) { if (safewrite(logfd, *tmp, strlen(*tmp)) < 0) - umlLog(VIR_LOG_WARN, _("Unable to write envv to logfile: %s\n"), + VIR_WARN(_("Unable to write envv to logfile: %s"), virStrerror(errno, ebuf, sizeof ebuf)); if (safewrite(logfd, " ", 1) < 0) - umlLog(VIR_LOG_WARN, _("Unable to write envv to logfile: %s\n"), + VIR_WARN(_("Unable to write envv to logfile: %s"), virStrerror(errno, ebuf, sizeof ebuf)); tmp++; } tmp = argv; while (*tmp) { if (safewrite(logfd, *tmp, strlen(*tmp)) < 0) - umlLog(VIR_LOG_WARN, _("Unable to write argv to logfile: %s\n"), + VIR_WARN(_("Unable to write argv to logfile: %s"), virStrerror(errno, ebuf, sizeof ebuf)); if (safewrite(logfd, " ", 1) < 0) - umlLog(VIR_LOG_WARN, _("Unable to write argv to logfile: %s\n"), + VIR_WARN(_("Unable to write argv to logfile: %s"), virStrerror(errno, ebuf, sizeof ebuf)); tmp++; } if (safewrite(logfd, "\n", 1) < 0) - umlLog(VIR_LOG_WARN, _("Unable to write argv to logfile: %s\n"), + VIR_WARN(_("Unable to write argv to logfile: %s"), virStrerror(errno, ebuf, sizeof ebuf)); vm->monitor = -1; @@ -888,8 +883,7 @@ static void umlShutdownVMDaemon(virConnectPtr conn ATTRIBUTE_UNUSED, vm->monitor = -1; if ((ret = waitpid(vm->pid, NULL, 0)) != vm->pid) { - umlLog(VIR_LOG_WARN, - _("Got unexpected pid %d != %d\n"), + VIR_WARN(_("Got unexpected pid %d != %d"), ret, vm->pid); }

3 2

[libvirt] Memory leak in node_device_conf.c
by Dave Allan 25 Jun '09

25 Jun '09

I found what I assume is a memory leak in the node device code while working on a separate problem; patch attached. Dave diff --git a/src/node_device_conf.c b/src/node_device_conf.c index 1fbf9dc..56a9bb5 100644 --- a/src/node_device_conf.c +++ b/src/node_device_conf.c @@ -1203,6 +1203,8 @@ void virNodeDevCapsDefFree(virNodeDevCapsDefPtr caps) VIR_FREE(data->net.address); break; case VIR_NODE_DEV_CAP_SCSI_HOST: + VIR_FREE(data->scsi_host.wwnn); + VIR_FREE(data->scsi_host.wwpn); break; case VIR_NODE_DEV_CAP_SCSI: VIR_FREE(data->scsi.type);

3 2

[libvirt] Re: [netcf-devel] Multiple interfaces with identical mac-addresses
by Laine Stump 25 Jun '09

25 Jun '09

(expanding Cc to include libvir-list, because this is more of a libvirt issue) On 06/24/2009 01:52 PM, David Lutterkort wrote: > On Wed, 2009-06-24 at 18:22 +0100, Daniel P. Berrange wrote: > >> On Wed, Jun 24, 2009 at 10:20:00AM -0700, David Lutterkort wrote: >> >>> On Tue, 2009-06-23 at 21:47 +0100, Daniel P. Berrange wrote: >>> >>>> Why would we ever have duplicate MAC addresses? >>>> >>> VLANs: >>> >>> # vconfig add eth0 42 >>> # cat /sys/class/net/eth0.42/address >>> 00:15:58:81:5b:0e >>> # cat /sys/class/net/eth0/address >>> 00:15:58:81:5b:0e >>> >> Ok, so for the libvirt API we should define that the lookup-by-mac API >> will not return VLAN devices, since we cant provide a 1-1 lookup there >> > > Why would you do that ? When the user asks for interfaces with a MAC, > you don't know if they are looking for a VLAN or base device. If they > want the VLAN, how would they look that up ? > I think we need to do one of two things: 1) Modify the existing virInterfaceLookupByMACString() api to return a list of virInterfaces. Although the public API has been in one release, there has been no functionality behind the API, so there's nobody using it as it is, and nobody is going to expect to use it as it is either. Because of that, "backward compatibility" isn't as much of an issue, and maybe we could let this modification to the API slide. 2) If we want to be really anal, we could modify virInterfaceLookupByMACString() to return an error if there are multiple interfaces with that particular MAC address, then provide a new function (name suggestion?) that would return a list of interfaces.

2 1

[libvirt] [PATCH] fix virsh dominfo returns error when virNodeGetSecurityModel() is not supported.
by Tatsuro Enokura 25 Jun '09

25 Jun '09

Hi all I try virsh dominfo in upstream libvirt on xen machine, the commands returns -1 as follows: [root@vmi20 ~]# virsh dominfo rhel53rc2_pv_sdb3 Id: 1 Name: rhel53rc2_pv_sdb3 UUID: 05ba9be8-f4e9-e208-11c7-fc936655cd8e OS Type: linux State: idle CPU(s): 2 CPU time: 8.8s Max memory: 1048576 kB Used memory: 716800 kB Autostart: disable error: this function is not supported by the hypervisor: virNodeGetSecurityModel [root@vmi20 ~]# echo $? 1 The explanation of virNodeGetSecurityModel() and virNodeGetSecurityModel() in libvirt.c is return -2 when hypervisor drivers don't support these operations. But these functions return -1 in this case, and so cmdDominfo() in virsh.c returns FALSE. I make a patch. - virNodeGetSecurityModel() and virNodeGetSecurityModel() return -2 when drivers don't supprted these operations. - In CmdDominfo(), it is no operation when virNodeGetSecurityModel() and virNodeGetSecurityModel() return -2. Signed-off-by: Tatsuro Enokura <fj2026af(a)aa.jp.fujitsu.com> Thanks Tatsuro Enokura

3 8

[libvirt] [PATCH] OpenNebula driver changes
by Javier Fontan 25 Jun '09

25 Jun '09

Hello, The first patch makes OpenNebula driver compilable in recent codebase. The second one adds direct calls to xmlrpc library so it does not depend on OpenNebula libraries and can be licensed as LGPL. I have compiled libvirt with the modifications without errors but with the current version I checked out from git repository I am having problems: --8<------ (LD) -o libvirtd libvirtd-event.o libvirtd-qemud.o libvirtd-remote.o libvirtd-remote_protocol.o ../src/.libs/libvirt_driver_storage.a(storage_backend.o): In function `virStorageBackendWaitForDevices': /home/jfontan/git/libvirt.git/src/storage_backend.c:262: undefined reference to `virNodeDeviceWaitForDevices' ------>8-- Patches are made from 0a29f59e3b8e2c1fb797d2fa93831f21a3e1711e Bye -- Javier Fontan, Grid & Virtualization Technology Engineer/Researcher DSA Research Group: http://dsa-research.org Globus GridWay Metascheduler: http://www.GridWay.org OpenNebula Virtual Infrastructure Engine: http://www.OpenNebula.org

4 5

[libvirt] [PATCH 2/5] Add partition type
by Henrik Persson 25 Jun '09

25 Jun '09

This patch add the partition type (primary, extended, logical) in internal libvirt data structure. This is important when deciding what kind of partition should be created.

2 1

[libvirt] [PATCH 1/5] Add type of free area
by Henrik Persson 25 Jun '09

25 Jun '09

This patch adds the type of the free area, since this is important when creating logical partitions.

2 1

[libvirt] [PATCH 4/5] free extent fix
by Henrik Persson 25 Jun '09

25 Jun '09

Parted reports that the first block of the disk is free, even if it is occupied by the partition table.

2 1

[libvirt] libvirt support for qemu downscript
by Shahar Klein 24 Jun '09

24 Jun '09

Hi I'm using virsh to launch a VM. the if-up script works perfectly but I couldn't find any reference to using down script I 'gueesed ' and put something like that: <interface type='ethernet'> . . <script path='ifup'/> <downscript path='ifdwon'/> . . </interface> but the down script is not called on shutdown am I missing something? thanks Shahar

1 0