- Devel - libvirt List Archives

[libvirt] [PATCH v2 00/13] CPU selection patches
by Jiri Denemark 15 Dec '09

15 Dec '09

Hi, This is a second version of CPU selection patchset. Changes in version 2: - virConnectGetHostCPU() API call was completely removed - 'CPU driver implementation' (11/14) patch was dropped - virConnectCompareCPU() API call is implemented directly by hypervisor drivers - new cpuCompareXML() internal function to make virConnectCompareCPU() simpler Jirka Jiri Denemark (13): XML schema for CPU flags XML parsing/formating code for CPU flags Public API Internal driver API Public API implementation Wire protocol format Remote driver Server side dispatcher CPU selection infrastructure CPU map for models and features Set cpuCompare handler in drivers Implement CPU selection in QEMU driver Implement virsh commands configure.in | 20 + daemon/remote.c | 22 + docs/schemas/capability.rng | 46 ++- docs/schemas/domain.rng | 62 +++ include/libvirt/libvirt.h.in | 13 + include/libvirt/virterror.h | 1 + src/Makefile.am | 23 +- src/conf/capabilities.c | 31 ++- src/conf/capabilities.h | 6 + src/conf/cpu_conf.c | 366 ++++++++++++++ src/conf/cpu_conf.h | 116 +++++ src/conf/domain_conf.c | 15 + src/conf/domain_conf.h | 2 + src/cpu/cpu.c | 242 +++++++++ src/cpu/cpu.h | 129 +++++ src/cpu/cpu_generic.c | 123 +++++ src/cpu/cpu_generic.h | 32 ++ src/cpu/cpu_map.c | 130 +++++ src/cpu/cpu_map.h | 41 ++ src/cpu/cpu_map.xml | 304 +++++++++++ src/cpu/cpu_x86.c | 1142 ++++++++++++++++++++++++++++++++++++++++++ src/cpu/cpu_x86.h | 31 ++ src/cpu/cpu_x86_data.h | 45 ++ src/driver.h | 5 + src/esx/esx_driver.c | 1 + src/libvirt.c | 41 ++ src/libvirt_private.syms | 19 + src/libvirt_public.syms | 5 + src/lxc/lxc_driver.c | 1 + src/openvz/openvz_driver.c | 1 + src/qemu/qemu_conf.c | 401 ++++++++++++++- src/qemu/qemu_conf.h | 7 + src/qemu/qemu_driver.c | 43 ++- src/remote/remote_driver.c | 27 + src/remote/remote_protocol.x | 12 +- src/test/test_driver.c | 1 + src/uml/uml_driver.c | 1 + src/util/virterror.c | 3 + src/vbox/vbox_tmpl.c | 1 + tools/virsh.c | 65 +++ 40 files changed, 3541 insertions(+), 35 deletions(-) create mode 100644 src/conf/cpu_conf.c create mode 100644 src/conf/cpu_conf.h create mode 100644 src/cpu/cpu.c create mode 100644 src/cpu/cpu.h create mode 100644 src/cpu/cpu_generic.c create mode 100644 src/cpu/cpu_generic.h create mode 100644 src/cpu/cpu_map.c create mode 100644 src/cpu/cpu_map.h create mode 100644 src/cpu/cpu_map.xml create mode 100644 src/cpu/cpu_x86.c create mode 100644 src/cpu/cpu_x86.h create mode 100644 src/cpu/cpu_x86_data.h

1 13

[libvirt] getSchedulerParameters() always returning nullpointerexception in JAVA
by Marc Gonzalez Mateo 15 Dec '09

15 Dec '09

Hi everyvody, I'm developing a new API based on libvirt. I'm currently stucked using getSchedulerParameters, always is returning a nullpointerexception, no matter which Xen Domain I'm passing to the function. Enclosing both the code and the error console: public int getCPUPriority(String name) { int res=-1; try { Domain d = getDomain(name); SchedParameter[] pars = d.getSchedulerParameters(); for (SchedParameter pri : pars) { if (pri.field=="weight") res=Integer.parseInt(pri.getValueAsString()); } } catch (LibvirtException e) { log.error(" Error: getting CPU priority of \""+name+"\"." + e.getClass()); e.printStackTrace(); } return res; } Dec 11, 2009 1:04:18 PM net.emotivecloud.virtmonitor.VirtMonitor getCPUCapacity SEVERE: Error: getting CPU capacity of "XenTest". java.lang.NullPointerException at org.libvirt.SchedParameter.create(Unknown Source) at org.libvirt.Domain.getSchedulerParameters(Unknown Source) at net.emotivecloud.virtmonitor.VirtMonitor.getCPUCapacity(VirtMonitor.java:462) at net.emotivecloud.virtmonitor.VirtMonitor.main(VirtMonitor.java:763) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:616) at org.codehaus.mojo.exec.ExecJavaMojo$1.run(ExecJavaMojo.java:283) at java.lang.Thread.run(Thread.java:636) Any ideas? Thanks in advance, Marc Gonzalez Mateo

4 4

[libvirt] [PATCH 00/14] CPU selection patches
by Jiri Denemark 15 Dec '09

15 Dec '09

Hi, Here it is, finally. Jirka Jiri Denemark (14): XML schema for CPU flags XML parsing/formating code for CPU flags Public API Internal driver API Public API implementation Wire protocol format Remote driver Server side dispatcher CPU selection infrastructure CPU map for models and features CPU driver implementation Set getHostCPU handler in drivers Implement CPU selection in QEMU driver Implement virsh commands configure.in | 20 + daemon/Makefile.am | 2 + daemon/libvirtd.c | 3 + daemon/remote.c | 42 ++ daemon/remote_dispatch_prototypes.h | 16 + docs/schemas/capability.rng | 46 ++- docs/schemas/domain.rng | 62 ++ include/libvirt/libvirt.h.in | 15 + include/libvirt/virterror.h | 2 + src/Makefile.am | 43 ++- src/conf/capabilities.c | 31 +- src/conf/capabilities.h | 6 + src/conf/cpu_conf.c | 366 +++++++++++ src/conf/cpu_conf.h | 116 ++++ src/conf/domain_conf.c | 15 + src/conf/domain_conf.h | 2 + src/cpu/cpu.c | 206 +++++++ src/cpu/cpu.h | 124 ++++ src/cpu/cpu_driver.c | 190 ++++++ src/cpu/cpu_driver.h | 40 ++ src/cpu/cpu_generic.c | 123 ++++ src/cpu/cpu_generic.h | 32 + src/cpu/cpu_map.c | 130 ++++ src/cpu/cpu_map.h | 41 ++ src/cpu/cpu_map.xml | 304 ++++++++++ src/cpu/cpu_x86.c | 1142 +++++++++++++++++++++++++++++++++++ src/cpu/cpu_x86.h | 31 + src/cpu/cpu_x86_data.h | 45 ++ src/datatypes.h | 2 + src/driver.h | 20 + src/esx/esx_driver.c | 1 + src/libvirt.c | 129 ++++ src/libvirt_private.syms | 19 + src/libvirt_public.syms | 6 + src/lxc/lxc_driver.c | 1 + src/openvz/openvz_driver.c | 1 + src/qemu/qemu_conf.c | 401 ++++++++++++- src/qemu/qemu_conf.h | 7 + src/qemu/qemu_driver.c | 37 +- src/remote/remote_driver.c | 125 ++++ src/remote/remote_protocol.c | 27 + src/remote/remote_protocol.x | 18 +- src/test/test_driver.c | 1 + src/uml/uml_driver.c | 1 + src/util/virterror.c | 8 + src/vbox/vbox_tmpl.c | 1 + tools/virsh.c | 65 ++ 47 files changed, 4029 insertions(+), 36 deletions(-) create mode 100644 src/conf/cpu_conf.c create mode 100644 src/conf/cpu_conf.h create mode 100644 src/cpu/cpu.c create mode 100644 src/cpu/cpu.h create mode 100644 src/cpu/cpu_driver.c create mode 100644 src/cpu/cpu_driver.h create mode 100644 src/cpu/cpu_generic.c create mode 100644 src/cpu/cpu_generic.h create mode 100644 src/cpu/cpu_map.c create mode 100644 src/cpu/cpu_map.h create mode 100644 src/cpu/cpu_map.xml create mode 100644 src/cpu/cpu_x86.c create mode 100644 src/cpu/cpu_x86.h create mode 100644 src/cpu/cpu_x86_data.h

1 15

[libvirt] [PATCH] libvirtd: avoid a NULL dereference on error path
by Jim Meyering 15 Dec '09

15 Dec '09

>From f124b132913884ced6e9fbae8233056e0e97cd0a Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Mon, 14 Dec 2009 16:45:11 +0100 Subject: [PATCH] libvirtd: avoid a NULL dereference on error path * daemon/libvirtd.c (qemudDispatchServer): Since "client" may be NULL in the "cleanup:" block, free client->rx only when it's not. --- daemon/libvirtd.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index 6b7e33d..de6fc27 100644 --- a/daemon/libvirtd.c +++ b/daemon/libvirtd.c @@ -1422,7 +1422,8 @@ static int qemudDispatchServer(struct qemud_server *server, struct qemud_socket if (client && client->tlssession) gnutls_deinit (client->tlssession); close (fd); - VIR_FREE(client->rx); + if (client) + VIR_FREE(client->rx); VIR_FREE(client); return -1; } -- 1.6.6.rc2.275.g51e2d

2 2

[libvirt] libvirt -0.7.4 on fc8 gives "Starting libvirtd daemon: error: Unable to initialize network sockets"
by Nimal Prabudoss I 15 Dec '09

15 Dec '09

Hi, I'm trying to use the libvirt 0.7.4 in fc8. I have configured and done with make, make install. Virsh command also displays the version correctly as 0.7.4 But when I try to start the libvirtd service, I get the following error. "Starting libvirtd daemon: error: Unable to initialize network sockets [Failed]" My machine details is given below "2.6.21-2950.fc8xen #1 SMP Tue Oct 23 12:24:34 EDT 2007 i686 i686 i386 GNU/Linux" Have anybody encountered the same kind of error? Please help me on this. Thanks, Nimal.I

1 0

[libvirt] [PATCH] Fix and improve domain xml video element description
by Matthias Bolte 14 Dec '09

14 Dec '09

The description mismatched the actual structure since the video element was introduced. The nvram attribute is actually called vram. Specify the unit of the vram attribute. --- docs/formatdomain.html.in | 30 ++++++++++++++++++++++-------- 1 files changed, 22 insertions(+), 8 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 5b7aa10..3d418b9 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -768,20 +768,34 @@ qemu-kvm -net nic,model=? /dev/null <pre> ... - <video type='vga' nvram='8192' heads='1'> - <acceleration accel3d='yes' accel3d='yes' /> + <video> + <model type='vga' vram='8192' heads='1'> + <acceleration accel3d='yes' accel3d='yes'/> + </model> </video> ...</pre> <dl> <dt><code>video</code></dt> - <dd>The <code>video</code> element has a mandatory <code>type</code> - attribute which takes the value "vga", "cirrus", "vmvga", "xen" or "vbox". - You can also provide the amount of video memory using <code>nvram</code>, - the number of screen with <code>heads</code>, and whether acceleration - should be enabled (if supported) using the <code>accel3d</code> and - <code>accel2d</code> attributes in the <code>acceleration</code> element. + <dd> + The <code>video</code> element is the a container for describing + video devices. + </dd> + + <dt><code>model</code></dt> + <dd> + The <code>model</code> element has a mandatory <code>type</code> + attribute which takes the value "vga", "cirrus", "vmvga", "xen" or "vbox". + You can also provide the amount of video memory in kilobytes using + <code>vram</code> and the number of screen with <code>heads</code>. + </dd> + <dt><code>acceleration</code></dt> + <dd> + If acceleration should be enabled (if supported) using the + <code>accel3d</code> and <code>accel2d</code> attributes in the + <code>acceleration</code> element. + </dd> </dl> <h4><a name="elementsConsole">Consoles, serial, parallel & channel devices</a></h4> -- 1.6.0.4

2 2

[libvirt] Python script and extension module directory handling
by Matthias Bolte 14 Dec '09

14 Dec '09

Commit 66137344feb488ea87b0d92f3c03844d9a7a7786 changed the Python detection mechanism in configure. This results in a changed install location for the Python bindings at least on Fedora 12 64bit systems. For the explanation below I assume a Fedora 12 64bit systems, libvirt is configured with prefix /usr and Python 2.6 is installed. Before this commit libvirt.py and libvirtmod.so were installed to /usr/lib64/python2.6/site-packages. After this commit both are installed to /usr/lib/python2.6/site-packages. This is at least wrong for libvirtmod.so, as it should be installed to /usr/lib64/python2.6/site-packages on a 64bit system. Before this commit pythondir was set manually to /usr/lib64/python2.6/site-packages and python/Makefile.am contains 'python_LTLIBRARIES = libvirtmod.la' that results in installing libvirtmod.so to pythondir. AM_PATH_PYTHON defines two variables: pythondir and pyexecdir. But according to the AM_PATH_PYTHON documentation [1] pythondir is the directory where Python scripts should be installed. /usr/lib/python2.6/site-packages in this case, because Python scripts are not architecture dependent in general. pyexecdir is the directory where Python extension modules (shared libraries) should be installed. AM_PATH_PYTHON detects pyexecdir correctly as /usr/lib64/python2.6/site-packages, but python/Makefile.am contains 'python_LTLIBRARIES = libvirtmod.la' that results in installing libvirtmod.so to pythondir. So python/Makefile.am must be changed: diff --git a/python/Makefile.am b/python/Makefile.am index 736631e..04342b7 100644 --- a/python/Makefile.am +++ b/python/Makefile.am @@ -32,7 +32,7 @@ mylibs = $(top_builddir)/src/libvirt.la all-local: libvirt.py -python_LTLIBRARIES = libvirtmod.la +pyexec_LTLIBRARIES = libvirtmod.la libvirtmod_la_SOURCES = libvirt-override.c typewrappers.c libvirt.c libvirt.h # Python <= 2.4 header files contain a redundant decl, hence we Now libvirtmod.so is installed to the correct directory: /usr/lib64/python2.6/site-packages But libvirt.py gets installed to /usr/lib/python2.6/site-packages, this is different from the installation directory before the commit. A default Fedora 12 64bit installation has *.py files installed to /usr/lib/python2.6/site-packages and /usr/lib64/python2.6/site-packages. By looking at both directories the policy it pretty obvious: Packages that are pure Python go to /usr/lib/python2.6/site-packages and packages that are mixed (Python and shared libraries) go completely to /usr/lib64/python2.6/site-packages. So we restore the behavior from before the commit completely by applying this additional patch: diff --git a/python/Makefile.am b/python/Makefile.am index 736631e..04342b7 100644 --- a/python/Makefile.am +++ b/python/Makefile.am @@ -60,14 +60,14 @@ $(GENERATED): generated.stamp $(libvirtmod_la_OBJECTS): $(GENERATED) install-data-local: - $(mkinstalldirs) $(DESTDIR)$(pythondir) - @INSTALL@ -m 0644 libvirt.py $(DESTDIR)$(pythondir) + $(mkinstalldirs) $(DESTDIR)$(pyexecdir) + @INSTALL@ -m 0644 libvirt.py $(DESTDIR)$(pyexecdir) $(mkinstalldirs) $(DESTDIR)$(DOCS_DIR) @(for doc in $(DOCS) ; \ do @INSTALL@ -m 0644 $$doc $(DESTDIR)$(DOCS_DIR) ; done) uninstall-local: - rm -f $(DESTDIR)$(pythondir)/libvirt.py + rm -f $(DESTDIR)$(pyexecdir)/libvirt.py CLEANFILES= $(GENERATED) generated.stamp I discussed this with Daniel Veillard on IRC and there was some confusion what the actual problem was and how to solve it, so I wanted to recap it here. Also thanks to Daniel Hokka Zakrisson, who gave the important hint about pythondir vs pyexecdir on IRC. [1] http://www.gnu.org/software/hello/manual/automake/Python.html Matthias

3 3

[libvirt] [PATCH] node_device_driver.c: don't write beyond EOB for 4K-byte symlink
by Jim Meyering 14 Dec '09

14 Dec '09

Without this patch, a symlink pointing to a 4096-byte name could make this code write NUL into the byte beyond end of buffer: if ((n = readlink(driver_link, devpath, sizeof devpath - 1)) < 0) { virReportSystemError(conn, errno, _("cannot resolve driver link %s"), driver_link); goto cleanup; } devpath[n] = '\0'; >From a075e207bc8fb279c43c9f4f43a960ffbd9a8a70 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Mon, 14 Dec 2009 12:05:38 +0100 Subject: [PATCH] node_device_driver.c: don't write beyond EOB for 4K-byte symlink * src/node_device/node_device_driver.c (update_driver_name): Leave one byte for the trailing NUL we'll append. --- src/node_device/node_device_driver.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_device_driver.c index f083f16..eda5d5e 100644 --- a/src/node_device/node_device_driver.c +++ b/src/node_device/node_device_driver.c @@ -97,7 +97,7 @@ static int update_driver_name(virConnectPtr conn, goto cleanup; } - if ((n = readlink(driver_link, devpath, sizeof devpath)) < 0) { + if ((n = readlink(driver_link, devpath, sizeof devpath - 1)) < 0) { virReportSystemError(conn, errno, _("cannot resolve driver link %s"), driver_link); goto cleanup; -- 1.6.6.rc2.275.g51e2d

3 6

[libvirt] [PATCH] Allow versioned pc machines for QEmu
by Diego Elio Pettenò 14 Dec '09

14 Dec '09

* docs/schemas/domain.rng: add pattern for pc-0.10, pc-0.11 and similar machine types --- docs/schemas/domain.rng | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng index d1d3efb..dd3f732 100644 --- a/docs/schemas/domain.rng +++ b/docs/schemas/domain.rng @@ -171,6 +171,9 @@ <value>xenfv</value> <value>pc</value> <value>isapc</value> + <data type="string"> + <param name="pattern">pc-[0-9\.]+</param> + </data> </choice> </attribute> </optional> -- 1.6.5.6

4 3

[libvirt] [PATCH] Fix owner and group in example volume XML
by Matthew Booth 14 Dec '09

14 Dec '09

The owner and group in the documentation examples were confusingly given as '0744'. They should be numeric uid and gid. Changed the examples to use the default uid and gid assigned to qemu in F12. * docs/formatstorage.html.in: Change example owner and group in volume XML --- docs/formatstorage.html.in | 16 ++++++++-------- 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/formatstorage.html.in b/docs/formatstorage.html.in index ccf5a91..5c41c39 100644 --- a/docs/formatstorage.html.in +++ b/docs/formatstorage.html.in @@ -119,8 +119,8 @@ <target> <path>/dev/disk/by-path</path> <permissions> - <owner>0744</owner> - <group>0744</group> + <owner>107</owner> + <group>107</group> <mode>0744</mode> <label>virt_image_t</label> </permissions> @@ -244,8 +244,8 @@ <path>/var/lib/virt/images/sparse.img</path> <format type='qcow2'/> <permissions> - <owner>0744</owner> - <group>0744</group> + <owner>107</owner> + <group>107</group> <mode>0744</mode> <label>virt_image_t</label> </permissions> @@ -294,8 +294,8 @@ <path>/var/lib/virt/images/master.img</path> <format>raw</format> <permissions> - <owner>0744</owner> - <group>0744</group> + <owner>107</owner> + <group>107</group> <mode>0744</mode> <label>virt_image_t</label> </permissions> @@ -368,8 +368,8 @@ <target> <path>/var/lib/virt/images/sparse.img</path> <permissions> - <owner>0744</owner> - <group>0744</group> + <owner>107</owner> + <group>107</group> <mode>0744</mode> <label>virt_image_t</label> </permissions> -- 1.6.5.2

3 2