- Devel - libvirt List Archives

[libvirt] [PATCH] show compiled in options in virsh --version
by Daniel Veillard 29 Oct '10

29 Oct '10

To ease debugging this trivial patch allows to find what was compiled in in the local version of libvirt, this doesn't work for remote access but that's probably sufficient. With the patch I get on my machine: paphio:~/libvirt/tools -> ./virsh --version Virsh command line tool of libvirt 0.8.4 See web site at http://libvirt.org/ Compiled with support for: Hypervisors: Xen QEmu/KVM UML OpenVZ LXC ESX PHYP Test Networking: Remote Daemon Network Bridging Netcf Nwfilter Storage: Dir Disk Filesystem SCSI Multipath iSCSI LVM Miscellaneous: SELinux Secrets Debug Readline paphio:~/libvirt/tools -> instead of just "0.8.4" Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

7 12

[libvirt] [PATCH 0/2] speed up qemu domain save by increasing dd blocksize
by Laine Stump 29 Oct '10

29 Oct '10

These two patches are posted together because applying the 2nd exposes the bug fixed by the first. Here are the results of tests I made with various block sizes before deciding the 1MB really was the best balance (all tests were done on a paused 512MB domain, saving to local disk on a Lenovo T61 laptop) BS M:SS save image size ----- ---- --------------- 2048K - 0:56 476135451 1024K - 0:56 475090953 512k - 1:02 474564173 256k - 1:10 474303797 128k - 1:25 474176859 512 - 3:47 474085423 - the original I didn't bother testing sizes between 512 and 128k, as there was still significant improvement from 128k to 256k.

5 27

[libvirt] [PATCH] fix warnign on virtaudit.c
by KAMEZAWA Hiroyuki 29 Oct '10

29 Oct '10

I met this on the latest git tree. == >From fdd982b0cf3b772f61825736e6fc98bf948c4792 Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki <kamezawa.hiroyu(a)jp.fujitsu.com> Date: Thu, 28 Oct 2010 16:18:07 +0900 Subject: [PATCH] libvirt-audit-printf-warning-fix fix warning CC libvirt_util_la-virtaudit.lo cc1: warnings being treated as errors util/virtaudit.c: In function 'virAuditEncode': util/virtaudit.c:146: error: implicit declaration of function 'virAsprintf' [-Wimplicit-function-declaration] util/virtaudit.c:146: error: nested extern declaration of 'virAsprintf' [-Wnested-externs] --- src/util/virtaudit.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/util/virtaudit.c b/src/util/virtaudit.c index d568660..6af7af0 100644 --- a/src/util/virtaudit.c +++ b/src/util/virtaudit.c @@ -30,6 +30,7 @@ #include "virterror_internal.h" #include "logging.h" #include "virtaudit.h" +#include "util.h" /* Provide the macros in case the header file is old. FIXME: should be removed. */ -- 1.7.2.3

2 1

[libvirt] libvirt-csharp coverage update
by arnaud.champion＠devatom.fr 29 Oct '10

29 Oct '10

?Hi Justin, I have sended some patches today. When they will be pushed the coverage will the one in the xls file. I have also changed the linux testing environment, now I test mono bindings with Ubuntu 10.10 x64 and mono compiled in 64 bits, because we have seen some troubles with marshaling in this configuration. So, here are the all the test environements : - Windows 7 (64 bits) / .Net 4 - Windows 7 (64 bits) / Mono (compiled in 32 bits) 2.6.7 - Ubuntu 10.10 amd64 / Mono (compiled in 64 bits) 2.6.7 I will notify you about any changes about testing envs. Best regards, Arnaud

5 10

[libvirt] [PATCH] eliminate possibility of a double-closed file descriptor
by Stefan Berger 28 Oct '10

28 Oct '10

The 2nd and 3rd hunk show the only double-closed file descriptor code part that I found while trying to clean up close(). The first hunk seems a harmless cleanup in that same file. Signed-off-by: Stefan Berger <stefanb(a)us.ibm.com> Index: Stefan/src/storage/storage_backend_logical.c =================================================================== --- Stefan.orig/src/storage/storage_backend_logical.c +++ Stefan/src/storage/storage_backend_logical.c @@ -37,6 +37,7 @@ #include "util.h" #include "memory.h" #include "logging.h" +#include "files.h" #define VIR_FROM_THIS VIR_FROM_STORAGE @@ -408,10 +409,10 @@ virStorageBackendLogicalBuildPool(virCon virReportSystemError(errno, _("cannot clear device header of '%s'"), pool->def->source.devices[i].path); - close(fd); + VIR_FORCE_CLOSE(fd); goto cleanup; } - if (close(fd) < 0) { + if (VIR_CLOSE(fd) < 0) { virReportSystemError(errno, _("cannot close device '%s'"), pool->def->source.devices[i].path); @@ -622,7 +623,7 @@ virStorageBackendLogicalCreateVol(virCon goto cleanup; } - if (close(fd) < 0) { + if (VIR_CLOSE(fd) < 0) { virReportSystemError(errno, _("cannot close file '%s'"), vol->target.path); @@ -641,8 +642,7 @@ virStorageBackendLogicalCreateVol(virCon return 0; cleanup: - if (fd != -1) - close(fd); + VIR_FORCE_CLOSE(fd); virStorageBackendLogicalDeleteVol(conn, pool, vol, 0); return -1; }

2 2

[libvirt] [PATCH] qemu: check for vm after starting a job
by Eric Blake 28 Oct '10

28 Oct '10

https://bugzilla.redhat.com/show_bug.cgi?id=638285 - when migrating a guest, it was very easy to provoke a race where an application could query block information on a VM that had just been migrated away. Any time qemu code obtains a job lock, it must also check that the VM was not taken down in the time where it was waiting for the lock. * src/qemu/qemu_driver.c (qemudDomainSetMemory) (qemudDomainGetInfo, qemuDomainGetBlockInfo): Check that vm still exists after obtaining job lock, before starting monitor action. --- src/qemu/qemu_driver.c | 25 ++++++++++++++++++++++--- 1 files changed, 22 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index ae1d833..af5126d 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -463,7 +463,8 @@ static int ATTRIBUTE_RETURN_CHECK qemuDomainObjEndJob(virDomainObjPtr obj) * obj must be locked before calling, qemud_driver must be unlocked * * To be called immediately before any QEMU monitor API call - * Must have alrady called qemuDomainObjBeginJob(). + * Must have already called qemuDomainObjBeginJob(), and checked + * that the VM is still active. * * To be followed with qemuDomainObjExitMonitor() once complete */ @@ -504,7 +505,7 @@ static void qemuDomainObjExitMonitor(virDomainObjPtr obj) * obj must be locked before calling, qemud_driver must be locked * * To be called immediately before any QEMU monitor API call - * Must have alrady called qemuDomainObjBeginJob(). + * Must have already called qemuDomainObjBeginJob(). * * To be followed with qemuDomainObjExitMonitorWithDriver() once complete */ @@ -522,7 +523,7 @@ static void qemuDomainObjEnterMonitorWithDriver(struct qemud_driver *driver, vir /* obj must NOT be locked before calling, qemud_driver must be unlocked, * and will be locked after returning * - * Should be paired with an earlier qemuDomainObjEnterMonitor() call + * Should be paired with an earlier qemuDomainObjEnterMonitorWithDriver() call */ static void qemuDomainObjExitMonitorWithDriver(struct qemud_driver *driver, virDomainObjPtr obj) { @@ -4948,6 +4949,12 @@ static int qemudDomainSetMemory(virDomainPtr dom, unsigned long newmem) { if (qemuDomainObjBeginJob(vm) < 0) goto cleanup; + if (!virDomainObjIsActive(vm)) { + qemuReportError(VIR_ERR_OPERATION_INVALID, + "%s", _("domain is not running")); + goto endjob; + } + priv = vm->privateData; qemuDomainObjEnterMonitor(vm); r = qemuMonitorSetBalloon(priv->mon, newmem); @@ -5014,11 +5021,17 @@ static int qemudDomainGetInfo(virDomainPtr dom, } else if (!priv->jobActive) { if (qemuDomainObjBeginJob(vm) < 0) goto cleanup; + if (!virDomainObjIsActive(vm)) { + qemuReportError(VIR_ERR_OPERATION_INVALID, + "%s", _("domain is not running")); + goto endjob; + } qemuDomainObjEnterMonitor(vm); err = qemuMonitorGetBalloonInfo(priv->mon, &balloon); qemuDomainObjExitMonitor(vm); if (err < 0) { + endjob: if (qemuDomainObjEndJob(vm) == 0) vm = NULL; goto cleanup; @@ -10343,6 +10356,11 @@ static int qemuDomainGetBlockInfo(virDomainPtr dom, qemuDomainObjPrivatePtr priv = vm->privateData; if (qemuDomainObjBeginJob(vm) < 0) goto cleanup; + if (!virDomainObjIsActive(vm)) { + qemuReportError(VIR_ERR_OPERATION_INVALID, + "%s", _("domain is not running")); + goto endjob; + } qemuDomainObjEnterMonitor(vm); ret = qemuMonitorGetBlockExtent(priv->mon, @@ -10350,6 +10368,7 @@ static int qemuDomainGetBlockInfo(virDomainPtr dom, &info->allocation); qemuDomainObjExitMonitor(vm); + endjob: if (qemuDomainObjEndJob(vm) == 0) vm = NULL; } else { -- 1.7.2.3

3 6

[libvirt] iptables complains about a bad rule
by Matthias Bolte 28 Oct '10

28 Oct '10

With libvirt from git on Ubuntu 10.04 I get this 3 errors (actually 2 warnings an 1 error) when starting libvirtd: 23:15:45.221: error : virRunWithHook:855 : internal error '/sbin/iptables --table mangle --delete POSTROUTING --out-interface virbr0 --protocol udp --destination-port 68 --jump CHECKSUM --checksum-fill' exited with non-zero status 2 and signal 0: iptables v1.4.4: unknown option `--checksum-fill' Try `iptables -h' or 'iptables --help' for more information. 23:15:45.238: error : virRunWithHook:855 : internal error '/sbin/iptables --table filter --delete INPUT --in-interface virbr0 --protocol udp --destination-port 69 --jump ACCEPT' exited with non-zero status 1 and signal 0: iptables: Bad rule (does a matching rule exist in that chain?). 23:15:45.275: error : virRunWithHook:855 : internal error '/sbin/iptables --table mangle --insert POSTROUTING --out-interface virbr0 --protocol udp --destination-port 68 --jump CHECKSUM --checksum-fill' exited with non-zero status 2 and signal 0: iptables v1.4.4: unknown option `--checksum-fill' Try `iptables -h' or 'iptables --help' for more information. The first and the last one just indicate that my iptables here is too old to know about --checksum-fill, but what about the second one? Matthias

2 4

[libvirt] cgroups and USB passthrough devices don't work together
by Diego Elio Pettenò 28 Oct '10

28 Oct '10

Hi all, beside the problem with USB devices I sent the patch for earlier, there is another problem that I'm not sure how to fix: the QEmu cgroup is _not_ allowed to access the device when adding it to the virtual machine. Basically it'd need a call to virCgroupAllowDevicePath() when adding the device… -- Diego Elio Pettenò — “Flameeyes” http://blog.flameeyes.eu/ If you found a .asc file in this mail and know not what it is, it's a GnuPG digital signature: http://www.gnupg.org/

2 1

[libvirt] [PATCH] qemu: Unref domain on error of opening qemu monitor
by Hu Tao 28 Oct '10

28 Oct '10

The domain refed will be left unrefed when there is error when opening qemu monitor, so unref it. --- src/qemu/qemu_driver.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 25695df..4bcfb27 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -1385,7 +1385,7 @@ qemuConnectMonitor(struct qemud_driver *driver, virDomainObjPtr vm) (driver->securityDriver,vm) < 0) { VIR_ERROR(_("Failed to set security context for monitor for %s"), vm->def->name); - goto error; + return ret; } /* Hold an extra reference because we can't allow 'vm' to be @@ -1420,8 +1420,10 @@ qemuConnectMonitor(struct qemud_driver *driver, virDomainObjPtr vm) qemuDomainObjExitMonitorWithDriver(driver, vm); error: - if (ret < 0) + if (ret < 0) { qemuMonitorClose(priv->mon); + virDomainObjUnref(vm); + } return ret; } -- 1.7.3

3 4

Re: [libvirt] SPAM-LOW: Re: Re: Guide for libvirt C# bindings
by arnaud.champion＠devatom.fr 28 Oct '10

28 Oct '10

?In fact, I think it's better to let the choice to the libvirt team. I think they should have a good reason to not expose windows binary. Regards Arnaud From: 黄亮 Sent: Thursday, October 28, 2010 10:28 AM To: arnaud.champion(a)devatom.fr Subject: Re: Re: Re: SPAM-LOW: Re: Re: Guide for libvirt C# bindings yes. Compiling them can be really tough. And thanks for your job that we may invoke api of libvirt in Windows. Maybe you can upload the dll somewhere if libvirt.org won't host, just a suggestion. Regards. 2010-10-28 -------------------------------------------------------------------------------- Lancer -------------------------------------------------------------------------------- 发件人： arnaud.champion(a)devatom.fr 发送时间： 2010-10-28 16:10:54 收件人：黄亮抄送： libvir-list(a)redhat.com 主题： Re: Re: SPAM-LOW: Re: Re: Guide for libvirt C# bindings Yes all the dlls will be produced by this script. In fact, thanks for the script to it's author, it's the harder part (especially for windows users as I am, we are not used to compile in the linux wa ) I hope in the future that the libvirt windows dll will be directly hosted on libvirt.org, but I don't know. Regards, Arnaud From: 黄亮 Sent: Thursday, October 28, 2010 10:05 AM To: arnaud.champion(a)devatom.fr Subject: Re: Re: SPAM-LOW: Re: Re: Guide for libvirt C# bindings Really appreciated! Just to confirm that, all the dlls you mentioned is produced after I use photron scripts, right? That's great. And really thank you for what you've done. Regards and best wishes 2010-10-28 -------------------------------------------------------------------------------- 黄亮 -------------------------------------------------------------------------------- 发件人： arnaud.champion(a)devatom.fr 发送时间： 2010-10-28 15:45:15 收件人：黄亮抄送： libvir-list(a)redhat.com 主题： Re: SPAM-LOW: Re: Re: Guide for libvirt C# bindings Okay, libvirt-0.dll is the libvirt project compilation under windows. To produced it, there is two ways, the hard way and the smooth way the hard way is to install msys, mingwin and so one to have all needed tools, then download needed sources compile them. It's hard, and long. the smooth way is to use photron (Matthias) scripts to produce it. You can find scripts here : http://github.com/photron/msys_setup You download the scripts and foolow the readme.txt which is inside. Once you have compiled libvirt, you need to put these dll in an accessible way for your application (usually, I put it under the .exe produced by .Net) : - libcurl-4.dll (if compiled with esx support) - libgcrypt-11.dll - libgnutls-26.dll - libgpg-error-0.dll - libportablexdr-0.dll - libtasn1-3.dll - libvirt-0.dll - libxml2-2.dll Regards, Arnaud From: 黄亮 Sent: Thursday, October 28, 2010 9:29 AM To: arnaud.champion(a)devatom.fr Subject: SPAM-LOW: Re: Re: Guide for libvirt C# bindings Thank you for your reply. I've downloaded the source code by git. It seems the project needs a dll called libvirt-0.dll. It would be appreciated that you can tell me where to get the dll or how to produce it. Then I can try your examples and write my own. Regards 2010-10-28 -------------------------------------------------------------------------------- Lancer -------------------------------------------------------------------------------- 发件人： arnaud.champion(a)devatom.fr 发送时间： 2010-10-28 15:12:43 收件人：黄亮抄送： libvir-list(a)redhat.com 主题： Re: Guide for libvirt C# bindings Hi, the C# bindings provides 3 sample code to show how to use them. All functions are not in the examples, but examples show how to connect and get domain events (callbacks...) I use these bindings for another project : DAVIM ( www.devatom.fr sorry it's in french only ) and they work well. Anyway, I can help you if you have questions. Arnaud From: 黄亮 Sent: Thursday, October 28, 2010 4:30 AM To: arnaud.champion Subject: Guide for libvirt C# bindings Dear Arnaud Champion I learned you are making C# bindings for libvirt on libvirt.org. I'm interested in it and want to have a try on Windows. Do you have any guide books or introductions for using your C# bindings? I'm using .Net Framework 3.5 and VS 2005. Look forward to your reply. Regards 2010-10-28 -------------------------------------------------------------------------------- Lancer __________ Information from ESET Smart Security, version of virus signature database 5569 (20101027) __________ The message was checked by ESET Smart Security. http://www.eset.com __________ Information from ESET Smart Security, version of virus signature database 5569 (20101027) __________ The message was checked by ESET Smart Security. http://www.eset.com

2 1