- Devel - libvirt List Archives

[libvirt] [PATCH] Pass virSecurityManagerPtr to virSecurityDAC{Set, Restore}ChardevCallback
by Soren Hansen 03 Mar '11

03 Mar '11

virSecurityDAC{Set,Restore}ChardevCallback expect virSecurityManagerPtr, but are passed virDomainObjPtr instead. This makes virSecurityDACSetChardevLabel set a wrong uid/gid on chardevs. This patch fixes this behaviour. Signed-off-by: Soren Hansen <soren(a)linux2go.dk> --- src/security/security_dac.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/security/security_dac.c b/src/security/security_dac.c index 1c1a037..b8de232 100644 --- a/src/security/security_dac.c +++ b/src/security/security_dac.c @@ -509,7 +509,7 @@ virSecurityDACRestoreSecurityAllLabel(virSecurityManagerPtr mgr, if (virDomainChrDefForeach(vm->def, false, virSecurityDACRestoreChardevCallback, - vm) < 0) + mgr) < 0) rc = -1; if (vm->def->os.kernel && @@ -565,7 +565,7 @@ virSecurityDACSetSecurityAllLabel(virSecurityManagerPtr mgr, if (virDomainChrDefForeach(vm->def, true, virSecurityDACSetChardevCallback, - vm) < 0) + mgr) < 0) return -1; if (vm->def->os.kernel && -- 1.7.4.1

3 2

[libvirt] [PATCH 0/6] Allow debug dump in case of crashes
by Daniel Veillard 03 Mar '11

03 Mar '11

This patch set main goal is to allow dumping of full debug informations for operations occuring in libvirt daemon before a crash. The principle is to save all logs to a round-robbin memory buffer (which we already do, except we never use that buffer), save the general daemon logs to a libvirtd.log file for which we keep an open descriptor, and upon reception of a fatal signal, save the memory buffer directly to the file descriptor and fsync it. There is quite a few remarks about this, we already have that buffer but we don't log everything in, only what's output, that's what patch 1 changes, then we need to provide a function to dump this, so there is a new internal API for it. We also need to be cautious about what system call we operate from the signal handler, but basically we should limit ourselves here to write/fsync and sigaction which are safe there dixit POSIX. Something like killall -USR2 libvirtd allows to see the kind of output one get, an idle libvirtd is quiet, but handle/timer/fdpolls tend to be very verbose, maybe we need an intermediate debug level, but that would also impact the API. Maybe now that this part is well debugged some of those could be suppressed or commented off. Also the buffer is a statically allocated 64KB, maybe this could be made more flexible but IMHO that's not fundamental. Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

2 3

[libvirt] [PATCH 6/6] Dump the debug buffer to libvirtd.log on fatal signal
by Daniel Veillard 03 Mar '11

03 Mar '11

In case of imminent crash or upon request (signal USR2), dump the logging buffer to the libvirtd.log file for post-mortem analysis * daemon/libvirtd.c: create a sig_fatal() handler connected to SIGFPE SIGSEGV SIGILL SIGABRT SIGBUS and SIGUSR2, just dumping the log buffer to the libvirtd.log open file descriptor Signed-off-by: Daniel Veillard <veillard(a)redhat.com> --- daemon/libvirtd.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 51 insertions(+), 0 deletions(-)

2 2

[libvirt] [PATCH 2/6] Save daemon logs to libvirtd.log
by Daniel Veillard 03 Mar '11

03 Mar '11

Depending on whether it's run as root or user, the log is saved in the local state dir or in $HOME/.libvirt. The file descriptor is kept as a global variable used by following patches. * daemon/libvirtd.c: add libvirtd.log as the output for logs Signed-off-by: Daniel Veillard <veillard(a)redhat.com> --- daemon/libvirtd.c | 90 ++++++++++++++++++++++++++++++++++++++++++++++++++--- 1 files changed, 85 insertions(+), 5 deletions(-)

2 2

[libvirt] RFC: Increasing number of processes allowed for qemu user
by Jiri Denemark 03 Mar '11

03 Mar '11

Hi all, When libvirt is running on a system with limited number of processes allowed to be created by the user under which qemu processes are run, we hit scalability issues. My take on this issue is that it's in fact a host configuration issue and it should just be documented that users need to increase the limit if they're going to run large number of domains or on a large number of VCPUs. I don't think libvirt should be involved in changing the limit in any way, especially since it's not possible to change the limit in runtime as doing so can only affect new processes. However, I'd like to be sure this is also the thinking of broader community, esp. Dan :-) Jirka

2 2

[libvirt] [libvirt-snmp][PATCH] Another cleanup
by Michal Privoznik 03 Mar '11

03 Mar '11

--- With respect to hints given in package review process: https://bugzilla.redhat.com/show_bug.cgi?id=681558 Makefile.am | 9 +++++++-- libvirt-snmp.spec.in | 14 ++++---------- 2 files changed, 11 insertions(+), 12 deletions(-) diff --git a/Makefile.am b/Makefile.am index a38312e..ae1cd79 100644 --- a/Makefile.am +++ b/Makefile.am @@ -5,11 +5,16 @@ EXTRA_DIST = \ autobuild.sh \ autogen.sh -rpm: clean gen-ChangeLog +rpm: clean @(unset CDPATH ; $(MAKE) dist && rpmbuild -ta $(distdir).tar.gz) gen-ChangeLog: if [ -d .git ]; then \ - git log --oneline | sed 's/[0-9a-f]* $.*$/\1/' > ChangeLog; \ + git log --oneline | sed 's/[0-9a-f]* $.*$/\1/' > $(distdir)/ChangeLog; \ + else \ + echo "Prevent non-empty ChangeLog" > $(distdir)/ChangeLog ;\ fi +.PHONY: gen-ChangeLog + +dist-hook: gen-ChangeLog diff --git a/libvirt-snmp.spec.in b/libvirt-snmp.spec.in index ed93e75..0591aa3 100644 --- a/libvirt-snmp.spec.in +++ b/libvirt-snmp.spec.in @@ -1,6 +1,6 @@ Name: libvirt-snmp Version: @VERSION@ -Release: 1%{?dist}%{?extra_release} +Release: 1%{?dist} Summary: SNMP functionality for libvirt Group: Development/Libraries @@ -9,8 +9,7 @@ URL: http://libvirt.org Source0: http://www.libvirt.org/sources/snmp/libvirt-snmp-%{version}.tar.gz BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) -BuildRequires: net-snmp-perl net-snmp net-snmp-utils net-snmp-devel libvirt-devel -Requires: net-snmp +BuildRequires: net-snmp-perl net-snmp net-snmp-utils net-snmp-devel libvirt-devel %description Provides a way to control libvirt through SNMP protocol. @@ -25,23 +24,18 @@ make %{?_smp_mflags} %install -rm -rf $RPM_BUILD_ROOT make install DESTDIR=$RPM_BUILD_ROOT -%clean -rm -rf $RPM_BUILD_ROOT - - %files %defattr(-,root,root,-) %{_bindir}/libvirtMib_subagent %{_datadir}/snmp/mibs/LIBVIRT-MIB.txt -%doc README NEWS ChangeLog AUTHORS +%doc README NEWS ChangeLog AUTHORS src/LIBVIRT-MIB.txt %{_mandir}/man1/libvirtMib_subagent.1* %changelog -* Thu Feb 2 2011 Michal Privoznik <mprivozn(a)redhat.com> 0.0.1-1%{?dist}%{?extra_release} +* Thu Feb 2 2011 Michal Privoznik <mprivozn(a)redhat.com> 0.0.1-1%{?dist} - initial revision -- 1.7.4

2 1

[libvirt] [PATCH 5/6] Provide an internal function to dump the log buffer
by Daniel Veillard 03 Mar '11

03 Mar '11

An old virLogDump() function was left in the logging code but commented out, this resurrects it, fixes the callback function used and the internal code * src/util/logging.c src/util/logging.h: provide and expose virLogDump() * src/libvirt_private.syms: exports it as a private symbol Signed-off-by: Daniel Veillard <veillard(a)redhat.com> --- src/libvirt_private.syms | 1 + src/util/logging.c | 64 ++++++++++++++++++++++++--------------------- src/util/logging.h | 12 ++++++++ 3 files changed, 47 insertions(+), 30 deletions(-)

2 1

[libvirt] [PATCH 4/6] Fix a counter bug in the log buffer
by Daniel Veillard 03 Mar '11

03 Mar '11

* src/util/logging.c: the start pointer need to wrap around too Signed-off-by: Daniel Veillard <veillard(a)redhat.com> --- src/util/logging.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)

2 1

[libvirt] [PATCH 3/6] Add logrotate support for libvirtd.log
by Daniel Veillard 03 Mar '11

03 Mar '11

As the file may grow quite a bit especially with debug turned on. * daemon/libvirtd.logrotate.in daemon/Makefile.am libvirt.spec.in: add new logrotate file for the daemon log Signed-off-by: Daniel Veillard <veillard(a)redhat.com> --- daemon/Makefile.am | 10 +++++++++- daemon/libvirtd.logrotate.in | 9 +++++++++ libvirt.spec.in | 1 + 3 files changed, 19 insertions(+), 1 deletions(-) create mode 100644 daemon/libvirtd.logrotate.in

2 1

[libvirt] [PATCH 1/6] Force all logs to go to the round robbin memory buffer
by Daniel Veillard 03 Mar '11

03 Mar '11

Initially only the log actually written out by libvirt were saved on the memory buffer, this patch forces all informations including info and debug to be saved in memory too. This is useful to get full data in case of crash. Signed-off-by: Daniel Veillard <veillard(a)redhat.com> --- src/util/logging.c | 16 ++++++++++------ 1 files changed, 10 insertions(+), 6 deletions(-)

2 1