- Devel - libvirt List Archives

[libvirt] [PATCH] OpenVZ driver: fix openvzGetVPSUUID()
by Jean-Baptiste Rouault 27 May '11

27 May '11

openvzGetUUID did not work since openvz_readline() was replaced by getline() --- src/openvz/openvz_conf.c | 13 ++----------- 1 files changed, 2 insertions(+), 11 deletions(-) diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index 2cccd81..7b939b2 100644 --- a/src/openvz/openvz_conf.c +++ b/src/openvz/openvz_conf.c @@ -863,7 +863,6 @@ openvzGetVPSUUID(int vpsid, char *uuidstr, size_t len) char *conf_file; char *line = NULL; size_t line_size = 0; - ssize_t ret; char *saveptr = NULL; char *uuidbuf; char *iden; @@ -877,16 +876,8 @@ openvzGetVPSUUID(int vpsid, char *uuidstr, size_t len) if (fp == NULL) goto cleanup; - while (1) { - ret = getline(&line, &line_size, fp); - if (ret == -1) - goto cleanup; - - if (ret == 0) { /* EoF, UUID was not found */ - uuidstr[0] = 0; - break; - } - + uuidstr[0] = 0; + while (getline(&line, &line_size, fp) >= 0) { iden = strtok_r(line, " ", &saveptr); uuidbuf = strtok_r(NULL, "\n", &saveptr); -- 1.7.1

3 6

[libvirt] [PATCH 0/6] Add virNodeGetMemoryStats() API
by Minoru Usui 27 May '11

27 May '11

Hi, everyone. I wrote new API called virNodeGetMemoryStats(). It returns total/free/buffer/cached memory of the node from /proc/meminfo. The user I/F is like virNodeGetCPUStats(). Previous discussion is here. (See about virNodeGetFreeMemory() part.) http://www.mail-archive.com/libvir-list@redhat.com/msg32553.html This patch series based on latest git tree. If my virNodeGetCPUStats() patch series applied, I'll rebase on it. Minoru Usui (6): virNodeGetMemoryStats: Expose new API virNodeGetMemoryStats: Define internal driver API virNodeGetMemoryStats: Implement public API virNodeGetMemoryStats: Implement remote protocol virNodeGetMemoryStats: Implement virsh support virNodeGetMemoryStats: Implement linux support daemon/remote.c | 76 +++++++++++++++++++++++++++++++++ include/libvirt/libvirt.h.in | 65 +++++++++++++++++++++++++++- src/driver.h | 8 +++ src/libvirt.c | 81 +++++++++++++++++++++++++++++++++++ src/libvirt_private.syms | 1 + src/libvirt_public.syms | 1 + src/lxc/lxc_driver.c | 1 + src/nodeinfo.c | 97 ++++++++++++++++++++++++++++++++++++++++++ src/nodeinfo.h | 4 ++ src/qemu/qemu_driver.c | 1 + src/remote/remote_driver.c | 63 +++++++++++++++++++++++++++ src/remote/remote_protocol.x | 21 +++++++++- src/uml/uml_driver.c | 1 + tools/virsh.c | 51 ++++++++++++++++++++++ tools/virsh.pod | 4 ++ 15 files changed, 473 insertions(+), 2 deletions(-) -- Minoru Usui <usui(a)mxm.nes.nec.co.jp>

2 7

[libvirt] [PATCH] sexpr: Improve serialization error reporting
by Matthias Bolte 27 May '11

27 May '11

--- src/util/sexpr.c | 12 +++++------- 1 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/util/sexpr.c b/src/util/sexpr.c index d8d4c2d..0e30087 100644 --- a/src/util/sexpr.c +++ b/src/util/sexpr.c @@ -215,7 +215,7 @@ sexpr2string(const struct sexpr *sexpr, virBufferPtr buffer) virBufferAddChar(buffer, '('); if (sexpr2string(sexpr->u.s.car, buffer) < 0) - goto error; + return -1; while (sexpr->u.s.cdr->kind != SEXPR_NIL) { sexpr = sexpr->u.s.cdr; @@ -223,7 +223,7 @@ sexpr2string(const struct sexpr *sexpr, virBufferPtr buffer) virBufferAddChar(buffer, ' '); if (sexpr2string(sexpr->u.s.car, buffer) < 0) - goto error; + return -1; } virBufferAddChar(buffer, ')'); @@ -241,14 +241,12 @@ sexpr2string(const struct sexpr *sexpr, virBufferPtr buffer) virBufferAddLit(buffer, "()"); break; default: - goto error; + virSexprError(VIR_ERR_SEXPR_SERIAL, + _("unknown s-expression kind %d"), sexpr->kind); + return -1; } return 0; - - error: - virSexprError(VIR_ERR_SEXPR_SERIAL, NULL); - return -1; } #define IS_SPACE(c) ((c == 0x20) || (c == 0x9) || (c == 0xD) || (c == 0xA)) -- 1.7.0.4

2 2

[libvirt] [PATCH] Ensure hvsupport.html.in is built before HTML validation
by Daniel P. Berrange 27 May '11

27 May '11

In a parallel make, HTML validation tries to run before hvsupport.html.in has been built. * docs/Makefile.am: List hvsupport.html.in as a built source --- docs/Makefile.am | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index 59ae685..2b6ccf7 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -8,6 +8,8 @@ DOC_SOURCE_DIR=../src DEVHELP_DIR=$(datadir)/gtk-doc/html/libvirt +BUILT_SOURCES=hvsupport.html.in + apihtml = \ html/index.html \ html/libvirt-libvirt.html \ -- 1.7.4.4

3 2

[libvirt] FYI: qemu silently clipping large integers in JSON protocol
by Richard W.M. Jones 27 May '11

27 May '11

This thread may be of interest: http://lists.gnu.org/archive/html/qemu-devel/2011-05/threads.html#02162 Currently, qemu silently clips any JSON integer in the range 0x8000_0000_0000_0000 - 0xffff_ffff_ffff_ffff (all numbers in this range will be clipped to 0x7fff_ffff_ffff_ffff == LLONG_MAX). This basically could affect any libvirt code in this file which uses the "U:..." prefix as far as I can tell: http://libvirt.org/git/?p=libvirt.git;a=blob;f=src/qemu/qemu_monitor_json.c… Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v

2 1

[libvirt] Fwd: Re: ports/157024: [new port] devel/libvirt: Toolkit to interact with virtualization capabilities
by Jason Helfman 27 May '11

27 May '11

Port was committed to the FreeBSD portstree! Many thanks, Jason -- Jason Helfman System Administrator experts-exchange.com http://www.experts-exchange.com/M_4830110.html E4AD 7CF1 1396 27F6 79DD 4342 5E92 AD66 8C8C FBA5

2 1

[libvirt] [PATCH 00/10 v4] Integration of lock managers in QEMU
by Daniel P. Berrange 27 May '11

27 May '11

An update to http://www.redhat.com/archives/libvir-list/2011-May/msg00622.html New in this series: - Split the QEMU lock manager integration into 3 patches for easier review - Actually implemented the lease hotplug/unplug code fully - Fixes from previous review of patches 1+2 - Fix QEMU startup to not rely on uninitialized variable !

3 26

[libvirt] [PATCH 0/3] Allow extra URI and target VM XML when migrating
by Daniel P. Berrange 27 May '11

27 May '11

This series takes advantage of the fact that we've not yet released the v3 migration protocol, to add support for some extra migration parameters.

2 4

[libvirt] [PATCH] Fix build with --with-driver-modules enabled
by Matthias Bolte 27 May '11

27 May '11

Export a bunch of missing symbols and link the remote driver to gnulib. --- src/Makefile.am | 8 +++++++- src/libvirt_private.syms | 3 +++ src/libvirt_xenxs.syms | 21 +++++++++++++++++++++ 3 files changed, 31 insertions(+), 1 deletions(-) create mode 100644 src/libvirt_xenxs.syms diff --git a/src/Makefile.am b/src/Makefile.am index c3d3102..02d53ee 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -553,6 +553,7 @@ libvirt_driver_remote_la_CFLAGS = \ libvirt_driver_remote_la_LDFLAGS = $(AM_LDFLAGS) libvirt_driver_remote_la_LIBADD = $(GNUTLS_LIBS) $(SASL_LIBS) if WITH_DRIVER_MODULES +libvirt_driver_remote_la_LIBADD += ../gnulib/lib/libgnu.la libvirt_driver_remote_la_LDFLAGS += -module -avoid-version endif libvirt_driver_remote_la_SOURCES = $(REMOTE_DRIVER_SOURCES) @@ -1077,6 +1078,10 @@ if WITH_VMX USED_SYM_FILES += libvirt_vmx.syms endif +if WITH_XENXS +USED_SYM_FILES += libvirt_xenxs.syms +endif + EXTRA_DIST += \ libvirt_public.syms \ libvirt_private.syms \ @@ -1086,7 +1091,8 @@ EXTRA_DIST += \ libvirt_macvtap.syms \ libvirt_daemon.syms \ libvirt_nwfilter.syms \ - libvirt_vmx.syms + libvirt_vmx.syms \ + libvirt_xenxs.syms BUILT_SOURCES += libvirt.syms libvirt.def libvirt_qemu.def diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 4cb8dda..2088f38 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -929,6 +929,7 @@ virEventRemoveHandle; virExec; virExecWithHook; virFileAbsPath; +virFileBuildPath; virFileDeletePid; virFileExists; virFileFindMountPoint; @@ -1017,6 +1018,8 @@ virStrerror; # xml.h +virXMLParseFileHelper; +virXMLParseHelper; virXMLParseStrHelper; virXMLPropString; virXPathBoolean; diff --git a/src/libvirt_xenxs.syms b/src/libvirt_xenxs.syms new file mode 100644 index 0000000..3d794d6 --- /dev/null +++ b/src/libvirt_xenxs.syms @@ -0,0 +1,21 @@ +# +# These symbols are dependent upon --with-xen via WITH_XEN or --with-libxl via WITH_LIBXL. +# + +# xen_sxpr.h +xenFormatSxpr; +xenFormatSxprChr; +xenFormatSxprDisk; +xenFormatSxprNet; +xenFormatSxprOnePCI; +xenFormatSxprSound; +xenGetDomIdFromSxpr; +xenGetDomIdFromSxprString; +xenParseSxpr; +xenParseSxprChar; +xenParseSxprSound; +xenParseSxprString; + +# xen_xm.h +xenFormatXM; +xenParseXM; -- 1.7.0.4

2 2

[libvirt] virsh list didn't show anything
by YAO 27 May '11

27 May '11

Hi, I tried to connect xen using latest libvirt When I connected to xend, "virsh list --all" gave me the right output. But when I connected to libxl, the virsh didn't show anything only as follows Id Name State ---------------------------------- I think at least Domain-0 should show up. Did I miss some point or something broken with the libxl_driver?

1 0