- Devel - libvirt List Archives

[libvirt] [PATCH] Fix reporting of cert validation failures
by Daniel P. Berrange 15 Jul '11

15 Jul '11

If the server succesfully validates the client cert, it will send back a single byte, under TLS. If it fails, it will close the connection. In this case, we were just reporting the standard I/O error. The original RPC code had a special case hack for the GNUTLS_E_UNEXPECTED_PACKET_LENGTH error code to make us report a more useful error message * src/rpc/virnetclient.c: Return ENOMSG if we get GNUTLS_E_UNEXPECTED_PACKET_LENGTH * src/rpc/virnettlscontext.c: Report cert failure if we see ENOMSG --- src/rpc/virnetclient.c | 2 +- src/rpc/virnettlscontext.c | 3 +++ 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c index b9f0fc8..d3965c6 100644 --- a/src/rpc/virnetclient.c +++ b/src/rpc/virnetclient.c @@ -348,7 +348,7 @@ int virNetClientSetTLSSession(virNetClientPtr client, ignore_value(pthread_sigmask(SIG_BLOCK, &oldmask, NULL)); len = virNetTLSSessionRead(client->tls, buf, 1); - if (len < 0) { + if (len < 0 && errno != ENOMSG) { virReportSystemError(errno, "%s", _("Unable to read TLS confirmation")); goto error; diff --git a/src/rpc/virnettlscontext.c b/src/rpc/virnettlscontext.c index b778550..4963ab7 100644 --- a/src/rpc/virnettlscontext.c +++ b/src/rpc/virnettlscontext.c @@ -932,6 +932,9 @@ ssize_t virNetTLSSessionWrite(virNetTLSSessionPtr sess, case GNUTLS_E_INTERRUPTED: errno = EINTR; break; + case GNUTLS_E_UNEXPECTED_PACKET_LENGTH: + errno = ENOMSG; + break; default: errno = EIO; break; -- 1.7.4.4

2 1

[libvirt] [PATCH] Unregister event callback if a fatal error occurs during dispatch
by Daniel P. Berrange 15 Jul '11

15 Jul '11

If we get an I/O error in the async event callback for an RPC client, we might not have consumed all pending data off the wire. This could result in the callback being immediately invoked again. At which point the same I/O might occur. And we're invoked again. And again...And again... Unregistering the async event callback if an error occurs is a good safety net. The real error will be seen when the next RPC method is invoked * src/rpc/virnetclient.c: Unregister event callback on error --- src/rpc/virnetclient.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c index 9fb8fd4..58d4274 100644 --- a/src/rpc/virnetclient.c +++ b/src/rpc/virnetclient.c @@ -1124,8 +1124,10 @@ void virNetClientIncomingEvent(virNetSocketPtr sock, goto done; } - if (virNetClientIOHandleInput(client) < 0) - VIR_DEBUG("Something went wrong during async message processing"); + if (virNetClientIOHandleInput(client) < 0) { + VIR_WARN("Something went wrong during async message processing"); + virNetSocketRemoveIOCallback(sock); + } done: virNetClientUnlock(client); -- 1.7.4.4

2 1

[libvirt] [PATCH] Fix error message for missing TLS write function
by Daniel P. Berrange 15 Jul '11

15 Jul '11

* src/rpc/virnettlscontext.c: s/read/write/ --- src/rpc/virnettlscontext.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/rpc/virnettlscontext.c b/src/rpc/virnettlscontext.c index 4963ab7..6a06565 100644 --- a/src/rpc/virnettlscontext.c +++ b/src/rpc/virnettlscontext.c @@ -803,7 +803,7 @@ virNetTLSSessionPush(void *opaque, const void *buf, size_t len) { virNetTLSSessionPtr sess = opaque; if (!sess->writeFunc) { - VIR_WARN("TLS session push with missing read function"); + VIR_WARN("TLS session push with missing write function"); errno = EIO; return -1; }; -- 1.7.4.4

2 1

[libvirt] ANNOUNCE: libvirt Perl bindings Sys::Virt 0.9.3 release
by Daniel P. Berrange 15 Jul '11

15 Jul '11

I am happy to announce a new release[1] of the libvirt Perl bindings, Sys::Virt 0.9.3 is available for download: http://search.cpan.org/CPAN/authors/id/D/DA/DANBERR/Sys-Virt-0.9.3.tar.gz Changes in this release - Add all new APIs in libvirt 0.9.3 - Requires libvirt >= 0.9.3 The permanent link for the Sys::Virt package, where all historic releases can be found, is http://search.cpan.org/dist/Sys-Virt/ Thanks to everyone who contributed to this release through testing, bug reporting, patch submission, etc. I am now caught up to main libvirt releases and intended to track each new release more promptly in the future. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

1 0

[libvirt] [PATCH] util: fix a typo error on virStrncpy
by ajia＠redhat.com 15 Jul '11

15 Jul '11

* src/util/util.c: fix a typo error on virStrncpy. --- src/util/util.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/util/util.c b/src/util/util.c index 0ca81df..1080823 100644 --- a/src/util/util.c +++ b/src/util/util.c @@ -1754,7 +1754,7 @@ virStrncpy(char *dest, const char *src, size_t n, size_t destbytes) return NULL; ret = strncpy(dest, src, n); - /* strncpy NULL terminates iff the last character is \0. Therefore + /* strncpy NULL terminates if the last character is \0. Therefore * force the last byte to be \0 */ dest[n] = '\0'; -- 1.7.1

3 2

[libvirt] EMOTIVE Cloud based in Libvirt
by Alex Vaqué Brull 15 Jul '11

15 Jul '11

Hi, We can link in http://libvirt.org/apps.html EMOTIVE Cloud ( www.emotivecloud.net ) ? It is an interesting middleware based in Libvirt. Thank you

2 8

[libvirt] [PATCH] build: fix VPATH build of todo
by Eric Blake 15 Jul '11

15 Jul '11

Without this patch, the make rule in a VPATH build was trying to invoke ../../docs/../../docs/todo.pl, which didn't exist. * docs/Makefile.am (todo.html.in): Using $< already implies $(srcdir) in GNU make VPATH situations. --- Pushing under the trivial rule. docs/Makefile.am | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index 050ebe1..7ff94a0 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -104,7 +104,7 @@ web: $(dot_html) html/index.html devhelp/index.html todo.html.in: todo.pl if [ -f todo.cfg ]; then \ echo "Generating $@"; \ - $(PERL) $(srcdir)/$< > $@ \ + $(PERL) $< > $@ \ || { rm $@ && exit 1; }; \ else \ echo "Stubbing $@"; \ -- 1.7.4.4

2 1

[libvirt] [PATCH RFC V2 00/10] support cpu bandwidth in libvirt
by Wen Congyang 15 Jul '11

15 Jul '11

TODO: 1. We create sub directory for each vcpu in cpu subsystem. So we should recalculate cpu.shares for each vcpu. Changelog: v2: almost rewrite the patchset to support to control each vcpu's bandwidth. Limit quota to [-1, 2^64/1000] at the schemas level. We will check it at cgroup level. Wen Congyang (10): Introduce the function virCgroupForVcpu cgroup: Implement cpu.cfs_period_us and cpu.cfs_quota_us tuning API Update XML Schema for new entries qemu: Implement period and quota tunable XML configuration and parsing. support to pass VIR_DOMAIN_AFFECT_CURRENT to virDomainGetVcpusFlags() vcpubandwidth: introduce two new libvirt APIs vcpubandwidth: implement the code to support new API for the qemu driver vcpubandwidth: implement the remote protocol to address the new API vcpubandwidth: Implement virsh support doc: Add documentation for new cputune elements period and quota daemon/remote.c | 132 +++++++ docs/formatdomain.html.in | 19 + docs/schemas/domain.rng | 29 ++- include/libvirt/libvirt.h.in | 41 +++- python/generator.py | 2 + src/conf/domain_conf.c | 272 ++++++++++++++- src/conf/domain_conf.h | 17 + src/driver.h | 14 + src/libvirt.c | 129 +++++++- src/libvirt_private.syms | 9 + src/libvirt_public.syms | 6 + src/qemu/qemu_cgroup.c | 131 +++++++ src/qemu/qemu_cgroup.h | 2 + src/qemu/qemu_driver.c | 429 ++++++++++++++++++++++- src/qemu/qemu_process.c | 4 + src/remote/remote_driver.c | 64 ++++ src/remote/remote_protocol.x | 32 ++- src/rpc/gendispatch.pl | 30 ++ src/util/cgroup.c | 153 ++++++++- src/util/cgroup.h | 11 + tests/qemuxml2argvdata/qemuxml2argv-cputune.xml | 2 + tools/virsh.c | 142 ++++++++- tools/virsh.pod | 16 + 23 files changed, 1658 insertions(+), 28 deletions(-)

5 32

[libvirt] [Patch 0/3]virsh: Patches for virsh logging
by Supriya Kannery 15 Jul '11

15 Jul '11

Virsh logging has some basic issues: 1. In code, magic numbers are used for logging rather than loglevel variables. 2. Magic number "5" is used for logging which doesn't map to any loglevel variable. Valid loglevel range is 0-4 3. Usage of loglevel variables doesn't align with that of libvirt logging. In libvirt "DEBUG" loglevel is the superset and logs messages at all other levels. Whereas in virsh, "ERROR" loglevel behaves this way, which needs correction 4. virsh man page and code are inconsistent with respect to loglevels Following patchset is to address the above mentioned issues. 1/3 - Avoid using magic numbers for logging 2/3 - Align log level usage to that of libvirt 3/3 - Update virsh manpage with related changes tools/virsh.pod | 30 ++++++++++++ tools/virsh.c | 124 +++++++++++++++++++++++++++--------------------- 2 files changed, 102 insertions(+), 52 deletions(-)

4 12

[libvirt] [PATCHv2 00/27] flags cleanup
by Eric Blake 15 Jul '11

15 Jul '11

Addressing my review comments from round 1, and introducing a few more goodies along the way. I've added some syntax checks to make it easier to stick with this style in the future. v1 was at https://www.redhat.com/archives/libvir-list/2011-July/msg00264.html, with patches 1-5 already applied, and patches 6-20 of that series revamped in this series as 5-19. Patches 1-4 and 20-27 in this series are new. Eric Blake (27): maint: exclude more files from syntax check maint: print flags in hex during debug build: also check qemu_protocol for on-the-wire stability libvirt-qemu: use unsigned flags util: reject unknown flags, and prefer unsigned flags node_device: reject unknown flags storage: reject unknown flags esx: reject unknown flags libxl: reject unknown flags lxc: reject unknown flags openvz: reject unknown flags phyp: reject unknown flags qemu: reject unknown flags test: reject unknown flags uml: reject unknown flags vbox: reject unknown flags vmware: reject unknown flags xen: reject unknown flags xenapi: reject unknown flags virsh, daemon: prefer unsigned flags node_device: avoid implicit int python: prefer unsigned flags conf: prefer unsigned flags build: don't hand-roll cloexec code conf: delete unused flags arguments remote: prefer unsigned flags build: add syntax check for proper flags use cfg.mk | 49 +++++++++--- daemon/remote.c | 2 +- python/libvirt-override.c | 6 +- src/Makefile.am | 20 +++-- src/conf/cpu_conf.c | 6 +- src/conf/cpu_conf.h | 6 +- src/conf/domain_conf.c | 24 ++---- src/conf/node_device_conf.h | 58 +++++++------- src/conf/storage_conf.c | 4 +- src/datatypes.h | 4 +- src/esx/esx_device_monitor.c | 4 +- src/esx/esx_driver.c | 28 +++++-- src/esx/esx_interface_driver.c | 4 +- src/esx/esx_network_driver.c | 4 +- src/esx/esx_nwfilter_driver.c | 4 +- src/esx/esx_secret_driver.c | 4 +- src/esx/esx_storage_driver.c | 4 +- src/fdstream.c | 28 +++--- src/fdstream.h | 6 +- src/interface/netcf_driver.c | 16 +++- src/libvirt-qemu.c | 5 +- src/libxl/libxl_driver.c | 18 +++- src/locking/lock_driver_nop.c | 13 ++-- src/locking/lock_driver_sanlock.c | 3 +- src/locking/lock_manager.c | 18 +++-- src/lxc/lxc_container.c | 4 +- src/lxc/lxc_driver.c | 12 ++- src/network/bridge_driver.c | 9 ++- src/node_device/node_device_driver.c | 18 +++- src/node_device/node_device_hal.c | 4 +- src/node_device/node_device_udev.c | 4 +- src/nodeinfo.h | 6 +- src/nwfilter/nwfilter_driver.c | 4 +- src/openvz/openvz_driver.c | 9 ++- src/phyp/phyp_driver.c | 12 ++- src/qemu/qemu_domain.c | 21 +++--- src/qemu/qemu_domain.h | 4 +- src/qemu/qemu_driver.c | 30 +++++-- src/qemu/qemu_migration.c | 32 ++++---- src/qemu/qemu_monitor.c | 10 +- src/qemu_protocol-structs | 14 +++ src/remote/qemu_protocol.x | 4 +- src/remote/remote_driver.c | 6 +- src/rpc/virnetserverclient.c | 2 +- src/secret/secret_driver.c | 17 +++- src/storage/storage_backend.c | 12 ++- src/storage/storage_backend_disk.c | 10 ++- src/storage/storage_backend_fs.c | 26 +++++-- src/storage/storage_backend_iscsi.c | 4 +- src/storage/storage_backend_logical.c | 18 +++- src/storage/storage_driver.c | 45 ++++++++-- src/test/test_driver.c | 144 +++++++++++++++++++++++++------- src/uml/uml_driver.c | 33 +++----- src/util/bridge.c | 19 +--- src/util/command.c | 18 ++-- src/util/iohelper.c | 18 ++-- src/util/logging.c | 13 +++- src/util/logging.h | 8 +- src/util/util.c | 14 ++-- src/vbox/vbox_driver.c | 5 +- src/vbox/vbox_tmpl.c | 44 ++++++++-- src/vmware/vmware_driver.c | 17 +++- src/xen/xen_driver.c | 12 ++- src/xen/xen_hypervisor.c | 8 ++- src/xen/xen_inotify.c | 4 +- src/xen/xend_internal.c | 23 ++++-- src/xen/xend_internal.h | 3 +- src/xen/xm_internal.c | 11 ++- src/xen/xm_internal.h | 2 +- src/xen/xs_internal.c | 12 ++- src/xenapi/xenapi_driver.c | 13 +++- tools/virsh.c | 2 +- 72 files changed, 731 insertions(+), 367 deletions(-) create mode 100644 src/qemu_protocol-structs -- 1.7.4.4

3 76