- Devel - libvirt List Archives

[libvirt] [PATCH] util: avoid null deref on qcowXGetBackingStore
by ajia＠redhat.com 30 Nov '11

30 Nov '11

From: Alex Jia <ajia(a)redhat.com> Detected by Coverity. the only case is caller passes a NULL to 'format' variable, then taking 'if (format)' false branch, the function qcow2GetBackingStoreFormat will directly dereferences the NULL 'format' pointer variable. Signed-off-by: Alex Jia <ajia(a)redhat.com> --- src/util/storage_file.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/util/storage_file.c b/src/util/storage_file.c index f33ea74..ba9cfc5 100644 --- a/src/util/storage_file.c +++ b/src/util/storage_file.c @@ -333,7 +333,7 @@ qcowXGetBackingStore(char **res, * between the end of the header (QCOW2_HDR_TOTAL_SIZE) * and the start of the backingStoreName (offset) */ - if (isQCow2) + if (isQCow2 && format) qcow2GetBackingStoreFormat(format, buf, buf_size, QCOW2_HDR_TOTAL_SIZE, offset); return BACKING_STORE_OK; -- 1.7.1

2 1

[libvirt] [PATCH 00/14] Cleanup node suspend code
by Daniel P. Berrange 30 Nov '11

30 Nov '11

This patch series does a large number of pretty small / trivial cleanups of the recently committed node suspend code. There are a few important changes though - Patch 1 changes public API enum values - Patch 3 changes the capabilities XML schema - Patch 11 ensures we don't probe suspend info unles we need it - Patch 14 fixes a bug Obviously due to 1 & 3 we need to do this before the next release

4 44

[libvirt] [libvirt-glib] gir: use libraries from build tree, not installed ones
by Christophe Fergeau 30 Nov '11

30 Nov '11

If we don't explicitly mention path to our uninstalled libraries to g-ir-scanner, it will use installed libvirt-* libraries instead of the ones we just built to run a binary during the generation of the gir file. However this binary will have been compiled with the uninstalled ones, This is an issue if the installed libraries are not ABI compatible with the uninstalled one, and will cause a compile failure because the binary will fail to run. This fix has been suggested by Colin Walters (gobject-introspection maintainer). --- libvirt-gobject/Makefile.am | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/libvirt-gobject/Makefile.am b/libvirt-gobject/Makefile.am index 1e0f851..c4405f0 100644 --- a/libvirt-gobject/Makefile.am +++ b/libvirt-gobject/Makefile.am @@ -130,6 +130,8 @@ LibvirtGObject-1.0.gir: libvirt-gobject-1.0.la $(G_IR_SCANNER) Makefile.am --include-uninstalled $(top_builddir)/libvirt-gconfig/LibvirtGConfig-1.0.gir \ --identifier-prefix=GVir \ --symbol-prefix=gvir \ + --library=$(top_builddir)/libvirt-glib/libvirt-glib-1.0.la \ + --library=$(top_builddir)/libvirt-gconfig/libvirt-gconfig-1.0.la \ --library=$(builddir)/libvirt-gobject-1.0.la \ --output $@ \ -I$(top_builddir) \ -- 1.7.7.3

2 1

[libvirt] [PATCH 0/3 v2] Improve async signal safety of timestamp APIs
by Daniel P. Berrange 30 Nov '11

30 Nov '11

An update of https://www.redhat.com/archives/libvir-list/2011-November/msg01609.html In v2: - Rename all APIs which return with errno set to have a Raw postfix ( async signal safe) - Add variants of all APIs which raise errors (async signal dangerous)

2 6

[libvirt] [PATCH] virsh: Update docs for block related commands
by Osier Yang 30 Nov '11

30 Nov '11

commit 3ac26e26 allows to lookup the disk via both target name and source path. But virsh documents were not updated. --- tools/virsh.c | 15 ++++++++++----- tools/virsh.pod | 14 +++++++++----- 2 files changed, 19 insertions(+), 10 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 27ecaf3..94b5478 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -1059,7 +1059,8 @@ static const vshCmdInfo info_domblkstat[] = { static const vshCmdOptDef opts_domblkstat[] = { {"domain", VSH_OT_DATA, VSH_OFLAG_REQ, N_("domain name, id or uuid")}, - {"device", VSH_OT_DATA, VSH_OFLAG_REQ, N_("block device")}, + {"device", VSH_OT_DATA, VSH_OFLAG_REQ, N_("Fully-qualified source path or unique " + "target name of the block device")}, {"human", VSH_OT_BOOL, 0, N_("print a more human readable output")}, {NULL, 0, 0, NULL} }; @@ -1637,7 +1638,8 @@ static const vshCmdInfo info_domblkinfo[] = { static const vshCmdOptDef opts_domblkinfo[] = { {"domain", VSH_OT_DATA, VSH_OFLAG_REQ, N_("domain name, id or uuid")}, - {"device", VSH_OT_DATA, VSH_OFLAG_REQ, N_("block device")}, + {"device", VSH_OT_DATA, VSH_OFLAG_REQ, N_("Fully-qualified source path or unique target" + "name of the block device")}, {NULL, 0, 0, NULL} }; @@ -5959,7 +5961,8 @@ static const vshCmdInfo info_block_pull[] = { static const vshCmdOptDef opts_block_pull[] = { {"domain", VSH_OT_DATA, VSH_OFLAG_REQ, N_("domain name, id or uuid")}, - {"path", VSH_OT_DATA, VSH_OFLAG_REQ, N_("Fully-qualified path of disk")}, + {"path", VSH_OT_DATA, VSH_OFLAG_REQ, N_("Fully-qualified source path or unique " + "target name of the disk")}, {"bandwidth", VSH_OT_DATA, VSH_OFLAG_NONE, N_("Bandwidth limit in MB/s")}, {NULL, 0, 0, NULL} }; @@ -5983,7 +5986,8 @@ static const vshCmdInfo info_block_job[] = { static const vshCmdOptDef opts_block_job[] = { {"domain", VSH_OT_DATA, VSH_OFLAG_REQ, N_("domain name, id or uuid")}, - {"path", VSH_OT_DATA, VSH_OFLAG_REQ, N_("Fully-qualified path of disk")}, + {"path", VSH_OT_DATA, VSH_OFLAG_REQ, N_("Fully-qualified source path or unique" + "target name of the disk")}, {"abort", VSH_OT_BOOL, VSH_OFLAG_NONE, N_("Abort the active job on the speficied disk")}, {"info", VSH_OT_BOOL, VSH_OFLAG_NONE, N_("Get active job information for the specified disk")}, {"bandwidth", VSH_OT_DATA, VSH_OFLAG_NONE, N_("Set the Bandwidth limit in MB/s")}, @@ -6039,7 +6043,8 @@ static const vshCmdInfo info_block_resize[] = { static const vshCmdOptDef opts_block_resize[] = { {"domain", VSH_OT_DATA, VSH_OFLAG_REQ, N_("domain name, id or uuid")}, - {"path", VSH_OT_DATA, VSH_OFLAG_REQ, N_("Fully-qualified path of block device")}, + {"path", VSH_OT_DATA, VSH_OFLAG_REQ, N_("Fully-qualified source path or unique " + "target name of the block device")}, {"size", VSH_OT_INT, VSH_OFLAG_REQ, N_("New size of the block device in kilobytes, " "the size must be integer")}, {NULL, 0, 0, NULL} diff --git a/tools/virsh.pod b/tools/virsh.pod index a5758f4..61951e6 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -569,14 +569,16 @@ image has been pulled, the disk no longer depends on the backing image. It pulls data for the entire disk in the background, the process of the operation can be checked with B<blockjob>. -I<path> specifies fully-qualified path of the disk. +I<path> specifies fully-qualified source path (<source file='name'/>) or +unique target name (<target dev='name'/>) of the disk. I<bandwidth> specifies copying bandwidth limit in Mbps. =item B<blockjob> I<domain> I<path> [I<--abort>] [I<--info>] [I<bandwidth>] Manage active block operations. -I<path> specifies fully-qualified path of the disk. +I<path> specifies fully-qualified source path (<source file='name'/>) or +unique target name (<target dev='name'/>) of the disk. If I<--abort> is specified, the active job on the specified disk will be aborted. If I<--info> is specified, the active job information on the specified @@ -585,9 +587,11 @@ I<bandwidth> can be used to set bandwidth limit for the active job. =item B<blockresize> I<domain> I<--path> I<--size> -Resize a block device of domain while the domain is running, I<--path> -specifies the absolute path of the block device, I<--size> specifies the -new size in kilobytes +Resize a block device of domain while the domain is running. + +I<path> specifies fully-qualified source path (<source file='name'/>) or +unique target name (<target dev='name'/>) of the disk. +I<--size> specifies the new size in kilobytes. =item B<dominfo> I<domain-id> -- 1.7.7.3

2 1

[libvirt] gdb works abnormally when debug the libvirt.
by ShaoHe Feng 30 Nov '11

30 Nov '11

When I to use gdb to check whether qemuMonitorJSONIOProcessEvent processes the Event that I expect. but the gdb works abnormally. I list the the position of the source file by gdb. It is the correct functionqemuMonitorJSONIOProcessEvent. However I set break point on this position. then "info b", it is the wrong function qemuMonitorJSONIOProcess. I debug my libvirt on Ubuntu 11.10 this time.But I have set a break point at this function on redhat 6.0 before, it can work well. My gcc version is: gcc (Ubuntu/Linaro 4.6.1-9ubuntu3) 4.6.1 My gdb version is: GNU gdb (Ubuntu/Linaro 7.3-0ubuntu2) 7.3-2011.08 here is the info: (gdb) list qemu/qemu_monitor_json.c:88 83 qemuMonitorJSONIOProcessEvent(qemuMonitorPtr mon, 84 virJSONValuePtr obj) 85 { 86 const char *type; 87 int i; 88 int findEventFlag = -1; 89 VIR_DEBUG("mon=%p obj=%p", mon, obj); 90 91 type = virJSONValueObjectGetString(obj, "event"); 92 if (!type) { (gdb) b qemu/qemu_monitor_json.c:88 Breakpoint 5 at 0x4a18d4: file qemu/qemu_monitor_json.c, line 88. (gdb) info b Num Type Disp Enb Address What 5 breakpoint keep y 0x00000000004a18d4 in qemuMonitorJSONIOProcess at qemu/qemu_monitor_json.c:88 (gdb)

3 3

[libvirt] [PATCH] build: fix typo in last patch
by Eric Blake 29 Nov '11

29 Nov '11

* src/remote_protocol-structs: Use correct RPC name. --- Pushing under the build-breaker rule. Osier attempted to fix this already, but added a typo. src/remote_protocol-structs | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/remote_protocol-structs b/src/remote_protocol-structs index 62c0248..927b6c6 100644 --- a/src/remote_protocol-structs +++ b/src/remote_protocol-structs @@ -2019,5 +2019,5 @@ enum remote_procedure { REMOTE_PROC_DOMAIN_EVENT_DISK_CHANGE = 248, REMOTE_PROC_DOMAIN_OPEN_GRAPHICS = 249, REMOTE_PROC_NODE_SUSPEND_FOR_DURATION = 250, - REMOTE_PROC_NODE_SUSPEND_FOR_DURATION = 251, + REMOTE_PROC_DOMAIN_BLOCK_RESIZE = 251, }; -- 1.7.7.3

1 0

[libvirt] [PATCH] Fix leak build config file path
by Daniel P. Berrange 29 Nov '11

29 Nov '11

From: "Daniel P. Berrange" <berrange(a)redhat.com> * src/libvirt.c: Free user directory path --- src/libvirt.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index cdd111c..55ef743 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -974,8 +974,11 @@ virConnectConfigFile(void) goto error; if (virAsprintf(&path, "%s/.libvirt/libvirt.conf", - userdir) < 0) + userdir) < 0) { + VIR_FREE(userdir); goto no_memory; + } + VIR_FREE(userdir); } return path; -- 1.7.6.4

2 1

[libvirt] [PATCH 0/5] Interface pools and passthrough mode
by Shradha Shah 29 Nov '11

29 Nov '11

Interface Pools and Passthrough mode: Current Method: The passthrough mode uses a macvtap âdirectâ connection to connect each guest to the network. The physical interface to be used is picked from among those listed in <interface> sub elements of the <forward> element. The current specification for <forward> extends to allow 0 or more <interface> sub-elements: Example: <forward mode='passthrough' dev='eth10'/> <interface dev='eth10'/> <interface dev='eth12'/> <interface dev='eth18'/> <interface dev='eth20'/> </forward> However with an ethernet card with 64 VF's or more, the above method gets tedious on the system. On the other hand, just parameterizing a string (eth%d) is inadequate, eg, when there are multiple non-contiguous ranges. Proposed Method: The 5 patches provided along with this introductory e-mail i) Introduce a structure to store the state of all the virtual functions attached to each physical function ii) Find a free virtual function given the physical function. The forward specification will hence only mention the physical function as the interface sub element: Example: <forward mode='passthrough' dev='eth2'/> <interface dev='eth2'/> </forward> Shradha Shah (5): Moving the declaration of _pciDevice and _pciDeviceList to pci.h Added function pciSysfsFile to enable access to the PCI SYSFS files. Adding functions virNetDevGetVirtualFunctions and virNetDevGetNetName virNetDevGetVirtualFunctions: Gets the BDF of all the Virtual Functions given a physical function virNetDevGetNetName: Gets the interface name of the PCI Device. Addition of a new device structure to store the state of a Virtual Function Modifications to the Physical Device Structure to store state of its Virtual Functions If a system has 64 or more VF's, it is quite tedious to mention each VF in the interface pool. The following modification find a Free VF given a Physical Function when mode=passthrough. We also save the state of each VF. Hence modifications to networkAllocateActualDevice, networkNotifyActualDevice and networkReleaseActualDevice were required. The following patch does just that. src/conf/network_conf.c | 19 ++++- src/conf/network_conf.h | 10 ++ src/network/bridge_driver.c | 208 +++++++++++++++++++++++++++++++++++++------ src/util/pci.c | 52 ++++------- src/util/pci.h | 36 ++++++++ src/util/virnetdev.c | 89 ++++++++++++++++++ src/util/virnetdev.h | 10 ++ 7 files changed, 359 insertions(+), 65 deletions(-) -- 1.7.4.4

1 0

[libvirt] [libvirt-glib] gir: Use --pkg=libxml-2.0 instead of LIBXML2_CFLAGS
by Christophe Fergeau 29 Nov '11

29 Nov '11

g-ir-scanner has a standard way of getting the flags for libraries providing .pc files, this commit uses this --pkg flag for libxml instead of using LIBXML2_CFLAGS we computed ourselves. --- libvirt-gconfig/Makefile.am | 2 +- libvirt-gobject/Makefile.am | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libvirt-gconfig/Makefile.am b/libvirt-gconfig/Makefile.am index b14bd92..fe5b1a5 100644 --- a/libvirt-gconfig/Makefile.am +++ b/libvirt-gconfig/Makefile.am @@ -119,9 +119,9 @@ LibvirtGConfig-1.0.gir: libvirt-gconfig-1.0.la $(G_IR_SCANNER) Makefile.am --output $@ \ -I$(top_builddir) \ -I$(top_srcdir) \ - $(LIBXML2_CFLAGS) \ --verbose \ --c-include="libvirt-gconfig/libvirt-gconfig.h" \ + --pkg=libxml-2.0 \ --pkg-export=libvirt-gconfig-1.0 \ $(srcdir)/libvirt-gconfig.h \ $(GCONFIG_SOURCE_FILES:%=$(srcdir)/%) \ diff --git a/libvirt-gobject/Makefile.am b/libvirt-gobject/Makefile.am index 5aa1080..ad746bb 100644 --- a/libvirt-gobject/Makefile.am +++ b/libvirt-gobject/Makefile.am @@ -133,10 +133,10 @@ LibvirtGObject-1.0.gir: libvirt-gobject-1.0.la $(G_IR_SCANNER) Makefile.am --output $@ \ -I$(top_builddir) \ -I$(top_srcdir) \ - $(LIBXML2_CFLAGS) \ --verbose \ - --pkg=gthread-2.0 \ --c-include="libvirt-gobject/libvirt-gobject.h" \ + --pkg=gthread-2.0 \ + --pkg=libxml-2.0 \ --pkg-export=libvirt-gobject-1.0 \ $(srcdir)/libvirt-gobject.h \ $(GOBJECT_SOURCE_FILES:%=$(srcdir)/%) \ -- 1.7.7.3

2 1